On Fri, Jan 17, 2025 at 05:05:42PM +0100, Marek Szyprowski wrote:
> On 17.01.2025 15:30, Andy Shevchenko wrote:
> > On Fri, Jan 17, 2025 at 04:09:58PM +0200, Andy Shevchenko wrote:
> >> On Fri, Jan 17, 2025 at 02:57:52PM +0100, Marek Szyprowski wrote:
> >>> On 16.
On Fri, Jan 17, 2025 at 04:09:58PM +0200, Andy Shevchenko wrote:
> On Fri, Jan 17, 2025 at 02:57:52PM +0100, Marek Szyprowski wrote:
> > On 16.01.2025 13:42, Andy Shevchenko wrote:
> > > If the selector register is represented in each page, its value
> > > in accorda
On Fri, Jan 17, 2025 at 02:57:52PM +0100, Marek Szyprowski wrote:
> On 16.01.2025 13:42, Andy Shevchenko wrote:
> > If the selector register is represented in each page, its value
> > in accordance to the debugfs is stale because it gets synchronized
> > only after the rea
case one thinks of unprintable characters, %pE is for that.
--
With Best Regards,
Andy Shevchenko
_lcd_ops);
> - if (!IS_ERR(lcd))
> - return 0;
> + return 0;
>
> - ret = PTR_ERR(lcd);
> unregister_framebuffer(info);
Haven't you got a dead code warning here?
>
> out_fb_dealloc_cmap:
--
With Best Regards,
Andy Shevchenko
look at it as well.
> Anyway feel free to add Reviewed-by: Christian König
> .
Side note: I don't believe tools support embedded tags, so we usually give
a tag as one tag per one line without. Otherwise it adds a manual job to
harvest them and ensure no typos made during that.
--
With Best Regards,
Andy Shevchenko
ECOVERY_REBIND) etc.), or
> make this a array of structs mapping the macro values to strings and
> loop over it.
>
> Also, the main point of the static assert was to ensure the array is
> updated when a new recovery option is added, and there's no out of
> bounds acces
ary/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/include/
>secure/_stdio.h:47:56: note: expanded from macro 'sprintf' 47 |
>__builtin___sprintf_chk (str, 0, __darwin_obsz(str), __VA_ARGS__)
>|^~~
Please, shrink this to the valuable ~3-5 lines. No need to repeat the same for
each case!
--
With Best Regards,
Andy Shevchenko
On Tue, Oct 01, 2024 at 08:08:18AM +0300, Raag Jadav wrote:
> On Mon, Sep 30, 2024 at 03:59:59PM +0300, Andy Shevchenko wrote:
> > On Mon, Sep 30, 2024 at 01:08:41PM +0530, Raag Jadav wrote:
...
> > > +static const char *const drm_wedge_recovery_opts[] = {
> > > +
On Tue, Oct 01, 2024 at 05:18:33PM +0300, Raag Jadav wrote:
> On Tue, Oct 01, 2024 at 03:07:59PM +0300, Andy Shevchenko wrote:
> > On Tue, Oct 01, 2024 at 08:08:18AM +0300, Raag Jadav wrote:
> > > On Mon, Sep 30, 2024 at 03:59:59PM +0300, Andy Shevchenko wrote:
> > > &
VERY_REBIND;
> +
> + for_each_set_bit(method, &dev->wedge_recovery, DRM_WEDGE_RECOVERY_MAX)
> + count += sysfs_emit_at(buf, count, "%s\n",
> drm_wedge_recovery_name(method));
> +
> + return count;
> +}
--
With Best Regards,
Andy Shevchenko
_wedge_recovery method)
> +{
> + static_assert(ARRAY_SIZE(drm_wedge_recovery_opts) ==
> DRM_WEDGE_RECOVERY_MAX);
...it doesn't fully belong to this function (or only to this function).
> + return method >= DRM_WEDGE_RECOVERY_REBIND && method <
> DRM_WEDGE_RECOVERY_MAX;
> +}
Why do we need this one-liner (after above comment being addressed) as a
separate function?
--
With Best Regards,
Andy Shevchenko
retval = 1;
> + break;
> + }
> }
> return retval;
Ditto.
...
Since it's applied, you can consider a followup.
--
With Best Regards,
Andy Shevchenko
null termimator.
/*
* The wrong comment style. Besides that a typo
* in the word 'terminator'. Please, run codespell on your changes.
* Also use the same form: NUL-terminator when you are talking
* about '\0' and not NULL.
*/
> +*/
--
With Best Regards,
Andy Shevchenko
On Mon, Sep 23, 2024 at 05:35:23PM +0300, Raag Jadav wrote:
> On Mon, Sep 23, 2024 at 11:38:55AM +0300, Andy Shevchenko wrote:
> > On Mon, Sep 23, 2024 at 09:28:23AM +0530, Raag Jadav wrote:
...
> > > +extern const char *const wedge_recovery_opts[];
> >
> > It&#x
> method)
> +{
> + if (method >= DRM_WEDGE_RECOVERY_REBIND && method <
> DRM_WEDGE_RECOVERY_MAX)
> + return true;
> +
> + return false;
Besides that this can be written as
return method >= DRM_WEDGE_RECOVERY_REBIND && method <
DRM_WEDGE_RECOVERY_MAX;
> +}
this seems a runtime approach for what we have at compile-time, i.e.
static_assert()
It's also possible to have as a third approach, but it's less robust.
--
With Best Regards,
Andy Shevchenko
+Cc: Kees
On Fri, Sep 20, 2024 at 02:18:19PM +0300, Raag Jadav wrote:
> On Thu, Sep 19, 2024 at 04:45:28PM +0300, Andy Shevchenko wrote:
> > On Thu, Sep 19, 2024 at 11:38:50AM +0300, Raag Jadav wrote:
> > > On Thu, Sep 19, 2024 at 10:38:51AM +0300, Jani Nikula wrote:
...
>
h Best Regards,
Andy Shevchenko
On Fri, Sep 13, 2024 at 02:11:56AM +0200, Vasileios Amoiridis wrote:
> Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> simple irq_get_trigger_type(irq).
LGTM, FWIW,
Reviewed-by: Andy Shevchenko
--
With Best Regards,
Andy Shevchenko
Use %*ph format to print small buffer as hex string.
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/panel/panel-sony-acx565akm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-sony-acx565akm.c
b/drivers/gpu/drm/panel/panel-sony-acx565akm.c
On Thu, Sep 05, 2024 at 03:03:24PM +0200, Uros Bizjak wrote:
> On Thu, Sep 5, 2024 at 2:41 PM Andy Shevchenko
> wrote:
> >
> > On Thu, Sep 05, 2024 at 02:17:08PM +0200, Uros Bizjak wrote:
> > > There were several attempts to resolve circular include dependency
> >
e there are many useful changes already waiting for a couple of years to
be applied.
Because I haven't found any references nor mentions of that in the cover letter
here and explanation why it was not taking into consideration.
> [1] https://lore.kernel.org/lkml/20240812115945.484051-4-ubiz...@gmail.com/
--
With Best Regards,
Andy Shevchenko
On Tue, Sep 03, 2024 at 06:20:14PM -0400, Stephen Boyd wrote:
> Quoting Andy Shevchenko (2024-09-02 04:35:46)
> > On Sat, Aug 31, 2024 at 09:06:44PM -0700, Stephen Boyd wrote:
> > > Extend the aux-hpd bridge driver to support assigning DP lanes to USB
> > > type-c pi
s not needed and will not be emitted
> [-Werror,-Wunneeded-internal-declaration]
> static inline bool drm_mm_node_scanned_block(const struct drm_mm_node *node)
>^
>
> Fix this by annotating drm_mm_node_scanned_block() with __maybe_unused.
FWIW,
Reviewed-by: An
ARRAY_SIZE(port->lane_mapping)))
> {
> + memcpy(port->lane_mapping, mapping, sizeof(mapping));
Hmm... I'm wondering if direct assignment will save a few .text bytes
port->lane_mapping = ...;
of_property_read_u32_array(ep.local_node, "data-lanes",
port->lane_mapping,
ARRAY_SIZE(port->lane_mapping));
Also note that conditional is not needed in this case.
(And again, why OF-centric code?)
> + }
--
With Best Regards,
Andy Shevchenko
> + if (IS_ERR(switch_dev))
> + return switch_dev;
> +
> + ret = devm_add_action_or_reset(parent, devm_typec_switch_unregister,
> switch_dev);
> + if (ret)
> + return ERR_PTR(ret);
> +
> + return switch_dev;
> +}
--
With Best Regards,
Andy Shevchenko
t; + */
> +typedef void *(*devcon_match_fn_t)(const struct fwnode_handle *fwnode,
> + const char *con_id, void *data);
--
With Best Regards,
Andy Shevchenko
a DT property like 'mode-switch' is always in the
> graph's parent node and not in the endpoint node.
> Cc: Andy Shevchenko
> Cc: Daniel Scally
> Cc: Heikki Krogerus
> Cc: Sakari Ailus
> Cc: Greg Kroah-Hartman
> Cc: Vinod Koul
> Cc: "Rafael J. Wysock
>
> I amended the commit message about clang, config options and commit
> 6863f5643dd7 ("kbuild: allow Clang to find unused static inline
> functions for W=1 build") while pushing.
It all makes sense. Thank you!
--
With Best Regards,
Andy Shevchenko
On Thu, Aug 29, 2024 at 07:53:25PM +0300, Andy Shevchenko wrote:
> On Thu, Aug 29, 2024 at 07:38:08PM +0300, Jani Nikula wrote:
> > On Thu, 29 Aug 2024, Andy Shevchenko
> > wrote:
> > > With CONFIG_WERROR=y and `make W=1` build fails on my x86_64 machine.
> >
On Thu, Aug 29, 2024 at 07:38:08PM +0300, Jani Nikula wrote:
> On Thu, 29 Aug 2024, Andy Shevchenko
> wrote:
> > With CONFIG_WERROR=y and `make W=1` build fails on my x86_64 machine.
> > This is due to some unused functions. Hence these quick fixes.
>
> Since when
With CONFIG_WERROR=y and `make W=1` build fails on my x86_64 machine.
This is due to some unused functions. Hence these quick fixes.
Andy Shevchenko (2):
drm/i915/fence: Mark debug_fence_init_onstack() with __maybe_unused
drm/i915/fence: Mark debug_fence_free() with __maybe_unused
drivers
nce *fence)
|^~~~
Fix this by marking debug_fence_init_onstack() with __maybe_unused.
Fixes: 214707fc2ce0 ("drm/i915/selftests: Wrap a timer into a i915_sw_fence")
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/i915_sw_fence.c | 4 ++-
nce *fence)
|^~~~
Fix this by marking debug_fence_free() with __maybe_unused.
Fixes: fc1584059d6c ("drm/i915: Integrate i915_sw_fence with debugobjects")
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/i915_sw_fence.c | 4 ++--
1 file changed, 2 insertions(+), 2 deleti
erval_tree)
| ~
Fix this by marking drm_mm_interval_tree*() functions with __maybe_unused.
Fixes: 202b52b7fbf7 ("drm: Track drm_mm nodes with an interval tree")
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/drm
The latter
> could happen if there's some AP controlled piece of hardware that is a
> typec switch, connected directly to a usb-c-connector. This is the case
> on Kukui where we send the DP lanes directly to the usb-c-connector.
Thanks!
--
With Best Regards,
Andy Shevchenko
On Thu, Aug 22, 2024 at 10:28:38AM +0300, Raag Jadav wrote:
> On Tue, Aug 20, 2024 at 05:06:39PM +0300, Andy Shevchenko wrote:
> > On Tue, Aug 20, 2024 at 04:12:46PM +0300, Raag Jadav wrote:
> > > On Tue, Aug 20, 2024 at 01:23:35PM +0300, Andy Shevchenko wrote:
> > > &
ri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote:
> > > > > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote:
...
> > > > > I do not understand why we pollute Git history with changelogs, but
> > > > > it's
> > > >
On Tue, Aug 20, 2024 at 05:49:23PM -0400, Rodrigo Vivi wrote:
> On Tue, Aug 20, 2024 at 12:00:27PM +0300, Raag Jadav wrote:
> > On Fri, Aug 09, 2024 at 12:57:54PM +0100, Andi Shyti wrote:
> > > On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote:
...
> > &
On Tue, Aug 20, 2024 at 10:24:47AM -0700, Stephen Boyd wrote:
> Quoting Andy Shevchenko (2024-08-20 10:17:46)
> > On Tue, Aug 20, 2024 at 10:12:55AM -0700, Stephen Boyd wrote:
> > > Quoting Andy Shevchenko (2024-08-20 03:09:29)
> > > > On Mon, Aug 19, 2024 at 03:38:
On Tue, Aug 20, 2024 at 10:23:06AM -0700, Stephen Boyd wrote:
> Quoting Stephen Boyd (2024-08-20 10:19:48)
> > Quoting Andy Shevchenko (2024-08-20 10:16:40)
> > > On Tue, Aug 20, 2024 at 10:01:07AM -0700, Stephen Boyd wrote:
> > > > Quoting Andy Shevchenko (2024-08
On Tue, Aug 20, 2024 at 10:12:55AM -0700, Stephen Boyd wrote:
> Quoting Andy Shevchenko (2024-08-20 03:09:29)
> > On Mon, Aug 19, 2024 at 03:38:16PM -0700, Stephen Boyd wrote:
...
> > Yeah, I really think that the appearance of this thousandth time in the Git
> > history ha
On Tue, Aug 20, 2024 at 10:01:07AM -0700, Stephen Boyd wrote:
> Quoting Andy Shevchenko (2024-08-20 03:16:09)
> > On Mon, Aug 19, 2024 at 03:38:19PM -0700, Stephen Boyd wrote:
> > > + ptr = devres_alloc(devm_typec_switch_unregister, sizeof(*ptr),
> > > GFP_KE
On Tue, Aug 20, 2024 at 04:12:46PM +0300, Raag Jadav wrote:
> On Tue, Aug 20, 2024 at 01:23:35PM +0300, Andy Shevchenko wrote:
> > On Tue, Aug 20, 2024 at 11:50:10AM +0530, Raag Jadav wrote:
...
> > > v6: Drop overflow logic (Andy)
> > > Aesthetic adjustments (B
*
> + * Calculate fan speed in RPM by time averaging two subsequent
> + * readings in minutes.
> + * RPM = number of rotations * msecs per minute / time in msecs
> + */
> + *val = DIV_ROUND_UP(rotations * (MSEC_PER_SEC * 60), time);
...somewhere here?
--
With Best Regards,
Andy Shevchenko
a DT property like 'mode-switch' is always in the
> graph's parent node and not in the endpoint node.
> Cc: Andy Shevchenko
> Cc: Daniel Scally
> Cc: Heikki Krogerus
> Cc: Sakari Ailus
> Cc: Greg Kroah-Hartman
> Cc: Vinod Koul
> Cc: "Rafael J. Wysock
v)) {
> + *ptr = switch_dev;
> + devres_add(parent, ptr);
> + } else {
> + devres_free(ptr);
> + }
devm_add_action_or_reset() ?
--
With Best Regards,
Andy Shevchenko
devres_free(ptr);
> + }
What does prevent you from using devm_add_action_or_reset()?
> + return mux_dev;
> +}
--
With Best Regards,
Andy Shevchenko
uct typec_switch_dev *sw) {}
> +
> +static inline void typec_switch_set_drvdata(struct typec_switch_dev *sw,
> void *data) {}
> +static inline void *typec_switch_get_drvdata(struct typec_switch_dev *sw)
> +{
> + return ERR_PTR(-EOPNOTSUPP);
> +}
> +
> +#endif /* CONFIG_TYPEC */
--
With Best Regards,
Andy Shevchenko
he next bridge wants to
> + * reassign lanes.
> + */
> + for (i = 0; i < num_input_lanes; i++)
> + if (i != input_lanes[i].logical && !num_output_lanes)
> + return -ENOTSUPP;
Besides missing {} this code is internal to the Linux kernel. Is it okay?
--
With Best Regards,
Andy Shevchenko
he drivers/platform/x86/dell/dell-uart-backlight.c are small
> and isolated. So I believe it is best if you take the entire series,
> to avoid conflicts if any other drivers/apci/video_detect.c DMI quirks
> show up this cycle.
FWIW,
Reviewed-by: Andy Shevchenko
I find this quite small
; + * mem_is_zero - Check if an area of memory is all 0's.
> + * @s: The memory area
> + * @n: The size of the area
> + *
> + * Return: True if the area of memory is all 0's.
> + */
> +static inline bool mem_is_zero(const void *s, size_t n)
> +{
> + return
On Tue, Aug 13, 2024 at 03:53:25PM +0300, Raag Jadav wrote:
> On Tue, Aug 13, 2024 at 02:47:27PM +0300, Andy Shevchenko wrote:
> > On Tue, Aug 13, 2024 at 02:23:13PM +0300, Raag Jadav wrote:
> > > On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote:
> > > &
On Tue, Aug 13, 2024 at 02:23:13PM +0300, Raag Jadav wrote:
> On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote:
> > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote:
...
> > > + /*
> > > + * HW register value is accumulated count of pulses f
On Sat, Dec 23, 2023 at 11:00:32AM +0800, Dillon Min wrote:
> On Mon, 11 Dec 2023 at 21:19, Andy Shevchenko
> wrote:
> > On Fri, Dec 08, 2023 at 09:18:20PM +0100, Noralf Trønnes wrote:
> > > On 12/8/23 17:00, Andy Shevchenko wrote:
> > > > Included au
Remove duplicate code that is handled by tinyDRM,
i.e. drivers/gpu/drm/tiny/ili9341.c.
Suggested-by: Maxime Ripard
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 210 +--
1 file changed, 3 insertions(+), 207 deletions(-)
diff --git a/drivers
On Thu, Apr 25, 2024 at 08:12:33PM +0300, Andy Shevchenko wrote:
> On Mon, Apr 22, 2024 at 09:49:04PM +0300, Jani Nikula wrote:
> > On Mon, 22 Apr 2024, Andy Shevchenko
> > wrote:
> > > Update header inclusions to follow IWYU (Include What You Use)
> > > pri
On Tue, Aug 13, 2024 at 08:45:19AM +0300, Raag Jadav wrote:
> On Mon, Aug 12, 2024 at 04:15:14PM +0300, Andy Shevchenko wrote:
> > On Mon, Aug 12, 2024 at 01:45:38PM +0530, Raag Jadav wrote:
...
> > > +static int
> > > +hwm_fan_read(struct hwm_drvdata
Convert to minutes for calculating RPM.
> + * RPM = number of rotations * msecs per minute / time in msecs
> + */
> + *val = DIV_ROUND_UP(rotations * (MSEC_PER_SEC * 60), time);
> +
> + fi->reg_val_prev = reg_val;
> + fi->time_prev = time_now;
> +exit:
> + mutex_unlock(&hwmon->hwmon_lock);
> + intel_runtime_pm_put(ddat->uncore->rpm, wakeref);
> + return ret;
> +}
--
With Best Regards,
Andy Shevchenko
EC_PER_SEC), time);
Have you considered to keep jiffies in the fi and use something from jiffies.h
here? To me it feels like we multiply and divide when it can be avoided.
Please, think about it (I haven't checked myself, just an idea to share).
Also comment probably needs to be expanded to explain the formulas behind all
this.
--
With Best Regards,
Andy Shevchenko
On Tue, Jun 11, 2024 at 06:46:12AM -0700, Jeff Johnson wrote:
> On 4/25/24 05:56, Andy Shevchenko wrote:
...
> I'll remove this from my series
No need, Maxime already applied, and I see
665415092eca ("drm: add missing MODULE_DESCRIPTION() macros")
> Reviewed-by: J
On Wed, Jun 05, 2024 at 11:38:31PM +0300, Andy Shevchenko wrote:
> On Thu, Apr 25, 2024 at 03:56:26PM +0300, Andy Shevchenko wrote:
> > The modpost script is not happy
> >
> > WARNING: modpost: missing MODULE_DESCRIPTION() in
> > drivers/gpu/drm/drm_mipi_dbi.o
a/v4l/vidioc-g-selection.rst
> > [1]
> > Signed-off-by: Devarsh Thakkar
>
> Acked-by: Sebastian Fricke
>
> Can, whoever picks up the math changes, pick up this change as well?
> I will send 1-6 via the media subsystem.
math.h is orphaned, meaning any Tier-1 maintainer may push this through.
So, there is nobody behind it.
--
With Best Regards,
Andy Shevchenko
On Thu, Apr 25, 2024 at 03:56:26PM +0300, Andy Shevchenko wrote:
> The modpost script is not happy
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in
> drivers/gpu/drm/drm_mipi_dbi.o
>
> because there is a missing module description.
>
> Add it to the modul
Make two APIs look similar. Hence convert match_string() to be
a 2-argument macro. In order to avoid unneeded churn, convert
all users as well. There is no functional change intended.
Signed-off-by: Andy Shevchenko
---
Compile tested with `make allyesconfig` and `make allmodconfig`
on x86_64
On Sun, Jun 02, 2024 at 05:21:03PM +0300, Andy Shevchenko wrote:
> Compilation fails on arm with:
>
> link_factory.c:743:1: error: the frame size of 1032 bytes is larger than
> 1024 bytes [-Werror=frame-larger-than=]
>
> Fix the frame size by allocation one of the big struc
Compilation fails on arm with:
link_factory.c:743:1: error: the frame size of 1032 bytes is larger than 1024
bytes [-Werror=frame-larger-than=]
Fix the frame size by allocation one of the big structures.
Signed-off-by: Andy Shevchenko
---
.../gpu/drm/amd/display/dc/link/link_factory.c
On Sat, Jun 01, 2024 at 02:05:08PM +0100, Jonathan Cameron wrote:
> On Fri, 31 May 2024 19:56:14 +0300
> Andy Shevchenko wrote:
>
> > The driver has no in kernel users and requires a board file
> > to be instantiated. Remove basically a dead code.
> >
&g
On Fri, May 31, 2024 at 02:31:45PM -0700, Chia-I Wu wrote:
> On Fri, May 31, 2024 at 1:57 AM Andy Shevchenko <
> andriy.shevche...@linux.intel.com> wrote:
> > On Thu, May 30, 2024 at 10:36:57PM -0700, Chia-I Wu wrote:
...
> > P.S> I'm not so sure about this chang
ub.com/devarsht/3f9042825be3da4e133b8f4eda067876
Make it a tag...
>
...here
Link: ... [1]
> Signed-off-by: Devarsh Thakkar
With the same caveat as per patch 1,
Acked-by: Andy Shevchenko
--
With Best Regards,
Andy Shevchenko
* round_closest_down(14, 4) = 12
> * roundclosest(21, 5) = 20
> * roundclosest(19, 5) = 20
> * roundclosest(17, 5) = 15
I don't know the estimation on how these will really useful or not, but I'm not
objecting if people think it's needed API.
Acked-by: Andy Shevchenko
--
With Best Regards,
Andy Shevchenko
On Fri, May 31, 2024 at 10:42:20PM +0530, Devarsh Thakkar wrote:
> Add documentation for rounding, scaling, absolute value and difference,
> 32-bit division related macros and functions exported by math.h header
> file.
As long as it renders correctly, fine to me
Reviewed-by: Andy S
are written so adding new test cases to cover edge cases should be
> easy
> * looking at code coverage, we hit all the branches in the .c files
Reviewed-by: Andy Shevchenko
--
With Best Regards,
Andy Shevchenko
On Fri, May 31, 2024 at 06:15:46PM +0100, Lee Jones wrote:
> On Fri, 31 May 2024, Andy Shevchenko wrote:
> > On Fri, May 31, 2024 at 07:56:12PM +0300, Andy Shevchenko wrote:
> > > Driver is quite outdated from the Linux kernel internal APIs
> > > perspective. In pa
+Cc: Johan (via kernel.org)
On Fri, May 31, 2024 at 08:14:43PM +0300, Andy Shevchenko wrote:
> On Fri, May 31, 2024 at 07:56:12PM +0300, Andy Shevchenko wrote:
> > Driver is quite outdated from the Linux kernel internal APIs
> > perspective. In particular GPIO code is using legacy
On Fri, May 31, 2024 at 06:14:25PM +0100, Lee Jones wrote:
> Making sure Johan is aware of this with his new address.
Right, in any case this is not the final version (a couple of leftovers).
I have mentioned this series in the original thread.
--
With Best Regards,
Andy Shevchenko
On Fri, May 31, 2024 at 07:56:12PM +0300, Andy Shevchenko wrote:
> Driver is quite outdated from the Linux kernel internal APIs
> perspective. In particular GPIO code is using legacy calls,
> that started being replaced by a new API ca. 2014, i.e. ten
> years ago.
>
> Suggested
The driver has no in kernel users and requires a board file
to be instantiated. Remove basically a dead code.
If ever needed, it can be reinstantiated and converted to one
that uses firmware node interfaces.
Signed-off-by: Andy Shevchenko
---
drivers/leds/Kconfig | 13 -
drivers/leds
Driver is quite outdated from the Linux kernel internal APIs
perspective. In particular GPIO code is using legacy calls,
that started being replaced by a new API ca. 2014, i.e. ten
years ago.
Suggested-by: Linus Walleij
Andy Shevchenko (4):
backlight: lm3533_bl: Remove the driver
iio: light
The driver has no in kernel users and requires a board file
to be instantiated. Remove basically a dead code.
If ever needed, it can be reinstantiated and converted to one
that uses firmware node interfaces.
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/Kconfig | 11
The driver has no in kernel users and requires a board file
to be instantiated. Remove basically a dead code.
If ever needed, it can be reinstantiated and converted to one
that uses firmware node interfaces.
Signed-off-by: Andy Shevchenko
---
drivers/iio/light/Kconfig | 17 -
drivers/iio
The driver has no in kernel users and requires a board file
to be instantiated. Remove basically a dead code.
If ever needed, it can be reinstantiated and converted to one
that uses firmware node interfaces.
Signed-off-by: Andy Shevchenko
---
drivers/mfd/lm3533-core.c | 645
ata from cpu memory into amdgpu
> bo, the throughput goes from 5.1GB/s to 6.6GB/s. perf report says
Also in the $Subj (and pay attention to the prefix)
"resource: ... find_next_iomem_res()"
--
With Best Regards,
Andy Shevchenko
her way they
needs to be added / expanded).
P.S> I'm not so sure about this change. It needs a thoroughly testing, esp.
in PCI case. Cc'ing to Ilpo.
--
With Best Regards,
Andy Shevchenko
You need to update the inclusion bloc in accordance with IWYU principle.
I see a few headers are missing.
--
With Best Regards,
Andy Shevchenko
on functions
> +--
> +
> +.. kernel-doc:: include/linux/math.h
> + :internal:
Please, double check that this is correct keyword in this case.
Otherwise LGTM.
--
With Best Regards,
Andy Shevchenko
> + *
> + * round_closest_down(15, 4) = 16
> + *
> + * round_closest_down(14, 4) = 12
As per above
...
> + * Examples :
> + *
> + * roundclosest(21, 5) = 20
> + *
> + * roundclosest(19, 5) = 20
> + *
> + * roundclosest(17, 5) = 15
As per above.
--
With Best Regards,
Andy Shevchenko
On Tue, May 28, 2024 at 05:01:31PM +0530, Devarsh Thakkar wrote:
> On 28/05/24 02:08, Andy Shevchenko wrote:
> > On Mon, May 27, 2024 at 11:37:20PM +0300, Andy Shevchenko wrote:
> >> On Sun, May 26, 2024 at 11:39:33PM +0530, Devarsh Thakkar wrote:
...
> >
On Tue, May 28, 2024 at 04:51:46PM +0530, Devarsh Thakkar wrote:
> On 28/05/24 02:07, Andy Shevchenko wrote:
[..]
> >> +#include
> >> +#include
> >> +#include
> >
> > + math.h (where abs()/DIV_ROUND_*()/etc come from?)
> > I believe I mentioned
On Tue, May 28, 2024 at 04:02:30PM +0530, Devarsh Thakkar wrote:
> On 28/05/24 02:02, Andy Shevchenko wrote:
> > On Sun, May 26, 2024 at 11:38:56PM +0530, Devarsh Thakkar wrote:
...
> >> +/**
> >> + * round_closest_up - round closest to be multiple of spec
k_get(&tmu->pdev->dev, "fck");
devm_ approach can help a lot in case of platform device code.
> + if (IS_ERR(tmu->clk)) {
> + dev_err(&tmu->pdev->dev, "cannot get clock\n");
> + return PTR_ERR(tmu->clk);
return dev_err_probe() ?
> + }
--
With Best Regards,
Andy Shevchenko
On Mon, May 27, 2024 at 11:37:20PM +0300, Andy Shevchenko wrote:
> On Sun, May 26, 2024 at 11:39:33PM +0530, Devarsh Thakkar wrote:
...
> > +MODULE_LICENSE("GPL");
>
> modpost validator won't be happy about this, i.e. missing
> MODULE_DESCRIPTION().
And obvi
de
...
> +MODULE_LICENSE("GPL");
modpost validator won't be happy about this, i.e. missing MODULE_DESCRIPTION().
--
With Best Regards,
Andy Shevchenko
* round_closest_up(17, 4) = 16
> + * round_closest_up(15, 4) = 16
> + * round_closest_up(14, 4) = 16
Btw, is kernel-doc validator happy about all kernel docs you added?
> + */
--
With Best Regards,
Andy Shevchenko
ing to have a new function per byte in question, or do we
come up with a common denominator, like mem_is_all_of(mem, byte)?
--
With Best Regards,
Andy Shevchenko
0], &tmp64, sizeof(u64));
> memcpy(&guid[8], &tmp64, sizeof(u64));
What is the type of guid? Shouldn't it be guid_t with the respective
guid_is_null()
...
> - if (memchr_inv(guid, 0, 16))
> + if (!mem_is_zero(guid, 16))
>
On Mon, May 20, 2024 at 07:51:24PM +0530, Devarsh Thakkar wrote:
> On 20/05/24 17:52, Andy Shevchenko wrote:
> > On Mon, May 20, 2024 at 05:11:18PM +0530, Devarsh Thakkar wrote:
> >> On 18/05/24 01:44, Andy Shevchenko wrote:
> >>> On Fri, May 17, 2024 at 11:06:07P
On Mon, May 20, 2024 at 05:11:18PM +0530, Devarsh Thakkar wrote:
> On 18/05/24 01:44, Andy Shevchenko wrote:
> > On Fri, May 17, 2024 at 11:06:07PM +0530, Devarsh Thakkar wrote:
[..]
> >> +#include
> >> +#include
> >
> >> +#include
> >
>
On Fri, May 17, 2024 at 01:53:47PM -0700, Daniel Latypov wrote:
> On Fri, May 17, 2024 at 1:14 PM Andy Shevchenko
> wrote:
...
> > > [devarsht: Rebase to 6.9 and change license to GPL]
> >
> > I'm not sure that you may change license. It needs the author's
#include
+ math.h // obviously
+ module.h
> +#include
+ types.h
...
Other than above, LGTM.
--
With Best Regards,
Andy Shevchenko
1 - 100 of 1019 matches
Mail list logo
