Re: [PATCHv2 03/22] drm/bridge: tc358767: fix ansi 8b10b use

2019-04-24 Thread Andrey Gusakov
Hi Laurent, On Tue, Apr 23, 2019 at 5:56 PM Laurent Pinchart wrote: > > Hi Andrey, > > On Tue, Apr 23, 2019 at 11:19:17AM +0300, Andrey Gusakov wrote: > > On Sun, Apr 21, 2019 at 12:14 AM Laurent Pinchart wrote: > > > On Tue, Mar 26, 2019 at 12:31:27PM +0200, Tomi

Re: [PATCHv2 03/22] drm/bridge: tc358767: fix ansi 8b10b use

2019-04-23 Thread Andrey Gusakov
Hi Laurent, On Sun, Apr 21, 2019 at 12:14 AM Laurent Pinchart wrote: > > Hi Tomi, > > Thank you for the patch. > > On Tue, Mar 26, 2019 at 12:31:27PM +0200, Tomi Valkeinen wrote: > > DP always uses ANSI 8B10B encoding. Some monitors (old?) may not have > > the ANSI 8B10B bit set in DPCD, even if

Re: [PATCHv2 12/22] drm/bridge: tc358767: remove unnecessary msleep

2019-04-23 Thread Andrey Gusakov
d there in the first place ? I see no reason for this delay. Seems this was not cleaned-up after debug. Reviewed-by: Andrey Gusakov > > > Drop it, as msleep(100) is a rather big one. > > > > Signed-off-by: Tomi Valkeinen > > --- > > drivers/gpu/drm/bridge/tc

Re: [PATCH v3 0/7] drm/bridge: tc358767: fixes and improvements

2017-11-29 Thread Andrey Gusakov
Andrzej, Please queue 1-6 to -fixes, 7 to -next. Andrey. On Wed, Nov 29, 2017 at 2:03 PM, Andrzej Hajda wrote: > On 07.11.2017 17:56, Andrey Gusakov wrote: > > This set of patches fixes several issues that was found during testing > > tc358767 with desktop Displ

[PATCH v3 7/7] drm/bridge: tc358767: add copyright lines

2017-11-07 Thread Andrey Gusakov
Add copyright lines for Zodiac who paid for driver development. Signed-off-by: Andrey Gusakov --- drivers/gpu/drm/bridge/tc358767.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 37e33f2..69d2af3 100644 --- a

[PATCH v3 6/7] drm/bridge: tc358767: fix 1-lane behavior

2017-11-07 Thread Andrey Gusakov
Use drm_dp_channel_eq_ok helper Acked-by: Philipp Zabel Signed-off-by: Andrey Gusakov --- drivers/gpu/drm/bridge/tc358767.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index bb5d277

[PATCH v3 2/7] drm/bridge: tc358767: filter out too high modes

2017-11-07 Thread Andrey Gusakov
Pixel clock limitation for DPI is 154 MHz. Do not accept modes with higher pixel clock rate. Reviewed-by: Andrzej Hajda Signed-off-by: Andrey Gusakov --- drivers/gpu/drm/bridge/tc358767.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358767

[PATCH v3 3/7] drm/bridge: tc358767: fix DP0_MISC register set

2017-11-07 Thread Andrey Gusakov
Remove shift from TU_SIZE_RECOMMENDED define as it used to calculate max_tu_symbols. Acked-by: Philipp Zabel Signed-off-by: Andrey Gusakov --- drivers/gpu/drm/bridge/tc358767.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b

[PATCH v3 4/7] drm/bridge: tc358767: fix timing calculations

2017-11-07 Thread Andrey Gusakov
Fields in HTIM01 and HTIM02 regs should be even. Recomended thresh_dly value is max_tu_symbol. Remove set of VPCTRL0.VSDELAY as it is related to DSI input interface. Currently driver supports only DPI. Acked-by: Philipp Zabel Signed-off-by: Andrey Gusakov --- drivers/gpu/drm/bridge/tc358767.c

[PATCH v3 5/7] drm/bridge: tc358767: fix AUXDATAn registers access

2017-11-07 Thread Andrey Gusakov
First four bytes should go to DP0_AUXWDATA0. Due to bug if len > 4 first four bytes was writen to DP0_AUXWDATA1 and all data get shifted by 4 bytes. Fix it. Acked-by: Philipp Zabel Signed-off-by: Andrey Gusakov --- drivers/gpu/drm/bridge/tc358767.c |2 +- 1 file changed, 1 insertion(+)

[PATCH v3 1/7] drm/bridge: tc358767: do no fail on hi-res displays

2017-11-07 Thread Andrey Gusakov
Do not fail data rates higher than 2.7 and more than 2 lanes. Try to fall back to 2.7Gbps and 2 lanes. Acked-by: Philipp Zabel Reviewed-by: Andrzej Hajda Signed-off-by: Andrey Gusakov --- drivers/gpu/drm/bridge/tc358767.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions

[PATCH v3 0/7] drm/bridge: tc358767: fixes and improvements

2017-11-07 Thread Andrey Gusakov
s since v2: - fixed maximum pixelclock frequency - copyright patch added Andrey Gusakov (7): drm/bridge: tc358767: do no fail on hi-res displays drm/bridge: tc358767: filter out too high modes drm/bridge: tc358767: fix DP0_MISC register set drm/bridge: tc358767: fix timing calculat

[PATCH v2 1/7] drm/bridge: tc358767: do no fail on hi-res displays

2017-11-03 Thread Andrey Gusakov
Do not fail data rates higher than 2.7 and more than 2 lanes. Try to fall back to 2.7Gbps and 2 lanes. --- drivers/gpu/drm/bridge/tc358767.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c i

[PATCH v2 4/7] drm/bridge: tc358767: fix timing calculations

2017-11-03 Thread Andrey Gusakov
Fields in HTIM01 and HTIM02 regs should be even. Recomended thresh_dly value is max_tu_symbol. --- drivers/gpu/drm/bridge/tc358767.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridg

[PATCH v2 2/7] drm/bridge: tc358767: filter out too high modes

2017-11-03 Thread Andrey Gusakov
Minimum pixel clock period is 6.5 nS for DPI. Do not accept modes with lower pixel clock period. --- drivers/gpu/drm/bridge/tc358767.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index d52cd41..7

[PATCH v2 3/7] drm/bridge: tc358767: fix DP0_MISC register set

2017-11-03 Thread Andrey Gusakov
Remove shift from TU_SIZE_RECOMMENDED define as it used to calculate max_tu_symbols. --- drivers/gpu/drm/bridge/tc358767.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 7f9c2e0..90d6b49 10064

[PATCH v2 7/7] drm/bridge: tc358767: add copyright lines

2017-11-03 Thread Andrey Gusakov
Add copyright lines for Zodiac who paid for driver development. Signed-off-by: Andrey Gusakov --- drivers/gpu/drm/bridge/tc358767.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 1e677be..d98d717 100644 --- a

[PATCH v2 5/7] drm/bridge: tc358767: fix AUXDATAn registers access

2017-11-03 Thread Andrey Gusakov
First four bytes should go to DP0_AUXWDATA0. Due to bug if len > 4 first four bytes was writen to DP0_AUXWDATA1 and all data get shifted by 4 bytes. Fix it. --- drivers/gpu/drm/bridge/tc358767.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358767.

[PATCH v2 6/7] drm/bridge: tc358767: fix 1-lane behavior

2017-11-03 Thread Andrey Gusakov
Use drm_dp_channel_eq_ok helper --- drivers/gpu/drm/bridge/tc358767.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 4394131..1e677be 100644 --- a/drivers/gpu/drm/bridge/tc358767.c ++

[PATCH v2 0/7] drm/bridge: tc358767: fixes and improvements (resend)

2017-11-03 Thread Andrey Gusakov
This set of patches fixes several issues that was found during testing tc358767 with desktop DisplayPort displays. Changes in V2: - fixed maximum pixelclock frequency - copyright patch added Andrey Gusakov (7): drm/bridge: tc358767: do no fail on hi-res displays drm/bridge

Re: [PATCH 2/6] drm/bridge: tc358767: filter out too high modes

2017-08-02 Thread Andrey Gusakov
On Tue, Aug 1, 2017 at 4:11 PM, Philipp Zabel wrote: > On Thu, 2017-07-27 at 15:47 +0300, Andrey Gusakov wrote: > > Minimum pixel clock period is 6.5 nS for DPI. Do not accept modes > > with lower pixel clock period. > > > > Signed-off-by: Andrey Gusakov > >

Re: [PATCH] drm/bridge: tc358767: fix probe without attached output node

2017-07-27 Thread Andrey Gusakov
t if > no endpoint is found. > > Fixes: ebc944613567 (drm: convert drivers to use > drm_of_find_panel_or_bridge) > CC: sta...@vger.kernel.org > Signed-off-by: Lucas Stach > Acked-by: Andrey Gusakov --- > drivers/gpu/drm/bridge/tc358767.c | 2 +- > 1 file changed, 1 insertio

[PATCH 0/6] drm/bridge: tc358767: fixes and improvements

2017-07-27 Thread Andrey Gusakov
This set of patches fixes several issues that was found during testing tc358767 with desktop DisplayPort displays. Andrey Gusakov (6): drm/bridge: tc358767: do no fail on hi-res displays drm/bridge: tc358767: filter out too high modes drm/bridge: tc358767: fix DP0_MISC register set drm

[PATCH 2/6] drm/bridge: tc358767: filter out too high modes

2017-07-27 Thread Andrey Gusakov
Minimum pixel clock period is 6.5 nS for DPI. Do not accept modes with lower pixel clock period. Signed-off-by: Andrey Gusakov --- drivers/gpu/drm/bridge/tc358767.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm

[PATCH 3/6] drm/bridge: tc358767: fix DP0_MISC register set

2017-07-27 Thread Andrey Gusakov
Remove shift from TU_SIZE_RECOMMENDED define as it used to calculate max_tu_symbols. Signed-off-by: Andrey Gusakov --- drivers/gpu/drm/bridge/tc358767.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767

[PATCH 6/6] drm/bridge: tc358767: fix 1-lane behavior

2017-07-27 Thread Andrey Gusakov
Use drm_dp_channel_eq_ok helper Signed-off-by: Andrey Gusakov --- drivers/gpu/drm/bridge/tc358767.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 84b0b0fff854..24abffae6edb 100644

[PATCH 4/6] drm/bridge: tc358767: fix timing calculations

2017-07-27 Thread Andrey Gusakov
Fields in HTIM01 and HTIM02 regs should be even. Recomended thresh_dly value is max_tu_symbol. Signed-off-by: Andrey Gusakov --- drivers/gpu/drm/bridge/tc358767.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/bridge

[PATCH 5/6] drm/bridge: tc358767: fix AUXDATAn registers access

2017-07-27 Thread Andrey Gusakov
First four bytes should go to DP0_AUXWDATA0. Due to bug if len > 4 first four bytes was writen to DP0_AUXWDATA1 and all data get shifted by 4 bytes. Fix it. Signed-off-by: Andrey Gusakov --- drivers/gpu/drm/bridge/tc358767.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PATCH 1/6] drm/bridge: tc358767: do no fail on hi-res displays

2017-07-27 Thread Andrey Gusakov
Do not fail data rates higher than 2.7 and more than 2 lanes. Try to fall back to 2.7Gbps and 2 lanes. Signed-off-by: Andrey Gusakov --- drivers/gpu/drm/bridge/tc358767.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b

[PATCH] drm/bridge: tc358767: add copyright lines

2017-01-13 Thread Andrey Gusakov
Add copyright lines for Zodiac who paid for driver development. Signed-off-by: Andrey Gusakov --- drivers/gpu/drm/bridge/tc358767.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index de9ffb4..f117673 100644 --- a

[PATCH] drm/bridge: tc358767: don't warn if display side ASSR enable fails

2016-12-01 Thread Andrey Gusakov
Hi. I'm fine with that change. Acked-by:Andrey Gusakov On Thu, Dec 1, 2016 at 10:58 AM, Philipp Zabel wrote: > Am Donnerstag, den 01.12.2016, 09:56 +0530 schrieb Archit Taneja: >> >> On 11/30/2016 05:18 PM, Lucas Stach wrote: >> > ASSR is an optional feature, so it's a valid operating conditi