Re: [Intel-gfx] [PATCH] drm/i915: enable semaphores on gen6 if dmar is not active

2012-04-02 Thread Andrew Lutomirski
On Mon, Apr 2, 2012 at 1:52 PM, Daniel Vetter wrote: > On Mon, Apr 02, 2012 at 01:45:39PM -0700, Andrew Lutomirski wrote: >> On Mon, Apr 2, 2012 at 11:48 AM, Daniel Vetter >> wrote: >> > Inspired by the recent ppgtt regression report, where switching of >> > d

[Intel-gfx] [PATCH] drm/i915: enable semaphores on gen6 if dmar is not active

2012-04-02 Thread Andrew Lutomirski
On Mon, Apr 2, 2012 at 1:52 PM, Daniel Vetter wrote: > On Mon, Apr 02, 2012 at 01:45:39PM -0700, Andrew Lutomirski wrote: >> On Mon, Apr 2, 2012 at 11:48 AM, Daniel Vetter >> wrote: >> > Inspired by the recent ppgtt regression report, where switching of >> > d

Re: [Intel-gfx] [PATCH] drm/i915: enable semaphores on gen6 if dmar is not active

2012-04-02 Thread Andrew Lutomirski
On Mon, Apr 2, 2012 at 11:48 AM, Daniel Vetter wrote: > Inspired by the recent ppgtt regression report, where switching of > dmar only for the gpu seems to fix things completely, I've looked > again at the semaphores+vt-d situation. > > Contrary to my earlier testing a few months back my system is

[Intel-gfx] [PATCH] drm/i915: enable semaphores on gen6 if dmar is not active

2012-04-02 Thread Andrew Lutomirski
On Mon, Apr 2, 2012 at 11:48 AM, Daniel Vetter wrote: > Inspired by the recent ppgtt regression report, where switching of > dmar only for the gpu seems to fix things completely, I've looked > again at the semaphores+vt-d situation. > > Contrary to my earlier testing a few months back my system i

Re: [RFC PATCH] drm: Fix off-by-one races on vblank disable

2011-11-17 Thread Andrew Lutomirski
On Thu, Nov 17, 2011 at 2:54 PM, Mario Kleiner wrote: > Jesse, cc'ing you in case you have thoughts about this for the intel side of > things? > > On Nov 17, 2011, at 4:39 PM, Andrew Lutomirski wrote: > >> 2011/11/17 Michel Dänzer : >>> >>> [ Dropping

[RFC PATCH] drm: Fix off-by-one races on vblank disable

2011-11-17 Thread Andrew Lutomirski
On Thu, Nov 17, 2011 at 2:54 PM, Mario Kleiner wrote: > Jesse, cc'ing you in case you have thoughts about this for the intel side of > things? > > On Nov 17, 2011, at 4:39 PM, Andrew Lutomirski wrote: > >> 2011/11/17 Michel D?nzer : >>> >>> [ Dropping

Re: [RFC PATCH] drm: Fix off-by-one races on vblank disable

2011-11-17 Thread Andrew Lutomirski
2011/11/17 Michel Dänzer : > [ Dropping intel-gfx list from CC, as it automatically rejects posts > from non-subscribers ] > > On Mit, 2011-11-16 at 21:39 -0800, Andy Lutomirski wrote: >> There are two possible races when disabling vblanks.  If the IRQ >> fired but the hardware didn't update its co

[RFC PATCH] drm: Fix off-by-one races on vblank disable

2011-11-17 Thread Andrew Lutomirski
2011/11/17 Michel D?nzer : > [ Dropping intel-gfx list from CC, as it automatically rejects posts > from non-subscribers ] > > On Mit, 2011-11-16 at 21:39 -0800, Andy Lutomirski wrote: >> There are two possible races when disabling vblanks. ?If the IRQ >> fired but the hardware didn't update its co

Re: [Intel-gfx] [RFC] Reduce idle vblank wakeups

2011-11-16 Thread Andrew Lutomirski
On Wed, Nov 16, 2011 at 6:19 PM, Matthew Garrett wrote: > On Thu, Nov 17, 2011 at 01:26:37AM +0100, Mario Kleiner wrote: >> On Nov 16, 2011, at 7:48 PM, Matthew Garrett wrote: >> >For Radeon, I'd have thought you could handle this by scheduling >> >an irq >> >for the beginning of scanout (avivo ha

[Intel-gfx] [RFC] Reduce idle vblank wakeups

2011-11-16 Thread Andrew Lutomirski
On Wed, Nov 16, 2011 at 6:19 PM, Matthew Garrett wrote: > On Thu, Nov 17, 2011 at 01:26:37AM +0100, Mario Kleiner wrote: >> On Nov 16, 2011, at 7:48 PM, Matthew Garrett wrote: >> >For Radeon, I'd have thought you could handle this by scheduling >> >an irq >> >for the beginning of scanout (avivo ha

Re: [Intel-gfx] [RFC] Reduce idle vblank wakeups

2011-11-16 Thread Andrew Lutomirski
2011/11/16 Matthew Garrett : > On Wed, Nov 16, 2011 at 06:03:15PM +0100, Michel Dänzer wrote: > >> I thought the main reason for the delay wasn't broken hardware but to >> avoid constantly ping-ponging the vblank IRQ between on and off with >> apps which regularly neeed the vblank counter value, as

[Intel-gfx] [RFC] Reduce idle vblank wakeups

2011-11-16 Thread Andrew Lutomirski
2011/11/16 Matthew Garrett : > On Wed, Nov 16, 2011 at 06:03:15PM +0100, Michel D?nzer wrote: > >> I thought the main reason for the delay wasn't broken hardware but to >> avoid constantly ping-ponging the vblank IRQ between on and off with >> apps which regularly neeed the vblank counter value, as

[Intel-gfx] [PATCH] drm/i915: Hold struct_mutex during hotplug processing

2011-07-26 Thread Andrew Lutomirski
On Tue, Jul 26, 2011 at 1:54 AM, Keith Packard wrote: > From 59b920597999381fab70c485c161dd50590e561a Mon Sep 17 00:00:00 2001 > From: Keith Packard > Date: Mon, 25 Jul 2011 22:37:51 -0700 > Subject: [PATCH] Revert and fix "drm/i915/dp: remove DPMS mode tracking from > ?DP" > > This reverts commi

Re: [Intel-gfx] [PATCH] drm/i915: Hold struct_mutex during hotplug processing

2011-07-26 Thread Andrew Lutomirski
On Tue, Jul 26, 2011 at 1:54 AM, Keith Packard wrote: > From 59b920597999381fab70c485c161dd50590e561a Mon Sep 17 00:00:00 2001 > From: Keith Packard > Date: Mon, 25 Jul 2011 22:37:51 -0700 > Subject: [PATCH] Revert and fix "drm/i915/dp: remove DPMS mode tracking from >  DP" > > This reverts commi

[Intel-gfx] [PATCH] drm/i915: Hold struct_mutex during hotplug processing

2011-07-25 Thread Andrew Lutomirski
On Mon, Jul 25, 2011 at 1:37 PM, Jesse Barnes wrote: > On Mon, 25 Jul 2011 10:10:29 -0700 > Keith Packard wrote: > >> Hotplug detection is a mode setting operation and must hold the >> struct_mutex or risk colliding with other mode setting operations. >> >> In particular, the display port hotplu

Re: [Intel-gfx] [PATCH] drm/i915: Hold struct_mutex during hotplug processing

2011-07-25 Thread Andrew Lutomirski
On Mon, Jul 25, 2011 at 1:37 PM, Jesse Barnes wrote: > On Mon, 25 Jul 2011 10:10:29 -0700 > Keith Packard wrote: > >> Hotplug detection is a mode setting operation and must hold the >> struct_mutex or risk colliding with other mode setting operations. >> >> In particular, the display port hotplug

[Intel-gfx] [PATCH] drm/i915: Hold struct_mutex during hotplug processing

2011-07-25 Thread Andrew Lutomirski
Will test tonight. It looks like there is a lot of hotplug activity when 'xset dpms force off' gets run. (That's not a typo. I do mean "off," not "on." See attached trace. perf rocks, even over ssh :) --Andy On Mon, Jul 25, 2011 at 1:37 PM, Jesse Barnes wrote: > On Mon, 25 Jul 2011 10:10:2

Re: [Intel-gfx] [PATCH] drm/i915: Hold struct_mutex during hotplug processing

2011-07-25 Thread Andrew Lutomirski
Will test tonight. It looks like there is a lot of hotplug activity when 'xset dpms force off' gets run. (That's not a typo. I do mean "off," not "on." See attached trace. perf rocks, even over ssh :) --Andy On Mon, Jul 25, 2011 at 1:37 PM, Jesse Barnes wrote: > On Mon, 25 Jul 2011 10:10:29

[Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2011-01-10 Thread Andrew Lutomirski
On Mon, Dec 27, 2010 at 7:58 AM, Mario Kleiner wrote: > On Dec 26, 2010, at 3:53 PM, Andrew Lutomirski wrote: > >> On Wed, Dec 22, 2010 at 4:06 PM, Mario Kleiner >> wrote: >>> >>> There's a new drm module parameter for selecting the timeout:

Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2011-01-09 Thread Andrew Lutomirski
On Mon, Dec 27, 2010 at 7:58 AM, Mario Kleiner wrote: > On Dec 26, 2010, at 3:53 PM, Andrew Lutomirski wrote: > >> On Wed, Dec 22, 2010 at 4:06 PM, Mario Kleiner >> wrote: >>> >>> There's a new drm module parameter for selecting the timeout:

[Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-26 Thread Andrew Lutomirski
On Wed, Dec 22, 2010 at 4:06 PM, Mario Kleiner wrote: > > There's a new drm module parameter for selecting the timeout: echo 50 > > /sys/module/drm/parameters/vblankoffdelay > would set the timeout to 50 msecs. A setting of zero will disable the timer, > so vblank irq's would stay on all the time.

Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-26 Thread Andrew Lutomirski
On Wed, Dec 22, 2010 at 4:06 PM, Mario Kleiner wrote: > > There's a new drm module parameter for selecting the timeout: echo 50 > > /sys/module/drm/parameters/vblankoffdelay > would set the timeout to 50 msecs. A setting of zero will disable the timer, > so vblank irq's would stay on all the time.

[Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-20 Thread Andrew Lutomirski
On Mon, Dec 20, 2010 at 10:47 PM, Keith Packard wrote: > On Mon, 20 Dec 2010 22:34:12 -0500, Andrew Lutomirski wrote: > >> But five seconds is a *long* time, and anything short enough that the >> interrupt actually gets turned off in normal use risks the same race. > > R

[Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-20 Thread Andrew Lutomirski
On Mon, Dec 20, 2010 at 10:23 PM, Keith Packard wrote: > On Mon, 20 Dec 2010 14:00:54 -0500, Andy Lutomirski wrote: > >> Enabling and disabling the vblank interrupt (on devices that >> support it) is cheap. ?So disable it quickly after each >> interrupt. > > So, the concern (and reason for the or

Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-20 Thread Andrew Lutomirski
On Mon, Dec 20, 2010 at 10:47 PM, Keith Packard wrote: > On Mon, 20 Dec 2010 22:34:12 -0500, Andrew Lutomirski wrote: > >> But five seconds is a *long* time, and anything short enough that the >> interrupt actually gets turned off in normal use risks the same race. > > R

Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-20 Thread Andrew Lutomirski
On Mon, Dec 20, 2010 at 10:23 PM, Keith Packard wrote: > On Mon, 20 Dec 2010 14:00:54 -0500, Andy Lutomirski wrote: > >> Enabling and disabling the vblank interrupt (on devices that >> support it) is cheap.  So disable it quickly after each >> interrupt. > > So, the concern (and reason for the or

[00/66] 2.6.36.1-stable review

2010-11-20 Thread Andrew Lutomirski
On Sat, Nov 20, 2010 at 10:52 AM, Greg KH wrote: > On Sat, Nov 20, 2010 at 09:24:05AM -0500, Andy Lutomirski wrote: >> Greg KH wrote: >>> This is the start of the stable review cycle for the 2.6.36.1 release. >>> There are 66 patches in this series, all will be posted as a response >>> to this one

Re: [00/66] 2.6.36.1-stable review

2010-11-20 Thread Andrew Lutomirski
On Sat, Nov 20, 2010 at 10:52 AM, Greg KH wrote: > On Sat, Nov 20, 2010 at 09:24:05AM -0500, Andy Lutomirski wrote: >> Greg KH wrote: >>> This is the start of the stable review cycle for the 2.6.36.1 release. >>> There are 66 patches in this series, all will be posted as a response >>> to this one

[PATCH v2 0/2] Fix nouveau-related freezes

2010-11-16 Thread Andrew Lutomirski
On Wed, Nov 10, 2010 at 6:04 PM, Andy Lutomirski wrote: > Nouveau takes down my system quite reliably when any hotplug event occurs. > The bug happens because the IRQ handler didn't acknowledge the hotplug > state until the bottom half, so the card generated a new interrupt > immediately, starving

Re: [PATCH v2 0/2] Fix nouveau-related freezes

2010-11-16 Thread Andrew Lutomirski
On Wed, Nov 10, 2010 at 6:04 PM, Andy Lutomirski wrote: > Nouveau takes down my system quite reliably when any hotplug event occurs. > The bug happens because the IRQ handler didn't acknowledge the hotplug > state until the bottom half, so the card generated a new interrupt > immediately, starving

Severe reproducible nouveau breakage in 2.6.36 (and maybe .35)

2010-11-10 Thread Andrew Lutomirski
Hi all- Somewhere between 2.6.34-fedora-whatever and 2.6.36, Nouveau became extremely broken on my hardware. It appears to be triggered by a bug in my monitor (HP LP2475w), which causes the monitor to disappear from DVI when it goes to sleep. Every time the console blanks (in X or otherwise AFAI

[PATCH 2/2] nouveau: Acknowledge HPD irq in handler, not bottom half

2010-11-10 Thread Andrew Lutomirski
On Wed, Nov 10, 2010 at 5:55 PM, Maarten Maathuis wrote: > On Wed, Nov 10, 2010 at 11:51 PM, Andrew Lutomirski wrote: >> On Wed, Nov 10, 2010 at 5:35 PM, Ben Skeggs wrote: >>> On Wed, 2010-11-10 at 17:25 -0500, Andrew Lutomirski wrote: >>>> On Wed, Nov 10, 2010

[PATCH 2/2] nouveau: Acknowledge HPD irq in handler, not bottom half

2010-11-10 Thread Andrew Lutomirski
On Wed, Nov 10, 2010 at 5:35 PM, Ben Skeggs wrote: > On Wed, 2010-11-10 at 17:25 -0500, Andrew Lutomirski wrote: >> On Wed, Nov 10, 2010 at 5:10 PM, Ben Skeggs wrote: >> > On Wed, 2010-11-10 at 16:32 -0500, Andy Lutomirski wrote: >> >> The old code generated an

[PATCH 2/2] nouveau: Acknowledge HPD irq in handler, not bottom half

2010-11-10 Thread Andrew Lutomirski
On Wed, Nov 10, 2010 at 5:10 PM, Ben Skeggs wrote: > On Wed, 2010-11-10 at 16:32 -0500, Andy Lutomirski wrote: >> The old code generated an interrupt storm bad enough to completely >> take down my system. >> >> This only fixes the bits that are defined nouveau_regs.h. ?Newer hardware >> uses anoth

Severe reproducible nouveau breakage in 2.6.36 (and maybe .35)

2010-11-10 Thread Andrew Lutomirski
On Wed, Nov 10, 2010 at 2:28 PM, Andrew Lutomirski wrote: > Hi all- > > Somewhere between 2.6.34-fedora-whatever and 2.6.36, Nouveau became > extremely broken on my hardware. ?It appears to be triggered by a bug > in my monitor (HP LP2475w), which causes the monitor to disappear

Re: [PATCH 2/2] nouveau: Acknowledge HPD irq in handler, not bottom half

2010-11-10 Thread Andrew Lutomirski
On Wed, Nov 10, 2010 at 5:55 PM, Maarten Maathuis wrote: > On Wed, Nov 10, 2010 at 11:51 PM, Andrew Lutomirski wrote: >> On Wed, Nov 10, 2010 at 5:35 PM, Ben Skeggs wrote: >>> On Wed, 2010-11-10 at 17:25 -0500, Andrew Lutomirski wrote: >>>> On Wed, Nov 10, 2010

Re: [PATCH 2/2] nouveau: Acknowledge HPD irq in handler, not bottom half

2010-11-10 Thread Andrew Lutomirski
On Wed, Nov 10, 2010 at 5:35 PM, Ben Skeggs wrote: > On Wed, 2010-11-10 at 17:25 -0500, Andrew Lutomirski wrote: >> On Wed, Nov 10, 2010 at 5:10 PM, Ben Skeggs wrote: >> > On Wed, 2010-11-10 at 16:32 -0500, Andy Lutomirski wrote: >> >> The old code generated an

Severe reproducible nouveau breakage in 2.6.36 (and maybe .35)

2010-11-10 Thread Andrew Lutomirski
Hi all- Somewhere between 2.6.34-fedora-whatever and 2.6.36, Nouveau became extremely broken on my hardware. It appears to be triggered by a bug in my monitor (HP LP2475w), which causes the monitor to disappear from DVI when it goes to sleep. Every time the console blanks (in X or otherwise AFAI

Re: [PATCH 2/2] nouveau: Acknowledge HPD irq in handler, not bottom half

2010-11-10 Thread Andrew Lutomirski
On Wed, Nov 10, 2010 at 5:10 PM, Ben Skeggs wrote: > On Wed, 2010-11-10 at 16:32 -0500, Andy Lutomirski wrote: >> The old code generated an interrupt storm bad enough to completely >> take down my system. >> >> This only fixes the bits that are defined nouveau_regs.h.  Newer hardware >> uses anoth

Re: Severe reproducible nouveau breakage in 2.6.36 (and maybe .35)

2010-11-10 Thread Andrew Lutomirski
On Wed, Nov 10, 2010 at 2:28 PM, Andrew Lutomirski wrote: > Hi all- > > Somewhere between 2.6.34-fedora-whatever and 2.6.36, Nouveau became > extremely broken on my hardware.  It appears to be triggered by a bug > in my monitor (HP LP2475w), which causes the monitor to disappear

[2.6.35 regression ping] i915 is unusable due to CRT hotplug bug

2010-06-16 Thread Andrew Lutomirski
[resend to correct dri-devel address] Hi all- Just a friendly regression reminder: a recent patch intended to fix the long-standing hotplug storm bugs in i915 instead made it a good deal worse -- I now get hotplug interrupts constantly as long as anything (plymouth or Xorg, for example) is query

[2.6.35 regression ping] i915 is unusable due to CRT hotplug bug

2010-06-16 Thread Andrew Lutomirski
[resend to correct dri-devel address] Hi all- Just a friendly regression reminder: a recent patch intended to fix the long-standing hotplug storm bugs in i915 instead made it a good deal worse -- I now get hotplug interrupts constantly as long as anything (plymouth or Xorg, for example) is query