Re: [PATCH] drm/vc4: tests: Fix UAF in the mock helpers

2023-10-26 Thread Anders Roxell
oses: > > https://lore.kernel.org/all/ca+g9fyvja2hgqzr9lggq63v0skauejhae6f7+z9cwwn-our...@mail.gmail.com/ > > Reported-by: Linux Kernel Functional Testing > > Signed-off-by: Maxime Ripard > > Reviewed-by: Maíra Canal Tested-by: Anders Roxell I tested this patch ontop o

Re: [PATCH v2] drm/amd/display: fix DSC related non-x86/PPC64 compilation issue

2022-08-11 Thread Anders Roxell
defined! > ERROR: modpost: "dc_dsc_compute_bandwidth_range" > [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! > > Fixes: 0087990a9f57 ("drm/amd/display: consider DSC pass-through during mode > validation") > Reported-by: Anders Roxell > Signed-off-by: Hamza Mahfooz Thank

Re: [PATCH v2 2/3] drm/amd/display: consider DSC pass-through during mode validation

2022-08-11 Thread Anders Roxell
On 2022-08-05 17:13, Hamza Mahfooz wrote: > Add a mode validation routine for DSC pass-through. Both the link from > source to hub, and the link from hub to monitor are checked, according > to the current link training result and full pbn returned by enum path > resource sideband message. > > Pi

[PATCH v3 2/2] drm/msm/gpu: Cancel idle/boost work on suspend

2022-02-17 Thread Anders Roxell
/2:2 Not tainted 5.17.0-rc1 #1 [ 17.328796] Hardware name: Qualcomm Technologies, Inc. APQ 8016 SBC (DT) [ 17.335137] Workqueue: pm pm_runtime_work [ 17.341979] pstate: 6005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 17.345896] pc : hrtimer_active+0x14/0x80 [ 17.352652] lr : hrtimer

[PATCH] drm/dp-mst: remove unused variable

2019-10-14 Thread Anders Roxell
d-variable] struct drm_device *dev = mgr->dev; ^~~ Rework to remove the unused variable. Fixes: 83fa9842afe7 ("drm/dp-mst: Drop connection_mutex check") Signed-off-by: Anders Roxell --- drivers/gpu/drm/drm_dp_mst_topology.c | 2 -- 1 file changed, 2 deletions(-) d

[PATCH] drm/mediatek: fix implicit function declaration

2019-08-25 Thread Anders Roxell
;, because that is the (only) header file containing that declaration. Fixes: 07098e82 ("drm/mediatek: set DMA max segment size") Signed-off-by: Anders Roxell --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_

[PATCH v2] drm: mali-dp: Mark expected switch fall-through

2019-07-31 Thread Anders Roxell
bout fall-through. Cc: sta...@vger.kernel.org # v5.2+ Fixes: b8207562abdd ("drm/arm/malidp: Specified the rotation memory requirements for AFBC YUV formats") Acked-by: Liviu Dudau Signed-off-by: Anders Roxell --- drivers/gpu/drm/arm/malidp_hw.c | 3 ++- 1 file changed, 2 insertions(+)

[PATCH v2] video: fbdev: Mark expected switch fall-through

2019-07-30 Thread Anders Roxell
Signed-off-by: Anders Roxell --- drivers/video/fbdev/sh_mobile_lcdcfb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c index ac0bcac9a865..c249763dbf0b 100644 --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c +++ b/d

[PATCH 3/3] drm: msm: a3xx: Mark expected switch fall-through

2019-07-29 Thread Anders Roxell
(priv->lastctx == ctx) ^ ../drivers/gpu/drm/msm/adreno/adreno_gpu.c:431:3: note: here case MSM_SUBMIT_CMD_BUF: ^~~~ Rework so that the compiler doesn't warn about fall-through. Fixes: d93512ef0f0e ("Makefile: Globally enable fall-through warning") Signed-off

[PATCH] drm: mali-dp: Mark expected switch fall-through

2019-07-29 Thread Anders Roxell
break;' in a case that didn't have it so that the compiler doesn't warn about fall-through. Cc: sta...@vger.kernel.org # v4.9+ Fixes: b8207562abdd ("drm/arm/malidp: Specified the rotation memory requirements for AFBC YUV formats") Signed-off-by: Anders Roxell --- drivers/

[PATCH 2/3] drm: msm: a5xx: Mark expected switch fall-through

2019-07-29 Thread Anders Roxell
->lastctx == ctx) ^ ../drivers/gpu/drm/msm/adreno/a5xx_gpu.c:152:3: note: here case MSM_SUBMIT_CMD_BUF: ^~~~ Rework so that the compiler doesn't warn about fall-through. Fixes: d93512ef0f0e ("Makefile: Globally enable fall-through warning") Signed-off-by: Anders Roxell

[PATCH 1/3] drm: msm: a6xx: Mark expected switch fall-through

2019-07-29 Thread Anders Roxell
->lastctx == ctx) ^ ../drivers/gpu/drm/msm/adreno/a6xx_gpu.c:118:3: note: here case MSM_SUBMIT_CMD_BUF: ^~~~ Rework so that the compiler doesn't warn about fall-through. Fixes: d93512ef0f0e ("Makefile: Globally enable fall-through warning") Signed-off-by: Anders Roxell

[PATCH 2/2] drm: sun4i: tcon: Mark expected switch fall-through

2019-07-26 Thread Anders Roxell
=] val |= SUN4I_TCON0_FRM_CTL_MODE_B; ../drivers/gpu/drm/sun4i/sun4i_tcon.c:317:2: note: here case MEDIA_BUS_FMT_RGB666_1X18: ^~~~ Rework so that the compiler doesn't warn about fall-through. Fixes: d93512ef0f0e ("Makefile: Globally enable fall-through warning") Signed-off-by

[PATCH] video: fbdev: Mark expected switch fall-through

2019-07-26 Thread Anders Roxell
93512ef0f0e ("Makefile: Globally enable fall-through warning") Signed-off-by: Anders Roxell --- drivers/video/fbdev/sh_mobile_lcdcfb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c index ac0bcac9a865

[PATCH 1/2] drm: sun4i: sun6i_mipi_dsi: Mark expected switch fall-through

2019-07-26 Thread Anders Roxell
lly enable fall-through warning") Signed-off-by: Anders Roxell --- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c index 472f73985deb..40ed21e527f9

Re: [PATCH 5/8] drivers: media: coda: fix warning same module names

2019-06-11 Thread Anders Roxell
On Tue, 11 Jun 2019 at 18:18, Ezequiel Garcia wrote: > > > > On Tue, Jun 11, 2019, 1:01 PM Anders Roxell wrote: >> >> On Tue, 11 Jun 2019 at 10:21, Hans Verkuil wrote: >> > >> > On 6/11/19 10:15 AM, Philipp Zabel wrote: >> > > Hi, >>

Re: [PATCH 5/8] drivers: media: coda: fix warning same module names

2019-06-11 Thread Anders Roxell
On Tue, 11 Jun 2019 at 10:21, Hans Verkuil wrote: > > On 6/11/19 10:15 AM, Philipp Zabel wrote: > > Hi, > > > > On Mon, 2019-06-10 at 13:14 +, Matt Redfearn wrote: > >> > >> On 10/06/2019 14:03, Anders Roxell wrote: > >>> On Thu, 6 Jun 20

Re: [PATCH 5/8] drivers: media: coda: fix warning same module names

2019-06-10 Thread Anders Roxell
On Thu, 6 Jun 2019 at 12:13, Hans Verkuil wrote: > > On 6/6/19 11:47 AM, Anders Roxell wrote: > > When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as > > loadable modules, we see the following warning: > > > > warning: same module names found: >

Re: [PATCH 8/8] drivers: regulator: 88pm800: fix warning same module names

2019-06-10 Thread Anders Roxell
On Thu, 6 Jun 2019 at 13:00, Mark Brown wrote: > > On Thu, Jun 06, 2019 at 11:47:36AM +0200, Anders Roxell wrote: > > > obj-$(CONFIG_REGULATOR_88PG86X) += 88pg86x.o > > -obj-$(CONFIG_REGULATOR_88PM800) += 88pm800.o > > +obj-$(CONFIG_REGULATOR_88PM800) += 88pm8

Re: [PATCH 0/8] fix warnings for same module names

2019-06-10 Thread Anders Roxell
On Thu, 6 Jun 2019 at 12:11, Mauro Carvalho Chehab wrote: > > Em Thu, 6 Jun 2019 11:46:57 +0200 > Anders Roxell escreveu: > > > Hi, > > > > This patch set addresses warnings that module names are named the > > same, this may lead to a problem that wrong mod

[PATCH 1/8] drivers: net: dsa: realtek: fix warning same module names

2019-06-06 Thread Anders Roxell
When building with CONFIG_NET_DSA_REALTEK_SMI and CONFIG_REALTEK_PHY enabled as loadable modules, we see the following warning: warning: same module names found: drivers/net/phy/realtek.ko drivers/net/dsa/realtek.ko Rework so the names matches the config fragment. Signed-off-by: Anders

[PATCH 4/8] drivers: media: i2c: fix warning same module names

2019-06-06 Thread Anders Roxell
-by: Anders Roxell --- This is only one issue that have been addressed. The other issue is that itseems to refer to the same device name in i2c_device_id, any guidance how that should be solved? Cheers, Anders drivers/gpu/drm/bridge/adv7511/Makefile | 10 +- drivers/media/i2c/Makefile

[PATCH 5/8] drivers: media: coda: fix warning same module names

2019-06-06 Thread Anders Roxell
known module. Signed-off-by: Anders Roxell --- drivers/media/platform/coda/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile index 54e9a73a92ab..588e6bf7c190 100644 --- a/drivers/media

[PATCH 3/8] drivers: (video|gpu): fix warning same module names

2019-06-06 Thread Anders Roxell
When building with CONFIG_DRM_MXSFB and CONFIG_FB_MXS enabled as loadable modules, we see the following warning: warning: same module names found: drivers/video/fbdev/mxsfb.ko drivers/gpu/drm/mxsfb/mxsfb.ko Rework so the names matches the config fragment. Signed-off-by: Anders Roxell

[PATCH 7/8] drivers: mfd: 88pm800: fix warning same module names

2019-06-06 Thread Anders Roxell
When building with CONFIG_MFD_88PM800 and CONFIG_REGULATOR_88PM800 enabled as loadable modules, we see the following warning: warning: same module names found: drivers/regulator/88pm800.ko drivers/mfd/88pm800.ko Rework so the names matches the config fragment. Signed-off-by: Anders Roxell

[PATCH 8/8] drivers: regulator: 88pm800: fix warning same module names

2019-06-06 Thread Anders Roxell
When building with CONFIG_MFD_88PM800 and CONFIG_REGULATOR_88PM800 enabled as loadable modules, we see the following warning: warning: same module names found: drivers/regulator/88pm800.ko drivers/mfd/88pm800.ko Rework to rename the name. Signed-off-by: Anders Roxell --- drivers/regulator

[PATCH 6/8] drivers: net: phy: fix warning same module names

2019-06-06 Thread Anders Roxell
since thats a well known module. Signed-off-by: Anders Roxell --- drivers/net/phy/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/Makefile b/drivers/net/phy/Makefile index 947c974bc69e..bab179b75a2a 100644 --- a/drivers/net/phy/Makefile +++ b/drivers

[PATCH 0/8] fix warnings for same module names

2019-06-06 Thread Anders Roxell
rivers: mfd: 88pm800: fix warning same module names" and "drivers: regulator: 88pm800: fix warning same module names" resolves the name clatch 88pm800.ko. warning: same module names found: drivers/regulator/88pm800.ko drivers/mfd/88pm800.ko Cheers, Anders Anders Roxell (8): driver

[PATCH] drm/tegra: vic: fix implicit function declaration warning

2019-02-18 Thread Anders Roxell
spec->ids[0] & 0x; ^~ Rework so that its inside a '#ifdef CONFIG_IOMMU_API' block. Fixes: f3779cb190a5 ("drm/tegra: vic: Support stream ID register programming") Signed-off-by: Anders Roxell --- drivers/gpu/drm/tegra/vic.c | 2 ++ 1 file chang

[PATCH] fbdev: omap2: fix warnings in dss core

2019-02-14 Thread Anders Roxell via dri-devel
ariable ‘r’ [-Wunused-variable] int r; ^ Rework so function dss_debugfs_create_file() that is declared to return void don't 'return 0' and remove the declaration of the unused variable 'r'. Signed-off-by: Anders Roxell --- drivers/video/fbdev/omap2/omapfb/ds

[PATCH] drm/msm: avoid unused function warning

2019-01-11 Thread Anders Roxell
From: Arnd Bergmann drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:368:13: error: 'dpu_plane_danger_signal_ctrl' defined but not used [-Werror=unused-function] Fixes: 7b2e7adea732 ("drm/msm/dpu: Make dpu_plane_danger_signal_ctrl void") Signed-off-by: Arnd Bergmann Signed-o

[PATCH] drm/sun4i: tcon: fix false-positive uninitialized build warning

2018-12-02 Thread Anders Roxell
-uninitialized] bool has_lvds_rst, has_lvds_alt, can_lvds; ^~~~ Reworked the code so it covers that false positive also. Co-developed-by: Arnd Bergmann Signed-off-by: Arnd Bergmann Signed-off-by: Anders Roxell --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 18

[PATCH] drm/msm/gpu: fix parameters in function msm_gpu_crashstate_capture

2018-08-02 Thread Anders Roxell
lared here static void msm_gpu_crashstate_capture(struct msm_gpu *gpu, char *comm, In current code the function msm_gpu_crashstate_capture parameters. Fixes: cdb95931dea3 ("drm/msm/gpu: Add the buffer objects from the submit to the crash dump") Signed-off-by: Anders Roxell ---

[PATCH] drm/bridge: cdns-dsi: mark PM functions as __maybe_unused

2018-05-05 Thread Anders Roxell
river") Signed-off-by: Anders Roxell --- drivers/gpu/drm/bridge/cdns-dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c b/drivers/gpu/drm/bridge/cdns-dsi.c index c255fc3e1be5..f2d43f24acfb 100644 --- a/drivers/gpu/drm/bridge/cdns-d

[PATCH] drivers: omap2: Kconfig: make FB_OMAP2_DSS_INIT depend on OF

2018-04-21 Thread Anders Roxell
ed make[6]: *** [drivers/video/fbdev/omap2/omapfb/dss] Error 2 make[6]: *** Waiting for unfinished jobs Add OF dependency in order to make all configurations work again. of_update_property() has no inline stub, and that that could be added as an alternative. Signed-off-by: Anders Roxell --- dri

Re: [PATCH] gpu/drm/amd/amdkfd: fix build, select MMU_NOTIFIER

2018-04-20 Thread Anders Roxell
d/amdkfd/kfd_process.c:534:2: error: implicit > declaration of function 'mmu_notifier_register' > [-Werror=implicit-function-declaration] > > Signed-off-by: Randy Dunlap > Cc: Oded Gabbay > Cc: dri-devel@lists.freedesktop.org Tested-by: Anders Roxell > --- >

Re: [PATCH] amdkfd: always select MMU_NOTIFIER

2018-04-20 Thread Anders Roxell
d/kfd_priv.h:584:22: error: field 'mmu_notifier' >> has incomplete type >> >> This adds the missing 'select MMU_NOTIFIER' line to make it build >> cleanly all the time. >> >> Signed-off-by: Arnd Bergmann > > > Acked-by: Christian Köni