Re: [PATCH v2 2/5] drm: adp: Add Apple Display Pipe driver

2024-11-26 Thread Alyssa Ross
On Tue, Nov 26, 2024 at 05:34:21PM +0100, Sasha Finkelstein via B4 Relay wrote: > +module_platform_driver(adp_mipi_platform_driver); This is part of the same driver as adp_drv.c, so I don't think there's supposed to be another module_platform_driver() call here? /nix/store/hni09p7jhc8szjr2h5j5m0l

Re: [PATCH 2/5] gpu: drm: adp: Add Apple Display Pipe driver

2024-11-25 Thread Alyssa Ross
This still has the bug that I originally reported at: https://github.com/AsahiLinux/linux/issues/258 On Sun, Nov 24, 2024 at 11:29:25PM +0100, Sasha Finkelstein via B4 Relay wrote: > +static int adp_probe(struct platform_device *pdev) > +{ > + struct adp_drv_private *adp; > + int err; > +

Re: [PATCH v3] drm/atomic-helpers: Invoke end_fb_access while owning plane state

2023-12-03 Thread Alyssa Ross
c_helper_unprepare_planes() for rolling back > * use correct state for end_fb_access > v2: > * fix test in drm_atomic_helper_cleanup_planes() > > Reported-by: Alyssa Ross > Closes: https://lore.kernel.org/dri-devel/87leazm0ya@alyssa.is/ > Suggested-by: Daniel Vetter > Fixes: 9

Re: [PATCH v2] drm/atomic-helpers: Invoke end_fb_access while owning plane state

2023-11-29 Thread Alyssa Ross
Thomas Zimmermann writes: > Hi > > Am 27.11.23 um 17:25 schrieb Alyssa Ross: >> Thomas Zimmermann writes: >> >>> Invoke drm_plane_helper_funcs.end_fb_access before >>> drm_atomic_helper_commit_hw_done(). The latter function hands over >>> owne

Re: [PATCH v2] drm/atomic-helpers: Invoke end_fb_access while owning plane state

2023-11-27 Thread Alyssa Ross
rk+0x14/0x20 > > For aborted commits, it is still ok to run end_fb_access as part of the > plane's cleanup. Add a test to drm_atomic_helper_cleanup_planes(). > > v2: > * fix test in drm_atomic_helper_cleanup_planes() > > Reported-by: Alyssa Ross > Closes: https:/

Re: [PATCH] drm/atomic-helpers: Invoke end_fb_access while owning plane state

2023-11-26 Thread Alyssa Ross
rk+0x14/0x20 > > For aborted commits, it is still ok to run end_fb_access as part of the > plane's cleanup. Add a test to drm_atomic_helper_cleanup_planes(). > > Reported-by: Alyssa Ross > Closes: https://lore.kernel.org/dri-devel/87leazm0ya@alyssa.is/ > Suggested-by: Daniel

Use after free with GEM shadow-buffered planes

2023-11-16 Thread Alyssa Ross
[Originally reported at https://gitlab.freedesktop.org/drm/misc/-/issues/33] The following happens in a cycle: • An atomic state is allocated • A plane state is allocated (drm_gem_duplicate_shadow_plane_state()) • Commit (drm_atomic_helper_commit(), possibly nonblocking / asynchronously) • Th