Re: [PATCH v3 1/2] pm: runtime: Simplify pm_runtime_get_if_active() usage

2024-01-26 Thread Alex Elder
main implementation is renamed as pm_runtime_get_conditional(). Signed-off-by: Sakari Ailus Reviewed-by: Alex Elder # drivers/net/ipa/ipa_smp2p.c I actually intended my "Reviewed-by" to cover the entire patch. I checked every caller and they all lo

Re: [PATCH v5 040/111] pwm: Provide devm_pwmchip_alloc() function

2024-01-26 Thread Alex Elder
On 1/25/24 6:09 AM, Uwe Kleine-König wrote: This function allocates a struct pwm_chip and driver data. Compared to the status quo the split into pwm_chip and driver data is new, otherwise it doesn't change anything relevant (yet). The intention is that after all drivers are switched to use this

Re: [PATCH 03/12] net: ipa: Proactively round up to kmalloc bucket size

2022-09-22 Thread Alex Elder
() hint. Cc: Alex Elder Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: net...@vger.kernel.org Signed-off-by: Kees Cook --- drivers/net/ipa/gsi_trans.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ipa/gsi

Re: [greybus-dev] [PATCH] Kbuild: remove -std=gnu89 from compiler arguments

2022-02-28 Thread Alex Elder
On 2/27/22 5:11 PM, Linus Torvalds wrote: On Sun, Feb 27, 2022 at 3:04 PM Alex Elder wrote: Glancing at the Greybus code, I don't believe there's any reason it needs to shift a negative value. Such warnings could be fixed by making certain variables unsigned, for example. As me

Re: [greybus-dev] [PATCH] Kbuild: remove -std=gnu89 from compiler arguments

2022-02-28 Thread Alex Elder
On 2/27/22 3:52 PM, Arnd Bergmann wrote: From: Arnd Bergmann During a patch discussion, Linus brought up the option of changing the C standard version from gnu89 to gnu99, which allows using variable declaration inside of a for() loop. While the C99, C11 and later standards introduce many other

Re: [PATCH 2/2] [v2] qcom_scm: hide Kconfig symbol

2021-09-28 Thread Alex Elder
| 2 +- drivers/media/platform/Kconfig | 2 +- drivers/mmc/host/Kconfig| 2 +- drivers/net/ipa/Kconfig | 1 + For drivers/net/ipa/Kconfig, looks good to me. Nice simplification. Acked-by: Alex Elder drivers/net/wireless/ath/ath10k/Kconfig | 2

Re: [PATCH v3 1/1] kernel.h: Split out panic and oops helpers

2021-05-11 Thread Alex Elder
tell me how you want me to do. Acked-by: Alex Elder . . . diff --git a/drivers/net/ipa/ipa_smp2p.c b/drivers/net/ipa/ipa_smp2p.c index a5f7a79a1923..34b68dc43886 100644 --- a/drivers/net/ipa/ipa_smp2p.c +++ b/drivers/net/ipa/ipa_smp2p.c @@ -8,6 +8,7 @@ #include #include #include +#in

[PATCH v2 2/4] clk: bcm/kona: use DIV_ROUND_CLOSEST_ULL()

2015-03-24 Thread Alex Elder
On 03/24/2015 09:03 AM, Javi Merino wrote: > Now that the kernel provides DIV_ROUND_CLOSEST_ULL(), drop the internal > implementation and use the kernel one. > > Cc: Mike Turquette > Cc: Stephen Boyd > Cc: Alex Elder Acked-by: Alex Elder > Signed-off-by: Javi Merino

[PATCH 4/4] media: cxd2820r: use DIV_ROUND_CLOSEST_ULL()

2015-03-20 Thread Alex Elder
On 03/20/2015 12:27 PM, Javi Merino wrote: > On Fri, Mar 20, 2015 at 01:51:36PM +0000, Alex Elder wrote: >> On 03/20/2015 06:14 AM, Javi Merino wrote: >>> Now that the kernel provides DIV_ROUND_CLOSEST_ULL(), drop the internal >>> implementation and use the kernel one.

[PATCH 4/4] media: cxd2820r: use DIV_ROUND_CLOSEST_ULL()

2015-03-20 Thread Alex Elder
On 03/20/2015 06:14 AM, Javi Merino wrote: > Now that the kernel provides DIV_ROUND_CLOSEST_ULL(), drop the internal > implementation and use the kernel one. > > Cc: Antti Palosaari > Cc: Mauro Carvalho Chehab > Signed-off-by: Javi Merino > --- > I've only compile-tested it, I don't have the ha

[PATCH 1/4] kernel.h: Implement DIV_ROUND_CLOSEST_ULL

2015-03-20 Thread Alex Elder
On 03/20/2015 06:14 AM, Javi Merino wrote: > We have grown a number of different implementations of > DIV_ROUND_CLOSEST_ULL throughout the kernel. Move the i915 one to > kernel.h so that it can be reused. > > Cc: Daniel Vetter > Cc: Jani Nikula > Cc: David Airlie > Cc: Darrick J. Wong > Cc: G