Re: [PATCH v4 5/5] arm64: dts: qcom: Add Lenovo ThinkBook 16 G7 QOY device tree

2025-05-25 Thread Aleksandrs Vinarskis
On Sun, 25 May 2025 at 15:33, Dmitry Baryshkov wrote: > > On Sat, May 24, 2025 at 07:58:13PM +0200, Aleksandrs Vinarskis wrote: > > On Sat, 24 May 2025 at 17:33, Dmitry Baryshkov > > wrote: > > > > > > On Sat, May 24, 2025 at 01:48:40PM +0200, Jens Glathe vi

Re: [PATCH v4 5/5] arm64: dts: qcom: Add Lenovo ThinkBook 16 G7 QOY device tree

2025-05-24 Thread Aleksandrs Vinarskis
> > > > This work was done without any schematics or non-public knowledge of the > > device. > > So, it is based on the existing x1e device trees, dsdt analysis, using > > HWInfo > > ARM64, and pure guesswork. It has been confirmed, however, that the device &g

[PATCH v5 4/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-05-07 Thread Aleksandrs Vinarskis
LTTPR handling") Tested-by: Jessica Zhang # SA8775P Tested-by: Johan Hovold Tested-by: Rob Clark Tested-by: Stefan Schmidt Signed-off-by: Aleksandrs Vinarskis Reviewed-by: Abel Vesa Reviewed-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_ct

[PATCH v5 2/4] drm/msm/dp: Account for LTTPRs capabilities

2025-05-07 Thread Aleksandrs Vinarskis
Take into account LTTPR capabilities when selecting maximum allowed link rate, number of data lines. Fixes: 72d0af4accd9 ("drm/msm/dp: Add support for LTTPR handling") Reviewed-by: Abel Vesa Reviewed-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov Signed-off-by: Aleksandrs Vinarsk

[PATCH v5 3/4] drm/msm/dp: Prepare for link training per-segment for LTTPRs

2025-05-07 Thread Aleksandrs Vinarskis
Signed-off-by: Aleksandrs Vinarskis Tested-by: Jessica Zhang # SA8775P Tested-by: Johan Hovold Tested-by: Rob Clark --- drivers/gpu/drm/msm/dp/dp_display.c | 17 +++-- drivers/gpu/drm/msm/dp/dp_link.h| 1 + 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH v5 0/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-05-07 Thread Aleksandrs Vinarskis
.136510-1-alex.vinars...@gmail.com/ Changes in v2: - Picked up Abel's R-b tags - Fixed typo as per Abel, fixed readability as per Johan - Updated cover and commit message on mailink issue which appears to be specific to Gnome+Wayland. No problems on Xorg. - Link to v1: https://lore.kern

[PATCH v5 1/4] drm/msm/dp: Fix support of LTTPR initialization

2025-05-07 Thread Aleksandrs Vinarskis
ned-off-by: Aleksandrs Vinarskis Tested-by: Jessica Zhang # SA8775P Tested-by: Johan Hovold Tested-by: Rob Clark --- drivers/gpu/drm/msm/dp/dp_display.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp

Re: [PATCH v4 4/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-05-07 Thread Aleksandrs Vinarskis
On Thu, 8 May 2025 at 00:08, Abhinav Kumar wrote: > > Hi Alex > > > On 5/7/2025 3:01 PM, Aleksandrs Vinarskis wrote: > > On Tue, 6 May 2025 at 01:41, Abhinav Kumar > > wrote: > >> > >> Hi Alex > >> > >> On 5/4/2025 3:06 PM, Aleksan

Re: [PATCH v4 4/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-05-07 Thread Aleksandrs Vinarskis
On Tue, 6 May 2025 at 01:41, Abhinav Kumar wrote: > > Hi Alex > > On 5/4/2025 3:06 PM, Aleksandrs Vinarskis wrote: > > On Sun, 4 May 2025 at 05:02, Abhinav Kumar > > wrote: > >> > >> Hi Alex > >> > >> Thanks for the response. > &

Re: [PATCH v4 4/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-05-05 Thread Aleksandrs Vinarskis
On Mon, 5 May 2025 at 00:06, Aleksandrs Vinarskis wrote: > > On Sun, 4 May 2025 at 05:02, Abhinav Kumar wrote: > > > > Hi Alex > > > > Thanks for the response. > > > > My updates below. I also had one question for Abel below. > > > > Thanks &

Re: [PATCH v4 4/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-05-04 Thread Aleksandrs Vinarskis
On Sun, 4 May 2025 at 05:02, Abhinav Kumar wrote: > > Hi Alex > > Thanks for the response. > > My updates below. I also had one question for Abel below. > > Thanks > > Abhinav > > On 5/1/2025 8:56 AM, Aleksandrs Vinarskis wrote: > > On Thu, 1 Ma

Re: [PATCH v4 4/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-05-01 Thread Aleksandrs Vinarskis
On Thu, 1 May 2025 at 04:11, Abhinav Kumar wrote: > > > > On 4/29/2025 5:09 PM, Aleksandrs Vinarskis wrote: > > DisplayPort requires per-segment link training when LTTPR are switched > > to non-transparent mode, starting with LTTPR closest to the source. > > Onl

[PATCH v4 4/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-29 Thread Aleksandrs Vinarskis
X1E laptops) and via the docking station (at least two LTTPRs). Fixes: 72d0af4accd9 ("drm/msm/dp: Add support for LTTPR handling") Tested-by: Johan Hovold Tested-by: Rob Clark Tested-by: Stefan Schmidt Signed-off-by: Aleksandrs Vinarskis Reviewed-by: Abel Vesa Reviewed-by: Dmitry

[PATCH v4 2/4] drm/msm/dp: Account for LTTPRs capabilities

2025-04-29 Thread Aleksandrs Vinarskis
Take into account LTTPR capabilities when selecting maximum allowed link rate, number of data lines. Fixes: 72d0af4accd9 ("drm/msm/dp: Add support for LTTPR handling") Reviewed-by: Abel Vesa Reviewed-by: Dmitry Baryshkov Signed-off-by: Aleksandrs Vinarskis Tested-by: Johan Hovold

[PATCH v4 3/4] drm/msm/dp: Prepare for link training per-segment for LTTPRs

2025-04-29 Thread Aleksandrs Vinarskis
Per-segment link training requires knowing the number of LTTPRs (if any) present. Store the count during LTTPRs' initialization. Fixes: 72d0af4accd9 ("drm/msm/dp: Add support for LTTPR handling") Reviewed-by: Abel Vesa Reviewed-by: Dmitry Baryshkov Signed-off-by: Aleksandrs Vi

[PATCH v4 1/4] drm/msm/dp: Fix support of LTTPR initialization

2025-04-29 Thread Aleksandrs Vinarskis
Initialize LTTPR before msm_dp_panel_read_sink_caps, as DPTX shall (re)read DPRX caps after LTTPR detection, as required by DP 2.1, Section 3.6.7.6.1. Fixes: 72d0af4accd9 ("drm/msm/dp: Add support for LTTPR handling") Reviewed-by: Dmitry Baryshkov Signed-off-by: Aleksandrs Vinarskis

[PATCH v4 0/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-29 Thread Aleksandrs Vinarskis
ms on Xorg. - Link to v1: https://lore.kernel.org/all/20250310211039.29843-1-alex.vinars...@gmail.com/ Aleksandrs Vinarskis (4): drm/msm/dp: Fix support of LTTPR initialization drm/msm/dp: Account for LTTPRs capabilities drm/msm/dp: Prepare for link training per-segment for LTTPRs drm/msm/dp: I

Re: drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-29 Thread Aleksandrs Vinarskis
vold wrote: > > > > > On Mon, Apr 28, 2025 at 11:06:39AM +0200, Aleksandrs Vinarskis wrote: > > > > > > On Mon, 28 Apr 2025 at 09:45, Johan Hovold wrote: > > > > > > > > Does this mean that the incomplete LTTPR support in 6.15-rc1 broke > &

Re: drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-29 Thread Aleksandrs Vinarskis
On Tue, 29 Apr 2025 at 08:52, Abel Vesa wrote: > > On 25-04-28 20:23:45, Aleksandrs Vinarskis wrote: > > On Mon, 28 Apr 2025 at 16:17, Abel Vesa wrote: > > > > > > The change itself makes sense though and I think makes sense to be marked > > > as a fix. &g

Re: drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-28 Thread Aleksandrs Vinarskis
On Mon, 28 Apr 2025 at 16:17, Abel Vesa wrote: > > On 25-04-28 14:47:04, Johan Hovold wrote: > > On Mon, Apr 28, 2025 at 11:06:39AM +0200, Aleksandrs Vinarskis wrote: > > > On Mon, 28 Apr 2025 at 09:45, Johan Hovold wrote: > > > > On Thu, Apr 17, 2025 at 04:10

Re: drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-28 Thread Aleksandrs Vinarskis
On Mon, 28 Apr 2025 at 09:45, Johan Hovold wrote: > > On Thu, Apr 17, 2025 at 04:10:31AM +0200, Aleksandrs Vinarskis wrote: > > Recently added Initial LTTPR support in msm/dp has configured LTTPR(s) > > to non-transparent mode to enable video output on X1E-based devices > &

drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-18 Thread Aleksandrs Vinarskis
that on Gnome+Wayland framerate and resolution parameter adjustment is not stable. Due to lack of access to the official DisplayPort specfication, changes were primarily inspired by/reverse engineered from Intel's i915 driver. [1] https://lore.kernel.org/all/20250226231436.16138-2-alex.vinars.

[PATCH v3 1/4] drm/msm/dp: Fix support of LTTPR initialization

2025-04-18 Thread Aleksandrs Vinarskis
Initialize LTTPR before msm_dp_panel_read_sink_caps, as DPTX shall (re)read DPRX caps after LTTPR detection, as required by DP 2.1, Section 3.6.7.6.1. Signed-off-by: Aleksandrs Vinarskis --- drivers/gpu/drm/msm/dp/dp_display.c | 13 + 1 file changed, 9 insertions(+), 4 deletions

[PATCH v3 3/4] drm/msm/dp: Prepare for link training per-segment for LTTPRs

2025-04-16 Thread Aleksandrs Vinarskis
Per-segment link training requires knowing the number of LTTPRs (if any) present. Store the count during LTTPRs' initialization. Signed-off-by: Aleksandrs Vinarskis --- drivers/gpu/drm/msm/dp/dp_display.c | 17 +++-- drivers/gpu/drm/msm/dp/dp_link.h| 1 + 2 files change

[PATCH v3 2/4] drm/msm/dp: Account for LTTPRs capabilities

2025-04-16 Thread Aleksandrs Vinarskis
Take into account LTTPR capabilities when selecting maximum allowed link rate, number of data lines. Signed-off-by: Aleksandrs Vinarskis --- drivers/gpu/drm/msm/dp/dp_display.c | 5 ++--- drivers/gpu/drm/msm/dp/dp_link.h| 3 +++ drivers/gpu/drm/msm/dp/dp_panel.c | 12 +++- 3

[PATCH v3 4/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-16 Thread Aleksandrs Vinarskis
X1E laptops) and via the docking station (at least two LTTPRs). Tested-by: Stefan Schmidt Signed-off-by: Aleksandrs Vinarskis Reviewed-by: Abel Vesa --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 126 ++- 1 file changed, 89 insertions(+), 37 deletions(-) diff --git a

Re: [PATCH v2 2/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-08 Thread Aleksandrs Vinarskis
On Tue, 1 Apr 2025 at 02:55, Dmitry Baryshkov wrote: > > On Wed, Mar 12, 2025 at 12:38:04AM +0100, Aleksandrs Vinarskis wrote: > > DisplayPort requires per-segment link training when LTTPR are switched > > to non-transparent mode, starting with LTTPR closest to the source.

Re: [PATCH v2 0/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-03-15 Thread Aleksandrs Vinarskis
On 3/12/25 22:16, Stefan Schmidt wrote: Hello Aleksandrs, On Wed, 12 Mar 2025 at 00:41, Aleksandrs Vinarskis wrote: Recently added Initial LTTPR support in msm/dp has configured LTTPR(s) to non-transparent mode to enable video output on X1E-based devices that come with LTTPR on the

[PATCH v2 2/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-03-11 Thread Aleksandrs Vinarskis
X1E laptops) and via the docking station (at least two LTTPRs). Signed-off-by: Aleksandrs Vinarskis Reviewed-by: Abel Vesa --- drivers/gpu/drm/msm/dp/dp_ctrl.c| 137 +++- drivers/gpu/drm/msm/dp/dp_ctrl.h| 2 +- drivers/gpu/drm/msm/dp/dp_display.c | 4 +- 3

[PATCH v2 1/2] drm/msm/dp: Fix support of LTTPR handling

2025-03-11 Thread Aleksandrs Vinarskis
eturn lttpr_count to prepare for per-segment link training. Signed-off-by: Aleksandrs Vinarskis Reviewed-by: Abel Vesa --- drivers/gpu/drm/msm/dp/dp_display.c | 29 +++- drivers/gpu/drm/msm/dp/dp_panel.c | 30 - drivers/gpu/drm/msm/dp/dp_pa

[PATCH v2 0/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-03-11 Thread Aleksandrs Vinarskis
alex.vinars...@gmail.com/ Signed-off-by: Aleksandrs Vinarskis --- Changes in v2: - Picked up Abel's R-b tags - Fixed typo as per Abel, fixed readability as per Johan - Updated cover and commit message on mailink issue which appears to be specific to Gnome+Wayland. No problems on Xor

[PATCH v1 2/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-03-10 Thread Aleksandrs Vinarskis
most X1E laptops) and via the docking station (at least two LTTPRs). This does not address/resolve underlying mainlink initialization issues. Signed-off-by: Aleksandrs Vinarskis --- drivers/gpu/drm/msm/dp/dp_ctrl.c| 136 +++- drivers/gpu/drm/msm/dp/dp_ctrl.h| 2

[PATCH v1 1/2] drm/msm/dp: Fix support of LTTPR handling

2025-03-10 Thread Aleksandrs Vinarskis
eturn lttpr_count to prepare for per-segment link training. Signed-off-by: Aleksandrs Vinarskis --- drivers/gpu/drm/msm/dp/dp_display.c | 31 +++-- drivers/gpu/drm/msm/dp/dp_panel.c | 30 +++- drivers/gpu/drm/msm/dp/dp_panel.h | 2 ++ 3 files ch

[PATCH v1 0/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-03-10 Thread Aleksandrs Vinarskis
driver. [1] https://lore.kernel.org/all/20250226231436.16138-2-alex.vinars...@gmail.com/ Aleksandrs Vinarskis (2): drm/msm/dp: Fix support of LTTPR handling drm/msm/dp: Introduce link training per-segment for LTTPRs drivers/gpu/drm/msm/dp/dp_ctrl.c| 136 +++- drivers/gpu/d

Re: [PATCH v1 1/1] drm/edp-panel: Add panels used by Dell XPS 13 9345

2024-10-08 Thread Aleksandrs Vinarskis
On Tue, 8 Oct 2024 at 01:04, Doug Anderson wrote: > > Hi, > > On Mon, Oct 7, 2024 at 1:14 PM Aleksandrs Vinarskis > wrote: > > > > Introduce low-res IPS and OLED panels for mentioned device. > > > > SHP panel's timings were picked experimentally, witho

[PATCH v1 1/1] drm/edp-panel: Add panels used by Dell XPS 13 9345

2024-10-08 Thread Aleksandrs Vinarskis
be working. Particular laptop also comes in high-res IPS variant, which unfortunately I do not have access to verify. Signed-off-by: Aleksandrs Vinarskis Tested-by: Peter de Kraker --- drivers/gpu/drm/panel/panel-edp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/pane

[PATCH v2 1/1] drm/edp-panel: Add panels used by Dell XPS 13 9345

2024-10-08 Thread Aleksandrs Vinarskis
0 23 78 26 00 09 04 00 00 00 00 00 41 00 00 22 00 14 55 27 05 85 3f 0b 9f 00 2f 80 1f 00 07 07 33 00 02 00 05 00 25 01 09 55 27 05 55 27 05 3c 3c 00 81 00 0b e3 05 80 00 e6 06 05 01 6d 60 02 00 00 00 00 00 00 31 90 Signed-off-by: Aleksandrs Vinarskis --- drivers/gpu/drm/panel/panel-edp.c | 2