to respect "xe_hw_engine" namespace (Rodrigo)
Signed-off-by: Alan Previn
Reviewed-by: Zhanjun Dong
---
drivers/gpu/drm/xe/xe_devcoredump.c | 2 +-
drivers/gpu/drm/xe/xe_guc_capture.c | 30 ---
drivers/gpu/drm/xe/xe_guc_capture.h | 1 -
drivers/gpu/drm/xe/x
manual
captures that were attached to a job vs late, raw jobless ones.
v8:- Rename the enum xe_guc_capture_snapshot_source to
xe_engine_capture_source to match the defines
(Matthew Brost/John Harrison).
- Minor patch header comment improvement. (Alan Previn)
v7:- Fix mis
node's register list.
v7: - Fix function name to respect "xe_hw_engine" name space. (Rodrigo)
- Remove additional newline in engine dump (Jose Souza) +
ensure changes didn't break mesa's aubinator tool (Rodrigo)
Signed-off-by: Alan Previn
Update the comments on GuC-Err-Capture flows with the
updated function names.
Signed-off-by: Alan Previn
Reviewed-by: Zhanjun Dong
---
drivers/gpu/drm/xe/xe_guc_capture.c | 42 -
1 file changed, 29 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/xe
ensures 'xe_devcoredump_snapshot' owns
'xe_hw_engine_snapshot generation' and the latter owns
'xe_guc_capture_snapshot' retrieval (with GuC-Error-Capture
as its helper).
Alan Previn (6):
drm/xe/guc: Rename __guc_capture_parsed_output
drm/xe/guc: Don't store cap
yright header fix in xe_guc_capture_snapshot_types.h
(Rodrigo)
Signed-off-by: Alan Previn
Reviewed-by: Rodrigo Vivi
Reviewed-by: Zhanjun Dong
---
drivers/gpu/drm/xe/xe_devcoredump_types.h | 2 +-
drivers/gpu/drm/xe/xe_guc_capture.c | 83 ++-
drivers/gpu/drm/xe/xe_guc_capt
anual-sourced capture node is found during xe_hw_engine printing
because this can be valid in some code-paths such as for
gt-reset events. (John Harrison)
Signed-off-by: Alan Previn
---
drivers/gpu/drm/xe/xe_devcoredump.c | 3 -
drivers/gpu/drm/xe/xe_devcoredump_types.h
alan: I will respin this rev with the changes mentiond below - thanks Zhanjun
for the time in reviewing this. :)
On Mon, 2025-02-10 at 18:41 -0500, Dong, Zhanjun wrote:
> See my comments inline below.
>
> Regards,
> Zhanjun Dong
>
> On 2025-01-28 1:36 p.m., Alan Previn
On Tue, 2025-02-11 at 18:09 -0500, Dong, Zhanjun wrote:
>
> >
alan:snip
> > *
> > - * User Sysfs / Debugfs
> > - *
> > - * --> xe_devcoredump_read->
> > + * User Devcoredump Sysfs
> > + * --
> > + * --> xe_devcoredump_read-> (user cats devcore
On Tue, 2025-02-11 at 17:48 -0500, Dong, Zhanjun wrote:
>
>
> On 2025-02-10 6:32 p.m., Alan Previn wrote:
> > Relocate the xe_engine_snapshot_print function from xe_guc_capture.c
> > into xe_hw_engine.c but split out the GuC-Err-Capture register printing
> > portion
On Wed, 2025-02-12 at 17:48 +0530, Tejas Upadhyay wrote:
> Allow user to provide a low latency hint. When set, KMD sends a hint
> to GuC which results in special handling for that process. SLPC will
> ramp the GT frequency aggressively every time it switches to this
> process.
>
> We need to enabl
On Mon, 2025-02-10 at 15:32 -0800, Teres Alexis, Alan Previn wrote:
> xe_hw_engine_print is called by debugfs to do an immediate raw
> --- a/drivers/gpu/drm/xe/xe_guc_capture_snapshot_types.h
> +++ b/drivers/gpu/drm/xe/xe_guc_capture_snapshot_types.h
> @@ -12,7 +12,11 @@
> stru
to respect "xe_hw_engine" namespace (Rodrigo)
Signed-off-by: Alan Previn
---
drivers/gpu/drm/xe/xe_devcoredump.c | 2 +-
drivers/gpu/drm/xe/xe_guc_capture.c | 30 ---
drivers/gpu/drm/xe/xe_guc_capture.h | 1 -
drivers/gpu/drm/xe/xe_hw_engine.c | 38 ++
ensures 'xe_devcoredump_snapshot' owns
'xe_hw_engine_snapshot generation' and the latter owns
'xe_guc_capture_snapshot' retrieval (with GuC-Error-Capture
as its helper).
Alan Previn (6):
drm/xe/guc: Rename __guc_capture_parsed_output
drm/xe/guc: Don't store cap
bless.
v7:- Fix mismatch func name vs comment (kernel robot)
- Differentiate between early manual captures that have a
job association vs raw manual captures that may not have
a job association like in gt-reset events. (John Harrison).
Signed-off-by: Alan Previn
---
driver
node's register list.
v7: - Fix function name to respect "xe_hw_engine" name space. (Rodrigo)
- Remove additional newline in engine dump (Jose Souza) +
ensure changes didn't break mesa's aubinator tool (Rodrigo)
Signed-off-by: Alan Previn
Update the comments on GuC-Err-Capture flows with the
updated function names.
Signed-off-by: Alan Previn
---
drivers/gpu/drm/xe/xe_guc_capture.c | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_guc_capture.c
b/drivers/gpu/drm/xe
igned-off-by: Alan Previn
---
drivers/gpu/drm/xe/xe_devcoredump.c | 3 -
drivers/gpu/drm/xe/xe_devcoredump_types.h | 6 -
drivers/gpu/drm/xe/xe_guc_capture.c | 153 ++
drivers/gpu/drm/xe/xe_guc_capture.h | 9 +-
drivers/gpu/drm/xe/xe_guc_submit.c
yright header fix in xe_guc_capture_snapshot_types.h
(Rodrigo)
Signed-off-by: Alan Previn
Reviewed-by: Rodrigo Vivi
Reviewed-by: Zhanjun Dong
---
drivers/gpu/drm/xe/xe_devcoredump_types.h | 2 +-
drivers/gpu/drm/xe/xe_guc_capture.c | 83 ++-
drivers/gpu/drm/xe/xe_guc_capt
On Fri, 2025-01-31 at 10:55 -0800, Teres Alexis, Alan Previn wrote:
> On Thu, 2025-01-30 at 17:42 -0500, Vivi, Rodrigo wrote:
> > On Tue, Jan 28, 2025 at 10:36:49AM -0800, Alan Previn wrote:
> >
> > >
alan:snip
> > > - if (!snapshot->matched_no
On Thu, 2025-01-30 at 17:42 -0500, Vivi, Rodrigo wrote:
> On Tue, Jan 28, 2025 at 10:36:49AM -0800, Alan Previn wrote:
> > Relocate the xe_engine_snapshot_print function from xe_guc_capture.c
> > into xe_hw_engine.c but split out the GuC-Err-Capture register printing
> &g
On Thu, 2025-01-30 at 17:43 -0500, Vivi, Rodrigo wrote:
> On Tue, Jan 28, 2025 at 10:36:50AM -0800, Alan Previn wrote:
alan:snip
> > @@ -55,8 +55,7 @@ void xe_hw_engine_handle_irq(struct xe_hw_engine *hwe,
> > u16 intr_vec);
> > void xe_hw_engine_enable_ring(struct xe_hw_e
> > +++ b/drivers/gpu/drm/xe/xe_guc_capture_snapshot_types.h
> > @@ -0,0 +1,53 @@
> > +/* SPDX-License-Identifier: MIT */
> > +/*
> > + * Copyright © 2021-2024 Intel Corporation
>
> 2025
>
> then
>
> Reviewed-by: Rodrigo Vivi
>
will do - thanks
On Tue, 2025-01-28 at 10:36 -0800, Teres Alexis, Alan Previn wrote:
> GuC-Err-Capture should not be storing register snapshot
> nodes directly inside of the top level xe_devcoredump_snapshot
> structure that it doesn't control. Furthermore, that is
> is not right from a driver s
Update: new URL with next rev that includes the split ->
https://patchwork.freedesktop.org/series/144050/
basically the same squash but i decided to drop some trivial things like
comments and name of function/variables.
...alan
On Thu, 2025-01-23 at 18:01 +, Teres Alexis, Alan Pre
ister snapshot
within its internal outlist).
Signed-off-by: Alan Previn
---
drivers/gpu/drm/xe/xe_devcoredump.c | 3 -
drivers/gpu/drm/xe/xe_devcoredump_types.h | 6 -
drivers/gpu/drm/xe/xe_guc_capture.c | 153 ++
drivers/gpu/drm/xe/xe_guc_capture.h
xe_devcoredump calls xe_engine_snapshot_capture_for_queue() to allocate
and populate the xe_hw_engine_snapshot structure. Move that function
back into xe_hw_engine.c since it doesn't make sense for
GuC-Err-Capture to allocate a structure it doesn't own.
Signed-off-by: Alan Previn
--
Since '__guc_capture_parsed_output *' is a handle that
is retrieved, stored and relinquished by an entity
external to GuC (i.e. xe_devcoredump), lets rename it to
something formal without the'__' prefix and export it
via give a header file.
Signed-off-by: Alan Previn
---
Update the comments on GuC-Err-Capture flows with the
updated function names.
Signed-off-by: Alan Previn
---
drivers/gpu/drm/xe/xe_guc_capture.c | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_guc_capture.c
b/drivers/gpu/drm/xe
ensures 'xe_devcoredump_snapshot' owns
'xe_hw_engine_snapshot generation' and the latter owns
'xe_guc_capture_snapshot' retrieval (with GuC-Error-Capture
as its helper).
Alan Previn (6):
drm/xe/guc: Rename __guc_capture_parsed_output
drm/xe/guc: Don't store cap
can also invoke GuC-Err-Capture for
an immediate jobless snapshot.
Signed-off-by: Alan Previn
---
drivers/gpu/drm/xe/xe_guc_capture.c | 26 ++
drivers/gpu/drm/xe/xe_guc_capture.h | 2 ++
drivers/gpu/drm/xe/xe_hw_engine.c | 15 +--
3 files changed, 41
node's register list.
Signed-off-by: Alan Previn
---
drivers/gpu/drm/xe/xe_guc_capture.c | 72 +
drivers/gpu/drm/xe/xe_guc_capture.h | 4 +-
drivers/gpu/drm/xe/xe_hw_engine.c | 28 +++
drivers/gpu/drm/xe/xe_hw_engine.h | 1 +
4 files change
On Tue, 2025-01-21 at 18:15 -0500, Vivi, Rodrigo wrote:
> On Tue, Jan 21, 2025 at 11:09:34AM -0800, Alan Previn wrote:
>
>
> A 'series' of 1 patch is not a series. Cover letter is not needed.
>
> However, this patch is the size of a series and it should be
> s
, rearranging the layering
back to what its should be (xe_devcoredump_snapshot owns
xe_hw_engine_snapshot owns xe_guc_capture_snapshot)..
Alan Previn (1):
drm/xe/guc/capture: Maintenence of devcoredump <-> GuC-Err-Capture
plumbing
drivers/gpu/drm/xe/xe_devcoredump.c | 3 -
d
ting manual capture (CI-test)
v2: Bail on manual capture when running on a VF (Zhanjun)
Signed-off-by: Alan Previn
Reviewed-by: Zhanjun Dong
---
drivers/gpu/drm/xe/xe_devcoredump.c | 3 -
drivers/gpu/drm/xe/xe_devcoredump_types.h | 6 -
drivers/gpu/drm/xe/xe_guc_capture.c
-test)
v1 -> v2:
- Bail on manual capture when running on a VF (Zhanjun)
Signed-off-by: Alan Previn
---
drivers/gpu/drm/xe/xe_devcoredump.c | 3 -
drivers/gpu/drm/xe/xe_devcoredump_types.h | 6 -
drivers/gpu/drm/xe/xe_guc_capture.c | 406 -
, rearranging the layering
back to what its should be (xe_devcoredump_snapshot owns
xe_hw_engine_snapshot owns xe_guc_capture_snapshot)..
Alan Previn (1):
drm/xe/guc/capture: Maintenence of devcoredump <-> GuC-Err-Capture
plumbing
drivers/gpu/drm/xe/xe_devcoredump.c | 3 -
d
e header) for xe_hw_engine_snapshot to use.
6. Since xe_hw_engine_snapshot can also be called by via debugfs
without a job, create a new function that does a manual capture
of engine registers without any associated job.
v1 -> v2:
- Bail on manual capture when running on a VF (Zhanju
, rearranging the layering
back to what its should be (xe_devcoredump_snapshot owns
xe_hw_engine_snapshot owns xe_guc_capture_snapshot)..
Alan Previn (1):
drm/xe/guc/capture: Maintenence of devcoredump <-> GuC-Err-Capture
plumbing
drivers/gpu/drm/xe/xe_devcoredump.c | 3 -
d
On Tue, 2024-11-26 at 12:09 -0500, Dong, Zhanjun wrote:
> See my comments inline below:
>
> Regards,
> Zhanjun
>
> On 2024-11-17 1:44 p.m., Alan Previn wrote:
> > The order of the devcoredump event flow is:
> > drm-scheduler -> guc-submission-execq-timed-out-j
e header) for xe_hw_engine_snapshot to use.
6. Since xe_hw_engine_snapshot can also be called by via debugfs
without a job, create a new function that does a manual capture
of engine registers without any associated job.
Signed-off-by: Alan Previn
---
drivers/gpu/drm/xe/xe_devcoredump.c
, rearranging the layering
back to what its should be (xe_devcoredump_snapshot owns
xe_hw_engine_snapshot owns xe_guc_capture_snapshot)..
Alan Previn (1):
drm/xe/guc/capture: Maintenence of devcoredump <-> GuC-Err-Capture
plumbing
drivers/gpu/drm/xe/xe_devcoredump.c | 3 -
d
Just some minor nits on header. Otherwise, LGTM:
Reviewed-by: Alan Previn
On Wed, 2024-10-30 at 15:38 -0700, Zhanjun Dong wrote:
> GuC to host communication is interrupt driven, the handling has 3
> parts: interrupt context, tasklet and request queue worker.
> During GuC rese
ude IP_VER 12.71. (Matt Roper)
v3: - Check targeted platforms using IP_VAL. (John Harrison)
v2: - Fix WA id number (John Harrison).
- Improve comments and code to be specific
for the targeted platforms (John Harrison)
Signed-off-by: Alan Previn
---
drivers/gpu/drm/i915/gt/intel
LGTM:
Reviewed-by: Alan Previn
On Fri, 2024-09-06 at 10:40 -0700, john.c.harri...@intel.com wrote:
> From: Juston Li
>
> This feature flag enables GuC autoteardown which allows for a grace
> period before session teardown.
>
> Also add a HAS_PXP() helper to share with th
When calling xe_bo_create_pin_map_at, use the correct
starting offset provided by caller at xe_ggtt_insert_bo_at.
Fixes: 44e694958b95 ("drm/xe/display: Implement display support")
Signed-off-by: Alan Previn
---
drivers/gpu/drm/xe/xe_bo.c | 2 +-
1 file changed, 1 insertion(+),
When calling xe_bo_create_pin_map_at, use the correct
starting offset provided by caller at xe_ggtt_insert_bo_at.
Fixes: 44e694958b95 ("drm/xe/display: Implement display support")
Signed-off-by: Alan Previn
---
drivers/gpu/drm/xe/xe_bo.c | 2 +-
1 file changed, 1 insertion(+),
" }, \
> { GEN8_RING_PDP_UDW(0, 3), 0, 0, "PDP3_UDW" }
>
> -#define COMMON_BASE_HAS_EU \
> - { EIR, 0, 0, "EIR" }
> -
alan:snip
alan: Thanks for catching this one.
Reviewed-by: Alan Previn
On Wed, 2023-12-27 at 20:55 -0800, Teres Alexis, Alan Previn wrote:
> This series is the result of debugging issues root caused to
> races between the GuC's destroyed_worker_func being triggered
> vs repeating suspend-resume cycles with concurrent delayed
> fence signals f
so
it can get picked up on the next destroy worker invocation
(if suspend aborted) or get fully purged as part of a GuC
sanitization (end of suspend) or a reset flow.
Signed-off-by: Alan Previn
Signed-off-by: Anshuman Gupta
Tested-by: Mousumi Jana
Acked-by: Daniele Ceraolo Spurio
Reviewed-by
_busy_loop, we need to undo
i.e. decrement the outstanding_submission_g2h.
- Patch #3 In wait_for_suspend, fix checking of return from
intel_gt_pm_wait_timeout_for_idle to now use -ETIMEDOUT
and add documentation for intel_wakeref_wait_for_idle.
(Rodrigo).
Ala
ff-by: Alan Previn
Reviewed-by: Rodrigo Vivi
Tested-by: Mousumi Jana
---
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 5 +
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h | 2 ++
drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 ++
3 files changed, 9 insertions(+)
diff --git a/dr
so
it can get picked up on the next destroy worker invocation
(if suspend aborted) or get fully purged as part of a GuC
sanitization (end of suspend) or a reset flow.
Signed-off-by: Alan Previn
Signed-off-by: Anshuman Gupta
Tested-by: Mousumi Jana
Acked-by: Daniele Ceraolo Spurio
---
dr
On Tue, 2023-12-26 at 10:11 -0500, Vivi, Rodrigo wrote:
> On Wed, Dec 20, 2023 at 11:08:59PM +, Teres Alexis, Alan Previn wrote:
> > On Wed, 2023-12-13 at 16:23 -0500, Vivi, Rodrigo wrote:
alan:snip
> >
> >
> > alan: Thanks Rodrigo for the RB last week, just quick
On Wed, 2023-12-13 at 16:23 -0500, Vivi, Rodrigo wrote:
> On Tue, Dec 12, 2023 at 08:57:16AM -0800, Alan Previn wrote:
> > If we are at the end of suspend or very early in resume
> > its possible an async fence signal (via rcu_call) is triggered
> > to free_engines which
ff-by: Alan Previn
Reviewed-by: Rodrigo Vivi
Tested-by: Mousumi Jana
---
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 5 +
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h | 2 ++
drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 ++
3 files changed, 9 insertions(+)
diff --git a/dr
so
it can get picked up on the next destroy worker invocation
(if suspend aborted) or get fully purged as part of a GuC
sanitization (end of suspend) or a reset flow.
Signed-off-by: Alan Previn
Signed-off-by: Anshuman Gupta
Tested-by: Mousumi Jana
Acked-by: Daniele Ceraolo Spurio
---
dr
nt the outstanding_submission_g2h.
- Patch #3 In wait_for_suspend, fix checking of return from
intel_gt_pm_wait_timeout_for_idle to now use -ETIMEDOUT
and add documentation for intel_wakeref_wait_for_idle.
(Rodrigo).
Alan Previn (2):
drm/i915/guc: Flush context destruc
> As far as i can tell, its only if we started resetting / wedging right after
> this
> queued worker got started.
alan: hope Daniele can proof read my tracing and confirm if got it right.
On Thu, 2023-11-30 at 16:18 -0500, Vivi, Rodrigo wrote:
> On Wed, Nov 29, 2023 at 04:20:13PM -0800, Alan Previn wrote:
alan:snip
> > +
> > if (unlikely(disabled)) {
> > release_guc_id(guc, ce);
> > __guc_context_destroy(
On Wed, 2023-11-29 at 13:13 -0800, Teres Alexis, Alan Previn wrote:
> On Mon, 2023-11-27 at 15:24 -0500, Vivi, Rodrigo wrote:
> > On Wed, Nov 22, 2023 at 12:30:03PM -0800, Alan Previn wrote:
> alan:snip
> alan: thanks for reviewing and apologize for replyi
- Patch #3 In wait_for_suspend, fix checking of return from
intel_gt_pm_wait_timeout_for_idle to now use -ETIMEDOUT
and add documentation for intel_wakeref_wait_for_idle.
(Rodrigo).
Alan Previn (2):
drm/i915/guc: Flush context destruction worker at suspend
drm/i915/guc:
so
it can get picked up on the next destroy worker invocation
(if suspend aborted) or get fully purged as part of a GuC
sanitization (end of suspend) or a reset flow.
Signed-off-by: Alan Previn
Signed-off-by: Anshuman Gupta
Tested-by: Mousumi Jana
---
drivers/gpu/drm/i915/gem/i915_gem_pm.c
ff-by: Alan Previn
Reviewed-by: Rodrigo Vivi
Tested-by: Mousumi Jana
---
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 5 +
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h | 2 ++
drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 ++
3 files changed, 9 insertions(+)
diff --git a/dr
On Mon, 2023-11-27 at 15:24 -0500, Vivi, Rodrigo wrote:
> On Wed, Nov 22, 2023 at 12:30:03PM -0800, Alan Previn wrote:
alan:snip
alan: thanks for reviewing and apologize for replying to this late.
> > /*
> > -* On MTL and newer platforms, protected contexts require setting
On Fri, 2023-11-24 at 08:30 +, Tvrtko Ursulin wrote:
> On 22/11/2023 19:15, Alan Previn wrote:
alan:snip
alan: thanks for reviewing.
> > if (iir & GEN12_DISPLAY_STATE_RESET_COMPLETE_INTERRUPT)
> > - pxp->session_events |= PXP_TERMINATION_COMPLET
On Mon, 2023-11-27 at 16:51 -0500, Vivi, Rodrigo wrote:
alan: Firstly, thanks for taking the time to review this, knowing you have a
lot on your plate right now.
>
alan:snip
> > @@ -3301,19 +3315,38 @@ static inline void guc_lrc_desc_unpin(struct
> > intel_context *ce)
> > /* Seal race with
- Improve comments and code to be specific
for the targeted platforms (John Harrison)
Signed-off-by: Alan Previn
---
drivers/gpu/drm/i915/gt/intel_lrc.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c
b/drivers/gpu/drm/i915/gt/i
On Tue, 2023-11-28 at 10:03 -0800, Roper, Matthew D wrote:
> On Mon, Nov 27, 2023 at 12:11:50PM -0800, Alan Previn wrote:
> > Add missing tag for "Wa_14019159160 - Case 2" (for existing
> > PXP code that ensures run alone mode bit is set to allow
> > PxP-decrypti
for the targeted platforms (John Harrison)
Signed-off-by: Alan Previn
---
drivers/gpu/drm/i915/gt/intel_lrc.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c
b/drivers/gpu/drm/i915/gt/intel_lrc.c
index 7c367ba8d9dc..1152cf25d
Add missing tag for "Wa_14019159160 - Case 2" (for existing
PXP code that ensures run alone mode bit is set to allow
PxP-decryption.
v2: - Fix WA id number (John Harrison).
- Improve comments and code to be specific
for the targetted platforms (John Harrison)
Signed-of
emove __func__ since drm_dbg covers that (Jani).
- add timeout dbg of the restart from front-end (Alan).
Signed-off-by: Alan Previn
Reviewed-by: Vivaik Balasubrawmanian
---
drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c | 2 ++
drivers/gpu/drm/i915/pxp/intel_pxp.c
Add missing tag for "Wa_14019159160 - Case 2" (for existing
PXP code that ensures run alone mode bit is set to allow
PxP-decryption.
Signed-off-by: Alan Previn
---
drivers/gpu/drm/i915/gt/intel_lrc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/d
On Thu, 2023-11-16 at 15:20 -0800, Teres Alexis, Alan Previn wrote:
> For Gen12 when using mei-pxp tee backend tranport, if we are coming
> up from a cold boot or from a resume (not runtime resume), we can
> optionally quicken the very first session cleanup that would occur
> as part
e that to the helper's caller.
Signed-off-by: Alan Previn
---
drivers/gpu/drm/i915/pxp/intel_pxp.c | 1 +
drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c | 3 ++-
drivers/gpu/drm/i915/pxp/intel_pxp_pm.c | 1 +
drivers/gpu/drm/i915/pxp/intel_pxp_session.c | 1 +
driver
On Tue, 2023-11-14 at 08:22 -0800, Teres Alexis, Alan Previn wrote:
> When suspending, add a timeout when calling
> intel_gt_pm_wait_for_idle else if we have a leaked
> wakeref (which would be indicative of a bug elsewhere
> in the driver), driver will at exit the suspend-resume
> c
On Tue, 2023-11-14 at 17:52 +, Tvrtko Ursulin wrote:
> On 14/11/2023 17:37, Teres Alexis, Alan Previn wrote:
> > On Tue, 2023-11-14 at 17:27 +, Tvrtko Ursulin wrote:
> > > On 13/11/2023 17:57, Teres Alexis, Alan Previn wrote:
> > > > On Wed, 2023-10-25 at 13:
On Tue, 2023-11-14 at 12:36 -0500, Vivi, Rodrigo wrote:
> On Tue, Nov 14, 2023 at 05:27:18PM +, Tvrtko Ursulin wrote:
> >
> > On 13/11/2023 17:57, Teres Alexis, Alan Previn wrote:
> > > On Wed, 2023-10-25 at 13:58 +0100, Tvrtko Ursulin wrote:
> > > > On
On Tue, 2023-11-14 at 17:27 +, Tvrtko Ursulin wrote:
> On 13/11/2023 17:57, Teres Alexis, Alan Previn wrote:
> > On Wed, 2023-10-25 at 13:58 +0100, Tvrtko Ursulin wrote:
> > > On 04/10/2023 18:59, Teres Alexis, Alan Previn wrote:
> > > > On Thu, 2023-09-28 at 13:
instead of hanging
in the kernel forever which then requires serial connection
or ramoops dump to debug further.
Signed-off-by: Alan Previn
Reviewed-by: Rodrigo Vivi
Tested-by: Mousumi Jana
---
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +-
drivers/gpu/drm/i915/gt/intel_gt_pm.c | 7
so
it can get picked up on the next destroy worker invocation
(if suspend aborted) or get fully purged as part of a GuC
sanitization (end of suspend) or a reset flow.
Signed-off-by: Alan Previn
Signed-off-by: Anshuman Gupta
Tested-by: Mousumi Jana
---
drivers/gpu/drm/i915/gem/i915_gem_pm.c
ff-by: Alan Previn
Reviewed-by: Rodrigo Vivi
Tested-by: Mousumi Jana
---
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 5 +
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h | 2 ++
drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 ++
3 files changed, 9 insertions(+)
diff --git a/dr
sion_g2h.
- Patch #3 In wait_for_suspend, fix checking of return from
intel_gt_pm_wait_timeout_for_idle to now use -ETIMEDOUT
and add documentation for intel_wakeref_wait_for_idle.
(Rodrigo).
Alan Previn (2):
drm/i915/guc: Flush context destruction worker at suspend
dr
s not -ENODEV
(since -ENODEV can happen on the majority of cases with
legacy products or with non-PXP kernel configs):
Reviewed-by: Alan Previn
ddress this "lack of a clean mirrored-function design of rpm_get/put
across the rc6 startup sequences", here is my rb:
Reviewed-by: Alan Previn
On Wed, 2023-10-25 at 13:58 +0100, Tvrtko Ursulin wrote:
> On 04/10/2023 18:59, Teres Alexis, Alan Previn wrote:
> > On Thu, 2023-09-28 at 13:46 +0100, Tvrtko Ursulin wrote:
> > > On 27/09/2023 17:36, Teres Alexis, Alan Previn wrote:
alan:snip
> > > It is not possi
On Fri, 2023-10-27 at 10:13 +0300, Jani Nikula wrote:
> On Thu, 26 Oct 2023, Zhanjun Dong wrote:
>
alan:snip
> I'll note that nobody checks intel_pxp_init() return status, so this
> silently skips PXP.
>
> BR,
> Jani.
alan:snip
> > + if (intel_gt_is_wedged(gt))
> > + return -ENODEV;
counters), instead of hanging in the kernel.
Signed-off-by: Alan Previn
Reviewed-by: Rodrigo Vivi
Tested-by: Mousumi Jana
---
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +-
drivers/gpu/drm/i915/gt/intel_gt_pm.c | 7 ++-
drivers/gpu/drm/i915/gt/intel_gt_pm.h | 7 ++-
drivers
t_timeout_for_idle to now use -ETIMEDOUT
and add documentation for intel_wakeref_wait_for_idle.
(Rodrigo).
Alan Previn (3):
drm/i915/guc: Flush context destruction worker at suspend
drm/i915/guc: Close deregister-context race against CT-loss
drm/i915/gt: Timeout when
ff-by: Alan Previn
Reviewed-by: Rodrigo Vivi
Tested-by: Mousumi Jana
---
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 5 +
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h | 2 ++
drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 ++
3 files changed, 9 insertions(+)
diff --git a/dr
so
it can get picked up on the next destroy worker invocation
(if suspend aborted) or get fully purged as part of a GuC
sanitization (end of suspend) or a reset flow.
Signed-off-by: Alan Previn
Signed-off-by: Anshuman Gupta
Tested-by: Mousumi Jana
---
drivers/gpu/drm/i915/gem/i915_gem_pm.c
On Thu, 2023-09-28 at 13:46 +0100, Tvrtko Ursulin wrote:
> On 27/09/2023 17:36, Teres Alexis, Alan Previn wrote:
> > Thanks for taking the time to review this Tvrtko, replies inline below.
alan:snip
> > >
> > > Main concern is that we need to be sure there are no possi
On Wed, 2023-10-04 at 06:34 +, Gupta, Anshuman wrote:
>
> > -Original Message-
> > From: Teres Alexis, Alan Previn > @@ -289,6 +289,13 @@ int intel_gt_resume(struct intel_gt *gt)
> >
> > static void wait_for_suspend(struct intel_gt *gt) {
> >
Thanks for taking the time to review this Tvrtko, replies inline below.
On Wed, 2023-09-27 at 10:02 +0100, Tvrtko Ursulin wrote:
> On 26/09/2023 20:05, Alan Previn wrote:
> > When suspending, add a timeout when calling
> > intel_gt_pm_wait_for_idle else if we have a lost
> >
counters), instead of hanging in the kernel.
Signed-off-by: Alan Previn
Reviewed-by: Rodrigo Vivi
Tested-by: Mousumi Jana
---
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +-
drivers/gpu/drm/i915/gt/intel_gt_pm.c | 6 +-
drivers/gpu/drm/i915/gt/intel_gt_pm.h | 7 ++-
drivers
out_for_idle to now use -ETIMEDOUT
and add documentation for intel_wakeref_wait_for_idle.
(Rodrigo).
Alan Previn (3):
drm/i915/guc: Flush context destruction worker at suspend
drm/i915/guc: Close deregister-context race against CT-loss
drm/i915/gt: Timeout when waiting f
aborted) or get fully purged as part of a GuC
sanitization (end of suspend) or a reset flow.
Signed-off-by: Alan Previn
Signed-off-by: Anshuman Gupta
Tested-by: Mousumi Jana
---
drivers/gpu/drm/i915/gt/intel_gt_pm.c | 7 ++
.../gpu/drm/i915/gt/uc/intel_guc_submission.c | 81 +
ff-by: Alan Previn
Reviewed-by: Rodrigo Vivi
Tested-by: Mousumi Jana
---
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 5 +
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h | 2 ++
drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 ++
3 files changed, 9 insertions(+)
diff --git a/dr
overs that (Jani).
- add timeout dbg of the restart from front-end (Alan).
Signed-off-by: Alan Previn
Reviewed-by: Vivaik Balasubrawmanian
---
drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c | 2 ++
drivers/gpu/drm/i915/pxp/intel_pxp.c | 15 ---
drivers/gpu/drm/i91
ts the GSC command streamer.
Also, move GSC_REPLY_LATENCY_MS definition from pxp header to
intel_gsc_uc_heci_cmd_submit.h since its for any GSC HECI packet.
Signed-off-by: Alan Previn
Reviewed-by: Vivaik Balasubrawmanian
---
.../i915/gt/uc/intel_gsc_uc_heci_cmd_submit.
1 - 100 of 556 matches
Mail list logo
