Re: [PATCH] MAINTAINERS: add Raphael Gallais-Pou to DRM/STi maintainers

2024-11-14 Thread Alain Volmat
On Mon, Nov 04, 2024 at 10:13:51AM +0100, Alain Volmat wrote: > Hi Raphael, > > On Tue, Oct 29, 2024 at 07:30:41PM +0100, Raphael Gallais-Pou wrote: > > Add myself as a maintainer for STi driver changes. > > > > Signed-off-by: Raphael Gallais-Pou > > --- &

Re: [PATCH] MAINTAINERS: add Raphael Gallais-Pou to DRM/STi maintainers

2024-11-04 Thread Alain Volmat
RS b/MAINTAINERS > index 71b739b40921..0e583aae590a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -7477,6 +7477,7 @@ F: drivers/gpu/drm/rockchip/ > > DRM DRIVERS FOR STI > M: Alain Volmat > +M: Raphael Gallais-Pou Acked-by: Alain Volmat > L: dri-devel@l

[PATCH v2 3/3] ARM: dts: st: enable the MALI gpu on the stih410-b2260

2024-10-06 Thread Alain Volmat
Enable the GPU on the stih410-b2260 board. Signed-off-by: Alain Volmat --- arch/arm/boot/dts/st/stih410-b2260.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/st/stih410-b2260.dts b/arch/arm/boot/dts/st/stih410-b2260.dts index

[PATCH v2 2/3] ARM: dts: st: add node for the MALI gpu on stih410.dtsi

2024-10-06 Thread Alain Volmat
Add the entry for the GPU (Mali400) on the stih410.dtsi Signed-off-by: Alain Volmat --- arch/arm/boot/dts/st/stih410.dtsi | 34 ++ 1 file changed, 34 insertions(+) diff --git a/arch/arm/boot/dts/st/stih410.dtsi b/arch/arm/boot/dts/st/stih410.dtsi index

[PATCH v2 1/3] dt-bindings: gpu: mali-utgard: Add st,stih410-mali compatible

2024-10-06 Thread Alain Volmat
ST STiH410 SoC has a Mali400. Add a compatible for it. Signed-off-by: Alain Volmat --- Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml b/Documentation/devicetree/bindings

[PATCH v2 0/3] ARM: dts: st: add and enable MALI400 on stih410/stih410-b2260

2024-10-06 Thread Alain Volmat
-off-by: Alain Volmat --- Changes in v2: - rename compatible from st,sti-mali to st,stih410-mali - Link to v1: https://lore.kernel.org/r/20241005-sti-gpu-v1-0-9bc11100b...@me.com --- Alain Volmat (3): dt-bindings: gpu: mali-utgard: Add st,stih410-mali compatible ARM: dts: st: add node

Re: [PATCH 1/3] dt-bindings: gpu: mali-utgard: Add ST sti compatible

2024-10-06 Thread Alain Volmat
Hi Krzysztof, On Sun, Oct 06, 2024 at 02:45:43PM +0200, Krzysztof Kozlowski wrote: > On Sat, Oct 05, 2024 at 06:07:59PM +0000, Alain Volmat wrote: > > ST STi SoC family (stih410, stih418) has a Mali400. > > Add a compatible for it. > > > > Signed-off-by: Alain Volmat

[PATCH 1/3] dt-bindings: gpu: mali-utgard: Add ST sti compatible

2024-10-05 Thread Alain Volmat
ST STi SoC family (stih410, stih418) has a Mali400. Add a compatible for it. Signed-off-by: Alain Volmat --- Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml b/Documentation

[PATCH 0/3] ARM: dts: st: add and enable MALI400 on stih410/stih410-b2260

2024-10-05 Thread Alain Volmat
-off-by: Alain Volmat --- Alain Volmat (3): dt-bindings: gpu: mali-utgard: Add ST sti compatible ARM: dts: st: add node for the MALI gpu on stih410.dtsi ARM: dts: st: enable the MALI gpu on the stih410-b2260 .../devicetree/bindings/gpu/arm,mali-utgard.yaml | 1 + arch/arm/boot

[PATCH 3/3] ARM: dts: st: enable the MALI gpu on the stih410-b2260

2024-10-05 Thread Alain Volmat
Enable the GPU on the stih410-b2260 board. Signed-off-by: Alain Volmat --- arch/arm/boot/dts/st/stih410-b2260.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/st/stih410-b2260.dts b/arch/arm/boot/dts/st/stih410-b2260.dts index

[PATCH 2/3] ARM: dts: st: add node for the MALI gpu on stih410.dtsi

2024-10-05 Thread Alain Volmat
Add the entry for the GPU (Mali400) on the stih410.dtsi Signed-off-by: Alain Volmat --- arch/arm/boot/dts/st/stih410.dtsi | 34 ++ 1 file changed, 34 insertions(+) diff --git a/arch/arm/boot/dts/st/stih410.dtsi b/arch/arm/boot/dts/st/stih410.dtsi index

Re: [PATCH] drm/sti: avoid potential dereference of error pointers in sti_hqvdp_atomic_check

2024-09-24 Thread Alain Volmat
Hi, On Fri, Sep 13, 2024 at 05:09:26PM +0800, Ma Ke wrote: > The return value of drm_atomic_get_crtc_state() needs to be > checked. To avoid use of error pointer 'crtc_state' in case > of the failure. > > Cc: sta...@vger.kernel.org > Fixes: dd86dc2f9ae1 ("drm/sti: implement atomic_check for the p

Re: [PATCH v2] drm/sti: avoid potential dereference of error pointers

2024-09-24 Thread Alain Volmat
Hi, On Fri, Sep 13, 2024 at 05:04:12PM +0800, Ma Ke wrote: > The return value of drm_atomic_get_crtc_state() needs to be > checked. To avoid use of error pointer 'crtc_state' in case > of the failure. > > Cc: sta...@vger.kernel.org > Fixes: dd86dc2f9ae1 ("drm/sti: implement atomic_check for the p

Re: [PATCH RESEND] drm/sti: avoid potential dereference of error pointers in sti_gdp_atomic_check

2024-09-24 Thread Alain Volmat
Hi, On Mon, Sep 09, 2024 at 02:33:59PM +0800, Ma Ke wrote: > The return value of drm_atomic_get_crtc_state() needs to be > checked. To avoid use of error pointer 'crtc_state' in case > of the failure. > > Cc: sta...@vger.kernel.org > Fixes: dd86dc2f9ae1 ("drm/sti: implement atomic_check for the p

Re: [PATCH RESEND] drm/sti: avoid potential dereference of error pointers

2024-09-12 Thread Alain Volmat
, which is related to the same original commit. Hence sti_cursor/sti_gdp and sti_hqvdp. Would you be ok to have those 3 fixes within a commit ? Regards, Alain On Tue, Sep 10, 2024 at 07:25:43PM +0200, Alain Volmat wrote: > Hi, > > Thanks for your patch. > > Acked-by: Alain Volm

Re: [PATCH RESEND] drm/sti: avoid potential dereference of error pointers in sti_gdp_atomic_check

2024-09-10 Thread Alain Volmat
Hi, Thank you for your patch. Acked-by: Alain Volmat Regards, Alain On Mon, Sep 09, 2024 at 02:33:59PM +0800, Ma Ke wrote: > The return value of drm_atomic_get_crtc_state() needs to be > checked. To avoid use of error pointer 'crtc_state' in case > of the fa

Re: [PATCH RESEND] drm/sti: avoid potential dereference of error pointers

2024-09-10 Thread Alain Volmat
Hi, Thanks for your patch. Acked-by: Alain Volmat Regards, Alain On Mon, Aug 26, 2024 at 01:26:52PM +0800, Ma Ke wrote: > The return value of drm_atomic_get_crtc_state() needs to be > checked. To avoid use of error pointer 'crtc_state' in case > of the failure. > > C

Re: [PATCH] MAINTAINERS: drm/sti: mark it as Odd Fixes

2024-07-09 Thread Alain Volmat
Hi Maxime, On Mon, Jul 08, 2024 at 04:57:49PM +0200, Maxime Ripard wrote: > On Fri, Jul 05, 2024 at 05:14:36PM GMT, Alain Volmat wrote: > > Hi Krzysztof, Daniel, and Maxime, > > > > On Fri, Jul 05, 2024 at 03:41:26PM +0200, Daniel Vetter wrote: > > > On Fri, Ju

Re: [PATCH] MAINTAINERS: drm/sti: mark it as Odd Fixes

2024-07-05 Thread Alain Volmat
Hi Krzysztof, Daniel, and Maxime, On Fri, Jul 05, 2024 at 03:41:26PM +0200, Daniel Vetter wrote: > On Fri, Jul 05, 2024 at 01:33:38PM +0200, Krzysztof Kozlowski wrote: > > On 05/07/2024 13:22, Maxime Ripard wrote: > > > On Fri, Jul 05, 2024 at 01:19:50PM GMT, Daniel Vetter wrote: > > >> On Fri, Ju

Re: [PATCH 4/4] drm/sti: vtg: drop driver owner assignment

2024-05-27 Thread Alain Volmat
er = THIS_MODULE, > .of_match_table = vtg_of_match, > }, > .probe = vtg_probe, > -- > 2.34.1 > Acked-by: Alain Volmat Alain

Re: [PATCH 07/21] drm/sti: Allow build with COMPILE_TEST=y

2024-05-27 Thread Alain Volmat
Hi Ville, thank you for your patch. On Mon, Apr 08, 2024 at 08:04:12PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Allow sti to be built with COMPILE_TEST=y for greater > coverage. Builds fine on x86/x86_64 at least. > > Cc: Alain Volmat > Signed-

Re: [PATCH 06/21] drm/sti: Include linux/io.h for devm_ioremap()

2024-05-27 Thread Alain Volmat
rom integer without a cast [-Werror=int-conversion] > 531 | dvo->regs = devm_ioremap(dev, res->start, > | ^ > > Cc: Alain Volmat > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/sti/sti_dvo.c | 1 + > 1 file changed, 1 inser

Re: [PATCH 3/4] drm/sti: tvout: drop driver owner assignment

2024-05-27 Thread Alain Volmat
.owner = THIS_MODULE, > .of_match_table = tvout_of_match, > }, > .probe = sti_tvout_probe, > -- > 2.34.1 > Acked-by: Alain Volmat Alain

Re: [PATCH 2/4] drm/sti: hda: drop driver owner assignment

2024-05-27 Thread Alain Volmat
er = THIS_MODULE, > .of_match_table = hda_of_match, > }, > .probe = sti_hda_probe, > -- > 2.34.1 > Acked-by: Alain Volmat Alain

Re: [PATCH 1/4] drm/sti: dvo: drop driver owner assignment

2024-05-27 Thread Alain Volmat
.of_match_table = dvo_of_match, > }, > .probe = sti_dvo_probe, > -- > 2.34.1 > Acked-by: Alain Volmat Alain

Re: [PATCH 5/6] drm/sti: hdmi: drop driver owner assignment

2024-05-27 Thread Alain Volmat
.name = "sti-hdmi", > - .owner = THIS_MODULE, > .of_match_table = hdmi_of_match, > }, > .probe = sti_hdmi_probe, > -- > 2.34.1 > Acked-by: Alain Volmat Alain

Re: [PATCH 6/6] drm/sti: hqvdp: drop driver owner assignment

2024-05-27 Thread Alain Volmat
.owner = THIS_MODULE, > .of_match_table = hqvdp_of_match, > }, > .probe = sti_hqvdp_probe, > -- > 2.34.1 > Acked-by: Alain Volmat Alain

[PATCH 07/14] drm/sti: add more possible GDP / VID planes entries in sti_plane

2023-07-27 Thread Alain Volmat
In order to address the STiH418, add more entries in sti_plane Signed-off-by: Alain Volmat --- drivers/gpu/drm/sti/sti_plane.c | 8 drivers/gpu/drm/sti/sti_plane.h | 8 +++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sti/sti_plane.c b/drivers/gpu

[PATCH 02/14] dt-bindings: display: add st, stih418-vtg compatible for sti vtg

2023-07-27 Thread Alain Volmat
Add a new compatible in st,stih4xx.txt in order to support sti vtg on stih418 platforms. Signed-off-by: Alain Volmat --- Documentation/devicetree/bindings/display/st,stih4xx.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/st

[PATCH 08/14] drm/sti: add more planes supports in sti_mixer

2023-07-27 Thread Alain Volmat
On STiH418, the mixer is able to driver more layers of planes. For this purpose, add those new possible entries and allow it to work in either STiH407 or STiH418 mode. Signed-off-by: Alain Volmat --- drivers/gpu/drm/sti/sti_mixer.c | 66 - drivers/gpu/drm/sti

[PATCH 04/14] drm/sti: add STih418 platform support in sti mixer

2023-07-27 Thread Alain Volmat
. Signed-off-by: Alain Volmat --- drivers/gpu/drm/sti/sti_mixer.c | 71 ++--- 1 file changed, 57 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_mixer.c b/drivers/gpu/drm/sti/sti_mixer.c index 7e5f14646625..9cd780403d7b 100644 --- a/drivers/gpu/drm/sti

[PATCH 10/14] drm/sti: add compositor support for stih418 platform

2023-07-27 Thread Alain Volmat
On the STiH418, a new clock (proc_mixer) must be enabled in order to have the plane mixers properly behaving. Add a new st,stih418-compositor in order to describe the planes/mixers available on this platform. Signed-off-by: Alain Volmat --- drivers/gpu/drm/sti/sti_compositor.c | 26

[PATCH 05/14] drm/sti: add support for stih418 in tvout

2023-07-27 Thread Alain Volmat
The tvout for stih407 and stih418 differ in the connection with the vtg regarding to the hdmi output. In order to cop with that, introduce a new compatible st,stih418-tvout in order to have the hdmi_sync_id being part of the data attached to each compatible. Signed-off-by: Alain Volmat

[PATCH 06/14] drm/sti: remove VTG_SYNC_ID_HDMI from sti_vtg.h

2023-07-27 Thread Alain Volmat
Since the synchro signal used for hdmi output and coming from the VTG differs between the stih407 and stih418 platforms, we cannot rely anymore on hardcoded value and involve drivers use compatible to figure out the value. The macro VTG_SYNC_ID_HDMI can thus be removed. Signed-off-by: Alain

[PATCH 00/14] drm/sti: add display support on stih418 family

2023-07-27 Thread Alain Volmat
planes), called here gdpplus Alain Volmat (14): drm/sti: add hdmi tx6g0c28 phy for STi platform dt-bindings: display: add st,stih418-vtg compatible for sti vtg drm/sti: add support for VTG on the stih418 platform drm/sti: add STih418 platform support in sti mixer drm/sti: add support for

[PATCH 09/14] drm/sti: add support for GDPPLUS / stih418 GDPs

2023-07-27 Thread Alain Volmat
same (but not at same addresses). For that purpose, this commit rework the way of addressing the GDP(PLUS) registers. Signed-off-by: Alain Volmat --- drivers/gpu/drm/sti/sti_compositor.c | 4 + drivers/gpu/drm/sti/sti_compositor.h | 1 + drivers/gpu/drm/sti/sti_gdp.c| 250

[PATCH 01/14] drm/sti: add hdmi tx6g0c28 phy for STi platform

2023-07-27 Thread Alain Volmat
Addition of the HDMI TX PHY driver for use in the STiH418 SoC platform and more especially the 4KOpen (B2264) board. Signed-off-by: Alain Volmat --- drivers/gpu/drm/sti/Makefile | 1 + drivers/gpu/drm/sti/sti_hdmi.c | 4 + drivers/gpu/drm/sti/sti_hdmi_tx6g0c28phy.c

[PATCH 03/14] drm/sti: add support for VTG on the stih418 platform

2023-07-27 Thread Alain Volmat
compatible st,stih418-vtg is added to differentiate that. Signed-off-by: Alain Volmat --- drivers/gpu/drm/sti/sti_vtg.c | 62 +-- 1 file changed, 52 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_vtg.c b/drivers/gpu/drm/sti/sti_vtg.c index

Re: [PATCH RESEND] drm/sti: Avoid full proxy f_ops for sti debug attributes

2023-06-10 Thread Alain Volmat
Hi Deepak, thank you for the patch and sorry for the delay. Acked-by: Alain Volmat Alain On Thu, Mar 02, 2023 at 01:28:20AM +0530, Deepak R Varma wrote: > Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() > function adds the overhead of introducing a proxy file ope

Re: [PATCH 41/53] drm/sti: Convert to platform remove callback returning void

2023-05-09 Thread Alain Volmat
Hi, Acked-by: Alain Volmat Regards, Alain On Sun, May 07, 2023 at 06:26:04PM +0200, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error

Re: [PATCH 4/5] drm/sti: Drop of_gpio header

2023-04-22 Thread Alain Volmat
Hi Maira, thanks for the patch. On Fri, Aug 12, 2022 at 05:57:45PM -0300, Maíra Canal wrote: > This driver includes the deprecated OF GPIO header > yet fail to use symbols from it, so drop this include. > > Cc: Alain Volmat > Signed-off-by: Maíra Canal > --- > drivers/

Re: [PATCH 7/9] drm/sti/sti_hdmi: convert to using is_hdmi from display info

2023-04-22 Thread Alain Volmat
Hi Jani, On Thu, Sep 01, 2022 at 03:47:09PM +0300, Jani Nikula wrote: > Prefer the parsed results for is_hdmi in display info over calling > drm_detect_hdmi_monitor(). Remove the now redundant hdmi_monitor member > from struct sti_hdmi. > > Cc: Alain Volmat > Signed-o

[PATCH] MAINTAINERS: Update Alain Volmat's email address for drm/sti

2023-04-17 Thread Alain Volmat
Update my email address for maintainer of the STi DRM driver. Signed-off-by: Alain Volmat --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0e64787aace8..3cec7ad72389 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6952,7 +6952,7

Re: [PATCH][next] drm/sti: Fix spelling mistake "top_cmd_offest" -> "top_cmd_offset"

2023-02-13 Thread Alain Volmat
> btm_cmd = hqvdp->hqvdp_cmd + btm_cmd_offset; > - top_cmd = hqvdp->hqvdp_cmd + top_cmd_offest; > + top_cmd = hqvdp->hqvdp_cmd + top_cmd_offset; > > memcpy(btm_cmd, top_cmd, sizeof(*btm_cmd)); > > -- Acked-by: Alain Volmat Alain > 2.30.2 >

Re: [PATCH] drm: sti: don't use kernel-doc markers

2022-03-28 Thread Alain Volmat
Hi Randy, thanks for the patch. Acked-by: Alain Volmat Alain On Sat, Mar 26, 2022 at 04:51:32PM -0700, Randy Dunlap wrote: > Don't mark static functions as kernel-doc. > > Prevents multiple kernel-doc build warnings: > > drivers/gpu/drm/sti/sti_hdmi.c:187: warning: This

Re: [PATCH 16/30] drm/sti: fix typos in comments

2022-03-14 Thread Alain Volmat
Hi Julia thanks for the patch. Reviewed-by: Alain Volmat Alain On Mon, Mar 14, 2022 at 12:53:40PM +0100, Julia Lawall wrote: > Various spelling mistakes in comments. > Detected with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/gpu/drm

Re: [PATCH 17/23] drm/sti: plane: Remove redundant zpos initialisation

2022-02-10 Thread Alain Volmat
Hi, thanks for the patch. Reviewed-by: Alain Volmat Alain On Mon, Feb 07, 2022 at 05:35:09PM +0100, Maxime Ripard wrote: > The sti KMS driver will call drm_plane_create_zpos_property() with an > init value depending on the plane type. > > Since the initial value wasn't ca

Re: [PATCH 2/2] MAINTAINERS: update drm/stm drm/sti and cec/sti maintainers

2022-01-17 Thread Alain Volmat
Hi Philippe, thanks for the patch. Reviewed-by: Alain Volmat Alain On Thu, Jan 13, 2022 at 06:19:21PM +0100, Philippe Cornu wrote: > Add Alain as sti maintainer for both drm/sti & cec/sti. > Add Raphaël as stm maintainer for drm/stm. > > Signed-off-by: Philippe Cornu >