[BUG] drm/rockchip: vop2: uninitialized variables passed to ilog2 and writel

2025-03-13 Thread Ahmad Fatoum
Hi, Running clang-analyzer[1] on the VOP2 driver in barebox[2], which was ported from Linux reports that following variables: dclk_out_div, if_pixclk_div, if_dclk_div defined in rk3588_set_intf_mux() and passed to rk3588_calc_cru_cfg() are given as uninitialized arguments to ilog2() and in som

Re: [PATCH v2 05/10] dt-bindings: display/lvds-codec: add ti,sn65lvds822

2025-02-19 Thread Ahmad Fatoum
Dear DRM bridge maintainers, On 06.01.25 17:06, Ahmad Fatoum wrote: > Add compatible strings for TI SN65LVDS822, a FlatLink LVDS receiver. > > Acked-by: Rob Herring (Arm) > Signed-off-by: Ahmad Fatoum Shawn has asked that the DT or display maintainers take this one patch throug

[PATCH v2 00/10] arm64: dts: imx8mp-skov: flesh out device trees

2025-01-06 Thread Ahmad Fatoum
: - Add Rob's Acked-by - Reword some commit messages. See individual patches for details - Link to v1: https://lore.kernel.org/r/20241219-skov-dt-updates-v1-0-38bf80dc2...@pengutronix.de --- Ahmad Fatoum (5): arm64: dts: imx8mp-skov: correct PMIC board limits arm64: dts: imx8mp

[PATCH v2 05/10] dt-bindings: display/lvds-codec: add ti,sn65lvds822

2025-01-06 Thread Ahmad Fatoum
Add compatible strings for TI SN65LVDS822, a FlatLink LVDS receiver. Acked-by: Rob Herring (Arm) Signed-off-by: Ahmad Fatoum --- v1 -> v2: - Add Rob's Acked-by To: Andrzej Hajda (maintainer:DRM DRIVERS FOR BRIDGE CHIPS) To: Neil Armstrong (maintainer:DRM DRIVERS FOR BRIDGE C

[PATCH 00/10] arm64: dts: imx8mp-skov: flesh out device trees

2024-12-18 Thread Ahmad Fatoum
When the Skov device trees were added a year ago, there were no upstream bindings yet for many parts of the display pipeline. This has changed now, so this series fleshes the display pipeline parts out and adds some more fixes/enhancements that have accrued in the meantime. --- Ahmad Fatoum (5

[PATCH 05/10] dt-bindings: display/lvds-codec: add ti,sn65lvds822

2024-12-18 Thread Ahmad Fatoum
Add compatible strings for TI SN65LVDS822, a FlatLink LVDS receiver. Signed-off-by: Ahmad Fatoum --- To: Andrzej Hajda (maintainer:DRM DRIVERS FOR BRIDGE CHIPS) To: Neil Armstrong (maintainer:DRM DRIVERS FOR BRIDGE CHIPS) To: Robert Foss (maintainer:DRM DRIVERS FOR BRIDGE CHIPS) Cc: Laurent

[PATCH 3/3] drm: panel-simple: support TOPLAND TIAN G07017 LCD panel

2024-12-18 Thread Ahmad Fatoum
ts no timings and these were provided by the vendor separately. Signed-off-by: Ahmad Fatoum --- drivers/gpu/drm/panel/panel-simple.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-sim

[PATCH 1/3] dt-bindings: vendor-prefixes: add prefix for Topland Electronics (H.K)

2024-12-18 Thread Ahmad Fatoum
Topland is a professional supplier of photoelectric display and touch integrated products from Hong Kong: https://www.topland.com.hk/aboutus/ Signed-off-by: Ahmad Fatoum --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[PATCH 0/3] drm: panel-simple: support TOPLAND TIAN G07017 LCD panel

2024-12-18 Thread Ahmad Fatoum
The TIAN-G07017-01 is a 7" TFT-LCD module by TOPLAND ELECTRONICS (H.K). The panel features 1024x600 24-bit RGB pixels driven over LVDS as well as a PWM backlight and I2C-connected ft5506-compatible capacitive touch. This series adds DT binding and Linux driver support for this panel. ---

[PATCH 2/3] dt-bindings: display: panel-simple: Document Topland TIAN-G07017-01

2024-12-18 Thread Ahmad Fatoum
The TIAN-G07017-01 is a 7" TFT-LCD module by TOPLAND ELECTRONICS (H.K). Add its compatible string. Signed-off-by: Ahmad Fatoum --- Documentation/devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/di

Re: [PATCH v4 3/3] ARM: dts: imx6sl: Provide a more specific lcdif compatible

2024-11-04 Thread Ahmad Fatoum
; Signed-off-by: Fabio Estevam Reviewed-by: Ahmad Fatoum Thank you, Ahmad > --- > Changes since v3: > - None. > > arch/arm/boot/dts/nxp/imx/imx6sl.dtsi | 3 ++- > arch/arm/boot/dts/nxp/imx/imx6sll.dtsi | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > >

Re: [PATCH v4 1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback

2024-11-04 Thread Ahmad Fatoum
dif', 'fsl,imx28-lcdif'] is too long > > To keep DT compatibility, document 'fsl,imx28-lcdif' as a possible > 'fsl,imx6sx-lcdif' fallback. > > Signed-off-by: Fabio Estevam Reviewed-by: Ahmad Fatoum > --- > Changes since v3: > - Also upda

Re: [PATCH v4 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks

2024-11-04 Thread Ahmad Fatoum
ay plane and the CRC32 support than the imx28-lcdif IP. > > Expand the imx6sl/imx6sll lcdif fallbacks to accept a less specific > fsl,imx28-lcdif fallback: > > compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif", "fsl,imx28-lcdif"; > > This hel

Re: [PATCH v3 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks

2024-10-29 Thread Ahmad Fatoum
On 29.10.24 21:16, Marek Vasut wrote: > On 10/29/24 8:16 PM, Fabio Estevam wrote: >> From: Fabio Estevam >> >> mx6sl.dtsi and imx6sll.dtsi have the following lcdif entries: >> >> compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif"; >> >> This causes dt-schema warnings as the current binding only >>

Re: [PATCH linux-next] drm/imx: Use device_match_of_node()

2022-11-28 Thread Ahmad Fatoum
Hello, On 17.11.22 08:11, ye.xingc...@zte.com.cn wrote: > From: ye xingchen > > Replace the open-code with device_match_of_node(). device_match_of_node() exists so a pointer to the function can be passed to class/driver_find_device. I see no reason to call it directly. I don't think you should

[PATCH v2] drm: bridge: adv7511: use dev_err_probe in probe function

2022-10-26 Thread Ahmad Fatoum
Signed-off-by: Ahmad Fatoum --- v1 -> v2: - broke overly long lines (Laurent) - Added Laurent's Reviewed-by --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 6 ++ drivers/gpu/drm/bridge/adv7511/adv7533.c | 20 2 files changed, 10 insertions(+), 16 d

[PATCH] drm: bridge: adv7511: use dev_err_probe in probe function

2022-10-17 Thread Ahmad Fatoum
ridge: adv7533: Create a MIPI DSI device") Signed-off-by: Ahmad Fatoum --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 6 ++ drivers/gpu/drm/bridge/adv7511/adv7533.c | 18 ++ 2 files changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/brid

Re: [PATCH v2 2/2] drm/panel: simple: add LOGIC Technologies LTTD800480070-L6WH-RT

2021-08-05 Thread Ahmad Fatoum
> Signed-off-by: Oleksij Rempel Reviewed-by: Ahmad Fatoum > --- > drivers/gpu/drm/panel/panel-simple.c | 35 > 1 file changed, 35 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c > b/drivers/gpu/drm/panel/panel-simple.c >

Re: [PATCH v2 1/2] drm/panel: simple: add Multi-Innotechnology MI1010AIT-1CP1

2021-08-05 Thread Ahmad Fatoum
t; > Co-Developed-by: Sam Ravnborg > Co-Developed-by: Ulrich Ölmann > Signed-off-by: Sam Ravnborg > Signed-off-by: Ulrich Ölmann > Signed-off-by: Oleksij Rempel Reviewed-by: Ahmad Fatoum > --- > drivers/gpu/drm/panel/panel-simple.c | 34 >

Re: [PATCH v1 2/2] drm/panel: simple: add LOGIC Technologies LTTD800480070-L6WH-RT

2021-08-05 Thread Ahmad Fatoum
Hello Oleksi, On 05.08.21 06:37, Oleksij Rempel wrote: > From: Søren Andersen > > Add support for the LOGIC Technologies, Inc LTTD800480070-L6WH-RT > > Co-Developed-by: Søren Andersen > Co-Developed-by: Sam Ravnborg > Signed-off-by: Søren Andersen > Signed-off-by: Sam Ravnborg > Signed-off-

Re: [PATCH v1 1/2] drm/panel: simple: add Multi-Innotechnology MI1010AIT-1CP1

2021-08-05 Thread Ahmad Fatoum
Hello Oleksij, On 05.08.21 06:37, Oleksij Rempel wrote: > From: Sam Ravnborg > > The Multi Innotechnology is a 10.1" 1280x800 panel. > > The datasheet did not specify specific values for sync, back, front porch. > The values are a best guess based on values for similar panels. > > Co-Developed

Re: [PATCH 03/19] gpu: drm: imx: ipuv3-plane: Mark 'crtc_state' as __always_unused

2020-11-08 Thread Ahmad Fatoum
On 11/6/20 8:41 AM, Lee Jones wrote: > On Thu, 05 Nov 2020, Ahmad Fatoum wrote: > >> Hello Lee, >> >> On 11/5/20 3:45 PM, Lee Jones wrote: >>> In the macro for_each_oldnew_crtc_in_state() 'crtc_state' is provided >>> as a container for state-

Re: [PATCH 03/19] gpu: drm: imx: ipuv3-plane: Mark 'crtc_state' as __always_unused

2020-11-06 Thread Ahmad Fatoum
Hello Lee, On 11/5/20 3:45 PM, Lee Jones wrote: > In the macro for_each_oldnew_crtc_in_state() 'crtc_state' is provided > as a container for state->crtcs[i].new_state, but is not utilised in > this use-case. We cannot simply delete the variable, so here we tell > the compiler that we're intention

Re: [PATCH 0/3] drm/mxsfb: support swapped RGB lanes

2019-03-27 Thread Ahmad Fatoum
Hello, On 2/1/19 22:05, Stefan Agner wrote: > On 02.01.2019 18:02, Ahmad Fatoum wrote: >> Hello, >> >> I got a board with the RED[0:7]/BLUE[0:7] lanes originating from the >> LCDIF swapped and would like to describe this in the device tree: >> >> This

Re: [PATCH 0/3] drm/mxsfb: support swapped RGB lanes

2019-03-27 Thread Ahmad Fatoum
Hello Sam, On 7/1/19 19:04, Sam Ravnborg wrote: > Hi Ahmad. > >> On 2/1/19 22:37, Sam Ravnborg wrote: >>> The problem with the RED/BLUE lines swapped is something I >>> have encountered while working with DRM support for Atmel at91sam9263 too. >>> >>> The solution selected is to extend the endpoi

[PATCH] drm/panel: simple: innolux, at070tn92: specify correct pixdata edge

2019-01-10 Thread Ahmad Fatoum
en running modetest -s. Signed-off-by: Ahmad Fatoum --- drivers/gpu/drm/panel/panel-simple.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index a04ffb3b2174..021066a231b5 100644 --- a/drivers/gpu/drm/panel/pane

Re: [PATCH 0/3] drm/mxsfb: support swapped RGB lanes

2019-01-08 Thread Ahmad Fatoum
Hello Sam, On 2/1/19 22:37, Sam Ravnborg wrote: > The problem with the RED/BLUE lines swapped is something I > have encountered while working with DRM support for Atmel at91sam9263 too. > > The solution selected is to extend the endpoint with > a new optional property: > > - wiring: Wiring of da

Re: [PATCH 0/3] drm/mxsfb: support swapped RGB lanes

2019-01-04 Thread Ahmad Fatoum
On 1/2/19 10:05 PM, Stefan Agner wrote: > On a quick glance patch 1 looks good. > > However, patch 2/3 are probably unnecessary when using of graph/panel > support. E.g. panel-simple.c supports bus formats. > > Is the display you are using regular RGB and only the board/connectors > happen to sw

[PATCH 2/3] drm/mxsfb: implement interface-pix-fmt of_property to override bus format

2019-01-03 Thread Ahmad Fatoum
This way hardware that has the LCD signal lines swapped can express so in the device tree and existing panel support can be reused unmodified. Signed-off-by: Ahmad Fatoum --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 4 +++- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 13 + drivers/gpu/drm

Re: [PATCH 1/3] drm/mxsfb: use bus_format to determine pixel RGB component order

2019-01-03 Thread Ahmad Fatoum
On 2/1/19 18:02, Ahmad Fatoum wrote: > - reg &= ~CTRL_BUS_WIDTH_MASK; > + ctrl &= ~CTRL_BUS_WIDTH_MASK; > switch (bus_format) { > default: > + pattern = CTRL2_PATTERN_RGB; > dev_err(drm->dev, "Unknown

[PATCH 3/3] dt-bindings: mxsfb: document new interface-pix-fmt property

2019-01-03 Thread Ahmad Fatoum
This newly implemented binding allows expressing swapped signal lanes in the device tree so existing panel support can be reused. Signed-off-by: Ahmad Fatoum --- Documentation/devicetree/bindings/display/mxsfb.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree

[PATCH 0/3] drm/mxsfb: support swapped RGB lanes

2019-01-03 Thread Ahmad Fatoum
MEDIA_BUS_FMT_GBR888_1X24 The latter two patches add a new interface-pix-fmt property (named so because fsl,imx-parallel-display has one), which allows a device tree to override the bus format to account for swapped signal lanes. Thoughts? Cheers Ahmad -- Ahmad Fatoum (3): drm/mxsfb: use

[PATCH 1/3] drm/mxsfb: use bus_format to determine pixel RGB component order

2019-01-03 Thread Ahmad Fatoum
The LCDIF controller v4, like the one included in the i.MX6UL, can be configured to accept other RGB pixel formats. Extend the driver to configure the controller to do so. Signed-off-by: Ahmad Fatoum --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 41 +- drivers/gpu/drm