[PATCH v3] checkpatch: remove %p4cn

2025-04-30 Thread Aditya Garg
%p4cn was recently removed and replaced by %p4chR in vsprintf. So, remove the check for %p4cn from checkpatch.pl. Fixes: 37eed892cc5f ("vsprintf: Use %p4chR instead of %p4cn for reading data in reversed host ordering") Signed-off-by: Aditya Garg --- v2: Add specific check for

[PATCH v2] checkpatch: remove %p4cn and add check for %p4chR

2025-04-29 Thread Aditya Garg
%p4cn was recently removed and replaced by %p4chR in vsprintf. So, remove the check for %p4cn from checkpatch.pl. Fixes: 37eed892cc5f ("vsprintf: Use %p4chR instead of %p4cn for reading data in reversed host ordering") Signed-off-by: Aditya Garg --- v2: Add specific check for

Re: [PATCH] checkpatch: remove %p4cn

2025-04-29 Thread Aditya Garg
On 29-04-2025 11:05 pm, Joe Perches wrote: > On Tue, 2025-04-29 at 16:07 +0000, Aditya Garg wrote: >> %p4cn was recently removed and replaced by %p4chR in vsprintf. So, >> remove the check for %p4cn from checkpatch.pl. >> >> Fixes: 37eed892cc5f ("vsprintf:

[PATCH] checkpatch: remove %p4cn

2025-04-29 Thread Aditya Garg
%p4cn was recently removed and replaced by %p4chR in vsprintf. So, remove the check for %p4cn from checkpatch.pl. Fixes: 37eed892cc5f ("vsprintf: Use %p4chR instead of %p4cn for reading data in reversed host ordering") Signed-off-by: Aditya Garg --- scripts/checkpatch.pl | 2

Re: [PATCH] vsprintf: Use %p4chR instead of %p4cn for reading data in reversed host ordering

2025-04-29 Thread Aditya Garg
Hi Petr > The generic FourCC format always prints the data using the big endian > order. It is generic because it allows to read the data using a custom > ordering. > > The current code uses "n" for reading data in the reverse host ordering. > It makes the 4 variants [hnbl] consistent with the

Re: [PATCH] vsprintf: Use %p4chR instead of %p4cn for reading data in reversed host ordering

2025-04-28 Thread Aditya Garg
On 28-04-2025 10:30 pm, Alyssa Rosenzweig wrote: > Acked-by: Alyssa Rosenzweig > > Since the other patches went thru drm-misc-next, I guess this should > too? I think yes. > > > Le Mon , Apr 28, 2025 at 02:31:32PM +0200, Petr Mladek a écrit : >> The generic FourCC format always prints the d

Re: [PATCH RESEND] drm/appletbdrm: Make appletbdrm depend on X86

2025-04-28 Thread Aditya Garg
Ccing the mailing lists> From: Aditya Garg > > The appletbdrm driver is exclusively for Touch Bars on x86 Intel Macs. > The M1 Macs have a separate driver. So, lets avoid compiling it for > other architectures. > > Reviewed-by: Alyssa Rosenzweig > Signed-off-by: Adity

Re: [PATCH] vsprintf: Use %p4chR instead of %p4cn for reading data in reversed host ordering

2025-04-28 Thread Aditya Garg
oid the confusion by replacing the "n" modifier with "hR", aka > reverse host ordering. It is inspired by the existing %p[mM]R printf > format. > > Reported-by: Geert Uytterhoeven > Closes: > https://lore.kernel.org/r/CAMuHMdV9tX=TG7E_CrSF=2py206txf+_yyruacg48ew

Re: [PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-04-23 Thread Aditya Garg
> On 23 Apr 2025, at 7:09 PM, Petr Mladek wrote: > > On Tue 2025-04-22 10:43:59, Geert Uytterhoeven wrote: >> Hi Aditya, >> >> CC netdev >> >>> On Tue, 22 Apr 2025 at 10:30, Aditya Garg wrote: >>> On 22-04-2025 01:37 pm, Geert Uytterhoe

Re: [PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-04-22 Thread Aditya Garg
On 22-04-2025 08:52 pm, Andy Shevchenko wrote: > On Tue, Apr 22, 2025 at 08:45:31PM +0530, Aditya Garg wrote: >> On 22-04-2025 04:02 pm, Geert Uytterhoeven wrote: >>> On Tue, 22 Apr 2025 at 12:16, Andy Shevchenko >>> wrote: > > ... > >>> I a

Re: [PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-04-22 Thread Aditya Garg
On 22-04-2025 04:02 pm, Geert Uytterhoeven wrote: > Hi Andy, > > On Tue, 22 Apr 2025 at 12:16, Andy Shevchenko > wrote: >> On Tue, Apr 22, 2025 at 10:43:59AM +0200, Geert Uytterhoeven wrote: >>> On Tue, 22 Apr 2025 at 10:30, Aditya Garg wrote: >>>> On

Re: [PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-04-22 Thread Aditya Garg
On 22-04-2025 02:13 pm, Geert Uytterhoeven wrote: > Hi Aditya, > > CC netdev > > On Tue, 22 Apr 2025 at 10:30, Aditya Garg wrote: >> On 22-04-2025 01:37 pm, Geert Uytterhoeven wrote: >>> On Tue, 8 Apr 2025 at 08:48, Aditya Garg wrote: >>>> From:

Re: [PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-04-22 Thread Aditya Garg
On 22-04-2025 01:37 pm, Geert Uytterhoeven wrote: > Hi Aditya, Hector, > > On Tue, 8 Apr 2025 at 08:48, Aditya Garg wrote: >> From: Hector Martin >> >> %p4cc is designed for DRM/V4L2 FourCCs with their specific quirks, but >> it's useful to be a

Re: [PATCH v4 0/3] Use proper printk format in appletbdrm

2025-04-21 Thread Aditya Garg
On 21-04-2025 07:26 pm, Alyssa Rosenzweig wrote: >> Any change needed or just because some other maintainer manages this? >> Although Tbh, I really don't care about backporting since T2 Mac users are >> still using patched kernels provided by us. I'd rather free my mind in >> getting this don

Re: [PATCH v4 0/3] Use proper printk format in appletbdrm

2025-04-21 Thread Aditya Garg
ng since T2 Mac users are still using patched kernels provided by us. I'd rather free my mind in getting this done. > > Le Mon, Apr 21, 2025 at 06:40:23PM +0530, Aditya Garg a écrit : >> >> >> On 21-04-2025 06:38 pm, Aditya Garg wrote: >>> >>> >>

Re: [PATCH v4 0/3] Use proper printk format in appletbdrm

2025-04-21 Thread Aditya Garg
On 21-04-2025 06:38 pm, Aditya Garg wrote: > > > On 21-04-2025 06:37 pm, Alyssa Rosenzweig wrote: >>> On 21-04-2025 05:35 pm, Alyssa Rosenzweig wrote: >>>>> Can I have a feedback from some DRM maintainer on this? AFAIK merge >>>>> window is ov

Re: [PATCH v4 0/3] Use proper printk format in appletbdrm

2025-04-21 Thread Aditya Garg
On 21-04-2025 06:37 pm, Alyssa Rosenzweig wrote: >> On 21-04-2025 05:35 pm, Alyssa Rosenzweig wrote: Can I have a feedback from some DRM maintainer on this? AFAIK merge window is over for some time now. It's been more than a week and last time when I submitted, it just stayed in

Re: [PATCH v4 0/3] Use proper printk format in appletbdrm

2025-04-21 Thread Aditya Garg
On 21-04-2025 05:35 pm, Alyssa Rosenzweig wrote: >> Can I have a feedback from some DRM maintainer on this? AFAIK merge window >> is over for some time now. It's been more than a week and last time when I >> submitted, it just stayed in the mailing list without any feedback. > > DRM hides the

Re: [PATCH v4 0/3] Use proper printk format in appletbdrm

2025-04-17 Thread Aditya Garg
Hi On 08-04-2025 12:17 pm, Aditya Garg wrote: > The vsprint patch was originally being sent as a seperate patch [1], and > I was waiting it to be taken up. But as suggested by Petr, I'm sending > them via DRM. > > v2: > Remove printf tests, will merge later through Kees&

[PATCH v4 3/3] drm/appletbdrm: use %p4cl instead of %p4cc

2025-04-10 Thread Aditya Garg
From: Aditya Garg Due to lack of a proper format specifier, %p4cc was being used instead of %p4cl for the purpose of printing FourCCs. But the disadvange was that they were being printed in a reverse order. %p4cl should correct this issue. Reviewed-by: Alyssa Rosenzweig Signed-off-by: Aditya

[PATCH v3 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-04-10 Thread Aditya Garg
nting LSByte-first FourCCs stored in host endian order (other than the hex form being in character order, not the integer value). Acked-by: Rasmus Villemoes Reviewed-by: Andy Shevchenko Reviewed-by: Petr Mladek Tested-by: Petr Mladek Signed-off-by: Hector Martin Signed-off-by: Aditya

[PATCH] drm/appletbdrm: Make appletbdrm depend on X86

2025-04-10 Thread Aditya Garg
From: Aditya Garg The appletbdrm driver is exclusively for Touch Bars on x86 Intel Macs. The M1 Macs have a separate driver. So, lets avoid compiling it for other architectures. Signed-off-by: Aditya Garg --- drivers/gpu/drm/tiny/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH v4 0/3] Use proper printk format in appletbdrm

2025-04-08 Thread Aditya Garg
merged now. v4: Do changes requested by Andy and add Petr's review to printf patch. Link: https://lore.kernel.org/lkml/1a03a5b4-93ac-4307-ae6a-4a4c4b7e9...@live.com/ [1] Aditya Garg (2): printf: add tests for generic FourCCs drm/appletbdrm: use %p4cl instead of %p4cc Hector Martin (1):

Re: [PATCH v4 0/3] Use proper printk format in appletbdrm

2025-04-08 Thread Aditya Garg
> On 8 Apr 2025, at 2:11 PM, Andy Shevchenko > wrote: > > On Tue, Apr 08, 2025 at 12:17:13PM +0530, Aditya Garg wrote: >> The vsprint patch was originally being sent as a seperate patch [1], and >> I was waiting it to be taken up. But as suggested by Petr, I&#

[PATCH v4 2/3] printf: add tests for generic FourCCs

2025-04-08 Thread Aditya Garg
From: Aditya Garg This patch adds support for kunit tests of generic 32-bit FourCCs added to vsprintf. Acked-by: Tamir Duberstein Reviewed-by: Andy Shevchenko Reviewed-by: Petr Mladek Tested-by: Petr Mladek Signed-off-by: Aditya Garg --- lib/tests/printf_kunit.c | 39

[PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-04-07 Thread Aditya Garg
nting LSByte-first FourCCs stored in host endian order (other than the hex form being in character order, not the integer value). Acked-by: Rasmus Villemoes Reviewed-by: Andy Shevchenko Reviewed-by: Petr Mladek Tested-by: Petr Mladek Signed-off-by: Hector Martin Signed-off-by: Aditya

[PATCH v3 2/3] printf: add tests for generic FourCCs

2025-04-07 Thread Aditya Garg
From: Aditya Garg This patch adds support for kunit tests of generic 32-bit FourCCs added to vsprintf. Acked-by: Tamir Duberstein Reviewed-by: Andy Shevchenko Signed-off-by: Aditya Garg --- lib/tests/printf_kunit.c | 39 --- 1 file changed, 32 insertions

Re: [PATCH v3 0/3] Use proper printk format in appletbdrm

2025-04-07 Thread Aditya Garg
On 07-04-2025 07:52 pm, Andy Shevchenko wrote: > On Mon, Apr 07, 2025 at 02:17:00PM +0000, Aditya Garg wrote: >>> On 7 Apr 2025, at 7:26 PM, Andy Shevchenko >>> wrote: >>> On Mon, Apr 07, 2025 at 07:05:13PM +0530, Aditya Garg wrote: >>>> The vs

Re: [PATCH v3 0/3] Use proper printk format in appletbdrm

2025-04-07 Thread Aditya Garg
> On 7 Apr 2025, at 7:26 PM, Andy Shevchenko > wrote: > > On Mon, Apr 07, 2025 at 07:05:13PM +0530, Aditya Garg wrote: >> The vsprint patch was originally being sent as a seperate patch [1], and >> I was waiting it to be taken up. But as suggested by Petr, I&#

Re: [PATCH v3 2/3] printf: add tests for generic FourCCs

2025-04-07 Thread Aditya Garg
On 07/04/25 7:07 pm, Aditya Garg wrote: > From: Aditya Garg > > This patch adds support for kunit tests of generic 32-bit FourCCs added to > vsprintf. > > Acked-by: Tamir Duberstein > Reviewed-by: Andy Shevchenko > Signed-off-by: Aditya Garg > --- Petr are you fine with this here?

[PATCH v3 3/3] drm/appletbdrm: use %p4cl instead of %p4cc

2025-04-07 Thread Aditya Garg
From: Aditya Garg Due to lack of a proper printk format, %p4cc was being used instead of %p4cl for the purpose of printing FourCCs. But the disadvange was that they were being printed in a reverse order. %p4cl should correct this issue. Signed-off-by: Aditya Garg --- drivers/gpu/drm/tiny

[PATCH v3 0/3] Use proper printk format in appletbdrm

2025-04-07 Thread Aditya Garg
merged now. [1]: https://lore.kernel.org/lkml/1a03a5b4-93ac-4307-ae6a-4a4c4b7e9...@live.com/ Aditya Garg (2): printf: add tests for generic FourCCs drm/appletbdrm: use %p4cl instead of %p4cc Hector Martin (1): lib/vsprintf: Add support for generic FourCCs by extending %p4cc Documentatio

Re: [PATCH v2 0/2] Use proper printk format in appletbdrm

2025-03-21 Thread Aditya Garg
Hi > On 13 Mar 2025, at 4:48 PM, Aditya Garg wrote: > > The vsprint patch was originally being sent as a seperate patch [1], and > I was waiting it to be taken up. But since 6.15 merge window is near, a > potential delay between the drm and vsprintf patch might make the vsprin

Re: [PATCH v2 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Aditya Garg
> On 13 Mar 2025, at 4:49 PM, Aditya Garg wrote: > > From: Hector Martin > > %p4cc is designed for DRM/V4L2 FourCCs with their specific quirks, but > it's useful to be able to print generic 4-character codes formatted as > an integer. Extend it to add format speci

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Aditya Garg
Hi > On 13 Mar 2025, at 11:10 PM, Kees Cook wrote: > > On Thu, Mar 13, 2025 at 11:48:32AM +0100, Petr Mladek wrote: >> So I am fine with this patch: >> >> Reviewed-by: Petr Mladek >> Tested-by: Petr Mladek >> >> >> Now, the question is how to get this patch into the mainline. >> >> Normal

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Aditya Garg
> On 13 Mar 2025, at 2:19 PM, Andy Shevchenko > wrote: > > On Thu, Mar 13, 2025 at 07:26:05AM +0000, Aditya Garg wrote: >>>> On 13 Mar 2025, at 12:58 AM, Andy Shevchenko >>>> wrote: >>> On Wed, Mar 12, 2025 at 07:14:36PM +, Aditya Garg

[PATCH v2 2/2] drm/appletbdrm: use %p4cl instead of %p4cc

2025-03-13 Thread Aditya Garg
From: Aditya Garg Due to lack of a proper printk format, %p4cc was being used instead of %p4cl for the purpose of printing FourCCs. But the disadvange was that they were being printed in a reverse order. %p4cl should correct this issue. Signed-off-by: Aditya Garg --- drivers/gpu/drm/tiny

[PATCH v2 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Aditya Garg
nting LSByte-first FourCCs stored in host endian order (other than the hex form being in character order, not the integer value). Acked-by: Rasmus Villemoes Reviewed-by: Andy Shevchenko Reviewed-by: Petr Mladek Tested-by: Petr Mladek Signed-off-by: Hector Martin Signed-off-by: Aditya

[PATCH v2 0/2] Use proper printk format in appletbdrm

2025-03-13 Thread Aditya Garg
have observed in LKML, vsprintf patches are being preferred to be taken upon by trees which are actually using them. v2: Remove printf tests, will merge later through Kees' tree [1]: https://lore.kernel.org/lkml/1a03a5b4-93ac-4307-ae6a-4a4c4b7e9...@live.com/ Aditya Garg (1): drm/appletbdrm

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Aditya Garg
> On 13 Mar 2025, at 4:18 PM, Petr Mladek wrote: > > Adding Kees into Cc to resolve how to get this patch into the mainline. > > On Thu 2025-03-13 09:13:23, Aditya Garg wrote: >> >> >>> On 13 Mar 2025, at 2:27 PM, Andy Shevchenko >>> wrote:

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Aditya Garg
> On 13 Mar 2025, at 2:27 PM, Andy Shevchenko > wrote: > > On Thu, Mar 13, 2025 at 08:53:28AM +0000, Aditya Garg wrote: >>>> On 13 Mar 2025, at 2:19 PM, Andy Shevchenko >>>> wrote: >>> On Thu, Mar 13, 2025 at 07:26:05AM +, Aditya Garg wr

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Aditya Garg
> On 13 Mar 2025, at 12:58 AM, Andy Shevchenko > wrote: > > On Wed, Mar 12, 2025 at 07:14:36PM +0000, Aditya Garg wrote: >>> On 12 Mar 2025, at 9:05 PM, Sven Peter wrote: >>> On Wed, Mar 12, 2025, at 13:03, Aditya Garg wrote: > > ... > >>> I

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Aditya Garg
> On 13 Mar 2025, at 12:58 AM, Andy Shevchenko > wrote: > > On Wed, Mar 12, 2025 at 07:14:36PM +0000, Aditya Garg wrote: >>>> On 12 Mar 2025, at 9:05 PM, Sven Peter wrote: >>> On Wed, Mar 12, 2025, at 13:03, Aditya Garg wrote: > > ... > >>

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Aditya Garg
> On 12 Mar 2025, at 9:05 PM, Sven Peter wrote: > > Hi, > > > On Wed, Mar 12, 2025, at 13:03, Aditya Garg wrote: >>>> On 12 Mar 2025, at 5:29 PM, Thomas Zimmermann wrote: >>> >>> Hi >>> >>>> Am 12.03.25 um 12:49

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Aditya Garg
> On 12 Mar 2025, at 5:33 PM, Aditya Garg wrote: > >  > >> On 12 Mar 2025, at 5:29 PM, Thomas Zimmermann wrote: >> >> Hi >> >>>> Am 12.03.25 um 12:49 schrieb Aditya Garg: >>> >>>>> On 12 Mar 2025, at 5:16 PM, T

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Aditya Garg
> On 12 Mar 2025, at 5:29 PM, Thomas Zimmermann wrote: > > Hi > >> Am 12.03.25 um 12:49 schrieb Aditya Garg: >> >>>> On 12 Mar 2025, at 5:16 PM, Thomas Zimmermann wrote: >>> >>> Hi >>> >>>> Am 12.03.25 um 10:05

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Aditya Garg
> On 12 Mar 2025, at 5:16 PM, Thomas Zimmermann wrote: > > Hi > >> Am 12.03.25 um 10:05 schrieb Aditya Garg: >> From: Hector Martin >> >> %p4cc is designed for DRM/V4L2 FourCCs with their specific quirks, but >> it's useful to be able to pri

[PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Aditya Garg
nting LSByte-first FourCCs stored in host endian order (other than the hex form being in character order, not the integer value). Acked-by: Rasmus Villemoes Reviewed-by: Andy Shevchenko Signed-off-by: Hector Martin Signed-off-by: Aditya Garg --- Documentation/core-api/printk-formats.rst

[PATCH 2/2] drm/appletbdm: use %p4cl instead of %p4cc

2025-03-12 Thread Aditya Garg
From: Aditya Garg Due to lack of a proper printk format, %p4cc was being used instead of %p4cl for the purpose of printing FourCCs. But the disadvange was that they were being printed in a reverse order. %p4cl should correct this issue. Signed-off-by: Aditya Garg --- drivers/gpu/drm/tiny

[PATCH 0/2] Use proper printk format in appletbdrm

2025-03-12 Thread Aditya Garg
have observed in LKML, vsprintf patches are being preferred to be taken upon by trees which are actually using them. [1]: https://lore.kernel.org/lkml/1a03a5b4-93ac-4307-ae6a-4a4c4b7e9...@live.com/ Aditya Garg (1): drm/appletbdm: use %p4cl instead of %p4cc Hector Martin (1): lib/vsprintf: Add

Re: [PATCH] drm/appletbdrm: Fix ref-counting on dmadev

2025-03-07 Thread Aditya Garg
> On 7 Mar 2025, at 2:48 PM, Thomas Zimmermann wrote: > > Hi > > Am 07.03.25 um 10:16 schrieb Aditya Garg: >> Hi Thomas >> >>> On 7 Mar 2025, at 2:06 PM, Thomas Zimmermann wrote: >>> >>> Remove the put_device() call on dmadev. The dri

Re: [PATCH v2 2/5] drm/appletbdrm: Set struct drm_device.dma_dev

2025-03-07 Thread Aditya Garg
pu/drm/tiny/appletbdrm.c | 27 ++- > 1 file changed, 10 insertions(+), 17 deletions(-) For this patch Tested-by: Aditya Garg Reviewed-by: Aditya Garg

Re: [PATCH] drm/appletbdrm: Fix ref-counting on dmadev

2025-03-07 Thread Aditya Garg
; maintains a reference internally. Hence dmadev will not become dangling > during the DRM device's lifetime. > > Signed-off-by: Thomas Zimmermann > Fixes: 0670c2f56e45 ("drm/tiny: add driver for Apple Touch Bars in x86 Macs") > Cc: Aditya Garg > Cc: Aun-Ali Zaid

Re: [PATCH] drm/tiny: fix printk format string for 32-bit

2025-03-04 Thread Aditya Garg
Hi > On 4 Mar 2025, at 7:57 PM, Arnd Bergmann wrote: > > From: Arnd Bergmann > > A size_t must be printed with the %z modifier instead of %l: > > In file included from include/linux/device.h:15, > from include/linux/usb.h:19, > from drivers/gpu/drm/tiny/appletb

Re: [PATCH] drm/appletbdrm: Fix format specifier for size_t variables

2025-03-04 Thread Aditya Garg
> On 4 Mar 2025, at 6:49 PM, Nathan Chancellor wrote: > > When building for a 32-bit platform, there are some warnings (or errors > with CONFIG_WERROR=y) due to an incorrect specifier for 'size_t' > variables, which is typedef'd as 'unsigned int' for these architectures: > > drivers/gpu/drm/

Re: [PATCH] drm/appletbdrm: fix format character for size_t

2025-03-04 Thread Aditya Garg
c2f56e45 ("drm/tiny: add driver for Apple Touch Bars in x86 Macs") > Cc: Kerem Karabay > Cc: Atharva Tiwari > Cc: Aditya Garg > Cc: Aun-Ali Zaidi > Cc: Thomas Zimmermann > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/tiny/appletbdrm.c | 4 ++-- > 1

Re: [PATCH v7 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-03-03 Thread Aditya Garg
> On 3 Mar 2025, at 9:15 PM, Thomas Zimmermann wrote: > > Hi > >> Am 27.02.25 um 10:42 schrieb Aditya Garg: >>>> On 27 Feb 2025, at 3:04 PM, Thomas Zimmermann wrote: >>> Hi >>>> Am 26.02.25 um 17:04 schrieb Aditya Garg: >>>

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-27 Thread Aditya Garg
> On 27 Feb 2025, at 10:24 PM, kernel test robot wrote: > > Hi Aditya, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on linus/master] > [also build test WARNING on v6.14-rc4 next-20250227] > [If your patch is applied to the wrong git tree, kindly dr

Re: [PATCH v7 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-27 Thread Aditya Garg
> On 27 Feb 2025, at 3:04 PM, Thomas Zimmermann wrote: > > Hi > >> Am 26.02.25 um 17:04 schrieb Aditya Garg: >> From: Kerem Karabay >> >> The Touch Bars found on x86 Macs support two USB configurations: one >> where the device presents itself as a

[PATCH v7 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-26 Thread Aditya Garg
driver was reverse-engineered the actual data types of the protocol might be different, including, but not limited to, endianness. Link: https://github.com/imbushuo/DFRDisplayKm Signed-off-by: Kerem Karabay Co-developed-by: Atharva Tiwari Signed-off-by: Atharva Tiwari Co-developed-by: Aditya Garg

[PATCH v7 1/2] drm/format-helper: Add conversion from XRGB8888 to BGR888

2025-02-26 Thread Aditya Garg
From: Kerem Karabay Add XRGB emulation helper for devices that only support BGR888. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg Reviewed-by: Thomas Zimmermann --- v2 -> Fix incorrect description v3 -> No change in this patch v4 -> No change in this patch v5 ->

[PATCH v7 0/2] Touch Bar DRM driver for x86 Macs

2025-02-26 Thread Aditya Garg
Hi all! This patch series aims to improve the Touch Bar support for x86 Macs. Recently, the hid-appletb-kbd and hid-appletb-bl drivers were upstreamed into the Linux kernel [1]. They enabled the Touch Bar to display a predefined set of media and function keys, exactly the same it does on Windows

Re: [PATCH v5 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-25 Thread Aditya Garg
> On 25 Feb 2025, at 9:39 PM, Aditya Garg wrote: > > > >> On 25 Feb 2025, at 9:36 PM, Thomas Zimmermann wrote: >> >> Hi >> >> Am 25.02.25 um 15:54 schrieb Aditya Garg: >> [...] >>>>>> +static int appletbdrm_prob

[PATCH v6 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-25 Thread Aditya Garg
driver was reverse-engineered the actual data types of the protocol might be different, including, but not limited to, endianness. Link: https://github.com/imbushuo/DFRDisplayKm Signed-off-by: Kerem Karabay Co-developed-by: Atharva Tiwari Signed-off-by: Atharva Tiwari Co-developed-by: Aditya Garg

[PATCH v6 1/2] drm/format-helper: Add conversion from XRGB8888 to BGR888

2025-02-25 Thread Aditya Garg
From: Kerem Karabay Add XRGB emulation helper for devices that only support BGR888. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg Reviewed-by: Thomas Zimmermann --- v2 -> Fix incorrect description v3 -> No change in this patch v4 -> No change in this patch v5 ->

[PATCH v6 0/2] Touch Bar DRM driver for x86 Macs

2025-02-25 Thread Aditya Garg
Hi all! This patch series aims to improve the Touch Bar support for x86 Macs. Recently, the hid-appletb-kbd and hid-appletb-bl drivers were upstreamed into the Linux kernel [1]. They enabled the Touch Bar to display a predefined set of media and function keys, exactly the same it does on Windows

Re: [PATCH v5 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-25 Thread Aditya Garg
> On 25 Feb 2025, at 9:36 PM, Thomas Zimmermann wrote: > > Hi > > Am 25.02.25 um 15:54 schrieb Aditya Garg: > [...] >>>>> +static int appletbdrm_probe(struct usb_interface *intf, >>>>> +const struct usb_device_id *id) &g

Re: [PATCH v5 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-25 Thread Aditya Garg
> On 25 Feb 2025, at 8:40 PM, Aditya Garg wrote: > >  > >> On 25 Feb 2025, at 8:24 PM, Aditya Garg wrote: >> >>  >> >>>> On 25 Feb 2025, at 5:28 PM, Thomas Zimmermann wrote: >>> >>> Hi >>> >>>>

Re: [PATCH v5 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-25 Thread Aditya Garg
> On 25 Feb 2025, at 8:24 PM, Aditya Garg wrote: > >  > >> On 25 Feb 2025, at 5:28 PM, Thomas Zimmermann wrote: >> >> Hi >> >>> Am 25.02.25 um 11:33 schrieb andriy.shevche...@linux.intel.com: >>>>> On Tue, Feb 25, 2025 at 10

Re: [PATCH v5 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-25 Thread Aditya Garg
> On 25 Feb 2025, at 8:26 PM, Aditya Garg wrote: > >  > >> On 25 Feb 2025, at 8:24 PM, Aditya Garg wrote: >> >>  >> >>>> On 25 Feb 2025, at 5:28 PM, Thomas Zimmermann wrote: >>> >>> Hi >>> >>>>

Re: [PATCH v5 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-25 Thread Aditya Garg
> On 25 Feb 2025, at 8:24 PM, Aditya Garg wrote: > >  > >> On 25 Feb 2025, at 5:28 PM, Thomas Zimmermann wrote: >> >> Hi >> >>> Am 25.02.25 um 11:33 schrieb andriy.shevche...@linux.intel.com: >>>>> On Tue, Feb 25, 2025 at 10

Re: [PATCH v5 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-25 Thread Aditya Garg
> On 25 Feb 2025, at 5:28 PM, Thomas Zimmermann wrote: > > Hi > >> Am 25.02.25 um 11:33 schrieb andriy.shevche...@linux.intel.com: >>> On Tue, Feb 25, 2025 at 10:09:42AM +, Aditya Garg wrote: >>> From: Kerem Karabay >>> >>

Re: [PATCH 1/6] drm/ast: Remove redundant else in atomic_check

2025-02-25 Thread Aditya Garg
> On 25 Feb 2025, at 5:19 PM, Thomas Zimmermann wrote: > > Hi > >> Am 25.02.25 um 12:06 schrieb Aditya Garg: >> From: Aditya Garg >> >> Remove the redundant else statement from atomic_check since the previous if >> statement was returning

Re: [PATCH v5 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-25 Thread Aditya Garg
> On 25 Feb 2025, at 4:17 PM, andriy.shevche...@linux.intel.com wrote: > > On Tue, Feb 25, 2025 at 10:36:03AM +0000, Aditya Garg wrote: >>>> On 25 Feb 2025, at 4:03 PM, andriy.shevche...@linux.intel.com wrote: >>> On Tue, Feb 25, 2025 at 10:09

[PATCH 6/6] drm/mgag200: Remove redundant else in atomic_check

2025-02-25 Thread Aditya Garg
From: Aditya Garg Remove the redundant else statement from atomic_check since the previous if statement was returning if true. Signed-off-by: Aditya Garg --- drivers/gpu/drm/mgag200/mgag200_mode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200

[PATCH 5/6] drm/simpledrm: Remove redundant else in atomic_check

2025-02-25 Thread Aditya Garg
From: Aditya Garg Remove the redundant else statement from atomic_check since the previous if statement was returning if true. Signed-off-by: Aditya Garg --- drivers/gpu/drm/tiny/simpledrm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tiny/simpledrm.c

[PATCH 4/6] drm/bochs: Remove redundant else in atomic_check

2025-02-25 Thread Aditya Garg
From: Aditya Garg Remove the redundant else statement from atomic_check since the previous if statement was returning if true. Signed-off-by: Aditya Garg --- drivers/gpu/drm/tiny/bochs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tiny/bochs.c b

[PATCH 3/6] drm/offdrm: Remove redundant else in atomic_check

2025-02-25 Thread Aditya Garg
From: Aditya Garg Remove the redundant else statement from atomic_check since the previous if statement was returning if true. Signed-off-by: Aditya Garg --- drivers/gpu/drm/tiny/ofdrm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tiny/ofdrm.c b

[PATCH 2/6] drm/cirrus-qemu: Remove redundant else in atomic_check

2025-02-25 Thread Aditya Garg
From: Aditya Garg Remove the redundant else statement from atomic_check since the previous if statement was returning if true. Signed-off-by: Aditya Garg --- drivers/gpu/drm/tiny/cirrus-qemu.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tiny

[PATCH 1/6] drm/ast: Remove redundant else in atomic_check

2025-02-25 Thread Aditya Garg
From: Aditya Garg Remove the redundant else statement from atomic_check since the previous if statement was returning if true. Signed-off-by: Aditya Garg --- drivers/gpu/drm/ast/ast_mode.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_mode.c

[PATCH 0/6] drm: remove redundant else across drivers

2025-02-25 Thread Aditya Garg
of simple_display_pipe. [1]: https://lore.kernel.org/dri-devel/z7igvxqvrytvf...@smile.fi.intel.com/ Aditya Garg (6): drm/ast: Remove redundant else in atomic_check drm/cirrus-qemu: Remove redundant else in atomic_check drm/offdrm: Remove redundant else in atomic_check drm/bochs: Remove

Re: [PATCH v5 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-25 Thread Aditya Garg
> On 25 Feb 2025, at 4:17 PM, andriy.shevche...@linux.intel.com wrote: > > On Tue, Feb 25, 2025 at 10:36:03AM +0000, Aditya Garg wrote: >>>> On 25 Feb 2025, at 4:03 PM, andriy.shevche...@linux.intel.com wrote: >>> On Tue, Feb 25, 2025 at 10:09

Re: [PATCH v5 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-25 Thread Aditya Garg
> On 25 Feb 2025, at 4:03 PM, andriy.shevche...@linux.intel.com wrote: > > On Tue, Feb 25, 2025 at 10:09:42AM +0000, Aditya Garg wrote: >> From: Kerem Karabay >> >> The Touch Bars found on x86 Macs support two USB configurations: one >> where the device pres

[PATCH v5 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-25 Thread Aditya Garg
driver was reverse-engineered the actual data types of the protocol might be different, including, but not limited to, endianness. Link: https://github.com/imbushuo/DFRDisplayKm Signed-off-by: Kerem Karabay Co-developed-by: Atharva Tiwari Signed-off-by: Atharva Tiwari Co-developed-by: Aditya Garg

[PATCH v5 1/2] drm/format-helper: Add conversion from XRGB8888 to BGR888

2025-02-25 Thread Aditya Garg
From: Kerem Karabay Add XRGB emulation helper for devices that only support BGR888. Reviewed-by: Thomas Zimmermann Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg --- v2 -> Fix incorrect description v3 -> No change in this patch v4 -> No change in this patch v5 ->

[PATCH v5 0/2] Touch Bar DRM driver for x86 Macs

2025-02-25 Thread Aditya Garg
Hi all! This patch series aims to improve the Touch Bar support for x86 Macs. Recently, the hid-appletb-kbd and hid-appletb-bl drivers were upstreamed into the Linux kernel [1]. They enabled the Touch Bar to display a predefined set of media and function keys, exactly the same it does on Windows

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-25 Thread Aditya Garg
> On 25 Feb 2025, at 3:07 PM, Aditya Garg wrote: > >  > >> On 25 Feb 2025, at 3:05 PM, Thomas Zimmermann wrote: >> >> Hi >> >>>> Am 25.02.25 um 10:07 schrieb Aditya Garg: >>> >>>>> On 25 Feb 2025, at 2:34 PM,

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-25 Thread Aditya Garg
> On 25 Feb 2025, at 3:05 PM, Thomas Zimmermann wrote: > > Hi > >> Am 25.02.25 um 10:07 schrieb Aditya Garg: >> >>>> On 25 Feb 2025, at 2:34 PM, Aditya Garg wrote: >>> >>>  >>> >>>> On 25 Feb 2025, at 1:27 P

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-25 Thread Aditya Garg
> On 25 Feb 2025, at 2:34 PM, Aditya Garg wrote: > >  > >> On 25 Feb 2025, at 1:27 PM, Thomas Zimmermann wrote: >> >> Hi >> >> Am 24.02.25 um 17:58 schrieb Aditya Garg: >> [...] >>>> >>>> +config DRM_APPLETBDRM &g

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-25 Thread Aditya Garg
> On 25 Feb 2025, at 1:27 PM, Thomas Zimmermann wrote: > > Hi > > Am 24.02.25 um 17:58 schrieb Aditya Garg: > [...] >>> >>> +config DRM_APPLETBDRM >>> +tristate "DRM support for Apple Touch Bars" >>> +depends on DRM &a

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-25 Thread Aditya Garg
> On 25 Feb 2025, at 1:22 PM, Thomas Zimmermann wrote: > > Hi > >> Am 24.02.25 um 14:40 schrieb Aditya Garg: >> From: Kerem Karabay >> >> The Touch Bars found on x86 Macs support two USB configurations: one >> where the device presents itself as a

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-25 Thread Aditya Garg
> On 25 Feb 2025, at 1:27 PM, Thomas Zimmermann wrote: > > Hi > > Am 24.02.25 um 17:58 schrieb Aditya Garg: > [...] >>> >>> +config DRM_APPLETBDRM >>> +tristate "DRM support for Apple Touch Bars" >>> +depends on DRM &a

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-24 Thread Aditya Garg
> On 24 Feb 2025, at 7:10 PM, Aditya Garg wrote: > > From: Kerem Karabay > > The Touch Bars found on x86 Macs support two USB configurations: one > where the device presents itself as a HID keyboard and can display > predefined sets of keys, and one where the oper

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-24 Thread Aditya Garg
> On 24 Feb 2025, at 9:45 PM, andriy.shevche...@linux.intel.com wrote: > > On Mon, Feb 24, 2025 at 03:56:36PM +0000, Aditya Garg wrote: >>>> On 24 Feb 2025, at 9:23 PM, andriy.shevche...@linux.intel.com wrote: >>> On Mon, Feb 24, 2025 at 03:40:29PM +, Adity

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-24 Thread Aditya Garg
> On 24 Feb 2025, at 9:26 PM, Aditya Garg wrote: > >  > >> On 24 Feb 2025, at 9:23 PM, andriy.shevche...@linux.intel.com wrote: >> >> On Mon, Feb 24, 2025 at 03:40:29PM +, Aditya Garg wrote: >>>>> On 24 Feb 2025, at 9:08 PM, andriy.shevche.

Re: [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc

2025-02-24 Thread Aditya Garg
I request the printk maintainers for their views on whether if they are ok with the sparse errors in this original patch. > On 20 Feb 2025, at 10:09 PM, Aditya Garg wrote: > > From: Hector Martin > > %p4cc is designed for DRM/V4L2 FOURCCs with their specific quirks, but >

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-24 Thread Aditya Garg
> On 24 Feb 2025, at 9:23 PM, andriy.shevche...@linux.intel.com wrote: > > On Mon, Feb 24, 2025 at 03:40:29PM +0000, Aditya Garg wrote: >>>> On 24 Feb 2025, at 9:08 PM, andriy.shevche...@linux.intel.com wrote: >>> On Mon, Feb 24, 2025 at 03:32:56PM +, Adit

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-24 Thread Aditya Garg
> On 24 Feb 2025, at 9:19 PM, andriy.shevche...@linux.intel.com wrote: > > On Mon, Feb 24, 2025 at 03:39:56PM +0000, Aditya Garg wrote: >>>> On 24 Feb 2025, at 9:07 PM, andriy.shevche...@linux.intel.com wrote: >>> On Mon, Feb 24, 2025 at 03:20:13PM +, Adity

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-24 Thread Aditya Garg
> On 24 Feb 2025, at 9:08 PM, andriy.shevche...@linux.intel.com wrote: > > On Mon, Feb 24, 2025 at 03:32:56PM +0000, Aditya Garg wrote: >>> On 24 Feb 2025, at 8:50 PM, Aditya Garg wrote: >>>> On 24 Feb 2025, at 8:41 PM, andriy.shevche...@linux.intel.com wrote: &

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-24 Thread Aditya Garg
> On 24 Feb 2025, at 9:07 PM, andriy.shevche...@linux.intel.com wrote: > > On Mon, Feb 24, 2025 at 03:20:13PM +0000, Aditya Garg wrote: >>>> On 24 Feb 2025, at 8:41 PM, andriy.shevche...@linux.intel.com wrote: >>> On Mon, Feb 24, 2025 at 03:03:40PM +, Adity

  1   2   3   >