RE: [EXT] Re: [PATCH 2/3] dt-bindings: display: panel: Add waveshare DPI panel support

2025-07-23 Thread Joseph Guo
HI, > -Original Message- > From: Rob Herring (Arm) > Sent: Monday, July 21, 2025 6:53 AM > To: Joseph Guo > Cc: Robert Foss ; Maxime Ripard ; > Thomas Zimmermann ; dri- > de...@lists.freedesktop.org; Maarten Lankhorst > ; Simona Vetter ; > Laurent Pinchart ; Jonas Karlman > ; David Air

[PULL] drm-misc-next-fixes

2025-07-23 Thread Maxime Ripard
Hi, Here's this week drm-misc-next-fixes PR. Maxime drm-misc-next-fixes-2025-07-24: Two more bridge conversions to devm_drm_bridge_alloc that address a warning now reported by the bridge core code. The following changes since commit fe69a391808404977b1f002a6e7447de3de7a88e: drm/panthor: Fix U

Re: [PATCH] drm/bridge: it6505: select REGMAP_I2C

2025-07-23 Thread Chen-Yu Tsai
On Tue, Jun 10, 2025 at 04:58:25PM -0700, Chia-I Wu wrote: > Fix > > aarch64-linux-gnu-ld: drivers/gpu/drm/bridge/ite-it6505.o: in function > `it6505_i2c_probe': > ite-it6505.c:(.text+0x754): undefined reference to `__devm_regmap_init_i2c' Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver"

Re: [PATCH v6 0/6] Add support for new Mali GPUs

2025-07-23 Thread Chia-I Wu
On Mon, Jul 21, 2025 at 2:36 PM Karunika Choo wrote: > > This patch series introduces some minor refactoring to enable support > for new Mali GPUs. > > Key changes: > - Addition of cache maintenance via the FLUSH_CACHES GPU command for all > supported GPUs in place of FLUSH_MEM and FLUSH_PT MMU_

Re: [PATCH v6 6/6] drm/panthor: Add support for Mali-Gx20 and Mali-Gx25 GPUs

2025-07-23 Thread Chia-I Wu
On Mon, Jul 21, 2025 at 3:53 PM Karunika Choo wrote: > > This patch adds firmware binary and GPU model naming support for > Mali-Gx20 and Mali-Gx25 GPUs. > > The GPU_COHERENCY_FEATURES macros are slightly reworked as the > assumption that FEATURE = BIT(PROTOCOL) no longer holds with the > introduc

Re: [PATCH 10/10] vfio/pci: Add dma-buf export support for MMIO regions

2025-07-23 Thread Leon Romanovsky
On Thu, Jul 24, 2025 at 05:13:49AM +, Kasireddy, Vivek wrote: > Hi Leon, > > > Subject: [PATCH 10/10] vfio/pci: Add dma-buf export support for MMIO > > regions > > > > From: Leon Romanovsky > > > > Add support for exporting PCI device MMIO regions through dma-buf, > > enabling safe sharing

Re: [PATCH v6 4/6] drm/panthor: Add support for Mali-Gx15 family of GPUs

2025-07-23 Thread Chia-I Wu
On Mon, Jul 21, 2025 at 3:13 PM Karunika Choo wrote: > > Mali-Gx15 introduces a new GPU_FEATURES register that provides > information about GPU-wide supported features. The register value will > be passed on to userspace via gpu_info. > > Additionally, Mali-Gx15 presents an 'Immortalis' naming var

Re: [PATCH v5 3/6] drm/panthor: Add support for Mali-G710, Mali-G510 and Mali-G310

2025-07-23 Thread Chia-I Wu
On Mon, Jul 21, 2025 at 4:33 AM Karunika Choo wrote: > > This patch adds GPU model name and FW binary support for Mali-G710, > Mali-G510, and Mali-G310. > > Signed-off-by: Karunika Choo > --- > drivers/gpu/drm/panthor/panthor_fw.c | 2 ++ > drivers/gpu/drm/panthor/panthor_hw.c | 6 ++ > 2 fi

Re: [PATCH v5 6/9] drm/xe/doc: Document device wedged and runtime survivability

2025-07-23 Thread Riana Tauro
On 7/23/2025 7:04 PM, Raag Jadav wrote: On Tue, Jul 15, 2025 at 04:17:26PM +0530, Riana Tauro wrote: Add documentation for vendor specific device wedged recovery method and runtime survivability. ... diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c index bd81eb

RE: [PATCH 10/10] vfio/pci: Add dma-buf export support for MMIO regions

2025-07-23 Thread Kasireddy, Vivek
Hi Leon, > Subject: [PATCH 10/10] vfio/pci: Add dma-buf export support for MMIO > regions > > From: Leon Romanovsky > > Add support for exporting PCI device MMIO regions through dma-buf, > enabling safe sharing of non-struct page memory with controlled > lifetime management. This allows RDMA an

RE: [PATCH] iosys-map: Fix undefined behavior in iosys_map_clear()

2025-07-23 Thread Gote, Nitin R
Hi Thomas, > > Hi > > Am 18.07.25 um 16:47 schrieb Andi Shyti: > > Hi Nitin, > > > > On Fri, Jul 18, 2025 at 04:20:51PM +0530, Nitin Gote wrote: > >> The current iosys_map_clear() implementation reads the potentially > >> uninitialized 'is_iomem' boolean field to decide which union member > >> t

Re: [PATCH] drm/sched: Prevent stopped entities from being added to the run queue.

2025-07-23 Thread Matthew Brost
On Wed, Jul 23, 2025 at 09:13:34PM -0700, Matthew Brost wrote: > On Wed, Jul 23, 2025 at 08:56:01AM +0200, Philipp Stanner wrote: > > On Tue, 2025-07-22 at 01:45 -0700, Matthew Brost wrote: > > > On Tue, Jul 22, 2025 at 01:07:29AM -0700, Matthew Brost wrote: > > > > On Tue, Jul 22, 2025 at 09:37:11

Re: [PATCH] drm/sched: Prevent stopped entities from being added to the run queue.

2025-07-23 Thread Matthew Brost
On Wed, Jul 23, 2025 at 08:56:01AM +0200, Philipp Stanner wrote: > On Tue, 2025-07-22 at 01:45 -0700, Matthew Brost wrote: > > On Tue, Jul 22, 2025 at 01:07:29AM -0700, Matthew Brost wrote: > > > On Tue, Jul 22, 2025 at 09:37:11AM +0200, Philipp Stanner wrote: > > > > On Mon, 2025-07-21 at 11:07 -0

[PATCH] fbdev: Check fb_add_videomode to prevent null-ptr-deref

2025-07-23 Thread Chenyuan Yang
fb_add_videomode() can fail with -ENOMEM when its internal kmalloc() cannot allocate a struct fb_modelist. If that happens, the modelist stays empty but the driver continues to register. Add a check for its return value to prevent poteintial null-ptr-deref, which is similar to the commit 17186f1f90

Re: [PATCH v6 09/12] tee: add Qualcomm TEE driver

2025-07-23 Thread Amirreza Zarrabi
Hi Sumit, On 7/21/2025 8:40 PM, Sumit Garg wrote: > On Sun, Jul 13, 2025 at 05:49:21PM -0700, Amirreza Zarrabi wrote: >> Introduce qcomtee_object, which represents an object in both QTEE and >> the kernel. QTEE clients can invoke an instance of qcomtee_object to >> access QTEE services. If this in

[PATCH] fbdev: atmel_lcdfb: Fix potential NULL dereference

2025-07-23 Thread Salah Triki
of_match_device() returns NULL in case of failure, so check its return value before casting and accessing to data field in order to prevent NULL dereference. Signed-off-by: Salah Triki --- drivers/video/fbdev/atmel_lcdfb.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[PATCH] drm/amd/display: Add null pointer check in mod_hdcp_hdcp1_create_session()

2025-07-23 Thread Chenyuan Yang
The function mod_hdcp_hdcp1_create_session() calls the function get_first_active_display(), but does not check its return value. The return value is a null pointer if the display list is empty. This will lead to a null pointer dereference. Add a null pointer check for get_first_active_display() an

Re: [git pull] drm fixes for 6.16-rc8/final (resend in txt for sure)

2025-07-23 Thread pr-tracker-bot
The pull request you sent on Thu, 24 Jul 2025 10:40:08 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2025-07-24 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/25fae0b93d1d7ddb25958bcb90c3c0e5e0e202bd Thank you! -- Deet-doot-dot, I am a bot. h

Re: [git pull] drm fixes for 6.16-rc8/final (resend in txt for sure)

2025-07-23 Thread Dave Airlie
On Thu, 24 Jul 2025 at 11:59, Linus Torvalds wrote: > > On Wed, 23 Jul 2025 at 17:40, Dave Airlie wrote: > > > > (this time for sure, plain text). > > I knew you could do it! Third time's the charm! > > I hope I don't need to worry about the branch contents as much as I > apparently need to worry

Re: [PATCH] drm/bridge: Add null pointer check for ITE IT6263

2025-07-23 Thread Liu Ying
Hi Chenyuan, On 07/23/2025, Chenyuan Yang wrote: > On Tue, Jul 22, 2025 at 23:57 Maxime Ripard wrote: > >> On Tue, Jul 22, 2025 at 03:41:14PM -0500, Chenyuan Yang wrote: >>> drm_atomic_get_new_connector_for_encoder and >>> drm_atomic_get_new_connector_state could return Null. >> >> They can, but

Re: [git pull] drm fixes for 6.16-rc8/final (resend in txt for sure)

2025-07-23 Thread Linus Torvalds
On Wed, 23 Jul 2025 at 17:40, Dave Airlie wrote: > > (this time for sure, plain text). I knew you could do it! Third time's the charm! I hope I don't need to worry about the branch contents as much as I apparently need to worry about your email sending capabilities? Linus

Re: [PATCH v12 10/12] drm/msm/dpu: support SSPP assignment for quad-pipe case

2025-07-23 Thread Jun Nie
Dmitry Baryshkov 于2025年7月22日周二 20:04写道: > > On Mon, Jul 21, 2025 at 04:06:13PM +0800, Jun Nie wrote: > > Dmitry Baryshkov 于2025年7月19日周六 18:09写道: > > > > > > On Mon, Jul 07, 2025 at 02:18:05PM +0800, Jun Nie wrote: > > > > Currently, SSPPs are assigned to a maximum of two pipes. However, > > > > q

Re: [PATCH v5 01/23] Introduce drm_gpuvm_sm_map_ops_flags enums for sm_map_ops

2025-07-23 Thread Matthew Brost
On Tue, Jul 22, 2025 at 03:38:14PM +0200, Danilo Krummrich wrote: > (Cc: Caterina) > > On Tue Jul 22, 2025 at 3:35 PM CEST, Himal Prasad Ghimiray wrote: > > - DRM_GPUVM_SM_MAP_NOT_MADVISE: Default sm_map operations for the input > > range. > > > > - DRM_GPUVM_SKIP_GEM_OBJ_VA_SPLIT_MADVISE: This

[git pull] drm fixes for 6.16-rc8/final (resend in txt for sure)

2025-07-23 Thread Dave Airlie
(this time for sure, plain text). Hi Linus, This might just be part one, but I'm sending it a bit early as it has two sets of reverts for regressions, one is all the gem/dma-buf handling and another was a nouveau ioctl change. Otherwise there is an amdgpu fix, nouveau fix and a scheduler fix. I

[git pull] drm fixes for 6.16-rc8/final (resend)

2025-07-23 Thread Dave Airlie
(somehow fat fingered into HTML writing the first time) Hi Linus, This might just be part one, but I'm sending it a bit early as it has two sets of reverts for regressions, one is all the gem/dma-buf handling and another was a nouveau ioctl change. Otherwise there is an amdgpu fix, nouveau fix a

[git pull] drm fixes for 6.16-rc8/final

2025-07-23 Thread Dave Airlie
Hi Linus, This might just be part one, but I'm sending it a bit early as it has two sets of reverts for regressions, one is all the gem/dma-buf handling and another was a nouveau ioctl change. Otherwise there is an amdgpu fix, nouveau fix and a scheduler fix. If any other changes come in I'll fo

Re: [PATCH v2 14/15] drm: sprd: implement IOMMU-based buffer management

2025-07-23 Thread kernel test robot
Hi Otto, kernel test robot noticed the following build warnings: [auto build test WARNING on 05adbee3ad528100ab0285c15c91100e19e10138] url: https://github.com/intel-lab-lkp/linux/commits/Otto-Pfl-ger/dt-bindings-display-sprd-adapt-for-UMS9230-support/20250722-224414 base: 05adbee3ad528100a

[PATCH 2/2] drm/msm: Handle in-place remaps

2025-07-23 Thread Rob Clark
Handle the special case of a MAP op simply updating the va flags by detecting the special case, and skip pgtable updates. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_vma.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_

[PATCH 1/2] drm/gpuvm: Send in-place re-maps to the driver as remap

2025-07-23 Thread Rob Clark
The 'keep' hint on the unmap is only half useful, without being able to link it to a map cb. Instead combine the two ops into a remap op to give the driver a chance to figure things out. Signed-off-by: Rob Clark --- In theory, drivers should treat an unmap+map combined in a remap step the same a

[PATCH 0/2] drm/gpuvm+msm: Handle in-place remaps

2025-07-23 Thread Rob Clark
turnip+msm uses a DUMP flag on the gpuva to indicate VA ranges to dump (ie. for devcoredump). In most cases (internal BOs like shader instructions) this is known at the time the BO is MAPd, and the DUMP flag can be set at the same time as the BO is initially bound into the VM. But for descriptor

Re: [PATCH 16/17] drm/msm/a6xx: Enable IFPC on Adreno X1-85

2025-07-23 Thread Akhil P Oommen
On 7/23/2025 4:03 PM, Konrad Dybcio wrote: > On 7/22/25 11:37 PM, Akhil P Oommen wrote: >> On 7/22/2025 7:25 PM, Dmitry Baryshkov wrote: >>> On Sun, Jul 20, 2025 at 05:46:17PM +0530, Akhil P Oommen wrote: Add the IFPC restore register list and enable IFPC support on Adreno X1-85 gpu. >>>

Re: [PATCH 15/17] drm/msm/a6xx: Make crashstate capture IFPC safe

2025-07-23 Thread Akhil P Oommen
On 7/23/2025 4:02 PM, Konrad Dybcio wrote: > On 7/20/25 2:16 PM, Akhil P Oommen wrote: >> Now with IFPC, GX domain can collapse as soon as GPU becomes IDLE. So >> add gx_is_on check before accessing any GX registers during crashstate >> capture and recovery. >> >> Signed-off-by: Akhil P Oommen >>

Re: [PATCH 08/17] drm/msm/a6xx: Set Keep-alive votes to block IFPC

2025-07-23 Thread Dmitry Baryshkov
On Thu, Jul 24, 2025 at 02:52:52AM +0530, Akhil P Oommen wrote: > On 7/23/2025 3:35 PM, Konrad Dybcio wrote: > > On 7/22/25 11:24 PM, Akhil P Oommen wrote: > >> On 7/22/2025 7:14 PM, Dmitry Baryshkov wrote: > >>> On Sun, Jul 20, 2025 at 05:46:09PM +0530, Akhil P Oommen wrote: > Set Keepalive v

Re: [PATCH 12/17] drm/msm: Skip devfreq IDLE when possible

2025-07-23 Thread Akhil P Oommen
On 7/23/2025 1:43 AM, Rob Clark wrote: > On Tue, Jul 22, 2025 at 12:23 PM Akhil P Oommen > wrote: >> >> On 7/22/2025 9:08 PM, Rob Clark wrote: >>> On Tue, Jul 22, 2025 at 6:50 AM Dmitry Baryshkov >>> wrote: On Sun, Jul 20, 2025 at 05:46:13PM +0530, Akhil P Oommen wrote: > When IFPC

Re: [PATCH 11/17] drm/msm: Add support for IFPC

2025-07-23 Thread Akhil P Oommen
On 7/23/2025 3:57 PM, Konrad Dybcio wrote: > On 7/22/25 11:27 PM, Akhil P Oommen wrote: >> On 7/22/2025 7:19 PM, Dmitry Baryshkov wrote: >>> On Sun, Jul 20, 2025 at 05:46:12PM +0530, Akhil P Oommen wrote: Add a new quirk to denote IFPC (Inter-Frame Power Collapse) support for a gpu. Based

Re: [PATCH 08/17] drm/msm/a6xx: Set Keep-alive votes to block IFPC

2025-07-23 Thread Akhil P Oommen
On 7/23/2025 3:35 PM, Konrad Dybcio wrote: > On 7/22/25 11:24 PM, Akhil P Oommen wrote: >> On 7/22/2025 7:14 PM, Dmitry Baryshkov wrote: >>> On Sun, Jul 20, 2025 at 05:46:09PM +0530, Akhil P Oommen wrote: Set Keepalive votes at appropriate places to block IFPC power collapse until we acce

Re: [PATCH 07/17] drm/msm/adreno: Add fenced regwrite support

2025-07-23 Thread Akhil P Oommen
On 7/22/2025 8:22 PM, Konrad Dybcio wrote: > On 7/22/25 3:39 PM, Dmitry Baryshkov wrote: >> On Sun, Jul 20, 2025 at 05:46:08PM +0530, Akhil P Oommen wrote: >>> There are some special registers which are accessible even when GX power >>> domain is collapsed during an IFPC sleep. Accessing these regi

Re: [PATCH 07/17] drm/msm/adreno: Add fenced regwrite support

2025-07-23 Thread Akhil P Oommen
On 7/22/2025 7:09 PM, Dmitry Baryshkov wrote: > On Sun, Jul 20, 2025 at 05:46:08PM +0530, Akhil P Oommen wrote: >> There are some special registers which are accessible even when GX power >> domain is collapsed during an IFPC sleep. Accessing these registers >> wakes up GPU from power collapse and

[PATCH 0/2] drm/msm: Defer fd_install()

2025-07-23 Thread Rob Clark
The first patch fixes an issue that Dan Carpenter reported in https://lore.kernel.org/all/55953f27-0762-4ef2-8dda-3208b34a5c75@sabinyo.mountain/ and the second fixes the same issue in the more recently introduced VM_BIND ioctl. Rob Clark (2): drm/msm: Defer fd_install in SUBMIT ioctl drm/msm:

[PATCH 2/2] drm/msm: Defer fd_install in VM_BIND ioctl

2025-07-23 Thread Rob Clark
Avoid fd_install() until there are no more potential error paths, to avoid put_unused_fd() after the fd is made visible to userspace. Fixes: 03b6becb03c8 ("Merge tag 'drm-msm-next-2025-07-05' into HEAD") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_vma.c | 14 +++--- 1 file c

[PATCH 1/2] drm/msm: Defer fd_install in SUBMIT ioctl

2025-07-23 Thread Rob Clark
Avoid fd_install() until there are no more potential error paths, to avoid put_unused_fd() after the fd is made visible to userspace. Fixes: 68dc6c2d5eec ("drm/msm: Fix submit error-path leaks") Reported-by: Dan Carpenter Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_submit.c | 14 ++

[PATCH] drivers/gpu: Fix typos

2025-07-23 Thread Bjorn Helgaas
From: Bjorn Helgaas Fix typos, most reported by "codespell drivers/gpu". Only touches comments, no code changes. Signed-off-by: Bjorn Helgaas --- Documentation/gpu/amdgpu/driver-core.rst | 2 +- drivers/gpu/drm/amd/amdgpu/Makefile | 2 +- drivers/gpu/drm/amd/amdgpu/amdg

Re: [PATCH 1/3] dt-bindings: display: panel: Add Samsung EA8076 panel

2025-07-23 Thread Rob Herring (Arm)
On Wed, 23 Jul 2025 16:52:08 +0200, Alicja Michalska wrote: > Add bindings for Samsung EA8076 LCD panel. > This panel was usually used in mid-high end smartphones manufactured by > Xiaomi in 2018 and 2019 (Mi 9 Lite and Mi Mix 3, with codenames > "xiaomi-pyxis" and "xiaomi-perseus", respectively)

Re: [PATCH] drm/msm/dpu: Add a null ptr check for dpu_encoder_needs_modeset

2025-07-23 Thread Chenyuan Yang
On Wed, Jul 23, 2025 at 12:05 PM Dmitry Baryshkov wrote: > > On Tue, Jul 22, 2025 at 04:17:40PM -0500, Chenyuan Yang wrote: > > The drm_atomic_get_new_connector_state() can return NULL if the > > connector is not part of the atomic state. Add a check to prevent > > a NULL pointer dereference. > >

Re: [PATCH 04/17] drm/msm/a6xx: Poll additional DRV status

2025-07-23 Thread Akhil P Oommen
On 7/23/2025 3:31 PM, Konrad Dybcio wrote: > On 7/20/25 2:16 PM, Akhil P Oommen wrote: >> A7XX_GEN2 generation has additional TCS slots. Poll the respective >> DRV status registers before pm suspend. >> >> Signed-off-by: Akhil P Oommen >> --- >> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 16

Re: [PATCH 03/17] drm/msm: a6xx: Fix gx_is_on check for a7x family

2025-07-23 Thread Akhil P Oommen
On 7/23/2025 4:40 PM, Dmitry Baryshkov wrote: > On Wed, Jul 23, 2025 at 01:22:20AM +0530, Akhil P Oommen wrote: >> On 7/22/2025 8:03 PM, Konrad Dybcio wrote: >>> On 7/20/25 2:16 PM, Akhil P Oommen wrote: Bitfield definition for REG_A6XX_GMU_SPTPRAC_PWR_CLK_STATUS register is different in

Re: [PATCH 02/17] drm/msm: a6xx: Refactor a6xx_sptprac_enable()

2025-07-23 Thread Akhil P Oommen
On 7/23/2025 3:43 PM, Konrad Dybcio wrote: > On 7/22/25 9:47 PM, Akhil P Oommen wrote: >> On 7/22/2025 8:00 PM, Konrad Dybcio wrote: >>> On 7/20/25 2:16 PM, Akhil P Oommen wrote: A minor refactor to combine the subroutines for legacy a6xx GMUs under a single check. This helps to avoid an

Re: [PATCH -resend] gpu: ipu-v3: Use dev_fwnode()

2025-07-23 Thread Dmitry Baryshkov
On Wed, Jul 23, 2025 at 08:27:37AM +0200, Jiri Slaby (SUSE) wrote: > irq_domain_create_simple() takes fwnode as the first argument. It can be > extracted from the struct device using dev_fwnode() helper instead of > using of_node with of_fwnode_handle(). > > So use the dev_fwnode() helper. > > Si

[PATCH 1/2] drm/msm: Fix refcnt underflow in error path

2025-07-23 Thread Rob Clark
If we hit an error path in GEM obj creation before msm_gem_new_handle() updates obj->resv to point to the gpuvm resv object, then obj->resv still points to &obj->_resv. In this case we don't want to decrement the refcount of the object being freed (since the refcnt is already zero). This fixes th

[PATCH 2/2] drm/msm: Fix submit error path cleanup

2025-07-23 Thread Rob Clark
submit_unpin_objects() should come before we unlock the objects. This fixes the splat: WARNING: CPU: 2 PID: 2171 at drivers/gpu/drm/msm/msm_gem.h:395 msm_gem_unpin_locked+0x8c/0xd8 [msm] Modules linked in: uinput snd_seq_dummy snd_hrtimer aes_ce_ccm snd_soc_wsa884x regmap_sdw q6prm_clocks

[PATCH 0/2] drm/msm: Error path fixes

2025-07-23 Thread Rob Clark
For reasons unknown to me, systemd-udev recently started limiting max-files to 64k (at least in f42), which exposed some problematic allocation related error paths. Rob Clark (2): drm/msm: Fix refcnt underflow in error path drm/msm: Fix submit error path cleanup drivers/gpu/drm/msm/msm_gem.c

Re: [PATCH] drm/msm/dpu: Add a null ptr check for dpu_encoder_needs_modeset

2025-07-23 Thread Dmitry Baryshkov
On Tue, Jul 22, 2025 at 04:17:40PM -0500, Chenyuan Yang wrote: > The drm_atomic_get_new_connector_state() can return NULL if the > connector is not part of the atomic state. Add a check to prevent > a NULL pointer dereference. > > This follows the same pattern used in dpu_encoder_update_topology()

Re: [PATCH v2 3/8] drm/xe: Fix typo "notifer"

2025-07-23 Thread Matthew Brost
On Tue, Jul 15, 2025 at 09:44:02PM +0800, WangYuli wrote: > There is a spelling mistake of 'notifer' in the comment which > should be 'notifier'. > > Link: > https://lore.kernel.org/all/b3c019b63c93846f+20250715071245.398846-1-wangy...@uniontech.com/ > Signed-off-by: WangYuli Reviewed-by: Matth

Re: [PATCH v6 5/8] dt-bindings: gpu: img,powervr-rogue: Add TH1520 GPU compatible

2025-07-23 Thread Michal Wilczynski
On 7/23/25 18:50, Matt Coster wrote: > On 23/07/2025 17:26, Michal Wilczynski wrote: >> On 7/23/25 11:45, Matt Coster wrote: >>> On 25/06/2025 15:41, Krzysztof Kozlowski wrote: On 25/06/2025 16:18, Michal Wilczynski wrote: > > > On 6/25/25 15:55, Krzysztof Kozlowski wrote: >

Re: [PATCH v6 5/8] dt-bindings: gpu: img,powervr-rogue: Add TH1520 GPU compatible

2025-07-23 Thread Matt Coster
On 23/07/2025 17:26, Michal Wilczynski wrote: > On 7/23/25 11:45, Matt Coster wrote: >> On 25/06/2025 15:41, Krzysztof Kozlowski wrote: >>> On 25/06/2025 16:18, Michal Wilczynski wrote: On 6/25/25 15:55, Krzysztof Kozlowski wrote: > On 25/06/2025 14:45, Michal Wilczynski wrote: >

Re: [PATCH v6 5/8] dt-bindings: gpu: img,powervr-rogue: Add TH1520 GPU compatible

2025-07-23 Thread Michal Wilczynski
On 7/23/25 11:45, Matt Coster wrote: > On 25/06/2025 15:41, Krzysztof Kozlowski wrote: >> On 25/06/2025 16:18, Michal Wilczynski wrote: >>> >>> >>> On 6/25/25 15:55, Krzysztof Kozlowski wrote: On 25/06/2025 14:45, Michal Wilczynski wrote: > > > On 6/24/25 15:53, Matt Coster wrot

Re: [PATCH] drm/bridge: Add null pointer check for ITE IT6263

2025-07-23 Thread Chenyuan Yang
Apologies for the second email. I am resending this message as the formatting in the previous version was incorrect On Tue, Jul 22, 2025 at 11:57 PM Maxime Ripard wrote: > > On Tue, Jul 22, 2025 at 03:41:14PM -0500, Chenyuan Yang wrote: > > drm_atomic_get_new_connector_for_encoder and > > drm_ato

Re: [PATCH v2] drm/panel-edp: Add 50ms disable delay for four panels

2025-07-23 Thread Doug Anderson
Hi, On Wed, Jul 23, 2025 at 12:25 AM Langyan Ye wrote: > > Add 50ms disable delay for NV116WHM-N49, NV122WUM-N41, and MNC207QS1-1 > to satisfy T9+T10 timing. Add 50ms disable delay for MNE007JA1-2 > as well, since MNE007JA1-2 copies the timing of MNC207QS1-1. > > Specifically, it should be noted

Re: [PATCH] drm/bridge: Add null pointer check for ITE IT6263

2025-07-23 Thread Chenyuan Yang
On Tue, Jul 22, 2025 at 23:57 Maxime Ripard wrote: > On Tue, Jul 22, 2025 at 03:41:14PM -0500, Chenyuan Yang wrote: > > drm_atomic_get_new_connector_for_encoder and > > drm_atomic_get_new_connector_state could return Null. > > They can, but not in that scenario. atomic_enable will never be called

Re: linux-next: Tree for Jul 21 [drivers/gpu/drm/xe/xe.ko]

2025-07-23 Thread Lucas De Marchi
On Tue, Jul 22, 2025 at 10:26:11AM -0300, Lucas De Marchi wrote: On Mon, Jul 21, 2025 at 10:50:29PM -0700, Randy Dunlap wrote: Hi, On 7/21/25 6:38 PM, Lucas De Marchi wrote: On Mon, Jul 21, 2025 at 01:17:33PM -0700, Randy Dunlap wrote: On 7/21/25 12:41 AM, Stephen Rothwell wrote: Hi all,

Re: [PATCH v2 2/3] ASoC: hdac_hdmi: Use dev_info on invalid ELD version

2025-07-23 Thread Detlev Casanova
Hi Mark, On Wednesday, 23 July 2025 06:40:13 EDT Mark Brown wrote: > On Tue, Jul 22, 2025 at 03:54:36PM -0400, Detlev Casanova wrote: > > When disconnected, the ELD data cannot be read by the display driver, so > > it just sets the data to 0. > > Please don't put patches for different subsystems i

Re: [PATCH 00/10] Introduce drm sharpness property

2025-07-23 Thread Xaver Hugl
I reviewed the KWin implementation for this (https://invent.kde.org/plasma/kwin/-/merge_requests/7689), and the uAPI looks good to me. - Xaver

Re: [PATCH v2 1/3] drm/bridge: dw-hdmi-qp: Return 0 in audio prepare when disconnected

2025-07-23 Thread Detlev Casanova
Hi Dmitry On Wednesday, 23 July 2025 07:41:43 EDT Dmitry Baryshkov wrote: > On Tue, Jul 22, 2025 at 03:54:35PM -0400, Detlev Casanova wrote: > > To configure audio registers, the clock of the video port in use must be > > enabled. > > As those clocks are managed by the VOP driver, they can't be ena

Re: [PATCH v6 1/4] drm: Create mipi_dsi_dual* macros

2025-07-23 Thread Brigham Campbell
On Tue Jul 22, 2025 at 10:20 AM MDT, Doug Anderson wrote: > On Mon, Jul 21, 2025 at 6:53 PM Brigham Campbell > wrote: > add/remove: 0/0 grow/shrink: 0/4 up/down: 0/-8754 (-8754) > Function old new delta > elish_csot_init_sequence.d 758

[PATCH] drm: don't run atomic_async_check for disabled planes

2025-07-23 Thread Xaver Hugl
It's entirely valid and correct for compositors to include disabled planes in the atomic commit, and doing that should not prevent async flips from working. To fix that, this commit skips the async checks if the plane was and still is not visible. Fixes: fd40a63c drm/atomic: Let drivers decide whi

Re: [PATCH v5 4/9] drm/xe/xe_survivability: Refactor survivability mode

2025-07-23 Thread Riana Tauro
On 7/23/2025 7:30 PM, Raag Jadav wrote: On Tue, Jul 15, 2025 at 04:17:24PM +0530, Riana Tauro wrote: The patches in these series refactor the boot survivability code to allow adding runtime survivability Refactor existing code to separate both the modes Punctuations please! This patch ren

Re: [PATCH v5 5/9] drm/xe/xe_survivability: Add support for Runtime survivability mode

2025-07-23 Thread Riana Tauro
On 7/23/2025 7:38 PM, Raag Jadav wrote: On Tue, Jul 15, 2025 at 04:17:25PM +0530, Riana Tauro wrote: Certain runtime firmware errors can cause the device to be in a unusable state requiring a firmware flash to restore normal operation. Runtime Survivability Mode indicates firmware flash is ne

Re: [PATCH] drm/sched: Prevent stopped entities from being added to the run queue.

2025-07-23 Thread Philipp Stanner
Hello, On Tue, 2025-07-22 at 13:05 -0700, James wrote: > On Mon, Jul 21, 2025, at 1:16 AM, Philipp Stanner wrote: > > On Mon, 2025-07-21 at 09:52 +0200, Philipp Stanner wrote: > > > +Cc Tvrtko, who's currently reworking FIFO and RR. > > > > > > On Sun, 2025-07-20 at 16:56 -0700, James Flowers wro

Re: [PATCH v5 5/9] drm/xe/xe_survivability: Add support for Runtime survivability mode

2025-07-23 Thread Raag Jadav
On Tue, Jul 15, 2025 at 04:17:25PM +0530, Riana Tauro wrote: > Certain runtime firmware errors can cause the device to be in a unusable > state requiring a firmware flash to restore normal operation. > Runtime Survivability Mode indicates firmware flash is necessary by > wedging the device and expo

Re: [PATCH v5 4/9] drm/xe/xe_survivability: Refactor survivability mode

2025-07-23 Thread Raag Jadav
On Tue, Jul 15, 2025 at 04:17:24PM +0530, Riana Tauro wrote: > The patches in these series refactor the boot survivability code to > allow adding runtime survivability > Refactor existing code to separate both the modes Punctuations please! > This patch renames the functions and separates init an

Re: [PATCH V10 41/46] drm/colorop: allow non-bypass colorops

2025-07-23 Thread F. R. A. Prado
On Mon, 2025-06-16 at 22:17 -0600, Alex Hung wrote: > From: Harry Wentland > > Not all HW will be able to do bypass on all color > operations. Introduce an 32 bits 'flags' for all colorop > init functions and DRM_COLOROP_FLAG_ALLOW_BYPASS for creating > the BYPASS property when it's true. > > Si

Re: [PATCH 6.1.y-cip 2/5] [PARTIAL BACKPORT]drm: Add an HPD poll helper to reschedule the poll work

2025-07-23 Thread Greg KH
On Wed, Jul 23, 2025 at 03:54:24PM +0300, Nicusor Huhulea wrote: > From: Imre Deak > > Add a helper to reschedule drm_mode_config::output_poll_work after > polling has been enabled for a connector (and needing a reschedule, > since previously polling was disabled for all connectors and hence > ou

Re: [PATCH v5 6/9] drm/xe/doc: Document device wedged and runtime survivability

2025-07-23 Thread Raag Jadav
On Tue, Jul 15, 2025 at 04:17:26PM +0530, Riana Tauro wrote: > Add documentation for vendor specific device wedged recovery method > and runtime survivability. ... > diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c > index bd81ebd370cb..d28c92f8b80c 100644 > --- a/driv

[PATCH v3] soc: qcom: ubwc: provide no-UBWC configuration

2025-07-23 Thread Dmitry Baryshkov
/msm tree. --- Changes in v3: - Just picked up all R-B tags from v1 (forgot those in v2) - Link to v2: https://lore.kernel.org/r/20250723-ubwc-no-ubwc-v2-1-825e1ee54...@oss.qualcomm.com Changes in v2: - Added APQ8026 to the list (Luca Weiss) - Link to v1: https://lore.kernel.org/r/20250706-ub

Re: [PATCH v2] soc: qcom: ubwc: provide no-UBWC configuration

2025-07-23 Thread Dmitry Baryshkov
On Wed, Jul 23, 2025 at 03:26:51PM +0200, Konrad Dybcio wrote: > On 7/23/25 3:23 PM, Dmitry Baryshkov wrote: > > After the commit 45a2974157d2 ("drm/msm: Use the central UBWC config > > database") the MDSS driver errors out if UBWC database didn't provide it > > with the UBWC configuration. Make UB

Re: [PATCH] drm/display: bridge-connector: correct CEC bridge pointers in drm_bridge_connector_init

2025-07-23 Thread Dmitry Baryshkov
On Sat, 19 Jul 2025 13:58:13 +0300, Dmitry Baryshkov wrote: > The bridge used in drm_bridge_connector_init() for CEC init does not > correctly point to the required HDMI CEC bridge, which can lead to > errors during CEC initialization. > > Applied to drm-misc-next, thanks! [1/1] drm/display: br

Re: [PATCH v2] soc: qcom: ubwc: provide no-UBWC configuration

2025-07-23 Thread Konrad Dybcio
On 7/23/25 3:23 PM, Dmitry Baryshkov wrote: > After the commit 45a2974157d2 ("drm/msm: Use the central UBWC config > database") the MDSS driver errors out if UBWC database didn't provide it > with the UBWC configuration. Make UBWC database return zero data for > MSM8916 / APQ8016, MSM8974 / APQ8074

[PATCH v2] soc: qcom: ubwc: provide no-UBWC configuration

2025-07-23 Thread Dmitry Baryshkov
After the commit 45a2974157d2 ("drm/msm: Use the central UBWC config database") the MDSS driver errors out if UBWC database didn't provide it with the UBWC configuration. Make UBWC database return zero data for MSM8916 / APQ8016, MSM8974 / APQ8074, MSM8226 and MSM8939. Fixes: 1924272b9ce1 ("soc: q

Re: [PATCH] soc: qcom: ubwc: provide no-UBWC configuration

2025-07-23 Thread Dmitry Baryshkov
On Wed, Jul 23, 2025 at 02:54:04PM +0200, Luca Weiss wrote: > On Sun Jul 6, 2025 at 1:01 PM CEST, Dmitry Baryshkov wrote: > > After the commit 45a2974157d2 ("drm/msm: Use the central UBWC config > > database") the MDSS driver errors out if UBWC database didn't provide it > > with the UBWC configura

[PATCH 09/10] vfio/pci: Share the core device pointer while invoking feature functions

2025-07-23 Thread Leon Romanovsky
From: Vivek Kasireddy There is no need to share the main device pointer (struct vfio_device *) with all the feature functions as they only need the core device pointer. Therefore, extract the core device pointer once in the caller (vfio_pci_core_ioctl_feature) and share it instead. Signed-off-by

[PATCH 07/10] vfio: Export vfio device get and put registration helpers

2025-07-23 Thread Leon Romanovsky
From: Vivek Kasireddy These helpers are useful for managing additional references taken on the device from other associated VFIO modules. Signed-off-by: Jason Gunthorpe Signed-off-by: Vivek Kasireddy Signed-off-by: Leon Romanovsky --- drivers/vfio/vfio_main.c | 2 ++ include/linux/vfio.h

[PATCH 10/10] vfio/pci: Add dma-buf export support for MMIO regions

2025-07-23 Thread Leon Romanovsky
From: Leon Romanovsky Add support for exporting PCI device MMIO regions through dma-buf, enabling safe sharing of non-struct page memory with controlled lifetime management. This allows RDMA and other subsystems to import dma-buf FDs and build them into memory regions for PCI P2P operations. The

[PATCH 08/10] vfio/pci: Enable peer-to-peer DMA transactions by default

2025-07-23 Thread Leon Romanovsky
From: Leon Romanovsky Make sure that all VFIO PCI devices have peer-to-peer capabilities enables, so we would be able to export their MMIO memory through DMABUF, Signed-off-by: Leon Romanovsky --- drivers/vfio/pci/vfio_pci_core.c | 4 include/linux/vfio_pci_core.h| 1 + 2 files change

[PATCH 06/10] types: move phys_vec definition to common header

2025-07-23 Thread Leon Romanovsky
From: Leon Romanovsky Move the struct phys_vec definition from block/blk-mq-dma.c to include/linux/types.h to make it available for use across the kernel. The phys_vec structure represents a physical address range with a length, which is used by the new physical address-based DMA mapping API. Th

[PATCH 05/10] PCI/P2PDMA: Export pci_p2pdma_map_type() function

2025-07-23 Thread Leon Romanovsky
From: Leon Romanovsky Export the pci_p2pdma_map_type() function to allow external modules and subsystems to determine the appropriate mapping type for P2PDMA transfers between a provider and target device. The function determines whether peer-to-peer DMA transfers can be done directly through PC

[PATCH 03/10] PCI/P2PDMA: Simplify bus address mapping API

2025-07-23 Thread Leon Romanovsky
From: Leon Romanovsky Update the pci_p2pdma_bus_addr_map() function to take a direct pointer to the p2pdma_provider structure instead of the pci_p2pdma_map_state. This simplifies the API by removing the need for callers to extract the provider from the state structure. The change updates all cal

[PATCH 02/10] PCI/P2PDMA: Introduce p2pdma_provider structure for cleaner abstraction

2025-07-23 Thread Leon Romanovsky
From: Leon Romanovsky Extract the core P2PDMA provider information (device owner and bus offset) from the dev_pagemap into a dedicated p2pdma_provider structure. This creates a cleaner separation between the memory management layer and the P2PDMA functionality. The new p2pdma_provider structure

[PATCH 04/10] PCI/P2PDMA: Refactor to separate core P2P functionality from memory allocation

2025-07-23 Thread Leon Romanovsky
From: Leon Romanovsky Refactor the PCI P2PDMA subsystem to separate the core peer-to-peer DMA functionality from the optional memory allocation layer. This creates a two-tier architecture: The core layer provides P2P mapping functionality for physical addresses based on PCI device MMIO BARs and

[PATCH 00/10] vfio/pci: Allow MMIO regions to be exported through dma-buf

2025-07-23 Thread Leon Romanovsky
From: Leon Romanovsky --- Based on blk and DMA patches which will be sent during coming merge window. --- This series extends the VFIO PCI subsystem to

[PATCH 01/10] PCI/P2PDMA: Remove redundant bus_offset from map state

2025-07-23 Thread Leon Romanovsky
From: Leon Romanovsky Remove the bus_off field from pci_p2pdma_map_state since it duplicates information already available in the pgmap structure. The bus_offset is only used in one location (pci_p2pdma_bus_addr_map) and is always identical to pgmap->bus_offset. Signed-off-by: Jason Gunthorpe S

Re: [PATCH] soc: qcom: ubwc: provide no-UBWC configuration

2025-07-23 Thread Luca Weiss
On Sun Jul 6, 2025 at 1:01 PM CEST, Dmitry Baryshkov wrote: > After the commit 45a2974157d2 ("drm/msm: Use the central UBWC config > database") the MDSS driver errors out if UBWC database didn't provide it > with the UBWC configuration. Make UBWC database return zero data for > MSM8916 / APQ8016, M

Re: [PATCH v4 05/17] phy: cdns-dphy: Remove leftover code

2025-07-23 Thread Vinod Koul
On 23-07-25, 11:49, Tomi Valkeinen wrote: > Hi Vinod, > > (I accidentally sent my mail only to you. List added here). > > On 23/07/2025 10:36, Tomi Valkeinen wrote: > > Hi Vinod, > > > > On 27/06/2025 02:32, Vinod Koul wrote: > >> On 18-06-25, 12:59, Tomi Valkeinen wrote: > >>> The code in cdns-

Re: [PATCH 09/17] drm/msm/a6xx: Switch to GMU AO counter

2025-07-23 Thread Rob Clark
On Wed, Jul 23, 2025 at 3:19 AM Konrad Dybcio wrote: > > On 7/20/25 2:16 PM, Akhil P Oommen wrote: > > CP_ALWAYS_ON counter falls under GX domain which is collapsed during > > IFPC. So switch to GMU_ALWAYS_ON counter for any CPU reads since it is > > not impacted by IFPC. Both counters are clocked

Re: [PATCH v2 1/3] drm/bridge: dw-hdmi-qp: Return 0 in audio prepare when disconnected

2025-07-23 Thread Dmitry Baryshkov
On Tue, Jul 22, 2025 at 03:54:35PM -0400, Detlev Casanova wrote: > To configure audio registers, the clock of the video port in use must be > enabled. > As those clocks are managed by the VOP driver, they can't be enabled here > to write the registers even when the HDMI cable is disconnected. > >

Re: [PATCH -resend] drm/msm: use dev_fwnode()

2025-07-23 Thread Dmitry Baryshkov
On Wed, Jul 23, 2025 at 07:55:12AM +0200, Jiri Slaby (SUSE) wrote: > irq_domain_create_simple() takes fwnode as the first argument. It can be > extracted from the struct device using dev_fwnode() helper instead of > using of_node with of_fwnode_handle(). > > So use the dev_fwnode() helper. > > Si

Re: [PATCH 08/17] drm/msm/a6xx: Set Keep-alive votes to block IFPC

2025-07-23 Thread Dmitry Baryshkov
On Wed, Jul 23, 2025 at 02:54:59AM +0530, Akhil P Oommen wrote: > On 7/22/2025 7:14 PM, Dmitry Baryshkov wrote: > > On Sun, Jul 20, 2025 at 05:46:09PM +0530, Akhil P Oommen wrote: > >> Set Keepalive votes at appropriate places to block IFPC power collapse > >> until we access all the required regis

Re: [PATCH 05/17] drm/msm/a6xx: Fix PDC sleep sequence

2025-07-23 Thread Dmitry Baryshkov
On Wed, Jul 23, 2025 at 02:35:31AM +0530, Akhil P Oommen wrote: > On 7/22/2025 10:56 PM, Rob Clark wrote: > > On Tue, Jul 22, 2025 at 6:33 AM Dmitry Baryshkov > > wrote: > >> > >> On Sun, Jul 20, 2025 at 05:46:06PM +0530, Akhil P Oommen wrote: > >>> Since the PDC resides out of the GPU subsystem a

Re: [PATCH 03/17] drm/msm: a6xx: Fix gx_is_on check for a7x family

2025-07-23 Thread Dmitry Baryshkov
On Wed, Jul 23, 2025 at 01:22:20AM +0530, Akhil P Oommen wrote: > On 7/22/2025 8:03 PM, Konrad Dybcio wrote: > > On 7/20/25 2:16 PM, Akhil P Oommen wrote: > >> Bitfield definition for REG_A6XX_GMU_SPTPRAC_PWR_CLK_STATUS register is > >> different in A7XX family. Check the correct bits to see if GX

Re: [PATCH 0/3] drm/bridge: get/put the bridge returned by drm_bridge_get_prev_bridge()

2025-07-23 Thread Luca Ceresoli
On Wed, 09 Jul 2025 17:59:36 +0200, Luca Ceresoli wrote: > This series adds drm_bridge_get/put() calls for DRM bridges returned by > drm_bridge_get_prev_bridge(). > > This is part of the work towards removal of bridges from a still existing > DRM pipeline without use-after-free. The grand plan w

Re: [PATCH v2 2/3] ASoC: hdac_hdmi: Use dev_info on invalid ELD version

2025-07-23 Thread Mark Brown
On Tue, Jul 22, 2025 at 03:54:36PM -0400, Detlev Casanova wrote: > When disconnected, the ELD data cannot be read by the display driver, so > it just sets the data to 0. Please don't put patches for different subsystems into the same series if there's no dependencies, it just makes dependencies le

  1   2   >