Re: [PATCH v9 3/4] drm/amdgpu: add debugfs support for VM pagetable per client

2025-07-03 Thread Khatri, Sunil
On 7/3/2025 1:30 PM, Christian König wrote: On 01.07.25 18:49, Sunil Khatri wrote: Add a debugfs file under the client directory which shares the root page table base address of the VM. This address could be used to dump the pagetable for debug memory issues. Signed-off-by: Sunil Khatri ---

Re: [PATCH v3 13/17] drm/mediatek: add BLENDER support for MT8196

2025-07-03 Thread 陳柏霖

Re: [PATCH v3 12/17] drm/mediatek: add EXDMA support for MT8196

2025-07-03 Thread 陳柏霖

Re: [PATCH v6 02/10] mei: late_bind: add late binding component driver

2025-07-03 Thread Greg KH
On Fri, Jul 04, 2025 at 01:00:58AM +0530, Badal Nilawar wrote: > From: Alexander Usyskin > > Add late binding component driver. > It allows pushing the late binding configuration from, for example, > the Xe graphics driver to the Intel discrete graphics card's CSE device. > > Signed-off-by: Alex

Re: [RFC 4/4] drm: define NVIDIA DRM format modifiers for GB20x

2025-07-03 Thread James Jones
On 7/3/25 16:22, Faith Ekstrand wrote: On Thu, Jul 3, 2025 at 6:34 PM James Jones > wrote: The layout of bits within the individual tiles (referred to as sectors in the DRM_FORMAT_MOD_NVIDIA_BLOCK_LINEAR_2D() macro) changed for some formats starting in

[PATCH RESEND] drm/uapi: Fix typo "restictions"

2025-07-03 Thread WangYuli
There is a spelling mistake of 'restictions' in comments which should be 'restrictions'. This typo was not listed in scripts/spelling.txt, thus it was more difficult to detect. Add it for convenience. This typo is reported by GitHub Copilot code review. [1] [1]. https://github.com/deepin-communi

[PATCH] drm/amdgpu: Fix lifetime of struct amdgpu_task_info after ring reset

2025-07-03 Thread André Almeida
When a ring reset happens, amdgpu calls drm_dev_wedged_event() using struct amdgpu_task_info *ti as one of the arguments. After using *ti, a call to amdgpu_vm_put_task_info(ti) is required to correctly track its lifetime. However, it's called from a place that the ring reset path never reaches due

Re: possible amdgpu_task_info reference leak

2025-07-03 Thread André Almeida
Hi Dave, Em 03/07/2025 20:59, Dave Airlie escreveu: In this commit : a72002cb181f350734108228b24c5d10d358f95a Author: André Almeida Date: Tue Jun 17 09:49:49 2025 -0300 drm/amdgpu: Make use of drm_wedge_task_info @@ -164,13 +165,15 @@ static enum drm_gpu_sched_stat amdgpu_job_timedou

Re: [PATCH v4 0/5] Improvements to S5 power consumption

2025-07-03 Thread Mario Limonciello
On 7/3/25 10:29, Rafael J. Wysocki wrote: On Mon, Jun 16, 2025 at 7:50 PM Mario Limonciello wrote: From: Mario Limonciello A variety of issues both in function and in power consumption have been raised as a result of devices not being put into a low power state when the system is powered off

[git pull] drm fixes for 6.16-rc5

2025-07-03 Thread Dave Airlie
Hi Linus, Weekly drm fixes, bit of a bumper crop, the usual amdgpu/xe/i915 suspects, then there is a large scattering of fixes across core and drivers. I think the simple panel lookup fix is probably the largest, the sched race fix is also fun, but I don't see anything standing out too badly. I'm

possible amdgpu_task_info reference leak

2025-07-03 Thread Dave Airlie
In this commit : a72002cb181f350734108228b24c5d10d358f95a Author: André Almeida Date: Tue Jun 17 09:49:49 2025 -0300 drm/amdgpu: Make use of drm_wedge_task_info @@ -164,13 +165,15 @@ static enum drm_gpu_sched_stat amdgpu_job_timedout(struct drm_sched_job *s_job) i

[PATCH v2] drm/bridge: tc358767: fix uninitialized variable regression

2025-07-03 Thread Luca Ceresoli
ail.com/ Reviewed-by: Colin Ian King Signed-off-by: Luca Ceresoli --- - Link to v1: https://lore.kernel.org/r/20250703-drm-bridge-alloc-fix-tc358767-regression-v1-1-8f224cd06...@bootlin.com --- Changes in v2: - fix 'Closes:' tag URL - add 'Cc: sta...@vger.kernel.org' --- dr

Re: [PATCH] drm/bridge: tc358767: fix uninitialized variable regression

2025-07-03 Thread Luca Ceresoli
On Thu, 3 Jul 2025 19:00:44 +0100 "Colin King (gmail)" wrote: > On 03/07/2025 17:32, Luca Ceresoli wrote: > > Commit a59a27176914 ("drm/bridge: tc358767: convert to > > devm_drm_bridge_alloc() API") split tc_probe_bridge_endpoint() in two > > functions, thus duplicating the loop over the endpoint

[PULL] drm-xe-fixes

2025-07-03 Thread Lucas De Marchi
Hi Dave and Sima, Here is drm-xe-fixes for rc5. A little on the big side, but number of commits is more due to splitting the logical changes to fix some HW workarounds. drm-xe-fixes-2025-07-03: Driver Changes: - Fix chunking the PTE updates and overflowing the maximum number of dwords with wit

Re: [PATCH v13 2/5] rust: support formatting of foreign types

2025-07-03 Thread Tamir Duberstein
On Thu, Jul 3, 2025 at 6:41 PM Tamir Duberstein wrote: > > On Thu, Jul 3, 2025 at 4:36 PM Benno Lossin wrote: > > > > On Thu Jul 3, 2025 at 8:55 PM CEST, Tamir Duberstein wrote: > > > On Thu, Jul 3, 2025 at 11:08 AM Benno Lossin wrote: > > >> On Thu Jul 3, 2025 at 3:55 PM CEST, Tamir Duberstein

Re: [RFC 4/4] drm: define NVIDIA DRM format modifiers for GB20x

2025-07-03 Thread Faith Ekstrand
On Thu, Jul 3, 2025 at 6:34 PM James Jones wrote: > The layout of bits within the individual tiles > (referred to as sectors in the > DRM_FORMAT_MOD_NVIDIA_BLOCK_LINEAR_2D() macro) > changed for some formats starting in Blackwell 2 > GPUs. To denote the difference, extend the sector > field in th

Re: [PATCH v13 2/5] rust: support formatting of foreign types

2025-07-03 Thread Tamir Duberstein
On Thu, Jul 3, 2025 at 5:38 PM Miguel Ojeda wrote: > > On Thu, Jul 3, 2025 at 11:28 PM Andrew Lunn wrote: > > > > A small patch tends to be more obviously correct than a big patch. The > > commit message is more focused and helpful because it refers to a > > small chunk of code. Because the commi

Re: [PATCH] rust: drm: device: drop_in_place() the drm::Device in release()

2025-07-03 Thread Danilo Krummrich
On Sun, Jun 29, 2025 at 05:37:42PM +0200, Danilo Krummrich wrote: > In drm::Device::new() we allocate with __drm_dev_alloc() and return an > ARef. > > When the reference count of the drm::Device falls to zero, the C code > automatically calls drm_dev_release(), which eventually frees the memory >

Re: [PATCH v13 2/5] rust: support formatting of foreign types

2025-07-03 Thread Tamir Duberstein
On Thu, Jul 3, 2025 at 4:36 PM Benno Lossin wrote: > > On Thu Jul 3, 2025 at 8:55 PM CEST, Tamir Duberstein wrote: > > On Thu, Jul 3, 2025 at 11:08 AM Benno Lossin wrote: > >> On Thu Jul 3, 2025 at 3:55 PM CEST, Tamir Duberstein wrote: > >> > On Thu, Jul 3, 2025 at 5:32 AM Benno Lossin wrote: >

[RFC 4/4] drm: define NVIDIA DRM format modifiers for GB20x

2025-07-03 Thread James Jones
The layout of bits within the individual tiles (referred to as sectors in the DRM_FORMAT_MOD_NVIDIA_BLOCK_LINEAR_2D() macro) changed for some formats starting in Blackwell 2 GPUs. To denote the difference, extend the sector field in the parametric format modifier definition used to generate modifie

[RFC 3/4] drm/nouveau: use format modifier helper funcs

2025-07-03 Thread James Jones
When parsing the parameteric NVIDIA block-linear format modifiers to determine surface tiling attributes, use the new helper functions to extract values from various fields. This avoids using magic values to extract the bitfields from the modifier, which makes the code more readable. Signed-off-by

[RFC 1/4] drm: macros defining fields of NVIDIA modifiers

2025-07-03 Thread James Jones
Code parsing the fields of the NVIDIA block-linear format modifiers frequently needs to use magic values defined within the DRM_FORMAT_MOD_NVIDIA_BLOCK_LINEAR_2D() macro and document in the comment above it. Such code is error prone and hard to read. See for example, nouveau_decode_mod() in the nou

[RFC 2/4] drm: add inline helper funcs for NVIDIA modifiers

2025-07-03 Thread James Jones
Code parsing the fields of the NVIDIA block-linear format modifiers frequently needs to use magic values defined within the DRM_FORMAT_MOD_NVIDIA_BLOCK_LINEAR_2D() macro and document in the comment above it. Such code is error prone and hard to read. See for example, nouveau_decode_mod() in the nou

[RFC 0/4] Add Format Modifiers for NVIDIA Blackwell chipsets

2025-07-03 Thread James Jones
The layout of bits within the individual tiles (referred to as sectors in the DRM_FORMAT_MOD_NVIDIA_BLOCK_LINEAR_2D() macro) changed for some formats starting in Blackwell 2 GPUs. New format modifiers are needed to denote the difference and prevent direct sharing of these incompatible buffers with

Re: [PATCH] drm/nouveau: Do not fail module init on debugfs errors

2025-07-03 Thread Danilo Krummrich
On Thu, Jul 03, 2025 at 09:19:49PM +, Aaron Thompson wrote: > From: Aaron Thompson > > If CONFIG_DEBUG_FS is enabled, nouveau_drm_init() returns an error if it > fails to create the "nouveau" directory in debugfs. One case where that > will happen is when debugfs access is restricted by > CON

Re: [PATCH] nouveau/gsp: add a 50ms delay between fbsr and driver unload rpcs

2025-07-03 Thread Danilo Krummrich
On Thu, Jul 03, 2025 at 09:27:07AM +1000, Dave Airlie wrote: > From: Dave Airlie > > This fixes a bunch of command hangs after runtime suspend/resume. > > This fixes a regression caused by code movement in the commit below, > the commit seems to just change timings enough to cause this to happen

Second kexec_file_load (but not kexec_load) fails on i915 if CONFIG_INTEL_IOMMU_DEFAULT_ON=n

2025-07-03 Thread Askar Safin
TL;DR: I found a bug in strange interaction in kexec_file_load (but not kexec_load) and i915 TL;DR#2: Second (sometimes third or forth) kexec (using kexec_file_load) fails on my particular hardware TL;DR#3: I did 55 expirements, each of them required a lot of boots, in total I did 1908 boots Ok

[PATCH] drm/nouveau: Do not fail module init on debugfs errors

2025-07-03 Thread Aaron Thompson
From: Aaron Thompson If CONFIG_DEBUG_FS is enabled, nouveau_drm_init() returns an error if it fails to create the "nouveau" directory in debugfs. One case where that will happen is when debugfs access is restricted by CONFIG_DEBUG_FS_ALLOW_NONE or by the boot parameter debugfs=off, which cause th

Re: [PATCH] nouveau/gsp: add a 50ms delay between fbsr and driver unload rpcs

2025-07-03 Thread David Airlie
On Fri, Jul 4, 2025 at 7:46 AM Danilo Krummrich wrote: > > On 7/3/25 1:27 AM, Dave Airlie wrote: > > From: Dave Airlie > > > > This fixes a bunch of command hangs after runtime suspend/resume. > > > > This fixes a regression caused by code movement in the commit below, > > the commit seems to jus

Re: [PATCH] nouveau/gsp: add a 50ms delay between fbsr and driver unload rpcs

2025-07-03 Thread Danilo Krummrich
On 7/3/25 1:27 AM, Dave Airlie wrote: From: Dave Airlie This fixes a bunch of command hangs after runtime suspend/resume. This fixes a regression caused by code movement in the commit below, the commit seems to just change timings enough to cause this to happen now, and adding the sleep seems

Re: [PATCH v6 05/10] drm/xe/xe_late_bind_fw: Load late binding firmware

2025-07-03 Thread Daniele Ceraolo Spurio
On 7/3/2025 12:31 PM, Badal Nilawar wrote: Load late binding firmware v2: - s/EAGAIN/EBUSY/ - Flush worker in suspend and driver unload (Daniele) v3: - Use retry interval of 6s, in steps of 200ms, to allow other OS components release MEI CL handle (Sasha) v4: - return -ENODEV if c

Re: [PATCH v13 2/5] rust: support formatting of foreign types

2025-07-03 Thread Miguel Ojeda
On Thu, Jul 3, 2025 at 11:28 PM Andrew Lunn wrote: > > A small patch tends to be more obviously correct than a big patch. The > commit message is more focused and helpful because it refers to a > small chunk of code. Because the commit message is more focused, it > can answer questions reviewers m

Re: [PATCH] drm/display: hdmi-cec-helper: Fix adapter unregistration

2025-07-03 Thread Dmitry Baryshkov
On Thu, Jul 03, 2025 at 11:05:45PM +0300, Cristian Ciocaltea wrote: > Attempting to reload a kernel module of an HDMI driver making use of the > new CEC helpers revealed a resource deallocation issue, i.e. the entries > in /dev/cec* keep growing. > > Moreover, after a couple of tries the kernel cr

Re: [PATCH v13 2/5] rust: support formatting of foreign types

2025-07-03 Thread Andrew Lunn
On Thu, Jul 03, 2025 at 02:55:30PM -0400, Tamir Duberstein wrote: > On Thu, Jul 3, 2025 at 11:08 AM Benno Lossin wrote: > > > > On Thu Jul 3, 2025 at 3:55 PM CEST, Tamir Duberstein wrote: > > > On Thu, Jul 3, 2025 at 5:32 AM Benno Lossin wrote: > > >> On Tue Jul 1, 2025 at 6:49 PM CEST, Tamir Dub

Re: [PATCH v3 2/2] drm/bridge: Pass down connector to drm bridge detect hook

2025-07-03 Thread Dmitry Baryshkov
On Thu, Jul 03, 2025 at 08:49:53PM +0800, Andy Yan wrote: > From: Andy Yan > > In some application scenarios, we hope to get the corresponding > connector when the bridge's detect hook is invoked. > > In most cases, we can get the connector by > drm_atomic_get_connector_for_encoder > if the enc

Re: [PATCH] rust: drm: device: drop_in_place() the drm::Device in release()

2025-07-03 Thread Alice Ryhl
On Sun, Jun 29, 2025 at 5:38 PM Danilo Krummrich wrote: > > In drm::Device::new() we allocate with __drm_dev_alloc() and return an > ARef. > > When the reference count of the drm::Device falls to zero, the C code > automatically calls drm_dev_release(), which eventually frees the memory > allocate

Re: [PATCH] drm/nouveau: Do not fail module init on debugfs errors

2025-07-03 Thread Timur Tabi
On Thu, 2025-07-03 at 21:19 +, Aaron Thompson wrote: > From: Aaron Thompson > > If CONFIG_DEBUG_FS is enabled, nouveau_drm_init() returns an error if it > fails to create the "nouveau" directory in debugfs. One case where that > will happen is when debugfs access is restricted by > CONFIG_DEB

Re: [PATCH 17/17] amdgpu: add support for memory cgroups

2025-07-03 Thread David Airlie
> > Do you mean a task in cgroup A does amdgpu_gem_object_create() and then > the actual allocation can happen in the task in cgroup B? On android and in some graphics scenarios, this might happen, not sure if it does always though. We have scenarios where a display server allocate a buffer for an

Re: [PATCH v3 0/7] drm/panthor: support repeated mappings

2025-07-03 Thread Danilo Krummrich
On 7/3/25 10:52 PM, Caterina Shablia wrote: This patch series adds OP_MAP_REPEAT flag, which lets the user map a BO region over an address range repeatedly with just one map operation. Thanks for resending, will take a look soon!

[PATCH v3 6/7] drm/gpuvm: Add DRM_GPUVA_REPEAT flag and logic

2025-07-03 Thread Caterina Shablia
From: Asahi Lina To be able to support "fake sparse" mappings without relying on GPU page fault handling, drivers may need to create large (e.g. 4GiB) mappings of the same page repeatedly (or same range of pages). Doing this through individual mappings would be very wasteful. This can be handled

[PATCH v3 7/7] drm/panthor: Add support for repeated mappings

2025-07-03 Thread Caterina Shablia
From: Boris Brezillon This allows us to optimize mapping of a relatively small portion of a BO over and over in a large VA range, which is useful to support Vulkan sparse bindings in an efficient way. Signed-off-by: Boris Brezillon Co-developed-by: Caterina Shablia Signed-off-by: Caterina Shab

[PATCH v3 5/7] drm/gpuvm: Add a flags field to drm_gpuvm_map_req/drm_gpuva_op_map

2025-07-03 Thread Caterina Shablia
From: Asahi Lina drm_gpuva objects have a flags field. Currently, this can be managed by drivers out-of-band, without any special handling in drm_gpuvm. To be able to introduce flags that do affect the logic in the drm_gpuvm core, we need to plumb it through the map calls. This will allow the co

[PATCH v3 4/7] drm/gpuvm: Add a helper to check if two VA can be merged

2025-07-03 Thread Caterina Shablia
From: Boris Brezillon We are going to add flags/properties that will impact the VA merging ability. Instead of sprinkling tests all over the place in __drm_gpuvm_sm_map(), let's add a helper aggregating all these checks can call it for every existing VA we walk through in the __drm_gpuvm_sm_map()

[PATCH v3 3/7] drm/gpuvm: Pass map arguments through a struct

2025-07-03 Thread Caterina Shablia
From: Boris Brezillon We are about to pass more arguments to drm_gpuvm_sm_map[_ops_create](), so, before we do that, let's pass arguments through a struct instead of changing each call site every time a new optional argument is added. Signed-off-by: Boris Brezillon Signed-off-by: Caterina Shabl

[PATCH v3 2/7] drm/gpuvm: Kill drm_gpuva_init()

2025-07-03 Thread Caterina Shablia
From: Boris Brezillon drm_gpuva_init() only has one internal user, and given we are about to add new optional fields, it only add maintenance burden for no real benefit, so let's kill the thing now. Signed-off-by: Boris Brezillon Signed-off-by: Caterina Shablia --- include/drm/drm_gpuvm.h | 1

[PATCH v3 1/7] drm/panthor: Add support for atomic page table updates

2025-07-03 Thread Caterina Shablia
From: Boris Brezillon Move the lock/flush_mem operations around the gpuvm_sm_map() calls so we can implement true atomic page updates, where any access in the locked range done by the GPU has to wait for the page table updates to land before proceeding. This is needed for vkQueueBindSparse(), so

[PATCH v3 0/7] drm/panthor: support repeated mappings

2025-07-03 Thread Caterina Shablia
This patch series adds OP_MAP_REPEAT flag, which lets the user map a BO region over an address range repeatedly with just one map operation. Sparse resources in the Vulkan API let the user leave regions of a resource unmapped (from the API perspective.) Accesses to such regions must not result in

Re: [PATCH v13 2/5] rust: support formatting of foreign types

2025-07-03 Thread Benno Lossin
On Thu Jul 3, 2025 at 8:55 PM CEST, Tamir Duberstein wrote: > On Thu, Jul 3, 2025 at 11:08 AM Benno Lossin wrote: >> On Thu Jul 3, 2025 at 3:55 PM CEST, Tamir Duberstein wrote: >> > On Thu, Jul 3, 2025 at 5:32 AM Benno Lossin wrote: >> >> On Tue Jul 1, 2025 at 6:49 PM CEST, Tamir Duberstein wrote

[PATCH] drm/display: hdmi-cec-helper: Fix adapter unregistration

2025-07-03 Thread Cristian Ciocaltea
ter_adapter(data->adapter); if (data->funcs->uninit) data->funcs->uninit(connector); --- base-commit: 8d6c58332c7a8ba025fcfa76888b6c37dbce9633 change-id: 20250703-hdmi-cec-helper-unreg-fix-d9e71349c1f4

Re: [PATCH 17/17] amdgpu: add support for memory cgroups

2025-07-03 Thread Shakeel Butt
On Thu, Jul 03, 2025 at 08:15:09PM +0200, Christian König wrote: > On 03.07.25 19:58, Shakeel Butt wrote: > > On Thu, Jul 03, 2025 at 12:53:44PM +1000, David Airlie wrote: > >> On Thu, Jul 3, 2025 at 2:03 AM Shakeel Butt wrote: > >>> > >>> On Mon, Jun 30, 2025 at 02:49:36PM +1000, Dave Airlie wrot

Re: [PATCH] drm/msm: Update register xml

2025-07-03 Thread Dmitry Baryshkov
On Thu, Jul 03, 2025 at 10:51:19AM -0700, Rob Clark wrote: > Sync register xml from mesa commit eb3e0b7164a3 ("freedreno/a6xx: Split > descriptors out into their own file"). > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/Makefile |5 + > drivers/gpu/drm/msm/adreno/

Re: [PATCH] drm/msm: Use of_reserved_mem_region_to_resource() for "memory-region"

2025-07-03 Thread Dmitry Baryshkov
On Thu, Jul 03, 2025 at 01:34:41PM -0500, Rob Herring (Arm) wrote: > Use the newly added of_reserved_mem_region_to_resource() function to > handle "memory-region" properties. > > The original code did not set 'zap_available' to false if > of_address_to_resource() failed which seems like an oversig

Re: [PATCH] misc: fastrpc: Use of_reserved_mem_region_to_resource() for "memory-region"

2025-07-03 Thread Dmitry Baryshkov
On Thu, Jul 03, 2025 at 01:34:54PM -0500, Rob Herring (Arm) wrote: > Use the newly added of_reserved_mem_region_to_resource() function to > handle "memory-region" properties. > > The error handling is a bit different. "memory-region" is optional, so > failed lookup is not an error. But then an err

Re: [PATCH v6 2/2] i2c: i2c-qcom-geni: Add Block event interrupt support

2025-07-03 Thread Dmitry Baryshkov
On Thu, 3 Jul 2025 at 15:51, Jyothi Kumar Seerapu wrote: > > > > On 6/19/2025 9:46 PM, Jyothi Kumar Seerapu wrote: > > > > > > On 6/18/2025 1:02 AM, Dmitry Baryshkov wrote: > >> On Tue, 17 Jun 2025 at 17:11, Jyothi Kumar Seerapu > >> wrote: > >>> > >>> > >>> > >>> On 5/30/2025 10:12 PM, Dmitry Ba

Re: [PATCH v2] agp/amd64: Check AGP Capability before binding to unsupported devices

2025-07-03 Thread Andi Kleen
I suspect these days it would be also reasonable to drop it this old hack. If any of these old chipsets are still missing I would rather adds its PCI-ID. There will be certainly not any new unknown ones for these old CPUs. Also there shouldn't be that many high speed devices that need the old

[PATCH v6 08/10] drm/xe/xe_late_bind_fw: Introduce debug fs node to disable late binding

2025-07-03 Thread Badal Nilawar
Introduce a debug filesystem node to disable late binding fw reload during the system or runtime resume. This is intended for situations where the late binding fw needs to be loaded from user mode, perticularly for validation purpose. Note that xe kmd doesn't participate in late binding flow from u

[PATCH v6 10/10] drm/xe/xe_late_bind_fw: Select INTEL_MEI_LATE_BIND for CI

2025-07-03 Thread Badal Nilawar
Do not review Signed-off-by: Badal Nilawar --- drivers/gpu/drm/xe/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig index f66e6d39e319..ef3f4807b0b3 100644 --- a/drivers/gpu/drm/xe/Kconfig +++ b/drivers/gpu/drm/xe/Kconfig @@ -45,6

[PATCH v6 09/10] drm/xe/xe_late_bind_fw: Extract and print version info

2025-07-03 Thread Badal Nilawar
Extract and print version info of the late binding binary. v2: Some refinements (Daniele) Signed-off-by: Badal Nilawar Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/xe/xe_late_bind_fw.c | 124 + drivers/gpu/drm/xe/xe_late_bind_fw_types.h | 3 + drivers/gpu

[PATCH v6 06/10] drm/xe/xe_late_bind_fw: Reload late binding fw in rpm resume

2025-07-03 Thread Badal Nilawar
Reload late binding fw during runtime resume. Signed-off-by: Badal Nilawar Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/xe/xe_late_bind_fw.c | 2 +- drivers/gpu/drm/xe/xe_late_bind_fw.h | 1 + drivers/gpu/drm/xe/xe_pm.c | 4 3 files changed, 6 insertions(+), 1 deletion(-) diff

[PATCH v6 07/10] drm/xe/xe_late_bind_fw: Reload late binding fw during system resume

2025-07-03 Thread Badal Nilawar
Reload late binding fw during resume from system suspend v2: - Unconditionally reload late binding fw (Rodrigo) - Flush worker during system suspend Cc: Rodrigo Vivi Signed-off-by: Badal Nilawar Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/xe/xe_pm.c | 4 1 file changed, 4 insertion

[PATCH v6 05/10] drm/xe/xe_late_bind_fw: Load late binding firmware

2025-07-03 Thread Badal Nilawar
Load late binding firmware v2: - s/EAGAIN/EBUSY/ - Flush worker in suspend and driver unload (Daniele) v3: - Use retry interval of 6s, in steps of 200ms, to allow other OS components release MEI CL handle (Sasha) v4: - return -ENODEV if component not added (Daniele) - parse and print statu

[PATCH v6 04/10] drm/xe/xe_late_bind_fw: Initialize late binding firmware

2025-07-03 Thread Badal Nilawar
Search for late binding firmware binaries and populate the meta data of firmware structures. v2 (Daniele): - drm_err if firmware size is more than max pay load size - s/request_firmware/firmware_request_nowarn/ as firmware will not be available for all possible cards v3 (Daniele): - init fir

[PATCH v6 03/10] drm/xe/xe_late_bind_fw: Introducing xe_late_bind_fw

2025-07-03 Thread Badal Nilawar
Introducing xe_late_bind_fw to enable firmware loading for the devices, such as the fan controller, during the driver probe. Typically, firmware for such devices are part of IFWI flash image but can be replaced at probe after OEM tuning. This patch binds mei late binding component to enable firmwar

[PATCH v6 02/10] mei: late_bind: add late binding component driver

2025-07-03 Thread Badal Nilawar
From: Alexander Usyskin Add late binding component driver. It allows pushing the late binding configuration from, for example, the Xe graphics driver to the Intel discrete graphics card's CSE device. Signed-off-by: Alexander Usyskin Signed-off-by: Badal Nilawar Reviewed-by: Anshuman Gupta ---

[PATCH v6 01/10] mei: bus: add mei_cldev_mtu interface

2025-07-03 Thread Badal Nilawar
From: Alexander Usyskin Allow to bus client to obtain client mtu. Signed-off-by: Alexander Usyskin Signed-off-by: Badal Nilawar Reviewed-by: Umesh Nerlige Ramappa --- drivers/misc/mei/bus.c | 13 + include/linux/mei_cl_bus.h | 1 + 2 files changed, 14 insertions(+) diff --g

[PATCH v6 00/10] Introducing firmware late binding

2025-07-03 Thread Badal Nilawar
Introducing firmware late binding feature to enable firmware loading for the devices, such as the fan controller and voltage regulator, during the driver probe. Typically, firmware for these devices are part of IFWI flash image but can be replaced at probe after OEM tuning. v2: - Dropped voltage

Re: [PATCH v13 2/5] rust: support formatting of foreign types

2025-07-03 Thread Tamir Duberstein
On Thu, Jul 3, 2025 at 2:55 PM Tamir Duberstein wrote: > > On Thu, Jul 3, 2025 at 11:08 AM Benno Lossin wrote: > > > > On Thu Jul 3, 2025 at 3:55 PM CEST, Tamir Duberstein wrote: > > > On Thu, Jul 3, 2025 at 5:32 AM Benno Lossin wrote: > > >> On Tue Jul 1, 2025 at 6:49 PM CEST, Tamir Duberstein

Re: [PATCH v13 2/5] rust: support formatting of foreign types

2025-07-03 Thread Tamir Duberstein
On Thu, Jul 3, 2025 at 12:26 PM Miguel Ojeda wrote: > > On Thu, Jul 3, 2025 at 3:56 PM Tamir Duberstein wrote: > > > > Can you help me understand why? The changes you ask to be separated > > would all be in different files, so why would separate commits make it > > easier to review? > > By the wa

Re: [PATCH v13 2/5] rust: support formatting of foreign types

2025-07-03 Thread Tamir Duberstein
On Thu, Jul 3, 2025 at 11:08 AM Benno Lossin wrote: > > On Thu Jul 3, 2025 at 3:55 PM CEST, Tamir Duberstein wrote: > > On Thu, Jul 3, 2025 at 5:32 AM Benno Lossin wrote: > >> On Tue Jul 1, 2025 at 6:49 PM CEST, Tamir Duberstein wrote: > >> > Introduce a `fmt!` macro which wraps all arguments in

[PATCH] fbdev: simplefb: Use of_reserved_mem_region_to_resource() for "memory-region"

2025-07-03 Thread Rob Herring (Arm)
Use the newly added of_reserved_mem_region_to_resource() function to handle "memory-region" properties. The error handling is a bit different. "memory-region" is optional, so failed lookup is not an error. But then an error in of_address_to_resource() is treated as an error. However, that distinct

[PATCH] misc: fastrpc: Use of_reserved_mem_region_to_resource() for "memory-region"

2025-07-03 Thread Rob Herring (Arm)
Use the newly added of_reserved_mem_region_to_resource() function to handle "memory-region" properties. The error handling is a bit different. "memory-region" is optional, so failed lookup is not an error. But then an error in of_reserved_mem_lookup() is treated as an error. However, that distinct

[PATCH] drm/simpledrm: Use of_reserved_mem_region_to_resource() for "memory-region"

2025-07-03 Thread Rob Herring (Arm)
Use the newly added of_reserved_mem_region_to_resource() function to handle "memory-region" properties. Signed-off-by: Rob Herring (Arm) --- drivers/gpu/drm/sysfb/simpledrm.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/sysfb/simpledrm.c b

[PATCH] drm/msm: Use of_reserved_mem_region_to_resource() for "memory-region"

2025-07-03 Thread Rob Herring (Arm)
Use the newly added of_reserved_mem_region_to_resource() function to handle "memory-region" properties. The original code did not set 'zap_available' to false if of_address_to_resource() failed which seems like an oversight. Signed-off-by: Rob Herring (Arm) --- drivers/gpu/drm/msm/adreno/adreno

Re: [PATCH 17/17] amdgpu: add support for memory cgroups

2025-07-03 Thread Christian König
On 03.07.25 19:58, Shakeel Butt wrote: > On Thu, Jul 03, 2025 at 12:53:44PM +1000, David Airlie wrote: >> On Thu, Jul 3, 2025 at 2:03 AM Shakeel Butt wrote: >>> >>> On Mon, Jun 30, 2025 at 02:49:36PM +1000, Dave Airlie wrote: From: Dave Airlie This adds support for adding a obj cgr

Re: [PATCH] drm/bridge: tc358767: fix uninitialized variable regression

2025-07-03 Thread Colin King (gmail)
tc->pre_emphasis, --- base-commit: b4cd18f485687a2061ee7a0ce6833851fc4438da change-id: 20250703-drm-bridge-alloc-fix-tc358767-regression-536ea2861af6 Best regards, Looks good to me. Thanks Luca. Reviewed-by: Colin Ian King OpenPGP_0x68C287DFC6A80226.asc Description: OpenPGP public key OpenPGP_si

Re: [PATCH 17/17] amdgpu: add support for memory cgroups

2025-07-03 Thread Shakeel Butt
On Thu, Jul 03, 2025 at 12:53:44PM +1000, David Airlie wrote: > On Thu, Jul 3, 2025 at 2:03 AM Shakeel Butt wrote: > > > > On Mon, Jun 30, 2025 at 02:49:36PM +1000, Dave Airlie wrote: > > > From: Dave Airlie > > > > > > This adds support for adding a obj cgroup to a buffer object, > > > and passi

Re: Warnings in next-20250703 caused by commit 582111e630f5

2025-07-03 Thread Bert Karwatzki
utions Germany GmbH > Frankenstrasse 146, 90461 Nuernberg, Germany > GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman > HRB 36809 (AG Nuernberg) I applied the patch on top of next-20250703 $ git log --oneline 18ee3ed3cb60 (HEAD -> drm_gem_object_handle_put) drm/amdg

Re: [PATCH v5 10/10] drm/xe/xe_late_bind_fw: Select INTEL_MEI_LATE_BIND for CI

2025-07-03 Thread Daniele Ceraolo Spurio
On 7/2/2025 2:48 PM, Rodrigo Vivi wrote: On Wed, Jul 02, 2025 at 10:22:16PM +0530, Badal Nilawar wrote: Do not review Why? Why don't we add this dependency here? For INTEL_MEI_LATE_BIND to work we also need  INTEL_MEI_GSC, which is the config for the mei child device and depends on the c

[PATCH] drm/bridge: tc358767: fix uninitialized variable regression

2025-07-03 Thread Luca Ceresoli
e(dev->of_node, node) { + of_graph_parse_endpoint(node, &endpoint); if (endpoint.port == 2) { of_property_read_u8_array(node, "toshiba,pre-emphasis", tc->pre_emphasis, --- base-commit: b4cd18f485687a2061ee

Re: [PATCH] drm/bridge: analogix_dp: Use devm_drm_bridge_alloc() API

2025-07-03 Thread Luca Ceresoli
Hi Maxime, On Tue, 1 Jul 2025 16:27:54 +0200 Maxime Ripard wrote: > On Tue, Jul 01, 2025 at 04:02:19PM +0200, Luca Ceresoli wrote: > > Hello Marek, Maxime, > > > > thanks Marek for spotting the issue and sending a patch! > > > > On Mon, 30 Jun 2025 18:44:24 +0200 > > Maxime Ripard wrote: > >

Re: [PATCH v13 2/5] rust: support formatting of foreign types

2025-07-03 Thread Miguel Ojeda
On Thu, Jul 3, 2025 at 3:56 PM Tamir Duberstein wrote: > > Can you help me understand why? The changes you ask to be separated > would all be in different files, so why would separate commits make it > easier to review? By the way, if we are talking about splitting, it is easier to land patches t

Re: drm/bridge: tc358767: convert to devm_drm_bridge_alloc() API

2025-07-03 Thread Luca Ceresoli
Hello Colin, sorry for the late reply (vacation time). On Wed, 2 Jul 2025 10:41:52 +0100 "Colin King (gmail)" wrote: > Hi, > > I believe there is a regression in linux-next caused by the following > commit: > > commit a59a271769149f0b8258507276f3d2a24370cbdb > Author: Luca Ceresoli > Date:

Re: Warnings in next-20250703 caused by commit 582111e630f5

2025-07-03 Thread Thomas Zimmermann
Hi, before I give up on the issue, could you please test the attached patch? Best regards Thomas Am 03.07.25 um 13:59 schrieb Bert Karwatzki: When booting next-20250703 on my Msi Alpha 15 Laptop running debian sid (last updated 20250703) I get a several warnings of the following kind

Re: [PATCH v3 6/7] Documentation: gpu: nova-core: Document fwsec operation and layout

2025-07-03 Thread Joel Fernandes
On 7/2/2025 8:25 PM, Bagas Sanjaya wrote: > On Wed, Jul 02, 2025 at 08:00:43PM +0900, Alexandre Courbot wrote: >> +FWSEC Memory Layout >> +--- >> +The memory layout of the FWSEC image is as follows (this is using an GA-102 >> +Ampere GPU as an example and could vary for future GP

Re: [PATCH v3 4/7] Documentation: gpu: nova-core: Document vbios layout

2025-07-03 Thread Joel Fernandes
On 7/2/2025 8:20 PM, Bagas Sanjaya wrote: > On Wed, Jul 02, 2025 at 08:00:41PM +0900, Alexandre Courbot wrote: >> diff --git a/Documentation/gpu/nova/core/vbios.rst >> b/Documentation/gpu/nova/core/vbios.rst >> new file mode 100644 >> index >> ..55d7dd4a

Re: (subset) [PATCH 0/5] sunxi: Various minor V3s clock/pinctrl fixes

2025-07-03 Thread Chen-Yu Tsai
On Tue, 01 Jul 2025 22:11:19 +0200, Paul Kocialkowski wrote: > This is a mixed-bag of minor fixes for V3s clocks and pinctrl. > > The last patch is a weak attempt at accomodating using both the display > engine and tcon along with the camera subsystem. The main issue is that > the tcon and de need

Re: [RESEND PATCH v2] drm/msm/dsi: Fix 14nm DSI PHY PLL Lock issue

2025-07-03 Thread Dmitry Baryshkov
On Thu, 3 Jul 2025 at 17:28, Loic Poulain wrote: > > Hi Dmitry, > > On Sun, Jun 29, 2025 at 4:57 PM Dmitry Baryshkov > wrote: > > > > On Sun, Jun 29, 2025 at 10:50:36AM +0200, Loic Poulain wrote: > > > To configure and enable the DSI PHY PLL clocks, the MDSS AHB clock must > > > be active for MMI

[PATCH v2 5/7] drm/gpuvm: Add a flags field to drm_gpuvm_map_req/drm_gpuva_op_map

2025-07-03 Thread Caterina Shablia
From: Asahi Lina drm_gpuva objects have a flags field. Currently, this can be managed by drivers out-of-band, without any special handling in drm_gpuvm. To be able to introduce flags that do affect the logic in the drm_gpuvm core, we need to plumb it through the map calls. This will allow the co

[PATCH v2 6/7] drm/gpuvm: Add DRM_GPUVA_REPEAT flag and logic

2025-07-03 Thread Caterina Shablia
From: Asahi Lina To be able to support "fake sparse" mappings without relying on GPU page fault handling, drivers may need to create large (e.g. 4GiB) mappings of the same page repeatedly (or same range of pages). Doing this through individual mappings would be very wasteful. This can be handled

[PATCH v2 7/7] drm/panthor: Add support for repeated mappings

2025-07-03 Thread Caterina Shablia
From: Boris Brezillon This allows us to optimize mapping of a relatively small portion of a BO over and over in a large VA range, which is useful to support Vulkan sparse bindings in an efficient way. Signed-off-by: Boris Brezillon Co-developed-by: Caterina Shablia Signed-off-by: Caterina Shab

[PATCH v2 4/7] drm/gpuvm: Add a helper to check if two VA can be merged

2025-07-03 Thread Caterina Shablia
From: Boris Brezillon We are going to add flags/properties that will impact the VA merging ability. Instead of sprinkling tests all over the place in __drm_gpuvm_sm_map(), let's add a helper aggregating all these checks can call it for every existing VA we walk through in the __drm_gpuvm_sm_map()

[PATCH v2 3/7] drm/gpuvm: Pass map arguments through a struct

2025-07-03 Thread Caterina Shablia
From: Boris Brezillon We are about to pass more arguments to drm_gpuvm_sm_map[_ops_create](), so, before we do that, let's pass arguments through a struct instead of changing each call site every time a new optional argument is added. Signed-off-by: Boris Brezillon Signed-off-by: Caterina Shabl

[PATCH v2 2/7] drm/gpuvm: Kill drm_gpuva_init()

2025-07-03 Thread Caterina Shablia
From: Boris Brezillon drm_gpuva_init() only has one internal user, and given we are about to add new optional fields, it only add maintenance burden for no real benefit, so let's kill the thing now. Signed-off-by: Boris Brezillon Signed-off-by: Caterina Shablia --- include/drm/drm_gpuvm.h | 1

[PATCH v2 1/7] drm/panthor: Add support for atomic page table updates

2025-07-03 Thread Caterina Shablia
From: Boris Brezillon Move the lock/flush_mem operations around the gpuvm_sm_map() calls so we can implement true atomic page updates, where any access in the locked range done by the GPU has to wait for the page table updates to land before proceeding. This is needed for vkQueueBindSparse(), so

[PATCH v2 7/7] drm/panthor: Add support for repeated mappings

2025-07-03 Thread Caterina Shablia
From: Boris Brezillon This allows us to optimize mapping of a relatively small portion of a BO over and over in a large VA range, which is useful to support Vulkan sparse bindings in an efficient way. Signed-off-by: Boris Brezillon Co-developed-by: Caterina Shablia Signed-off-by: Caterina Shab

[PATCH v2 6/7] drm/gpuvm: Add DRM_GPUVA_REPEAT flag and logic

2025-07-03 Thread Caterina Shablia
From: Asahi Lina To be able to support "fake sparse" mappings without relying on GPU page fault handling, drivers may need to create large (e.g. 4GiB) mappings of the same page repeatedly (or same range of pages). Doing this through individual mappings would be very wasteful. This can be handled

[PATCH v2 5/7] drm/gpuvm: Add a flags field to drm_gpuvm_map_req/drm_gpuva_op_map

2025-07-03 Thread Caterina Shablia
From: Asahi Lina drm_gpuva objects have a flags field. Currently, this can be managed by drivers out-of-band, without any special handling in drm_gpuvm. To be able to introduce flags that do affect the logic in the drm_gpuvm core, we need to plumb it through the map calls. This will allow the co

[PULL] drm-misc-fixes

2025-07-03 Thread Maarten Lankhorst
Hi Dave, Simona, Fixes for rc5. :-) Kind regards, ~Maarten drm-misc-fixes-2025-07-03: drm-misc-fixes for v6.16-rc5: - Replace simple panel lookup hack with proper fix. - nullpointer deref in vesadrm fix. - fix dma_resv_wait_timeout. - fix error handling in ttm_buffer_object_transfer. - bridge fi

[PATCH 6.1 105/132] drm/udl: Unregister device before cleaning up on disconnect

2025-07-03 Thread Greg Kroah-Hartman
6.1-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Zimmermann commit ff9cb6d2035c586ea7c8f1754d4409eec7a2d26d upstream. Disconnecting a DisplayLink device results in the following kernel error messages [ 93.041748] [drm:udl_urb_comple

[PATCH 6.1 068/132] dummycon: Trigger redraw when switching consoles with deferred takeover

2025-07-03 Thread Greg Kroah-Hartman
6.1-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Zimmermann [ Upstream commit 03bcbbb3995ba5df43af9aba45334e35f2dfe27b ] Signal vt subsystem to redraw console when switching to dummycon with deferred takeover enabled. Makes the console

  1   2   >