[bug report] drm/ttm, drm_xe, Implement ttm_lru_walk_for_evict() using the guarded LRU iteration

2025-06-28 Thread Dan Carpenter
Hello Thomas Hellström, Commit bb8aa27eff6f ("drm/ttm, drm_xe, Implement ttm_lru_walk_for_evict() using the guarded LRU iteration") from Jun 23, 2025 (linux-next), leads to the following (unpublished) Smatch static checker warning: drivers/gpu/drm/ttm/ttm_bo_util.c:991 __ttm_bo_lru_cursor

[PATCH] drm/bridge: anx7625: Fix invalid EDID size

2025-06-28 Thread Loic Poulain
DRM checks EDID block count against allocated size in drm_edid_valid function. We have to allocate the right EDID size instead of the max size to prevent the EDID to be reported as invalid. Fixes: 7c585f9a71aa ("drm/bridge: anx7625: use struct drm_edid more") Signed-off-by: Loic Poulain --- driv

[PATCH] drm/v3d: Disable interrupts before resetting the GPU

2025-06-28 Thread Maíra Canal
Currently, an interrupt can be triggered during a GPU reset, which can lead to GPU hangs and NULL pointer dereference in an interrupt context as shown in the following trace: [ 314.035040] Unable to handle kernel NULL pointer dereference at virtual address 00c0 [ 314.043822] Mem a

Re: [PATCH v2 2/2] staging: fbtft: cleanup error handling in fbtft_framebuffer_alloc()

2025-06-28 Thread Andy Shevchenko
On Sat, Jun 28, 2025 at 7:59 AM Abdun Nihaal wrote: > > The error handling in fbtft_framebuffer_alloc() mixes managed allocation > and plain allocation, and performs error handling in an order different > from the order in fbtft_framebuffer_release(). > > Fix them by moving vmem allocation closer

Re: [PATCH] Introduce Tyr

2025-06-28 Thread Maíra Canal
Hi Daniel, On 27/06/25 19:34, Daniel Almeida wrote: [...] diff --git a/drivers/gpu/drm/tyr/driver.rs b/drivers/gpu/drm/tyr/driver.rs new file mode 100644 index ..2443620e10620585eae3d57978e64d2169a1b2d1 --- /dev/null +++ b/drivers/gpu/drm/tyr/driver.rs

Re: [PATCH v2] workaround for Sphinx false positive preventing indexing

2025-06-28 Thread Mauro Carvalho Chehab
Em Sat, 28 Jun 2025 08:30:21 +0700 Bagas Sanjaya escreveu: > [also Cc'ing Mauro] > > On Fri, Jun 27, 2025 at 05:27:18PM +0530, Kevin Paul Reddy Janagari wrote: > > Functions drm_format_info, drm_modeset_lock, drm_ioctl_flags are not being > > indexed in the documentation because there are struct

[PATCH] rockchip/drm: vop2: make vp registers nonvolatile

2025-06-28 Thread Piotr Zalewski
Make video port registers nonvolatile. As DSP_CTRL register is written to twice due to gamma LUT enable bit which is set outside of the main DSP_CTRL initialization within atomic_enable (for rk356x case it is also necesarry to always disable gamma LUT before writing a new LUT) there is a chance tha

Re: [PATCH v2 drm-dp 10/10] drm/hisilicon/hibmc: adapting modification for the former commit

2025-06-28 Thread Dmitry Baryshkov
On Fri, Jun 20, 2025 at 05:31:04PM +0800, Yongbang Shi wrote: > From: Baihan Li > > Add colorbar disable operation and move hdcp opreation behind the reset > controller operation. Two items => two commits You missed the 'why' part of the commit message. > > Fixes: 3c7623fb5bb6 ("drm/hisilicon/

Re: [PATCH v2 drm-dp 09/10] drm/hisilicon/hibmc: fix no showing problem with loading hibmc manually

2025-06-28 Thread Dmitry Baryshkov
On Fri, Jun 20, 2025 at 05:31:03PM +0800, Yongbang Shi wrote: > From: Baihan Li > > When using command rmmod and insmod, there is no showing in second time > insmoding. Because DP controller won't send HPD signals, if connection > doesn't change or controller isn't reset. So add reset before unre

Re: [PATCH v2 drm-dp 08/10] drm/hisilicon/hibmc: fix no showing when no connectors connected

2025-06-28 Thread Dmitry Baryshkov
On Fri, Jun 20, 2025 at 05:31:02PM +0800, Yongbang Shi wrote: > From: Baihan Li > > Our chip support KVM over IP feature, so hibmc driver need to support > displaying without any connectors plugged in. Deleting the detect_ctx() > of VGA to make it connected when no connector is detected. I think

Re: [PATCH v2 drm-dp 07/10] drm/hisilicon/hibmc: fix dp and vga cannot show together

2025-06-28 Thread Dmitry Baryshkov
On Fri, Jun 20, 2025 at 05:31:01PM +0800, Yongbang Shi wrote: > From: Baihan Li > > If VGA and DP connected together, there will be only one can get crtc. > Add encoder possible_clones to support two connectors enable. > > Fixes: 0ab6ea261c1f ("drm/hisilicon/hibmc: add dp module in hibmc") > Fix

Re: [PATCH v2 drm-dp 06/10] drm/hisilicon/hibmc: add dp mode valid check

2025-06-28 Thread Dmitry Baryshkov
On Fri, Jun 20, 2025 at 05:31:00PM +0800, Yongbang Shi wrote: > From: Baihan Li > > If DP is connected, add mode check and BW check in mode_valid_ctx() to > ensure DP's cfg is usable. > > Fixes: f9698f802e50 ("drm/hisilicon/hibmc: Restructuring the header dp_reg.h") > Signed-off-by: Baihan Li >

Re: [PATCH v2 drm-dp 04/10] drm/hisilicon/hibmc: fix the hibmc loaded failed bug

2025-06-28 Thread Dmitry Baryshkov
On Fri, Jun 20, 2025 at 05:30:58PM +0800, Yongbang Shi wrote: > From: Baihan Li > > When hibmc loaded failed, the driver use hibmc_unload to free the > resource, but the mutexes in mode.config are not init, which will > access an NULL pointer. Just change goto statement to return, because > hibnc

Re: [PATCH v2 drm-dp 03/10] drm/hisilicon/hibmc: fix irq_request()'s irq name variable is local

2025-06-28 Thread Dmitry Baryshkov
On Fri, Jun 20, 2025 at 05:30:57PM +0800, Yongbang Shi wrote: > From: Baihan Li > > The local variable is passed in request_irq (), and there will be use > after free problem, which will make request_irq failed. Using the global > irq name instead of it to fix. > > Fixes: b11bc1ae4658 ("drm/hisi

Re: [PATCH v2 drm-dp 01/10] drm/hisilicon/hibmc: fix the i2c device resource leak when vdac init failed

2025-06-28 Thread Dmitry Baryshkov
On Fri, Jun 20, 2025 at 05:30:55PM +0800, Yongbang Shi wrote: > From: Baihan Li > > Currently the driver missed to clean the i2c adapter when vdac init failed. > It may cause resource leak. > > Fixes: a0d078d06e516 ("drm/hisilicon: Features to support reading resolutions > from EDID") > Signed-

Re: Help: Samsung Exynos 7870 DECON SYSMMU panic

2025-06-28 Thread Kaustabh Chakraborty
On 2025-06-25 11:34, Robin Murphy wrote: On 2025-06-25 9:42 am, Marek Szyprowski wrote: On 25.06.2025 09:39, Kaustabh Chakraborty wrote: On 2025-06-24 17:12, Robin Murphy wrote: On 2025-06-18 3:02 pm, Kaustabh Chakraborty wrote: Since bcb81ac6ae3c (iommu: Get DT/ACPI parsing into the proper p

Re: [PATCH v6 9/9] PCI: Add a new 'boot_display' attribute

2025-06-28 Thread kernel test robot
g (https://download.01.org/0day-ci/archive/20250628/202506282240.aqa0j5m3-...@intel.com/config) compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project e04c938cc08a90ae60440ce22d072ebc69d67ee8) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250628/2

Re: [PATCH] Introduce Tyr

2025-06-28 Thread Miguel Ojeda
On Sat, Jun 28, 2025 at 3:06 PM Daniel Almeida wrote: > > The branch I shared is drm-misc-next plus a few dependencies, i.e.: 10 commits > total if I counted it correctly - all of which have been sent to the list > already and most of which have seen a quite a few iterations. I should have > expli

[PATCH] drm/tests: Initialize framebuffer's filp_head in drm_test_framebuffer_free()

2025-06-28 Thread Sasha Levin
The drm_test_framebuffer_free() test creates a framebuffer on the stack without properly initializing the filp_head list, causing the following warning when drm_framebuffer_free() checks it: [ 144.996969] drm-kunit-mock-device drm_test_framebuffer_free.drm-kunit-mock-device: [drm] drm_WARN_ON(\

Re: [PATCH 1/3] dt-bindings: display/msm/gpu: account for 7xx GPUs in clocks conditions

2025-06-28 Thread Konrad Dybcio
On 6/28/25 5:02 AM, Dmitry Baryshkov wrote: > Handle two cases for Adreno 7xx: > - Adreno 702 follows A610 and A619 example and has clocks in the GPU > node. > - Newer 7xx GPUs use a different pattern for the compatibles and did not > match currently. > > Signed-off-by: Dmitry Baryshkov > ---

Re: [PATCH] Introduce Tyr

2025-06-28 Thread FUJITA Tomonori
Hi, On Sat, 28 Jun 2025 10:05:11 -0300 Daniel Almeida wrote: > Anyway, I thought that having a branch would be more tidy than listing them, > as > the branch shows in what order they're applied and etc. For example, the patch > for read_poll_timeout was cherry-picked from Fujita's v12 series, a

Re: [PATCH v7 00/42] drm/msm: sparse / "VM_BIND" support

2025-06-28 Thread Antonino Maniscalco
On 6/25/25 8:46 PM, Rob Clark wrote: Conversion to DRM GPU VA Manager[1], and adding support for Vulkan Sparse Memory[2] in the form of: 1. A new VM_BIND submitqueue type for executing VM MSM_SUBMIT_BO_OP_MAP/ MAP_NULL/UNMAP commands 2. A new VM_BIND ioctl to allow submitting batches of one

Re: [PATCH] Introduce Tyr

2025-06-28 Thread Daniel Almeida
Hi Miguel, > On 28 Jun 2025, at 06:44, Miguel Ojeda > wrote: > > Hi Daniel, > > Some procedural notes and general comments, and please note that some > may apply several times. > > On Sat, Jun 28, 2025 at 12:35 AM Daniel Almeida > wrote: >> >> Signed-off-by: Rob Herring >> >> Signed-off-b

Re: [PATCH v4 1/4] dt-bindings: misc: qcom,fastrpc: Add GDSP label

2025-06-28 Thread Krzysztof Kozlowski
On Fri, Jun 27, 2025 at 04:03:16PM +0530, Ling Xu wrote: > Add "gdsp" as the new supported label for GDSP fastrpc domain. > > Signed-off-by: Ling Xu > --- > Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 2 ++ > 1 file changed, 2 insertions(+) > NAK, nothing improved. You got comme

Re: [PATCH v4 02/10] mei: late_bind: add late binding component driver

2025-06-28 Thread Greg KH
On Wed, Jun 25, 2025 at 10:30:07PM +0530, Badal Nilawar wrote: > +/** > + * struct late_bind_component_ops - ops for Late Binding services. > + * @owner: Module providing the ops > + * @push_config: Sends a config to FW. > + */ > +struct late_bind_component_ops { > + struct module *owner; I do

Re: [PATCH v4 02/10] mei: late_bind: add late binding component driver

2025-06-28 Thread Greg KH
On Wed, Jun 25, 2025 at 10:30:07PM +0530, Badal Nilawar wrote: > --- /dev/null > +++ b/drivers/misc/mei/late_bind/mei_late_bind.c > @@ -0,0 +1,281 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2025 Intel Corporation > + */ > +#include > +#include > +#include > +#include >

Re: [PATCH v2 1/5] dt-bindings: display: simple-framebuffer: Add interconnects property

2025-06-28 Thread Krzysztof Kozlowski
On 27/06/2025 13:34, Thomas Zimmermann wrote: > Hi > > Am 27.06.25 um 10:08 schrieb Krzysztof Kozlowski: >> On Mon, Jun 23, 2025 at 08:44:45AM +0200, Luca Weiss wrote: >>> Document the interconnects property which is a list of interconnect >>> paths that is used by the framebuffer and therefore ne

Re: [PATCH v2 1/5] dt-bindings: display: simple-framebuffer: Add interconnects property

2025-06-28 Thread Krzysztof Kozlowski
On 27/06/2025 11:48, Luca Weiss wrote: > Hi Krzysztof, > > On Fri Jun 27, 2025 at 10:08 AM CEST, Krzysztof Kozlowski wrote: >> On Mon, Jun 23, 2025 at 08:44:45AM +0200, Luca Weiss wrote: >>> Document the interconnects property which is a list of interconnect >>> paths that is used by the framebuff

Re: [PATCH v6 6/8] drm/vkms: Change YUV helpers to support u16 inputs for conversion

2025-06-28 Thread Maíra Canal
Hi Louis, On 6/27/25 19:45, Louis Chauvet wrote: Some YUV format uses 16 bit values, so change the helper function for conversion to support those new formats. Signed-off-by: Louis Chauvet Reviewed-by: Maíra Canal Best Regards, - Maíra --- drivers/gpu/drm/vkms/tests/vkms_format_test.c

Re: [PATCH] Introduce Tyr

2025-06-28 Thread Miguel Ojeda
Hi Daniel, Some procedural notes and general comments, and please note that some may apply several times. On Sat, Jun 28, 2025 at 12:35 AM Daniel Almeida wrote: > > Signed-off-by: Rob Herring > > Signed-off-by: Daniel Almeida No newline. > [2]: https://gitlab.freedesktop.org/panfrost/linux/-

Re: [PATCH] Introduce Tyr

2025-06-28 Thread Miguel Ojeda
On Sat, Jun 28, 2025 at 2:13 AM Daniel Almeida wrote: > > Also, for some reason the Clippy lint did not save me this time. Hmm... it should -- I tried to build it and Clippy reports it. There is also another warning too [1]. I see the compiler reporting [2] too. By the way, do you need to depen

Re: [PATCH] MAINTAINERS: Add missing sysfb files to firmware framebuffers entry

2025-06-28 Thread Javier Martinez Canillas
Javier Martinez Canillas writes: > The commit d391c5827107 ("drivers/firmware: move x86 Generic System > Framebuffers support") moved the sysfb*.c source files from arch/x86 > to drivers/firmware, because the logic wasn't x86 specific and could > be used by other architectures. > > But the driver

Re: [PATCH] drm/fourcc: Add RGB161616 and BGR161616 formats

2025-06-28 Thread Javier Martinez Canillas
Rob Clark writes: > On Fri, Jun 27, 2025 at 12:10 PM Javier Martinez Canillas > wrote: >> >> Laurent Pinchart writes: >> >> > On Fri, Jun 27, 2025 at 09:39:37AM -0700, Rob Clark wrote: >> >> On Mon, Feb 26, 2024 at 5:43 AM Jacopo Mondi wrote: >> >> > >> >> > Add FourCC definitions for the 48-bi