Re: [PATCH v15 0/9] ref_tracker: add ability to register a debugfs file for a ref_tracker_dir

2025-06-20 Thread Eric Dumazet
On Thu, Jun 19, 2025 at 5:13 PM Jakub Kicinski wrote: > > On Wed, 18 Jun 2025 10:24:13 -0400 Jeff Layton wrote: > > For those just joining in, this series adds a new top-level > > "ref_tracker" debugfs directory, and has each ref_tracker_dir register a > > file in there as part of its initializati

[PATCH] drm/amdgpu: Use str_on_off() helper

2025-06-20 Thread long.yunjian
From: Yumeng Fang Remove hard-coded strings by using the str_on_off() helper. Signed-off-by: Yumeng Fang --- drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdg

RE: [PATCH] mm/hugetlb: Don't crash when allocating a folio if there are no resv

2025-06-20 Thread Kasireddy, Vivek
Hi Oscar, > Subject: Re: [PATCH] mm/hugetlb: Don't crash when allocating a folio if there > are no resv > > On Tue, Jun 17, 2025 at 10:28:40PM -0700, Vivek Kasireddy wrote: > > There are cases when we try to pin a folio but discover that it has > > not been faulted-in. So, we try to allocate it i

Re: [RFC PATCH 00/30] Host side (KVM/VFIO/IOMMUFD) support for TDISP using TSM

2025-06-20 Thread Alexey Kardashevskiy
On 11/6/25 11:55, Alexey Kardashevskiy wrote: Hi, Is there a QEMU tree using this somewhere? Ping? Thanks, Also it would be nice to have this tree pushed somewhere, saves time. Thanks, On 29/5/25 15:34, Xu Yilun wrote: This series is the generic host side (KVM/VFIO/IOMMUFD) supp

[PATCH 1/4] panthor: set owner field for driver fops

2025-06-20 Thread Chia-I Wu
It allows us to get rid of manual try_module_get / module_put. Signed-off-by: Chia-I Wu --- drivers/gpu/drm/panthor/panthor_drv.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c ind

[PATCH 4/4] panthor: dump task pid and comm on gpu errors

2025-06-20 Thread Chia-I Wu
It is useful to know which tasks cause gpu errors. Signed-off-by: Chia-I Wu --- drivers/gpu/drm/panthor/panthor_sched.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.

[PATCH 3/4] panthor: save task pid and comm in panthor_file

2025-06-20 Thread Chia-I Wu
We would like to report them on gpu errors. Signed-off-by: Chia-I Wu --- drivers/gpu/drm/panthor/panthor_device.h | 6 ++ drivers/gpu/drm/panthor/panthor_drv.c| 9 + 2 files changed, 15 insertions(+) diff --git a/drivers/gpu/drm/panthor/panthor_device.h b/drivers/gpu/drm/pantho

[PATCH 2/4] panthor: save panthor_file in panthor_group

2025-06-20 Thread Chia-I Wu
We would like to access panthor_file from panthor_group on gpu errors. Because panthour_group can outlive drm_file, add refcount to panthor_file to ensure its lifetime. Signed-off-by: Chia-I Wu --- drivers/gpu/drm/panthor/panthor_device.h | 16 drivers/gpu/drm/panthor/panthor_dr

[PATCH 0/4] panthor: print task pid and comm on gpu errors

2025-06-20 Thread Chia-I Wu
This series saves task pid and comm in panthor_file, ensures panthor_group can access panthor_file, and prints task pid and comm on gpu errors. Chia-I Wu (4): panthor: set owner field for driver fops panthor: save panthor_file in panthor_group panthor: save task pid and comm in panthor_file

Re: [PATCH v3 6/7] PCI/VGA: Move check for firmware default out of VGA arbiter

2025-06-20 Thread Mario Limonciello
On 6/20/2025 3:45 AM, Thomas Zimmermann wrote: Hi Am 20.06.25 um 04:49 schrieb Mario Limonciello: From: Mario Limonciello The x86 specific check for whether a framebuffer belongs to a device works for display devices as well as VGA devices.  Callers to video_is_primary_device() can benefit fr

Re: [PATCH v3 0/4] Support for Adreno X1-45 GPU

2025-06-20 Thread Aleksandrs Vinarskis
On 6/20/25 08:54, Akhil P Oommen wrote: Add support for X1-45 GPU found in X1P41200 chipset (8 cpu core version). X1-45 is a smaller version of X1-85 with lower core count and smaller memories. From UMD perspective, this is similar to "FD735" present in Mesa. Tested Glmark & Vkmark on Debian G

Re: [PATCH v3 0/4] Support for Adreno X1-45 GPU

2025-06-20 Thread Jens Glathe
On 20.06.25 08:54, Akhil P Oommen wrote: Add support for X1-45 GPU found in X1P41200 chipset (8 cpu core version). X1-45 is a smaller version of X1-85 with lower core count and smaller memories. From UMD perspective, this is similar to "FD735" present in Mesa. Tested Glmark & Vkmark on Debian Gn

Re: [PATCH v2 04/16] drm/panel/sun4i: Keep up with refcounting

2025-06-20 Thread Anusha Srivatsa
On Fri, Jun 20, 2025 at 8:27 AM Maxime Ripard wrote: > Hi, > > On Thu, Jun 19, 2025 at 02:15:56PM -0500, Anusha Srivatsa wrote: > > Put the panel reference back when driver is no > > longer using it. > > > > Signed-off-by: Anusha Srivatsa > > When I asked you to provide a rationale for why you t

Re: [PATCH v2 01/16] drm/panel: get/put panel reference in drm_panel_add/remove()

2025-06-20 Thread Anusha Srivatsa
On Fri, Jun 20, 2025 at 4:11 AM Maxime Ripard wrote: > On Fri, Jun 20, 2025 at 10:33:53AM +0200, Luca Ceresoli wrote: > > Hello Anusha, > > > > On Thu, 19 Jun 2025 14:15:53 -0500 > > Anusha Srivatsa wrote: > > > > > Take the panel reference and put it back as required. > > > drm_panel_add() and

Re: [PATCH v2 6/6] drm/etnaviv: Add module parameter to force PPU flop reset

2025-06-20 Thread Lucas Stach
Am Mittwoch, dem 18.06.2025 um 22:43 +0200 schrieb Gert Wollny: > Signed-off-by: Gert Wollny > --- > drivers/gpu/drm/etnaviv/etnaviv_flop_reset.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_flop_reset.c > b/drivers/gpu/drm/etnaviv/etnaviv_fl

Re: [PATCH v2 5/6] drm/etnaviv: Add PPU flop reset

2025-06-20 Thread Lucas Stach
Am Mittwoch, dem 18.06.2025 um 22:43 +0200 schrieb Gert Wollny: > The PPU flop reset is required on some hardware to clear the > temporary registers. This implementation follows the code > implemented in the public galcore kernel module code to this > for the PPU. > > v2: - Move flop reset data to

Re: (subset) [PATCH 0/3] rockchip: Add GPU support for RK3528

2025-06-20 Thread Heiko Stuebner
On Sun, 18 May 2025 22:54:10 +, Jonas Karlman wrote: > This series adds support for the Mali-450 MP2 GPU in the RK3528 SoC. > > The clock used for the GPU can use normal PLL to support a rate of 100, > 300 or 500 MHz. Or it can use PVTPLL to reach rates up to 800 MHz. > > The TF-A SCMI_CLK_

Re: [PATCH v2 4/6] drm/etnaviv: Identify GPU already when binding

2025-06-20 Thread Lucas Stach
Am Mittwoch, dem 18.06.2025 um 22:43 +0200 schrieb Gert Wollny: > This is required to know whether to be able to avoid allocating > the flop reset data if non of the available GPUs actually need > it. > I'm surprised that this works on your platform at all. You can not move the identification here

[PATCH] drm/etnaviv: remove unnecessary cache flushes on pipe switch

2025-06-20 Thread Lucas Stach
The current pipe switch sequence is ported from the Vivante driver, which does flush some caches before switching to another pipe. This however, is not necessary with etnaviv, as we always flush all write caches before completion of a cmdstream. Thus the caches are already clean before execution of

[PATCH] drm/etnaviv: disable pulse eater on cores with 3D pipe and revision > 0x5420

2025-06-20 Thread Lucas Stach
The downstream driver switched from only disabling internal DFS on those cores to clearing bit 16 and setting bit 17 in commit "MGS-3448: gpu-viv: fix 6.2.4 remaning issues". This, as far as is known, completely disables the pulse eater. Signed-off-by: Lucas Stach --- drivers/gpu/drm/etnaviv/etn

[PATCH 1/2] drm/etnaviv: reset bit 0 when disabling pulse eater for reset

2025-06-20 Thread Lucas Stach
It seems this bit is sticky across the reset. The downstream driver pulses this bit on and off in the reset sequence, which had been missed when porting this part over from the Vivante driver. While no bad behavior has been observed when the bit is active after reset, better be safe than sorry and

[PATCH 2/2] drm/etnaviv: don't touch clock gating register during reset

2025-06-20 Thread Lucas Stach
While the Vivante driver also claims to disable clock gating during reset (in reality it doesn't because it clears the wrong register and *enables* clock gating for all modules), it has been shown that switching the clock gating enable state in the reset sequence has made the GPU reset less reliabl

Re: [PATCH 1/2] mm: add gpu active/reclaim per-node stat counters (v2)

2025-06-20 Thread Shakeel Butt
On Thu, Jun 19, 2025 at 05:20:25PM +1000, Dave Airlie wrote: > From: Dave Airlie > > While discussing memcg intergration with gpu memory allocations, > it was pointed out that there was no numa/system counters for > GPU memory allocations. > > With more integrated memory GPU server systems turni

[PATCH v3 2/2] drm/gpuvm: Add locking helpers

2025-06-20 Thread Rob Clark
For UNMAP/REMAP steps we could be needing to lock objects that are not explicitly listed in the VM_BIND ioctl in order to tear-down unmapped VAs. These helpers handle locking/preparing the needed objects. Note that these functions do not strictly require the VM changes to be applied before the ne

Re: [PATCH 2/3] drm/sysfb: simpledrm: Add support for interconnect paths

2025-06-20 Thread Thomas Zimmermann
Hi Am 20.06.25 um 12:31 schrieb Luca Weiss: Some devices might require keeping an interconnect path alive so that the framebuffer continues working. Add support for that by setting the bandwidth requirements appropriately for all provided interconnect paths. Signed-off-by: Luca Weiss --- dri

Re: [PATCH 3/3] fbdev/simplefb: Add support for interconnect paths

2025-06-20 Thread Thomas Zimmermann
Hi Am 20.06.25 um 12:31 schrieb Luca Weiss: Some devices might require keeping an interconnect path alive so that the framebuffer continues working. Add support for that by setting the bandwidth requirements appropriately for all provided interconnect paths. Signed-off-by: Luca Weiss --- dri

[PATCH v8 2/5] drm/bridge: get the bridge returned by drm_bridge_chain_get_first_bridge()

2025-06-20 Thread Luca Ceresoli
drm_bridge_chain_get_first_bridge() returns a bridge pointer that the caller could hold for a long time. Increment the refcount of the returned bridge and document it must be put by the caller. Reviewed-by: Maxime Ripard Signed-off-by: Luca Ceresoli --- This patch was added in v7. --- include/

[PATCH v8 5/5] drm/probe-helper: put the bridge returned by drm_bridge_chain_get_first_bridge()

2025-06-20 Thread Luca Ceresoli
The bridge returned by drm_bridge_chain_get_first_bridge() is refcounted. Put it when done. Reviewed-by: Maxime Ripard Signed-off-by: Luca Ceresoli --- This patch was added in v7. --- drivers/gpu/drm/drm_probe_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_pro

[PATCH v8 1/5] drm/bridge: add a cleanup action for scope-based drm_bridge_put() invocation

2025-06-20 Thread Luca Ceresoli
Many functions get a drm_bridge pointer, only use it in the function body (or a smaller scope such as a loop body), and don't store it. In these cases they always need to drm_bridge_put() it before returning (or exiting the scope). Some of those functions have complex code paths with multiple retu

Re: [PATCH] drm/msm/dp: add linux/io.h header to fix build errors

2025-06-20 Thread Dmitry Baryshkov
On Tue, 17 Jun 2025 11:56:11 -0700, Randy Dunlap wrote: > Add header to pull in readl/writel and friends. > This eliminates the following build errors: > > drivers/gpu/drm/msm/dp/dp_panel.c: In function 'msm_dp_read_link': > drivers/gpu/drm/msm/dp/dp_panel.c:33:16: error: implicit declaration o

Re: [PATCH v7 00/13] drm/msm: Add support for SM8750

2025-06-20 Thread Dmitry Baryshkov
On Wed, 18 Jun 2025 16:32:29 +0200, Krzysztof Kozlowski wrote: > Dependency / Rabased on top of > == > https://lore.kernel.org/r/20250522-dpu-drop-features-v5-0-3b2085a07...@oss.qualcomm.com/ > > Changes in v7: > = > - Add ack/rb tags > - Drop unrelated DS

Re: [PATCH] drm/msm/dpu: Fill in min_prefill_lines for SC8180X

2025-06-20 Thread Dmitry Baryshkov
On Tue, 10 Jun 2025 14:50:03 +0200, Konrad Dybcio wrote: > Based on the downstream release, predictably same value as for SM8150. > > Applied, thanks! [1/1] drm/msm/dpu: Fill in min_prefill_lines for SC8180X https://gitlab.freedesktop.org/lumag/msm/-/commit/457fad6dee5e Best regards, -

Re: [PATCH v6 00/11] drm/msm/dp: perform misc cleanups

2025-06-20 Thread Dmitry Baryshkov
On Sun, 18 May 2025 14:21:33 +0300, Dmitry Baryshkov wrote: > Rework most of the register programming functions to be local to the > calling module rather than accessing everything through huge dp_catalog > monster. > > Applied, thanks! [01/11] drm/msm/dp: split MMSS_DP_DSC_DTO register write

Re: [PATCH v5 00/30] drm/msm/dpu: rework HW block feature handling

2025-06-20 Thread Dmitry Baryshkov
On Thu, 22 May 2025 22:03:19 +0300, Dmitry Baryshkov wrote: > Some time ago we started the process of converting HW blocks to use > revision-based checks instead of having feature bits (which are easy to > miss or to set incorrectly). Then the process of such a conversion was > postponed. (Mostly

[PATCH v3 1/2] drm/gpuvm: Fix doc comments

2025-06-20 Thread Rob Clark
Correctly summerize drm_gpuvm_sm_map/unmap, and fix the parameter order and names. Just something I noticed in passing. v2: Don't rename the arg names in prototypes to match function declarations [Danilo] Signed-off-by: Rob Clark Acked-by: Danilo Krummrich --- drivers/gpu/drm/drm_gpuvm.c

[PATCH v3 0/2] drm/gpuvm: Locking helpers

2025-06-20 Thread Rob Clark
First patch is just some cleanup. The second patch adds helpers for drivers to deal with "invisible" unmapped BO locking. Ie. a VM_BIND ioctl won't explicitly list BOs associated with unmapped/remapped VAs making locking all the BOs involved in a VM_BIND ioclt harder than it needs to be. The hel

Re: [PATCH 3/3] drm/bridge: add warning for bridges not using devm_drm_bridge_alloc()

2025-06-20 Thread Maxime Ripard
Hi Luca, On Fri, Jun 20, 2025 at 11:32:08AM +0200, Luca Ceresoli wrote: > To the best of my knowledge, all drivers in the mainline kernel adding a > DRM bridge are now converted to using devm_drm_bridge_alloc() for > allocation and initialization. Among others this ensures initialization of > the

[PATCH v2 drm-dp 10/10] drm/hisilicon/hibmc: adapting modification for the former commit

2025-06-20 Thread Yongbang Shi
From: Baihan Li Add colorbar disable operation and move hdcp opreation behind the reset controller operation. Fixes: 3c7623fb5bb6 ("drm/hisilicon/hibmc: Enable this hot plug detect of irq feature") Fixes: 94ee73ee3020 ("drm/hisilicon/hibmc: add dp hw moduel in hibmc driver") Signed-off-by: Baih

Re: [PATCH 1/2] mm: add gpu active/reclaim per-node stat counters (v2)

2025-06-20 Thread Zi Yan
On 19 Jun 2025, at 3:20, Dave Airlie wrote: > From: Dave Airlie > > While discussing memcg intergration with gpu memory allocations, > it was pointed out that there was no numa/system counters for > GPU memory allocations. > > With more integrated memory GPU server systems turning up, and > more

[PATCH v8 0/5] drm/bridge: get/put the bridge returned by drm_bridge_chain_get_first_bridge()

2025-06-20 Thread Luca Ceresoli
s changed, 19 insertions(+), 3 deletions(-) --- base-commit: a59a271769149f0b8258507276f3d2a24370cbdb change-id: 20250620-drm-bridge-alloc-getput-drm_bridge_chain_get_first_bridge-be39c442dcd6 Best regards, -- Luca Ceresoli

Re: [PATCH] rust: drm: Drop the use of Opaque for ioctl arguments

2025-06-20 Thread Daniel Almeida
Hi Beata, > There is no concurrent access nor shared references, unless the > handler decides otherwise It can’t do so in safe code. There is no way to manufacture a shared reference from a mutable one in safe code and if it passes that to C, then it’s already using a unsafe block for the ffi ca

Re: [PATCH] rust: drm: Drop the use of Opaque for ioctl arguments

2025-06-20 Thread Beata Michalska
On Thu, Jun 19, 2025 at 09:30:19AM -0300, Daniel Almeida wrote: > Hi Beata, > > > On 19 Jun 2025, at 07:21, Beata Michalska wrote: > > > > With the Opaque, the expectations are that Rust should not make any > > assumptions on the layout or invariants of the wrapped C types. > > That runs rather

Re: [PATCH 10/10] fs: replace mmap hook with .mmap_prepare for simple mappings

2025-06-20 Thread Ryusuke Konishi
On Tue, Jun 17, 2025 at 4:48 AM Lorenzo Stoakes wrote: > > Since commit c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file > callback"), the f_op->mmap() hook has been deprecated in favour of > f_op->mmap_prepare(). > > This callback is invoked in the mmap() logic far earlier, so error handling

Re: [PATCH v3 28/54] dyndbg: restore classmap protection when theres a controlling_param

2025-06-20 Thread Sean Paul
On Thu, Apr 3, 2025 at 9:48 AM Jim Cromie wrote: > \snip > > -static void ddebug_match_apply_kparam(const struct kernel_param *kp, > - const struct _ddebug_class_map *map, > - const char *mod_name) > +static struct _ddebug_c

Re: [PATCH] drm/bridge: samsung-dsim: Fix init order

2025-06-20 Thread Hiago De Franco
On Thu, Jun 19, 2025 at 03:27:18PM +0300, Tomi Valkeinen wrote: > The commit c9b1150a68d9 ("drm/atomic-helper: Re-order bridge chain > pre-enable and post-disable") changed the order of enable/disable calls. > Previously the calls (on imx8mm) were: > > mxsfb_crtc_atomic_enable() > samsung_dsim_ato

Re: [PATCH] rust: drm: Drop the use of Opaque for ioctl arguments

2025-06-20 Thread Beata Michalska
On Thu, Jun 19, 2025 at 12:55:08PM +0200, Danilo Krummrich wrote: > On Thu, Jun 19, 2025 at 12:21:02PM +0200, Beata Michalska wrote: > > With the Opaque, the expectations are that Rust should not make any > > assumptions on the layout or invariants of the wrapped C types. > > That runs rather count

Re: [PATCH] rust: drm: Drop the use of Opaque for ioctl arguments

2025-06-20 Thread Beata Michalska
On Thu, Jun 19, 2025 at 03:17:31PM +0200, Benno Lossin wrote: > On Thu Jun 19, 2025 at 2:26 PM CEST, Daniel Almeida wrote: > > Hi Benno, > > > >> On 19 Jun 2025, at 08:01, Benno Lossin wrote: > >> > >> On Thu Jun 19, 2025 at 12:55 PM CEST, Danilo Krummrich wrote: > >>> On Thu, Jun 19, 2025 at 12:

[PATCH] rust: drm: Drop the use of Opaque for ioctl arguments

2025-06-20 Thread Beata Michalska
With the Opaque, the expectations are that Rust should not make any assumptions on the layout or invariants of the wrapped C types. That runs rather counter to ioctl arguments, which must adhere to certain data-layout constraints. By using Opaque, ioctl handlers end up doing unsound castings, which

[PATCH v8 3/5] drm/mxsfb: put the bridge returned by drm_bridge_chain_get_first_bridge()

2025-06-20 Thread Luca Ceresoli
The bridge returned by drm_bridge_chain_get_first_bridge() is refcounted. Put it when done. Use a scope-based free action to catch all the code paths. Reviewed-by: Maxime Ripard Signed-off-by: Luca Ceresoli --- This patch was added in v7. --- drivers/gpu/drm/mxsfb/lcdif_kms.c | 3 ++- 1 file c

[PATCH v8 4/5] drm/atomic-helper: put the bridge returned by drm_bridge_chain_get_first_bridge()

2025-06-20 Thread Luca Ceresoli
The bridge returned by drm_bridge_chain_get_first_bridge() is refcounted. Put it when done. Signed-off-by: Luca Ceresoli --- Changes in v8: - reworked after the changes in pre_enable/post_disable order: f6ee26f58870 ("drm/atomic-helper: Refactor crtc & encoder-bridge op loops into separate fu

[PATCH v2 drm-dp 01/10] drm/hisilicon/hibmc: fix the i2c device resource leak when vdac init failed

2025-06-20 Thread Yongbang Shi
From: Baihan Li Currently the driver missed to clean the i2c adapter when vdac init failed. It may cause resource leak. Fixes: a0d078d06e516 ("drm/hisilicon: Features to support reading resolutions from EDID") Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- ChangeLog: v1 -> v2: - u

Re: DRM scheduler issue with spsc_queue

2025-06-20 Thread Matthew Brost
On Mon, Jun 16, 2025 at 12:42:53PM +0200, Simona Vetter wrote: > On Mon, Jun 16, 2025 at 09:24:38AM +0200, Christian König wrote: > > On 6/13/25 21:11, Matthew Brost wrote: > > > On Fri, Jun 13, 2025 at 07:26:22PM +0200, Christian König wrote: > > >> On 6/13/25 19:01, Matthew Brost wrote: > > >>> A

Re: [PATCH v3 07/10] drm/xe/xe_late_bind_fw: Reload late binding fw in S2Idle/S3 resume

2025-06-20 Thread Nilawar, Badal
On 20-06-2025 19:19, Rodrigo Vivi wrote: On Thu, Jun 19, 2025 at 12:30:04AM +0530, Badal Nilawar wrote: Reload late binding fw during S2Idle/S3 resume. Signed-off-by: Badal Nilawar --- drivers/gpu/drm/xe/xe_pm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_

Re: [PATCH 3/3] drm/bridge: add warning for bridges not using devm_drm_bridge_alloc()

2025-06-20 Thread Luca Ceresoli
Hi Maxime, On Fri, 20 Jun 2025 13:41:48 +0200 Maxime Ripard wrote: > Hi Luca, > > On Fri, Jun 20, 2025 at 11:32:08AM +0200, Luca Ceresoli wrote: > > To the best of my knowledge, all drivers in the mainline kernel adding a > > DRM bridge are now converted to using devm_drm_bridge_alloc() for > >

[PATCH] drm/bridge: ti-sn65dsi86: remove unnecessary GPIO line direction check

2025-06-20 Thread Bartosz Golaszewski
From: Bartosz Golaszewski As of commit 92ac7de3175e3 ("gpiolib: don't allow setting values on input lines"), the GPIO core makes sure values cannot be set on input lines. Remove the unnecessary check. Signed-off-by: Bartosz Golaszewski --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 5 - 1 fil

[PATCH v9 2/3] drm/bridge: get/put the bridge reference in drm_bridge_attach/detach()

2025-06-20 Thread Luca Ceresoli
drm_bridge_attach() adds the bridge to the encoder chain, so take a reference for that. Vice versa in drm_bridge_detach(). Reviewed-by: Maxime Ripard Signed-off-by: Luca Ceresoli --- Changes in v9: none Changes in v8: none Changes in v7: - in v6 this was part of "drm/bridge: add support for re

[PATCH v9 3/3] drm/bridge: add warning for bridges not using devm_drm_bridge_alloc()

2025-06-20 Thread Luca Ceresoli
To the best of my knowledge, all drivers in the mainline kernel adding a DRM bridge are now converted to using devm_drm_bridge_alloc() for allocation and initialization. Among others this ensures initialization of the bridge refcount, allowing dynamic allocation lifetime. devm_drm_bridge_alloc() i

[PATCH v9 1/3] drm/bridge: get/put the bridge reference in drm_bridge_add/remove()

2025-06-20 Thread Luca Ceresoli
drm_bridge_add() adds the bridge to the global bridge_list, so take a reference for that. Vice versa in drm_bridge_remove(). Reviewed-by: Maxime Ripard Signed-off-by: Luca Ceresoli --- Changes in v9: none Changes in v8: none Changes in v7: - in v6 this was part of "drm/bridge: add support for

[PATCH v9 0/3] drm/bridge: get/put the bridge reference in drm_bridge.c, warn on old alloc pattern

2025-06-20 Thread Luca Ceresoli
c3...@bootlin.com/t/#u [2] https://lore.kernel.org/all/20250314-drm-bridge-refcount-v7-0-152571f8c...@bootlin.com/ Signed-off-by: Luca Ceresoli --- Changes in v9: - patch 3: change warning trigger from "refcount != 1" to "container not NULL" - Link to v8 (counted as v1 by mistake):

Re: [PATCH v3 7/7] fbcon: Make a symlink to the device selected as primary

2025-06-20 Thread Mario Limonciello
On 6/20/25 3:47 AM, Thomas Zimmermann wrote: Hi Am 20.06.25 um 04:49 schrieb Mario Limonciello: From: Mario Limonciello Knowing which device is the primary device can be useful for userspace to make decisions on which device to start a display server. Create a link to that device called 'pri

Re: [PATCH v3 4/4] arm64: dts: qcom: Add GPU support to X1P42100 SoC

2025-06-20 Thread Konrad Dybcio
On 6/20/25 8:54 AM, Akhil P Oommen wrote: > X1P42100 SoC has a new GPU called Adreno X1-45 which is a smaller > version of Adreno X1-85 GPU. Describe this new GPU and also add > the secure gpu firmware path that should used for X1P42100 CRD. > > Tested-by: Jens Glathe > Signed-off-by: Akhil P Oom

Re: [PATCH v4 4/7] drm/panthor: Introduce sampling sessions to handle userspace clients

2025-06-20 Thread Steven Price
Hi Lukas, I was going to try testing this out, but it doesn't look functional. See below. On 16/05/2025 16:49, Lukas Zapolskas wrote: [...] > diff --git a/drivers/gpu/drm/panthor/panthor_perf.c > b/drivers/gpu/drm/panthor/panthor_perf.c > index 9365ce9fed04..15fa533731f3 100644 > --- a/drivers/g

Re: [PATCH v6 0/5] Add Mali GPU support for Mediatek MT8370 SoC

2025-06-20 Thread Steven Price
All 5 patches push to drm-misc-next. Thanks, Steve On 09/05/2025 11:12, Louis-Alexis Eyraud wrote: > This patchset adds the support of the ARM Mali G57 MC2 GPU (Valhall-JM, > dual core), integrated in the Mediatek MT8370 SoC, to the panfrost > driver and to the mt8370.dtsi include file. > > Sinc

[PATCH 1/2] drm/fourcc: Add missing half-float formats

2025-06-20 Thread Rob Clark
Not something that is likely to be scanned out, but GPUs usually support half-float formats with 1, 2, or possibly 3 components, and it is useful to be able to import/export them with a valid fourcc, and/or use gbm to create them. These correspond to PIPE_FORMAT_{R16,R16G16,R16G16B16}_FLOAT in mes

[PATCH 0/2] drm/fourcc: Add additional float formats

2025-06-20 Thread Rob Clark
GPUs support 1/2/3/4 component f16 and f32 formats. Define the missing fourcc's needed to import/export these formats, and/or create with gbm. Rob Clark (2): drm/fourcc: Add missing half-float formats drm/fourcc: Add 32b float formats include/uapi/drm/drm_fourcc.h | 16 +++- 1 f

[PATCH 2/2] drm/fourcc: Add 32b float formats

2025-06-20 Thread Rob Clark
Add 1, 2, 3, and 4 component 32b float formats, so that buffers with these formats can be imported/exported with fourcc+modifier, and/or created by gbm. These correspond to PIPE_FORMAT_{R32,R32G32,R32G32B32,R32G32B32A32}_FLOAT in mesa. Signed-off-by: Rob Clark --- include/uapi/drm/drm_fourcc.h

[PATCH] drm/msm/dp: include linux/io.h

2025-06-20 Thread Arnd Bergmann
From: Arnd Bergmann The driver started using readl/writel, which are defined in linux/io.h, so this needs to be included here: drivers/gpu/drm/msm/dp/dp_panel.c:33:9: error: call to undeclared function 'readl_relaxed'; ISO C99 and later do not support implicit function declarations [-Wimplicit

Re: [PATCH v3 08/10] drm/xe/xe_late_bind_fw: Introduce debug fs node to disable late binding

2025-06-20 Thread Rodrigo Vivi
On Thu, Jun 19, 2025 at 12:21:10PM +0530, Nilawar, Badal wrote: > > On 19-06-2025 02:49, Daniele Ceraolo Spurio wrote: > > > > > > On 6/18/2025 12:00 PM, Badal Nilawar wrote: > > > Introduce a debug filesystem node to disable late binding fw reload > > > during the system or runtime resume. This

Re: [PATCH v3 07/10] drm/xe/xe_late_bind_fw: Reload late binding fw in S2Idle/S3 resume

2025-06-20 Thread Rodrigo Vivi
On Thu, Jun 19, 2025 at 12:30:04AM +0530, Badal Nilawar wrote: > Reload late binding fw during S2Idle/S3 resume. > > Signed-off-by: Badal Nilawar > --- > drivers/gpu/drm/xe/xe_pm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.

Re: [PATCH] drm/msm/dp: include linux/io.h

2025-06-20 Thread Abel Vesa
On 25-06-20 14:47:43, Arnd Bergmann wrote: > From: Arnd Bergmann > > The driver started using readl/writel, which are defined in linux/io.h, > so this needs to be included here: > > drivers/gpu/drm/msm/dp/dp_panel.c:33:9: error: call to undeclared function > 'readl_relaxed'; ISO C99 and later d

Re: [PATCH v2 04/16] drm/panel/sun4i: Keep up with refcounting

2025-06-20 Thread Maxime Ripard
Hi, On Thu, Jun 19, 2025 at 02:15:56PM -0500, Anusha Srivatsa wrote: > Put the panel reference back when driver is no > longer using it. > > Signed-off-by: Anusha Srivatsa When I asked you to provide a rationale for why you think the drm_panel_put() call belonged where it does, it was pretty ob

Re: [PATCH 3/3] fbdev/simplefb: Add support for interconnect paths

2025-06-20 Thread Luca Weiss
On Fri Jun 20, 2025 at 2:36 PM CEST, Thomas Zimmermann wrote: > Hi > > Am 20.06.25 um 14:07 schrieb Luca Weiss: >> On Fri Jun 20, 2025 at 1:28 PM CEST, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 20.06.25 um 13:07 schrieb Luca Weiss: Hi Thomas, On Fri Jun 20, 2025 at 1:02 PM CEST, Tho

Re: [PATCH v1 0/2] debugfs support for pt base for each vm

2025-06-20 Thread Tvrtko Ursulin
On 13/06/2025 08:15, Sunil Khatri wrote: root@amd-X570-AORUS-ELITE:~# cat /sys/kernel/debug/dri/0/clients command tgid dev master a uid magic name client-id systemd-logind 1056 0 yy 0

Re: [PATCH 3/3] fbdev/simplefb: Add support for interconnect paths

2025-06-20 Thread Thomas Zimmermann
Hi Am 20.06.25 um 14:07 schrieb Luca Weiss: On Fri Jun 20, 2025 at 1:28 PM CEST, Thomas Zimmermann wrote: Hi Am 20.06.25 um 13:07 schrieb Luca Weiss: Hi Thomas, On Fri Jun 20, 2025 at 1:02 PM CEST, Thomas Zimmermann wrote: Hi Am 20.06.25 um 12:31 schrieb Luca Weiss: Some devices might req

Re: [PATCH 3/3] fbdev/simplefb: Add support for interconnect paths

2025-06-20 Thread Luca Weiss
On Fri Jun 20, 2025 at 1:28 PM CEST, Thomas Zimmermann wrote: > Hi > > Am 20.06.25 um 13:07 schrieb Luca Weiss: >> Hi Thomas, >> >> On Fri Jun 20, 2025 at 1:02 PM CEST, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 20.06.25 um 12:31 schrieb Luca Weiss: Some devices might require keeping an interc

[PATCH] drm/i915/wm: reduce stack usage in skl_print_wm_changes()

2025-06-20 Thread Arnd Bergmann
From: Arnd Bergmann When KMSAN is enabled, this function causes has a rather excessive stack usage: drivers/gpu/drm/i915/display/skl_watermark.c:2977:1: error: stack frame size (1432) exceeds limit (1408) in 'skl_compute_wm' [-Werror,-Wframe-larger-than] This is apparently all caused by the va

[PATCH] drm/i915: reduce stack usage in igt_vma_pin1()

2025-06-20 Thread Arnd Bergmann
From: Arnd Bergmann The igt_vma_pin1() function has a rather high stack usage, which gets in the way of reducing the default warning limit: In file included from drivers/gpu/drm/i915/i915_vma.c:2285: drivers/gpu/drm/i915/selftests/i915_vma.c:257:12: error: stack frame size (1288) exceeds limit

Re: [PATCH 3/3] fbdev/simplefb: Add support for interconnect paths

2025-06-20 Thread Thomas Zimmermann
Hi Am 20.06.25 um 13:07 schrieb Luca Weiss: Hi Thomas, On Fri Jun 20, 2025 at 1:02 PM CEST, Thomas Zimmermann wrote: Hi Am 20.06.25 um 12:31 schrieb Luca Weiss: Some devices might require keeping an interconnect path alive so that the framebuffer continues working. Add support for that by se

Re: [PATCH 1/3] dt-bindings: display: simple-framebuffer: Add interconnects property

2025-06-20 Thread Thomas Zimmermann
Hi Am 20.06.25 um 12:31 schrieb Luca Weiss: Document the interconnects property which is a list of interconnect paths that is used by the framebuffer and therefore needs to be kept alive when the framebuffer is being used. Signed-off-by: Luca Weiss Acked-by: Thomas Zimmermann Maybe also ge

[PATCH] i915: fix build error some more

2025-06-20 Thread Arnd Bergmann
From: Arnd Bergmann An earlier patch fixed a build failure with clang, but I still see the same problem with some configurations using gcc: drivers/gpu/drm/i915/i915_pmu.c: In function 'config_mask': include/linux/compiler_types.h:568:38: error: call to '__compiletime_assert_462' declared with

Re: [PATCH 3/3] fbdev/simplefb: Add support for interconnect paths

2025-06-20 Thread Luca Weiss
Hi Thomas, On Fri Jun 20, 2025 at 1:02 PM CEST, Thomas Zimmermann wrote: > Hi > > Am 20.06.25 um 12:31 schrieb Luca Weiss: >> Some devices might require keeping an interconnect path alive so that >> the framebuffer continues working. Add support for that by setting the >> bandwidth requirements ap

[PATCH v2 drm-dp 08/10] drm/hisilicon/hibmc: fix no showing when no connectors connected

2025-06-20 Thread Yongbang Shi
From: Baihan Li Our chip support KVM over IP feature, so hibmc driver need to support displaying without any connectors plugged in. Deleting the detect_ctx() of VGA to make it connected when no connector is detected. Fixes: 4c962bc929f1 ("drm/hisilicon/hibmc: Add vga connector detect functions")

RE: [PATCH 13/13] drm/i915/backlight: Use drm_edp_backlight_enable

2025-06-20 Thread Murthy, Arun R
> -Original Message- > From: Kandpal, Suraj > Sent: Monday, April 14, 2025 9:47 AM > To: nouv...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; intel- > x...@lists.freedesktop.org; intel-...@lists.freedesktop.org > Cc: Nautiyal, Ankit K ; Murthy, Arun R > ; Kandpal, Suraj > Subje

Patch "dummycon: Trigger redraw when switching consoles with deferred takeover" has been added to the 6.15-stable tree

2025-06-20 Thread gregkh
This is a note to let you know that I've just added the patch titled dummycon: Trigger redraw when switching consoles with deferred takeover to the 6.15-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of t

Patch "dummycon: Trigger redraw when switching consoles with deferred takeover" has been added to the 6.12-stable tree

2025-06-20 Thread gregkh
This is a note to let you know that I've just added the patch titled dummycon: Trigger redraw when switching consoles with deferred takeover to the 6.12-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of t

[PATCH 2/3] drm/sysfb: simpledrm: Add support for interconnect paths

2025-06-20 Thread Luca Weiss
Some devices might require keeping an interconnect path alive so that the framebuffer continues working. Add support for that by setting the bandwidth requirements appropriately for all provided interconnect paths. Signed-off-by: Luca Weiss --- drivers/gpu/drm/sysfb/simpledrm.c | 83

[PATCH 0/3] Add interconnent support for simpledrm/simplefb

2025-06-20 Thread Luca Weiss
Some devices might require keeping an interconnect path alive so that the framebuffer continues working. Add support for that by setting the bandwidth requirements appropriately for all provided interconnect paths. Signed-off-by: Luca Weiss --- Luca Weiss (3): dt-bindings: display: simple-f

[PATCH 3/3] fbdev/simplefb: Add support for interconnect paths

2025-06-20 Thread Luca Weiss
Some devices might require keeping an interconnect path alive so that the framebuffer continues working. Add support for that by setting the bandwidth requirements appropriately for all provided interconnect paths. Signed-off-by: Luca Weiss --- drivers/video/fbdev/simplefb.c | 83 +++

[PATCH 1/3] dt-bindings: display: simple-framebuffer: Add interconnects property

2025-06-20 Thread Luca Weiss
Document the interconnects property which is a list of interconnect paths that is used by the framebuffer and therefore needs to be kept alive when the framebuffer is being used. Signed-off-by: Luca Weiss --- Documentation/devicetree/bindings/display/simple-framebuffer.yaml | 3 +++ 1 file chang

Re: [PATCH] Revert "drm/amd/display: more liberal vmin/vmax update for freesync"

2025-06-20 Thread Uwe Kleine-König
Hello, On Thu, Jun 05, 2025 at 07:44:19AM +0200, Uwe Kleine-König wrote: > On Wed, Jun 04, 2025 at 11:09:15AM -0400, Alex Deucher wrote: > > On Wed, Jun 4, 2025 at 10:55 AM Uwe Kleine-König > > wrote: > > > > > > Hello Alex, > > > > > > On Wed, Jun 04, 2025 at 03:29:58PM +0200, Greg KH wrote: > >

[PATCH 1/3] drm/bridge: get/put the bridge reference in drm_bridge_add/remove()

2025-06-20 Thread Luca Ceresoli
drm_bridge_add() adds the bridge to the global bridge_list, so take a reference for that. Vice versa in drm_bridge_remove(). Reviewed-by: Maxime Ripard Signed-off-by: Luca Ceresoli --- Changes in v8: none Changes in v7: - in v6 this was part of "drm/bridge: add support for refcounted DRM bri

[PATCH v2 drm-dp 04/10] drm/hisilicon/hibmc: fix the hibmc loaded failed bug

2025-06-20 Thread Yongbang Shi
From: Baihan Li When hibmc loaded failed, the driver use hibmc_unload to free the resource, but the mutexes in mode.config are not init, which will access an NULL pointer. Just change goto statement to return, because hibnc_hw_init() doesn't need to free anything. Fixes: b3df5e65cc03 ("drm/hibmc

[PATCH v2 drm-dp 07/10] drm/hisilicon/hibmc: fix dp and vga cannot show together

2025-06-20 Thread Yongbang Shi
From: Baihan Li If VGA and DP connected together, there will be only one can get crtc. Add encoder possible_clones to support two connectors enable. Fixes: 0ab6ea261c1f ("drm/hisilicon/hibmc: add dp module in hibmc") Fixes: 3c7623fb5bb6 ("drm/hisilicon/hibmc: Enable this hot plug detect of irq

[PATCH v2 drm-dp 09/10] drm/hisilicon/hibmc: fix no showing problem with loading hibmc manually

2025-06-20 Thread Yongbang Shi
From: Baihan Li When using command rmmod and insmod, there is no showing in second time insmoding. Because DP controller won't send HPD signals, if connection doesn't change or controller isn't reset. So add reset before unreset in hibmc_dp_hw_init(). Fixes: 3c7623fb5bb6 ("drm/hisilicon/hibmc: E

[PATCH v2 drm-dp 00/10] Fix hibmc driver bugs

2025-06-20 Thread Yongbang Shi
From: Baihan Li There are some bugfix for hibmc-drm driver. --- ChangeLog: v1 -> v2: - use the hibmc_ddc_del() in hibmc_connector_destroy(), suggested by Dmitry Baryshkov. - fix the tag, suggested by Dmitry Baryshkov. - don't use the flag, and use more checks in detect_ctx(), suggested by

[PATCH v2 drm-dp 06/10] drm/hisilicon/hibmc: add dp mode valid check

2025-06-20 Thread Yongbang Shi
From: Baihan Li If DP is connected, add mode check and BW check in mode_valid_ctx() to ensure DP's cfg is usable. Fixes: f9698f802e50 ("drm/hisilicon/hibmc: Restructuring the header dp_reg.h") Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- ChangeLog: v1 -> v2: - delete if (!dp->is_

[PATCH v2 drm-dp 02/10] drm/hisilicon/hibmc: fix dp probabilistical detect errors after HPD irq

2025-06-20 Thread Yongbang Shi
From: Baihan Li The debouncing when HPD pulled out still remains sometimes, 200ms still can not ensure helper_detect() is correct. So add more checks and hibmc_dp_link_training0() in detect_ctx(). Fixes: 3c7623fb5bb6 ("drm/hisilicon/hibmc: Enable this hot plug detect of irq feature") Signed-off

[PATCH v2 drm-dp 03/10] drm/hisilicon/hibmc: fix irq_request()'s irq name variable is local

2025-06-20 Thread Yongbang Shi
From: Baihan Li The local variable is passed in request_irq (), and there will be use after free problem, which will make request_irq failed. Using the global irq name instead of it to fix. Fixes: b11bc1ae4658 ("drm/hisilicon/hibmc: Add MSI irq getting and requesting for HPD") Signed-off-by: Ba

[PATCH v2 drm-dp 05/10] drm/hisilicon/hibmc: fix rare monitors cannot display problem

2025-06-20 Thread Yongbang Shi
From: Baihan Li In some case, the dp link training success at 8.1Gbps, but the sink's maximum supported rate is less than 8.1G. So change the default 8.1Gbps link rate to the rate that reads from devices' capabilities. Fixes: 54063d86e036 ("drm/hisilicon/hibmc: add dp link moduel in hibmc drive

[PATCH 3/3] drm/bridge: add warning for bridges not using devm_drm_bridge_alloc()

2025-06-20 Thread Luca Ceresoli
To the best of my knowledge, all drivers in the mainline kernel adding a DRM bridge are now converted to using devm_drm_bridge_alloc() for allocation and initialization. Among others this ensures initialization of the bridge refcount, allowing dynamic allocation lifetime. devm_drm_bridge_alloc() i

  1   2   >