Re: [PATCH v3 2/4] drm/msm/dp: Account for LTTPRs capabilities

2025-04-24 Thread Abel Vesa
On 25-04-17 04:10:33, Aleksandrs Vinarskis wrote: > Take into account LTTPR capabilities when selecting maximum allowed > link rate, number of data lines. > > Signed-off-by: Aleksandrs Vinarskis Reviewed-by: Abel Vesa

Re: [PATCH v3 3/4] drm/msm/dp: Prepare for link training per-segment for LTTPRs

2025-04-24 Thread Abel Vesa
On 25-04-17 04:10:34, Aleksandrs Vinarskis wrote: > Per-segment link training requires knowing the number of LTTPRs > (if any) present. Store the count during LTTPRs' initialization. > > Signed-off-by: Aleksandrs Vinarskis Reviewed-by: Abel Vesa

[PATCH drm-next v2] drm/hyperv: Replace simple-KMS with regular atomic helpers

2025-04-24 Thread Ryosuke Yasuoka
Drop simple-KMS in favor of regular atomic helpers to make the code more modular. The simple-KMS helper mix up plane and CRTC state, so it is obsolete and should go away [1]. Since it just split the simple-pipe functions into per-plane and per-CRTC, no functional changes is expected. [1] https://l

[PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

2025-04-24 Thread Junxiao Chang
MEI GSC interrupt comes from i915. It has top half and bottom half. Top half is called from i915 interrupt handler. It should be in irq disabled context. With RT kernel, by default i915 IRQ handler is in threaded IRQ. MEI GSC top half might be in threaded IRQ context. generic_handle_irq_safe API c

Re: [RFC PATCH] drm/bridge: ti-sn65dsi86: Enable HPD functionality

2025-04-24 Thread Krzysztof Kozlowski
On 24/04/2025 12:54, Jayesh Choudhary wrote: > For TI SoC J784S4, the display pipeline looks like: > TIDSS -> CDNS-DSI -> SN65DSI86 -> DisplayConnector -> DisplaySink > This requires HPD to detect connection form the connector. > By default, the HPD is disabled for eDP. So enable it conditionally >

Re: [PATCH v9 10/10] drm/amdgpu: update trace format to match gpu_scheduler_trace

2025-04-24 Thread Yadav, Arvind
Reviewed-by: Arvind Yadav On 4/24/2025 2:08 PM, Pierre-Eric Pelloux-Prayer wrote: Log fences using the same format for coherency. Signed-off-by: Pierre-Eric Pelloux-Prayer Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 22 ++ 1 file change

Re: [PATCH v9 08/10] drm: get rid of drm_sched_job::id

2025-04-24 Thread Yadav, Arvind
Reviewed-by: Arvind Yadav On 4/24/2025 2:08 PM, Pierre-Eric Pelloux-Prayer wrote: Its only purpose was for trace events, but jobs can already be uniquely identified using their fence. The downside of using the fence is that it's only available after 'drm_sched_job_arm' was called which is true

Re: [PATCH 2/2] udmabuf: fix vmap missed offset page

2025-04-24 Thread Bingbu Cao
On 4/22/25 1:22 PM, Kasireddy, Vivek wrote: > Hi Huan, > >> Subject: [PATCH 2/2] udmabuf: fix vmap missed offset page >> >> Before invoke vmap, we need offer a pages pointer array which each page >> need to map in vmalloc area. >> >> But currently vmap_udmabuf only set each folio's head page int

Re: [13/16] gpu: nova-core: Add support for VBIOS ucode extraction for boot

2025-04-24 Thread Joel Fernandes
Hello, Danilo, On April 24, 2025, 8:17 p.m. UTC Danilo Krummrich wrote: > On Thu, Apr 24, 2025 at 03:54:48PM -0400, Joel Fernandes wrote: > > On Wed, Apr 23, 2025 at 05:02:58PM +0200, Danilo Krummrich wrote: > > > On Wed, Apr 23, 2025 at 10:52:42AM -0400, Joel Fernandes wrote: > > > > Hello, Dani

Re: [13/16] gpu: nova-core: Add support for VBIOS ucode extraction for boot

2025-04-24 Thread Joel Fernandes
Hello, Danilo, On April 24, 2025, 8:08 p.m. UTC Danilo Krummrich wrote: > On Thu, Apr 24, 2025 at 02:54:42PM -0400, Joel Fernandes wrote: > > > > > > On 4/23/2025 10:06 AM, Danilo Krummrich wrote: > > [...] > > >> + > > >> +/// Probe for VBIOS extraction > > >> +/// Once the VBIOS obje

Re: [PATCH v7] drm/msm/dp: reuse generic HDMI codec implementation

2025-04-24 Thread Abhinav Kumar
On 4/23/2025 10:52 AM, Dmitry Baryshkov wrote: From: Dmitry Baryshkov The MSM DisplayPort driver implements several HDMI codec functions in the driver, e.g. it manually manages HDMI codec device registration, returning ELD and plugged_cb support. In order to reduce code duplication reuse drm

[PATCH v3 05/20] drm/amd/pm: Avoid open-coded use of ratelimit_state structure's internals

2025-04-24 Thread Paul E. McKenney
The amdgpu_set_thermal_throttling_logging() function directly accesses the ratelimit_state structure's ->missed field, which work, but which also makes it more difficult to change this field. Therefore, make use of the ratelimit_state_reset_miss() function instead of directly accessing the ->misse

[PATCH v3 04/20] drm/i915: Avoid open-coded use of ratelimit_state structure's ->missed field

2025-04-24 Thread Paul E. McKenney
The i915_oa_stream_destroy() function directly accesses the ratelimit_state structure's ->missed field, which work, but which also makes it more difficult to change this field. Therefore, make use of the ratelimit_state_get_miss() function instead of directly accessing the ->missed field. Link:

Re: [PATCH v2 2/2] dma-buf: heaps: Give default CMA heap a fixed name

2025-04-24 Thread John Stultz
On Thu, Apr 24, 2025 at 1:34 AM Maxime Ripard wrote: > On Tue, Apr 22, 2025 at 12:19:39PM -0700, Jared Kangas wrote: > > @@ -22,6 +22,7 @@ > > #include > > #include > > > > +#define DEFAULT_CMA_NAME "default_cma" > > I appreciate this is kind of bikeshed-color territory, but I think "cma" > wo

Re: [PATCH v3 7/7] drm/xe/pt: unify xe_pt_svm_pre_commit with userptr

2025-04-24 Thread Matthew Brost
On Thu, Apr 24, 2025 at 01:18:35PM +0100, Matthew Auld wrote: > We now use the same notifier lock for SVM and userptr, with that we can > combine xe_pt_userptr_pre_commit and xe_pt_svm_pre_commit. > > v2: (Matt B) > - Re-use xe_svm_notifier_lock/unlock for userptr. > - Combine svm/userptr hand

Re: [PATCH v3 6/7] drm/xe/userptr: replace xe_hmm with gpusvm

2025-04-24 Thread Matthew Brost
On Thu, Apr 24, 2025 at 01:18:34PM +0100, Matthew Auld wrote: > Goal here is cut over to gpusvm and remove xe_hmm, relying instead on > common code. The core facilities we need are get_pages(), unmap_pages() > and free_pages() for a given useptr range, plus a vm level notifier > lock, which is now

Re: [PATCH] fbdev/nvidiafb: Correct const string length in nvidiafb_setup()

2025-04-24 Thread Helge Deller
On 4/7/25 13:55, Zijun Hu wrote: From: Zijun Hu The actual length of const string "noaccel" is 7, but the strncmp() branch in nvidiafb_setup() wrongly hard codes it as 6. Fix by using actual length 7 as argument of the strncmp(). Signed-off-by: Zijun Hu --- drivers/video/fbdev/nvidia/nvidi

Re: [PATCH][next] fbdev/carminefb: Fix spelling mistake of CARMINE_TOTAL_DIPLAY_MEM

2025-04-24 Thread Helge Deller
On 4/18/25 14:51, Colin Ian King wrote: There is a spelling mistake in macro CARMINE_TOTAL_DIPLAY_MEM. Fix it. Signed-off-by: Colin Ian King --- drivers/video/fbdev/carminefb.c | 8 drivers/video/fbdev/carminefb.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) applied.

Re: [PATCH v1 1/1] atyfb: Remove unused PCI vendor ID

2025-04-24 Thread Helge Deller
On 4/24/25 13:56, Andy Shevchenko wrote: The custom definition of PCI vendor ID in video/mach64.h is unused. Remove it. Note, that the proper one is available in pci_ids.h. Signed-off-by: Andy Shevchenko --- include/video/mach64.h | 3 --- 1 file changed, 3 deletions(-) applied. Thanks! H

Re: drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-24 Thread Dmitry Baryshkov
On Thu, Apr 24, 2025 at 02:12:15PM -0700, Rob Clark wrote: > On Wed, Apr 16, 2025 at 7:13 PM Aleksandrs Vinarskis > wrote: > > > > Recently added Initial LTTPR support in msm/dp has configured LTTPR(s) > > to non-transparent mode to enable video output on X1E-based devices > > that come with LTTPR

Re: [PATCH v3 5/7] drm/gpusvm: export drm_gpusvm_pages API

2025-04-24 Thread Matthew Brost
On Thu, Apr 24, 2025 at 03:01:21PM -0700, Matthew Brost wrote: > On Thu, Apr 24, 2025 at 01:18:33PM +0100, Matthew Auld wrote: > > Export get/unmap/free pages API. We also need to tweak the SVM init to > > allow skipping much of the unneeded parts. > > > > Signed-off-by: Matthew Auld > > Cc: Thom

Re: [PATCH v3 5/7] drm/gpusvm: export drm_gpusvm_pages API

2025-04-24 Thread Matthew Brost
On Thu, Apr 24, 2025 at 01:18:33PM +0100, Matthew Auld wrote: > Export get/unmap/free pages API. We also need to tweak the SVM init to > allow skipping much of the unneeded parts. > > Signed-off-by: Matthew Auld > Cc: Thomas Hellström > Cc: Matthew Brost > --- > drivers/gpu/drm/drm_gpusvm.c |

Re: [PATCH v3 1/4] drm/msm/dp: Fix support of LTTPR initialization

2025-04-24 Thread Dmitry Baryshkov
On Thu, Apr 17, 2025 at 04:10:32AM +0200, Aleksandrs Vinarskis wrote: > Initialize LTTPR before msm_dp_panel_read_sink_caps, as DPTX shall > (re)read DPRX caps after LTTPR detection, as required by DP 2.1, > Section 3.6.7.6.1. > > Signed-off-by: Aleksandrs Vinarskis > --- > drivers/gpu/drm/msm/d

Re: [PATCH v3 4/7] drm/gpusvm: refactor core API to use pages struct

2025-04-24 Thread Matthew Brost
On Thu, Apr 24, 2025 at 01:18:32PM +0100, Matthew Auld wrote: > Refactor the core API of get/unmap/free pages to all operate on > drm_gpusvm_pages. In the next patch we want to export a simplified core > API without needing fully blown svm range etc. > > Suggested-by: Matthew Brost > Signed-off-b

Re: drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-24 Thread Rob Clark
On Wed, Apr 16, 2025 at 7:13 PM Aleksandrs Vinarskis wrote: > > Recently added Initial LTTPR support in msm/dp has configured LTTPR(s) > to non-transparent mode to enable video output on X1E-based devices > that come with LTTPR on the motherboards. However, video would not work > if additional LTT

Re: [PATCH v3 6/7] drm/msm/mdp4: switch LVDS to use drm_bridge/_connector

2025-04-24 Thread Abhinav Kumar
On 4/24/2025 3:23 AM, Dmitry Baryshkov wrote: On Wed, Apr 23, 2025 at 07:04:16PM -0700, Abhinav Kumar wrote: On 2/26/2025 6:25 PM, Dmitry Baryshkov wrote: LVDS support in MDP4 driver makes use of drm_connector directly. However LCDC encoder and LVDS connector are wrappers around drm_panel.

[PATCH v23 5/5] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-04-24 Thread Jonathan Cavitt
Add support for userspace to request a list of observed faults from a specified VM. v2: - Only allow querying of failed pagefaults (Matt Brost) v3: - Remove unnecessary size parameter from helper function, as it is a property of the arguments. (jcavitt) - Remove unnecessary copy_from_user (Jain

[PATCH v23 0/5] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-04-24 Thread Jonathan Cavitt
Add additional information to each VM so they can report up to the first 50 seen faults. Only pagefaults are saved this way currently, though in the future, all faults should be tracked by the VM for future reporting. Additionally, of the pagefaults reported, only failed pagefaults are saved this

[PATCH v23 3/5] drm/xe/uapi: Define drm_xe_vm_get_property

2025-04-24 Thread Jonathan Cavitt
Add initial declarations for the drm_xe_vm_get_property ioctl. v2: - Expand kernel docs for drm_xe_vm_get_property (Jianxun) v3: - Remove address type external definitions (Jianxun) - Add fault type to xe_drm_fault struct (Jianxun) v4: - Remove engine class and instance (Ivan) v5: - Add declare

[PATCH v23 4/5] drm/xe/xe_vm: Add per VM fault info

2025-04-24 Thread Jonathan Cavitt
Add additional information to each VM so they can report up to the first 50 seen faults. Only pagefaults are saved this way currently, though in the future, all faults should be tracked by the VM for future reporting. Additionally, of the pagefaults reported, only failed pagefaults are saved this

[PATCH v23 1/5] drm/xe/xe_gt_pagefault: Disallow writes to read-only VMAs

2025-04-24 Thread Jonathan Cavitt
The page fault handler should reject write/atomic access to read only VMAs. Add code to handle this in handle_pagefault after the VMA lookup. Fixes: 3d420e9fa848 ("drm/xe: Rework GPU page fault handling") Signed-off-by: Jonathan Cavitt Suggested-by: Matthew Brost Reviewed-by: Shuicheng Lin Rev

[PATCH v23 2/5] drm/xe/xe_gt_pagefault: Move pagefault struct to header

2025-04-24 Thread Jonathan Cavitt
Move the pagefault struct from xe_gt_pagefault.c to the xe_gt_pagefault_types.h header file, and move the associated enum values into the regs folder under xe_pagefault_desc.h Since xe_pagefault_desc.h is being initialized here, also move the xe_guc_pagefault_desc hardware formats to the new file.

Re: [PATCH 13/16] gpu: nova-core: Add support for VBIOS ucode extraction for boot

2025-04-24 Thread Joel Fernandes
On 4/23/2025 10:06 AM, Danilo Krummrich wrote: > On Sun, Apr 20, 2025 at 09:19:45PM +0900, Alexandre Courbot wrote: >> From: Joel Fernandes >> >> Add support for navigating and setting up vBIOS ucode data required for >> GSP to boot. The main data extracted from the vBIOS is the FWSEC-FRTS >> f

Re: [PATCH v2 3/4] drm/msm/a6xx: Get HBB dynamically, if available

2025-04-24 Thread Konrad Dybcio
On 4/23/25 5:23 PM, Dmitry Baryshkov wrote: > On 23/04/2025 17:55, Rob Clark wrote: >> On Tue, Apr 22, 2025 at 4:57 PM Konrad Dybcio >> wrote: >>> >>> On 4/21/25 10:13 PM, Rob Clark wrote: On Fri, Apr 18, 2025 at 9:00 AM Akhil P Oommen wrote: > > On 4/18/2025 6:40 AM, Connor Ab

Re: [PATCH 13/16] gpu: nova-core: Add support for VBIOS ucode extraction for boot

2025-04-24 Thread Danilo Krummrich
On Thu, Apr 24, 2025 at 03:54:48PM -0400, Joel Fernandes wrote: > On Wed, Apr 23, 2025 at 05:02:58PM +0200, Danilo Krummrich wrote: > > On Wed, Apr 23, 2025 at 10:52:42AM -0400, Joel Fernandes wrote: > > > Hello, Danilo, > > > Thanks for all the feedback. Due to the volume of feedback, I will respo

[PATCH v2 34/34] drm/bridge: panel: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. The devm lifetime management of this driver is peculiar. The underlying device for the panel_bridge is the panel, and the devm lifetime is tied the panel device (panel->dev). However the panel_bridge allocation is not performed by the panel driver, b

Re: [PATCH 13/16] gpu: nova-core: Add support for VBIOS ucode extraction for boot

2025-04-24 Thread Danilo Krummrich
On Thu, Apr 24, 2025 at 02:54:42PM -0400, Joel Fernandes wrote: > > > On 4/23/2025 10:06 AM, Danilo Krummrich wrote: > [...] > >> + > >> +/// Probe for VBIOS extraction > >> +/// Once the VBIOS object is built, bar0 is not read for vbios > >> purposes anymore. > >> +pub(crate) fn pro

Re: [PATCH 13/16] gpu: nova-core: Add support for VBIOS ucode extraction for boot

2025-04-24 Thread Danilo Krummrich
On Thu, Apr 24, 2025 at 03:19:00PM -0400, Joel Fernandes wrote: > On Wed, Apr 23, 2025 at 05:02:58PM +0200, Danilo Krummrich wrote: > > [..] > > > > >> +data.extend_with(len, 0, GFP_KERNEL)?; > > > >> +with_bar!(?bar0, |bar0_ref| { > > > >> +let dst = &mut data[current

Re: [PATCH 13/16] gpu: nova-core: Add support for VBIOS ucode extraction for boot

2025-04-24 Thread Joel Fernandes
On Wed, Apr 23, 2025 at 05:02:58PM +0200, Danilo Krummrich wrote: > On Wed, Apr 23, 2025 at 10:52:42AM -0400, Joel Fernandes wrote: > > Hello, Danilo, > > Thanks for all the feedback. Due to the volume of feedback, I will respond > > incrementally in multiple emails so we can discuss as we go - hop

Re: [PATCH] drm/panthor: Fix build warning when DEBUG_FS is disabled

2025-04-24 Thread Liviu Dudau
On Thu, Apr 24, 2025 at 07:40:34PM +0100, Adrián Larumbe wrote: > Commit a3707f53eb3f ("drm/panthor: show device-wide list of DRM GEM > objects over DebugFS") causes a build warning and linking error when > built without support for DebugFS, because of a non-inline non-static > function declaration

Re: [PATCH v3 3/7] drm/msm/mdp4: register the LVDS PLL as a clock provider

2025-04-24 Thread Abhinav Kumar
On 4/24/2025 3:22 AM, Dmitry Baryshkov wrote: On Wed, Apr 23, 2025 at 03:54:13PM -0700, Abhinav Kumar wrote: On 2/26/2025 6:25 PM, Dmitry Baryshkov wrote: The LVDS/LCDC controller uses pixel clock coming from the multimedia controller (mmcc) rather than using the PLL directly. Stop using L

Re: [PATCH v22 0/5] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-04-24 Thread Matthew Brost
On Thu, Apr 24, 2025 at 02:38:05PM +, Jonathan Cavitt wrote: > Add additional information to each VM so they can report up to the first > 50 seen faults. Only pagefaults are saved this way currently, though in > the future, all faults should be tracked by the VM for future reporting. > > Addi

Re: [PATCH v22 1/5] drm/xe/xe_gt_pagefault: Disallow writes to read-only VMAs

2025-04-24 Thread Matthew Brost
On Thu, Apr 24, 2025 at 02:38:06PM +, Jonathan Cavitt wrote: > The page fault handler should reject write/atomic access to read only > VMAs. Add code to handle this in handle_pagefault after the VMA lookup. > > Fixes: 3d420e9fa848 ("drm/xe: Rework GPU page fault handling") > Signed-off-by: Jo

Re: [PATCH v22 5/5] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-04-24 Thread Matthew Brost
On Thu, Apr 24, 2025 at 02:38:10PM +, Jonathan Cavitt wrote: > Add support for userspace to request a list of observed faults > from a specified VM. > > v2: > - Only allow querying of failed pagefaults (Matt Brost) > > v3: > - Remove unnecessary size parameter from helper function, as it >

Re: [PATCH 13/16] gpu: nova-core: Add support for VBIOS ucode extraction for boot

2025-04-24 Thread Joel Fernandes
On Wed, Apr 23, 2025 at 05:02:58PM +0200, Danilo Krummrich wrote: [..] > > >> +data.extend_with(len, 0, GFP_KERNEL)?; > > >> +with_bar!(?bar0, |bar0_ref| { > > >> +let dst = &mut data[current_len..current_len + len]; > > >> +for (idx, chunk) in dst > > >> +

Re: [PATCH v2 11/34] drm/bridge: dw-hdmi: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Cristian Ciocaltea
On 4/24/25 9:59 PM, Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli > > --- > > Cc: Cristian Ciocaltea > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) Reviewed-by: Cristia

Re: [PATCH] Revert "drm/amd/display: Hardware cursor changes color when switched to software cursor"

2025-04-24 Thread Harry Wentland
On 2025-04-22 10:58, Melissa Wen wrote: > This reverts commit 272e6aab14bbf98d7a06b2b1cd6308a02d4a10a1. > > Applying degamma curve to the cursor by default breaks Linux userspace > expectation. > > On Linux, AMD display manager enables cursor degamma ROM just for > implict sRGB on HW versions

[PATCH v2 21/34] drm/omap: dss: hdmi4: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Switching from a non-devm to a devm allocation allows removing the kfree() in the remove function and in the probe error management code, and as a consequence to simplify the code flow by removing now unnecessary gotos. Signed-off-by: Luca Ceresoli

[PATCH v2 32/34] drm/bridge: tc358767: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Converting this driver is a bit convoluted because the drm_bridge funcs pointer differs based on the bridge mode. So the current code does: * tc_probe() * devm_kzalloc() private struct embedding drm_bridge * call tc_probe_bridge_endpoint() wh

[PATCH v2 33/34] drm/bridge: add devm_drm_put_bridge()

2025-04-24 Thread Luca Ceresoli
Bridges obtained via devm_drm_bridge_alloc(dev, ...) will be put when the requesting device (@dev) is removed. However drivers which obtained them may need to put the obtained reference explicitly. One such case is if they bind the devm removal action to a different device than the one implemented

[PATCH v2 31/34] drm/bridge: imx8*-ldb: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. These two drivers are tangled together by the ldb_add_bridge_helper(), so they are converted at once. They also have a similar design, each embedding an array of channels in their main struct, and each channel embeds a drm_bridge. This prevents dyna

[PATCH v2 29/34] drm: zynqmp_dp: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. This driver has a peculiar structure. zynqmp_dpsub.c is the actual driver, which delegates to a submodule (zynqmp_dp.c) the allocation of a sub-structure embedding the drm_bridge and its initialization, however it does not delegate the drm_bridge_add

[PATCH v2 27/34] drm/vc4: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. This driver already implements refcounting of the struct vc4_dsi, which embeds struct drm_bridge. Now this is a duplicate of the refcounting implemented by the DRM bridge core, so convert the vc4_dsi_get/put() calls into drm_bridge_get/put() calls an

[PATCH v2 26/34] drm/bridge: stm_lvds: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Signed-off-by: Luca Ceresoli --- Cc: Alexandre Torgue Cc: Maxime Coquelin Cc: Philippe Cornu Cc: Raphael Gallais-Pou Cc: Yannick Fertre --- drivers/gpu/drm/stm/lvds.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a

[PATCH v2 30/34] drm/bridge: imx8qxp-pixel-combiner: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. This driver embeds an array of channels in the main struct, and each channel embeds a drm_bridge. This prevents dynamic, refcount-based deallocation of the bridges. To make the new, dynamic bridge allocation possible: * change the array of channel

[PATCH v2 28/34] drm/sti: dvo: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. This driver allocates the DRM bridge separately from the main driver private struct, which prevents using the new devm_drm_bridge_alloc() API. Simplify the code by replacing the struct drm_bridge pointer with an embedded struct drm_bridge inside the

[PATCH v2 25/34] drm/rcar-du: dsi: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Signed-off-by: Luca Ceresoli --- Cc: Kieran Bingham Cc: Laurent Pinchart Cc: Tomi Valkeinen --- drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/renesas

[PATCH v2 24/34] drm/omap: dss: venc: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Switching from a non-devm to a devm allocation allows removing the kfree() in the remove function and in the probe error management code, and as a consequence to simplify the code flow by removing now unnecessary gotos. Signed-off-by: Luca Ceresoli

[PATCH v2 22/34] drm/omap: dss: hdmi5: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Switching from a non-devm to a devm allocation allows removing the kfree() in the remove function and in the probe error management code, and as a consequence to simplify the code flow by removing now unnecessary gotos. Signed-off-by: Luca Ceresoli

[PATCH v2 17/34] drm/msm/dsi: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Reviewed-by: Dmitry Baryshkov Signed-off-by: Luca Ceresoli --- Cc: Abhinav Kumar Cc: Marijn Suijten Cc: Rob Clark Cc: Sean Paul --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --g

[PATCH v2 23/34] drm/omap: dss: sdi: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Switching from a non-devm to a devm allocation allows removing the kfree() in the remove function and in the probe error management code, and as a consequence to simplify the code flow by removing now unnecessary gotos. Signed-off-by: Luca Ceresoli

[PATCH v2 18/34] drm/msm/hdmi: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Reviewed-by: Dmitry Baryshkov Signed-off-by: Luca Ceresoli --- Cc: Abhinav Kumar Cc: Marijn Suijten Cc: Rob Clark Cc: Sean Paul --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --

[PATCH v2 20/34] drm/omap: dss: dsi: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Signed-off-by: Luca Ceresoli --- Cc: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dsi.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c index 91

[PATCH v2 19/34] drm/omap: dss: dpi: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Signed-off-by: Luca Ceresoli --- Cc: "Rob Herring (Arm)" Cc: Helge Deller Cc: Kuninori Morimoto Cc: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dpi.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/dr

[PATCH v2 15/34] drm/mcde: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Signed-off-by: Luca Ceresoli --- Cc: Linus Walleij --- drivers/gpu/drm/mcde/mcde_dsi.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/mcde/mcde_dsi.c index b302d8ec3a

[PATCH v2 06/34] drm/bridge: display-connector: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Reviewed-by: Dmitry Baryshkov Signed-off-by: Luca Ceresoli --- drivers/gpu/drm/bridge/display-connector.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/display-connector.c b/drivers/gpu/drm/bri

[PATCH v2 16/34] drm/msm/dp: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Reviewed-by: Dmitry Baryshkov Signed-off-by: Luca Ceresoli --- Cc: Abhinav Kumar Cc: Bjorn Andersson Cc: Marijn Suijten Cc: Rob Clark Cc: Sean Paul --- drivers/gpu/drm/msm/dp/dp_drm.c | 9 + 1 file changed, 5 insertions(+), 4 deletio

[PATCH v2 13/34] drm/bridge: ti-sn65dsi86: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Reviewed-by: Herve Codina Signed-off-by: Luca Ceresoli --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi8

[PATCH v2 10/34] drm/bridge: sii902x: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Signed-off-by: Luca Ceresoli --- drivers/gpu/drm/bridge/sii902x.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c index 6de61d9fe06487856e8b3c32db3c8d8c

[PATCH v2 14/34] drm/exynos: mic: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Signed-off-by: Luca Ceresoli --- Cc: Alim Akhtar Cc: Inki Dae Cc: Kyungmin Park Cc: Seung-Woo Kim --- drivers/gpu/drm/exynos/exynos_drm_mic.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/ex

[PATCH v2 11/34] drm/bridge: dw-hdmi: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Signed-off-by: Luca Ceresoli --- Cc: Cristian Ciocaltea --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/

[PATCH v2 07/34] drm/bridge: lt9611uxc: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Reviewed-by: Dmitry Baryshkov Signed-off-by: Luca Ceresoli --- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/brid

[PATCH v2 12/34] drm/bridge: tda998x: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Reviewed-by: Dmitry Baryshkov Signed-off-by: Luca Ceresoli --- Cc: Russell King --- drivers/gpu/drm/bridge/tda998x_drv.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/tda998x_drv.c b/drivers/g

[PATCH v2 09/34] drm/bridge: nxp-ptn3460: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Signed-off-by: Luca Ceresoli --- drivers/gpu/drm/bridge/nxp-ptn3460.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c b/drivers/gpu/drm/bridge/nxp-ptn3460.c index 25d7c415478b14ef6

[PATCH v2 08/34] drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Signed-off-by: Luca Ceresoli --- Cc: Ian Ray Cc: Martyn Welch Cc: Peter Senna Tschudin --- drivers/gpu/drm/bridge/megachips-stdp-ge-b850v3-fw.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v2 05/34] drm/bridge: cdns-dsi: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Signed-off-by: Luca Ceresoli --- Cc: Aradhya Bhatia Cc: Tomi Valkeinen --- drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c

[PATCH v2 04/34] drm/bridge: anx7625: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Signed-off-by: Luca Ceresoli --- Cc: "Rob Herring (Arm)" Cc: Hsin-Te Yuan Cc: Jani Nikula Cc: Pin-yen Lin Cc: Sui Jingfeng Cc: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-)

[PATCH v2 03/34] drm/bridge: analogix-anx6345: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Signed-off-by: Luca Ceresoli --- Cc: "Uwe Kleine-König" Cc: Andy Yan Cc: Dmitry Baryshkov Cc: Jani Nikula Cc: Sui Jingfeng --- drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[PATCH v2 01/34] drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
devm_drm_bridge_alloc() is the new API to be used for allocating (and partially initializing) a private driver struct embedding a struct drm_bridge. For many drivers having a simple code flow in the probe function, this commit does a mass conversion automatically with the following semantic patch.

[PATCH v2 02/34] platform: arm64: acer-aspire1-ec: convert to devm_drm_bridge_alloc() API

2025-04-24 Thread Luca Ceresoli
This is the new API for allocating DRM bridges. Acked-by: Ilpo Järvinen Signed-off-by: Luca Ceresoli --- Cc: "Bryan O'Donoghue" Cc: "Ilpo Järvinen" Cc: Hans de Goede --- drivers/platform/arm64/acer-aspire1-ec.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drive

Re: [PATCH 13/16] gpu: nova-core: Add support for VBIOS ucode extraction for boot

2025-04-24 Thread Joel Fernandes
On 4/23/2025 10:06 AM, Danilo Krummrich wrote: [...] >> + >> +/// Probe for VBIOS extraction >> +/// Once the VBIOS object is built, bar0 is not read for vbios purposes >> anymore. >> +pub(crate) fn probe(bar0: &Devres) -> Result { > > Let's not call it probe(), what about VBios::p

Re: [PATCH v4 03/16] drm/msm/hdmi: convert clock and regulator arrays to const arrays

2025-04-24 Thread Jessica Zhang
On 2/8/2025 9:04 PM, Dmitry Baryshkov wrote: As a preparation to the next patches convert 'static const char *' arrays to 'static const char * const', as required by the checkpatch.pl Signed-off-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang --- drivers/gpu/drm/msm/hdmi/hdmi.c | 10 +

Re: [PATCH] drm/panthor: fix building without CONFIG_DEBUG_FS

2025-04-24 Thread Adrián Larumbe
Hi Arnd, Thanks for the fix. I've already submitted a second attempt because I thought the build being broken is something we ought to deal with ASAP. I've added you as a bug reporter and also made mention of this thread in the new patch. Kind Regards, Adrian On 24.04.2025 13:25, Arnd Bergmann

[PATCH] drm/panthor: Fix build warning when DEBUG_FS is disabled

2025-04-24 Thread Adrián Larumbe
Commit a3707f53eb3f ("drm/panthor: show device-wide list of DRM GEM objects over DebugFS") causes a build warning and linking error when built without support for DebugFS, because of a non-inline non-static function declaration in a header file. On top of that, the function is only being used insi

Re: [PATCH v4 2/5] drm/xe: Strict migration policy for atomic SVM faults

2025-04-24 Thread Matthew Brost
On Thu, Apr 24, 2025 at 04:39:21PM +0200, Thomas Hellström wrote: > On Tue, 2025-04-22 at 10:04 -0700, Matthew Brost wrote: > > Mixing GPU and CPU atomics does not work unless a strict migration > > policy of GPU atomics must be device memory. Enforce a policy of must > > be > > in VRAM with a retr

[PATCH v22 4/5] drm/xe/xe_vm: Add per VM fault info

2025-04-24 Thread Jonathan Cavitt
Add additional information to each VM so they can report up to the first 50 seen faults. Only pagefaults are saved this way currently, though in the future, all faults should be tracked by the VM for future reporting. Additionally, of the pagefaults reported, only failed pagefaults are saved this

[PATCH v22 3/5] drm/xe/uapi: Define drm_xe_vm_get_property

2025-04-24 Thread Jonathan Cavitt
Add initial declarations for the drm_xe_vm_get_property ioctl. v2: - Expand kernel docs for drm_xe_vm_get_property (Jianxun) v3: - Remove address type external definitions (Jianxun) - Add fault type to xe_drm_fault struct (Jianxun) v4: - Remove engine class and instance (Ivan) v5: - Add declare

[PATCH v3 3/7] drm/gpusvm: pull out drm_gpusvm_pages substructure

2025-04-24 Thread Matthew Auld
Pull the pages stuff from the svm range into its own substructure, with the idea of having the main pages related routines, like get_pages(), unmap_pages() and free_pages() all operating on some lower level structures, which can then be re-used for stuff like userptr. v2: - Move seq into pages s

[PATCH v3 7/7] drm/xe/pt: unify xe_pt_svm_pre_commit with userptr

2025-04-24 Thread Matthew Auld
We now use the same notifier lock for SVM and userptr, with that we can combine xe_pt_userptr_pre_commit and xe_pt_svm_pre_commit. v2: (Matt B) - Re-use xe_svm_notifier_lock/unlock for userptr. - Combine svm/userptr handling further down into op_check_svm_userptr. Suggested-by: Matthew Brost

Re: [PATCH v2 1/4] PM: device: Introduce platform_resources_managed flag

2025-04-24 Thread Ulf Hansson
+ Stephen On Thu, 17 Apr 2025 at 18:19, Michal Wilczynski wrote: > > > > On 4/16/25 16:48, Rafael J. Wysocki wrote: > > On Wed, Apr 16, 2025 at 3:32 PM Michal Wilczynski > > wrote: > >> > >> On 4/15/25 18:42, Rafael J. Wysocki wrote: > >>> On Mon, Apr 14, 2025 at 8:53 PM Michal Wilczynski > >>>

Re: [PATCH] drm: drm_fourcc: add 10/12bit software decoder YCbCr formats

2025-04-24 Thread Tomi Valkeinen
Hi, On 24/04/2025 16:31, Laurent Pinchart wrote: On Thu, Apr 24, 2025 at 02:53:18PM +0200, Robert Mader wrote: Chris, Javier, Laurent - sorry for the noise, but given you reviewed changes in the respective files before, maybe you can help me moving this forward? I'd be very happy for any feedba

[PATCH v7 0/2] Rework/Correction on minimum hblank calculation

2025-04-24 Thread Arun R Murthy
Signed-off-by: Arun R Murthy --- Changes in v7: - EDITME: describe what is new in this series revision. - EDITME: use bulletpoints and terse descriptions. - Link to v6: https://lore.kernel.org/r/20250424-hblank-v6-0-3d10442d9...@intel.com Changes in v6: - EDITME: describe what is new in this

[PATCH RFC v2 1/5] dt-bindings: display: panel: Fix port binding

2025-04-24 Thread Kory Maincent
Faced a binding error check while adding the data-lanes property in the ilitek,ili9881c binding. See the next patch for the binding changes. Here is the error: Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.example.dtb: panel@0: port:endpoint: Unevaluated properties are not allowed

Re: [PATCH v2 2/2] dma-buf: heaps: Give default CMA heap a fixed name

2025-04-24 Thread Jared Kangas
Hi Maxime, On Thu, Apr 24, 2025 at 10:33:58AM +0200, Maxime Ripard wrote: > Hi Jared, > > Thanks for working on this > > On Tue, Apr 22, 2025 at 12:19:39PM -0700, Jared Kangas wrote: > > The CMA heap's name in devtmpfs can vary depending on how the heap is > > defined. Its name defaults to "rese

Re: [PATCH v4 0/4] Don't create Python bytecode when building the kernel

2025-04-24 Thread Jonathan Corbet
Mauro Carvalho Chehab writes: > As reported by Andy, the Kernel build system runs kernel-doc script for DRM, > when W=1. Due to Python's normal behavior, its JIT compiler will create > a bytecode and store it under scripts/lib/*/__pycache__. As one may be using > O= and even having the sources o

[PATCH 2/4] drm/nouveau: Simplify calls to nvif_event_block()

2025-04-24 Thread Philipp Stanner
nouveau_fence_signal() returns a de-facto boolean to indicate when nvif_event_block() shall be called. The code can be made more compact and readable by calling nvif_event_block() in nouveau_fence_update() directly. Make those calls in nouveau_fence.c more canonical. Signed-off-by: Philipp Stann

[PATCH v2 2/2] drm: nova-drm: add initial driver skeleton

2025-04-24 Thread Danilo Krummrich
Add the initial nova-drm driver skeleton. nova-drm is connected to nova-core through the auxiliary bus and implements the DRM parts of the nova driver stack. For now, it implements the fundamental DRM abstractions, i.e. creates a DRM device and registers it, exposing a three sample IOCTLs. DRM

Re: [PATCH 2/4] drm/radeon: Remove unused radeon_doorbell_free

2025-04-24 Thread Dr. David Alan Gilbert
* Alex Deucher (alexdeuc...@gmail.com) wrote: > On Fri, Apr 18, 2025 at 2:18 AM Christophe JAILLET > wrote: > > > > Le 18/04/2025 à 02:21, li...@treblig.org a écrit : > > > From: "Dr. David Alan Gilbert" > > > > > > radeon_doorbell_free() was added in 2013 by > > > commit 75efdee11b5d ("drm/radeo

[PATCH v7 2/2] drm/i915/display: move min_hblank from dp_mst.c to dp.c

2025-04-24 Thread Arun R Murthy
Minimum HBlank is programmed to address jitter for high resolutions with high refresh rates that have small Hblank, specifically where Hblank is smaller than one MTP. TODO: Add the min_hblank calculation for hdmi as well. v2: move from intel_audio.c to intel_dp.c some correction in link_bpp_x

[PATCH v7 1/2] drm/display/dp: Export fn to calculate link symbol cycles

2025-04-24 Thread Arun R Murthy
Unify the function to calculate the link symbol cycles for both dsc and non-dsc case and export the function so that it can be used in the respective platform display drivers for other calculations. v2: unify the fn for both dsc and non-dsc case (Imre) v3: rename drm_dp_link_symbol_cycles to drm_d

  1   2   3   >