[PATCH 4/5] drm/mediatek: Add eDP driver for mt8196

2025-04-17 Thread Bincai Liu
Add code to support eDP 1.4 driver for mt8196. Signed-off-by: Bincai Liu --- drivers/gpu/drm/mediatek/mtk_dp.c | 484 ++ drivers/gpu/drm/mediatek/mtk_dp_reg.h | 126 +++ 2 files changed, 550 insertions(+), 60 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk

[PATCH 1/5] dt-bindings: eDP: mediatek: add eDP yaml for mt8196

2025-04-17 Thread Bincai Liu
Add compatible string to support eDP for MT8196. Signed-off-by: Bincai Liu --- .../devicetree/bindings/display/mediatek/mediatek,dp.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml b/Documentation/devicetree/bi

[PATCH v2] drm/bridge: lt9611uxc: Fix an error handling path in lt9611uxc_probe()

2025-04-17 Thread Christophe JAILLET
If lt9611uxc_audio_init() fails, some resources still need to be released before returning the error code. Use the existing error handling path. Fixes: 0cbbd5b1a012 ("drm: bridge: add support for lontium LT9611UXC bridge") Signed-off-by: Christophe JAILLET Reviewed-by: Dmitry Baryshkov --- Comp

[PATCH V6 4/5] drm/amdgpu: change DRM_ERROR to drm_file_err in amdgpu_userqueue.c

2025-04-17 Thread Sunil Khatri
change the DRM_ERROR to drm_file_err to add process name and pid to the logging. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 52 +++ 1 file changed, 29 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c

[PATCH v4 09/11] drm/bridge: anx7625: fix drm_bridge ops flags to support hot-plugging

2025-04-17 Thread Ayushi Makhija
From: Ayushi Makhija The anx7625_link_bridge() checks if a device is not a panel bridge and add DRM_BRIDGE_OP_HPD and DRM_BRIDGE_OP_DETECT flags to the drm_bridge->ops. However, on port 1 of the anx7625 bridge, any device added is always treated as a panel bridge, preventing connector_detect() fr

Re: [PATCH 2/4] drm/radeon: Remove unused radeon_doorbell_free

2025-04-17 Thread Christophe JAILLET
Le 18/04/2025 à 02:21, li...@treblig.org a écrit : From: "Dr. David Alan Gilbert" radeon_doorbell_free() was added in 2013 by commit 75efdee11b5d ("drm/radeon: implement simple doorbell page allocator") but never used. Hi, I think than instead of being removed, it should be used in the error

[PULL] drm-xe-fixes

2025-04-17 Thread Lucas De Marchi
Hi Dave and Sima, A few fixes for 6.15-rc3. Nothing really special. drm-xe-fixes-2025-04-18: Driver Changes: - Fix LRC address being written too late for GuC - Fix notifier vs folio deadlock - Fix race betwen dma_buf unmap and vram eviction - Fix debugfs handling PXP terminations unconditionally

Re: [PATCH 1/1] dt-bindings: display: imx: convert ldb.txt to yaml format

2025-04-17 Thread Alexander Stein
Am Mittwoch, 16. April 2025, 23:19:27 CEST schrieb Frank Li: > Convert ldb.txt to yaml format. > > Additional changes > - fix clock-names order to match existed dts file. > - remove lvds-panel and iomuxc-gpr node in examples. > - fsl,imx6q-ldb fail back to fsl,imx53-ldb. > > Signed-off-by: Frank

Re: [PATCH v2 7/8] rust: drm: gem: Add GEM object abstraction

2025-04-17 Thread Danilo Krummrich
On Thu, Apr 17, 2025 at 06:33:24PM -0400, Lyude Paul wrote: > On Thu, 2025-04-17 at 22:31 +0200, Danilo Krummrich wrote: > > On Thu, Apr 17, 2025 at 02:42:24PM -0400, Lyude Paul wrote: > > > On Fri, 2025-04-11 at 01:55 +0200, Danilo Krummrich wrote: > > > > +/// A base GEM object. > > > > +/// > >

[PATCH v9 0/4] Panthor BO tagging and GEMS debug display

2025-04-17 Thread Adrián Larumbe
This patch series is aimed at providing UM with detailed memory profiling information in debug builds. It is achieved through a device-wide list of DRM GEM objects, and also implementing the ability to label BO's from UM through a new IOCTL. The new debugfs file shows a list of driver DRM GEM obje

[PATCH] drm: panel: jd9365da: fix reset signal polarity in unprepare

2025-04-17 Thread Hugo Villeneuve
From: Hugo Villeneuve commit a8972d5a49b4 ("drm: panel: jd9365da-h3: fix reset signal polarity") fixed reset signal polarity in jadard_dsi_probe() and jadard_prepare(). It was not done in jadard_unprepare() because of an incorrect assumption about reset line handling in power off mode. After loo

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-17 Thread Danilo Krummrich
On Thu, Apr 17, 2025 at 05:08:12PM +0100, Tvrtko Ursulin wrote: > To catch up on why if you could dig out the links to past discussions it > would be helpful. I can't look it up currently, sorry. That's why I said Philipp will loop you in once he's back. :) > I repeat how there is a lot of attrac

Re: [PATCH 2/2] accel/ivpu: Show NPU frequency in sysfs

2025-04-17 Thread Falkowski, Maciej
On 4/11/2025 5:49 PM, Jeff Hugo wrote: On 4/8/2025 8:55 AM, Falkowski, Maciej wrote: On 4/4/2025 5:13 PM, Jeff Hugo wrote: On 4/1/2025 9:59 AM, Maciej Falkowski wrote: From: Andrzej Kacprowski Add sysfs files that show maximum and current frequency of the NPU's data processing unit. New sy

[PATCH v9 3/4] drm/panthor: Label all kernel BO's

2025-04-17 Thread Adrián Larumbe
Kernel BO's aren't exposed to UM, so labelling them is the responsibility of the driver itself. This kind of tagging will prove useful in further commits when want to expose these objects through DebugFS. Expand panthor_kernel_bo_create() interface to take a NUL-terminated string. No bounds checki

[PATCH v9 2/4] drm/panthor: Add driver IOCTL for setting BO labels

2025-04-17 Thread Adrián Larumbe
Allow UM to label a BO for which it possesses a DRM handle. Signed-off-by: Adrián Larumbe Reviewed-by: Liviu Dudau Reviewed-by: Boris Brezillon Reviewed-by: Steven Price --- drivers/gpu/drm/panthor/panthor_drv.c | 45 ++- drivers/gpu/drm/panthor/panthor_gem.h | 2 ++

[PATCH v9 4/4] drm/panthor: show device-wide list of DRM GEM objects over DebugFS

2025-04-17 Thread Adrián Larumbe
Add a device DebugFS file that displays a complete list of all the DRM GEM objects that are exposed to UM through a DRM handle. Since leaking object identifiers that might belong to a different NS is inadmissible, this functionality is only made available in debug builds with DEBUGFS support enabl

Re: [PATCH v2 2/2] drm/panthor: Fix the user MMIO offset logic for emulators

2025-04-17 Thread Boris Brezillon
On Thu, 17 Apr 2025 16:13:49 +0100 Steven Price wrote: > On 17/04/2025 15:49, Boris Brezillon wrote: > > Currently, we pick the MMIO offset based on the size of the pgoff_t > > type seen by the process that manipulates the FD, such that a 32-bit > > process can always map the user MMIO ranges. Bu

Re: [PATCH v2 3/4] drm/msm/a6xx: Get HBB dynamically, if available

2025-04-17 Thread Connor Abbott
On Thu, Apr 17, 2025, 1:50 PM Akhil P Oommen wrote: > > On 4/17/2025 9:02 PM, Connor Abbott wrote: > > On Thu, Apr 17, 2025 at 3:45 AM Akhil P Oommen > > wrote: > >> > >> On 4/10/2025 11:13 PM, Konrad Dybcio wrote: > >>> From: Konrad Dybcio > >>> > >>> The Highest Bank address Bit value can cha

Re: [PATCH] drm/amd/display: do not copy invalid CRTC timing info

2025-04-17 Thread Alex Hung
No issues from promotion tests. Reviewed-by: Alex Hung On 4/8/25 10:55, Alex Hung wrote: Hi Gergo, Thanks for the patch. I am sending this patch for testing and I will update test result next week. On 4/2/25 11:03, Gergo Koteles wrote: Since b255ce4388e0, it is possible that the CRTC tim

[PATCH 4/4] drm/amd/display: Remove unused *vbios_smu_set_dprefclk

2025-04-17 Thread linux
From: "Dr. David Alan Gilbert" rn_vbios_smu_set_dprefclk() was added in 2019 by commit 4edb6fc91878 ("drm/amd/display: Add Renoir clock manager") rv1_vbios_smu_set_dprefclk() was also added in 2019 by commit dc88b4a684d2 ("drm/amd/display: make clk mgr soc specific") neither have been used. Rem

[PATCH 3/4] drm/radeon: Remove unused radeon_fence_wait_any

2025-04-17 Thread linux
From: "Dr. David Alan Gilbert" radeon_fence_wait_any() last use was removed in 2023's commit 254986e324ad ("drm/radeon: Use the drm suballocation manager implementation.") Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/radeon/radeon.h | 3 -- drivers/gpu/drm/radeo

[PATCH 1/4] drm/radeon/radeon_audio: Remove unused r600_hdmi_audio_workaround

2025-04-17 Thread linux
From: "Dr. David Alan Gilbert" The last use of r600_hdmi_audio_workaround() was removed by 2014's commit 6e72376dcc66 ("radeon/audio: consolidate audio_mode_set() functions") Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/radeon/r600_hdmi.c | 22 --

[PATCH 2/4] drm/radeon: Remove unused radeon_doorbell_free

2025-04-17 Thread linux
From: "Dr. David Alan Gilbert" radeon_doorbell_free() was added in 2013 by commit 75efdee11b5d ("drm/radeon: implement simple doorbell page allocator") but never used. Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/radeon/radeon.h| 1 - drivers/gpu/drm/radeon/ra

[PATCH 0/4] drm/amd & radeon deadcoding

2025-04-17 Thread linux
From: "Dr. David Alan Gilbert" Hi, Another set of deadcoding around amd/radeon GPU stuff. Dave Signed-off-by: Dr. David Alan Gilbert Dr. David Alan Gilbert (4): drm/radeon/radeon_audio: Remove unused r600_hdmi_audio_workaround drm/radeon: Remove unused radeon_doorbell_free drm/radeon:

Re: [PATCH v4 01/10] dt-bindings: display/msm: dp-controller: describe SAR2130P

2025-04-17 Thread Dmitry Baryshkov
On Thu, 17 Apr 2025 at 15:04, Krzysztof Kozlowski wrote: > > On 17/04/2025 13:12, Konrad Dybcio wrote: > > On 4/17/25 8:03 AM, Krzysztof Kozlowski wrote: > >> On Thu, Apr 17, 2025 at 02:16:31AM GMT, Dmitry Baryshkov wrote: > >>> From: Dmitry Baryshkov > >>> > >>> Describe DisplayPort controller p

Re: [PATCH v2 7/8] rust: drm: gem: Add GEM object abstraction

2025-04-17 Thread Lyude Paul
On Thu, 2025-04-17 at 22:31 +0200, Danilo Krummrich wrote: > On Thu, Apr 17, 2025 at 02:42:24PM -0400, Lyude Paul wrote: > > On Fri, 2025-04-11 at 01:55 +0200, Danilo Krummrich wrote: > > > +/// A base GEM object. > > > +/// > > > +/// Invariants > > > +/// > > > +/// `self.dev` is always a valid p

[PATCH v2 0/2] drm/panthor: Fix panthor+FEX-Emu

2025-04-17 Thread Boris Brezillon
Hello, This is an attempt a couple bugs exposed by FEX-Emu. The first one is pretty trivial and should be uncontroversial, since it's just a missing padding field in one of our uAPI structs. We are getting away with it on arm32 because of the alignment rules provided by the Arm ABI, but x86 has re

Re: [PATCH] dma-buf: heaps: Set allocation orders for larger page sizes

2025-04-17 Thread Juan Yescas
On Thu, Apr 17, 2025 at 1:06 AM Christian König wrote: > > Am 16.04.25 um 23:51 schrieb Juan Yescas: > > On Wed, Apr 16, 2025 at 4:34 AM Christian König > wrote: > > > Am 15.04.25 um 19:19 schrieb Juan Yescas: > > This change sets the allocation orders for the different page sizes > (4k, 16k, 64k

Re: [PATCH v9 5/6] rust: enable `clippy::cast_lossless` lint

2025-04-17 Thread Tamir Duberstein
On Thu, Apr 17, 2025 at 1:29 PM Boqun Feng wrote: > > On Wed, Apr 16, 2025 at 01:36:09PM -0400, Tamir Duberstein wrote: > > Before Rust 1.29.0, Clippy introduced the `cast_lossless` lint [1]: > > > > > Rust’s `as` keyword will perform many kinds of conversions, including > > > silently lossy conve

Re: [PATCH 2/4] bpf: Add dmabuf iterator

2025-04-17 Thread Song Liu
On Thu, Apr 17, 2025 at 9:05 AM T.J. Mercier wrote: > > On Wed, Apr 16, 2025 at 9:56 PM Song Liu wrote: > > > > On Wed, Apr 16, 2025 at 7:09 PM T.J. Mercier wrote: > > > > > > On Wed, Apr 16, 2025 at 6:26 PM Song Liu wrote: > > [...] > > > > > > > > Here is another rookie question, it appears t

Re: [PATCH v2 4/8] rust: drm: add device abstraction

2025-04-17 Thread Danilo Krummrich
On Thu, Apr 17, 2025 at 02:53:33PM -0400, Lyude Paul wrote: > On Fri, 2025-04-11 at 01:55 +0200, Danilo Krummrich wrote: > > +    /// Not intended to be called externally, except via > > declare_drm_ioctls!() > > +    /// > > +    /// # Safety > > +    /// > > +    /// Callers must ensure that `pt

[PATCH v3] dma-buf: system_heap: Set allocation orders for larger page sizes

2025-04-17 Thread Juan Yescas
This change sets the allocation orders for the different page sizes (4k, 16k, 64k) based on PAGE_SHIFT. Before this change, the orders for large page sizes were calculated incorrectly, this caused system heap to allocate from 2% to 4% more memory on 16KiB page size kernels. This change was tested

Re: [PATCH v9 4/6] rust: enable `clippy::as_underscore` lint

2025-04-17 Thread Boqun Feng
On Thu, Apr 17, 2025 at 03:26:14PM -0400, Tamir Duberstein wrote: [...] > > > > > Ok(()) > > > } > > > diff --git a/rust/kernel/device_id.rs b/rust/kernel/device_id.rs > > > index e5859217a579..4063f09d76d9 100644 > > > --- a/rust/kernel/device_id.rs > > > +++ b/rust/kernel/device_id.

Re: [PATCH V6 2/5] drm/amdgpu: add drm_file reference in userq_mgr

2025-04-17 Thread Tvrtko Ursulin
On 17/04/2025 13:31, Sunil Khatri wrote: drm_file will be used in usermode queues code to enable better process information in logging and hence add drm_file part of the userq_mgr struct. update the drm_file pointer in userq_mgr for each amdgpu_driver_open_kms. Signed-off-by: Sunil Khatri --

[PATCH] drm/schedular: fix the warning in drm_sched_job_done

2025-04-17 Thread Sunil Khatri
Fix the below warning. scheduler/sched_main.c:397: warning: Function parameter or struct member 'result' not described in 'drm_sched_job_done' Signed-off-by: Sunil Khatri --- drivers/gpu/drm/scheduler/sched_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/scheduler/sch

Re: [PATCH v9 4/6] rust: enable `clippy::as_underscore` lint

2025-04-17 Thread Tamir Duberstein
On Thu, Apr 17, 2025 at 1:55 PM Boqun Feng wrote: > > On Wed, Apr 16, 2025 at 01:36:08PM -0400, Tamir Duberstein wrote: > > In Rust 1.63.0, Clippy introduced the `as_underscore` lint [1]: > > > > > The conversion might include lossy conversion or a dangerous cast that > > > might go undetected due

Re: [PATCH V6 1/5] drm: add drm_file_err function to add process info

2025-04-17 Thread Khatri, Sunil
On 4/17/2025 7:04 PM, Tvrtko Ursulin wrote: On 17/04/2025 13:31, Sunil Khatri wrote: Add a drm helper function which append the process information for appends Noted the drm_file over drm_err formated output. formatted 'Noted v5: change to macro from function (Christian Koenig)   

Re: [PATCH v2 4/8] rust: drm: add device abstraction

2025-04-17 Thread Lyude Paul
On Fri, 2025-04-11 at 01:55 +0200, Danilo Krummrich wrote: > +    /// Not intended to be called externally, except via > declare_drm_ioctls!() > +    /// > +    /// # Safety > +    /// > +    /// Callers must ensure that `ptr` is valid, non-null, and has a > non-zero reference count, > +    /// i

[PATCH V6 3/5] drm/amdgpu: use drm_file_err in fence timeouts

2025-04-17 Thread Sunil Khatri
use drm_file_err instead of DRM_ERROR which adds process and pid information in the userqueue error logging. Sample log: [ 42.444297] [drm:amdgpu_userqueue_wait_for_signal [amdgpu]] *ERROR* Timed out waiting for fence f=1c74d978 for comm:Xwayland pid:3427 [ 42.444669] [drm:amdgpu_user

Re: [PATCH v4 0/3] Use proper printk format in appletbdrm

2025-04-17 Thread Aditya Garg
Hi On 08-04-2025 12:17 pm, Aditya Garg wrote: > The vsprint patch was originally being sent as a seperate patch [1], and > I was waiting it to be taken up. But as suggested by Petr, I'm sending > them via DRM. > > v2: > Remove printf tests, will merge later through Kees' tree > > v3: > Re-add

Re: [PATCH v2 7/8] rust: drm: gem: Add GEM object abstraction

2025-04-17 Thread Lyude Paul
Some comments down below: On Fri, 2025-04-11 at 01:55 +0200, Danilo Krummrich wrote: > From: Asahi Lina > > DRM GEM is the DRM memory management subsystem used by most modern > drivers; add a Rust abstraction for DRM GEM. > > This includes the BaseObject trait, which contains operations shared

Re: [PATCH 4/7] drm/bridge: analogic_dp: drop panel_lock

2025-04-17 Thread Neil Armstrong
On 01/04/2025 07:11, Dmitry Baryshkov wrote: The analogix_dp_prepare_panel() function is called from bridge's atomic_pre_enable() and atomic_post_disable() callbacks, which can not happen simultaneously. Drop the useless mutex. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/analog

Re: [PATCH 02/13] drm/amd/display: use drm_edid_product_id for parsing EDID product info

2025-04-17 Thread Melissa Wen
On 15/04/2025 06:32, Michel Dänzer wrote: On 2025-04-11 22:08, Melissa Wen wrote: Since [1], we can use drm_edid_product_id to get debug info from drm_edid instead of directly parsing EDID. Link: https://lore.kernel.org/dri-devel/cover.1712655867.git.jani.nik...@intel.com/ [1] Signed-off-b

Re: [PATCH] drm/schedular: fix the warning in drm_sched_job_done

2025-04-17 Thread Tvrtko Ursulin
[Added Philipp and Danilo to cc.] On 17/04/2025 10:25, Sunil Khatri wrote: Fix the below warning. scheduler/sched_main.c:397: warning: Function parameter or struct member 'result' not described in 'drm_sched_job_done' Signed-off-by: Sunil Khatri --- drivers/gpu/drm/scheduler/sched_main.c

[PATCH] dma-buf: system_heap: No separate allocation for attachment sg_tables

2025-04-17 Thread T.J. Mercier
struct dma_heap_attachment is a separate allocation from the struct sg_table it contains, but there is no reason for this. Let's use the slab allocator just once instead of twice for dma_heap_attachment. Signed-off-by: T.J. Mercier --- drivers/dma-buf/heaps/system_heap.c | 43 ---

Re: [PATCH v9 4/6] rust: enable `clippy::as_underscore` lint

2025-04-17 Thread Boqun Feng
On Wed, Apr 16, 2025 at 01:36:08PM -0400, Tamir Duberstein wrote: > In Rust 1.63.0, Clippy introduced the `as_underscore` lint [1]: > > > The conversion might include lossy conversion or a dangerous cast that > > might go undetected due to the type being inferred. > > > > The lint is allowed by de

Re: [PATCH v2 3/4] drm/msm/a6xx: Get HBB dynamically, if available

2025-04-17 Thread Akhil P Oommen
On 4/17/2025 9:02 PM, Connor Abbott wrote: > On Thu, Apr 17, 2025 at 3:45 AM Akhil P Oommen > wrote: >> >> On 4/10/2025 11:13 PM, Konrad Dybcio wrote: >>> From: Konrad Dybcio >>> >>> The Highest Bank address Bit value can change based on memory type used. >>> >>> Attempt to retrieve it dynamical

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-17 Thread Tvrtko Ursulin
On 17/04/2025 08:45, Philipp Stanner wrote: On Mon, 2025-04-07 at 17:22 +0200, Philipp Stanner wrote: drm_sched_fini() can leak jobs under certain circumstances. Warn if that happens. Signed-off-by: Philipp Stanner ---  drivers/gpu/drm/scheduler/sched_main.c | 4 I hear a lot of amaz

Re: [PATCH v9 5/6] rust: enable `clippy::cast_lossless` lint

2025-04-17 Thread Boqun Feng
On Wed, Apr 16, 2025 at 01:36:09PM -0400, Tamir Duberstein wrote: > Before Rust 1.29.0, Clippy introduced the `cast_lossless` lint [1]: > > > Rust’s `as` keyword will perform many kinds of conversions, including > > silently lossy conversions. Conversion functions such as `i32::from` > > will only

Re: [PATCH v9 2/6] rust: enable `clippy::ptr_cast_constness` lint

2025-04-17 Thread Tamir Duberstein
On Thu, Apr 17, 2025 at 1:12 PM Boqun Feng wrote: > > On Wed, Apr 16, 2025 at 01:36:06PM -0400, Tamir Duberstein wrote: > > In Rust 1.72.0, Clippy introduced the `ptr_cast_constness` lint [1]: > > > > > Though `as` casts between raw pointers are not terrible, > > > `pointer::cast_mut` and `pointer

Re: [PATCH v9 3/6] rust: enable `clippy::as_ptr_cast_mut` lint

2025-04-17 Thread Boqun Feng
On Wed, Apr 16, 2025 at 01:36:07PM -0400, Tamir Duberstein wrote: > In Rust 1.66.0, Clippy introduced the `as_ptr_cast_mut` lint [1]: > > > Since `as_ptr` takes a `&self`, the pointer won’t have write > > permissions unless interior mutability is used, making it unlikely > > that having it as a mu

Re: [PATCH v9 2/6] rust: enable `clippy::ptr_cast_constness` lint

2025-04-17 Thread Boqun Feng
On Wed, Apr 16, 2025 at 01:36:06PM -0400, Tamir Duberstein wrote: > In Rust 1.72.0, Clippy introduced the `ptr_cast_constness` lint [1]: > > > Though `as` casts between raw pointers are not terrible, > > `pointer::cast_mut` and `pointer::cast_const` are safer because they > > cannot accidentally c

Re: [PATCH v9 1/6] rust: enable `clippy::ptr_as_ptr` lint

2025-04-17 Thread Tamir Duberstein
On Thu, Apr 17, 2025 at 12:48 PM Boqun Feng wrote: > > On Wed, Apr 16, 2025 at 01:36:05PM -0400, Tamir Duberstein wrote: > > In Rust 1.51.0, Clippy introduced the `ptr_as_ptr` lint [1]: > > > > > Though `as` casts between raw pointers are not terrible, > > > `pointer::cast` is safer because it can

Re: [PATCH v8 4/4] drm/panthor: show device-wide list of DRM GEM objects over DebugFS

2025-04-17 Thread Steven Price
On 15/04/2025 20:15, Adrián Larumbe wrote: > Add a device DebugFS file that displays a complete list of all the DRM > GEM objects that are exposed to UM through a DRM handle. > > Since leaking object identifiers that might belong to a different NS is > inadmissible, this functionality is only made

Re: [PATCH v9 1/6] rust: enable `clippy::ptr_as_ptr` lint

2025-04-17 Thread Boqun Feng
On Wed, Apr 16, 2025 at 01:36:05PM -0400, Tamir Duberstein wrote: > In Rust 1.51.0, Clippy introduced the `ptr_as_ptr` lint [1]: > > > Though `as` casts between raw pointers are not terrible, > > `pointer::cast` is safer because it cannot accidentally change the > > pointer's mutability, nor cast

Re: [PATCH v2 2/2] drm/panthor: Fix the user MMIO offset logic for emulators

2025-04-17 Thread Steven Price
On 17/04/2025 15:49, Boris Brezillon wrote: > Currently, we pick the MMIO offset based on the size of the pgoff_t > type seen by the process that manipulates the FD, such that a 32-bit > process can always map the user MMIO ranges. But this approach doesn't > work well for emulators like FEX, where

[PATCH][next] accel/habanalabs: Make the read-only array edma_queues_id static const

2025-04-17 Thread Colin Ian King
Don't populate the read-only array edma_queues_id on the stack at run time, instead make it static const. Signed-off-by: Colin Ian King --- drivers/accel/habanalabs/gaudi2/gaudi2.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/accel/habanalabs/gaudi2/gaud

Re: [PATCH v2 1/4] PM: device: Introduce platform_resources_managed flag

2025-04-17 Thread Michal Wilczynski
On 4/16/25 16:48, Rafael J. Wysocki wrote: > On Wed, Apr 16, 2025 at 3:32 PM Michal Wilczynski > wrote: >> >> On 4/15/25 18:42, Rafael J. Wysocki wrote: >>> On Mon, Apr 14, 2025 at 8:53 PM Michal Wilczynski >>> wrote: Introduce a new dev_pm_info flag - platform_resources_managed, to

[PATCH V8 1/5] drm: add drm_file_err function to add process info

2025-04-17 Thread Sunil Khatri
Add a drm helper function which appends the process information for the drm_file over drm_err formatted output. v5: change to macro from function (Christian Koenig) add helper functions for lock/unlock (Christian Koenig) v6: remove __maybe_unused and make function inline (Jani Nikula) rem

[PATCH V8 4/5] drm/amdgpu: change DRM_ERROR to drm_file_err in amdgpu_userqueue.c

2025-04-17 Thread Sunil Khatri
change the DRM_ERROR to drm_file_err to add process name and pid to the logging. Signed-off-by: Sunil Khatri Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 52 +++ 1 file changed, 29 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/am

[PATCH V8 3/5] drm/amdgpu: use drm_file_err in fence timeouts

2025-04-17 Thread Sunil Khatri
use drm_file_err instead of DRM_ERROR which adds process and pid information in the userqueue error logging. Sample log: [ 19.802315] amdgpu :0a:00.0: [drm] *ERROR* comm: ibus-x11 pid: 2055 client: Unset ... Couldn't unmap all the queues [ 19.802319] amdgpu :0a:00.0: [drm] *ERROR* co

[PATCH V8 5/5] drm/amdgpu: change DRM_DBG_DRIVER to drm_dbg_driver

2025-04-17 Thread Sunil Khatri
update the functions in amdgpu_userqueues.c from DRM_DBG_DRIVER to drm_dbg_driver so multi gpu instance can be logged in. Signed-off-by: Sunil Khatri Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-17 Thread Tvrtko Ursulin
On 17/04/2025 15:48, Danilo Krummrich wrote: On Thu, Apr 17, 2025 at 03:20:44PM +0100, Tvrtko Ursulin wrote: On 17/04/2025 13:11, Danilo Krummrich wrote: On Thu, Apr 17, 2025 at 12:27:29PM +0100, Tvrtko Ursulin wrote: On 17/04/2025 08:45, Philipp Stanner wrote: On Mon, 2025-04-07 at 17:22

Re: [PATCH V6 3/5] drm/amdgpu: use drm_file_err in fence timeouts

2025-04-17 Thread Tvrtko Ursulin
On 17/04/2025 13:31, Sunil Khatri wrote: use drm_file_err instead of DRM_ERROR which adds process and pid information in the userqueue error logging. Sample log: [ 42.444297] [drm:amdgpu_userqueue_wait_for_signal [amdgpu]] *ERROR* Timed out waiting for fence f=1c74d978 for comm:Xway

Re: [PATCH 2/4] bpf: Add dmabuf iterator

2025-04-17 Thread T.J. Mercier
On Wed, Apr 16, 2025 at 9:56 PM Song Liu wrote: > > On Wed, Apr 16, 2025 at 7:09 PM T.J. Mercier wrote: > > > > On Wed, Apr 16, 2025 at 6:26 PM Song Liu wrote: > [...] > > > > > > Here is another rookie question, it appears to me there is a file > > > descriptor > > > associated with each DMA b

Re: [PATCH V6 3/5] drm/amdgpu: use drm_file_err in fence timeouts

2025-04-17 Thread Khatri, Sunil
On 4/17/2025 7:11 PM, Tvrtko Ursulin wrote: On 17/04/2025 13:31, Sunil Khatri wrote: use drm_file_err instead of DRM_ERROR which adds process and pid information in the userqueue error logging. Sample log: [   42.444297] [drm:amdgpu_userqueue_wait_for_signal [amdgpu]] *ERROR* Timed out wait

Re: [PATCH v3 0/2] Add Visionox G2647FB105 panel support

2025-04-17 Thread Neil Armstrong
Hi, On Mon, 14 Apr 2025 20:26:30 +0300, Alexander Baransky wrote: > This patch series adds support for the Visionox G2647FB105 panel, used in: > - Xiaomi Mi Note 10 / CC9 Pro (sm7150-xiaomi-tucana) > - Xiaomi Mi Note 10 Lite (sm7150-xiaomi-toco) > > Testing has been done by me on sm7150-xiaomi-tu

Re: [PATCH 2/7] drm/bridge: analogix_dp: drop unused argument to analogix_dp_prepare_panel()

2025-04-17 Thread Neil Armstrong
On 01/04/2025 07:11, Dmitry Baryshkov wrote: After previous cleanup all calling sites pass true as is_modeset_prepare argument to analogix_dp_prepare_panel(). Drop dead code depending on that argument being false. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/analogix/analogix_dp

Re: [PATCH 6/7] drm/bridge: analogix_dp: ignore return values of drm_panel_* calls

2025-04-17 Thread Neil Armstrong
On 01/04/2025 07:11, Dmitry Baryshkov wrote: Follow the example of other drivers and ignore return values of the drm_panel_prepare() / unprepare() / enable() / disable() calls. There is no possible error recovery, so the driver just logs a message. Signed-off-by: Dmitry Baryshkov --- drivers/

Re: [PATCH 5/7] drm/bridge: analogix_dp: inline analogix_dp_prepare_panel()

2025-04-17 Thread Neil Armstrong
On 01/04/2025 07:11, Dmitry Baryshkov wrote: The analogix_dp_prepare_panel() is now only calling a corresponding drm_panel function. Inline it to simplify the code. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 43 +- 1 file chan

Re: [PATCH 3/7] drm/bridge: analogic_dp: drop panel_is_modeset

2025-04-17 Thread Neil Armstrong
On 01/04/2025 07:11, Dmitry Baryshkov wrote: The dp->panel_is_modeset is now a write-only field. Drop it completely. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 11 +-- drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 1 - 2 files ch

Re: [PATCH v8 4/4] drm/panthor: show device-wide list of DRM GEM objects over DebugFS

2025-04-17 Thread Steven Price
On 17/04/2025 15:46, Adrián Larumbe wrote: > Hi Steve, > > On 17.04.2025 15:25, Steven Price wrote: >> On 15/04/2025 20:15, Adrián Larumbe wrote: >>> Add a device DebugFS file that displays a complete list of all the DRM >>> GEM objects that are exposed to UM through a DRM handle. >>> >>> Since le

Re: [PATCH v3 0/3] drm/panel: simple: add Tianma P0700WXF1MBAA and improve Tianma TM070JDHG34-00

2025-04-17 Thread Neil Armstrong
Hi, On Fri, 11 Apr 2025 21:19:43 +0200, Luca Ceresoli wrote: > This short series adds power on/off timings to the Tianma TM070JDHG34-00 > panel and adds support for the the Tianma P0700WXF1MBAA panel. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1

Re: [PATCH v4 0/3] Add driver for Himax HX8279 DriverIC panels

2025-04-17 Thread Neil Armstrong
Hi, On Mon, 14 Apr 2025 10:29:15 +0200, AngeloGioacchino Del Regno wrote: > Changes in v4: > - Changed hx8279_set_page() and all other utilities to void (Neil) > - Changed hx8279_{on,prepare,unprepare}() to return dsi_ctx.accum_err (Neil) > - Switched to devm_drm_panel_alloc() as suggested (Nei

Re: [PATCH v3 2/2] drm/panel: Add Visionox G2647FB105 panel driver

2025-04-17 Thread neil . armstrong
On 14/04/2025 19:26, Alexander Baransky wrote: Add the driver for Visionox G2647FB105 6.47" FHD Plus CMD mode AMOLED panel support found in: - Xiaomi Mi Note 10 / CC9 Pro (sm7150-xiaomi-tucana) - Xiaomi Mi Note 10 Lite (sm7150-xiaomi-toco) Signed-off-by: Alexander Baransky --- drivers/gpu/drm

Re: [PATCH v2 3/4] drm/msm/a6xx: Get HBB dynamically, if available

2025-04-17 Thread Connor Abbott
On Thu, Apr 17, 2025 at 3:45 AM Akhil P Oommen wrote: > > On 4/10/2025 11:13 PM, Konrad Dybcio wrote: > > From: Konrad Dybcio > > > > The Highest Bank address Bit value can change based on memory type used. > > > > Attempt to retrieve it dynamically, and fall back to a reasonable > > default (the

Re: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator

2025-04-17 Thread Gupta, Nipun
On 12-04-2025 06:53, Herbert Xu wrote: On Fri, Apr 11, 2025 at 11:50:54PM +0530, Gupta, Nipun wrote: AFAIU after looking into it, the keyring subsystem is not to perform the data operations, but for managing keys for these operations. Kindly correct me if I am wrong here. Have a look at s

[PATCH 1/1] dt-bindings: display: imx: convert fsl, dcu.txt to yaml format

2025-04-17 Thread Frank Li
Convert fsl,dcu.txt to yaml format. Additional changes: - remove label in example. - change node to display-controller in example. - use 32bit address in example. Signed-off-by: Frank Li --- .../devicetree/bindings/display/fsl,dcu.txt | 34 -- .../bindings/display/fsl,ls1021a-dcu.yaml

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-17 Thread Danilo Krummrich
On Thu, Apr 17, 2025 at 03:20:44PM +0100, Tvrtko Ursulin wrote: > > On 17/04/2025 13:11, Danilo Krummrich wrote: > > On Thu, Apr 17, 2025 at 12:27:29PM +0100, Tvrtko Ursulin wrote: > > > > > > On 17/04/2025 08:45, Philipp Stanner wrote: > > > > On Mon, 2025-04-07 at 17:22 +0200, Philipp Stanner w

Re: [PATCH v2] drm/doc: document front-buffer rendering

2025-04-17 Thread Simon Ser
On Monday, April 14th, 2025 at 13:06, Pekka Paalanen wrote: > Looking good, but given the new wording is 100% mine, not sure I can > give reviewed-by? > > Co-authored-by maybe? Since it's 100% yours, probably you should be the commit author? Would you mind giving a S-o-b as well? But I wonder

Re: [PATCH v8 1/4] drm/panthor: Introduce BO labeling

2025-04-17 Thread Steven Price
On 15/04/2025 20:15, Adrián Larumbe wrote: > Add a new character string Panthor BO field, and a function that allows > setting it from within the driver. > > Driver takes care of freeing the string when it's replaced or no longer > needed at object destruction time, but allocating it is the respon

Re: [PATCH V8 06/43] drm/colorop: Add 1D Curve subtype

2025-04-17 Thread Simon Ser
On Tuesday, April 15th, 2025 at 13:12, Borah, Chaitanya Kumar wrote: > On 4/8/2025 10:10 PM, Daniel Stone wrote: > > > As it stands, I've gone through the implementation pretty thoroughly, > > as well as our use of it in Weston. I'm happy with how it looks for > > pre-blend, and I'm even happie

[syzbot] [dri?] [virt?] WARNING in virtio_gpu_queue_fenced_ctrl_buffer

2025-04-17 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:7cdabafc0012 Merge tag 'trace-v6.15-rc1' of git://git.kern.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=108e787058 kernel config: https://syzkaller.appspot.com/x/.config?x=4c918722cb7e3d7 dash

Re: [PATCH V6 5/5] drm/amdgpu: change DRM_DBG_DRIVER to drm_dbg_driver

2025-04-17 Thread Tvrtko Ursulin
On 17/04/2025 13:31, Sunil Khatri wrote: update the functions in amdgpu_userqueues.c from DRM_DBG_DRIVER to drm_dbg_driver so multi gpu instance can be logged in. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 8 +--- 1 file changed, 5 insertions(+), 3

Re: [PATCH v2 1/2] drm/panthor: Add missing explicit padding in drm_panthor_gpu_info

2025-04-17 Thread Steven Price
On 17/04/2025 15:49, Boris Brezillon wrote: > drm_panthor_gpu_info::shader_present is currently automatically offset > by 4 byte to meet Arm's 32-bit/64-bit field alignment rules, but those > constraints don't stand on 32-bit x86 and cause a mismatch when running > an x86 binary in a user emulated

Re: [PATCH 03/13] drm/amd/display: parse display name from drm_eld

2025-04-17 Thread Melissa Wen
On 14/04/2025 07:10, Jani Nikula wrote: On Fri, 11 Apr 2025, Melissa Wen wrote: We don't need to parse dc_edid to get the display name since it's already set in drm_eld which in turn had it values updated when updating connector with the opaque drm_edid. Signed-off-by: Melissa Wen --- ..

[PATCH v6 3/5] drm/amdgpu: use drm_file_err to add process info

2025-04-17 Thread Sunil Khatri
add process and pid information in the userqueue error logging to make it more useful in resolving the error by logs. drm_file_err logs pid and process name by default. Sample log: [ 42.444297] [drm:amdgpu_userqueue_wait_for_signal [amdgpu]] *ERROR* Timed out waiting for fence f=1c74d97

Re: [PATCH 2/2] drm/panthor: Fix the user MMIO offset logic for emulators

2025-04-17 Thread Steven Price
On 17/04/2025 13:10, Boris Brezillon wrote: > On Thu, 17 Apr 2025 11:41:18 +0100 > Steven Price wrote: > >> On 17/04/2025 11:05, Boris Brezillon wrote: >>> Currently, we pick the MMIO offset based on the size of the pgoff_t >>> type seen by the process that manipulates the FD, such that a 32-bit

[PATCH V8] drm: add drm_file_err function to add process info

2025-04-17 Thread Sunil Khatri
Add a drm helper function which appends the process information for the drm_file over drm_err formatted output. v5: change to macro from function (Christian Koenig) add helper functions for lock/unlock (Christian Koenig) v6: remove __maybe_unused and make function inline (Jani Nikula) rem

[PATCH v2 1/2] drm/panthor: Add missing explicit padding in drm_panthor_gpu_info

2025-04-17 Thread Boris Brezillon
drm_panthor_gpu_info::shader_present is currently automatically offset by 4 byte to meet Arm's 32-bit/64-bit field alignment rules, but those constraints don't stand on 32-bit x86 and cause a mismatch when running an x86 binary in a user emulated environment like FEX. It's also generally agreed tha

[PATCH v2 2/2] drm/panthor: Fix the user MMIO offset logic for emulators

2025-04-17 Thread Boris Brezillon
Currently, we pick the MMIO offset based on the size of the pgoff_t type seen by the process that manipulates the FD, such that a 32-bit process can always map the user MMIO ranges. But this approach doesn't work well for emulators like FEX, where the emulator is a 64-bit binary which might be exec

Re: [PATCH 1/1] dt-bindings: display: imx: convert ldb.txt to yaml format

2025-04-17 Thread Frank Li
On Thu, Apr 17, 2025 at 08:37:49AM +0200, Alexander Stein wrote: > Am Mittwoch, 16. April 2025, 23:19:27 CEST schrieb Frank Li: > > Convert ldb.txt to yaml format. > > > > Additional changes > > - fix clock-names order to match existed dts file. > > - remove lvds-panel and iomuxc-gpr node in exampl

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-17 Thread Tvrtko Ursulin
On 17/04/2025 13:11, Danilo Krummrich wrote: On Thu, Apr 17, 2025 at 12:27:29PM +0100, Tvrtko Ursulin wrote: On 17/04/2025 08:45, Philipp Stanner wrote: On Mon, 2025-04-07 at 17:22 +0200, Philipp Stanner wrote: Problem exactly is that jobs can outlive the entities and the scheduler, while

Re: [PATCH 02/13] drm/amd/display: use drm_edid_product_id for parsing EDID product info

2025-04-17 Thread Michel Dänzer
On 2025-04-17 15:27, Melissa Wen wrote: > On 15/04/2025 06:32, Michel Dänzer wrote: >> On 2025-04-11 22:08, Melissa Wen wrote: >>> Since [1], we can use drm_edid_product_id to get debug info from >>> drm_edid instead of directly parsing EDID. >>> >>> Link: >>> https://lore.kernel.org/dri-devel/cov

Re: [PATCH V6 1/5] drm: add drm_file_err function to add process info

2025-04-17 Thread Tvrtko Ursulin
On 17/04/2025 13:31, Sunil Khatri wrote: Add a drm helper function which append the process information for appends the drm_file over drm_err formated output. formatted v5: change to macro from function (Christian Koenig) add helper functions for lock/unlock (Christian Koenig) v6:

Re: [PATCH V6 4/5] drm/amdgpu: change DRM_ERROR to drm_file_err in amdgpu_userqueue.c

2025-04-17 Thread Tvrtko Ursulin
On 17/04/2025 13:31, Sunil Khatri wrote: change the DRM_ERROR to drm_file_err to add process name and pid to the logging. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 52 +++ 1 file changed, 29 insertions(+), 23 deletions(-) diff --git a/

Re: [PATCH 11/13] drm/edid: introduce a helper that compares edid data from two drm_edid

2025-04-17 Thread Melissa Wen
On 14/04/2025 07:06, Jani Nikula wrote: On Fri, 11 Apr 2025, Melissa Wen wrote: AMD driver has a function used to compare if two edid are the same; this is useful to some of the link detection algorithms implemented by amdgpu. Since the amdgpu function can be helpful for other drivers, this

Re: [PATCH v2 08/34] drm/msm: Remove vram carveout support

2025-04-17 Thread Luca Weiss
On Thu Apr 17, 2025 at 1:20 AM CEST, Dmitry Baryshkov wrote: > On Wed, Mar 19, 2025 at 07:52:20AM -0700, Rob Clark wrote: >> From: Rob Clark >> >> It is standing in the way of drm_gpuvm / VM_BIND support. Not to >> mention frequently broken and rarely tested. And I think only needed >> for a 10

Re: [PATCH 2/2] drm/panthor: Fix the user MMIO offset logic for emulators

2025-04-17 Thread Boris Brezillon
On Thu, 17 Apr 2025 14:10:31 +0200 Boris Brezillon wrote: > > I can't help feeling we can just simplify this to: > > > > u64 mmio_offset = pfile->user_mmio.offset; > > > > if (offset >= mmio_offset) { > > offset -= mmio_offset; > > offset += DRM_PANTHOR_USER_MMIO

Re: [PATCH 2/2] drm/panthor: Fix the user MMIO offset logic for emulators

2025-04-17 Thread Liviu Dudau
On Thu, Apr 17, 2025 at 02:16:11PM +0200, Boris Brezillon wrote: > On Thu, 17 Apr 2025 12:33:01 +0100 > Liviu Dudau wrote: > > > On Thu, Apr 17, 2025 at 11:41:18AM +0100, Steven Price wrote: > > > On 17/04/2025 11:05, Boris Brezillon wrote: > > > > Currently, we pick the MMIO offset based on th

  1   2   3   >