[PATCH] (drm/rockchip): Consistently use rk3399 registers consts

2025-04-02 Thread Konstantin Shabanov
As rk3399 has its own registers definitions, update related structs to use them. There are no changes in behaviour as updated constants values are the same for rk3288/rk3368/rk3399 chips. Signed-off-by: Konstantin Shabanov --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 94 ++--

Re: [PATCH v3 2/7] dt-bindings: display: rockchip,inno-hdmi: Document GRF for RK3036 HDMI

2025-04-02 Thread Krzysztof Kozlowski
On Wed, Apr 02, 2025 at 08:31:36PM +0800, Andy Yan wrote: > From: Andy Yan > > HDMI on RK3036 use GRF control the HSYNC/VSYNC polarity, but this part > is missing when it first landing upstream. > > Document that it is mandatory for RK3036 HDMI. > > Signed-off-by: Andy Yan > > --- > > (no ch

Re: [PATCH v1 3/3] drm/ci: uprev mesa

2025-04-02 Thread Vignesh Raman
Hi Daniel, On 28/03/25 17:29, Vignesh Raman wrote: Hi Daniel, On 28/03/25 17:06, Daniel Stone wrote: Hi Vignesh, On Fri, 28 Mar 2025 at 11:03, Vignesh Raman wrote: The current s3cp implementation does not work anymore after the migration, and instead of fixing it and propagating the fix do

[PATCH v2 1/3] drm/panfrost: Add PM runtime flag

2025-04-02 Thread Philippe Simons
When the GPU is the only device attached to a single power domain, core genpd disable and enable it when gpu enter and leave runtime suspend. Some power-domain requires a sequence before disabled, and the reverse when enabled. Add GPU_PM_RT flag, and implement in panfrost_device_runtime_suspend/r

[PATCH v2 0/3] drm/panfrost: enable G31 on H616

2025-04-02 Thread Philippe Simons
Allwinner H616 has a dedicated power domain for its Mali G31. Currently after probe, the GPU is put in runtime suspend which disable the power domain. On first usage of GPU, the power domain enable hangs the system. This series adds the necessary calls to enable the clocks and deasserting the re

[PATCH v2 3/3] drm/panfrost: reorder pd/clk/rst sequence

2025-04-02 Thread Philippe Simons
According to Mali manuals, the powerup sequence should be enable pd, asserting the reset then enabling the clock and the reverse for powerdown. Signed-off-by: Philippe Simons --- drivers/gpu/drm/panfrost/panfrost_device.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletion

[PATCH v2 2/3] drm/panfrost: add h616 compatible string

2025-04-02 Thread Philippe Simons
Tie the Allwinner compatible string to the GPU_PM_RT feature bits that will toggle the clocks and the reset line whenever the power domain is changing state. Signed-off-by: Philippe Simons --- drivers/gpu/drm/panfrost/panfrost_drv.c | 8 1 file changed, 8 insertions(+) diff --git a/dri

[PATCH v3 1/9] dt-bindings: display: rockchip: Add schema for RK3588 DPTX Controller

2025-04-02 Thread Andy Yan
From: Andy Yan The Rockchip RK3588 SoC integrates the Synopsys DesignWare DPTX controller. And this DPTX controller need share a USBDP PHY with the USB 3.0 OTG controller during operation. Signed-off-by: Andy Yan Reviewed-by: Rob Herring (Arm) --- (no changes since v2) Changes in v2: - Link

Re: [PATCH v2 1/9] 9p: Add a migrate_folio method

2025-04-02 Thread Matthew Wilcox
On Thu, Apr 03, 2025 at 12:46:17PM +0900, Dominique Martinet wrote: > Matthew Wilcox (Oracle) wrote on Wed, Apr 02, 2025 at 03:59:55PM +0100: > > The migration code used to be able to migrate dirty 9p folios by writing > > them back using writepage. When the writepage method was removed, > > we ne

[PATCH v3 5/9] drm/birdge: simple-bridge: Add support for radxa ra620

2025-04-02 Thread Andy Yan
From: Andy Yan The RA620 is an active DP to HDMI converter chip, basically no software is involved to drive it. Add it to simple bridge to make it can be find by the drm bridge chain. Signed-off-by: Andy Yan --- Changes in v3: - First introduced in this version. drivers/gpu/drm/bridge/simp

Re: [PATCH v16 3/5] drm/xe/uapi: Define drm_xe_vm_get_property

2025-04-02 Thread Jianxun Zhang
On 4/2/25 18:19, Jianxun Zhang wrote: On 4/1/25 15:26, Jonathan Cavitt wrote: Add initial declarations for the drm_xe_vm_get_property ioctl. v2: - Expand kernel docs for drm_xe_vm_get_property (Jianxun) v3: - Remove address type external definitions (Jianxun) - Add fault type to xe_drm_fa

Re: [PATCH v2 1/9] 9p: Add a migrate_folio method

2025-04-02 Thread Dominique Martinet
Matthew Wilcox (Oracle) wrote on Wed, Apr 02, 2025 at 03:59:55PM +0100: > The migration code used to be able to migrate dirty 9p folios by writing > them back using writepage. When the writepage method was removed, > we neglected to add a migrate_folio method, which means that dirty 9p > folios ha

[PATCH v3 8/9] arm64: dts: rockchip: Enable DisplayPort for rk3588s Cool Pi 4B

2025-04-02 Thread Andy Yan
From: Andy Yan Enable the Mini DisplayPort on this board. Note that ROCKCHIP_VOP2_EP_DP0 is defined as 10 in dt-binding header, but it will trigger a dtc warning like "graph node unit address error, expected "a"" if we use it directly after endpoint, so we use "a" instead here. Signed-off-by: A

[PATCH v3 2/9] drm/bridge: synopsys: Add DW DPTX Controller support library

2025-04-02 Thread Andy Yan
From: Andy Yan The DW DP TX Controller is compliant with the DisplayPort Specification Version 1.4 with the following features: * DisplayPort 1.4a * Main Link: 1/2/4 lanes * Main Link Support 1.62Gbps, 2.7Gbps, 5.4Gbps and 8.1Gbps * AUX channel 1Mbps * Single Stream Transport(SST) * Multistream

[PATCH v3 4/9] dt-bindings: display: simple-bridge: Add ra620 compatible

2025-04-02 Thread Andy Yan
From: Andy Yan RA620 is a DP to HDMI bridge converter from RADXA, which first found be used on ROCK 5 ITX. This chip can be used without involving software. Signed-off-by: Andy Yan --- Changes in v3: - First introduced in this version. .../devicetree/bindings/display/bridge/simple-bridge.y

[PATCH v3 7/9] arm64: dts: rockchip: Add DP1 for rk3588

2025-04-02 Thread Andy Yan
From: Andy Yan The DP1 is compliant with the DisplayPort Specification Version 1.4, and share the USBDP combo PHY1 with USB 3.1 HOST1 controller. Signed-off-by: Andy Yan --- (no changes since v1) .../arm64/boot/dts/rockchip/rk3588-extra.dtsi | 30 +++ 1 file changed, 30 inser

[PATCH v3 3/9] drm/rockchip: Add RK3588 DPTX output support

2025-04-02 Thread Andy Yan
From: Andy Yan Add driver extension for Synopsys DesignWare DPTX IP used on Rockchip RK3588 SoC. Signed-off-by: Andy Yan Acked-by: Dmitry Baryshkov --- (no changes since v2) Changes in v2: - no include uapi path - switch to drmm_encoder_init drivers/gpu/drm/rockchip/Kconfig|

Re: [PATCH v2 7/7] drm/virtio: implement userptr: add interval tree

2025-04-02 Thread Huang, Honglei1
Hi Dmitry: Really sorry for missed this comment. Yes it can be done in UMD, actually the interval tree is used with the MMU notifier normally, it is for preventing create same MMU notifier for overlapped areas. Cause this version patch set doesn't have MMU notifier, removing interval tree is

Re: [PATCH v16 3/5] drm/xe/uapi: Define drm_xe_vm_get_property

2025-04-02 Thread Jianxun Zhang
On 4/1/25 15:26, Jonathan Cavitt wrote: Add initial declarations for the drm_xe_vm_get_property ioctl. v2: - Expand kernel docs for drm_xe_vm_get_property (Jianxun) v3: - Remove address type external definitions (Jianxun) - Add fault type to xe_drm_fault struct (Jianxun) v4: - Remove engine

Re: [PATCH v20 00/10] Add generic DRM-shmem memory shrinker (part 1)

2025-04-02 Thread Lucas De Marchi
On Sun, Mar 23, 2025 at 12:25:58AM +0300, Dmitry Osipenko wrote: Hi, This a continuation of a year-old series that adds generic DRM-shmem shrinker [1]. The old series became too big with too many patches, more reasonable to split it up into multiple smaller patchsets. Here is the firtst part tha

[PATCH v2 2/9] vboxsf: Convert to writepages

2025-04-02 Thread Matthew Wilcox (Oracle)
If we add a migrate_folio operation, we can convert the writepage operation to writepages. Further, this lets us optimise by using the same write handle for multiple folios. The large folio support here is illusory; we would need to kmap each page in turn for proper support. But we do remove a fe

Re:[PATCH] drm/bridge: dw-hdmi: Avoid including uapi headers

2025-04-02 Thread Andy Yan
Gentle ping.. At 2025-03-14 15:57:47, "Andy Yan" wrote: >From: Andy Yan > >It is not recommended for drivers to include UAPI header >directly. > >Signed-off-by: Andy Yan >--- > > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff

[PATCH v2 3/9] migrate: Remove call to ->writepage

2025-04-02 Thread Matthew Wilcox (Oracle)
The writepage callback is going away; filesystems must implement migrate_folio or else dirty folios will not be migratable. Signed-off-by: Matthew Wilcox (Oracle) --- mm/migrate.c | 60 ++-- 1 file changed, 7 insertions(+), 53 deletions(-) diff --

Re: [PATCH v16 3/5] drm/xe/uapi: Define drm_xe_vm_get_property

2025-04-02 Thread ivan.briano
On Tue, Apr 01, 2025 at 10:26:54PM +, Jonathan Cavitt wrote: > +/** struct xe_vm_fault - Describes faults for %DRM_XE_VM_GET_PROPERTY_FAULTS > */ > +struct xe_vm_fault { > + /** @address: Address of the fault */ > + __u64 address; > + /** @address_precision: Precision of faulted ad

Re: [PATCH] drm/imagination: take paired job reference

2025-04-02 Thread Matt Coster
On Tue, 18 Mar 2025 14:53:13 +, Brendan King wrote: > For paired jobs, have the fragment job take a reference on the > geometry job, so that the geometry job cannot be freed until > the fragment job has finished with it. > > The geometry job structure is accessed when the fragment job is bei

[PATCH][next] drm/nouveau: svm: Avoid -Wflex-array-member-not-at-end warning

2025-04-02 Thread Gustavo A. R. Silva
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a flexible structure where the size of the flexible-array member is known at compile-time, and refactor the rest of the code, a

[PATCH][next] drm/nouveau: fence: Avoid -Wflex-array-member-not-at-end warning

2025-04-02 Thread Gustavo A. R. Silva
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a flexible structure where the size of the flexible-array member is known at compile-time, and refactor the rest of the code, a

Re: [PATCH 07/30] panel/ilitek-ili9341: Use refcounted allocation in place of devm_kzalloc()

2025-04-02 Thread Ondřej Jirman
Hi Anusha, On Wed, Apr 02, 2025 at 11:23:45AM -0400, Anusha Srivatsa wrote: > Move to using the new API devm_drm_panel_alloc() to allocate the > panel. > > Signed-off-by: Anusha Srivatsa > --- > drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 8 +--- > 1 file changed, 5 insertions(+), 3 dele

Re: [PATCH v3 7/7] drm/rockchip: inno-hdmi: Convert to drm bridge

2025-04-02 Thread Alex Bee
Hi Andy, From: Andy Yan Convert it to drm bridge driver, it will be convenient for us to migrate the connector part to the display driver later. Signed-off-by: Andy Yan --- Changes in v3: - First included in v3 - Link to V2: https://lore.kernel.org/dri-devel/20250325132944.17-1-andy

[PATCH v3 13/54] dyndbg, module: make proper substructs in _ddebug_info

2025-04-02 Thread Jim Cromie
recompose struct _ddebug_info, inserting proper sub-structs. The struct currently has 2 pairs of fields: descs, num_descs and classes, num_classes. Several for-loops operate on these field pairs, soon many more will be added. Looping over these blocks by respective field-pairs is repetitive and

2025 X.Org Board of Directors Elections Nomination period is NOW OPEN

2025-04-02 Thread Mark Filion
Hello! We are seeking nominations for candidates for election to the X.Org Foundation Board of Directors. All X.Org Foundation members are eligible for election to the board. Nominations for the 2025 election are now open and will remain open until 23:59 UTC on 16 April 2025. The Board consists

Re: [BUG] drm_connector reference counting and USB-C docks

2025-04-02 Thread Mario Limonciello
On 3/23/2025 8:09 PM, Chris Bainbridge wrote: There is a reference couting / lifecycle issue with drm_connector when used with a USB-C dock. The problem has been previously reproduced on both Intel and AMD GPUs. On both Intel and AMD, the symptoms are: - multiple connectors being listed in s

[PATCH 12/30] panel/innolux-p079zca: Use refcounted allocation in place of devm_kzalloc()

2025-04-02 Thread Anusha Srivatsa
Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-innolux-p079zca.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-innolux-p079zca.c b/drivers/gpu/dr

Re: [PATCH v5 3/3] arm64: dts: qcom: x1e78100-t14s-oled: add edp panel

2025-04-02 Thread Dmitry Baryshkov
On Wed, Apr 02, 2025 at 03:36:34PM +0100, Christopher Obbard wrote: > Add the Samsung ATNA40YK20 eDP panel to the device tree for the > Snapdragon T14s OLED model. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Christopher Obbard > --- > arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14

Re: [PATCH v5 2/3] arm64: dts: qcom: x1e78100-t14s: add hpd gpio to dp controller

2025-04-02 Thread Dmitry Baryshkov
On Wed, Apr 02, 2025 at 03:36:33PM +0100, Christopher Obbard wrote: > The eDP controller has an HPD GPIO. Describe it in the device tree > for the generic T14s model, as the HPD GPIO is used in both the > OLED and LCD models which inherit this device tree. > > Signed-off-by: Christopher Obbard >

Re: [PATCH v5 1/3] arm64: dts: qcom: x1e80100: add epd hpd pinctrl

2025-04-02 Thread Dmitry Baryshkov
On Wed, Apr 02, 2025 at 03:36:32PM +0100, Christopher Obbard wrote: > Add edp_hpd_active pinctrl to the X1E80100 device tree. > > Signed-off-by: Christopher Obbard > --- > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Dmitry Baryshkov -- Wit

[PATCH v3 12/54] dyndbg: macrofy a 2-index for-loop pattern

2025-04-02 Thread Jim Cromie
dynamic-debug has several __sections, each with , num_, and it iterates over these with a 2-index for-loop. These loops are fiddly with the 2 names. We have only 2 such loops now, but are getting more soon; lets embed/abstract the fiddlyness in the for_subvec() macro, and avoid repeating it going

[PATCH v3 25/54] selftests-dyndbg: add test_mod_submod

2025-04-02 Thread Jim Cromie
This new test-fn runs 3 module/submodule modprobe scenarios, variously using both the generic dyndbg= modprobe arg, and the test-module's classmap-params to manipulate the test-mod*'s pr_debugs. In all cases, the current flag-settings are counted and tested vs expectations. The 3rd scenario recapi

[PATCH v3 53/54] drm: restore CONFIG_DRM_USE_DYNAMIC_DEBUG un-BROKEN

2025-04-02 Thread Jim Cromie
Time for some thorough CI. Also, the previous 18 patches could perhaps be replaced by a single invocation of DYNDBG_CLASSMAP_USE, from a C-file linked into all drm drivers & helpers. I didn't find such a file, nor a drm-client linkage item in the Makefile. Signed-off-by: Jim Cromie --- drivers

[PATCH v3 17/54] dyndbg-API: replace DECLARE_DYNDBG_CLASSMAP

2025-04-02 Thread Jim Cromie
DECLARE_DYNDBG_CLASSMAP() has a design error; its usage fails a basic K&R rule: "define once, refer many times". When DRM_USE_DYNAMIC_DEBUG=y, it is used across DRM core & drivers; each invocation allocates/inits the classmap understood by that module. All must match for the modules to respond to

[PATCH v3 15/54] dyndbg: ddebug_table.mod_name down to _ddebug_info

2025-04-02 Thread Jim Cromie
struct _ddebug_info already has most of dyndbg's info for a module; push debug_table.mod_name down into it, finishing the encapsulation. This allows refactoring several callchains, passing &_ddebug_info instead of &ddebug_table, and hoisting the "&dt->info" deref up. ddebug_table contains a _ddeb

[PATCH v3 51/54] drm-dyndbg: add DRM_CLASSMAP_USE to the qxl driver

2025-04-02 Thread Jim Cromie
The qxl driver has a number of DRM_UT_* debugs, make them controllable when CONFIG_DRM_USE_DYNAMIC_DEBUG=y by telling dyndbg that the module uses them. Signed-off-by: Jim Cromie --- drivers/gpu/drm/qxl/qxl_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/qxl/qxl_drv.c

Re: [PATCH v2 7/7] drm/virtio: implement userptr: add interval tree

2025-04-02 Thread Demi Marie Obenour
On 4/2/25 8:34 AM, Dmitry Osipenko wrote: > On 4/2/25 04:53, Huang, Honglei1 wrote: >> >> On 2025/3/30 19:57, Dmitry Osipenko wrote: >>> If the purpose of this feature is to dedup usrptr BOs of a the single >>> process/application, can this can be done in userspace? > > I assume it can be done in

[PATCH v3 45/54] drm-dyndbg: add DRM_CLASSMAP_USE to radeon

2025-04-02 Thread Jim Cromie
radeon has some DRM_UT_* debugs, make them controllable when CONFIG_DRM_USE_DYNAMIC_DEBUG=y by telling dyndbg about its use of the class'd debugs. Signed-off-by: Jim Cromie --- drivers/gpu/drm/radeon/radeon_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/radeon/radeon

[PATCH v3 00/54] Fix CONFIG_DRM_USE_DYNAMIC_DEBUG=y

2025-04-02 Thread Jim Cromie
This series fixes dynamic-debug's support for DRM debug-categories. Classmaps-v1 evaded full review, and got committed in 2 chunks: b7b4eebdba7b..6ea3bf466ac6# core dyndbg changes 0406faf25fb1..ee7d633f2dfb# drm adoption Then DRM-CI found a regression when booting with drm.debug=; t

[PATCH v3 44/54] drm-dyndbg: add DRM_CLASSMAP_USE to gma500 driver

2025-04-02 Thread Jim Cromie
The gma500 has 126 DRM_UT_* debugs, make them controllable when CONFIG_DRM_USE_DYNAMIC_DEBUG=y by telling dyndbg that the module has class'd debugs. Signed-off-by: Jim Cromie --- drivers/gpu/drm/gma500/psb_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/gma500/psb_drv

[PATCH v3 47/54] drm-dyndbg: add DRM_CLASSMAP_USE to vkms driver

2025-04-02 Thread Jim Cromie
The vkms driver has a number of DRM_UT_* debugs, make them controllable when CONFIG_DRM_USE_DYNAMIC_DEBUG=y by telling dyndbg that the module uses them. Signed-off-by: Jim Cromie --- drivers/gpu/drm/vkms/vkms_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/vkms/vkms_d

Re: [PATCH v2 2/2] drm/virtio: add VIRTGPU_PARAM_HOST_PAGE_SIZE to params

2025-04-02 Thread Dmitry Osipenko
On 4/2/25 20:46, Sergio Lopez wrote: > diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c > b/drivers/gpu/drm/virtio/virtgpu_ioctl.c > index > c33c057365f85a2ace536f91655c903036827312..405203b3c3847a8b318a7118aa34356c839d249e > 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_ioctl.c > +++ b/drive

Re: [PATCH v2 1/2] drm/virtio: introduce the HOST_PAGE_SIZE feature

2025-04-02 Thread Dmitry Osipenko
On 4/2/25 20:46, Sergio Lopez wrote: > diff --git a/include/uapi/linux/virtio_gpu.h b/include/uapi/linux/virtio_gpu.h > index > bf2c9cabd20793e3851e749baadf210341445501..adc264df4e458e9c754936c3015c069e5ee6b899 > 100644 > --- a/include/uapi/linux/virtio_gpu.h > +++ b/include/uapi/linux/virtio_gpu

[PATCH v2 2/2] drm/virtio: add VIRTGPU_PARAM_HOST_PAGE_SIZE to params

2025-04-02 Thread Sergio Lopez
Add VIRTGPU_PARAM_HOST_PAGE_SIZE as a param that can be read with VIRTGPU_GETPARAM by userspace applications running in the guest to obtain the host's page size and find out the right alignment to be used in shared memory allocations. Signed-off-by: Sergio Lopez --- drivers/gpu/drm/virtio/virtgp

[PATCH v2 0/2] drm/virtio: introduce the HOST_PAGE_SIZE feature

2025-04-02 Thread Sergio Lopez
6 files changed, 24 insertions(+), 3 deletions(-) --- base-commit: acc4d5ff0b61eb1715c498b6536c38c1feb7f3c1 change-id: 20250402-virtio-gpu-host-page-size-282c99dfe44c Best regards, -- Sergio Lopez

[PATCH v3 49/54] drm-dyndbg: add DRM_CLASSMAP_USE to mgag200 driver

2025-04-02 Thread Jim Cromie
The mgag200 driver has a number of DRM_UT_* debugs, make them controllable when CONFIG_DRM_USE_DYNAMIC_DEBUG=y by telling dyndbg that the module uses them. Signed-off-by: Jim Cromie --- drivers/gpu/drm/mgag200/mgag200_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mg

[PATCH v3 46/54] drm-dyndbg: add DRM_CLASSMAP_USE to vmwgfx driver

2025-04-02 Thread Jim Cromie
The vmwgfx driver has a number of DRM_UT_* debugs, make them controllable when CONFIG_DRM_USE_DYNAMIC_DEBUG=y by telling dyndbg that the module uses them. Signed-off-by: Jim Cromie --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/vmwgf

[PATCH v3 52/54] drm-dyndbg: add DRM_CLASSMAP_USE to the drm_gem_shmem_helper driver

2025-04-02 Thread Jim Cromie
The drm_gem_shmem_helper driver has a number of DRM_UT_* debugs, make them controllable when CONFIG_DRM_USE_DYNAMIC_DEBUG=y by telling dyndbg that the module uses them. Signed-off-by: Jim Cromie --- drivers/gpu/drm/drm_gem_shmem_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/driver

[PATCH v3 54/54] drm: RFC - make drm_dyndbg_user.o for drm-*_helpers, drivers

2025-04-02 Thread Jim Cromie
Add new drm_dyndbg_user.c with a single call to DYNDBG_CLASSMAP_USE(drm_debug_classes). This creates a _class_user record (and a linkage dependency). If a driver adds this object to its Makefile target, it gets the record, which authorizes dyndbg to enable the module's class'd pr_debugs, such as

[PATCH v3 37/54] drm-dyndbg: DRM_CLASSMAP_USE in drm_dp_helper

2025-04-02 Thread Jim Cromie
Following the dyndbg-api-fix, replace DECLARE_DYNDBG_CLASSMAP with DRM_CLASSMAP_USE. This refs the defined & exported classmap, rather than re-declaring it redundantly, and error-prone-ly. This resolves the appearance of "class:_UNKNOWN_" in the control file for the driver's drm_dbg()s. Fixes: f

[PATCH v3 50/54] drm-dyndbg: add DRM_CLASSMAP_USE to the gud driver

2025-04-02 Thread Jim Cromie
The gud driver has a number of DRM_UT_* debugs, make them controllable when CONFIG_DRM_USE_DYNAMIC_DEBUG=y by telling dyndbg that the module uses them. Signed-off-by: Jim Cromie --- drivers/gpu/drm/gud/gud_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/gud/gud_drv.c

[PATCH v3 48/54] drm-dyndbg: add DRM_CLASSMAP_USE to udl driver

2025-04-02 Thread Jim Cromie
The udl driver has a number of DRM_UT_* debugs, make them controllable when CONFIG_DRM_USE_DYNAMIC_DEBUG=y by telling dyndbg that the module uses them. Signed-off-by: Jim Cromie --- drivers/gpu/drm/udl/udl_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/udl/udl_main.

[PATCH v3 23/54] dyndbg: treat comma as a token separator

2025-04-02 Thread Jim Cromie
Treat comma as a token terminator, just like a space. This allows a user to avoid quoting hassles when spaces are otherwise needed: :#> modprobe drm dyndbg=class,DRM_UT_CORE,+p\;class,DRM_UT_KMS,+p or as a boot arg: drm.dyndbg=class,DRM_UT_CORE,+p # todo: support multi-query here Given the

[PATCH v3 43/54] drm-dyndbg: add DRM_CLASSMAP_USE to etnaviv

2025-04-02 Thread Jim Cromie
etnaviv has 5 DRM_UT_CORE debugs, make them controllable when CONFIG_DRM_USE_DYNAMIC_DEBUG=y by telling dyndbg that the module has class'd debugs as well as plain-old pr_debug()s Signed-off-by: Jim Cromie --- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --g

[PATCH v3 36/54] drm-dyndbg: DRM_CLASSMAP_USE in drm_crtc_helper

2025-04-02 Thread Jim Cromie
Following the dyndbg-api-fix, replace DECLARE_DYNDBG_CLASSMAP with DRM_CLASSMAP_USE. This refs the defined & exported classmap, rather than re-declaring it redundantly, and error-prone-ly. This resolves the appearance of "class:_UNKNOWN_" in the control file for the driver's drm_dbg()s. Fixes: f

[PATCH v3 27/54] dyndbg: drop "protection" of class'd pr_debugs from legacy queries

2025-04-02 Thread Jim Cromie
Current classmap code protects class'd pr_debugs from unintended changes by "legacy" unclassed queries: # this doesn't disable all of DRM_UT_* categories echo "-p" > /proc/dynamic_debug/control # name the class to change it - protective but tedious echo "class DRM_UT_CORE +p" > /proc/dyna

[PATCH v3 34/54] drm-dyndbg: DRM_CLASSMAP_USE in amdgpu driver

2025-04-02 Thread Jim Cromie
Following the dyndbg-api-fix, replace DECLARE_DYNDBG_CLASSMAP with DRM_CLASSMAP_USE. This refs the defined & exported classmap, rather than re-declaring it redundantly, and error-prone-ly. This resolves the appearance of "class:_UNKNOWN_" in the control file for the driver's drm_dbg()s. Fixes: f

[PATCH v3 33/54] drm-print: fix config-dependent unused variable

2025-04-02 Thread Jim Cromie
With CONFIG_DRM_USE_DYNAMIC_DEBUG=y, __drm_printfn_dbg() gets an unused variable warning/error on 'category', even though the usage follows immediately, in drm_debug_enabled(category). For static-key optimized dyndbg, the macro doesn't actually check the category var, since the static-key patches

[PATCH v3 08/54] dyndbg: reduce verbose/debug clutter

2025-04-02 Thread Jim Cromie
currently, for verbose=3, these are logged (blank lines for clarity): dyndbg: query 0: "class DRM_UT_CORE +p" mod:* dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op='+' dyndbg: flags=0x1 dyndbg: *flagsp=0x1 *maskp=0x dyndbg: parsed: func="" file="" module="" format="

[PATCH v3 24/54] dyndbg: split multi-query strings with %

2025-04-02 Thread Jim Cromie
Since commit 85f7f6c0edb8 ("dynamic_debug: process multiple debug-queries on a line") Multi-query commands have been allowed: modprobe drm dyndbg="class DRM_UT_CORE +p; class DRM_UT_KMS +p" modprobe drm dyndbg=< [ 203.902703] dyndbg: query parse failed [ 203.902871] dyndbg: processed 2 quer

[PATCH v3 19/54] dyndbg: detect class_id reservation conflicts

2025-04-02 Thread Jim Cromie
If a module _DEFINEs + _USEs 2 or more classmaps, it must devise them to share the per-module 0..62 class-id space; ie their respective base,+length reservations cannot overlap. To detect conflicts at modprobe, add ddebug_class_range_overlap(), call it from ddebug_add_module(), and WARN and return

[PATCH v3 26/54] dyndbg: change __dynamic_func_call_cls* macros into expressions

2025-04-02 Thread Jim Cromie
The Xe driver's XE_IOCTL_DBG macro calls drm_dbg() from inside an if (expression). This breaks when CONFIG_DRM_USE_DYNAMIC_DEBUG=y because the invoked macro has a do-while-0 wrapper. if (cond && (drm_dbg("expr-form"),1)) { ... do some more stuff } Fix for this usage by changing __dyn

[PATCH v3 21/54] dyndbg-test: change do_prints testpoint to accept a loopct

2025-04-02 Thread Jim Cromie
echo 1000 > /sys/module/test_dynamic_debug/parameters/do_prints This allows its use as a scriptable load generator, to generate dynamic-prefix-emits for flag combinations vs undecorated messages. This will make it easy to assess the cost of the prefixing. Reading the ./do_prints node also prints

[PATCH v3 22/54] dyndbg-API: promote DYNAMIC_DEBUG_CLASSMAP_PARAM to API

2025-04-02 Thread Jim Cromie
move the DYNAMIC_DEBUG_CLASSMAP_PARAM macro from test-dynamic-debug.c into the header, and refine it, by distinguishing the 2 use cases: 1.DYNAMIC_DEBUG_CLASSMAP_PARAM_REF for DRM, to pass in extern __drm_debug by name. dyndbg keeps bits in it, so drm can still use it as before 2.DYNAMIC_

[PATCH v3 09/54] dyndbg: refactor param_set_dyndbg_classes and below

2025-04-02 Thread Jim Cromie
Refactor callchain below param_set_dyndbg_classes(1) to allow mod-name specific settings. Split (1) into upper/lower fns, adding modname param to lower, and passing NULL in from upper. Below that, add the same param to ddebug_apply_class_bitmap(), and pass it thru to _ddebug_queries(), replacing

[PATCH v3 11/54] dyndbg: replace classmap list with a vector

2025-04-02 Thread Jim Cromie
Classmaps are stored in an elf section/array, but currently are individually list-linked onto dyndbg's per-module ddebug_table for operation. This is unnecessary. Just like dyndbg's descriptors, classes are packed in compile order; so even with many builtin modules employing multiple classmaps, ea

[PATCH v3 07/54] dyndbg: drop NUM_TYPE_ARRAY

2025-04-02 Thread Jim Cromie
ARRAY_SIZE works here, since array decl is complete. no functional change Signed-off-by: Jim Cromie Reviewed-by: Louis Chauvet --- include/linux/dynamic_debug.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h

[PATCH v3 03/54] docs/dyndbg: explain flags parse 1st

2025-04-02 Thread Jim Cromie
When writing queries to >control, flags are parsed 1st, since they are the only required field, and they require specific compositions. So if the flags draw an error (on those specifics), then keyword errors aren't reported. This can be mildly confusing/annoying, so explain it instead. cc: linux

[PATCH v3 06/54] dyndbg: make ddebug_class_param union members same size

2025-04-02 Thread Jim Cromie
struct ddebug_class_param keeps a ref to the state-storage of the param; make both class-types use the same unsigned long storage type. ISTM this is simpler and safer; it avoids an irrelevant difference, and if 2 users somehow get class-type mixed up (or refer to the wrong union member), at least

[PATCH] drm/i915/huc: Fix fence not released on early probe errors

2025-04-02 Thread Janusz Krzysztofik
HuC delayed loading fence, introduced with commit 27536e03271da ("drm/i915/huc: track delayed HuC load with a fence"), is registered with object tracker early on driver probe but unregistered only from driver remove, which is not called on early probe errors. Since its memory is allocated under de

[PATCH 19/30] panel/magnachip-d53e6ea8966: Use refcounted allocation in place of devm_kzalloc()

2025-04-02 Thread Anusha Srivatsa
Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-magnachip-d53e6ea8966.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-magnachip-d53e6ea8966.c b/dr

[PATCH 27/30] panel/novatek-nt36672e: Use refcounted allocation in place of devm_kzalloc()

2025-04-02 Thread Anusha Srivatsa
Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-novatek-nt36672e.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672e.c b/drivers/gpu/d

[PATCH 14/30] panel/jdi-fhd-r63452: Use refcounted allocation in place of devm_kzalloc()

2025-04-02 Thread Anusha Srivatsa
Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c b/drivers/gpu/drm/p

Re: [git pull] drm for 6.15-rc1

2025-04-02 Thread Jason Gunthorpe
On Wed, Apr 02, 2025 at 04:41:44PM +0200, Simona Vetter wrote: > - Gradually roll this out, ideally with support in main Kbuild so it > doesn't have to be replicated. No one said flag day, you'd have to approach the same way everyone else has done when adding new compiler errors and warnings to

Re: [PATCH 00/10] drm/panel: Use refcounted allocation in place of devm_kzalloc()

2025-04-02 Thread Anusha Srivatsa
On Wed, Apr 2, 2025 at 10:24 AM Neil Armstrong wrote: > On 01/04/2025 18:03, Anusha Srivatsa wrote: > > Start converting drivers to use the API - devm_drm_panel_alloc(). > > > > This series addresses only 10 drivers. There are 98 more to go. Sending > this > > series to mostly get feedback. if an

[PATCH 30/30] panel/orisetech-ota5601a: Use refcounted allocation in place of devm_kzalloc()

2025-04-02 Thread Anusha Srivatsa
Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-orisetech-ota5601a.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-orisetech-ota5601a.c b/drivers/

[PATCH 29/30] panel/lcd-olinuxino: Use refcounted allocation in place of devm_kzalloc()

2025-04-02 Thread Anusha Srivatsa
Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c b/driv

[PATCH 28/30] panel/novatek-nt39016: Use refcounted allocation in place of devm_kzalloc()

2025-04-02 Thread Anusha Srivatsa
Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-novatek-nt39016.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt39016.c b/drivers/gpu/drm

[PATCH 18/30] panel/lincolntech-lcd197: Use refcounted allocation in place of devm_kzalloc()

2025-04-02 Thread Anusha Srivatsa
Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-lincolntech-lcd197.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-lincolntech-lcd197.c b/drivers/

[PATCH 22/30] panel/newvision-nv3052c: Use refcounted allocation in place of devm_kzalloc()

2025-04-02 Thread Anusha Srivatsa
Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-newvision-nv3052c.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c b/drivers/gpu

[PATCH 23/30] panel/novatek-nt35510: Use refcounted allocation in place of devm_kzalloc()

2025-04-02 Thread Anusha Srivatsa
Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-novatek-nt35510.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt35510.c b/drivers/gpu/d

[PATCH 25/30] panel/novatek-nt35950: Use refcounted allocation in place of devm_kzalloc()

2025-04-02 Thread Anusha Srivatsa
Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-novatek-nt35950.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt35950.c b/drivers/gpu/drm

[PATCH 26/30] panel/novatek-nt36523: Use refcounted allocation in place of devm_kzalloc()

2025-04-02 Thread Anusha Srivatsa
Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-novatek-nt36523.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36523.c b/drivers/gpu/drm/p

[PATCH 24/30] panel/novatek-nt35560: Use refcounted allocation in place of devm_kzalloc()

2025-04-02 Thread Anusha Srivatsa
Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-novatek-nt35560.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt35560.c b/drivers/gpu/d

[PATCH 21/30] panel/newvision-nv3051d: Use refcounted allocation in place of devm_kzalloc()

2025-04-02 Thread Anusha Srivatsa
Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-newvision-nv3051d.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3051d.c b/drivers/gp

[PATCH 13/30] panel/jadard-jd9365da-h3: Use refcounted allocation in place of devm_kzalloc()

2025-04-02 Thread Anusha Srivatsa
Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c b/drivers/g

[PATCH 10/30] panel/ilitek-ili9881c: Use refcounted allocation in place of devm_kzalloc()

2025-04-02 Thread Anusha Srivatsa
Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/dr

[PATCH 06/30] panel/ilitek-ili9322: Use refcounted allocation in place of devm_kzalloc()

2025-04-02 Thread Anusha Srivatsa
Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-ilitek-ili9322.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9322.c b/drivers/gpu/drm/p

[PATCH 05/30] panel/himax-hx8394: Use refcounted allocation in place of devm_kzalloc()

2025-04-02 Thread Anusha Srivatsa
Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-himax-hx8394.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-himax-hx8394.c b/drivers/gpu/drm/pane

[PATCH 03/30] panel/fy07024di26a30d: Use refcounted allocation in place of devm_kzalloc()

2025-04-02 Thread Anusha Srivatsa
Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c b

[PATCH 01/30] panel/panel-elida-kd35t133: Refcounted allocation

2025-04-02 Thread Anusha Srivatsa
Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-elida-kd35t133.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-elida-kd35t133.c b/drivers/gpu/drm/p

[PATCH 02/30] panel/elida-kd35t133: Use refcounted allocation in place of devm_kzalloc()

2025-04-02 Thread Anusha Srivatsa
Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c b/driver

Re: [git pull] drm for 6.15-rc1

2025-04-02 Thread Jani Nikula
On Wed, 02 Apr 2025, Jason Gunthorpe wrote: > On Wed, Apr 02, 2025 at 03:56:37PM +0300, Jani Nikula wrote: >> On Tue, 01 Apr 2025, Jason Gunthorpe wrote: >> > On Tue, Apr 01, 2025 at 10:42:35PM +0300, Jani Nikula wrote: >> >> On Tue, 01 Apr 2025, Jason Gunthorpe wrote: >> >> > So, I'd suggest a

[PATCH v2 05/18] phy: cdns-dphy: Remove leftover code

2025-04-02 Thread Tomi Valkeinen
The code in cdns-dphy has probably been part of a DSI driver in the past. Remove DSI defines and variables which are not used or do not actually do anything. Also rename cdns_dsi_get_dphy_pll_cfg() to cdns_get_dphy_pll_cfg(), i.e. drop the "dsi", as it's not relevant here. Signed-off-by: Tomi Valk

  1   2   3   >