Re: [PATCH] kunit: fixes backtrace suppression test module description

2025-03-29 Thread David Gow
On Sat, 29 Mar 2025 at 23:06, Alessandro Carminati wrote: > > Adds module description to the backtrace suppression test > > Fixes: ("19f3496") kunit: add test cases for backtrace warning suppression > > Signed-off-by: Alessandro Carminati > --- The "Fixes" tag here should be immediately before

Re: [PATCH] kunit: fixes Compilation error on s390

2025-03-29 Thread David Gow
On Sat, 29 Mar 2025 at 23:04, Alessandro Carminati wrote: > > The current implementation of suppressing warning backtraces uses __func__, > which is a compile-time constant only for non -fPIC compilation. > GCC's support for this situation in position-independent code varies across > versions and

[PATCH v8 01/10] drm/debugfs: output client_id in in drm_clients_info

2025-03-29 Thread Pierre-Eric Pelloux-Prayer
client_id is a unique id used by fdinfo. Having it listed in 'clients' output means a userspace application can correlate the fields, eg: given a fdinfo id get the fdinfo name. Geiven that client_id is a uint64_t, we use a %20llu printf format to keep the output aligned (20 = digit count of the bi

Re: [PATCH v3 0/2] Add support for OLED panel used on Snapdragon Lenovo T14s Gen6

2025-03-29 Thread Rob Herring (Arm)
On Thu, 27 Mar 2025 16:56:52 +, Christopher Obbard wrote: > The Snapdragon Lenovo T14s Gen6 can be bought with a number of different > panels. This patch series adds support for the OLED model which has a > Samsung ATNA40YK20 panel. > > With this patch series, the backlight of the OLED eDP p

Re: [PATCH] kunit: fixes Compilation error on s390

2025-03-29 Thread Stephen Rothwell
Hi Alessandro, On Sat, 29 Mar 2025 15:03:20 + Alessandro Carminati wrote: > > The current implementation of suppressing warning backtraces uses __func__, > which is a compile-time constant only for non -fPIC compilation. > GCC's support for this situation in position-independent code varies

Re: [PATCH] drm/i915/gvt: update MAINTAINERS

2025-03-29 Thread Jani Nikula
On Thu, 27 Feb 2025, Jani Nikula wrote: > Update GVT-g MAINTAINERS entry to reflect the current status of > maintenance and repositories. > > Cc: Dave Airlie > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Simona Vetter > Cc: Tvrtko Ursulin > Cc: Zhenyu Wang > Cc: Zhi Wang Zhenyu, Zhi, ping

Re: [PATCH V8 43/43] drm/colorop: Add destroy functions for color pipeline

2025-03-29 Thread Simon Ser
I would prefer these functions to be introduced together with the patches adding functions to create objects and adding the new fields. That way it's easier to check the symmetry and at no point in the series there are memory leaks. Additionally, I would avoid using the name "cleanup", which seems

Re: [PATCH V8 32/43] drm/colorop: Add 1D Curve Custom LUT type

2025-03-29 Thread Simon Ser
Reviewed-by: Simon Ser

Re: [PATCH v2 0/7] *** Add virtio gpu userptr support ***

2025-03-29 Thread Demi Marie Obenour
On 3/21/25 4:00 AM, Honglei Huang wrote: > From: Honglei Huang > > Hello, > > This series add virtio gpu userptr support and add libhsakmt capset. > The userptr feature is used for let host access guest user space memory, > this feature is used for GPU compute use case, to enable ROCm/OpenCL nat

Re: [PATCH v1 1/7] virtio-gpu api: add blob userptr resource

2025-03-29 Thread Demi Marie Obenour
On 3/26/25 10:46 AM, Dmitry Osipenko wrote: > On 3/6/25 13:51, Huang, Honglei1 wrote: >> >> On 2025/3/1 5:21, Demi Marie Obenour wrote: >>> On 2/28/25 12:36 AM, Honglei Huang wrote: From: Honglei Huang Add a new resource for blob resource, called userptr, used for let host acce

[PATCH v2] ASoC: hdmi-codec: wire up the .prepare callback also for SPDIF DAI ops

2025-03-29 Thread Martin Blumenstingl
Commit 2fef64eec23a ("ASoC: hdmi-codec: Add a prepare hook") added a prepare implementation. Back then the new callback was only integrated with hdmi_codec_i2s_dai_ops (which is used by the I2S input code-path). It was not added to hdmi_codec_spdif_dai_ops (which is used by the SPDIF input code-pat

[PATCH v7 3/4] drm/tidss: Mark AM65x OLDI code separately

2025-03-29 Thread Aradhya Bhatia
The dss dt schema and the tidss driver have kept the single-link OLDI in AM65x integrated with the parent video-port (VP) from DSS (as the OLDI configuration happens from the source VP only). To help configure the dual-lvds modes that the OLDI has to offer in devices AM62x and later, a new OLDI bri

Re: [PATCH v3 00/16] Introduce and use generic parity16/32/64 helper

2025-03-29 Thread Kuan-Wei Chiu
On Mon, Mar 24, 2025 at 11:53:35AM -0400, Yury Norov wrote: > On Sun, Mar 23, 2025 at 03:40:20PM -0700, H. Peter Anvin wrote: > > On March 23, 2025 8:16:24 AM PDT, Kuan-Wei Chiu > > wrote: > > >On Thu, Mar 13, 2025 at 03:41:49PM +0800, Kuan-Wei Chiu wrote: > > >> On Thu, Mar 13, 2025 at 12:29:13A

Re: [PATCH V8 00/43] Color Pipeline API w/ VKMS

2025-03-29 Thread Simon Ser
Thanks a lot for sending the updated series, Alex! I've looked at all of the core DRM patches and they all look pretty close to being R-b'ed. I don't think I'd have time to look at vkms or amdgpu patches. Let me know if I missed anything! Simon

Re: [PATCH V8 39/43] drm/colorop: allow non-bypass colorops

2025-03-29 Thread Simon Ser
I'm personally not a fan of such boolean function arguments, especially when caller and callee are far apart. From the caller side, the meaning of the boolean argument is not immediately clear. I would prefer a "flags" argument, which can take a e.g. DRM_COLOROP_FLAG_ALLOW_BYPASS value. But I'm n

Re: [PATCH V8 20/43] drm/colorop: pass plane_color_pipeline client cap to atomic check

2025-03-29 Thread Simon Ser
Reviewed-by: Simon Ser

[PATCH v11 13/14] drm/bridge: Update the bridge enable/disable doc

2025-03-29 Thread Aradhya Bhatia
Now that the bridges get pre-enabled before the CRTC is enabled, and get post-disabled after the CRTC is disabled, update the function descriptions to accurately reflect the updated scenario. The enable sequence for the display pipeline looks like: bridge[n]_pre_enable ...

Re: [PATCH V8 03/43] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2025-03-29 Thread Simon Ser
Thanks a lot for these docs, very well written. I especially like the "Driver Implementer's Guide" section. A few minor comments below, regardless: Reviewed-by: Simon Ser > +What problem are we solving? > + > + > +We would like to support pre-, and post-blending comp

[PATCH] kunit: fixes backtrace suppression test module description

2025-03-29 Thread Alessandro Carminati
Adds module description to the backtrace suppression test Fixes: ("19f3496") kunit: add test cases for backtrace warning suppression Signed-off-by: Alessandro Carminati --- lib/kunit/backtrace-suppression-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/kunit/backtrace-suppressio

[PATCH] kunit: fixes Compilation error on s390

2025-03-29 Thread Alessandro Carminati
The current implementation of suppressing warning backtraces uses __func__, which is a compile-time constant only for non -fPIC compilation. GCC's support for this situation in position-independent code varies across versions and architectures. On the s390 architecture, -fPIC is required for compi

Re: [PATCH V8 28/43] drm/colorop: Add PQ 125 EOTF and its inverse

2025-03-29 Thread Simon Ser
Reviewed-by: Simon Ser

Re: [PATCH v4 02/14] kunit: bug: Count suppressed warning backtraces

2025-03-29 Thread David Gow
On Thu, 13 Mar 2025 at 19:44, Alessandro Carminati wrote: > > From: Guenter Roeck > > Count suppressed warning backtraces to enable code which suppresses > warning backtraces to check if the expected backtrace(s) have been > observed. > > Using atomics for the backtrace count resulted in build er

Re: [PATCH v4 01/14] bug/kunit: Core support for suppressing warning backtraces

2025-03-29 Thread David Gow
On Thu, 13 Mar 2025 at 19:44, Alessandro Carminati wrote: > > From: Guenter Roeck > > Some unit tests intentionally trigger warning backtraces by passing > bad parameters to API functions. Such unit tests typically check the > return value from those calls, not the existence of the warning backtr

[PATCH v11 09/14] drm/bridge: cdns-dsi: Move DSI mode check to _atomic_check()

2025-03-29 Thread Aradhya Bhatia
From: Aradhya Bhatia At present, the DSI mode configuration check happens during the _atomic_enable() phase, which is not really the best place for this. Moreover, if the mode is not valid, the driver gives a warning and continues the hardware configuration. Move the DSI mode configuration check

Re: [PATCH V8 12/43] Documentation/gpu: document drm_colorop

2025-03-29 Thread Simon Ser
Reviewed-by: Simon Ser

Re: [PATCH V8 11/43] drm/colorop: Introduce DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE

2025-03-29 Thread Simon Ser
Reviewed-by: Simon Ser

Re: [PATCH V8 10/43] drm/plane: Add COLOR PIPELINE property

2025-03-29 Thread Simon Ser
Two nits below, regardless: Reviewed-by: Simon Ser > + } else if (property == plane->color_pipeline_property) { > + /* find DRM colorop object */ > + struct drm_colorop *colorop = NULL; > + > + colorop = drm_colorop_find(dev, file_priv, val); > + > +

[PATCH v11 10/14] drm/atomic-helper: Refactor crtc & encoder-bridge op loops into separate functions

2025-03-29 Thread Aradhya Bhatia
From: Aradhya Bhatia The way any singular display pipeline, in need of a modeset, gets enabled is as follows - crtc enable (all) bridge pre-enable encoder enable (all) bridge enable - and the disable sequence is exactly the reverse of this. The crtc operations o

[PATCH v7 4/4] drm/tidss: Add OLDI bridge support

2025-03-29 Thread Aradhya Bhatia
From: Aradhya Bhatia The AM62x and AM62Px SoCs feature 2 OLDI TXes each, which makes it possible to connect them in dual-link or cloned single-link OLDI display modes. The current OLDI support in tidss_dispc.c can only support for a single OLDI TX, connected to a VP and doesn't really support con

Re: [PATCH 2/4] dt-bindings: display: panel: Add Himax HX83112B

2025-03-29 Thread Luca Weiss
Hi all, On 2/24/25 9:16 AM, Krzysztof Kozlowski wrote: On 23/02/2025 16:29, Luca Weiss wrote: Hi Krzysztof, On 23-02-2025 12:54 p.m., Krzysztof Kozlowski wrote: On Sat, Feb 22, 2025 at 06:58:05PM +0100, Luca Weiss wrote: Himax HX83112B is a display driver IC used to drive LCD DSI panels. Des

Re: [PATCH v4 0/3] drm/tidss: Add OLDI bridge support

2025-03-29 Thread Aradhya Bhatia
Hi Alexander, On 26/03/25 00:27, Sverdlin, Alexander wrote: > Hi Aradhya! > > On Thu, 2025-03-20 at 18:54 +0530, Aradhya Bhatia wrote: >>> I've tried to test the patchset with necessary pre-requisites and DT >>> additions >>> with a single channel LVDS pannel and while I'm not successful yet, I'

[PATCH v7 0/4] drm/tidss: Add OLDI bridge support

2025-03-29 Thread Aradhya Bhatia
Hello all, This patch series adds support for the dual OLDI TXes supported in Texas Instruments' AM62x and AM62Px family of SoCs. The OLDI TX hardware supports single-lvds, lvds-clone, and dual-lvds modes. These TXes have now been represented through DRM bridges within TI-DSS. * Some history and

[PATCH v7 2/4] dt-bindings: display: ti: Add schema for AM625 OLDI Transmitter

2025-03-29 Thread Aradhya Bhatia
From: Aradhya Bhatia The OLDI transmitters (TXes) do not have registers of their own, and are dependent on the source video-ports (VPs) from the DSS to provide configuration data. This hardware doesn't directly sit on the internal bus of the SoC, but does so via the DSS. Hence, the OLDI TXes are

[PATCH v7 1/4] dt-bindings: display: ti, am65x-dss: Re-indent the example

2025-03-29 Thread Aradhya Bhatia
From: Aradhya Bhatia Reduce tab size from 8 spaces to 4 spaces to make the bindings consistent, and easy to expand. Acked-by: Rob Herring (Arm) Reviewed-by: Laurent Pinchart Reviewed-by: Tomi Valkeinen Signed-off-by: Aradhya Bhatia Signed-off-by: Aradhya Bhatia --- .../bindings/display/ti/

[PATCH v11 07/14] drm/mipi-dsi: Add helper to find input format

2025-03-29 Thread Aradhya Bhatia
From: Aradhya Bhatia Add a helper API that can be used by the DSI hosts to find the required input bus format for the given output dsi pixel format. Reviewed-by: Dmitry Baryshkov Reviewed-by: Tomi Valkeinen Tested-by: Tomi Valkeinen Signed-off-by: Aradhya Bhatia Signed-off-by: Aradhya Bhatia

[PATCH v11 08/14] drm/bridge: cdns-dsi: Add input format negotiation

2025-03-29 Thread Aradhya Bhatia
From: Aradhya Bhatia Add support for the input format negotiation hook, that uses the helper drm_mipi_dsi_get_input_bus_fmt() for dsi hosts, to figure out the required input format. Reviewed-by: Dmitry Baryshkov Reviewed-by: Tomi Valkeinen Tested-by: Tomi Valkeinen Signed-off-by: Aradhya Bhat

[PATCH v11 05/14] drm/bridge: cdns-dsi: Wait for Clk and Data Lanes to be ready

2025-03-29 Thread Aradhya Bhatia
From: Aradhya Bhatia Once the DSI Link and DSI Phy are initialized, the code needs to wait for Clk and Data Lanes to be ready, before continuing configuration. This is in accordance with the DSI Start-up procedure, found in the Technical Reference Manual of Texas Instrument's J721E SoC[0] which h

[PATCH v11 02/14] drm/bridge: cdns-dsi: Fix phy de-init and flag it so

2025-03-29 Thread Aradhya Bhatia
From: Aradhya Bhatia The driver code doesn't have a Phy de-initialization path as yet, and so it does not clear the phy_initialized flag while suspending. This is a problem because after resume the driver looks at this flag to determine if a Phy re-initialization is required or not. It is in fact

Re: [PATCH 1/2] drm/edid: Use unsigned int in drm_add_modes_noedid()

2025-03-29 Thread Miguel Ojeda
On Fri, Mar 28, 2025 at 11:27 PM Lyude Paul wrote: > > So - it actually does protect us to a limited extent on the rust side of > things. With CONFIG_RUST_OVERFLOW_CHECKS=y, arithematic checks are builtin to > the language. This isn't the default config of course, but it's better then > nothing.

[PATCH v11 12/14] drm/atomic-helper: Re-order bridge chain pre-enable and post-disable

2025-03-29 Thread Aradhya Bhatia
Move the bridge pre_enable call before crtc enable, and the bridge post_disable call after the crtc disable. The sequence of enable after this patch will look like: bridge[n]_pre_enable ... bridge[1]_pre_enable crtc_enable encoder_enable bridge[1]

[PATCH v11 11/14] drm/atomic-helper: Separate out bridge pre_enable/post_disable from enable/disable

2025-03-29 Thread Aradhya Bhatia
The encoder-bridge ops occur by looping over the new connector states of the display pipelines. The enable sequence runs as follows - - pre_enable(bridge), - enable(encoder), - enable(bridge), while the disable sequnce runs as follows - - disable(bridge),

[PATCH v11 14/14] drm/bridge: cdns-dsi: Use pre_enable/post_disable to enable/disable

2025-03-29 Thread Aradhya Bhatia
From: Aradhya Bhatia The cdns-dsi controller requires that it be turned on completely before the input DPI's source has begun streaming[0]. Not having that, allows for a small window before cdns-dsi enable and after cdns-dsi disable where the previous entity (in this case tidss's videoport) to co

[PATCH v11 06/14] drm/bridge: cdns-dsi: Move to devm_drm_of_get_bridge()

2025-03-29 Thread Aradhya Bhatia
From: Aradhya Bhatia Instead of manually finding the next bridge/panel, and maintaining the panel-bridge (in-case the next entity is a panel), switch to using the automatically managing devm_drm_of_get_bridge() API. Drop the drm_panel support completely from the driver while at it. Reviewed-by:

[PATCH v11 04/14] drm/bridge: cdns-dsi: Check return value when getting default PHY config

2025-03-29 Thread Aradhya Bhatia
From: Aradhya Bhatia Check for the return value of the phy_mipi_dphy_get_default_config() call, and in case of an error, return back the same. Fixes: fced5a364dee ("drm/bridge: cdns: Convert to phy framework") Cc: sta...@vger.kernel.org Reviewed-by: Tomi Valkeinen Reviewed-by: Dmitry Baryshkov

[PATCH v11 00/14] drm/bridge: cdns-dsi: Fix the color-shift issue

2025-03-29 Thread Aradhya Bhatia
Hello all, This series provides some crucial fixes and improvements for the Cadence's DSI TX (cdns-dsi) controller found commonly in Texas Instruments' J7 family of SoCs, as well as in Sitara AM62P and AM62L SoCs. Along with that, this series aims to fix the color-shift issue that has been going

[PATCH v11 03/14] drm/bridge: cdns-dsi: Fix the clock variable for mode_valid()

2025-03-29 Thread Aradhya Bhatia
From: Aradhya Bhatia The crtc_* mode parameters do not get generated (duplicated in this case) from the regular parameters before the mode validation phase begins. The rest of the code conditionally uses the crtc_* parameters only during the bridge enable phase, but sticks to the regular paramet

[PATCH v2 RESEND] drm/msm/dpu: reorder pointer operations after sanity checks to avoid NULL deref

2025-03-29 Thread Qasim Ijaz
_dpu_encoder_trigger_start dereferences "struct dpu_encoder_phys *phys" before the sanity checks which can lead to a NULL pointer dereference if phys is NULL. Fix this by reordering the dereference after the sanity checks. Fixes: 8144d17a81d9 ("drm/msm/dpu: Skip trigger flush and start for CWB"

Re: [PATCH 1/2] drm/amd/display: Protect dml2_create()/dml2_copy()/dml2_create_copy()

2025-03-29 Thread Huacai Chen
Hi, Aurabindo, On Sat, Mar 29, 2025 at 2:27 AM Aurabindo Pillai wrote: > > > > On 2025-03-26 21:40, Huacai Chen wrote: > > Hi, Alex, > > > > On Thu, Mar 27, 2025 at 8:10 AM Alex Hung wrote: > >> > >> The following error messages showed up on an APU and a dGPU during testing. > >> > >> <3> [100.2

Re: [PATCH v4 06/14] x86: Add support for suppressing warning backtraces

2025-03-29 Thread David Gow
On Thu, 13 Mar 2025 at 19:44, Alessandro Carminati wrote: > > From: Guenter Roeck > > Add name of functions triggering warning backtraces to the __bug_table > object section to enable support for suppressing WARNING backtraces. > > To limit image size impact, the pointer to the function name is o

Re: [PATCH v4 03/14] kunit: Add test cases for backtrace warning suppression

2025-03-29 Thread David Gow
On Thu, 13 Mar 2025 at 19:44, Alessandro Carminati wrote: > > From: Guenter Roeck > > Add unit tests to verify that warning backtrace suppression works. > > If backtrace suppression does _not_ work, the unit tests will likely > trigger unsuppressed backtraces, which should actually help to get >

Re: [PATCH v4 00/14] Add support for suppressing warning backtraces

2025-03-29 Thread David Gow
On Thu, 13 Mar 2025 at 19:44, Alessandro Carminati wrote: > > Some unit tests intentionally trigger warning backtraces by passing bad > parameters to kernel API functions. Such unit tests typically check the > return value from such calls, not the existence of the warning backtrace. > > Such inten

Re: [PATCH] drm/amd/display: replace use of msleep(<20) with usleep_range for better accuracy

2025-03-29 Thread James
On Fri, Mar 28, 2025, at 3:46 PM, Shuah Khan wrote: > On 3/26/25 01:00, James Flowers wrote: >> msleep < 20ms will often sleep for ~20ms (according to >> Documentation/timers/timers-howto.rst). > > Can you elaborate and explain why this change is necessary? scripts/checkpatch.pl highlighted it as