Re: [PATCH RFT v2] drm/bridge: ite-it6505: make use of debugfs_init callback

2025-03-15 Thread Wolfram Sang
> > + struct dentry *debugfs = debugfs_create_dir(dev_name(it6505->dev), > > root); I will switch away from dev_name() here, too, of course. > > int i = 0; > > > > while (debugfs_entry[i].name && debugfs_entry[i].fops) { > > debugfs_create_file(debugfs_entry[i].name, 064

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: make use of debugfs_init callback

2025-03-15 Thread Wolfram Sang
On Sun, Mar 16, 2025 at 12:43:48AM +0200, Dmitry Baryshkov wrote: > On Sat, Mar 15, 2025 at 09:15:11PM +0100, Wolfram Sang wrote: > > Do not create a custom directory in debugfs-root, but use the > > debugfs_init callback to create a custom directory at the given place > > for the bridge. The new d

[PATCH] drm/panel: samsung-s6d7aa0: transition to mipi_dsi wrapped functions

2025-03-15 Thread Tejas Vipin
Changes the samsung-s6d7aa0 panel to use multi style functions for improved error handling. Signed-off-by: Tejas Vipin --- drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 223 ++ 1 file changed, 68 insertions(+), 155 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-

Re: [PATCH RFC 3/3] rust: hid: demo the core abstractions for probe and remove

2025-03-15 Thread Rahul Rameshbabu
On Thu, 13 Mar, 2025 18:05:36 +0100 "Benjamin Tissoires" wrote: > On Mar 13 2025, Rahul Rameshbabu wrote: >> This is a very basic "hello, world!" implementation to illustrate that the >> probe and remove callbacks are working as expected. I chose an arbitrary >> device I had on hand for populatin

Re: [PATCH RFC 2/3] rust: hid: USB Monitor Control Class driver

2025-03-15 Thread Rahul Rameshbabu
On Fri, 14 Mar, 2025 15:41:02 +0100 "Miguel Ojeda" wrote: > On Thu, Mar 13, 2025 at 5:58 PM Benjamin Tissoires wrote: >> >> skeletons are good for documentation, but not really for code review as >> they can not compile. >> >> You should make this patch part of a documentation in >> Documentatio

Re: [PATCH RFC 1/3] rust: core abstractions for HID drivers

2025-03-15 Thread Rahul Rameshbabu
On Thu, 13 Mar, 2025 20:25:23 +0100 "Danilo Krummrich" wrote: > On Thu, Mar 13, 2025 at 04:03:35PM +, Rahul Rameshbabu wrote: >> These abstractions enable the development of HID drivers in Rust by binding >> with the HID core C API. They provide Rust types that map to the >> equivalents in C.

Re: [PATCH RFC 1/3] rust: core abstractions for HID drivers

2025-03-15 Thread Rahul Rameshbabu
On Thu, 13 Mar, 2025 17:54:57 +0100 "Benjamin Tissoires" wrote: > On Mar 13 2025, Rahul Rameshbabu wrote: >> These abstractions enable the development of HID drivers in Rust by binding >> with the HID core C API. They provide Rust types that map to the >> equivalents in C. In this initial draft,

[Bug 219888] New: amdgpu: Oops connecting HDMI/DVI/DP on HD 7850 (Pitcairn)

2025-03-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=219888 Bug ID: 219888 Summary: amdgpu: Oops connecting HDMI/DVI/DP on HD 7850 (Pitcairn) Product: Drivers Version: 2.5 Kernel Version: 6.13.0 Hardware: All OS:

Re: [PATCH RFC 0/3] Initial work for Rust abstraction for HID device driver development

2025-03-15 Thread Rahul Rameshbabu
On Thu, 13 Mar, 2025 17:31:53 +0100 "Benjamin Tissoires" wrote: > Hi, > > [quick reply because I am completely under the water for the next 2 > weeks] > > On Mar 13 2025, Rahul Rameshbabu wrote: >> Hello, >> >> I am a hobbyist developer who has been working on a project to create a new >> Rust >

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: make use of debugfs_init callback

2025-03-15 Thread Dmitry Baryshkov
On Sat, Mar 15, 2025 at 09:15:11PM +0100, Wolfram Sang wrote: > Do not create a custom directory in debugfs-root, but use the > debugfs_init callback to create a custom directory at the given place > for the bridge. The new directory layout looks like this on a Renesas > GrayHawk-Single with a R-Ca

Re: [PATCH RFT v2] drm/bridge: ite-it6505: make use of debugfs_init callback

2025-03-15 Thread Dmitry Baryshkov
On Sat, Mar 15, 2025 at 09:17:16PM +0100, Wolfram Sang wrote: > Do not create a custom directory in debugfs-root, but use the > debugfs_init callback to create a custom directory at the given place > for the bridge. > > Signed-off-by: Wolfram Sang > --- > > Only build tested, but following the s

[PATCH RFT v2] drm/bridge: ite-it6505: make use of debugfs_init callback

2025-03-15 Thread Wolfram Sang
Do not create a custom directory in debugfs-root, but use the debugfs_init callback to create a custom directory at the given place for the bridge. Signed-off-by: Wolfram Sang --- Only build tested, but following the same pattern as the tested ti-sn65dsi86. Changes since v1: * switch from 'clie

[PATCH v2] drm/bridge: ti-sn65dsi86: make use of debugfs_init callback

2025-03-15 Thread Wolfram Sang
Do not create a custom directory in debugfs-root, but use the debugfs_init callback to create a custom directory at the given place for the bridge. The new directory layout looks like this on a Renesas GrayHawk-Single with a R-Car V4M SoC: /sys/kernel/debug/dri/feb0.display/DP-1/1-002c

Re: [PATCH 2/3] rust: alloc: add Vec::resize method

2025-03-15 Thread Miguel Ojeda
On Sat, Mar 15, 2025 at 3:43 AM Andrew Ballance wrote: > > +/// # Example Nit: please use the plural for section headers. Thanks! Cheers, Miguel

Re: drm: mipi_dbi_hw_reset() keeps display in reset

2025-03-15 Thread Dmitry Baryshkov
On Sat, Feb 15, 2025 at 02:14:54PM -0500, Alex Lanzano wrote: > On Fri, Feb 14, 2025 at 08:04:41PM -0500, Alex Lanzano wrote: > > On Fri, Feb 14, 2025 at 10:29:29AM +0100, Josef Luštický wrote: > > > Hello Alex, > > > there is a bug in mipi_dbi_hw_reset() function that implements the logic > > > o

[PATCH v3 7/8] drm/msm/dpu: remove DPU_CTL_SPLIT_DISPLAY from CTL blocks on DPU >= 5.0

2025-03-15 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Since DPU 5.0 CTL blocks do not require DPU_CTL_SPLIT_DISPLAY, as single CTL is used for both interfaces. As both RM and encoder now handle active CTLs, drop that feature bit. Reviewed-by: Marijn Suijten Tested-by: Neil Armstrong # on SM8550-QRD Signed-off-by: Dmitry Bar

Re: [PATCH] drm: panel-orientation-quirks: Add ZOTAC Gaming Zone

2025-03-15 Thread Dmitry Baryshkov
On Thu, 13 Mar 2025 14:16:44 -0700, Vicki Pfau wrote: > Add a panel orientation quirk for the ZOTAC Gaming Zone handheld gaming > device. > > Applied to drm-misc-next, thanks! [1/1] drm: panel-orientation-quirks: Add ZOTAC Gaming Zone commit: 96c85e428ebaeacd2c640eba075479ab92072ccd Bes

Re: [PATCH v4] drm/panel: novatek-nt36523: transition to mipi_dsi wrapped functions

2025-03-15 Thread Dmitry Baryshkov
On Sat, Mar 15, 2025 at 11:55:22PM +0530, Tejas Vipin wrote: > Changes the novatek-nt36523 panel to use multi style functions for > improved error handling. > > Reviewed-by: Douglas Anderson > Signed-off-by: Tejas Vipin > --- > Changes in v4: > - Cleanup nt36523_prepare > > Link to v3: > h

[PATCH v4] drm/panel: novatek-nt36523: transition to mipi_dsi wrapped functions

2025-03-15 Thread Tejas Vipin
Changes the novatek-nt36523 panel to use multi style functions for improved error handling. Reviewed-by: Douglas Anderson Signed-off-by: Tejas Vipin --- Changes in v4: - Cleanup nt36523_prepare Link to v3: https://lore.kernel.org/all/20250309040355.381386-1-tejasvipi...@gmail.com/ Changes

Re: [PATCH 1/3] rust: alloc: add Vec::truncate method

2025-03-15 Thread Benno Lossin
On Sat Mar 15, 2025 at 12:15 PM CET, Andrew Ballance wrote: > On Sat, Mar 15, 2025 at 10:09:26AM +, Benno Lossin wrote: >> On Sat Mar 15, 2025 at 3:42 AM CET, Andrew Ballance wrote: >> > implements the equivalent to the std's Vec::truncate >> > on the kernel's Vec type. >> > >> > Signed-off-by:

Re: [PATCH v7 0/7] DRM scheduler kunit tests

2025-03-15 Thread Tvrtko Ursulin
On 12/03/2025 10:39, Philipp Stanner wrote: On Tue, 2025-03-11 at 09:23 +, Tvrtko Ursulin wrote: There has repeatedly been quite a bit of apprehension when any change to the DRM scheduler is proposed, with two main reasons being code base is considered fragile, not well understood and not

[PATCH v2 0/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-15 Thread Ariel D'Alessandro
Hi all, This is a new iteration on Panfrost support for AARCH64_4K page table format. The main reason behind this patchset is that MediaTek MT8188 SoC (ARM Mali-G57 MC3 GPU) constantly faults due to the actual Panfrost cache configuration. Currently, Panfrost only supports MMU configuration in "L

[PATCH] drm/sun4i: backend: Fix error pointers in sun4i_backend_atomic_check

2025-03-15 Thread Chenyuan Yang
The function sun4i_backend_atomic_check was dereferencing pointers returned by drm_atomic_get_plane_state without checking for errors. This could lead to undefined behavior if the function returns an error pointer. This commit adds checks using IS_ERR to ensure that plane_state is valid before der

Re: [PATCH v6 1/4] drm/bridge: split HDMI Audio from DRM_BRIDGE_OP_HDMI

2025-03-15 Thread Maxime Ripard
On Fri, 14 Mar 2025 11:36:48 +0200, Dmitry Baryshkov wrote: > From: Dmitry Baryshkov > > As pointed out by Laurent, OP bits are supposed to describe operations. > Split DRM_BRIDGE_OP_HDMI_AUDIO from DRM_BRIDGE_OP_HDMI instead of > overloading DRM_BRIDGE_OP_HDMI. > > [ ... ] Reviewed-by: Maxime

Re: Include ASPEED ast-drm 1.15.1 video driver in kernel tree

2025-03-15 Thread Nicolas Baranger
Hi Thomas I'm really sorry for the delay of 2 weeks (I lost a big raid array and it tooks days++ to recover, sorry) As asked, I did patch linux-6.13.1 with the provided patch and I did use the original (but just patched) ast driver Here you can find the video of the test: https://xba.soartis

Re: [PATCH] drm/mxsfb: fix missing rollback on failure in mxsfb_probe()

2025-03-15 Thread Dario Binacchi
Hi All, On Thu, Mar 13, 2025 at 3:40 PM Thomas Zimmermann wrote: > > Hi > > Am 13.03.25 um 15:25 schrieb Luca Ceresoli: > > When aperture_remove_all_conflicting_devices() fails, the current code > > returns without going through the rollback actions at the end of the > > function, thus the action

Re: [PATCH] drm/ast: Support both SHMEM helper and VRAM helper

2025-03-15 Thread Thomas Zimmermann
Hi Am 06.03.25 um 07:04 schrieb Huacai Chen: On Wed, Mar 5, 2025 at 5:04 PM Thomas Zimmermann wrote: Hi Am 04.03.25 um 12:55 schrieb Huacai Chen: On Tue, Mar 4, 2025 at 5:39 PM Thomas Zimmermann wrote: Hi Am 04.03.25 um 10:19 schrieb Huacai Chen: On Tue, Mar 4, 2025 at 4:41 PM Thomas Zim

[PATCH v3 07/18] drm/imagination: Handle Rogue safety event IRQs

2025-03-15 Thread Matt Coster
From: Alessio Belle Extend interrupt handling logic to check for safety event IRQs, then clear and handle them in the IRQ handler thread. Safety events need to be checked and cleared with a different set of GPU registers than those the IRQ handler has been using so far. Only two safety events n

Re: [PATCH] accel/qaic: Fix possible data corruption in BOs > 2G

2025-03-15 Thread Troy Hanson
On 3/6/25 12:19 PM, Jeff Hugo wrote: From: Jeffrey Hugo When slicing a BO, we need to iterate through the BO's sgt to find the right pieces to construct the slice. Some of the data types chosen for this process are incorrectly too small, and can overflow. This can result in the incorrect sli

Re: [PATCH] accel/qaic: Remove redundant 'flush_workqueue()' calls

2025-03-15 Thread Jeff Hugo
On 3/12/2025 1:34 AM, Chen Ni wrote: 'destroy_workqueue()' already drains the queue before destroying it, so there is no need to flush it explicitly. Remove the redundant 'flush_workqueue()' calls. This was generated with coccinelle: @@ expression E; @@ - flush_workqueue(E); destroy_workque

Re: [PATCH v7 08/11] drm/atomic-helper: put the bridge returned by drm_bridge_chain_get_first_bridge()

2025-03-15 Thread Maxime Ripard
On Fri, 14 Mar 2025 11:31:21 +0100, Luca Ceresoli wrote: > The bridge returned by drm_bridge_chain_get_first_bridge() is > refcounted. Put it when done. > > Signed-off-by: Luca Ceresoli > > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

[PATCH v7 05/11] drm/bridge: add a cleanup action for scope-based drm_bridge_put() invocation

2025-03-15 Thread Luca Ceresoli
Many functions get a drm_bridge pointer, only use it in the function body (or a smaller scope such as a loop body), and don't store it. In these cases they always need to drm_bridge_put() it before returning (or exiting the scope). Some of those functions have complex code paths with multiple retu

[PATCH V4] drm/sched: Fix fence reference count leak

2025-03-15 Thread Qianyi Liu
From: qianyi liu The last_scheduled fence leaks when an entity is being killed and adding the cleanup callback fails. Decrement the reference count of prev when dma_fence_add_callback() fails, ensuring proper balance. Cc: sta...@vger.kernel.org Fixes: 2fdb8a8f07c2 ("drm/scheduler: rework entity

Re: [PATCH v8 2/6] drm/xe/xe_gt_pagefault: Move pagefault struct to header

2025-03-15 Thread Michal Wajdeczko
On 13.03.2025 19:34, Jonathan Cavitt wrote: > Move the pagefault struct from xe_gt_pagefault.c to the > xe_gt_pagefault_types.h header file, along with the associated enum values. > > v2: > - Normalize names for common header (Matt Brost) > > v3: > - s/Migrate/Move (Michal W) > - s/xe_pagefaul

Re: [PATCH v6 6/6] drm/xe/xe_vm: Implement xe_vm_get_faults_ioctl

2025-03-15 Thread Dan Carpenter
Hi Jonathan, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jonathan-Cavitt/drm-xe-xe_gt_pagefault-Disallow-writes-to-read-only-VMAs/20250308-064247 base: https://

Re: [RFC v3 18/33] rust: drm/kms: Add drm_atomic_state bindings

2025-03-15 Thread Maxime Ripard
On Wed, Mar 05, 2025 at 05:59:34PM -0500, Lyude Paul wrote: > Next up is introducing bindings that we can use to represent the global DRM > atomic state, along with all of the various object states contained within. > We do this by introducing a few new concepts: borrowed states, atomic state > mut

Re: [PATCH v5 04/16] drm/atomic: Introduce helper to lookup connector by encoder

2025-03-15 Thread Dmitry Baryshkov
On Fri, Mar 14, 2025 at 06:40:24PM +0100, Maxime Ripard wrote: > On Fri, Mar 14, 2025 at 09:59:36AM +0200, Dmitry Baryshkov wrote: > > On Fri, Mar 14, 2025 at 08:45:17AM +0100, Maxime Ripard wrote: > > > On Fri, Mar 14, 2025 at 07:52:35AM +0200, Dmitry Baryshkov wrote: > > > > On Fri, Mar 14, 2025

[PATCH v6 07/16] drm/tests: Create tests for drm_atomic

2025-03-15 Thread Maxime Ripard
We don't have a set of kunit tests for the functions under drm_atomic.h. Let's use the introduction of drm_atomic_get_connector_for_encoder() to create some tests for it and thus create that set. Reviewed-by: Dmitry Baryshkov Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/Makefile

[PATCH v7 02/11] drm/bridge: add support for refcounting

2025-03-15 Thread Luca Ceresoli
DRM bridges are currently considered as a fixed element of a DRM card, and thus their lifetime is assumed to extend for as long as the card exists. New use cases, such as hot-pluggable hardware with video bridges, require DRM bridges to be added to and removed from a DRM card without tearing the ca

[PATCH v6 drm-dp 2/9] drm/hisilicon/hibmc: Add dp serdes cfg to adjust serdes rate, voltage and pre-emphasis

2025-03-15 Thread Yongbang Shi
From: Baihan Li This dp controller need features of digital-to-analog conversion and high-speed transmission in chip by its extern serdes controller. Our serdes cfg is relatively simple, just need two register configurations. Don't need too much functions, like: power on/off, initialize, and some

Re: [PATCH 2/2] drm/bridge: fsl-ldb: make warning message more informative

2025-03-15 Thread Luca Ceresoli
Hello Liu, thanks for your reviews. On Fri, 7 Mar 2025 14:33:37 +0800 Liu Ying wrote: > On 03/07/2025, Luca Ceresoli wrote: > > This warning notifies a clock was set to an inaccurate value. Modify the > > string to also show the clock name. > > > > While doing that also rewrap the entire funct

[PATCH] drm/i915/gsc: delete a stray tab in intel_gsc_fw_get_binary_info()

2025-03-15 Thread Dan Carpenter
This line is indented on tab too far. Delete the extra tab. Signed-off-by: Dan Carpenter --- drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c index

[PATCH v6 drm-dp 6/9] drm/hisilicon/hibmc: Add colorbar-cfg feature and its debugfs file

2025-03-15 Thread Yongbang Shi
From: Baihan Li DP controller can support generating a color bar signal over the DisplayPort interface. This can be useful to check for possible DDR or GPU problems, as the signal generator resides completely in the DP block. Add debugfs file that controls colorbar generator. echo: config the co

Re: [PATCH v3 2/2] drm/vc4: hdmi: Add jack detection to HDMI audio driver

2025-03-15 Thread Maxime Ripard
On Wed, 12 Mar 2025 15:40:56 +, David Turner wrote: > Add ALSA jack detection to the vc4-hdmi audio driver so userspace knows > when to add/remove HDMI audio devices. > > Signed-off-by: Stefan Wahren > Signed-off-by: David Turner > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v7 32/32] drm/doc: gpusvm: Add GPU SVM documentation

2025-03-15 Thread Matthew Brost
On Thu, Mar 06, 2025 at 04:45:31PM +1100, Alistair Popple wrote: > On Wed, Mar 05, 2025 at 05:26:57PM -0800, Matthew Brost wrote: > > Add documentation for agree upon GPU SVM design principles, current > > status, and future plans. > > One minor nit and a comment below, but feel free to add: > >

Re: [PATCH v5 1/2] drm/bridge: split HDMI Audio from DRM_BRIDGE_OP_HDMI

2025-03-15 Thread Maxime Ripard
Hi, On Fri, Mar 07, 2025 at 07:55:52AM +0200, Dmitry Baryshkov wrote: > From: Dmitry Baryshkov > > As pointed out by Laurent, OP bits are supposed to describe operations. > Split DRM_BRIDGE_OP_HDMI_AUDIO from DRM_BRIDGE_OP_HDMI instead of > overloading DRM_BRIDGE_OP_HDMI. > > Signed-off-by: Dmi

Re: [PATCH 3/5] dt-bindings: display: simple-bridge: Document DPI color encoder

2025-03-15 Thread Liu Ying
On 03/06/2025, Maxime Ripard wrote: > On Thu, Mar 06, 2025 at 03:02:41PM +0800, Liu Ying wrote: >> On 03/06/2025, Rob Herring wrote: >>> On Wed, Mar 05, 2025 at 10:35:26AM +0100, Alexander Stein wrote: Hi, Am Dienstag, 4. März 2025, 16:23:20 CET schrieb Rob Herring: > On Tue, Mar

Re: [PATCH v1 5/6] drm/panfrost: Enable AARCH64_4K page table format on mediatek_mt8188

2025-03-15 Thread Ariel D'Alessandro
Angelo, On 3/11/25 6:09 AM, AngeloGioacchino Del Regno wrote: Il 10/03/25 20:59, Ariel D'Alessandro ha scritto: Now that Panfrost supports AARCH64_4K page table format, let's enable it on Mediatek MT8188. Signed-off-by: Ariel D'Alessandro ---   drivers/gpu/drm/panfrost/panfrost_drv.c | 1 +  

Re: [PATCH v2 0/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-03-15 Thread Aleksandrs Vinarskis
On 3/12/25 22:16, Stefan Schmidt wrote: Hello Aleksandrs, On Wed, 12 Mar 2025 at 00:41, Aleksandrs Vinarskis wrote: Recently added Initial LTTPR support in msm/dp has configured LTTPR(s) to non-transparent mode to enable video output on X1E-based devices that come with LTTPR on the motherb

Re: [PATCH v4 4/7] dt-bindings: gpu: v3d: Add per-compatible register restrictions

2025-03-15 Thread Stefan Wahren
Hello, Am 13.03.25 um 20:04 schrieb Maíra Canal: +Cc Stefan Hi Krzysztof, On 13/03/25 12:03, Krzysztof Kozlowski wrote: On 13/03/2025 15:43, Maíra Canal wrote: In order to enforce per-SoC register rules, add per-compatible restrictions. V3D 3.3 (represented by brcm,7268-v3d) has a cache cont

Re: [PATCH] drm/panel/synaptics-r63353: Use _multi variants

2025-03-15 Thread Anusha Srivatsa
On Fri, Mar 7, 2025 at 12:47 PM Maxime Ripard wrote: > On Thu, Mar 06, 2025 at 02:12:14PM -0500, Anusha Srivatsa wrote: > > On Thu, Mar 6, 2025 at 12:54 PM Doug Anderson > wrote: > > > On Thu, Mar 6, 2025 at 9:20 AM Maxime Ripard > wrote: > > > > > > > > On Thu, Mar 06, 2025 at 10:08:24AM -0500

[PATCH v2 3/6] drm/panfrost: Set HW_FEATURE_AARCH64_MMU feature flag on Bifrost models

2025-03-15 Thread Ariel D'Alessandro
Set this feature flag on all Mali Bifrost platforms as the MMU supports AARCH64 4K page table format. Signed-off-by: Ariel D'Alessandro Reviewed-by: Boris Brezillon Reviewed-by: Steven Price --- drivers/gpu/drm/panfrost/panfrost_features.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a

Re: [PATCH v2 7/7] arm64: dts: rockchip: Enable DP2HDMI for ROCK 5 ITX

2025-03-15 Thread Dmitry Baryshkov
On Thu, Mar 13, 2025 at 08:32:55AM +0800, Andy Yan wrote: > > Hi Dmitry, > > At 2025-03-12 20:39:17, "Dmitry Baryshkov" wrote: > >On Wed, Mar 12, 2025 at 06:42:08PM +0800, Andy Yan wrote: > >> From: Andy Yan > >> > >> The HDMI Port next to Headphone Jack is drived by > >> DP1 on rk3588 via a d

Re: [PATCH v6 2/4] drm/bridge: add function interface for DisplayPort audio implementation

2025-03-15 Thread Dmitry Baryshkov
On Fri, Mar 14, 2025 at 05:54:14PM +, Maxime Ripard wrote: > On Fri, 14 Mar 2025 11:36:49 +0200, Dmitry Baryshkov wrote: > > It is common for the DisplayPort bridges to implement audio support. In > > preparation to providing a generic framework for DP audio, add > > corresponding interface to

[PATCH v6 6/6] drm/sched: Add a basic test for checking credit limit

2025-03-15 Thread Tvrtko Ursulin
Add a basic test for checking whether scheduler respects the configured credit limit. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stanner --- drivers/gpu/drm/scheduler/tests/tests_basic.c | 60 ++- 1 file changed, 59 in

Re: [PATCH v1 1/6] drm/panfrost: Set IOMMU_CACHE flag

2025-03-15 Thread Steven Price
On 10/03/2025 19:59, Ariel D'Alessandro wrote: > Panfrost does not support uncached mappings, so flag them properly. Also > flag the pages that are mapped as response to a page fault as cached. As I understand it the hardware only sort-of supports uncached mappings. The legacy page table format ha

Re: [PATCH v5 7/7] test_bits: add tests for BIT_U*()

2025-03-15 Thread Andy Shevchenko
On Fri, Mar 07, 2025 at 01:08:15AM +0900, Vincent Mailhol wrote: > On 06/03/2025 at 22:11, Andy Shevchenko wrote: > > On Thu, Mar 06, 2025 at 08:29:58PM +0900, Vincent Mailhol via B4 Relay > > wrote: > >> From: Vincent Mailhol > >> > >> Add some additional tests in lib/test_bits.c to cover the ex

Re: [RFC PATCH 3/4] drm/panfrost: Support ARM_64_LPAE_S1 page table

2025-03-15 Thread Ariel D'Alessandro
Hi Steven, On 2/27/25 11:44 AM, Steven Price wrote: On 26/02/2025 18:30, Ariel D'Alessandro wrote: Bifrost MMUs support AArch64 4kB granule specification. However, panfrost only enables MMU in legacy mode, despite the presence of the HW_FEATURE_AARCH64_MMU feature flag. This commit adds suppor

Re: [PATCH v1 6/6] drm/panfrost: Set HW_FEATURE_AARCH64_MMU feature flag on Bifrost models

2025-03-15 Thread Steven Price
On 10/03/2025 19:59, Ariel D'Alessandro wrote: > Set this feature flag on all Mali Bifrost platforms as the MMU supports > AARCH64 4K page table format. > > Signed-off-by: Ariel D'Alessandro Reviewed-by: Steven Price > --- > drivers/gpu/drm/panfrost/panfrost_features.h | 3 +++ > 1 file chang

Re: [PATCH] accel/qaic: Remove redundant 'flush_workqueue()' calls

2025-03-15 Thread Jeff Hugo
On 3/12/2025 1:34 AM, Chen Ni wrote: 'destroy_workqueue()' already drains the queue before destroying it, so there is no need to flush it explicitly. Remove the redundant 'flush_workqueue()' calls. This was generated with coccinelle: @@ expression E; @@ - flush_workqueue(E); destroy_workque

Re: [PATCH] drm/ttm/tests: fix potential null pointer dereference in ttm_bo_unreserve_bulk()

2025-03-15 Thread Christian König
Am 11.03.25 um 20:01 schrieb Qasim Ijaz: > In the ttm_bo_unreserve_bulk() test function, resv is allocated > using kunit_kzalloc(), but the subsequent assertion mistakenly > verifies the ttm_dev pointer instead of checking the resv pointer. > This mistake means that if allocation for resv fails,

Re: [PATCH 2/2] drm/bridge: fsl-ldb: make warning message more informative

2025-03-15 Thread Liu Ying
On 03/07/2025, Luca Ceresoli wrote: > Hello Liu, Hello Luca, > > thanks for your reviews. > > On Fri, 7 Mar 2025 14:33:37 +0800 > Liu Ying wrote: > >> On 03/07/2025, Luca Ceresoli wrote: >>> This warning notifies a clock was set to an inaccurate value. Modify the >>> string to also show the c

Re: [PATCH v3] arm64: defconfig: mediatek: enable PHY drivers

2025-03-15 Thread Nícolas F . R . A . Prado
On Thu, Mar 13, 2025 at 09:38:24AM +0530, Vignesh Raman wrote: > The mediatek display driver fails to probe on mt8173-elm-hana and > mt8183-kukui-jacuzzi-juniper-sku16 in v6.14-rc4 due to missing PHY > configurations. > > Commit [1] stopped selecting the MediaTek PHY drivers, requiring them > to b

[PATCH v3 14/16] fsi: i2cr: Replace open-coded parity calculation with parity64()

2025-03-15 Thread Kuan-Wei Chiu
Refactor parity calculations to use the standard parity64() helper. This change eliminates redundant implementations and improves code efficiency. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- Changes in v3: - Change parity ^= parity64(v) to parity !=

Re: [PATCH v2 8/8] drm/client: s/unsigned int i/int i/

2025-03-15 Thread Jani Nikula
On Fri, 28 Feb 2025, Ville Syrjala wrote: > From: Ville Syrjälä > > Replace the 'unsigned int i' footguns with plain old signed > int. Avoids accidents if/when someone decides they need > to iterate backwards. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/

[PATCH v6 0/4] drm/bridge: reuse DRM HDMI Audio helpers for DisplayPort bridges

2025-03-15 Thread Dmitry Baryshkov
A lot of DisplayPort bridges use HDMI Codec in order to provide audio support. Present DRM HDMI Audio support has been written with the HDMI and in particular DRM HDMI Connector framework support, however those audio helpers can be easily reused for DisplayPort drivers too. Patches by Hermes Wu th

[PATCH] drm/bridge: dw-hdmi: Avoid including uapi headers

2025-03-15 Thread Andy Yan
From: Andy Yan It is not recommended for drivers to include UAPI header directly. Signed-off-by: Andy Yan --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/s

Re: [PATCH v6 2/4] drm/bridge: add function interface for DisplayPort audio implementation

2025-03-15 Thread Maxime Ripard
On Fri, 14 Mar 2025 11:36:49 +0200, Dmitry Baryshkov wrote: > It is common for the DisplayPort bridges to implement audio support. In > preparation to providing a generic framework for DP audio, add > corresponding interface to struct drm_bridge. As suggested by Maxime > for now this is mostly c&p

[PATCH v8 01/13] drm/bridge: analogix_dp: Add irq flag IRQF_NO_AUTOEN instead of calling disable_irq()

2025-03-15 Thread Damon Ding
The IRQF_NO_AUTOEN can be used for the drivers that don't want interrupts to be enabled automatically via devm_request_threaded_irq(). Using this flag can provide be more robust compared to the way of calling disable_irq() after devm_request_threaded_irq() without the IRQF_NO_AUTOEN flag. Suggeste

[PATCH DO NOT MERGE v3 18/18] arm64: dts: ti: k3-j721s2: Add GPU node

2025-03-15 Thread Matt Coster
The J721S2 binding is based on the TI downstream binding in 54b0f2a00d92 ("arm64: dts: ti: k3-j721s2-main: add gpu node") from [1] but with updated compatible strings. The clock[2] and power[3] indices were verified from docs, but the source of the interrupt index remains elusive. [1]: https://gi

Re: [PATCH RFC 11/12] drm/gem: Add cgroup memory accounting

2025-03-15 Thread Robin Murphy
On 2025-03-10 12:06 pm, Maxime Ripard wrote: In order to support any device using the GEM support, let's charge any GEM DMA allocation into the dmem cgroup. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_gem.c| 5 + drivers/gpu/drm/drm_gem_dma_helper.c | 6 ++ incl

Re: [PATCH] drm/sched: revert "drm_sched_job_cleanup(): correct false doc"

2025-03-15 Thread Philipp Stanner
On Mon, 2025-03-10 at 08:44 +0100, Christian König wrote: > This reverts commit 44d2f310f008613c1dbe5e234c2cf2be90cbbfab. > > Sorry for the delayed response, I only stumbled over this now while > going > over old mails and then re-thinking my reviewed by for this change. > > The function drm_sche

Re: Time for drm-ci-next?

2025-03-15 Thread Rob Clark
On Mon, Mar 10, 2025 at 4:07 AM Maxime Ripard wrote: > > On Fri, Mar 07, 2025 at 09:26:54AM -0800, Rob Clark wrote: > > On Fri, Mar 7, 2025 at 9:00 AM Maxime Ripard wrote: > > > On Fri, Mar 07, 2025 at 08:42:46AM -0800, Rob Clark wrote: > > > > On Tue, Sep 24, 2024 at 5:27 AM Vignesh Raman > > >

Re: Time for drm-ci-next?

2025-03-15 Thread Maxime Ripard
On Fri, Mar 07, 2025 at 09:26:54AM -0800, Rob Clark wrote: > On Fri, Mar 7, 2025 at 9:00 AM Maxime Ripard wrote: > > On Fri, Mar 07, 2025 at 08:42:46AM -0800, Rob Clark wrote: > > > On Tue, Sep 24, 2024 at 5:27 AM Vignesh Raman > > > > On 12/09/24 11:18, Dmitry Baryshkov wrote: > > > > > On Mon, S

[BUG] KASAN: slab-use-after-free in drm_atomic_helper_wait_for_vblanks (DRM) on 6.14.0-rc4

2025-03-15 Thread Strforexc yn
Dear Linux Kernel Developers,I’ve encountered a KASAN-reported slab-use-after-free in the DRM atomic helper on Linux 6.14.0-rc4 during a commit operation. Here are the details: Kernel commit: v6.14-rc4 (Commits on Feb 24, 2025) Kernel Config : https://github.com/Strforexc/LinuxKernelbug/blob/main/

[PATCH v4 5/5] drm/scheduler: Add a basic test for modifying entities scheduler list

2025-03-15 Thread Tvrtko Ursulin
Add a basic test for exercising modifying the entities scheduler list at runtime. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stanner --- drivers/gpu/drm/scheduler/tests/tests_basic.c | 69 ++- 1 file changed, 68 insert

Re: [PATCH v2 09/10] drm/bridge: anx7625: update bridge_ops and sink detect logic

2025-03-15 Thread Dmitry Baryshkov
On Thu, Mar 13, 2025 at 12:14:04PM +0530, Ayushi Makhija wrote: > > > On 3/12/2025 4:33 PM, Dmitry Baryshkov wrote: > > On Wed, 12 Mar 2025 at 11:47, Ayushi Makhija > > wrote: > >> > >> On 3/11/2025 9:11 PM, Dmitry Baryshkov wrote: > >>> On Tue, Mar 11, 2025 at 05:54:44PM +0530, Ayushi Makhija

Re: [PATCH v5 1/2] drm/bridge: split HDMI Audio from DRM_BRIDGE_OP_HDMI

2025-03-15 Thread Dmitry Baryshkov
On Fri, Mar 14, 2025 at 08:50:36AM +0100, Maxime Ripard wrote: > On Tue, Mar 11, 2025 at 07:50:50PM +0200, Dmitry Baryshkov wrote: > > On Tue, Mar 11, 2025 at 04:58:59PM +0100, Maxime Ripard wrote: > > > On Tue, Mar 11, 2025 at 05:50:09PM +0200, Dmitry Baryshkov wrote: > > > > On Tue, Mar 11, 2025

[PATCH v3] drm: Add UAPI for the Asahi driver

2025-03-15 Thread Alyssa Rosenzweig
This adds the UAPI for the Asahi driver targeting the GPU in the Apple M1 and M2 series systems on chip. The UAPI design is based on other modern Vulkan-capable drivers, including Xe and Panthor. Memory management is based on explicit VM management. Synchronization is exclusively explicit sync. Th

Re: [PATCH v5 04/16] drm/atomic: Introduce helper to lookup connector by encoder

2025-03-15 Thread Dmitry Baryshkov
On Fri, Mar 14, 2025 at 08:45:17AM +0100, Maxime Ripard wrote: > On Fri, Mar 14, 2025 at 07:52:35AM +0200, Dmitry Baryshkov wrote: > > On Fri, Mar 14, 2025 at 08:50:29AM +0800, Andy Yan wrote: > > > > > > Hi Maxime and Simona, > > > > > > > > > At 2025-03-13 19:55:33, "Maxime Ripard" wrote: > >

[pull] amdgpu, amdkfd, radeon drm-next-6.15

2025-03-15 Thread Alex Deucher
Hi Dave, Simona, Updates for 6.15. The following changes since commit 236f475d29f8e585a72fb6fac7f8bb4dc4b162b7: Merge tag 'amd-drm-next-6.15-2025-03-07' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2025-03-10 09:04:52 +1000) are available in the Git repository at: https:/

[PATCH RFC v4 6/6] drm/display: dp-tunnel: use new DCPD access helpers

2025-03-15 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Switch drm_dp_tunnel.c to use new set of DPCD read / write helpers. Reviewed-by: Lyude Paul Acked-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dp_tunnel.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) d

Re: [PATCH v7 02/11] drm/bridge: add support for refcounting

2025-03-15 Thread Maxime Ripard
On Fri, Mar 14, 2025 at 11:31:15AM +0100, Luca Ceresoli wrote: > DRM bridges are currently considered as a fixed element of a DRM card, and > thus their lifetime is assumed to extend for as long as the card > exists. New use cases, such as hot-pluggable hardware with video bridges, > require DRM br

[PATCH v7 00/11] drm/bridge: add devm_drm_bridge_alloc() with bridge refcount

2025-03-15 Thread Luca Ceresoli
This series improves the way DRM bridges are allocated and initialized and makes them reference-counted. The goal of reference counting is to avoid use-after-free by drivers which got a pointer to a bridge and keep it stored and used even after the bridge has been deallocated. The overall goal is

Re: [PATCH 09/11] arm64: dts: qcom: x1e80100-dell-xps13-9345: Drop clock-names from PS8830

2025-03-15 Thread Dmitry Baryshkov
On Thu, Mar 06, 2025 at 07:11:21PM +0100, Konrad Dybcio wrote: > From: Konrad Dybcio > > The preemptively-merged node contains a property absent from the final > bindings. Remove it. > > Signed-off-by: Konrad Dybcio > --- > arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 2 -- > 1 file

Re: [PATCH next] drm: adp: Fix NULL vs IS_ERR() check in adp_plane_new()

2025-03-15 Thread Alyssa Rosenzweig
On Fri, 07 Mar 2025 12:30:58 +0300, Dan Carpenter wrote: > The __drmm_universal_plane_alloc() function doesn't return NULL, it > returns error pointers. Update the check to match. > > Applied, thanks! [1/1] drm: adp: Fix NULL vs IS_ERR() check in adp_plane_new() (no commit info) Best

[PATCH 0/3] rust: alloc: add Vec::resize and Vec::truncate

2025-03-15 Thread Andrew Ballance
This patch series implements the Vec::truncate and Vec::resize methods that were needed by the nova driver and removes the corresponding item from their task list Andrew Ballance (3): rust: alloc: add Vec::truncate method rust: alloc: add Vec::resize method gpu: nova-core: remove completed V

Re: [PATCH 07/10] drm/msm/dsi/phy: add configuration for SAR2130P

2025-03-15 Thread Dmitry Baryshkov
On Sat, Mar 08, 2025 at 03:17:23PM +0100, Konrad Dybcio wrote: > On 8.03.2025 2:42 AM, Dmitry Baryshkov wrote: > > From: Dmitry Baryshkov > > > > Qualcomm SAR2130P requires slightly different setup for the DSI PHY. It > > is a 5nm PHY (like SM8450), so supplies are the same, but the rest of > > t

[PATCH v1 2/3] drm/ci: uprev IGT

2025-03-15 Thread Vignesh Raman
Uprev IGT to the latest version and update expectation files. Signed-off-by: Vignesh Raman --- drivers/gpu/drm/ci/gitlab-ci.yml | 2 +- .../gpu/drm/ci/xfails/amdgpu-stoney-fails.txt | 8 +- .../gpu/drm/ci/xfails/amdgpu-stoney-skips.txt | 1 + drivers/gpu/drm/ci/xfails/i915-aml

Re: [PATCH v5 08/16] drm/bridge: Add helper to reset bridge pipeline

2025-03-15 Thread Herve Codina
Hi Maxime, On Tue, 04 Mar 2025 12:10:51 +0100 Maxime Ripard wrote: > Let's provide an helper to make it easier for bridge drivers to > power-cycle their bridge. > > In order to avoid a circular dependency between that new helper and > drm_atomic_helper_reset_crtc(), this new helper will be in a

Re: [PATCH 08/11] arm64: dts: qcom: sc8180x: Rename AOSS_QMP to power-management

2025-03-15 Thread Dmitry Baryshkov
On Thu, Mar 06, 2025 at 07:11:20PM +0100, Konrad Dybcio wrote: > From: Konrad Dybcio > > The node is currently named power-controller, which requires the device > underneath is a power domain provider. Rename it to align with other > SoCs and resolve this sort of warnings: > > power-controller@c

Re: [PATCH rc] gpu: host1x: Do not assume that a NULL domain means no DMA IOMMU

2025-03-15 Thread Diogo Ivo
Hello again, On 2/4/25 7:18 PM, Jason Gunthorpe wrote: Previously with tegra-smmu, even with CONFIG_IOMMU_DMA, the default domain could have been left as NULL. The NULL domain is specially recognized by host1x_iommu_attach() as meaning it is not the DMA domain and should be replaced with the s

Re: [RFC v3 05/33] rust: drm/kms: Add drm_plane bindings

2025-03-15 Thread Maxime Ripard
On Wed, Mar 05, 2025 at 05:59:21PM -0500, Lyude Paul wrote: > The next step is adding a set of basic bindings to create a plane, which > has to happen before we can create a CRTC (since we need to be able to at > least specify a primary plane for a CRTC upon creation). This mostly > follows the sam

Re: (subset) [PATCH v2 7/9] backlight: pcf50633-backlight: Remove

2025-03-15 Thread Lee Jones
On Tue, 11 Mar 2025 01:49:57 +, li...@treblig.org wrote: > The pcf50633 was used as part of the OpenMoko devices but > the support for its main chip was recently removed in: > commit 61b7f8920b17 ("ARM: s3c: remove all s3c24xx support") > > See https://lore.kernel.org/all/Z8z236h4B5A6Ki3D@gall

Re: [PATCH 1/5] drm/dp: Pull drm_dp_link_power_up/down from Tegra to common drm_dp_helper

2025-03-15 Thread Dmitry Baryshkov
On Fri, Mar 14, 2025 at 11:38:40AM +0800, Andy Yan wrote: > From: Andy Yan > > The helper functions drm_dp_link_power_up/down were moved to Tegra > DRM at 2019[0]. Just mention commit here like "in the commit 9a42c7c647a9 ("drm/tegra: Move drm_dp_link helpers to Tegra DRM")" > > Now since more

[PATCH v5 1/3] drm/i915: Downgrade device register error if injected

2025-03-15 Thread Janusz Krzysztofik
Commit 8f460e2c78f2 ("drm/i915: Demidlayer driver loading") which introduced manual device registration also added a message that is submitted on device registration failure as an error. If that failure is triggered by error injection test, that's an expected error, but CI still reports it as a bu

Re: [PATCH v5 0/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2025-03-15 Thread Pavel Machek
Hi! > > Comments from previous review were not addressed. > > > > Most importantly, this is not a way to do kernel interface. We want > > reasonable interface that can be documented and modified as needed. We > > want to pass /dev/input to userspace, not raw HID. This is not ok. > > There are al

Re: [RFC v3 27/33] rust: drm/kms: Add DriverCrtc::atomic_begin() and atomic_flush()

2025-03-15 Thread Maxime Ripard
On Wed, Mar 05, 2025 at 05:59:43PM -0500, Lyude Paul wrote: > Optional trait methods for implementing the atomic_begin and atomic_flush > callbacks for a CRTC. > > Signed-off-by: Lyude Paul > --- > rust/kernel/drm/kms/crtc.rs | 90 - > 1 file changed, 88 inser

Re: [PATCH v7 10/11] drm/bridge: ti-sn65dsi83: use dynamic lifetime management

2025-03-15 Thread Maxime Ripard
On Fri, 14 Mar 2025 11:31:23 +0100, Luca Ceresoli wrote: > Allow this bridge to be removable without dangling pointers and > use-after-free, together with proper use of drm_bridge_get() and _put() by > consumers. > > Signed-off-by: Luca Ceresoli > > [ ... ] Reviewed-by: Maxime Ripard Thanks!

Re: [PATCH 0/3] rust: alloc: add Vec::resize and Vec::truncate

2025-03-15 Thread Danilo Krummrich
Hi Andrew, On Fri, Mar 14, 2025 at 09:42:32PM -0500, Andrew Ballance wrote: > This patch series implements the Vec::truncate and Vec::resize methods > that were needed by the nova driver and removes the corresponding item > from their task list > > Andrew Ballance (3): > rust: alloc: add Vec::t

  1   2   >