[PATCH v2 04/10] dt-bindings: display/msm: qcom,sc7280-dpu: describe SAR2130P

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Describe DPU controller present on Qualcomm SAR2130P platform. Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/msm/qcom,sc7280-dpu.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devic

Re: [PATCH v4 4/7] dt-bindings: gpu: v3d: Add per-compatible register restrictions

2025-03-13 Thread Maíra Canal
+Cc Stefan Hi Krzysztof, On 13/03/25 12:03, Krzysztof Kozlowski wrote: On 13/03/2025 15:43, Maíra Canal wrote: In order to enforce per-SoC register rules, add per-compatible restrictions. V3D 3.3 (represented by brcm,7268-v3d) has a cache controller (GCA), which is not present in other V3D gen

[PATCH RFC v4 2/6] drm/display: dp: change drm_dp_dpcd_read_link_status() return value

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov drm_dp_dpcd_read_link_status() follows the "return error code or number of bytes read" protocol, with the code returning less bytes than requested in case of some errors. However most of the drivers interpreted that as "return error code in case of any error". Switch drm_dp

[PATCH v2 07/10] drm/msm/dsi/phy: add configuration for SAR2130P

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Qualcomm SAR2130P requires slightly different setup for the DSI PHY. It is a 5nm PHY (like SM8450), so supplies are the same, but the rest of the configuration is the same as SM8550 DSI PHY. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c |

[PATCH v2 10/10] arm64: dts: qcom: sar2130p: add display nodes

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Add display controller, two DSI hosts, two DSI PHYs and a single DP controller. Link DP to the QMP Combo PHY. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sar2130p.dtsi | 394 + 1 file changed, 394 insertions(+) diff --git

Re: [PATCH] drm/msm/dpu: Fix error pointers in dpu_plane_virtual_atomic_check

2025-03-13 Thread Dmitry Baryshkov
On Thu, Mar 13, 2025 at 08:10:04PM -0500, Chenyuan Yang wrote: > The function dpu_plane_virtual_atomic_check was dereferencing pointers > returned by drm_atomic_get_plane_state without checking for errors. This > could lead to undefined behavior if the function returns an error pointer. > > This c

[PATCH v2] fbcon: Use static attribute groups for sysfs entries

2025-03-13 Thread oushixiong1025
From: Shixiong Ou Using device_create_with_groups() to simplify creation and removal. Same as commit 1083a7be4504 ("tty: Use static attribute groups for sysfs entries"). Signed-off-by: Shixiong Ou --- drivers/video/fbdev/core/fbcon.c | 69 +--- 1 file changed, 19 in

[PATCH v2 09/10] iommu/arm-smmu-qcom: Add SAR2130P MDSS compatible

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Add the SAR2130P compatible to clients compatible list, the device require identity domain. Signed-off-by: Dmitry Baryshkov --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/dr

[PATCH v2 08/10] drm/msm/dpu: add catalog entry for SAR2130P

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Add DPU driver support for the Qualcomm SAR2130P platform. It is mostly the same as SM8550, minor differences in the CDP configuration. Signed-off-by: Dmitry Baryshkov --- .../drm/msm/disp/dpu1/catalog/dpu_9_1_sar2130p.h | 434 + drivers/gpu/drm/msm

[PATCH v2 05/10] dt-bindings: display/msm: Add Qualcomm SAR2130P

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Describe the Mobile Display SubSystem (MDSS) device present on the Qualcomm SAR2130P platform. It looks pretty close to SM8550 on the system level. SAR2130P features two DSI hosts and single DisplayPort controller. Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Ko

[PATCH v2 06/10] drm/msm/mdss: add SAR2130P device configuration

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Add compatible and device configuration for the Qualcomm SAR2130P platform. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c

[PATCH v2 03/10] dt-bindings: display/msm: dsi-phy-7nm: describe SAR2130P

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Describe MIPI DSI PHY present on Qualcomm SAR2130P platform. Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/

[PATCH v2 01/10] dt-bindings: display/msm: dp-controller: describe SAR2130P

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Describe DisplayPort controller present on Qualcomm SAR2130P platform. Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation

[PATCH v2 00/10] drm/msm: add support for SAR2130P

2025-03-13 Thread Dmitry Baryshkov
Add support for the Mobile Display SubSystem (MDSS) device present on the Qualcomm SAR2130P platform. The MDSS device is similar to SM8550, it features two MIPI DSI controllers, two MIPI DSI PHYs and one DisplayPort controller. Note, due to the technical limitations DP controller wasn't completely

Re: [PATCH v5 04/16] drm/atomic: Introduce helper to lookup connector by encoder

2025-03-13 Thread Dmitry Baryshkov
On Fri, Mar 14, 2025 at 08:50:29AM +0800, Andy Yan wrote: > > Hi Maxime and Simona, > > > At 2025-03-13 19:55:33, "Maxime Ripard" wrote: > >Hi, > > > >On Thu, Mar 13, 2025 at 04:09:54PM +0800, Andy Yan wrote: > >> At 2025-03-05 19:55:19, "Andy Yan" wrote: > >> >At 2025-03-04 19:10:47, "Maxime

[PATCH RFC v4 5/6] drm/display: dp-mst-topology: use new DCPD access helpers

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Switch drm_dp_mst_topology.c to use new set of DPCD read / write helpers. Reviewed-by: Lyude Paul Acked-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dp_mst_topology.c | 105 +- 1 file changed, 51 insertions(+),

[PATCH RFC v4 4/6] drm/display: dp-cec: use new DCPD access helpers

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Switch drm_dp_cec.c to use new set of DPCD read / write helpers. Reviewed-by: Lyude Paul Acked-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dp_cec.c | 37 ++-- 1 file changed, 18 insertions(+), 19 delet

[PATCH RFC v4 3/6] drm/display: dp: use new DCPD access helpers

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Switch drm_dp_helper.c to use new set of DPCD read / write helpers. Reviewed-by: Lyude Paul Acked-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dp_helper.c | 296 +--- 1 file changed, 116 insertions(+), 180

[PATCH RFC v4 0/6] drm/display: dp: add new DPCD access functions

2025-03-13 Thread Dmitry Baryshkov
Existing DPCD access functions return an error code or the number of bytes being read / write in case of partial access. However a lot of drivers either (incorrectly) ignore partial access or mishandle error codes. In other cases this results in a boilerplate code which compares returned value with

[PATCH RFC v4 1/6] drm/display: dp: implement new access helpers

2025-03-13 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Existing DPCD access functions return an error code or the number of bytes being read / write in case of partial access. However a lot of drivers either (incorrectly) ignore partial access or mishandle error codes. In other cases this results in a boilerplate code which com

Re: [PATCH 5/5] drm/bridge: it6505: Switch to common helpers to power up/down dp link

2025-03-13 Thread Dmitry Baryshkov
On Fri, Mar 14, 2025 at 11:38:44AM +0800, Andy Yan wrote: > From: Andy Yan > > Use the common dp link power up/down helpers to avoid duplicating code. > > Signed-off-by: Andy Yan > --- > > drivers/gpu/drm/bridge/ite-it6505.c | 46 +++-- > 1 file changed, 4 insertions(+

Re: [PATCH 4/5] drm/bridge: anx78xx: Switch to common helpers to power up/down dp link

2025-03-13 Thread Dmitry Baryshkov
On Fri, Mar 14, 2025 at 11:38:43AM +0800, Andy Yan wrote: > From: Andy Yan > > Use the common dp link power up/down helpers to avoid duplicating code. > > Signed-off-by: Andy Yan > --- > > .../drm/bridge/analogix/analogix-anx78xx.c| 30 +-- > 1 file changed, 1 insertion(+)

Re: [PATCH 3/5] drm/bridge: anx6345: Switch to common helpers to power up/down dp link

2025-03-13 Thread Dmitry Baryshkov
On Fri, Mar 14, 2025 at 11:38:42AM +0800, Andy Yan wrote: > From: Andy Yan > > Use the common dp link power up/down helpers to avoid duplicating code. > > Signed-off-by: Andy Yan > --- > > .../drm/bridge/analogix/analogix-anx6345.c| 30 +-- > 1 file changed, 1 insertion(+)

Re: [PATCH 2/5] drm/bridge: cdns-mhdp8546: Switch to common helpers to power up/down dp link

2025-03-13 Thread Dmitry Baryshkov
On Fri, Mar 14, 2025 at 11:38:41AM +0800, Andy Yan wrote: > From: Andy Yan > > Use the common dp link power up/down helpers to avoid duplicating code. > > Signed-off-by: Andy Yan > --- > > .../drm/bridge/cadence/cdns-mhdp8546-core.c | 74 +-- > 1 file changed, 2 insertions(+

[PATCH] drm/panel/synaptics-r63353: Use _multi variants

2025-03-13 Thread Anusha Srivatsa
Move away from using deprecated API and use _multi variants if available. Use mipi_dsi_msleep() and mipi_dsi_usleep_range() instead of msleep() and usleep_range() respectively. Used Coccinelle to find the _multi variant APIs, replacing mpi_dsi_msleep() where necessary and for returning dsi_ctx.acc

Re: [PATCH v2 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Aditya Garg
> On 13 Mar 2025, at 4:49 PM, Aditya Garg wrote: > > From: Hector Martin > > %p4cc is designed for DRM/V4L2 FourCCs with their specific quirks, but > it's useful to be able to print generic 4-character codes formatted as > an integer. Extend it to add format specifiers for printing generic >

[PATCH 3/5] drm/bridge: anx6345: Switch to common helpers to power up/down dp link

2025-03-13 Thread Andy Yan
From: Andy Yan Use the common dp link power up/down helpers to avoid duplicating code. Signed-off-by: Andy Yan --- .../drm/bridge/analogix/analogix-anx6345.c| 30 +-- 1 file changed, 1 insertion(+), 29 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx

[PATCH 1/5] drm/dp: Pull drm_dp_link_power_up/down from Tegra to common drm_dp_helper

2025-03-13 Thread Andy Yan
From: Andy Yan The helper functions drm_dp_link_power_up/down were moved to Tegra DRM at 2019[0]. Now since more and more users are duplicating the same code in their own drivers, it's time to make them as DRM DP common helpers again. [0]https://patchwork.freedesktop.org/patch/336850/?series=68

[PATCH 4/5] drm/bridge: anx78xx: Switch to common helpers to power up/down dp link

2025-03-13 Thread Andy Yan
From: Andy Yan Use the common dp link power up/down helpers to avoid duplicating code. Signed-off-by: Andy Yan --- .../drm/bridge/analogix/analogix-anx78xx.c| 30 +-- 1 file changed, 1 insertion(+), 29 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx

[PATCH 2/5] drm/bridge: cdns-mhdp8546: Switch to common helpers to power up/down dp link

2025-03-13 Thread Andy Yan
From: Andy Yan Use the common dp link power up/down helpers to avoid duplicating code. Signed-off-by: Andy Yan --- .../drm/bridge/cadence/cdns-mhdp8546-core.c | 74 +-- 1 file changed, 2 insertions(+), 72 deletions(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp854

[PATCH 5/5] drm/bridge: it6505: Switch to common helpers to power up/down dp link

2025-03-13 Thread Andy Yan
From: Andy Yan Use the common dp link power up/down helpers to avoid duplicating code. Signed-off-by: Andy Yan --- drivers/gpu/drm/bridge/ite-it6505.c | 46 +++-- 1 file changed, 4 insertions(+), 42 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/driv

dri-devel@lists.freedesktop.org

2025-03-13 Thread Doug Anderson
Hi, On Mon, Mar 10, 2025 at 3:42 AM Damon Ding wrote: > > Add analogix_dpaux_wait_hpd_asserted() to help confirm the HPD state > before doing AUX transfers. > > Signed-off-by: Damon Ding > --- > .../drm/bridge/analogix/analogix_dp_core.c| 21 +++ > 1 file changed, 21 inserti

Re: [PATCH v8 06/13] drm/bridge: analogix_dp: Add support to get panel from the DP AUX bus

2025-03-13 Thread Doug Anderson
Hi, On Mon, Mar 10, 2025 at 3:42 AM Damon Ding wrote: > > The main modification is moving the DP AUX initialization from function > analogix_dp_bind() to analogix_dp_probe(). In order to get the EDID of > eDP panel during probing, it is also needed to advance PM operations to > ensure that eDP co

Re: [PATCH v8 08/13] drm/rockchip: analogix_dp: Add support to get panel from the DP AUX bus

2025-03-13 Thread Doug Anderson
Hi, On Mon, Mar 10, 2025 at 3:42 AM Damon Ding wrote: > > Move drm_of_find_panel_or_bridge() a little later and combine it with > component_add() into a new function rockchip_dp_link_panel(). The function > will serve as done_probing() callback of devm_of_dp_aux_populate_bus(), > aiding to suppor

Re:Re: [PATCH v5 04/16] drm/atomic: Introduce helper to lookup connector by encoder

2025-03-13 Thread Andy Yan
Hi Maxime and Simona, At 2025-03-13 19:55:33, "Maxime Ripard" wrote: >Hi, > >On Thu, Mar 13, 2025 at 04:09:54PM +0800, Andy Yan wrote: >> At 2025-03-05 19:55:19, "Andy Yan" wrote: >> >At 2025-03-04 19:10:47, "Maxime Ripard" wrote: >> >>With the bridges switching over to drm_bridge_connector,

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Kees Cook
On March 13, 2025 10:42:10 AM PDT, Aditya Garg wrote: >I already sent the 1st patch to DRM. I can rebase the test-printf bit to this >tree. Sounds good? Yeah, sounds good to me! Thanks :) -Kees -- Kees Cook

Re: [PATCH v3 01/16] bitops: Change parity8() return type to bool

2025-03-13 Thread Jacob Keller
On 3/13/2025 9:36 AM, H. Peter Anvin wrote: > On March 13, 2025 9:24:38 AM PDT, Yury Norov wrote: >> On Wed, Mar 12, 2025 at 05:09:16PM -0700, H. Peter Anvin wrote: >>> On March 12, 2025 4:56:31 PM PDT, Jacob Keller >>> wrote: >> >> [...] >> This is really a question of whether you expec

Re: [PATCH RFC 1/2] drm/panel: Add new helpers for refcounted panel allocatons

2025-03-13 Thread Anusha Srivatsa
On Thu, Mar 13, 2025 at 6:10 AM Luca Ceresoli wrote: > Hello Anusha, > > On Wed, 12 Mar 2025 20:54:42 -0400 > Anusha Srivatsa wrote: > > > Introduce reference counted allocations for panels to avoid > > use-after-free. The patch adds the macro devm_drm_bridge_alloc() > > to allocate a new refcou

Re: [PATCH 03/11] dt-bindings: power: qcom,kpss-acc-v2: Add MSM8916 compatible

2025-03-13 Thread Bjorn Andersson
On Wed, Mar 12, 2025 at 04:12:14PM +0100, Krzysztof Kozlowski wrote: > On 06/03/2025 19:11, Konrad Dybcio wrote: > > From: Konrad Dybcio > > > > MSM8916 seems to reuse the same hardware as MSM8974 and friends (for > > whom this binding document was created). Add a new compatible for it. > > > >

[PATCH v2] drm: Add UAPI for the Asahi driver

2025-03-13 Thread Alyssa Rosenzweig
This adds the UAPI for the Asahi driver targeting the GPU in the Apple M1 and M2 series systems on chip. The UAPI design is based on other modern Vulkan-capable drivers, including Xe and Panthor. Memory management is based on explicit VM management. Synchronization is exclusively explicit sync. Th

Re: [PATCH v2] drm/panel/synaptics-r63353: Use _multi variants

2025-03-13 Thread Anusha Srivatsa
On Wed, Mar 12, 2025 at 8:22 PM Doug Anderson wrote: > Hi, > > On Wed, Mar 12, 2025 at 5:00 PM Anusha Srivatsa > wrote: > > > > > > > > On Wed, Mar 12, 2025 at 11:48 AM Doug Anderson > wrote: > >> > >> Hi, > >> > >> On Wed, Mar 12, 2025 at 8:06 AM Anusha Srivatsa > wrote: > >> > > >> >> > @@ -

Re: [PATCH v8 3/6] drm/xe/uapi: Define drm_xe_vm_get_property

2025-03-13 Thread Jianxun Zhang
On 3/13/25 11:34, Jonathan Cavitt wrote: Add initial declarations for the drm_xe_vm_get_property ioctl. Signed-off-by: Jonathan Cavitt --- include/uapi/drm/xe_drm.h | 69 +++ 1 file changed, 69 insertions(+) diff --git a/include/uapi/drm/xe_drm.h b/inc

Re: [PATCH v4 00/14] Add support for suppressing warning backtraces

2025-03-13 Thread Andrew Morton
On Thu, 13 Mar 2025 11:31:12 -0700 Guenter Roeck wrote: > On Thu, Mar 13, 2025 at 06:24:25PM +0100, Maxime Ripard wrote: > > > > > > Yeah, as with my prior review, I'm a fan of this. It makes a bunch of my > > > very noisy tests much easier to deal with. > > > > And for the record, we're also a

[PATCH v8 3/6] drm/xe/uapi: Define drm_xe_vm_get_property

2025-03-13 Thread Jonathan Cavitt
Add initial declarations for the drm_xe_vm_get_property ioctl. Signed-off-by: Jonathan Cavitt --- include/uapi/drm/xe_drm.h | 69 +++ 1 file changed, 69 insertions(+) diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h index 616916985e3f..0ed52

Re: [PATCH RFC 1/2] drm/panel: Add new helpers for refcounted panel allocatons

2025-03-13 Thread Anusha Srivatsa
On Thu, Mar 13, 2025 at 10:42 AM Maxime Ripard wrote: > Hi Anusha, > > In addition to the feedback Luca already provided, I have a few comments > > On Wed, Mar 12, 2025 at 08:54:42PM -0400, Anusha Srivatsa wrote: > > Introduce reference counted allocations for panels to avoid > > use-after-free.

Re: [PATCH v4 1/7] drm/v3d: Don't run jobs that have errors flagged in its fence

2025-03-13 Thread Maíra Canal
On 13/03/25 11:43, Maíra Canal wrote: The V3D driver still relies on `drm_sched_increase_karma()` and `drm_sched_resubmit_jobs()` for resubmissions when a timeout occurs. The function `drm_sched_increase_karma()` marks the job as guilty, while `drm_sched_resubmit_jobs()` sets an error (-ECANCELED

drm-ci: mediatek: kms_atomic_transition@plane-toggle-modeset-transition flake

2025-03-13 Thread Vignesh Raman
Hi Maintainers, There are some flake test reported for mediatek driver testing in drm-ci. # Board Name: mt8183-kukui-jacuzzi-juniper-sku16 # Failure Rate: 20 # IGT Version: 1.30-g04bedb923 # Linux Version: 6.14.0-rc4 kms_atomic_transition@plane-toggle-modeset-transition 11:13:54.607: DEBUG - Be

Re: [PATCH RFC 1/3] rust: core abstractions for HID drivers

2025-03-13 Thread Danilo Krummrich
On Thu, Mar 13, 2025 at 04:03:35PM +, Rahul Rameshbabu wrote: > These abstractions enable the development of HID drivers in Rust by binding > with the HID core C API. They provide Rust types that map to the > equivalents in C. In this initial draft, only hid_device and hid_device_id > are provi

Re: [PATCH RFC 0/3] Initial work for Rust abstraction for HID device driver development

2025-03-13 Thread Benno Lossin
On Thu Mar 13, 2025 at 5:02 PM CET, Rahul Rameshbabu wrote: > Hello, > > I am a hobbyist developer who has been working on a project to create a new > Rust > HID device driver and the needed core abstractions for writing more HID device > drivers in Rust. My goal is to support the USB Monitor Cont

[PATCH v8 6/6] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-13 Thread Jonathan Cavitt
Add support for userspace to request a list of observed faults from a specified VM. v2: - Only allow querying of failed pagefaults (Matt Brost) v3: - Remove unnecessary size parameter from helper function, as it is a property of the arguments. (jcavitt) - Remove unnecessary copy_from_user (Jain

Re: [PATCH v1 5/6] drm/panfrost: Enable AARCH64_4K page table format on mediatek_mt8188

2025-03-13 Thread Ariel D'Alessandro
Boris, On 3/11/25 5:06 AM, Boris Brezillon wrote: On Mon, 10 Mar 2025 16:59:20 -0300 Ariel D'Alessandro wrote: Now that Panfrost supports AARCH64_4K page table format, let's enable it on Mediatek MT8188. Can you maybe give more details on why this is needed (legacy shareability/cacheability

[PATCH v8 0/6] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-13 Thread Jonathan Cavitt
Add additional information to each VM so they can report up to the first 50 seen faults. Only pagefaults are saved this way currently, though in the future, all faults should be tracked by the VM for future reporting. Additionally, of the pagefaults reported, only failed pagefaults are saved this

Re: [PATCH v2 2/2] drm/display: hdmi: Mention Infoframes testing with edid-decode

2025-03-13 Thread Hans Verkuil
On 12/03/2025 14:39, Maxime Ripard wrote: > edid-decode gained recently support to check that infoframes are > compliant and match the EDID the monitor exposes. > > Since the HDMI helpers provide those infoframes in debugfs, it makes it > easy to check from userspace that the drivers (and helpers)

[PATCH v8 5/6] drm/xe/xe_vm: Add per VM fault info

2025-03-13 Thread Jonathan Cavitt
Add additional information to each VM so they can report up to the first 50 seen faults. Only pagefaults are saved this way currently, though in the future, all faults should be tracked by the VM for future reporting. Additionally, of the pagefaults reported, only failed pagefaults are saved this

[PATCH v8 2/6] drm/xe/xe_gt_pagefault: Move pagefault struct to header

2025-03-13 Thread Jonathan Cavitt
Move the pagefault struct from xe_gt_pagefault.c to the xe_gt_pagefault_types.h header file, along with the associated enum values. v2: - Normalize names for common header (Matt Brost) v3: - s/Migrate/Move (Michal W) - s/xe_pagefault/xe_gt_pagefault (Michal W) - Create new header file, xe_gt_page

[PATCH v8 1/6] drm/xe/xe_gt_pagefault: Disallow writes to read-only VMAs

2025-03-13 Thread Jonathan Cavitt
The page fault handler should reject write/atomic access to read only VMAs. Add code to handle this in handle_pagefault after the VMA lookup. Fixes: 3d420e9fa848 ("drm/xe: Rework GPU page fault handling") Signed-off-by: Jonathan Cavitt Suggested-by: Matthew Brost --- drivers/gpu/drm/xe/xe_gt_p

[PATCH v8 4/6] drm/xe/xe_gt_pagefault: Add address_type field to pagefaults

2025-03-13 Thread Jonathan Cavitt
Add a new field to the xe_pagefault struct, address_type, that tracks the type of fault the pagefault incurred. Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/xe/xe_gt_pagefault.c | 3 +++ drivers/gpu/drm/xe/xe_gt_pagefault_types.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a

Re: [PATCH v4 00/14] Add support for suppressing warning backtraces

2025-03-13 Thread Guenter Roeck
On Thu, Mar 13, 2025 at 06:24:25PM +0100, Maxime Ripard wrote: > > > > Yeah, as with my prior review, I'm a fan of this. It makes a bunch of my > > very noisy tests much easier to deal with. > > And for the record, we're also affected by this in DRM and would very > much like to get it merged in

Re: [PATCH RFC 06/12] dma: direct: Provide accessor to dmem region

2025-03-13 Thread Maxime Ripard
On Mon, Mar 10, 2025 at 06:44:51PM +, Robin Murphy wrote: > On 2025-03-10 4:28 pm, Maxime Ripard wrote: > > On Mon, Mar 10, 2025 at 02:56:37PM +, Robin Murphy wrote: > > > On 2025-03-10 12:06 pm, Maxime Ripard wrote: > > > > Consumers of the direct DMA API will have to know which region the

Re: [PATCH v6 14/26] drm/bridge: add support for refcounted DRM bridges

2025-03-13 Thread Maxime Ripard
On Thu, Mar 13, 2025 at 12:56:56PM +0100, Luca Ceresoli wrote: > Hello Maxime, > > On Fri, 7 Feb 2025 12:47:51 +0100 > Maxime Ripard wrote: > > On Thu, Feb 06, 2025 at 07:14:29PM +0100, Luca Ceresoli wrote: > > > DRM bridges are currently considered as a fixed element of a DRM card, and > > > thu

[PULL] drm-misc-next-fixes

2025-03-13 Thread Thomas Zimmermann
Hi Dave, Sima, here's the first PR from drm-misc-next-fixes for this release cycle. Just one patch this week. Best regards Thomas drm-misc-next-fixes-2025-03-13: Short summary of fixes pull: appletbdrm: - Fix device refcount The following changes since commit d65a27f95f6ab236b1a788d9bc463d24a8b

Re: [PATCH v2 02/10] dt-bindings: msm: dsi-controller-main: document the SA8775P DSI CTRL

2025-03-13 Thread Ayushi Makhija
On 3/12/2025 5:14 PM, Krzysztof Kozlowski wrote: > On Tue, Mar 11, 2025 at 05:54:37PM +0530, Ayushi Makhija wrote: >> diff --git >> a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml >> b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml >> index ffbd

drm-ci: vkms: kms_flip@modeset-vs-vblank-race flake

2025-03-13 Thread Vignesh Raman
Hi Maintainers, There are some flake test reported for vkms driver testing in drm-ci. # Board Name: vkms # Failure Rate: 20 # IGT Version: 1.30-g04bedb923 # Linux Version: 6.14.0-rc4 kms_flip@modeset-vs-vblank-race DEBUG - Begin test kms_flip@modeset-vs-vblank-race ERROR - Igt error: (kms_flip:

[PATCH v4] drm: add modifiers for Apple GPU layouts

2025-03-13 Thread Alyssa Rosenzweig
Apple GPUs support non-linear "GPU-tiled" image layouts. Add modifiers for these layouts. Mesa requires these modifiers to share non-linear buffers across processes, but no other userspace or kernel support is required/expected. These layouts are notably not used for interchange across hardware bl

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Aditya Garg
Hi > On 13 Mar 2025, at 11:10 PM, Kees Cook wrote: > > On Thu, Mar 13, 2025 at 11:48:32AM +0100, Petr Mladek wrote: >> So I am fine with this patch: >> >> Reviewed-by: Petr Mladek >> Tested-by: Petr Mladek >> >> >> Now, the question is how to get this patch into the mainline. >> >> Normal

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Kees Cook
On Thu, Mar 13, 2025 at 11:48:32AM +0100, Petr Mladek wrote: > So I am fine with this patch: > > Reviewed-by: Petr Mladek > Tested-by: Petr Mladek > > > Now, the question is how to get this patch into the mainline. > > Normally, it would make perfect sense to queue it via the DRM tree > becau

Re: [PATCH v2] drm/mxsfb: fix missing rollback on failure in mxsfb_probe()

2025-03-13 Thread Thomas Zimmermann
r_unload; --- base-commit: f9f087d946266bc5da7c3a17bd8fd9d01969e3cf change-id: 20250313-mxsfb_probe-fix-rollback-on-error-3074b9080f34 Best regards, -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo

Re: [PATCH v4 00/14] Add support for suppressing warning backtraces

2025-03-13 Thread Maxime Ripard
Hi, On Thu, Mar 13, 2025 at 10:17:49AM -0700, Kees Cook wrote: > On Thu, Mar 13, 2025 at 11:43:15AM +, Alessandro Carminati wrote: > > Some unit tests intentionally trigger warning backtraces by passing bad > > parameters to kernel API functions. Such unit tests typically check the > > return

Re: [PATCH v4 9/9] drm/vkms: convert to use faux_device

2025-03-13 Thread José Expósito
On Thu, Mar 13, 2025 at 03:22:21PM +0100, Simona Vetter wrote: > On Wed, Mar 12, 2025 at 07:22:07AM +0100, Greg KH wrote: > > On Tue, Mar 11, 2025 at 06:20:53PM +0100, José Expósito wrote: > > > Hi everyone, > > > > > > > On Tue, Feb 25, 2025 at 02:51:40PM +0100, Louis Chauvet wrote: > > > > > >

Re: [PATCH v4 00/14] Add support for suppressing warning backtraces

2025-03-13 Thread Kees Cook
On Thu, Mar 13, 2025 at 11:43:15AM +, Alessandro Carminati wrote: > Some unit tests intentionally trigger warning backtraces by passing bad > parameters to kernel API functions. Such unit tests typically check the > return value from such calls, not the existence of the warning backtrace. Than

Re: [PATCH RFC 3/3] rust: hid: demo the core abstractions for probe and remove

2025-03-13 Thread Benjamin Tissoires
On Mar 13 2025, Rahul Rameshbabu wrote: > This is a very basic "hello, world!" implementation to illustrate that the > probe and remove callbacks are working as expected. I chose an arbitrary > device I had on hand for populating in the HID device id table. Nice to see this live :) Though as I me

Re: [PATCH RFC 2/3] rust: hid: USB Monitor Control Class driver

2025-03-13 Thread Benjamin Tissoires
On Mar 13 2025, Rahul Rameshbabu wrote: > This code will eventually contain the logic needed to drive the backlight > of displays that implement the USB Monitor Control Class specification. > Examples include the Apple Studio Display and Apple Pro Display XDR > monitors. USB Monitor Control Class e

Re: [PATCH v3 01/16] bitops: Change parity8() return type to bool

2025-03-13 Thread H. Peter Anvin
On March 13, 2025 9:24:38 AM PDT, Yury Norov wrote: >On Wed, Mar 12, 2025 at 05:09:16PM -0700, H. Peter Anvin wrote: >> On March 12, 2025 4:56:31 PM PDT, Jacob Keller >> wrote: > >[...] > >> >This is really a question of whether you expect odd or even parity as >> >the "true" value. I think that

Re: [PATCH v3 3/3] drm/tidss: Add support for AM62L display subsystem

2025-03-13 Thread Tomi Valkeinen
Hi, On 06/03/2025 15:29, Devarsh Thakkar wrote: Enable display for AM62L DSS [1] which supports only a single display pipeline using a single overlay manager, single video port and a single video lite pipeline which does not support scaling. The output of video port is routed to SoC boundary vi

Re: [PATCH RFC 1/3] rust: core abstractions for HID drivers

2025-03-13 Thread Benjamin Tissoires
On Mar 13 2025, Rahul Rameshbabu wrote: > These abstractions enable the development of HID drivers in Rust by binding > with the HID core C API. They provide Rust types that map to the > equivalents in C. In this initial draft, only hid_device and hid_device_id > are provided direct Rust type equiv

Re: [PATCH v3 00/11] backlight, lcd, led: Remove fbdev dependencies

2025-03-13 Thread Lee Jones
On Thu, 06 Mar 2025, Thomas Zimmermann wrote: > This series removes the remaining dependencies on fbdev from the > backlight, lcd and led subsystems. Each depends on fbdev events to > track display state. Make fbdev inform each subsystem via a dedicated > interface instead. > > Patches 1 to 3 mak

[PATCH RFC 2/3] rust: hid: USB Monitor Control Class driver

2025-03-13 Thread Rahul Rameshbabu
This code will eventually contain the logic needed to drive the backlight of displays that implement the USB Monitor Control Class specification. Examples include the Apple Studio Display and Apple Pro Display XDR monitors. USB Monitor Control Class encompasses more than just backlight control, so

Re: [PATCH v4 07/14] arm64: Add support for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
Hello Will, On Thu, Mar 13, 2025 at 1:25 PM Will Deacon wrote: > > On Thu, Mar 13, 2025 at 11:43:22AM +, Alessandro Carminati wrote: > > diff --git a/arch/arm64/include/asm/bug.h b/arch/arm64/include/asm/bug.h > > index 28be048db3f6..044c5e24a17d 100644 > > --- a/arch/arm64/include/asm/bug.h

[RFC PATCH 06/19] drm/pagemap, drm/xe: Add refcounting to struct drm_pagemap and manage lifetime

2025-03-13 Thread Thomas Hellström
Remove the xe embedded drm_pagemap, and instead allocate and reference count. This is a step towards adding drm_pagemaps on demand. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/drm_pagemap.c| 58 +++- drivers/gpu/drm/xe/xe_device_types.h | 2 +- drivers/gp

[PATCH v7 5/6] drm/xe/xe_gt_pagefault: Add address_type field to pagefaults

2025-03-13 Thread Jonathan Cavitt
Add a new field to the xe_pagefault struct, address_type, that tracks the type of fault the pagefault incurred. Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/xe/xe_gt_pagefault.c | 3 +++ drivers/gpu/drm/xe/xe_gt_pagefault.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-13 Thread Aditya Garg
> On 13 Mar 2025, at 2:19 PM, Andy Shevchenko > wrote: > > On Thu, Mar 13, 2025 at 07:26:05AM +, Aditya Garg wrote: On 13 Mar 2025, at 12:58 AM, Andy Shevchenko wrote: >>> On Wed, Mar 12, 2025 at 07:14:36PM +, Aditya Garg wrote: > On 12 Mar 2025, at 9:05 PM, Sven Peter

[PATCH] drm/komeda: Remove unnecessary NULL check before clk_prepare_enable()

2025-03-13 Thread Chen Ni
clk_prepare_enable() already checked NULL clock parameter. Remove unneeded NULL check for clk here. Signed-off-by: Chen Ni --- drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/

[PULL] drm-xe-fixes

2025-03-13 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes xe fixes for this week. It is worth mention that we are disabling D3Cold on BMG because we found some bugs where depending on the combination of BMG card and the host, the PCI upstream port link port re-training might fail on D3Cold -> D0 blowing things up. But while w

Re: [PATCH RFC 0/3] Initial work for Rust abstraction for HID device driver development

2025-03-13 Thread Benjamin Tissoires
Hi, [quick reply because I am completely under the water for the next 2 weeks] On Mar 13 2025, Rahul Rameshbabu wrote: > Hello, > > I am a hobbyist developer who has been working on a project to create a new > Rust > HID device driver and the needed core abstractions for writing more HID device

Re: [PATCH v3 01/16] bitops: Change parity8() return type to bool

2025-03-13 Thread Yury Norov
On Fri, Mar 07, 2025 at 11:33:40AM -0800, H. Peter Anvin wrote: > On March 7, 2025 11:30:08 AM PST, Yury Norov wrote: [...] > >> Instead of "bool" think of it as "bit" and it makes more sense > > > >So, to help people thinking that way we can introduce a corresponding > >type: > >typedef

[PULL] drm-intel-fixes

2025-03-13 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes i915 fixes for this week. The most interesting seems to be a bump in the MMAP_GTT_VERSION to indicate a missing support for partial mmaps, which had been previously introduced by commit 255fc1703e42 ("drm/i915/gem: Calculate object page offset for partial memory mappin

Re: [PATCH v3 01/16] bitops: Change parity8() return type to bool

2025-03-13 Thread Yury Norov
On Wed, Mar 12, 2025 at 05:09:16PM -0700, H. Peter Anvin wrote: > On March 12, 2025 4:56:31 PM PDT, Jacob Keller > wrote: [...] > >This is really a question of whether you expect odd or even parity as > >the "true" value. I think that would depend on context, and we may not > >reach a good cons

Re: [PATCH] drm/ttm/tests: fix potential null pointer dereference in ttm_bo_unreserve_bulk()

2025-03-13 Thread Qasim Ijaz
On Thu, Mar 13, 2025 at 03:20:34PM +0100, Christian König wrote: > Am 11.03.25 um 20:01 schrieb Qasim Ijaz: > > In the ttm_bo_unreserve_bulk() test function, resv is allocated > > using kunit_kzalloc(), but the subsequent assertion mistakenly > > verifies the ttm_dev pointer instead of checking t

Re: [PATCH v5 5/7] test_bits: add tests for __GENMASK() and __GENMASK_ULL()

2025-03-13 Thread Lucas De Marchi
On Thu, Mar 13, 2025 at 03:00:34PM +0900, Vincent Mailhol wrote: On 13/03/2025 at 13:13, Lucas De Marchi wrote: On Thu, Mar 06, 2025 at 08:29:56PM +0900, Vincent Mailhol via B4 Relay wrote: From: Vincent Mailhol The definitions of GENMASK() and GENMASK_ULL() do not depend any more on __GENMAS

[PATCH v4 5/7] dt-bindings: gpu: v3d: Add SMS register to BCM2712 compatible

2025-03-13 Thread Maíra Canal
V3D 7.1 exposes a new register block, called V3D_SMS. As BCM2712 has a V3D 7.1 core, add a new register item to its compatible. Similar to the GCA, which is specific for V3D 3.3, SMS should only be added for V3D 7.1 variants (such as brcm,2712-v3d). Signed-off-by: Maíra Canal --- Documentation/d

[PATCH] drm/ttm/tests: fix incorrect assert in ttm_bo_unreserve_bulk()

2025-03-13 Thread Qasim Ijaz
In the ttm_bo_unreserve_bulk() test function, resv is allocated using kunit_kzalloc(), but the subsequent assertion mistakenly verifies the ttm_dev pointer instead of the resv pointer. Fix the assertion to properly verify the resv pointer. Signed-off-by: Qasim Ijaz --- drivers/gpu/drm/ttm/tests

[PATCH RFC 1/3] rust: core abstractions for HID drivers

2025-03-13 Thread Rahul Rameshbabu
These abstractions enable the development of HID drivers in Rust by binding with the HID core C API. They provide Rust types that map to the equivalents in C. In this initial draft, only hid_device and hid_device_id are provided direct Rust type equivalents. hid_driver is specially wrapped with a c

[PATCH RFC 3/3] rust: hid: demo the core abstractions for probe and remove

2025-03-13 Thread Rahul Rameshbabu
This is a very basic "hello, world!" implementation to illustrate that the probe and remove callbacks are working as expected. I chose an arbitrary device I had on hand for populating in the HID device id table. [ +0.012968] monitor_control: Probing HID device vendor: 2389 product: 29204 using

[PATCH RFC 0/3] Initial work for Rust abstraction for HID device driver development

2025-03-13 Thread Rahul Rameshbabu
Hello, I am a hobbyist developer who has been working on a project to create a new Rust HID device driver and the needed core abstractions for writing more HID device drivers in Rust. My goal is to support the USB Monitor Control Class needed for functionality such as backlight control for monitor

Re: [RFC PATCH 00/19] drm, drm/xe: Multi-device GPUSVM

2025-03-13 Thread Thomas Hellström
On Thu, 2025-03-13 at 13:57 +0100, Christian König wrote: > Am 13.03.25 um 13:50 schrieb Thomas Hellström: > > Hi, Christian > > > > On Thu, 2025-03-13 at 11:19 +0100, Christian König wrote: > > > Am 12.03.25 um 22:03 schrieb Thomas Hellström: > > > > This RFC implements and requests comments for

Re: [PATCH] drm/amdgpu/gfx12: correct cleanup of 'me' field with gfx_v12_0_me_fini()

2025-03-13 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Mar 12, 2025 at 6:09 AM Wentao Liang wrote: > > In gfx_v12_0_cp_gfx_load_me_microcode_rs64(), gfx_v12_0_pfp_fini() is > incorrectly used to free 'me' field of 'gfx', since gfx_v12_0_pfp_fini() > can only release 'pfp' field of 'gfx'. The release function of 'me' fi

Re: [PATCH] drm/komeda: Remove unnecessary NULL check before clk_prepare_enable()

2025-03-13 Thread Liviu Dudau
On Thu, Mar 13, 2025 at 04:29:07PM +0800, Chen Ni wrote: > clk_prepare_enable() already checked NULL clock parameter. > Remove unneeded NULL check for clk here. You're not saving anything here. If mdev->aclk is NULL you still end up calling clk_prepare() and clk_enable() even if they return zero i

Re: [PATCH] drm/amdgpu/gfx12: correct cleanup of 'me' field with gfx_v12_0_me_fini()

2025-03-13 Thread Markus Elfring
… > can only release 'pfp' field of 'gfx'. The release function of 'me' field > should be gfx_v12_0_me_fini(). Do you care for an imperative wording in such a change description? https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rs

Re: [PATCH] drm/amd/display: avoid NPD when ASIC does not support DMUB

2025-03-13 Thread Alex Deucher
Applied. Thanks. Alex On Thu, Mar 13, 2025 at 11:17 AM Leo Li wrote: > > > > On 2025-03-13 07:29, Thadeu Lima de Souza Cascardo wrote: > > On Wed, Feb 05, 2025 at 10:06:38AM -0300, Thadeu Lima de Souza Cascardo > > wrote: > >> ctx->dmub_srv will de NULL if the ASIC does not support DMUB, which

[PATCH v8 6/6] drm/sched: Add a basic test for checking credit limit

2025-03-13 Thread Tvrtko Ursulin
Add a basic test for checking whether scheduler respects the configured credit limit. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stanner Acked-by: Christian König --- drivers/gpu/drm/scheduler/tests/tests_basic.c | 60 +++

  1   2   3   >