Re: udmabuf vmap failed (Revert "udmabuf: fix vmap_udmabuf error page set" can help)

2025-03-12 Thread Ryan Roberts
Hi, On 11/03/2025 09:34, Huan Yang wrote: > Hi Christoph and Ryan, > > Can you help us check vmap_pfn's pfn check is right? Did here mischecked > pfn_valid? I'm no expert on this piece of code, but I believe pfn_valid() is checking to see if a pfn is valid *memory*. i.e. does it have a correspo

Re: [PATCH v5 1/7] bits: split the definition of the asm and non-asm GENMASK()

2025-03-12 Thread Vincent Mailhol
On 13/03/2025 at 13:16, Lucas De Marchi wrote: > On Fri, Mar 07, 2025 at 02:10:28AM +0900, Vincent Mailhol wrote: >> On 06/03/2025 at 23:34, Lucas De Marchi wrote: >>> On Thu, Mar 06, 2025 at 08:29:52PM +0900, Vincent Mailhol via B4 Relay >>> wrote: >> >> (...) >> >>> it seems we now have 1 inconsi

Re: [PATCH v2 09/10] drm/bridge: anx7625: update bridge_ops and sink detect logic

2025-03-12 Thread Ayushi Makhija
On 3/12/2025 4:33 PM, Dmitry Baryshkov wrote: > On Wed, 12 Mar 2025 at 11:47, Ayushi Makhija > wrote: >> >> On 3/11/2025 9:11 PM, Dmitry Baryshkov wrote: >>> On Tue, Mar 11, 2025 at 05:54:44PM +0530, Ayushi Makhija wrote: The anx7625_link_bridge() checks if a device is not a panel br

RE: [PATCH v8 01/14] drm: Define histogram structures exposed to user

2025-03-12 Thread Murthy, Arun R
> > Display Histogram is an array of bins and can be generated in many > > ways referred to as modes. > > Ex: HSV max(RGB), Wighted RGB etc. > > > > Understanding the histogram data format(Ex: HSV max(RGB)) Histogram is > > just the pixel count. > > For a maximum resolution of 10k (10240 x 4320 = 4

Re: [PATCH v5 5/7] test_bits: add tests for __GENMASK() and __GENMASK_ULL()

2025-03-12 Thread Vincent Mailhol
On 13/03/2025 at 13:13, Lucas De Marchi wrote: > On Thu, Mar 06, 2025 at 08:29:56PM +0900, Vincent Mailhol via B4 Relay > wrote: >> From: Vincent Mailhol >> >> The definitions of GENMASK() and GENMASK_ULL() do not depend any more >> on __GENMASK() and __GENMASK_ULL(). Duplicate the existing unit t

Re: [PATCH v5 7/7] test_bits: add tests for BIT_U*()

2025-03-12 Thread Lucas De Marchi
On Thu, Mar 06, 2025 at 08:29:58PM +0900, Vincent Mailhol via B4 Relay wrote: From: Vincent Mailhol Add some additional tests in lib/test_bits.c to cover the expected results of the fixed type BIT_U*() macros. Signed-off-by: Vincent Mailhol Reviewed-by: Lucas De Marchi thanks Lucas De Mar

Re: [PATCH v2] drm/ci: add kms_cursor_legacy@torture-bo to apq8016 flakes

2025-03-12 Thread Vignesh Raman
Hi Abhinav, On 05/12/24 01:29, Abhinav Kumar wrote: From the jobs [1] and [2] of pipeline [3], its clear that kms_cursor_legacy@torture-bo is most certainly a flake and not a fail for apq8016. Mark the test accordingly to match the results. [1] : https://gitlab.freedesktop.org/drm/msm/-/jobs/6

[PULL] drm-xe-next-fixes

2025-03-12 Thread Lucas De Marchi
Hi Dave and Sima, Here's the drm-xe-next-fixes for this week targeting 6.15. Without the kernel-doc fix, building the docs was broken and there is also a warning fix microblaze arch. Others are "normal driver fixes". thanks Lucas De Marchi drm-xe-next-fixes-2025-03-12: Core Changes: - Fix kern

Re: [PATCH v5 1/7] bits: split the definition of the asm and non-asm GENMASK()

2025-03-12 Thread Lucas De Marchi
On Fri, Mar 07, 2025 at 02:10:28AM +0900, Vincent Mailhol wrote: On 06/03/2025 at 23:34, Lucas De Marchi wrote: On Thu, Mar 06, 2025 at 08:29:52PM +0900, Vincent Mailhol via B4 Relay wrote: (...) it seems we now have 1 inconsistency that we comment why GENMASK_U128() is not available in asm,

Re: [PATCH v5 5/7] test_bits: add tests for __GENMASK() and __GENMASK_ULL()

2025-03-12 Thread Lucas De Marchi
On Thu, Mar 06, 2025 at 08:29:56PM +0900, Vincent Mailhol via B4 Relay wrote: From: Vincent Mailhol The definitions of GENMASK() and GENMASK_ULL() do not depend any more on __GENMASK() and __GENMASK_ULL(). Duplicate the existing unit tests so that __GENMASK{,ULL}() is still covered. Signed-off

[PATCH v3] arm64: defconfig: mediatek: enable PHY drivers

2025-03-12 Thread Vignesh Raman
The mediatek display driver fails to probe on mt8173-elm-hana and mt8183-kukui-jacuzzi-juniper-sku16 in v6.14-rc4 due to missing PHY configurations. Commit [1] stopped selecting the MediaTek PHY drivers, requiring them to be explicitly enabled in defconfig. Enable the following PHY drivers for Me

Re: [PATCH v4 18/25] drm/renesas/rz-du: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-12 Thread kernel test robot
Hi Thomas, kernel test robot noticed the following build errors: [auto build test ERROR on next-20250311] [also build test ERROR on v6.14-rc6] [cannot apply to drm-exynos/exynos-drm-next rockchip/for-next tegra/for-next drm-xe/drm-xe-next linus/master v6.14-rc6 v6.14-rc5 v6.14-rc4] [If your patc

Re: [PATCH v2] arm64: defconfig: mediatek: enable PHY drivers

2025-03-12 Thread Vignesh Raman
Hi Nícolas, On 12/03/25 19:55, Nícolas F. R. A. Prado wrote: On Wed, Mar 12, 2025 at 09:49:26AM +0530, Vignesh Raman wrote: The mediatek display driver fails to probe on mt8173-elm-hana and mt8183-kukui-jacuzzi-juniper-sku16 in v6.14-rc4 due to missing PHY configurations. Enable the following

linux-next: manual merge of the tip tree with the drm tree

2025-03-12 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the tip tree got a conflict in: drivers/gpu/drm/i915/i915_pmu.c between commit: 87b593d79864 ("drm/i915/pmu: Drop custom hotplug code") from the drm tree and commit: 82ad584eed8b ("drm/i915/pmu: Switch to use hrtimer_setup()") from the tip tree. I f

[RFC PATCH 12/19] drm/xe: Make the PT code handle placement per PTE rather than per vma / range

2025-03-12 Thread Thomas Hellström
With SVM, ranges forwarded to the PT code for binding can, mostly due to races when migrating, point to both VRAM and system / foreign device memory. Make the PT code able to handle that by checking, for each PTE set up, whether it points to local VRAM or to system memory. Signed-off-by: Thomas He

Re: [PATCH v2] drm/panel/synaptics-r63353: Use _multi variants

2025-03-12 Thread Doug Anderson
Hi, On Wed, Mar 12, 2025 at 5:00 PM Anusha Srivatsa wrote: > > > > On Wed, Mar 12, 2025 at 11:48 AM Doug Anderson wrote: >> >> Hi, >> >> On Wed, Mar 12, 2025 at 8:06 AM Anusha Srivatsa wrote: >> > >> >> > @@ -106,53 +107,46 @@ static int r63353_panel_power_off(struct >> >> > r63353_panel *rpan

Re: [PATCH v4 18/25] drm/renesas/rz-du: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-12 Thread kernel test robot
Hi Thomas, kernel test robot noticed the following build errors: [auto build test ERROR on next-20250311] [also build test ERROR on v6.14-rc6] [cannot apply to drm-exynos/exynos-drm-next rockchip/for-next tegra/for-next drm-xe/drm-xe-next linus/master v6.14-rc6 v6.14-rc5 v6.14-rc4] [If your patc

[GIT PULL] mediatek drm next for 6.15

2025-03-12 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. HDMI fixup and refinement 2. Move to devm_platform_ioremap_resource() usage 3. Add MT8188 dsc compatible 4. Fix config_updating flag never false when no mbox channel 5. dp: drm_err => dev_err in HPD path to avoid NULL ptr 6. Add dpi power-domains example 7. Add

Re: [PATCH next] drm/xe: Fix uninitialized variable in xe_vm_bind_ioctl()

2025-03-12 Thread Dan Carpenter
On Mon, Mar 10, 2025 at 12:56:46PM -0400, Rodrigo Vivi wrote: > On Mon, Mar 10, 2025 at 01:48:00PM +0300, Dan Carpenter wrote: > > The error handling assumes that vm_bind_ioctl_check_args() will > > initialize "bind_ops" but there are a couple early returns where that's > > not true. Initialize "b

[RFC PATCH 13/19] drm/gpusvm: Allow mixed mappings

2025-03-12 Thread Thomas Hellström
Racing while migrating can cause part of an SVM range to reside in system and part of the range to reside in local VRAM. Currently we disallow that and repeatedly try to force everything out to system memory. Instead, allow drm_gpusvm_range_get_pages() to be a bit more permissive, and allow mappi

[PATCH RFC 1/2] drm/panel: Add new helpers for refcounted panel allocatons

2025-03-12 Thread Anusha Srivatsa
Introduce reference counted allocations for panels to avoid use-after-free. The patch adds the macro devm_drm_bridge_alloc() to allocate a new refcounted panel. Followed the documentation for drmm_encoder_alloc() and devm_drm_dev_alloc and other similar implementations for this purpose. Also addin

[PATCH RFC 2/2] drm/panel/panel-simple: Use the new allocation in place of devm_kzalloc()

2025-03-12 Thread Anusha Srivatsa
Start using the new helper that does the refcounted allocations. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-simple.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 232b

[PATCH RFC 0/2] drm/panel: Refcounted panel allocation

2025-03-12 Thread Anusha Srivatsa
Primary motivation is to avoid havig a dangling pointer with panels. In a scenario where panel device no longer exists, the DRM driver has no idea of it. It can continue to try and access a panel leading to use-after-free situations. This is the initial draft more for feedback only. Once the path f

[PULL] drm-intel-gt-next

2025-03-12 Thread Tvrtko Ursulin
Hi Dave, Sima, Here comes the final pull request for 6.15. Main thing is the bump of the reported mmap ioctl feature level, which enables Mesa to reliably detect full partial mmap support. Then the DRM client implementation gains vmap support and the remaining changes are just some refactors an

Re:Re: [PATCH v2 7/7] arm64: dts: rockchip: Enable DP2HDMI for ROCK 5 ITX

2025-03-12 Thread Andy Yan
Hi Dmitry, At 2025-03-12 20:39:17, "Dmitry Baryshkov" wrote: >On Wed, Mar 12, 2025 at 06:42:08PM +0800, Andy Yan wrote: >> From: Andy Yan >> >> The HDMI Port next to Headphone Jack is drived by >> DP1 on rk3588 via a dp2hdmi converter. >> >> Add related dt nodes to enable it. >> >> Note: ROC

Re:Re: [PATCH v2 2/7] drm/bridge: synopsys: Add DW DPTX Controller support library

2025-03-12 Thread Andy Yan
Hi Piotr, 在 2025-03-12 22:23:15,"Piotr Oniszczuk" 写道: > > >> Wiadomość napisana przez Andy Yan w dniu 12 mar 2025, o >> godz. 11:42: >> >> From: Andy Yan >> >> The DW DP TX Controller is compliant with the DisplayPort Specification >> Version 1.4 with the following features: >> >> * Display

Re: [PATCH v3 01/16] bitops: Change parity8() return type to bool

2025-03-12 Thread H. Peter Anvin
On March 12, 2025 4:56:31 PM PDT, Jacob Keller wrote: > > >On 3/7/2025 11:36 AM, David Laight wrote: >> On Fri, 7 Mar 2025 12:42:41 +0100 >> Jiri Slaby wrote: >> >>> On 07. 03. 25, 12:38, Ingo Molnar wrote: * Jiri Slaby wrote: > On 06. 03. 25, 17:25, Kuan-Wei Chiu wrote:

Re: [PATCH v2] drm/panel/synaptics-r63353: Use _multi variants

2025-03-12 Thread Anusha Srivatsa
On Wed, Mar 12, 2025 at 11:48 AM Doug Anderson wrote: > Hi, > > On Wed, Mar 12, 2025 at 8:06 AM Anusha Srivatsa > wrote: > > > >> > @@ -106,53 +107,46 @@ static int r63353_panel_power_off(struct > r63353_panel *rpanel) > >> > static int r63353_panel_activate(struct r63353_panel *rpanel) > >> >

Re: [RESEND PATCH v3] drm/mxsfb: Remove generic DRM drivers in probe function

2025-03-12 Thread Thomas Zimmermann
Merged into drm-misc-next. Thanks for the patch. Am 05.03.25 um 15:09 schrieb Dario Binacchi: Use aperture helpers to remove all generic graphics drivers before loading mxsfb. Makes mxsfb compatible with simpledrm. Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off

Re: [PATCH v3 01/16] bitops: Change parity8() return type to bool

2025-03-12 Thread Jacob Keller
On 3/7/2025 11:36 AM, David Laight wrote: > On Fri, 7 Mar 2025 12:42:41 +0100 > Jiri Slaby wrote: > >> On 07. 03. 25, 12:38, Ingo Molnar wrote: >>> >>> * Jiri Slaby wrote: >>> On 06. 03. 25, 17:25, Kuan-Wei Chiu wrote: > Change return type to bool for better clarity. Update the

Re: [PATCH v2] arm64: defconfig: mediatek: enable PHY drivers

2025-03-12 Thread Nícolas F . R . A . Prado
On Wed, Mar 12, 2025 at 09:49:26AM +0530, Vignesh Raman wrote: > The mediatek display driver fails to probe on mt8173-elm-hana and > mt8183-kukui-jacuzzi-juniper-sku16 in v6.14-rc4 due to missing PHY > configurations. > > Enable the following PHY drivers for MediaTek platforms: > - CONFIG_PHY_MTK_

Re: [PATCH 1/2] fbcon: Register sysfs groups through device_add_group

2025-03-12 Thread Thomas Weißschuh
Hi, On Tue, Mar 11, 2025 at 07:28:55PM +0800, oushixiong1...@163.com wrote: > From: Shixiong Ou > > Use device_add_group() to simplify creation and removal. > > Signed-off-by: Shixiong Ou > --- > drivers/video/fbdev/core/fbcon.c | 48 +++- > 1 file changed, 22 inse

Re: [PATCH] drm/bridge: anx7625: Remove redundant 'flush_workqueue()' calls

2025-03-12 Thread Doug Anderson
Hi, On Wed, Mar 12, 2025 at 2:02 AM Chen Ni wrote: > > 'destroy_workqueue()' already drains the queue before destroying it, so > there is no need to flush it explicitly. > > Remove the redundant 'flush_workqueue()' calls. > > This was generated with coccinelle: > > @@ > expression E; > @@ > - flu

[PATCH 2/2] drm/nouveau: DRM_NOUVEAU_SET_ZCULL_CTXSW_BUFFER

2025-03-12 Thread Mel Henning
We add this ioctl to set up the zcull context switch buffer so userspace can manage it. This also includes support for unbinding the buffer, which helps simplify device teardown on the userspace side. Signed-off-by: Mel Henning --- drivers/gpu/drm/nouveau/include/nvif/if0020.h | 6 +++ .../gpu/

Re: [GIT PULL] mediatek drm next for 6.15

2025-03-12 Thread Chun-Kuang Hu
Hi, Dave: Dave Airlie 於 2025年3月12日 週三 上午7:40寫道: > > Hey, > > This introduced a warning on my local builds, > > commit 30d5c46444a6aa4c78103fb898250ab5e6e8a97d > Author: Jason-JH Lin > Date: Mon Feb 24 13:12:21 2025 +0800 > > drm/mediatek: Fix config_updating flag never false when no mbox c

[PATCH 0/2] drm/nouveau: ZCULL support

2025-03-12 Thread Mel Henning
These patches add kernel-side support for using the zcull hardware in nvidia gpus. Zcull aims to improve memory bandwidth by using an early approximate depth test, similar to hierarchical Z on an AMD card. These patches add two new ioctls on nouveau devices, which are currently only supported when

[PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-03-12 Thread Mel Henning
Userspace needs this information to set up zcull correctly. Signed-off-by: Mel Henning --- .../drm/nouveau/include/nvkm/core/device.h| 6 ++ .../sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080gr.h | 69 +++ drivers/gpu/drm/nouveau/nouveau_abi16.c | 15 drivers/gpu/drm/nouve

[GIT PULL v2] mediatek drm next for 6.15

2025-03-12 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. HDMI fixup and refinement 2. Move to devm_platform_ioremap_resource() usage 3. Add MT8188 dsc compatible 4. Fix config_updating flag never false when no mbox channel 5. dp: drm_err => dev_err in HPD path to avoid NULL ptr 6. Add dpi power-domains example 7. Add

[PATCH 0/2] drm/panfrost:

2025-03-12 Thread Philippe Simons
Allwinner H616 has a dedicated power domain for its Mali G31. Currently after probe, the GPU is put in runtime suspend which disable the power domain. On first usage of GPU, the power domain enable hangs the system. This series adds the necessary calls to enable the clocks and deasserting the re

[PATCH 2/2] drm/panfrost: add h616 compatible string

2025-03-12 Thread Philippe Simons
Tie the Allwinner compatible string to the two features bits that will toggle the clocks and the reset line whenever the power domain is changing state. Signed-off-by: Philippe Simons --- drivers/gpu/drm/panfrost/panfrost_drv.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/

[PATCH 1/2] drm/panfrost: Add PM runtime flags

2025-03-12 Thread Philippe Simons
When the GPU is the only device attached to a single power domain, core genpd disable and enable it when gpu enter and leave runtime suspend. Some power-domain requires a sequence before disabled, and the reverse when enabled. Add PM flags for CLK and RST, and implement in panfrost_device_runtime

[PATCH v5 3/6] PCI: Allow IOV resources to be resized in pci_resize_resource()

2025-03-12 Thread Michał Winiarski
Similar to regular resizable BAR, VF BAR can also be resized. The structures are very similar, which means we can reuse most of the implementation. Extend the pci_resize_resource() function to accept IOV resources. See PCIe r4.0, sec 9.3.7.4. Signed-off-by: Michał Winiarski --- drivers/pci/io

[PATCH v5 0/6] PCI: VF resizable BAR

2025-03-12 Thread Michał Winiarski
Hi, No major logic changes since v4, just a few tweaks to docs, commit messages and function naming. v4 can be found here: https://lore.kernel.org/linux-pci/20241025215038.3125626-1-michal.winiar...@intel.com/ For regular BAR, drivers can use pci_resize_resource to resize it to the desired size

[PATCH v5 6/6] drm/xe/pf: Set VF LMEM BAR size

2025-03-12 Thread Michał Winiarski
LMEM is partitioned between multiple VFs and we expect that the more VFs we have, the less LMEM is assigned to each VF. This means that we can achieve full LMEM BAR access without the need to attempt full VF LMEM BAR resize via pci_resize_resource(). Always set the largest possible BAR size that a

[PATCH v5 5/6] PCI: Allow drivers to control VF BAR size

2025-03-12 Thread Michał Winiarski
Drivers could leverage the fact that the VF BAR MMIO reservation is created for total number of VFs supported by the device by resizing the BAR to larger size when smaller number of VFs is enabled. Add a pci_iov_vf_bar_set_size() function to control the size and a pci_iov_vf_bar_get_sizes() helper

[PATCH v5 4/6] PCI/IOV: Check that VF BAR fits within the reservation

2025-03-12 Thread Michał Winiarski
When the resource representing VF MMIO BAR reservation is created, its size is always large enough to accommodate the BAR of all SR-IOV Virtual Functions that can potentially be created (total VFs). If it's not possible to accommodate all VFs - the resource is not assigned and no VFs can be create

[PATCH v5 2/6] PCI: Add a helper to convert between VF BAR number and IOV resource

2025-03-12 Thread Michał Winiarski
There are multiple places where conversions between IOV resources and corresponding VF BAR numbers are done. Extract the logic to pci_resource_num_from_vf_bar() and pci_resource_num_to_vf_bar() helpers. Suggested-by: Ilpo Järvinen Signed-off-by: Michał Winiarski --- drivers/pci/iov.c | 2

[PATCH v5 1/6] PCI/IOV: Restore VF resizable BAR state after reset

2025-03-12 Thread Michał Winiarski
Similar to regular resizable BAR, VF BAR can also be resized, e.g. by the system firmware or the PCI subsystem itself. Add the capability ID and restore it as a part of IOV state. See PCIe r4.0, sec 9.3.7.4. Signed-off-by: Michał Winiarski Reviewed-by: Ilpo Järvinen Reviewed-by: Christian Köni

Re: [PATCH v4] Documentation: dma-buf: heaps: Add heap name definitions

2025-03-12 Thread Jonathan Corbet
Maxime Ripard writes: > Following a recent discussion at last Plumbers, John Stultz, Sumit > Sewal, TJ Mercier and I came to an agreement that we should document > what the dma-buf heaps names are expected to be, and what the buffers > attributes you'll get should be documented. > > Let's create

Re: [PATCH v3 5/7] dt-bindings: gpu: v3d: Add SMS register to BCM2712 compatible

2025-03-12 Thread Maíra Canal
Hi Krzysztof, On 12/03/25 06:06, Krzysztof Kozlowski wrote: On Tue, Mar 11, 2025 at 07:05:31PM -0300, Maíra Canal wrote: +reg-names: + items: +- const: hub +- const: core0 +- const: sms +- const: bridge This is an ABI change bec

Re: [PATCH 1/2] drm: Create an app info option for wedge events

2025-03-12 Thread André Almeida
Em 12/03/2025 07:06, Raag Jadav escreveu: On Tue, Mar 11, 2025 at 07:09:45PM +0200, Raag Jadav wrote: On Mon, Mar 10, 2025 at 06:27:53PM -0300, André Almeida wrote: Em 01/03/2025 02:53, Raag Jadav escreveu: On Fri, Feb 28, 2025 at 06:54:12PM -0300, André Almeida wrote: Hi Raag, On 2/28/25 11

[PATCH v8 2/3] drm/plane: modify create_in_formats to accommodate async

2025-03-12 Thread Arun R Murthy
create_in_formats creates the list of supported format/modifiers for synchronous flips, modify the same function so as to take the format_mod_supported as argument and create list of format/modifier for async as well. v5: create_in_formats can return -ve value in failure case, correct the if condi

[RFC PATCH 00/19] drm, drm/xe: Multi-device GPUSVM

2025-03-12 Thread Thomas Hellström
This RFC implements and requests comments for a way to handle SVM with multi-device, typically with fast interconnects. It adds generic code and helpers in drm, and device-specific code for xe. For SVM, devices set up maps of device-private struct pages, using a struct dev_pagemap, The CPU virtu

Re: [PATCH v2 0/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-03-12 Thread Stefan Schmidt
Hello Aleksandrs, On Wed, 12 Mar 2025 at 00:41, Aleksandrs Vinarskis wrote: > > Recently added Initial LTTPR support in msm/dp has configured LTTPR(s) > to non-transparent mode to enable video output on X1E-based devices > that come with LTTPR on the motherboards. However, video would not work >

[RFC PATCH 11/19] drm/xe: Use the drm_pagemap_util helper to get a svm pagemap owner

2025-03-12 Thread Thomas Hellström
Register a driver-wide owner list, provide a callback to identify fast interconnects and use the drm_pagemap_util helper to allocate or reuse a suitable owner struct. For now we consider pagemaps on different tiles on the same device as having fast interconnect. Signed-off-by: Thomas Hellström --

[RFC PATCH 04/19] drm/pagemap: Add a populate_mm op

2025-03-12 Thread Thomas Hellström
Add an operation to populate a part of a drm_mm with device private memory. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/drm_gpusvm.c | 7 ++- drivers/gpu/drm/drm_pagemap.c | 32 include/drm/drm_pagemap.h | 32 3

[RFC PATCH 02/19] drm/xe/svm: Fix a potential bo UAF

2025-03-12 Thread Thomas Hellström
If drm_gpusvm_migrate_to_devmem() succeeds, if a cpu access happens to the range the bo may be freed before xe_bo_unlock(), causing a UAF. Since the reference is transferred, use xe_svm_devmem_release() to release the reference on drm_gpusvm_migrate_to_devmem() failure, and hold a local reference

[RFC PATCH 19/19] drm/xe: HAX: Use pcie p2p dma to test fast interconnect

2025-03-12 Thread Thomas Hellström
Knowing that this is not the correct way to support pcie_p2p over hmm + the dma api, pretend that pcie_p2p is a driver-private fast interconnect to demonstrate how multi-device SVM can be done. This has been used to test SVM on a BMG client with a pagemap created on a DG1 GPU over pcie p2p. Signe

[RFC PATCH 18/19] drm/xe/uapi: HAX: Add the xe_madvise_prefer_devmem IOCTL

2025-03-12 Thread Thomas Hellström
As a POC, add an xe_madvise_prefer_devmem IOCTL so that the user can set the preferred pagemap to migrate to for a given memory region (in this POC, the memory region is the whole GPU VM). This is intended to be replaced by a proper madvise IOCTL, probably with improved functionality Signed-off-b

[RFC PATCH 17/19] drm/xe/uapi: Add the devmem_open ioctl

2025-03-12 Thread Thomas Hellström
Add an IOCTL to get a file descriptor referencing a memory region for SVM. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/xe/xe_device.c | 1 + drivers/gpu/drm/xe/xe_svm.c| 50 ++ drivers/gpu/drm/xe/xe_svm.h| 8 ++ include/uapi/drm/xe_drm.h

[RFC PATCH 14/19] drm/xe: Add a preferred dpagemap

2025-03-12 Thread Thomas Hellström
Introduce a preferred dpagemap, that can override the default. The default is still the local tile vram dpagemap. The preferred pagemap is intended to be set from user-space. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/xe/xe_svm.c | 18 +- drivers/gpu/drm/xe/xe_svm.h

[RFC PATCH 16/19] drm/xe/migrate: Allow xe_migrate_vram() also on non-pagefault capable devices

2025-03-12 Thread Thomas Hellström
The drm_pagemap functionality does not depend on the device having recoverable pagefaults available. So allow xe_migrate_vram() also for such devices. Even if this will have little use in practice, it's beneficial for testin multi-device SVM, since a memory provider could be a non-pagefault capable

[RFC PATCH 15/19] drm/pagemap/util: Add file descriptors pointing to struct drm_pagemap

2025-03-12 Thread Thomas Hellström
Falicitate implementing uapi representing a struct drm_pagemap as a file descriptor. A drm_pagemap file descriptor holds, while open, a reference to the struct drm_pagemap and to the drm_pagemap_helper module. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/drm_pagemap_util.c | 78 +

[RFC PATCH 09/19] drm/pagemap_util: Add a utility to assign an owner to a set of interconnected gpus

2025-03-12 Thread Thomas Hellström
The hmm_range_fault() and the migration helpers currently need a common "owner" to identify pagemaps and clients with fast interconnect. Add a drm_pagemap utility to setup such owners by registering drm_pagemaps, in a registry, and for each new drm_pagemap, query which existing drm_pagemaps have fa

[RFC PATCH 10/19] drm/gpusvm, drm/xe: Move the device private owner to the drm_gpusvm_ctx

2025-03-12 Thread Thomas Hellström
It may not be known at drm_gpusvm_init time. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/drm_gpusvm.c | 21 - drivers/gpu/drm/xe/xe_svm.c | 5 +++-- include/drm/drm_gpusvm.h | 7 --- 3 files changed, 19 insertions(+), 14 deletions(-) diff --git a/drivers/g

[RFC PATCH 08/19] drm/xe/bo: Add a bo remove callback

2025-03-12 Thread Thomas Hellström
On device unbind, migrate exported bos, including pagemap bos to system. This allows importers to take proper action without disruption. In particular, SVM clients on remote devices may continue as if nothing happened, and can chose a different placement. The evict_flags() placement is chosen in s

[RFC PATCH 03/19] drm/gpusvm, drm/pagemap: Move migration functionality to drm_pagemap

2025-03-12 Thread Thomas Hellström
From: Matthew Brost The migration functionality and track-keeping of per-pagemap VRAM mapped to the CPU mm is not per GPU_vm, but rather per pagemap. This is also reflected by the functions not needing the drm_gpusvm structures. So move to drm_pagemap. With this, drm_gpusvm shouldn't really acce

[RFC PATCH 07/19] drm/pagemap: Get rid of the struct drm_pagemap_zdd::device_private_page_owner field

2025-03-12 Thread Thomas Hellström
Now that there is always a valid page pointer, we can deduce the owner from the page. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/drm_pagemap.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/drm_pagemap.c b/drivers/gpu/drm/drm_pagemap

[RFC PATCH 05/19] drm/xe: Implement and use the drm_pagemap populate_mm op

2025-03-12 Thread Thomas Hellström
Add runtime PM since we might call populate_mm on a foreign device. Also create the VRAM bos as ttm_bo_type_kernel. This avoids the initial clearing and the creation of an mmap handle. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/drm_pagemap.c | 4 +- drivers/gpu/drm/xe/xe_svm.c | 80 +

[RFC PATCH 01/19] drm/xe: Introduce CONFIG_DRM_XE_GPUSVM

2025-03-12 Thread Thomas Hellström
Don't rely on CONFIG_DRM_GPUSVM because other drivers may enable it causing us to compile in SVM support unintentionally. Also take the opportunity to leave more code out of compilation if !CONFIG_DRM_XE_GPUSVM and !CONFIG_DRM_XE_DEVMEM_MIRROR Signed-off-by: Thomas Hellström --- drivers/gpu/drm

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Andy Shevchenko
On Wed, Mar 12, 2025 at 07:35:54PM +, Aditya Garg wrote: > > On 13 Mar 2025, at 12:58 AM, Andy Shevchenko > > wrote: > > On Wed, Mar 12, 2025 at 07:14:36PM +, Aditya Garg wrote: > On 12 Mar 2025, at 9:05 PM, Sven Peter wrote: > >>> On Wed, Mar 12, 2025, at 13:03, Aditya Garg wrote:

Re: [RFC PATCH 4/5] drm/panthor: Add support for protected memory allocation in panthor

2025-03-12 Thread Adrian Larumbe
Hi Florent, There's a chance whatever I say here's already been discussed in the review before. If that were the case, ignore it without further ado. On 30.01.2025 13:09, Florent Tomasin wrote: > This patch allows Panthor to allocate buffer objects from a > protected heap. The Panthor driver shou

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Aditya Garg
> On 13 Mar 2025, at 12:58 AM, Andy Shevchenko > wrote: > > On Wed, Mar 12, 2025 at 07:14:36PM +, Aditya Garg wrote: On 12 Mar 2025, at 9:05 PM, Sven Peter wrote: >>> On Wed, Mar 12, 2025, at 13:03, Aditya Garg wrote: > > ... > >>> I don't have a strong opinion either way: for SMC

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Andy Shevchenko
On Wed, Mar 12, 2025 at 07:14:36PM +, Aditya Garg wrote: > > On 12 Mar 2025, at 9:05 PM, Sven Peter wrote: > > On Wed, Mar 12, 2025, at 13:03, Aditya Garg wrote: ... > > I don't have a strong opinion either way: for SMC I just need to print > > FourCC keys for debugging / information in a fe

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Aditya Garg
> On 12 Mar 2025, at 9:05 PM, Sven Peter wrote: > > Hi, > > > On Wed, Mar 12, 2025, at 13:03, Aditya Garg wrote: On 12 Mar 2025, at 5:29 PM, Thomas Zimmermann wrote: >>> >>> Hi >>> Am 12.03.25 um 12:49 schrieb Aditya Garg: >> On 12 Mar 2025, at 5:16 PM, Thomas Zimmerm

[pull] amdgpu, amdkfd drm-fixes-6.14

2025-03-12 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.14. The following changes since commit 80e54e84911a923c40d7bee33a34c1b4be148d7a: Linux 6.14-rc6 (2025-03-09 13:45:25 -1000) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.14-2025-03-12 for you to fe

[PATCH] accel/qaic: Remove redundant 'flush_workqueue()' calls

2025-03-12 Thread Chen Ni
'destroy_workqueue()' already drains the queue before destroying it, so there is no need to flush it explicitly. Remove the redundant 'flush_workqueue()' calls. This was generated with coccinelle: @@ expression E; @@ - flush_workqueue(E); destroy_workqueue(E); Signed-off-by: Chen Ni --- dri

Re: [PATCH v1 4/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-12 Thread Ariel D'Alessandro
Boris, Angelo, On 3/11/25 7:05 AM, Boris Brezillon wrote: On Tue, 11 Mar 2025 10:14:44 +0100 AngeloGioacchino Del Regno wrote: Il 11/03/25 09:05, Boris Brezillon ha scritto: On Mon, 10 Mar 2025 16:59:19 -0300 Ariel D'Alessandro wrote: Currently, Panfrost only supports MMU configuration

Re: [PATCH v2 7/7] drm/tests: hdmi: Add max TMDS rate fallback tests for YUV420 mode

2025-03-12 Thread kernel test robot
: 4423e607ff50157aaf088854b145936cbab4d560 patch link: https://lore.kernel.org/r/20250311-hdmi-conn-yuv-v2-7-fbdb94f02562%40collabora.com patch subject: [PATCH v2 7/7] drm/tests: hdmi: Add max TMDS rate fallback tests for YUV420 mode config: arm64-randconfig-004-20250312 (https://download.01

Re: [PATCH] drm/amd/display: Remove incorrect macro guard

2025-03-12 Thread Alex Hung
On 3/12/25 02:11, Christian König wrote: Am 11.03.25 um 18:10 schrieb Alex Hung: This macro guard "__cplusplus" is unnecessary and should not be there. Signed-off-by: Alex Hung --- drivers/gpu/drm/amd/display/dc/sspl/dc_spl.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/

Re: [PATCH v2 1/2] drm/display: hdmi: Create documentation section

2025-03-12 Thread Dmitry Baryshkov
On Wed, Mar 12, 2025 at 02:39:16PM +0100, Maxime Ripard wrote: > We have had documentation for the public functions in the HDMI helpers, > but those were never referenced anywhere and thus not compiled as part > of the doc. > > Let's add a section. > > Signed-off-by: Maxime Ripard > --- > Docum

Re: [PATCH v1 4/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-12 Thread Ariel D'Alessandro
Boris, On 3/11/25 5:05 AM, Boris Brezillon wrote: On Mon, 10 Mar 2025 16:59:19 -0300 Ariel D'Alessandro wrote: Currently, Panfrost only supports MMU configuration in "LEGACY" (as Bifrost calls it) mode, a (modified) version of LPAE "Large Physical Address Extension", which in Linux we've call

Re: [PATCH v3] drm/ci: fix merge request rules

2025-03-12 Thread Helen Mae Koike Fornazier
Em seg., 10 de mar. de 2025 às 05:25, Daniel Stone escreveu: > > On Fri, 28 Feb 2025 at 13:26, Vignesh Raman > wrote: > > Merge request pipelines were only created when changes > > were made to drivers/gpu/drm/ci/, causing MRs that > > didn't touch this path to break. Fix MR pipeline rules > > t

RE: [PATCH v7 4/6] drm/xe/uapi: Define drm_xe_vm_get_faults

2025-03-12 Thread Cavitt, Jonathan
-Original Message- From: Zhang, Jianxun Sent: Wednesday, March 12, 2025 9:28 AM To: Cavitt, Jonathan ; Brost, Matthew Cc: intel...@lists.freedesktop.org; Gupta, saurabhg ; Zuo, Alex ; joonas.lahti...@linux.intel.com; Lin, Shuicheng ; dri-devel@lists.freedesktop.org Subject: Re: [PATCH

Re: [PATCH v4] drm/i915: Fix harmful driver register/unregister asymmetry

2025-03-12 Thread Janusz Krzysztofik
Hi Krzysztof, Thanks for looking at this. On Wednesday, 12 March 2025 16:06:15 CET Krzysztof Niemiec wrote: > On 2025-03-11 at 21:04:56 GMT, Janusz Krzysztofik wrote: > > Starting with commit ec3e00b4ee27 ("drm/i915: stop registering if > > drm_dev_register() fails"), we return from i915_driver_r

Re: [PATCH 1/2] fbcon: Register sysfs groups through device_add_group

2025-03-12 Thread kernel test robot
Hi, kernel test robot noticed the following build errors: [auto build test ERROR on linus/master] [also build test ERROR on v6.14-rc6 next-20250312] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as doc

Re: [PATCH 00/63] Fix CONFIG_DRM_USE_DYNAMIC_DEBUG=y

2025-03-12 Thread jim . cromie
hello everyone, sorry for the late reply. I have a cleaner version cooking now. less inter-commit churn, by bringing more cleanups forward. I'll send a -v2 soon. (lets forget all the meandering crap versions I sent) Louis, thanks for testing ! I wrote the test script and submod.ko so the

Re: [PATCH v2 01/10] dt-bindings: display: msm-dsi-phy-7nm: document the SA8775P DSI PHY

2025-03-12 Thread Krzysztof Kozlowski
On Tue, Mar 11, 2025 at 05:54:36PM +0530, Ayushi Makhija wrote: > Document the DSI PHY on the SA8775P Platform. > > Signed-off-by: Ayushi Makhija > --- > Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 + > 1 file changed, 1 insertion(+) Acked-by: Krzysztof Kozlowski Best r

Re: [PATCH v3 00/16] Introduce and use generic parity16/32/64 helper

2025-03-12 Thread Kuan-Wei Chiu
On Wed, Mar 12, 2025 at 11:51:12AM -0400, Yury Norov wrote: > On Tue, Mar 11, 2025 at 03:24:14PM -0700, H. Peter Anvin wrote: > > On March 11, 2025 3:01:30 PM PDT, Yury Norov wrote: > > >On Sun, Mar 09, 2025 at 11:48:26PM +0800, Kuan-Wei Chiu wrote: > > >> On Fri, Mar 07, 2025 at 12:07:02PM -0800,

Re: [PATCH v7 4/6] drm/xe/uapi: Define drm_xe_vm_get_faults

2025-03-12 Thread Zhang, Jianxun
Sorry if my reply is still in a wrong format. I have set plain text in the web-based outlook this time but don't know if it really works. Refer to my inline comment, thanks. From: Cavitt, Jonathan Sent: Tuesday, March 11, 2025 7:11 AM To: Brost, Matthew;

[v4 23/23] drm/doc/rfc: Add documentation for multi-segmented 1D LUT

2025-03-12 Thread Uma Shankar
Add documentation to explain properties of the exposed hardware 1D LUT blocks, its identification and computation of the LUT samples based on the number of samples, their distribution and precison. Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- Documentation/gpu/rfc/color_p

Re: [PATCH v1 4/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-12 Thread AngeloGioacchino Del Regno
Il 12/03/25 15:20, Ariel D'Alessandro ha scritto: Angelo, On 3/11/25 6:10 AM, AngeloGioacchino Del Regno wrote: Il 10/03/25 20:59, Ariel D'Alessandro ha scritto: Currently, Panfrost only supports MMU configuration in "LEGACY" (as Bifrost calls it) mode, a (modified) version of LPAE "Large Phys

Re: [PATCH v3 00/16] Introduce and use generic parity16/32/64 helper

2025-03-12 Thread Yury Norov
On Tue, Mar 11, 2025 at 03:24:14PM -0700, H. Peter Anvin wrote: > On March 11, 2025 3:01:30 PM PDT, Yury Norov wrote: > >On Sun, Mar 09, 2025 at 11:48:26PM +0800, Kuan-Wei Chiu wrote: > >> On Fri, Mar 07, 2025 at 12:07:02PM -0800, H. Peter Anvin wrote: > >> > On March 7, 2025 11:53:10 AM PST, Davi

Re: [PATCH v2] drm/panel/synaptics-r63353: Use _multi variants

2025-03-12 Thread Doug Anderson
Hi, On Wed, Mar 12, 2025 at 8:06 AM Anusha Srivatsa wrote: > >> > @@ -106,53 +107,46 @@ static int r63353_panel_power_off(struct >> > r63353_panel *rpanel) >> > static int r63353_panel_activate(struct r63353_panel *rpanel) >> > { >> > struct mipi_dsi_device *dsi = rpanel->dsi; >> > -

[PATCH v2 2/2] fbcon: Change return value type to void

2025-03-12 Thread Shixiong Ou
From: Shixiong Ou fbcon_init_device() doesn't need to return a value. Signed-off-by: Shixiong Ou --- drivers/video/fbdev/core/fbcon.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c index 9ee5f8492249..6

[PATCH v2 1/2] fbcon: Register sysfs groups through device_add_group

2025-03-12 Thread Shixiong Ou
From: Shixiong Ou Use device_add_group() to simplify creation and removal. Signed-off-by: Shixiong Ou --- v1->v2: fix build error. drivers/video/fbdev/core/fbcon.c | 49 ++-- 1 file changed, 22 insertions(+), 27 deletions(-) diff --git a/drivers/video/fbde

Re: [PATCH v2] drm/panel/synaptics-r63353: Use _multi variants

2025-03-12 Thread Doug Anderson
Hi, On Wed, Mar 12, 2025 at 7:54 AM Anusha Srivatsa wrote: > >> > @@ -78,7 +79,7 @@ static int r63353_panel_power_on(struct r63353_panel >> > *rpanel) >> > return ret; >> > } >> > >> > - usleep_range(15000, 25000); >> > + mipi_dsi_usleep_range(&dsi_ctx, 15000,

[PATCH v3 0/2] drm/vc4: hdmi: Add jack detection to HDMI audio driver

2025-03-12 Thread David Turner
deletions(-) --- base-commit: eff0347e7c228335e9ff64aaf02c66957803af6a change-id: 20250312-vc4_hotplug-3ae4e783484a Best regards, -- David Turner

[PATCH v3 2/2] drm/vc4: hdmi: Add jack detection to HDMI audio driver

2025-03-12 Thread David Turner
Add ALSA jack detection to the vc4-hdmi audio driver so userspace knows when to add/remove HDMI audio devices. Signed-off-by: Stefan Wahren Signed-off-by: David Turner --- drivers/gpu/drm/vc4/vc4_hdmi.c | 18 ++ drivers/gpu/drm/vc4/vc4_hdmi.h | 7 +++ 2 files changed, 25 in

[PATCH v3 1/2] drm/vc4: hdmi: Call HDMI hotplug helper on disconnect

2025-03-12 Thread David Turner
From: Stefan Wahren drm_atomic_helper_connector_hdmi_hotplug() must be called regardless of the connection status, otherwise the HDMI audio disconnect event won't be notified. Also update the comment on drm_atomic_helper_connector_hdmi_hotplug() to explain that this is necessary. Fixes: 2ea9ec5

  1   2   >