RE: [PATCH 0/4] cover-letter: Allow MMIO regions to be exported through dmabuf

2025-02-25 Thread Kasireddy, Vivek
Hi Wei Lin, [...] > > Yeah, the mmap handler is really needed as a debugging tool given > that the > importer would not be able to provide access to the dmabuf's > underlying > memory via the CPU in any other way. > > > > - Rather than handle different regions w

Re: [PATCH 2/3] dummycon: fix default rows/cols

2025-02-25 Thread Thomas Zimmermann
Am 25.02.25 um 17:44 schrieb Arnd Bergmann: From: Arnd Bergmann dummycon fails to build on ARM/footbridge when the VGA console is disabled, since I got the dependencies slightly wrong in a previous patch: drivers/video/console/dummycon.c: In function 'dummycon_init': drivers/video/console/d

Re: [PATCH 1/3] dummycon: only build module if there are users

2025-02-25 Thread Thomas Zimmermann
Am 26.02.25 um 08:48 schrieb Thomas Zimmermann: Hi Arnd Am 25.02.25 um 17:44 schrieb Arnd Bergmann: From: Arnd Bergmann Dummycon is used as a fallback conswitchp for vgacon and fbcon in the VT code, and there are no references to it if all three are disabled, so just leave it out of the ke

Re: [PATCH 1/3] dummycon: only build module if there are users

2025-02-25 Thread Thomas Zimmermann
Hi Arnd Am 25.02.25 um 17:44 schrieb Arnd Bergmann: From: Arnd Bergmann Dummycon is used as a fallback conswitchp for vgacon and fbcon in the VT code, and there are no references to it if all three are disabled, so just leave it out of the kernel image for configurations without those. Signed

Re: [PATCH v2 2/4] dt-bindings: display: panel: Add Himax HX83112B

2025-02-25 Thread Krzysztof Kozlowski
On Tue, Feb 25, 2025 at 10:14:30PM +0100, Luca Weiss wrote: > Himax HX83112B is a display driver IC used to drive LCD DSI panels. > Describe it and the Fairphone 3 panel (98-03057-6598B-I) from DJN using > it. > > Signed-off-by: Luca Weiss > --- > .../bindings/display/panel/himax,hx83112b.yaml

Re: [PATCH 3/7] drm/mediatek: Add TDSHP component support for MT8196

2025-02-25 Thread 胡俊光

Re: [PATCH 5/5] drm/xe/query: use PAGE_SIZE as the minimum page alignment

2025-02-25 Thread Mingcong Bai
在 2025/2/26 12:43, Matthew Brost 写道: On Wed, Feb 26, 2025 at 10:00:22AM +0800, Mingcong Bai via B4 Relay wrote: From: Mingcong Bai As this component hooks into userspace API, it should be assumed that it will play well with non-4K/64K pages. Use `PAGE_SIZE' as the final reference for page

Re: [PATCH 1/5] drm/xe/bo: fix alignment with non-4K kernel page sizes

2025-02-25 Thread Mingcong Bai
Hi Matt, 在 2025/2/26 12:18, Matthew Brost 写道: On Tue, Feb 25, 2025 at 09:13:09PM -0600, Lucas De Marchi wrote: On Wed, Feb 26, 2025 at 10:00:18AM +0800, Mingcong Bai via B4 Relay wrote: From: Mingcong Bai The bo/ttm interfaces with kernel memory mapping from dedicated GPU memory. It is not c

Re: [PATCH 1/1] drm/bridge: ti-sn65dsi83: Support negative DE polarity

2025-02-25 Thread Herve Codina
Hi Alexander, On Tue, 25 Feb 2025 14:51:13 +0100 Alexander Stein wrote: > Polarity for DE is stored in bridge state. Use this flag for setting > the DE polarity in the bridge. > > Signed-off-by: Alexander Stein > --- > drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 ++ > 1 file changed, 2 insertio

Re: [PATCH 02/17] bitops: Add generic parity calculation for u64

2025-02-25 Thread Jiri Slaby
On 25. 02. 25, 14:29, Kuan-Wei Chiu wrote: +#define parity(val)\ +({ \ + u64 __v = (val);\ + int __ret; \ + switch (BITS_P

Re: [PATCH 1/7] drm/mediatek: Add CCORR component support for MT8196

2025-02-25 Thread 胡俊光

Re: [PATCH 1/1] drm/bridge: ti-sn65dsi83: Support negative DE polarity

2025-02-25 Thread Dmitry Baryshkov
On Tue, Feb 25, 2025 at 02:51:13PM +0100, Alexander Stein wrote: > Polarity for DE is stored in bridge state. Use this flag for setting > the DE polarity in the bridge. > > Signed-off-by: Alexander Stein > --- > drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 ++ > 1 file changed, 2 insertions(+) >

Re: [PATCH v3 drm-dp 7/8] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-02-25 Thread Dmitry Baryshkov
On Tue, Feb 25, 2025 at 09:57:17PM +0800, Yongbang Shi wrote: > > On Mon, 24 Feb 2025 at 16:03, Yongbang Shi wrote: > > > > On Sat, Feb 22, 2025 at 06:35:48PM +0800, Yongbang Shi wrote: > > > > > > > +static int hibmc_dp_hpd_event(struct drm_client_dev *client) > > > > > > > +{ > > > > > > > + st

Re: [PATCH v2 3/3] drm/bridge: simple-bridge: Add support for MStar TSUMU88ADT3-LF-1

2025-02-25 Thread Dmitry Baryshkov
On Tue, 25 Feb 2025 at 14:02, Svyatoslav Ryhel wrote: > > вт, 25 лют. 2025 р. о 13:57 Dmitry Baryshkov > пише: > > > > On Tue, Feb 25, 2025 at 10:33:44AM +0200, Svyatoslav Ryhel wrote: > > > From: Maxim Schwalm > > > > > > A simple HDMI bridge used in ASUS Transformer AiO P1801-T. > > > > > > S

Re: [PATCH v4 08/15] drm/tests: bridge: Provide tests for drm_bridge_reset_crtc

2025-02-25 Thread Dmitry Baryshkov
On Tue, Feb 25, 2025 at 05:43:56PM +0100, Maxime Ripard wrote: > Let's provide a bunch of kunit tests to make sure > drm_bridge_reset_crtc() works as expected. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/tests/drm_bridge_test.c | 168 > +++- > 1 file cha

Re: [PATCH v4 09/15] drm/bridge: ti-sn65dsi83: Switch to drm_bridge_reset_crtc

2025-02-25 Thread Dmitry Baryshkov
On Tue, Feb 25, 2025 at 05:43:57PM +0100, Maxime Ripard wrote: > Now that we have a helper for bridge drivers to call to reset the output > pipeline, let's use it. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/bridge/ti-sn65dsi83.c | 26 ++ > 1 file changed, 10

Re: [PATCH v4 08/15] drm/tests: bridge: Provide tests for drm_bridge_reset_crtc

2025-02-25 Thread Dmitry Baryshkov
On Tue, Feb 25, 2025 at 05:43:56PM +0100, Maxime Ripard wrote: > Let's provide a bunch of kunit tests to make sure > drm_bridge_reset_crtc() works as expected. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/tests/drm_bridge_test.c | 168 > +++- > 1 file cha

Re: [PATCH 2/7] drm/mediatek: fix CCORR mtk_ctm_s31_32_to_s1_n function issue

2025-02-25 Thread 胡俊光

Re: [PATCH v4 07/15] drm/bridge: Add helper to reset bridge pipeline

2025-02-25 Thread Dmitry Baryshkov
On Tue, Feb 25, 2025 at 05:43:55PM +0100, Maxime Ripard wrote: > Let's provide an helper to make it easier for bridge drivers to > power-cycle their bridge. > > Co-developed-by: Simona Vetter > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/drm_bridge.c | 44 > +++

Re: [PATCH v4 03/15] drm/tests: Add kunit tests for bridges

2025-02-25 Thread Dmitry Baryshkov
On Tue, Feb 25, 2025 at 05:43:51PM +0100, Maxime Ripard wrote: > None of the drm_bridge function have kunit tests so far. Let's change > that, starting with drm_bridge_get_current_state(). > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/Kconfig | 1 + > drivers/gpu/drm

Re: [PATCH v4 06/15] drm/tests: Create tests for drm_atomic

2025-02-25 Thread Dmitry Baryshkov
On Tue, Feb 25, 2025 at 05:43:54PM +0100, Maxime Ripard wrote: > We don't have a set of kunit tests for the functions under drm_atomic.h. > Let's use the introduction of drm_atomic_get_connector_for_encoder() to > create some tests for it and thus create that set. > > Signed-off-by: Maxime Ripard

Re: [PATCH v4 04/15] drm/atomic: Introduce helper to lookup connector by encoder

2025-02-25 Thread Dmitry Baryshkov
On Tue, Feb 25, 2025 at 05:43:52PM +0100, Maxime Ripard wrote: > With the bridges switching over to drm_bridge_connector, the direct > association between a bridge driver and its connector was lost. > > This is mitigated for atomic bridge drivers by the fact you can access > the encoder, and then

Re: [PATCH v4 05/15] drm/tests: helpers: Create new helper to enable output

2025-02-25 Thread Dmitry Baryshkov
On Tue, Feb 25, 2025 at 05:43:53PM +0100, Maxime Ripard wrote: > We'll need the HDMI state tests light_up_connector() function in more > tests, so let's promote it to a helper. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 151 > +-

Re: [PATCH v4 11/15] drm/bridge: cdns-csi: Switch to atomic helpers

2025-02-25 Thread Dmitry Baryshkov
On Tue, Feb 25, 2025 at 05:43:59PM +0100, Maxime Ripard wrote: > The Cadence DSI driver follows the drm_encoder->crtc pointer that is > deprecated and shouldn't be used by atomic drivers. > > This was due to the fact that we did't have any other alternative to > retrieve the CRTC pointer. Fortunat

Re: [PATCH v4 04/15] drm/atomic: Introduce helper to lookup connector by encoder

2025-02-25 Thread Dmitry Baryshkov
On Tue, Feb 25, 2025 at 05:43:52PM +0100, Maxime Ripard wrote: > With the bridges switching over to drm_bridge_connector, the direct > association between a bridge driver and its connector was lost. > > This is mitigated for atomic bridge drivers by the fact you can access > the encoder, and then

Re: [PATCH v2 4/4] arm64: dts: qcom: sdm632-fairphone-fp3: Enable display and GPU

2025-02-25 Thread Dmitry Baryshkov
On Tue, Feb 25, 2025 at 10:14:32PM +0100, Luca Weiss wrote: > Add the description for the display panel found on this phone. > Unfortunately the LCDB module on PMI632 isn't yet supported upstream so > we need to use a dummy regulator-fixed in the meantime. > > And with this done we can also enable

Re: [PATCH v2 3/4] drm/panel: Add driver for DJN HX83112B LCD panel

2025-02-25 Thread Dmitry Baryshkov
On Tue, Feb 25, 2025 at 10:14:31PM +0100, Luca Weiss wrote: > Add support for the 2160x1080 LCD panel from DJN (98-03057-6598B-I) > bundled with a HX83112B driver IC, as found on the Fairphone 3 > smartphone. > > Signed-off-by: Luca Weiss > --- > drivers/gpu/drm/panel/Kconfig| 1

Re: [PATCH 1/5] drm/xe/bo: fix alignment with non-4K kernel page sizes

2025-02-25 Thread Matthew Brost
On Tue, Feb 25, 2025 at 11:05:16PM -0600, Lucas De Marchi wrote: > On Tue, Feb 25, 2025 at 08:18:42PM -0800, Matthew Brost wrote: > > On Tue, Feb 25, 2025 at 09:13:09PM -0600, Lucas De Marchi wrote: > > > On Wed, Feb 26, 2025 at 10:00:18AM +0800, Mingcong Bai via B4 Relay wrote: > > > > From: Mingc

Re: [PATCH 1/5] drm/xe/bo: fix alignment with non-4K kernel page sizes

2025-02-25 Thread Lucas De Marchi
On Tue, Feb 25, 2025 at 08:18:42PM -0800, Matthew Brost wrote: On Tue, Feb 25, 2025 at 09:13:09PM -0600, Lucas De Marchi wrote: On Wed, Feb 26, 2025 at 10:00:18AM +0800, Mingcong Bai via B4 Relay wrote: > From: Mingcong Bai > > The bo/ttm interfaces with kernel memory mapping from dedicated GPU

Re: [PATCH 2/5] drm/xe/guc: use SZ_4K for alignment

2025-02-25 Thread Matthew Brost
On Wed, Feb 26, 2025 at 10:00:19AM +0800, Mingcong Bai via B4 Relay wrote: > From: Mingcong Bai > > Per the "Firmware" chapter in "drm/xe Intel GFX Driver", as well as > "Volume 8: Command Stream Programming" in "Intel® Arc™ A-Series Graphics > and Intel Data Center GPU Flex Series Open-Source Pr

Re: [PATCH 2/5] drm/xe/guc: use SZ_4K for alignment

2025-02-25 Thread Matthew Brost
On Wed, Feb 26, 2025 at 10:00:19AM +0800, Mingcong Bai via B4 Relay wrote: > From: Mingcong Bai > > Per the "Firmware" chapter in "drm/xe Intel GFX Driver", as well as > "Volume 8: Command Stream Programming" in "Intel® Arc™ A-Series Graphics > and Intel Data Center GPU Flex Series Open-Source Pr

Re: [PATCH 5/5] drm/xe/query: use PAGE_SIZE as the minimum page alignment

2025-02-25 Thread Matthew Brost
On Wed, Feb 26, 2025 at 10:00:22AM +0800, Mingcong Bai via B4 Relay wrote: > From: Mingcong Bai > > As this component hooks into userspace API, it should be assumed that it > will play well with non-4K/64K pages. > > Use `PAGE_SIZE' as the final reference for page alignment instead. > > Cc: sta

Re: [PATCH 1/5] drm/xe/bo: fix alignment with non-4K kernel page sizes

2025-02-25 Thread Matthew Brost
On Tue, Feb 25, 2025 at 09:13:09PM -0600, Lucas De Marchi wrote: > On Wed, Feb 26, 2025 at 10:00:18AM +0800, Mingcong Bai via B4 Relay wrote: > > From: Mingcong Bai > > > > The bo/ttm interfaces with kernel memory mapping from dedicated GPU > > memory. It is not correct to assume that SZ_4K would

Re: [PATCH] drm/msm: Expose DRIVER_SYNCOBJ_TIMELINE

2025-02-25 Thread Akhil P Oommen
On 2/26/2025 4:22 AM, Rob Clark wrote: > From: Rob Clark > > Initially we didn't want to expose the cap, as it would expose a bug > in the vk driver (turnip) with older mesa versions. This was fixed over > a year ago (and cherry-picked to stable release branches at the time), > see https://gitla

Re: [PATCH v2] fbdev: hyperv_fb: Allow graceful removal of framebuffer

2025-02-25 Thread Saurabh Singh Sengar
On Tue, Feb 25, 2025 at 04:46:12PM +, Michael Kelley wrote: > From: Saurabh Sengar > > > > When a Hyper-V framebuffer device is unbind, hyperv_fb driver tries to > > release the framebuffer forcefully. If this framebuffer is in use it > > produce the following WARN and hence this framebuffer

Re: [PATCH 3/5] drm/xe/regs: fix RING_CTL_SIZE(size) calculation

2025-02-25 Thread Matthew Brost
On Wed, Feb 26, 2025 at 10:00:20AM +0800, Mingcong Bai via B4 Relay wrote: > From: Mingcong Bai > > Similar to the preceding patch for GuC (and with the same references), > Intel DG1 and DG2 GPUs expects command buffers to align to 4K boundaries. > > Current code uses `PAGE_SIZE' as an assumed a

Re: [PATCH 1/5] drm/xe/bo: fix alignment with non-4K kernel page sizes

2025-02-25 Thread Lucas De Marchi
On Wed, Feb 26, 2025 at 10:00:18AM +0800, Mingcong Bai via B4 Relay wrote: From: Mingcong Bai The bo/ttm interfaces with kernel memory mapping from dedicated GPU memory. It is not correct to assume that SZ_4K would suffice for page alignment as there are a few hardware platforms that commonly u

Re: [PATCH] drm/arm/komeda: Add a condition check before removing sysfs attribute

2025-02-25 Thread Shixiong Ou
Hello, In my opinion, the corresponding error handling has already been implemented in sysfs_create_group(), so we do not need to call sysfs_remove_group() if sysfs_create_group() fails. Thanks and Regards, Shixiong Ou. 在 2025/2/25 18:28, Liviu Dudau 写道: Hello, Replying from my personal

Re: [PATCH] drm/xe/regs: remove a duplicate definition for RING_CTL_SIZE(size)

2025-02-25 Thread Rodrigo Vivi
On Tue, Feb 25, 2025 at 03:34:03PM -0800, Matthew Brost wrote: > On Tue, Feb 25, 2025 at 03:31:01PM +0800, Mingcong Bai wrote: > > Commit b79e8fd954c4 ("drm/xe: Remove dependency on intel_engine_regs.h") > > introduced an internal set of engine registers, however, as part of this > > change, it has

Re: [PATCH 4/5] drm/xe: use 4K alignment for cursor jumps

2025-02-25 Thread Matthew Brost
On Wed, Feb 26, 2025 at 10:00:21AM +0800, Mingcong Bai via B4 Relay wrote: > From: Mingcong Bai > > It appears that the xe_res_cursor also assumes 4K alignment. > > Current code uses `PAGE_SIZE' as an assumed alignment reference but 4K > kernel page sizes is by no means a guarantee. On 16K-paged

Re: [PATCH v3 08/16] ata: libata-zpodd: convert timeouts to secs_to_jiffies()

2025-02-25 Thread Damien Le Moal
On 2/26/25 5:24 AM, Easwar Hariharan wrote: > On 2/25/2025 12:17 PM, Easwar Hariharan wrote: >> Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced >> secs_to_jiffies(). As the value here is a multiple of 1000, use >> secs_to_jiffies() instead of msecs_to_jiffies() to avoid the mu

[PATCH 4/5] drm/xe: use 4K alignment for cursor jumps

2025-02-25 Thread Mingcong Bai via B4 Relay
From: Mingcong Bai It appears that the xe_res_cursor also assumes 4K alignment. Current code uses `PAGE_SIZE' as an assumed alignment reference but 4K kernel page sizes is by no means a guarantee. On 16K-paged kernels, this causes driver failures during boot up: [ 23.242757] [ cut

[PATCH 3/5] drm/xe/regs: fix RING_CTL_SIZE(size) calculation

2025-02-25 Thread Mingcong Bai via B4 Relay
From: Mingcong Bai Similar to the preceding patch for GuC (and with the same references), Intel DG1 and DG2 GPUs expects command buffers to align to 4K boundaries. Current code uses `PAGE_SIZE' as an assumed alignment reference but 4K kernel page sizes is by no means a guarantee. On 16K-paged ke

[PATCH 2/5] drm/xe/guc: use SZ_4K for alignment

2025-02-25 Thread Mingcong Bai via B4 Relay
From: Mingcong Bai Per the "Firmware" chapter in "drm/xe Intel GFX Driver", as well as "Volume 8: Command Stream Programming" in "Intel® Arc™ A-Series Graphics and Intel Data Center GPU Flex Series Open-Source Programmer's Reference Manual For the discrete GPUs code named "Alchemist" and "Arctic

[PATCH 5/5] drm/xe/query: use PAGE_SIZE as the minimum page alignment

2025-02-25 Thread Mingcong Bai via B4 Relay
From: Mingcong Bai As this component hooks into userspace API, it should be assumed that it will play well with non-4K/64K pages. Use `PAGE_SIZE' as the final reference for page alignment instead. Cc: sta...@vger.kernel.org Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs

[PATCH 1/5] drm/xe/bo: fix alignment with non-4K kernel page sizes

2025-02-25 Thread Mingcong Bai via B4 Relay
From: Mingcong Bai The bo/ttm interfaces with kernel memory mapping from dedicated GPU memory. It is not correct to assume that SZ_4K would suffice for page alignment as there are a few hardware platforms that commonly uses non-4K pages - for instance, currently, Loongson 3A5000/6000 devices (of

[PATCH 0/5] drm/xe: enable driver usage on non-4KiB kernels

2025-02-25 Thread Mingcong Bai via B4 Relay
This patch series attempts to enable the use of xe DRM driver on non-4KiB kernel page platforms. This involves fixing the ttm/bo interface, as well as parts of the userspace API to make use of kernel `PAGE_SIZE' for alignment instead of the assumed `SZ_4K', it also fixes incorrect usage of `PAGE_SI

[PATCH 0/5] drm/xe: enable driver usage on non-4KiB kernels

2025-02-25 Thread Mingcong Bai
This patch series attempts to enable the use of xe DRM driver on non-4KiB kernel page platforms. This involves fixing the ttm/bo interface, as well as parts of the userspace API to make use of kernel `PAGE_SIZE' for alignment instead of the assumed `SZ_4K', it also fixes incorrect usage of `PAGE_SI

Re: [PATCH 02/17] bitops: Add generic parity calculation for u64

2025-02-25 Thread H. Peter Anvin
On February 25, 2025 1:43:27 PM PST, Andrew Cooper wrote: >> Incidentally, in all of this, didn't anyone notice __builtin_parity()? > >Yes.  It it has done sane for a decade on x86, yet does things such as >emitting a library call on other architectures. > >https://godbolt.org/z/6qG3noebq > >~And

Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation

2025-02-25 Thread Danilo Krummrich
On Tue, Feb 25, 2025 at 08:49:16PM -0400, Jason Gunthorpe wrote: > I'm pointing out the fundamental different in approachs. The typical > widely used pattern results in __device_release_driver() completing > with no concurrent driver code running. Typically yes, but there are exceptions, such as D

Re: [PATCH v7 0/3] Add HDMI audio on the rk3588 SoC

2025-02-25 Thread Kuninori Morimoto
Hi Detlev Thank you for the testing. > I got same report from our test team. I'm now tring to solve it. It seems our test team and your team are encounter same issues by different way, and it seems it happen if some kind of deffer issue happen (?). > That being said, I'm not sure I completely

linux-next: manual merge of the drm-xe tree with the drm-intel tree

2025-02-25 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-xe tree got a conflict in: drivers/gpu/drm/xe/display/xe_display.c between commit: 1b242ceec536 ("drm/i915/audio: convert to struct intel_display") from the drm-intel tree and commit: d41d048043c4 ("drm/xe/display: Drop xe_display_driver_remov

Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation

2025-02-25 Thread Jason Gunthorpe
On Wed, Feb 26, 2025 at 12:45:45AM +0100, Danilo Krummrich wrote: > On Tue, Feb 25, 2025 at 06:57:56PM -0400, Jason Gunthorpe wrote: > > The common driver shutdown process in the kernel, that is well tested > > and copied, makes the driver single threaded during the remove() > > callback. > > All

Re: [PATCH 03/17] x86: Replace open-coded parity calculation with parity8()

2025-02-25 Thread H. Peter Anvin
On February 25, 2025 2:46:23 PM PST, David Laight wrote: >On Mon, 24 Feb 2025 13:55:28 -0800 >"H. Peter Anvin" wrote: > >> On 2/24/25 07:24, Uros Bizjak wrote: >> > >> > >> > On 23. 02. 25 17:42, Kuan-Wei Chiu wrote: >> >> Refactor parity calculations to use the standard parity8() helper. Th

Re: [PATCH] drm/amd/display: fix type mismatch in CalculateDynamicMetadataParameters()

2025-02-25 Thread Alex Hung
On 2/22/25 16:58, Vitaliy Shevtsov wrote: There is a type mismatch between what CalculateDynamicMetadataParameters() takes and what is passed to it. Currently this function accepts several args as signed long but it's called with unsigned integers. On some systems where long is 32 bits and one

Re: [PATCH V2] drm/sched: fix fence reference count leak

2025-02-25 Thread Qianyi Liu
Hello Markus, >… >> fence callback add fails. > failed? >> To fix this, we should decrement the reference count of prev when >… > See also: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14-rc4#n94

Re: [PATCH v3 06/16] rbd: convert timeouts to secs_to_jiffies()

2025-02-25 Thread Easwar Hariharan
On 2/25/2025 1:09 PM, Christophe JAILLET wrote: > Le 25/02/2025 à 21:17, Easwar Hariharan a écrit : >> Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced >> secs_to_jiffies().  As the value here is a multiple of 1000, use >> secs_to_jiffies() instead of msecs_to_jiffies() to avoid

Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation

2025-02-25 Thread Danilo Krummrich
On Tue, Feb 25, 2025 at 06:57:56PM -0400, Jason Gunthorpe wrote: > The common driver shutdown process in the kernel, that is well tested > and copied, makes the driver single threaded during the remove() > callback. All devres callbacks run in the same callchain, __device_release_driver() first ca

Re: [PATCH] drm/xe/regs: remove a duplicate definition for RING_CTL_SIZE(size)

2025-02-25 Thread Matthew Brost
On Tue, Feb 25, 2025 at 03:31:01PM +0800, Mingcong Bai wrote: > Commit b79e8fd954c4 ("drm/xe: Remove dependency on intel_engine_regs.h") > introduced an internal set of engine registers, however, as part of this > change, it has also introduced two duplicate `define' lines for > `RING_CTL_SIZE(size

Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation

2025-02-25 Thread Danilo Krummrich
On Tue, Feb 25, 2025 at 06:57:56PM -0400, Jason Gunthorpe wrote: > I think this resource-revoke idea is deviating from the normal > expected driver model by allowing driver code to continue to run in > other threads once remove completes. That is definitely abnormal at > least. No, it simply guara

Re: [PATCH v4 6/6] drm/xe/xe_query: Add support for per-drm-client reset stat querying

2025-02-25 Thread Matthew Brost
On Thu, Feb 20, 2025 at 08:38:32PM +, Jonathan Cavitt wrote: > Add support for userspace to query per drm client reset stats via the > query ioctl. This includes the number of engine resets the drm client > has observed, as well as a list of up to the last 50 relevant exec > queue bans and the

Re: [PATCH v2] drm: add modifiers for Apple GPU layouts

2025-02-25 Thread Daniel Stone
Hi, On Tue, 25 Feb 2025 at 21:35, Alyssa Rosenzweig wrote: > These layouts are notably not used for interchange across hardware > blocks (e.g. with the display controller). There are other layouts for > that but we don't support them either in userspace or kernelspace yet > (even downstream), so

Re: [PATCH next] drm/msm/dpu: fix error pointer dereference in msm_kms_init_aspace()

2025-02-25 Thread Abhinav Kumar
On 2/24/2025 11:30 PM, Dan Carpenter wrote: If msm_gem_address_space_create() fails, then return right away. Otherwise it leads to a Oops when we dereference "aspace" on the next line. Fixes: 2d215d440faa ("drm/msm: register a fault handler for display mmu faults") Signed-off-by: Dan Carpente

[PATCH RESEND 08/12] drm/stm: move to devm_platform_ioremap_resource() usage

2025-02-25 Thread Anusha Srivatsa
Replace platform_get_resource + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_1@ identifier res; expression ioremap_res; identifier pdev; @@ -struct resource *res; ... -res = platform_get_resource(pdev,...); -ioremap_res = dev

Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation

2025-02-25 Thread Jason Gunthorpe
On Tue, Feb 25, 2025 at 04:02:28PM -0500, Joel Fernandes wrote: > > Besides that I don't really see why we can't just re-acquire it after we > > sleep? > > Rust provides good options to implement it ergonimcally I think. > > > > > > > > Another colleague told me RDMA also uses SRCU for a similar

Re: [PATCH] drm/amd/display: Fix null check for pipe_ctx->plane_state in resource_build_scaling_params

2025-02-25 Thread Alex Hung
On 2/23/25 23:32, Ma Ke wrote: Null pointer dereference issue could occur when pipe_ctx->plane_state is null. The fix adds a check to ensure 'pipe_ctx->plane_state' is not null before accessing. This prevents a null pointer dereference. Found by code review. Cc: sta...@vger.kernel.org Fixes:

[PATCH] drm/msm: Expose DRIVER_SYNCOBJ_TIMELINE

2025-02-25 Thread Rob Clark
From: Rob Clark Initially we didn't want to expose the cap, as it would expose a bug in the vk driver (turnip) with older mesa versions. This was fixed over a year ago (and cherry-picked to stable release branches at the time), see https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25981.

Re: [PATCH 03/17] x86: Replace open-coded parity calculation with parity8()

2025-02-25 Thread David Laight
On Mon, 24 Feb 2025 13:55:28 -0800 "H. Peter Anvin" wrote: > On 2/24/25 07:24, Uros Bizjak wrote: > > > > > > On 23. 02. 25 17:42, Kuan-Wei Chiu wrote: > >> Refactor parity calculations to use the standard parity8() helper. This > >> change eliminates redundant implementations and improves co

Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation

2025-02-25 Thread Dave Airlie
> > I'm saying that extending the time of critical sections is a concern, because > it's more likely to miss the unplug event and it's just not necessary. You > grab > the guard, do a few I/O ops and drop it -- simple. At least for nova-core I've realised I got this partly wrong, https://gitlab.

[PATCH RESEND 12/12] Documentation: Update the todo

2025-02-25 Thread Anusha Srivatsa
Update the Documentation to be more precise. v2: Update for clarity v3: Further details in Todo Cc: Thomas Zimmermann Signed-off-by: Anusha Srivatsa --- Documentation/gpu/todo.rst | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/Documentation/gpu/todo.rst b/Doc

[PATCH RESEND 11/12] drm/vc4: move to devm_platform_ioremap_resource() usage

2025-02-25 Thread Anusha Srivatsa
Replace platform_get_resource_byname + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: //rule s/(devm_)platform_get_resource_byname + //(devm_)ioremap/devm_platform_ioremap_resource. @rule_3@ identifier res; expression ioremap; identi

[PATCH RESEND 10/12] drm/tiny: move to devm_platform_ioremap_resource() usage

2025-02-25 Thread Anusha Srivatsa
Replace platform_get_resource + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_1@ identifier res; expression ioremap_res; identifier pdev; @@ -struct resource *res; ... -res = platform_get_resource(pdev,...); -ioremap_res = dev

[PATCH RESEND 09/12] drm/tegra: move to devm_platform_ioremap_resource() usage

2025-02-25 Thread Anusha Srivatsa
Replace platform_get_resource + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_1@ identifier res; expression ioremap_res; identifier pdev; @@ -struct resource *res; ... -res = platform_get_resource(pdev,...); -ioremap_res = dev

[PATCH RESEND 07/12] drm/sti: move to devm_platform_ioremap_resource() usage

2025-02-25 Thread Anusha Srivatsa
Replace platform_get_resource/_byname + devm_ioremap with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule@ identifier res; expression ioremap; identifier pdev; constant mem; expression name; @@ -struct resource *res; ... -res = platform_get_resource_byna

[PATCH RESEND 06/12] drm/sprd: move to devm_platform_ioremap_resource() usage

2025-02-25 Thread Anusha Srivatsa
Replace platform_get_resource + devm_ioremap with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_2@ identifier res; expression ioremap; identifier pdev; @@ -struct resource *res; ... -res = platform_get_resource(pdev,...); <... -if (!res) { -... -} ...>

[PATCH RESEND 05/12] drm/mxsfb: move to devm_platform_ioremap_resource() usage

2025-02-25 Thread Anusha Srivatsa
Replace platform_get_resource + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_1@ identifier res; expression ioremap_res; identifier pdev; @@ -struct resource *res; ... -res = platform_get_resource(pdev,...); -ioremap_res = dev

[PATCH RESEND 04/12] drm/mediatek: move to devm_platform_ioremap_resource() usage

2025-02-25 Thread Anusha Srivatsa
Replace platform_get_resource + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_1@ identifier res; expression ioremap_res; identifier pdev; @@ -struct resource *res; ... -res = platform_get_resource(pdev,...); -ioremap_res = dev

[PATCH RESEND 03/12] drm/hisilicon: move to devm_platform_ioremap_resource() usage

2025-02-25 Thread Anusha Srivatsa
Replace platform_get_resource + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_1@ identifier res; expression ioremap_res; identifier pdev; @@ -struct resource *res; ... -res = platform_get_resource(pdev,...); -ioremap_res = dev

[PATCH RESEND 02/12] drm/fsl-dcu: move to devm_platform_ioremap_resource() usage

2025-02-25 Thread Anusha Srivatsa
Replace platform_get_resource + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_1@ identifier res; expression ioremap_res; identifier pdev; @@ -struct resource *res; ... -res = platform_get_resource(pdev,...); -ioremap_res = dev

[PATCH RESEND 01/12] drm/aspeed: move to devm_platform_ioremap_resource() usage

2025-02-25 Thread Anusha Srivatsa
Replace platform_get_resource + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_1@ identifier res; expression ioremap_res; identifier pdev; @@ -struct resource *res; ... -res = platform_get_resource(pdev,...); -ioremap_res = dev

[PATCH RESEND 00/12] drm: Move to using devm_platform_ioremap_resource

2025-02-25 Thread Anusha Srivatsa
drm/vc4/vc4_hdmi.c | 53 + 28 files changed, 51 insertions(+), 171 deletions(-) --- base-commit: 27d4815149ba0c80ef2db2a82f0512f647e76d62 change-id: 20250225-memory-drm-misc-next-b2444b488db2 Best regards, -- Anusha Srivatsa

Re: [PATCH v2] drm: add modifiers for Apple GPU layouts

2025-02-25 Thread Alyssa Rosenzweig
> > These layouts are notably not used for interchange across hardware > > blocks (e.g. with the display controller). There are other layouts for > > that but we don't support them either in userspace or kernelspace yet > > (even downstream), so we don't add modifiers here. > > Yeah, when those ha

Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation

2025-02-25 Thread Danilo Krummrich
On Tue, Feb 25, 2025 at 04:02:28PM -0500, Joel Fernandes wrote: > On Tue, Feb 25, 2025 at 05:09:35PM +0100, Danilo Krummrich wrote: > > On Tue, Feb 25, 2025 at 10:52:41AM -0500, Joel Fernandes wrote: > > > > > > > > > On 2/24/2025 6:44 PM, Danilo Krummrich wrote: > > > > On Mon, Feb 24, 2025 at 0

Re: [PATCH 02/17] bitops: Add generic parity calculation for u64

2025-02-25 Thread Andrew Cooper
> Incidentally, in all of this, didn't anyone notice __builtin_parity()? Yes.  It it has done sane for a decade on x86, yet does things such as emitting a library call on other architectures. https://godbolt.org/z/6qG3noebq ~Andrew

Re: [PATCH] x86/platform/iosf_mbi: Remove unused iosf_mbi_unregister_pmic_bus_access_notifier

2025-02-25 Thread Ingo Molnar
* li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > The last use of iosf_mbi_unregister_pmic_bus_access_notifier() was > removed in 2017 by > commit a5266db4d314 ("drm/i915: Acquire PUNIT->PMIC bus for > intel_uncore_forcewake_reset()") > > Remove it. > > Note the '_unlocked' ve

[PATCH v2] drm: add modifiers for Apple GPU layouts

2025-02-25 Thread Alyssa Rosenzweig
Apple GPUs support various non-linear image layouts. Add modifiers for these layouts. Mesa requires these modifiers to share non-linear buffers across processes, but no other userspace or kernel support is required/expected. These layouts are notably not used for interchange across hardware blocks

Re: [PATCH v4 6/6] drm/xe/xe_query: Add support for per-drm-client reset stat querying

2025-02-25 Thread Matthew Brost
On Thu, Feb 20, 2025 at 08:38:32PM +, Jonathan Cavitt wrote: > Add support for userspace to query per drm client reset stats via the > query ioctl. This includes the number of engine resets the drm client > has observed, as well as a list of up to the last 50 relevant exec > queue bans and the

Re: [PATCH v3 07/16] libceph: convert timeouts to secs_to_jiffies()

2025-02-25 Thread Christophe JAILLET
Le 25/02/2025 à 21:17, Easwar Hariharan a écrit : Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies() to avoid the multiplication This is converted using scripts/cocc

[PATCH v2 1/4] dt-bindings: vendor-prefixes: document Shenzhen DJN Optronics Technology

2025-02-25 Thread Luca Weiss
Add the vendor prefix for DJN (http://en.djnlcd.com/). Acked-by: Krzysztof Kozlowski Signed-off-by: Luca Weiss --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation

[PATCH v2 4/4] arm64: dts: qcom: sdm632-fairphone-fp3: Enable display and GPU

2025-02-25 Thread Luca Weiss
Add the description for the display panel found on this phone. Unfortunately the LCDB module on PMI632 isn't yet supported upstream so we need to use a dummy regulator-fixed in the meantime. And with this done we can also enable the GPU and set the zap shader firmware path. Reviewed-by: Konrad Dy

[PATCH v2 0/4] Add display support for Fairphone 3 smartphone

2025-02-25 Thread Luca Weiss
Add a driver for the HX83112B-based panel, and enable it on Fairphone 3 to enable display output, and enable GPU as well. Signed-off-by: Luca Weiss --- Changes in v2: - Change compatible to "djn,98-03057-6598b-i" based on other docs I found - Pick up tags - Link to v1: https://lore.kernel.org/

[PATCH v2 2/4] dt-bindings: display: panel: Add Himax HX83112B

2025-02-25 Thread Luca Weiss
Himax HX83112B is a display driver IC used to drive LCD DSI panels. Describe it and the Fairphone 3 panel (98-03057-6598B-I) from DJN using it. Signed-off-by: Luca Weiss --- .../bindings/display/panel/himax,hx83112b.yaml | 75 ++ 1 file changed, 75 insertions(+) diff --g

[PATCH v2 3/4] drm/panel: Add driver for DJN HX83112B LCD panel

2025-02-25 Thread Luca Weiss
Add support for the 2160x1080 LCD panel from DJN (98-03057-6598B-I) bundled with a HX83112B driver IC, as found on the Fairphone 3 smartphone. Signed-off-by: Luca Weiss --- drivers/gpu/drm/panel/Kconfig| 10 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm

Re: [PATCH v4 1/6] drm/xe/xe_exec_queue: Add ID param to exec queue struct

2025-02-25 Thread Matthew Brost
On Thu, Feb 20, 2025 at 08:38:27PM +, Jonathan Cavitt wrote: > Add the exec queue id to the exec queue struct. This is useful for > performing a reverse lookup into the xef->exec_queue xarray. > > Signed-off-by: Jonathan Cavitt Have quite a few comments on the series, assuming this is neede

Re: [PATCH v4 4/6] drm/xe/xe_drm_client: Add per drm client reset stats

2025-02-25 Thread Matthew Brost
On Thu, Feb 20, 2025 at 08:38:30PM +, Jonathan Cavitt wrote: > Add a counter to xe_drm_client that tracks the number of times the > engine has been reset since the drm client was created. > > Signed-off-by: Jonathan Cavitt > --- > drivers/gpu/drm/xe/xe_drm_client.h | 2 ++ > drivers/gpu/drm/

Re: [PATCH v3 06/16] rbd: convert timeouts to secs_to_jiffies()

2025-02-25 Thread Christophe JAILLET
Le 25/02/2025 à 21:17, Easwar Hariharan a écrit : Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies() to avoid the multiplication This is converted using scripts/cocc

Re: [PATCH v4 3/6] drm/xe/xe_drm_client: Add per drm client pagefault info

2025-02-25 Thread Matthew Brost
On Thu, Feb 20, 2025 at 08:38:29PM +, Jonathan Cavitt wrote: > Add additional information to drm client so it can report up to the last > 50 exec queues to have been banned on it, as well as the last pagefault > seen when said exec queues were banned. Since we cannot reasonably > associate a p

[PATCH 2/2] dt-bindings: display: mitsubishi, aa104xd12: Adjust allowed and required properties

2025-02-25 Thread Rob Herring (Arm)
The Mitsubishi aa104xd12 panel requires an external backlight driver circuit, so allow the "backlight" property. There are users of this panel without a vcc-supply, so it shouldn't be required. Signed-off-by: Rob Herring (Arm) --- .../devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml

[PATCH 1/2] dt-bindings: display: mitsubishi, aa104xd12: Allow jeida-18 for data-mapping

2025-02-25 Thread Rob Herring (Arm)
There's both a user and the datasheet[1] indicate that 6-bpp is supported as well. [1] https://agdisplays.com/pub/media/catalog/datasheet/Mitsubishi/AA104XD12.pdf Signed-off-by: Rob Herring (Arm) --- .../bindings/display/panel/mitsubishi,aa104xd12.yaml | 4 +++- 1 file changed, 3 inser

Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation

2025-02-25 Thread Joel Fernandes
On Tue, Feb 25, 2025 at 05:09:35PM +0100, Danilo Krummrich wrote: > On Tue, Feb 25, 2025 at 10:52:41AM -0500, Joel Fernandes wrote: > > > > > > On 2/24/2025 6:44 PM, Danilo Krummrich wrote: > > > On Mon, Feb 24, 2025 at 01:45:02PM -0500, Joel Fernandes wrote: > > >> Hi Danilo, > > >> > > >> On Mo

  1   2   3   4   >