Re: [PATCH v7 24/27] drm: sun4i: de33: mixer: add Display Engine 3.3 (DE33) support

2025-02-22 Thread Ryan Walklin
On Sun, 23 Feb 2025, at 8:15 PM, Jernej Škrabec wrote: >> +if (mixer->cfg->de_type == sun8i_mixer_de33) >> +regmap_write(mixer->top_regs, SUN50I_MIXER_GLOBAL_DBUFF, >> + SUN8I_MIXER_GLOBAL_DBUFF_ENABLE); > > This was my mistake. There is no such thing as >

Re: [PATCH v7 24/27] drm: sun4i: de33: mixer: add Display Engine 3.3 (DE33) support

2025-02-22 Thread Jernej Škrabec
Dne nedelja, 16. februar 2025 ob 19:36:24 Srednjeevropski standardni čas je Ryan Walklin napisal(a): > From: Jernej Skrabec > > The DE33 is a newer version of the Allwinner Display Engine IP block, > found in the H616, H618, H700 and T507 SoCs. DE2 and DE3 are already > supported by the mainline

Re: [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc

2025-02-22 Thread Aditya Garg
> On 22 Feb 2025, at 5:41 PM, Aditya Garg wrote: > >  > >> On 21 Feb 2025, at 8:57 PM, andriy.shevche...@linux.intel.com wrote: >>> On Thu, Feb 20, 2025 at 04:39:23PM +, Aditya Garg wrote: >>> From: Hector Martin >>> %p4cc is designed for DRM/V4L2 FOURCCs with their specific quirks, but

Re: Please backport "drm: select DRM_KMS_HELPER from DRM_GEM_SHMEM_HELPER" to 6.13.x

2025-02-22 Thread Slade Watkins
On 2/22/2025 8:20 PM, NoisyCoil wrote: The build (actually, linking) failure described in [1] affects current stable (6.13.4). Could the commit that fixes it in mainline, namely, c40ca9ef7c5c9bbb0d2f7774c87417cc4f1713bf ("drm: select DRM_KMS_HELPER from DRM_GEM_SHMEM_HELPER") be backported to

Re: [PATCH v3 drm-dp 7/8] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-02-22 Thread kernel test robot
e' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Yongbang-Shi/drm-hisilicon-hibmc-Restructuring-the-header-dp_reg-h/20250222-110052 base: linus/master patch link: https://lore.kernel.org/r/20250222025102

Re: [PATCH v7 08/27] drm: sun4i: de3: add YUV support to the DE3 mixer

2025-02-22 Thread Ryan Walklin
On Sat, 22 Feb 2025, at 10:30 PM, Jernej Škrabec wrote: > Dne nedelja, 16. februar 2025 ob 19:36:08 Srednjeevropski standardni > čas je Ryan Walklin napisal(a): >> +struct regmap *top_regs; >> +struct regmap *disp_regs; > > This chunk is DE33 specific an

Re: [PATCH v7 00/27] drm: sun4i: add Display Engine 3.3 (DE33) support

2025-02-22 Thread Ryan Walklin
On Sat, 22 Feb 2025, at 10:28 PM, Jernej Škrabec wrote: > Sorry, completely forgot. YUV420 HDMI code relies on my previous work, > with which > Maxime wasn't happy with: > > https://lore.kernel.org/linux-sunxi/20230924192604.3262187-1-jernej.skra...@gmail.com/ > > So unless switching HDMI to br

RE: [PATCH] fbdev: hyperv_fb: Allow graceful removal of framebuffer

2025-02-22 Thread Michael Kelley
From: Saurabh Singh Sengar Sent: Saturday, February 22, 2025 9:27 AM > > On Wed, Feb 19, 2025 at 05:22:36AM +, Michael Kelley wrote: > > From: Saurabh Sengar Sent: Saturday, February > > 15, > 2025 1:21 AM > > > > > > When a Hyper-V framebuffer device is unbind, hyperv_fb driver tries to >

Re: [PATCH v6 08/14] drm/rockchip: analogix_dp: Add support to get panel from the DP AUX bus

2025-02-22 Thread Damon Ding
Hi Heiko, On 2025/1/31 4:33, Heiko Stübner wrote: Hi Damon, Am Donnerstag, 23. Januar 2025, 11:07:41 MEZ schrieb Damon Ding: Move drm_of_find_panel_or_bridge() a little later and combine it with component_add() into a new function rockchip_dp_link_panel(). The function will serve as done_probi

[PATCH 4/4] arm64: dts: qcom: sdm632-fairphone-fp3: Enable display and GPU

2025-02-22 Thread Luca Weiss
Add the description for the display panel found on this phone. Unfortunately the LCDB module on PMI632 isn't yet supported upstream so we need to use a dummy regulator-fixed in the meantime. And with this done we can also enable the GPU and set the zap shader firmware path. Signed-off-by: Luca We

[PATCH 0/4] Add display support for Fairphone 3 smartphone

2025-02-22 Thread Luca Weiss
+ 7 files changed, 581 insertions(+), 1 deletion(-) --- base-commit: 197aed880d4de2127c80c389ec62601b7d837351 change-id: 20250222-fp3-display-b79cb339e65b Best regards, -- Luca Weiss

[PATCH 1/4] dt-bindings: vendor-prefixes: document Shenzhen DJN Optronics Technology

2025-02-22 Thread Luca Weiss
Add the vendor prefix for DJN (http://en.djnlcd.com/). Signed-off-by: Luca Weiss --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-pre

[PATCH 2/4] dt-bindings: display: panel: Add Himax HX83112B

2025-02-22 Thread Luca Weiss
Himax HX83112B is a display driver IC used to drive LCD DSI panels. Describe it and the Fairphone 3 panel from DJN using it. Signed-off-by: Luca Weiss --- .../bindings/display/panel/himax,hx83112b.yaml | 75 ++ 1 file changed, 75 insertions(+) diff --git a/Documentation

[PATCH 3/4] drm/panel: Add driver for DJN HX83112B LCD panel

2025-02-22 Thread Luca Weiss
Add support for the 2160x1080 LCD panel from DJN bundled with a HX83112B driver IC, as found on the Fairphone 3 smartphone. Signed-off-by: Luca Weiss --- drivers/gpu/drm/panel/Kconfig| 10 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-himax-

Re: [PATCH v2 1/2] dt-bindings: mfd: Document TI LM3533 MFD

2025-02-22 Thread Jonathan Cameron
On Sat, 22 Feb 2025 16:39:31 +0200 Svyatoslav Ryhel wrote: > сб, 22 лют. 2025 р. о 16:29 Jonathan Cameron пише: > > > > On Tue, 18 Feb 2025 15:26:59 +0200 > > Svyatoslav Ryhel wrote: > > > > > Add bindings for the LM3533 - a complete power source for > > > backlight, keypad, and indicator LED

Re: [PATCH] fbdev: hyperv_fb: Allow graceful removal of framebuffer

2025-02-22 Thread Saurabh Singh Sengar
On Wed, Feb 19, 2025 at 05:22:36AM +, Michael Kelley wrote: > From: Saurabh Sengar Sent: Saturday, February > 15, 2025 1:21 AM > > > > When a Hyper-V framebuffer device is unbind, hyperv_fb driver tries to > > release the framebuffer forcefully. If this framebuffer is in use it > > produce t

[PATCH 5/5] drm: panel-orientation-quirks: Add Zotac Gaming Zone quirk

2025-02-22 Thread Antheas Kapenekakis
The Zotac Gaming Zone handheld features a 1080p portrait OLED screen. Add the rotation to the panel orientation quirks. Signed-off-by: Antheas Kapenekakis --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/drm_panel_orient

[PATCH 4/5] HID: Add quirk to ignore the touchscreen battery on OneXPlayer X1

2025-02-22 Thread Antheas Kapenekakis
The X1 devices come with a pen-capable touchscreen, in which the HID descriptor reports there is always a battery at 100% charge. Quirk it to not report the battery status. Signed-off-by: Antheas Kapenekakis --- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-input.c | 2 ++ 2 files changed, 3 in

[PATCH 3/5] drm: panel-orientation-quirks: Add OneXPlayer F1Pro quirk

2025-02-22 Thread Antheas Kapenekakis
The OneXPlayer F1Pro has a 144hz 1920x1080 portrait OLED panel. Add a quirk to correct the panel portrait orientation. In addition, it comes with a red limited edition variant in the Chinese market, so add that as well. Signed-off-by: Antheas Kapenekakis --- drivers/gpu/drm/drm_panel_orientation

[PATCH 2/5] drm: panel-orientation-quirks: Add OneXPlayer X1 Mini (AMD) quirk

2025-02-22 Thread Antheas Kapenekakis
The OneXPlayer X1 mini features a 2k 8.8 display with a portrait orientation. Add a quirk to set the panel orientation to portrait mode. There is no Intel variant. Signed-off-by: Antheas Kapenekakis --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++ 1 file changed, 6 insertions(+) d

[PATCH 1/5] drm: panel-orientation-quirks: Add OneXPlayer X1 AMD and Intel quirk

2025-02-22 Thread Antheas Kapenekakis
The OneXPlayer X1 series features a 2k 10.95 display with a portrait orientation. Add a quirk to set the panel orientation to portrait mode to both the Intel and AMD variants. Signed-off-by: Antheas Kapenekakis --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++ 1 file ch

[PATCH 0/5] drm: panel-orientation-quirks: Add 2024 OneXPlayer line & ZOTAC Zone orientation quirks

2025-02-22 Thread Antheas Kapenekakis
A number of OneXPlayer handhelds have come out with portrait panels. Specifically, those are the X1 AMD and Intel variants, X1 Mini, and F1 Pro. For X1 specifically, they also have spurious battery reporting within their digitizer. The Zotac Gaming Zone also has a portrait OLED panel, so add that a

Re: [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc

2025-02-22 Thread Aditya Garg
> On 20 Feb 2025, at 10:09 PM, Aditya Garg wrote: > > From: Hector Martin > > %p4cc is designed for DRM/V4L2 FOURCCs with their specific quirks, but > it's useful to be able to print generic 4-character codes formatted as > an integer. Extend it to add format specifiers for printing generic >

Re: [PATCH v2 1/2] dt-bindings: mfd: Document TI LM3533 MFD

2025-02-22 Thread Svyatoslav Ryhel
сб, 22 лют. 2025 р. о 16:29 Jonathan Cameron пише: > > On Tue, 18 Feb 2025 15:26:59 +0200 > Svyatoslav Ryhel wrote: > > > Add bindings for the LM3533 - a complete power source for > > backlight, keypad, and indicator LEDs in smartphone handsets. > > The high-voltage inductive boost converter prov

Re: [PATCH v2 1/2] dt-bindings: mfd: Document TI LM3533 MFD

2025-02-22 Thread Jonathan Cameron
On Tue, 18 Feb 2025 15:26:59 +0200 Svyatoslav Ryhel wrote: > Add bindings for the LM3533 - a complete power source for > backlight, keypad, and indicator LEDs in smartphone handsets. > The high-voltage inductive boost converter provides the > power for two series LED strings display backlight and

Re: [PATCH v2 1/2] dt-bindings: mfd: Document TI LM3533 MFD

2025-02-22 Thread Jonathan Cameron
On Sat, 22 Feb 2025 09:01:18 +0200 Svyatoslav Ryhel wrote: > пт, 21 лют. 2025 р. о 22:38 Rob Herring пише: > > > > On Tue, Feb 18, 2025 at 03:26:59PM +0200, Svyatoslav Ryhel wrote: > > > Add bindings for the LM3533 - a complete power source for > > > backlight, keypad, and indicator LEDs in sm

Re: [PATCH v3 3/3] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-22 Thread Aditya Garg
> On 22 Feb 2025, at 2:37 PM, Aditya Garg wrote: > >> >> What padding, please? Why TCP UAPI headers do not have these attributes? >> Think about it, and think about what actually __packed does and how it >> affects >> (badly) the code generation. Otherwise it looks like a cargo cult. >> >>>

Re: [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc

2025-02-22 Thread Aditya Garg
> On 21 Feb 2025, at 8:57 PM, andriy.shevche...@linux.intel.com wrote: > > On Thu, Feb 20, 2025 at 04:39:23PM +, Aditya Garg wrote: >> From: Hector Martin >> >> %p4cc is designed for DRM/V4L2 FOURCCs with their specific quirks, but >> it's useful to be able to print generic 4-character cod

Re: [PATCH v6 08/14] drm/rockchip: analogix_dp: Add support to get panel from the DP AUX bus

2025-02-22 Thread Damon Ding
Hi Lucas, On 2025/2/8 3:42, Lucas Stach wrote: Hi Damon, Am Donnerstag, dem 23.01.2025 um 18:07 +0800 schrieb Damon Ding: Move drm_of_find_panel_or_bridge() a little later and combine it with component_add() into a new function rockchip_dp_link_panel(). The function will serve as done_probing(

Re: [PATCH 3/4] arm64: dts: rockchip: Add HDMI1 PHY PLL clock source to VOP2 on RK3588

2025-02-22 Thread Johannes Erdfelt
On Tue, Feb 18, 2025, Heiko Stübner wrote: > I was more thinking about fixing the correct thing, with something like: > > --- 8< -- > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > index cf7720b9172f..50faafbf5dda 100644 > --- a/drivers/clk/clk.c > +++ b/drivers/clk/clk.c >

Re: [PATCH v3 drm-dp 2/8] drm/hisilicon/hibmc: Add dp serdes cfg to adjust serdes rate, voltage and pre-emphasis

2025-02-22 Thread Yongbang Shi
On Sat, Feb 22, 2025 at 10:50:55AM +0800, Yongbang Shi wrote: From: Baihan Li This dp controller need features of digital-to-analog conversion and high-speed transmission in chip by its extern serdes controller. Our serdes cfg is relatively simple, just need two register configurations. Don't n

Re: [PATCH v6 08/14] drm/rockchip: analogix_dp: Add support to get panel from the DP AUX bus

2025-02-22 Thread Damon Ding
On 2025/2/22 19:25, Damon Ding wrote: Hi Heiko, On 2025/1/31 4:33, Heiko Stübner wrote: Hi Damon, Am Donnerstag, 23. Januar 2025, 11:07:41 MEZ schrieb Damon Ding: Move drm_of_find_panel_or_bridge() a little later and combine it with component_add() into a new function rockchip_dp_link_panel()

Re: [PATCH v4 3/8] mailbox: mtk-cmdq: Add driver data to support for MT8196

2025-02-22 Thread 林睿祥

Re: [PATCH v3 drm-dp 3/8] drm/hisilicon/hibmc: Add dp serdes cfg in dp process

2025-02-22 Thread Yongbang Shi
On Sat, Feb 22, 2025 at 10:50:56AM +0800, Yongbang Shi wrote: From: Baihan Li Add dp serdes cfg in link training process, and related adapting and modificating. Change some init values about training, because we want completely to negotiation process, so we start with the maximum rate and the e

Re: [PATCH v3 drm-dp 7/8] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-02-22 Thread Yongbang Shi
+static int hibmc_dp_hpd_event(struct drm_client_dev *client) +{ + struct hibmc_dp *dp = container_of(client, struct hibmc_dp, client); + struct hibmc_drm_private *priv = to_hibmc_drm_private(dp->drm_dev); + struct drm_display_mode *mode = &priv->crtc.state->adjusted_mode; +

Re: [PATCH v3 drm-dp 7/8] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-02-22 Thread Yongbang Shi
On Sat, Feb 22, 2025 at 10:51:00AM +0800, Yongbang Shi wrote: From: Baihan Li Enable HPD feature and add its isr and event function. Add a drm client dev and realized the hotplug callback in it. What for? There should be no need to add a separate drm client just for the hotplug. Signed-off-b

Re: [PATCH v3 drm-dp 6/8] drm/hisilicon/hibmc: Add colorbar-cfg feature and its debugfs file

2025-02-22 Thread Yongbang Shi
On Sat, Feb 22, 2025 at 10:50:59AM +0800, Yongbang Shi wrote: From: Baihan Li DP controller can support generating a color bar signal over the DisplayPort interface. This can be useful to check for possible DDR or GPU problems, as the signal generator resides completely in the DP block. Add deb

[PATCH RFC] drm/vc4: hdmi: Add jack detection to HDMI audio driver

2025-02-22 Thread Stefan Wahren
From: David Turner Add ALSA jack detection to the vc4-hdmi audio driver so userspace knows when to add/remove HDMI audio devices. Signed-off-by: David Turner Signed-off-by: Stefan Wahren --- drivers/gpu/drm/vc4/vc4_hdmi.c | 26 -- drivers/gpu/drm/vc4/vc4_hdmi.h | 7 ++

Re: [PATCH v7 08/27] drm: sun4i: de3: add YUV support to the DE3 mixer

2025-02-22 Thread Jernej Škrabec
Dne nedelja, 16. februar 2025 ob 19:36:08 Srednjeevropski standardni čas je Ryan Walklin napisal(a): > From: Jernej Skrabec > > The mixer in the DE3 display engine supports YUV 8 and 10 bit > formats in addition to 8-bit RGB. Add the required register > configuration and format enumeration callb

Re: [PATCH v7 00/27] drm: sun4i: add Display Engine 3.3 (DE33) support

2025-02-22 Thread Jernej Škrabec
Dne sobota, 22. februar 2025 ob 03:48:01 Srednjeevropski standardni čas je Ryan Walklin napisal(a): > On Sat, 22 Feb 2025, at 7:57 AM, Jernej Škrabec wrote: > > Hi Ryan, > > > > sorry for very late review, but here we go... > > No problem, thanks for the review! > > > This patchset actually intr

Re: [PATCH v3 3/3] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-22 Thread Aditya Garg
> What padding, please? Why TCP UAPI headers do not have these attributes? > Think about it, and think about what actually __packed does and how it affects > (badly) the code generation. Otherwise it looks like a cargo cult. > >> I tried removing __packed btw and driver no longer works. > > So,