RE: [PATCH 1/3] drm/dp: Add the DPCD register required for Extended wake timeout

2025-01-20 Thread Murthy, Arun R
> Add DPCD registers required to configure Extended Wake Timeout for LTTPR. > > Signed-off-by: Suraj Kandpal > --- Reviewed-by: Arun R Murthy Thanks and Regards, Arun R Murthy > include/drm/display/drm_dp.h | 14 ++ > 1 file changed, 14 insertions(+) > > diff

[PATCH] drm/aspeed: Use devm_platform_get_and_ioremap_resource()

2025-01-20 Thread oushixiong1025
From: Shixiong Ou Signed-off-by: Shixiong Ou --- drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c index a7a6b70220eb..33f81b53771d 100644 --- a/drivers

Re: [PATCH v3 1/1] regmap: Synchronize cache for the page selector

2025-01-20 Thread Marek Szyprowski
On 17.01.2025 18:28, Andy Shevchenko wrote: > On Fri, Jan 17, 2025 at 05:05:42PM +0100, Marek Szyprowski wrote: >> On 17.01.2025 15:30, Andy Shevchenko wrote: >>> On Fri, Jan 17, 2025 at 04:09:58PM +0200, Andy Shevchenko wrote: On Fri, Jan 17, 2025 at 02:57:52PM +0100, Marek Szyprowski wrote:

Re: [PATCH v3 1/1] regmap: Synchronize cache for the page selector

2025-01-20 Thread Marek Szyprowski
On 17.01.2025 18:28, Andy Shevchenko wrote: > On Fri, Jan 17, 2025 at 05:05:42PM +0100, Marek Szyprowski wrote: >> On 17.01.2025 15:30, Andy Shevchenko wrote: >>> On Fri, Jan 17, 2025 at 04:09:58PM +0200, Andy Shevchenko wrote: On Fri, Jan 17, 2025 at 02:57:52PM +0100, Marek Szyprowski wrote:

[PATCH v4] drm/bridge: it6505: fix HDCP V match check is not performed correctly

2025-01-20 Thread Hermes Wu via B4 Relay
From: Hermes Wu Fix a typo where V compare incorrectly compares av[] with av[] itself, which can result in HDCP failure. The loop of V compare is expected to iterate for 5 times which compare V array form av[0][] to av[4][]. It should check loop counter reach the last statement "i == 5" before r

[PATCH] fbdev/sh_mobile_lcdcfb: Use backlight helper

2025-01-20 Thread oushixiong1025
From: Shixiong Ou Signed-off-by: Shixiong Ou --- drivers/video/fbdev/sh_mobile_lcdcfb.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c index 6b37b188af31..69c9067eff88 100644 --- a/drivers

RE: [PATCH v7 01/14] drm: Define histogram structures exposed to user

2025-01-20 Thread Murthy, Arun R
> > On Thu, Jan 16, 2025 at 01:33:43PM +, Murthy, Arun R wrote: > > > > On Thu, Jan 16, 2025 at 12:33:20PM +, Murthy, Arun R wrote: > > > > > > > > On Fri, Jan 10, 2025 at 01:15:29AM +0530, Arun R Murthy wrote: > > > > > > > > > Display Histogram is an array of bins and can be > > > > > > >

[PATCH v6 6/6] arm64: dts: rockchip: Fix label name of hdptxphy for RK3588

2025-01-20 Thread Damon Ding
The hdptxphy is a combo transmit-PHY for HDMI2.1 TMDS Link, FRL Link, DP and eDP Link. Therefore, it is better to name it hdptxphy0 other than hdptxphy_hdmi0, which will be referenced by both hdmi0 and edp0 nodes. Signed-off-by: Damon Ding --- arch/arm64/boot/dts/rockchip/rk3588-base.dtsi

[PATCH v6 5/6] dt-bindings: display: rockchip: Fix label name of hdptxphy for RK3588 HDMI TX Controller

2025-01-20 Thread Damon Ding
The hdptxphy is a combo transmit-PHY for HDMI2.1 TMDS Link, FRL Link, DP and eDP Link. Therefore, it is better to name it hdptxphy0 other than hdptxphy_hdmi0, which will be referenced by both hdmi0 and edp0 nodes. Acked-by: Rob Herring (Arm) Signed-off-by: Damon Ding --- .../bindings/display/ro

[PATCH v6 4/6] phy: phy-rockchip-samsung-hdptx: Add eDP mode support for RK3588

2025-01-20 Thread Damon Ding
The PHY is based on a Samsung IP block that supports HDMI 2.1, and eDP 1.4b. RK3588 integrates the Analogix eDP 1.3 TX controller IP and the HDMI/eDP TX Combo PHY to support eDP display. Add basic support for RBR/HBR/HBR2 link rates, and the voltage swing and pre-emphasis configurations of each li

[PATCH v6 3/6] phy: phy-rockchip-samsung-hdptx: Add the '_MASK' suffix to all registers

2025-01-20 Thread Damon Ding
Adding the '_MASK' suffix to all registers in order to ensures consistency in the naming convention for register macros throughout the file. Signed-off-by: Damon Ding Reviewed-by: Dmitry Baryshkov --- Changes in v4: - Split the older patch related to the renaming of registers into three diff

[PATCH v6 2/6] phy: phy-rockchip-samsung-hdptx: Supplement some register names with their full version

2025-01-20 Thread Damon Ding
Complete the register names of CMN_REG(0081) and CMN_REG(0087) to their full version, and it can help to better match the datasheet. Signed-off-by: Damon Ding Reviewed-by: Dmitry Baryshkov --- drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 delet

[PATCH v6 1/6] phy: phy-rockchip-samsung-hdptx: Swap the definitions of LCPLL_REF and ROPLL_REF

2025-01-20 Thread Damon Ding
According to the datasheet, setting the dig_clk_sel bit of CMN_REG(0097) to 1'b1 selects LCPLL as the reference clock, while setting it to 1'b0 selects the ROPLL. Signed-off-by: Damon Ding Reviewed-by: Dmitry Baryshkov --- drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 4 ++-- 1 file chang

[PATCH v6 0/6] Add eDP mode support for Rockchip Samsung HDPTX PHY

2025-01-20 Thread Damon Ding
Picked from: https://patchwork.kernel.org/project/linux-rockchip/list/?series=923593 These patchs have been tested with a 1536x2048p60 eDP panel on RK3588S EVB1 board, and HDMI 1080P/4K display also has been verified on RK3588 EVB1 board. Damon Ding (6): phy: phy-rockchip-samsung-hdptx: Swap th

[PATCH] drm/i915/backlight: Return immediately when scale() finds invalid parameters

2025-01-20 Thread Guenter Roeck
The scale() functions detects invalid parameters, but continues its calculations anyway. This causes bad results if negative values are used for unsigned operations. Worst case, a division by 0 error will be seen if source_min == source_max. On top of that, after v6.13, the sequence of WARN_ON() f

[PATCH 0/3] Extended Wake Timeout

2025-01-20 Thread Suraj Kandpal
Retimers in H/w usually takes 30 to 40ms to wake up all the devices. To get this we use the Extended Wake Time feature in which the sink device tells us the minimum amount of time it requires to wake up and we need to do a write to grant this request else we need to wake up within 1ms of low power

[PATCH 3/3] drm/i915/lttpr: Enable Extended Wake Timeout

2025-01-20 Thread Suraj Kandpal
Usually retimers take around 30 to 40ms to exit all devices from sleep state. Extended wake timeout mechanism helps to give that additional time. --v2 -Grant the requested time only if greater than 1ms [Arun/Jani] -Reframe commit message [Arun] --v3 -Move the function to drm_core [Dmitry/Jani] S

[PATCH 1/3] drm/dp: Add the DPCD register required for Extended wake timeout

2025-01-20 Thread Suraj Kandpal
Add DPCD registers required to configure Extended Wake Timeout for LTTPR. Signed-off-by: Suraj Kandpal --- include/drm/display/drm_dp.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h index a6f8b098c56f..480370bba1de

[PATCH 2/3] drm/display/dp: Define function to setup Extended wake time

2025-01-20 Thread Suraj Kandpal
Extended wake timeout request helps to give additional time by reading the DPCD register through which sink requests the minimal amount of time required to wake the sink up. Source device shall keep retying the AUX tansaction till the extended timeout that is being granted for LTTPRs from the sink

Re: [RFC PATCH 08/12] vfio/pci: Create host unaccessible dma-buf for private device

2025-01-20 Thread Xu Yilun
On Mon, Jan 20, 2025 at 09:25:25AM -0400, Jason Gunthorpe wrote: > On Mon, Jun 24, 2024 at 03:59:53AM +0800, Xu Yilun wrote: > > > But it also seems to me that VFIO should be able to support putting > > > the device into the RUN state > > > > Firstly I think VFIO should support putting device into

Re: [PATCH v2 7/7] accel/qaic: Add AIC200 support

2025-01-20 Thread Manivannan Sadhasivam
On Fri, Jan 17, 2025 at 10:09:43AM -0700, Jeffrey Hugo wrote: > Add basic support for the new AIC200 product. The PCIe Device ID is > 0xa110. With this, we can turn on the lights for AIC200 by leveraging > much of the existing driver. > > Co-developed-by: Youssef Samir > Signed-off-by: Youssef Sa

Re: [PATCH v2 2/7] bus: mhi: host: Add a policy to enable image transfer via BHIe in PBL

2025-01-20 Thread Manivannan Sadhasivam
On Fri, Jan 17, 2025 at 10:09:38AM -0700, Jeffrey Hugo wrote: > From: Matthew Leung > > Currently, MHI host only performs firmware transfer via BHI in PBL and > BHIe from SBL. To support BHIe transfer directly from PBL, a policy > needs to be added. > > With this policy, BHIe will be used to tra

Re: [PATCH v2 1/7] bus: mhi: host: Refactor BHI/BHIe based firmware loading

2025-01-20 Thread Manivannan Sadhasivam
On Fri, Jan 17, 2025 at 10:09:37AM -0700, Jeffrey Hugo wrote: > From: Matthew Leung > > Refactor the firmware loading code to have distinct helper functions for > BHI and BHIe operations. This lays the foundation for separating the > firmware loading protocol from the firmware being loaded and th

RE: [PATCH 2/2] drm/i915/lttpr: Enable Extended Wake Timeout

2025-01-20 Thread Kandpal, Suraj
> -Original Message- > From: Dmitry Baryshkov > Sent: Friday, January 17, 2025 11:50 AM > To: Kandpal, Suraj > Cc: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org; Murthy, Arun R > Subject: Re: [PATCH 2/2] drm/i915/lttpr: Enable Exte

Re: [PATCH v4 16/16] drm/msm/dpu: Enable quad-pipe for DSC and dual-DSI case

2025-01-20 Thread Jun Nie
Marijn Suijten 于2025年1月20日周一 04:58写道: > > On 2025-01-17 15:32:44, Jun Nie wrote: > > Dmitry Baryshkov 于2025年1月16日周四 16:32写道: > > > > > > On Thu, Jan 16, 2025 at 03:26:05PM +0800, Jun Nie wrote: > > > > Request 4 mixers and 4 DSC for the case that both dual-DSI and DSC are > > > > enabled. > > > >

RE: [PATCH v3 4/5] drm/i915/display: Populate list of async supported formats/modifiers

2025-01-20 Thread Murthy, Arun R
> On Wed, Jan 08, 2025 at 11:09:02AM +0530, Arun R Murthy wrote: > > Populate the list of formats/modifiers supported by async flip. > > Register a async property and expose the same to user through blob. > > > > Signed-off-by: Arun R Murthy > > --- > > drivers/gpu/drm/i915/display/skl_universal_

Re: [PATCH v10 2/4] drm/doc: Document device wedged event

2025-01-20 Thread Xaver Hugl
> +It is the responsibility of the consumer to make sure that the device or > +its resources are not in use by any process before attempting recovery. I'm not convinced this is actually doable in practice, outside of killing all apps that aren't the one trying to recover the GPU. Is this just about

Re: [PATCH v10 0/4] Introduce DRM device wedged event

2025-01-20 Thread Xaver Hugl
Hi, I experimented with using this in KWin, and https://invent.kde.org/plasma/kwin/-/merge_requests/7027/diffs?commit_id=6da40f1b9e2bc94615a436de4778880cee16f940 makes it fall back to a software renderer when a rebind is required to recover the GPU. Making it also survive the rebind properly is mo

Re: [PATCH v5 08/15] drm/msm/dpu: bind correct pingpong for quad pipe

2025-01-20 Thread Jun Nie
Marijn Suijten 于2025年1月20日周一 05:15写道: > > On 2025-01-18 00:00:51, Jun Nie wrote: > > There are 2 interfaces and 4 pingpong in quad pipe. Map the 2nd > > interface to 3rd PP instead of the 2nd PP. > > Can you explain why this patch uses the number of LMs, instead of dividing the > number of PPs div

[PATCH RFC] drm/msm/dpu: Fall back to a single DSC encoder (1:1:1) on small SoCs

2025-01-20 Thread Marijn Suijten
Some SoCs such as SC7280 (used in the FairPhone 5) have only a single DSC "hard slice" encoder. The current hardcoded use of 2:2:1 topology (2 LM and 2 DSC for a single interface) make it impossible to use Display Stream Compression panels with mainline, which is exactly what's installed on the Fa

Re: [PATCH] drm/panic: fix compilation issue on ARM

2025-01-20 Thread Miguel Ojeda
On Mon, Jan 20, 2025 at 11:03 PM Link Mauve wrote: > > when building with today’s nightly compiler (maybe that’s relevant?). Ah, that explains it! The type changes with beta (1.85.0), and I can also reproduce it in CE. We should probably try to backport the cleanups we did before the remapping,

Re: [PATCH 2/2] drm/meson: vclk: fix precision in vclk calculations

2025-01-20 Thread kernel test robot
Hi Christian, kernel test robot noticed the following build errors: [auto build test ERROR on linus/master] [also build test ERROR on v6.13 next-20250120] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as

Re: [PATCH] drm/panic: fix compilation issue on ARM

2025-01-20 Thread Link Mauve
On Mon, Jan 20, 2025 at 10:52:48PM +0100, Miguel Ojeda wrote: > Hi Emmanuel, Hi Miguel, > > On Mon, Jan 20, 2025 at 1:45 PM Emmanuel Gil Peyrot > wrote: > > > > In C, the char type is specified with “The implementation shall define char > > to > > have the same range, representation, and behav

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2025-01-20 Thread Laurent Pinchart
On Fri, Jan 10, 2025 at 01:23:40PM -0800, James Jones wrote: > On 12/19/24 10:03, Simona Vetter wrote: > > On Thu, Dec 19, 2024 at 09:02:27AM +, Daniel Stone wrote: > >> On Wed, 18 Dec 2024 at 10:32, Brian Starkey wrote: > >>> On Wed, Dec 18, 2024 at 11:24:58AM +, Simona Vetter wrote: > >>

Re: [PATCH] drm/panic: fix compilation issue on ARM

2025-01-20 Thread Miguel Ojeda
Hi Emmanuel, On Mon, Jan 20, 2025 at 1:45 PM Emmanuel Gil Peyrot wrote: > > In C, the char type is specified with “The implementation shall define char to > have the same range, representation, and behavior as either signed char or > unsigned char.” > > On x86 it defaults to signed char, and on A

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2025-01-20 Thread Laurent Pinchart
On Tue, Dec 17, 2024 at 11:13:05AM +0100, Michel Dänzer wrote: > On 2024-12-17 10:14, Brian Starkey wrote: > > On Sun, Dec 15, 2024 at 03:53:14PM +, Marek Olšák wrote: > >> The comment explains the problem with DRM_FORMAT_MOD_LINEAR. > >> > >> Signed-off-by: Marek Olšák > >> > >> diff --git a/

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2025-01-20 Thread Laurent Pinchart
On Mon, Jan 20, 2025 at 08:58:20AM +0100, Thomas Zimmermann wrote: > Am 18.01.25 um 03:37 schrieb Marek Olšák: > [...] > > > > 3) Implementing DRM_FORMAT_MOD_LINEAR as having 256B pitch and offset > > alignment. This is what we do today. Even if Intel and some AMD chips > > can do 64B or 128B ali

Re: [V7 41/45] drm/colorop: Add 3D LUT supports to color pipeline

2025-01-20 Thread Simon Ser
Some minor comments below, apart from that looks good! Typo in the commit title: s/supports/support/ > diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h > index 5ef87cb5b242..316c643e0dea 100644 > --- a/include/uapi/drm/drm_mode.h > +++ b/include/uapi/drm/drm_mode.h > @@ -913

Re: [PATCH v3 4/5] drm/i915/display: Populate list of async supported formats/modifiers

2025-01-20 Thread Ville Syrjälä
On Wed, Jan 08, 2025 at 11:09:02AM +0530, Arun R Murthy wrote: > Populate the list of formats/modifiers supported by async flip. Register > a async property and expose the same to user through blob. > > Signed-off-by: Arun R Murthy > --- > drivers/gpu/drm/i915/display/skl_universal_plane.c | 51

Re: [PATCH v3 2/5] drm/plane: Expose function to create format/modifier blob

2025-01-20 Thread Ville Syrjälä
On Wed, Jan 08, 2025 at 11:09:00AM +0530, Arun R Murthy wrote: > Expose drm plane function to create formats/modifiers blob. This > function can be used to expose list of supported formats/modifiers for > sync/async flips. > > Signed-off-by: Arun R Murthy > --- > drivers/gpu/drm/drm_plane.c | 44

Re: [RFC PATCH 01/12] dma-buf: Introduce dma_buf_get_pfn_unlocked() kAPI

2025-01-20 Thread Jason Gunthorpe
On Mon, Jan 20, 2025 at 07:50:23PM +0100, Simona Vetter wrote: > On Mon, Jan 20, 2025 at 01:59:01PM -0400, Jason Gunthorpe wrote: > > On Mon, Jan 20, 2025 at 01:14:12PM +0100, Christian König wrote: > > What is going wrong with your email? You replied to Simona, but > > Simona Vetter is dropped fr

Re: [RFC PATCH 01/12] dma-buf: Introduce dma_buf_get_pfn_unlocked() kAPI

2025-01-20 Thread Simona Vetter
On Mon, Jan 20, 2025 at 01:59:01PM -0400, Jason Gunthorpe wrote: > On Mon, Jan 20, 2025 at 01:14:12PM +0100, Christian König wrote: > What is going wrong with your email? You replied to Simona, but > Simona Vetter is dropped from the To/CC > list??? I added the address back, but seems like a weird

Re: [PATCH 1/4] drm/sched: Add job popping API

2025-01-20 Thread Christian König
Am 20.01.25 um 18:13 schrieb Danilo Krummrich: On Mon, Jan 20, 2025 at 04:52:37PM +, Tvrtko Ursulin wrote: Idea is to add a helper for popping jobs from the entity with the goal of making amdgpu use it in the next patch. That way amdgpu will decouple itself a tiny bit more from scheduler imp

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2025-01-20 Thread Simona Vetter
On Mon, Jan 20, 2025 at 08:58:20AM +0100, Thomas Zimmermann wrote: > Hi > > > Am 18.01.25 um 03:37 schrieb Marek Olšák: > [...] > > > > 3) Implementing DRM_FORMAT_MOD_LINEAR as having 256B pitch and offset > > alignment. This is what we do today. Even if Intel and some AMD chips > > can do 64B o

Re: [RFC PATCH 01/12] dma-buf: Introduce dma_buf_get_pfn_unlocked() kAPI

2025-01-20 Thread Jason Gunthorpe
On Mon, Jan 20, 2025 at 01:14:12PM +0100, Christian König wrote: What is going wrong with your email? You replied to Simona, but Simona Vetter is dropped from the To/CC list??? I added the address back, but seems like a weird thing to happen. > Please take another look at what is proposed here.

Re: [PATCH v7 11/12] drm/atomic-helper: Re-order bridge chain pre-enable and post-disable

2025-01-20 Thread Aradhya Bhatia
Hi Dmitry, On 20/01/25 14:08, Dmitry Baryshkov wrote: > On Fri, Jan 17, 2025 at 06:37:00PM +0530, Aradhya Bhatia wrote: >> Hi Dmitry, >> >> On 14/01/25 16:54, Dmitry Baryshkov wrote: >>> On Tue, Jan 14, 2025 at 11:26:25AM +0530, Aradhya Bhatia wrote: Move the bridge pre_enable call before crt

Re: [PATCH v4 3/3] drm/vkms: Switch to dynamic allocation for CRTC

2025-01-20 Thread Louis Chauvet
On 20/01/25 - 17:23, José Expósito wrote: > > A specific allocation for the CRTC is not strictly necessary at this > > point, but in order to implement dynamic configuration of VKMS (configFS), > > it will be easier to have one allocation per CRTC. > > > > Reviewed-by: Maxime Ripard > > Signed-of

[RFC v3 14/18] riscv: dts: thead: Add device tree VO clock controller

2025-01-20 Thread Michal Wilczynski
VO clocks reside in a different address space from the AP clocks on the T-HEAD SoC. Add the device tree node of a clock-controller to handle VO address space as well. Signed-off-by: Michal Wilczynski --- arch/riscv/boot/dts/thead/th1520.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --g

[RFC v3 15/18] riscv: dts: thead: Add mailbox node

2025-01-20 Thread Michal Wilczynski
Add mailbox device tree node. This work is based on the vendor kernel [1]. Link: https://github.com/revyos/thead-kernel.git [1] Reviewed-by: Drew Fustini Signed-off-by: Michal Wilczynski --- arch/riscv/boot/dts/thead/th1520.dtsi | 16 1 file changed, 16 insertions(+) diff --g

[RFC v3 13/18] drm/imagination: Enable PowerVR driver for RISC-V

2025-01-20 Thread Michal Wilczynski
Several RISC-V boards feature Imagination GPUs that are compatible with the PowerVR driver. An example is the IMG BXM-4-64 GPU on the Lichee Pi 4A board. This commit adjusts the driver's Kconfig dependencies to allow the PowerVR driver to be compiled on the RISC-V architecture. By enabling compila

[RFC v3 16/18] riscv: dts: thead: Introduce power domain nodes with aon firmware

2025-01-20 Thread Michal Wilczynski
The DRM Imagination GPU requires a power-domain driver. In the T-HEAD TH1520 SoC implements power management capabilities through the E902 core, which can be communicated with through the mailbox, using firmware protocol. Add AON node, which servers as a power-domain controller. Signed-off-by: Mi

[RFC v3 18/18] riscv: dts: thead: Add GPU node to TH1520 device tree

2025-01-20 Thread Michal Wilczynski
Add a device tree node for the IMG BXM-4-64 GPU present in the T-HEAD TH1520 SoC used by the Lichee Pi 4A board. This node enables support for the GPU using the drm/imagination driver. By adding this node, the kernel can recognize and initialize the GPU, providing graphics acceleration capabilitie

[RFC v3 17/18] riscv: dts: thead: Introduce reset controller node

2025-01-20 Thread Michal Wilczynski
T-HEAD TH1520 SoC requires to put the GPU out of the reset state as part of the power-up sequence. Signed-off-by: Michal Wilczynski --- arch/riscv/boot/dts/thead/th1520.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/the

[RFC v3 11/18] dt-bindings: gpu: Add compatibles for T-HEAD TH1520 GPU

2025-01-20 Thread Michal Wilczynski
Add a new SoC-specific compatible ("thead,th1520-gpu") for the T-HEAD TH1520 GPU, alongside the Imagination BXM family compatible ("img,img-bxm"). This documents the GPU integration on the T-HEAD platform. Also adjust clock name constraints to accommodate a second clock named "sys" instead of "me

[RFC v3 09/18] drm/imagination: Add reset controller support for GPU initialization

2025-01-20 Thread Michal Wilczynski
Certain platforms, such as the T-Head TH1520 and Banana Pi BPI-F3, require a controlled GPU reset sequence during the power-up procedure to ensure proper initialization. Without this reset, the GPU may remain in an undefined state, potentially leading to stability or performance issues. This commi

[RFC v3 08/18] reset: thead: Add TH1520 reset controller driver

2025-01-20 Thread Michal Wilczynski
Introduce reset controller driver for the T-HEAD TH1520 SoC. The controller manages hardware reset lines for various SoC subsystems, such as the GPU. By exposing these resets via the Linux reset subsystem, drivers can request and control hardware resets to reliably initialize or recover key compone

[RFC v3 02/18] clk: thead: Add clock support for VO subsystem in T-Head TH1520 SoC

2025-01-20 Thread Michal Wilczynski
The T-Head TH1520 SoC integrates a variety of clocks for its subsystems, including the Application Processor (AP) and the Video Output (VO) [1]. Up until now, the T-Head clock driver only supported AP clocks. This commit extends the driver to provide clock functionality for the VO subsystem. At th

[RFC v3 07/18] dt-bindings: reset: Add T-HEAD TH1520 SoC Reset Controller

2025-01-20 Thread Michal Wilczynski
Add a YAML schema for the T-HEAD TH1520 SoC reset controller. This controller manages resets for subsystems such as the GPU within the TH1520 SoC. Signed-off-by: Michal Wilczynski --- .../bindings/reset/thead,th1520-reset.yaml| 44 +++ MAINTAINERS

[RFC v3 06/18] riscv: Enable PM_GENERIC_DOMAINS for T-Head SoCs

2025-01-20 Thread Michal Wilczynski
T-Head SoCs feature separate power domains (power islands) for major components like the GPU, Audio, and NPU. To manage the power states of these components effectively, the kernel requires generic power domain support. This commit enables `CONFIG_PM_GENERIC_DOMAINS` for T-Head SoCs, allowing the

[RFC v3 12/18] drm/imagination: Add support for IMG BXM-4-64 GPU

2025-01-20 Thread Michal Wilczynski
The IMG BXM-4-64 GPU is integrated into the T-Head TH1520 SoC. This commit adds the compatible string "img,img-bxm" to the device tree match table in the drm/imagination driver, enabling support for this GPU. By including this GPU in the compatible devices list, the driver can initialize and manag

[RFC v3 03/18] dt-bindings: firmware: thead,th1520: Add support for firmware node

2025-01-20 Thread Michal Wilczynski
The kernel communicates with the E902 core through the mailbox transport using AON firmware protocol. Add dt-bindings to document it the dt node. Signed-off-by: Michal Wilczynski --- .../bindings/firmware/thead,th1520-aon.yaml | 53 +++ MAINTAINERS

[RFC v3 10/18] dt-bindings: gpu: Add 'resets' property for GPU initialization

2025-01-20 Thread Michal Wilczynski
Many RISC-V boards featuring Imagination Technologies GPUs require a reset line to be de-asserted as part of the GPU power-up sequence. To support this, add a 'resets' property (and corresponding 'reset-names') to the GPU device tree bindings. This ensures the GPU can be properly initialized on the

[RFC v3 05/18] pmdomain: thead: Add power-domain driver for TH1520

2025-01-20 Thread Michal Wilczynski
The T-Head TH1520 SoC contains multiple power islands that can be programmatically turned on and off using the AON (Always-On) protocol and a hardware mailbox [1]. The relevant mailbox driver has already been merged into the mainline kernel in commit 5d4d263e1c6b ("mailbox: Introduce support for T-

[RFC v3 04/18] firmware: thead: Add AON firmware protocol driver

2025-01-20 Thread Michal Wilczynski
The T-Head TH1520 SoC uses an E902 co-processor running Always-On (AON) firmware to manage power, clock, and other system resources [1]. This patch introduces a driver implementing the AON firmware protocol, allowing the Linux kernel to communicate with the firmware via mailbox channels. Through a

[RFC v3 01/18] dt-bindings: clock: Add VO subsystem clock controller support

2025-01-20 Thread Michal Wilczynski
Add a separate compatible string "thead,th1520-clk-vo" to describe the Video Output (VO) subsystem clock controller in the T-Head TH1520 SoC. The VO subsystem configures the clock gates for HDMI, MIPI, and GPU components. Meanwhile, the existing AP sub-system clock controller remains responsible fo

[RFC v3 00/18] Enable drm/imagination BXM-4-64 Support for LicheePi 4A

2025-01-20 Thread Michal Wilczynski
The LicheePi 4A board, featuring the T-HEAD TH1520 SoC, includes an Imagination Technologies BXM-4-64 GPU. Initial support for this GPU was provided through a downstream driver [1]. Recently, efforts have been made to upstream support for the Rogue family GPUs, which the BXM-4-64 is part of [2]. W

Re: [PATCH 3/4] drm/sched: Remove to_drm_sched_job internal helper

2025-01-20 Thread Danilo Krummrich
On Mon, Jan 20, 2025 at 04:52:39PM +, Tvrtko Ursulin wrote: > The code assumes queue node is the first element in struct > drm_sched_job. I'd add that this assumption lies in doing the NULL check after the container_of(). Without saying that, it might not be that obvious. > Since this is not

Re: [PATCH 1/4] drm/sched: Add job popping API

2025-01-20 Thread Danilo Krummrich
On Mon, Jan 20, 2025 at 04:52:37PM +, Tvrtko Ursulin wrote: > Idea is to add a helper for popping jobs from the entity with the goal > of making amdgpu use it in the next patch. That way amdgpu will decouple > itself a tiny bit more from scheduler implementation details. I object to adding thi

[PATCH 2/2] drm/sched: Consolidate drm_sched_rq_select_entity_rr

2025-01-20 Thread Tvrtko Ursulin
Extract out two copies of the identical code to function epilogue to make it smaller and more readable. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stanner --- drivers/gpu/drm/scheduler/sched_main.c | 48 +++--- 1 f

[PATCH 1/2] drm/sched: Clarify locked section in drm_sched_rq_select_entity_fifo

2025-01-20 Thread Tvrtko Ursulin
Rq->lock only protects the tree walk so lets move the rest out. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stanner --- drivers/gpu/drm/scheduler/sched_main.c | 31 ++ 1 file changed, 17 insertions(+), 14 deleti

[PATCH 0/2] Some entity selection streamlining

2025-01-20 Thread Tvrtko Ursulin
Two patches extracted from my deadline scheduler RFC. I think they are making the entity selection logic a bit easier on the eyes but as opinions may vary please have a look and see what you think. Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stanner Tvrtko Ursulin (

Re: [PATCH v3 1/7] dt-bindings: mailbox: mediatek: Add MT8196 support for gce-mailbox

2025-01-20 Thread Jassi Brar
On Mon, Jan 20, 2025 at 12:46 AM Chen-Yu Tsai wrote: > > On Sun, Jan 19, 2025 at 5:24 AM Jassi Brar wrote: > > > > On Thu, Dec 19, 2024 at 11:08 AM Jason-JH.Lin > > wrote: > > > > > > 1. Add compatible name and iommus property to mediatek,gce-mailbox.yaml > > >for MT8196. > > > > > >- T

[PATCH 3/4] drm/sched: Remove to_drm_sched_job internal helper

2025-01-20 Thread Tvrtko Ursulin
The code assumes queue node is the first element in struct drm_sched_job. Since this is not documented it can be very fragile so lets just remove the internal helper and explicitly check for "nothing dequeued", before converting the node to a sched job. Signed-off-by: Tvrtko Ursulin Cc: Christian

[PATCH 4/4] drm/sched: Make the type of drm_sched_job->last_dependency consistent

2025-01-20 Thread Tvrtko Ursulin
Dependency tracking via xarray uses xa_limit_32b so there is not need for the struct member to be unsigned long. At the same time re-order some struct members and take u32 credits outside of the pointer sandwich and avoid a hole. Pahole report before: /* size: 160, cachelines: 3, members:

[PATCH 2/4] drm/amdgpu: Use the new low level job popping helper

2025-01-20 Thread Tvrtko Ursulin
Amdgpu is the only driver which peeks into scheduler internals in this way so lets make it use the previously added helper. This allows removing the local copy of the to_drm_sched_job macro. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp St

[PATCH 0/4] A bit of struct drm_sched_job cleanup

2025-01-20 Thread Tvrtko Ursulin
At one point I thought I wanted to add a member to struct drm_sched_job. As I noticed there is a hole in the struct, I went to re-order some members to get rid of it (the hole), at which point I was greeted by a subtle bug cause by the frequent pattern of: job = to_drm_sched_job(spsc_queue_peek|p

[PATCH 1/4] drm/sched: Add job popping API

2025-01-20 Thread Tvrtko Ursulin
Idea is to add a helper for popping jobs from the entity with the goal of making amdgpu use it in the next patch. That way amdgpu will decouple itself a tiny bit more from scheduler implementation details. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost

[PATCH v4 3/3] drm/vkms: Switch to dynamic allocation for CRTC

2025-01-20 Thread José Expósito
> A specific allocation for the CRTC is not strictly necessary at this > point, but in order to implement dynamic configuration of VKMS (configFS), > it will be easier to have one allocation per CRTC. > > Reviewed-by: Maxime Ripard > Signed-off-by: Louis Chauvet > --- > drivers/gpu/drm/vkms/vkm

Re: [RFC PATCH 01/12] dma-buf: Introduce dma_buf_get_pfn_unlocked() kAPI

2025-01-20 Thread Christian König
Am 21.06.24 um 00:02 schrieb Xu Yilun: On Thu, Jan 16, 2025 at 04:13:13PM +0100, Christian König wrote: Am 15.01.25 um 18:09 schrieb Jason Gunthorpe: On Wed, Jan 15, 2025 at 05:34:23PM +0100, Christian König wrote: Granted, let me try to improve this. Here is a real world examp

Re: [PATCH v5 2/2] i2c: i2c-qcom-geni: Add Block event interrupt support

2025-01-20 Thread kernel test robot
Hi Jyothi, kernel test robot noticed the following build warnings: [auto build test WARNING on 55bcd2e0d04c1171d382badef1def1fd04ef66c5] url: https://github.com/intel-lab-lkp/linux/commits/Jyothi-Kumar-Seerapu/dmaengine-qcom-gpi-Add-GPI-Block-event-interrupt-support/20250120-180058 base

Re: [RFC PATCH 08/12] vfio/pci: Create host unaccessible dma-buf for private device

2025-01-20 Thread Jason Gunthorpe
On Mon, Jan 20, 2025 at 08:45:51PM +1100, Alexey Kardashevskiy wrote: > > For CC I'm expecting the KVM fd to be the handle for the cVM, so any > > RPCs that want to call into the secure world need the KVM FD to get > > the cVM's identifier. Ie a "bind to cVM" RPC will need the PCI > > information

Re: [RFC PATCH 08/12] vfio/pci: Create host unaccessible dma-buf for private device

2025-01-20 Thread Jason Gunthorpe
On Mon, Jun 24, 2024 at 03:59:53AM +0800, Xu Yilun wrote: > > But it also seems to me that VFIO should be able to support putting > > the device into the RUN state > > Firstly I think VFIO should support putting device into *LOCKED* state. > From LOCKED to RUN, there are many evidence fetching and

Re: [PATCH v1 0/2] support for kingdisplay-kd110n11-51ie and starry-2082109qfh040022-50e MIPI-DSI panels

2025-01-20 Thread Langyan Ye
Hi, I already have DT binding for my panel.Please help review the patch for V4. Thank you very much. On Thu, Jan 16, 2025 at 10:04 PM Dmitry Baryshkov < dmitry.barysh...@linaro.org> wrote: > On Thu, Jan 16, 2025 at 09:05:30PM +0800, Langyan Ye wrote: > > The kingdisplay-kd110n11-51ie and starry-2

[PATCH 2/2] drm/bridge: nwl-dsi: Set bridge type

2025-01-20 Thread Alexander Stein
This is a DSI bridge, so set the bridge type accordingly. Signed-off-by: Alexander Stein --- drivers/gpu/drm/bridge/nwl-dsi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c index 1e5b2a37cb8c9..6f2581e0034b4 100644 --- a/dr

[PATCH 1/2] drm/bridge: ti-sn65dsi83: Set bridge type

2025-01-20 Thread Alexander Stein
This is a DSI to LVDS bridge, so set the bridge type accordingly. Signed-off-by: Alexander Stein --- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c index 336380114eea9..9e959

Re: [PATCH v5 08/15] drm/msm/dpu: bind correct pingpong for quad pipe

2025-01-20 Thread Marijn Suijten
On 2025-01-18 00:00:51, Jun Nie wrote: > There are 2 interfaces and 4 pingpong in quad pipe. Map the 2nd > interface to 3rd PP instead of the 2nd PP. Can you explain why this patch uses the number of LMs, instead of dividing the number of PPs divided by the number of physical encoders? This detai

Re: [PATCH v4 16/16] drm/msm/dpu: Enable quad-pipe for DSC and dual-DSI case

2025-01-20 Thread Marijn Suijten
On 2025-01-17 15:32:44, Jun Nie wrote: > Dmitry Baryshkov 于2025年1月16日周四 16:32写道: > > > > On Thu, Jan 16, 2025 at 03:26:05PM +0800, Jun Nie wrote: > > > Request 4 mixers and 4 DSC for the case that both dual-DSI and DSC are > > > enabled. > > > > Why? What is the issue that you are solving? > >

Re: [PATCH] drm/panfrost: Drop redundant Mediatek driver data

2025-01-20 Thread AngeloGioacchino Del Regno
Il 18/01/25 17:06, Krzysztof Kozlowski ha scritto: mediatek_mt8192_supplies are exactly the same as mediatek_mt8183_b_supplies. mediatek_mt8188_data is exactly the same as &mediatek_mt8183_b_data. There is never point in duplicating all these structures - it only raises questions or encourages

[PATCH] drm/panic: fix compilation issue on ARM

2025-01-20 Thread Emmanuel Gil Peyrot
In C, the char type is specified with “The implementation shall define char to have the same range, representation, and behavior as either signed char or unsigned char.” On x86 it defaults to signed char, and on ARM it defaults to unsigned char. This carries over to Rust’s FFI, which aliases its c

[PATCH 5.10] drm/radeon: check bo_va->bo is non-NULL before using it

2025-01-20 Thread Denis Arefev
From: Pierre-Eric Pelloux-Prayer commit 6fb15dcbcf4f212930350eaee174bb60ed40a536 upstream. The call to radeon_vm_clear_freed might clear bo_va->bo, so we have to check it before dereferencing it. Signed-off-by: Pierre-Eric Pelloux-Prayer Acked-by: Alex Deucher Signed-off-by: Alex Deucher [De

Re: [PATCH v5 32/34] drm/mediatek: Introduce HDMI/DDC v2 for MT8195/MT8188

2025-01-20 Thread AngeloGioacchino Del Regno
Il 17/01/25 23:04, kernel test robot ha scritto: Hi AngeloGioacchino, kernel test robot noticed the following build warnings: CK, if there's no other concern about this submission, and you deem it ready to be applied - can you please resolve this error while applying by adding `#include ` b

Re: drm/bridge: nwl-dsi: Use vsync/hsync polarity from display mode

2025-01-20 Thread Alexander Stein
Hi, I'm sorry I'm late to the party. Am Mittwoch, 14. August 2024, 12:37:26 CET schrieb Esben Haabendal: > Using the correct bit helps. The documentation specifies bit 0 in both > registers to be controlling polarity of dpi_vsync_input and > dpi_hsync_input polarity. Bit 1 is reserved, and should

Re: [RFC PATCH 01/12] dma-buf: Introduce dma_buf_get_pfn_unlocked() kAPI

2025-01-20 Thread Christian König
Am 17.01.25 um 15:42 schrieb Simona Vetter: On Wed, Jan 15, 2025 at 11:06:53AM +0100, Christian König wrote: [SNIP] Anything missing? Well as far as I can see this use case is not a good fit for the DMA-buf interfaces in the first place. DMA-buf deals with devices and buffer exchange. What's

Re: [PATCH 2/2] drm/client: Handle tiled displays better

2025-01-20 Thread Thomas Zimmermann
Am 16.01.25 um 15:28 schrieb Maarten Lankhorst: When testing on my tiled display, initially the tiled display is detected correctly: [90376.523692] xe :67:00.0: [drm:drm_client_firmware_config.isra.0 [drm]] fallback: Not all outputs enabled [90376.523713] xe :67:00.0: [drm:drm_client

Re: [PATCH 1/2] drm/modeset: Handle tiled displays in pan_display_atomic.

2025-01-20 Thread Thomas Zimmermann
Hi Am 16.01.25 um 15:28 schrieb Maarten Lankhorst: Tiled displays have a different x/y offset to begin with. Instead of attempting to remember this, just apply a delta instead. Hope this works.. As far as I understand the tile code, this makes sense. Signed-off-by: Maarten Lankhorst Ac

Re: [PATCH] drm/i915: Handle null 'fb' in 'intel_plane_atomic_check_with_state'

2025-01-20 Thread Jani Nikula
On Mon, 20 Jan 2025, Lu Yao wrote: > Add null pointer check before use fb. > Reported by smatch. If new_plane_state->uapi.visible is true, fb will be non-NULL too, but smatch is unable to see that. Adding these checks makes one believe that this is not something you can rely on. BR, Jani. > >

Re: [PATCH 8/8] drm/ast: Only warn about unsupported TX chips on Gen4 and later

2025-01-20 Thread Jocelyn Falempe
On 17/01/2025 11:29, Thomas Zimmermann wrote: Only Gen4 and later read the installed TX chip from the SoC. So only warn on those generations about unsupported chips. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mai

Re: [PATCH 7/8] drm/ast: Merge TX-chip detection code for Gen4 and later

2025-01-20 Thread Jocelyn Falempe
On 17/01/2025 11:29, Thomas Zimmermann wrote: Gens 4 to 6 and Gen7 use the same pattern for detecting the installed TX chips. Merge the code into a single branch. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_main.c

Re: [PATCH 5/8] drm/ast: Hide Gens 1 to 3 TX detection in branch

2025-01-20 Thread Jocelyn Falempe
On 17/01/2025 11:29, Thomas Zimmermann wrote: Gen7 only supports ASTDP. Gens 4 to 6 support various TX chips, except ASTDP. These boards detect the TX chips by reading the SoC scratch register as VGACRD1. Gens 1 to 3 only support SIL164. These boards read the DVO bit from VGACRA3. Hence move thi

Re: [PATCH 6/8] drm/ast: Align Gen1 DVO detection to register manual

2025-01-20 Thread Jocelyn Falempe
On 17/01/2025 11:29, Thomas Zimmermann wrote: Align variable names and register constants for TX-chip detection to the names in the register manual. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_main.c | 6 +++---

  1   2   >