Re: [PATCH] drm/i915/gt: Handle INTEL_WAKEREF_DEF return value in gen8_ggtt_bind_get_ce

2025-01-16 Thread Jani Nikula
On Fri, 17 Jan 2025, Ingyu Jang wrote: > The function 'gen8_ggtt_bind_get_ce' previously did not handle the case > where 'intel_gt_pm_get_if_awake()' returns 'INTEL_WAKEREF_DEF'. > This value is returned when the 'intel_ref_tracker_alloc()' call within > 'intel_gt_pm_get_if_awake()' fails to alloc

Re: [PATCH v4 16/16] drm/msm/dpu: Enable quad-pipe for DSC and dual-DSI case

2025-01-16 Thread Jun Nie
Dmitry Baryshkov 于2025年1月16日周四 16:32写道: > > On Thu, Jan 16, 2025 at 03:26:05PM +0800, Jun Nie wrote: > > Request 4 mixers and 4 DSC for the case that both dual-DSI and DSC are > > enabled. > > Why? What is the issue that you are solving? To support high-resolution cases that exceed the width

Re: [PATCH v2 2/4] dt-bindings: display: panel: Add compatible for STARRY 2082109QFH040022-50E

2025-01-16 Thread Krzysztof Kozlowski
On 17/01/2025 06:04, Langyan Ye wrote: > The STARRY 2082109QFH040022-50E is a 10.95" WUXGA TFT LCD panel, > which fits in nicely with the existing panel-boe-tv101wum-nl6 > driver. Hence, we add a new compatible with panel specific config. > "Add a new compatible for foo bar panel ". One senten

Re: [PATCH v2 1/4] dt-bindings: display: panel: Add compatible for KINGDISPLAY KD110N11-51IE

2025-01-16 Thread Krzysztof Kozlowski
On 17/01/2025 06:04, Langyan Ye wrote: > The KINGDISPLAY KD110N11-51IE is a 10.95" WUXGA TFT LCD panel, > which fits in nicely with the existing panel-boe-tv101wum-nl6 > driver. Hence, we add a new compatible with panel specific config. > > Signed-off-by: Langyan Ye Please use scripts/get_maint

Re: [RFC PATCH 01/12] dma-buf: Introduce dma_buf_get_pfn_unlocked() kAPI

2025-01-16 Thread Xu Yilun
On Thu, Jan 16, 2025 at 04:13:13PM +0100, Christian König wrote: >Am 15.01.25 um 18:09 schrieb Jason Gunthorpe: > > On Wed, Jan 15, 2025 at 05:34:23PM +0100, Christian König wrote: > > Granted, let me try to improve this. > Here is a real world example of one of the issues we ran int

Re: [PATCH 2/2] drm/i915/lttpr: Enable Extended Wake Timeout

2025-01-16 Thread Dmitry Baryshkov
On Fri, Jan 17, 2025 at 11:18:50AM +0530, Suraj Kandpal wrote: > Usually retimers take around 30 to 40ms to exit all devices from > sleep state. Extended wake timeout request helps to give additional > time by reading the DPCD register through which sink requests the > minimal amount of time requir

RE: [PATCH v7 01/14] drm: Define histogram structures exposed to user

2025-01-16 Thread Murthy, Arun R
> On Thu, Jan 16, 2025 at 01:33:43PM +, Murthy, Arun R wrote: > > > On Thu, Jan 16, 2025 at 12:33:20PM +, Murthy, Arun R wrote: > > > > > > > On Fri, Jan 10, 2025 at 01:15:29AM +0530, Arun R Murthy wrote: > > > > > > > > Display Histogram is an array of bins and can be generated > > > > > >

[PATCH 2/2] drm/i915/lttpr: Enable Extended Wake Timeout

2025-01-16 Thread Suraj Kandpal
Usually retimers take around 30 to 40ms to exit all devices from sleep state. Extended wake timeout request helps to give additional time by reading the DPCD register through which sink requests the minimal amount of time required to wake the sink up. Source device shall keep retying the AUX tans

[PATCH 1/2] drm/dp: Add the DPCD register required for Extended wake timeout

2025-01-16 Thread Suraj Kandpal
Add DPCD registers required to configure Extended Wake Timeout for LTTPR. Signed-off-by: Suraj Kandpal --- include/drm/display/drm_dp.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h index a6f8b098c56f..480370bba1de

[PATCH 0/2] Extended Wake Timeout

2025-01-16 Thread Suraj Kandpal
Retimers in H/w usually takes 30 to 40ms to wake up all the devices. To get this we use the Extended Wake Time feature in which the sink device tells us the minimum amount of time it requires to wake up and we need to do a write to grant this request else we need to wake up within 1ms of low power

[PATCH v2 4/4] drm/panel: boe-tv101wum-nl6: support for starry-2082109qfh040022-50e MIPI-DSI panel

2025-01-16 Thread Langyan Ye
The starry-2082109qfh040022-50e is a 10.95" TFT panel. which fits in nicely with the existing panel-boe-tv101wum-nl6 driver. >From the datasheet, MIPI needs to keep the LP11 state before the lcm_reset pin is pulled high, so increase lp11_before_reset flag. Signed-off-by: Langyan Ye --- .../gpu/d

[PATCH v2 3/4] drm/panel: boe-tv101wum-nl6: support for kingdisplay-kd110n11-51ie MIPI-DSI panel

2025-01-16 Thread Langyan Ye
The kingdisplay-kd110n11-51ie is a 10.95" TFT panel. which fits in nicely with the existing panel-boe-tv101wum-nl6 driver. >From the datasheet, MIPI needs to keep the LP11 state before the lcm_reset pin is pulled high, so increase lp11_before_reset flag. Signed-off-by: Langyan Ye --- .../gpu/drm

[PATCH v2 1/4] dt-bindings: display: panel: Add compatible for KINGDISPLAY KD110N11-51IE

2025-01-16 Thread Langyan Ye
The KINGDISPLAY KD110N11-51IE is a 10.95" WUXGA TFT LCD panel, which fits in nicely with the existing panel-boe-tv101wum-nl6 driver. Hence, we add a new compatible with panel specific config. Signed-off-by: Langyan Ye --- .../devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml | 2 ++ 1

[PATCH v2 2/4] dt-bindings: display: panel: Add compatible for STARRY 2082109QFH040022-50E

2025-01-16 Thread Langyan Ye
The STARRY 2082109QFH040022-50E is a 10.95" WUXGA TFT LCD panel, which fits in nicely with the existing panel-boe-tv101wum-nl6 driver. Hence, we add a new compatible with panel specific config. Signed-off-by: Langyan Ye --- .../devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml | 2 ++

[PATCH v2 0/4] Add kd110n11-51ie and 2082109qfh040022-50e bindings

2025-01-16 Thread Langyan Ye
KINGDISPLAY KD110N11-51IE and STARRY 2082109QFH040022-50E are 10.95" WUXGA TFT LCD panel, which fits in nicely with the existing panel-boe-tv101wum-nl6 driver. Hence, we add a new compatible with panel specific config. Changes in v1: - PATCH 1/2: support for kingdisplay-kd110n11-51ie MIPI-DSI pan

Re: [git pull] drm fixes for 6.13-rc8

2025-01-16 Thread pr-tracker-bot
The pull request you sent on Fri, 17 Jan 2025 12:55:50 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2025-01-17 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/9bffa1ad25b8b3b95d8f463e5c24dabe3c87d54d Thank you! -- Deet-doot-dot, I am a bot. h

Re: [PATCH v4 2/5] drm: adp: Add Apple Display Pipe driver

2025-01-16 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 05:01:03PM +0100, Maxime Ripard wrote: > Hi Dmitry, > > On Wed, Jan 15, 2025 at 12:21:39PM +0200, Dmitry Baryshkov wrote: > > On Tue, Jan 14, 2025 at 10:38:53PM +0100, Sasha Finkelstein via B4 Relay > > wrote: > > > +static int adp_dsi_host_attach(struct mipi_dsi_host *hos

Re: [PATCH v4 14/16] drm/msm/dpu: support SSPP assignment for quad-pipe case

2025-01-16 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 10:22:07PM +0800, Jun Nie wrote: > Dmitry Baryshkov 于2025年1月16日周四 16:18写道: > > > > On Thu, Jan 16, 2025 at 03:26:03PM +0800, Jun Nie wrote: > > > Support SSPP assignment for quad-pipe case with unified method. > > > The first 2 pipes can share a set of mixer config and enab

Re: [PATCH v4 10/16] drm/msm/dpu: handle pipes as array

2025-01-16 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 11:36:21PM +0800, Jun Nie wrote: > Dmitry Baryshkov 于2025年1月16日周四 18:08写道: > > > > On Thu, Jan 16, 2025 at 05:49:43PM +0800, Jun Nie wrote: > > > Dmitry Baryshkov 于2025年1月16日周四 16:00写道: > > > > > > > > On Thu, Jan 16, 2025 at 03:25:59PM +0800, Jun Nie wrote: > > > > > Stor

[git pull] drm fixes for 6.13-rc8

2025-01-16 Thread Dave Airlie
Hi Linus, Final(?) set of fixes for 6.13, I think the holidays finally caught up with everyone, the misc changes are 2 weeks worth, otherwise amdgpu and xe are most of it. The largest pieces is a new test so I'm not too worried about that. I'll follow this up hopefully with the main merge window M

Re: [PATCH v4 01/16] drm/msm/dpu: check every pipe per capability

2025-01-16 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 10:38:33PM +0800, Jun Nie wrote: > Dmitry Baryshkov 于2025年1月16日周四 15:44写道: > > > > > On Thu, Jan 16, 2025 at 03:25:50PM +0800, Jun Nie wrote: > > > Move requreiment check to routine of every pipe check. As sblk > > > and pipe_hw_caps of r_pipe are not checked in current im

Re: [RFC PATCH 08/12] vfio/pci: Create host unaccessible dma-buf for private device

2025-01-16 Thread Baolu Lu
On 1/15/25 21:01, Jason Gunthorpe wrote: On Wed, Jan 15, 2025 at 11:57:05PM +1100, Alexey Kardashevskiy wrote: On 15/1/25 00:35, Jason Gunthorpe wrote: On Tue, Jun 18, 2024 at 07:28:43AM +0800, Xu Yilun wrote: is needed so the secure world can prepare anything it needs prior to starting the V

[PATCH v2] drm/panel-edp: Add BOE NV140FHM-NZ panel entry

2025-01-16 Thread Andy Yan
Add an eDP panel entry for BOE NV140FHM-NZ. No datasheet found for this panel, so the timing is based on a similar NV140FHM-N41 datasheet that I can find on internet[0]. edid: 00 ff ff ff ff ff ff 00 09 e5 09 0b 00 00 00 00 01 20 01 04 a5 1f 11 78 03 9b 75 99 5b 5d 8f 2a 23 50 54 00 00 00 01 01 0

Re: [PATCH v2] drm/i915/slpc: Add sysfs for SLPC power profiles

2025-01-16 Thread Belgaumkar, Vinay
On 1/16/2025 2:57 PM, Rodrigo Vivi wrote: On Fri, Jan 10, 2025 at 03:21:51PM -0800, Vinay Belgaumkar wrote: Default SLPC power profile is Base(0). Power Saving mode(1) has conservative up/down thresholds and is suitable for use with apps that typically need to be power efficient. Selected pow

Re: [V7 33/45] drm/colorop: Add 1D Curve Custom LUT type

2025-01-16 Thread Alex Hung
On 1/15/25 01:14, Simon Ser wrote: diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c index a3e1fcad47ad..4744c12e429d 100644 --- a/drivers/gpu/drm/drm_atomic_uapi.c +++ b/drivers/gpu/drm/drm_atomic_uapi.c @@ -701,6 +701,9 @@ static int drm_atomic_color_set_dat

Re: [PATCH v2] drm/i915/slpc: Add sysfs for SLPC power profiles

2025-01-16 Thread Rodrigo Vivi
On Fri, Jan 10, 2025 at 03:21:51PM -0800, Vinay Belgaumkar wrote: > Default SLPC power profile is Base(0). Power Saving mode(1) > has conservative up/down thresholds and is suitable for use with > apps that typically need to be power efficient. > > Selected power profile will be displayed in this

Re: [PATCH] drm/edid: add CTA Video Format Data Block support

2025-01-16 Thread Hamza Mahfooz
On Thu, Jan 16, 2025 at 09:13:18AM -0500, Alex Deucher wrote: > On Tue, Nov 5, 2024 at 9:14 PM Hamza Mahfooz wrote: > > > > Video Format Data Blocks (VFDBs) contain the necessary information that > > needs to be fed to the Optimized Video Timings (OVT) Algorithm. > > Also, we require OVT support t

Re: [PATCH RFC 1/4] drm/msm/adreno: Add speedbin support for X1-85

2025-01-16 Thread Konrad Dybcio
On 15.01.2025 8:59 PM, Dmitry Baryshkov wrote: > On Thu, Jan 16, 2025 at 01:07:17AM +0530, Akhil P Oommen wrote: >> On 1/9/2025 7:27 PM, Konrad Dybcio wrote: >>> On 8.01.2025 11:42 PM, Akhil P Oommen wrote: Adreno X1-85 has an additional bit which is at a non-contiguous location in qfprom

[PULL] drm-xe-fixes

2025-01-16 Thread Thomas Hellstrom
Hi Dave, Simona! The hopefully last drm-xe-fixes for 6.13 It's a little bigger than I was hoping for but nothing that really stands out. Thanks, Thomas drm-xe-fixes-2025-01-16: Driver Changes: - Add steering info support for GuC register lists (Jesus Narvaez) - Add means to wait for reset and sy

Re: [PATCH next] cgroup/rdma: Drop bogus PAGE_COUNTER select

2025-01-16 Thread Tejun Heo
On Thu, Jan 16, 2025 at 10:56:35AM +0100, Geert Uytterhoeven wrote: > When adding the Device memory controller (DMEM), "select PAGE_COUNTER" > was added to CGROUP_RDMA, presumably instead of CGROUP_DMEM. > While commit e33b51499a0a6bca ("cgroup/dmem: Select PAGE_COUNTER") added > the missing select

Re: [PATCH 1/2] MAINTAINERS: Update DRM GPU Scheduler section

2025-01-16 Thread Dave Airlie
On Mon, 13 Jan 2025 at 22:19, Philipp Stanner wrote: > > Luben has not been active and has not responded to mails since summer > 2024. Remove him from MAINTAINERS and add an entry in CREDITS. > > Philipp has a new email address and an ACK to commit work time to the > scheduler. Thus, set the state

Re: [PATCH v4 2/5] drm: adp: Add Apple Display Pipe driver

2025-01-16 Thread Sasha Finkelstein
On Wed, 15 Jan 2025 at 11:21, Dmitry Baryshkov wrote: > > + ret = drm_simple_encoder_init(drm, &adp->encoder, > > DRM_MODE_ENCODER_DSI); > > This is being deprecated, please use drm_encoder_init() / > drmm_encoder_init() instead. I seem to be unable to find any documentation or a mailing lis

Re: [PATCH] drm/i915/uc: Include requested frequency in slow firmware load messages

2025-01-16 Thread John Harrison
On 1/16/2025 03:52, Krzysztof Karas wrote: Hi John, From: John Harrison To aid debug of sporadic issues, include the requested frequency in the debug message as well as the actual frequency. That way we know for certain that the clamping is not because the driver forgot to ask. ...

[PATCH v9 7/8] drm: writeback: Create drmm variants for drm_writeback_connector initialization

2025-01-16 Thread Louis Chauvet
To allows driver to only use drmm objects, add helper to create drm_writeback_connectors with automated lifetime management. Acked-by: Thomas Zimmermann Acked-by: Maxime Ripard Signed-off-by: Louis Chauvet --- drivers/gpu/drm/drm_writeback.c | 74 + incl

[PATCH v9 6/8] drm: writeback: Add missing cleanup in case of initialization failure

2025-01-16 Thread Louis Chauvet
The current implementation of drm_writeback_connector initialization does not properly clean up all resources in case of failure (allocated properties and possible_encoders). Add this cleaning in case of failure. Acked-by: Thomas Zimmermann Signed-off-by: Louis Chauvet --- drivers/gpu/drm/drm_w

[PATCH v9 4/8] drm/vkms: Switch to managed for crtc

2025-01-16 Thread Louis Chauvet
The current VKMS driver uses managed function to create crtc, but don't use it to properly clean the crtc workqueue. It is not an issue yet, but in order to support multiple devices easily, convert this code to use drm and device managed helpers. Acked-by: Maxime Ripard Reviewed-by: José Expósito

[PATCH v9 5/8] drm: writeback: Create an helper for drm_writeback_connector initialization

2025-01-16 Thread Louis Chauvet
As the old drm and the new drmm variants of drm_writeback_connector requires almost the same initialization, create an internal helper to do most of the initialization work. Currently there is no cleanup function for writeback connectors. To allows implementation of drmm variant of writeback conne

[PATCH v9 3/8] drm/managed: Add DRM-managed alloc_ordered_workqueue

2025-01-16 Thread Louis Chauvet
Add drmm_alloc_ordered_workqueue(), a helper that provides managed ordered workqueue cleanup. The workqueue will be destroyed with the final reference of the DRM device. Reviewed-by: Thomas Zimmermann Signed-off-by: Louis Chauvet --- drivers/gpu/drm/drm_managed.c | 8 include/drm/drm_

[PATCH v9 8/8] drm/vkms: Switch to managed for writeback connector

2025-01-16 Thread Louis Chauvet
The current VKMS driver uses non-managed function to create writeback connectors. It is not an issue yet, but in order to support multiple devices easily, convert this code to use drm and device managed helpers. Acked-by: Thomas Zimmermann Acked-by: Maxime Ripard Reviewed-by: José Expósito Sign

[PATCH v9 2/8] drm/vkms: Switch to managed for encoder

2025-01-16 Thread Louis Chauvet
The current VKMS driver uses non-managed function to create encoders. It is not an issue yet, but in order to support multiple devices easily, convert this code to use drm and device managed helpers. Reviewed-by: Maxime Ripard Reviewed-by: Maíra Canal Reviewed-by: Thomas Zimmermann Reviewed-by:

[PATCH v9 1/8] drm/vkms: Switch to managed for connector

2025-01-16 Thread Louis Chauvet
The current VKMS driver uses non-managed function to create connectors. It is not an issue yet, but in order to support multiple devices easily, convert this code to use drm and device managed helpers. Reviewed-by: Maxime Ripard Reviewed-by: Maíra Canal Reviewed-by: Thomas Zimmermann Reviewed-b

[PATCH v9 0/8] drm/vkms: Switch all vkms object to DRM managed objects

2025-01-16 Thread Louis Chauvet
To simplify the memory managment, this series replace all manual drm object managment by drm-managed one. This way the VKMS code don't have to manage it directly and the DRM core will handle the object destruction. No functional changes are intended in this series. PATCH 1/8: Migrate connector ma

[PATCH] drm/mediatek: dp: drm_err => dev_err in HPD path to avoid NULL ptr

2025-01-16 Thread Douglas Anderson
The function mtk_dp_wait_hpd_asserted() may be called before the `mtk_dp->drm_dev` pointer is assigned in mtk_dp_bridge_attach(). Specifically it can be called via this callpath: - mtk_edp_wait_hpd_asserted - [panel probe] - dp_aux_ep_probe Using "drm" level prints anywhere in this callpath cau

[PATCH] drm: document DRM_MODE_PAGE_FLIP_EVENT interactions with atomic

2025-01-16 Thread Simon Ser
It's not obvious off-hand which CRTCs will get a page-flip event when using this flag in an atomic commit, because it's all implicitly implied based on the contents of the atomic commit. Document requirements for using this flag and Note, because prepare_signaling() runs right after drm_atomic_set

Re: [PATCH] drm/edid: add CTA Video Format Data Block support

2025-01-16 Thread Jani Nikula
On Thu, 16 Jan 2025, Alex Deucher wrote: > On Tue, Nov 5, 2024 at 9:14 PM Hamza Mahfooz wrote: >> >> Video Format Data Blocks (VFDBs) contain the necessary information that >> needs to be fed to the Optimized Video Timings (OVT) Algorithm. >> Also, we require OVT support to cover modes that aren'

Re: [RFC PATCH 01/12] dma-buf: Introduce dma_buf_get_pfn_unlocked() kAPI

2025-01-16 Thread Jason Gunthorpe
On Thu, Jan 16, 2025 at 04:13:13PM +0100, Christian König wrote: >> But this, fundamentally, is importers creating attachments and then >> *ignoring the lifetime rules of DMABUF*. If you created an attachment, >> got a move and *ignored the move* because you put the PFN in your own >> VMA, then you

[PATCH v8 1/8] drm/vkms: Switch to managed for connector

2025-01-16 Thread José Expósito
> The current VKMS driver uses non-managed function to create connectors. It > is not an issue yet, but in order to support multiple devices easily, > convert this code to use drm and device managed helpers. > > Reviewed-by: Maxime Ripard > Reviewed-by: Maíra Canal > Reviewed-by: Thomas Zimmerma

Re: [PATCH] drm/sched: Remove job submit/free race when using unordered workqueues

2025-01-16 Thread Tvrtko Ursulin
On 10/01/2025 11:14, Tvrtko Ursulin wrote: After commit f7fe64ad0f22 ("drm/sched: Split free_job into own work item") and with drivers who use the unordered workqueue sched_jobs can be freed in parallel as soon as the complete_all(&entity->entity_idle) is called. This makes all dereferencing in

Re: [PATCH v4 2/5] drm: adp: Add Apple Display Pipe driver

2025-01-16 Thread Maxime Ripard
Hi Dmitry, On Wed, Jan 15, 2025 at 12:21:39PM +0200, Dmitry Baryshkov wrote: > On Tue, Jan 14, 2025 at 10:38:53PM +0100, Sasha Finkelstein via B4 Relay > wrote: > > +static int adp_dsi_host_attach(struct mipi_dsi_host *host, > > + struct mipi_dsi_device *dev) > > +{ > > +

[PATCH v8 8/8] drm/vkms: Switch to managed for writeback connector

2025-01-16 Thread José Expósito
> The current VKMS driver uses non-managed function to create > writeback connectors. It is not an issue yet, but in order > to support multiple devices easily, convert this code to > use drm and device managed helpers. > > Acked-by: Thomas Zimmermann > Signed-off-by: Louis Chauvet > Acked-by: M

[PATCH v8 4/8] drm/vkms: Switch to managed for crtc

2025-01-16 Thread José Expósito
> The current VKMS driver uses managed function to create crtc, but > don't use it to properly clean the crtc workqueue. It is not an > issue yet, but in order to support multiple devices easily, > convert this code to use drm and device managed helpers. > > Signed-off-by: Louis Chauvet > Acked-b

[PATCH v8 2/8] drm/vkms: Switch to managed for encoder

2025-01-16 Thread José Expósito
> The current VKMS driver uses non-managed function to create encoders. It > is not an issue yet, but in order to support multiple devices easily, > convert this code to use drm and device managed helpers. > > Reviewed-by: Maxime Ripard > Reviewed-by: Maíra Canal > Reviewed-by: Thomas Zimmermann

Re: [PATCH v7 7/7] drm/vkms: Switch to managed for writeback connector

2025-01-16 Thread José Expósito
On Mon, Jan 13, 2025 at 06:12:03PM +0100, Louis Chauvet wrote: > On 13/01/25 - 18:09, Louis Chauvet wrote: > > The current VKMS driver uses non-managed function to create > > writeback connectors. It is not an issue yet, but in order > > to support multiple devices easily, convert this code to > >

[PATCH v2] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Brian Geffon
When converting to folios the cleanup path of shmem_get_pages() was missed. When a DMA remap fails and the max segment size is greater than PAGE_SIZE it will attempt to retry the remap with a PAGE_SIZEd segment size. The cleanup code isn't properly using the folio apis and as a result isn't handlin

Re: [PATCH v4 10/16] drm/msm/dpu: handle pipes as array

2025-01-16 Thread Jun Nie
Dmitry Baryshkov 于2025年1月16日周四 18:08写道: > > On Thu, Jan 16, 2025 at 05:49:43PM +0800, Jun Nie wrote: > > Dmitry Baryshkov 于2025年1月16日周四 16:00写道: > > > > > > On Thu, Jan 16, 2025 at 03:25:59PM +0800, Jun Nie wrote: > > > > Store pipes in array with removing dedicated r_pipe. There are > > > > 2 pi

Re: [RFC PATCH] driver: dma-buf: use vmf_insert_page for cma_heap_vm_fault

2025-01-16 Thread Christian König
Am 16.01.25 um 02:46 schrieb Zhaoyang Huang: On Wed, Jan 15, 2025 at 7:49 PM Christian König wrote: Am 15.01.25 um 07:18 schrieb zhaoyang.huang: From: Zhaoyang Huang When using dma-buf as memory pool for VMM. The vmf_insert_pfn will apply PTE_SPECIAL on pte which have vm_normal_page report b

Re: [PATCH] drm/amd/display: mark static functions noinline_for_stack

2025-01-16 Thread Alex Deucher
On Thu, Jan 16, 2025 at 9:47 AM Nathan Chancellor wrote: > > Hi Tzung-Bi, > > First of all, thanks for the patch! > > On Thu, Jan 09, 2025 at 05:35:04AM +, Tzung-Bi Shih wrote: > > When compiling allmodconfig (CONFIG_WERROR=y) with clang-19, see the > > following errors: > > > > .../display/dc

Re: [RFC PATCH 01/12] dma-buf: Introduce dma_buf_get_pfn_unlocked() kAPI

2025-01-16 Thread Christian König
Am 15.01.25 um 18:09 schrieb Jason Gunthorpe: On Wed, Jan 15, 2025 at 05:34:23PM +0100, Christian König wrote: Granted, let me try to improve this. Here is a real world example of one of the issues we ran into and why CPU mappings of importers are redirected to the exporter. We h

Re: [PATCH] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Ville Syrjälä
On Thu, Jan 16, 2025 at 04:24:26PM +0200, Ville Syrjälä wrote: > On Thu, Jan 16, 2025 at 08:56:36AM -0500, Brian Geffon wrote: > > When converting to folios the cleanup path of shmem_get_pages() was > > missed. When a DMA remap fails and the max segment size is greater than > > PAGE_SIZE it will at

Re: [PATCH 2/3] drm/panfrost: Add support for Mali on the MT8370 SoC

2025-01-16 Thread Steven Price
On 16/01/2025 14:25, Louis-Alexis Eyraud wrote: > This commit adds a compatible for the MediaTek MT8370 SoC, with an > integrated ARM Mali G57 MC2 GPU (Valhall-JM, dual core), and adds > platform data using the same supplies and the same power domain lists > as MT8186 (one regulator, two power doma

Re: [PATCH] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Brian Geffon
On Thu, Jan 16, 2025 at 9:38 AM Ville Syrjälä wrote: > > On Thu, Jan 16, 2025 at 04:24:26PM +0200, Ville Syrjälä wrote: > > On Thu, Jan 16, 2025 at 08:56:36AM -0500, Brian Geffon wrote: > > > When converting to folios the cleanup path of shmem_get_pages() was > > > missed. When a DMA remap fails a

Re: [PATCH] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Brian Geffon
On Thu, Jan 16, 2025 at 9:24 AM Ville Syrjälä wrote: > > On Thu, Jan 16, 2025 at 08:56:36AM -0500, Brian Geffon wrote: > > When converting to folios the cleanup path of shmem_get_pages() was > > missed. When a DMA remap fails and the max segment size is greater than > > PAGE_SIZE it will attempt t

Re: [PATCH] drm/amd/display: mark static functions noinline_for_stack

2025-01-16 Thread Nathan Chancellor
Hi Tzung-Bi, First of all, thanks for the patch! On Thu, Jan 09, 2025 at 05:35:04AM +, Tzung-Bi Shih wrote: > When compiling allmodconfig (CONFIG_WERROR=y) with clang-19, see the > following errors: > > .../display/dc/dml2/display_mode_core.c:6268:13: warning: stack frame size > (3128) exce

Re: [PATCH] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Ville Syrjälä
On Thu, Jan 16, 2025 at 09:36:42AM -0500, Brian Geffon wrote: > On Thu, Jan 16, 2025 at 9:24 AM Ville Syrjälä > wrote: > > > > On Thu, Jan 16, 2025 at 08:56:36AM -0500, Brian Geffon wrote: > > > When converting to folios the cleanup path of shmem_get_pages() was > > > missed. When a DMA remap fail

Re: [PATCH v4 01/16] drm/msm/dpu: check every pipe per capability

2025-01-16 Thread Jun Nie
Dmitry Baryshkov 于2025年1月16日周四 15:44写道: > > On Thu, Jan 16, 2025 at 03:25:50PM +0800, Jun Nie wrote: > > Move requreiment check to routine of every pipe check. As sblk > > and pipe_hw_caps of r_pipe are not checked in current implementation. > How about this version? The capability stored in

Re: [PATCH] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Ville Syrjälä
On Thu, Jan 16, 2025 at 04:24:26PM +0200, Ville Syrjälä wrote: > On Thu, Jan 16, 2025 at 08:56:36AM -0500, Brian Geffon wrote: > > When converting to folios the cleanup path of shmem_get_pages() was > > missed. When a DMA remap fails and the max segment size is greater than > > PAGE_SIZE it will at

Re: [PATCH] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Brian Geffon
On Thu, Jan 16, 2025 at 9:24 AM Ville Syrjälä wrote: > > On Thu, Jan 16, 2025 at 08:56:36AM -0500, Brian Geffon wrote: > > When converting to folios the cleanup path of shmem_get_pages() was > > missed. When a DMA remap fails and the max segment size is greater than > > PAGE_SIZE it will attempt t

Re: AAARRRGGGHHH!!!! (was Re: [PATCH 6.12.y] xe/oa: Fix query mode of operation for OAR/OAC)

2025-01-16 Thread Simona Vetter
On Thu, Jan 16, 2025 at 02:52:23PM +0100, Greg KH wrote: > On Thu, Jan 16, 2025 at 10:48:45AM +0100, Simona Vetter wrote: > > Maybe also helps to go back from examples to the generic algorithm, which > > is two steps: > > > > 1. You first need to find the root sha1 that all the cherry picks > > or

[PATCH 1/2] drm/modeset: Handle tiled displays in pan_display_atomic.

2025-01-16 Thread Maarten Lankhorst
Tiled displays have a different x/y offset to begin with. Instead of attempting to remember this, just apply a delta instead. Hope this works.. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_fb_helper.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a

[PATCH 2/2] drm/client: Handle tiled displays better

2025-01-16 Thread Maarten Lankhorst
When testing on my tiled display, initially the tiled display is detected correctly: [90376.523692] xe :67:00.0: [drm:drm_client_firmware_config.isra.0 [drm]] fallback: Not all outputs enabled [90376.523713] xe :67:00.0: [drm:drm_client_firmware_config.isra.0 [drm]] Enabled: 0, detected:

[PATCH 3/3] arm64: dts: mediatek: mt8370: Enable gpu support

2025-01-16 Thread Louis-Alexis Eyraud
This commits adds a gpu node in mt8370.dtsi to enable support for the ARM Mali G57 MC2 GPU (Valhall-JM) found on the MT8370 SoC, using the Panfrost driver. On a Mediatek Genio 510 EVK board, the panfrost driver probed with the following message: ``` panfrost 1300.gpu: clock rate = 39000 pa

[PATCH 2/3] drm/panfrost: Add support for Mali on the MT8370 SoC

2025-01-16 Thread Louis-Alexis Eyraud
This commit adds a compatible for the MediaTek MT8370 SoC, with an integrated ARM Mali G57 MC2 GPU (Valhall-JM, dual core), and adds platform data using the same supplies and the same power domain lists as MT8186 (one regulator, two power domains). Signed-off-by: Louis-Alexis Eyraud --- drivers/

[PATCH 0/3] Add Mali GPU support for Mediatek MT8370 SoC

2025-01-16 Thread Louis-Alexis Eyraud
This patchset adds the support of the ARM Mali G57 MC2 GPU (Valhall-JM, dual core), integrated in the Mediatek MT8370 SoC, to the panfrost driver and to the mt8370.dtsi include file. I've testing this patchset on a Mediatek Genio 510 EVK board, with a kernel based on linux-next (tag: next-20250113

[PATCH 1/3] dt-bindings: gpu: mali-bifrost: Add compatible for MT8370 SoC

2025-01-16 Thread Louis-Alexis Eyraud
This commit adds a compatible for the MediaTek MT8370 SoC, with an integrated ARM Mali G57 MC2 GPU (Valhall-JM, dual core). Signed-off-by: Louis-Alexis Eyraud --- Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/D

Re: [PATCH] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Ville Syrjälä
On Thu, Jan 16, 2025 at 08:56:36AM -0500, Brian Geffon wrote: > When converting to folios the cleanup path of shmem_get_pages() was > missed. When a DMA remap fails and the max segment size is greater than > PAGE_SIZE it will attempt to retry the remap with a PAGE_SIZEd segment > size. The cleanup

Re: [PATCH v4 14/16] drm/msm/dpu: support SSPP assignment for quad-pipe case

2025-01-16 Thread Jun Nie
Dmitry Baryshkov 于2025年1月16日周四 16:18写道: > > On Thu, Jan 16, 2025 at 03:26:03PM +0800, Jun Nie wrote: > > Support SSPP assignment for quad-pipe case with unified method. > > The first 2 pipes can share a set of mixer config and enable > > multi-rect mode if condition is met. It is also the case for

Re: [PATCH] drm/edid: add CTA Video Format Data Block support

2025-01-16 Thread Alex Deucher
On Tue, Nov 5, 2024 at 9:14 PM Hamza Mahfooz wrote: > > Video Format Data Blocks (VFDBs) contain the necessary information that > needs to be fed to the Optimized Video Timings (OVT) Algorithm. > Also, we require OVT support to cover modes that aren't supported by > earlier standards (e.g. CVT). S

Re: [PATCH v1 0/2] support for kingdisplay-kd110n11-51ie and starry-2082109qfh040022-50e MIPI-DSI panels

2025-01-16 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 09:05:30PM +0800, Langyan Ye wrote: > The kingdisplay-kd110n11-51ie and starry-2082109qfh040022-50e are both 10.95" > TFT panels. > which fits in nicely with the existing panel-boe-tv101wum-nl6 driver.From the > datasheet, > MIPI needs to keep the LP11 state before the lcm

[PATCH] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Brian Geffon
When converting to folios the cleanup path of shmem_get_pages() was missed. When a DMA remap fails and the max segment size is greater than PAGE_SIZE it will attempt to retry the remap with a PAGE_SIZEd segment size. The cleanup code isn't properly using the folio apis and as a result isn't handlin

Re: AAARRRGGGHHH!!!! (was Re: [PATCH 6.12.y] xe/oa: Fix query mode of operation for OAR/OAC)

2025-01-16 Thread Greg KH
On Thu, Jan 16, 2025 at 10:48:45AM +0100, Simona Vetter wrote: > On Wed, Jan 15, 2025 at 08:02:01PM +0100, Simona Vetter wrote: > > On Wed, Jan 15, 2025 at 12:18:13PM -0500, Sasha Levin wrote: > > > On Wed, Jan 15, 2025 at 12:15:46PM +0100, Simona Vetter wrote: > > > > On Wed, Jan 15, 2025 at 10:38

Re: [PATCH v1 1/2] drm/panel: boe-tv101wum-nl6: support for kingdisplay-kd110n11-51ie MIPI-DSI panel

2025-01-16 Thread neil . armstrong
On 16/01/2025 14:06, Langyan Ye wrote: The kingdisplay-kd110n11-51ie is a 10.95" TFT panel. which fits in nicely with the existing panel-boe-tv101wum-nl6 driver. From the datasheet, MIPI needs to keep the LP11 state before the lcm_reset pin is pulled high, so increase lp11_before_reset flag. Si

[PATCH] drm/repaper: fix integer overflows in repeat functions

2025-01-16 Thread Nikita Zhandarovich
There are conditions, albeit somewhat unlikely, under which right hand expressions, calculating the end of time period in functions like repaper_frame_fixed_repeat(), may overflow. For instance, if 'factor10x' in repaper_get_temperature() is high enough (170), as is 'epd->stage_time' in repaper_pr

Re: [PATCH v1 2/2] drm/panel: boe-tv101wum-nl6: support for starry-2082109qfh040022-50e MIPI-DSI panel

2025-01-16 Thread neil . armstrong
On 16/01/2025 14:06, Langyan Ye wrote: The starry-2082109qfh040022-50e is a 10.95" TFT panel. which fits in nicely with the existing panel-boe-tv101wum-nl6 driver. From the datasheet, MIPI needs to keep the LP11 state before the lcm_reset pin is pulled high, so increase lp11_before_reset flag.

Re: [PATCH v7 01/14] drm: Define histogram structures exposed to user

2025-01-16 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 01:33:43PM +, Murthy, Arun R wrote: > > On Thu, Jan 16, 2025 at 12:33:20PM +, Murthy, Arun R wrote: > > > > > > On Fri, Jan 10, 2025 at 01:15:29AM +0530, Arun R Murthy wrote: > > > > > > > Display Histogram is an array of bins and can be generated in > > > > > > > ma

RE: [PATCH v7 01/14] drm: Define histogram structures exposed to user

2025-01-16 Thread Murthy, Arun R
> On Thu, Jan 16, 2025 at 12:33:20PM +, Murthy, Arun R wrote: > > > > > On Fri, Jan 10, 2025 at 01:15:29AM +0530, Arun R Murthy wrote: > > > > > > Display Histogram is an array of bins and can be generated in > > > > > > many ways referred to as modes. > > > > > > Ex: HSV max(RGB), Wighted RGB

RE: [PATCH v7 02/14] drm: Define ImageEnhancemenT LUT structures exposed to user

2025-01-16 Thread Murthy, Arun R
> On Thu, Jan 16, 2025 at 12:33:30PM +, Murthy, Arun R wrote: > > > > > On Fri, Jan 10, 2025 at 01:15:30AM +0530, Arun R Murthy wrote: > > > > > > ImageEnhancemenT(IET) hardware interpolates the LUT value to > > > > > > generate the enhanced output image. LUT takes an input value, > > > > > > o

Re: [RFC PATCH 01/12] dma-buf: Introduce dma_buf_get_pfn_unlocked() kAPI

2025-01-16 Thread Jason Gunthorpe
On Thu, Jan 16, 2025 at 06:33:48AM +0100, Christoph Hellwig wrote: > On Wed, Jan 15, 2025 at 09:34:19AM -0400, Jason Gunthorpe wrote: > > > Or do you mean some that don't have pages associated with them, and > > > thus have pfn_valid fail on them? They still have a PFN, just not > > > one that is

Re: [PATCH v7 01/14] drm: Define histogram structures exposed to user

2025-01-16 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 12:33:20PM +, Murthy, Arun R wrote: > > > > On Fri, Jan 10, 2025 at 01:15:29AM +0530, Arun R Murthy wrote: > > > > > Display Histogram is an array of bins and can be generated in many > > > > > ways referred to as modes. > > > > > Ex: HSV max(RGB), Wighted RGB etc. > > >

Re: [PATCH v7 02/14] drm: Define ImageEnhancemenT LUT structures exposed to user

2025-01-16 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 12:33:30PM +, Murthy, Arun R wrote: > > > > On Fri, Jan 10, 2025 at 01:15:30AM +0530, Arun R Murthy wrote: > > > > > ImageEnhancemenT(IET) hardware interpolates the LUT value to > > > > > generate the enhanced output image. LUT takes an input value, > > > > > outputs a n

[PATCH v1 1/2] drm/panel: boe-tv101wum-nl6: support for kingdisplay-kd110n11-51ie MIPI-DSI panel

2025-01-16 Thread Langyan Ye
The kingdisplay-kd110n11-51ie is a 10.95" TFT panel. which fits in nicely with the existing panel-boe-tv101wum-nl6 driver. >From the datasheet, MIPI needs to keep the LP11 state before the lcm_reset pin is pulled high, so increase lp11_before_reset flag. Signed-off-by: Langyan Ye --- .../gpu/drm

[PATCH v1 0/2] support for kingdisplay-kd110n11-51ie and starry-2082109qfh040022-50e MIPI-DSI panels

2025-01-16 Thread Langyan Ye
The kingdisplay-kd110n11-51ie and starry-2082109qfh040022-50e are both 10.95" TFT panels. which fits in nicely with the existing panel-boe-tv101wum-nl6 driver.From the datasheet, MIPI needs to keep the LP11 state before the lcm_reset pin is pulled high, so increase lp11_before_reset flag. Langy

[PATCH v1 2/2] drm/panel: boe-tv101wum-nl6: support for starry-2082109qfh040022-50e MIPI-DSI panel

2025-01-16 Thread Langyan Ye
The starry-2082109qfh040022-50e is a 10.95" TFT panel. which fits in nicely with the existing panel-boe-tv101wum-nl6 driver. >From the datasheet, MIPI needs to keep the LP11 state before the lcm_reset pin is pulled high, so increase lp11_before_reset flag. Signed-off-by: Langyan Ye --- .../gpu/d

Re: [PATCH 2/2] drm/imagination: Use the drm_sched_job_has_dependency helper

2025-01-16 Thread Matt Coster
On 16/01/2025 10:02, Philipp Stanner wrote: > On Mon, 2025-01-13 at 10:33 +, Tvrtko Ursulin wrote: >> Instead of manually peeking into the DRM scheduler implementation >> details >> lets use the previously added helper. >> >> Signed-off-by: Tvrtko Ursulin >> Cc: Christian König >> Cc: Danilo

[PATCH v2] drm/sched: Avoid double re-lock on the job free path

2025-01-16 Thread Tvrtko Ursulin
Currently the job free work item will lock sched->job_list_lock first time to see if there are any jobs, free a single job, and then lock again to decide whether to re-queue itself if there are more finished jobs. Since drm_sched_get_finished_job() already looks at the second job in the queue we c

RE: [PATCH v7 02/14] drm: Define ImageEnhancemenT LUT structures exposed to user

2025-01-16 Thread Murthy, Arun R
> > > On Fri, Jan 10, 2025 at 01:15:30AM +0530, Arun R Murthy wrote: > > > > ImageEnhancemenT(IET) hardware interpolates the LUT value to > > > > generate the enhanced output image. LUT takes an input value, > > > > outputs a new value based on the data within the LUT. 1D LUT can > > > > remap indi

RE: [PATCH v7 01/14] drm: Define histogram structures exposed to user

2025-01-16 Thread Murthy, Arun R
> > > On Fri, Jan 10, 2025 at 01:15:29AM +0530, Arun R Murthy wrote: > > > > Display Histogram is an array of bins and can be generated in many > > > > ways referred to as modes. > > > > Ex: HSV max(RGB), Wighted RGB etc. > > > > > > > > Understanding the histogram data format(Ex: HSV max(RGB)) > >

Re: [PATCH v5 08/10] drm/bridge: samsung-dsim: use supporting variable for out_bridge

2025-01-16 Thread Maxime Ripard
Hi Luca, On Thu, Jan 16, 2025 at 11:32:36AM +0100, Luca Ceresoli wrote: > Hello Dmitry, Maxime, All, > > On Fri, 10 Jan 2025 11:58:19 +0100 > Luca Ceresoli wrote: > > > Hi Dmitry, > > > > On Thu, 2 Jan 2025 13:01:49 +0100 > > Luca Ceresoli wrote: > > > > > > > diff --git a/drivers/gpu/drm/br

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-16 Thread Daniel Stone
On Thu, 16 Jan 2025 at 10:35, Dmitry Baryshkov wrote: > On Thu, Jan 16, 2025 at 11:17:50AM +0100, Geert Uytterhoeven wrote: > > On Thu, Jan 16, 2025 at 11:03 AM Tomi Valkeinen > > wrote: > > > On the platforms I have been using (omap, tidss, xilinx, rcar) the dumb > > > buffers are the only buffe

Re: [PATCH] drm/i915/uc: Include requested frequency in slow firmware load messages

2025-01-16 Thread Krzysztof Karas
Hi John, > From: John Harrison > > To aid debug of sporadic issues, include the requested frequency in > the debug message as well as the actual frequency. That way we know > for certain that the clamping is not because the driver forgot to ask. > ... > } else if (delta_ms > 200) { >

Re: linux-next: build warnings after merge of the drm-misc tree

2025-01-16 Thread Maxime Ripard
On Thu, Jan 16, 2025 at 12:34:39PM +0200, Tomi Valkeinen wrote: > Hi drm maintainers, > > On 14/01/2025 07:41, Stephen Rothwell wrote: > > Hi all, > > > > On Fri, 20 Dec 2024 15:42:08 +1100 Stephen Rothwell > > wrote: > > > > > > After merging the drm-misc tree, today's linux-next build (htmld

  1   2   >