Re: [PATCH V1 1/7] accel/amdxdna: Declare npu device profile as static variables

2025-01-03 Thread Mario Limonciello
Hi, Thanks for the patches. For the series: Reviewed-by: Mario Limonciello I've committed them to drm-misc-next as well: fee7aaee11f52 accel/amdxdna: Declare npu6_dev_priv as static 3b5bcf64a65b3 accel/amdxdna: Add __user to second parameter of aie2_query_status 72e487b47d249 accel/amdxdna

[Bug 209535] resume fails after hibernate amdgpu

2025-01-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209535 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED Reso

Re: [PATCH v3 4/4] drm/msm/dp: Add support for LTTPR handling

2025-01-03 Thread Dmitry Baryshkov
On Fri, Jan 03, 2025 at 02:58:18PM +0200, Abel Vesa wrote: > Link Training Tunable PHY Repeaters (LTTPRs) are defined in DisplayPort > 1.4a specification. As the name suggests, these PHY repeaters are > capable of adjusting their output for link training purposes. > > According to the DisplayPort

Re: [PATCH v4 0/2] Add Block event interrupt support for I2C protocol

2025-01-03 Thread Andi Shyti
Hi, this patch has been hanging here for a while, can we please have someone from DMA and Qualcomm look at it? Thanks, Andi On Tue, Dec 17, 2024 at 10:34:22PM +0530, Jyothi Kumar Seerapu wrote: > The I2C driver gets an interrupt upon transfer completion. > When handling multiple messages in a si

Re: [git pull] drm fixes for 6.13-rc6

2025-01-03 Thread pr-tracker-bot
The pull request you sent on Fri, 3 Jan 2025 12:09:54 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2025-01-03 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/92c3bb3d2e89ab35072248b08008c508f714f070 Thank you! -- Deet-doot-dot, I am a bot. ht

Re: [PATCH] drm/tests: helpers: Fix compile wrarning

2025-01-03 Thread Dmitry Baryshkov
On Sat, Jan 04, 2025 at 05:43:54AM +0800, Kuan-Wei Chiu wrote: > Hi Dmitry, > > On Fri, Jan 03, 2025 at 08:14:20PM +0200, Dmitry Baryshkov wrote: > > On Sat, Jan 04, 2025 at 12:17:58AM +0800, Yu-Chun Lin wrote: > > > Delete one line break to make the format correct, resolving the > > > following w

Re: [PATCH] drm/tests: helpers: Fix compile wrarning

2025-01-03 Thread Kuan-Wei Chiu
Hi Dmitry, On Fri, Jan 03, 2025 at 08:14:20PM +0200, Dmitry Baryshkov wrote: > On Sat, Jan 04, 2025 at 12:17:58AM +0800, Yu-Chun Lin wrote: > > Delete one line break to make the format correct, resolving the > > following warning during a W=1 build: > > > > >> drivers/gpu/drm/tests/drm_kunit_help

Re: [PATCH v3 15/15] drm/msm/dpu: Enable quad-pipe for DSC and dual-DSI case

2025-01-03 Thread Dmitry Baryshkov
On Fri, Jan 03, 2025 at 11:49:07PM +0800, Jun Nie wrote: > Dmitry Baryshkov 于2024年12月20日周五 07:46写道: > > > > On Thu, Dec 19, 2024 at 03:49:33PM +0800, Jun Nie wrote: > > > Request 4 mixers and 4 DSC for the case that both dual-DSI and DSC are > > > enabled. We prefer to use 4 pipes for dual DSI cas

Re: [PATCH v4 15/25] drm/msm/dpu: Add CWB to msm_display_topology

2025-01-03 Thread Dmitry Baryshkov
On Fri, Jan 03, 2025 at 10:03:35AM -0800, Jessica Zhang wrote: > > > On 12/19/2024 9:03 PM, Dmitry Baryshkov wrote: > > On Mon, Dec 16, 2024 at 04:43:26PM -0800, Jessica Zhang wrote: > > > Add the cwb_enabled flag to msm_display topology and adjust the toplogy > > > to account for concurrent writ

Re: [PATCH RESEND v7 00/10] drm/bridge: it6505: fix HDCP CTS fail items and add MCCS support

2025-01-03 Thread Dmitry Baryshkov
On Mon, 30 Dec 2024 18:51:18 +0800, Hermes Wu wrote: > There are lots of failure items while running HDCP CTS using UNIGRAF DPR-100. > In Order to fix those failures, HDCP flow needs to be changed. > > The DisplayPort AUX protocol supports I2C transport. > In Order to support MCCS via the aux chan

Re: [PATCH] drm/tests: helpers: Fix compile wrarning

2025-01-03 Thread Dmitry Baryshkov
On Sat, Jan 04, 2025 at 12:17:58AM +0800, Yu-Chun Lin wrote: > Delete one line break to make the format correct, resolving the > following warning during a W=1 build: > > >> drivers/gpu/drm/tests/drm_kunit_helpers.c:324: warning: bad line: for a > >> KUnit test > > Reported-by: kernel test robot

Re: [PATCH v3 3/4] drm/i915/dp: Use the generic helper to control LTTPR transparent mode

2025-01-03 Thread Dmitry Baryshkov
On Fri, Jan 03, 2025 at 02:58:17PM +0200, Abel Vesa wrote: > LTTPRs operating modes are defined by the DisplayPort standard and the > generic framework now provides a helper to switch between them, which > is handling the explicit disabling of non-transparent mode and its > disable->enable sequence

Re: [PATCH v3 1/4] drm/dp: Add helper to set LTTPRs in transparent mode

2025-01-03 Thread Dmitry Baryshkov
On Fri, Jan 03, 2025 at 02:58:15PM +0200, Abel Vesa wrote: > According to the DisplayPort standard, LTTPRs have two operating > modes: > - non-transparent - it replies to DPCD LTTPR field specific AUX >requests, while passes through all other AUX requests > - transparent - it passes through a

Re: [PATCH v4 15/25] drm/msm/dpu: Add CWB to msm_display_topology

2025-01-03 Thread Jessica Zhang
On 12/19/2024 9:03 PM, Dmitry Baryshkov wrote: On Mon, Dec 16, 2024 at 04:43:26PM -0800, Jessica Zhang wrote: Add the cwb_enabled flag to msm_display topology and adjust the toplogy to account for concurrent writeback Why? Hi Dmitry, This flag is necessary to specify that CWB mux(es) nee

Re: [PATCH v3 1/7] dt-bindings: mailbox: mediatek: Add MT8196 support for gce-mailbox

2025-01-03 Thread Krzysztof Kozlowski
On 30/12/2024 10:23, Jason-JH Lin (林睿祥) wrote: > Hi Krzysztof, > > On Fri, 2024-12-27 at 09:13 +0100, Krzysztof Kozlowski wrote: >> >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> >> >> On Fri, Dec 20, 2024 at 01:07:54AM +0

Re: [PATCH v8 8/9] dt-bindings: display: vop2: Add rk3576 support

2025-01-03 Thread Rob Herring
On Tue, Dec 31, 2024 at 05:07:51PM +0800, Andy Yan wrote: > From: Andy Yan > > Add vop found on rk3576, the main difference between rk3576 and the > previous vop is that each VP has its own interrupt line. > > Signed-off-by: Andy Yan > > --- > > Changes in v8: > - Fix dt_binding_check errors

[PATCH] drm/tests: helpers: Fix compile wrarning

2025-01-03 Thread Yu-Chun Lin
Delete one line break to make the format correct, resolving the following warning during a W=1 build: >> drivers/gpu/drm/tests/drm_kunit_helpers.c:324: warning: bad line: for a >> KUnit test Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202501032001.o6wy1vcw-...@

Re: [PATCH v3 15/15] drm/msm/dpu: Enable quad-pipe for DSC and dual-DSI case

2025-01-03 Thread Jun Nie
Dmitry Baryshkov 于2024年12月20日周五 07:46写道: > > On Thu, Dec 19, 2024 at 03:49:33PM +0800, Jun Nie wrote: > > Request 4 mixers and 4 DSC for the case that both dual-DSI and DSC are > > enabled. We prefer to use 4 pipes for dual DSI case for it is power optimal > > for DSC. > > > > Signed-off-by: Jun N

Re: AW: [RFC 00/14] Deadline scheduler and other ideas

2025-01-03 Thread Tvrtko Ursulin
On 03/01/2025 15:16, Koenig, Christian wrote: [AMD Official Use Only - AMD Internal Distribution Only] Could you send that whole patch set to me once more? No problem - I've pushed it to https://gitlab.freedesktop.org/tursulin/kernel/-/commits/drm-sched-deadline?ref_type=heads, that's prob

Re: [RFC 00/14] Deadline scheduler and other ideas

2025-01-03 Thread Tvrtko Ursulin
On 03/01/2025 12:31, Christian König wrote: Am 03.01.25 um 13:02 schrieb Tvrtko Ursulin: If I remember correctly Christian mentioned recently (give or take) that maybe round-robin could be removed. That got me thinking how and what could be improved and simplified. So I played a bit in the s

AW: [RFC 00/14] Deadline scheduler and other ideas

2025-01-03 Thread Koenig, Christian
[AMD Official Use Only - AMD Internal Distribution Only] Could you send that whole patch set to me once more? The AMD mails servers seem to have had a hickup over the holidays and all mails received between ~25.12.2024 and 1.1.2025 are somehow mangled. Thanks in advance, Christian. ___

Re: [RFC 08/14] drm/sched: Add deadline policy

2025-01-03 Thread Tvrtko Ursulin
On 03/01/2025 12:59, Philipp Stanner wrote: On Fri, 2025-01-03 at 12:40 +, Tvrtko Ursulin wrote: On 02/01/2025 13:11, Philipp Stanner wrote: On Mon, 2024-12-30 at 16:52 +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Deadline scheduling policy should be a fairer flavour of FIFO with

Re: [RFC 00/14] Deadline scheduler and other ideas

2025-01-03 Thread Philipp Stanner
On Fri, 2025-01-03 at 13:31 +0100, Christian König wrote: > Am 03.01.25 um 13:02 schrieb Tvrtko Ursulin: > > > > > > > > > > > > If I remember correctly Christian mentioned recently (give or > > > > take) > > > > that maybe > > > > round-robin could be removed. That got me thinking how and what >

[PATCH v3 2/4] drm/nouveau/dp: Use the generic helper to control LTTPR transparent mode

2025-01-03 Thread Abel Vesa
LTTPRs operating modes are defined by the DisplayPort standard and the generic framework now provides a helper to switch between them, which is handling the explicit disabling of non-transparent mode and its disable->enable sequence mentioned in the DP Standard v2.0 section 3.6.6.1. So use the new

[PATCH v3 4/4] drm/msm/dp: Add support for LTTPR handling

2025-01-03 Thread Abel Vesa
Link Training Tunable PHY Repeaters (LTTPRs) are defined in DisplayPort 1.4a specification. As the name suggests, these PHY repeaters are capable of adjusting their output for link training purposes. According to the DisplayPort standard, LTTPRs have two operating modes: - non-transparent - it re

[PATCH v3 1/4] drm/dp: Add helper to set LTTPRs in transparent mode

2025-01-03 Thread Abel Vesa
According to the DisplayPort standard, LTTPRs have two operating modes: - non-transparent - it replies to DPCD LTTPR field specific AUX requests, while passes through all other AUX requests - transparent - it passes through all AUX requests. Switching between this two modes is done by the DPT

[PATCH v3 3/4] drm/i915/dp: Use the generic helper to control LTTPR transparent mode

2025-01-03 Thread Abel Vesa
LTTPRs operating modes are defined by the DisplayPort standard and the generic framework now provides a helper to switch between them, which is handling the explicit disabling of non-transparent mode and its disable->enable sequence mentioned in the DP Standard v2.0 section 3.6.6.1. So use the new

[PATCH v3 0/4] drm/dp: Rework LTTPR transparent mode handling and add support to msm driver

2025-01-03 Thread Abel Vesa
Looking at both i915 and nouveau DP drivers, both are setting the first LTTPR (if found) in transparent mode first and then in non-transparent mode, just like the DP v2.0 specification mentions in section 3.6.6.1. Being part of the standard, setting the LTTPR in a specific operation mode can be ea

Re: [RFC 08/14] drm/sched: Add deadline policy

2025-01-03 Thread Philipp Stanner
On Fri, 2025-01-03 at 12:40 +, Tvrtko Ursulin wrote: > > On 02/01/2025 13:11, Philipp Stanner wrote: > > On Mon, 2024-12-30 at 16:52 +, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > Deadline scheduling policy should be a fairer flavour of FIFO > > > with > > > two > > > ma

Re: [RFC 00/14] Deadline scheduler and other ideas

2025-01-03 Thread Christian König
Am 03.01.25 um 13:02 schrieb Tvrtko Ursulin: If I remember correctly Christian mentioned recently (give or take) that maybe round-robin could be removed. That got me thinking how and what could be improved and simplified. So I played a bit in the scheduler code and came up with something which

Re: [PATCH v3 6/6] arm64: dts: qcom: x1e80100: Add OPPs up to Turbo L3 for GPU

2025-01-03 Thread Konrad Dybcio
On 30.12.2024 10:11 PM, Akhil P Oommen wrote: > Now that we have ACD support for GPU, add additional OPPs up to > Turbo L3 which are supported across all existing SKUs. > > Signed-off-by: Akhil P Oommen > --- Reviewed-by: Konrad Dybcio Konrad

Re: [RFC 08/14] drm/sched: Add deadline policy

2025-01-03 Thread Tvrtko Ursulin
On 02/01/2025 13:11, Philipp Stanner wrote: On Mon, 2024-12-30 at 16:52 +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Deadline scheduling policy should be a fairer flavour of FIFO with two main advantages being that it can naturally connect with the dma- fence deadlines, and secondly tha

Re: [PATCH v3 2/6] drm/msm: a6x: Rework qmp_get() error handling

2025-01-03 Thread Konrad Dybcio
On 30.12.2024 10:11 PM, Akhil P Oommen wrote: > Fix the following for qmp_get() errors: > > 1. Correctly handle probe defer for A6x GPUs > 2. Ignore other errors because those are okay when GPU ACD is > not required. They are checked again during gpu acd probe. > > Signed-off-by: Akhil P Oommen

Re: [PATCH v10 03/10] drm/connector: implement generic HDMI audio helpers

2025-01-03 Thread Dmitry Baryshkov
On Tue, Dec 31, 2024 at 07:49:40PM +0100, Martin Blumenstingl wrote: > On Tue, Dec 31, 2024 at 3:34 AM Dmitry Baryshkov > wrote: > [...] > > > I checked all instances of struct hdmi_codec_ops in v6.13-rc3 and it > > > seems that there is only a single driver which uses the .prepare > > > callback

Re: [PATCH v2] drm/ci: uprev IGT

2025-01-03 Thread Dmitry Baryshkov
On Tue, Dec 17, 2024 at 09:36:52PM +0530, Vignesh Raman wrote: > Uprev IGT to the latest version and update expectation files. > > Signed-off-by: Vignesh Raman > --- > > v1: > - Pipeline link - > https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1327810 > Will update the flake

Re: [RFC 00/14] Deadline scheduler and other ideas

2025-01-03 Thread Tvrtko Ursulin
On 02/01/2025 13:09, Philipp Stanner wrote: On Mon, 2024-12-30 at 16:52 +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Replacing FIFO with a flavour of deadline driven scheduling and removing round- robin. Connecting the scheduler with dma-fence deadlines. First draft and testing by dif

Re: [PATCH v2 16/16] drm/i915/dp: compute config for 128b/132b SST w/o DSC

2025-01-03 Thread Jani Nikula
On Thu, 02 Jan 2025, Imre Deak wrote: > On Thu, Dec 19, 2024 at 11:34:05PM +0200, Jani Nikula wrote: >> Enable basic 128b/132b SST functionality without compression. Reuse >> intel_dp_mtp_tu_compute_config() to figure out the TU after we've >> determined we need to use an UHBR rate. >> >> It's sl

Re: [PATCH v2 13/16] drm/i915/ddi: start distinguishing 128b/132b SST and MST at state readout

2025-01-03 Thread Jani Nikula
On Thu, 02 Jan 2025, Imre Deak wrote: > On Thu, Dec 19, 2024 at 11:34:02PM +0200, Jani Nikula wrote: >> We'll want to distinguish 128b/132b SST and MST modes at state >> readout. There's a catch, though. From the hardware perspective, >> 128b/132b SST and MST programming are pretty much the same.

Re: ADV7511/13 implementing atomic ops and bus formats

2025-01-03 Thread Dmitry Baryshkov
On Thu, Jan 02, 2025 at 09:04:47AM +, Jesse Van Gavere wrote: > Hello Dmitry, > > ... > > > The atomic_check() function verifies if the passed set of changes (in the > > form of drm_*_state) is valid from the driver's point of view. If you have > > nothing to check, it's fine to skip the fu

Re: [PATCH v9 drm-dp 0/5] Add dp module in hibmc driver

2025-01-03 Thread Dmitry Baryshkov
On Fri, 03 Jan 2025 17:38:19 +0800, Yongbang Shi wrote: > From: Baihan Li > > Realizing the basic display function of DP cable for DP connector > displaying. Add DP module in hibmc drm driver, which is for Hisilicon > Hibmc SoC which used for Out-of-band management. Blow is the general > hardware

Re: [PATCH v5 2/2] Documentation/gpu: Add fdinfo meanings of drm-*-internal memory tags

2025-01-03 Thread Tvrtko Ursulin
On 02/01/2025 22:18, Adrián Martínez Larumbe wrote: On 02.01.2025 21:59, Tvrtko Ursulin wrote: On 18/12/2024 18:18, Adrián Martínez Larumbe wrote: From: Adrián Larumbe A previous commit enabled display of driver-internal kernel BO sizes through the device file's fdinfo interface. Expand t

Re: [PATCH 0/6] A few drm_syncobj optimisations

2025-01-03 Thread Tvrtko Ursulin
On 02/01/2025 19:44, Tvrtko Ursulin wrote: From: Tvrtko Ursulin A small set of drm_syncobj optimisations which should make things a tiny bit more efficient on the CPU side of things. /Maybe/ between 1-2% more FPS can be observed with "vkgears -present-mailbox" on the Steam Deck Plasma deskto

[PATCH] drm/bochs: Do not put DRM device in PCI remove callback

2025-01-03 Thread Thomas Zimmermann
Removing the bochs PCI device should mark the DRM device as unplugged without removing it. Hence clear the respective call to drm_dev_put() from bochs_pci_remove(). Fixes a double unref in devm_drm_dev_init_release(). An example error message is shown below: [ 32.958338] BUG: KASAN: use-after-f

[PATCH v9 drm-dp 4/5] drm/hisilicon/hibmc: refactored struct hibmc_drm_private

2025-01-03 Thread Yongbang Shi
From: Baihan Li Refactored struct hibmc_drm_private to separate VGA module from generic struct. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov Reviewed-by: Tian Tao --- ChangeLog: v8 -> v9: - changing bahan li to Baihan Li, clear sign-off mismatches warn

[PATCH v9 drm-dp 0/5] Add dp module in hibmc driver

2025-01-03 Thread Yongbang Shi
From: Baihan Li Realizing the basic display function of DP cable for DP connector displaying. Add DP module in hibmc drm driver, which is for Hisilicon Hibmc SoC which used for Out-of-band management. Blow is the general hardware connection, both the Hibmc and the host CPU are on the same mother

[PATCH v9 drm-dp 3/5] drm/hisilicon/hibmc: add dp hw moduel in hibmc driver

2025-01-03 Thread Yongbang Shi
From: Baihan Li Build a dp level that hibmc driver can enable dp by calling their functions. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov Reviewed-by: Tian Tao --- ChangeLog: v8 -> v9: - changing bahan li to Baihan Li, clear sign-off mismatches warning

[PATCH v9 drm-dp 5/5] drm/hisilicon/hibmc: add dp module in hibmc

2025-01-03 Thread Yongbang Shi
From: Baihan Li To support DP interface displaying in hibmc driver. Add a encoder and connector for DP modual. The HPD function and get_edid function will be add in next series, so temporarily using 1024x768 as default in hibmc_dp_connector_get_modes() Signed-off-by: Baihan Li Signed-off-by: Yo

[PATCH v9 drm-dp 2/5] drm/hisilicon/hibmc: add dp link moduel in hibmc drivers

2025-01-03 Thread Yongbang Shi
From: Baihan Li Add link training process functions in this moduel. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov Reviewed-by: Tian Tao --- Changelog: v8 -> v9: - changing bahan li to Baihan Li, clear sign-off mismatches warnings, suggested by Dmitry B

[PATCH v9 drm-dp 1/5] drm/hisilicon/hibmc: add dp aux in hibmc drivers

2025-01-03 Thread Yongbang Shi
From: Baihan Li Add dp aux read/write functions. They are basic functions and will be used later. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov Reviewed-by: Tian Tao --- ChangeLog: v8 -> v9: - changing bahan li to Baihan Li, clear sign-off mismatches wa

Re: [PATCH v3 2/4] drm/bridge: imx8mp-hdmi-tx: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR

2025-01-03 Thread Liu Ying
On 01/01/2025, Marek Vasut wrote: > The dw-hdmi output_port is set to 1 in order to look for a connector > next bridge in order to get DRM_BRIDGE_ATTACH_NO_CONNECTOR working. > The output_port set to 1 makes the DW HDMI driver core look up the > next bridge in DT, where the next bridge is often the

Re: [PATCH v3 0/4] Update MT8188 OVL compatible from MT8183 to MT8195

2025-01-03 Thread AngeloGioacchino Del Regno
On Fri, 20 Dec 2024 02:15:27 +0800, Jason-JH.Lin wrote: > This patch series updates the compatible strings for the MediaTek OVL > in the MT8188 dts and the corresponding dt-binding. > The changes ensure that the MT8188 OVL device is correctly identified > and managed by the appropriate drivers. >

Re: [PATCH v5 03/10] drm/bridge: add support for refcounted DRM bridges

2025-01-03 Thread Jani Nikula
On Thu, 02 Jan 2025, Luca Ceresoli wrote: > Hello Jani, > > thanks for your review. > > On Tue, 31 Dec 2024 13:11:31 +0200 > Jani Nikula wrote: > >> On Tue, 31 Dec 2024, Luca Ceresoli wrote: >> > DRM bridges are currently considered as a fixed element of a DRM card, and >> > thus their lifetime

Re: [PATCH v8 drm-dp 0/5] Add dp module in hibmc driver

2025-01-03 Thread Yongbang Shi
On Thu, 2 Jan 2025 at 14:53, Yongbang Shi wrote: On Thu, Dec 19, 2024 at 10:52:32AM +0800, Yongbang Shi wrote: Does everyone have a question with the patch? -:225: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'reg_value' - possible side-effects? #225: FILE: drivers/gpu/drm/hisilicon/hibmc/dp/d

AW: [PATCH] drm/amdgpu: Enable runtime modification of gpu_recovery parameter with validation

2025-01-03 Thread Koenig, Christian
[AMD Official Use Only - AMD Internal Distribution Only] Hi Shuai, setting gpu_recovery=0 is not even remotely related to RAS. If that option affects RAS behavior in any way then that is a bug. The purpose of setting gpu_recovery=0 is to disable resets after a submission timeout most likely ca