[PATCH v4 1/1] drm/mediatek: Add return value check when reading DPCD

2025-01-02 Thread Liankun Yang
Returns the number of bytes transferred (1) on success. Check the return value to confirm that AUX communication is successful. Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver") Signed-off-by: Liankun Yang --- Changes in V4: - Fix IF judgement condition. Per suggestion

Re: [PATCH v2] drm/ci: uprev IGT

2025-01-02 Thread Dmitry Baryshkov
On Tue, Dec 17, 2024 at 09:36:52PM +0530, Vignesh Raman wrote: > Uprev IGT to the latest version and update expectation files. > > Signed-off-by: Vignesh Raman > --- > > v1: > - Pipeline link - > https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1327810 > Will update the flake

Re: [PATCH v5 08/10] drm/bridge: samsung-dsim: use supporting variable for out_bridge

2025-01-02 Thread Dmitry Baryshkov
On Thu, Jan 02, 2025 at 01:01:49PM +0100, Luca Ceresoli wrote: > Hi Dmitry, > > On Tue, 31 Dec 2024 16:57:38 +0200 > Dmitry Baryshkov wrote: > > > On Tue, Dec 31, 2024 at 11:40:02AM +0100, Luca Ceresoli wrote: > > > Instead of using dsi->out_bridge during the bridge search process, use a > > > t

Re: [PATCH v3 2/4] drm/bridge: imx8mp-hdmi-tx: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR

2025-01-02 Thread Dmitry Baryshkov
On Fri, Jan 03, 2025 at 12:22:34AM +0100, Marek Vasut wrote: > On 1/2/25 5:55 AM, Dmitry Baryshkov wrote: > > On Tue, Dec 31, 2024 at 08:28:49PM +0100, Marek Vasut wrote: > > > The dw-hdmi output_port is set to 1 in order to look for a connector > > > next bridge in order to get DRM_BRIDGE_ATTACH_N

Re: [PATCH v3 1/4] drm: bridge: dw_hdmi: Add flag to indicate output port is optional

2025-01-02 Thread Dmitry Baryshkov
On Thu, Jan 02, 2025 at 10:30:38AM +0200, Laurent Pinchart wrote: > On Thu, Jan 02, 2025 at 05:26:50AM +0200, Dmitry Baryshkov wrote: > > On Thu, Jan 02, 2025 at 12:36:20AM +0200, Laurent Pinchart wrote: > > > On Tue, Dec 31, 2024 at 10:10:51PM +0100, Marek Vasut wrote: > > > > On 12/31/24 9:31 PM,

Re: [PATCH v3 3/4] drm/lcdif: add DRM_BRIDGE_ATTACH_NO_CONNECTOR flag to drm_bridge_attach

2025-01-02 Thread Dmitry Baryshkov
On Fri, Jan 03, 2025 at 12:20:19AM +0100, Marek Vasut wrote: > On 1/2/25 6:58 PM, Dmitry Baryshkov wrote: > > [...] > > > > @@ -97,13 +100,36 @@ static int lcdif_attach_bridge(struct > > > lcdif_drm_private *lcdif) > > > return ret; > > > } > > > -

Re: [PATCH v1 2/4] ipmi: Add Loongson-2K BMC support

2025-01-02 Thread kernel test robot
Hi Binbin, kernel test robot noticed the following build warnings: [auto build test WARNING on linus/master] [also build test WARNING on v6.13-rc5] [cannot apply to cminyard-ipmi/for-next lee-mfd/for-mfd-next lee-mfd/for-mfd-fixes next-20241220] [If your patch is applied to the wrong git tree, k

[PATCH] fbdev: efifb: Change the return value type to void

2025-01-02 Thread oushixiong1025
From: Shixiong Ou efifb_setup() doesn't need to return a value. Signed-off-by: Shixiong Ou --- drivers/video/fbdev/efifb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c index 20517448487e..0e1bd3dba255 100644 --

Re: [PATCH v3 1/1] drm/mediatek: Add return value check when reading DPCD

2025-01-02 Thread 杨连坤

[git pull] drm fixes for 6.13-rc6

2025-01-02 Thread Dave Airlie
Hi Linus, Happy New Year, It was fairly quiet for holidays period, certainly nothing that worth getting off the couch before I needed to, this is for the past two weeks, i915, xe and some adv7511, I expect we will see some amdgpu etc happening next week, but otherwise all quiet. Regards, Dave. d

Re: [PATCH v6 1/2] drm/panthor: Expose size of driver internal BO's over fdinfo

2025-01-02 Thread kernel test robot
Hi Adrián, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on next-20241220] [cannot apply to linus/master v6.13-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting pa

Re: [PATCH v4 01/11] libnvdimm: Replace namespace_match() with device_find_child_by_name()

2025-01-02 Thread Zijun Hu
On 2025/1/3 02:17, Fan Ni wrote: >> - >> static bool is_idle(struct device *dev, struct nd_namespace_common *ndns) >> { >> struct nd_region *nd_region = to_nd_region(dev->parent); >> @@ -168,7 +161,7 @@ ssize_t nd_namespace_store(struct device *dev, >> goto out; >> } >> >

Re: [PATCH v3 2/4] drm/bridge: imx8mp-hdmi-tx: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR

2025-01-02 Thread Marek Vasut
On 1/2/25 5:55 AM, Dmitry Baryshkov wrote: On Tue, Dec 31, 2024 at 08:28:49PM +0100, Marek Vasut wrote: The dw-hdmi output_port is set to 1 in order to look for a connector next bridge in order to get DRM_BRIDGE_ATTACH_NO_CONNECTOR working. The output_port set to 1 makes the DW HDMI driver core

Re: [PATCH v3 3/4] drm/lcdif: add DRM_BRIDGE_ATTACH_NO_CONNECTOR flag to drm_bridge_attach

2025-01-02 Thread Marek Vasut
On 1/2/25 6:58 PM, Dmitry Baryshkov wrote: [...] @@ -97,13 +100,36 @@ static int lcdif_attach_bridge(struct lcdif_drm_private *lcdif) return ret; } - ret = drm_bridge_attach(encoder, bridge, NULL, 0); + ret = drm_bridge_attach(encoder,

Re: [PATCH v5 2/2] Documentation/gpu: Add fdinfo meanings of drm-*-internal memory tags

2025-01-02 Thread Adrián Martínez Larumbe
On 02.01.2025 21:59, Tvrtko Ursulin wrote: > >On 18/12/2024 18:18, Adrián Martínez Larumbe wrote: >> From: Adrián Larumbe >> >> A previous commit enabled display of driver-internal kernel BO sizes >> through the device file's fdinfo interface. >> >> Expand the description of the relevant driver-

Re: [PATCH v5 2/2] Documentation/gpu: Add fdinfo meanings of drm-*-internal memory tags

2025-01-02 Thread Tvrtko Ursulin
On 18/12/2024 18:18, Adrián Martínez Larumbe wrote: From: Adrián Larumbe A previous commit enabled display of driver-internal kernel BO sizes through the device file's fdinfo interface. Expand the description of the relevant driver-specific key:value pairs with the definitions of the new drm

[PATCH V1 6/7] accel/amdxdna: Add __user to second parameter of aie2_query_status

2025-01-02 Thread Lizhi Hou
The second parameter of aie2_query_status() is a userspace pointer. Declaring it as 'char __user *' to fix sparse warning. Fixes: 850d71f6bf4c ("accel/amdxdna: Add query functions") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202412311655.ybvq2wjb-...@intel.com/

[PATCH V1 4/7] accel/amdxdna: Use rcu_access_pointer for __rcu pointer

2025-01-02 Thread Lizhi Hou
Use rcu_access_pointer for pid in struct drm_file. This fixes sparse warning. Fixes: be462c97b7df ("accel/amdxdna: Add hardware context") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202412311210.lfehtzlw-...@intel.com/ Signed-off-by: Lizhi Hou --- drivers/accel

[PATCH V1 1/7] accel/amdxdna: Declare npu device profile as static variables

2025-01-02 Thread Lizhi Hou
Declare the variables as static to fix the sparse warnings: symbol 'npu5_dev_priv' was not declared. Should it be static? symbol 'npu1_dev_priv' was not declared. Should it be static? symbol 'npu4_dev_priv' was not declared. Should it be static? symbol 'npu2_dev_priv' was not declared. Should it be

[PATCH V1 7/7] accel/amdxdna: Declare npu6_dev_priv as static

2025-01-02 Thread Lizhi Hou
Fix sparse warning: symbol 'npu6_dev_priv' was not declared. Should it be static? Fixes: 273b5176ac17 ("accel/amdxdna: Add RyzenAI-npu6 support") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202412311819.9mz11uak-...@intel.com/ Signed-off-by: Lizhi Hou --- dri

[PATCH V1 5/7] accel/amdxdna: Declare force_cmdlist as static

2025-01-02 Thread Lizhi Hou
Fix sparse warning: symbol 'force_cmdlist' was not declared. Should it be static? Fixes: aac243092b70 ("accel/amdxdna: Add command execution") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202412311448.gkqj7upz-...@intel.com/ Signed-off-by: Lizhi Hou --- driver

[PATCH V1 2/7] accel/amdxdna: Declare mailbox register base as __iomem pointer

2025-01-02 Thread Lizhi Hou
Declare mailbox ringbuf_base and mbox_base as 'void __iomem *' to fix sparse warnings: cast removes address space '__iomem' of expression incorrect type in argument 2 (different address spaces) Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox") Reported-by: kernel test robot Clos

[PATCH V1 3/7] accel/amdxdna: Declare aie2_max_col as static

2025-01-02 Thread Lizhi Hou
Fix the sparse warning: symbol 'aie2_max_col' was not declared. Should it be static? Fixes: c88d3325ae69 ("accel/amdxdna: Add hardware resource solver") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202412311028.x2utcshm-...@intel.com/ Signed-off-by: Lizhi Hou -

[PATCH v6 2/2] Documentation/gpu: Add fdinfo meanings of drm-*-internal memory tags

2025-01-02 Thread Adrián Larumbe
A previous commit enabled display of driver-internal kernel BO sizes through the device file's fdinfo interface. Expand the description of the relevant driver-specific key:value pairs with the definitions of the new drm-*-internal ones. Reviewed-by: Mihail Atanassov Reviewed-by: Liviu Dudau Rev

[PATCH v6 1/2] drm/panthor: Expose size of driver internal BO's over fdinfo

2025-01-02 Thread Adrián Larumbe
This will display the sizes of kenrel BO's bound to an open file, which are otherwise not exposed to UM through a handle. The sizes recorded are as follows: - Per group: suspend buffer, protm-suspend buffer, syncobjcs - Per queue: ringbuffer, profiling slots, firmware interface - For all heaps

[PATCH v6 0/2] drm/panthor: Display size of internal kernel BOs through fdinfo

2025-01-02 Thread Adrián Larumbe
This patch series enables display of the size of driver-owned shmem BO's that aren't exposed to userspace through a DRM handle. Discussion of previous revision can be found here [1]. Changelog: v6: - Replace up_write with up_read, which was left out in the previous version - Fixed some minor c

Re: [PATCH v5 1/2] drm/panthor: Expose size of driver internal BO's over fdinfo

2025-01-02 Thread Adrián Martínez Larumbe
On 19.12.2024 16:30, Mihail Atanassov wrote: On 18/12/2024 18:18, Adrián Martínez Larumbe wrote: > > From: Adrián Larumbe > > > > This will display the sizes of kenrel BO's bound to an open file, which are > > otherwise not exposed to UM through a handle. > > > > The sizes recorded are as follow

Re: [PATCH 0/2] Print GMU version at boot on >A630

2025-01-02 Thread Akhil P Oommen
On 12/20/2024 4:06 AM, Konrad Dybcio wrote: > Might come in useful to try and track down otherwise inexplicable > failures in e.g. old CI logs. A630 uses a different mechanism that is > not implemented in this series. > > Tested on 8280 and X1 > > Signed-off-by: Konrad Dybcio For the whole seri

Re: [PATCH v2] drm/msm: UAPI error reporting

2025-01-02 Thread Akhil P Oommen
On 12/30/2024 9:30 PM, Rob Clark wrote: > From: Rob Clark > > Debugging incorrect UAPI usage tends to be a bit painful, so add a > helper macro to make it easier to add debug logging which can be enabled > at runtime via drm.debug. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/adren

Re: [PULL] drm-xe-fixes

2025-01-02 Thread Thomas Hellström
On Mon, 2024-12-23 at 18:53 +0100, Thomas Hellstrom wrote: > Hi Dave, Simona > > The Xe fixes for -rc5. This PR just got superseded by a new one (drm-xe-fixes-2025-01-02), that includes also the commits mentioned here. Thanks, Thomas > > Thanks, > Thomas > > drm-xe-fixes-2024-12-23: > UAPI

[PULL] drm-xe-fixes

2025-01-02 Thread Thomas Hellstrom
Hi Dave, Simona! Happy new year! This PR supersedes the one sent out 24-12-23, since that didn't seem to get pulled over the holidays. There's one extra commit (The OA fixes). The rest of the summary is repeated. Thanks, Thomas drm-xe-fixes-2025-01-02: This supersedes drm-xe-fixes-2024-12-23. U

[PATCH 3/6] drm/syncobj: Do not allocate an array to store zeros

2025-01-02 Thread Tvrtko Ursulin
From: Tvrtko Ursulin When waiting on syncobjs the current code allocates a temporary array only to fill it up with all zeros. We can avoid that by relying on the allocated entry array already being zero allocated. For the timeline mode we fetch the timeline point values as we populate the entrie

[PATCH 4/6] drm/syncobj: Avoid one temporary allocation in drm_syncobj_array_find

2025-01-02 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Drm_syncobj_array_find() is used from many entry points with the task of looking up userspace handles to internal objects. We can easily avoid one temporary allocation by making it read the handles as it is looking them up. "vkgears -present-mailbox" average framerate: B

[PATCH 6/6] drm/syncobj: Avoid temporary allocation in drm_syncobj_timeline_signal_ioctl

2025-01-02 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We can avoid one of the two temporary allocations if we read the userspace supplied timeline points as we go along. The only new complication is to unwind unused fence chains on the error path, but even that code was already present in the function. Signed-off-by: Tvrtko Ur

[PATCH 5/6] drm/syncobj: Use put_user in drm_syncobj_query_ioctl

2025-01-02 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Since the query loop is using copy_to_user() to write out a single u64 at a time it feels more natural (and is a tiny bit more compact) to replace it with put_user(). Access_ok() check is added to the input checking for an early bailout in case of a bad buffer passed in. Si

[PATCH 2/6] drm/syncobj: Remove unhelpful helper

2025-01-02 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Helper which fails to consolidate the code and instead just forks into two copies of the code based on a boolean parameter is not very helpful or readable. Lets just remove it and proof in the pudding is the net smaller code. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/d

[PATCH 0/6] A few drm_syncobj optimisations

2025-01-02 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A small set of drm_syncobj optimisations which should make things a tiny bit more efficient on the CPU side of things. /Maybe/ between 1-2% more FPS can be observed with "vkgears -present-mailbox" on the Steam Deck Plasma desktop but I am reluctant to make a definitive claim

[PATCH 1/6] drm/syncobj: Avoid double memset in drm_syncobj_find_fence

2025-01-02 Thread Tvrtko Ursulin
From: Tvrtko Ursulin On kernels hardened with CONFIG_INIT_STACK_ALL_ZERO we can avoid the double memset by moving the memory clearing to the declaration block. That way the compiler can notice and only emit it once. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/drm_syncobj.c | 3 +-- 1 fil

Re: [PATCH v4 06/11] mtd: intel-dg: align 64bit read and write

2025-01-02 Thread David Laight
On Wed, 1 Jan 2025 17:39:20 +0200 Alexander Usyskin wrote: > GSC NVM controller HW errors on quad access overlapping 1K border. > Align 64bit read and write to avoid readq/writeq over 1K border. > > Acked-by: Miquel Raynal > Signed-off-by: Alexander Usyskin > --- > drivers/mtd/devices/mtd-in

Re: [PATCH v4 06/11] mtd: intel-dg: align 64bit read and write

2025-01-02 Thread David Laight
On Wed, 1 Jan 2025 16:41:19 + David Laight wrote: > On Wed, 1 Jan 2025 17:39:20 +0200 > Alexander Usyskin wrote: > > > GSC NVM controller HW errors on quad access overlapping 1K border. > > Align 64bit read and write to avoid readq/writeq over 1K border. > > > > Acked-by: Miquel Raynal >

Re: [PATCH v1 3/4] drm/ls2kbmc: Add support for Loongson-2K BMC display

2025-01-02 Thread Binbin Zhou
Hi Thomas: Thanks for your reply. On Thu, Jan 2, 2025 at 5:07 PM Thomas Zimmermann wrote: > > Hi > > > Am 30.12.24 um 10:31 schrieb Binbin Zhou: > [...] > > + > > +static struct platform_driver ls2kbmc_platform_driver = { > > + .driver = { > > + .name = "ls2kbmc-framebuffer", > >

Re: [PATCH v8 drm-dp 0/5] Add dp module in hibmc driver

2025-01-02 Thread Dmitry Baryshkov
On Thu, 2 Jan 2025 at 14:53, Yongbang Shi wrote: > > > On Thu, Dec 19, 2024 at 10:52:32AM +0800, Yongbang Shi wrote: > >> Does everyone have a question with the patch? > > -:225: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'reg_value' - possible > > side-effects? > > #225: FILE: drivers/gpu/drm/h

Re: [PATCH v4 01/11] libnvdimm: Replace namespace_match() with device_find_child_by_name()

2025-01-02 Thread Fan Ni
On Wed, Dec 11, 2024 at 08:08:03AM +0800, Zijun Hu wrote: > From: Zijun Hu > > Simplify nd_namespace_store() implementation by > using device_find_child_by_name(). > > Reviewed-by: Alison Schofield > Signed-off-by: Zijun Hu > --- > drivers/nvdimm/claim.c | 9 + > 1 file changed, 1 ins

Re: [PATCH v3 3/4] drm/lcdif: add DRM_BRIDGE_ATTACH_NO_CONNECTOR flag to drm_bridge_attach

2025-01-02 Thread Dmitry Baryshkov
On Tue, Dec 31, 2024 at 08:28:50PM +0100, Marek Vasut wrote: > Commit a25b988ff83f ("drm/bridge: Extend bridge API to disable connector > creation") > added DRM_BRIDGE_ATTACH_NO_CONNECTOR bridge flag and all bridges handle > this flag in some way since then. > Newly added bridge drivers must no lo

Re: [PATCH v4 04/11] driver core: Constify API device_find_child() then adapt for various usages

2025-01-02 Thread Mathieu Poirier
On Wed, Dec 11, 2024 at 08:08:06AM +0800, Zijun Hu wrote: > From: Zijun Hu > > Constify the following API: > struct device *device_find_child(struct device *dev, void *data, > int (*match)(struct device *dev, void *data)); > To : > struct device *device_find_child(struct device *dev

Re: [PATCH v2 12/16] drm/i915/ddi: enable ACT handling for 128b/132b SST

2025-01-02 Thread Imre Deak
On Thu, Dec 19, 2024 at 11:34:01PM +0200, Jani Nikula wrote: > Add ACT handling for 128b/132b SST. > > This is preparation for enabling 128b/132b SST. This path is not > reachable yet. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 13 + > 1 file c

Re: [PATCH v2 16/16] drm/i915/dp: compute config for 128b/132b SST w/o DSC

2025-01-02 Thread Imre Deak
On Thu, Dec 19, 2024 at 11:34:05PM +0200, Jani Nikula wrote: > Enable basic 128b/132b SST functionality without compression. Reuse > intel_dp_mtp_tu_compute_config() to figure out the TU after we've > determined we need to use an UHBR rate. > > It's slightly complicated as the M/N computation is d

Re: [PATCH v2 15/16] drm/i915/ddi: disable trancoder port select for 128b/132b SST

2025-01-02 Thread Imre Deak
On Thu, Dec 19, 2024 at 11:34:04PM +0200, Jani Nikula wrote: > 128b/1232b SST will have mst_master_transcoder set and matching > cpu_transcoder. Ensure disable also for 128b/132b SST. > > Co-developed-by: Imre Deak > Signed-off-by: Imre Deak > Signed-off-by: Jani Nikula Reviewed-by: Imre Deak

Re: [PATCH v2 14/16] drm/i915/ddi: handle 128b/132b SST in intel_ddi_read_func_ctl()

2025-01-02 Thread Imre Deak
On Thu, Dec 19, 2024 at 11:34:03PM +0200, Jani Nikula wrote: > We'll only ever get here in MST mode from MST stream encoders; the > primary encoder's ->get_config() won't be called when we've detected > it's MST. > > v2: Read mst_master_transcoder in 128b/132b SST path (Imre) > > Signed-off-by: J

Re: [PATCH v2 13/16] drm/i915/ddi: start distinguishing 128b/132b SST and MST at state readout

2025-01-02 Thread Imre Deak
On Thu, Dec 19, 2024 at 11:34:02PM +0200, Jani Nikula wrote: > We'll want to distinguish 128b/132b SST and MST modes at state > readout. There's a catch, though. From the hardware perspective, > 128b/132b SST and MST programming are pretty much the same. And we can't > really ask the sink at this p

Re: [PATCH] drm/amdgpu: Add null pointer check before task_info get and put

2025-01-02 Thread Sharma, Shashank
Lgtm, Reviewed-by: Shashank Sharma Regards Shashank On 01/01/2025 02:58, Lu Yao wrote: This patch add null pointer check for amdgpu_vm_put_task_info and amdgpu_vm_get_task_info_vm, because there is only a warning if create task_info failed in amdgpu_vm_init. Fixes: b8f67b9ddf4f ("drm/amdgpu

Re: [PATCH v3 1/1] drm/mediatek: Add return value check when reading DPCD

2025-01-02 Thread Chun-Kuang Hu
Hi, Liankun: Liankun Yang 於 2024年12月18日 週三 下午7:35寫道: > > Returns the number of bytes transferred (1) on success. > Check the return value to confirm that AUX communication is successful. > > Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver") > > Signed-off-by: Liankun Ya

RE: [PATCH v4 06/11] mtd: intel-dg: align 64bit read and write

2025-01-02 Thread Usyskin, Alexander
> > GSC NVM controller HW errors on quad access overlapping 1K border. > > Align 64bit read and write to avoid readq/writeq over 1K border. > > > > Acked-by: Miquel Raynal > > Signed-off-by: Alexander Usyskin > > --- > > drivers/mtd/devices/mtd-intel-dg.c | 35 > ++ >

Re: [PATCH v2 10/16] drm/i915/ddi: write payload for 128b/132b SST

2025-01-02 Thread Imre Deak
On Thu, Jan 02, 2025 at 12:52:38PM +0200, Jani Nikula wrote: > On Tue, 31 Dec 2024, Imre Deak wrote: > > On Thu, Dec 19, 2024 at 11:33:59PM +0200, Jani Nikula wrote: > >> Write the payload allocation table for 128b/132b SST. Use VCPID 1 and > >> start from slot 0, with dp_m_n.tu slots. > >> > >>

Re: [PATCH v2] drm/mediatek: dp: Support flexible length of DP calibration data

2025-01-02 Thread Chun-Kuang Hu
Hi, Fei: Fei Shao 於 2024年12月4日 週三 下午10:26寫道: > > The DP calibration data is stored in nvmem cells, and the data layout is > described in the `mtk_dp_efuse_fmt` arrays for each platform. > > There is no guarantee that the data is always a 4-length u32 cell array. > For example, MT8188 has a data l

Re: [PATCH 0/4] cover-letter: Allow MMIO regions to be exported through dmabuf

2025-01-02 Thread Jason Gunthorpe
On Thu, Dec 19, 2024 at 11:04:54AM +0100, Christian König wrote: > > Based on all the above, I think we can conclude that since dma_buf_put() > > does not directly (or synchronously) call the f_op->release() handler, a > > deadlock is unlikely to occur in the scenario you described. Right, there

Re: [PATCH v2 07/16] drm/i915/mst: adapt intel_dp_mtp_tu_compute_config() for 128b/132b SST

2025-01-02 Thread Imre Deak
On Thu, Jan 02, 2025 at 12:30:34PM +0200, Jani Nikula wrote: > On Tue, 31 Dec 2024, Imre Deak wrote: > > On Thu, Dec 19, 2024 at 11:33:56PM +0200, Jani Nikula wrote: > >> Handle 128b/132b SST in intel_dp_mtp_tu_compute_config(). The remote > >> bandwidth overhead and time slot allocation are only

Re: [PATCH v1 3/4] drm/ls2kbmc: Add support for Loongson-2K BMC display

2025-01-02 Thread Thomas Zimmermann
Hi Am 02.01.25 um 13:55 schrieb Binbin Zhou: Hi Thomas: Thanks for your reply. On Thu, Jan 2, 2025 at 5:07 PM Thomas Zimmermann wrote: Hi Am 30.12.24 um 10:31 schrieb Binbin Zhou: [...] + +static struct platform_driver ls2kbmc_platform_driver = { + .driver = { + .name = "

RE: [PATCH v4 02/11] mtd: add driver for intel graphics non-volatile memory device

2025-01-02 Thread Usyskin, Alexander
> ... > > > +struct intel_dg_nvm { > > + struct kref refcnt; > > + void __iomem *base; > > + size_t size; > > + unsigned int nregions; > > + struct { > > + const char *name; > > + u8 id; > > + u64 offset; > > + u64 size; > > + } regions[]; > > _

Re: [RFC 08/14] drm/sched: Add deadline policy

2025-01-02 Thread Philipp Stanner
On Mon, 2024-12-30 at 16:52 +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Deadline scheduling policy should be a fairer flavour of FIFO with > two > main advantages being that it can naturally connect with the dma- > fence > deadlines, and secondly that it can get away with multiple run

Re: [RFC 00/14] Deadline scheduler and other ideas

2025-01-02 Thread Philipp Stanner
On Mon, 2024-12-30 at 16:52 +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > > Replacing FIFO with a flavour of deadline driven scheduling and > removing round- > robin. Connecting the scheduler with dma-fence deadlines. First draft > and > testing by different drivers and feedback would

Re: [PATCH v8 drm-dp 0/5] Add dp module in hibmc driver

2025-01-02 Thread Yongbang Shi
On Thu, Dec 19, 2024 at 10:52:32AM +0800, Yongbang Shi wrote: Does everyone have a question with the patch? -:225: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'reg_value' - possible side-effects? #225: FILE: drivers/gpu/drm/hisilicon/hibmc/dp/dp_comm.h:23: +#define dp_field_modify(reg_value, ma

Re: [PATCH RESEND v7 00/10] drm/bridge: it6505: fix HDCP CTS fail items and add MCCS support

2025-01-02 Thread AngeloGioacchino Del Regno
Il 30/12/24 11:51, Hermes Wu via B4 Relay ha scritto: There are lots of failure items while running HDCP CTS using UNIGRAF DPR-100. In Order to fix those failures, HDCP flow needs to be changed. The DisplayPort AUX protocol supports I2C transport. In Order to support MCCS via the aux channel, th

Re: [PATCH] drm/mediatek: Remove unneeded semicolon

2025-01-02 Thread AngeloGioacchino Del Regno
Il 30/12/24 14:53, Chun-Kuang Hu ha scritto: cocci warnings: (new ones prefixed by >>) drivers/gpu/drm/mediatek/mtk_drm_drv.c:1092:2-3: Unneeded semicolon Fixes: 4c932840db1d ("drm/mediatek: Implement OF graphs support for display paths") Reported-by: kernel test robot Closes: https://lore.

Re: [PATCH v2 11/16] drm/i915/ddi: initialize 128b/132b SST DP2 VFREQ registers

2025-01-02 Thread Imre Deak
On Thu, Jan 02, 2025 at 11:39:07AM +0200, Jani Nikula wrote: > On Tue, 31 Dec 2024, Imre Deak wrote: > > On Thu, Dec 19, 2024 at 11:34:00PM +0200, Jani Nikula wrote: > >> Write the DP2 specific VFREQ registers. > >> > >> This is preparation for enabling 128b/132b SST. This path is not > >> reacha

Re: [PATCH v5 03/10] drm/bridge: add support for refcounted DRM bridges

2025-01-02 Thread Luca Ceresoli
Hello Jani, thanks for your review. On Tue, 31 Dec 2024 13:11:31 +0200 Jani Nikula wrote: > On Tue, 31 Dec 2024, Luca Ceresoli wrote: > > DRM bridges are currently considered as a fixed element of a DRM card, and > > thus their lifetime is assumed to extend for as long as the card > > exists.

Re: [PATCH v5 04/10] drm/bridge: add documentation of refcounted bridges

2025-01-02 Thread Luca Ceresoli
Hello Randy, On Tue, 31 Dec 2024 09:54:41 -0800 Randy Dunlap wrote: > Hi-- > > On 12/31/24 2:39 AM, Luca Ceresoli wrote: > > Document in detail the new refcounted bridges as well as the "legacy" way. > > > > Signed-off-by: Luca Ceresoli > > > > --- ... > > + * Allocation, initializion and

Re: [PATCH v5 08/10] drm/bridge: samsung-dsim: use supporting variable for out_bridge

2025-01-02 Thread Luca Ceresoli
Hi Dmitry, On Tue, 31 Dec 2024 16:57:38 +0200 Dmitry Baryshkov wrote: > On Tue, Dec 31, 2024 at 11:40:02AM +0100, Luca Ceresoli wrote: > > Instead of using dsi->out_bridge during the bridge search process, use a > > temporary variable and assign dsi->out_bridge only on successful > > completion.

Re: [PATCH v5 10/10] drm/bridge: hotplug-bridge: add driver to support hot-pluggable DSI bridges

2025-01-02 Thread Luca Ceresoli
Hi Dmitry, On Tue, 31 Dec 2024 17:29:52 +0200 Dmitry Baryshkov wrote: > On Tue, Dec 31, 2024 at 11:40:04AM +0100, Luca Ceresoli wrote: > > This driver implements the point of a DRM pipeline where a connector allows > > removal of all the following bridges up to the panel. > > > > The DRM subsys

Re: [PATCH 3/3] drm/rockchip: Add basic RK3576 HDMI output support

2025-01-02 Thread Heiko Stübner
Am Mittwoch, 25. Dezember 2024, 11:37:31 CET schrieb Andy Yan: > From: Andy Yan > > The HDMI on RK3576 shares the same IP block (PHY and Controller) > with rk3588. > However, there are some control bits scattered in different GRF. > > Signed-off-by: Andy Yan > Signed-off-by: Detlev Casanova >

Re: [PATCH 1/3] drm/rockchip: dw_hdmi_qp: Add platform ctrl callback

2025-01-02 Thread Heiko Stübner
Hi Andy, Am Mittwoch, 25. Dezember 2024, 11:37:29 CET schrieb Andy Yan: > From: Andy Yan > > There are some control bits for IO and interrupts status scattered > across different GRF on differt SOC. > Add platform callback for this IO setting and interrupts status > handling. > > Signed-off-by:

Re: [PATCH] drm/mst: remove mgr parameter and debug logging from drm_dp_get_vc_payload_bw()

2025-01-02 Thread Jani Nikula
On Thu, 02 Jan 2025, Jani Nikula wrote: > The struct drm_dp_mst_topology_mgr *mgr parameter is only used for debug > logging in case the passed in link rate or lane count are zero. There's > no further error checking as such, and the function returns 0. > > There should be no case where the parame

[PATCH RESEND] drm/nouveau/disp: Fix missing backlight control on Macbook 5, 1

2025-01-02 Thread Takashi Iwai
Macbook 5,1 with MCP79 lost its backlight control since the recent change for supporting GFP-RM; it rewrote the whole nv50 backlight control code and each display engine is supposed to have an entry for IOR bl callback, but it didn't cover mcp77. This patch adds the missing bl entry initialization

Re: [PATCH v2 10/16] drm/i915/ddi: write payload for 128b/132b SST

2025-01-02 Thread Jani Nikula
On Tue, 31 Dec 2024, Imre Deak wrote: > On Thu, Dec 19, 2024 at 11:33:59PM +0200, Jani Nikula wrote: >> Write the payload allocation table for 128b/132b SST. Use VCPID 1 and >> start from slot 0, with dp_m_n.tu slots. >> >> This is preparation for enabling 128b/132b SST. This path is not >> reach

RE: [PATCH v4 03/11] mtd: intel-dg: implement region enumeration

2025-01-02 Thread Usyskin, Alexander
> > > @@ -89,6 +281,13 @@ static int intel_dg_mtd_probe(struct > auxiliary_device *aux_dev, > > goto err; > > } > > > > + ret = intel_dg_nvm_init(nvm, device); > > + if (ret < 0) { > > + dev_err(device, "cannot initialize nvm\n"); > > + ret = -ENODEV; > > W

Re: [PATCH v4 03/11] mtd: intel-dg: implement region enumeration

2025-01-02 Thread Christophe JAILLET
Le 01/01/2025 à 16:39, Alexander Usyskin a écrit : In intel-dg, there is no access to the spi controller, the information is extracted from the descriptor region. CC: Lucas De Marchi Reviewed-by: Rodrigo Vivi Acked-by: Miquel Raynal Co-developed-by: Tomas Winkler Signed-off-by: Tomas Winkler

Re: [PATCH v3 1/6] drm/msm/adreno: Add support for ACD

2025-01-02 Thread Akhil P Oommen
On 12/31/2024 3:18 PM, neil.armstr...@linaro.org wrote: > On 30/12/2024 22:11, Akhil P Oommen wrote: >> ACD a.k.a Adaptive Clock Distribution is a feature which helps to reduce >> the power consumption. In some chipsets, it is also a requirement to >> support higher GPU frequencies. This patch adds

Re: [PATCH v4 02/11] mtd: add driver for intel graphics non-volatile memory device

2025-01-02 Thread Christophe JAILLET
Le 01/01/2025 à 16:39, Alexander Usyskin a écrit : Add auxiliary driver for intel discrete graphics non-volatile memory device. CC: Lucas De Marchi Reviewed-by: Rodrigo Vivi Acked-by: Miquel Raynal Co-developed-by: Tomas Winkler Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin

Re: [PATCH v2 07/16] drm/i915/mst: adapt intel_dp_mtp_tu_compute_config() for 128b/132b SST

2025-01-02 Thread Jani Nikula
On Tue, 31 Dec 2024, Imre Deak wrote: > On Thu, Dec 19, 2024 at 11:33:56PM +0200, Jani Nikula wrote: >> Handle 128b/132b SST in intel_dp_mtp_tu_compute_config(). The remote >> bandwidth overhead and time slot allocation are only relevant for MST; >> SST only needs the local bandwidth and a check t

Re: [PATCH v3 4/6] dt-bindings: opp: Add v2-qcom-adreno vendor bindings

2025-01-02 Thread Akhil P Oommen
On 12/31/2024 3:09 PM, Konrad Dybcio wrote: > On 30.12.2024 11:25 PM, Rob Herring (Arm) wrote: >> >> On Tue, 31 Dec 2024 02:41:05 +0530, Akhil P Oommen wrote: >>> Add a new schema which extends opp-v2 to support a new vendor specific >>> property required for Adreno GPUs found in Qualcomm's SoCs. T

Re: [PATCH v2 06/16] drm/i915/mst: split out a helper for figuring out the TU

2025-01-02 Thread Jani Nikula
On Tue, 31 Dec 2024, Imre Deak wrote: > On Thu, Dec 19, 2024 at 11:33:55PM +0200, Jani Nikula wrote: >> Extract intel_dp_mtp_tu_compute_config() for figuring out the TU. Move >> the link configuration and mst state access to the callers. This will be >> easier to adapt to 128b/132b SST. >> >> v2:

[PATCH] drm/mst: remove mgr parameter and debug logging from drm_dp_get_vc_payload_bw()

2025-01-02 Thread Jani Nikula
The struct drm_dp_mst_topology_mgr *mgr parameter is only used for debug logging in case the passed in link rate or lane count are zero. There's no further error checking as such, and the function returns 0. There should be no case where the parameters are zero. The returned value is generally use

Re: [PATCH v2 11/16] drm/i915/ddi: initialize 128b/132b SST DP2 VFREQ registers

2025-01-02 Thread Jani Nikula
On Tue, 31 Dec 2024, Imre Deak wrote: > On Thu, Dec 19, 2024 at 11:34:00PM +0200, Jani Nikula wrote: >> Write the DP2 specific VFREQ registers. >> >> This is preparation for enabling 128b/132b SST. This path is not >> reachable yet. >> >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/i9

Re: [PATCH v1 3/4] drm/ls2kbmc: Add support for Loongson-2K BMC display

2025-01-02 Thread Thomas Zimmermann
Hi Am 30.12.24 um 10:31 schrieb Binbin Zhou: [...] + +static struct platform_driver ls2kbmc_platform_driver = { + .driver = { + .name = "ls2kbmc-framebuffer", The driver is mostly a copy of simpledrm. Why don't you use "simple-framebuffer" for your device name? You could

RE: ADV7511/13 implementing atomic ops and bus formats

2025-01-02 Thread Jesse Van Gavere
Hello Dmitry, ... > The atomic_check() function verifies if the passed set of changes (in the > form of drm_*_state) is valid from the driver's point of view. If you have > nothing to check, it's fine to skip the function. ... Perhaps one last question on the use of atomic_check, this functio

[PULL] drm-misc-fixes

2025-01-02 Thread Maarten Lankhorst
Hi Dave, Simona, Happy newyear! Cheers, ~Maarten drm-misc-fixes-2025-01-02: drm-misc-fixes for v6.13-rc6: - Only fixes for adv7511 driver, including a use-after-free. The following changes since commit 1b684ca15f9d78f45de3cdba7e19611387e16aa7: drm/sched: Fix drm_sched_fini() docu generation (

Re: [PATCH v3 1/4] drm: bridge: dw_hdmi: Add flag to indicate output port is optional

2025-01-02 Thread Laurent Pinchart
On Thu, Jan 02, 2025 at 05:26:50AM +0200, Dmitry Baryshkov wrote: > On Thu, Jan 02, 2025 at 12:36:20AM +0200, Laurent Pinchart wrote: > > On Tue, Dec 31, 2024 at 10:10:51PM +0100, Marek Vasut wrote: > > > On 12/31/24 9:31 PM, Laurent Pinchart wrote: > > > > Hi Marek, > > > > > > Hi, > > > > > > >

Re: [PATCH 1/2] dt-bindings: display: ti,am65x-dss: Add support for AM62L DSS

2025-01-02 Thread Krzysztof Kozlowski
On Tue, Dec 31, 2024 at 02:34:31PM +0530, Devarsh Thakkar wrote: > The DSS controller on TI's AM62L SoC is an update from that on TI's > AM625/AM65x/AM62A7 SoC. The AM62L DSS [1] only supports a single display > pipeline using a single overlay manager, single video port and a single > video lite pi