Re: [PATCH v4 00/16] drm/msm/dp: perform misc cleanups

2024-12-21 Thread Dmitry Baryshkov
On Mon, 16 Dec 2024 00:44:05 +0200, Dmitry Baryshkov wrote: > - Fix register programming in the dp_audio module > - Rework most of the register programming functions to be local to the > calling module rather than accessing everything through huge > dp_catalog monster. > > Applied, thanks!

Re: [PATCH v3 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-21 Thread Helge Deller
On 12/16/24 08:42, Thomas Zimmermann wrote: Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev core code and data structures. Make fbdev drivers depend on BACKLIGHT_CLASS_DEVICE and let users select it explicitly. Fixes warnings about

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-21 Thread Helge Deller
On 12/12/24 11:04, Thomas Zimmermann wrote: Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev core code and data structures. Make fbdev drivers depend on BACKLIGHT_CLASS_DEVICE and let users select it explicitly. Fixes warnings about

Re: [PATCH] fbdev: omapfb: Remove unused hdmi5_core_handle_irqs

2024-12-21 Thread Helge Deller
On 12/18/24 02:59, li...@treblig.org wrote: From: "Dr. David Alan Gilbert" hdmi5_core_handle_irqs() has been unused since commit f5bab2229190 ("OMAPDSS: HDMI: Add OMAP5 HDMI support") Remove it. Signed-off-by: Dr. David Alan Gilbert --- .../video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 17

Re: [PATCH] video: hdmi: Remove unused hdmi_infoframe_check

2024-12-21 Thread Helge Deller
On 12/17/24 02:38, li...@treblig.org wrote: From: "Dr. David Alan Gilbert" hdmi_infoframe_check() has been unused since it was added in commit c5e69ab35c0d ("video/hdmi: Constify infoframe passed to the pack functions") Remove it. Note that the individual check functions for each type are act

Re: [PATCH] fbdev/udlfb: Use const 'struct bin_attribute' callback

2024-12-21 Thread Helge Deller
On 12/15/24 15:55, Thomas Weißschuh wrote: The sysfs core now provides callback variants that explicitly take a const pointer. Make use of it to match the attribute definition. Signed-off-by: Thomas Weißschuh --- drivers/video/fbdev/udlfb.c | 8 1 file changed, 4 insertions(+), 4 de

Re: [PATCH] fbdev/radeon: Use const 'struct bin_attribute' callbacks

2024-12-21 Thread Helge Deller
On 12/15/24 15:58, Thomas Weißschuh wrote: The sysfs core now provides callback variants that explicitly take a const pointer. Make use of it to match the attribute definitions. Signed-off-by: Thomas Weißschuh --- drivers/video/fbdev/aty/radeon_base.c | 8 1 file changed, 4 insertio

[PATCH 1/6] drm/atomic-helper: document drm_atomic_helper_check() restrictions

2024-12-21 Thread Dmitry Baryshkov
The drm_atomic_helper_check() calls drm_atomic_helper_check_modeset() insternally. Document that corresponding restrictions also apply to the drivers that call the former function (as it's easy to miss the documentation for the latter function). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/dr

[PATCH 5/6] drm/msm/dpu: simplify dpu_encoder_get_topology() interface

2024-12-21 Thread Dmitry Baryshkov
As a preparation for calling dpu_encoder_get_topology() from different code paths, simplify its calling interface, obtaining some data pointers internally instead passing them via arguments. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 12 1 file

[PATCH 6/6] drm/msm/dpu: don't set crtc_state->mode_changed from atomic_check()

2024-12-21 Thread Dmitry Baryshkov
The MSM driver uses drm_atomic_helper_check() which mandates that none of the atomic_check() callbacks toggles crtc_state->mode_changed. Perform corresponding check before calling the drm_atomic_helper_check() function. Fixes: 8b45a26f2ba9 ("drm/msm/dpu: reserve cdm blocks for writeback in case of

[PATCH 4/6] drm/msm/dpu: move needs_cdm setting to dpu_encoder_get_topology()

2024-12-21 Thread Dmitry Baryshkov
As a preparation for calling dpu_encoder_get_topology() from different places, move the code setting topology->needs_cdm to that function (instead of patching topology separately). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 41 -

[PATCH 2/6] drm/atomic: prepare to check that drivers follow restrictions for needs_modeset

2024-12-21 Thread Dmitry Baryshkov
Some drivers might fail to follow the restrictions documented for drm_atomic_helper_check_modesets(). In order to catch such an issues, add the drm_atomic_state->dirty_needs_modeset field and check it in drm_atomic_check_only(). Make sure that neither of atomic_check() callbacks can set that field

[PATCH 3/6] drm/msm/dpu: don't use active in atomic_check()

2024-12-21 Thread Dmitry Baryshkov
The driver isn't supposed to consult crtc_state->active/active_check for resource allocation. Instead all resources should be allocated if crtc_state->enabled is set. Stop consulting active / active_changed in order to determine whether the hardware resources should be (re)allocated. Fixes: 25fdd5

[PATCH 0/6] drm: enforce rules for drm_atomic_helper_check_modeset()

2024-12-21 Thread Dmitry Baryshkov
As pointed out by Simona, the drm_atomic_helper_check_modeset() and drm_atomic_helper_check() require the former function is rerun if the driver's callbacks modify crtc_state->mode_changed. MSM is one of the drivers which failed to follow this requirement. As suggested by Simona, implement generic

Re: [PATCH] drm/atomic: clarify the rules around drm_atomic_state->allow_modeset

2024-12-21 Thread Dmitry Baryshkov
Hello, On Wed, 11 Oct 2023 at 12:20, Daniel Vetter wrote: > > msm is automagically upgrading normal commits to full modesets, and > that's a big no-no: > > - for one this results in full on->off->on transitions on all these > crtc, at least if you're using the usual helpers. Which seems to be >

Re: [RFC PATCH 3/3] drm/virtio: implement blob userptr resource object

2024-12-21 Thread Demi Marie Obenour
On 12/20/24 10:35 AM, Simona Vetter wrote: > On Fri, Dec 20, 2024 at 06:04:09PM +0800, Honglei Huang wrote: >> From: Honglei Huang >> >> A virtio-gpu userptr is based on HMM notifier. >> Used for let host access guest userspace memory and >> notice the change of userspace memory. >> This series pa

Re: [PATCH 0/3] drm/i915/gvt: Deadcoding

2024-12-21 Thread Dr. David Alan Gilbert
Note: zhen...@linux.intel.com's address bounces: > The following message to was undeliverable. > The reason for the problem: > 5.1.0 - Unknown address error 550-'5.1.1 : Recipient > address rejected: User unknown in +virtual mailbox table' * li...@treblig.org (li...@treblig.org) wrote: > From:

[PATCH 0/3] drm/i915/gvt: Deadcoding

2024-12-21 Thread linux
From: "Dr. David Alan Gilbert" Remove a bunch of long unused functions from the gvt code. Signed-off-by: Dr. David Alan Gilbert Dr. David Alan Gilbert (3): drm/i915/gvt: Remove intel_gvt_ggtt_h2g<->index drm/i915/gvt: Remove unused intel_vgpu_decode_sprite_plane drm/i915/gvt: Remove unu

[PATCH 3/3] drm/i915/gvt: Remove unused intel_gvt_in_force_nonpriv_whitelist

2024-12-21 Thread linux
From: "Dr. David Alan Gilbert" The last use of intel_gvt_in_force_nonpriv_whitelist() was removed in 2020 by commit 02dd2b12a685 ("drm/i915/gvt: unify lri cmd handler and mmio handlers") Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/i915/gvt/handlers.c | 17

[PATCH 1/3] drm/i915/gvt: Remove intel_gvt_ggtt_h2g<->index

2024-12-21 Thread linux
From: "Dr. David Alan Gilbert" intel_gvt_ggtt_h2g_index() and intel_gvt_ggtt_index_g2h() were added in 2016 by commit 2707e4446688 ("drm/i915/gvt: vGPU graphics memory virtualization") but haven't been used. Remove them. They were the only users of intel_gvt_ggtt_gmadr_g2h() and intel_gvt_ggtt_

[PATCH 2/3] drm/i915/gvt: Remove unused intel_vgpu_decode_sprite_plane

2024-12-21 Thread linux
From: "Dr. David Alan Gilbert" intel_vgpu_decode_sprite_plane() was added in 2017 by commit 9f31d1063b43 ("drm/i915/gvt: Add framebuffer decoder support") but has remained unused. Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/i915/gvt/fb_decoder.c | 117

Re: [PATCH] MAINTAINERS: Assume maintainership of PL111

2024-12-21 Thread Dmitry Baryshkov
On Sun, 22 Dec 2024 at 00:26, Linus Walleij wrote: > > On Fri, Dec 20, 2024 at 1:11 AM Dmitry Baryshkov > wrote: > > > Could you please convert it to use DRM_BRIDGE_ATTACH_NO_CONNECTOR? > > Likewise pl111_display_enable() should use the bus flags and input > > formats of the next bridge rather th

Re: [PATCH] MAINTAINERS: Assume maintainership of PL111

2024-12-21 Thread Linus Walleij
On Fri, Dec 20, 2024 at 1:11 AM Dmitry Baryshkov wrote: > Could you please convert it to use DRM_BRIDGE_ATTACH_NO_CONNECTOR? > Likewise pl111_display_enable() should use the bus flags and input > formats of the next bridge rather than the ones of the connector. I can surely look into it. Is ther

Re: [PATCH v3 07/33] dt-bindings: display: mediatek: Add binding for MT8195 HDMI-TX v2

2024-12-21 Thread Krzysztof Kozlowski
On 19/12/2024 11:54, AngeloGioacchino Del Regno wrote: >> hdmi@ >> >> Best regards, >> Krzysztof >> > > Thanks for the great review krzk. > > I was wondering if it'd be more straightforward to just send the bindings in a > different series, instead of sending another batch of 33 (actually, 34, >

[PATCH] drm/panel-edp: Add support for 2 panels

2024-12-21 Thread Langyan Ye
Add support for the following 2 panels: 1. B140UAN04.4 2. CXOT T9 The raw edid for B140UAN04.4 panel is: 00 ff ff ff ff ff ff 00 06 af b3 a7 00 00 00 00 0c 22 01 04 a5 1e 13 78 03 cb 55 91 57 5a 91 29 1c 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 f4 3c 80 b8 70 b0 24 40 10 10

Re: [PATCH v4 5/6] optee: FF-A: dynamic restricted memory allocation

2024-12-21 Thread kernel test robot
: fac04efc5c793dccbd07e2d59af9f90b7fc0dca4 patch link: https://lore.kernel.org/r/20241217100809.3962439-6-jens.wiklander%40linaro.org patch subject: [PATCH v4 5/6] optee: FF-A: dynamic restricted memory allocation config: arm64-randconfig-r112-20241221 (https://download.01.org/0day-ci/archive/20241221/202412211952.locc8lbo