Re: [PATCH v4 1/4] clk: sunxi-ng: a64: force select PLL_MIPI in TCON0 mux

2024-12-13 Thread Vasily Khoruzhick
On Fri, Dec 13, 2024 at 10:29 PM Vasily Khoruzhick wrote: > > On Thu, May 4, 2023 at 10:34 PM Roman Beranek wrote: > > > > TCON0's source clock can be fed from either PLL_MIPI, or PLL_VIDEO0(2X), > > however MIPI DSI output only seems to work when PLL_MIPI is selected and > > thus the choice must

[PATCH v2] drm/rockchip: Fix Copyright description

2024-12-13 Thread Andy Yan
From: Andy Yan The company name has update to Rockchip Electronics Co., Ltd. since 2021. And change Co.Ltd to Co., Ltd. to fix mail server warning: DBL_SPAM(6.50)[co.ltd:url]; Signed-off-by: Andy Yan Reviewed-by: Sebastian Reichel --- Changes in v2: - Fix an omitted file cdn-dp-core.h driv

Re: [PATCH v4 1/4] clk: sunxi-ng: a64: force select PLL_MIPI in TCON0 mux

2024-12-13 Thread Vasily Khoruzhick
On Thu, May 4, 2023 at 10:34 PM Roman Beranek wrote: > > TCON0's source clock can be fed from either PLL_MIPI, or PLL_VIDEO0(2X), > however MIPI DSI output only seems to work when PLL_MIPI is selected and > thus the choice must be hardcoded in. > > Currently, this driver can't propagate rate chang

Re: [PATCH v2 03/29] mm/migrate: Trylock device page in do_swap_page

2024-12-13 Thread Matthew Brost
On Fri, Dec 13, 2024 at 02:16:51PM -0800, Matthew Brost wrote: > On Fri, Nov 29, 2024 at 10:31:32AM +1100, Alistair Popple wrote: > > > > Matthew Brost writes: > > > > > Avoid multiple CPU page faults to the same device page racing by trying > > > to lock the page in do_swap_page before taking a

Re: [git pull] drm fixes for 6.13-rc3

2024-12-13 Thread pr-tracker-bot
The pull request you sent on Sat, 14 Dec 2024 07:23:44 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-12-14 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e72da82d5a6deec67a680434e1f19ba3996fbb11 Thank you! -- Deet-doot-dot, I am a bot. h

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-12-13 Thread Matthew Brost
On Fri, Nov 29, 2024 at 11:00:24AM +1100, Alistair Popple wrote: > > Matthew Brost writes: > > [...] > > > + * 3) Invalidation driver vfunc. > > + * > > + * void driver_invalidation(struct drm_gpusvm *gpusvm, > > + * struct drm_gpusvm_notifier *notifier, > > + *

Re: 6.13-rc1 graphics fail

2024-12-13 Thread Genes Lists
On Tue, 2024-12-03 at 06:34 -0500, Genes Lists wrote: > On Tue, 2024-12-03 at 11:16 +0200, Ville Syrjälä wrote: > > > ... > > > Probably https://gitlab.freedesktop.org/drm/i915/kernel/- > > /issues/13057 > > > Very helpful. > > I tested your patch set on Linus' tree commit > cdd30ebb1b9f36159d66

Re: [PATCH 7/7] accel/qaic: Add AIC200 support

2024-12-13 Thread Lizhi Hou
On 12/13/24 13:33, Jeffrey Hugo wrote: Add basic support for the new AIC200 product. The PCIe Device ID is 0xa110. With this, we can turn on the lights for AIC200 by leveraging much of the existing driver. Co-developed-by: Youssef Samir Signed-off-by: Youssef Samir Signed-off-by: Jeffrey Hug

Re: [PATCH 5/7] accel/qaic: Mask out SR-IOV PCI resources

2024-12-13 Thread Lizhi Hou
On 12/13/24 13:33, Jeffrey Hugo wrote: From: Youssef Samir During the initialization of the qaic device, pci_select_bars() is used to fetch a bitmask of the BARs exposed by the device. On devices that have Virtual Functions capabilities, the bitmask includes SR-IOV BARs. Use a mask to filter

Re: [PATCH 6/7] accel/qaic: Add config structs for supported cards

2024-12-13 Thread Lizhi Hou
On 12/13/24 13:33, Jeffrey Hugo wrote: As the number of cards supported by the driver grows, their configurations will differ. The driver needs to become more dynamic to support these configurations. Currently, each card may differ in the exposed BARs, the regions they map to, and the family.

Re: [PATCH 4/7] accel/qaic: Add support for MSI-X

2024-12-13 Thread Lizhi Hou
On 12/13/24 13:33, Jeffrey Hugo wrote: From: Youssef Samir AIC200 device will support MSI-X while AIC100 devices will keep using MSI. pci_alloc_irq_vectors() will try to allocate MSI-X vectors if it is supported by the target device, otherwise, it will fallback to MSI. Add support for MSI-X

Re: [PATCH v5 4/7] drm/msm: adreno: find bandwidth index of OPP and set it along freq index

2024-12-13 Thread Konrad Dybcio
On 13.12.2024 5:55 PM, Akhil P Oommen wrote: > On 12/13/2024 10:10 PM, neil.armstr...@linaro.org wrote: >> On 13/12/2024 17:31, Konrad Dybcio wrote: >>> On 13.12.2024 5:28 PM, neil.armstr...@linaro.org wrote: On 13/12/2024 16:37, Konrad Dybcio wrote: > On 13.12.2024 2:12 PM, Akhil P Oommen

Re: [PATCH 3/7] accel/qaic: Allocate an exact number of MSIs

2024-12-13 Thread Lizhi Hou
On 12/13/24 13:33, Jeffrey Hugo wrote: From: Youssef Samir Devices use 1 MSI vector for the MHI controller and as many vectors as the DMA bridge channels on the device. During the probing of the device, the driver allocates 32 MSI vectors, which is usually more than what is needed for AIC100

[PATCH V3 4/5] accel/amdxdna: Read firmware interface version from registers

2024-12-13 Thread Lizhi Hou
The latest released firmware supports reading firmware interface version from registers directly. The driver's probe routine reads the major and minor version numbers. If the firmware interface is not compatible with the driver, the driver's probe routine returns failure. Co-developed-by: Min Ma

[PATCH V3 3/5] accel/amdxdna: Enhance power management settings

2024-12-13 Thread Lizhi Hou
Add SET_STATE ioctl to configure device power mode for aie2 device. Three modes are supported initially. POWER_MODE_DEFAULT: Enable clock gating and set DPM (Dynamic Power Management) level to value which has been set by resource solver or maximum DPM level the device supports. POWER_MODE_HIGH: E

[PATCH V3 2/5] accel/amdxdna: Replace idr api with xarray

2024-12-13 Thread Lizhi Hou
Switch mailbox message id and hardware context id management over from the idr api to the xarray api. Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/TODO | 1 - drivers/accel/amdxdna/aie2_ctx.c| 5 ++- drivers/accel/amdxdna/aie2_message.c| 5 ++- drivers/accel/amd

[PATCH V3 5/5] accel/amdxdna: Add zero check for pad in ioctl input structures

2024-12-13 Thread Lizhi Hou
For input structures, it is better to check if the pad is zero. Thus, the pad bytes might be usable in the future. Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/aie2_ctx.c | 3 +++ drivers/accel/amdxdna/aie2_message.c | 3 +++ drivers/accel/amdxdna/amdxdna_ctx.c | 6 ++ drivers/

[PATCH V3 1/5] accel/amdxdna: Add RyzenAI-npu6 support

2024-12-13 Thread Lizhi Hou
Add NPU6 registers and other private configurations. Co-developed-by: Xiaoming Ren Signed-off-by: Xiaoming Ren Reviewed-by: Mario Limonciello Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/Makefile | 3 +- drivers/accel/amdxdna/amdxdna_pci_drv.c | 1 + drivers/accel/amdxdna/a

[PATCH V3 0/5] AMD NPU driver improvements

2024-12-13 Thread Lizhi Hou
Add recent improvements and bug fixes for amdxdna driver (depends on [1]) 1. Support recent hardware and firmware. 2. Replace idr APIs with xarray. 3. Fix the bugs been found. [1]: https://lore.kernel.org/all/20241118172942.2014541-1-lizhi@amd.com/ Changes since v2: - Remove merged patches fr

Re: [PATCH v1 1/5] dt-bindings: display: tegra: Add actmon information

2024-12-13 Thread Johnny Liu
> On Tue, Dec 10, 2024 at 09:45:50AM -0800, Johnny Liu wrote: > > An activity monitor (actmon) is used to measure the device runtime > > utilization to help drive software power management policies. > > > > Extend the reg space to include actmon aperture for actmon configuration > > through host1x.

Re: [PATCH v1 0/5] Support host1x actmon

2024-12-13 Thread Johnny Liu
> On Tue, Dec 10, 2024 at 09:45:49AM -0800, Johnny Liu wrote: > > Activity monitoring (actmon for short) is a means to dynamically > > measure the utilization of units in the system to help drive software > > power management policies. > > > > Is this a resend or v2? Please always mark your patches

Re: [PATCH v2 03/29] mm/migrate: Trylock device page in do_swap_page

2024-12-13 Thread Matthew Brost
On Fri, Nov 29, 2024 at 10:31:32AM +1100, Alistair Popple wrote: > > Matthew Brost writes: > > > Avoid multiple CPU page faults to the same device page racing by trying > > to lock the page in do_swap_page before taking an extra reference to the > > page. This prevents scenarios where multiple C

[PATCH 35/35] drm/msm/dpu: move features out of the DPU_HW_BLK_INFO

2024-12-13 Thread Dmitry Baryshkov
Only SSPP, WB and VBIF still have feature bits remaining, all other hardware blocks don't have feature bits anymore. Remove the 'features' from the DPU_HW_BLK_INFO so that it doesn't get included into hw info structures by default and only include it when necessary. Signed-off-by: Dmitry Baryshkov

[PATCH 32/35] drm/msm/dpu: get rid of DPU_MIXER_SOURCESPLIT

2024-12-13 Thread Dmitry Baryshkov
Continue cleanup of the feature flags and replace the last remaining LM feature with a bitfield flag, simplifying corresponding data structures and access. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_10_0_sm8650.h | 12 ++-- drivers/gpu/drm/msm/disp/dpu

[PATCH 33/35] drm/msm/dpu: get rid of DPU_DSC_NATIVE_42x_EN

2024-12-13 Thread Dmitry Baryshkov
Continue cleanup of the feature flags and replace the last remaining LM feature with a bitfield flag, simplifying corresponding data structures and access. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_10_0_sm8650.h | 8 drivers/gpu/drm/msm/disp/dpu1/ca

[PATCH 34/35] drm/msm/dpu: get rid of DPU_CTL_SPLIT_DISPLAY

2024-12-13 Thread Dmitry Baryshkov
Continue cleanup of the feature flags and replace the last remaining CTL feature with a bitfield flag, simplifying corresponding data structures and access. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_10_0_sm8650.h | 6 +++--- drivers/gpu/drm/msm/disp/dpu1/cat

[PATCH 31/35] drm/msm/dpu: drop ununused MIXER features

2024-12-13 Thread Dmitry Baryshkov
Drop unused LM features from the current codebase. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw

[PATCH 26/35] drm/msm/dpu: get rid of DPU_DSC_OUTPUT_CTRL

2024-12-13 Thread Dmitry Baryshkov
Continue migration to the MDSS-revision based checks and replace DPU_DSC_OUTPUT_CTRL feature bit with the core_major_ver >= 5 check. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_0_sm8150.h | 4 drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h | 6 -

[PATCH 29/35] drm/msm/dpu: drop unused MDP TOP features

2024-12-13 Thread Dmitry Baryshkov
Drop unused MDP TOP features from the current codebase. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cata

[PATCH 30/35] drm/msm/dpu: drop ununused PINGPONG features

2024-12-13 Thread Dmitry Baryshkov
The DPU_PINGPONG_TE2 is unused by the current code (and can further be replaced by the checking for the te2 sblk presense). Other feature bits are completely unused. Drop them from the current codebase. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_7_msm8996.h |

[PATCH 28/35] drm/msm/dpu: get rid of DPU_SSPP_QOS_8LVL

2024-12-13 Thread Dmitry Baryshkov
Continue migration to the MDSS-revision based checks and replace DPU_SSPP_QOS_8LVL feature bit with the core_major_ver >= 4 check. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 6 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 2 -- drivers/gpu/drm

[PATCH 24/35] drm/msm/dpu: get rid of DPU_DIM_LAYER

2024-12-13 Thread Dmitry Baryshkov
Continue migration to the MDSS-revision based checks and drop the DPU_DIM_LAYER feature bit. It is currently unused, but can be replaed with the core_major_ver >= 4 check. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_4_sm6125.h | 2 -- drivers/gpu/drm/msm/disp

[PATCH 27/35] drm/msm/dpu: get rid of DPU_WB_INPUT_CTRL

2024-12-13 Thread Dmitry Baryshkov
Continue migration to the MDSS-revision based checks and replace DPU_WB_INPUT_CTRL feature bit with the core_major_ver >= 5 check. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_10_0_sm8650.h | 2 +- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_0_sm8150.h | 2 +-

[PATCH 22/35] drm/msm/dpu: get rid of DPU_MDP_AUDIO_SELECT

2024-12-13 Thread Dmitry Baryshkov
Continue migration to the MDSS-revision based checks and replace DPU_MDP_AUDIO_SELECT feature bit with the core_major_ver == 8 || core_major_ver == 5 check. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_4_0_sdm845.h | 1 - drivers/gpu/drm/msm/disp/dpu1/catalog/dp

[PATCH 25/35] drm/msm/dpu: get rid of DPU_DSC_HW_REV_1_2

2024-12-13 Thread Dmitry Baryshkov
Continue migration to the MDSS-revision based checks and replace DPU_DSC_HW_REV_1_2 feature bit with the core_major_ver >= 7 check. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_10_0_sm8650.h | 10 -- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_7_0_sm8350.h

[PATCH 15/35] drm/msm/dpu: get rid of DPU_DATA_HCTL_EN

2024-12-13 Thread Dmitry Baryshkov
Continue migration to the MDSS-revision based checks and replace DPU_DATA_HCTL_EN feature bit with the core_major_ver >= 5 check. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 3 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 3 --- drivers/gpu/drm/ms

[PATCH 23/35] drm/msm/dpu: get rid of DPU_MIXER_COMBINED_ALPHA

2024-12-13 Thread Dmitry Baryshkov
Continue migration to the MDSS-revision based checks and replace DPU_MIXER_COMBINED_ALPHA feature bit with the core_major_ver >= 4 check. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 4 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 2 -- drivers/gp

[PATCH 13/35] drm/msm/dpu: get rid of DPU_CTL_DSPP_SUB_BLOCK_FLUSH

2024-12-13 Thread Dmitry Baryshkov
Continue migration to the MDSS-revision based checks and replace DPU_CTL_DSPP_SUB_BLOCK_FLUSH feature bit with the core_major_ver >= 7 check. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 3 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 2 -- drivers

[PATCH 17/35] drm/msm/dpu: get rid of DPU_INTF_INPUT_CTRL

2024-12-13 Thread Dmitry Baryshkov
Continue migration to the MDSS-revision based checks and replace DPU_INTF_INPUT_CTRL feature bit with the core_major_ver >= 5 check. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_10_0_sm8650.h | 4 drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_0_sm8150.h |

[PATCH 21/35] drm/msm/dpu: get rid of DPU_MDP_PERIPH_0_REMOVED

2024-12-13 Thread Dmitry Baryshkov
Continue migration to the MDSS-revision based checks and replace DPU_MDP_PERIPH_0_REMOVED feature bit with the core_major_ver >= 8 check. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_10_0_sm8650.h | 1 - drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h |

[PATCH 20/35] drm/msm/dpu: get rid of DPU_MDP_VSYNC_SEL

2024-12-13 Thread Dmitry Baryshkov
Continue migration to the MDSS-revision based checks and replace DPU_MDP_VSYNC_SEL feature bit with the core_major_ver < 5 check. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_14_msm8937.h | 1 - drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_15_msm8917.h | 1 - dr

[PATCH 19/35] drm/msm/dpu: get rid of DPU_PINGPONG_DITHER

2024-12-13 Thread Dmitry Baryshkov
Continue migration to the MDSS-revision based checks and replace DPU_PINGPONG_DITHER feature bit with the core_major_ver >= 3 check. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_10_0_sm8650.h | 10 -- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998

[PATCH 18/35] drm/msm/dpu: get rid of DPU_PINGPONG_DSC

2024-12-13 Thread Dmitry Baryshkov
Continue migration to the MDSS-revision based checks and replace DPU_PINGPONG_DSC feature bit with the core_major_ver < 7 check. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_14_msm8937.h | 2 -- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_15_msm8917.h | 1 -

[PATCH 16/35] drm/msm/dpu: get rid of DPU_INTF_STATUS_SUPPORTED

2024-12-13 Thread Dmitry Baryshkov
Continue migration to the MDSS-revision based checks and replace DPU_INTF_STATUS_SUPPORTED feature bit with the core_major_ver >= 5 check. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 3 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 2 -- drivers/gp

[PATCH 14/35] drm/msm/dpu: get rid of DPU_CTL_VM_CFG

2024-12-13 Thread Dmitry Baryshkov
Continue migration to the MDSS-revision based checks and replace DPU_CTL_VM_CFG feature bit with the core_major_ver >= 7 check. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_10_0_sm8650.h | 8 ++-- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_7_0_sm8350.h | 8

[PATCH 04/35] drm/msm/dpu: drop INTF_SC7280_MASK

2024-12-13 Thread Dmitry Baryshkov
The INTF_SC7280_MASK is equal to the INTF_SC7180_MASK. Stop defining a separate symbol and use the INTF_SC7180_MASK instead. Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/catalog/dpu_10_0_sm8650.h| 8 drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_7_0_sm8350.h | 8 -

[PATCH 12/35] drm/msm/dpu: get rid of DPU_CTL_FETCH_ACTIVE

2024-12-13 Thread Dmitry Baryshkov
Continue migration to the MDSS-revision based checks and replace DPU_CTL_FETCH_ACTIVE feature bit with the core_major_ver >= 7 check. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 3 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 2 -- drivers/gpu/drm

[PATCH 10/35] drm/msm/dpu: get rid of DPU_CTL_HAS_LAYER_EXT4

2024-12-13 Thread Dmitry Baryshkov
Continue migration to the MDSS-revision based checks and replace DPU_CTL_HAS_LAYER_EXT4 feature bit with the core_major_ver >= 9 check. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_10_0_sm8650.h | 12 ++-- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_0_sm

[PATCH 11/35] drm/msm/dpu: get rid of DPU_CTL_ACTIVE_CFG

2024-12-13 Thread Dmitry Baryshkov
Continue migration to the MDSS-revision based checks and replace DPU_CTL_ACTIVE_CFG feature bit with the core_major_ver >= 5 check. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_0_sm8150.h | 8 ++-- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h |

[PATCH 09/35] drm/msm/dpu: remove DSPP_SC7180_MASK

2024-12-13 Thread Dmitry Baryshkov
Stop declaring DPU_DSPP_PCC as a part of the DSPP features, use the presence of the PCC sblk to check whether PCC is present in the hardware or not. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_10_0_sm8650.h | 4 drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_

[PATCH 08/35] drm/msm/dpu: inline _setup_mixer_ops()

2024-12-13 Thread Dmitry Baryshkov
Inline the _setup_mixer_ops() function, it makes it easier to handle different conditions involving LM configuration. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 24 +--- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/driver

[PATCH 07/35] drm/msm/dpu: inline _setup_dspp_ops()

2024-12-13 Thread Dmitry Baryshkov
Inline the _setup_dspp_ops() function, it makes it easier to handle different conditions involving DSPP configuration. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/ms

[PATCH 05/35] drm/msm/dpu: inline _setup_ctl_ops()

2024-12-13 Thread Dmitry Baryshkov
Inline the _setup_ctl_ops() function, it makes it easier to handle different conditions involving CTL configuration. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 96 ++ 1 file changed, 46 insertions(+), 50 deletions(-) diff --git a

[PATCH 06/35] drm/msm/dpu: inline _setup_dsc_ops()

2024-12-13 Thread Dmitry Baryshkov
Inline the _setup_dsc_ops() function, it makes it easier to handle different conditions involving DSC configuration. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/d

[PATCH 03/35] drm/msm/dpu: stop passing mdss_ver to setup_timing_gen()

2024-12-13 Thread Dmitry Baryshkov
As a preparation to further MDSS-revision cleanups stop passing MDSS revision to the setup_timing_gen() callback. Instead store a pointer to it inside struct dpu_hw_intf and use it diretly. It's not that the MDSS revision can chance between dpu_hw_intf_init() and dpu_encoder_phys_vid_setup_timing_e

[PATCH 01/35] drm/msm/dpu: skip watchdog timer programming through TOP on >= SM8450

2024-12-13 Thread Dmitry Baryshkov
The SM8450 and later chips have DPU_MDP_PERIPH_0_REMOVED feature bit set, which means that those platforms have dropped some of the registers, including the WD TIMER-related ones. Stop providing the callback to program WD timer on those platforms. Fixes: 100d7ef6995d ("drm/msm/dpu: add support for

[PATCH 02/35] drm/msm/dpu: enable DPU_WB_INPUT_CTRL for DPU 5.x

2024-12-13 Thread Dmitry Baryshkov
Several DPU 5.x platforms are supposed to be using DPU_WB_INPUT_CTRL, to bind WB and PINGPONG blocks, but they do not. Change those platforms to use WB_SM8250_MASK, which includes that bit. Fixes: 1f5bcc4316b3 ("drm/msm/dpu: enable writeback on SC8108X") Fixes: ab2b03d73a66 ("drm/msm/dpu: enable w

[PATCH 00/35] drm/msm/dpu: rework HW block feature handling

2024-12-13 Thread Dmitry Baryshkov
| 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c| 4 +- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 17 ++- 50 files changed, 295 insertions(+), 836 deletions(-) --- base-commit: 789384eb1437aed94155dc0eac8a8a6ba1baf578 change-id: 20241213-dpu-drop-features-7603dc3ee1

[PATCH 5/7] accel/qaic: Mask out SR-IOV PCI resources

2024-12-13 Thread Jeffrey Hugo
From: Youssef Samir During the initialization of the qaic device, pci_select_bars() is used to fetch a bitmask of the BARs exposed by the device. On devices that have Virtual Functions capabilities, the bitmask includes SR-IOV BARs. Use a mask to filter out SR-IOV BARs if they exist. Signed-off

[PATCH 1/7] bus: mhi: host: Refactor BHI/BHIe based firmware loading

2024-12-13 Thread Jeffrey Hugo
From: Matthew Leung Refactor the firmware loading code to have distinct helper functions for BHI and BHIe operations. This lays the foundation for separating the firmware loading protocol from the firmware being loaded and the EE it is loaded in. Signed-off-by: Matthew Leung Reviewed-by: Yousse

[PATCH 7/7] accel/qaic: Add AIC200 support

2024-12-13 Thread Jeffrey Hugo
Add basic support for the new AIC200 product. The PCIe Device ID is 0xa110. With this, we can turn on the lights for AIC200 by leveraging much of the existing driver. Co-developed-by: Youssef Samir Signed-off-by: Youssef Samir Signed-off-by: Jeffrey Hugo --- drivers/accel/qaic/mhi_controller.c

[PATCH 6/7] accel/qaic: Add config structs for supported cards

2024-12-13 Thread Jeffrey Hugo
As the number of cards supported by the driver grows, their configurations will differ. The driver needs to become more dynamic to support these configurations. Currently, each card may differ in the exposed BARs, the regions they map to, and the family. Create config structs for each card, and le

[PATCH 4/7] accel/qaic: Add support for MSI-X

2024-12-13 Thread Jeffrey Hugo
From: Youssef Samir AIC200 device will support MSI-X while AIC100 devices will keep using MSI. pci_alloc_irq_vectors() will try to allocate MSI-X vectors if it is supported by the target device, otherwise, it will fallback to MSI. Add support for MSI-X vectors allocation for AIC200 devices. Sig

[PATCH 3/7] accel/qaic: Allocate an exact number of MSIs

2024-12-13 Thread Jeffrey Hugo
From: Youssef Samir Devices use 1 MSI vector for the MHI controller and as many vectors as the DMA bridge channels on the device. During the probing of the device, the driver allocates 32 MSI vectors, which is usually more than what is needed for AIC100 devices, which is wasting resources. Alloc

[PATCH 0/7] accel/qaic: Initial AIC200 support

2024-12-13 Thread Jeffrey Hugo
Initial support to the driver to boot up AIC200. AIC200 uses BHIe without BHI, which is something that the MHI bus has not supported until now. While the MHI changes are listed first to facilitate cross-tree merging, they are not needed until the last change in the series. Also, AIC200 is a differ

[PATCH 2/7] bus: mhi: host: Add a policy to enable image transfer via BHIe in PBL

2024-12-13 Thread Jeffrey Hugo
From: Matthew Leung Currently, mhi host only performs firmware transfer via BHI in PBL and BHIe from SBL. To support BHIe transfer directly from PBL, a policy needs to be added. With this policy, BHIe will be used to transfer firmware in PBL if the mhi controller has bhie regs, sets seg_len, and

[git pull] drm fixes for 6.13-rc3

2024-12-13 Thread Dave Airlie
Hi Linus, This is the weekly fixes pull for drm. Just has i915, xe and amdgpu changes in it, the misc tree didn't get a PR to me this week (cc'ed), so next week might have a larger set of changes, otherwise nothing too major in here. Regards, Dave. drm-fixes-2024-12-14: drm fixes for 6.13-rc3

Re: [PATCH] drm/msm/dpu: Filter modes based on adjusted mode clock

2024-12-13 Thread Dmitry Baryshkov
On Fri, 13 Dec 2024 at 21:15, Abhinav Kumar wrote: > > > > On 12/12/2024 5:05 PM, Dmitry Baryshkov wrote: > > On Thu, Dec 12, 2024 at 11:11:54AM -0800, Jessica Zhang wrote: > >> Filter out modes that have a clock rate greater than the max core clock > >> rate when adjusted for the perf clock facto

Re: [PATCH] drm/ci: add kms_cursor_legacy@torture-bo to apq8016 flakes

2024-12-13 Thread Abhinav Kumar
Hi Vignesh On 12/11/2024 9:10 PM, Vignesh Raman wrote: Hi Abhinav / Helen, On 12/12/24 01:48, Abhinav Kumar wrote: Hi Helen / Vignesh On 12/4/2024 12:33 PM, Helen Mae Koike Fornazier wrote: On Wed, 04 Dec 2024 16:21:26 -0300 Abhinav Kumar  wrote ---   > Hi Helen   >   > On 12/4/202

Re: [PATCH 14/26] drm/xe/eudebug: implement userptr_vma access

2024-12-13 Thread Matthew Brost
On Thu, Dec 12, 2024 at 11:12:39AM +0100, Simona Vetter wrote: > On Thu, Dec 12, 2024 at 09:49:24AM +0100, Thomas Hellström wrote: > > On Mon, 2024-12-09 at 16:31 +0100, Simona Vetter wrote: > > > On Mon, Dec 09, 2024 at 03:03:04PM +0100, Christian König wrote: > > > > Am 09.12.24 um 14:33 schrieb

Re: [PATCH] drm/msm/dpu: Filter modes based on adjusted mode clock

2024-12-13 Thread Abhinav Kumar
On 12/12/2024 5:05 PM, Dmitry Baryshkov wrote: On Thu, Dec 12, 2024 at 11:11:54AM -0800, Jessica Zhang wrote: Filter out modes that have a clock rate greater than the max core clock rate when adjusted for the perf clock factor This is especially important for chipsets such as QCS615 that hav

[PATCH] drm/i915/selftests: Use preemption timeout on cleanup

2024-12-13 Thread Janusz Krzysztofik
Many selftests call igt_flush_test() on cleanup. With default preemption timeout of compute engines raised to 7.5 seconds, hardcoded flush timeout of 3 seconds is too short. That results in GPU forcibly wedged and kernel taineted, then IGT abort triggered. CI BAT runs loose a part of their expec

[PATCH] accel/qaic: Change aic100_image_table definition

2024-12-13 Thread Jeffrey Hugo
From: Youssef Samir aic100_image_table is currently defined as a "const char *" array, this can potentially lead to the accidental modification of the pointers inside. Also, checkpatch.pl gives a warning about it. Change the type to a "const char * const" array to make the pointers immutable, pr

[PATCH] drm: add modifiers for MediaTek tiled formats

2024-12-13 Thread eric . smith
From: "Eric R. Smith" MediaTek (MTK) uses some unique tiled memory formats for video decoding. Add these to the uapi drm_fourcc.h so that we can use them in Mesa, GStreamer, and other tools/libraries. Signed-off-by: Eric R. Smith --- include/uapi/drm/drm_fourcc.h | 31 +

Re: [PATCH v5 05/18] drm/rockchip: vop2: Set AXI id for rk3588

2024-12-13 Thread Detlev Casanova
On Thursday, 12 December 2024 02:52:34 EST Andy Yan wrote: > Hi Detlev, > > At 2024-12-11 23:45:01, "Detlev Casanova" wrote: > >On Wednesday, 11 December 2024 01:34:34 EST Andy Yan wrote: > >> Hi Detlev, > >> > >> At 2024-12-11 02:40:14, "Detlev Casanova" > > > >wrote: > >> >Hi Andy, > >> > >

Re: [PATCH 1/2] accel/amdxdna: use modern PM helpers

2024-12-13 Thread Jeffrey Hugo
On 12/13/2024 10:57 AM, Lizhi Hou wrote: On 12/13/24 09:49, Jeffrey Hugo wrote: On 12/13/2024 10:41 AM, Lizhi Hou wrote: On 12/13/24 09:07, Jeffrey Hugo wrote: On 12/13/2024 2:02 AM, Arnd Bergmann wrote: From: Arnd Bergmann The old SET_SYSTEM_SLEEP_PM_OPS and SET_RUNTIME_PM_OPS macros cau

Re: [PATCH 1/2] accel/amdxdna: use modern PM helpers

2024-12-13 Thread Lizhi Hou
On 12/13/24 09:49, Jeffrey Hugo wrote: On 12/13/2024 10:41 AM, Lizhi Hou wrote: On 12/13/24 09:07, Jeffrey Hugo wrote: On 12/13/2024 2:02 AM, Arnd Bergmann wrote: From: Arnd Bergmann The old SET_SYSTEM_SLEEP_PM_OPS and SET_RUNTIME_PM_OPS macros cause a build warning when CONFIG_PM is di

Re: [RFC] drm/msm: Add UABI to request perfcntr usage

2024-12-13 Thread Rob Clark
On Fri, Dec 13, 2024 at 8:47 AM Akhil P Oommen wrote: > > On 12/12/2024 10:42 PM, Rob Clark wrote: > > On Thu, Dec 12, 2024 at 9:08 AM Rob Clark wrote: > >> > >> On Thu, Dec 12, 2024 at 7:59 AM Akhil P Oommen > >> wrote: > >>> > >>> On 12/5/2024 10:24 PM, Rob Clark wrote: > From: Rob Clark

Re: [PATCH 1/2] accel/amdxdna: use modern PM helpers

2024-12-13 Thread Jeffrey Hugo
On 12/13/2024 10:41 AM, Lizhi Hou wrote: On 12/13/24 09:07, Jeffrey Hugo wrote: On 12/13/2024 2:02 AM, Arnd Bergmann wrote: From: Arnd Bergmann The old SET_SYSTEM_SLEEP_PM_OPS and SET_RUNTIME_PM_OPS macros cause a build warning when CONFIG_PM is disabled: drivers/accel/amdxdna/amdxdna_pci

Re: [PATCH 1/2] accel/amdxdna: use modern PM helpers

2024-12-13 Thread Lizhi Hou
On 12/13/24 09:07, Jeffrey Hugo wrote: On 12/13/2024 2:02 AM, Arnd Bergmann wrote: From: Arnd Bergmann The old SET_SYSTEM_SLEEP_PM_OPS and SET_RUNTIME_PM_OPS macros cause a build warning when CONFIG_PM is disabled: drivers/accel/amdxdna/amdxdna_pci_drv.c:343:12: error: 'amdxdna_pmops_res

Re: [PATCH V2 6/8] accel/amdxdna: Enhance power management settings

2024-12-13 Thread Lizhi Hou
On 12/13/24 08:55, Jeffrey Hugo wrote: On 12/6/2024 2:59 PM, Lizhi Hou wrote: +/** + * struct amdxdna_drm_get_power_mode - Get the configured power mode + * @power_mode: The mode type from enum amdxdna_power_mode_type + * @pad: MBZ. I don't see a check for zero in the implementation We discu

Re: [PATCH v3] drm: Drop explicit initialization of struct i2c_device_id::driver_data to 0

2024-12-13 Thread Doug Anderson
Hi, On Wed, Dec 4, 2024 at 2:58 AM Uwe Kleine-König wrote: > > These drivers don't use the driver_data member of struct i2c_device_id, > so don't explicitly initialize this member. > > This prepares putting driver_data in an anonymous union which requires > either no initialization or named desig

Re: [PATCH V2 7/8] accel/amdxdna: Read firmware interface version from registers

2024-12-13 Thread Jeffrey Hugo
On 12/13/2024 10:02 AM, Lizhi Hou wrote: On 12/13/24 08:58, Jeffrey Hugo wrote: On 12/6/2024 3:00 PM, Lizhi Hou wrote: The latest released firmware supports reading firmware interface version from registers directly. The driver's probe routine reads the major and minor version numbers. If the

Re: [PATCH] accel/amdxdna: Add include interrupt.h to amdxdna_mailbox.c

2024-12-13 Thread Jeffrey Hugo
On 12/13/2024 9:38 AM, Lizhi Hou wrote: From: Mike Lothian For amdxdna_mailbox.c, linux/interrupt.h is indirectly included by trace/events/amdxdna.h. So if TRACING is disabled, driver compiling will fail. Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox") Reported-by: Mike Lothian

Re: [PATCH 1/7] vsprintf: Add %pTN to print task name

2024-12-13 Thread Andy Shevchenko
On Fri, Dec 13, 2024 at 02:27:09PM +0100, Borislav Petkov wrote: > On Fri, Dec 13, 2024 at 10:35:03AM +0200, Kalle Valo wrote: > > I agree, it makes the code harder to read for someone who is not > > familiar with all the %p magic we have (like me). > +1 And me too. In case one thinks of unprinta

Re: [PATCH 2/2] accel/amdxdna: add missing includes

2024-12-13 Thread Jeffrey Hugo
On 12/13/2024 2:02 AM, Arnd Bergmann wrote: From: Arnd Bergmann This driver fails to build in random configurations: drivers/accel/amdxdna/amdxdna_mailbox.c:357:8: error: unknown type name 'irqreturn_t' 357 | static irqreturn_t mailbox_irq_handler(int irq, void *p) |^~~~

Re: [RFC] drm/msm: Add UABI to request perfcntr usage

2024-12-13 Thread Antonino Maniscalco
On 12/13/24 5:50 PM, Akhil P Oommen wrote: On 12/12/2024 9:44 PM, Antonino Maniscalco wrote: On 12/12/24 4:58 PM, Akhil P Oommen wrote: On 12/5/2024 10:24 PM, Rob Clark wrote: From: Rob Clark Performance counter usage falls into two categories: 1. Local usage, where the counter configuratio

Re: [PATCH 1/2] accel/amdxdna: use modern PM helpers

2024-12-13 Thread Jeffrey Hugo
On 12/13/2024 2:02 AM, Arnd Bergmann wrote: From: Arnd Bergmann The old SET_SYSTEM_SLEEP_PM_OPS and SET_RUNTIME_PM_OPS macros cause a build warning when CONFIG_PM is disabled: drivers/accel/amdxdna/amdxdna_pci_drv.c:343:12: error: 'amdxdna_pmops_resume' defined but not used [-Werror=unused-fu

Re: [PATCH] accel/amdxdna: Add include interrupt.h to amdxdna_mailbox.c

2024-12-13 Thread Jeffrey Hugo
On 12/13/2024 9:38 AM, Lizhi Hou wrote: From: Mike Lothian For amdxdna_mailbox.c, linux/interrupt.h is indirectly included by trace/events/amdxdna.h. So if TRACING is disabled, driver compiling will fail. Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox") Reported-by: Mike Lothian

Re: [PATCH V2 7/8] accel/amdxdna: Read firmware interface version from registers

2024-12-13 Thread Lizhi Hou
On 12/13/24 08:58, Jeffrey Hugo wrote: On 12/6/2024 3:00 PM, Lizhi Hou wrote: The latest released firmware supports reading firmware interface version from registers directly. The driver's probe routine reads the major and minor version numbers. If the firmware interface does not compatible w

Re: [PATCH V2 0/8] AMD NPU driver improvements

2024-12-13 Thread Jeffrey Hugo
On 12/6/2024 2:59 PM, Lizhi Hou wrote: Add recent improvements and bug fixes for amdxdna driver (depends on [1]) 1. Support recent hardware and firmware. 2. Replace idr APIs with xarray. 3. Fix the bugs been found. [1]: https://lore.kernel.org/all/20241118172942.2014541-1-lizhi@amd.com/ Cha

Re: [PATCH V2 7/8] accel/amdxdna: Read firmware interface version from registers

2024-12-13 Thread Jeffrey Hugo
On 12/6/2024 3:00 PM, Lizhi Hou wrote: The latest released firmware supports reading firmware interface version from registers directly. The driver's probe routine reads the major and minor version numbers. If the firmware interface does not compatible with the driver, the driver's probe routine

Re: [PATCH V2 6/8] accel/amdxdna: Enhance power management settings

2024-12-13 Thread Jeffrey Hugo
On 12/6/2024 2:59 PM, Lizhi Hou wrote: +/** + * struct amdxdna_drm_get_power_mode - Get the configured power mode + * @power_mode: The mode type from enum amdxdna_power_mode_type + * @pad: MBZ. I don't see a check for zero in the implementation + */ +struct amdxdna_drm_get_power_mode { +

Re: [PATCH v5 4/7] drm/msm: adreno: find bandwidth index of OPP and set it along freq index

2024-12-13 Thread Akhil P Oommen
On 12/13/2024 10:10 PM, neil.armstr...@linaro.org wrote: > On 13/12/2024 17:31, Konrad Dybcio wrote: >> On 13.12.2024 5:28 PM, neil.armstr...@linaro.org wrote: >>> On 13/12/2024 16:37, Konrad Dybcio wrote: On 13.12.2024 2:12 PM, Akhil P Oommen wrote: > On 12/13/2024 3:07 AM, Neil Armstrong

Re: [PATCH V2 4/8] accel/amdxdna: Replace idr api with xarray

2024-12-13 Thread Lizhi Hou
On 12/13/24 08:42, Jeffrey Hugo wrote: On 12/6/2024 2:59 PM, Lizhi Hou wrote: Switch mailbox message id and hardware context id management over from the idr api to the xarray api. Signed-off-by: Lizhi Hou Implementation looks sane, however you appear to be missing several instances of #in

Re: [RFC] drm/msm: Add UABI to request perfcntr usage

2024-12-13 Thread Akhil P Oommen
On 12/12/2024 9:44 PM, Antonino Maniscalco wrote: > On 12/12/24 4:58 PM, Akhil P Oommen wrote: >> On 12/5/2024 10:24 PM, Rob Clark wrote: >>> From: Rob Clark >>> >>> Performance counter usage falls into two categories: >>> >>> 1. Local usage, where the counter configuration, start, and end read >>

Re: [PATCH V2 5/8] accel/amdxdna: Add query firmware version

2024-12-13 Thread Jeffrey Hugo
On 12/6/2024 2:59 PM, Lizhi Hou wrote: Enhance GET_INFO ioctl to support retrieving firmware version. Signed-off-by: Lizhi Hou Reviewed-by: Jeffrey Hugo Warning below through. enum amdxdna_drm_get_param { DRM_AMDXDNA_QUERY_AIE_STATUS, DRM_AMDXDNA_QUERY_AIE_METADATA, @@ -

Re: [RFC] drm/msm: Add UABI to request perfcntr usage

2024-12-13 Thread Akhil P Oommen
On 12/12/2024 10:42 PM, Rob Clark wrote: > On Thu, Dec 12, 2024 at 9:08 AM Rob Clark wrote: >> >> On Thu, Dec 12, 2024 at 7:59 AM Akhil P Oommen >> wrote: >>> >>> On 12/5/2024 10:24 PM, Rob Clark wrote: From: Rob Clark Performance counter usage falls into two categories: >>>

Re: [PATCH V2 3/8] accel/amdxdna: Add RyzenAI-npu6 support

2024-12-13 Thread Lizhi Hou
On 12/13/24 08:37, Jeffrey Hugo wrote: On 12/6/2024 2:59 PM, Lizhi Hou wrote: Add NPU6 registers and other private configurations. Co-developed-by: Xiaoming Ren Signed-off-by: Xiaoming Ren Signed-off-by: Lizhi Hou ---   drivers/accel/amdxdna/Makefile    |   3 +-   drivers/accel/amdxdna/npu

Re: [PATCH v4 3/7] dt-bindings: display: renesas,du: Add missing maxItems

2024-12-13 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Fri, Dec 13, 2024 at 04:02:59PM +0200, Tomi Valkeinen wrote: > From: Tomi Valkeinen > > The binding is missing maxItems for all renesas,cmms and renesas,vsps > properties. As the amount of cmms or vsps is always a fixed amount, set > the maxItems to match th

  1   2   3   >