Re: [PATCH v2] drm: bridge: fsl-ldb: fixup mode on freq mismatch

2024-12-06 Thread Nikolaus Voss
Hi Miquèl, On 06.12.2024 15:08, Miquel Raynal wrote: On 03/12/2024 at 20:09:52 +01, Nikolaus Voss wrote: LDB clock has to be a fixed multiple of the pixel clock. Not only, IIUC it also needs to be synchronized, ie. share the same source. As LDB and pixel clock are derived from different c

[PATCH v3] drm: bridge: fsl-ldb: fixup mode on freq mismatch

2024-12-06 Thread Nikolaus Voss
LDB clock has to be a fixed multiple of the pixel clock. Although LDB and pixel clock have a common source, this constraint cannot be satisfied for any pixel clock at a fixed source clock. Violating this constraint leads to flickering and distorted lines on the attached display. To overcome this,

Re: [PATCH v2 02/22] drm: Add valid clones check

2024-12-06 Thread Jessica Zhang
On 9/25/2024 12:23 AM, Maxime Ripard wrote: On Tue, Sep 24, 2024 at 03:59:18PM GMT, Jessica Zhang wrote: Check that all encoders attached to a given CRTC are valid possible_clones of each other. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/drm_atomic_helper.c | 23

Re: [PATCH V7 03/10] accel/amdxdna: Support hardware mailbox

2024-12-06 Thread Mike Lothian
I can send one in tomorrow if you like On Fri, 6 Dec 2024, 22:55 Jeffrey Hugo, wrote: > On 12/6/2024 11:47 AM, Lizhi Hou wrote: > > > > On 12/6/24 09:01, Mike Lothian wrote: > >> On Fri, 6 Dec 2024 at 16:41, Mike Lothian wrote: > >>> On Fri, 6 Dec 2024 at 16:26, Jeffrey Hugo > >>> wrote: > >>>

Re: [PATCH V7 03/10] accel/amdxdna: Support hardware mailbox

2024-12-06 Thread Jeffrey Hugo
On 12/6/2024 11:47 AM, Lizhi Hou wrote: On 12/6/24 09:01, Mike Lothian wrote: On Fri, 6 Dec 2024 at 16:41, Mike Lothian wrote: On Fri, 6 Dec 2024 at 16:26, Jeffrey Hugo wrote: On 12/5/2024 8:44 AM, Mike Lothian wrote: Hi I needed to add the following to get things compiling for me diff

[PATCH V2 1/8] accel/amdxdna: Add device status for aie2 devices

2024-12-06 Thread Lizhi Hou
Add device status to track if aie2_hw_start() or aie2_hw_stop() is re-entered. In aie2_hw_stop(), call drmm_kfree to free mbox. Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/aie2_pci.c| 17 + drivers/accel/amdxdna/aie2_pci.h| 7 +++ drivers/accel/amdxdna

[PATCH V2 8/8] accel/amdxdna: Add include interrupt.h to amdxdna_mailbox.c

2024-12-06 Thread Lizhi Hou
For amdxdna_mailbox.c, linux/interrupt.h is indirectly included by trace/events/amdxdna.h. So if TRACING is disabled, driver compiling will fail. Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox") Reported-by: Mike Lothian Closes: https://lore.kernel.org/dri-devel/CAHbf0-E+Z2O7rW-x+

[PATCH V2 7/8] accel/amdxdna: Read firmware interface version from registers

2024-12-06 Thread Lizhi Hou
The latest released firmware supports reading firmware interface version from registers directly. The driver's probe routine reads the major and minor version numbers. If the firmware interface does not compatible with the driver, the driver's probe routine returns failure. Co-developed-by: Min Ma

[PATCH V2 4/8] accel/amdxdna: Replace idr api with xarray

2024-12-06 Thread Lizhi Hou
Switch mailbox message id and hardware context id management over from the idr api to the xarray api. Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/TODO | 1 - drivers/accel/amdxdna/aie2_ctx.c| 4 +- drivers/accel/amdxdna/aie2_message.c| 4 +- drivers/accel/amdxd

[PATCH V2 6/8] accel/amdxdna: Enhance power management settings

2024-12-06 Thread Lizhi Hou
Add SET_STATE ioctl to configure device power mode for aie2 device. Three modes are supported initially. POWER_MODE_DEFAULT: Enable clock gating and set DPM (Dynamic Power Management) level to value which has been set by resource solver or maximum DPM level the device supports. POWER_MODE_HIGH: E

[PATCH V2 2/8] accel/amdxdna: Replace mmput with mmput_async to avoid dead lock

2024-12-06 Thread Lizhi Hou
Hardware mailbox message receiving handler calls mmput to release the process mm. If the process has already exited, the mmput here may call mmu notifier handler, amdxdna_hmm_invalidate, which will cause a dead lock. Using mmput_async instead prevents this dead lock. Fixes: aac243092b70 ("accel/am

[PATCH V2 5/8] accel/amdxdna: Add query firmware version

2024-12-06 Thread Lizhi Hou
Enhance GET_INFO ioctl to support retrieving firmware version. Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/aie2_pci.c | 20 include/uapi/drm/amdxdna_accel.h | 16 +++- 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/drivers/accel/amdxdna/aie

[PATCH V2 0/8] AMD NPU driver improvements

2024-12-06 Thread Lizhi Hou
Add recent improvements and bug fixes for amdxdna driver (depends on [1]) 1. Support recent hardware and firmware. 2. Replace idr APIs with xarray. 3. Fix the bugs been found. [1]: https://lore.kernel.org/all/20241118172942.2014541-1-lizhi@amd.com/ Changes since v1: - Add one patch to fix pos

[PATCH V2 3/8] accel/amdxdna: Add RyzenAI-npu6 support

2024-12-06 Thread Lizhi Hou
Add NPU6 registers and other private configurations. Co-developed-by: Xiaoming Ren Signed-off-by: Xiaoming Ren Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/Makefile| 3 +- drivers/accel/amdxdna/npu6_regs.c | 121 ++ 2 files changed, 123 insertions(+), 1

Re: [PULL] drm-fixes

2024-12-06 Thread pr-tracker-bot
The pull request you sent on Fri, 6 Dec 2024 22:12:48 +0100: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-12-06 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/c7cde621b2acfd6bc7d5f002b19b60ad2ed25df8 Thank you! -- Deet-doot-dot, I am a bot. ht

Re: [PATCH v2 2/2] leds: lp8864: New driver

2024-12-06 Thread Andrew Davis
On 12/6/24 3:24 PM, A. Sverdlin wrote: From: Alexander Sverdlin Add driver for TI LP8864, LP8864S, LP8866 4/6 channel LED-backlight drivers with I2C interface. Link: https://www.ti.com/lit/gpn/lp8864-q1 Link: https://www.ti.com/lit/gpn/lp8864s-q1 Link: https://www.ti.com/lit/gpn/lp8866-q1 Link

Re: [RFC 00/13] acpi/x86: s2idle: implement Modern Standby transition states and expose to userspace

2024-12-06 Thread Antheas Kapenekakis
Hi Rafael, since 6.13-rc1 is out, hopefully you can have a look over the next few days We have deployed a variant of this patchset now on desktop builds as well for over 2 months now, and we haven't had any regressions reported. We have also been using it on handheld builds, where for the last 2 o

[PATCH v2 1/2] dt-bindings: backlight: add TI LP8864/LP8866 LED-backlight drivers

2024-12-06 Thread A. Sverdlin
From: Alexander Sverdlin Add bindings for Texas Instruments' LP8864/LP8866 LED-backlight drivers. Note that multiple channels in these models are used for load-balancing and brightness is controlled gobally, so from a user perspective it's only one LED. Signed-off-by: Alexander Sverdlin --- ..

[PATCH v2 2/2] leds: lp8864: New driver

2024-12-06 Thread A. Sverdlin
From: Alexander Sverdlin Add driver for TI LP8864, LP8864S, LP8866 4/6 channel LED-backlight drivers with I2C interface. Link: https://www.ti.com/lit/gpn/lp8864-q1 Link: https://www.ti.com/lit/gpn/lp8864s-q1 Link: https://www.ti.com/lit/gpn/lp8866-q1 Link: https://www.ti.com/lit/gpn/lp8866s-q1 S

[PATCH v2 0/2] leds: TI LP8864/LP8866 support

2024-12-06 Thread A. Sverdlin
From: Alexander Sverdlin The series adds support for a family of Texas Instruments' automotive high-efficiency LED drivers with boost controller. The four or six high-precision current sinks support phase shifting that is automatically adjusted based on the number of channels in use. LED brightne

Re: [PATCH v2 0/2] leds: TI LP8864/LP8866 support

2024-12-06 Thread Sverdlin, Alexander
On Fri, 2024-12-06 at 22:24 +0100, A. Sverdlin wrote: > From: Alexander Sverdlin > > The series adds support for a family of Texas Instruments' automotive > high-efficiency LED drivers with boost controller. The four or six > high-precision current sinks support phase shifting that is automatical

[PULL] drm-fixes

2024-12-06 Thread Simona Vetter
Hi Linus, Due to mailing list unreliability we missed the amdgpu pull, hence part 2 with that now included. drm-fixes-2024-12-06: drm fixes for -rc2, part 2 - amdgu: mostly display fixes + jpeg vcn 1.0, sriov, dcn4.0 resume firxes - amdkfd fixes Cheers, Sima The following changes since commi

Re: [pull] amdgpu, amdkfd drm-fixes-6.13

2024-12-06 Thread Simona Vetter
On Fri, Dec 06, 2024 at 02:04:52PM -0500, Alex Deucher wrote: > Hi Dave, Simona, > > Fixes for 6.13. > > Resending as this didn't seem to make it out to the mailing list when I first > sent it. > > The following changes since commit 40384c840ea1944d7c5a392e8975ed088ecf0b37: > > Linux 6.13-rc1

Re: [PATCH v2 00/21] Converge on using secs_to_jiffies()

2024-12-06 Thread Easwar Hariharan
On 11/29/2024 4:57 AM, Przemek Kitszel wrote: > > [removed most non-list recipients, it's just too much] > > On 11/15/24 10:26 PM, Easwar Hariharan wrote: >> >> --- >> Changes in v2: >> - EDITME: describe what is new in this series revision. >> - EDITME: use bulletpoints and terse descriptions.

Re: [PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

2024-12-06 Thread Simona Vetter
On Mon, Dec 02, 2024 at 10:07:23PM +0200, Imre Deak wrote: > On Mon, Dec 02, 2024 at 05:35:34PM +0100, Simona Vetter wrote: > > On Tue, Nov 26, 2024 at 06:18:56PM +0200, Imre Deak wrote: > > > Atm when the connector is added to the drm_mode_config::connector_list, > > > the connector may not be ful

RE: [PATCH 02/10] compiler.h: add is_const() as a replacement of __is_constexpr()

2024-12-06 Thread David Laight
... > > > #define const_NULL(x) _Generic(0 ? (x) : (char *)0, char *: 1, void *: 0) > > > #define const_true(x) const_NULL((x) ? NULL : (void *)1L)) > > > #define const_expr(x) const_NULL((x) ? NULL : NULL)) > > > I send this morning. > > > Needs 's/char/struct kjkjkjkjui/' applied. > > > > Oh Chri

Re: [PATCH v3 5/9] drm/msm/dpu: Add SM6150 support

2024-12-06 Thread Abhinav Kumar
On 11/22/2024 1:56 AM, Fange Zhang wrote: From: Li Liu Add definitions for the display hardware used on the Qualcomm SM6150 platform. Signed-off-by: Li Liu Signed-off-by: Fange Zhang --- .../gpu/drm/msm/disp/dpu1/catalog/dpu_5_3_sm6150.h | 263 + drivers/gpu/drm/msm

Re: [PATCH 6/8] drm/msm/dp: Add maximum width limitation for modes

2024-12-06 Thread Abhinav Kumar
On 12/3/2024 5:58 AM, Dmitry Baryshkov wrote: On Tue, Dec 03, 2024 at 03:41:53PM +0800, Xiangxu Yin wrote: On 12/2/2024 5:32 PM, Dmitry Baryshkov wrote: On Mon, 2 Dec 2024 at 11:05, Xiangxu Yin wrote: On 11/29/2024 9:52 PM, Dmitry Baryshkov wrote: On Fri, 29 Nov 2024 at 09:59, Xiangx

Re: [PATCH] drm/bridge-connector: Prioritize supported_formats over ycbcr_420_allowed

2024-12-06 Thread Cristian Ciocaltea
("drm/display: bridge_connector: handle > ycbcr_420_allowed") Please ignore this and check v2 instead: https://lore.kernel.org/all/20241206-bridge-conn-fmt-prio-v2-1-85c817529...@collabora.com/

Re: [git pull] drm fixes for 6.13-rc2

2024-12-06 Thread pr-tracker-bot
The pull request you sent on Sat, 7 Dec 2024 04:44:29 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-12-07 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/9a6e8c7c3a024b9e9ec8fd6295c3159504263cb2 Thank you! -- Deet-doot-dot, I am a bot. ht

[PATCH] drm/msm/dpu: filter out too wide modes if no 3dmux is present

2024-12-06 Thread Abhinav Kumar
+*/ + if (!dpu_kms->catalog->caps->has_3d_merge + && mode->hdisplay > dpu_kms->catalog->caps->max_mixer_width) + return MODE_BAD; /* * max crtc width is equal to the max mixer width * 2 and max height is 4K *

[PATCH v2] drm/bridge-connector: Prioritize supported_formats over ycbcr_420_allowed

2024-12-06 Thread Cristian Ciocaltea
Bridges having the DRM_BRIDGE_OP_HDMI flag set in drm_bridge->ops are supposed to rely on drm_bridge->supported_formats bitmask to advertise the supported colorspaces, including HDMI_COLORSPACE_YUV420. Therefore, the newly introduced drm_bridge->ycbcr_420_allowed flag becomes redundant in this par

[PATCH v3] drm/etnaviv: add optional reset support

2024-12-06 Thread LECOINTRE Philippe
Add optional reset support which is mentioned in vivante,gc.yaml to allow the driver to work on SoCs whose reset signal is asserted by default Signed-off-by: Philippe Lecointre Reviewed-by: Simon Lenain --- v3: - Rework to match initial feedback --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 37 ++

[PATCH] drm/mediatek: Set private->all_drm_private[i]->drm to NULL if mtk_drm_bind returns err

2024-12-06 Thread Guoqing Jiang
The pointer need to be set to NULL, otherwise KASAN complains about use-after-free. Because in mtk_drm_bind, all private's drm are set as follows. private->all_drm_private[i]->drm = drm; And drm will be released by drm_dev_put in case mtk_drm_kms_init returns failure. However, the shutdown path s

[PATCH 2/3] backlight: dwi_bl: Add Apple DWI backlight driver

2024-12-06 Thread Nick Chan
Add driver for backlight controllers attached via Apple DWI 2-wire interface, which is found on some Apple iPhones, iPads and iPod touches with a LCD display. Signed-off-by: Nick Chan --- drivers/video/backlight/Kconfig | 12 +++ drivers/video/backlight/Makefile | 1 + drivers/video/backligh

[PATCH] drm/exynos: Remove unnecessary checking

2024-12-06 Thread Guoqing Jiang
It is not needed since drm_atomic_helper_shutdown checks it. Signed-off-by: Guoqing Jiang --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c index 2a4

[PATCH 0/3] Apple DWI backlight driver

2024-12-06 Thread Nick Chan
Apple SoCs come with a 2-wire interface named DWI. On some iPhones, iPads and iPod touches 1-2 backlight controllers are attached via this interface. Though, to software using this interface, there is effectively only one controller to worry about since the registers changes the brightness setting

[PATCH 1/3] dt-bindings: leds: backlight: apple, dwi-bl: Add bindings for Apple DWI backlight

2024-12-06 Thread Nick Chan
Add the device tree bindings for backlight controllers attached via Apple DWI 2-wire interface. Signed-off-by: Nick Chan --- .../bindings/leds/backlight/apple,dwi-bl.yaml | 55 +++ 1 file changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backli

[PATCH] drm/rockchip: Remove unnecessary checking

2024-12-06 Thread Guoqing Jiang
It is not needed since drm_atomic_helper_shutdown checks it. Signed-off-by: Guoqing Jiang --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv

[PATCH 3/3] MAINTAINERS: Add entries for Apple DWI backlight controller

2024-12-06 Thread Nick Chan
Add MAINTAINERS entries for the driver. Signed-off-by: Nick Chan --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1e930c7a58b1..36de76bc6fd4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2204,6 +2204,7 @@ F: Documentation/devicetree/b

RE: [PATCH 02/10] compiler.h: add is_const() as a replacement of __is_constexpr()

2024-12-06 Thread David Laight
From: Willy Tarreau > Sent: 06 December 2024 19:39 > On Fri, Dec 06, 2024 at 11:15:20AM -0800, Linus Torvalds wrote: > > On Fri, 6 Dec 2024 at 11:07, David Laight wrote: > > > > > > I'm missing the compiler version and options to generate the error. > > > > Just -Wall with most recent gcc versions

RE: [PATCH 02/10] compiler.h: add is_const() as a replacement of __is_constexpr()

2024-12-06 Thread David Laight
From: Linus Torvalds > Sent: 06 December 2024 19:15 > On Fri, 6 Dec 2024 at 11:07, David Laight wrote: > > > > I'm missing the compiler version and options to generate the error. > > Just -Wall with most recent gcc versions seems to do it. At least I > can repro it with gcc-14.2.1 and something s

[PATCH drm-misc-next] rockchip/drm: vop2: don't check color_mgmt_changed in atomic_enable

2024-12-06 Thread Piotr Zalewski
Remove color_mgmt_changed check from vop2_crtc_atomic_try_set_gamma to allow gamma LUT rewrite during modeset when coming out of suspend. Add a check for color_mgmt_changed directly in vop2_crtc_atomic_flush. This patch fixes the patch adding gamma LUT support for vop2 [1]. [1] https://lore.kern

Re: [PATCH 02/10] compiler.h: add is_const() as a replacement of __is_constexpr()

2024-12-06 Thread Linus Torvalds
On Fri, 6 Dec 2024 at 11:07, David Laight wrote: > > I'm missing the compiler version and options to generate the error. Just -Wall with most recent gcc versions seems to do it. At least I can repro it with gcc-14.2.1 and something silly like this: $ cat t.c int fn(int a) { return (a<<2)?1:2

Re: [git pull] drm fixes for 6.13-rc2

2024-12-06 Thread Alex Deucher
On Fri, Dec 6, 2024 at 1:55 PM Dave Airlie wrote: > > Hi Linus, > > Pretty quiet week which is probably expected after US holidays, the > dma-fence and displayport MST message handling fixes make up the bulk > of this, along with a couple of minor xe and other driver fixes. FWIW, I sent out a PR

RE: [PATCH 02/10] compiler.h: add is_const() as a replacement of __is_constexpr()

2024-12-06 Thread David Laight
From: Linus Torvalds > Sent: 06 December 2024 18:53 > > On Fri, 6 Dec 2024 at 10:31, Vincent Mailhol > wrote: > > > > > causes issues when 'x' is not an integer expression (think > > > "is_const(NULL)" or "is_const(1 == 2)". > > > > But 1 == 2 already has an integer type as proven by: > > Yeah,

[pull] amdgpu, amdkfd drm-fixes-6.13

2024-12-06 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.13. Resending as this didn't seem to make it out to the mailing list when I first sent it. The following changes since commit 40384c840ea1944d7c5a392e8975ed088ecf0b37: Linux 6.13-rc1 (2024-12-01 14:28:56 -0800) are available in the Git repository at: https://g

Re: [PATCH 02/10] compiler.h: add is_const() as a replacement of __is_constexpr()

2024-12-06 Thread Linus Torvalds
On Fri, 6 Dec 2024 at 10:52, Linus Torvalds wrote: > > This may be a case of "we just need to disable that incorrect compiler > warning". Or does anybody see a workaround? Hmm. The "== 0" thing does work, but as mentioned, that causes (more valid, imho) warnings with pointers. And it's not neces

Re: [PATCH 02/10] compiler.h: add is_const() as a replacement of __is_constexpr()

2024-12-06 Thread Linus Torvalds
On Fri, 6 Dec 2024 at 10:31, Vincent Mailhol wrote: > > > causes issues when 'x' is not an integer expression (think > > "is_const(NULL)" or "is_const(1 == 2)". > > But 1 == 2 already has an integer type as proven by: Yeah, I was confused about exactly what triggers that odd '-Wint-in-bool-contex

Re: [PATCH V7 03/10] accel/amdxdna: Support hardware mailbox

2024-12-06 Thread Lizhi Hou
On 12/6/24 09:01, Mike Lothian wrote: On Fri, 6 Dec 2024 at 16:41, Mike Lothian wrote: On Fri, 6 Dec 2024 at 16:26, Jeffrey Hugo wrote: On 12/5/2024 8:44 AM, Mike Lothian wrote: Hi I needed to add the following to get things compiling for me diff --git a/drivers/accel/amdxdna/amdxdna_ma

[git pull] drm fixes for 6.13-rc2

2024-12-06 Thread Dave Airlie
Hi Linus, Pretty quiet week which is probably expected after US holidays, the dma-fence and displayport MST message handling fixes make up the bulk of this, along with a couple of minor xe and other driver fixes. Dave. drm-fixes-2024-12-07: drm fixes for 6.13-rc2 dma-fence: - Fix reference leak

Re: [PATCH 1/2] dt-bindings: backlight: Convert LP8860 into YAML format adding LP886x

2024-12-06 Thread Andrew Davis
On 12/6/24 12:20 PM, Sverdlin, Alexander wrote: Hi Andrew, On Fri, 2024-12-06 at 12:02 -0600, Andrew Davis wrote: On 12/6/24 11:46 AM, Sverdlin, Alexander wrote: Hi Andrew, On Fri, 2024-12-06 at 11:43 -0600, Andrew Davis wrote: Are you sure this is a correct thing to do? The lp8860-q1 produc

Re: [PATCH 1/3] dt-bindings: leds: backlight: apple,dwi-bl: Add bindings for Apple DWI backlight

2024-12-06 Thread Rob Herring (Arm)
On Sat, 07 Dec 2024 01:24:33 +0800, Nick Chan wrote: > Add the device tree bindings for backlight controllers attached via Apple > DWI 2-wire interface. > > Signed-off-by: Nick Chan > --- > .../bindings/leds/backlight/apple,dwi-bl.yaml | 55 +++ > 1 file changed, 55 insertions(

Re: [PATCH V7 03/10] accel/amdxdna: Support hardware mailbox

2024-12-06 Thread Mike Lothian
On Fri, 6 Dec 2024 at 18:13, Lizhi Hou wrote: > > > On 12/6/24 09:52, Mike Lothian wrote: > > On Fri, 6 Dec 2024 at 17:10, Lizhi Hou wrote: > >> Hi Mike, > >> > >> > >> How did you install npu.sbin.1.5.2.380? There should be a symlink > >> npu.sbin which points to npu.sbin.1.5.2.380. > >> > >> h

Re: [PATCH 1/2] dt-bindings: backlight: Convert LP8860 into YAML format adding LP886x

2024-12-06 Thread Sverdlin, Alexander
Hi Andrew, On Fri, 2024-12-06 at 12:02 -0600, Andrew Davis wrote: > On 12/6/24 11:46 AM, Sverdlin, Alexander wrote: > > Hi Andrew, > > > > On Fri, 2024-12-06 at 11:43 -0600, Andrew Davis wrote: > > > > Are you sure this is a correct thing to do? The lp8860-q1 product link > > > > cites it as bein

Re: [PATCH V7 03/10] accel/amdxdna: Support hardware mailbox

2024-12-06 Thread Lizhi Hou
On 12/6/24 09:52, Mike Lothian wrote: On Fri, 6 Dec 2024 at 17:10, Lizhi Hou wrote: Hi Mike, How did you install npu.sbin.1.5.2.380? There should be a symlink npu.sbin which points to npu.sbin.1.5.2.380. https://gitlab.com/kernel-firmware/linux-firmware/-/blob/main/WHENCE?ref_type=heads#L

Re: [PATCH 1/2] dt-bindings: backlight: Convert LP8860 into YAML format adding LP886x

2024-12-06 Thread Andrew Davis
On 12/6/24 11:46 AM, Sverdlin, Alexander wrote: Hi Andrew, On Fri, 2024-12-06 at 11:43 -0600, Andrew Davis wrote: Are you sure this is a correct thing to do? The lp8860-q1 product link cites it as being a 4-channel device. Even if the kernel only ever supports it as a single-channel device, the

Re: [PATCH V7 03/10] accel/amdxdna: Support hardware mailbox

2024-12-06 Thread Mike Lothian
On Fri, 6 Dec 2024 at 17:10, Lizhi Hou wrote: > > Hi Mike, > > > How did you install npu.sbin.1.5.2.380? There should be a symlink > npu.sbin which points to npu.sbin.1.5.2.380. > > https://gitlab.com/kernel-firmware/linux-firmware/-/blob/main/WHENCE?ref_type=heads#L2719 > > > Thanks, > > Lizhi >

Re: [PATCH 1/2] dt-bindings: backlight: Convert LP8860 into YAML format adding LP886x

2024-12-06 Thread Sverdlin, Alexander
Hi Andrew, On Fri, 2024-12-06 at 11:43 -0600, Andrew Davis wrote: > > Are you sure this is a correct thing to do? The lp8860-q1 product link > > cites it as being a 4-channel device. Even if the kernel only ever > > supports it as a single-channel device, the binding should reflect what > > it is

Re: [PATCH 1/2] dt-bindings: backlight: Convert LP8860 into YAML format adding LP886x

2024-12-06 Thread Sverdlin, Alexander
Hello Conor, On Fri, 2024-12-06 at 17:14 +, Conor Dooley wrote: > > Add Texas Instruments' LP8864/LP8866 bindings into LP8860 converting them > > into YAML format simultaneously. While here, drop the index of the "led" > > subnode, this one is neither used nor mandated by the drivers. All the

Re: [PATCH 1/2] dt-bindings: backlight: Convert LP8860 into YAML format adding LP886x

2024-12-06 Thread Andrew Davis
On 12/6/24 11:14 AM, Conor Dooley wrote: On Fri, Dec 06, 2024 at 06:07:12PM +0100, A. Sverdlin wrote: From: Alexander Sverdlin Add Texas Instruments' LP8864/LP8866 bindings into LP8860 converting them into YAML format simultaneously. While here, drop the index of the "led" subnode, this one is

[PATCH 2/2] leds: lp8864: New driver

2024-12-06 Thread A. Sverdlin
From: Alexander Sverdlin Add driver for TI LP8864, LP8864S, LP8866 4/6 channel LED-backlight drivers with I2C interface. Link: https://www.ti.com/lit/gpn/lp8866-q1 Link: https://www.ti.com/lit/gpn/lp8864-q1 Link: https://www.ti.com/lit/gpn/lp8864s-q1 Signed-off-by: Alexander Sverdlin --- MAINT

[PATCH 0/2] leds: TI LP8864/LP8866 support

2024-12-06 Thread A. Sverdlin
From: Alexander Sverdlin Add new DT compatible ti,lp8864 to support all four software-compatible devices: - LP8864 - LP8864S - LP8866 - LP8866S This is a new family with a functionality similar to LP8860 -- hence the same (re-used) DT bindings. They had to be converted to YAML along the way. Add

[PATCH 1/2] dt-bindings: backlight: Convert LP8860 into YAML format adding LP886x

2024-12-06 Thread A. Sverdlin
From: Alexander Sverdlin Add Texas Instruments' LP8864/LP8866 bindings into LP8860 converting them into YAML format simultaneously. While here, drop the index of the "led" subnode, this one is neither used nor mandated by the drivers. All the *-cells properties are therefore not required. Move t

Re: [PATCH 1/2] dt-bindings: backlight: Convert LP8860 into YAML format adding LP886x

2024-12-06 Thread Conor Dooley
On Fri, Dec 06, 2024 at 06:07:12PM +0100, A. Sverdlin wrote: > From: Alexander Sverdlin > > Add Texas Instruments' LP8864/LP8866 bindings into LP8860 converting them > into YAML format simultaneously. While here, drop the index of the "led" > subnode, this one is neither used nor mandated by the

[PATCH] drm:panel-orientation-quirks Added DeckHD support

2024-12-06 Thread Guy Chronister
This commit introduces a new quirk to handle specific orientation issues for DeckHD panels on the Steam Deck. The quirk ensures the correct display orientation for these panels, enhancing the user experience on Steam Deck devices. Tested on my Steam Deck to ensure reliability. Feedback and furth

Re: [PATCH V7 03/10] accel/amdxdna: Support hardware mailbox

2024-12-06 Thread Mike Lothian
On Fri, 6 Dec 2024 at 16:41, Mike Lothian wrote: > > On Fri, 6 Dec 2024 at 16:26, Jeffrey Hugo wrote: > > > > On 12/5/2024 8:44 AM, Mike Lothian wrote: > > > Hi > > > > > > I needed to add the following to get things compiling for me > > > > > > > > > diff --git a/drivers/accel/amdxdna/amdxdna_ma

Re: [PATCH V7 03/10] accel/amdxdna: Support hardware mailbox

2024-12-06 Thread Lizhi Hou
Hi Mike, How did you install npu.sbin.1.5.2.380?  There should be a symlink npu.sbin which points to npu.sbin.1.5.2.380. https://gitlab.com/kernel-firmware/linux-firmware/-/blob/main/WHENCE?ref_type=heads#L2719 Thanks, Lizhi On 12/5/24 07:44, Mike Lothian wrote: Hi I needed to add the f

Re: [PATCH] drm:panel-orientation-quirks Added DeckHD support to panel orientation quirks for Steam Deck This commit introduces a new quirk to handle specific orientation issues for DeckHD panels on t

2024-12-06 Thread Guy Chronister
Disregard this one, I resubmitted after running "git format-patch -1 HEAD" after breaking the subject/commit message amendment. On Fri, Dec 6, 2024 at 9:45 AM Guy Chronister wrote: > Signed-off-by: Guy Chronister > --- > drivers/gpu/drm/drm_panel_orientation_quirks.c | 7 +++ > 1 file cha

Re: [PATCH V7 03/10] accel/amdxdna: Support hardware mailbox

2024-12-06 Thread Mike Lothian
On Fri, 6 Dec 2024 at 16:26, Jeffrey Hugo wrote: > > On 12/5/2024 8:44 AM, Mike Lothian wrote: > > Hi > > > > I needed to add the following to get things compiling for me > > > > > > diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c > > b/drivers/accel/amdxdna/amdxdna_mailbox.c > > index fe684f

Re: [PATCH V7 03/10] accel/amdxdna: Support hardware mailbox

2024-12-06 Thread Jeffrey Hugo
On 12/5/2024 8:44 AM, Mike Lothian wrote: Hi I needed to add the following to get things compiling for me diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c b/drivers/accel/amdxdna/amdxdna_mailbox.c index fe684f463b945..79b9801935e71 100644 --- a/drivers/accel/amdxdna/amdxdna_mailbox.c +++ b

Re: [PATCH v5 3/4] proc_pid_fdinfo.5: Add subsection headers for different fd types

2024-12-06 Thread Alejandro Colomar
Hi Ian, On Thu, Dec 05, 2024 at 11:38:27PM -0800, Ian Rogers wrote: > Make the sections about eventfd, epoll, signalfd, inotify, fanotify, > timerfd better separated with a clearer subsection header. > --- > man/man5/proc_pid_fdinfo.5 | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2024-12-06 Thread Mark Brown
On Fri, Dec 06, 2024 at 03:39:15PM +, Jiaxin Yu (俞家鑫) wrote: > On Mon, 2024-12-02 at 13:16 +, Mark Brown wrote: > > On Sun, Dec 01, 2024 at 05:15:45PM +, Jiaxin Yu (俞家鑫) wrote: > > > So I want to ask if I can do it by just adding > > > SOC_DAPM_PIN_SWITCH("Speakers") and SOC_DAPM_PIN_S

[PATCH] drm:panel-orientation-quirks Added DeckHD support to panel orientation quirks for Steam Deck This commit introduces a new quirk to handle specific orientation issues for DeckHD panels on the S

2024-12-06 Thread Guy Chronister
Signed-off-by: Guy Chronister --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index 3f2e2b851cbc..c412273799cb 100644 --- a/drivers/gpu/dr

[PATCH] drm/v3d: Fix miscellaneous documentation errors

2024-12-06 Thread Maíra Canal
This commit fixes several miscellaneous documentation errors. Mostly, delete/update comments that are outdated or are leftovers from past code changes. Apart from that, remove double-spaces in several comments. Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_bo.c | 4 --

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2024-12-06 Thread 俞家鑫

Re: [WIP RFC v2 02/35] WIP: rust: drm: Add traits for registering KMS devices

2024-12-06 Thread Alice Ryhl
On Tue, Oct 1, 2024 at 1:37 AM Lyude Paul wrote: > > This commit adds some traits for registering DRM devices with KMS support, > implemented through the kernel::drm::kms::Kms trait. Devices which don't > have KMS support can simply use PhantomData. > > Signed-off-by: Lyude Paul > > --- > > TODO:

Re: [PATCH v5 2/4] proc_pid_fdinfo.5: Make pid clearer in the name and 1st paragraph

2024-12-06 Thread Alejandro Colomar
Hi Ian, On Thu, Dec 05, 2024 at 11:38:26PM -0800, Ian Rogers wrote: > Previously the pid was highlighted through being a tagged paragraph > but not mentioned in the description. Add italics to the path > emphasizing pid and then change the first sentence to include pid in > the definition. > > Su

Re: [PATCH v5 1/4] proc_pid_fdinfo.5: Reduce indent for most of the page

2024-12-06 Thread Alejandro Colomar
Hi Ian, On Thu, Dec 05, 2024 at 11:38:25PM -0800, Ian Rogers wrote: > When /proc/pid/fdinfo was part of proc.5 man page the indentation made > sense. As a standalone man page the indentation doesn't need to be so > far over to the right. Remove the initial tagged pragraph, move the > "since Linux

Re: [PATCH 0/4] drm/vc4: Clean-up the BO seqnos

2024-12-06 Thread Christian König
Am 06.12.24 um 16:11 schrieb Maíra Canal: On 06/12/24 11:17, Christian König wrote: Am 06.12.24 um 14:12 schrieb Maíra Canal: This series introduces a series of clean-ups in BO reservations for the VC4 driver. Currently, VC4 uses shared fences to track BO reservations as several other DRM devi

Re: [PATCH 0/4] drm/vc4: Clean-up the BO seqnos

2024-12-06 Thread Maíra Canal
On 06/12/24 11:17, Christian König wrote: Am 06.12.24 um 14:12 schrieb Maíra Canal: This series introduces a series of clean-ups in BO reservations for the VC4 driver. Currently, VC4 uses shared fences to track BO reservations as several other DRM devices. But apart from the DMA reservation obje

Re: [PATCH v1 00/10] Add eDP support for RK3588

2024-12-06 Thread Heiko Stübner
Hi Daemon, Am Mittwoch, 27. November 2024, 08:51:47 CET schrieb Damon Ding: > These patchs have been tested with a 1536x2048p60 eDP panel on > RK3588S EVB1 board, and HDMI 1080P/4K display also has been verified > on RK3588 EVB1 board. > > Patch 1~3 are the RK3588 eDP support of Rockchip analogix

Re: [PATCH v6 09/10] drm/vc4: hdmi: stop rereading EDID in get_modes()

2024-12-06 Thread Maxime Ripard
Hi, On Fri, Dec 06, 2024 at 12:16:03PM +0200, Dmitry Baryshkov wrote: > The vc4_hdmi_connector_detect_ctx() via vc4_hdmi_handle_hotplug() > already reads EDID and propagates it to the drm_connector. Stop > rereading EDID as a part of the .get_modes() callback and just update > the list of modes. T

Re: [PATCH v5 9/9] drm/vc4: hdmi: use drm_atomic_helper_connector_hdmi_update_edid()

2024-12-06 Thread mripard
On Tue, Dec 03, 2024 at 02:27:44PM +0200, Dmitry Baryshkov wrote: > On Mon, Dec 02, 2024 at 02:27:49PM +0100, Maxime Ripard wrote: > > Hi, > > > > On Sun, Dec 01, 2024 at 02:44:13AM +0200, Dmitry Baryshkov wrote: > > > Use the helper function to update the connector's information. This > > > makes

Re: [PATCH 0/4] drm/vc4: Clean-up the BO seqnos

2024-12-06 Thread Christian König
Am 06.12.24 um 14:12 schrieb Maíra Canal: This series introduces a series of clean-ups in BO reservations for the VC4 driver. Currently, VC4 uses shared fences to track BO reservations as several other DRM devices. But apart from the DMA reservation objects, VC4 also attaches seqnos to its BOs wi

Re: [PATCH v5 8/9] drm/vc4: hdmi: switch to using generic HDMI Codec infrastructure

2024-12-06 Thread Maxime Ripard
On Tue, Dec 03, 2024 at 02:19:41PM +0200, Dmitry Baryshkov wrote: > On Mon, Dec 02, 2024 at 02:20:04PM +0100, Maxime Ripard wrote: > > Hi, > > > > Sorry, I've been drowning under work and couldn't review that series before. > > No worries, at this point I'm more concerned about my IGT series rath

Re: [PATCH v2] drm: bridge: fsl-ldb: fixup mode on freq mismatch

2024-12-06 Thread Miquel Raynal
Hi Nikolaus, On 03/12/2024 at 20:09:52 +01, Nikolaus Voss wrote: > LDB clock has to be a fixed multiple of the pixel clock. Not only, IIUC it also needs to be synchronized, ie. share the same source. > As LDB and pixel clock are derived from different clock sources > (at least on imx8mp), Wai

Re: [PATCH v3 04/11] driver core: Constify API device_find_child() then adapt for various usages

2024-12-06 Thread Takashi Sakamoto
Hi, On Thu, Dec 05, 2024 at 08:10:13AM +0800, Zijun Hu wrote: > From: Zijun Hu > > Constify the following API: > struct device *device_find_child(struct device *dev, void *data, > int (*match)(struct device *dev, void *data)); > To : > struct device *device_find_child(struct device

Re: [PATCH v3 05/10] clk: renesas: r8a779h0: Add display clocks

2024-12-06 Thread Geert Uytterhoeven
Hi Tomi, On Fri, Dec 6, 2024 at 10:33 AM Tomi Valkeinen wrote: > From: Tomi Valkeinen > > Add display related clocks for DU, DSI, FCPVD, and VSPD. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > Tested-by: Geert Uytterhoeven Reviewed-by: Geert Uytterhoeven i.e. will queu

[PATCH 1/4] drm/vc4: Use `drm_gem_lock_reservations()` instead of hard-coding

2024-12-06 Thread Maíra Canal
Instead of creating internal copies of `drm_gem_lock_reservations()` and `drm_gem_unlock_reservations()`, use the functions provided by DRM GEM. Signed-off-by: Maíra Canal --- drivers/gpu/drm/vc4/vc4_gem.c | 66 --- 1 file changed, 6 insertions(+), 60 deletions(-)

[PATCH 4/4] drm/vc4: Remove `vc4_queue_seqno_cb()`

2024-12-06 Thread Maíra Canal
The function `vc4_queue_seqno_cb()` is no longer needed, as we are using DMA Reservation Objects to track BOs. Using DMA Resv, we can use `dma_fence_add_callback()` to perform the async page flip. Signed-off-by: Maíra Canal --- drivers/gpu/drm/vc4/vc4_drv.h | 3 --- drivers/gpu/drm/vc4/vc4_gem.

[PATCH 3/4] drm/vc4: Remove BOs seqnos

2024-12-06 Thread Maíra Canal
`bo->seqno`, `bo->write_seqno`, and `exec->bin_dep_seqno` are leftovers from a time when VC4 didn't support DMA Reservation Objects. When they were introduced, it made sense to think about tracking the correspondence between the BOs and the jobs through the job's seqno. This is no longer needed, a

[PATCH 2/4] drm/vc4: Use DMA Resv to implement VC4 wait BO IOCTL

2024-12-06 Thread Maíra Canal
As the BOs used by VC4 have DMA Reservation Objects attached to it, there is no need to use seqnos wait for the BOs availability. Instead, we can use `dma_gem_dma_resv_wait()`. Signed-off-by: Maíra Canal --- drivers/gpu/drm/vc4/vc4_drv.h | 10 ++ drivers/gpu/drm/vc4/vc4_gem.c | 31 ++

[PATCH 0/4] drm/vc4: Clean-up the BO seqnos

2024-12-06 Thread Maíra Canal
This series introduces a series of clean-ups in BO reservations for the VC4 driver. Currently, VC4 uses shared fences to track BO reservations as several other DRM devices. But apart from the DMA reservation objects, VC4 also attaches seqnos to its BOs with the intention to track if the job that us

Re: [PATCH 44/45] arm64: dts: qcom: add mst support for pixel stream clk for DP0

2024-12-06 Thread Konrad Dybcio
On 6.12.2024 5:32 AM, Abhinav Kumar wrote: > From: Yongxing Mou > > Populate the pixel clock for stream 1 for DP0 for sa8775p DP controller. > > Signed-off-by: Yongxing Mou > Signed-off-by: Abhinav Kumar > --- > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 12 > 1 file changed, 8 inse

Re: [PATCH 13/45] drm/msm/dp: separate dp_display_prepare() into its own API

2024-12-06 Thread Stephan Gerhold
On Thu, Dec 05, 2024 at 08:31:44PM -0800, Abhinav Kumar wrote: > dp_display_prepare() only prepares the link in case its not > already ready before dp_display_enable(). Hence separate it into > its own API. > > Signed-off-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/dp/dp_display.c | 24 +++

Re:[PATCH] drm/rockchip: Remove unnecessary checking

2024-12-06 Thread Andy Yan
Hi Guoqing, At 2024-12-06 19:42:33, "Guoqing Jiang" wrote: >It is not needed since drm_atomic_helper_shutdown checks it. > >Signed-off-by: Guoqing Jiang Acked-by: Andy Yan Thanks >--- > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >

Re: [PATCH v3 04/11] driver core: Constify API device_find_child() then adapt for various usages

2024-12-06 Thread Zijun Hu
On 2024/12/6 15:21, Uwe Kleine-König wrote: > Hello, > > On Thu, Dec 05, 2024 at 08:10:13AM +0800, Zijun Hu wrote: >> From: Zijun Hu >> >> Constify the following API: >> struct device *device_find_child(struct device *dev, void *data, >> int (*match)(struct device *dev, void *data));

Re: [PATCH v2 1/2] drm/msm/dpu1: don't choke on disabling the writeback connector

2024-12-06 Thread Johan Hovold
Hi Dmitry, On Wed, Nov 20, 2024 at 09:39:27AM +0100, Johan Hovold wrote: > On Fri, Aug 02, 2024 at 10:47:33PM +0300, Dmitry Baryshkov wrote: > > During suspend/resume process all connectors are explicitly disabled and > > then reenabled. However resume fails because of the connector_status check:

RE: [PATCHv2 01/10] drm/crtc: Add histogram properties

2024-12-06 Thread Murthy, Arun R
> On Thu, Dec 05, 2024 at 04:29:55PM +, Murthy, Arun R wrote: > > > > > -Original Message- > > > > > From: Dmitry Baryshkov > > > > > Sent: Wednesday, December 4, 2024 5:17 PM > > > > > To: Murthy, Arun R > > > > > Cc: intel...@lists.freedesktop.org; > > > > > intel-...@lists.freedesk

  1   2   >