RE: [PATCHv2 01/10] drm/crtc: Add histogram properties

2024-12-04 Thread Murthy, Arun R
> -Original Message- > From: Dmitry Baryshkov > Sent: Wednesday, December 4, 2024 5:17 PM > To: Murthy, Arun R > Cc: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Subject: Re: [PATCHv2 01/10] drm/crtc: Add histogram properties >

Re: [PATCH v2 1/3] drm/xen: remove redundant initialization info print

2024-12-04 Thread Thomas Zimmermann
Am 04.12.24 um 15:31 schrieb Jani Nikula: drm_dev_register() already prints the same information on successful init. Remove the redundant prints. Acked-by: Alex Deucher Signed-off-by: Jani Nikula --- Note: I prefer to merge this together with the next patch via drm-misc-next. Cc: Oleksa

Re: [PATCH 2/4] dt-bindings: display: msm: dp-controller: document clock parents better

2024-12-04 Thread Krzysztof Kozlowski
On 04/12/2024 11:09, Dmitry Baryshkov wrote: > On Wed, Dec 04, 2024 at 09:02:18AM +0100, Krzysztof Kozlowski wrote: >> On Tue, Dec 03, 2024 at 03:41:48PM +0200, Dmitry Baryshkov wrote: >>> On Tue, Dec 03, 2024 at 09:01:31AM +0100, Krzysztof Kozlowski wrote: On 03/12/2024 04:31, Abhinav Kumar w

Re: [RFC PATCH v1 01/14] clk: thead: Refactor TH1520 clock driver to share common code

2024-12-04 Thread Krzysztof Kozlowski
On 04/12/2024 14:54, Michal Wilczynski wrote: > > > On 12/3/24 20:56, Stephen Boyd wrote: >> Quoting Michal Wilczynski (2024-12-03 05:41:24) >>> diff --git a/drivers/clk/thead/Makefile b/drivers/clk/thead/Makefile >>> index 7ee0bec1f251..d7cf88390b69 100644 >>> --- a/drivers/clk/thead/Makefile >>

Re: [PATCH v2 3/3] drm: remove driver date from struct drm_driver and all drivers

2024-12-04 Thread Thomas Zimmermann
Am 04.12.24 um 15:31 schrieb Jani Nikula: We stopped using the driver initialized date in commit 7fb8af6798e8 ("drm: deprecate driver date") and (eventually) started returning "0" for drm_version ioctl instead. Finish the job, and remove the unused date member from struct drm_driver, its ini

Re: [PATCH v2 2/3] accel/ivpu: remove DRIVER_DATE conditional drm_driver init

2024-12-04 Thread Thomas Zimmermann
Am 04.12.24 um 15:31 schrieb Jani Nikula: The ivpu struct drm_driver has conditional initialization based on #ifdef DRIVER_DATE, which is never defined anywhere. Neither are the macros referenced within the block: DRIVER_DATE, DRIVER_MAJOR, DRIVER_MINOR, and DRIVER_PATCHLEVEL. With the struct

Re: [RFC PATCH v1 05/14] dt-bindings: clock: thead,th1520: Add support for Video Output subsystem

2024-12-04 Thread Krzysztof Kozlowski
On 04/12/2024 21:21, Stephen Boyd wrote: >>> No, that's a clear NAK. You claim you have no address space but in the >>> same time you have address space via regmap. >> >> I see your concern. The VOSYS subsystem's address space includes >> registers for various components, such as clock gates and re

Re: [RFC PATCH v1 05/14] dt-bindings: clock: thead,th1520: Add support for Video Output subsystem

2024-12-04 Thread Krzysztof Kozlowski
On 04/12/2024 11:11, Michal Wilczynski wrote: > > > On 12/3/24 16:45, Krzysztof Kozlowski wrote: >> On 03/12/2024 14:41, Michal Wilczynski wrote: >>> The device tree bindings for the T-Head TH1520 SoC clocks currently >>> support only the Application Processor (AP) subsystem. This commit >>> exte

Re: [PATCH 6/9] drm/rcar-du: Add support for r8a779h0

2024-12-04 Thread Tomi Valkeinen
Hi Laurent, On 03/12/2024 12:48, Laurent Pinchart wrote: On Tue, Dec 03, 2024 at 11:22:15AM +0200, Tomi Valkeinen wrote: On 03/12/2024 10:56, Laurent Pinchart wrote: On Tue, Dec 03, 2024 at 10:01:40AM +0200, Tomi Valkeinen wrote: From: Tomi Valkeinen Add support for r8a779h0. It is very sim

Re: [PATCH V1 1/7] accel/amdxdna: Add device status for aie2 devices

2024-12-04 Thread Lizhi Hou
On 12/4/24 14:26, Mario Limonciello wrote: On 12/4/2024 15:37, Lizhi Hou wrote: Add device status to track if aie2_hw_start() or aie2_hw_stop() is re-entered. In aie2_hw_stop(), call drmm_kfree to free mbox. Signed-off-by: Lizhi Hou ---   drivers/accel/amdxdna/aie2_pci.c    | 17

Re: [PATCH V1 5/7] accel/amdxdna: Add query firmware version

2024-12-04 Thread Lizhi Hou
On 12/4/24 14:24, Mario Limonciello wrote: On 12/4/2024 15:37, Lizhi Hou wrote: Enhance GET_INFO ioctl to support retrieving firmware version. Signed-off-by: Lizhi Hou ---   drivers/accel/amdxdna/aie2_pci.c | 20   include/uapi/drm/amdxdna_accel.h | 19 +++

Re: [PATCH v2] drm/atmel_hlcdc: Fix uninitialized variable

2024-12-04 Thread Advait Dhamorikar
Hello, Just a gentle ping, this patch was never applied. Is there something more that needs to be done? Thanks and regards, Advait On Mon, 14 Oct 2024 at 13:08, Dmitry Baryshkov wrote: > > On Mon, Oct 07, 2024 at 08:39:04PM +0530, Advait Dhamorikar wrote: > > atmel_hlcdc_plane_update_buffers: m

Re: [PATCH V1 6/7] accel/amdxdna: Enhance power management settings

2024-12-04 Thread Mario Limonciello
On 12/4/2024 15:37, Lizhi Hou wrote: Add SET_STATE ioctl to configure device power mode for aie2 device. Three modes are supported initially. POWER_MODE_DEFAULT: Enable clock gating and set DPM (Dynamic Power Management) level to value which has been set by resource solver or maximum DPM level t

Re: [PATCH v1 7/7] drm/mediatek: Introduce HDMI/DDC v2 for MT8195/MT8188

2024-12-04 Thread 胡俊光

Re: [PATCH v1 6/7] drm/mediatek: mtk_hdmi: Split driver and add common probe function

2024-12-04 Thread 胡俊光

Re: [PATCH v1 7/7] drm/mediatek: Introduce HDMI/DDC v2 for MT8195/MT8188

2024-12-04 Thread 胡俊光

Re: [PATCH 3/5] drm/msm: mdss: Add QCS8300 support

2024-12-04 Thread Yongxing Mou
On 2024/11/30 2:55, Dmitry Baryshkov wrote: On Wed, Nov 27, 2024 at 03:05:03PM +0800, Yongxing Mou wrote: Add Mobile Display Subsystem (MDSS) support for the QCS8300 platform. Signed-off-by: Yongxing Mou --- drivers/gpu/drm/msm/msm_mdss.c | 11 +++ 1 file changed, 11 insertions(+

Re: [PATCH v1 7/7] drm/mediatek: Introduce HDMI/DDC v2 for MT8195/MT8188

2024-12-04 Thread 胡俊光

Re: [PATCH v2.1 1/1] kernel/cgroup: Add "dmem" memory accounting cgroup

2024-12-04 Thread kernel test robot
Hi Maarten, kernel test robot noticed the following build errors: [auto build test ERROR on tj-cgroup/for-next] [also build test ERROR on akpm-mm/mm-everything linus/master v6.13-rc1 next-20241204] [cannot apply to drm-misc/drm-misc-next drm-tip/drm-tip] [If your patch is applied to the wrong

Re: [PATCH v1 04/10] phy: phy-rockchip-samsung-hdptx: Add support for eDP mode

2024-12-04 Thread Damon Ding
Hi Sebastian, On 2024/12/2 22:41, Sebastian Reichel wrote: Hi, On Mon, Dec 02, 2024 at 11:28:13AM +0800, Damon Ding wrote: Hi, On 2024/12/2 6:59, Sebastian Reichel wrote: Hi, On Sat, Nov 30, 2024 at 09:25:12PM +0100, Heiko Stübner wrote: Am Freitag, 29. November 2024, 03:43:57 CET schrieb

Re: [PATCH v3 2/3] dt-bindings: display: rockchip: Add schema for RK3588 DW DSI2 controller

2024-12-04 Thread Andy Yan
Hi Heiko, On 12/4/24 00:54, Heiko Stuebner wrote: From: Heiko Stuebner The Display Serial Interface 2 (DSI-2) is part of a group of communication protocols defined by the MIPI Alliance. The RK3588 implements this specification in its two MIPI DSI-2 Host Controllers that are based on a new Syno

Re: [PATCH v3 00/11] driver core: Constify API device_find_child()

2024-12-04 Thread Zijun Hu
On 2024/12/5 08:10, Zijun Hu wrote: > This patch series is to constify the following API: This patch series is based on the lasted mainline commit Commit: feffde684ac2 ("Merge tag 'for-6.13-rc1-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux") to avoid potential conflict as much

[PATCH v3 11/11] usb: typec: class: Remove both cable_match() and partner_match()

2024-12-04 Thread Zijun Hu
From: Zijun Hu cable_match(), as matching function of device_find_child(), is to match a device with device type @typec_cable_dev_type, and is unnecessary. partner_match() is similar with cable_match() but with different device type @typec_partner_dev_type. Remove both functions and directly us

[PATCH v3 10/11] cxl/pmem: Remove match_nvdimm_bridge()

2024-12-04 Thread Zijun Hu
From: Zijun Hu match_nvdimm_bridge(), as matching function of device_find_child(), is to match a device with device type @cxl_nvdimm_bridge_type, and is unnecessary Remove it and use API device_match_type() plus the device type instead. Signed-off-by: Zijun Hu --- drivers/cxl/core/pmem.c | 9

[PATCH v3 09/11] driver core: Introduce an device matching API device_match_type()

2024-12-04 Thread Zijun Hu
From: Zijun Hu Introduce device_match_type() for purposes below: - Test if a device matches with a specified device type. - As argument of various device finding APIs to find a device with specified type. device_find_child() will use it to simplify operations later. Signed-off-by: Zijun Hu

[PATCH v3 08/11] gpio: sim: Remove gpio_sim_dev_match_fwnode()

2024-12-04 Thread Zijun Hu
From: Zijun Hu gpio_sim_dev_match_fwnode() is a simple wrapper of device_match_fwnode() Remvoe the unnecessary wrapper. Signed-off-by: Zijun Hu --- drivers/gpio/gpio-sim.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.

[PATCH v3 07/11] slimbus: core: Simplify of_find_slim_device() implementation

2024-12-04 Thread Zijun Hu
From: Zijun Hu Simplify of_find_slim_device() implementation by device_match_of_node(). Signed-off-by: Zijun Hu --- drivers/slimbus/core.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index ab927fd077cb4fe1e29c00

[PATCH v3 06/11] driver core: Remove match_any()

2024-12-04 Thread Zijun Hu
From: Zijun Hu Static match_any() is same as API device_match_any() Remove the former and use the later instead. Signed-off-by: Zijun Hu --- drivers/base/core.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index 8116bc8dd6

[PATCH v3 05/11] driver core: Simplify API device_find_child_by_name() implementation

2024-12-04 Thread Zijun Hu
From: Zijun Hu Simplify device_find_child_by_name() implementation by both existing API device_find_child() and device_match_name(). Signed-off-by: Zijun Hu --- drivers/base/core.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/base/core.c b/drivers/b

[PATCH v3 04/11] driver core: Constify API device_find_child() then adapt for various usages

2024-12-04 Thread Zijun Hu
From: Zijun Hu Constify the following API: struct device *device_find_child(struct device *dev, void *data, int (*match)(struct device *dev, void *data)); To : struct device *device_find_child(struct device *dev, const void *data, device_match_t ma

[PATCH v3 03/11] bus: fsl-mc: Constify fsl_mc_device_match()

2024-12-04 Thread Zijun Hu
From: Zijun Hu fsl_mc_device_match() does not modify caller's inputs. Constify it by simply changing its parameter types to const pointer. Signed-off-by: Zijun Hu --- drivers/bus/fsl-mc/dprc-driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/bus/fsl-mc/dp

[PATCH v3 02/11] slimbus: core: Constify slim_eaddr_equal()

2024-12-04 Thread Zijun Hu
From: Zijun Hu bool slim_eaddr_equal(struct slim_eaddr *a, struct slim_eaddr *b) does not modify @*a or @*b. Constify it by simply changing its parameter type to 'const struct slim_eaddr *'. Signed-off-by: Zijun Hu --- drivers/slimbus/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletio

[PATCH v3 01/11] libnvdimm: Simplify nd_namespace_store() implementation

2024-12-04 Thread Zijun Hu
From: Zijun Hu Simplify nd_namespace_store() implementation by device_find_child_by_name() Signed-off-by: Zijun Hu --- drivers/nvdimm/claim.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/nvdimm/claim.c b/drivers/nvdimm/claim.c index 030dbde6b0882050c90fb

[PATCH v3 00/11] driver core: Constify API device_find_child()

2024-12-04 Thread Zijun Hu
This patch series is to constify the following API: struct device *device_find_child(struct device *dev, void *data, int (*match)(struct device *dev, void *data)); To : struct device *device_find_child(struct device *dev, const void *data, device_mat

[Bug 219563] New: amdgpu graphical glitches on Thinkpad E14 G6 with panel self-refresh enabled

2024-12-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=219563 Bug ID: 219563 Summary: amdgpu graphical glitches on Thinkpad E14 G6 with panel self-refresh enabled Product: Drivers Version: 2.5 Hardware: AMD OS: Linux

Re: [PATCH v2 00/32] driver core: Constify API device_find_child() and adapt for various existing usages

2024-12-04 Thread Zijun Hu
On 2024/12/5 00:42, James Bottomley wrote:  introduce extra device_find_child_new() which is constified  -> use *_new() replace ALL device_find_child() instances one by one -> remove device_find_child() -> rename *_new() to device_find_child() once. >>> Why bother with the last

Re: [PATCH 00/10] compiler.h: refactor __is_constexpr() into is_const{,_true,_false}()

2024-12-04 Thread Kees Cook
On December 3, 2024 3:33:22 AM GMT+10:00, Vincent Mailhol via B4 Relay wrote: >This series is the spiritual successor of [1] which introduced >const_true(). In [1], following a comment from David Laight, Linus >came with a suggestion to simplify __is_constexpr() and its derived >macros using a

[PATCH AUTOSEL 6.11 12/15] drm/amdgpu/vcn: reset fw_shared when VCPU buffers corrupted on vcn v4.0.3

2024-12-04 Thread Sasha Levin
From: Xiang Liu [ Upstream commit 928cd772e18ffbd7723cb2361db4a8ccf235 ] It is not necessarily corrupted. When there is RAS fatal error, device memory access is blocked. Hence vcpu bo cannot be saved to system memory as in a regular suspend sequence before going for reset. In other full devi

[PATCH AUTOSEL 6.1 4/8] drm: display: Set fwnode for aux bus devices

2024-12-04 Thread Sasha Levin
From: Saravana Kannan [ Upstream commit fe2e59aa5d7077c5c564d55b7e2997e83710c314 ] fwnode needs to be set for a device for fw_devlink to be able to track/enforce its dependencies correctly. Without this, you'll see error messages like this when the supplier has probed and tries to make sure all

Re: [PATCH v3 1/1] drm/xe/guc/capture: Maintenence of devcoredump <-> GuC-Err-Capture plumbing

2024-12-04 Thread Dong, Zhanjun
LGTM Reviewed-by: Zhanjun Dong *Previous RB send to coverletter, resend to the patch itself. Regards, Zhanjun Dong On 2024-12-03 12:47 p.m., Alan Previn wrote: The order of the devcoredump event flow is: drm-scheduler -> guc-submission-execq-timed-out-job -> guc-submission-kill-job -> xe-dev

[PATCH AUTOSEL 6.6 04/10] drm: display: Set fwnode for aux bus devices

2024-12-04 Thread Sasha Levin
From: Saravana Kannan [ Upstream commit fe2e59aa5d7077c5c564d55b7e2997e83710c314 ] fwnode needs to be set for a device for fw_devlink to be able to track/enforce its dependencies correctly. Without this, you'll see error messages like this when the supplier has probed and tries to make sure all

[PATCH AUTOSEL 6.6 07/10] drm/amdgpu/vcn: reset fw_shared when VCPU buffers corrupted on vcn v4.0.3

2024-12-04 Thread Sasha Levin
From: Xiang Liu [ Upstream commit 928cd772e18ffbd7723cb2361db4a8ccf235 ] It is not necessarily corrupted. When there is RAS fatal error, device memory access is blocked. Hence vcpu bo cannot be saved to system memory as in a regular suspend sequence before going for reset. In other full devi

[PATCH AUTOSEL 6.11 08/15] drm: display: Set fwnode for aux bus devices

2024-12-04 Thread Sasha Levin
From: Saravana Kannan [ Upstream commit fe2e59aa5d7077c5c564d55b7e2997e83710c314 ] fwnode needs to be set for a device for fw_devlink to be able to track/enforce its dependencies correctly. Without this, you'll see error messages like this when the supplier has probed and tries to make sure all

[PATCH AUTOSEL 6.12 12/15] drm/amdgpu/vcn: reset fw_shared when VCPU buffers corrupted on vcn v4.0.3

2024-12-04 Thread Sasha Levin
From: Xiang Liu [ Upstream commit 928cd772e18ffbd7723cb2361db4a8ccf235 ] It is not necessarily corrupted. When there is RAS fatal error, device memory access is blocked. Hence vcpu bo cannot be saved to system memory as in a regular suspend sequence before going for reset. In other full devi

[PATCH AUTOSEL 6.12 08/15] drm: display: Set fwnode for aux bus devices

2024-12-04 Thread Sasha Levin
From: Saravana Kannan [ Upstream commit fe2e59aa5d7077c5c564d55b7e2997e83710c314 ] fwnode needs to be set for a device for fw_devlink to be able to track/enforce its dependencies correctly. Without this, you'll see error messages like this when the supplier has probed and tries to make sure all

Re: [PATCH 07/10] drm/msm/dp: use eld_mutex to protect access to connector->eld

2024-12-04 Thread Abhinav Kumar
On 12/3/2024 5:58 AM, Dmitry Baryshkov wrote: On Mon, Dec 02, 2024 at 07:27:45PM -0800, Abhinav Kumar wrote: On 11/30/2024 3:55 PM, Dmitry Baryshkov wrote: Reading access to connector->eld can happen at the same time the drm_edid_to_eld() updates the data. Take the newly added eld_mutex in

Re: [PATCH v5 7/9] drm/bridge_connector: hook drm_atomic_helper_connector_hdmi_update_edid()

2024-12-04 Thread Dmitry Baryshkov
On Wed, Dec 04, 2024 at 09:42:11AM +0200, Jani Nikula wrote: > On Wed, 04 Dec 2024, Dmitry Baryshkov wrote: > > On Tue, Dec 03, 2024 at 04:25:58PM +0200, Jani Nikula wrote: > >> On Sun, 01 Dec 2024, Dmitry Baryshkov wrote: > >> > +drm_edid = drm_bridge_edid_read(bridge, connector); > >> >

Re: [PATCH v2 3/3] drm: remove driver date from struct drm_driver and all drivers

2024-12-04 Thread Dmitry Baryshkov
On Wed, Dec 04, 2024 at 04:31:12PM +0200, Jani Nikula wrote: > We stopped using the driver initialized date in commit 7fb8af6798e8 > ("drm: deprecate driver date") and (eventually) started returning "0" > for drm_version ioctl instead. > > Finish the job, and remove the unused date member from str

Re: [PATCH v3 0/1] Maintenence of devcoredump <-> GuC-Err-Capture plumbing

2024-12-04 Thread Dong, Zhanjun
LGTM Reviewed-by: Zhanjun Dong On 2024-12-03 12:47 p.m., Alan Previn wrote: The GuC-Error-Capture is currently reaching into xe_devcoredump structure to store its own place-holder snaphot to workaround the race between G2H-Error-Capture-Notification vs Drm-Scheduler triggering GuC-Submission-e

Re: [PATCH V1 1/7] accel/amdxdna: Add device status for aie2 devices

2024-12-04 Thread Mario Limonciello
On 12/4/2024 15:37, Lizhi Hou wrote: Add device status to track if aie2_hw_start() or aie2_hw_stop() is re-entered. In aie2_hw_stop(), call drmm_kfree to free mbox. Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/aie2_pci.c| 17 + drivers/accel/amdxdna/aie2_pci.h

Re: [PATCH V1 5/7] accel/amdxdna: Add query firmware version

2024-12-04 Thread Mario Limonciello
On 12/4/2024 15:37, Lizhi Hou wrote: Enhance GET_INFO ioctl to support retrieving firmware version. Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/aie2_pci.c | 20 include/uapi/drm/amdxdna_accel.h | 19 +++ 2 files changed, 39 insertions(+) diff --g

Re: [PATCH v2] drm: bridge: fsl-ldb: fixup mode on freq mismatch

2024-12-04 Thread kernel test robot
Hi Nikolaus, kernel test robot noticed the following build warnings: [auto build test WARNING on linus/master] [also build test WARNING on drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip v6.13-rc1 next-20241204] [If your patch is applied to the wrong git tree, kindly

Re: [PATCH v2 1/2] drm/msm/adreno: Introduce ADRENO_QUIRK_NO_SYSCACHE

2024-12-04 Thread Rob Clark
On Wed, Dec 4, 2024 at 1:47 PM Rob Clark wrote: > > On Wed, Dec 4, 2024 at 11:04 AM Akhil P Oommen > wrote: > > > > On 12/1/2024 10:06 PM, Rob Clark wrote: > > > On Sat, Nov 30, 2024 at 12:30 PM Akhil P Oommen > > > wrote: > > >> > > >> On 11/30/2024 7:01 PM, Konrad Dybcio wrote: > > >>> On 25.

Re: [PATCH v2 1/2] drm/msm/adreno: Introduce ADRENO_QUIRK_NO_SYSCACHE

2024-12-04 Thread Rob Clark
On Wed, Dec 4, 2024 at 11:04 AM Akhil P Oommen wrote: > > On 12/1/2024 10:06 PM, Rob Clark wrote: > > On Sat, Nov 30, 2024 at 12:30 PM Akhil P Oommen > > wrote: > >> > >> On 11/30/2024 7:01 PM, Konrad Dybcio wrote: > >>> On 25.11.2024 5:33 PM, Akhil P Oommen wrote: > There are a few chipsets

Re: [PATCH RESEND v2] drm/i915: Fix memory leak by correcting cache object name in error handler

2024-12-04 Thread Andi Shyti
Hi Jiasheng, On Wed, Nov 27, 2024 at 08:10:42PM +, Jiasheng Jiang wrote: > From: Jiasheng Jiang > > Replace "slab_priorities" with "slab_dependencies" in the error handler > to avoid memory leak. > > Fixes: 32eb6bcfdda9 ("drm/i915: Make request allocation caches global") > Cc: # v5.2+ > Re

[PATCH V1 5/7] accel/amdxdna: Add query firmware version

2024-12-04 Thread Lizhi Hou
Enhance GET_INFO ioctl to support retrieving firmware version. Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/aie2_pci.c | 20 include/uapi/drm/amdxdna_accel.h | 19 +++ 2 files changed, 39 insertions(+) diff --git a/drivers/accel/amdxdna/aie2_pci.c b/dr

[PATCH V1 7/7] accel/amdxdna: Read firmware interface version from registers

2024-12-04 Thread Lizhi Hou
The latest released firmware supports reading firmware interface version from registers directly. The driver's probe routine reads the major and minor version numbers. If the firmware interface does not compatible with the driver, the driver's probe routine returns failure. Co-developed-by: Min Ma

[PATCH V1 6/7] accel/amdxdna: Enhance power management settings

2024-12-04 Thread Lizhi Hou
Add SET_STATE ioctl to configure device power mode for aie2 device. Three modes are supported initially. POWER_MODE_DEFAULT: Enable clock gating and set DPM (Dynamic Power Management) level to value which has been set by resource solver or maximum DPM level the device supports. POWER_MODE_HIGH: E

[PATCH V1 1/7] accel/amdxdna: Add device status for aie2 devices

2024-12-04 Thread Lizhi Hou
Add device status to track if aie2_hw_start() or aie2_hw_stop() is re-entered. In aie2_hw_stop(), call drmm_kfree to free mbox. Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/aie2_pci.c| 17 + drivers/accel/amdxdna/aie2_pci.h| 7 +++ drivers/accel/amdxdna

[PATCH V1 3/7] accel/amdxdna: Add RyzenAI-npu6 support

2024-12-04 Thread Lizhi Hou
Add NPU6 registers and other private configurations. Co-developed-by: Xiaoming Ren Signed-off-by: Xiaoming Ren Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/Makefile| 3 +- drivers/accel/amdxdna/npu6_regs.c | 121 ++ 2 files changed, 123 insertions(+), 1

[PATCH V1 4/7] accel/amdxdna: Replace idr api with xarray

2024-12-04 Thread Lizhi Hou
Switch mailbox message id and hardware context id management over from the idr api to the xarray api. Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/TODO | 1 - drivers/accel/amdxdna/aie2_ctx.c| 4 +- drivers/accel/amdxdna/aie2_message.c| 4 +- drivers/accel/amdxd

[PATCH V1 0/7] AMD NPU driver improvements

2024-12-04 Thread Lizhi Hou
Add recent improvements and bug fixes for amdxdna driver (depends on [1]) 1. Support recent hardware and firmware. 2. Replace idr APIs with xarray. 3. Fix the bugs been found. [1]: https://lore.kernel.org/all/20241118172942.2014541-1-lizhi@amd.com/ Lizhi Hou (7): accel/amdxdna: Add device s

[PATCH V1 2/7] accel/amdxdna: Replace mmput with mmput_async to avoid dead lock

2024-12-04 Thread Lizhi Hou
Hardware mailbox message receiving handler calls mmput to release the process mm. If the process has already exited, the mmput here may call mmu notifier handler, amdxdna_hmm_invalidate, which will cause a dead lock. Using mmput_async instead prevents this dead lock. Signed-off-by: Lizhi Hou ---

Re: [PATCH 02/10] compiler.h: add is_const() as a replacement of __is_constexpr()

2024-12-04 Thread Yury Norov
> > diff --git a/include/linux/compiler.h b/include/linux/compiler.h > > index > > a2a56a50dd85227a4fdc62236a2710ca37c5ba52..30ce06df4153cfdc0fad9bc7bffab9097f8b0450 > > 100644 > > --- a/include/linux/compiler.h > > +++ b/include/linux/compiler.h > > @@ -316,6 +316,47 @@ static inline void *offse

Re: [WIP RFC v2 05/35] rust: drm/kms: Add bindings for drm_connector

2024-12-04 Thread Lyude Paul
On Wed, 2024-12-04 at 16:16 -0500, Lyude Paul wrote: > > At least the inputs must be valid. Speaking of which, are there any > > restrictions on `type_` ? > > type_ should actually be the constants that you were looking at before. In > retrospect we probably should make a custom enum for it, I th

Re: [WIP RFC v2 05/35] rust: drm/kms: Add bindings for drm_connector

2024-12-04 Thread Lyude Paul
On Tue, 2024-11-26 at 18:25 -0300, Daniel Almeida wrote: > Hi Lyude, > > > On 30 Sep 2024, at 20:09, Lyude Paul wrote: > > > > We start off by introducing wrappers for the first important type of mode > > object: a DRM display connector. This introduces Connector > DriverConnector> and Connector

[RFC PATCH 0/2] drm/amd/display: address page fault caused by max surface mismatch

2024-12-04 Thread Melissa Wen
[Resending due to temporary mailing list server error on gabe.freedesktop.org - trying again to reach dri-devel and amd-gfx] Hi, This is another attempt to approach page fault error faced by Cosmic users of AMD display hw that exposes two overlay planes. It was first reported as an interface fre

[RFC PATCH 1/2] drm/amd/display: fix page fault due to max surface definition mismatch

2024-12-04 Thread Melissa Wen
DC driver is using two different values to define the maximum number of surfaces: MAX_SURFACES and MAX_SURFACE_NUM. Consolidate MAX_SURFACES as the unique definition for surface updates across DC. It fixes page fault faced by Cosmic users on AMD display versions that support two overlay planes, si

[RFC PATCH 2/2] drm/amd/display: increase MAX_SURFACES to the value supported by hw

2024-12-04 Thread Melissa Wen
As the hw supports up to 4 surfaces, increase the maximum number of surfaces to prevent the DC error when trying to use more than three planes. [drm:dc_state_add_plane [amdgpu]] *ERROR* Surface: can not attach plane_state 3e2cb82c! Maximum is: 3 Link: https://gitlab.freedesktop.org/drm/a

Re: [PATCH v2.1 1/1] kernel/cgroup: Add "dmem" memory accounting cgroup

2024-12-04 Thread kernel test robot
Hi Maarten, kernel test robot noticed the following build warnings: [auto build test WARNING on tj-cgroup/for-next] [also build test WARNING on akpm-mm/mm-everything linus/master v6.13-rc1 next-20241204] [cannot apply to drm-misc/drm-misc-next drm-tip/drm-tip] [If your patch is applied to the

Re: [PATCH] drm/ci: add kms_cursor_legacy@torture-bo to apq8016 flakes

2024-12-04 Thread Helen Mae Koike Fornazier
s.txt and > mistook that as the rate at which flakes are seen. > > Let me fix this up as 33% > > > Regards, > > Helen > > > > > +# IGT Version: 1.28-ga73311079 > > > +# Linux Version: 6.12.0-rc2 > > > +kms_cursor_legacy@torture-bo > > > > > > --- > > > base-commit: 798bb342e0416d846cf67f4725a3428f39bfb96b > > > change-id: 20241204-cursor_tor_skip-9d128dd62c4f > > > > > > Best regards, > > > -- > > > Abhinav Kumar quic_abhin...@quicinc.com> > > > > > > > > >

[PATCH v2] drm/ci: add kms_cursor_legacy@torture-bo to apq8016 flakes

2024-12-04 Thread Abhinav Kumar
msm/-/jobs/67677430 [3]: https://gitlab.freedesktop.org/drm/msm/-/pipelines/1322770 Signed-off-by: Abhinav Kumar --- Changes in v2: - Fix the failure rate from 100 to 33 as thats the accurate one - Link to v1: https://lore.kernel.org/r/20241204-cursor_tor_skip-v1-1-f5f0bba5d...@quicinc.

Re: [RFC PATCH v1 05/14] dt-bindings: clock: thead, th1520: Add support for Video Output subsystem

2024-12-04 Thread Stephen Boyd
Quoting Stephen Boyd (2024-12-04 12:21:11) > Quoting Michal Wilczynski (2024-12-04 02:11:26) > > > > To address this, I'll specify the 'reg' property in each node to define > > the address ranges explicitly fragmenting the address space for the VOSYS > > manually. > > > > vosys_clk: clock-control

Re: [RFC PATCH v1 05/14] dt-bindings: clock: thead, th1520: Add support for Video Output subsystem

2024-12-04 Thread Stephen Boyd
Quoting Michal Wilczynski (2024-12-04 02:11:26) > On 12/3/24 16:45, Krzysztof Kozlowski wrote: > > On 03/12/2024 14:41, Michal Wilczynski wrote: > > [1] - > https://openbeagle.org/beaglev-ahead/beaglev-ahead/-/blob/main/docs/TH1520%20Video%20Image%20Processing%20User%20Manual.pdf > > > >> +

Re: [PATCH] drm/ci: add kms_cursor_legacy@torture-bo to apq8016 flakes

2024-12-04 Thread Abhinav Kumar
Linux Version: 6.12.0-rc2 > +kms_cursor_legacy@torture-bo > > --- > base-commit: 798bb342e0416d846cf67f4725a3428f39bfb96b > change-id: 20241204-cursor_tor_skip-9d128dd62c4f > > Best regards, > -- > Abhinav Kumar quic_abhin...@quicinc.com> > >

Re: [PATCH 8/9] arm64: dts: renesas: r8a779h0: Add display support

2024-12-04 Thread Geert Uytterhoeven
Hi Tomi, On Wed, Dec 4, 2024 at 5:04 PM Tomi Valkeinen wrote: > On 03/12/2024 11:37, Laurent Pinchart wrote: > > On Tue, Dec 03, 2024 at 10:01:42AM +0200, Tomi Valkeinen wrote: > >> From: Tomi Valkeinen > >> > >> Add the device nodes for supporting DU and DSI. > >> > >> Signed-off-by: Tomi Valke

Re: [PATCH v3 2/7] drm/msm: adreno: add plumbing to generate bandwidth vote table for GMU

2024-12-04 Thread Akhil P Oommen
On 12/4/2024 9:05 PM, Neil Armstrong wrote: > On 02/12/2024 09:46, Neil Armstrong wrote: >> On 30/11/2024 22:49, Akhil P Oommen wrote: >>> On 11/28/2024 3:55 PM, Neil Armstrong wrote: The Adreno GPU Management Unit (GMU) can also scale DDR Bandwidth along the Frequency and Power Domain le

Re: [PATCH] drm/ci: add kms_cursor_legacy@torture-bo to apq8016 flakes

2024-12-04 Thread Helen Mae Koike Fornazier
e Rate: 100, maybe we should fix them as well) Regards, Helen > +# IGT Version: 1.28-ga73311079 > +# Linux Version: 6.12.0-rc2 > +kms_cursor_legacy@torture-bo > > --- > base-commit: 798bb342e0416d846cf67f4725a3428f39bfb96b > change-id: 20241204-cursor_tor_skip-9d128dd62c4f > > Best regards, > -- > Abhinav Kumar quic_abhin...@quicinc.com> > >

[ANNOUNCE] libdrm 2.4.124

2024-12-04 Thread Matt Turner
Alan Coopersmith (1): include/drm/README: update drm-next link to use gitlab instead of cgit Dmitry Baryshkov (2): modetest: simplify planar YUV handling modetest: add support for YUV422 and YUV444 plane format Marek Olšák (1): xf86drm: print AMD modifiers properly Marijn

Re: [PATCH 7/7] arm64: dts: broadcom: Fix device tree errors on BCM2712.

2024-12-04 Thread Florian Fainelli
On 12/2/24 07:24, Krzysztof Kozlowski wrote: On 02/12/2024 15:32, Dave Stevenson wrote: Resolves the issues on clocks and power nodes Which issues? Be specific. Such commit is unprecise and not really helpful. We see it from the diff that this is "some issue". What we do not see is WHY and WHA

Re: [PATCH 4/7] arm64: dts: broadcom: Fix device tree warnings for BCM2712 display pipeline

2024-12-04 Thread Florian Fainelli
On 12/2/24 07:20, Krzysztof Kozlowski wrote: On 02/12/2024 15:31, Dave Stevenson wrote: Fixes up errors on HDMI and interrupt controllers that weren't What errors? I can't find anything in the commit. Describe the error. noticed before merging. Fixes: de9bc2dba3db ("arm64: dts: broadcom: Ad

Re: [PATCH v2 1/2] drm/msm/adreno: Introduce ADRENO_QUIRK_NO_SYSCACHE

2024-12-04 Thread Akhil P Oommen
On 12/1/2024 10:06 PM, Rob Clark wrote: > On Sat, Nov 30, 2024 at 12:30 PM Akhil P Oommen > wrote: >> >> On 11/30/2024 7:01 PM, Konrad Dybcio wrote: >>> On 25.11.2024 5:33 PM, Akhil P Oommen wrote: There are a few chipsets which don't have system cache a.k.a LLC. Currently, the assumptio

RE: [PATCH 08/10] drm/i915/reg: replace __is_const_expr() by is_const_true() or is_const()

2024-12-04 Thread David Laight
From: Vincent Mailhol > Sent: 02 December 2024 17:34 > > Most of the use of __is_const_expr() in i915_reg_defs.h are just to > test whether an expression is known to be true. Because those checks > are all done in a BUILD_BUG_ON_ZERO(), replace those with > is_const_true(). Another place that cou

Re: [PATCH 8/9] arm64: dts: renesas: r8a779h0: Add display support

2024-12-04 Thread Tomi Valkeinen
Hi, On 03/12/2024 11:37, Laurent Pinchart wrote: Hi Tomi, Thank you for the patch. On Tue, Dec 03, 2024 at 10:01:42AM +0200, Tomi Valkeinen wrote: From: Tomi Valkeinen Add the device nodes for supporting DU and DSI. Signed-off-by: Tomi Valkeinen --- arch/arm64/boot/dts/renesas/r8a779h0.

Re: [PATCH v2 6/8] drm/panfrost: Make re-enabling job interrupts at device reset optional

2024-12-04 Thread Adrián Larumbe
Hi Boris, On 02.12.2024 12:20, Boris Brezillon wrote: > On Thu, 28 Nov 2024 21:06:21 + > Adrián Larumbe wrote: > > > Rather than remasking interrupts after a device reset in the main reset > > path, allow selecting whether to do this with an additional bool parameter. > > > > To this end, s

Re: [PATCH v2 00/32] driver core: Constify API device_find_child() and adapt for various existing usages

2024-12-04 Thread James Bottomley
On Wed, 2024-12-04 at 20:26 +0800, Zijun Hu wrote: > On 2024/12/3 23:34, James Bottomley wrote: > > > > This also enables an incremental migration. > > > change the API prototype from: > > > device_find_child(..., void *data_0, int (*match)(struct device > > > *dev, void *data)); > > > > > > to: >

Re: [PATCH v2 6/8] drm/panfrost: Make re-enabling job interrupts at device reset optional

2024-12-04 Thread Steven Price
On 04/12/2024 15:34, Adrián Larumbe wrote: > Hi Boris, > > On 02.12.2024 12:20, Boris Brezillon wrote: >> On Thu, 28 Nov 2024 21:06:21 + >> Adrián Larumbe wrote: >> >>> Rather than remasking interrupts after a device reset in the main reset >>> path, allow selecting whether to do this with an

[PATCH v2 0/3] fixes for udmabuf (memfd sealing checks and a leak)

2024-12-04 Thread Jann Horn
I have tested that patches 2 and 3 work using the following reproducers. I did not write a reproducer for the issue described in patch 1. Reproducer for F_SEAL_FUTURE_WRITE not being respected: ``` #define _GNU_SOURCE #include #include #include #include #include #include #include #define S

[PATCH v2 2/3] udmabuf: also check for F_SEAL_FUTURE_WRITE

2024-12-04 Thread Jann Horn
When F_SEAL_FUTURE_WRITE was introduced, it was overlooked that udmabuf must reject memfds with this flag, just like ones with F_SEAL_WRITE. Fix it by adding F_SEAL_FUTURE_WRITE to SEALS_DENIED. Fixes: ab3948f58ff8 ("mm/memfd: add an F_SEAL_FUTURE_WRITE seal to memfd") Cc: sta...@vger.kernel.org A

[PATCH v2 3/3] udmabuf: fix memory leak on last export_udmabuf() error path

2024-12-04 Thread Jann Horn
In export_udmabuf(), if dma_buf_fd() fails because the FD table is full, a dma_buf owning the udmabuf has already been created; but the error handling in udmabuf_create() will tear down the udmabuf without doing anything about the containing dma_buf. This leaves a dma_buf in memory that contains a

[PATCH v2 1/3] udmabuf: fix racy memfd sealing check

2024-12-04 Thread Jann Horn
The current check_memfd_seals() is racy: Since we first do check_memfd_seals() and then udmabuf_pin_folios() without holding any relevant lock across both, F_SEAL_WRITE can be set in between. This is problematic because we can end up holding pins to pages in a write-sealed memfd. Fix it using the

RE: [PATCH 01/10] drm/fourcc: Add warning for bad bpp

2024-12-04 Thread Sagar, Vishal
[AMD Official Use Only - AMD Internal Distribution Only] Hi Tomi, Thanks for the patch. > -Original Message- > From: Tomi Valkeinen > Sent: Wednesday, December 4, 2024 10:31 AM > To: Sagar, Vishal ; Klymenko, Anatoliy > ; Maarten Lankhorst > ; Maxime Ripard ; > Thomas Zimmermann ; David

Re: [PATCH 3/3] udmabuf: fix memory leak on last export_udmabuf() error path

2024-12-04 Thread Jann Horn
On Wed, Dec 4, 2024 at 10:14 AM Kasireddy, Vivek wrote: > > Subject: [PATCH 3/3] udmabuf: fix memory leak on last export_udmabuf() > > error path > > > > In export_udmabuf(), if dma_buf_fd() fails because the FD table is full, a > > dma_buf owning the udmabuf has already been created; but the erro

Re: [PATCH 4.19 000/138] 4.19.325-rc1 review

2024-12-04 Thread Naresh Kamboju
On Wed, 4 Dec 2024 at 19:24, Naresh Kamboju wrote: > > On Tue, 3 Dec 2024 at 20:04, Greg Kroah-Hartman > wrote: > > > > -- > > Note, this is the LAST 4.19.y kernel to be released. After this one, it > > is end-of-life. It's been 6 years, everyone should have moved off of it > >

Re: [PATCH 1/3] udmabuf: fix racy memfd sealing check

2024-12-04 Thread Jann Horn
On Wed, Dec 4, 2024 at 10:09 AM Kasireddy, Vivek wrote: > > Subject: [PATCH 1/3] udmabuf: fix racy memfd sealing check > > > > The current check_memfd_seals() is racy: Since we first do > > check_memfd_seals() and then udmabuf_pin_folios() without holding any > > relevant lock across both, F_SEAL_

[PATCH v9 6/6] drm/log: Add integer scaling support

2024-12-04 Thread Jocelyn Falempe
Add a module parameter, to increase the font size for HiDPI screen. Even with CONFIG_FONT_TER16x32, it can still be a bit small to read. In this case, adding drm_log.scale=2 to your kernel command line will double the character size. Signed-off-by: Jocelyn Falempe Reviewed-by: Thomas Zimmermann

[PATCH v9 3/6] drm/log: Do not draw if drm_master is taken

2024-12-04 Thread Jocelyn Falempe
When userspace takes drm_master, the drm_client buffer is no more visible, so drm_log shouldn't waste CPU cycle to draw on it. Signed-off-by: Jocelyn Falempe Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/clients/drm_log.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) di

[PATCH v9 5/6] drm/log: Implement suspend/resume

2024-12-04 Thread Jocelyn Falempe
Normally the console is already suspended when the graphic driver suspend callback is called, but if the parameter no_console_suspend is set, it might still be active. So call console_stop()/console_start() in the suspend/resume callbacks, to make sure it won't try to write to the framebuffer while

[PATCH v9 4/6] drm/log: Color the timestamp, to improve readability

2024-12-04 Thread Jocelyn Falempe
Color the timesamp prefix, similar to dmesg. Signed-off-by: Jocelyn Falempe Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/clients/drm_log.c | 27 +-- 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/clients/drm_log.c b/drivers/gpu/drm/

[PATCH v9 0/6] drm/log: Introduce a new boot logger to draw the kmsg on the screen

2024-12-04 Thread Jocelyn Falempe
drm_log is a simple logger that uses the drm_client API to print the kmsg boot log on the screen. This is not a full replacement to fbcon, as it will only print the kmsg. It will never handle user input, or a terminal because this is better done in userspace. If you're curious on how it looks li

  1   2   >