Re: [PATCH v3 1/4] tee: add restricted memory allocation

2024-12-02 Thread Sumit Garg
Hi Jens, On Thu, 28 Nov 2024 at 20:39, Jens Wiklander wrote: > > Add restricted memory allocation to the TEE subsystem. Restricted memory > is not be accessible by kernel during normal circumstances. A new ioctl s/not be accessible/not accessible/ How about if we reword it as follows? Rest

Re: [PATCH] drm: bridge: fsl-ldb: fixup mode on freq mismatch

2024-12-02 Thread Nikolaus Voss
On 03.12.2024 03:22, Liu Ying wrote: On 12/02/2024, Nikolaus Voss wrote: [You don't often get email from n...@vosn.de. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Hi Liu, Hi, On 02.12.2024 07:32, Liu Ying wrote: On 11/27/2024, Nikolaus Voss wrote: LDB

Re: [PATCH v1 7/7] drm/mediatek: Introduce HDMI/DDC v2 for MT8195/MT8188

2024-12-02 Thread 胡俊光

Re: [PATCH v2] Documentation: dma-buf: heaps: Add heap name definitions

2024-12-02 Thread Maxime Ripard
Hi John, On Mon, Dec 02, 2024 at 11:12:23AM -0800, John Stultz wrote: > On Mon, Dec 2, 2024 at 3:58 AM Maxime Ripard wrote: > > > > Following a recent discussion at last Plumbers, John Stultz, Sumit > > Sewal, TJ Mercier and I came to an agreement that we should document > > what the dma-buf heap

Re: [PATCH] drm: bridge: fsl-ldb: fixup mode on freq mismatch

2024-12-02 Thread Nikolaus Voss
On 03.12.2024 04:12, Marek Vasut wrote: On 12/3/24 3:22 AM, Liu Ying wrote: [...] I doubt that pixel clock tree cannot find appropriate division ratios for some pixel clock rates, especially for dual-link LVDS on i.MX8MP and i.MX93 platforms, because PLL clock rate should be 7x faster than

Re: [PATCH v5 04/10] drm/display: hdmi: add generic mode_valid helper

2024-12-02 Thread Maxime Ripard
On Sat, 30 Nov 2024 03:52:29 +0200, Dmitry Baryshkov wrote: > Add drm_hdmi_connector_mode_valid(), generic helper for HDMI connectors. > It can be either used directly or as a part of the .mode_valid callback. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Maxime Ripard Thanks! Maxime

[PATCHv6 09/10] drm/i915/histogram: Histogram changes for Display 20+

2024-12-02 Thread Arun R Murthy
In Display 20+, new registers are added for setting index, reading histogram and writing the IET. v2: Removed duplicate code (Jani) v3: Moved histogram core changes to earlier patches (Jani/Suraj) v4: Rebased after addressing comments on patch 1 v5: Added the retry logic from patch3 and rebased th

[PATCH 07/10] drm/i915/display: handle drm-crtc histogram property updates

2024-12-02 Thread Arun R Murthy
Check for any updates on drm_crtc property histogram_enable and histogram_iet_updated and call/act accordingly to update histogram or update the image enhancement LUT data API defined in i915 histogram. Signed-off-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_atomic.c | 1 + driver

[PATCH 10/10] drm/i915/histogram: Enable pipe dithering

2024-12-02 Thread Arun R Murthy
Enable pipe dithering while enabling histogram to overcome some atrifacts seen on the screen. Signed-off-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_histogram.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_histogram.c b/drivers/

[PATCH 05/10] drm/xe: Add histogram support to Xe builds

2024-12-02 Thread Arun R Murthy
Histogram added as part of i915/display driver. Adding the same for xe as well. Signed-off-by: Arun R Murthy Reviewed-by: Suraj Kandpal --- drivers/gpu/drm/xe/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile index a93e6fcc0ad

[PATCH 01/10] drm/crtc: Add histogram properties

2024-12-02 Thread Arun R Murthy
Add variables for histogram drm_property, its corrsponding crtc_state variables and define the structure pointed by the blob property. Signed-off-by: Arun R Murthy --- include/drm/drm_crtc.h | 48 + include/uapi/drm/drm_mode.h | 11 + 2 files chan

[PATCHv3 08/10] drm/i915/histogram: histogram delay counter doesnt reset

2024-12-02 Thread Arun R Murthy
The delay counter for histogram does not reset and as a result the histogram bin never gets updated. Workaround would be to use save and restore histogram register. v2: Follow the seq in interrupt handler Restore DPST bit 0 read/write dpst ctl rg Restore DPST bit 1 and Guar

[PATCHv5 06/10] drm/i915/histogram: histogram interrupt handling

2024-12-02 Thread Arun R Murthy
Upon enabling histogram an interrupt is trigerred after the generation of the statistics. This patch registers the histogram interrupt and handles the interrupt. v2: Added intel_crtc backpointer to intel_histogram struct (Jani) Removed histogram_wq and instead use dev_priv->unodered_eq (Jani)

[PATCHv5 04/10] drm/i915/histogram: Add support for histogram

2024-12-02 Thread Arun R Murthy
Statistics is generated from the image frame that is coming to display and an event is sent to user after reading this histogram data. This statistics/histogram is then shared with the user upon getting a request from user. User can then use this histogram and generate an enhancement factor. This e

[PATCHv2 03/10] drm/i915/histogram: Define registers for histogram

2024-12-02 Thread Arun R Murthy
Add the register/bit definitions for global histogram. v2: Intended the register contents, removed unused regs (Jani) Bspec: 4270 Signed-off-by: Arun R Murthy Reviewed-by: Suraj Kandpal --- .../drm/i915/display/intel_histogram_regs.h | 48 +++ 1 file changed, 48 insertions(+)

[PATCH 02/10] drm/crtc: Expose API to create drm crtc property for histogram

2024-12-02 Thread Arun R Murthy
Add drm-crtc property for histogram and for the properties added add corresponding get/set_property. Signed-off-by: Arun R Murthy --- drivers/gpu/drm/drm_atomic_state_helper.c | 6 + drivers/gpu/drm/drm_atomic_uapi.c | 17 + drivers/gpu/drm/drm_crtc.c| 30

[PATCHv9 00/10] Display Global Histogram

2024-12-02 Thread Arun R Murthy
Display histogram is a hardware functionality where a statistics for 'x' number of frames is generated to form a histogram data. This is notified to the user via histogram event. Compositor will then upon sensing the histogram event will read the histogram data from KMD via crtc property. A library

Re: [PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

2024-12-02 Thread Simona Vetter
On Tue, Nov 26, 2024 at 06:18:56PM +0200, Imre Deak wrote: > Atm when the connector is added to the drm_mode_config::connector_list, > the connector may not be fully initialized yet. This is not a problem > for user space, which will see the connector only after it's registered > later, it could be

[PATCH 7/7] arm64: dts: broadcom: Fix device tree errors on BCM2712.

2024-12-02 Thread Dave Stevenson
Resolves the issues on clocks and power nodes Fixes: 4254a647b6c9 ("arm64: dts: broadcom: Add firmware clocks and power nodes to Pi5 DT") Signed-off-by: Dave Stevenson --- arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[PATCH v6 2/2] misc: fastrpc: Rename tgid and pid to client_id

2024-12-02 Thread Ekansh Gupta
The information passed as request tgid and pid is actually the client id of the process. This client id is used as an identifier by DSP to identify the DSP PD corresponding to the process. Currently process tgid is getting passed as the identifier which is getting replaced by a custom client id. Re

[PATCH v6 0/2] Add changes to use session index as identifier

2024-12-02 Thread Ekansh Gupta
This patch series carries changes to use a masked session index as an identifier instead of process tgid to support mutiple PDs from same process. Patch [v5]: https://lore.kernel.org/all/20241202064806.1164800-1-quic_ekang...@quicinc.com/ Changes in v6: - Add single-line comment. Changes in v5:

[PATCH v6 1/2] misc: fastrpc: Add support for multiple PD from one process

2024-12-02 Thread Ekansh Gupta
Memory intensive applications(which requires more tha 4GB) that wants to offload tasks to DSP might have to split the tasks to multiple user PD to make the resources available. For every call to DSP, fastrpc driver passes the process tgid which works as an identifier for the DSP to enqueue the tas

Re: [PATCH v1 4/4] misc: fastrpc: Add debugfs support for fastrpc

2024-12-02 Thread Ekansh Gupta
On 12/2/2024 6:18 PM, Dmitry Baryshkov wrote: > On Mon, Dec 02, 2024 at 03:27:43PM +0530, Ekansh Gupta wrote: >> >> On 11/22/2024 12:23 AM, Dmitry Baryshkov wrote: >>> On Thu, Nov 21, 2024 at 12:12:17PM +0530, Ekansh Gupta wrote: On 11/18/2024 7:32 PM, Greg KH wrote: > On Mon, Nov 18, 2

Re: [PATCH] drm/panel: visionox-rm69299: Remove redundant assignments of panel fields

2024-12-02 Thread Chen-Yu Tsai
On Mon, Dec 2, 2024 at 8:50 PM Dmitry Baryshkov wrote: > > On Mon, Dec 02, 2024 at 02:24:48PM +0800, Chen-Yu Tsai wrote: > > drm_panel_init() was made to initialize the fields in |struct drm_panel|. > > There is no need to separately initialize them again. > > > > Drop the separate assignments tha

Re: [PATCH v10 1/4] drm: Introduce device wedged event

2024-12-02 Thread Raag Jadav
On Mon, Dec 02, 2024 at 10:07:59AM +0200, Raag Jadav wrote: > On Fri, Nov 29, 2024 at 10:40:14AM -0300, André Almeida wrote: > > Hi Raag, > > > > Em 28/11/2024 12:37, Raag Jadav escreveu: > > > Introduce device wedged event, which notifies userspace of 'wedged' > > > (hanged/unusable) state of the

Re: [PATCH] drm/msm/hdmi: simplify code in pll_get_integloop_gain

2024-12-02 Thread Abhinav Kumar
On 11/11/2024 11:41 PM, Rex Nie wrote: In pll_get_integloop_gain(), digclk_divsel=1 or 2, base=63 or 196ULL, so the base may be 63, 126, 196, 392. The condition base <= 2046 always true. Fixes: caedbf17c48d ("drm/msm: add msm8998 hdmi phy/pll support") Signed-off-by: Rex Nie --- drivers/gp

[PATCH 01/11] tools headers: Sync uapi/drm/drm.h with the kernel sources

2024-12-02 Thread Namhyung Kim
To pick up the changes in this cset: 56c594d8df64e726 ("drm: add DRM_SET_CLIENT_NAME ioctl") This addresses these perf build warnings: Warning: Kernel ABI header differences: diff -u tools/include/uapi/drm/drm.h include/uapi/drm/drm.h Please see tools/include/uapi/README for further det

Re: [PATCH] drm: bridge: fsl-ldb: fixup mode on freq mismatch

2024-12-02 Thread Marek Vasut
On 12/3/24 3:22 AM, Liu Ying wrote: [...] I doubt that pixel clock tree cannot find appropriate division ratios for some pixel clock rates, especially for dual-link LVDS on i.MX8MP and i.MX93 platforms, because PLL clock rate should be 7x faster than pixel clock rate and 2x faster than "ldb" cl

Re: [PATCH v2] dt-bindings: display/msm: qcom, sa8775p-mdss: fix the example

2024-12-02 Thread Abhinav Kumar
On 12/2/2024 3:21 AM, Krzysztof Kozlowski wrote: On 12/11/2024 20:16, Abhinav Kumar wrote: On 11/12/2024 5:15 AM, Dmitry Baryshkov wrote: On Tue, 12 Nov 2024 at 05:40, Abhinav Kumar wrote: On 11/11/2024 7:21 PM, Dmitry Baryshkov wrote: Add p1 region to the list of DP registers in the

[PATCH v2 1/1] drm/xe/guc/capture: Maintenence of devcoredump <-> GuC-Err-Capture plumbing

2024-12-02 Thread Alan Previn
The order of the devcoredump event flow is: drm-scheduler -> guc-submission-execq-timed-out-job -> guc-submission-kill-job -> xe-devcoredump (once the work is confirmed to have been killed). As we are aware, the GuC-FW IRQ for error-capture delivery and extraction could have happened before the st

[PATCH v2 0/1] Maintenence of devcoredump <-> GuC-Err-Capture plumbing

2024-12-02 Thread Alan Previn
The GuC-Error-Capture is currently reaching into xe_devcoredump structure to store its own place-holder snaphot to workaround the race between G2H-Error-Capture-Notification vs Drm-Scheduler triggering GuC-Submission-exec-queue-timeout/kill. Part of that race workaround design included GuC-Error-C

[PATCH 2/4] dt-bindings: display: msm: dp-controller: document clock parents better

2024-12-02 Thread Abhinav Kumar
Document the assigned-clock-parents better for the DP controller node to indicate its functionality better. Signed-off-by: Abhinav Kumar --- Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devi

[PATCH 3/4] dt-bindings: display/msm: add stream 1 pixel clock binding

2024-12-02 Thread Abhinav Kumar
On some chipsets the display port controller can support more than one pixel stream (multi-stream transport). To support MST on such chipsets, add the binding for stream 1 pixel clock for display port controller. Since this mode is not supported on all chipsets, add exception rules and min/max item

[PATCH 0/4] dt-bindings: msm/dp: add support for pixel clock to driver another stream

2024-12-02 Thread Abhinav Kumar
: 798bb342e0416d846cf67f4725a3428f39bfb96b change-id: 20241202-dp_mst_bindings-7536ffc9ae2f Best regards, -- Abhinav Kumar

[PATCH 1/4] dt-bindings: display: msm: dp-controller: document pixel clock stream

2024-12-02 Thread Abhinav Kumar
Display port controller on some MSM chipsets are capable of supporting multiple streams. In order to distinguish the streams better, describe the current pixel clock better to emphasize that it drives the stream 0. Signed-off-by: Abhinav Kumar --- Documentation/devicetree/bindings/display/msm/dp

[PATCH 4/4] dt-bindings: display: msm: dp: update maintainer entry

2024-12-02 Thread Abhinav Kumar
Add myself as maintainer for dp controller yaml as to support review of the incoming changes. Signed-off-by: Abhinav Kumar --- Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm/dp-con

Re: [PATCH 07/10] drm/msm/dp: use eld_mutex to protect access to connector->eld

2024-12-02 Thread Abhinav Kumar
On 11/30/2024 3:55 PM, Dmitry Baryshkov wrote: Reading access to connector->eld can happen at the same time the drm_edid_to_eld() updates the data. Take the newly added eld_mutex in order to protect connector->eld from concurrent access. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/

Re: [RFC PATCH] drm/bridge: panel: Use devm_drm_bridge_add()

2024-12-02 Thread Sui Jingfeng
Hi, On 2024/12/2 18:12, Maxime Ripard wrote: On Fri, Nov 29, 2024 at 11:24:18PM +0800, Sui Jingfeng wrote: Hi, On 2024/11/29 22:54, Maxime Ripard wrote: On Fri, Nov 29, 2024 at 10:12:02PM +0800, Sui Jingfeng wrote: Hi, On 2024/11/29 18:51, Maxime Ripard wrote: On Wed, Nov 27, 2024 at 05:58

Re: [PATCH 1/1] drm/xe/guc/capture: Maintenence of devcoredump <-> GuC-Err-Capture plumbing

2024-12-02 Thread Teres Alexis, Alan Previn
On Tue, 2024-11-26 at 12:09 -0500, Dong, Zhanjun wrote: > See my comments inline below: > > Regards, > Zhanjun > > On 2024-11-17 1:44 p.m., Alan Previn wrote: > > The order of the devcoredump event flow is: > > drm-scheduler -> guc-submission-execq-timed-out-job -> > > guc-submission-kill-job ->

Re: [PATCH v2] drm: Drop explicit initialization of struct i2c_device_id::driver_data to 0

2024-12-02 Thread Liu Ying
On 12/02/2024, Uwe Kleine-König wrote: > These drivers don't use the driver_data member of struct i2c_device_id, > so don't explicitly initialize this member. > > This prepares putting driver_data in an anonymous union which requires > either no initialization or named designators. But it's also a

Re: [PATCH] drm/msm/dpu: fix x1e80100 intf_6 underrun/vsync interrupt

2024-12-02 Thread Abhinav Kumar
On 11/15/2024 4:55 AM, Stephan Gerhold wrote: The IRQ indexes for the intf_6 underrun/vsync interrupts are swapped. DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 16) is the actual underrun interrupt and DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 17) is the vsync interrupt. This causes timeout errors when using the DP

Re: [PATCH v2 02/14] drm/msm/dp: fix msm_dp_utils_pack_sdp_header interface

2024-12-02 Thread Abhinav Kumar
On 12/2/2024 2:06 AM, Dmitry Baryshkov wrote: The msm_dp_utils_pack_sdp_header() accepts an unlimited-size u32 pointer for the header output, while it expects a two-element array. It performs a sizeof check which is always true on 64-bit platforms (since sizeof(u32*) is 8) and is always falce

Re: [PATCH v2 01/14] drm/msm/dp: set safe_to_exit_level before printing it

2024-12-02 Thread Abhinav Kumar
On 12/2/2024 2:06 AM, Dmitry Baryshkov wrote: Rather than printing random garbage from stack and pretending that it is the default safe_to_exit_level, set the variable beforehand. Fixes: d13e36d7d222 ("drm/msm/dp: add audio support for Display Port on MSM") Reported-by: kernel test robot Clo

Re: [PATCH v2 00/32] driver core: Constify API device_find_child() and adapt for various existing usages

2024-12-02 Thread quic_zijuhu
On 12/3/2024 8:33 AM, Zijun Hu wrote: > This patch series is to constify the following API: > struct device *device_find_child(struct device *dev, void *data, > int (*match)(struct device *dev, void *data)); > To : > struct device *device_find_child(struct device *dev, const void *dat

Re: [PATCH] drm: bridge: fsl-ldb: fixup mode on freq mismatch

2024-12-02 Thread Liu Ying
On 12/02/2024, Nikolaus Voss wrote: > [You don't often get email from n...@vosn.de. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > Hi Liu, Hi, > > On 02.12.2024 07:32, Liu Ying wrote: >> On 11/27/2024, Nikolaus Voss wrote: >>> LDB clock has to be a fixed m

Re: [PATCH v2] drm: Drop explicit initialization of struct i2c_device_id::driver_data to 0

2024-12-02 Thread Doug Anderson
Hi, On Mon, Dec 2, 2024 at 3:47 AM Uwe Kleine-König wrote: > > These drivers don't use the driver_data member of struct i2c_device_id, > so don't explicitly initialize this member. > > This prepares putting driver_data in an anonymous union which requires > either no initialization or named desig

[PATCH v2 11/32] libnvdimm: Simplify nd_namespace_store() implementation

2024-12-02 Thread Zijun Hu
From: Zijun Hu Simplify nd_namespace_store() implementation by device_find_child_by_name() Signed-off-by: Zijun Hu --- drivers/nvdimm/claim.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/nvdimm/claim.c b/drivers/nvdimm/claim.c index 030dbde6b0882050c90fb

[PATCH v2 10/32] nvdimm: Adapt for constified device_find_child()

2024-12-02 Thread Zijun Hu
From: Zijun Hu device_find_child() has been constified to take new match function type: typedef int (*device_match_t)(struct device *dev, const void *data); Make match_dimm() take a const pointer to adapt for the new type. Signed-off-by: Zijun Hu --- drivers/nvdimm/bus.c | 2 +- 1 file change

[PATCH v2 09/32] pwm: Adapt for constified device_find_child()

2024-12-02 Thread Zijun Hu
From: Zijun Hu device_find_child() has been constified to take new match function type: typedef int (*device_match_t)(struct device *dev, const void *data); Make pwm_unexport_match() take a const pointer to adapt for the new type. Signed-off-by: Zijun Hu --- drivers/pwm/core.c | 2 +- 1 file

[PATCH 0/4] drm/msm/dp: ST_DISPLAY_OFF hpd cleanup

2024-12-02 Thread Abhinav Kumar
file changed, 2 insertions(+), 21 deletions(-) --- base-commit: 798bb342e0416d846cf67f4725a3428f39bfb96b change-id: 20241202-hpd_display_off-6051aa510f23 Best regards, -- Abhinav Kumar

[PATCH 2/4] drm/msm/dp: remove redundant ST_DISPLAY_OFF checks in msm_dp_bridge_atomic_enable()

2024-12-02 Thread Abhinav Kumar
The checks in msm_dp_display_prepare() for making sure that we are in ST_DISPLAY_OFF OR ST_MAINLINK_READY seem redundant. DRM fwk shall not issue any commits if state is not ST_MAINLINK_READY as msm_dp's atomic_check callback returns a failure if state is not ST_MAINLINK_READY. For the ST_DISPLA

[PATCH v2 08/32] net: dsa: Adapt for constified device_find_child()

2024-12-02 Thread Zijun Hu
From: Zijun Hu device_find_child() has been constified to take new match function type: typedef int (*device_match_t)(struct device *dev, const void *data); Make dev_is_class() take a const pointer to adapt for the new type. Signed-off-by: Zijun Hu --- net/dsa/dsa.c | 2 +- 1 file changed, 1

[PATCH 1/4] drm/msm/dp: remove redundant checks related to ST_DISPLAY_OFF in plug/irq_ipd handlers

2024-12-02 Thread Abhinav Kumar
In commit 8ede2ecc3e5ee ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets"), checks were introduced to avoid handling any plug or irq hpd events in ST_DISPLAY_OFF state. Even if we do get hpd events, after the bridge was disabled, it should get handled. Moreover, its unclear under what

[PATCH 4/4] drm/msm/dp: remove ST_DISPLAY_OFF as a hpd_state

2024-12-02 Thread Abhinav Kumar
ST_DISPLAY_OFF check in msm_dp_bridge_atomic_enable() is used to check that if the display was disabled while still hotplugged, phy needs to be re-initialized. This can be replaced with a different check as it just means the hpd_state was still ST_CONNECTED but without display being powered on. Rep

[PATCH 3/4] drm/msm/dp: replace ST_DISPLAY_OFF with power_on in msm_dp_hpd_unplug_handle()

2024-12-02 Thread Abhinav Kumar
msm_dp_hpd_unplug_handle() checks if the display was already disabled and if so does not transition to ST_DISCONNECT_PENDING state and goes directly to ST_DISCONNECTED. The same result can be achieved with the !power_on check. Replace ST_DISPLAY_OFF with !power_on to achieve the same outcome. Sig

[PATCH v2 07/32] gpio: sim: Remove gpio_sim_dev_match_fwnode()

2024-12-02 Thread Zijun Hu
From: Zijun Hu device_find_child() has been constified to take new match function type: typedef int (*device_match_t)(struct device *dev, const void *data); So device_match_fwnode() is applicable for the new type directly, and remove its unnecessary wrapper gpio_sim_dev_match_fwnode(). Signed-o

[PATCH v2 06/32] thunderbolt: Adapt for constified device_find_child()

2024-12-02 Thread Zijun Hu
From: Zijun Hu device_find_child() has been constified to take new match function type: typedef int (*device_match_t)(struct device *dev, const void *data); Make its match functions take a const pointer to adapt for the new type. Signed-off-by: Zijun Hu --- drivers/thunderbolt/retimer.c | 2 +

[PATCH v2 05/32] media: pci: mgb4: Adapt for constified device_find_child()

2024-12-02 Thread Zijun Hu
From: Zijun Hu device_find_child() has been constified to take new match function type: typedef int (*device_match_t)(struct device *dev, const void *data); Make its match functions take a const pointer to adapt for the new type. Signed-off-by: Zijun Hu --- drivers/media/pci/mgb4/mgb4_core.c

[PATCH v2 04/32] hwmon: Adapt for constified device_find_child()

2024-12-02 Thread Zijun Hu
From: Zijun Hu device_find_child() has been constified to take new match function type: typedef int (*device_match_t)(struct device *dev, const void *data); Make hwmon_match_device() take a const pointer to adapt for the new type. Signed-off-by: Zijun Hu --- drivers/hwmon/hwmon.c | 2 +- 1 fi

[PATCH v2 03/32] drm/mediatek: Adapt for constified device_find_child()

2024-12-02 Thread Zijun Hu
From: Zijun Hu device_find_child() has been constified to take new match function type: typedef int (*device_match_t)(struct device *dev, const void *data); Make mtk_drm_match() take a const pointer to adapt for the new type. Signed-off-by: Zijun Hu --- drivers/gpu/drm/mediatek/mtk_drm_drv.c

[PATCH v2 02/32] driver core: Introduce device_match_type() to match device with a device type

2024-12-02 Thread Zijun Hu
From: Zijun Hu Introduce device_match_type() to simplify operations below: - Test if a device matches with specified device type. - Find a device with specified device type via various device finding APIs. device_find_child() will use it as argument to simplify operations later. Signed-off-by:

[PATCH v2 01/32] driver core: Constify API device_find_child()

2024-12-02 Thread Zijun Hu
From: Zijun Hu Constify the following API: struct device *device_find_child(struct device *dev, void *data, int (*match)(struct device *dev, void *data)); To : struct device *device_find_child(struct device *dev, const void *data, device_match_t ma

[PATCH v2 00/32] driver core: Constify API device_find_child() and adapt for various existing usages

2024-12-02 Thread Zijun Hu
This patch series is to constify the following API: struct device *device_find_child(struct device *dev, void *data, int (*match)(struct device *dev, void *data)); To : struct device *device_find_child(struct device *dev, const void *data, device_mat

Re: [PATCH 6/7] arm: dts: broadcom: Add interrupt-controller flag for intc on BCM2711

2024-12-02 Thread Stefan Wahren
Hi Dave, Am 02.12.24 um 15:31 schrieb Dave Stevenson: BCM2711 DT was producing dtbinding validation errors of interrupt-controller@4000: 'interrupt-controller' is a required property interrupt-controller@4000: '#interrupt-cells' is a required property Fix them by adding the required fl

[PATCH 05/10] minmax: simplify __clamp_once() by using is_const_false()

2024-12-02 Thread Vincent Mailhol via B4 Relay
From: Vincent Mailhol In __clamp_once(), __builtin_choose_expr(__is_constexpr((lo) > (hi)), (lo) <= (hi), true) is equivalent to: !is_const_false((lo) <= (hi)) Apply is_const_false() to simplify __clamp_once(). Signed-off-by: Vincent Mailhol --- include/linux/minmax.h | 3 +-- 1 file c

Re: [PATCH] drm: bridge: fsl-ldb: fixup mode on freq mismatch

2024-12-02 Thread Nikolaus Voss
On 02.12.2024 13:56, Marek Vasut wrote: On 12/2/24 7:32 AM, Liu Ying wrote: On 11/27/2024, Nikolaus Voss wrote: LDB clock has to be a fixed multiple of the pixel clock. As LDB and pixel clock are derived from different clock sources (at least on imx8mp), this constraint cannot be satisfied for

[PATCH 09/10] coresight: etm4x: replace __is_const_expr() by is_const()

2024-12-02 Thread Vincent Mailhol via B4 Relay
From: Vincent Mailhol is_const() is a one to one replacement of __is_constexpr(). Do the replacement so that __is_constexpr() can be removed. Refer to [1] for an explaination of why __builtin_constant_p() can not be used as a replacement here. [1] commit 4d45bc82df66 ("coresight: etm4x: avoid b

Re: [PATCH 1/7] dtbindings: display: bcm2711-hdmi: Correct bindings for 2712

2024-12-02 Thread Rob Herring (Arm)
kdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241202-dt-bcm2712-fixes-v1-1-fac67cc2f...@raspberrypi.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and

Re: [PATCH] drm/amdgpu: device: fix spellos and punctuation

2024-12-02 Thread Alex Deucher
Applied. Thanks! On Wed, Nov 27, 2024 at 11:17 PM Randy Dunlap wrote: > > Make spelling and punctuation changes to ease reading of the comments. > > Signed-off-by: Randy Dunlap > Cc: Alex Deucher > Cc: Christian König > Cc: Xinhui Pan > Cc: amd-...@lists.freedesktop.org > Cc: David Airlie >

Re: [PATCH] drm: amd: Fix potential NULL pointer dereference in atomctrl_get_smc_sclk_range_table

2024-12-02 Thread Alex Deucher
On Mon, Dec 2, 2024 at 3:27 AM Ivan Stepchenko wrote: > > The function atomctrl_get_smc_sclk_range_table() does not check the return > value of smu_atom_get_data_table(). If smu_atom_get_data_table() fails to > retrieve SMU_Info table, it returns NULL which is later dereferenced. > > Found by Linu

Re: [PATCH v2 3/4] drm/panel-edp: Add unknown BOE panel for HP Omnibook X14

2024-12-02 Thread Doug Anderson
Hi, On Sat, Nov 30, 2024 at 11:09 AM Jens Glathe via B4 Relay wrote: > > From: Jens Glathe > > Seems to be like NV140DRM-N61 but with touch. Haven't disassembled > the lid to look. > > Due to lack of information, use the delay_200_500_e200 timings like > many other BOE panels do for now. > > The

[PATCH 2/7] dtbindings: display: Fix BCM2835 HVS bindings for BCM2712

2024-12-02 Thread Dave Stevenson
The previous patch adding the compatible string missed out that the number of interrupts and clocks changed with BCM2712 too. Update to validate clock and interrupts for the variants. Fixes: 6cfcbe548a3a ("dt-bindings: display: Add BCM2712 HVS bindings") Signed-off-by: Dave Stevenson --- .../bi

Re: [PATCH 09/10] drm/sti: hdmi: use eld_mutex to protect access to connector->eld

2024-12-02 Thread Raphaël Gallais-Pou
Le 01/12/2024 à 00:55, Dmitry Baryshkov a écrit : Reading access to connector->eld can happen at the same time the drm_edid_to_eld() updates the data. Take the newly added eld_mutex in order to protect connector->eld from concurrent access. Signed-off-by: Dmitry Baryshkov Hi Dmitry, Acked

Re: [PATCH v1 04/10] phy: phy-rockchip-samsung-hdptx: Add support for eDP mode

2024-12-02 Thread Sebastian Reichel
Hi, On Mon, Dec 02, 2024 at 11:28:13AM +0800, Damon Ding wrote: > Hi, > > On 2024/12/2 6:59, Sebastian Reichel wrote: > > Hi, > > > > On Sat, Nov 30, 2024 at 09:25:12PM +0100, Heiko Stübner wrote: > > > Am Freitag, 29. November 2024, 03:43:57 CET schrieb Damon Ding: > > > > On 2024/11/27 19:04,

[PATCH 5/7] arm64: dts: broadcom: Add interrupt-controller flag for intc on BCM2712

2024-12-02 Thread Dave Stevenson
BCM2712 DT was producing dtbinding validation errors of interrupt-controller@7cd0: 'interrupt-controller' is a required property interrupt-controller@7cd0: '#interrupt-cells' is a required property Fix them by adding the required flags. Signed-off-by: Dave Stevenson --- arch/arm64/boot

Re: [PATCH] drm/connector: Allow clearing hdr infoframe

2024-12-02 Thread Derek Foreman
On 2024-11-29 17:40, Dmitry Baryshkov wrote: On Fri, Nov 29, 2024 at 03:38:01PM -0600, Derek Foreman wrote: When a display isn't presenting HDR content, the infoframe shouldn't be present at all. Currently if we set the HDR_OUTPUT_METADATA blob, we'll set a Dynamic Range and Mastering (DRM) info

[PATCH 3/7] dt-bindings: gpio: brcmstb: add gpio-line-name

2024-12-02 Thread Dave Stevenson
Support comes from gpiolib, so permit it through the binding. Signed-off-by: Dave Stevenson --- Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.yaml b/Documentation/devic

Re: [PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

2024-12-02 Thread Imre Deak
On Mon, Dec 02, 2024 at 04:07:56PM +0100, Maxime Ripard wrote: > On Mon, Dec 02, 2024 at 03:24:43PM +0200, Imre Deak wrote: > > On Mon, Dec 02, 2024 at 02:07:36PM +0200, Jani Nikula wrote: > > > On Mon, 02 Dec 2024, Maxime Ripard wrote: > > > > It's not about whether we have a problem or not: you

[PATCH 0/7] drm/vc4: Fixup DT and DT binding issues from recent patchset

2024-12-02 Thread Dave Stevenson
I missed the DT errors from the recent patchset[1] (DT patches in linux-next via Florian, DRM bindings patches on dri-misc-next) as Rob's bot report got spam filtered, so this is a fixup set. Largely it was changes to number of interrupts or clocks in the bindings, so those are now covered. I've

Re: [PATCH 5/7] arm64: dts: broadcom: Add interrupt-controller flag for intc on BCM2712

2024-12-02 Thread Krzysztof Kozlowski
On 02/12/2024 15:31, Dave Stevenson wrote: > BCM2712 DT was producing dtbinding validation errors of s/DT/DTS/ No one uses term like "dtbinding". Use full make target name or DT schema. > > interrupt-controller@7cd0: 'interrupt-controller' is a required > property > interrupt-controller@7cd

Re: [PATCH v2] drm: Drop explicit initialization of struct i2c_device_id::driver_data to 0

2024-12-02 Thread Thomas Zimmermann
Am 02.12.24 um 12:47 schrieb Uwe Kleine-König: These drivers don't use the driver_data member of struct i2c_device_id, so don't explicitly initialize this member. This prepares putting driver_data in an anonymous union which requires either no initialization or named designators. But it's al

Re: [PATCH v2 09/21] drm/etnaviv: Convert timeouts to secs_to_jiffies()

2024-12-02 Thread Christian Gmeiner
> > Changes made with the following Coccinelle rules: > > @@ constant C; @@ > > - msecs_to_jiffies(C * 1000) > + secs_to_jiffies(C) > > @@ constant C; @@ > > - msecs_to_jiffies(C * MSEC_PER_SEC) > + secs_to_jiffies(C) > > Signed-off-by: Easwar Hariharan Reviewed-by: Christian Gmeiner > --- > d

[PATCH 2/3] drm/msm/dp: do not touch the MMSS_DP_INTF_CONFIG for tpg

2024-12-02 Thread Abhinav Kumar
MMSS_DP_INTF_CONFIG has already been setup by the main datapath for DP to account for widebus to be used/unused etc. In current implementation, TPG only switches the DP controller to use the main datapath stream OR use the test pattern but expects the rest of the controller to be already setup. K

[PATCH 3/3] drm/msm/dp: add a debugfs node for using tpg

2024-12-02 Thread Abhinav Kumar
DP test pattern generator is a very useful tool to debug issues where monitor is showing incorrect output as it helps to isolate whether the issue is due to rest of DPU pipeline or in the DP controller itself. Expose a debugfs to use the TPG configuration to help debug DP issues. Signed-off-by: Ab

[PATCH 0/3] drm/msm/dp: Fix and utilize TPG with a debugfs

2024-12-02 Thread Abhinav Kumar
| 61 + drivers/gpu/drm/msm/dp/dp_panel.h | 2 ++ 3 files changed, 76 insertions(+), 2 deletions(-) --- base-commit: 798bb342e0416d846cf67f4725a3428f39bfb96b change-id: 20241202-tpg-3f7543c036ac Best regards, -- Abhinav Kumar

[PATCH 1/3] drm/msm/dp: account for widebus in msm_dp_catalog_panel_tpg_enable()

2024-12-02 Thread Abhinav Kumar
Adjust the h_active calculation to account for widebus in tpg. Fixes: 757a2f36ab09 ("drm/msm/dp: enable widebus feature for display port") Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_catalog.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drive

[PATCH] drm/rockchip: dw_hdmi_qp: Simplify clock handling

2024-12-02 Thread Cristian Ciocaltea
break; } } - hdmi->ref_clk = clk; + if (!hdmi->ref_clk) { + drm_err(hdmi, "Missing ref clock\n"); + return -EINVAL; + } hdmi->enable_gpio = devm_gpiod_get_optional(hdmi->dev, "enable",

Re: [PATCH] drm/connector: Allow clearing HDMI infoframes

2024-12-02 Thread Dmitry Baryshkov
On Mon, Dec 02, 2024 at 12:19:39PM -0600, Derek Foreman wrote: > Our infoframe setting code currently lacks the ability to clear > infoframes. For some of the infoframes, we only need to replace them, > so if an error occurred when generating a new infoframe we would leave > a stale frame instead o

Re: [PATCH 2/7] dtbindings: display: Fix BCM2835 HVS bindings for BCM2712

2024-12-02 Thread Krzysztof Kozlowski
On 02/12/2024 15:31, Dave Stevenson wrote: > The previous patch adding the compatible string missed out that > the number of interrupts and clocks changed with BCM2712 too. > > Update to validate clock and interrupts for the variants. > > Fixes: 6cfcbe548a3a ("dt-bindings: display: Add BCM2712 HV

RE: [PATCH] drm/dp_mst: Fix drm RAD print

2024-12-02 Thread Lin, Wayne
[Public] Hi Imre, Thanks for your time and suggestions! I'll adjust it and send out v2 later. Thanks, Wayne > -Original Message- > From: Imre Deak > Sent: Saturday, November 30, 2024 4:24 AM > To: Lin, Wayne > Cc: dri-devel@lists.freedesktop.org; ly...@redhat.com; Ville Syrjälä > ; We

Re: [PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

2024-12-02 Thread Imre Deak
On Mon, Dec 02, 2024 at 05:35:34PM +0100, Simona Vetter wrote: > On Tue, Nov 26, 2024 at 06:18:56PM +0200, Imre Deak wrote: > > Atm when the connector is added to the drm_mode_config::connector_list, > > the connector may not be fully initialized yet. This is not a problem > > for user space, which

Re: [PATCH 3/7] dt-bindings: gpio: brcmstb: add gpio-line-name

2024-12-02 Thread Krzysztof Kozlowski
On 02/12/2024 15:31, Dave Stevenson wrote: > Support comes from gpiolib, so permit it through the binding. > > Signed-off-by: Dave Stevenson > --- > Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/

Re: [PATCH] drm/xe/vm_doc: fix more doc typos

2024-12-02 Thread Rodrigo Vivi
On Wed, Nov 27, 2024 at 07:58:59PM -0800, Randy Dunlap wrote: > Fix all typos in xe_vm_doc.h as reported by codespell. > > Signed-off-by: Randy Dunlap > Cc: Lucas De Marchi > Cc: Thomas Hellström > Cc: Rodrigo Vivi > Cc: intel...@lists.freedesktop.org > Cc: David Airlie > Cc: Simona Vetter >

Re: [PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

2024-12-02 Thread Maxime Ripard
On Mon, Dec 02, 2024 at 02:07:36PM +0200, Jani Nikula wrote: > On Mon, 02 Dec 2024, Maxime Ripard wrote: > > It's not about whether we have a problem or not: you introduce new > > framework functions, you need to have kunit tests to check their > > behaviour. > > I don't fundamentally disagree wi

Re: [PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

2024-12-02 Thread Maxime Ripard
On Mon, Dec 02, 2024 at 03:24:43PM +0200, Imre Deak wrote: > On Mon, Dec 02, 2024 at 02:07:36PM +0200, Jani Nikula wrote: > > On Mon, 02 Dec 2024, Maxime Ripard wrote: > > > It's not about whether we have a problem or not: you introduce new > > > framework functions, you need to have kunit tests t

Re: [PATCH v5 2/9] ASoC: hdmi-codec: move no_capture_mute to struct hdmi_codec_pdata

2024-12-02 Thread Dmitry Baryshkov
On Mon, Dec 02, 2024 at 01:06:09PM +0100, Maxime Ripard wrote: > Hi, > > On Sun, Dec 01, 2024 at 02:44:06AM +0200, Dmitry Baryshkov wrote: > > The no_capture_mute flag might differ from platform to platform, > > especially in the case of the wrapping implementations, like the > > upcoming DRM HDMI

Re: [PATCH v2 RESEND 3/3] i2c: i2c-qcom-geni: Add Block event interrupt support

2024-12-02 Thread Jyothi Kumar Seerapu
On 11/21/2024 6:28 PM, Jyothi Kumar Seerapu wrote: On 11/12/2024 10:03 AM, Bjorn Andersson wrote: On Mon, Nov 11, 2024 at 07:32:44PM +0530, Jyothi Kumar Seerapu wrote: The I2C driver gets an interrupt upon transfer completion. For multiple messages in a single transfer, N interrupts will b

Re: [PATCH v5] drm/virtio: Add drm_panic support

2024-12-02 Thread Dmitry Osipenko
On 11/29/24 15:24, Ryosuke Yasuoka wrote: > +static int virtio_drm_get_scanout_buffer(struct drm_plane *plane, > + struct drm_scanout_buffer *sb) > +{ > + struct virtio_gpu_object *bo; > + > + if (!plane->state || !plane->state->fb || !plane->state-

Re: [PATCH] drm: bridge: fsl-ldb: fixup mode on freq mismatch

2024-12-02 Thread Marek Vasut
On 12/2/24 6:03 PM, Nikolaus Voss wrote: On 02.12.2024 13:56, Marek Vasut wrote: On 12/2/24 7:32 AM, Liu Ying wrote: On 11/27/2024, Nikolaus Voss wrote: LDB clock has to be a fixed multiple of the pixel clock. As LDB and pixel clock are derived from different clock sources (at least on imx8mp)

Re: 6.13-rc1 graphics fail

2024-12-02 Thread Thomas Hellström
Hi, On Mon, 2024-12-02 at 13:40 -0500, Genes Lists wrote: > > 6.12.1 on same system with same userspace works fine (as did 6.12) > while 6.13-rc1 boots, but without working graphics using gnome with > wayland. > > Laptop is raptor lake with Intel XE (lspci attached). > No kernel errors are logge

  1   2   3   >