Re: [PATCH RESEND v9 1/2] drm/atomic: Let drivers decide which planes to async flip

2024-11-02 Thread Christopher Snowhill
On Fri Nov 1, 2024 at 11:23 AM PDT, André Almeida wrote: > Currently, DRM atomic uAPI allows only primary planes to be flipped > asynchronously. However, each driver might be able to perform async > flips in other different plane types. To enable drivers to set their own > restrictions on which typ

Re: [PATCH RESEND v9 1/2] drm/atomic: Let drivers decide which planes to async flip

2024-11-02 Thread Dmitry Baryshkov
On Fri, Nov 01, 2024 at 03:23:47PM -0300, André Almeida wrote: > Currently, DRM atomic uAPI allows only primary planes to be flipped > asynchronously. However, each driver might be able to perform async > flips in other different plane types. To enable drivers to set their own > restrictions on whi

Re: [PATCH v2 2/3] drm/sysfs: Remove device type drm_sysfs_device_minor

2024-11-02 Thread Dmitry Baryshkov
On Sat, Nov 02, 2024 at 10:47:25PM +0100, Heiner Kallweit wrote: > Only user of this device type was struct dev_pm_ops of drm_class which > was removed in d14d2a8453d6 ("drm: Remove dev_pm_ops from drm_class"). > So remove this now unused device type. > > Signed-off-by: Heiner Kallweit > --- > d

Re: [PATCH v2 3/3] drm/sysfs: Constify struct drm_sysfs_device_connector

2024-11-02 Thread Dmitry Baryshkov
On Sat, Nov 02, 2024 at 10:48:42PM +0100, Heiner Kallweit wrote: > Constify struct drm_sysfs_device_connector to eliminate the risk of code > trying to change it. > > Signed-off-by: Heiner Kallweit > --- > drivers/gpu/drm/drm_sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Re

Re: [PATCH v2 1/3] proc_pid_fdinfo.5: Reduce indent for most of the page

2024-11-02 Thread G. Branden Robinson
Hi Alex, At 2024-11-02T11:39:37+0100, Alejandro Colomar wrote: > And diffs are a real win for text. Thus, semantic newlines are a real > win for text. "Write poems, not prose." (Any chance we may get that > warning added to groff(1)? :D) Yes, but I've kicked it out to groff 1.25 because a gif

Re: [PATCH v2 1/3] proc_pid_fdinfo.5: Reduce indent for most of the page

2024-11-02 Thread Colin Watson
On Sat, Nov 02, 2024 at 07:50:23PM -0500, G. Branden Robinson wrote: > At 2024-11-02T19:06:53+, Colin Watson wrote: > > How embarrassing. Could somebody please file a bug on > > https://gitlab.com/man-db/man-db/-/issues to remind me to fix that? > > Done;

Re: [PATCH v2 1/3] proc_pid_fdinfo.5: Reduce indent for most of the page

2024-11-02 Thread Colin Watson
(now with some local vim macros fixed to stop accidentally corrupting the To: lines of some of my outgoing emails ...) On Sat, Nov 02, 2024 at 08:09:29PM -0500, G. Branden Robinson wrote: > At 2024-11-03T00:47:23+, Colin Watson wrote: > > and the fact that the NAME section has both semantic an

Re: [PATCH v2 1/3] proc_pid_fdinfo.5: Reduce indent for most of the page

2024-11-02 Thread G. Branden Robinson
Hi Colin, At 2024-11-03T00:47:23+, Colin Watson wrote: > (That's leaving aside things like localized man pages, which I know > some folks on the groff list tend to sniff I can think of only one, the maintainer of a rival formatter. ;-) > at but I think they're important, Me too. I agree w

Re: [PATCH v2 1/3] proc_pid_fdinfo.5: Reduce indent for most of the page

2024-11-02 Thread G. Branden Robinson
Hi Colin, At 2024-11-02T19:06:53+, Colin Watson wrote: > How embarrassing. Could somebody please file a bug on > https://gitlab.com/man-db/man-db/-/issues to remind me to fix that? Done; . > lexgrog(1) is a useful (if oddly-named, sorry) debuggi

Re: [PATCH v2 1/3] proc_pid_fdinfo.5: Reduce indent for most of the page

2024-11-02 Thread Colin Watson
On Sun, Nov 03, 2024 at 01:05:34AM +0100, Alejandro Colomar wrote: > Are you sure? With a small tweak, I get the following comparison: > > alx@devuan:~/src/linux/man-pages/man-pages/main$ time lexgrog man/*/* | > wc > lexgrog: can't resolve man7/groff_man.7 > 12475 99295 9

Re: [PATCH v2 1/3] proc_pid_fdinfo.5: Reduce indent for most of the page

2024-11-02 Thread Alejandro Colomar
On Sun, Nov 03, 2024 at 01:05:42AM +0100, Alejandro Colomar wrote: > Hi Colin, > > On Sat, Nov 02, 2024 at 11:47:14PM +, Colin Watson wrote: > > On Sat, Nov 02, 2024 at 10:36:20PM +0100, Alejandro Colomar wrote: > > > This is quite naive, and will not work with pages that define their own > >

Re: [PATCH v2 1/3] proc_pid_fdinfo.5: Reduce indent for most of the page

2024-11-02 Thread Alejandro Colomar
Hi Colin, On Sat, Nov 02, 2024 at 11:47:14PM +, Colin Watson wrote: > On Sat, Nov 02, 2024 at 10:36:20PM +0100, Alejandro Colomar wrote: > > This is quite naive, and will not work with pages that define their own > > stuff, since this script is not groff(1). But it should be as fast as > > is

Re: [PATCH v2 1/3] proc_pid_fdinfo.5: Reduce indent for most of the page

2024-11-02 Thread Colin Watson
On Sat, Nov 02, 2024 at 10:36:20PM +0100, Alejandro Colomar wrote: > This is quite naive, and will not work with pages that define their own > stuff, since this script is not groff(1). But it should be as fast as > is possible, which is what Colin wants, is as simple as it can be (and > thus relat

Re: [PATCH v2 1/3] proc_pid_fdinfo.5: Reduce indent for most of the page

2024-11-02 Thread Colin Watson
On Sat, Nov 02, 2024 at 05:08:37AM -0500, G. Branden Robinson wrote: > On GNU/Linux systems, the only man page indexer I know of is Colin > Watson's man-db--specifically, its mandb(8) program. But it's nicely > designed so that the "topic and summary description extraction" task is > delegated to

Re: [PATCH v3 2/4] proc_pid_fdinfo.5: Make pid clearer in the name and 1st paragraph

2024-11-02 Thread G. Branden Robinson
Hi Ian, At 2024-11-01T12:11:54-0700, Ian Rogers wrote: > diff --git a/man/man5/proc_pid_fdinfo.5 b/man/man5/proc_pid_fdinfo.5 > index 87e6dbe56..935b54b4c 100644 > --- a/man/man5/proc_pid_fdinfo.5 > +++ b/man/man5/proc_pid_fdinfo.5 [...] > -this is a subdirectory containing one entry for each file

Re: [PATCH v4 3/4] proc_pid_fdinfo.5: Add subsection headers for different fd types

2024-11-02 Thread G. Branden Robinson
Hi Ian, At 2024-11-01T14:18:29-0700, Ian Rogers wrote: > Make the sections about eventfd, epoll, signalfd, inotify, fanotify, > timerfd better separated with a clearer subsection header. > > Signed-off-by: Ian Rogers [...] > +.SS eventfd > .P [...] > +.SS epoll > .P [...] > +.SS signalfd > .P

Re: [PATCH v2 1/3] proc_pid_fdinfo.5: Reduce indent for most of the page

2024-11-02 Thread G. Branden Robinson
[adding Colin Watson to CC; and the groff list because I started musing] Hi Alex, At 2024-11-01T21:07:29+0100, Alejandro Colomar wrote: > > > > -/proc/pid/fdinfo/ \- information about file descriptors > > > > +.IR /proc/ pid /fdinfo " \- information about file descriptors" > > > > > > I wouldn't

Re: [PATCH v3 4/4] proc_pid_fdinfo.5: Add DRM subsection

2024-11-02 Thread G. Branden Robinson
Hi Ian, At 2024-11-01T12:11:56-0700, Ian Rogers wrote: [...] > +.EX > +pos:0 > +flags: 0212 > +mnt_id: 26 > +ino:284 > +drm-driver: i915 > +drm-client-id: 39 > +drm-pdev: :00:02.0 > +drm-total-system0: 6044 KiB > +drm-shared-system0: 0 > +drm-active-system0:

[PATCH v2 0/3] drm: Series with core improvements/refactorings

2024-11-02 Thread Heiner Kallweit
Series with DRM core improvements/refactorings. v2: - Improve commit descriptions - Partially split patches - Remove patches from the series which need more clarification Heiner Kallweit (3): drm/sysfs: Drop unused drm_class_device_(un)register drm/sysfs: Remove device type drm_sysfs_device_m

[PATCH v2 3/3] drm/sysfs: Constify struct drm_sysfs_device_connector

2024-11-02 Thread Heiner Kallweit
Constify struct drm_sysfs_device_connector to eliminate the risk of code trying to change it. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/drm_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c index 82e2d0c

[PATCH v2 2/3] drm/sysfs: Remove device type drm_sysfs_device_minor

2024-11-02 Thread Heiner Kallweit
Only user of this device type was struct dev_pm_ops of drm_class which was removed in d14d2a8453d6 ("drm: Remove dev_pm_ops from drm_class"). So remove this now unused device type. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/drm_sysfs.c | 5 - 1 file changed, 5 deletions(-) diff --gi

[PATCH v2 1/3] drm/sysfs: Drop unused drm_class_device_(un)register

2024-11-02 Thread Heiner Kallweit
Only user of these functions was TTM code which dropped sysfs interfaces in commit ed89fff97382 ("drm/ttm: drop sysfs directory"). So remove these now unused functions. Reviewed-by: Dmitry Baryshkov Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/drm_sysfs.c | 32

Re: [PATCH v2 1/3] proc_pid_fdinfo.5: Reduce indent for most of the page

2024-11-02 Thread Alejandro Colomar
Hi Branden, Colin, On Sat, Nov 02, 2024 at 11:40:13AM +0100, Alejandro Colomar wrote: > > I also of course have ideas for generalizing the feature, so that you > > can request any (sub)section by name, and, with a bit more ambition,[4] > > paragraph tags (`TP`) too. > > > > So you could do things

Re: [PATCH 4/6] drm: Change drm_class from pointer to const struct class

2024-11-02 Thread Heiner Kallweit
On 22.09.2024 17:11, Dmitry Baryshkov wrote: > On Sun, Sep 08, 2024 at 02:11:25PM GMT, Heiner Kallweit wrote: >> Define class drm statically and constify it. This ensure that no user >> of the exported struct class can tamper with it. >> >> Signed-off-by: Heiner Kallweit >> --- >> drivers/gpu/drm

Re: [PATCH v3] drm/etnaviv: Request pages from DMA32 zone on addressing_limited

2024-11-02 Thread Sui Jingfeng
Hi, On 2024/10/1 20:17, Lucas Stach wrote: Hi Xiaolei, Am Dienstag, dem 03.09.2024 um 10:08 +0800 schrieb Xiaolei Wang: Remove __GFP_HIGHMEM when requesting a page from DMA32 zone, and since all vivante GPUs in the system will share the same DMA constraints, move the check of whether to get a

Re: [PATCH v3] drm/etnaviv: Request pages from DMA32 zone on addressing_limited

2024-11-02 Thread Sui Jingfeng
Hi, I forget to mention that the commit title should be "on addressing limited devices", the underscore between the last two words is not necessary. It's a typo when reply email. On 2024/10/1 20:32, xiaolei wang wrote: On 10/1/24 20:17, Lucas Stach wrote: CAUTION: This email comes from a

Re: [PATCH] fbdev: udl: Make CONFIG_FB_DEVICE optional

2024-11-02 Thread Helge Deller
On 11/1/24 09:19, Thomas Zimmermann wrote: Am 30.10.24 um 10:30 schrieb Helge Deller: I'm happy to get rid of the fbdev drivers, but for that DRM really needs to allow some sort of native fillrect, copyarea and imageblt operations so that we can get performance back on the old cards when impleme

Re: [PATCH v2 1/3] proc_pid_fdinfo.5: Reduce indent for most of the page

2024-11-02 Thread Alejandro Colomar
Hi Branden, On Sat, Nov 02, 2024 at 05:08:37AM -0500, G. Branden Robinson wrote: > [adding Colin Watson to CC; and the groff list because I started musing] > > Hi Alex, > > At 2024-11-01T21:07:29+0100, Alejandro Colomar wrote: > > > > > -/proc/pid/fdinfo/ \- information about file descriptors >

[PATCH] drm/etnaviv: etnaviv_cmdbuf.c: Drop the unneeded 'etnaviv_perfmon.h' header

2024-11-02 Thread Sui Jingfeng
The etnaviv_perfmon.h header is about performance monitor, it can hardly has something to do with command buffer suballocator. Drop it. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/etnaviv/etnaviv_cmdbuf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_cmdb

Re: [PATCH v4 3/4] proc_pid_fdinfo.5: Add subsection headers for different fd types

2024-11-02 Thread Alejandro Colomar
Hi Branden, Ian, On Sat, Nov 02, 2024 at 04:20:07AM -0500, G. Branden Robinson wrote: > Hi Ian, > > At 2024-11-01T14:18:29-0700, Ian Rogers wrote: > > Make the sections about eventfd, epoll, signalfd, inotify, fanotify, > > timerfd better separated with a clearer subsection header. > > > > Signe

Re: [PATCH v4 1/4] proc_pid_fdinfo.5: Reduce indent for most of the page

2024-11-02 Thread Alejandro Colomar
Hi Ian, On Fri, Nov 01, 2024 at 02:18:27PM -0700, Ian Rogers wrote: > When /proc/pid/fdinfo was part of proc.5 man page the indentation made > sense. As a standalone man page the indentation doesn't need to be so > far over to the right. Remove the initial tagged pragraph, move the > "since Linux

[PATCH] drm/msm/dpu: rework documentation comments

2024-11-02 Thread Dmitry Baryshkov
Unfortunately the tooling doesn't check documents placed before funciton prototypes. Such comments frequently become outdated, miss several params, etc. Move documentation for the functions to be placed before the actual function body, allowing 'make W=1' to actually check these comments and report