RE: [PATCH v4 08/13] dt-bindings: display: Document dual-link LVDS display common properties

2024-10-28 Thread Biju Das
Hi Liu Ying, > -Original Message- > From: Liu Ying > Sent: 29 October 2024 06:17 > Subject: Re: [PATCH v4 08/13] dt-bindings: display: Document dual-link LVDS > display common properties > > On 10/28/2024, Liu Ying wrote: > > Dual-link LVDS displays receive odd pixels and even pixels se

Re: [PATCH v2 03/29] mm/migrate: Trylock device page in do_swap_page

2024-10-28 Thread Alistair Popple
Matthew Brost writes: > On Thu, Oct 17, 2024 at 12:51:08PM +1100, Alistair Popple wrote: >> >> Matthew Brost writes: >> >> > On Wed, Oct 16, 2024 at 03:00:08PM +1100, Alistair Popple wrote: >> >> >> >> Matthew Brost writes: >> >> >> >> > Avoid multiple CPU page faults to the same device p

Re: [PATCH v1 05/10] media: platform: mediatek: add isp_7x camsys unit

2024-10-28 Thread 胡俊光

RE: [PATCH v2 2/5] drm/virtio: Add a helper to map and note the dma addrs and lengths

2024-10-28 Thread Kasireddy, Vivek
Hi Dmitry, > Subject: Re: [PATCH v2 2/5] drm/virtio: Add a helper to map and note the > dma addrs and lengths > > +long virtgpu_dma_buf_import_sgt(struct virtio_gpu_mem_entry > >> **ents, > > + unsigned int *nents, > > + struc

Re: [PATCH] drm/xe: Fix build error for XE_IOCTL_DBG macro

2024-10-28 Thread gyeyoung
Thank you for your review, I missed how && work. I will revise a patch that print only when cond is true. sincerely, Gyeyoung baek On Tue, Oct 29, 2024 at 4:47 AM Lucas De Marchi wrote: > > On Sun, Oct 27, 2024 at 01:57:52PM +0900, Gyeyoung Baek wrote: > >In the previous code, there is build err

Re: [PATCH v4 08/13] dt-bindings: display: Document dual-link LVDS display common properties

2024-10-28 Thread Liu Ying
On 10/28/2024, Liu Ying wrote: > Dual-link LVDS displays receive odd pixels and even pixels separately from > dual LVDS links. One link receives odd pixels and the other receives even > pixels. Some of those displays may also use only one LVDS link to receive > all pixels, being odd and even agno

[PATCH v18 6/8] phy: freescale: Add DisplayPort/HDMI Combo-PHY driver for i.MX8MQ

2024-10-28 Thread Sandor Yu
Add Cadence HDP-TX DisplayPort and HDMI PHY driver for i.MX8MQ. Cadence HDP-TX PHY could be put in either DP mode or HDMI mode base on the configuration chosen. DisplayPort or HDMI PHY mode is configured in the driver. Signed-off-by: Sandor Yu Signed-off-by: Alexander Stein --- v17->v18: - fix

[PATCH v18 8/8] arm64: dts: imx8mq: tqma8mq-mba8mx: Enable HDMI support

2024-10-28 Thread Sandor Yu
From: Alexander Stein Add HDMI connector and connect it to MHDP output. Enable peripherals for HDMI output. Signed-off-by: Alexander Stein --- v17->v18: - replace lane-mapping with data-lanes .../dts/freescale/imx8mq-tqma8mq-mba8mx.dts | 21 +++ arch/arm64/boot/dts/freescale

[PATCH v18 7/8] arm64: dts: imx8mq: Add DCSS + HDMI/DP display pipeline

2024-10-28 Thread Sandor Yu
From: Alexander Stein This adds DCSS + MHDP + MHDP PHY nodes. PHY mode (DP/HDMI) is selected by the connector type connected to mhdp port@1 endpoint. Signed-off-by: Alexander Stein --- v17->v18: *No change arch/arm64/boot/dts/freescale/imx8mq.dtsi | 68 +++ 1 file changed

[PATCH v18 5/8] dt-bindings: phy: Add Freescale iMX8MQ DP and HDMI PHY

2024-10-28 Thread Sandor Yu
Add bindings for Freescale iMX8MQ DP and HDMI PHY. Signed-off-by: Sandor Yu Reviewed-by: Rob Herring --- v9->v18: *No change. .../bindings/phy/fsl,imx8mq-dp-hdmi-phy.yaml | 51 +++ 1 file changed, 51 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/fsl

[PATCH v18 4/8] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2024-10-28 Thread Sandor Yu
Add a new DRM DisplayPort and HDMI bridge driver for Candence MHDP8501 used in i.MX8MQ SOC. MHDP8501 could support HDMI or DisplayPort standards according embedded Firmware running in the uCPU. For iMX8MQ SOC, the DisplayPort/HDMI FW was loaded and activated by SOC's ROM code. Bootload binary incl

[PATCH v18 0/8] Initial support Cadence MHDP8501(HDMI/DP) for i.MX8MQ

2024-10-28 Thread Sandor Yu
The patch set initial support Cadence MHDP8501(HDMI/DP) DRM bridge driver and Cadence HDP-TX PHY(HDMI/DP) driver for Freescale i.MX8MQ. The patch set compose of DRM bridge drivers and PHY driver. Both of them need by patch #1 and #2 to pass build. DRM bridges driver patches: #1: drm: bridge: C

[PATCH v18 3/8] dt-bindings: display: bridge: Add Cadence MHDP8501

2024-10-28 Thread Sandor Yu
Add bindings for Cadence MHDP8501 DisplayPort/HDMI bridge. Signed-off-by: Sandor Yu --- v17->v18: - remove lane-mapping and replace it with data-lanes - remove r-b tag as property changed. v16->v17: - Add lane-mapping property v9->v16: *No change .../display/bridge/cdns,mhdp8501.yaml

[PATCH v18 2/8] phy: Add HDMI configuration options

2024-10-28 Thread Sandor Yu
Allow HDMI PHYs to be configured through the generic functions through a custom structure added to the generic union. The parameters added here are based on HDMI PHY implementation practices. The current set of parameters should cover the potential users. Signed-off-by: Sandor Yu Reviewed-by: D

[PATCH v18 1/8] drm: bridge: Cadence: Create MHDP helper driver

2024-10-28 Thread Sandor Yu
Mailbox access functions in MHDP8546 will be share to other MHDP driver and Cadence HDP-TX HDMI/DP PHY drivers. Create a new MHDP helper driver and move all mailbox access functions into. According the mailbox access sequence and type of security. Six mailbox access API functions are introduced. T

Re: [PATCH v1 06/10] media: platform: mediatek: add isp_7x utility

2024-10-28 Thread 胡俊光

Re: [PATCH v4 00/13] Add ITE IT6263 LVDS to HDMI converter support

2024-10-28 Thread Liu Ying
On 10/28/2024, Dmitry Baryshkov wrote: > On Mon, Oct 28, 2024 at 11:12:00AM +, Biju Das wrote: >> Hi Dmitry, Liu, >> >>> -Original Message- >>> From: Dmitry Baryshkov >>> Sent: 28 October 2024 10:20 >>> Subject: Re: [PATCH v4 00/13] Add ITE IT6263 LVDS to HDMI converter support >>> >>>

Re: [PATCH v2] drm/amdgpu: Fix possible NULL pointer dereference

2024-10-28 Thread Lazar, Lijo
On 10/29/2024 3:48 PM, Li Huafei wrote: > Fix the potential NULL pointer dereference on mem_ranges in > amdgpu_discovery_get_nps_info(). Additionally, assign the output > parameters nps_type and range_cnt after the kvzalloc() call to prevent > modifying the output parameters in case of an error

Re: [PATCH] drm/tiny: Fix some error handling paths in sharp_memory_probe()

2024-10-28 Thread Alex Lanzano
On Sat, Oct 26, 2024 at 08:32:36AM +0200, Christophe JAILLET wrote: > If an error occurs after allocating resources based on which > "sharp,vcom-mode" is used, then these resources must be released, as > already done in the .remove() function. > > Use 2 new devm_add_action_or_reset() for that and

Re: [PATCH v1 05/10] media: platform: mediatek: add isp_7x camsys unit

2024-10-28 Thread 胡俊光

[PATCH v2] drm/amdgpu: Fix possible NULL pointer dereference

2024-10-28 Thread Li Huafei
Fix the potential NULL pointer dereference on mem_ranges in amdgpu_discovery_get_nps_info(). Additionally, assign the output parameters nps_type and range_cnt after the kvzalloc() call to prevent modifying the output parameters in case of an error return. Fixes: b194d21b9bcc ("drm/amdgpu: Use NPS

Re: [PATCH] drm/amdgpu: Fix possible NULL pointer dereference

2024-10-28 Thread Li Huafei
On 2024/10/28 22:33, Lazar, Lijo wrote: > > > On 10/29/2024 3:29 AM, Li Huafei wrote: >> Fix the potential NULL pointer dereference on mem_ranges in >> amdgpu_discovery_get_nps_info(). Additionally, assign the output >> parameters nps_type and range_cnt after the kvzalloc() call to prevent >>

Re: [PATCH] drm/v3d: Drop allocation of object without mountpoint

2024-10-28 Thread Maíra Canal
Maíra - else - shmem_obj = drm_gem_shmem_create(dev, unaligned_size); - if (IS_ERR(shmem_obj)) return ERR_CAST(shmem_obj); bo = to_v3d_bo(&shmem_obj->base); --- base-commit: dec9255a128e19c5fcc3bdb18175d78094cc624d change-id: 20241028-v3d-1d254

Re:Re:Re: [PATCH v6] rockchip/drm: vop2: add support for gamma LUT

2024-10-28 Thread Andy Yan
Hi Piotr, 在 2024-10-28 14:42:28,"Andy Yan" 写道: > >Hi Piotr, >Tested on top of Linux 6.12-rc5 with rk3566-box-demo in a buildroot + > weston environment: >weston --backend=drm-backend.so -i 0 --continue-without-input >weston-simple-egl > > simple-egl will draw a triangle on the des

[PATCH v1] FOR-CI: drm/i915/guc: Disable ct receive tasklet during reset preparation

2024-10-28 Thread Zhanjun Dong
During GuC reset prepare, interrupt is disabled, if the interrupt event already happens and is in progress, from interrupt event to tasklet get running, there is alway some kind of latency. In long latency case, it might have 2 rare race conditions: 1. Tasklet runs after IRQ flush, add request to q

[PATCH] drm/edid: add non-desktop quirk to XREAL Air/Air 2 Pro

2024-10-28 Thread Sefa Eyeoglu
Both devices lack a DisplayID 2.0 block and therefore do not advertise themselves as HMDs. See https://gitlab.freedesktop.org/drm/misc/kernel/-/issues/53 Signed-off-by: Sefa Eyeoglu --- drivers/gpu/drm/drm_edid.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c

Re: [PATCH v9 0/4] io-pgtable-arm + drm/msm: Extend iova fault debugging

2024-10-28 Thread Rob Clark
On Mon, Oct 28, 2024 at 4:53 AM Mostafa Saleh wrote: > > Hi Rob, > > On Tue, Aug 27, 2024 at 11:17:08AM -0700, Rob Clark wrote: > > From: Rob Clark > > > > This series extends io-pgtable-arm with a method to retrieve the page > > table entries traversed in the process of address translation, and

[PATCH v10 4/4] drm/msm: Extend gpu devcore dumps with pgtbl info

2024-10-28 Thread Rob Clark
From: Rob Clark In the case of iova fault triggered devcore dumps, include additional debug information based on what we think is the current page tables, including the TTBR0 value (which should match what we have in adreno_smmu_fault_info unless things have gone horribly wrong), and the pagetabl

[PATCH v10 0/4] io-pgtable-arm + drm/msm: Extend iova fault debugging

2024-10-28 Thread Rob Clark
From: Rob Clark This series extends io-pgtable-arm with a method to retrieve the page table entries traversed in the process of address translation, and then beefs up drm/msm gpu devcore dump to include this (and additional info) in the devcore dump. This is a respin of https://patchwork.freedes

Re: [PATCH v2 1/3] drm/xen: remove redundant initialization info print

2024-10-28 Thread Alex Deucher
On Mon, Oct 28, 2024 at 3:04 PM Jani Nikula wrote: > > drm_dev_register() already prints the same information on successful > init. Remove the redundant prints. > > Signed-off-by: Jani Nikula Acked-by: Alex Deucher > > --- > > Note: I prefer to merge this together with the next patch via > drm

Re:Re: [PATCH v6] rockchip/drm: vop2: add support for gamma LUT

2024-10-28 Thread Piotr Zalewski
Hi again On Monday, October 28th, 2024 at 5:40 PM, Piotr Zalewski wrote: > On Monday, October 28th, 2024 at 7:42 AM, Andy Yan andys...@163.com wrote: > > > Hi Piotr, > > > Hi Andy > > > Tested on top of Linux 6.12-rc5 with rk3566-box-demo in a buildroot + > > weston environment: > > weston

Re: [PATCH v2 2/3] accel/ivpu: remove DRIVER_DATE conditional drm_driver init

2024-10-28 Thread Alex Deucher
On Mon, Oct 28, 2024 at 2:52 PM Jani Nikula wrote: > > The ivpu struct drm_driver has conditional initialization based on #ifdef > DRIVER_DATE, which is never defined anywhere. Neither are the macros > referenced within the block: DRIVER_DATE, DRIVER_MAJOR, DRIVER_MINOR, > and DRIVER_PATCHLEVEL. W

Re: [PATCH] fbdev: udl: Make CONFIG_FB_DEVICE optional

2024-10-28 Thread kernel test robot
Hi Gonzalo, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-tip/drm-tip linus/master v6.12-rc5 next-20241028] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH v2] driver core: fw_devlink: Stop trying to optimize cycle detection logic

2024-10-28 Thread Saravana Kannan
On Mon, Oct 28, 2024 at 1:06 AM Tomi Valkeinen wrote: > > Hi, > > On 26/10/2024 07:52, Saravana Kannan wrote: > > In attempting to optimize fw_devlink runtime, I introduced numerous cycle > > detection bugs by foregoing cycle detection logic under specific > > conditions. Each fix has further narr

[PATCH] drm/vmwgfx: Add common resolutions to the connector mode list

2024-10-28 Thread Ian Forbes
We replaced our custom list of resolutions with the noedid list, which is based on the VESA DMT standard, in the referenced fixes commit. The reason for this was that the user can technically set any resolution they want by using Autofit or the vmwgfxctl utility. Unfortunately the Autofit feature

Re: [PATCH 2/2] drm: bridge: ti-sn65dsi83: Add error recovery mechanism

2024-10-28 Thread Marek Vasut
On 10/28/24 2:52 PM, Herve Codina wrote: Hi Marek, Hi, On Sat, 26 Oct 2024 00:53:51 +0200 Marek Vasut wrote: On 10/24/24 11:55 AM, Herve Codina wrote: In some cases observed during ESD tests, the TI SN65DSI83 cannot recover from errors by itself. A full restart of the bridge is needed

Re: [PATCH] drm/xe: Fix build error for XE_IOCTL_DBG macro

2024-10-28 Thread Lucas De Marchi
On Sun, Oct 27, 2024 at 01:57:52PM +0900, Gyeyoung Baek wrote: In the previous code, there is build error. if CONFIG_DRM_USE_DYNAMIC_DEBUG is set, 'drm_dbg' function is replaced with '__dynamic_func_call_cls', which is replaced with a do while statement. The problem is that, XE_IOCTL_DBG uses th

Re: [PATCH v12 09/15] drm/vkms: Remove useless drm_rotation_simplify

2024-10-28 Thread Maíra Canal
Hi Louis, On 28/10/24 08:01, Louis Chauvet wrote: On 28/10/24 - 07:17, Maíra Canal wrote: Hi Louis, On 28/10/24 06:50, Louis Chauvet wrote: On 26/10/24 - 09:10, Maíra Canal wrote: Hi Louis, On 14/10/24 05:39, Louis Chauvet wrote: On 11/10/24 - 10:53, Maira Canal wrote: Hi Louis, On 10/11

Re: [PATCH 1/2] drm/etnaviv: Fix misunderstanding about the scatterlist structure

2024-10-28 Thread Sui Jingfeng
Hi, On 2024/10/29 00:05, Sui Jingfeng wrote: The 'offset' data member of the 'struct scatterlist' denotes the offset into a SG entry in bytes. The sg_dma_len() macro could be used to get lengths of SG entries, those lengths are expected to be CPU page size aligned. Since, at least for now, we c

Re: [RFC 1/1] SWDEV476969 - dm: Fail dm_atomic_check if cursor overlay is required at MAX_SURFACES

2024-10-28 Thread Leo Li
On 2024-10-25 22:01, Melissa Wen wrote: On 25/10/2024 16:37, Zaeem Mohamed wrote: [why] Prevent index-out-of-bounds due to requiring cursor overlay when plane_count is MAX_SURFACES. Hi Zaeem, Thanks for working on this fix. [how] Bounds check on plane_count when requiring overlay curs

[pull] drm/msm: drm-msm-next-2024-10-28 for v6.13

2024-10-28 Thread Rob Clark
Hi Dave, Simona, This is the main pull for v6.13. Further description below. The following changes since commit 9852d85ec9d492ebef56dc5f229416c925758edc: Linux 6.12-rc1 (2024-09-29 15:06:19 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/drm/msm.git tags/drm-

Re: [PATCH] drm/panel: leadtek-ltk050h3146w: transition to mipi_dsi wrapped functions

2024-10-28 Thread Doug Anderson
Hi, On Fri, Oct 25, 2024 at 9:00 PM Tejas Vipin wrote: > > @@ -418,79 +398,42 @@ static const struct ltk050h3146w_desc ltk050h3146w_data > = { > MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET, > }; > > -static int ltk050h3146w_a2_select_page(struct ltk050h3146w *ctx, int page)

[PATCH v2 2/3] accel/ivpu: remove DRIVER_DATE conditional drm_driver init

2024-10-28 Thread Jani Nikula
The ivpu struct drm_driver has conditional initialization based on #ifdef DRIVER_DATE, which is never defined anywhere. Neither are the macros referenced within the block: DRIVER_DATE, DRIVER_MAJOR, DRIVER_MINOR, and DRIVER_PATCHLEVEL. With the struct drm_driver date member going away anyway, just

[PATCH v2 3/3] drm: remove driver date from struct drm_driver and all drivers

2024-10-28 Thread Jani Nikula
We stopped using the driver initialized date in commit 7fb8af6798e8 ("drm: deprecate driver date") and (eventually) started returning "0" for drm_version ioctl instead. Finish the job, and remove the unused date member from struct drm_driver, its initialization from drivers, along with the common

[PATCH v2 1/3] drm/xen: remove redundant initialization info print

2024-10-28 Thread Jani Nikula
drm_dev_register() already prints the same information on successful init. Remove the redundant prints. Signed-off-by: Jani Nikula --- Note: I prefer to merge this together with the next patch via drm-misc-next. Cc: Oleksandr Andrushchenko Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas

[PATCH] lib/scatterlist: Use sg_phys() helper

2024-10-28 Thread Sui Jingfeng
This shorten the length of code in horizential direction, therefore is easier to read. Signed-off-by: Sui Jingfeng --- lib/scatterlist.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/scatterlist.c b/lib/scatterlist.c index 473b2646f71c..5bb6b8aff232 100644 --- a/lib

Re: [PATCH 2/2] drm: bridge: ti-sn65dsi83: Add error recovery mechanism

2024-10-28 Thread Herve Codina
On Mon, 28 Oct 2024 15:47:25 +0100 Marek Vasut wrote: > On 10/28/24 2:52 PM, Herve Codina wrote: > > Hi Marek, > > Hi, > > >>> On Sat, 26 Oct 2024 00:53:51 +0200 > >>> Marek Vasut wrote: > >>> > On 10/24/24 11:55 AM, Herve Codina wrote: > > In some cases observed during ESD

Re: [PATCH v2 0/5] dt-bindings: mfd: convert zii,rave-sp.txt and child txt to yaml format

2024-10-28 Thread Rob Herring
On Thu, Oct 10, 2024 at 11:42:37AM -0400, Frank Li wrote: > Fixed below warnings: > > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb: > /soc@0/bus@3080/serial@3089/mcu: failed to match any schema with > compatible: ['zii,rave-sp-rdu2'] > arch/arm64/boot/dts/freescale/imx8mq-zii-

Re: [PATCH v2 3/3] drm/panthor: Report innocent group kill

2024-10-28 Thread Boris Brezillon
On Mon, 28 Oct 2024 15:31:19 + Steven Price wrote: > On 28/10/2024 11:48, Boris Brezillon wrote: > > Groups can be killed during a reset even though they did nothing wrong. > > That usually happens when the FW is put in a bad state by other groups, > > resulting in group suspension failures w

Re: [PATCH 1/5] drm/edid: convert drm_parse_hdmi_vsdb_video to use struct cea_db *

2024-10-28 Thread Ville Syrjälä
On Mon, Oct 28, 2024 at 03:45:07PM +0200, Jani Nikula wrote: > On Sun, 27 Oct 2024, Vamsi Krishna Brahmajosyula > wrote: > > @@ -6320,19 +6321,20 @@ static void drm_parse_hdmi_deep_color_info(struct > > drm_connector *connector, > > > > /* HDMI Vendor-Specific Data Block (HDMI VSDB, H14b-VSDB

Re: [PATCH 3/5] drm/vblank: Remove unused drm_crtc_vblank_count_and_time

2024-10-28 Thread Dr. David Alan Gilbert
* Ville Syrjälä (ville.syrj...@linux.intel.com) wrote: > On Wed, Oct 23, 2024 at 12:29:32AM +0100, li...@treblig.org wrote: > > From: "Dr. David Alan Gilbert" > > > > drm_crtc_vblank_count_and_time() was explicitly added by > > commit cf6483050e9b ("drm/irq: Add drm_crtc_vblank_count_and_time()")

Re: [PATCH v4 5/7] PCI/IOV: Check that VF BAR fits within the reservation

2024-10-28 Thread Bjorn Helgaas
On Fri, Oct 25, 2024 at 11:50:36PM +0200, Michał Winiarski wrote: > VF MMIO resource reservation, either created by system firmware and > inherited by Linux PCI subsystem or created by the subsystem itself, > should contain enough space to fit the BAR of all SR-IOV Virtual > Functions that can pote

Re: [PATCH v4 6/7] PCI: Allow drivers to control VF BAR size

2024-10-28 Thread Bjorn Helgaas
On Fri, Oct 25, 2024 at 11:50:37PM +0200, Michał Winiarski wrote: > Drivers could leverage the fact that the VF BAR MMIO reservation is > created for total number of VFs supported by the device by resizing the > BAR to larger size when smaller number of VFs is enabled. > > Add a pci_iov_vf_bar_set

Re:Re: [PATCH v6] rockchip/drm: vop2: add support for gamma LUT

2024-10-28 Thread Piotr Zalewski
On Monday, October 28th, 2024 at 7:42 AM, Andy Yan wrote: > Hi Piotr, Hi Andy > Tested on top of Linux 6.12-rc5 with rk3566-box-demo in a buildroot + weston > environment: > weston --backend=drm-backend.so -i 0 --continue-without-input > weston-simple-egl Thank you for testing it! > simple-e

[PATCH] drm/imx/dcss: include drm/drm_bridge.h header

2024-10-28 Thread Arnd Bergmann
From: Arnd Bergmann Compile-testing random configurations leads to failures in dcss-kms.c from a missing declaration: drivers/gpu/drm/imx/dcss/dcss-kms.c:95:8: error: use of undeclared identifier 'drm_bridge_attach' 95 | ret = drm_bridge_attach(encoder, bridge, NULL, |

Re: [PATCH 1/2] drm/etnaviv: Fix misunderstanding about the scatterlist structure

2024-10-28 Thread Sui Jingfeng
Hi, Dear reviewers On 2024/10/29 00:05, Sui Jingfeng wrote: The 'offset' data member of the 'struct scatterlist' denotes the offset into a SG entry in bytes. The sg_dma_len() macro could be used to get lengths of SG entries, those lengths are expected to be CPU page size aligned. Since, at least

Re: [PATCH 3/5] drm/vblank: Remove unused drm_crtc_vblank_count_and_time

2024-10-28 Thread Ville Syrjälä
On Wed, Oct 23, 2024 at 12:29:32AM +0100, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > drm_crtc_vblank_count_and_time() was explicitly added by > commit cf6483050e9b ("drm/irq: Add drm_crtc_vblank_count_and_time()") > in 2015, but never used. I see a bunch of places that could t

Re: [PATCH 3/3] drm/etnaviv: Print an error message if inserting IOVA range fails

2024-10-28 Thread Sui Jingfeng
Hi, On 2024/10/29 00:01, Lucas Stach wrote: Hi Sui, Am Montag, dem 07.10.2024 um 12:20 +0200 schrieb Lucas Stach: Am Samstag, dem 05.10.2024 um 03:42 +0800 schrieb Sui Jingfeng: Print an error message to help debug when such an issue happen, since it's not so obvious. Signed-off-by: Sui Jing

Re: [PATCH 3/5] drm/vblank: Remove unused drm_crtc_vblank_count_and_time

2024-10-28 Thread Dmitry Baryshkov
On Wed, Oct 23, 2024 at 12:29:32AM +0100, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > drm_crtc_vblank_count_and_time() was explicitly added by > commit cf6483050e9b ("drm/irq: Add drm_crtc_vblank_count_and_time()") > in 2015, but never used. > > Remove it, and rework comments t

Re: [PATCH v2 2/3] drm/panthor: Report group as timedout when we fail to properly suspend

2024-10-28 Thread Steven Price
On 28/10/2024 11:48, Boris Brezillon wrote: > If we don't do that, the group is considered usable by userspace, but > all further GROUP_SUBMIT will fail with -EINVAL. > > Changes in v2: > - New patch > > Fixes: de8548813824 ("drm/panthor: Add the scheduler logical block") > Signed-off-by: Boris B

[PATCH 1/2] drm/etnaviv: Fix misunderstanding about the scatterlist structure

2024-10-28 Thread Sui Jingfeng
The 'offset' data member of the 'struct scatterlist' denotes the offset into a SG entry in bytes. The sg_dma_len() macro could be used to get lengths of SG entries, those lengths are expected to be CPU page size aligned. Since, at least for now, we call drm_prime_pages_to_sg() to convert our variou

[PATCH 2/2] drm/etnaviv: Fix the debug log for the mmu map/unmap procudure

2024-10-28 Thread Sui Jingfeng
The 'iova' variable is invarant within one invoke of the etnaviv_iommu_unmap()/etnaviv_iommu_unmap(), which means that the debug log always print the same GPU virtual address while mapping or unmaping. Made the GPU virtual address being printed increment with real GPUVA being mapped or unmapped.

Re: [PATCH 3/3] drm/etnaviv: Print an error message if inserting IOVA range fails

2024-10-28 Thread Lucas Stach
Hi Sui, Am Montag, dem 07.10.2024 um 12:20 +0200 schrieb Lucas Stach: > Am Samstag, dem 05.10.2024 um 03:42 +0800 schrieb Sui Jingfeng: > > Print an error message to help debug when such an issue happen, since it's > > not so obvious. > > > > Signed-off-by: Sui Jingfeng > > Reviewed-by: Lucas S

Re: [PATCH] drm/etnaviv: etnaviv_cmdbuf.c: Drop the unneeded include of drm_mm.h

2024-10-28 Thread Lucas Stach
Am Samstag, dem 26.10.2024 um 01:56 +0800 schrieb Sui Jingfeng: > The etnaviv_cmdbuf.c doesn't reference any functions or data members > defined in drm_mm.h, remove unneeded headers may reduce kernel compile > times. > > Signed-off-by: Sui Jingfeng Thanks, applied to etnaviv/next. > --- > driv

Re: [PATCH] drm/etnaviv: Drop the 'struct etnaviv_iommu_global::pta_lock' data member

2024-10-28 Thread Lucas Stach
Am Samstag, dem 26.10.2024 um 01:51 +0800 schrieb Sui Jingfeng: > Because it is not get used, drop it. > > Signed-off-by: Sui Jingfeng Thanks, applied to etnaviv/next. > --- > drivers/gpu/drm/etnaviv/etnaviv_mmu.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/etnaviv

Re: [PATCH v2 0/2] drm/etnaviv: Fix GPUVA range collision when CPU page size is not equal to GPU page size

2024-10-28 Thread Lucas Stach
Am Samstag, dem 26.10.2024 um 04:43 +0800 schrieb Sui Jingfeng: > Etnaviv assumes that GPU page size is 4KiB, however, when using > softpin capable GPUs on a different CPU page size configuration. > The userspace allocated GPUVA ranges collision, unable to be > inserted to the specified address hol

Re: [PATCH] drm/bridge: tc358767: Fix use of unadjusted mode in the driver

2024-10-28 Thread Robert Foss
On Sat, 26 Oct 2024 06:10:42 +0200, Marek Vasut wrote: > The driver configures mostly Pixel PLL from the clock cached in > local copy of the mode. Make sure the driver uses adjusted mode > which contains the updated Pixel PLL settings negotiated in > tc_dpi_atomic_check()/tc_edp_atomic_check(). >

Re: [PATCH v2 1/5] drm/etnaviv: hold GPU lock across perfmon sampling

2024-10-28 Thread Lucas Stach
Am Freitag, dem 05.07.2024 um 22:00 +0200 schrieb Lucas Stach: > The perfmon sampling mutates shared GPU state (e.g. VIVS_HI_CLOCK_CONTROL > to select the pipe for the perf counter reads). To avoid clashing with > other functions mutating the same state (e.g. etnaviv_gpu_update_clock) > the perfmon

Re: [PATCH] drm/etnaviv: Fix missing mutex_destroy()

2024-10-28 Thread Lucas Stach
Am Sonntag, dem 25.08.2024 um 20:14 +0800 schrieb Sui Jingfeng: > Currently, the calling of mutex_destroy() is ignored on error handling > code path. It is safe for now, since mutex_destroy() actually does > nothing in non-debug builds. But the mutex_destroy() is used to mark > the mutex uninitiali

Re: [PATCH v2 1/5] drm/etnaviv: Use unsigned type to count the number of pages

2024-10-28 Thread Lucas Stach
Am Sonntag, dem 08.09.2024 um 20:11 +0800 schrieb Sui Jingfeng: > The drm_prime_pages_to_sg() function takes an 'unsigned int' argument to > store the length of the page vector. The size of the object in number of > CPU pages can not be negative, hence, use 'unsigned' variable to store > the number

Re: [PATCH v4] drm/etnaviv: Request pages from DMA32 zone on addressing_limited

2024-10-28 Thread Lucas Stach
Am Mittwoch, dem 02.10.2024 um 07:34 +0800 schrieb Xiaolei Wang: > Remove __GFP_HIGHMEM when requesting a page from DMA32 zone, > and since all vivante GPUs in the system will share the same > DMA constraints, move the check of whether to get a page from > DMA32 to etnaviv_bind(). > > Fixes: b72af

Re: [PATCH] drm/bridge: tc358767: Fix odd pixel alignment

2024-10-28 Thread Marek Vasut
On 10/28/24 2:52 PM, Maxime Ripard wrote: On Mon, Oct 28, 2024 at 01:36:58PM +0100, Marek Vasut wrote: On 10/28/24 10:25 AM, Maxime Ripard wrote: On Sat, Oct 26, 2024 at 06:10:01AM +0200, Marek Vasut wrote: Horizontal Timing Control0 Register 1/2 (HTIM01/HTIM02) Register bitfields description

Re: [PATCH v2 3/3] drm/panthor: Report innocent group kill

2024-10-28 Thread Steven Price
On 28/10/2024 11:48, Boris Brezillon wrote: > Groups can be killed during a reset even though they did nothing wrong. > That usually happens when the FW is put in a bad state by other groups, > resulting in group suspension failures when the reset happens. > > If we end up in that situation, flag

[GIT PULL] mediatek drm fixes 20241028

2024-10-28 Thread Chun-Kuang Hu
ints Regards, Chun-Kuang. The following changes since commit 9852d85ec9d492ebef56dc5f229416c925758edc: Linux 6.12-rc1 (2024-09-29 15:06:19 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git tags/mediatek-drm-fixes-20241028 for yo

RE: [PATCH 06/10] mtd: intel-dg: wake card on operations

2024-10-28 Thread Gupta, Anshuman
> -Original Message- > From: Vivi, Rodrigo > Sent: Monday, October 28, 2024 8:27 PM > To: Usyskin, Alexander ; Gupta, Anshuman > ; Deak, Imre > Cc: Miquel Raynal ; Richard Weinberger > ; Vignesh Raghavendra ; De Marchi, > Lucas ; Thomas Hellström > ; Maarten Lankhorst > ; Maxime Ripard

Re: [PATCH v6 0/8] drm: zynqmp_dp: IRQ cleanups and debugfs support

2024-10-28 Thread Tomi Valkeinen
Hi, On 25/10/2024 17:58, Sean Anderson wrote: Hi Tomi, On 10/3/24 10:53, Sean Anderson wrote: On 10/2/24 10:50, Tomi Valkeinen wrote: Hi, On 01/10/2024 21:31, Sean Anderson wrote: On 8/9/24 15:35, Sean Anderson wrote: This series cleans up the zyqnmp_dp IRQ and locking situation. Once that

Re: [PATCH 06/10] mtd: intel-dg: wake card on operations

2024-10-28 Thread Rodrigo Vivi
On Tue, Oct 22, 2024 at 01:41:15PM +0300, Alexander Usyskin wrote: > Enable runtime PM in mtd driver to notify graphics driver that > whole card should be kept awake while nvm operations are > performed through this driver. > > CC: Lucas De Marchi > Signed-off-by: Alexander Usyskin > --- > driv

Re: [PATCH 1/7] kernel/cgroup: Add "dev" memory accounting cgroup

2024-10-28 Thread Friedrich Vock
On 23.10.24 09:52, Maarten Lankhorst wrote: The initial version was based roughly on the rdma and misc cgroup controllers, with a lot of the accounting code borrowed from rdma. The current version is a complete rewrite with page counter; it uses the same min/low/max semantics as the memory cgrou

[PATCH] drm/v3d: Drop allocation of object without mountpoint

2024-10-28 Thread matthias . bgg
v3d_bo(&shmem_obj->base); --- base-commit: dec9255a128e19c5fcc3bdb18175d78094cc624d change-id: 20241028-v3d-1d2546ed92d7 Best regards, -- Matthias Brugger

Re: [PATCH 09/10] drm/xe/nvm: add on-die non-volatile memory device

2024-10-28 Thread Rodrigo Vivi
On Tue, Oct 22, 2024 at 01:41:18PM +0300, Alexander Usyskin wrote: > Enable access to internal non-volatile memory on DGFX > with GSC/CSC devices via a child device. > The nvm child device is exposed via auxiliary bus. I looked at all of the i915 and xe patches here and everything looks right. Jus

Re: [PATCH] drm/amdgpu: Fix possible NULL pointer dereference

2024-10-28 Thread Lazar, Lijo
On 10/29/2024 3:29 AM, Li Huafei wrote: > Fix the potential NULL pointer dereference on mem_ranges in > amdgpu_discovery_get_nps_info(). Additionally, assign the output > parameters nps_type and range_cnt after the kvzalloc() call to prevent > modifying the output parameters in case of an error

Re: [PATCH] drm: encoder_slave: Remove unused encoder functions

2024-10-28 Thread Dmitry Baryshkov
On Fri, Oct 25, 2024 at 09:39:20PM +0100, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > drm_i2c_encoder_commit(), drm_i2c_encoder_mode_set() and > drm_i2c_encoder_prepare() have been unused since 2016's > commit 7bc61cc5df80 ("drm/arcpgu: Accommodate adv7511 switch to DRM > bridge

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix multiple instances

2024-10-28 Thread Dmitry Baryshkov
On Tue, Oct 22, 2024 at 07:37:01AM -0700, Doug Anderson wrote: > Hi, > > On Tue, Oct 22, 2024 at 12:12 AM Geert Uytterhoeven > wrote: > > > > > > > > > However, using i2c_client->adapter->nr instead of ida_alloc() > > > > > > > in the TI driver does sound like a good idea to me... > > > > > > > >

Re: [PATCH 2/2] drm: bridge: ti-sn65dsi83: Add error recovery mechanism

2024-10-28 Thread Laurent Pinchart
On Mon, Oct 28, 2024 at 02:55:47PM +0100, Maxime Ripard wrote: > On Mon, Oct 28, 2024 at 03:28:58PM +0200, Laurent Pinchart wrote: > > On Mon, Oct 28, 2024 at 01:21:45PM +0100, Maxime Ripard wrote: > > > On Mon, Oct 28, 2024 at 01:28:57PM +0200, Laurent Pinchart wrote: > > > > On Mon, Oct 28, 2024

Re: [PATCH] drm/bridge: tc358767: Fix odd pixel alignment

2024-10-28 Thread Maxime Ripard
On Mon, Oct 28, 2024 at 01:36:58PM +0100, Marek Vasut wrote: > On 10/28/24 10:25 AM, Maxime Ripard wrote: > > On Sat, Oct 26, 2024 at 06:10:01AM +0200, Marek Vasut wrote: > > > Horizontal Timing Control0 Register 1/2 (HTIM01/HTIM02) Register > > > bitfields description state "These bits must be mul

Re: [PATCH 5/5] drm/client: Remove unused drm_client_modeset_check

2024-10-28 Thread Dmitry Baryshkov
On Wed, Oct 23, 2024 at 12:29:34AM +0100, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > drm_client_modeset_check() was explicitly added in 2020 by > commit 64593f2a6fc9 ("drm/client: Add drm_client_modeset_check()") > but has never been used. > > Remove it. If you are removing i

[PATCH] drm/amdgpu: Fix possible NULL pointer dereference

2024-10-28 Thread Li Huafei
Fix the potential NULL pointer dereference on mem_ranges in amdgpu_discovery_get_nps_info(). Additionally, assign the output parameters nps_type and range_cnt after the kvzalloc() call to prevent modifying the output parameters in case of an error return. Fixes: b194d21b9bcc ("drm/amdgpu: Use NPS

Re: [PATCH 2/2] drm: bridge: ti-sn65dsi83: Add error recovery mechanism

2024-10-28 Thread Maxime Ripard
On Mon, Oct 28, 2024 at 03:28:58PM +0200, Laurent Pinchart wrote: > On Mon, Oct 28, 2024 at 01:21:45PM +0100, Maxime Ripard wrote: > > On Mon, Oct 28, 2024 at 01:28:57PM +0200, Laurent Pinchart wrote: > > > On Mon, Oct 28, 2024 at 09:13:31AM +0100, Herve Codina wrote: > > > > On Sun, 27 Oct 2024 18

Re: [PATCH] drm/bridge: tc358767: Fix odd pixel alignment

2024-10-28 Thread Maxime Ripard
On Mon, Oct 28, 2024 at 02:52:09PM +0100, Maxime Ripard wrote: > On Mon, Oct 28, 2024 at 01:36:58PM +0100, Marek Vasut wrote: > > On 10/28/24 10:25 AM, Maxime Ripard wrote: > > > On Sat, Oct 26, 2024 at 06:10:01AM +0200, Marek Vasut wrote: > > > > Horizontal Timing Control0 Register 1/2 (HTIM01/HTI

Re: [PATCH 2/2] drm: bridge: ti-sn65dsi83: Add error recovery mechanism

2024-10-28 Thread Herve Codina
Hi Marek, On Mon, 28 Oct 2024 12:47:14 +0100 Marek Vasut wrote: > On 10/28/24 9:02 AM, Herve Codina wrote: > > Hi Marek, > > Hi, > > > On Sat, 26 Oct 2024 00:53:51 +0200 > > Marek Vasut wrote: > > > >> On 10/24/24 11:55 AM, Herve Codina wrote: > >>> In some cases observed during ESD te

Re: [PATCH 5/5] drm/client: Remove unused drm_client_modeset_check

2024-10-28 Thread Dr. David Alan Gilbert
* Dmitry Baryshkov (dmitry.barysh...@linaro.org) wrote: > On Wed, Oct 23, 2024 at 12:29:34AM +0100, li...@treblig.org wrote: > > From: "Dr. David Alan Gilbert" > > > > drm_client_modeset_check() was explicitly added in 2020 by > > commit 64593f2a6fc9 ("drm/client: Add drm_client_modeset_check()")

Re: [RFC PATCH 1/2] drm/drm_file: Add display of driver's internal memory size

2024-10-28 Thread Adrián Larumbe
On 16.10.2024 09:07, Tvrtko Ursulin wrote: > > On 15/10/2024 20:05, Adrián Larumbe wrote: > > Hi Tvrtko, > > > > On 10.10.2024 10:50, Tvrtko Ursulin wrote: > > > > > > On 09/10/2024 23:55, Adrián Larumbe wrote: > > > > Hi Tvrtko, > > > > > > > > On 04.10.2024 14:41, Tvrtko Ursulin wrote: > > >

Re: [PATCH 1/5] drm/edid: convert drm_parse_hdmi_vsdb_video to use struct cea_db *

2024-10-28 Thread Jani Nikula
On Sun, 27 Oct 2024, Vamsi Krishna Brahmajosyula wrote: > @@ -6320,19 +6321,20 @@ static void drm_parse_hdmi_deep_color_info(struct > drm_connector *connector, > > /* HDMI Vendor-Specific Data Block (HDMI VSDB, H14b-VSDB) */ > static void > -drm_parse_hdmi_vsdb_video(struct drm_connector *co

[PATCH v2] drm: xlnx: zynqmp_dpsub: fix hotplug detection

2024-10-28 Thread Steffen Dirkwinkel
From: Steffen Dirkwinkel drm_kms_helper_poll_init needs to be called after zynqmp_dpsub_kms_init. zynqmp_dpsub_kms_init creates the connector and without it we don't enable hotplug detection. Fixes: eb2d64bfcc17 ("drm: xlnx: zynqmp_dpsub: Report HPD through the bridge") Cc: sta...@vger.kernel.or

[PATCH v2] drm: xlnx: zynqmp_disp: layer may be null while releasing

2024-10-28 Thread Steffen Dirkwinkel
From: Steffen Dirkwinkel layer->info can be null if we have an error on the first layer in zynqmp_disp_create_layers Fixes: 1836fd5ed98d ("drm: xlnx: zynqmp_dpsub: Minimize usage of global flag") Signed-off-by: Steffen Dirkwinkel --- drivers/gpu/drm/xlnx/zynqmp_disp.c | 3 +++ 1 file changed,

Re: [PATCH] drm/bridge: tc358767: Fix odd pixel alignment

2024-10-28 Thread Marek Vasut
On 10/28/24 10:25 AM, Maxime Ripard wrote: On Sat, Oct 26, 2024 at 06:10:01AM +0200, Marek Vasut wrote: Horizontal Timing Control0 Register 1/2 (HTIM01/HTIM02) Register bitfields description state "These bits must be multiple of even pixel". It is not possible to simply align every bitfield to t

[PATCH v2] drm: xlnx: zynqmp_dpsub: fix hotplug detection

2024-10-28 Thread Steffen Dirkwinkel
From: Steffen Dirkwinkel drm_kms_helper_poll_init needs to be called after zynqmp_dpsub_kms_init. zynqmp_dpsub_kms_init creates the connector and without it we don't enable hotplug detection. Fixes: eb2d64bfcc17 ("drm: xlnx: zynqmp_dpsub: Report HPD through the bridge") Signed-off-by: Steffen Di

Re: [PATCH 2/2] drm: bridge: ti-sn65dsi83: Add error recovery mechanism

2024-10-28 Thread Laurent Pinchart
On Mon, Oct 28, 2024 at 01:21:45PM +0100, Maxime Ripard wrote: > On Mon, Oct 28, 2024 at 01:28:57PM +0200, Laurent Pinchart wrote: > > On Mon, Oct 28, 2024 at 09:13:31AM +0100, Herve Codina wrote: > > > On Sun, 27 Oct 2024 18:23:50 +0200 Laurent Pinchart wrote: > > > > > > [...] > > > > > +static

Re: [PATCH v2 1/1] drm/mediatek: Fix potential KP on 0 bytes nvmem cell read

2024-10-28 Thread 杨连坤

Re: [PATCH 2/5] drm/sysfs: Remove unused drm_class_device_(un)register

2024-10-28 Thread Dmitry Baryshkov
On Wed, Oct 23, 2024 at 12:29:31AM +0100, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > drm_class_device_register() and drm_class_device_unregister() have been > unused since > commit ed89fff97382 ("drm/ttm: drop sysfs directory") > > Remove them. > > Signed-off-by: Dr. David Al

  1   2   >