Re: [PATCH 4/8] drm/bridge: fsl-ldb: Use clk_round_rate() to validate "ldb" clock rate

2024-10-11 Thread Liu Ying
On 10/11/2024, Maxime Ripard wrote: > On Mon, Sep 30, 2024 at 03:55:30PM GMT, Liu Ying wrote: >> On 09/30/2024, Maxime Ripard wrote: >>> On Mon, Sep 30, 2024 at 01:28:59PM GMT, Liu Ying wrote: Multiple display modes could be read from a display device's EDID. Use clk_round_rate() to valid

Re: [PATCH v1 4/5] drm/xe/bo: Create a new sg for dmabuf BOs that are associated with a VF

2024-10-11 Thread Matthew Brost
On Fri, Oct 11, 2024 at 07:40:26PM -0700, Vivek Kasireddy wrote: > For BOs of type ttm_bo_type_sg, that are backed by PCI BAR addresses > associated with a VF, we need to adjust and translate these addresses > to LMEM addresses to make the BOs usable by the PF. Otherwise, the BOs > (i.e, PCI BAR ad

[PATCH v1 4/5] drm/xe/bo: Create a new sg for dmabuf BOs that are associated with a VF

2024-10-11 Thread Vivek Kasireddy
For BOs of type ttm_bo_type_sg, that are backed by PCI BAR addresses associated with a VF, we need to adjust and translate these addresses to LMEM addresses to make the BOs usable by the PF. Otherwise, the BOs (i.e, PCI BAR addresses) are only accessible by the CPU and not by the GPU. In order to

[PATCH v1 5/5] drm/xe/pt: Add an additional check for dmabuf BOs while updating PTEs

2024-10-11 Thread Vivek Kasireddy
If a BO's is_devmem_external flag is set, it means that it is an imported dmabuf BO that has a backing store in VRAM. Therefore, we need to add XE_PPGTT_PTE_DM to the PTE flags as part of vm_bind. Signed-off-by: Vivek Kasireddy --- drivers/gpu/drm/xe/xe_pt.c | 5 +++-- 1 file changed, 3 insertio

[PATCH v1 3/5] drm/xe/pf: Add a helper function to get a VF's starting address in LMEM

2024-10-11 Thread Vivek Kasireddy
To properly import a dmabuf that is associated with a VF (or that originates in a Guest VM that includes a VF), we need to know where in LMEM the VF's allocated region starts. The function introduced in this patch does just that by returning the DPA associated with the BO that backs the VF's region

[PATCH v1 1/5] PCI/P2PDMA: Don't enforce ACS check for functions of same device

2024-10-11 Thread Vivek Kasireddy
Functions of the same PCI device (such as a PF and a VF) share the same bus and have a common root port and typically, the PF provisions resources for the VF. Therefore, they can be considered compatible as far as P2P access is considered. Currently, although the distance (2) is correctly calculat

[PATCH v1 0/5] drm/xe/sriov: Don't migrate dmabuf BO to System RAM while running in VM

2024-10-11 Thread Vivek Kasireddy
While testing [1] and [2] with a SRIOV enabled dGPU, it was noticed that migrating a BO to System RAM before exporting it as a dmabuf results in considerable performance degradation while running in a Guest VM. For example, running a simple 3D app such as weston-simple-egl would yield ~50 FPS inste

[PATCH v1 2/5] drm/xe/dmabuf: Don't migrate BO to System RAM while running in VF mode

2024-10-11 Thread Vivek Kasireddy
If the importer has allow_peer2peer set to true, then we can expect that it would be able to handle VRAM addresses. Therefore, in this specific case and only while running in VF mode, do not migrate the BO to System RAM before exporting it. Signed-off-by: Vivek Kasireddy --- drivers/gpu/drm/xe/x

RE: [PATCH 1/2] drm/sched: adding a new scheduling policy

2024-10-11 Thread Zhang, Jesse(Jie)
[AMD Official Use Only - AMD Internal Distribution Only] Hi Christian, -Original Message- From: Koenig, Christian Sent: Friday, October 11, 2024 4:40 PM To: Zhang, Jesse(Jie) ; dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org Cc: Deucher, Alexander Subject: Re: [PATCH 1/2

Re: [PATCH v2] dma-buf: fix S_IRUGO to 0444, block comments, func declaration

2024-10-11 Thread John Stultz
On Sat, Oct 5, 2024 at 11:10 AM Pintu Kumar wrote: > > These warnings/errors are reported by checkpatch. > Fix them with minor changes to make it clean. > No other functional changes. > > WARNING: Block comments use * on subsequent lines > + /* only support discovering the end of the buffer,

Re: [PATCH] drm/panthor: Fix firmware initialization on systems with a page size > 4k

2024-10-11 Thread Liviu Dudau
On Fri, Oct 11, 2024 at 06:58:45PM +0100, Adrián Larumbe wrote: > Hi Boris, > > On 09.10.2024 09:10, Steven Price wrote: > > On 08/10/2024 09:47, Boris Brezillon wrote: > > > The system and GPU MMU page size might differ, which becomes a > > > problem for FW sections that need to be mapped at expl

Re: [GIT PULL] fbdev platform_driver::remove() migration for v6.12-rc3

2024-10-11 Thread pr-tracker-bot
The pull request you sent on Fri, 11 Oct 2024 22:50:28 +0200: > http://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git > tags/fbdev-for-6.12-rc3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/9066258d0a533530c2508f784e85c53b44f5d9e4 Thank you! -- Dee

Re: [PATCH 1/3] drm/panthor: Fix runtime suspend sequence after OPP transition error

2024-10-11 Thread Liviu Dudau
On Fri, Oct 11, 2024 at 11:56:59PM +0100, Adrián Larumbe wrote: > In case an OPP transition to a suspension state fails during the runtime > PM suspend call, if the driver's subsystems were successfully resumed, > we should return -EAGAIN so that the device's runtime PM status remains > 'active'. >

[PATCH V4 07/10] accel/amdxdna: Add command execution

2024-10-11 Thread Lizhi Hou
Add interfaces for user application to submit command and wait for its completion. Co-developed-by: Min Ma Signed-off-by: Min Ma Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/aie2_ctx.c | 624 +- drivers/accel/amdxdna/aie2_message.c | 343 ++

[PATCH V4 09/10] accel/amdxdna: Add error handling

2024-10-11 Thread Lizhi Hou
When there is a hardware error, the NPU firmware notifies the host through a mailbox message. The message includes details of the error, such as the tile and column indexes where the error occurred. The driver starts a thread to handle the NPU error message. The thread stops the clients which are

[PATCH V4 10/10] accel/amdxdna: Add query functions

2024-10-11 Thread Lizhi Hou
Add GET_INFO ioctl to retrieve hardware information, including AIE, clock, hardware context etc. Co-developed-by: Min Ma Signed-off-by: Min Ma Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/aie2_message.c| 65 +++ drivers/accel/amdxdna/aie2_pci.c| 222 +

[PATCH V4 06/10] accel/amdxdna: Add GEM buffer object management

2024-10-11 Thread Lizhi Hou
There different types of BOs are supported: - shmem A user application uses shmem BOs as input/output for its workload running on NPU. - device memory heap The fixed size buffer dedicated to the device. - device buffer The buffer object allocated from device memory heap. - command buffer The bu

[PATCH V4 04/10] accel/amdxdna: Add hardware resource solver

2024-10-11 Thread Lizhi Hou
The AI Engine consists of 2D array of tiles arranged as columns. Provides the basic column allocation and release functions for the tile columns. Co-developed-by: Min Ma Signed-off-by: Min Ma Reviewed-by: Jeffrey Hugo Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/Makefile | 1

[PATCH V4 02/10] accel/amdxdna: Add a new driver for AMD AI Engine

2024-10-11 Thread Lizhi Hou
AMD AI Engine forms the core of AMD NPU and can be used for accelerating machine learning applications. Add the driver to support AI Engine integrated to AMD CPU. Only very basic functionalities are added. - module and PCI device initialization - firmware load - power up - low level hardwa

[PATCH V4 05/10] accel/amdxdna: Add hardware context

2024-10-11 Thread Lizhi Hou
The hardware can be shared among multiple user applications. The hardware resources are allocated/freed based on the request from user application via driver IOCTLs. DRM_IOCTL_AMDXDNA_CREATE_HWCTX Allocate tile columns and create a hardware context structure to track the usage and status of the re

[PATCH V4 08/10] accel/amdxdna: Add suspend and resume

2024-10-11 Thread Lizhi Hou
Implement PCI power management suspend and resume callbacks. Co-developed-by: Narendra Gutta Signed-off-by: Narendra Gutta Co-developed-by: Xiaoming Ren Signed-off-by: Xiaoming Ren Co-developed-by: Min Ma Signed-off-by: Min Ma Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/aie2_ctx.c

[PATCH V4 03/10] accel/amdxdna: Support hardware mailbox

2024-10-11 Thread Lizhi Hou
The hardware mailboxes are used by the driver to submit requests to firmware and receive the completion notices from hardware. Initially, a management mailbox channel is up and running. The driver may request firmware to create/destroy more channels dynamically through management channel. Add dri

[PATCH V4 01/10] accel/amdxdna: Add documentation for AMD NPU accelerator driver

2024-10-11 Thread Lizhi Hou
AMD NPU (Neural Processing Unit) is a multi-user AI inference accelerator integrated into AMD client APU. NPU enables efficient execution of Machine Learning applications like CNN, LLM, etc. NPU is based on AMD XDNA Architecture. NPU is managed by amdxdna driver. Co-developed-by: Sonal Santan Sig

[PATCH V4 00/10] AMD XDNA driver

2024-10-11 Thread Lizhi Hou
This patchset introduces a new Linux Kernel Driver, amdxdna for AMD NPUs. The driver is based on Linux accel subsystem. NPU (Neural Processing Unit) is an AI inference accelerator integrated into AMD client CPUs. NPU enables efficient execution of Machine Learning applications like CNNs, LLMs, etc

Re: [PATCH 0/5] perf: Fix pmu for drivers with bind/unbind

2024-10-11 Thread Lucas De Marchi
On Fri, Oct 11, 2024 at 03:21:18PM -0700, Umesh Nerlige Ramappa wrote: On Tue, Oct 08, 2024 at 01:34:56PM -0500, Lucas De Marchi wrote: v2 of my attempt at fixing how i915 interacts with perf events. v1 - https://lore.kernel.org/all/20240722210648.80892-1-lucas.demar...@intel.com/ From other

[PATCH 3/3] drm/panthor: Rreset device and load FW after failed PM suspend

2024-10-11 Thread Adrián Larumbe
On rk3588 SoCs, during a runtime PM suspend, the transition to the lowest voltage/frequency pair might sometimes fail for reasons not yet understood. In that case, even a slow FW reset will fail, leaving the device's PM runtime status as unusuable. When that happens, successive attempts to resume

[PATCH 2/3] drm/panthor: Retry OPP transition to suspension state a few times

2024-10-11 Thread Adrián Larumbe
When the device's runtime PM suspend callback is invoked, the switch to a suspension OPP might sometimes fail. Although this is beyond the control of the Panthor driver, we can attempt suspending it more than once as a defensive strategy. Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/panthor

[PATCH 1/3] drm/panthor: Fix runtime suspend sequence after OPP transition error

2024-10-11 Thread Adrián Larumbe
In case an OPP transition to a suspension state fails during the runtime PM suspend call, if the driver's subsystems were successfully resumed, we should return -EAGAIN so that the device's runtime PM status remains 'active'. If FW reload failed, then we should fall through, so that the PM core ca

Re: [PATCH 0/5] perf: Fix pmu for drivers with bind/unbind

2024-10-11 Thread Lucas De Marchi
On Tue, Oct 08, 2024 at 01:34:56PM -0500, Lucas De Marchi wrote: v2 of my attempt at fixing how i915 interacts with perf events. v1 - https://lore.kernel.org/all/20240722210648.80892-1-lucas.demar...@intel.com/ From other people: 1) https://lore.kernel.org/lkml/20240115170120.662220-1-tvrtko.

Re: [PATCH 0/5] perf: Fix pmu for drivers with bind/unbind

2024-10-11 Thread Umesh Nerlige Ramappa
On Tue, Oct 08, 2024 at 01:34:56PM -0500, Lucas De Marchi wrote: v2 of my attempt at fixing how i915 interacts with perf events. v1 - https://lore.kernel.org/all/20240722210648.80892-1-lucas.demar...@intel.com/ From other people: 1) https://lore.kernel.org/lkml/20240115170120.662220-1-tvrtko.

[GIT PULL] fbdev platform_driver::remove() migration for v6.12-rc3

2024-10-11 Thread Helge Deller
Hi Linus, will you consider pulling one huge, but trivial patch from Uwe Kleine-König to switch all fbdev drivers at once back to struct platform_driver::remove()? Thanks, Helge The following changes since commit 8cf0b93919e13d1e8d

[PATCH RFC 3/3] arm64: dts: qcom: x1e80100: Add ACD levels for GPU

2024-10-11 Thread Akhil P Oommen
Update GPU node to include acd level values. Signed-off-by: Akhil P Oommen --- arch/arm64/boot/dts/qcom/x1e80100.dtsi | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi index a36076e3c56

[PATCH RFC 1/3] drm/msm/adreno: Add support for ACD

2024-10-11 Thread Akhil P Oommen
ACD a.k.a Adaptive Clock Distribution is a feature which helps to reduce the power consumption. In some chipsets, it is also a requirement to support higher GPU frequencies. This patch adds support for GPU ACD by sending necessary data to GMU and AOSS. The feature support for the chipset is detecte

[PATCH RFC 2/3] dt-bindings: opp: Add v2-qcom-adreno vendor bindings

2024-10-11 Thread Akhil P Oommen
Add a new schema which extends opp-v2 to support a new vendor specific property required for Adreno GPUs found in Qualcomm's SoCs. The new property called "qcom,opp-acd-level" carries a u32 value recommended for each opp needs to be shared to GMU during runtime. Signed-off-by: Akhil P Oommen ---

[PATCH RFC 0/3] Support for GPU ACD feature on Adreno X1-85

2024-10-11 Thread Akhil P Oommen
This series adds support for ACD feature for Adreno GPU which helps to lower the power consumption on GX rail and also sometimes is a requirement to enable higher GPU frequencies. At high level, following are the sequences required for ACD feature: 1. Identify the ACD level data for each re

Re: [PATCH 4/4] drm/panel: samsung-s6e88a0-ams427ap24: Add flip option

2024-10-11 Thread Jakob Hauser
Hi Jessica, On 11.10.24 19:17, Jessica Zhang wrote: On 10/10/2024 11:31 AM, Jakob Hauser wrote: The way of implementing a flip option follows the existing panel-samsung-s6e8aa0.c [1][2][3]. The value to flip the screen is taken from a downstream kernel file of a similar but older panel [4]. T

[PATCH] fbdev/da8xx-fb: unlock on error paths in suspend/resume

2024-10-11 Thread Dan Carpenter
Add a missing console_unlock() in the suspend and resume functions on the error paths. Fixes: 611097d5daea ("fbdev: da8xx: add support for a regulator") Signed-off-by: Dan Carpenter --- drivers/video/fbdev/da8xx-fb.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/dri

Re: [PATCH 2/4] drm/panel: samsung-s6e88a0-ams427ap24: Add initial driver

2024-10-11 Thread Jakob Hauser
Hi Jessica, On 11.10.24 18:52, Jessica Zhang wrote: On 10/10/2024 11:31 AM, Jakob Hauser wrote: ... +struct s6e88a0_ams427ap24 { +    struct drm_panel panel; +    struct mipi_dsi_device *dsi; +    struct regulator_bulk_data *supplies; +    struct gpio_desc *reset_gpio; +    bool prepared;

Re: [PATCH net-next v25 10/13] net: add SO_DEVMEM_DONTNEED setsockopt to release RX frags

2024-10-11 Thread Mina Almasry
On Fri, Oct 11, 2024 at 8:27 AM Jakub Kicinski wrote: > > On Thu, 10 Oct 2024 12:05:38 -0700 Mina Almasry wrote: > > diff --git a/net/core/sock.c b/net/core/sock.c > > index 083d438d8b6f..cb3d8b19de14 100644 > > --- a/net/core/sock.c > > +++ b/net/core/sock.c > > @@ -1071,11 +1071,11 @@ sock_devme

Re: [PATCH 1/4] dt-bindings: display: panel: Add Samsung S6E88A0-AMS427AP24 bindings

2024-10-11 Thread Jakob Hauser
Hi Rob, On 11.10.24 16:27, Rob Herring wrote: On Thu, Oct 10, 2024 at 08:31:48PM +0200, Jakob Hauser wrote: Add bindings for Samsung AMS427AP24 panel with S6E88A0 controller. Signed-off-by: Jakob Hauser --- Patch is based on https://gitlab.freedesktop.org/drm/misc/kernel.git current branch dr

Re: [git pull] drm fixes for 6.12-rc3

2024-10-11 Thread pr-tracker-bot
The pull request you sent on Fri, 11 Oct 2024 17:17:44 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-10-11 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/befcc89362383208f62b15887592758165459e3d Thank you! -- Deet-doot-dot, I am a bot. h

Re: [PATCH net-next 3/3] accel/qaic: Pass string literal as format argument of alloc_workqueue()

2024-10-11 Thread Simon Horman
On Fri, Oct 11, 2024 at 08:27:43AM -0600, Jeffrey Hugo wrote: > On 10/11/2024 3:57 AM, Simon Horman wrote: > > Recently I noticed that both gcc-14 and clang-18 report that passing > > a non-string literal as the format argument of alloc_workqueue() > > is potentially insecure. > > > > E.g. clang-1

[PATCH 2/2] drm/mediatek: Switch to for_each_child_of_node_scoped()

2024-10-11 Thread Javier Carrasco
Introduce the scoped variant of the loop to automatically release the child node when it goes out of scope, which is more robust than the non-scoped variant, and accounts for new early exits that could be added in the future. Signed-off-by: Javier Carrasco --- drivers/gpu/drm/mediatek/mtk_drm_dr

[PATCH 1/2] drm/mediatek: Fix child node refcount handling in early exit

2024-10-11 Thread Javier Carrasco
Early exits (goto, break, return) from for_each_child_of_node() required an explicit call to of_node_put(), which was not introduced with the break if cnt == MAX_CRTC. Add the missing of_node_put() before the break. Cc: sta...@vger.kernel.org Fixes: d761b9450e31 ("drm/mediatek: Add cnt checking f

[PATCH 0/2] drm/mediatek: Fix child node refcount handling and use scoped macro

2024-10-11 Thread Javier Carrasco
ommit: d61a00525464bfc5fe92c6ad713350988e492b88 change-id: 20241011-mtk_drm_drv_memleak-5e8b8e45ed1c Best regards, -- Javier Carrasco

Notes from the XDC 2024 "universal buffer allocator" workshop

2024-10-11 Thread Laurent Pinchart
Hello, We held a workshop at XDC 2024 titled "Towards a universal buffer allocator for Linux", whose abstract was as follows: Buffer allocation for media contents, despite being required for any framework or application dealing with image capture, processing, decoding, encoding, rendering a

Re: [PATCH] drm/panthor: Fix firmware initialization on systems with a page size > 4k

2024-10-11 Thread Adrián Larumbe
Hi Boris, On 09.10.2024 09:10, Steven Price wrote: > On 08/10/2024 09:47, Boris Brezillon wrote: > > The system and GPU MMU page size might differ, which becomes a > > problem for FW sections that need to be mapped at explicit address > > since our PAGE_SIZE alignment might cover a VA range that's

[PATCH v2] drm/msm/dpu: don't always activate merge_3d block

2024-10-11 Thread Jessica Zhang
Only enable the merge_3d block for the video phys encoder when the 3d blend mode is not *_NONE since there is no need to activate the merge_3d block for cases where merge_3d is not needed. Fixes: 3e79527a33a8 ("drm/msm/dpu: enable merge_3d support on sm8150/sm8250") Suggested-by: Abhinav Kumar Si

Re: [PATCH 4/4] drm/panel: samsung-s6e88a0-ams427ap24: Add flip option

2024-10-11 Thread Jessica Zhang
On 10/10/2024 11:31 AM, Jakob Hauser wrote: The way of implementing a flip option follows the existing panel-samsung-s6e8aa0.c [1][2][3]. The value to flip the screen is taken from a downstream kernel file of a similar but older panel [4]. The mipi clock [5] for the new panel samsung-s6e88a0-

Re: [PATCH 4/7] drm/ttm: move LRU walk defines into new internal header

2024-10-11 Thread Thomas Hellström
On Thu, 2024-10-10 at 10:00 +0200, Christian König wrote: > Am 09.10.24 um 16:17 schrieb Thomas Hellström: > > On Wed, 2024-10-09 at 15:39 +0200, Thomas Hellström wrote: > > > On Mon, 2024-10-07 at 11:08 +0200, Christian König wrote: > > > > Hi Thomas, > > > > > > > > I'm on sick leave, but I will

Re: [PATCH 2/4] drm/panel: samsung-s6e88a0-ams427ap24: Add initial driver

2024-10-11 Thread Jessica Zhang
On 10/10/2024 11:31 AM, Jakob Hauser wrote: This initial part of the panel driver was mostly generated by the "linux-mdss-dsi-panel-driver-generator" tool [1], reading downstream Android kernel file "dsi_panel_S6E88A0_AMS427AP24_qhd_octa_video.dtsi" [2]. On top of the generic output of the to

RE: [PATCH v5 0/7] drm/mgag200: Implement VBLANK support

2024-10-11 Thread Luck, Tony
Posted too soon. Some time (kernel timestamps say a few minutes) after the successful boot the console spewed another stack dump and the machine hung. -Tony brk-bdx-01 login: [ 364.922549] [ cut here ] [ 364.927987] mgag200 :08:00.0: [drm] drm_WARN_ON(pipe >= dev->n

RE: [PATCH v5 0/7] drm/mgag200: Implement VBLANK support

2024-10-11 Thread Luck, Tony
Progress! My system now boots. But there's one WARN_ON dump along the way to the "login:" prompt. Thanks -Tony --- [ 33.111505] Console: switching to colour dummy device 80x25 [ 33.119581] mgag200 :08:00.0: vgaarb: deactivate vga console [ 33.139574] [drm] Initialized mgag200 1.0.0 f

[PATCH] drm/edid: transition to passing struct cea_db * to cae_db_payload_len

2024-10-11 Thread Vamsi Krishna Brahmajosyula
Address the FIXME in cea_db_payload_len Transition to passing struct cea_db * everywhere Precompute the payload length in drm_parse_cea_ext and pass to individual parsers to avoid casting struct cea_db pointer to u8 pointer where length is needed. Since the type of payload length is incon

Re: [PATCH net-next v25 10/13] net: add SO_DEVMEM_DONTNEED setsockopt to release RX frags

2024-10-11 Thread Jakub Kicinski
On Thu, 10 Oct 2024 12:05:38 -0700 Mina Almasry wrote: > diff --git a/net/core/sock.c b/net/core/sock.c > index 083d438d8b6f..cb3d8b19de14 100644 > --- a/net/core/sock.c > +++ b/net/core/sock.c > @@ -1071,11 +1071,11 @@ sock_devmem_dontneed(struct sock *sk, > sockptr_t optval, unsigned int optlen)

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-11 Thread Pavel Machek
Hi! > > 1. > > https://lore.kernel.org/all/6b32fb73-0544-4a68-95ba-e82406a4b...@gmx.de/ > > -> Should be no problem? Because this is not generally exposing wmi > > calls, just mapping two explicitly with sanitized input (whitelisting > > basically). > > It would be OK to expose a selected set of

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-11 Thread Pavel Machek
Hi! > > > There is a slight difference between mouse support and LEDs on your > > > keyboard. The former is actually required to bring up the machine and to > > > use it, the latter is nice to have. > > > > But that's not the difference that matters. Linux is not microkernel, > > and is trying to

[PATCH 4/6] drm/panel: panel-samsung-s6e3ha2: Include

2024-10-11 Thread Thomas Zimmermann
Include directly to get struct of_device_id. Avoids the proxy include via Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Jessica Zhang --- drivers/gpu/drm/panel/panel-samsung-s6e63j0x03.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e63j0

[PATCH 6/6] drm/tiny: panel-mipi-dbi: Include

2024-10-11 Thread Thomas Zimmermann
Include directly to get of_property_read_string_index(). Avoids the proxy include via Signed-off-by: Thomas Zimmermann Cc: "Noralf Trønnes" --- drivers/gpu/drm/tiny/panel-mipi-dbi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tiny/panel-mipi-dbi.c b/drivers/gpu/drm/ti

[PATCH 1/6] drm/fsl-dcu: Include

2024-10-11 Thread Thomas Zimmermann
Include directly to get of_parse_phandle(). Avoids the proxy include via Signed-off-by: Thomas Zimmermann Cc: Stefan Agner Cc: Alison Wang --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c b/drivers/gp

[PATCH 5/6] drm/panel: panel-samsung-s6e63m0: Include

2024-10-11 Thread Thomas Zimmermann
Include directly to get device_property_read_u32(). Avoids the proxy include via Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Jessica Zhang --- drivers/gpu/drm/panel/panel-samsung-s6e63m0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e

[PATCH 3/6] drm/panel: panel-orisetech-otm8009a: Include

2024-10-11 Thread Thomas Zimmermann
Include directly to get struct of_device_id. Avoids the proxy include via Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Jessica Zhang --- drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm80

[PATCH 0/6] drm: Trivial include fixes

2024-10-11 Thread Thomas Zimmermann
Fix several proxy includes related to , which in turn includes . This includes several more headers that declare interfaces used by drivers. As backlight.h is expected to not refer to fb.h soon, resolve the proxy includes by including required header files directly. Thomas Zimmermann (6): drm/fs

[PATCH 2/6] drm/panel: Include

2024-10-11 Thread Thomas Zimmermann
Include directly to get of_device_is_available(). Avoids the proxy include via Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Jessica Zhang --- drivers/gpu/drm/drm_panel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c i

Re: [PATCH v12 13/15] drm/vkms: Create KUnit tests for YUV conversions

2024-10-11 Thread Louis Chauvet
On 11/10/24 - 12:49, Maxime Ripard wrote: > On Tue, Oct 08, 2024 at 11:23:22AM GMT, Louis Chauvet wrote: > > > > Hi, > > > > > > + * The YUV color representation were acquired via the colour python > > > > framework. > > > > + * Below are the function calls used for generating each case. > > >

Re: [PATCH net-next 3/3] accel/qaic: Pass string literal as format argument of alloc_workqueue()

2024-10-11 Thread Jeffrey Hugo
On 10/11/2024 3:57 AM, Simon Horman wrote: Recently I noticed that both gcc-14 and clang-18 report that passing a non-string literal as the format argument of alloc_workqueue() is potentially insecure. E.g. clang-18 says: .../qaic_drv.c:61:23: warning: format string is not a string literal (po

Re: [PATCH 1/4] dt-bindings: display: panel: Add Samsung S6E88A0-AMS427AP24 bindings

2024-10-11 Thread Rob Herring
On Thu, Oct 10, 2024 at 08:31:48PM +0200, Jakob Hauser wrote: > Add bindings for Samsung AMS427AP24 panel with S6E88A0 controller. > > Signed-off-by: Jakob Hauser > --- > Patch is based on https://gitlab.freedesktop.org/drm/misc/kernel.git > current branch drm-misc-next. > --- > .../panel/samsun

Re: [PATCH] drm/panel: himax-hx83102: Adjust power and gamma to optimize brightness

2024-10-11 Thread Doug Anderson
Hi, On Thu, Oct 10, 2024 at 7:08 PM Cong Yang wrote: > > The current panel brightness is only 360 nit. Adjust the power and gamma to > optimize the panel brightness. The brightness after adjustment is 390 nit. > > Fixes: 3179338750d8 ("drm/panel: Support for IVO t109nw41 MIPI-DSI panel") > Signed

Re: [PATCH v12 09/15] drm/vkms: Remove useless drm_rotation_simplify

2024-10-11 Thread Maxime Ripard
On Fri, Oct 11, 2024 at 10:53:52AM GMT, Maira Canal wrote: > Hi Louis, > > On 10/11/24 06:36, Louis Chauvet wrote: > > > > Hi all, > > > > Until this point, this series has not received any major comments since > > v9. I will commit patches 1-9 next week if there are no further comments. > > >

Re: [PATCH v12 09/15] drm/vkms: Remove useless drm_rotation_simplify

2024-10-11 Thread Maira Canal
Hi Louis, On 10/11/24 06:36, Louis Chauvet wrote: Hi all, Until this point, this series has not received any major comments since v9. I will commit patches 1-9 next week if there are no further comments. Although we are maintainers of VKMS, it isn't recommended that we push our own changes

Re: [PATCH 2/3] drm: logicvc: switch to for_each_child_of_node_scoped()

2024-10-11 Thread Javier Carrasco
On 11/10/2024 15:01, Louis Chauvet wrote: > Hi, > > I think you can squash this commit with the prvious one, I don't think > this is needed to add of_node_put and remove it just after. > > Thanks, > Louis Chauvet > Hi Louis, Thanks for your review. I did not squash them because the first one

Re: [PATCH 2/3] drm: logicvc: switch to for_each_child_of_node_scoped()

2024-10-11 Thread Louis Chauvet
On 11/10/24 - 15:01, Louis Chauvet wrote: > Hi, > > I think you can squash this commit with the prvious one, I don't think > this is needed to add of_node_put and remove it just after. Forget this, I missed the Fixes in the first commit, sorry for the noise. Reviewed-by: Louis Chauvet > Thank

Re: [PATCH 1/3] drm: logicvc: fix missing of_node_put() in for_each_child_of_node()

2024-10-11 Thread Louis Chauvet
On 11/10/24 - 01:11, Javier Carrasco wrote: > Early exits from the for_each_child_of_node() loop require explicit > calls to of_node_put() for the child node. > > Add the missing 'of_node_put(layer_node)' in the only error path. > > Cc: sta...@vger.kernel.org > Fixes: efeeaefe9be5 ("drm: Add supp

Re: [PATCH 2/3] drm: logicvc: switch to for_each_child_of_node_scoped()

2024-10-11 Thread Louis Chauvet
Hi, I think you can squash this commit with the prvious one, I don't think this is needed to add of_node_put and remove it just after. Thanks, Louis Chauvet On 11/10/24 - 01:11, Javier Carrasco wrote: > Use the scoped variant of the macro to avoid leaking memory upon early > exits without the r

Re: [PATCH 3/3] drm: logicvc: use automatic cleanup facility for layers_node

2024-10-11 Thread Louis Chauvet
On 11/10/24 - 01:11, Javier Carrasco wrote: > Use the more robust approach provided by the __free() macro to > automatically call of_node_put() when the device node goes out of scope. > > Signed-off-by: Javier Carrasco Reviewed-by: Louis Chauvet > --- > drivers/gpu/drm/logicvc/logicvc_layer.c

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-11 Thread Armin Wolf
Am 09.10.24 um 11:55 schrieb Werner Sembach: Resend because HTML mail ..., but I think I now know when Thunderbird does it: Every time I include a link it gets converted. Hi Am 08.10.24 um 17:21 schrieb Benjamin Tissoires: On Oct 08 2024, Werner Sembach wrote: [...] Yeah, it just means that

Re: [PATCH v2 0/2] drm/bridge: tc358767: Fix DRM_BRIDGE_ATTACH_NO_CONNECTOR case

2024-10-11 Thread Tomi Valkeinen
Hi, On 23/09/2024 15:25, Dmitry Baryshkov wrote: As Dmitry asked me during Plumbers to revalidate if our setup still needs patch 2, I just did that over 6.11.0-next-20240923 (where patch 1 is now included). No surprise, it is still needed for our iot2050 device series, otherwise the display rem

Re: [PATCH v4 7/7] drm/log: Add integer scaling support

2024-10-11 Thread Jocelyn Falempe
On 11/10/2024 13:18, Jani Nikula wrote: On Fri, 11 Oct 2024, Jocelyn Falempe wrote: Add a module parameter, to increase the font size for HiDPI screen. Even with CONFIG_FONT_TER16x32, it can still be a bit small to read. In this case, adding drm_log.scale=2 to your kernel command line will doub

Re: [PATCH] drm/ttm: Fix incorrect use of kernel-doc format

2024-10-11 Thread Thomas Hellström
On Thu, 2024-10-10 at 16:26 +0200, Nirmoy Das wrote: > > On 10/10/2024 2:45 PM, Thomas Hellström wrote: > > Add a missing colon. > > > > Cc: dri-devel@lists.freedesktop.org > > Reported-by: Stephen Rothwell > > Closes: > > https://lore.kernel.org/linux-next/20241010160942.192ca...@canb.auug.org.

Re: [PATCH v4 7/7] drm/log: Add integer scaling support

2024-10-11 Thread Jani Nikula
On Fri, 11 Oct 2024, Jocelyn Falempe wrote: > Add a module parameter, to increase the font size for HiDPI screen. > Even with CONFIG_FONT_TER16x32, it can still be a bit small to read. > In this case, adding drm_log.scale=2 to your kernel command line will > double the character size. > > Signed-o

[PULL] drm-intel-next

2024-10-11 Thread Jani Nikula
Hi Dave & Sima - Here's the first i915 feature pull towards v6.13. drm-intel-next-2024-10-11: drm/i915 features for v6.13: Features and functionality: - Enable BMG and LNL+ ultra joiner support to join 2+2 pipes (Ankit, Stan) - Enable 10bpc+CCS scanout for ICL+ and fp16+CCS scanout for TGL+ (V

Re: [PATCH 4/8] drm/bridge: fsl-ldb: Use clk_round_rate() to validate "ldb" clock rate

2024-10-11 Thread Maxime Ripard
On Mon, Sep 30, 2024 at 03:55:30PM GMT, Liu Ying wrote: > On 09/30/2024, Maxime Ripard wrote: > > On Mon, Sep 30, 2024 at 01:28:59PM GMT, Liu Ying wrote: > >> Multiple display modes could be read from a display device's EDID. > >> Use clk_round_rate() to validate the "ldb" clock rate for each mode

Re: [PATCH 0/2] accel/ivpu: Intel NPU Panther Lake support

2024-10-11 Thread Jacek Lawrynowicz
Applied to drm-misc-next On 10/4/2024 6:25 PM, Maciej Falkowski wrote: > This patchset adds initial support for 5th generation Intel NPU > that is going to be present in the upcoming Panther Lake CPUs. > > Maciej Falkowski (1): > accel/ivpu: Add initial Panther Lake support > > Wachowski, Karo

[PATCH v4 7/7] drm/log: Add integer scaling support

2024-10-11 Thread Jocelyn Falempe
Add a module parameter, to increase the font size for HiDPI screen. Even with CONFIG_FONT_TER16x32, it can still be a bit small to read. In this case, adding drm_log.scale=2 to your kernel command line will double the character size. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_log.c |

[PATCH v4 6/7] drm/log: Implement suspend/resume

2024-10-11 Thread Jocelyn Falempe
The console is already suspended in printk.c. Just make sure we don't write to the framebuffer while the graphic driver is suspended. It may lose a few messages between graphic suspend and console suspend. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_log.c | 26

[PATCH v4 5/7] drm/log: Color the timestamp, to improve readability

2024-10-11 Thread Jocelyn Falempe
Color the timesamp prefix, similar to dmesg. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_log.c | 27 +-- 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_log.c b/drivers/gpu/drm/drm_log.c index 226e206e8b6a..635dff7b37ce 100644

[PATCH v4 4/7] drm/log: Do not draw if drm_master is taken

2024-10-11 Thread Jocelyn Falempe
When userspace takes drm_master, the drm_client buffer is no more visible, so drm_log shouldn't waste CPU cycle to draw on it. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_log.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_log.c b/d

[PATCH v4 3/7] drm/log: Introduce a new boot logger to draw the kmsg on the screen

2024-10-11 Thread Jocelyn Falempe
drm_log is a simple logger that uses the drm_client API to print the kmsg boot log on the screen. This is not a full replacement to fbcon, as it will only print the kmsg. It will never handle user input, or a terminal because this is better done in userspace. Design decisions: * It uses the drm_c

[PATCH v4 2/7] drm/panic: Move drawing functions to drm_draw

2024-10-11 Thread Jocelyn Falempe
Move the color conversions, blit and fill functions to drm_draw.c, so that they can be re-used by drm_log. drm_draw is internal to the drm subsystem, and shouldn't be used by gpu drivers. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/Kconfig | 5 + drivers/gpu/drm/Makefile| 1 +

[PATCH v4 1/7] [NOT FOR REVIEW] drm/client, squash of drm client pending series

2024-10-11 Thread Jocelyn Falempe
From: Thomas Zimmermann squashed patch of v3 of drm: Introduce DRM client library https://patchwork.freedesktop.org/series/139219/ --- Documentation/gpu/drm-client.rst | 3 + drivers/gpu/drm/Kconfig | 41 +++- drivers/gpu/drm/Makefile |

[PATCH v4 0/7] drm/log: Introduce a new boot logger to draw the kmsg on the screen

2024-10-11 Thread Jocelyn Falempe
drm_log is a simple logger that uses the drm_client API to print the kmsg boot log on the screen. This is not a full replacement to fbcon, as it will only print the kmsg. It will never handle user input, or a terminal because this is better done in userspace. If you're curious on how it looks li

Re: [PATCH 0/7] drm: Add physical status and BMC support to conenctor

2024-10-11 Thread Maxime Ripard
Hi, On Fri, Oct 11, 2024 at 08:43:05AM GMT, Thomas Zimmermann wrote: > Track a connector's physical status separately from the logical status > and implement BMC support for DRM drivers. Connectors with virtual BMC > stay connected even if no display is physically connected. DRM clients > then con

Re: [PATCH v12 13/15] drm/vkms: Create KUnit tests for YUV conversions

2024-10-11 Thread Maxime Ripard
On Tue, Oct 08, 2024 at 11:23:22AM GMT, Louis Chauvet wrote: > > Hi, > > > > + * The YUV color representation were acquired via the colour python > > > framework. > > > + * Below are the function calls used for generating each case. > > > + * > > > + * For more information got to the docs: > >

Re: [PATCH] drm/nouveau/i2c: rename aux.c and aux.h to auxch.c and auxch.h

2024-10-11 Thread Szőke Benjamin
2024. 10. 10. 23:17 keltezéssel, Lyude Paul írta: Hi - how did you send this message? This patch comes out looking quite strange on my machine, perhaps you don't have the encoding set to UTF-8 or aren't using git send-email? On Mon, 2024-09-23 at 22:18 +0200, Szőke Benjamin wrote: s=201

[PATCH net-next 3/3] accel/qaic: Pass string literal as format argument of alloc_workqueue()

2024-10-11 Thread Simon Horman
Recently I noticed that both gcc-14 and clang-18 report that passing a non-string literal as the format argument of alloc_workqueue() is potentially insecure. E.g. clang-18 says: .../qaic_drv.c:61:23: warning: format string is not a string literal (potentially insecure) [-Wformat-security] 61

[PATCH net-next 2/3] net: txgbe: Pass string literal as format argument of alloc_workqueue()

2024-10-11 Thread Simon Horman
Recently I noticed that both gcc-14 and clang-18 report that passing a non-string literal as the format argument of clkdev_create() is potentially insecure. E.g. clang-18 says: .../txgbe_phy.c:582:35: warning: format string is not a string literal (potentially insecure) [-Wformat-security] 581

[PATCH net-next 1/3] net: dsa: microchip: copy string using strscpy

2024-10-11 Thread Simon Horman
Prior to this patch ksz_ptp_msg_irq_setup() uses snprintf() to copy strings. It does so by passing strings as the format argument of snprintf(). This appears to be safe, due to the absence of format specifiers in the strings, which are declared within the same function. But nonetheless GCC 14 warns

[PATCH net-next 0/3] net: String format safety updates

2024-10-11 Thread Simon Horman
Hi, This series addresses string format safety issues that are flagged by tooling in files touched by recent patches. I do not believe that any of these issues are bugs. Rather, I am providing these updates as I think there is a value in addressing such warnings so real problems stand out. --- S

Re: [PATCH v12 09/15] drm/vkms: Remove useless drm_rotation_simplify

2024-10-11 Thread Louis Chauvet
Hi all, Until this point, this series has not received any major comments since v9. I will commit patches 1-9 next week if there are no further comments. For patches 10-15, I am currently waiting for feedback from Maxime to send the next iteration with a fix for kunit tests. Thanks, Louis Ch

Re: [PATCH v2 2/3] PCI: Allow extending VF BAR within original resource boundary

2024-10-11 Thread Christian König
Re-sending this as text from my private mail account since the AMD servers now seem to convert everything to HTML ^^. Christian. Am 11.10.24 um 10:57 schrieb Christian König: Am 10.10.24 um 10:59 schrieb Michał Winiarski: On Fri, Sep 20, 2024 at 12:07:34PM +0200, Christian König wrote: Am 20

  1   2   >