Re: [PATCH] drm/vc4: Set `fbdev_probe` in `struct vc5_drm_driver`

2024-10-08 Thread Thomas Zimmermann
Hi Am 09.10.24 um 02:40 schrieb Maíra Canal: Currently, when booting the RPi 4B, we get a NULL pointer dereference: [7.642883] Unable to handle kernel NULL pointer dereference at virtual address 0038 [7.642926] Mem abort info: [7.642938] ESR = 0x9644 [

[PATCH 2/2] drm/msm/dpu: configure DSC per number in use

2024-10-08 Thread Jun Nie
Only 2 DSC engines are allowed, or no DSC is involved currently. We need 4 DSC in quad-pipe topology in future. So let's only configure DSC engines in use, instread of maximum number of DSC engines. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 13 - 1 file

[PATCH 0/2] drm/msm/dpu: Support different number of DSC

2024-10-08 Thread Jun Nie
If DSC is enabled, the only case is with 2 DSC engines so far. And DSC in all pipes are configured by default. More usage case will be added, such as 4 DSC in 4:4:2 topoplogy. Pipe number is extended in future to support quad-pipe. But only some of 4 pipes are used in non quad-pipe. So number of D

[PATCH 1/2] drm/msm/dpu: Do not fix number of DSC

2024-10-08 Thread Jun Nie
If DSC is enabled, the only case is with 2 DSC engines so far. More usage case will be added, such as 4 DSC in 4:4:2 topoplogy. So get real number of DSCs to decide whether DSC merge is needed. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h| 2 ++ drivers/gpu/drm/msm/dis

Re: radeon drm fails to load on v6.12-rc2 "Bogus possible_clones: [ENCODER:46:TV-46] possible_clones=0x4 (full encoder mask=0x7)" ( Thinkpad T60)

2024-10-08 Thread Ville Syrjälä
On Wed, Oct 09, 2024 at 12:03:21AM +0200, Erhard Furtner wrote: > Greetings! > > On kernel v6.12-rc I get no X and dmesg (via netconsole) shows this at > loading radeon drm: > > [...] > [drm] PCIE GART of 512M enabled (table at 0x0004). > radeon :01:00.0: WB enabled > radeon

Re: [PATCH v3 04/14] drm/mediatek: Fix XRGB setting error in Mixer

2024-10-08 Thread 宋孝謙

linux-next: build warning after merge of the drm-misc tree

2024-10-08 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (htmldocs) produced this warning: include/drm/drm_file.h:400: warning: Function parameter or struct member 'client_name_lock' not described in 'drm_file' include/drm/drm_file.h:400: warning: Excess struct member 'name_lock' descr

Re: [PATCH 3/3] drm/vc4: Correct generation check in vc4_hvs_lut_load

2024-10-08 Thread Marek Szyprowski
On 08.10.2024 18:44, Dave Stevenson wrote: > Commit 24c5ed3ddf27 ("drm/vc4: Introduce generation number enum") > incorrectly swapped a check of hvs->vc4->is_vc5 to > hvs->vc4->gen == VC4_GEN_4 in vc4_hvs_lut_load, hence breaking > loading the gamma look up table on Pi0-3. > > Correct that condition

Re: [PATCH 2/3] drm/vc4: Match drm_dev_enter and exit calls in vc4_hvs_atomic_flush

2024-10-08 Thread Marek Szyprowski
On 08.10.2024 18:44, Dave Stevenson wrote: > Commit 92c17d16476c ("drm/vc4: hvs: Ignore atomic_flush if we're disabled") > added a path which returned early without having called drm_dev_exit. > > Ensure all paths call drm_dev_exit. > > Fixes: 92c17d16476c ("drm/vc4: hvs: Ignore atomic_flush if we'

Re: [PATCH 1/3] drm/vc4: Match drm_dev_enter and exit calls in vc4_hvs_lut_load

2024-10-08 Thread Marek Szyprowski
On 08.10.2024 18:44, Dave Stevenson wrote: > Commit 52efe364d196 ("drm/vc4: hvs: Don't write gamma luts on 2711") > added a return path to vc4_hvs_lut_load that had called > drm_dev_enter, but not drm_dev_exit. > > Ensure we call drm_dev_exit. > > Fixes: 52efe364d196 ("drm/vc4: hvs: Don't write gam

Re: [v10 4/5] drm/mediatek: ovl: Add blend_modes to driver data

2024-10-08 Thread Markus Elfring
>> … >>> pre-multiplied is supported in the current platform. >> … >> >> format would be? … > blend_modes is the driver data that describes the supported blend mode > in current platform no matter format would be any one. > > This sentence is describing mtk_ovl_fmt_convert() will c

Re: [PATCH v2 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools

2024-10-08 Thread Thomas Hellström
On Sat, 2024-10-05 at 04:14 +, Matthew Brost wrote: > On Fri, Oct 04, 2024 at 04:28:29PM +0200, Thomas Hellström wrote: > > On Wed, 2024-10-02 at 14:54 +0200, Thomas Hellström wrote: > > > On Wed, 2024-10-02 at 14:45 +0200, Christian König wrote: > > > > Am 02.10.24 um 14:24 schrieb Thomas Hell

[RFC PATCH] drm/bridge: panel: Use devm_drm_bridge_add()

2024-10-08 Thread Fei Shao
In the mtk_dsi driver, its DSI host attach callback calls devm_drm_of_get_bridge() to get the next bridge. If that next bridge is a panel bridge, a panel_bridge object is allocated and managed by the panel device. Later, if the attach callback fails with -EPROBE_DEFER from subsequent component_add

[PATCH v11 0/5] Fix degradation problem of alpha blending series

2024-10-08 Thread Jason-JH . Lin
Some SoCs do not support the ignore_pixl_alpha flag, which breaks the XRGB format. Some SoCs do not support pre-multiplied pixel formats and extending configuration of OVL pre-multiplied color formats, such as MT8173. Fix the SoC degradation problem by this series. Tested-by: Chen-Yu Tsai --

[PATCH v11 2/5] drm/mediatek: ovl: Refine ignore_pixel_alpha comment and placement

2024-10-08 Thread Jason-JH . Lin
Refine the comment for ignore_pixel_alpha flag and move it to if(state->fb) statement to make it less conditional. Signed-off-by: Jason-JH.Lin Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 18 +- 1 file changed, 9 inse

[PATCH v11 5/5] drm/mediatek: Add blend_modes to mtk_plane_init() for different SoCs

2024-10-08 Thread Jason-JH . Lin
Since some SoCs support premultiplied pixel formats but some do not, the blend_modes parameter is added to mtk_plane_init(), which is obtained from the mtk_ddp_comp_get_blend_modes function implemented in different blending supported components. The blending supported components can use driver dat

[PATCH v11 4/5] drm/mediatek: ovl: Add blend_modes to driver data

2024-10-08 Thread Jason-JH . Lin
OVL_CON_CLRFMT_MAN is a configuration for extending color format settings of DISP_REG_OVL_CON(n). It will change some of the original color format settings. Take the settings of (3 << 12) for example. - If OVL_CON_CLRFMT_MAN = 0 means OVL_CON_CLRFMT_RGBA. - If OVL_CON_CLRFMT_MAN = 1 means OVL_

[PATCH v11 3/5] drm/mediatek: ovl: Remove the color format comment for ovl_fmt_convert()

2024-10-08 Thread Jason-JH . Lin
Since we changed MACROs to be consistent with DRM input color format naming, the comment for ovl_fmt_conver() is no longer needed. Fixes: 9f428b95ac89 ("drm/mediatek: Add new color format MACROs in OVL") Signed-off-by: Jason-JH.Lin Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c

[PATCH v11 1/5] drm/mediatek: ovl: Fix XRGB format breakage for blend_modes unsupported SoCs

2024-10-08 Thread Jason-JH . Lin
OVL_CON_AEN is for alpha blending enable. For the SoC that is supported the blend_modes, OVL_CON_AEN will always enabled to use constant alpha and then use the ignore_pixel_alpha bit to do the alpha blending for XRGB format. Note that ignore pixel alpha bit is not supported if the SoC is not su

Re: [PATCH v10 4/5] drm/mediatek: ovl: Add blend_modes to driver data

2024-10-08 Thread 林睿祥

Re: [PATCH v10 1/5] drm/mediatek: ovl: Fix XRGB format breakage for blend_modes unsupported SoCs

2024-10-08 Thread 胡俊光

[PATCH v7 9/9] media: xilinx-tpg: use new of_graph functions

2024-10-08 Thread Kuninori Morimoto
Now we can use new port related functions for port parsing. Use it. Signed-off-by: Kuninori Morimoto Reviewed-by: Tomi Valkeinen --- drivers/media/platform/xilinx/xilinx-tpg.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/media/platform/xilinx/xilin

[PATCH v7 8/9] fbdev: omapfb: use new of_graph functions

2024-10-08 Thread Kuninori Morimoto
Now we can use new port related functions for port parsing. Use it. Signed-off-by: Kuninori Morimoto --- drivers/video/fbdev/omap2/omapfb/dss/dpi.c| 3 +- drivers/video/fbdev/omap2/omapfb/dss/dss-of.c | 66 --- drivers/video/fbdev/omap2/omapfb/dss/dss.c| 20 +++--- drive

[PATCH v7 7/9] gpu: drm: omapdrm: use new of_graph functions

2024-10-08 Thread Kuninori Morimoto
Now we can use new port related functions for port parsing. Use it. Signed-off-by: Kuninori Morimoto Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dpi.c | 3 ++- drivers/gpu/drm/omapdrm/dss/sdi.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/d

[PATCH v7 6/9] ASoC: audio-graph-card2: use new of_graph functions

2024-10-08 Thread Kuninori Morimoto
Now we can use new port related functions for port parsing. Use it. Signed-off-by: Kuninori Morimoto Acked-by: Mark Brown --- sound/soc/generic/audio-graph-card2.c | 104 -- 1 file changed, 48 insertions(+), 56 deletions(-) diff --git a/sound/soc/generic/audio-graph-car

[PATCH v7 4/9] ASoC: test-component: use new of_graph functions

2024-10-08 Thread Kuninori Morimoto
Current test-component.c is using for_each_endpoint_of_node() for parsing "port", because there was no "port" base loop before. It has been assuming 1 port has 1 endpoint here. But now we can use "port" base loop (= for_each_of_graph_port()). Let's replace for_each function from "endpoint" base to

[PATCH v7 5/9] ASoC: audio-graph-card: use new of_graph functions

2024-10-08 Thread Kuninori Morimoto
Now we can use new port related functions for port parsing. Use it. Signed-off-by: Kuninori Morimoto Acked-by: Mark Brown --- sound/soc/generic/audio-graph-card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-

[PATCH v7 3/9] of: property: use new of_graph functions

2024-10-08 Thread Kuninori Morimoto
Current of_graph_get_next_endpoint() can be replaced by using new of_graph_get_next_port(). Signed-off-by: Kuninori Morimoto --- drivers/of/property.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/of/property.c b/drivers/of/property.c index bf15b

[PATCH v7 2/9] of: property: add of_graph_get_next_port_endpoint()

2024-10-08 Thread Kuninori Morimoto
We already have of_graph_get_next_endpoint(), but it is not intuitive to use in some case. (X) node { (Y) ports { (P0)port@0 { endpoint { remote-endpoint = ...; };}; (P10) port@1 { endpoint { remote-endpoint = ...; }; (P11)

[PATCH v7 1/9] of: property: add of_graph_get_next_port()

2024-10-08 Thread Kuninori Morimoto
We have endpoint base functions - of_graph_get_next_endpoint() - of_graph_get_endpoint_count() - for_each_endpoint_of_node() Here, for_each_endpoint_of_node() loop finds each endpoints ports { port@0 { (1) endpoint {...};

[PATCH v7 0/9] of: property: add of_graph_get_next_port/port_endpoint()

2024-10-08 Thread Kuninori Morimoto
Hi Rob, Saravana, Tomi, Laurent, Sakari, Mark This is v7 patch-set Current Of-graph has "endpoint base" for loop, but doesn't have "port base" loop. "endpoint base" loop only is not enough. This patch-set add new "port base" for loop, and use it. v6 -> v7 - based on latest linus/master

Re:[PATCH drm-dp 1/4] drm/hisilicon/hibmc: add dp aux in hibmc drivers

2024-10-08 Thread Andy Yan
Hi Baihan, At 2024-10-01 15:26:23, "shiyongbang" wrote: >From: baihan li > >Add dp aux read/write functions. They are basic functions > and will be used later. > >Signed-off-by: baihan li >--- > drivers/gpu/drm/hisilicon/hibmc/Makefile | 3 +- > drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.c

Re: [PATCH v10 1/5] drm/mediatek: ovl: Fix XRGB format breakage for blend_modes unsupported SoCs

2024-10-08 Thread 林睿祥

Re: [PATCH v10 0/5] Fix degradation problem of alpha blending series

2024-10-08 Thread 林睿祥

Re: [PATCH 3/3] drm/vc4: Correct generation check in vc4_hvs_lut_load

2024-10-08 Thread Maíra Canal
Hi Dave, On 10/8/24 13:44, Dave Stevenson wrote: Commit 24c5ed3ddf27 ("drm/vc4: Introduce generation number enum") incorrectly swapped a check of hvs->vc4->is_vc5 to hvs->vc4->gen == VC4_GEN_4 in vc4_hvs_lut_load, hence breaking loading the gamma look up table on Pi0-3. Correct that conditional

Re: [PATCH 2/3] drm/vc4: Match drm_dev_enter and exit calls in vc4_hvs_atomic_flush

2024-10-08 Thread Maíra Canal
Hi Dave, On 10/8/24 13:44, Dave Stevenson wrote: Commit 92c17d16476c ("drm/vc4: hvs: Ignore atomic_flush if we're disabled") added a path which returned early without having called drm_dev_exit. Ensure all paths call drm_dev_exit. Fixes: 92c17d16476c ("drm/vc4: hvs: Ignore atomic_flush if we'r

Re: [PATCH 1/3] drm/vc4: Match drm_dev_enter and exit calls in vc4_hvs_lut_load

2024-10-08 Thread Maíra Canal
Hi Dave, On 10/8/24 13:44, Dave Stevenson wrote: Commit 52efe364d196 ("drm/vc4: hvs: Don't write gamma luts on 2711") added a return path to vc4_hvs_lut_load that had called drm_dev_enter, but not drm_dev_exit. Ensure we call drm_dev_exit. Fixes: 52efe364d196 ("drm/vc4: hvs: Don't write gamma

[PATCH] drm/vc4: Set `fbdev_probe` in `struct vc5_drm_driver`

2024-10-08 Thread Maíra Canal
Currently, when booting the RPi 4B, we get a NULL pointer dereference: [7.642883] Unable to handle kernel NULL pointer dereference at virtual address 0038 [7.642926] Mem abort info: [7.642938] ESR = 0x9644 [7.642951] EC = 0x25: DABT (current EL), IL = 3

[PATCH] drm/amd/display: Remove unused cm3_helper_translate_curve_to_degamma_hw_format

2024-10-08 Thread linux
From: "Dr. David Alan Gilbert" cm3_helper_translate_curve_to_degamma_hw_format() since it was added in 2020's commit 03f54d7d3448 ("drm/amd/display: Add DCN3 DPP") Remove it. Signed-off-by: Dr. David Alan Gilbert --- .../amd/display/dc/dcn30/dcn30_cm_common.c| 151 -- .../

Re: [PATCH 3/5] dt-bindings: nvmem: convert zii,rave-sp-eeprom.txt to yaml format

2024-10-08 Thread Rob Herring (Arm)
bindings/nvmem/zii,rave-sp-eeprom.yaml: Documentation/devicetree/bindings/mfd/zii,rave-sp.yaml See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241008-zii_yaml-v1-3-d06ba7e26...@nxp.com The base for the series is generally the latest rc1. A different dependency shou

Re: [PATCH 4/5] dt-bindings: watchdog: convert zii,rave-sp-wdt.txt to yaml format

2024-10-08 Thread Rob Herring (Arm)
tion/devicetree/bindings/watchdog/zii,rave-sp-wdt.yaml: Documentation/devicetree/bindings/mfd/zii,rave-sp.yaml See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241008-zii_yaml-v1-4-d06ba7e26...@nxp.com The base for the series is generally the latest rc1. A different dependency shou

Re: [PATCH 2/5] dt-bindings: backlight: convert zii,rave-sp-backlight.txt to yaml

2024-10-08 Thread Rob Herring (Arm)
mentation/devicetree/bindings/leds/backlight/zii,rave-sp-backlight.yaml: Documentation/devicetree/bindings/mfd/zii,rave-sp.yaml See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241008-zii_yaml-v1-2-d06ba7e26...@nxp.com The base for the series is generally the latest rc1. A diffe

Re: [PATCH 1/5] dt-bindings: input: convert zii,rave-sp-pwrbutton.txt to yaml

2024-10-08 Thread Rob Herring (Arm)
i,rave-sp-pwrbutton.yaml: Documentation/devicetree/bindings/mfd/zii,rave-sp.yaml See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241008-zii_yaml-v1-1-d06ba7e26...@nxp.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* pat

[PATCH 1/2] clk: imx: clk-imx8mp: Allow LDB serializer clock reconfigure parent rate

2024-10-08 Thread Marek Vasut
The media_ldb_root_clk supply LDB serializer. These clock are usually shared with the LCDIFv3 pixel clock and supplied by the Video PLL on i.MX8MP, but the LDB clock run at either x7 or x14 rate of the LCDIFv3 pixel clock. Allow the LDB to reconfigure Video PLL as needed, as that results in accurat

[PATCH 2/2] drm: bridge: ldb: Configure LDB clock in .mode_set

2024-10-08 Thread Marek Vasut
The LDB serializer clock operate at either x7 or x14 rate of the input LCDIFv3 scanout engine clock. Make sure the serializer clock and their upstream Video PLL are configured early in .mode_set to the x7 or x14 rate of pixel clock, before LCDIFv3 .atomic_enable is called which would configure the

radeon drm fails to load on v6.12-rc2 "Bogus possible_clones: [ENCODER:46:TV-46] possible_clones=0x4 (full encoder mask=0x7)" ( Thinkpad T60)

2024-10-08 Thread Erhard Furtner
Greetings! On kernel v6.12-rc I get no X and dmesg (via netconsole) shows this at loading radeon drm: [...] [drm] PCIE GART of 512M enabled (table at 0x0004). radeon :01:00.0: WB enabled radeon :01:00.0: fence driver on ring 0 use gpu addr 0x0800 radeon :01:00

[PATCH 5/5] dt-bindings: mfd: convert zii,rave-sp.txt to yaml format

2024-10-08 Thread Frank Li
Convert device binding doc zii,rave-sp.txt to yaml format. Additional change: - ref to other zii yaml files. - remove rave-sp-hwmon and rave-sp-leds. Signed-off-by: Frank Li --- .../devicetree/bindings/mfd/zii,rave-sp.txt| 39 -- .../devicetree/bindings/mfd/zii,rave-sp.yaml

[PATCH 4/5] dt-bindings: watchdog: convert zii,rave-sp-wdt.txt to yaml format

2024-10-08 Thread Frank Li
Convert device binding doc zii,rave-sp-wdt.txt to yaml format. Additional changes: - Ref to watchdog.yaml. - Remove mfd node in example. - Remove eeprom part in example. Signed-off-by: Frank Li --- .../bindings/watchdog/zii,rave-sp-wdt.txt | 39 -- .../bindings/watchdog/

[PATCH 3/5] dt-bindings: nvmem: convert zii,rave-sp-eeprom.txt to yaml format

2024-10-08 Thread Frank Li
Convert device tree binding doc zii,rave-sp-eeprom.txt to yaml format. Additional changes: - Add ref to nvme.yaml. - Add reg property. - Remove mfd at example. Signed-off-by: Frank Li --- .../bindings/nvmem/zii,rave-sp-eeprom.txt | 40 .../bindings/nvmem/zii,rave-sp-eep

[PATCH 2/5] dt-bindings: backlight: convert zii,rave-sp-backlight.txt to yaml

2024-10-08 Thread Frank Li
Convert device tree binding doc zii,rave-sp-backlight.txt to yaml format. Additional Changes: - Remove mfd parent node at example. - Ref to backlight's common.yaml Signed-off-by: Frank Li --- .../leds/backlight/zii,rave-sp-backlight.txt | 23 -- .../leds/backlight/zii,rave-sp-b

[PATCH 1/5] dt-bindings: input: convert zii,rave-sp-pwrbutton.txt to yaml

2024-10-08 Thread Frank Li
Convert device tree binding doc zii,rave-sp-pwrbutton.txt to yaml format. Additional changes: - add ref to input.yaml. - remove mfd node in example. Signed-off-by: Frank Li --- .../bindings/input/zii,rave-sp-pwrbutton.txt | 22 - .../bindings/input/zii,rave-sp-pwrbutton.yaml

[PATCH 0/5] dt-bindings: mfd: convert zii,rave-sp.txt and child txt to yaml format

2024-10-08 Thread Frank Li
.../bindings/watchdog/zii,rave-sp-wdt.yaml | 47 10 files changed, 236 insertions(+), 163 deletions(-) --- base-commit: ba5c58f259ba6a60856db98052e0c79729acfe99 change-id: 20241008-zii_yaml-7b4802029873 Best regards, --- Frank Li

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-08 Thread Marek Vasut
On 10/8/24 12:07 PM, Isaac Scott wrote: On Mon, 2024-10-07 at 20:06 +0200, Marek Vasut wrote: On 10/7/24 7:01 PM, Isaac Scott wrote: Hi Marek, Hi, On Sat, 2024-07-06 at 02:16 +0200, Marek Vasut wrote: On 6/24/24 11:19 AM, Alexander Stein wrote: Am Freitag, 31. Mai 2024, 22:27:21 CEST schr

RE: [PATCH v3 12/12] drm/client: Add client-lib module

2024-10-08 Thread Cavitt, Jonathan
-Original Message- From: Intel-gfx On Behalf Of Thomas Zimmermann Sent: Tuesday, October 8, 2024 5:00 AM To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com Cc: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; intel-...@lists.freedesktop.org; in

RE: [PATCH v3 11/12] drm/client: Make client support optional

2024-10-08 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Thomas Zimmermann Sent: Tuesday, October 8, 2024 5:00 AM To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com Cc: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; intel-...@lists.freedesktop.org; int

RE: [PATCH v3 10/12] drm/radeon: Suspend and resume clients with client helpers

2024-10-08 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Thomas Zimmermann Sent: Tuesday, October 8, 2024 4:59 AM To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com Cc: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; intel-...@lists.freedesktop.org; int

RE: [PATCH v3 09/12] drm/nouveau: Suspend and resume clients with client helpers

2024-10-08 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Thomas Zimmermann Sent: Tuesday, October 8, 2024 4:59 AM To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com Cc: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; intel-...@lists.freedesktop.org; int

RE: [PATCH v3 08/12] drm/amdgpu: Suspend and resume internal clients with client helpers

2024-10-08 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Thomas Zimmermann Sent: Tuesday, October 8, 2024 4:59 AM To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com Cc: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; intel-...@lists.freedesktop.org; int

[PATCH] drm/xe/guc: Fix deference after check

2024-10-08 Thread Everest K.C.
The `if (!snapshot->copy)` evaluates to True only when `snapshot->copy` is Null. Thus, derefrencing `snapshot->copy` inside this if block is equivalent to Null pointer derefrencing. The `if` condition is now changed to evaluate to true only when `snapshot->copy` is not Null. This issue was reported

Re: [PATCH v2 1/1] drm/edp-panel: Add panels used by Dell XPS 13 9345

2024-10-08 Thread Peter de Kraker
On Tue, Oct 8, 2024 at 9:30 AM Aleksandrs Vinarskis wrote: > > Introduce low-res IPS and OLED panels for mentioned device. > > SHP panel's timings were picked experimentally, without this patch or with > `delay_200_500_e50` panel sometimes fails to boot/stays black on startup. > > LGD panel's timi

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2024-10-08 Thread kernel test robot
Hi Ekansh, kernel test robot noticed the following build warnings: [auto build test WARNING on char-misc/char-misc-testing] [also build test WARNING on char-misc/char-misc-next char-misc/char-misc-linus linus/master v6.12-rc2 next-20241008] [If your patch is applied to the wrong git tree

RE: [PATCH v3 07/12] drm/client: Move suspend/resume into DRM client callbacks

2024-10-08 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Thomas Zimmermann Sent: Tuesday, October 8, 2024 4:59 AM To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com Cc: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; intel-...@lists.freedesktop.org; int

RE: [PATCH v3 06/12] drm/client: Move client event handlers to drm_client_event.c

2024-10-08 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Thomas Zimmermann Sent: Tuesday, October 8, 2024 4:59 AM To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com Cc: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; intel-...@lists.freedesktop.org; int

Re: [v8,09/12] drm/msm/a6xx: Add traces for preemption

2024-10-08 Thread Kees Bakker
Op 03-10-2024 om 18:12 schreef Antonino Maniscalco: Add trace points corresponding to preemption being triggered and being completed for latency measurement purposes. Reviewed-by: Akhil P Oommen Tested-by: Rob Clark Tested-by: Neil Armstrong # on SM8650-QRD Tested-by: Neil Armstrong # on SM8

RE: [PATCH v3 05/12] drm/fbdev: Store fbdev module parameters in separate file

2024-10-08 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Thomas Zimmermann Sent: Tuesday, October 8, 2024 4:59 AM To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com Cc: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; intel-...@lists.freedesktop.org; int

RE: [PATCH v3 04/12] drm/fbdev: Select fbdev I/O helpers from modules that require them

2024-10-08 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Thomas Zimmermann Sent: Tuesday, October 8, 2024 4:59 AM To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com Cc: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; intel-...@lists.freedesktop.org; int

RE: [PATCH v3 03/12] drm/fbdev-dma: Select FB_DEFERRED_IO

2024-10-08 Thread Cavitt, Jonathan
-Original Message- From: Intel-gfx On Behalf Of Thomas Zimmermann Sent: Tuesday, October 8, 2024 4:59 AM To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com Cc: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; intel-...@lists.freedesktop.org; in

RE: [PATCH v3 02/12] drm/xe: Select DRM_CLIENT_SELECTION

2024-10-08 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Thomas Zimmermann Sent: Tuesday, October 8, 2024 4:59 AM To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com Cc: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; intel-...@lists.freedesktop.org; int

RE: [PATCH v3 01/12] drm/i915: Select DRM_CLIENT_SELECTION

2024-10-08 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Thomas Zimmermann Sent: Tuesday, October 8, 2024 4:59 AM To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com Cc: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; intel-...@lists.freedesktop.org; int

Re: [PATCH 00/51] treewide: Switch to __pm_runtime_put_autosuspend()

2024-10-08 Thread Uwe Kleine-König
Hello, On Mon, Oct 07, 2024 at 09:49:24PM +0300, Laurent Pinchart wrote: > On Fri, Oct 04, 2024 at 04:38:36PM +0200, Ulf Hansson wrote: > > On Fri, 4 Oct 2024 at 11:41, Sakari Ailus > > wrote: > > > > > > Hello everyone, > > > > > > This set will switch the users of pm_runtime_put_autosuspend()

Re: [PATCH v2 1/1] drm/edp-panel: Add panels used by Dell XPS 13 9345

2024-10-08 Thread Doug Anderson
Hi, On Tue, Oct 8, 2024 at 12:30 AM Aleksandrs Vinarskis wrote: > > Introduce low-res IPS and OLED panels for mentioned device. > > SHP panel's timings were picked experimentally, without this patch or with > `delay_200_500_e50` panel sometimes fails to boot/stays black on startup. > > LGD panel'

Re: [PATCH 4/8] drm/client: Make copies of modes

2024-10-08 Thread Ville Syrjälä
On Mon, Oct 07, 2024 at 09:36:13AM +0200, Thomas Zimmermann wrote: > Hi > > Am 03.10.24 um 13:33 schrieb Ville Syrjala: > > From: Ville Syrjälä > > > > drm_client_firmware_config() is currently picking up the current > > mode of the crtc via the legacy crtc->mode, which is not supposed > > to be

[PATCH-next v3] drm/amdgpu: Cleanup shift coding style

2024-10-08 Thread Advait Dhamorikar
Improves the coding style by updating bit-shift operations in the amdgpu_jpeg.c driver file. It ensures consistency and avoids potential issues by explicitly using 1U and 1ULL for unsigned and unsigned long long shifts in all relevant instances. Signed-off-by: Advait Dhamorikar --- v1->v2: addre

Re: [PATCH 8/8] drm/client: s/unsigned int i/int i/

2024-10-08 Thread Ville Syrjälä
On Mon, Oct 07, 2024 at 09:43:47AM +0200, Thomas Zimmermann wrote: > Hi > > Am 03.10.24 um 13:33 schrieb Ville Syrjala: > > From: Ville Syrjälä > > > > Replace the 'unsigned int i' footguns with plain old signed > > int. Avoids accidents if/when someone decides they need > > to iterate backwards.

RE: [PATCH v5 0/6] DRM_SET_CLIENT_NAME ioctl

2024-10-08 Thread Deucher, Alexander
[Public] > -Original Message- > From: Koenig, Christian > Sent: Tuesday, October 8, 2024 4:27 AM > To: Deucher, Alexander > Cc: robdcl...@gmail.com; amd-...@lists.freedesktop.org; Pelloux-Prayer, > Pierre- > Eric ; dri-devel@lists.freedesktop.org; > dmitry.osipe...@collabora.com; jani.n

Re: [PATCH v5 0/7] drm/mgag200: Implement VBLANK support

2024-10-08 Thread Ville Syrjälä
On Mon, Oct 07, 2024 at 03:37:40PM +0200, Thomas Zimmermann wrote: > Hi > > Am 04.10.24 um 12:01 schrieb Ville Syrjälä: > > On Fri, Oct 04, 2024 at 11:17:02AM +0200, Thomas Zimmermann wrote: > >> Hi > >> > >> Am 02.10.24 um 18:15 schrieb Luck, Tony: > Thanks for the bug report. Can you provid

[PATCH 1/5] perf: Add dummy pmu module

2024-10-08 Thread Lucas De Marchi
Simple dummy module that mimics what can be done with drivers to bind/unbind them from the bus, which should trigger resource release. This is mostly based on how i915 and (pending changes for) xe drivers are interacting with perf pmu. A few differences due to not having backing hardware or for si

[PATCH 5/5] perf/dummy_pmu: Track and disable active events

2024-10-08 Thread Lucas De Marchi
When unregistering the PMU, disable the currently active events. This allows userspace to see the change and possibly reacting on it, like reopening the fd. With perf-stat, "" starts to be printed: $ stat -e dummy_pmu_0/test-event-1/ -I1000 1.001227905 12 dummy

[PATCH 4/5] perf/dummy_pmu: Tie pmu to device lifecycle

2024-10-08 Thread Lucas De Marchi
Allow to unregister the PMU from perf with active events. When driver is being accessed perf keeps a reference that when released triggers the device cleanup. Signed-off-by: Lucas De Marchi --- kernel/events/dummy_pmu.c | 56 --- 1 file changed, 41 insertions(

[PATCH 3/5] perf: Add pmu get/put

2024-10-08 Thread Lucas De Marchi
If a pmu is unregistered while there's an active event, perf will still access the pmu via event->pmu, even after the event is destroyed. This makes it difficult for drivers like i915 that can be unbound from the HW. BUG: KASAN: use-after-free in exclusive_event_destroy+0xd8/0xf0 R

[PATCH 2/5] perf: Move free outside of the mutex

2024-10-08 Thread Lucas De Marchi
It's not needed to hold the mutex to free the percpu variables stored in pmu. Move them outside of the mutex protection in preparation for possibly allowing them to live longer, according to the lifecycle of the object owning/containing the pmu. Signed-off-by: Lucas De Marchi --- kernel/events/c

[PATCH 0/5] perf: Fix pmu for drivers with bind/unbind

2024-10-08 Thread Lucas De Marchi
v2 of my attempt at fixing how i915 interacts with perf events. v1 - https://lore.kernel.org/all/20240722210648.80892-1-lucas.demar...@intel.com/ >From other people: 1) https://lore.kernel.org/lkml/20240115170120.662220-1-tvrtko.ursu...@linux.intel.com/ 2) https://lore.kernel.org/all/202402131

Re: [PATCH 00/51] treewide: Switch to __pm_runtime_put_autosuspend()

2024-10-08 Thread Rafael J. Wysocki
On Tue, Oct 8, 2024 at 12:35 AM Ulf Hansson wrote: > > On Tue, 8 Oct 2024 at 00:25, Laurent Pinchart > wrote: > > > > Hi Ulf, > > > > On Tue, Oct 08, 2024 at 12:08:24AM +0200, Ulf Hansson wrote: > > > On Mon, 7 Oct 2024 at 20:49, Laurent Pinchart wrote: > > > > On Fri, Oct 04, 2024 at 04:38:36PM

Re: [PATCH v8 5/5] drm/amd/display: Fetch the EDID from _DDC if available for eDP

2024-10-08 Thread Mario Limonciello
On 10/8/2024 11:05, Mark Pearson wrote: For the series, we tested at Lenovo and it fixed a couple of different issues we had seen and reported on different HW models. - issue with setting 1600 x 1200 on Z16 G2 - issue with frequency setting being incorrect on T14 G4 AMD with OLED panels I d

Re: [PATCH v8 5/5] drm/amd/display: Fetch the EDID from _DDC if available for eDP

2024-10-08 Thread Mark Pearson
On Fri, Sep 27, 2024, at 7:06 PM, Mario Limonciello wrote: > From: Mario Limonciello > > Some manufacturers have intentionally put an EDID that differs from > the EDID on the internal panel on laptops. > > Attempt to fetch this EDID if it exists and prefer it over the EDID > that is provided by th

[PATCH 3/3] drm/vc4: Correct generation check in vc4_hvs_lut_load

2024-10-08 Thread Dave Stevenson
Commit 24c5ed3ddf27 ("drm/vc4: Introduce generation number enum") incorrectly swapped a check of hvs->vc4->is_vc5 to hvs->vc4->gen == VC4_GEN_4 in vc4_hvs_lut_load, hence breaking loading the gamma look up table on Pi0-3. Correct that conditional. Fixes: 24c5ed3ddf27 ("drm/vc4: Introduce generati

[PATCH 0/3] drm/vc4: 3 minor fixes from mismatched drm_dev_[enter|exit] calls

2024-10-08 Thread Dave Stevenson
file changed, 5 insertions(+), 3 deletions(-) --- base-commit: 2c34a5464007c45142af009d13c668b0630ef9c0 change-id: 20241008-drm-vc4-fixes-4aceb259455c Best regards, -- Dave Stevenson

[PATCH 1/3] drm/vc4: Match drm_dev_enter and exit calls in vc4_hvs_lut_load

2024-10-08 Thread Dave Stevenson
Commit 52efe364d196 ("drm/vc4: hvs: Don't write gamma luts on 2711") added a return path to vc4_hvs_lut_load that had called drm_dev_enter, but not drm_dev_exit. Ensure we call drm_dev_exit. Fixes: 52efe364d196 ("drm/vc4: hvs: Don't write gamma luts on 2711") Reported-by: Marek Szyprowski Closes

[PATCH 2/3] drm/vc4: Match drm_dev_enter and exit calls in vc4_hvs_atomic_flush

2024-10-08 Thread Dave Stevenson
Commit 92c17d16476c ("drm/vc4: hvs: Ignore atomic_flush if we're disabled") added a path which returned early without having called drm_dev_exit. Ensure all paths call drm_dev_exit. Fixes: 92c17d16476c ("drm/vc4: hvs: Ignore atomic_flush if we're disabled") Signed-off-by: Dave Stevenson --- dri

Re: [PATCH V4 2/2] drm/vc4: v3d: add PM suspend/resume support

2024-10-08 Thread Stefan Wahren
Hi Maíra, Am 08.10.24 um 15:49 schrieb Maíra Canal: Hi Stefan, On 10/3/24 09:41, Stefan Wahren wrote: Add suspend/resume support for the VC4 V3D component in order to handle suspend to idle properly. Signed-off-by: Stefan Wahren ---   drivers/gpu/drm/vc4/vc4_v3d.c | 7 +++   1 file change

Re: [PATCH v2 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO

2024-10-08 Thread Lee Jones
On Mon, 07 Oct 2024, Werner Sembach wrote: > > Am 07.10.24 um 14:58 schrieb Lee Jones: > > On Fri, 04 Oct 2024, Werner Sembach wrote: > > > > > Am 03.10.24 um 09:59 schrieb Lee Jones: > > > > On Wed, 02 Oct 2024, Werner Sembach wrote: > > > > > > > > > Hi, > > > > > > > > > > Am 02.10.24 um 14

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-08 Thread Benjamin Tissoires
On Oct 08 2024, Werner Sembach wrote: > > Am 08.10.24 um 14:18 schrieb Benjamin Tissoires: > > On Oct 08 2024, Werner Sembach wrote: > > > Am 08.10.24 um 11:53 schrieb Benjamin Tissoires: > > > > On Oct 07 2024, Werner Sembach wrote: > > > > > Hi, > > > > > > > > > > Am 02.10.24 um 10:31 schrieb

Re: [PATCH v6 03/44] drm/vkms: Add kunit tests for VKMS LUT handling

2024-10-08 Thread Jeff Johnson
On 10/3/24 13:00, Harry Wentland wrote: > Debugging LUT math is much easier when we can unit test ... > diff --git a/drivers/gpu/drm/vkms/tests/vkms_color_test.c > b/drivers/gpu/drm/vkms/tests/vkms_color_test.c > new file mode 100644 > index ..efe139978860 > --- /dev/null > +++ b/drive

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-08 Thread Raag Jadav
On Thu, Oct 03, 2024 at 03:23:22PM +0300, Raag Jadav wrote: > On Tue, Oct 01, 2024 at 02:20:29PM +0200, Michal Wajdeczko wrote: > > On 30.09.2024 09:38, Raag Jadav wrote: > > > > > > +/** > > > + * enum drm_wedge_recovery - Recovery method for wedged device in order > > > of > > > + * severity.

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-08 Thread Werner Sembach
Am 08.10.24 um 14:18 schrieb Benjamin Tissoires: On Oct 08 2024, Werner Sembach wrote: Am 08.10.24 um 11:53 schrieb Benjamin Tissoires: On Oct 07 2024, Werner Sembach wrote: Hi, Am 02.10.24 um 10:31 schrieb Benjamin Tissoires: On Oct 01 2024, Werner Sembach wrote: Hi Benjamin, Am 01.10.2

[PATCH v3 0/4] arm64: dts: imx8mm-kontron: Add HDMI and LVDS display support

2024-10-08 Thread Frieder Schrempf
This add support for the display bridges (DSI->LVDS and DSI->HDMI) on the BL i.MX8MM and the 7" LVDS panel in a separate overlay. Only one of the interfaces (HDMI or LVDS) is supported at the same time. Enabling the LVDS overlay will disable the HDMI interface. * Patch 1 and 2: Add the necessary

[PATCH v3 2/4] dt-bindings: display: panel-lvds: Add compatible for Jenson BL-JT60050-01A

2024-10-08 Thread Frieder Schrempf
From: Frieder Schrempf The Jenson BL-JT60050-01A is a 7" 1024x600 LVDS display. Signed-off-by: Frieder Schrempf Acked-by: Conor Dooley --- Changes for v3: * none Changes for v2: * Add tag from Conor (thanks!) --- Documentation/devicetree/bindings/display/panel/panel-lvds.yaml | 2 ++ 1 file

Re: [PATCH v2 0/4] arm64: dts: imx8mm-kontron: Add HDMI and LVDS display support

2024-10-08 Thread Frieder Schrempf
On 08.10.24 11:04 AM, Shawn Guo wrote: > On Tue, Oct 08, 2024 at 09:21:05AM +0200, Frieder Schrempf wrote: >> On 28.08.24 9:46 AM, Frieder Schrempf wrote: >>> From: Frieder Schrempf >>> >>> This add support for the display bridges (DSI->LVDS and DSI->HDMI) >>> on the BL i.MX8MM and the 7" LVDS pan

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-08 Thread Marek Vasut
On 10/8/24 12:07 PM, Isaac Scott wrote: On Mon, 2024-10-07 at 20:06 +0200, Marek Vasut wrote: On 10/7/24 7:01 PM, Isaac Scott wrote: Hi Marek, Hi, On Sat, 2024-07-06 at 02:16 +0200, Marek Vasut wrote: On 6/24/24 11:19 AM, Alexander Stein wrote: Am Freitag, 31. Mai 2024, 22:27:21 CEST schr

[pull] amdgpu, amdkfd, radeon drm-fixes-6.12

2024-10-08 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.12. The following changes since commit 5b272bf7dcf969eb4f19ef994b6e60458ee6300f: Merge tag 'drm-xe-fixes-2024-10-03' of https://gitlab.freedesktop.org/drm/xe/kernel into drm-fixes (2024-10-04 11:00:39 +1000) are available in the Git repository at: https://git

  1   2   3   >