Re: [PATCH v3 13/14] drm/mediatek: Support DRM plane alpha in OVL

2024-10-04 Thread Yassine Oudjana
On 03/10/2024 8:17 am, Jason-JH Lin (林睿祥) wrote: Jason: That is a lot of information, and quite above my head! Thank you though. I should note that the log items I sent you are from the "good" kernel - 6.11 with the commit reverted. Here is a much longer set of logs: https://termbin.com/co6v

Re: [PATCH v3 13/14] drm/mediatek: Support DRM plane alpha in OVL

2024-10-04 Thread Yassine Oudjana
On 03/10/2024 8:17 am, Jason-JH Lin (林睿祥) wrote: Jason: That is a lot of information, and quite above my head! Thank you though. I should note that the log items I sent you are from the "good" kernel - 6.11 with the commit reverted. Here is a much longer set of logs: https://termbin.com/co6v

Re: [PATCH v6 15/44] drm/vkms: Add kunit tests for linear and sRGB LUTs

2024-10-04 Thread kernel test robot
Hi Harry, kernel test robot noticed the following build errors: [auto build test ERROR on drm/drm-next] [also build test ERROR on drm-exynos/exynos-drm-next drm-misc/drm-misc-next linus/master v6.12-rc1 next-20241004] [If your patch is applied to the wrong git tree, kindly drop us a note. And

Re: [PATCH v2 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools

2024-10-04 Thread Matthew Brost
On Fri, Oct 04, 2024 at 04:28:29PM +0200, Thomas Hellström wrote: > On Wed, 2024-10-02 at 14:54 +0200, Thomas Hellström wrote: > > On Wed, 2024-10-02 at 14:45 +0200, Christian König wrote: > > > Am 02.10.24 um 14:24 schrieb Thomas Hellström: > > > > The ttm_device_init funcition uses multiple bool

Re: [PATCH-next] Fix unintentional integer overflow

2024-10-04 Thread Sundararaju, Sathishkumar
On 10/4/2024 11:30 PM, Alex Deucher wrote: On Fri, Oct 4, 2024 at 5:15 AM Sundararaju, Sathishkumar wrote: All occurrences of this error fix should have been together in a single patch both in _get and _set callbacks corresponding to f0b19b84d391, please avoid separate patch for each occu

Re: [PATCH v2 10/11] drm/client: Make client support optional

2024-10-04 Thread kernel test robot
Hi Thomas, kernel test robot noticed the following build errors: [auto build test ERROR on next-20241002] [cannot apply to drm-xe/drm-xe-next drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip linus/master v6.12

Re: [PATCH V3 01/11] accel/amdxdna: Add documentation for AMD NPU accelerator driver

2024-10-04 Thread Lizhi Hou
On 10/4/24 10:06, Jeffrey Hugo wrote: On 9/11/2024 12:05 PM, Lizhi Hou wrote: AMD NPU (Neural Processing Unit) is a multi-user AI inference accelerator integrated into AMD client APU. NPU enables efficient execution of Machine Learning applications like CNN, LLM, etc. NPU is based on AMD XDN

Re: [PATCH 1/8] drm/client: Constify modes

2024-10-04 Thread kernel test robot
Hi Ville, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on next-20241004] [cannot apply to drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm/drm-next drm-exynos/exynos-drm-next linus/master v6.12

Re: [PATCH 1/8] drm/client: Constify modes

2024-10-04 Thread kernel test robot
Hi Ville, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on next-20241004] [cannot apply to drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm/drm-next drm-exynos/exynos-drm-next linus/master v6.12-rc1] [If

[PATCH] drm/amdgpu: prevent BO_HANDLES error from being overwritten

2024-10-04 Thread Mohammed Anees
Before this patch, if multiple BO_HANDLES chunks were submitted, the error -EINVAL would be correctly set but could be overwritten by the return value from amdgpu_cs_p1_bo_handles(). This patch ensures that once an error condition is detected, the function returns immediately, avoiding the overwrit

[PATCH] drm/amd/display: Remove unused regamma functions

2024-10-04 Thread linux
From: "Dr. David Alan Gilbert" calculate_user_regamma_coeff() and calculate_user_regamma_ramp() were added in 2018 in commit 55a01d4023ce ("drm/amd/display: Add user_regamma to color module") but never used. Remove them and their helpers. Signed-off-by: Dr. David Alan Gilbert --- .../amd/dis

Re: [PATCH v3 0/4] drm/log: Introduce a new boot logger to draw the kmsg on the screen

2024-10-04 Thread Caleb Connolly
Hi Jocelyn, On 10/09/2024 08:56, Jocelyn Falempe wrote: drm_log is a simple logger that uses the drm_client API to print the kmsg boot log on the screen. This is not a full replacement to fbcon, as it will only print the kmsg. It will never handle user input, or a terminal because this is bette

Re: [PATCH RFT 2/2] drm/msm/adreno: Setup SMMU aparture for per-process page table

2024-10-04 Thread Jessica Zhang
On 10/2/2024 8:01 PM, Bjorn Andersson wrote: Support for per-process page tables requires the SMMU aparture to be setup such that the GPU can make updates with the SMMU. On some targets this is done statically in firmware, on others it's expected to be requested in runtime by the driver, throu

Re: [PATCH RFT 1/2] firmware: qcom: scm: Introduce CP_SMMU_APERTURE_ID

2024-10-04 Thread Jessica Zhang
On 10/2/2024 8:01 PM, Bjorn Andersson wrote: The QCOM_SCM_SVC_MP service provides QCOM_SCM_MP_CP_SMMU_APERTURE_ID, which is used to trigger the mapping of register banks into the SMMU context for per-processes page tables to function (in case this isn't statically setup by firmware). This is

Re: [PATCH] drm: panel: jd9365da-h3: Remove unused num_init_cmds structure member

2024-10-04 Thread Jessica Zhang
On 9/30/2024 10:05 AM, Hugo Villeneuve wrote: From: Hugo Villeneuve Now that the driver has been converted to use wrapped MIPI DCS functions, the num_init_cmds structure member is no longer needed, so remove it. Fixes: 35583e129995 ("drm/panel: panel-jadard-jd9365da-h3: use wrapped MIPI DCS

[PATCH] vmwgfx: allow building with CONFIG_HAS_IOPORT disabled

2024-10-04 Thread Arnd Bergmann
From: Arnd Bergmann The older version of the vmwgfx driver requires port I/O in order to work: In file included from arch/arm64/include/asm/io.h:298, from drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:28: drivers/gpu/drm/vmwgfx/vmwgfx_drv.h: In function 'vmw_read': include/asm-generic/io.

[PATCH] accel/qaic: Add AIC080 support

2024-10-04 Thread Jeffrey Hugo
Add basic support for the new AIC080 product. The PCIe Device ID is 0xa080. AIC080 is a lower cost, lower performance SKU variant of AIC100. >From the qaic perspective, it is the same as AIC100. Reviewed-by: Troy Hanson Signed-off-by: Jeffrey Hugo --- Documentation/accel/qaic/aic080.rst | 14 ++

[PATCH 3/3] drm/etnaviv: Print an error message if inserting IOVA range fails

2024-10-04 Thread Sui Jingfeng
Print an error message to help debug when such an issue happen, since it's not so obvious. Signed-off-by: Sui Jingfeng --- v0 -> v1: Use dev_err_ratelimited() to prevent spamming the logs v0 is at https://lore.kernel.org/dri-devel/20240930221706.399139-1-sui.jingf...@linux.dev/ --- drivers/gpu

[PATCH 0/3] Fix GPU virtual address collosion when CPU page size != GPU page size

2024-10-04 Thread Sui Jingfeng
Etnaviv assumes that GPU page size is 4KiB, however, when using softpin capable GPUs on a different CPU page size configuration. Userspace still doing the allocation with 4KiB page as unit. This results in userspace allocated GPU virtual address ranges collision and therefore unable to be inserted

[PATCH 2/3] drm/etnaviv: Map and unmap the GPU VA range with respect to its user size

2024-10-04 Thread Sui Jingfeng
Since the GPU VA space is compact in terms of 4KiB unit, map and/or unmap the area that doesn't belong to a context breaks the philosophy of PPAS. That results in severe errors: GPU hang and MMU fault (page not present) and such. Shrink the usuable size of etnaviv GEM buffer object to its user siz

[PATCH 1/3] drm/etnaviv: Track GPU VA size separately

2024-10-04 Thread Sui Jingfeng
Etnaviv assumes that GPU page size is 4KiB, yet on some systems, the CPU page size is 16KiB. The size of etnaviv buffer objects will be aligned to CPU page size on kernel side, however, userspace still assumes the page size is 4KiB and doing allocation with 4KiB page as unit. This results in usersp

[PATCH] accel/qaic: Fix the for loop used to walk SG table

2024-10-04 Thread Jeffrey Hugo
From: Pranjal Ramajor Asha Kanojiya Only for_each_sgtable_dma_sg() should be used to walk through a SG table to grab correct bus address and length pair after calling DMA MAP API on a SG table as DMA MAP APIs updates the SG table and for_each_sgtable_sg() walks through the original SG table. Fix

Re: [PATCH] drm/atmel_hlcdc: Fix uninitialized variable

2024-10-04 Thread Shuah Khan
On 10/4/24 09:08, Advait Dhamorikar wrote: atmel_hlcdc_plane_update_buffers: may use an uninitialized sr variable when the if condition remains unsatisfied As mentioned in my response to another one of your patches, include how you found the problem in the change log. Signed-off-by: Advait D

Re: [git pull] drm fixes for 6.12-rc2

2024-10-04 Thread pr-tracker-bot
The pull request you sent on Fri, 4 Oct 2024 14:06:23 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-10-04 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/fe6fceceaecf4c7488832be18a37ddf9213782bc Thank you! -- Deet-doot-dot, I am a bot. ht

Re: [PATCH V3 11/11] accel/amdxdna: Add firmware debug buffer support

2024-10-04 Thread Jeffrey Hugo
On 9/11/2024 12:06 PM, Lizhi Hou wrote: User application may allocate a debug buffer and attach it to an NPU context through the driver. Then the NPU firmware prints its debug information to this buffer for debugging. I feel like I must be missing something. It looks like this patch accepts a

[PATCH AUTOSEL 5.10 25/26] drm/amd/display: Check null pointer before dereferencing se

2024-10-04 Thread Sasha Levin
From: Alex Hung [ Upstream commit ff599ef6970ee000fa5bc38d02fa5ff5f3fc7575 ] [WHAT & HOW] se is null checked previously in the same function, indicating it might be null; therefore, it must be checked when used again. This fixes 1 FORWARD_NULL issue reported by Coverity. Acked-by: Alex Hung R

Re: [PATCH v2 03/11] drm/fbdev: Select fbdev I/O helpers from modules that require them

2024-10-04 Thread kernel test robot
Hi Thomas, kernel test robot noticed the following build errors: [auto build test ERROR on next-20241002] [also build test ERROR on v6.12-rc1] [cannot apply to drm-xe/drm-xe-next drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-misc/drm-misc-nex

[PATCH AUTOSEL 5.15 30/31] drm/amd/display: Check null pointer before dereferencing se

2024-10-04 Thread Sasha Levin
From: Alex Hung [ Upstream commit ff599ef6970ee000fa5bc38d02fa5ff5f3fc7575 ] [WHAT & HOW] se is null checked previously in the same function, indicating it might be null; therefore, it must be checked when used again. This fixes 1 FORWARD_NULL issue reported by Coverity. Acked-by: Alex Hung R

[PATCH AUTOSEL 6.1 41/42] fbcon: Fix a NULL pointer dereference issue in fbcon_putcs

2024-10-04 Thread Sasha Levin
From: Qianqiang Liu [ Upstream commit 5b97eebcce1b4f3f07a71f635d6aa3af96c236e7 ] syzbot has found a NULL pointer dereference bug in fbcon. Here is the simplified C reproducer: struct param { uint8_t type; struct tiocl_selection ts; }; int main() { struct fb_con2fbmap co

[PATCH AUTOSEL 6.1 40/42] drm/amd/display: Check null pointer before dereferencing se

2024-10-04 Thread Sasha Levin
From: Alex Hung [ Upstream commit ff599ef6970ee000fa5bc38d02fa5ff5f3fc7575 ] [WHAT & HOW] se is null checked previously in the same function, indicating it might be null; therefore, it must be checked when used again. This fixes 1 FORWARD_NULL issue reported by Coverity. Acked-by: Alex Hung R

[PATCH AUTOSEL 6.6 56/58] fbcon: Fix a NULL pointer dereference issue in fbcon_putcs

2024-10-04 Thread Sasha Levin
From: Qianqiang Liu [ Upstream commit 5b97eebcce1b4f3f07a71f635d6aa3af96c236e7 ] syzbot has found a NULL pointer dereference bug in fbcon. Here is the simplified C reproducer: struct param { uint8_t type; struct tiocl_selection ts; }; int main() { struct fb_con2fbmap co

[PATCH AUTOSEL 6.6 55/58] drm/amd/display: Check null pointer before dereferencing se

2024-10-04 Thread Sasha Levin
From: Alex Hung [ Upstream commit ff599ef6970ee000fa5bc38d02fa5ff5f3fc7575 ] [WHAT & HOW] se is null checked previously in the same function, indicating it might be null; therefore, it must be checked when used again. This fixes 1 FORWARD_NULL issue reported by Coverity. Acked-by: Alex Hung R

[PATCH AUTOSEL 6.10 68/70] fbcon: Fix a NULL pointer dereference issue in fbcon_putcs

2024-10-04 Thread Sasha Levin
From: Qianqiang Liu [ Upstream commit 5b97eebcce1b4f3f07a71f635d6aa3af96c236e7 ] syzbot has found a NULL pointer dereference bug in fbcon. Here is the simplified C reproducer: struct param { uint8_t type; struct tiocl_selection ts; }; int main() { struct fb_con2fbmap co

[PATCH AUTOSEL 6.10 67/70] drm/amd/display: Check null pointer before dereferencing se

2024-10-04 Thread Sasha Levin
From: Alex Hung [ Upstream commit ff599ef6970ee000fa5bc38d02fa5ff5f3fc7575 ] [WHAT & HOW] se is null checked previously in the same function, indicating it might be null; therefore, it must be checked when used again. This fixes 1 FORWARD_NULL issue reported by Coverity. Acked-by: Alex Hung R

[PATCH AUTOSEL 6.10 66/70] drm/amdgpu: nuke the VM PD/PT shadow handling

2024-10-04 Thread Sasha Levin
From: Christian König [ Upstream commit 7181faaa4703705939580abffaf9cb5d6b50dbb7 ] This was only used as workaround for recovering the page tables after VRAM was lost and is no longer necessary after the function amdgpu_vm_bo_reset_state_machine() started to do the same. Compute never used shad

[PATCH AUTOSEL 6.10 65/70] drm/xe/oa: Fix overflow in oa batch buffer

2024-10-04 Thread Sasha Levin
From: José Roberto de Souza [ Upstream commit 6c10ba06bb1b48acce6d4d9c1e33beb9954f1788 ] By default xe_bb_create_job() appends a MI_BATCH_BUFFER_END to batch buffer, this is not a problem if batch buffer is only used once but oa reuses the batch buffer for the same metric and at each call it app

[PATCH v2] drm/radeon: add late_register for connector - Please test

2024-10-04 Thread Christian Zigotzky
Hi All, I compiled a new RC1 of kernel 6.12 with this patch today. Please test it. Downloads: - https://github.com/chzigotzky/kernels/releases/tag/v6.12.0-rc1-2 - https://www.xenosoft.de/linux-image-6.12-rc1-2-X1000_X5000.tar.gz Thanks, Christian On 04 October 2024 at 4:00pm, Alex Deucher wro

Re: [PATCH V3 10/11] accel/amdxdna: Add query functions

2024-10-04 Thread Jeffrey Hugo
On 9/11/2024 12:06 PM, Lizhi Hou wrote: diff --git a/drivers/accel/amdxdna/aie2_error.c b/drivers/accel/amdxdna/aie2_error.c index 3b8223420f5b..9dc44ecf2adb 100644 --- a/drivers/accel/amdxdna/aie2_error.c +++ b/drivers/accel/amdxdna/aie2_error.c @@ -3,6 +3,7 @@ * Copyright (C) 2023-2024, Adv

[PATCH AUTOSEL 6.11 74/76] fbcon: Fix a NULL pointer dereference issue in fbcon_putcs

2024-10-04 Thread Sasha Levin
From: Qianqiang Liu [ Upstream commit 5b97eebcce1b4f3f07a71f635d6aa3af96c236e7 ] syzbot has found a NULL pointer dereference bug in fbcon. Here is the simplified C reproducer: struct param { uint8_t type; struct tiocl_selection ts; }; int main() { struct fb_con2fbmap co

[PATCH AUTOSEL 6.11 73/76] drm/amd/display: Check null pointer before dereferencing se

2024-10-04 Thread Sasha Levin
From: Alex Hung [ Upstream commit ff599ef6970ee000fa5bc38d02fa5ff5f3fc7575 ] [WHAT & HOW] se is null checked previously in the same function, indicating it might be null; therefore, it must be checked when used again. This fixes 1 FORWARD_NULL issue reported by Coverity. Acked-by: Alex Hung R

[PATCH AUTOSEL 6.11 72/76] drm/amdgpu: nuke the VM PD/PT shadow handling

2024-10-04 Thread Sasha Levin
From: Christian König [ Upstream commit 7181faaa4703705939580abffaf9cb5d6b50dbb7 ] This was only used as workaround for recovering the page tables after VRAM was lost and is no longer necessary after the function amdgpu_vm_bo_reset_state_machine() started to do the same. Compute never used shad

Re: [PATCH V3 09/11] accel/amdxdna: Add error handling

2024-10-04 Thread Jeffrey Hugo
On 9/11/2024 12:06 PM, Lizhi Hou wrote: +/* + * Below enum, struct and lookup tables are porting from XAIE util header file. + * + * Below data is defined by AIE device and it is used for decode error message + * from the device. + */ + +enum aie_module_type { + AIE_MEM_MOD = 0, + AIE

[PATCH AUTOSEL 6.11 71/76] drm/xe/oa: Fix overflow in oa batch buffer

2024-10-04 Thread Sasha Levin
From: José Roberto de Souza [ Upstream commit 6c10ba06bb1b48acce6d4d9c1e33beb9954f1788 ] By default xe_bb_create_job() appends a MI_BATCH_BUFFER_END to batch buffer, this is not a problem if batch buffer is only used once but oa reuses the batch buffer for the same metric and at each call it app

Re: [PATCH V3 08/11] accel/amdxdna: Add suspend and resume

2024-10-04 Thread Jeffrey Hugo
On 9/11/2024 12:06 PM, Lizhi Hou wrote: +static int amdxdna_rpmops_suspend(struct device *dev) +{ + struct amdxdna_dev *xdna = pci_get_drvdata(to_pci_dev(dev)); + int ret; + + mutex_lock(&xdna->dev_lock); + WARN_ON(!list_empty(&xdna->client_list)); This feels weird. Can

Re: [PATCH V3 07/11] accel/amdxdna: Add command execution

2024-10-04 Thread Jeffrey Hugo
On 9/11/2024 12:06 PM, Lizhi Hou wrote: +enum amdxdna_cmd_type { + AMDXDNA_CMD_SUBMIT_EXEC_BUF = 0, + AMDXDNA_CMD_SUBMIT_DEPENDENCY, + AMDXDNA_CMD_SUBMIT_SIGNAL, +}; + +/** + * struct amdxdna_drm_exec_cmd - Execute command. + * @ext: MBZ. + * @ext_flags: MBZ. I see a check for

Re: [PATCH-next] Fix unintentional integer overflow

2024-10-04 Thread Alex Deucher
On Fri, Oct 4, 2024 at 5:15 AM Sundararaju, Sathishkumar wrote: > > > All occurrences of this error fix should have been together in a single patch > both in _get and _set callbacks corresponding to f0b19b84d391, please avoid > separate patch for each occurrence. > > Sorry Alex, I missed to note

Re: [PATCH V3 06/11] accel/amdxdna: Add GEM buffer object management

2024-10-04 Thread Jeffrey Hugo
On 9/11/2024 12:05 PM, Lizhi Hou wrote: +/** + * struct amdxdna_drm_create_bo - Create a buffer object. + * @flags: Buffer flags. MBZ. + * @type: Buffer type. + * @pad1: MBZ. + * @vaddr: User VA of buffer if applied. MBZ. + * @size: Size in bytes. + * @handle: Returned DRM buffer object handle. +

Re: [PATCH] drm/i915/display: Remove kstrdup_const() and kfree_const() usage

2024-10-04 Thread Christophe JAILLET
Le 04/10/2024 à 11:35, Jani Nikula a écrit : On Thu, 03 Oct 2024, Christophe JAILLET wrote: kstrdup_const() and kfree_const() can be confusing in code built as a module. In such a case, it does not do what one could expect from the name of the functions. The code is not wrong by itself, but in

Re: [PATCH V3 05/11] accel/amdxdna: Add hardware context

2024-10-04 Thread Jeffrey Hugo
On 9/11/2024 12:05 PM, Lizhi Hou wrote: diff --git a/drivers/accel/amdxdna/aie2_ctx.c b/drivers/accel/amdxdna/aie2_ctx.c new file mode 100644 index ..52a71661f887 --- /dev/null +++ b/drivers/accel/amdxdna/aie2_ctx.c @@ -0,0 +1,186 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyri

Re: [PATCH V3 04/11] accel/amdxdna: Add hardware resource solver

2024-10-04 Thread Jeffrey Hugo
On 9/11/2024 12:05 PM, Lizhi Hou wrote: The AI Engine consists of 2D array of tiles arranged as columns. Provides the basic column allocation and release functions for the tile columns. Co-developed-by: Min Ma Signed-off-by: Min Ma Signed-off-by: Lizhi Hou Reviewed-by: Jeffrey Hugo

Re: [PATCH V3 03/11] accel/amdxdna: Support hardware mailbox

2024-10-04 Thread Jeffrey Hugo
On 9/11/2024 12:05 PM, Lizhi Hou wrote: +struct create_ctx_req { + __u32 aie_type; + __u8start_col; + __u8num_col; + __u16 reserved; + __u8num_cq_pairs_requested; + __u8reserved1; + __u16 pasid; + __u32 pad[2]; + __u32

Re: [PATCH-next] Fix unintentional integer overflow

2024-10-04 Thread Shuah Khan
On 10/4/24 03:15, Sundararaju, Sathishkumar wrote: All occurrences of this error fix should have been together in a single patch both in _get and _set callbacks corresponding to f0b19b84d391, please avoid separate patch for each occurrence. Sorry Alex, I missed to note this yesterday. Regar

Re: [PATCH V3 02/11] accel/amdxdna: Add a new driver for AMD AI Engine

2024-10-04 Thread Jeffrey Hugo
On 9/11/2024 12:05 PM, Lizhi Hou wrote: diff --git a/drivers/accel/amdxdna/aie2_pci.c b/drivers/accel/amdxdna/aie2_pci.c new file mode 100644 index ..e21b32557fc2 --- /dev/null +++ b/drivers/accel/amdxdna/aie2_pci.c @@ -0,0 +1,183 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyri

Re: [PATCH V3 01/11] accel/amdxdna: Add documentation for AMD NPU accelerator driver

2024-10-04 Thread Jeffrey Hugo
On 9/11/2024 12:05 PM, Lizhi Hou wrote: AMD NPU (Neural Processing Unit) is a multi-user AI inference accelerator integrated into AMD client APU. NPU enables efficient execution of Machine Learning applications like CNN, LLM, etc. NPU is based on AMD XDNA Architecture. NPU is managed by amdxdna d

RE: [PATCH v5 0/7] drm/mgag200: Implement VBLANK support

2024-10-04 Thread Luck, Tony
Thomas, v6.12-rc1 plus your off-by-one patch is still broken. Console log from when things went off the rails: [ 32.126676] Console: switching to colour dummy device 80x25 [ 32.134887] mgag200 :08:00.0: vgaarb: deactivate vga console [ OK ] Started Show Plymouth Boot Screen. [ OK ] S

Re: [PATCH 2/2] accel/ivpu: Update power island delays

2024-10-04 Thread Jeffrey Hugo
On 10/4/2024 10:25 AM, Maciej Falkowski wrote: From: "Wachowski, Karol" Apply Hardware Architecture Specification compatible delays for main island power delivery for 50xx and above. Signed-off-by: Wachowski, Karol Signed-off-by: Maciej Falkowski Reviewed-by: Jeffrey Hugo

Re: [PATCH 1/2] accel/ivpu: Add initial Panther Lake support

2024-10-04 Thread Jeffrey Hugo
On 10/4/2024 10:25 AM, Maciej Falkowski wrote: Add support for the 5th generation of Intel NPU that is going to be present in PTL_P (Panther Lake) CPUs. NPU5 code reuses almost all of previous driver code. Signed-off-by: Maciej Falkowski Reviewed-by: Jeffrey Hugo

[PATCH] accel/qaic: Add ipc_router channel

2024-10-04 Thread Jeffrey Hugo
The ipc_router channel allows AF_QIPCRTR clients and services to communicate with the AIC100 device. The ipc_router MHI transport layer expects the channel to be named exactly "IPCR". Reviewed-by: Carl Vanderlip Signed-off-by: Jeffrey Hugo --- Documentation/accel/qaic/aic100.rst | 2 ++ driver

Re: [PATCH 2/2] drm/vc4: Stop the active perfmon before being destroyed

2024-10-04 Thread Juan A.
Worth to mention we got this issue happened also for v3d (a fix was already submitted). Reviewed-by: Juan A. Suarez On Fri, 2024-10-04 at 09:36 -0300, Maíra Canal wrote: > Upon closing the file descriptor, the active performance monitor is > not > stopped. Although all perfmons are destroyed i

Re: [PATCH 1/2] drm/vc4: Use `vc4_perfmon_find()`

2024-10-04 Thread Juan A.
Reviewed-by: Juan A. Suarez On Fri, 2024-10-04 at 09:35 -0300, Maíra Canal wrote: > Similar to commit f2a4bcb25328 ("drm/v3d: Use v3d_perfmon_find()"), > replace the open-coded `vc4_perfmon_find()` with the real thing. > > Cc: Christian Gmeiner > Signed-off-by: Maíra Canal > --- >  drivers/gpu

Re: [PATCH] drm/v3d: Stop the active perfmon before being destroyed

2024-10-04 Thread Juan A.
Good catch! Reviewed-by: Juan A. Suarez

Re: [PATCH v8 0/5] drm/amd/display: Use drm_edid for more code

2024-10-04 Thread Alex Hung
No regressed found on this patchset series. Reviewed-by: Alex Hung On 9/27/24 17:05, Mario Limonciello wrote: From: Mario Limonciello This is the successor of Melissa's v5 series that was posted [1] as well as my series that was posted [2]. Melissa's patches are mostly unmodified from v5, b

[PATCH v2] fbdev: sstfb: Make CONFIG_FB_DEVICE optional

2024-10-04 Thread Gonzalo Silvalde Blanco
The sstfb driver currently depends on CONFIG_FB_DEVICE to create sysfs entries and access info->dev. This patch wraps the relevant code blocks with #ifdef CONFIG_FB_DEVICE, allowing the driver to be built and used even if CONFIG_FB_DEVICE is not selected. The sysfs setting only controls the VGA pa

Re: [PATCH v2 02/10] drm/tilcdc: Allow build with COMPILE_TEST=y

2024-10-04 Thread kernel test robot
se: next-20241003 patch link: https://lore.kernel.org/r/20241003111851.10453-3-ville.syrjala%40linux.intel.com patch subject: [PATCH v2 02/10] drm/tilcdc: Allow build with COMPILE_TEST=y config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20241004/202410042345.cqdnf4wd-...@intel.

[PATCH] drm/atmel_hlcdc: Fix uninitialized variable

2024-10-04 Thread Advait Dhamorikar
atmel_hlcdc_plane_update_buffers: may use an uninitialized sr variable when the if condition remains unsatisfied Signed-off-by: Advait Dhamorikar --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/at

Re: [RFC PATCH v4 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-04 Thread Ilpo Järvinen
On Fri, 4 Oct 2024, Werner Sembach wrote: > Am 03.10.24 um 12:54 schrieb Ilpo Järvinen: > > On Wed, 2 Oct 2024, Werner Sembach wrote: > > > Am 02.10.24 um 11:52 schrieb Ilpo Järvinen: > > > > On Tue, 1 Oct 2024, Werner Sembach wrote: > > > > > > > > > The TUXEDO Sirius 16 Gen1 and TUXEDO Sirius 16

Re: [PATCH 00/51] treewide: Switch to __pm_runtime_put_autosuspend()

2024-10-04 Thread Ulf Hansson
t; @@ > expression E1; > > @@ > > - pm_runtime_put_autosuspend(E1) > + __pm_runtime_put_autosuspend(E1) > --8<--- > > These patches are on top of today's linux-next (i.e. next-20241004). > > Sakari Ailus (51): > accel/ivpu: Switch to __pm_ru

Re: [PATCH v2 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO

2024-10-04 Thread Werner Sembach
Am 03.10.24 um 09:59 schrieb Lee Jones: On Wed, 02 Oct 2024, Werner Sembach wrote: Hi, Am 02.10.24 um 14:52 schrieb Lee Jones: On Fri, 27 Sep 2024, Werner Sembach wrote: Hi, first revision integrating Armins feedback. Stuff I did not yet change and did not comment on previously: - Still

Re: [RFC PATCH v4 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-04 Thread Werner Sembach
Hi Ilpo, Am 03.10.24 um 12:54 schrieb Ilpo Järvinen: On Wed, 2 Oct 2024, Werner Sembach wrote: Am 02.10.24 um 11:52 schrieb Ilpo Järvinen: On Tue, 1 Oct 2024, Werner Sembach wrote: The TUXEDO Sirius 16 Gen1 and TUXEDO Sirius 16 Gen2 devices have a per-key controllable RGB keyboard backlight.

Re: [PATCH v2 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools

2024-10-04 Thread Thomas Hellström
On Wed, 2024-10-02 at 14:54 +0200, Thomas Hellström wrote: > On Wed, 2024-10-02 at 14:45 +0200, Christian König wrote: > > Am 02.10.24 um 14:24 schrieb Thomas Hellström: > > > The ttm_device_init funcition uses multiple bool arguments. That > > > means > > > readability in the caller becomes poor,

Re: [PATCH v2] drm/xe/tests: Fix the shrinker test compiler warnings.

2024-10-04 Thread Matthew Auld
On 04/10/2024 15:11, Thomas Hellström wrote: The xe_bo_shrink_kunit test has an uninitialized value and illegal integer size conversions on 32-bit. Fix. v2: - Use div64_u64 to ensure the u64 division compiles everywhere. (Matt Auld) Reported-by: Nathan Chancellor Closes: https://lore.kernel.or

Re: [PATCH v2 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools

2024-10-04 Thread Thomas Hellström
On Thu, 2024-10-03 at 00:28 -0400, Zack Rusin wrote: > On Wed, Oct 2, 2024 at 8:24 AM Thomas Hellström > wrote: > > > > The ttm_device_init funcition uses multiple bool arguments. That > > means > > readability in the caller becomes poor, and all callers need to > > change if > > yet another bool

[PATCH v2] drm/xe/tests: Fix the shrinker test compiler warnings.

2024-10-04 Thread Thomas Hellström
The xe_bo_shrink_kunit test has an uninitialized value and illegal integer size conversions on 32-bit. Fix. v2: - Use div64_u64 to ensure the u64 division compiles everywhere. (Matt Auld) Reported-by: Nathan Chancellor Closes: https://lore.kernel.org/20240913195649.GA61514@thelio-3990X/ Fixes: 5

Re: [PATCH v2 20/28] fbdev: clps711x-fb: Replace check_fb in favor of struct fb_info.lcd_dev

2024-10-04 Thread Thomas Zimmermann
Hi Am 03.10.24 um 20:33 schrieb Kees Bakker: Op 06-09-2024 om 09:52 schreef Thomas Zimmermann: Store the lcd device in struct fb_info.lcd_dev. The lcd subsystem can now detect the lcd's fbdev device from this field. This makes the implementation of check_fb in clps711x_lcd_ops obsolete. Remove

Re: [PATCH v2] drm/radeon: add late_register for connector

2024-10-04 Thread Alex Deucher
On Thu, Oct 3, 2024 at 9:18 PM Wu Hoi Pok wrote: > > The patch is to solve null dereference in 'aux.dev', which is > introduced in recent radeon rework. By having 'late_register', > the connector should be registered after 'drm_dev_register' > automatically, where in before it is the opposite. > >

Re: [PATCH v9 07/11] drm/print: Introduce drm_line_printer

2024-10-04 Thread Maarten Lankhorst
I don't think there's an immediate use for this in drm-misc, so its easier to merge through xe. :-) Acked-by: Maarten Lankhorst Den 2024-10-03 kl. 02:46, skrev john.c.harri...@intel.com: From: Michal Wajdeczko This drm printer wrapper can be used to increase the robustness of the captured ou

Re: [RFC PATCH 1/2] drm/drm_file: Add display of driver's internal memory size

2024-10-04 Thread Tvrtko Ursulin
Hi Adrian, On 03/10/2024 00:45, Adrián Larumbe wrote: Some drivers must allocate a considerable amount of memory for bookkeeping structures and GPU's MCU-kernel shared communication regions. These are often created as a result of the invocation of the driver's ioctl() interface functions, so i

[PATCH v1 3/3] drm/ci: add sm8350-hdk

2024-10-04 Thread Vignesh Raman
Add job that executes the IGT test suite for sm8350-hdk. Signed-off-by: Vignesh Raman --- drivers/gpu/drm/ci/arm64.config | 7 +- drivers/gpu/drm/ci/build.sh | 1 + drivers/gpu/drm/ci/test.yml | 16 ++ .../drm/ci/xfails/msm-sm8350-hdk-fails.

[PATCH v1 2/3] drm/ci: add dedede

2024-10-04 Thread Vignesh Raman
Add job that executes the IGT test suite for acer-cb317-1h-c3z6-dedede. dedede boards use 64 bit Intel Jasper Lake processors. Signed-off-by: Vignesh Raman --- drivers/gpu/drm/ci/test.yml | 9 drivers/gpu/drm/ci/xfails/i915-jsl-fails.txt | 51 +++ drivers

[PATCH v1 1/3] drm/ci: refactor software-driver stage jobs

2024-10-04 Thread Vignesh Raman
Move common job configuration for software-driver stage jobs to seperate job. Signed-off-by: Vignesh Raman --- drivers/gpu/drm/ci/test.yml | 59 +++-- 1 file changed, 24 insertions(+), 35 deletions(-) diff --git a/drivers/gpu/drm/ci/test.yml b/drivers/gpu/drm/ci/

[PATCH v1 0/3] drm/ci: add new devices for testing

2024-10-04 Thread Vignesh Raman
Add jobs that execute the IGT test suite for sm8350-hdk and dedede. Also refactor software-driver stage jobs. Successful pipeline link, https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1283825 Once this patch series is reviewed, will send v2 with gitlab issues link for flake tests.

[PATCH 2/2] accel/ivpu: Update power island delays

2024-10-04 Thread Maciej Falkowski
From: "Wachowski, Karol" Apply Hardware Architecture Specification compatible delays for main island power delivery for 50xx and above. Signed-off-by: Wachowski, Karol Signed-off-by: Maciej Falkowski --- drivers/accel/ivpu/ivpu_hw_40xx_reg.h | 2 ++ drivers/accel/ivpu/ivpu_hw_ip.c | 49

[PATCH 1/2] accel/ivpu: Add initial Panther Lake support

2024-10-04 Thread Maciej Falkowski
Add support for the 5th generation of Intel NPU that is going to be present in PTL_P (Panther Lake) CPUs. NPU5 code reuses almost all of previous driver code. Signed-off-by: Maciej Falkowski --- drivers/accel/ivpu/ivpu_drv.c | 1 + drivers/accel/ivpu/ivpu_drv.h | 10 +++--- drivers/accel/iv

[PATCH 0/2] accel/ivpu: Intel NPU Panther Lake support

2024-10-04 Thread Maciej Falkowski
This patchset adds initial support for 5th generation Intel NPU that is going to be present in the upcoming Panther Lake CPUs. Maciej Falkowski (1): accel/ivpu: Add initial Panther Lake support Wachowski, Karol (1): accel/ivpu: Update power island delays drivers/accel/ivpu/ivpu_drv.c

[PATCH] drm/v3d: Stop the active perfmon before being destroyed

2024-10-04 Thread Maíra Canal
When running `kmscube` with one or more performance monitors enabled via `GALLIUM_HUD`, the following kernel panic can occur: [ 55.008324] Unable to handle kernel paging request at virtual address 052004a4 [ 55.008368] Mem abort info: [ 55.008377] ESR = 0x9605 [ 55.0

[PATCH 2/2] drm/vc4: Stop the active perfmon before being destroyed

2024-10-04 Thread Maíra Canal
Upon closing the file descriptor, the active performance monitor is not stopped. Although all perfmons are destroyed in `vc4_perfmon_close_file()`, the active performance monitor's pointer (`vc4->active_perfmon`) is still retained. If we open a new file descriptor and submit a few jobs with perfor

[PATCH 1/2] drm/vc4: Use `vc4_perfmon_find()`

2024-10-04 Thread Maíra Canal
Similar to commit f2a4bcb25328 ("drm/v3d: Use v3d_perfmon_find()"), replace the open-coded `vc4_perfmon_find()` with the real thing. Cc: Christian Gmeiner Signed-off-by: Maíra Canal --- drivers/gpu/drm/vc4/vc4_perfmon.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/dr

Re: fw_devlinks preventing a panel driver from probing

2024-10-04 Thread Tomi Valkeinen
Hi Dmitry, On 27/09/2024 11:35, Dmitry Baryshkov wrote: On Fri, 27 Sept 2024 at 08:41, Tomi Valkeinen wrote: On 27/09/2024 02:26, Dmitry Baryshkov wrote: On Thu, Sep 26, 2024 at 02:52:35PM GMT, Tomi Valkeinen wrote: Hi, On 21/09/2024 23:15, Dmitry Baryshkov wrote: On Mon, Sep 16, 2024 at

Re: [PATCH v5 0/7] drm/mgag200: Implement VBLANK support

2024-10-04 Thread Thomas Zimmermann
Hi Am 04.10.24 um 13:19 schrieb Ville Syrjälä: On Fri, Oct 04, 2024 at 01:03:21PM +0200, Thomas Zimmermann wrote: Hi thanks for your help. Am 04.10.24 um 12:01 schrieb Ville Syrjälä: On Fri, Oct 04, 2024 at 11:17:02AM +0200, Thomas Zimmermann wrote: Hi Am 02.10.24 um 18:15 schrieb Luck, T

Re: [PATCH v6 15/44] drm/vkms: Add kunit tests for linear and sRGB LUTs

2024-10-04 Thread Louis Chauvet
On 03/10/24 - 16:00, Harry Wentland wrote: checkpatch: commit description - Add an appropriate one > Signed-off-by: Harry Wentland > --- > drivers/gpu/drm/vkms/tests/vkms_color_test.c | 38 +++- > drivers/gpu/drm/vkms/vkms_composer.c | 15 ++-- > drivers/gpu/drm/vkms

Re: [PATCH v6 03/44] drm/vkms: Add kunit tests for VKMS LUT handling

2024-10-04 Thread Louis Chauvet
On 03/10/24 - 16:00, Harry Wentland wrote: > Debugging LUT math is much easier when we can unit test > it. Add kunit functionality to VKMS and add tests for > - get_lut_index > - lerp_u16 > > Signed-off-by: Harry Wentland > Cc: Arthur Grillo > --- > v6: > - Eliminate need to include test as .

Re: [PATCH v6 19/44] drm/vkms: add 3x4 matrix in color pipeline

2024-10-04 Thread Louis Chauvet
On 03/10/24 - 16:01, Harry Wentland wrote: > We add two 3x4 matrices into the VKMS color pipeline. The reason > we're adding matrices is so that we can test that application > of a matrix and its inverse yields an output equal to the input > image. > > One complication with the matrix implementati

Re: [PATCH v6 20/44] drm/tests: Add a few tests around drm_fixed.h

2024-10-04 Thread Louis Chauvet
Few checkpatch warnings: - line length of 103 exceeds 100 columns - Blank lines aren't necessary before a close brace '}' - adding a line without newline at end of file With those fixed: Reviewd-by: Louis Chauvet On 03/10/24 - 16:01, Harry Wentland wrote: > While working on the CTM implementatio

Re: [PATCH v6 14/44] drm/vkms: Add enumerated 1D curve colorop

2024-10-04 Thread Louis Chauvet
On 03/10/24 - 16:00, Harry Wentland wrote: > This patch introduces a VKMS color pipeline that includes two > drm_colorops for named transfer functions. For now the only ones > supported are sRGB EOTF, sRGB Inverse EOTF, and a Linear TF. > We will expand this in the future but I don't want to do so

Re: [PATCH v6 21/44] drm/vkms: Add tests for CTM handling

2024-10-04 Thread Louis Chauvet
On 03/10/24 - 16:01, Harry Wentland wrote: > A whole slew of tests for CTM handling that greatly helped in > debugging the CTM code. The extent of tests might seem a bit > silly but they're fast and might someday help save someone > else's day when debugging this. > > Signed-off-by: Harry Wentland

Re: [PATCH v6 18/44] drm/vkms: Use s32 for internal color pipeline precision

2024-10-04 Thread Louis Chauvet
On 03/10/24 - 16:01, Harry Wentland wrote: > Certain operations require us to preserve values below 0.0 and > above 1.0 (0x0 and 0x respectively in 16 bpc unorm). One > such operation is a BT709 encoding operation followed by its > decoding operation, or the reverse. > > We'll use s32 values a

Re: [PATCH v6 41/44] drm/colorop: allow non-bypass colorops

2024-10-04 Thread Louis Chauvet
On 03/10/24 - 16:01, Harry Wentland wrote: > Not all HW will be able to do bypass on all color > operations. Introduce an 'allow_bypass' boolean for > all colorop init functions and only create the BYPASS > property when it's true. > > Signed-off-by: Harry Wentland > --- > .../amd/display/amdgpu

Re: [PATCH v2 07/10] drm/imx/dcss: Allow build with COMPILE_TEST=y

2024-10-04 Thread Laurentiu Palcu
Hi, On Thu, Oct 03, 2024 at 02:18:48PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Allow imx/dcss to be built with COMPILE_TEST=y for greater > coverage. Builds fine on x86/x86_64 at least. > > Cc: Laurentiu Palcu > Cc: Lucas Stach > Signed-off-by: Ville Syrjälä a Reviewed-by: Laur

Re: [PATCH v2 06/10] drm/imx/dcss: Fix 64bit divisions

2024-10-04 Thread Laurentiu Palcu
Hi, On Thu, Oct 03, 2024 at 02:18:47PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Use the appropriate 64bit division helpers to make the code > build on 32bit architectures. > > Cc: Laurentiu Palcu > Cc: Lucas Stach > Signed-off-by: Ville Syrjälä Reviewed-by: Laurentiu Palcu Th

Re: [PATCH-next v2] Fix unintentional integer overflow

2024-10-04 Thread Lazar, Lijo
On 10/3/2024 3:56 PM, Advait Dhamorikar wrote: > Fix shift-count-overflow in JPEG instance > multiplication. The expression's value may not be > what the programmer intended, because the expression > is evaluated using a narrower integer type. > > Fixes: f0b19b84d391 ("drm/amdgpu: add amdgpu_jp

  1   2   >