Hello Pintu,
On Tue, 1 Oct 2024 at 23:16, Pintu Kumar wrote:
>
> Symbolic permissions are not preferred, instead use the octal.
> Also, fix other warnings/errors as well for cleanup.
>
> WARNING: Block comments use * on subsequent lines
> + /* only support discovering the end of the buffer,
This is a fix patch not tested yet,
for a bug I introduce in previous rework of radeon driver.
The bug is a null dereference in 'aux.dev', which is the
'device' not registered, resulting in kernel panic. By having
'late_register', the connector should be registered after
'drm_dev_register' automati
On 02 October 2024 at 3:43pm, Hoi Pok Wu wrote:
Thanks to Christophe.
I have figured out what happened.
The connector is registered before the device,
where drm_connector_register() states that,
drm_dev_register() has to be called before it.
Assuming this is the fix, I will send the patch for t
On Wed, Oct 2, 2024 at 8:24 AM Thomas Hellström
wrote:
>
> The ttm_device_init funcition uses multiple bool arguments. That means
> readability in the caller becomes poor, and all callers need to change if
> yet another bool is added.
>
> Instead use a struct with multiple single-bit flags. This a
On 02-10-2024 18:46, Matthew Brost wrote:
Now that drm sched uses a single lockdep map for all submit_wq, drop the
GuC submit_wq pool hack.
Signed-off-by: Matthew Brost
---
drivers/gpu/drm/xe/xe_guc_submit.c | 60 +-
drivers/gpu/drm/xe/xe_guc_types.h | 7
On 02-10-2024 18:46, Matthew Brost wrote:
Avoid leaking a lockdep map on each drm sched creation and destruction
by using a single lockdep map for all drm sched allocated submit_wq.
v2:
- Use alloc_ordered_workqueue_lockdep_map (Tejun)
Cc: Luben Tuikov
Cc: Christian König
Signed-off-by:
Hi all,
After merging the drm-misc tree, today's linux-next build (htmldocs)
produced this warning:
Documentation/gpu/panthor.rst: WARNING: document isn't included in any toctree
Introduced by commit
6a797bdfde77 ("drm/panthor: add sysfs knob for enabling job profiling")
--
Cheers,
Stephen
The MediaTek DPI module is typically associated with one of the
following multimedia power domains:
- POWER_DOMAIN_DISPLAY
- POWER_DOMAIN_VDOSYS
- POWER_DOMAIN_MM
The specific power domain used varies depending on the SoC design.
These power domains are shared by multiple devices within the SoC
The ethernet-phy node in mt8395-genio-1200-evk.dts was triggering a
dtbs_check error. The error message was:
eth-phy0@1: $nodename:0: 'eth-phy0@1' does not match
'^ethernet-phy(@[a-f0-9]+)?$'
Fix this issue by replacing 'eth-phy' node to generic 'ethernet-phy'.
Fixes: f2b543a191b6
The infra-iommu node in mt8195.dtsi was triggering a CHECK_DTBS error due
to an excessively long 'interrupts' property. The error message was:
infra-iommu@10315000: interrupts: [[0, 795, 4, 0], [0, 796, 4, 0],
[0, 797, 4, 0], [0, 798, 4, 0], [0, 799, 4, 0]]
The mutex node in mt8195.dtsi was triggering a dtbs_check error:
mutex@1c101000: 'clock-names', 'reg-names' do not match any of the
regexes: 'pinctrl-[0-9]+'
This seems no need by inspecting the DT schemas and other reference boards,
so drop 'clock-names' and 'reg-names' in mt8
Added colon in kernel-doc comment to fix the warning.
./include/drm/drm_drv.h:372: warning: Incorrect use of kernel-doc format:
* @fbdev_probe
./include/drm/drm_drv.h:435: warning: Function parameter or struct member
'fbdev_probe' not described in 'drm_driver'
Signed-off-by: R Sundar
On Wed, Oct 02, 2024 at 09:56:38AM GMT, Uwe Kleine-König wrote:
> Hello,
>
> On Tue, Oct 01, 2024 at 11:37:35PM -0400, Alex Lanzano wrote:
> > This patch series add support for the monochrome Sharp Memory LCD
> > panels. This series is based off of the work done by Mehdi Djait.
> >
> > References
Hi all,
Today's linux-next merge of the drm-misc tree got a conflict in:
drivers/gpu/drm/panthor/panthor_drv.c
between commit:
2b55639a4e25 ("drm/panthor: Add FOP_UNSIGNED_OFFSET to fop_flags")
from the drm-misc-fixes tree and commit:
e16635d88fa0 ("drm/panthor: add DRM fdinfo support")
From: Michal Wajdeczko
This drm printer wrapper can be used to increase the robustness of
the captured output generated by any other drm_printer to make sure
we didn't lost any intermediate lines of the output by adding line
numbers to each output line. Helpful for capturing some crash data.
v2:
Commit f11b0417eec2 ("drm/panfrost: Add fdinfo support GPU load metrics")
retrieves the OPP for the maximum device clock frequency, but forgets to
keep the reference count balanced by putting the returned OPP object. This
eventually leads to an OPP core warning when removing the device.
Fix it by
This includes both DRM objects created to support queues, groups and heaps,
and also objects whose pages are shared between the GPU and the MCU.
However, this doesn't include objects that hold the firmware's binary
regions, since these aren't owned by a render context and are allocated
only once a
Some drivers must allocate a considerable amount of memory for bookkeeping
structures and GPU's MCU-kernel shared communication regions. These are
often created as a result of the invocation of the driver's ioctl()
interface functions, so it is sensible to consider them as being owned by
the render
This patch series lets DRM fdinfo stats functions display an additional tag
that will reflect the amount of memory internal BOs of a DRM driver take
up.
The rationale for this is that some drivers, like Panthor, need quite a bit
of memory for things like queue ring buffers or tiler heap chunks, an
On Wed, Oct 02, 2024 at 01:16:17PM +0800, Macpaul Lin wrote:
> The infra-iommu node in mt8195.dtsi was triggering a CHECK_DTBS error due
> to an excessively long 'interrupts' property. The error message was:
>
> infra-iommu@10315000: interrupts: [[0, 795, 4, 0], [0, 796, 4, 0],
>
Currently, DRM atomic uAPI allows only primary planes to be flipped
asynchronously. However, each driver might be able to perform async
flips in other different plane types. To enable drivers to set their own
restrictions on which type of plane they can or cannot flip, use the
existing atomic_async
amdgpu can handle async flips on overlay planes, so allow it for atomic
async checks.
Signed-off-by: André Almeida
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pla
ge-id: 20241002-tonyk-async_flip-828cfe9cf3ca
Best regards,
--
André Almeida
From: Michal Wajdeczko
This drm printer wrapper can be used to increase the robustness of
the captured output generated by any other drm_printer to make sure
we didn't lost any intermediate lines of the output by adding line
numbers to each output line. Helpful for capturing some crash data.
v2:
Fine by me
On Tue, 2024-10-01 at 10:35 -0300, Jason Gunthorpe wrote:
> On Mon, Sep 16, 2024 at 04:42:33PM -0400, Lyude Paul wrote:
> > Sigh. Took me a minute but I think I know what happened - I meant to push
> > the
> > entire series to drm-misc-next and not drm-misc-fixes, but I must have
> >
Hi,
On Fri, Sep 27, 2024 at 2:44 AM Zhaoxiong Lv
wrote:
>
> In MTK chips, if the DRM runtime resume has not yet completed and the
> system enters sleep mode at the same time, there is a possibility of
> a black screen after waking the machine. Reduce the disable delay
> resolves this issue,
Simi
Hi,
On Fri, Sep 27, 2024 at 2:44 AM Zhaoxiong Lv
wrote:
>
> In MTK chips, if the DRM runtime resume has not yet completed and the
> system enters sleep mode at the same time, there is a possibility of
> a black screen after waking the machine. Reduce the disable delay
> resolves this issue,
This
Op 02-09-2024 om 12:53 schreef Thomas Zimmermann:
Allocate an instance of struct drm_device in struct bochs_device. Also
remove all uses of dev_private from bochs and upcast from the embedded
instance if necessary.
Signed-off-by: Thomas Zimmermann
Acked-by: Gerd Hoffmann
---
drivers/gpu/drm/
Hi Jonas and Laurent,
I may be showing my n00bness ... or I actually found something ...
On Fri Sep 13, 2024 at 7:30 PM CEST, Diederik de Haas wrote:
> On Sun Sep 8, 2024 at 3:28 PM CEST, Jonas Karlman wrote:
> > This series ensure poweron/poweroff and CEC phys addr invalidation is
> > happening
[Public]
> -Original Message-
> From: Vignesh Raman
> Sent: Tuesday, October 1, 2024 9:51 AM
> To: Deucher, Alexander ; Koenig, Christian
> ; Pan, Xinhui ; amd-
> g...@lists.freedesktop.org
> Cc: dani...@collabora.com; helen.ko...@collabora.com; airl...@gmail.com;
> dan...@ffwll.ch; robdc
From: Ville Syrjälä
Atomic drivers shouldn't be using the legacy state stored
directly under drm_crtc. Move that junk into a 'legacy' sub
structure to highlight the offenders, of which there are
quite a few unfortunately.
I'm hoping we could get all these fixed and then declare
the legacy state
From: Ville Syrjälä
Hide the plane->fb/etc. footguns better by stashing them inside
a "legacy" sub struct.
Eventually maybe we could turn 'legacy' into a pointer
that only exists on legacy drivers to completely prevent
any abuse by atomic drivers...
Side note: _dpu_plane_set_danger_state() look
From: Ville Syrjälä
An attempt to hide the drm_plane/crtc legacy state better.
This also highlights the fact that a lot of supposedly
atomic drivers are poking around in the legacy crtc state,
which is rather questionable. For planes we did force the
legacy state to NULL already to force drivers
Applied. Thanks!
On Wed, Oct 2, 2024 at 3:51 AM Colin Ian King wrote:
>
> There is a spelling mistake in a dev_err message. Fix it.
>
> Signed-off-by: Colin Ian King
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/driver
Applied. Thanks!
Alex
On Wed, Oct 2, 2024 at 9:28 AM Igor Artemiev wrote:
>
> amdgpu_irq_ad_id() may fail and the irq handlers will not be registered.
> This patch adds error code check.
>
> Found by Linux Verification Center (linuxtesting.org) with static
> analysis tool SVACE.
>
> Signed-off-
Le 02/10/2024 à 13:51, Jani Nikula a écrit :
On Tue, 01 Oct 2024, Christophe JAILLET wrote:
Le 30/09/2024 à 09:48, Jani Nikula a écrit :
On Sat, 28 Sep 2024, Christophe JAILLET wrote:
"name" is allocated and freed in intel_backlight_device_register().
The initial allocation just duplicates "
On 10/2/24 9:11 AM, Louis Chauvet wrote:
> On 02/10/24 - 08:49, Randy Dunlap wrote:
>> Hi Louis,
>>
>> On 10/2/24 1:57 AM, Louis Chauvet wrote:
>>> On 01/10/24 - 20:54, Randy Dunlap wrote:
Hi--
On 9/30/24 8:31 AM, Louis Chauvet wrote:
> The pre_mul_alpha_blend is dedicated to
> Thanks for the bug report. Can you provide the output of 'sudo lspci
> -vvv' for the graphics device?
Thomas,
Sure. Here's the output (run on the v6.11.0 kernel)
$ sudo lspci -vvv -s :08:00.0
08:00.0 VGA compatible controller: Matrox Electronics Systems Ltd. MGA G200e
[Pilot] ServerEngin
On 02/10/24 - 08:49, Randy Dunlap wrote:
> Hi Louis,
>
> On 10/2/24 1:57 AM, Louis Chauvet wrote:
> > On 01/10/24 - 20:54, Randy Dunlap wrote:
> >> Hi--
> >>
> >> On 9/30/24 8:31 AM, Louis Chauvet wrote:
> >>> The pre_mul_alpha_blend is dedicated to blending, so to avoid mixing
> >>> different con
On 9/30/24 8:31 AM, Louis Chauvet wrote:
> From: Arthur Grillo
>
> Add support to the YUV formats bellow:
>
> - NV12/NV16/NV24
> - NV21/NV61/NV42
> - YUV420/YUV422/YUV444
> - YVU420/YVU422/YVU444
>
> The conversion from yuv to rgb is done with fixed-point arithmetic, using
> 32.32 fixed-poin
Hi Louis,
On 10/2/24 1:57 AM, Louis Chauvet wrote:
> On 01/10/24 - 20:54, Randy Dunlap wrote:
>> Hi--
>>
>> On 9/30/24 8:31 AM, Louis Chauvet wrote:
>>> The pre_mul_alpha_blend is dedicated to blending, so to avoid mixing
>>> different concepts (coordinate calculation and color management), extrac
Hi Dave & Sima,
Here goes drm-intel-fixes toward v6.12-rc2.
Just one & vs && fixup into PM code that should only trigger with debug
Kconfig options.
Regards, Joonas
***
drm-intel-fixes-2024-10-02:
- One fix for bitwise and logical "and" mixup in PM code
The following changes since commit 985
Hi Dave, Sima,
although a bit early, here's the week's PR for drm-misc-fixes.
Best regards
Thomas
drm-misc-fixes-2024-10-02:
Short summary of fixes pull:
panthor:
- Set FOP_UNSIGNED_OFFSET in fops instance
- Acquire lock in panthor_vm_prepare_map_op_ctx()
- Avoid ninitialized variable in tick_c
On Wed, Oct 02, 2024 at 03:00:08PM +, Matthew Brost wrote:
> On Wed, Oct 02, 2024 at 04:16:00PM +0200, Danilo Krummrich wrote:
> > On Wed, Oct 02, 2024 at 06:16:38AM -0700, Matthew Brost wrote:
> > > Avoid leaking a lockdep map on each drm sched creation and destruction
> > > by using a single
Commit 5d08c44e47b9 ("drm/fbdev: Add memory-agnostic fbdev client")
added the newer probe function, but left a path where no probe
function was called. fb_helper->fb would then be NULL and the strcpy
would throw a NULL pointer exception.
Handle that error case.
Fixes: 5d08c44e47b9 ("drm/fbdev: Ad
Commit 45903624e9fc ("drm/vc4: Run DRM default client setup")
only added DRM_FBDEV_DMA_DRIVER_OPS for the vc4 (Pi0-3) driver
definition, which caused an issue on vc5 (Pi4) as there was no
fbdev_probe function defined.
Fixes: 45903624e9fc ("drm/vc4: Run DRM default client setup")
Signed-off-by: Dav
ons is defined
drivers/gpu/drm/drm_fb_helper.c | 2 ++
drivers/gpu/drm/vc4/vc4_drv.c | 1 +
2 files changed, 3 insertions(+)
---
base-commit: 86fdd6b9b1e98cfd26249505e8ce72f4fc0de37f
change-id: 20241002-vc4_fbdev_fix-f4c8b11928cd
Best regards,
--
Dave Stevenson
On Wed, Oct 02, 2024 at 04:16:00PM +0200, Danilo Krummrich wrote:
> On Wed, Oct 02, 2024 at 06:16:38AM -0700, Matthew Brost wrote:
> > Avoid leaking a lockdep map on each drm sched creation and destruction
> > by using a single lockdep map for all drm sched allocated submit_wq.
> >
> > v2:
> > -
Am 02.10.24 um 11:52 schrieb Ilpo Järvinen:
On Tue, 1 Oct 2024, Werner Sembach wrote:
The TUXEDO Sirius 16 Gen1 and TUXEDO Sirius 16 Gen2 devices have a per-key
controllable RGB keyboard backlight. The firmware API for it is implemented
via WMI.
To make the backlight userspace configurable t
Hi
Am 02.10.24 um 15:26 schrieb Jacek Lawrynowicz:
Applied to drm-misc-fixes
And removed from drm-misc-fixes.
The -misc-fixes branch is for fixing bugs that either regressed working
code or to resolve serious bugs that affects upstream users. It is NOT a
dumping ground for all kinds of thin
Hi,
On 01/10/2024 21:31, Sean Anderson wrote:
On 8/9/24 15:35, Sean Anderson wrote:
This series cleans up the zyqnmp_dp IRQ and locking situation. Once
that's done, it adds debugfs support. The intent is to enable compliance
testing or to help debug signal-integrity issues.
I think the patche
6.6-stable review patch. If anyone has any objections, please let me know.
--
From: Zack Rusin
commit aba07b9a0587f50e5d3346eaa19019cf3f86c0ea upstream.
The kms paths keep a persistent map active to read and compare the cursor
buffer. These maps can race with each other in sim
On Wed, Oct 02, 2024 at 06:16:38AM -0700, Matthew Brost wrote:
> Avoid leaking a lockdep map on each drm sched creation and destruction
> by using a single lockdep map for all drm sched allocated submit_wq.
>
> v2:
> - Use alloc_ordered_workqueue_lockdep_map (Tejun)
>
> Cc: Luben Tuikov
> Cc: C
On 10/2/2024 3:16 PM, Matthew Brost wrote:
> Now that drm sched uses a single lockdep map for all submit_wq, drop the
> GuC submit_wq pool hack.
>
> Signed-off-by: Matthew Brost
Reviewed-by: Nirmoy Das
> ---
> drivers/gpu/drm/xe/xe_guc_submit.c | 60 +-
> drivers/
On 10/2/2024 3:16 PM, Matthew Brost wrote:
> Avoid leaking a lockdep map on each drm sched creation and destruction
> by using a single lockdep map for all drm sched allocated submit_wq.
>
> v2:
> - Use alloc_ordered_workqueue_lockdep_map (Tejun)
>
> Cc: Luben Tuikov
> Cc: Christian König
> Si
Hi Dave, Simona,
Fixes for 6.12.
The following changes since commit d7d2688bf4ea58734d73e18edcbf4684b1496d30:
drm/amd/pm: update workload mask after the setting (2024-09-26 17:05:10 -0400)
are available in the Git repository at:
https://gitlab.freedesktop.org/agd5f/linux.git
tags/amd-drm-
Hi,
On 09/08/2024 22:35, Sean Anderson wrote:
Now that all of the sleeping work is done outside of the IRQ, we can
convert it to a hard IRQ. Shared IRQs may be triggered even after
calling disable_irq, so use free_irq instead which removes our callback
altogether.
Signed-off-by: Sean Anderson
On Mon, Sep 30, 2024 at 03:03:00PM +0200, Thomas Zimmermann wrote:
> DRM's aperture functions have long been implemented as helpers
> under drivers/video/ for use with fbdev. Avoid the DRM wrappers by
> calling the video functions directly.
>
> Signed-off-by: Thomas Zimmermann
> Cc: Liviu Dudau
Am 02.10.24 um 14:24 schrieb Thomas Hellström:
Some graphics APIs differentiate between out-of-graphics-memory and
out-of-host-memory (system memory). Add a device init flag to
have -ENOSPC propagated from the resource managers instead of being
converted to -ENOMEM, to aid driver stacks in determ
Thanks to Christophe.
I have figured out what happened.
The connector is registered before the device,
where drm_connector_register() states that,
drm_dev_register() has to be called before it.
Assuming this is the fix, I will send the patch for testing soon.
On Tue, Oct 1, 2024 at 8:23 PM Christ
Hi,
Am 02.10.24 um 14:52 schrieb Lee Jones:
On Fri, 27 Sep 2024, Werner Sembach wrote:
Hi,
first revision integrating Armins feedback.
Stuff I did not yet change and did not comment on previously:
- Still have to ask Christoffer why the mutex is required
- Still using acpi_size instad of size
Applied to drm-misc-fixes
On 9/30/2024 9:52 PM, Jacek Lawrynowicz wrote:
> Most notable changes are coredump and tracing support.
> The rest are stability fixes, some refactoring and typos.
>
> Changes in v2:
> - Fix typos in FW API headers
> - Split fw refactor commit into 2 commits and improved
Avoid leaking a lockdep map on each drm sched creation and destruction
by using a single lockdep map for all drm sched allocated submit_wq.
v2:
- Use alloc_ordered_workqueue_lockdep_map (Tejun)
Cc: Luben Tuikov
Cc: Christian König
Signed-off-by: Matthew Brost
---
drivers/gpu/drm/scheduler/sc
Now that drm sched uses a single lockdep map for all submit_wq, drop the
GuC submit_wq pool hack.
Signed-off-by: Matthew Brost
---
drivers/gpu/drm/xe/xe_guc_submit.c | 60 +-
drivers/gpu/drm/xe/xe_guc_types.h | 7
2 files changed, 1 insertion(+), 66 deletions(-
By default, each DRM scheduler instance creates an ordered workqueue for
submission, and each workqueue creation allocates a new lockdep map.
This becomes problematic when a DRM scheduler is created for every user
queue (e.g., in DRM drivers with firmware schedulers like Xe) due to the
limited numb
A number of DRM-client functions serve as entry points from device
operations to client code. Moving them info a separate file will later
allow for a more fine-grained kernel configuration. For most of the
users it is sufficient to include instead of
the full driver-side interface in
v2:
- renam
The fbdev code does not really belong into drm_kms_helper.ko. But
there are module parameters that control the behavior of the fbdev
emulation. It is not possible to remove them from the module without
breaking someone's installation.
Therefore move the fbdev module parameters to drm_kms_helper_co
Suspend and resume is still tied to fbdev emulation. Modeset helpers
and several drivers call drm_fb_helper_set_suspend_unlocked() to inform
the fbdev client about suspend/resume events.
To make it work with arbitrary clients, add per-client callback
functions for suspend and resume. Implement the
Replace calls to drm_fb_helper_set_suspend_unlocked() with calls
to the client functions drm_client_dev_suspend() and
drm_client_dev_resume(). Any registered in-kernel client will now
receive suspend and resume events.
Signed-off-by: Thomas Zimmermann
Cc: Karol Herbst
Cc: Lyude Paul
Cc: Danilo
Only build client code if DRM_CLIENT has been selected. Automatially
do so if one of the default clients has been enabled. If client support
has been disabled, the helpers for client-related events are empty and
the regular client functions are not present.
Amdgpu has an internal DRM client, so it
Add drm_client_lib.ko to contain DRM's built-in client. Move the
existing client for fbdev emulation into the new module. Protect the
new module behind CONFIG_DRM_CLIENT_LIB.
The Kconfig rules separate the DRM drivers from the DRM clients. A
driver can opt into the default clients, but the user co
Replace calls to drm_fb_helper_set_suspend() with calls to the client
functions drm_client_dev_suspend() and drm_client_dev_resume(). Any
registered in-kernel client will now receive suspend and resume events.
Signed-off-by: Thomas Zimmermann
Cc: Alex Deucher
Cc: "Christian König"
Cc: Xinhui Pa
Replace calls to drm_fb_helper_set_suspend_unlocked() with calls
to the client functions drm_client_dev_suspend() and
drm_client_dev_resume(). Any registered in-kernel client will now
receive suspend and resume events.
Signed-off-by: Thomas Zimmermann
Cc: Alex Deucher
Cc: "Christian König"
Cc:
Fbdev emulation for SHMEM and TTM requires helpers from the fbdev
subsystem. Select them from the modules that use them instead of the
core DRM module.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/d
The Kconfig token DRM_CLIENT_SELECTION will make DRM clients
available to drivers. Select it from xe.
Signed-off-by: Thomas Zimmermann
Cc: Lucas De Marchi
Cc: "Thomas Hellström"
Cc: Rodrigo Vivi
---
drivers/gpu/drm/xe/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm
With the next DRM client coming soon (drm_log) and most of DRM's
fbdev emulation consolidated in a few places, it's time to provide
a single place for the clients.
The new module drm_client_lib.ko stores most of the in-kernel client
code. It is designed such that drivers can opt into client suppor
The Kconfig token DRM_CLIENT_SELECTION will make DRM clients
available to drivers. Select it from i915.
Signed-off-by: Thomas Zimmermann
Cc: Jani Nikula i
Cc: Joonas Lahtinen
Cc: Rodrigo Vivi
Cc: Tvrtko Ursulin
---
drivers/gpu/drm/i915/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git
On Wed, 25 Sep 2024, He Lugang wrote:
> The parameter dev_priv is actually not used in macro PORT_ALPM_CTL
> and PORT_ALPM_LFPS_CTL,so remove it to simplify the code.
>
> Reviewed-by: Jani Nikula
> Signed-off-by: He Lugang
> ---
> drivers/gpu/drm/i915/display/intel_alpm.c | 4 ++--
> driver
amdgpu_irq_ad_id() may fail and the irq handlers will not be registered.
This patch adds error code check.
Found by Linux Verification Center (linuxtesting.org) with static
analysis tool SVACE.
Signed-off-by: Igor Artemiev
---
v2: Remove the cast to struct amdgpu_device as Christian König
sugg
On Wed, 02 Oct 2024, Thomas Hellström wrote:
> The ttm_device_init funcition uses multiple bool arguments. That means
> readability in the caller becomes poor, and all callers need to change if
> yet another bool is added.
>
> Instead use a struct with multiple single-bit flags. This addresses bot
When using mutex_acquire_nest() with a nest_lock, lockdep refcounts the
number of acquired lockdep_maps of mutexes of the same class, and also
keeps a pointer to the first acquired lockdep_map of a class. That pointer
is then used for various comparison-, printing- and checking purposes,
but there
On Wed, 2024-10-02 at 14:45 +0200, Christian König wrote:
> Am 02.10.24 um 14:24 schrieb Thomas Hellström:
> > The ttm_device_init funcition uses multiple bool arguments. That
> > means
> > readability in the caller becomes poor, and all callers need to
> > change if
> > yet another bool is added.
On Fri, 27 Sep 2024, Werner Sembach wrote:
> Hi,
> first revision integrating Armins feedback.
>
> Stuff I did not yet change and did not comment on previously:
> - Still have to ask Christoffer why the mutex is required
> - Still using acpi_size instad of size_t in the util functions, because th
Am 02.10.24 um 14:24 schrieb Thomas Hellström:
The ttm_device_init funcition uses multiple bool arguments. That means
readability in the caller becomes poor, and all callers need to change if
yet another bool is added.
Instead use a struct with multiple single-bit flags. This addresses both
prob
On 14/09/2024 08:31, Jianeng Ceng wrote:
Ponyta is a custom label Chromebook based on MT8186. It is a
self-developed project of Huaqin and has no fixed OEM.
Reviewed-by: AngeloGioacchino Del Regno
Acked-by: Krzysztof Kozlowski
Signed-off-by: Jianeng Ceng
Reviewed-by: Matthias Brugger
Some graphics APIs differentiate between out-of-graphics-memory and
out-of-host-memory (system memory). Add a device init flag to
have -ENOSPC propagated from the resource managers instead of being
converted to -ENOMEM, to aid driver stacks in determining what
error code to return or whether correc
The ttm_device_init funcition uses multiple bool arguments. That means
readability in the caller becomes poor, and all callers need to change if
yet another bool is added.
Instead use a struct with multiple single-bit flags. This addresses both
problems. Prefer it over using defines or enums with
Some graphics APIs differentiate between out-of-graphics-memory and
out-of-host-memory (system memory). Add a device init flag to
have -ENOSPC propagated from the resource managers instead of being
converted to -ENOMEM, to aid driver stacks in determining what
error code to return or whether correc
On Wed, 25 Sep 2024, Maxime Ripard wrote:
> On Wed, Sep 25, 2024 at 01:52:02PM GMT, Simona Vetter wrote:
>> I think for at least drm the consensus is clear, we won't have kunit tests
>> that splat.
>
> Where was that ever discussed?
Well, where was it ever agreed that it's okay for drm kunit test
On Mon, 30 Sep 2024, Thomas Zimmermann wrote:
> DRM's aperture functions have long been implemented as helpers
> under drivers/video/ for use with fbdev. Avoid the DRM wrappers by
> calling the video functions directly.
>
> Signed-off-by: Thomas Zimmermann
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
On Tue, 01 Oct 2024, Christophe JAILLET wrote:
> Le 30/09/2024 à 09:48, Jani Nikula a écrit :
>> On Sat, 28 Sep 2024, Christophe JAILLET
>> wrote:
>>> "name" is allocated and freed in intel_backlight_device_register().
>>> The initial allocation just duplicates "intel_backlight".
>>>
>>> Later,
Hi Harshit,
On Mon, Sep 30, 2024 at 11:25:54PM -0700, Harshit Mogalapalli wrote:
> make htmldocs is reporting:
>
> drivers/gpu/drm/i915/i915_irq.c:1: warning:
> 'intel_runtime_pm_disable_interrupts' not found
> drivers/gpu/drm/i915/i915_irq.c:1: warning:
> 'intel_runtime_pm_enable_interrupts' n
Hi, Christian,
Gentle ping on this one as well.
Thanks,
Thomas
On Thu, 2024-09-19 at 17:24 +0200, Thomas Hellström wrote:
> Hi Christian,
>
> Ping?
>
> /Thomas
>
>
> On Thu, 2024-09-12 at 15:40 +0200, Thomas Hellström wrote:
> > Hi, Christian,
> >
> > On Wed, 2024-09-04 at 12:47 +0200, Chri
Hi
On Wed, 2024-10-02 at 13:32 +0200, Christian König wrote:
> Ah, yes sorry totally forgotten about that.
>
> Give me till Friday to swap everything back into my head again.
>
> Christian.
Thanks!
Once we agree on a direction MBrost is ready to do an in-depth review.
/Thomas
>
> Am 02.10.
Ah, yes sorry totally forgotten about that.
Give me till Friday to swap everything back into my head again.
Christian.
Am 02.10.24 um 13:30 schrieb Thomas Hellström:
Hi, Christian,
Ping? Can i get an ack to proceed with this?
Thanks,
Thomas
On Wed, 2024-09-18 at 14:57 +0200, Thomas Hellst
Hi, Christian,
Ping? Can i get an ack to proceed with this?
Thanks,
Thomas
On Wed, 2024-09-18 at 14:57 +0200, Thomas Hellström wrote:
> Sima, Christian
>
> I've updated the shrinker series now with a guarded for_each macro
> instead:
>
> https://patchwork.freedesktop.org/patch/614514/?series
Hi,
On 02/10/2024 13:02, Maxime Ripard wrote:
+ Jocelyn
On Wed, Oct 02, 2024 at 09:59:57AM GMT, Neil Armstrong wrote:
diff --git a/drivers/gpu/drm/meson/meson_plane.c
b/drivers/gpu/drm/meson/meson_plane.c
index b43ac61201f3..b2def784c00d 100644
--- a/drivers/gpu/drm/meson/meson_plane.c
+++ b/
On 2024-09-30 at 23:25:54 -0700, Harshit Mogalapalli wrote:
> make htmldocs is reporting:
>
> drivers/gpu/drm/i915/i915_irq.c:1: warning:
> 'intel_runtime_pm_disable_interrupts' not found
> drivers/gpu/drm/i915/i915_irq.c:1: warning:
> 'intel_runtime_pm_enable_interrupts' not found
>
Hi Harshit
+ Jocelyn
On Wed, Oct 02, 2024 at 09:59:57AM GMT, Neil Armstrong wrote:
> > diff --git a/drivers/gpu/drm/meson/meson_plane.c
> > b/drivers/gpu/drm/meson/meson_plane.c
> > index b43ac61201f3..b2def784c00d 100644
> > --- a/drivers/gpu/drm/meson/meson_plane.c
> > +++ b/drivers/gpu/drm/meson/meson_pl
1 - 100 of 143 matches
Mail list logo
