Re: [PATCH v2 1/2] drm: fsl-dcu: Use dev_err_probe

2024-09-25 Thread Dmitry Baryshkov
On Thu, Sep 26, 2024 at 07:55:50AM GMT, Alexander Stein wrote: > fsl_dcu_drm_modeset_init can return -EPROBE_DEFER, so use dev_err_probe > to remove an invalid error message and add it to deferral description. > > Signed-off-by: Alexander Stein > --- > Changes in v2: > * None > > drivers/gpu/dr

Re: [PATCH 1/6] fbcon: Make cursor_blink=0 work when configured before fb devices appear

2024-09-25 Thread Helge Deller
Hi Ville, On 9/23/24 17:57, Ville Syrjala wrote: Currently setting cursor_blink attribute to 0 before any fb devices are around does absolutely nothing. When fb devices appear and fbcon becomes active the cursor starts blinking. Fix the problem by recoding the desired state of the attribute even

Re: [PATCH v2 2/2] drm: fsl-dcu: enable PIXCLK on LS1021A

2024-09-25 Thread Dmitry Baryshkov
On Thu, Sep 26, 2024 at 07:55:51AM GMT, Alexander Stein wrote: > From: Matthias Schiffer > > The PIXCLK needs to be enabled in SCFG before accessing certain DCU > registers, or the access will hang. For simplicity, the PIXCLK is enabled > unconditionally, resulting in increased power consumption.

Re: [PATCH v4 ] gpu: drm: replace of_graph_get_next_endpoint()

2024-09-25 Thread Dmitry Baryshkov
On Thu, Sep 26, 2024 at 12:05:42AM GMT, Kuninori Morimoto wrote: > From DT point of view, in general, drivers should be asking for a > specific port number because their function is fixed in the binding. > > of_graph_get_next_endpoint() doesn't match to this concept. > > Simply replace > >

[PATCH v2 1/2] drm: fsl-dcu: Use dev_err_probe

2024-09-25 Thread Alexander Stein
fsl_dcu_drm_modeset_init can return -EPROBE_DEFER, so use dev_err_probe to remove an invalid error message and add it to deferral description. Signed-off-by: Alexander Stein --- Changes in v2: * None drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 6 ++ 1 file changed, 2 insertions(+), 4 deleti

[PATCH v2 2/2] drm: fsl-dcu: enable PIXCLK on LS1021A

2024-09-25 Thread Alexander Stein
From: Matthias Schiffer The PIXCLK needs to be enabled in SCFG before accessing certain DCU registers, or the access will hang. For simplicity, the PIXCLK is enabled unconditionally, resulting in increased power consumption. Signed-off-by: Matthias Schiffer Signed-off-by: Alexander Stein --- C

Re: [PATCH 6/6] dt-bindings: display: samsung,exynos7-decon: add exynos7870 compatible

2024-09-25 Thread Kwanghoon Son
On Wed, 2024-09-25 at 20:05 +, Kaustabh Chakraborty wrote: > On 2024-09-25 19:56, Krzysztof Kozlowski wrote: > > On 25/09/2024 21:36, Kaustabh Chakraborty wrote: > > > On 2024-09-25 19:25, Krzysztof Kozlowski wrote: > > > > On 25/09/2024 20:42, Kaustabh Chakraborty wrote: > > > > > On 2024-09-2

[PATCH] drm/exynos: remove unused prototype for crtc

2024-09-25 Thread Kwanghoon Son
, - struct exynos_drm_plane *exynos_plane); /* This function gets crtc device matched with out_type. */ struct exynos_drm_crtc *exynos_drm_crtc_get_by_type(struct drm_device *drm_dev, --- base-commit: 684a64bf32b6e488004e0ad7f0d7e922798f65b6 change-id: 20240925

Re: [PATCH] [V2] drm: panel-orientation-quirks: Also handle rotation for DeckHD equipped LCDs units

2024-09-25 Thread Dmitry Baryshkov
On Thu, Aug 01, 2024 at 09:10:03AM GMT, Marco Rodolfi wrote: > From: Marco Rodolfi > > This patch also take account of the different resolution for the > aftermarket DeckHD panel, which hasn't been accounted for yet in kernel, > since these quirks are applied based on BIOS information + panel > r

Re: [PATCH v5 2/2] drm/mediatek: Add blend_modes to mtk_plane_init() for different SoCs

2024-09-25 Thread 胡俊光

[PATCH v4 ] gpu: drm: replace of_graph_get_next_endpoint()

2024-09-25 Thread Kuninori Morimoto
>From DT point of view, in general, drivers should be asking for a specific port number because their function is fixed in the binding. of_graph_get_next_endpoint() doesn't match to this concept. Simply replace - of_graph_get_next_endpoint(xxx, NULL); + of_graph_get_endpoint_by_r

[PATCH v6 9/9] media: xilinx-tpg: use new of_graph functions

2024-09-25 Thread Kuninori Morimoto
Now we can use new port related functions for port parsing. Use it. Signed-off-by: Kuninori Morimoto Reviewed-by: Tomi Valkeinen --- drivers/media/platform/xilinx/xilinx-tpg.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/media/platform/xilinx/xilin

[PATCH v6 8/9] fbdev: omapfb: use new of_graph functions

2024-09-25 Thread Kuninori Morimoto
Now we can use new port related functions for port parsing. Use it. Signed-off-by: Kuninori Morimoto --- drivers/video/fbdev/omap2/omapfb/dss/dpi.c| 3 +- drivers/video/fbdev/omap2/omapfb/dss/dss-of.c | 66 --- drivers/video/fbdev/omap2/omapfb/dss/dss.c| 20 +++--- drive

[PATCH v6 7/9] gpu: drm: omapdrm: use new of_graph functions

2024-09-25 Thread Kuninori Morimoto
Now we can use new port related functions for port parsing. Use it. Signed-off-by: Kuninori Morimoto Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dpi.c | 3 ++- drivers/gpu/drm/omapdrm/dss/sdi.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/d

[PATCH v6 6/9] ASoC: audio-graph-card2: use new of_graph functions

2024-09-25 Thread Kuninori Morimoto
Now we can use new port related functions for port parsing. Use it. Signed-off-by: Kuninori Morimoto Acked-by: Mark Brown --- sound/soc/generic/audio-graph-card2.c | 104 -- 1 file changed, 48 insertions(+), 56 deletions(-) diff --git a/sound/soc/generic/audio-graph-car

[PATCH v6 5/9] ASoC: audio-graph-card: use new of_graph functions

2024-09-25 Thread Kuninori Morimoto
Now we can use new port related functions for port parsing. Use it. Signed-off-by: Kuninori Morimoto Acked-by: Mark Brown --- sound/soc/generic/audio-graph-card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-

[PATCH v6 4/9] ASoC: rcar_snd: use new of_graph functions

2024-09-25 Thread Kuninori Morimoto
Now we can use new port related functions for port parsing. Use it. Signed-off-by: Kuninori Morimoto Acked-by: Mark Brown --- sound/soc/sh/rcar/core.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c i

[PATCH v6 3/9] ASoC: test-component: use new of_graph functions

2024-09-25 Thread Kuninori Morimoto
Current test-component.c is using for_each_endpoint_of_node() for parsing "port", because there was no "port" base loop before. It has been assuming 1 port has 1 endpoint here. But now we can use "port" base loop (= for_each_of_graph_port()). Let's replace for_each function from "endpoint" base to

[PATCH v6 2/9] of: property: add of_graph_get_next_port_endpoint()

2024-09-25 Thread Kuninori Morimoto
We already have of_graph_get_next_endpoint(), but it is not intuitive to use in some case. (X) node { (Y) ports { (P0)port@0 { endpoint { remote-endpoint = ...; };}; (P10) port@1 { endpoint { remote-endpoint = ...; }; (P11)

[PATCH v6 1/9] of: property: add of_graph_get_next_port()

2024-09-25 Thread Kuninori Morimoto
We have endpoint base functions - of_graph_get_next_device_endpoint() - of_graph_get_device_endpoint_count() - for_each_of_graph_device_endpoint() Here, for_each_of_graph_device_endpoint() loop finds each endpoints ports { port@0 { (1)

[PATCH v6 0/9] of: property: add of_graph_get_next_port/port_endpoint()

2024-09-25 Thread Kuninori Morimoto
Hi Rob, Saravana, Tomi, Laurent, Sakari, Mark This is v6 patch-set Current Of-graph has "endpoint base" for loop, but doesn't have "port base" loop. "endpoint base" loop only is not enough. This patch-set add new "port base" for loop, and use it. Unfortunately, new helper function need to call

Re: [PATCH 2/6] drm/exynos: exynos7_drm_decon: fix suspended condition in decon_commit()

2024-09-25 Thread Kaustabh Chakraborty
On 2024-09-20 12:40, Krzysztof Kozlowski wrote: > On 19/09/2024 17:11, Kaustabh Chakraborty wrote: >> decon_commit() gets called during atomic_enable. At this stage, DECON is >> suspended, and thus the function refuses to run. Fix the suspended >> condition checking in decon_commit(). >> >> Signed

Re: [PATCH] drm: xlnx: zynqmp_dpsub: also call drm_helper_hpd_irq_event

2024-09-25 Thread Steffen Dirkwinkel
Hi Laurent, On Tue, 2024-09-24 at 21:43 +0300, Laurent Pinchart wrote: > Hi Steffen, > > Thank you for the patch. > > On Mon, Sep 23, 2024 at 09:48:03AM +0200, li...@steffen.cc wrote: > > From: Steffen Dirkwinkel > > > > With hpd going through the bridge as of commit eb2d64bfcc17 > > ("drm: xl

Re: [PATCH 6/6] dt-bindings: display: samsung,exynos7-decon: add exynos7870 compatible

2024-09-25 Thread Kaustabh Chakraborty
On 2024-09-20 12:39, Krzysztof Kozlowski wrote: > On 19/09/2024 17:20, Kaustabh Chakraborty wrote: >> Add the compatible string of Exynos7870 to the existing list. >> >> Signed-off-by: Kaustabh Chakraborty > > ... and the DTS is ? Didn't quite understand. The patch adds the compatible string fo

Re: [PATCH 6/6] dt-bindings: display: samsung,exynos7-decon: add exynos7870 compatible

2024-09-25 Thread Kaustabh Chakraborty
On 2024-09-25 19:25, Krzysztof Kozlowski wrote: > On 25/09/2024 20:42, Kaustabh Chakraborty wrote: >> On 2024-09-20 12:39, Krzysztof Kozlowski wrote: >>> On 19/09/2024 17:20, Kaustabh Chakraborty wrote: Add the compatible string of Exynos7870 to the existing list. Signed-off-by: Kaus

Re: [PATCH 6/6] dt-bindings: display: samsung,exynos7-decon: add exynos7870 compatible

2024-09-25 Thread Kaustabh Chakraborty
On 2024-09-25 19:56, Krzysztof Kozlowski wrote: > On 25/09/2024 21:36, Kaustabh Chakraborty wrote: >> On 2024-09-25 19:25, Krzysztof Kozlowski wrote: >>> On 25/09/2024 20:42, Kaustabh Chakraborty wrote: On 2024-09-20 12:39, Krzysztof Kozlowski wrote: > On 19/09/2024 17:20, Kaustabh Chakrab

Re: [PATCH v2 05/22] drm/msm/dpu: move resource allocation to CRTC

2024-09-25 Thread Abhinav Kumar
On 9/25/2024 2:11 PM, Dmitry Baryshkov wrote: On Wed, 25 Sept 2024 at 22:39, Jessica Zhang wrote: On 9/24/2024 4:13 PM, Dmitry Baryshkov wrote: On Tue, Sep 24, 2024 at 03:59:21PM GMT, Jessica Zhang wrote: From: Dmitry Baryshkov All resource allocation is centered around the LMs. Then

Re: [PATCH 0/2] Add MSM8996/MSM8953 dpu catalog

2024-09-25 Thread Dmitry Baryshkov
On Wed, 25 Sept 2024 at 23:28, wrote: > > On 2024-08-01 21:25, Dmitry Baryshkov wrote: > > On Fri, Jun 28, 2024 at 04:39:38PM GMT, Barnabás Czémán wrote: > >> This patch series add dpu support for MSM8996/MSM8953 devices. > >> > >> Note, by default these platforms are still handled by the MDP5 dri

Re: [PATCH 0/2] Add MSM8996/MSM8953 dpu catalog

2024-09-25 Thread barnabas . czeman
On 2024-08-01 21:25, Dmitry Baryshkov wrote: On Fri, Jun 28, 2024 at 04:39:38PM GMT, Barnabás Czémán wrote: This patch series add dpu support for MSM8996/MSM8953 devices. Note, by default these platforms are still handled by the MDP5 driver unless the `msm.prefer_mdp5=false' parameter is provid

Re: [RFC PATCH 05/28] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-09-25 Thread Matthew Brost
On Tue, Sep 24, 2024 at 04:30:06PM +, Matthew Brost wrote: > On Tue, Sep 24, 2024 at 12:42:56PM +0200, Thomas Hellström wrote: > > Hi, Matt, > > > > Some random review comments on this patch I came across while looking > > at multi-device. > > > > Thanks, > > Thomas > > > > > > On Tue, 2024

Re: [PATCH v2 05/22] drm/msm/dpu: move resource allocation to CRTC

2024-09-25 Thread Dmitry Baryshkov
On Wed, 25 Sept 2024 at 22:39, Jessica Zhang wrote: > > > > On 9/24/2024 4:13 PM, Dmitry Baryshkov wrote: > > On Tue, Sep 24, 2024 at 03:59:21PM GMT, Jessica Zhang wrote: > >> From: Dmitry Baryshkov > >> > >> All resource allocation is centered around the LMs. Then other blocks > >> (except DSCs)

Re: [PATCH v6 2/2] drm/tiny: Add driver for Sharp Memory LCD

2024-09-25 Thread Uwe Kleine-König
Hello, On Thu, Sep 05, 2024 at 08:44:00AM -0400, Alex Lanzano wrote: > +static void sharp_memory_crtc_enable(struct drm_crtc *crtc, > + struct drm_atomic_state *state) > +{ > + struct pwm_state pwm_state; > + struct sharp_memory_device *smd = drm_to_sharp_m

Re: [PATCH v2 2/2] media: imx: vdic: Introduce mem2mem VDI deinterlacer driver

2024-09-25 Thread Marek Vasut
On 9/25/24 7:58 PM, Nicolas Dufresne wrote: Hi, [...] +static struct v4l2_pix_format * +ipu_mem2mem_vdic_get_format(struct ipu_mem2mem_vdic_priv *priv, + enum v4l2_buf_type type) +{ + return &priv->fmt[V4L2_TYPE_IS_OUTPUT(type) ? V4L2_M2M_SRC : V4L2_M2M_DST]; +

Re: [PATCH v2 2/2] media: imx: vdic: Introduce mem2mem VDI deinterlacer driver

2024-09-25 Thread Marek Vasut
On 9/25/24 5:07 PM, Philipp Zabel wrote: Hi, On Di, 2024-09-24 at 17:28 +0200, Marek Vasut wrote: On 9/6/24 11:01 AM, Philipp Zabel wrote: [...] Instead of presenting two devices to userspace, it would be better to have a single video device that can distribute work to both IPUs. Why do yo

Re: [PATCH v2 1/2] gpu: ipu-v3: vdic: Simplify ipu_vdi_setup()

2024-09-25 Thread Marek Vasut
On 9/25/24 6:43 PM, Philipp Zabel wrote: On Di, 2024-09-24 at 12:47 +0200, Marek Vasut wrote: On 9/4/24 11:05 AM, Philipp Zabel wrote: On Mi, 2024-07-24 at 02:19 +0200, Marek Vasut wrote: The 'code' parameter only ever selects between YUV 4:2:0 and 4:2:2 subsampling, turn it into boolean to se

Re: [PATCH v2 01/22] drm: add clone mode check for CRTC

2024-09-25 Thread Jessica Zhang
On 9/25/2024 1:12 AM, Jani Nikula wrote: On Tue, 24 Sep 2024, Jessica Zhang wrote: Add helper to check if the given CRTC state is in clone mode Signed-off-by: Jessica Zhang --- include/drm/drm_crtc.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/drm/drm_crtc.h b/inc

Re: [PATCH v2 05/22] drm/msm/dpu: move resource allocation to CRTC

2024-09-25 Thread Jessica Zhang
On 9/24/2024 4:13 PM, Dmitry Baryshkov wrote: On Tue, Sep 24, 2024 at 03:59:21PM GMT, Jessica Zhang wrote: From: Dmitry Baryshkov All resource allocation is centered around the LMs. Then other blocks (except DSCs) are allocated basing on the LMs that was selected, and LM powers up the CRTC

Re: [PATCH 6/6] dt-bindings: display: samsung,exynos7-decon: add exynos7870 compatible

2024-09-25 Thread Krzysztof Kozlowski
On 25/09/2024 22:05, Kaustabh Chakraborty wrote: > On 2024-09-25 19:56, Krzysztof Kozlowski wrote: >> On 25/09/2024 21:36, Kaustabh Chakraborty wrote: >>> On 2024-09-25 19:25, Krzysztof Kozlowski wrote: On 25/09/2024 20:42, Kaustabh Chakraborty wrote: > On 2024-09-20 12:39, Krzysztof Kozlo

Re: [PATCH v2] drm/meson: switch to a managed drm device

2024-09-25 Thread Martin Blumenstingl
Hi Anastasia, thank you for picking this up and apologies for my late reply. On Tue, Sep 10, 2024 at 5:17 PM Anastasia Belova wrote: [...] > @@ -215,7 +210,7 @@ static int meson_drv_bind_master(struct device *dev, bool > has_components) > regs = devm_platform_ioremap_resource_byname(pde

Re: [PATCH 6/6] dt-bindings: display: samsung,exynos7-decon: add exynos7870 compatible

2024-09-25 Thread Krzysztof Kozlowski
On 25/09/2024 21:36, Kaustabh Chakraborty wrote: > On 2024-09-25 19:25, Krzysztof Kozlowski wrote: >> On 25/09/2024 20:42, Kaustabh Chakraborty wrote: >>> On 2024-09-20 12:39, Krzysztof Kozlowski wrote: On 19/09/2024 17:20, Kaustabh Chakraborty wrote: > Add the compatible string of Exynos7

Re: [PATCH] fbdev: omapfb: Call of_node_put(ep) only once in omapdss_of_find_source_for_first_ep()

2024-09-25 Thread Helge Deller
On 9/25/24 21:21, Markus Elfring wrote: From: Markus Elfring Date: Wed, 25 Sep 2024 21:12:36 +0200 An of_node_put(ep) call was immediately used after a pointer check for a of_graph_get_remote_port() call in this function implementation. Thus call such a function only once instead directly befor

Re: [PATCH v3] fbcon: Fix a NULL pointer dereference issue in fbcon_putcs

2024-09-25 Thread Helge Deller
On 9/25/24 07:29, Qianqiang Liu wrote: syzbot has found a NULL pointer dereference bug in fbcon. Here is the simplified C reproducer: struct param { uint8_t type; struct tiocl_selection ts; }; int main() { struct fb_con2fbmap con2fb; struct param param;

Re: [PATCH v4 00/11] Preemption support for A7XX

2024-09-25 Thread Rob Clark
On Tue, Sep 24, 2024 at 8:22 AM Akhil P Oommen wrote: > > On Tue, Sep 24, 2024 at 07:47:12AM -0700, Rob Clark wrote: > > On Tue, Sep 24, 2024 at 4:54 AM Antonino Maniscalco > > wrote: > > > > > > On 9/20/24 7:09 PM, Akhil P Oommen wrote: > > > > On Wed, Sep 18, 2024 at 09:46:33AM +0200, Neil Arms

Re: [PATCH] gpu: host1x: Set up device DMA parameters

2024-09-25 Thread Thierry Reding
On Mon, Sep 16, 2024 at 03:33:20PM GMT, Thierry Reding wrote: > From: Thierry Reding > > In order to store device DMA parameters, the DMA framework depends on > the device's dma_parms field to point at a valid memory location. Add > backing storage for this in struct host1x_memory_context and poi

Re: [PATCH] gpu: host1x: Fix boot regression for Tegra

2024-09-25 Thread Thierry Reding
On Wed, Sep 25, 2024 at 05:05:04PM GMT, Jon Hunter wrote: > Commit 4c27ac45e622 ("gpu: host1x: Request syncpoint IRQs only during > probe") caused a boot regression for the Tegra186 device. Following this > update the function host1x_intr_init() now calls > host1x_hw_intr_disable_all_syncpt_intrs()

Re: [PATCH 6/6] dt-bindings: display: samsung,exynos7-decon: add exynos7870 compatible

2024-09-25 Thread Krzysztof Kozlowski
On 25/09/2024 20:42, Kaustabh Chakraborty wrote: > On 2024-09-20 12:39, Krzysztof Kozlowski wrote: >> On 19/09/2024 17:20, Kaustabh Chakraborty wrote: >>> Add the compatible string of Exynos7870 to the existing list. >>> >>> Signed-off-by: Kaustabh Chakraborty >> >> ... and the DTS is ? > > Didn'

[PATCH] fbdev: omapfb: Call of_node_put(ep) only once in omapdss_of_find_source_for_first_ep()

2024-09-25 Thread Markus Elfring
From: Markus Elfring Date: Wed, 25 Sep 2024 21:12:36 +0200 An of_node_put(ep) call was immediately used after a pointer check for a of_graph_get_remote_port() call in this function implementation. Thus call such a function only once instead directly before the check. This issue was transformed b

Re: radeon ARUBA NULL pointer dereference

2024-09-25 Thread Ewan Milne
Follow-up, qla2xxx appears to be fixed, most recent test was with: commit 684a64bf32b6e488004e0ad7f0d7e922798f65b6 (HEAD -> master, origin/master, origin/HEAD) Merge: f7fccaa77271 68898131d2df Author: Linus Torvalds Date: Tue Sep 24 15:44:18 2024 -0700 Merge tag 'nfs-for-6.12-1' of git://g

Re: [PATCH v2 2/2] media: imx: vdic: Introduce mem2mem VDI deinterlacer driver

2024-09-25 Thread Nicolas Dufresne
Hi, Le mercredi 24 juillet 2024 à 02:19 +0200, Marek Vasut a écrit : > Introduce dedicated memory-to-memory IPUv3 VDI deinterlacer driver. > Currently the IPUv3 can operate VDI in DIRECT mode, from sensor to > memory. This only works for single stream, that is, one input from > one camera is deint

Re: [PATCH v7 09/10] drm/amd/display: remove dc_edid handler from dm_helpers_parse_edid_caps

2024-09-25 Thread Mario Limonciello
Alex, Unfortunately I can't reproduce the regression on the APU I tried. However I do have a suspicion on a fix. Can you see if this helps? If it does, we can squash it in. diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c in

Re: [PATCH v7 09/10] drm/amd/display: remove dc_edid handler from dm_helpers_parse_edid_caps

2024-09-25 Thread Alex Hung
Mario and Melissa, This patch causes a regrerssion on 7900 XTX in an IGT test: amd_mem_leak's connector-suspend-resume. Is this patch necessary on this series or is it independent from other patches, i.e. can it be dropped from this series until fixed?? Cheers, Alex Hung On 9/18/24 15:38,

Re: [PATCH v2 1/2] gpu: ipu-v3: vdic: Simplify ipu_vdi_setup()

2024-09-25 Thread Philipp Zabel
On Di, 2024-09-24 at 12:47 +0200, Marek Vasut wrote: > On 9/4/24 11:05 AM, Philipp Zabel wrote: > > On Mi, 2024-07-24 at 02:19 +0200, Marek Vasut wrote: > > > The 'code' parameter only ever selects between YUV 4:2:0 and 4:2:2 > > > subsampling, turn it into boolean to select exactly that and update

Re: [PATCH] drm: xlnx: zynqmp_dpsub: also call drm_helper_hpd_irq_event

2024-09-25 Thread Laurent Pinchart
Hi Steffen, On Wed, Sep 25, 2024 at 09:54:18AM +0200, Steffen Dirkwinkel wrote: > On Tue, 2024-09-24 at 21:43 +0300, Laurent Pinchart wrote: > > On Mon, Sep 23, 2024 at 09:48:03AM +0200, li...@steffen.cc wrote: > > > From: Steffen Dirkwinkel > > > > > > With hpd going through the bridge as of co

RE: [RFC PATCH 05/28] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-09-25 Thread Zeng, Oak
Hi Sima, > -Original Message- > From: Simona Vetter > Sent: Tuesday, September 24, 2024 5:25 AM > To: Zeng, Oak > Cc: Brost, Matthew ; intel- > x...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > thomas.hellst...@linux.intel.com; Auld, Matthew > ; dan...@ffwll.ch; airl...@gmai

[PATCH] gpu: host1x: Fix boot regression for Tegra

2024-09-25 Thread Jon Hunter
Commit 4c27ac45e622 ("gpu: host1x: Request syncpoint IRQs only during probe") caused a boot regression for the Tegra186 device. Following this update the function host1x_intr_init() now calls host1x_hw_intr_disable_all_syncpt_intrs() during probe. However, host1x_intr_init() is called before runtim

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-25 Thread Guenter Roeck
On 9/25/24 06:05, Maxime Ripard wrote: [ ... ] We've had similar discussions in the past around unit tests that wasted too much cpu time with randomized combinatorial testing, and we've thrown those out too from drm. Test hygiene matters. We had that discussion because those tests could run fo

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-25 Thread Guenter Roeck
On 9/25/24 05:59, Maxime Ripard wrote: ... All I'm saying it generates an extra burden for current real world CI systems that run tests on a massive scale and even have paid maintainers. It's not trivial to sort out expected and unexpected warnings, and keep the filters updated every time the wa

[PATCH 2/2] drm/amd/display: add warnings for MAX_SURFACES mismatch

2024-09-25 Thread Melissa Wen
So that, in the future, when the max number of planes and streams increases, they might be synced with the number of surfaces to prevent array-index-out-of-bounds issues. Signed-off-by: Melissa Wen --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 20 +++ 1 file changed, 20 ins

[PATCH 1/2] drm/amd/display: increase max surfaces in line with planes and streams

2024-09-25 Thread Melissa Wen
091a97e542cf ("drm/amd/display: Fix warning. Set MAX_SURFACES to 3") reduced the max number of surfaces since, at that time, there was no use for more. However, HW and driver evolves and there are now driver versions that allow two overlay planes (max_slave_planes). Moreover, commit 3cfd03b79425 ("

[PATCH 0/2] drm/amd/display: increase MAX_SURFACES in line with planes and streams

2024-09-25 Thread Melissa Wen
Hi! AFAIU, the driver is defining two different max number of surfaces: MAX_SURFACES (dc.h) and MAX_SURFACE_NUM (dc_types.h) Many years ago, MAX_SURFACES was set 3 just to prevent a stack size warning as in 091a97e542cf ("drm/amd/display: Fix warning. Set MAX_SURFACES to 3")[1]. But according to c

[PATCH 6/6] drm/sprd: Constify struct regmap_bus

2024-09-25 Thread Javier Carrasco
`regmap_txt_io` is not modified and can be declared as const to move its data to a read-only section. Signed-off-by: Javier Carrasco --- drivers/gpu/drm/sprd/sprd_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sprd/sprd_dsi.c b/drivers/gpu/drm/sprd/sprd

[PATCH 5/6] drm/panel: ili9322: Constify struct regmap_bus

2024-09-25 Thread Javier Carrasco
`ili9322_regmap_bus` is not modified and can be declared as const to move its data to a read-only section. Signed-off-by: Javier Carrasco --- drivers/gpu/drm/panel/panel-ilitek-ili9322.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili932

[PATCH 4/6] drm/meson: Constify struct regmap_config

2024-09-25 Thread Javier Carrasco
`meson_regmap_config` is not modified and can be declared as const to move its data to a read-only section. Signed-off-by: Javier Carrasco --- drivers/gpu/drm/meson/meson_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/dr

[PATCH 3/6] drm/mediatek: dp: Constify struct regmap_config

2024-09-25 Thread Javier Carrasco
`mtk_dp_regmap_config` is not modified and can be declared as const to move its data to a read-only section. Signed-off-by: Javier Carrasco --- drivers/gpu/drm/mediatek/mtk_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/d

[PATCH 2/6] drm/fsl-dcu: Constify struct regmap_config

2024-09-25 Thread Javier Carrasco
`fsl_tcon_regmap_config` is not modified and can be declared as const to move its data to a read-only section. Signed-off-by: Javier Carrasco --- drivers/gpu/drm/fsl-dcu/fsl_tcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/fsl-dcu/fsl_tcon.c b/drivers/g

[PATCH 1/6] drm/bridge: dpc3433: Constify struct regmap_config

2024-09-25 Thread Javier Carrasco
`dlpc_regmap_config` is not modified and can be declared as const to move its data to a read-only section. Signed-off-by: Javier Carrasco --- drivers/gpu/drm/bridge/ti-dlpc3433.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ti-dlpc3433.c b/drivers/g

[PATCH 0/6] drm: constify read-only regmap structs

2024-09-25 Thread Javier Carrasco
changed, 6 insertions(+), 6 deletions(-) --- base-commit: 2b7275670032a98cba266bd1b8905f755b3e650f change-id: 20240925-drm-const-regmap-307f2c358d10 Best regards, -- Javier Carrasco

[PATCHv4 5/7] drm/i915/histogram: Add crtc properties for global histogram

2024-09-25 Thread Arun R Murthy
CRTC properties have been added for enable/disable histogram, reading the histogram data and writing the IET data. "HISTOGRAM_EN" is the crtc property to enable/disable the global histogram and takes a value 0/1 accordingly. "Histogram" is a crtc property to read the binary histogram data. "Global

[PATCHv4 0/7] Display Global Histogram

2024-09-25 Thread Arun R Murthy
Display histogram is a hardware functionality where a statistics for 'x' number of frames is generated to form a histogram data. This is notified to the user via histogram event. Compositor will then upon sensing the histogram event will read the histogram data from KMD via crtc property. A library

[PATCHv4 7/7] drm/i915/histogram: Histogram changes for Display 20+

2024-09-25 Thread Arun R Murthy
In Display 20+, new registers are added for setting index, reading histogram and writing the IET. v2: Removed duplicate code (Jani) v3: Moved histogram core changes to earlier patches (Jani/Suraj) v4: Rebased after addressing comments on patch 1 Signed-off-by: Arun R Murthy --- .../gpu/drm/i915

[PATCH 6/7] drm/i915/histogram: histogram delay counter doesnt reset

2024-09-25 Thread Arun R Murthy
The delay counter for histogram does not reset and as a result the histogram bin never gets updated. Workaround would be to use save and restore histogram register. Wa: 14014889975 Signed-off-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_histogram.c | 17 + .../gpu/dr

[PATCHv4 4/7] drm/i915/histogram: histogram interrupt handling

2024-09-25 Thread Arun R Murthy
Upon enabling histogram an interrupt is trigerred after the generation of the statistics. This patch registers the histogram interrupt and handles the interrupt. v2: Added intel_crtc backpointer to intel_histogram struct (Jani) Removed histogram_wq and instead use dev_priv->unodered_eq (Jani)

[PATCH 3/7] drm/xe: Add histogram support to Xe builds

2024-09-25 Thread Arun R Murthy
Histogram added as part of i915/display driver. Adding the same for xe as well. Signed-off-by: Arun R Murthy Reviewed-by: Suraj Kandpal --- drivers/gpu/drm/xe/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile index 1122765c711

[PATCHv2 2/7] drm/i915/histogram: Add support for histogram

2024-09-25 Thread Arun R Murthy
Statistics is generated from the image frame that is coming to display and an event is sent to user after reading this histogram data. This statistics/histogram is then shared with the user upon getting a request from user. User can then use this histogram and generate an enhancement factor. This e

[PATCH 1/7] drm/i915/histogram: Define registers for histogram

2024-09-25 Thread Arun R Murthy
Add the register/bit definitions for global histogram. Signed-off-by: Arun R Murthy --- .../drm/i915/display/intel_histogram_reg.h| 54 +++ 1 file changed, 54 insertions(+) create mode 100644 drivers/gpu/drm/i915/display/intel_histogram_reg.h diff --git a/drivers/gpu/drm/i9

Re: [PATCH v2 2/2] media: imx: vdic: Introduce mem2mem VDI deinterlacer driver

2024-09-25 Thread Philipp Zabel
Hi, On Di, 2024-09-24 at 17:28 +0200, Marek Vasut wrote: > On 9/6/24 11:01 AM, Philipp Zabel wrote: [...] > > Instead of presenting two devices to userspace, it would be better to > > have a single video device that can distribute work to both IPUs. > > Why do you think so ? The scaler/colorspac

Re: [PATCH 1/2] drm/sched: add WARN_ON and BUG_ON to drm_sched_fini

2024-09-25 Thread Philipp Stanner
On Tue, 2024-09-24 at 13:18 +0200, Simona Vetter wrote: > On Mon, Sep 23, 2024 at 05:24:10PM +0200, Christian König wrote: > > Am 20.09.24 um 15:26 schrieb Philipp Stanner: > > > On Fri, 2024-09-20 at 12:33 +0200, Christian König wrote: > > > > Am 20.09.24 um 10:57 schrieb Philipp Stanner: > > > >

Re: [PATCH v3 0/2] drm/panthor: Expose realtime group priority and allowed priorites to userspace

2024-09-25 Thread Steven Price
On 09/09/2024 07:48, Mary Guillemard wrote: > This patch series adds support for realtime group priority and exposes > allowed priorities info with a new dev query. > > Those changes are required to implement EGL_IMG_context_priority and > EGL_NV_context_priority_realtime extensions properly. > >

Re: [PATCH 3/6] dt-bindings: display: mediatek: Fix clocks count constraint for new SoCs

2024-09-25 Thread Conor Dooley
On Wed, Sep 25, 2024 at 04:42:59PM +0800, Macpaul Lin wrote: > > On 9/25/24 00:00, Conor Dooley wrote: > > On Tue, Sep 24, 2024 at 01:42:01PM +0200, AngeloGioacchino Del Regno wrote: > > > Il 24/09/24 12:31, Macpaul Lin ha scritto: > > > > The display node in mt8195.dtsi was triggering a CHECK_DTB

Re: [PATCH v3] drm/panel: elida-kd35t133: transition to mipi_dsi wrapped functions

2024-09-25 Thread Doug Anderson
Hi, On Wed, Sep 25, 2024 at 1:00 AM Tejas Vipin wrote: > > Changes the elida-kd35t133 panel to use multi style functions for > improved error handling. > > Reviewed-by: Jessica Zhang > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Tejas Vipin > --- > Changes in v3: > - Added back bytes th

[PATCH] drm/i915: Use memdup_user() instead of kmalloc() and copy_from_user()

2024-09-25 Thread Thorsten Blum
Use memdup_user() instead of kmalloc() followed by copy_from_user() to simplify set_context_image(). Fixes the following Coccinelle/coccicheck warning reported by memdup_user.cocci: WARNING opportunity for memdup_user Signed-off-by: Thorsten Blum --- drivers/gpu/drm/i915/gem/i915_gem_context

Re: [Linaro-mm-sig] Re: [RFC PATCH 0/4] Linaro restricted heap

2024-09-25 Thread Christian König
Am 25.09.24 um 14:51 schrieb Dmitry Baryshkov: On Wed, Sep 25, 2024 at 10:51:15AM GMT, Christian König wrote: Am 25.09.24 um 01:05 schrieb Dmitry Baryshkov: On Tue, Sep 24, 2024 at 01:13:18PM GMT, Andrew Davis wrote: On 9/23/24 1:33 AM, Dmitry Baryshkov wrote: Hi, On Fri, Aug 30, 2024 at 09:

Re: [PATCH] gpu: host1x: Request syncpoint IRQs only during probe

2024-09-25 Thread Jon Hunter
On 25/09/2024 13:58, Thierry Reding wrote: On Tue, Sep 24, 2024 at 07:33:05PM GMT, Jon Hunter wrote: On 06/09/2024 09:38, Jon Hunter wrote: Hi Mikko, On 31/05/2024 08:07, Mikko Perttunen wrote: From: Mikko Perttunen Syncpoint IRQs are currently requested in a code path that runs during r

Re: [RFC PATCH] drm: allow encoder mode_set even when connectors change for crtc

2024-09-25 Thread Maxime Ripard
Hi, On Wed, Sep 11, 2024 at 05:54:44PM GMT, Abhinav Kumar wrote: > On 9/10/2024 1:40 AM, Maxime Ripard wrote: > > Hi, > > > > On Mon, Sep 09, 2024 at 12:59:47PM GMT, Abhinav Kumar wrote: > > > On 9/9/2024 6:37 AM, Maxime Ripard wrote: > > > > Hi, > > > > > > > > On Thu, Sep 05, 2024 at 03:11:24P

Re: [PATCH -next 2/3] drm/tegra: Enable module autoloading

2024-09-25 Thread Thierry Reding
On Mon, Sep 23, 2024 at 07:21:21AM GMT, Dmitry Baryshkov wrote: > On Mon, Sep 02, 2024 at 11:33:19AM GMT, Liao Chen wrote: > > Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based > > on the alias from of_device_id table. > > > > Signed-off-by: Liao Chen > > --- > > drivers/g

Re: [PATCH v6 01/12] spi: add driver for intel graphics on-die spi device

2024-09-25 Thread Mark Brown
On Wed, Sep 25, 2024 at 12:31:34PM +, Usyskin, Alexander wrote: > > It's locking/refcounting stuff that looks nothing like any other SPI > > controller driver. Even if it works it's obviously fragile since the > > driver does surprising things which break assumptions that will be made > > by

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-25 Thread Maxime Ripard
On Wed, Sep 25, 2024 at 01:52:02PM GMT, Simona Vetter wrote: > On Tue, Sep 24, 2024 at 08:09:38AM -0700, Guenter Roeck wrote: > > On 9/24/24 06:56, Maxime Ripard wrote: > > > On Tue, Sep 24, 2024 at 06:37:59AM GMT, Guenter Roeck wrote: > > > > On 9/24/24 04:54, Maxime Ripard wrote: > > > > > +Guent

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-25 Thread Maxime Ripard
On Wed, Sep 25, 2024 at 12:41:40PM GMT, Jani Nikula wrote: > On Tue, 24 Sep 2024, Maxime Ripard wrote: > > On Tue, Sep 24, 2024 at 06:56:26PM GMT, Jani Nikula wrote: > >> On Tue, 24 Sep 2024, Guenter Roeck wrote: > >> On Tue, Sep 24, 2024 at 12:06:28PM GMT, Simona Vetter wrote: > >> > Ye

RE: [PATCHv3 6/6] drm/i915/histogram: Histogram changes for Display 20+

2024-09-25 Thread Jani Nikula
On Wed, 25 Sep 2024, "Murthy, Arun R" wrote: >> >> > +static __inline__ void set_bin_index_0(struct intel_display >> >> > +*display, enum pipe pipe) >> >> ^^ >> >> >> >> Why? >> >> >> > Sorry, didn't get your question. Is it why "enum pipe pipe" >> >> No, why __inline__? What's

Re: [PATCH] gpu: host1x: Request syncpoint IRQs only during probe

2024-09-25 Thread Thierry Reding
On Tue, Sep 24, 2024 at 07:33:05PM GMT, Jon Hunter wrote: > > On 06/09/2024 09:38, Jon Hunter wrote: > > Hi Mikko, > > > > On 31/05/2024 08:07, Mikko Perttunen wrote: > > > From: Mikko Perttunen > > > > > > Syncpoint IRQs are currently requested in a code path that runs > > > during resume. Due

Re: [RFC PATCH 0/4] Linaro restricted heap

2024-09-25 Thread Jens Wiklander
On Wed, Sep 25, 2024 at 1:41 PM Dmitry Baryshkov wrote: > > On Wed, Sep 25, 2024 at 09:15:04AM GMT, Jens Wiklander wrote: > > On Mon, Sep 23, 2024 at 09:33:29AM +0300, Dmitry Baryshkov wrote: > > > Hi, > > > > > > On Fri, Aug 30, 2024 at 09:03:47AM GMT, Jens Wiklander wrote: > > > > Hi, > > > > >

Re: [Linaro-mm-sig] Re: [RFC PATCH 0/4] Linaro restricted heap

2024-09-25 Thread Dmitry Baryshkov
On Wed, Sep 25, 2024 at 10:51:15AM GMT, Christian König wrote: > Am 25.09.24 um 01:05 schrieb Dmitry Baryshkov: > > On Tue, Sep 24, 2024 at 01:13:18PM GMT, Andrew Davis wrote: > > > On 9/23/24 1:33 AM, Dmitry Baryshkov wrote: > > > > Hi, > > > > > > > > On Fri, Aug 30, 2024 at 09:03:47AM GMT, Jens

RE: [PATCH v6 01/12] spi: add driver for intel graphics on-die spi device

2024-09-25 Thread Usyskin, Alexander
> On Sat, Sep 21, 2024 at 01:00:52PM +, Winkler, Tomas wrote: > > > On Thu, Sep 19, 2024 at 09:54:24AM +, Winkler, Tomas wrote: > > > > > On Mon, Sep 16, 2024 at 04:49:17PM +0300, Alexander Usyskin > wrote: > > > > Just do normal open coded allocations, the reference counting is just > > >

Re: [PATCH v6 11/11] drm/v3d: Expose Super Pages capability

2024-09-25 Thread Maíra Canal
Hi Iago, On 9/24/24 02:30, Iago Toral wrote: Reviewed-by: Iago Toral Quiroga I just applied to misc/kernel.git (drm-misc-next). Thank you and Tvrtko for all the help during the reviewing process! Best Regards, - Maíra El lun, 23-09-2024 a las 10:55 -0300, Maíra Canal escribió: Add a new

[PATCH AUTOSEL 6.6 128/139] drm/amdgpu/gfx10: use rlc safe mode for soft recovery

2024-09-25 Thread Sasha Levin
From: Alex Deucher [ Upstream commit ead60e9c4e29c8574cae1be4fe3af1d9a978fb0f ] Protect the MMIO access with safe mode. Acked-by: Vitaly Prosyak Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 ++ 1 file changed, 2 insertions(+) diff --

[PATCH AUTOSEL 6.6 127/139] drm/amdgpu/gfx11: use rlc safe mode for soft recovery

2024-09-25 Thread Sasha Levin
From: Alex Deucher [ Upstream commit 3f2d35c325534c1b7ac5072173f0dc7ca969dec2 ] Protect the MMIO access with safe mode. Acked-by: Vitaly Prosyak Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2 ++ 1 file changed, 2 insertions(+) diff --

[PATCH AUTOSEL 6.6 123/139] drm/amdgpu/gfx9: use rlc safe mode for soft recovery

2024-09-25 Thread Sasha Levin
From: Alex Deucher [ Upstream commit 3ec2ad7c34c412bd9264cd1ff235d0812be90e82 ] Protect the MMIO access with safe mode. Acked-by: Vitaly Prosyak Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 ++ 1 file changed, 2 insertions(+) diff --g

[PATCH AUTOSEL 6.6 124/139] drm/amd/pm: ensure the fw_info is not null before using it

2024-09-25 Thread Sasha Levin
From: Tim Huang [ Upstream commit 186fb12e7a7b038c2710ceb2fb74068f1b5d55a4 ] This resolves the dereference null return value warning reported by Coverity. Signed-off-by: Tim Huang Reviewed-by: Jesse Zhang Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/pm/pow

[PATCH AUTOSEL 6.6 113/139] drm/amd/display: Initialize get_bytes_per_element's default to 1

2024-09-25 Thread Sasha Levin
From: Alex Hung [ Upstream commit 4067f4fa0423a89fb19a30b57231b384d77d2610 ] Variables, used as denominators and maybe not assigned to other values, should not be 0. bytes_per_element_y & bytes_per_element_c are initialized by get_bytes_per_element() which should never return 0. This fixes 10 D

[PATCH AUTOSEL 6.6 122/139] drm/amdgpu: Block MMR_READ IOCTL in reset

2024-09-25 Thread Sasha Levin
From: Victor Skvortsov [ Upstream commit 9e823f307074c0f82b5f6044943b0086e3079bed ] Register access from userspace should be blocked until reset is complete. Signed-off-by: Victor Skvortsov Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm

  1   2   3   >