Intend to work on the DRM_* logging macro conversion

2024-09-16 Thread YJ Lin
Hi Sean and the vkms maintainers: I’m Leo, currently one of the mentees of the Linux Kernel Bug Fixing Program 2024 Summer Unpaid[1]. I saw an item on the DRM TODO list regarding "Convert logging to drm_* functions with drm_device parameter"[2]. It also suggests reaching out to the driver maintain

[PATCH 6.6] drm/amd/display: Fix subvp+drr logic errors

2024-09-16 Thread Murad Masimov
From: Alvin Lee commit 8a0f02b7beed7b2b768dbdf3b79960de68f460c5 upstream. [Why] There is some logic error where the wrong variable was used to check for OTG_MASTER and DPP_PIPE. [How] Add booleans to confirm that the expected pipes were found before validating schedulability. Tested-by: Daniel

[PATCH 6.1] drm/amd/display: Fix subvp+drr logic errors

2024-09-16 Thread Murad Masimov
From: Alvin Lee commit 8a0f02b7beed7b2b768dbdf3b79960de68f460c5 upstream. [Why] There is some logic error where the wrong variable was used to check for OTG_MASTER and DPP_PIPE. [How] Add booleans to confirm that the expected pipes were found before validating schedulability. Tested-by: Daniel

Re: [PATCH v5 3/4] drm/xe: Use device wedged event

2024-09-16 Thread Raag Jadav
On Tue, Sep 17, 2024 at 10:11:05AM +0530, Ghimiray, Himal Prasad wrote: > On 17-09-2024 09:32, Raag Jadav wrote: > > This was previously attempted as xe specific reset uevent but dropped > > in commit 77a0d4d1cea2 ("drm/xe/uapi: Remove reset uevent for now") > > as part of refactoring. > > > > Now

Re: [PATCH] fbcon: Fix a NULL pointer dereference issue in fbcon_putcs

2024-09-16 Thread Helge Deller
On 9/16/24 03:10, Qianqiang Liu wrote: syzbot has found a NULL pointer dereference bug in fbcon [1]. This issue is caused by ops->putcs being a NULL pointer. We need to check the pointer before using it. [1] https://syzkaller.appspot.com/bug?extid=3d613ae53c031502687a Cc: sta...@vger.kernel.or

Re: [PATCH v6 02/15] drm/msm/dpu: move CRTC resource assignment to dpu_encoder_virt_atomic_check

2024-09-16 Thread Dmitry Baryshkov
On Mon, Sep 16, 2024 at 06:04:08PM GMT, Abhinav Kumar wrote: > > > On 9/2/2024 8:22 PM, Dmitry Baryshkov wrote: > > Historically CRTC resources (LMs and CTLs) were assigned in > > dpu_crtc_atomic_begin(). The commit 9222cdd27e82 ("drm/msm/dpu: move hw > > resource tracking to crtc state") simply

Re: [PATCH v2 1/5] dt-bindings: phy: Add eDP PHY compatible for sa8775p

2024-09-16 Thread Krzysztof Kozlowski
On 17/09/2024 01:26, Konrad Dybcio wrote: > On 16.09.2024 10:33 PM, Dmitry Baryshkov wrote: >> On Mon, Sep 16, 2024 at 05:23:55PM GMT, Krzysztof Kozlowski wrote: >>> On Fri, Sep 13, 2024 at 04:07:51PM +0530, Soutrik Mukhopadhyay wrote: Add compatible string for the supported eDP PHY on sa8775p

Re: [PATCH v5 3/4] drm/xe: Use device wedged event

2024-09-16 Thread Ghimiray, Himal Prasad
On 17-09-2024 09:32, Raag Jadav wrote: This was previously attempted as xe specific reset uevent but dropped in commit 77a0d4d1cea2 ("drm/xe/uapi: Remove reset uevent for now") as part of refactoring. Now that we have device wedged event supported by DRM core, make use of it. With this in pla

[PATCH v5 4/4] drm/i915: Use device wedged event

2024-09-16 Thread Raag Jadav
Now that we have device wedged event supported by DRM core, make use of it. With this in place, userspace will be notified of wedged device on gt reset failure. Signed-off-by: Raag Jadav --- drivers/gpu/drm/i915/gt/intel_reset.c | 2 ++ drivers/gpu/drm/i915/i915_driver.c| 10 ++ 2 f

[PATCH v5 3/4] drm/xe: Use device wedged event

2024-09-16 Thread Raag Jadav
This was previously attempted as xe specific reset uevent but dropped in commit 77a0d4d1cea2 ("drm/xe/uapi: Remove reset uevent for now") as part of refactoring. Now that we have device wedged event supported by DRM core, make use of it. With this in place userspace will be notified of wedged devi

[PATCH v5 2/4] drm: Expose wedge recovery methods

2024-09-16 Thread Raag Jadav
Now that we have device wedged event in place, add wedge_recovery sysfs attribute which will expose recovery methods supported by the DRM device. This is useful for userspace consumers in cases where the device supports multiple recovery methods which can be used as fallbacks. $ cat /sys/class/drm

[PATCH v5 1/4] drm: Introduce device wedged event

2024-09-16 Thread Raag Jadav
Introduce device wedged event, which will notify userspace of wedged (hanged/unusable) state of the DRM device through a uevent. This is useful especially in cases where the device is no longer operating as expected and has become unrecoverable from driver context. Purpose of this implementation i

[PATCH v5 0/4] Introduce DRM device wedged event

2024-09-16 Thread Raag Jadav
This series introduces device wedged event in DRM subsystem and uses it in xe and i915 drivers. Detailed description in commit message. This was earlier attempted as xe specific uevent in v1 and v2. https://patchwork.freedesktop.org/series/136909/ v2: Change authorship to Himal (Aravind) Add

Re: [PATCH v3 1/4] dt-bindings: display: bridge: add sam9x75-mipi-dsi binding

2024-09-16 Thread Manikandan.M
Hi Conor, On 14/08/24 7:29 pm, Conor Dooley wrote: > On Wed, Aug 14, 2024 at 04:22:53PM +0530, Manikandan Muralidharan wrote: >> Add the 'sam9x75-mipi-dsi' compatible binding, which describes the >> Microchip's specific wrapper for the Synopsys DesignWare MIPI DSI HOST >> Controller for the sam9x7

Re: [PATCH v6 02/15] drm/msm/dpu: move CRTC resource assignment to dpu_encoder_virt_atomic_check

2024-09-16 Thread Abhinav Kumar
On 9/2/2024 8:22 PM, Dmitry Baryshkov wrote: Historically CRTC resources (LMs and CTLs) were assigned in dpu_crtc_atomic_begin(). The commit 9222cdd27e82 ("drm/msm/dpu: move hw resource tracking to crtc state") simply moved resources to struct dpu_crtc_state, without changing the code sequence

Re: [PATCH v6 01/15] drm/msm/dpu: make sure phys resources are properly initialized

2024-09-16 Thread Abhinav Kumar
On 9/2/2024 8:22 PM, Dmitry Baryshkov wrote: The commit b954fa6baaca ("drm/msm/dpu: Refactor rm iterator") removed zero-init of the hw_ctl array, but didn't change the error condition, that checked for hw_ctl[i] being NULL. At the same time because of the early returns in case of an error dpu_

Re: [PATCH v2 1/5] dt-bindings: phy: Add eDP PHY compatible for sa8775p

2024-09-16 Thread Konrad Dybcio
On 16.09.2024 10:33 PM, Dmitry Baryshkov wrote: > On Mon, Sep 16, 2024 at 05:23:55PM GMT, Krzysztof Kozlowski wrote: >> On Fri, Sep 13, 2024 at 04:07:51PM +0530, Soutrik Mukhopadhyay wrote: >>> Add compatible string for the supported eDP PHY on sa8775p platform. >>> >>> Signed-off-by: Soutrik Mukho

[PATCH v2] drm/panic: Fix uninitialized spinlock acquisition with CONFIG_DRM_PANIC=n

2024-09-16 Thread Lyude Paul
It turns out that if you happen to have a kernel config where CONFIG_DRM_PANIC is disabled and spinlock debugging is enabled, along with KMS being enabled - we'll end up trying to acquire an uninitialized spin_lock with drm_panic_lock() when we try to do a commit: rvkms rvkms.0: [drm:drm_atomic_

Re: [PATCH -next] drm/msm: Remove unneeded semicolon

2024-09-16 Thread Abhinav Kumar
On 9/2/2024 5:56 PM, Yang Li wrote: ./drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c:282:2-3: Unneeded semicolon Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9852 Signed-off-by: Yang Li --- drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 2 +- 1 file changed, 1 in

[PATCH v2] drm/scheduler: Improve documentation

2024-09-16 Thread Shuicheng Lin
Function drm_sched_entity_push_job() doesn't have return value, remove the return value description for it. Correct several other typo errors. v2 (Philipp): - more correction with related comments. Signed-off-by: Shuicheng Lin Cc: Philipp Stanner --- drivers/gpu/drm/scheduler/sched_entity.c |

Re: [PATCH] drm/amd/display: Remove unused function bios_get_vga_enabled_displays

2024-09-16 Thread Alex Deucher
Acked-by: Alex Deucher And applied. Thanks! On Sun, Sep 15, 2024 at 10:19 AM wrote: > > From: "Dr. David Alan Gilbert" > > bios_get_vga_enabled_displays has been unused since > commit 5a8132b9f606 ("drm/amd/display: remove dead dc vbios code") > > Remove it. > > Signed-off-by: Dr. David Ala

Re: [PATCH 1/1] drm/amd/display: handle nulled pipe context in DCE110's set_drr()

2024-09-16 Thread Alex Deucher
Acked-by: Alex Deucher And applied. Thanks! On Mon, Sep 16, 2024 at 9:03 AM wrote: > > From: Tobias Jakobi > > As set_drr() is called from IRQ context, it can happen that the > pipe context has been nulled by dc_state_destruct(). > > Apply the same protection here that is already present for

Re: [PATCH] MAINTAINERS: drm/sched: Add new maintainers

2024-09-16 Thread Danilo Krummrich
On Mon, Sep 16, 2024 at 08:52:00PM +0200, Philipp Stanner wrote: > DRM's GPU scheduler is arguably in need of more intensive maintenance. > Danilo and Philipp volunteer to help with the maintainership. > > Signed-off-by: Philipp Stanner > Cc: Christian König > Cc: Luben Tuikov > Cc: Matthew Bro

Re: [PATCH v2 1/3] drm/nouveau/tegra: Use iommu_paging_domain_alloc()

2024-09-16 Thread Lyude Paul
Sigh. Took me a minute but I think I know what happened - I meant to push the entire series to drm-misc-next and not drm-misc-fixes, but I must have misread or typo'd the branch name and pushed the second half of patches to drm-misc- fixes by mistake. So the nouveau commit is present in drm-misc-ne

Re: [PATCH v2 1/5] dt-bindings: phy: Add eDP PHY compatible for sa8775p

2024-09-16 Thread Dmitry Baryshkov
On Mon, Sep 16, 2024 at 05:23:55PM GMT, Krzysztof Kozlowski wrote: > On Fri, Sep 13, 2024 at 04:07:51PM +0530, Soutrik Mukhopadhyay wrote: > > Add compatible string for the supported eDP PHY on sa8775p platform. > > > > Signed-off-by: Soutrik Mukhopadhyay > > --- > > v2: No change > > > > Acke

Re: [PATCH] MAINTAINERS: drm/sched: Add new maintainers

2024-09-16 Thread Matthew Brost
On Mon, Sep 16, 2024 at 08:52:00PM +0200, Philipp Stanner wrote: > DRM's GPU scheduler is arguably in need of more intensive maintenance. > Danilo and Philipp volunteer to help with the maintainership. > > Signed-off-by: Philipp Stanner > Cc: Christian König > Cc: Luben Tuikov > Cc: Matthew Bro

Re: [PATCH v4 04/27] dt-bindings: panel: add Samsung s6e3ha8

2024-09-16 Thread Krzysztof Kozlowski
On Fri, Sep 13, 2024 at 06:07:47PM +0300, Dzmitry Sankouski wrote: > Add binding for the Samsung s6e3ha8 panel found in the Samsung S9. > > Signed-off-by: Dzmitry Sankouski > > --- > Changes in v4: > - change dts example intendation from tabs > to spaces > - remove reset-gpios description > ---

[RFC] more descriptor fun: dma_buf_fd()

2024-09-16 Thread Al Viro
dma_buf_fd() takes dmabuf and either inserts the corresponding struct file reference into descriptor table (and returns the descriptor) or returns an error. In the former case dmabuf reference is consumed, in the latter it is not. At the very least, the calling conventions are wro

Re: [PATCH v6 2/4] drm/amd/display: Add support for minimum backlight quirk

2024-09-16 Thread Harry Wentland
On 2024-08-26 12:57, Mario Limonciello wrote: > On 8/24/2024 13:33, Thomas Weißschuh wrote: >> Not all platforms provide the full range of PWM backlight capabilities >> supported by the hardware through ATIF. >> Use the generic drm panel minimum backlight quirk infrastructure to >> override the

Re: [PATCH] MAINTAINERS: drm/sched: Add new maintainers

2024-09-16 Thread Alex Deucher
On Mon, Sep 16, 2024 at 3:03 PM Philipp Stanner wrote: > > DRM's GPU scheduler is arguably in need of more intensive maintenance. > Danilo and Philipp volunteer to help with the maintainership. > > Signed-off-by: Philipp Stanner > Cc: Christian König > Cc: Luben Tuikov > Cc: Matthew Brost > Cc

Re: [PATCH] MAINTAINERS: drm/sched: Add new maintainers

2024-09-16 Thread Christian König
Am 16.09.24 um 20:52 schrieb Philipp Stanner: DRM's GPU scheduler is arguably in need of more intensive maintenance. Danilo and Philipp volunteer to help with the maintainership. Signed-off-by: Philipp Stanner Cc: Christian König Cc: Luben Tuikov Cc: Matthew Brost Cc: Danilo Krummrich Cc: T

[PATCH] MAINTAINERS: drm/sched: Add new maintainers

2024-09-16 Thread Philipp Stanner
DRM's GPU scheduler is arguably in need of more intensive maintenance. Danilo and Philipp volunteer to help with the maintainership. Signed-off-by: Philipp Stanner Cc: Christian König Cc: Luben Tuikov Cc: Matthew Brost Cc: Danilo Krummrich Cc: Tvrtko Ursulin --- MAINTAINERS | 2 ++ 1 file

Re: [PATCH v6 0/4] drm: Minimum backlight overrides and implementation for amdgpu

2024-09-16 Thread Thomas Weißschuh
Hi Harry, Leo and other amdgpu maintainers, On 2024-08-24 20:33:53+, Thomas Weißschuh wrote: > The value of "min_input_signal" returned from ATIF on a Framework AMD 13 > is "12". This leads to a fairly bright minimum display backlight. > > Introduce a quirk to override "min_input_signal" to "

Re: [PATCH v6 11/12] drm/xe/spi: add on-die spi device

2024-09-16 Thread Rodrigo Vivi
On Mon, Sep 16, 2024 at 04:49:27PM +0300, Alexander Usyskin wrote: > Enable access to internal spi on DGFX with GSC/CSC devices > via a child device. > The spi child device is exposed via auxiliary bus. > > Signed-off-by: Alexander Usyskin > --- > drivers/gpu/drm/xe/Makefile | 1 + > d

[PATCH v2] drm/i915/cx0: Set power state to ready only on owned PHY lanes

2024-09-16 Thread Vamsi Krishna Brahmajosyula
In DP alt mode, when pin assignment is D, only one PHY lane is owned by the display. intel_cx0pll_enable currently performs a power cycle ready on both the lanes in all cases. Address the todo to perfom power state ready on owned lanes. Tested on Meteor Lake-P [Intel Arc Graphics] with DP alt mod

Re: [PATCH v6 07/12] spi: intel-dg: wake card on operations

2024-09-16 Thread Rodrigo Vivi
On Mon, Sep 16, 2024 at 04:49:23PM +0300, Alexander Usyskin wrote: > Enable runtime PM in spi driver to notify graphics driver that > whole card should be kept awake while spi operations are > performed through this driver. > > CC: Lucas De Marchi > Signed-off-by: Alexander Usyskin > --- > driv

Re: [PATCH v3 04/10] drm/msm/A6xx: Implement preemption for A7XX targets

2024-09-16 Thread Akhil P Oommen
On Thu, Sep 12, 2024 at 05:48:45PM +0200, Antonino Maniscalco wrote: > On 9/10/24 6:43 PM, Akhil P Oommen wrote: > > On Mon, Sep 09, 2024 at 01:22:22PM +0100, Connor Abbott wrote: > > > On Fri, Sep 6, 2024 at 9:03 PM Akhil P Oommen > > > wrote: > > > > > > > > On Thu, Sep 05, 2024 at 04:51:22PM

Re: [PATCH 8/8] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-16 Thread Tvrtko Ursulin
On 16/09/2024 13:20, Tvrtko Ursulin wrote: On 16/09/2024 13:11, Christian König wrote: Am 13.09.24 um 18:05 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Having removed one re-lock cycle on the entity->lock in a patch titled "drm/sched: Optimise drm_sched_entity_push_job", with only a tiny

[PATCH v2] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-16 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Having removed one re-lock cycle on the entity->lock in a patch titled "drm/sched: Optimise drm_sched_entity_push_job", with only a tiny bit larger refactoring we can do the same optimisation on the rq->lock. (Currently both drm_sched_rq_add_entity() and drm_sched_rq_update_f

Re: [PATCH v8 0/2] arm64: dts: mediatek: Add MT8186 Ponyta

2024-09-16 Thread Rob Herring (Arm)
On Sat, 14 Sep 2024 14:31:20 +0800, Jianeng Ceng wrote: > This is v8 of the MT8186 Chromebook device tree series. > --- > Changes in v8: > - PATCH 1/2: Remove custom label. > - PATCH 2/2: Change the commit about ponyta. > - Link to > v7:https://lore.kernel.org/all/20240913031505.372868-1-cengjia

Re: [PATCH v2] drm/xe: use devm_add_action_or_reset() helper

2024-09-16 Thread Rodrigo Vivi
On Wed, Sep 11, 2024 at 06:22:15PM +0800, He Lugang wrote: > Use devm_add_action_or_reset() to release resources in case of failure, > because the cleanup function will be automatically called. > > Reviewed-by: Rodrigo Vivi > Signed-off-by: He Lugang > --- > v2:move devm_add_action_or_reset afte

Re: [PATCH v2] drm/mediatek: ovl: Add fmt_support_man for MT8192 and MT8195

2024-09-16 Thread Alper Nebi Yasak
Hi, On 2024-09-15 19:12 +03:00, Jason-JH.Lin wrote: > OVL_CON_CLRFMT_MAN is an configuration for extending color format > settings of DISP_REG_OVL_CON(n). > It will change some of the original color format settings. > > Take the settings of (3 << 12) for example. > - If OVL_CON_CLRFMT_MAN = 0 mea

Re: [PATCH v2 1/5] dt-bindings: phy: Add eDP PHY compatible for sa8775p

2024-09-16 Thread Krzysztof Kozlowski
On Fri, Sep 13, 2024 at 04:07:51PM +0530, Soutrik Mukhopadhyay wrote: > Add compatible string for the supported eDP PHY on sa8775p platform. > > Signed-off-by: Soutrik Mukhopadhyay > --- > v2: No change > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 1/5] dt-bindings: phy: Add eDP PHY compatible for sa8775p

2024-09-16 Thread Krzysztof Kozlowski
On Fri, Sep 13, 2024 at 04:07:51PM +0530, Soutrik Mukhopadhyay wrote: > Add compatible string for the supported eDP PHY on sa8775p platform. > > Signed-off-by: Soutrik Mukhopadhyay > --- > v2: No change > > --- > Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 1 + Reviewed-by: Krzys

Re: [PATCH v2 3/3] drm/amdgpu: use drm_file name

2024-09-16 Thread Tvrtko Ursulin
On 16/09/2024 14:32, Pierre-Eric Pelloux-Prayer wrote: In debugfs gem_info/vm_info files, timeout handler and page fault reports. This information is useful with the virtio/native-context driver: this allows the guest applications identifier to visible in amdgpu's output. The output in amdgpu

[PATCH v10 5/7] drm/ttm: Add a shrinker helper and a macro to perform LRU iteration

2024-09-16 Thread Thomas Hellström
Following the design direction communicated here: https://lore.kernel.org/linux-mm/b7491378-defd-4f1c-31e2-29e4c77e2...@amd.com/T/#ma918844aa8a6efe8768fdcda0c6590d5c93850c9 Export the LRU walker for driver shrinker use and add a bo shrinker helper for initial use by the xe driver. v8: - Split ou

[PATCH v10 7/7] drm/xe: Increase the XE_PL_TT watermark

2024-09-16 Thread Thomas Hellström
The XE_PL_TT watermark was set to 50% of system memory. The idea behind that was unclear since the net effect is that TT memory will be evicted to TTM_PL_SYSTEM memory if that watermark is exceeded, requiring PPGTT rebinds and dma remapping. But there is no similar watermark for TTM_PL_1SYSTEM memo

[PATCH v10 6/7] drm/xe: Add a shrinker for xe bos

2024-09-16 Thread Thomas Hellström
Rather than relying on the TTM watermark accounting add a shrinker for xe_bos in TT or system memory. Leverage the newly added TTM per-page shrinking and shmem backup support. Although xe doesn't fully support WONTNEED (purgeable) bos yet, introduce and add shrinker support for purgeable ttm_tts.

[PATCH v10 4/7] drm/ttm: Use fault-injection to test error paths

2024-09-16 Thread Thomas Hellström
Use fault-injection to test partial TTM swapout and interrupted swapin. Return -EINTR for swapin to test the callers ability to handle and restart the swapin, and on swapout perform a partial swapout to test that the swapin and release_shrunken functionality. v8: - Use the core fault-injection sys

[PATCH v10 3/7] drm/ttm/pool: Provide a helper to shrink pages

2024-09-16 Thread Thomas Hellström
Provide a helper to shrink ttm_tt page-vectors on a per-page basis. A ttm_backup backend could then in theory get away with allocating a single temporary page for each struct ttm_tt. This is accomplished by splitting larger pages before trying to back them up. In the future we could allow ttm_bac

[PATCH v10 2/7] drm/ttm: Add a virtual base class for graphics memory backup

2024-09-16 Thread Thomas Hellström
Initially intended for experimenting with different backup solutions (shmem vs direct swap cache insertion), abstract the backup destination using a virtual base class. Also provide a sample implementation for shmem. While when settling on a preferred backup solution, one could perhaps skip the a

[PATCH v10 1/7] drm/ttm: Balance ttm_resource_cursor_init() and ttm_resource_cursor_fini()

2024-09-16 Thread Thomas Hellström
Make the interface more symmetric by providing and using a ttm_resource_cursor_init(). v10: - Fix a stray newline (Matthew Brost) - Update kerneldoc (Matthew Brost) Signed-off-by: Thomas Hellström Reviewed-by: Matthew Brost --- drivers/gpu/drm/ttm/ttm_bo.c | 3 ++- drivers/gpu/drm/ttm/t

[PATCH v10 0/7] TTM shrinker helpers and xe buffer object shrinker

2024-09-16 Thread Thomas Hellström
This series implements TTM shrinker / eviction helpers and an xe bo shrinker. It builds on a previous series, *and obsoletes that one*. https://lore.kernel.org/linux-mm/b7491378-defd-4f1c-31e2-29e4c77e2...@amd.com/T/ Where the comment about layering https://lore.kernel.org/linux-mm/b7491378-defd-

Re: [PATCH v2 2/3] drm: use drm_file name in fdinfo

2024-09-16 Thread Tvrtko Ursulin
On 16/09/2024 14:32, Pierre-Eric Pelloux-Prayer wrote: Add an optional drm-client-name field to drm fdinfo's output. Signed-off-by: Pierre-Eric Pelloux-Prayer --- Documentation/gpu/drm-usage-stats.rst | 5 + drivers/gpu/drm/drm_file.c| 5 + 2 files changed, 10 insertio

Re: [PATCH v2 1/3] drm: add DRM_SET_NAME ioctl

2024-09-16 Thread Tvrtko Ursulin
On 16/09/2024 14:32, Pierre-Eric Pelloux-Prayer wrote: Giving the opportunity to userspace to associate a free-form name with a drm_file struct is helpful for tracking and debugging. This is similar to the existing DMA_BUF_SET_NAME ioctl. Access to name is protected by a mutex, and the 'clien

Re: [PATCH v4 1/2] firmware: sysfb: Add a sysfb_handles_screen_info() helper function

2024-09-16 Thread Thomas Zimmermann
Am 16.09.24 um 13:00 schrieb Javier Martinez Canillas: That can be used by drivers to check if the Generic System Framebuffers (sysfb) support can handle the data contained in the global screen_info. Drivers might need this information to know if have to setup the system framebuffer, or if th

Re: [PATCH] drm/i915/cx0: Use one lane to set power state to ready in DP alt mode

2024-09-16 Thread Gustavo Sousa
Hi, Vamsi. Thanks for your patch. Please, see my feedback below. Quoting Vamsi Krishna Brahmajosyula (2024-09-06 14:46:01-03:00) >In DP alt mode one lane is owned by display and the other by usb >intel_cx0pll_enable currently performs a power cycle ready on both >the lanes in all cases. > >Addres

[PATCH v6 09/12] drm/i915/spi: add intel_spi_region map

2024-09-16 Thread Alexander Usyskin
From: Tomas Winkler Add the dGFX spi region map and convey it via auxiliary device to the spi child device. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/i915/spi/intel_spi.c | 8 1 file changed, 8 insertions(

[PATCH v6 11/12] drm/xe/spi: add on-die spi device

2024-09-16 Thread Alexander Usyskin
Enable access to internal spi on DGFX with GSC/CSC devices via a child device. The spi child device is exposed via auxiliary bus. Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/xe/Makefile | 1 + drivers/gpu/drm/xe/xe_device.c | 3 + drivers/gpu/drm/xe/xe_device_types.h |

[PATCH v6 12/12] drm/xe/spi: add support for access mode

2024-09-16 Thread Alexander Usyskin
Check SPI access mode from GSC FW status registers and overwrite access status read from SPI descriptor, if needed. Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/xe/regs/xe_gsc_regs.h | 4 drivers/gpu/drm/xe/xe_heci_gsc.c | 5 +--- drivers/gpu/drm/xe/xe_spi.c | 33 ++

[PATCH v6 08/12] drm/i915/spi: add spi device for discrete graphics

2024-09-16 Thread Alexander Usyskin
From: Tomas Winkler Enable access to internal spi on DGFX devices via a child device. The spi child device is exposed via auxiliary bus. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/i915/Makefile| 4 ++ drive

[PATCH v6 10/12] drm/i915/spi: add support for access mode

2024-09-16 Thread Alexander Usyskin
Check SPI access mode from GSC FW status registers and overwrite access status read from SPI descriptor, if needed. Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/i915/spi/intel_spi.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/i915/spi/in

[PATCH v6 07/12] spi: intel-dg: wake card on operations

2024-09-16 Thread Alexander Usyskin
Enable runtime PM in spi driver to notify graphics driver that whole card should be kept awake while spi operations are performed through this driver. CC: Lucas De Marchi Signed-off-by: Alexander Usyskin --- drivers/spi/spi-intel-dg.c | 44 ++ 1 file changed,

[PATCH v6 06/12] spi: intel-dg: align 64bit read and write

2024-09-16 Thread Alexander Usyskin
GSC SPI HW errors on quad access overlapping 1K border. Align 64bit read and write to avoid readq/writeq over 1K border. Signed-off-by: Alexander Usyskin --- drivers/spi/spi-intel-dg.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/spi/spi-intel-

[PATCH v6 05/12] spi: intel-dg: implement mtd access handlers

2024-09-16 Thread Alexander Usyskin
From: Tomas Winkler Implement mtd read, erase, and write handlers. For erase operation address and size should be 4K aligned. For write operation address and size has to be 4bytes aligned. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Vitaly Lubart Signed-o

[PATCH v6 04/12] spi: intel-dg: spi register with mtd

2024-09-16 Thread Alexander Usyskin
From: Tomas Winkler Register the on-die spi device with the mtd subsystem. Refcount spi object on _get and _put mtd callbacks. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/spi/spi-intel-dg.c | 111

[PATCH v6 03/12] spi: intel-dg: implement spi access functions

2024-09-16 Thread Alexander Usyskin
From: Tomas Winkler Implement spi_read(), spi_erase() and spi_write() functions. CC: Lucas De Marchi CC: Rodrigo Vivi Signed-off-by: Tomas Winkler Signed-off-by: Vitaly Lubart Signed-off-by: Alexander Usyskin --- drivers/spi/spi-intel-dg.c | 199 + 1 fil

[PATCH v6 02/12] spi: intel-dg: implement region enumeration

2024-09-16 Thread Alexander Usyskin
From: Tomas Winkler In intel-dg spi, there is no access to the spi controller, the information is extracted from the descriptor region. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/spi/spi-intel-dg.c | 190 +++

[PATCH v6 01/12] spi: add driver for intel graphics on-die spi device

2024-09-16 Thread Alexander Usyskin
Add auxiliary driver for intel discrete graphics on-die spi device. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- MAINTAINERS | 7 ++ drivers/spi/Kconfig | 11 +++ drivers/spi/Makefile |

[PATCH v6 00/12] spi: add driver for Intel discrete graphics

2024-09-16 Thread Alexander Usyskin
Add driver for access to Intel discrete graphics card internal SPI device. Expose device on auxiliary bus by i915 and Xe drivers and provide spi driver to register this device with MTD framework. This is a rewrite of "drm/i915/spi: spi access for discrete graphics" series with connection to the Xe

Re: [PATCH v2 3/3] drm/amdgpu: use drm_file name

2024-09-16 Thread Christian König
Am 16.09.24 um 15:32 schrieb Pierre-Eric Pelloux-Prayer: In debugfs gem_info/vm_info files, timeout handler and page fault reports. This information is useful with the virtio/native-context driver: this allows the guest applications identifier to visible in amdgpu's output. The output in amdgpu

Re: [PATCH v2 2/3] drm: use drm_file name in fdinfo

2024-09-16 Thread Christian König
Am 16.09.24 um 15:32 schrieb Pierre-Eric Pelloux-Prayer: Add an optional drm-client-name field to drm fdinfo's output. Signed-off-by: Pierre-Eric Pelloux-Prayer Reviewed-by: Christian König --- Documentation/gpu/drm-usage-stats.rst | 5 + drivers/gpu/drm/drm_file.c| 5 ++

Re: [PATCH v2 1/3] drm: add DRM_SET_NAME ioctl

2024-09-16 Thread Christian König
Am 16.09.24 um 15:32 schrieb Pierre-Eric Pelloux-Prayer: Giving the opportunity to userspace to associate a free-form name with a drm_file struct is helpful for tracking and debugging. This is similar to the existing DMA_BUF_SET_NAME ioctl. Access to name is protected by a mutex, and the 'clien

Re: [PATCH] drm/tidss: Add MIT license along with GPL-2.0

2024-09-16 Thread Devarsh Thakkar
Hi Laurent, Thanks for the quick review. On 13/09/24 13:54, Laurent Pinchart wrote: > Hi Devarsh, > > On Thu, Sep 12, 2024 at 10:41:42PM +0530, Devarsh Thakkar wrote: >> Modify license to include dual licensing as GPL-2.0-only OR MIT license for >> tidss display driver. This allows other operati

[PATCH] gpu: host1x: Set up device DMA parameters

2024-09-16 Thread Thierry Reding
From: Thierry Reding In order to store device DMA parameters, the DMA framework depends on the device's dma_parms field to point at a valid memory location. Add backing storage for this in struct host1x_memory_context and point to it. Reported-by: Jonathan Hunter Signed-off-by: Thierry Reding

[PATCH v2 3/3] drm/amdgpu: use drm_file name

2024-09-16 Thread Pierre-Eric Pelloux-Prayer
In debugfs gem_info/vm_info files, timeout handler and page fault reports. This information is useful with the virtio/native-context driver: this allows the guest applications identifier to visible in amdgpu's output. The output in amdgpu_vm_info/amdgpu_gem_info looks like this: pid:12255P

[PATCH v2 1/3] drm: add DRM_SET_NAME ioctl

2024-09-16 Thread Pierre-Eric Pelloux-Prayer
Giving the opportunity to userspace to associate a free-form name with a drm_file struct is helpful for tracking and debugging. This is similar to the existing DMA_BUF_SET_NAME ioctl. Access to name is protected by a mutex, and the 'clients' debugfs file has been updated to print it. Userspace M

[PATCH v2 2/3] drm: use drm_file name in fdinfo

2024-09-16 Thread Pierre-Eric Pelloux-Prayer
Add an optional drm-client-name field to drm fdinfo's output. Signed-off-by: Pierre-Eric Pelloux-Prayer --- Documentation/gpu/drm-usage-stats.rst | 5 + drivers/gpu/drm/drm_file.c| 5 + 2 files changed, 10 insertions(+) diff --git a/Documentation/gpu/drm-usage-stats.rst b/D

[PATCH 3/3] drm: panel-orientation-quirks: Add quirk for AYA NEO GEEK

2024-09-16 Thread tjakobi
From: Joaquín Ignacio Aramendía Add quirk orientation for AYA NEO GEEK. The name appears without spaces in DMI strings. The board name is completely different to the previous models making it difficult to reuse their quirks despite being the same resolution and using the same orientation. Tested

[PATCH 2/3] drm: panel-orientation-quirks: Add quirk for AYA NEO Founder edition

2024-09-16 Thread tjakobi
From: Joaquín Ignacio Aramendía Add quirk orientation for AYA NEO Founder. The name appears with spaces in DMI strings as other devices of the brand. The panel is the same as the NEXT and 2021 models. Those could not be reused as the former has VENDOR name as "AYANEO" without spaces and the latte

Re: [PATCH 3/3] drm/ast: Warn about unsupported TX chips

2024-09-16 Thread Jocelyn Falempe
On 16/09/2024 10:25, Thomas Zimmermann wrote: A number of TX chips are listed in VGACRD1, but not supported by the ast driver. Whether any existing product uses such a chip is unknown. Warn if the driver encounters any. We can then add support as necessary. Thanks, it looks good to me. Reviewe

Re: [PATCH 2/3] drm/ast: Use TX-chip register constants

2024-09-16 Thread Jocelyn Falempe
On 16/09/2024 10:25, Thomas Zimmermann wrote: Replace magic values with named constants when reading the TX chip from VGACRD1. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_dp501.c | 13 +++-- drivers/gpu/d

[PATCH 1/3] drm: panel-orientation-quirks: Add quirk for AYA NEO 2 model

2024-09-16 Thread tjakobi
From: Joaquín Ignacio Aramendía Add quirk orientation for AYA NEO 2. The name appears without spaces in DMI strings. That made it difficult to reuse the 2021 match. Also the display is larger in resolution. Tested by the JELOS team that has been patching their own kernel for a while now and conf

[PATCH 0/3] Panel orientation quirks for AYA NEO handhelds

2024-09-16 Thread tjakobi
From: Tobias Jakobi Hello, this is a re-submit of panel orientation quirks for some of the handheld devices by vendor AYA NEO. The quirks were posted to dri-devel some time ago, but got lost: https://lore.kernel.org/lkml/20230621220615.1253571-2-samsa...@gmail.com/T/#u With best wishes, Tobias

Re: [PATCH 1/3] drm/ast: Rename register constants for TX-chip types

2024-09-16 Thread Jocelyn Falempe
On 16/09/2024 10:25, Thomas Zimmermann wrote: The type of the TX chip is provided in VGACRD1. Rename the constants accordingly. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_main.c | 4 ++-- drivers/gpu/drm/ast/a

[PATCH 0/1] drm/amd: more VRR race fixes during IRQ handling

2024-09-16 Thread tjakobi
From: Tobias Jakobi Hello, this is a follow-up for these (already merged) patches: https://lore.kernel.org/all/cover.1725269643.git.tjak...@math.uni-bielefeld.de/ A user on the GitLab issue tracker pointed out that the problem also manifests itself on DCE110 hardware. This is a straight port o

Re: linux-next: manual merge of the drm tree with Linus' tree

2024-09-16 Thread Tobias Jakobi
On 9/16/24 06:15, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_hwseq.c between commit: e835d5144f5e ("drm/amd/display: Avoid race between dcn35_set_drr() and dc_state_destruct()") from Linu

[PATCH 1/1] drm/amd/display: handle nulled pipe context in DCE110's set_drr()

2024-09-16 Thread tjakobi
From: Tobias Jakobi As set_drr() is called from IRQ context, it can happen that the pipe context has been nulled by dc_state_destruct(). Apply the same protection here that is already present for dcn35_set_drr() and dcn10_set_drr(). I.e. fetch the tg pointer first (to avoid a race with dc_state_

Re: [PATCH 2/2] drm/v3d: Appease lockdep while updating GPU stats

2024-09-16 Thread Maíra Canal
Hi Tvrtko, On 8/13/24 07:25, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Lockdep thinks our seqcount_t usage is unsafe because the update path can be both from irq and worker context: [ ] [ ] WARNING: inconsistent lock state [ ] 6.10.3-v8-16k-numa #159 Ta

Re: [PATCH 8/8] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-16 Thread Tvrtko Ursulin
On 16/09/2024 13:11, Christian König wrote: Am 13.09.24 um 18:05 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Having removed one re-lock cycle on the entity->lock in a patch titled "drm/sched: Optimise drm_sched_entity_push_job", with only a tiny bit larger refactoring we can do the same opt

Re: [PATCH 8/8] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-16 Thread Christian König
Am 13.09.24 um 18:05 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Having removed one re-lock cycle on the entity->lock in a patch titled "drm/sched: Optimise drm_sched_entity_push_job", with only a tiny bit larger refactoring we can do the same optimisation on the rq->lock. (Currently both drm_

fw_devlinks preventing a panel driver from probing

2024-09-16 Thread Tomi Valkeinen
Hi, We have an issue where two devices have dependencies to each other, according to drivers/base/core.c's fw_devlinks, and this prevents them from probing. I've been adding debugging to the core.c, but so far I don't quite grasp the issue, so I thought to ask. Maybe someone can instantly say

Re: [PATCH v4] drm/connector: hdmi: Fix writing Dynamic Range Mastering infoframes

2024-09-16 Thread Derek Foreman
Gentle ping - is there anything more I need to do before this can land? Thanks, Derek On 2024-08-28 03:31, Jani Nikula wrote: On Tue, 27 Aug 2024, Derek Foreman wrote: The largest infoframe we create is the DRM (Dynamic Range Mastering) infoframe which is 26 bytes + a 4 byte header, for a tot

Re: [PATCH 4/8] drm/sched: Optimise drm_sched_entity_push_job

2024-09-16 Thread Christian König
Am 13.09.24 um 18:05 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin In FIFO mode We can avoid dropping the lock only to immediately re-acquire by adding a new drm_sched_rq_update_fifo_locked() helper. v2: * Remove drm_sched_rq_update_fifo() altogether. (Christian) Signed-off-by: Tvrtko Ursuli

Re: [PATCH v2] drm/mediatek: ovl: Add fmt_support_man for MT8192 and MT8195

2024-09-16 Thread AngeloGioacchino Del Regno
Il 15/09/24 18:12, Jason-JH.Lin ha scritto: OVL_CON_CLRFMT_MAN is an configuration for extending color format settings of DISP_REG_OVL_CON(n). It will change some of the original color format settings. Take the settings of (3 << 12) for example. - If OVL_CON_CLRFMT_MAN = 0 means OVL_CON_CLRFMT_R

Re: [PATCH] drm/i915: Fix typos

2024-09-16 Thread Andrew Kreimer
On Mon, Sep 16, 2024 at 12:15:32PM +0200, Andi Shyti wrote: > Hi Andrew, > > On Sun, Sep 15, 2024 at 03:01:55PM GMT, Andrew Kreimer wrote: > > Fix typos in documentation. > > > > Reported-by: Matthew Wilcox > > Signed-off-by: Andrew Kreimer > > Reviewed-by: Andi Shyti > > Because we are rece

Re: [PATCH v6 2/5] drm/panthor: record current and maximum device clock frequencies

2024-09-16 Thread Steven Price
On 13/09/2024 13:42, Adrián Larumbe wrote: > In order to support UM in calculating rates of GPU utilisation, the current > operating and maximum GPU clock frequencies must be recorded during device > initialisation, and also during OPP state transitions. > > Signed-off-by: Adrián Larumbe Reviewe

Re: [PATCH v6 1/5] drm/panthor: introduce job cycle and timestamp accounting

2024-09-16 Thread Steven Price
On 13/09/2024 13:42, Adrián Larumbe wrote: > Enable calculations of job submission times in clock cycles and wall > time. This is done by expanding the boilerplate command stream when running > a job to include instructions that compute said times right before and > after a user CS. > > A separate

[PATCH v4 0/2] firmware: Avoid coreboot and sysfb to register a pdev for same framebuffer

2024-09-16 Thread Javier Martinez Canillas
Hello, This is v4 of a fix to prevent both coreboot and sysfb drivers to register a platform device to setup a system framebuffer. It has been converted to a series since contains changes for both drivers, to prevent build issues on architectures that don't define a global struct screen_info. Pat

[PATCH v4 1/2] firmware: sysfb: Add a sysfb_handles_screen_info() helper function

2024-09-16 Thread Javier Martinez Canillas
That can be used by drivers to check if the Generic System Framebuffers (sysfb) support can handle the data contained in the global screen_info. Drivers might need this information to know if have to setup the system framebuffer, or if they have to delegate this action to sysfb instead. Suggested

  1   2   >