Re: [PATCH v4 03/27] gcc-sdm845: Add general purpose clock ops

2024-09-13 Thread kernel test robot
Hi Dzmitry, kernel test robot noticed the following build errors: [auto build test ERROR on 5acd9952f95fb4b7da6d09a3be39195a80845eb6] url: https://github.com/intel-lab-lkp/linux/commits/Dzmitry-Sankouski/power-supply-add-undervoltage-health-status-property/20240913-231027 base

[PATCH v1] drm/i915: Fix typo in the comment

2024-09-13 Thread Yan Zhen
Correctly spelled comments make it easier for the reader to understand the code. Replace 'ojects' with 'objects' in the comment & replace 'resonable' with 'reasonable' in the comment & replace 'droping' with 'dropping' in the comment & replace 'sacrifical' with 'sacrificial' in the comment. Signe

[PATCH v8 2/2] arm64: dts: mediatek: Add MT8186 Ponyta Chromebooks

2024-09-13 Thread Jianeng Ceng
MT8186 Ponyta is a Huaqin board based on the Corsola board design with the addition of LTE connectivity through usb integrated module. SKU0 with LTE. SKU1 without LTE. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Jianeng Ceng --- Changes in v8: - PATCH 2/2: Change the commit about pon

[PATCH v8 1/2] dt-bindings: arm: mediatek: Add MT8186 Ponyta Chromebook

2024-09-13 Thread Jianeng Ceng
Ponyta is a custom label Chromebook based on MT8186. It is a self-developed project of Huaqin and has no fixed OEM. Reviewed-by: AngeloGioacchino Del Regno Acked-by: Krzysztof Kozlowski Signed-off-by: Jianeng Ceng --- Changes in v8: - PATCH 1/2: Remove custom label. - Link to v7:https://lore.

[PATCH v8 0/2] arm64: dts: mediatek: Add MT8186 Ponyta

2024-09-13 Thread Jianeng Ceng
This is v8 of the MT8186 Chromebook device tree series. --- Changes in v8: - PATCH 1/2: Remove custom label. - PATCH 2/2: Change the commit about ponyta. - Link to v7:https://lore.kernel.org/all/20240913031505.372868-1-cengjian...@huaqin.corp-partner.google.com/ Changes in v7: - PATCH 2/2: Remove

Re: [PATCH v4 11/27] power: supply: max77705: Add charger driver for Maxim 77705

2024-09-13 Thread kernel test robot
Hi Dzmitry, kernel test robot noticed the following build errors: [auto build test ERROR on 5acd9952f95fb4b7da6d09a3be39195a80845eb6] url: https://github.com/intel-lab-lkp/linux/commits/Dzmitry-Sankouski/power-supply-add-undervoltage-health-status-property/20240913-231027 base

Re: [PATCH v4 03/27] gcc-sdm845: Add general purpose clock ops

2024-09-13 Thread kernel test robot
Hi Dzmitry, kernel test robot noticed the following build errors: [auto build test ERROR on 5acd9952f95fb4b7da6d09a3be39195a80845eb6] url: https://github.com/intel-lab-lkp/linux/commits/Dzmitry-Sankouski/power-supply-add-undervoltage-health-status-property/20240913-231027 base

[PATCH v2] drm/panel: raydium-rm69380: transition to mipi_dsi wrapped functions

2024-09-13 Thread Tejas Vipin
Changes the raydium-rm69380 panel to use multi style functions for improved error handling. Reviewed-by: Douglas Anderson Signed-off-by: Tejas Vipin --- Changes in v2: - Fix whitespace issues Link to v1: https://lore.kernel.org/all/20240907140130.410349-1-tejasvipi...@gmail.com/ --- drive

[PATCH] drm/amd/display: Skip dpp1_dscl_set_scaler_filter if filter is null

2024-09-13 Thread Ma Ke
Callers can pass null in filter (i.e. from returned from the function dpp1_dscl_get_filter_coeffs_64p) and a null check is added to ensure that is not the case. Cc: sta...@vger.kernel.org Fixes: 5e9a81b2c465 ("drm/amd/display: separate scl functions out from dcn10_dpp") Signed-off-by: Ma Ke ---

Re: [PATCH next] drm/tegra: Fix NULL vs IS_ERR() check in probe()

2024-09-13 Thread Baolu Lu
On 9/13/24 10:34 PM, Dan Carpenter wrote: The iommu_paging_domain_alloc() function doesn't return NULL pointers, it returns error pointers. Update the check to match. Fixes: 45c690aea8ee ("drm/tegra: Use iommu_paging_domain_alloc()") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/tegra/drm

[PATCH 2/2] drm/i915/gt: Fixed an typo

2024-09-13 Thread Zhang He
column header should be GPU, not CPU --- ChangeLog: v1: use correct name as Author and Signer v2: change one line in drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c, LLC's information header from "Effective CPU freq" to "Effective GPU freq" Signed-off-by: Zhang He --- drivers/gpu

Re: [PATCH 1/3] drm: add DRM_SET_NAME ioctl

2024-09-13 Thread kernel test robot
Hi Pierre-Eric, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-exynos/exynos-drm-next] [also build test WARNING on drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip linus/master v6.11-rc7 next-20240913

Re: [PATCH 1/1] mm/migrate: Trylock device page in do_swap_page

2024-09-13 Thread Matthew Brost
On Wed, Sep 11, 2024 at 02:53:31PM +1000, Alistair Popple wrote: > > Matthew Brost writes: > > > Avoid multiple CPU page faults to the same device page racing by locking > > the page in do_swap_page before taking an additional reference to the > > page. This prevents scenarios where multiple CPU

Re: [PATCH v4 05/27] dt-bindings: mfd: add maxim,max77705

2024-09-13 Thread Rob Herring
On Fri, Sep 13, 2024 at 06:07:48PM +0300, Dzmitry Sankouski wrote: > Add maxim,max77705 core binding part. > > Signed-off-by: Dzmitry Sankouski > > --- > Changes in v4: > - change dts example intendation from tabs > to spaces > - remove interrupt-names property > - remove obvious reg descriptio

Re: [PATCH v6 1/5] drm/panthor: introduce job cycle and timestamp accounting

2024-09-13 Thread kernel test robot
Hi Adrián, kernel test robot noticed the following build warnings: [auto build test WARNING on linus/master] [also build test WARNING on v6.11-rc7 next-20240913] [cannot apply to drm-misc/drm-misc-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH v2] firmware: coreboot: Don't register a pdev if screen_info data is present

2024-09-13 Thread Javier Martinez Canillas
Julius Werner writes: Hello Julius, >> + /* >> +* On Coreboot systems, the advertised LB_TAG_FRAMEBUFFER entry >> +* in the Coreboot table should only be used if the payload did >> +* not pass a framebuffer information to the Linux kernel. > > nit: The official bran

Re: [PATCH 1/2] dt-bindings: display: mediatek: dpi: Add power-domains to the bindings

2024-09-13 Thread Rob Herring
On Thu, Sep 12, 2024 at 9:44 AM Pin-yen Lin wrote: > > The power-domains property is used by most DT nodes using mediatek,dpi > bindings. Add this to the bindings to fix the schema check error. > > Signed-off-by: Pin-yen Lin > --- > > .../bindings/display/mediatek/mediatek,dpi.yaml | 8

Re: [PATCH 2/2] arm64: dts: mt8183: Add port node to dpi node

2024-09-13 Thread Rob Herring
On Thu, Sep 12, 2024 at 9:44 AM Pin-yen Lin wrote: > > Add the port node to fix the binding schema check. The dsi node has the same issue. > Fixes: 009d855a26fd ("arm64: dts: mt8183: add dpi node to mt8183") > Signed-off-by: Pin-yen Lin > Reported-by: kernel test robot > Closes: > https://lor

[PATCH v3] firmware: coreboot: Don't register a pdev if screen_info data is present

2024-09-13 Thread Javier Martinez Canillas
On coreboot platforms, a system framebuffer may be provided to the Linux kernel by filling a LB_TAG_FRAMEBUFFER entry in the coreboot table. But a coreboot payload (e.g: SeaBIOS) could also provide its own framebuffer information to the Linux kernel. If that's the case, arch x86 boot code will fil

Re: [PATCH 5/5] drm/msm/dp: Add DisplayPort controller for SA8775P

2024-09-13 Thread Bjorn Andersson
On Thu, Sep 12, 2024 at 03:34:05PM +0530, Soutrik Mukhopadhyay wrote: > > On 9/12/2024 1:32 AM, Bjorn Andersson wrote: > > On Wed, Sep 11, 2024 at 03:38:13PM +0530, Soutrik Mukhopadhyay wrote: > > > The Qualcomm SA8775P platform comes with a DisplayPort controller > > > with a different base offse

Re: [RESEND PATCH v2] drm/bridge: dw-hdmi-i2s: set insert_pcuv bit if hardware supports it

2024-09-13 Thread Hugh Cole-Baker
Hi Geraldo, and apologies for resurrecting a 2 year old thread... On 17/10/2022 13:04, Geraldo Nascimento wrote: > Hi Mark, resending this as it failed to apply in my last submission. Added > Neil Armstrong to Cc: as hopefully he will be able to better review this. > > Thanks, > Geraldo Nasciment

Re: [PATCH v2] firmware: coreboot: Don't register a pdev if screen_info data is present

2024-09-13 Thread Julius Werner
> + /* > +* On Coreboot systems, the advertised LB_TAG_FRAMEBUFFER entry > +* in the Coreboot table should only be used if the payload did > +* not pass a framebuffer information to the Linux kernel. nit: The official brand spelling is "coreboot", always lowercase (ev

[PATCH v2] drm/sched: Fix dynamic job-flow control race

2024-09-13 Thread Rob Clark
From: Rob Clark Fixes a race condition reported here: https://github.com/AsahiLinux/linux/issues/309#issuecomment-2238968609 The whole premise of lockless access to a single-producer-single- consumer queue is that there is just a single producer and single consumer. That means we can't call dr

Re: [PATCH v3 -next] drm/xe/irq: Remove unneeded semicolon

2024-09-13 Thread Rodrigo Vivi
On Fri, Sep 13, 2024 at 11:53:05AM +0530, Ghimiray, Himal Prasad wrote: > > > On 13-09-2024 11:32, Jiapeng Chong wrote: > > Remove unnecessary semicolon in pick_engine_gt(). > > > > Reported-by: Abaci Robot > > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8757 > > LGTM > Reviewed-by:

[PATCH] drm/msm/a6xx+: Insert a fence wait before SMMU table update

2024-09-13 Thread Rob Clark
From: Rob Clark The CP_SMMU_TABLE_UPDATE _should_ be waiting for idle, but on some devices (x1-85, possibly others), it seems to pass that barrier while there are still things in the event completion FIFO waiting to be written back to memory. Work around that by adding a fence wait before contex

[PATCH v2] firmware: coreboot: Don't register a pdev if screen_info data is present

2024-09-13 Thread Javier Martinez Canillas
On Coreboot platforms, a system framebuffer may be provided to the Linux kernel by filling a LB_TAG_FRAMEBUFFER entry in the Coreboot table. But a Coreboot payload (e.g: SeaBIOS) could also provide its own framebuffer information to the Linux kernel. If that's the case, arch x86 boot code will fil

Re: [NOT A REGRESSION] firmware: framebuffer-coreboot: duplicate device name "simple-framebuffer.0"

2024-09-13 Thread Javier Martinez Canillas
Brian Norris writes: Hello Brian, > Hi Javier, > > On Thu, Sep 12, 2024 at 06:33:58PM +0200, Javier Martinez Canillas wrote: >> That's a very good point. I'm actually not familiar with Coreboot and I >> used an educated guess (in the case of DT for example, that's the main >> source of truth and

Re: [PATCH v4 16/27] arm64: dts: qcom: sdm845: enable gmu

2024-09-13 Thread Steev Klimaszewski
Hi Dzmitry, On Fri, Sep 13, 2024 at 10:15 AM Dzmitry Sankouski wrote: > > Leave gmu enabled, because it's only probed when > GPU is. > > Signed-off-by: Dzmitry Sankouski > --- > arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 4 > arch/arm64/boot/dts/qcom/sdm845-db845c.dts

Re: [PATCH v4 02/27] clk: qcom: clk-rcg2: name refactoring

2024-09-13 Thread Stephen Boyd
Quoting Dzmitry Sankouski (2024-09-13 08:07:45) > clk-rcg2.c uses 2 variable names for pre divisor register value: > pre_div and hid_div. > > Replace hid_div with pre_div. Update calc_rate docs to reflect, that > pre_div is not pure divisor, but a register value, and requires conversion. > > Sign

Re: [git pull] drm fixes for 6.11-rc8

2024-09-13 Thread pr-tracker-bot
The pull request you sent on Fri, 13 Sep 2024 16:46:14 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-09-13 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/46040ea8a6a58e5645d91ffa3ead7ed8fd633d56 Thank you! -- Deet-doot-dot, I am a bot. h

Re: [PATCH] drm/sched: Fix dynamic job-flow control race

2024-09-13 Thread Danilo Krummrich
On Fri, Sep 13, 2024 at 09:53:25AM -0700, Rob Clark wrote: > From: Rob Clark > > Fixes a race condition reported here: > https://github.com/AsahiLinux/linux/issues/309#issuecomment-2238968609 Good catch! Please add a 'Closes' tag with this link. > > The whole premise of lockless access to a s

Re: [NOT A REGRESSION] firmware: framebuffer-coreboot: duplicate device name "simple-framebuffer.0"

2024-09-13 Thread Brian Norris
Hi Javier, On Thu, Sep 12, 2024 at 06:33:58PM +0200, Javier Martinez Canillas wrote: > That's a very good point. I'm actually not familiar with Coreboot and I > used an educated guess (in the case of DT for example, that's the main > source of truth and I didn't know if a Core table was in a simil

Re: [PATCH v2 00/10] drm: bridge: dw_hdmi: Misc enable/disable, CEC and EDID cleanup

2024-09-13 Thread Diederik de Haas
Hi Jonas, On Sun Sep 8, 2024 at 3:28 PM CEST, Jonas Karlman wrote: > This series ensure poweron/poweroff and CEC phys addr invalidation is > happening under drm mode_config mutex lock, and also ensure EDID is > updated (when the dw-hdmi connector is used) after a hotplug pulse. > > These changes h

Re: [PATCH] drm/sched: Fix dynamic job-flow control race

2024-09-13 Thread Rob Clark
On Fri, Sep 13, 2024 at 10:03 AM Michel Dänzer wrote: > > On 2024-09-13 18:53, Rob Clark wrote: > > From: Rob Clark > > > > Fixes a race condition reported here: > > https://github.com/AsahiLinux/linux/issues/309#issuecomment-2238968609 > > > > The whole premise of lockless access to a single-pr

Re: [PATCH] drm/sched: Fix dynamic job-flow control race

2024-09-13 Thread Michel Dänzer
On 2024-09-13 18:53, Rob Clark wrote: > From: Rob Clark > > Fixes a race condition reported here: > https://github.com/AsahiLinux/linux/issues/309#issuecomment-2238968609 > > The whole premise of lockless access to a single-producer-single- > consumer queue is that there is just a single produc

[PATCH] drm/sched: Fix dynamic job-flow control race

2024-09-13 Thread Rob Clark
From: Rob Clark Fixes a race condition reported here: https://github.com/AsahiLinux/linux/issues/309#issuecomment-2238968609 The whole premise of lockless access to a single-producer-single- consumer queue is that there is just a single producer and single consumer. That means we can't call dr

Re: [PATCH v3 04/23] dt-bindings: mfd: add maxim,max77705

2024-09-13 Thread Conor Dooley
On Fri, Sep 13, 2024 at 05:51:56PM +0300, Dzmitry Sankouski wrote: > чт, 20 июн. 2024 г. в 18:46, Krzysztof Kozlowski : > > > > On 18/06/2024 15:59, Dzmitry Sankouski wrote: > > > maxim,max77705 is MAX77705 pmic binding part > > > > > > Signed-off-by: Dzmitry Sankouski > > > --- > > > .../devicet

[PATCH] drm/vc4: Fix atomicity violation in vc4_crtc_send_vblank()

2024-09-13 Thread Qiu-ji Chen
Atomicity violation occurs when the vc4_crtc_send_vblank function is executed simultaneously with modifications to crtc->state or crtc->state->event. Consider a scenario where both crtc->state and crtc->state->event are non-null. They can pass the validity check, but at the same time, crtc->state o

Re: [PATCH v4 05/27] dt-bindings: mfd: add maxim,max77705

2024-09-13 Thread Rob Herring (Arm)
from schema $id: http://devicetree.org/schemas/mfd/maxim,max77705.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240913-starqltechn_integration_upstream-v4-5-2d2efd5c5...@gmail.com The base for the series is generally t

[PATCH 6/8] drm/sched: Re-order struct drm_sched_rq members for clarity

2024-09-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Current kerneldoc for struct drm_sched_rq incompletely documents what fields are protected by the lock. This is not good because it is misleading. Lets fix it by listing all the elements which are protected by the lock. While at it, lets also re-order the members so all pr

[PATCH 7/8] drm/sched: Re-group and rename the entity run-queue lock

2024-09-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Christian suggested to rename the lock and improve the documentation of what it protects. And to also re-order the structure members so all protected by the lock are together in a block. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Alex Deucher Cc: Luben Tuikov

[PATCH 8/8] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Having removed one re-lock cycle on the entity->lock in a patch titled "drm/sched: Optimise drm_sched_entity_push_job", with only a tiny bit larger refactoring we can do the same optimisation on the rq->lock. (Currently both drm_sched_rq_add_entity() and drm_sched_rq_update_f

[PATCH v3 0/8] DRM scheduler fixes and improvements

2024-09-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Re-spin of the series from last week. Changelog is in individual patches. Cc: Christian König Cc: Alex Deucher Cc: Luben Tuikov Cc: Matthew Brost Cc: Philipp Stanner Tvrtko Ursulin (8): drm/sched: Add locking to drm_sched_entity_modify_sched drm/sched: Always wake

[PATCH 5/8] drm/sched: Stop setting current entity in FIFO mode

2024-09-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It does not seem there is a need to set the current entity in FIFO mode since ot only serves as being a "cursor" in round-robin mode. Even if scheduling mode is changed at runtime the change in behaviour is simply to restart from the first entity, instead of continuing in RR

[PATCH 4/8] drm/sched: Optimise drm_sched_entity_push_job

2024-09-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In FIFO mode We can avoid dropping the lock only to immediately re-acquire by adding a new drm_sched_rq_update_fifo_locked() helper. v2: * Remove drm_sched_rq_update_fifo() altogether. (Christian) Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Alex Deucher Cc: Lu

[PATCH 3/8] drm/sched: Always increment correct scheduler score

2024-09-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Entities run queue can change during drm_sched_entity_push_job() so make sure to update the score consistently. Signed-off-by: Tvrtko Ursulin Fixes: d41a39dda140 ("drm/scheduler: improve job distribution with multiple queues") Cc: Nirmoy Das Cc: Christian König Cc: Luben

[PATCH 2/8] drm/sched: Always wake up correct scheduler in drm_sched_entity_push_job

2024-09-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Since drm_sched_entity_modify_sched() can modify the entities run queue, lets make sure to only dereference the pointer once so both adding and waking up are guaranteed to be consistent. Alternative of moving the spin_unlock to after the wake up would for now be more problem

[PATCH 1/8] drm/sched: Add locking to drm_sched_entity_modify_sched

2024-09-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Without the locking amdgpu currently can race between amdgpu_ctx_set_entity_priority() (via drm_sched_entity_modify_sched()) and drm_sched_job_arm(), leading to the latter accesing potentially inconsitent entity->sched_list and entity->num_sched_list pair. v2: * Improve com

Re: [PATCH 8/8] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-13 Thread Tvrtko Ursulin
On 13/09/2024 13:19, Philipp Stanner wrote: On Wed, 2024-09-11 at 13:22 +0100, Tvrtko Ursulin wrote: On 10/09/2024 11:25, Philipp Stanner wrote: On Mon, 2024-09-09 at 18:19 +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Having removed one re-lock cycle on the entity->lock in a patch ti

Re: [PATCH] drm/i915/gt: Fixed an typo

2024-09-13 Thread Andi Shyti
Hi Zhang, On Fri, Sep 13, 2024 at 10:07:21PM GMT, Zhang He wrote: > column header should be GPU, not CPU > > Signed-off-by: Zhang He Thanks for having fixed the issues I pointed out. Said that, for the next patches: 1. Add a versioning. This is version number 2, so that yo uneed to do "git

[PATCH v4 27/27] arm64: dts: qcom: starqltechn: add modem support

2024-09-13 Thread Dzmitry Sankouski
Add support for modem and ipa(IP Accelerator). Add spss reserved memory node. Signed-off-by: Dzmitry Sankouski --- .../boot/dts/qcom/sdm845-samsung-starqltechn.dts | 39 ++ 1 file changed, 39 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dt

[PATCH v4 26/27] arm64: dts: qcom: starqltechn: add graphics support

2024-09-13 Thread Dzmitry Sankouski
Add support for gpu and panel. Signed-off-by: Dzmitry Sankouski --- .../boot/dts/qcom/sdm845-samsung-starqltechn.dts | 67 ++ 1 file changed, 67 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm845-samsung-st

[PATCH v4 25/27] arm64: dts: qcom: starqltechn: add initial sound support

2024-09-13 Thread Dzmitry Sankouski
Add support for sound (headphones and mics only) Also redefine slpi reserved memory, because adsp_mem overlaps with slpi_mem inherited from sdm845.dtsi. Signed-off-by: Dzmitry Sankouski --- .../boot/dts/qcom/sdm845-samsung-starqltechn.dts | 213 + 1 file changed, 213 insert

[PATCH v4 24/27] arm64: dts: qcom: starqltechn: add touchscreen support

2024-09-13 Thread Dzmitry Sankouski
Add support for samsung,s6sy761 touchscreen. Signed-off-by: Dzmitry Sankouski --- .../boot/dts/qcom/sdm845-samsung-starqltechn.dts | 28 ++ 1 file changed, 28 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm

[PATCH v4 23/27] arm64: dts: qcom: starqltechn: add display PMIC

2024-09-13 Thread Dzmitry Sankouski
Add support for s2dos05 display / touchscreen PMIC Signed-off-by: Dzmitry Sankouski --- .../boot/dts/qcom/sdm845-samsung-starqltechn.dts | 77 ++ 1 file changed, 77 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qc

[PATCH v4 22/27] arm64: dts: qcom: starqltechn: add max77705 PMIC

2024-09-13 Thread Dzmitry Sankouski
Add support for max77705 MFD device. Supported sub-devices: charger, fuelgauge, haptic, led Signed-off-by: Dzmitry Sankouski --- .../boot/dts/qcom/sdm845-samsung-starqltechn.dts | 103 + 1 file changed, 103 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsun

[PATCH v4 21/27] arm64: dts: qcom: starqltechn: add gpio keys

2024-09-13 Thread Dzmitry Sankouski
Add support for phone buttons. Signed-off-by: Dzmitry Sankouski --- .../boot/dts/qcom/sdm845-samsung-starqltechn.dts | 36 ++ 1 file changed, 36 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm845-samsung-st

[PATCH v4 20/27] arm64: dts: qcom: starqltechn: remove excess reserved gpios

2024-09-13 Thread Dzmitry Sankouski
Starqltechn has 2 reserved gpio ranges <27 4>, <85 4>. <27 4> is spi for eSE(embedded Secure Element). <85 4> is spi for fingerprint. Remove excess reserved gpio regions. Fixes: d711b22eee55 ("arm64: dts: qcom: starqltechn: add initial device tree for starqltechn") Signed-off-by: Dzmitry Sankou

[PATCH v4 17/27] arm64: dts: qcom: starqltechn: remove wifi

2024-09-13 Thread Dzmitry Sankouski
Starqltechn has broadcom chip for wifi, so sdm845 wifi part can be disabled. Fixes: d711b22eee55 ("arm64: dts: qcom: starqltechn: add initial device tree for starqltechn") Reviewed-by: Konrad Dybcio Signed-off-by: Dzmitry Sankouski --- arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts |

[PATCH v4 19/27] arm64: dts: qcom: starqltechn: refactor node order

2024-09-13 Thread Dzmitry Sankouski
Fixes: d711b22eee55 ("arm64: dts: qcom: starqltechn: add initial device tree for starqltechn") Signed-off-by: Dzmitry Sankouski --- arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung

[PATCH v4 18/27] arm64: dts: qcom: starqltechn: fix usb regulator mistake

2024-09-13 Thread Dzmitry Sankouski
Usb regulator was wrongly pointed to vreg_l1a_0p875. However, on starqltechn it's powered from vreg_l5a_0p8. Fixes: d711b22eee55 ("arm64: dts: qcom: starqltechn: add initial device tree for starqltechn") Signed-off-by: Dzmitry Sankouski --- arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.d

[PATCH v4 16/27] arm64: dts: qcom: sdm845: enable gmu

2024-09-13 Thread Dzmitry Sankouski
Leave gmu enabled, because it's only probed when GPU is. Signed-off-by: Dzmitry Sankouski --- arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 4 arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 arch/arm64/boot/dts/qcom/sdm845-mtp.dts

[PATCH v4 15/27] regulator: add s2dos05 regulator support

2024-09-13 Thread Dzmitry Sankouski
S2dos05 has 1 buck and 4 LDO regulators, used for powering panel/touchscreen. Signed-off-by: Dzmitry Sankouski --- Changes in v4: - remove excessive linux/module.h import - use generic regulator helpers - use of_match - use devm_* for mem allocations - use // style comment - drop all junk Samsun

[PATCH v4 14/27] mfd: sec-core: add s2dos05 support

2024-09-13 Thread Dzmitry Sankouski
S2dos05 is a panel/touchscreen PMIC, often found in Samsung phones. We define 2 sub-devices for which drivers will be added in subsequent patches. Signed-off-by: Dzmitry Sankouski --- drivers/mfd/sec-core.c | 11 +++ include/linux/mfd/samsung/core.h | 1 + 2 files changed, 12

[PATCH v4 13/27] leds: max77705: Add LEDs support

2024-09-13 Thread Dzmitry Sankouski
This adds basic support for LEDs for the max77705 PMIC. Signed-off-by: Dzmitry Sankouski --- Changes in v4: - inline BLINK_(ON|OFF) macro - remove camel case - drop backwards compatibility(new driver) - drop module alias --- MAINTAINERS | 1 + drivers/leds/Kconfig |

[PATCH v4 12/27] power: supply: max77705: Add fuel gauge driver for Maxim 77705

2024-09-13 Thread Dzmitry Sankouski
Add driver for Maxim 77705 fuel gauge (part of max77705 MFD driver) providing power supply class information to userspace. The driver is configured through DTS (battery and system related settings). Signed-off-by: Dzmitry Sankouski --- Changes for V4: - rework driver from scratch - change word

[PATCH v4 11/27] power: supply: max77705: Add charger driver for Maxim 77705

2024-09-13 Thread Dzmitry Sankouski
Add driver for Maxim 77705 switch-mode charger (part of max77705 MFD driver) providing power supply class information to userspace. The driver is configured through DTS (battery and system related settings). Signed-off-by: Dzmitry Sankouski --- Changes for V4: - start from scratch - change word

[PATCH v4 03/27] gcc-sdm845: Add general purpose clock ops

2024-09-13 Thread Dzmitry Sankouski
SDM845 has "General Purpose" clocks that can be muxed to SoC pins to clock various external devices. Those clocks may be used as e.g. PWM sources for external peripherals. GPCLK can in theory have arbitrary value depending on the use case, so the concept of frequency tables, used in rcg2 clock dri

[PATCH v4 10/27] input: max77693: add max77705 haptic support

2024-09-13 Thread Dzmitry Sankouski
Add support for haptic controller on MAX77705 Multifunction device. This driver supports external pwm and LRA (Linear Resonant Actuator) motor. User can control the haptic device via force feedback framework. Signed-off-by: Dzmitry Sankouski --- Changes in v4: - add max77705 haptic support to m

[PATCH v4 09/27] mfd: Add new driver for MAX77705 PMIC

2024-09-13 Thread Dzmitry Sankouski
Add the core MFD driver for max77705 PMIC. We define five sub-devices for which the drivers will be added in subsequent patches. Signed-off-by: Dzmitry Sankouski --- Changes for V4: - rework driver from scratch - migrate to regmap_add_irq_chip, remove max77705-irq.c, rename max77705-core.c to

[PATCH v4 07/27] drm/panel: Add support for S6E3HA8 panel driver

2024-09-13 Thread Dzmitry Sankouski
Add support for MIPI-DSI based S6E3HA8 AMOLED panel driver. This panel has 1440x2960 resolution, 5.8-inch physical size, and can be found in starqltechn device. Brightness regulation is not yet supported. Signed-off-by: Dzmitry Sankouski Changes in v4: - inline power related functions - rework d

[PATCH v4 08/27] mfd: max77693: remove unused declarations

2024-09-13 Thread Dzmitry Sankouski
Remove `enum max77693_irq_source` declaration because unused. Signed-off-by: Dzmitry Sankouski --- include/linux/mfd/max77693-private.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/include/linux/mfd/max77693-private.h b/include/linux/mfd/max77693-private.h index 20c5e02ed9da.

[PATCH v4 06/27] dt-bindings: mfd: add samsung,s2dos05

2024-09-13 Thread Dzmitry Sankouski
Add samsung,s2dos05 MFD module binding. Signed-off-by: Dzmitry Sankouski --- Changes in v4: - split long(>80) lines - fix indentation - merge with regulators binding - drop pmic suffix - drop unused labels in example - correct description --- .../devicetree/bindings/mfd/samsung,s2dos05.yaml |

[PATCH v4 05/27] dt-bindings: mfd: add maxim,max77705

2024-09-13 Thread Dzmitry Sankouski
Add maxim,max77705 core binding part. Signed-off-by: Dzmitry Sankouski --- Changes in v4: - change dts example intendation from tabs to spaces - remove interrupt-names property - remove obvious reg description - split long(>80) lines --- .../devicetree/bindings/mfd/maxim,max77705.yaml| 169

[PATCH v4 04/27] dt-bindings: panel: add Samsung s6e3ha8

2024-09-13 Thread Dzmitry Sankouski
Add binding for the Samsung s6e3ha8 panel found in the Samsung S9. Signed-off-by: Dzmitry Sankouski --- Changes in v4: - change dts example intendation from tabs to spaces - remove reset-gpios description --- .../bindings/display/panel/samsung,s6e3ha8.yaml| 75 ++ MAINT

[PATCH v4 02/27] clk: qcom: clk-rcg2: name refactoring

2024-09-13 Thread Dzmitry Sankouski
clk-rcg2.c uses 2 variable names for pre divisor register value: pre_div and hid_div. Replace hid_div with pre_div. Update calc_rate docs to reflect, that pre_div is not pure divisor, but a register value, and requires conversion. Signed-off-by: Dzmitry Sankouski --- drivers/clk/qcom/clk-rcg2.c

[PATCH v4 01/27] power: supply: add undervoltage health status property

2024-09-13 Thread Dzmitry Sankouski
Add POWER_SUPPLY_HEALTH_UNDERVOLTAGE status for power supply to report under voltage lockout failures. Signed-off-by: Dzmitry Sankouski --- include/linux/power_supply.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h index 910d407eb

[PATCH v4 00/27] This is continued work on Samsung S9(SM-9600) starqltechn

2024-09-13 Thread Dzmitry Sankouski
Add support for new features: - sound (headphones and mics only) - gpu - panel - buttons - MAX77705 MFD:   - charger   - fuelgauge   - haptic   - led Changes in version 2: - s2dos05 regulator: - hex to decimal in regulator values - fix compatible value - remove interrupt specific code, becau

Re: [PATCH v4 27/28] gcc-sdm845: Add general purpose clock ops

2024-09-13 Thread Dzmitry Sankouski
вт, 10 сент. 2024 г. в 12:59, Uwe Kleine-König : > > Hello, > > On Fri, Jul 19, 2024 at 03:55:04PM +0300, Dzmitry Sankouski wrote: > > SDM845 has "General Purpose" clocks that can be muxed to > > SoC pins to clock various external devices. > > Those clocks may be used as e.g. PWM sources for extern

Re: [PATCH 8/8] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-13 Thread Tvrtko Ursulin
On 10/09/2024 16:03, Christian König wrote: Am 10.09.24 um 11:46 schrieb Tvrtko Ursulin: On 10/09/2024 10:08, Christian König wrote: Am 09.09.24 um 19:19 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Having removed one re-lock cycle on the entity->lock in a patch titled "drm/sched: Optimis

[PATCH] drm/i915/gt: Fixed an typo

2024-09-13 Thread Zhang He
column header should be GPU, not CPU Signed-off-by: Zhang He --- drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c index 8d08b38874ef..b6

Re: [PATCH v3 04/23] dt-bindings: mfd: add maxim,max77705

2024-09-13 Thread Dzmitry Sankouski
чт, 20 июн. 2024 г. в 18:46, Krzysztof Kozlowski : > > On 18/06/2024 15:59, Dzmitry Sankouski wrote: > > maxim,max77705 is MAX77705 pmic binding part > > > > Signed-off-by: Dzmitry Sankouski > > --- > > .../devicetree/bindings/mfd/maxim,max77705.yaml| 112 > > + > > Your p

[PATCH next] drm/tegra: Fix NULL vs IS_ERR() check in probe()

2024-09-13 Thread Dan Carpenter
The iommu_paging_domain_alloc() function doesn't return NULL pointers, it returns error pointers. Update the check to match. Fixes: 45c690aea8ee ("drm/tegra: Use iommu_paging_domain_alloc()") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/tegra/drm.c | 4 ++-- 1 file changed, 2 insertions(+)

Re: [PATCH v7 0/2] arm64: dts: mediatek: Add MT8186 Ponyta

2024-09-13 Thread Rob Herring (Arm)
On Fri, 13 Sep 2024 11:15:03 +0800, Jianeng Ceng wrote: > This is v7 of the MT8186 Chromebook device tree series. > --- > Changes in v7: > - PATCH 2/2: Remove prototype sku. > - PATCH 2/2: Disable the other trackpad to enable one of them. > - Link to > v5:https://lore.kernel.org/all/202409130155

Re: [PATCH] drm/panthor: Lock the VM resv before calling drm_gpuvm_bo_obtain_prealloc()

2024-09-13 Thread Steven Price
On 13/09/2024 12:27, Boris Brezillon wrote: > drm_gpuvm_bo_obtain_prealloc() will call drm_gpuvm_bo_put() on our > pre-allocated BO if the association exists. Given we > only have one ref on preallocated_vm_bo, drm_gpuvm_bo_destroy() will > be called immediately, and we have to hold the VM resv lo

Re: [PATCH v6 5/5] drm/panthor: add sysfs knob for enabling job profiling

2024-09-13 Thread Boris Brezillon
On Fri, 13 Sep 2024 13:42:13 +0100 Adrián Larumbe wrote: > This commit introduces a DRM device sysfs attribute that lets UM control > the job accounting status in the device. The knob variable had been brought > in as part of a previous commit, but now we're able to fix it manually. > > As sysfs

Re: [PATCH v6 3/5] drm/panthor: add DRM fdinfo support

2024-09-13 Thread Boris Brezillon
On Fri, 13 Sep 2024 13:42:11 +0100 Adrián Larumbe wrote: > Drawing from the FW-calculated values in a previous commit, we can increase > the numbers for an open file by collecting them from finished jobs when > updating their group synchronisation objects. > > Display of fdinfo key-value pairs i

Re: [PATCH v6 2/5] drm/panthor: record current and maximum device clock frequencies

2024-09-13 Thread Boris Brezillon
On Fri, 13 Sep 2024 13:42:10 +0100 Adrián Larumbe wrote: > In order to support UM in calculating rates of GPU utilisation, the current > operating and maximum GPU clock frequencies must be recorded during device > initialisation, and also during OPP state transitions. > > Signed-off-by: Adrián L

Re: [PATCH] drm/panthor: Lock the VM resv before calling drm_gpuvm_bo_obtain_prealloc()

2024-09-13 Thread Liviu Dudau
On Fri, Sep 13, 2024 at 01:27:22PM +0200, Boris Brezillon wrote: > drm_gpuvm_bo_obtain_prealloc() will call drm_gpuvm_bo_put() on our > pre-allocated BO if the association exists. Given we > only have one ref on preallocated_vm_bo, drm_gpuvm_bo_destroy() will > be called immediately, and we have t

Re: [PATCH 1/3] drm: add DRM_SET_NAME ioctl

2024-09-13 Thread Tvrtko Ursulin
On 13/09/2024 13:17, Pierre-Eric Pelloux-Prayer wrote: Hi Tvrtko, Le 12/09/2024 à 10:13, Tvrtko Ursulin a écrit : On 11/09/2024 15:58, Pierre-Eric Pelloux-Prayer wrote: Giving the opportunity to userspace to associate a free-form name with a drm_file struct is helpful for tracking and debug

[pull] amdgpu, amdkfd, drm amd-drm-next-6.12

2024-09-13 Thread Alex Deucher
Hi Dave, Simona, A few fixes for 6.12 and the drm dma-buf race fixes from Al Viro. The following changes since commit 7a199557643e993d4e7357860624b8aa5d8f4340: Revert "drm/amdgpu: align pp_power_profile_mode with kernel docs" (2024-09-05 14:27:41 -0400) are available in the Git repository at

Re: [PATCH v2 1/2] drm/sched: memset() 'job' in drm_sched_job_init()

2024-09-13 Thread Tvrtko Ursulin
On 13/09/2024 13:30, Philipp Stanner wrote: On Fri, 2024-09-13 at 12:56 +0100, Tvrtko Ursulin wrote: Hi, On 28/08/2024 10:41, Philipp Stanner wrote: drm_sched_job_init() has no control over how users allocate struct drm_sched_job. Unfortunately, the function can also not set some struct mem

[PATCH v6 5/5] drm/panthor: add sysfs knob for enabling job profiling

2024-09-13 Thread Adrián Larumbe
This commit introduces a DRM device sysfs attribute that lets UM control the job accounting status in the device. The knob variable had been brought in as part of a previous commit, but now we're able to fix it manually. As sysfs files are part of a driver's uAPI, describe its legitimate input val

[PATCH v6 4/5] drm/panthor: enable fdinfo for memory stats

2024-09-13 Thread Adrián Larumbe
Implement drm object's status callback. Also, we consider a PRIME imported BO to be resident if its matching dma_buf has an open attachment, which means its backing storage had already been allocated. Signed-off-by: Adrián Larumbe Reviewed-by: Steven Price Reviewed-by: Liviu Dudau Reviewed-by:

[PATCH v6 3/5] drm/panthor: add DRM fdinfo support

2024-09-13 Thread Adrián Larumbe
Drawing from the FW-calculated values in a previous commit, we can increase the numbers for an open file by collecting them from finished jobs when updating their group synchronisation objects. Display of fdinfo key-value pairs is governed by a bitmask that is by default unset in the present commi

[PATCH v6 2/5] drm/panthor: record current and maximum device clock frequencies

2024-09-13 Thread Adrián Larumbe
In order to support UM in calculating rates of GPU utilisation, the current operating and maximum GPU clock frequencies must be recorded during device initialisation, and also during OPP state transitions. Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/panthor/panthor_devfreq.c | 18 +

[PATCH v6 1/5] drm/panthor: introduce job cycle and timestamp accounting

2024-09-13 Thread Adrián Larumbe
Enable calculations of job submission times in clock cycles and wall time. This is done by expanding the boilerplate command stream when running a job to include instructions that compute said times right before and after a user CS. A separate kernel BO is created per queue to store those values.

[PATCH v6 0/5] Support fdinfo runtime and memory stats on Panthor

2024-09-13 Thread Adrián Larumbe
This patch series enables userspace utilities like gputop and nvtop to query a render context's fdinfo file and figure out rates of engine and memory utilisation. Previous discussion can be found at https://lore.kernel.org/dri-devel/20240903202541.430225-1-adrian.laru...@collabora.com/ Changelog:

Re: [PATCH v2 3/5] phy: qcom: edp: Add support for eDP PHY on SA8775P

2024-09-13 Thread Dmitry Baryshkov
On Fri, Sep 13, 2024 at 04:07:53PM GMT, Soutrik Mukhopadhyay wrote: > Add support for eDP PHY v5 found on the Qualcomm SA8775P platform. > > Signed-off-by: Soutrik Mukhopadhyay > --- > v2: Fixed review comments from Dmitry > - Reused edp_swing_hbr_rbr and edp_swing_hbr2_hbr3 for v5. > > --

Re: [PATCH v2 1/2] drm/sched: memset() 'job' in drm_sched_job_init()

2024-09-13 Thread Philipp Stanner
On Fri, 2024-09-13 at 12:56 +0100, Tvrtko Ursulin wrote: > > Hi, > > On 28/08/2024 10:41, Philipp Stanner wrote: > > drm_sched_job_init() has no control over how users allocate struct > > drm_sched_job. Unfortunately, the function can also not set some > > struct > > members such as job->sched. >

  1   2   >