Re: [RFC PATCH 4/4] dma-buf: heaps: add Linaro restricted dmabuf heap support

2024-09-09 Thread Jens Wiklander
On Wed, Sep 4, 2024 at 11:42 PM T.J. Mercier wrote: > > On Wed, Sep 4, 2024 at 2:44 AM Jens Wiklander > wrote: > > > > On Tue, Sep 3, 2024 at 7:50 PM T.J. Mercier wrote: > > > > > > On Fri, Aug 30, 2024 at 12:04 AM Jens Wiklander > > > wrote: > > > > > > > > Add a Linaro restricted heap using

[PATCH] drm/gma500: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2024-09-09 Thread Tejas Vipin
Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi since monitor HDMI information is available after EDID is parsed. Additionally rewrite the code the code to have fewer indentation levels. Signed-off-by: Tejas Vipin --- drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 18 +

Re: drm-ci: flaky tests for rockchip driver testing

2024-09-09 Thread Vignesh Raman
Hi Maintainers, On 24/07/24 14:22, Vignesh Raman wrote: Hi Maintainers, There are some flaky tests reported for rockchip driver testing in drm-ci. === rockchip rk3288 === # Board Name: rk3288-veyron-jaq # Failure Rate: 100 # IGT Version: 1.28-gf13702b8e # Linux Version: 6.10.0-rc5 kms_cursor_l

Re: drm-ci: flaky tests for msm driver testing

2024-09-09 Thread Vignesh Raman
Hi Maintainers, On 12/07/24 11:35, Vignesh Raman wrote: Hi Maintainers, On 28/05/24 11:39, Vignesh Raman wrote: Hi Maintainers, There are some flaky tests reported for msm driver testing in drm-ci for the below boards. *) # Board Name: apq8096-db820c # IGT Version: 1.28-g0df7b9b97 # Linux

Re: [PATCH net-next v25 10/13] net: add SO_DEVMEM_DONTNEED setsockopt to release RX frags

2024-09-09 Thread Jakub Kicinski
On Mon, 9 Sep 2024 05:43:15 + Mina Almasry wrote: > --- a/include/uapi/linux/uio.h > +++ b/include/uapi/linux/uio.h > @@ -33,6 +33,10 @@ struct dmabuf_cmsg { >*/ > }; > > +struct dmabuf_token { > + __u32 token_start; > + __u32 token_count; > +}; > /*

Re: drm-ci: flaky tests for i915 driver testing

2024-09-09 Thread Vignesh Raman
Hi Maintainers, On 12/07/24 11:22, Vignesh Raman wrote: Hi Maintainers, On 28/05/24 12:07, Vignesh Raman wrote: Hi Maintainers, There are some flaky tests reported for i915 driver testing in drm-ci for the below boards. *) # Board Name: asus-C523NA-A20057-coral # IGT Version: 1.28-g0df7b9b

Re: [PATCH net-next v25 08/13] net: add support for skbs with unreadable frags

2024-09-09 Thread Jakub Kicinski
On Mon, 9 Sep 2024 05:43:13 + Mina Almasry wrote: > For device memory TCP, we expect the skb headers to be available in host > memory for access, and we expect the skb frags to be in device memory > and unaccessible to the host. We expect there to be no mixing and > matching of device memory f

Re: [PATCH net-next v25 06/13] memory-provider: dmabuf devmem memory provider

2024-09-09 Thread Jakub Kicinski
On Mon, 9 Sep 2024 05:43:11 + Mina Almasry wrote: > diff --git a/include/net/netmem.h b/include/net/netmem.h > index 5eccc40df92d..8a6e20be4b9d 100644 > --- a/include/net/netmem.h > +++ b/include/net/netmem.h > @@ -8,6 +8,7 @@ > #ifndef _NET_NETMEM_H > #define _NET_NETMEM_H > > +#include

Re: drm-ci: flaky tests for amdgpu driver testing

2024-09-09 Thread Vignesh Raman
Hi Maintainers, On 28/05/24 10:19, Vignesh Raman wrote: Hi Maintainers, There are some flaky tests reported for amdgpu driver testing in drm-ci. # Board Name: hp-11A-G6-EE-grunt # IGT Version: 1.28-g0df7b9b97 # Linux Version: 6.9.0-rc7 # Failure Rate: 50 kms_async_flips@async-flip-with-page-fl

Re: [PATCH RESEND v2 00/19] random: Resolve circular include dependency and include

2024-09-09 Thread Jason A. Donenfeld
Hi Uros, On Mon, Sep 09, 2024 at 09:30:06PM +0200, Uros Bizjak wrote: > Besides GCC, clang can define various named address space via > address_space attribute: > > --cut here-- > #define __as(N) __attribute__((address_space(N))) > > void *foo(void __as(1) *x) { return x; } // error > >

[PATCH] drm/amdgpu: Fix a typo

2024-09-09 Thread Andrew Kreimer
Fix a typo in comments. Reported-by: Matthew Wilcox Signed-off-by: Andrew Kreimer --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom

Re: [PATCH v4 1/3] drm: Introduce device wedged event

2024-09-09 Thread Matt Roper
On Fri, Sep 06, 2024 at 03:12:23PM +0530, Raag Jadav wrote: > Introduce device wedged event, which will notify userspace of wedged > (hanged/unusable) state of the DRM device through a uevent. This is > useful especially in cases where the device is in unrecoverable state > and requires userspace i

Re: [PATCH V4] i2c: imx-lpi2c: add eDMA mode support for LPI2C

2024-09-09 Thread Andi Shyti
Hi Carlos, Thanks for your patch, sorry for having taken so much time, looks good, just some nitpicks. ... > diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c > b/drivers/i2c/busses/i2c-imx-lpi2c.c > index 976d43f73f38..530ca5d76403 100644 > --- a/drivers/i2c/busses/i2c-imx-lpi2c.c > +++ b/driver

Re: [PATCH 6/7] drm/i915/pmu: Lazy unregister

2024-09-09 Thread Lucas De Marchi
Hi Peter, On Wed, Jul 24, 2024 at 10:39:57AM GMT, Lucas De Marchi wrote: On Wed, Jul 24, 2024 at 02:41:05PM GMT, Peter Zijlstra wrote: On Tue, Jul 23, 2024 at 10:30:08AM -0500, Lucas De Marchi wrote: On Tue, Jul 23, 2024 at 09:03:25AM GMT, Tvrtko Ursulin wrote: On 22/07/2024 22:06, Lucas De

[PATCH] drm/syncobj: Fix syncobj leak in drm_syncobj_eventfd_ioctl

2024-09-09 Thread T.J. Mercier
A syncobj reference is taken in drm_syncobj_find, but not released if eventfd_ctx_fdget or kzalloc fails. Put the reference in these error paths. Reported-by: Xingyu Jin Fixes: c7a472297169 ("drm/syncobj: add IOCTL to register an eventfd") Signed-off-by: T.J. Mercier --- drivers/gpu/drm/drm_syn

Re: [PATCH] drm/xe: fix build warning with CONFIG_PM=n

2024-09-09 Thread Rodrigo Vivi
On Mon, Sep 09, 2024 at 08:25:08PM +, Arnd Bergmann wrote: > From: Arnd Bergmann > > The 'runtime_status' field is an implementation detail of the > power management code, so a device driver should not normally > touch this: > > drivers/gpu/drm/xe/xe_pm.c: In function 'xe_pm_suspending_or_re

Re: [PATCH v4 1/3] drm: Introduce device wedged event

2024-09-09 Thread Rodrigo Vivi
On Sun, Sep 08, 2024 at 11:08:39PM +0900, Asahi Lina wrote: > > > On 9/8/24 12:07 AM, Lucas De Marchi wrote: > > On Sat, Sep 07, 2024 at 08:38:30PM GMT, Asahi Lina wrote: > >> > >> > >> On 9/6/24 6:42 PM, Raag Jadav wrote: > >>> Introduce device wedged event, which will notify userspace of wedged

[PATCH] drm/xe: fix build warning with CONFIG_PM=n

2024-09-09 Thread Arnd Bergmann
From: Arnd Bergmann The 'runtime_status' field is an implementation detail of the power management code, so a device driver should not normally touch this: drivers/gpu/drm/xe/xe_pm.c: In function 'xe_pm_suspending_or_resuming': drivers/gpu/drm/xe/xe_pm.c:606:26: error: 'struct dev_pm_info' has n

Re: [PATCH v4 1/3] drm: Introduce device wedged event

2024-09-09 Thread Lucas De Marchi
On Sun, Sep 08, 2024 at 11:08:39PM GMT, Asahi Lina wrote: On 9/8/24 12:07 AM, Lucas De Marchi wrote: On Sat, Sep 07, 2024 at 08:38:30PM GMT, Asahi Lina wrote: On 9/6/24 6:42 PM, Raag Jadav wrote: Introduce device wedged event, which will notify userspace of wedged (hanged/unusable) state o

Re: [PATCH 0/2] drm/amd: fix VRR race condition during IRQ handling

2024-09-09 Thread Tobias Jakobi
On 9/9/24 19:18, Harry Wentland wrote: On 2024-09-09 13:11, Alex Deucher wrote: On Sun, Sep 8, 2024 at 7:23 AM Tobias Jakobi wrote: On 9/8/24 09:35, Christopher Snowhill wrote: On Mon Sep 2, 2024 at 2:40 AM PDT, tjakobi wrote: From: Tobias Jakobi Hello, this fixes a nasty race conditio

Re: [PATCH RESEND v2 00/19] random: Resolve circular include dependency and include

2024-09-09 Thread Uros Bizjak
On Mon, Sep 9, 2024 at 5:57 PM Jason A. Donenfeld wrote: > On Mon, Sep 09, 2024 at 09:53:43AM +0200, Uros Bizjak wrote: > > a) Substitutes the inclusion of with the > > inclusion of where needed (patches 1 - 17). > > > > b) Removes legacy inclusion of from > > (patch 18). > > > > c) Includes

Re: [PATCH v5 00/44] Color Pipeline API w/ VKMS

2024-09-09 Thread Harry Wentland
On 2024-08-29 10:55, Xaver Hugl wrote: > Hi, > > I have a WIP implementation of this for KWin at > https://invent.kde.org/plasma/kwin/-/commits/work/zamundaaa/drm-colorop. > It maps KWin's color pipeline to the drm one to get (primary plane > only, for now) direct scanout of HDR content on SDR

[Bug 195159] nouveau incorrect ACPI usgage results in ACPI Error : AE_AML_PACKAGE_LIMIT

2024-09-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=195159 Yury Puchalski (p...@aikipooh.name) changed: What|Removed |Added CC||p...@aikipooh.name

Re: [PATCH v4 71/80] drm/vmwgfx: Run DRM default client setup

2024-09-09 Thread Zack Rusin
On Mon, Sep 9, 2024 at 7:37 AM Thomas Zimmermann wrote: > > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: Zack Rusin > Cc:

Re: [PATCH RESEND] drm/amd/display: Add null check before access structs in dcn32_enable_phantom_plane

2024-09-09 Thread Alex Deucher
On Mon, Sep 9, 2024 at 2:48 AM Ma Ke wrote: > > In dcn32_enable_phantom_plane, we should better check null pointer before > accessing various structs. > > Cc: sta...@vger.kernel.org > Fixes: 235c67634230 ("drm/amd/display: add DCN32/321 specific files for > Display Core") > Signed-off-by: Ma Ke

Re: [PATCH v3 04/10] drm/msm/A6xx: Implement preemption for A7XX targets

2024-09-09 Thread Antonino Maniscalco
On 9/9/24 3:15 PM, Antonino Maniscalco wrote: On 9/6/24 9:54 PM, Akhil P Oommen wrote: On Thu, Sep 05, 2024 at 04:51:22PM +0200, Antonino Maniscalco wrote: This patch implements preemption feature for A6xx targets, this allows the GPU to switch to a higher priority ringbuffer if one is ready. A

[PATCH 8/8] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Having removed one re-lock cycle on the entity->lock in a patch titled "drm/sched: Optimise drm_sched_entity_push_job", with only a tiny bit larger refactoring we can do the same optimisation on the rq->lock. (Currently both drm_sched_rq_add_entity() and drm_sched_rq_update_f

[PATCH 1/8] drm/sched: Add locking to drm_sched_entity_modify_sched

2024-09-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Without the locking amdgpu currently can race between amdgpu_ctx_set_entity_priority() (via drm_sched_entity_modify_sched()) and drm_sched_job_arm(), leading to the latter accesing potentially inconsitent entity->sched_list and entity->num_sched_list pair. v2: * Improve com

[PATCH 7/8] drm/sched: Re-group and rename the entity run-queue lock

2024-09-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Christian suggested to rename the lock and improve the documentation of what it protects. And to also re-order the structure members so all protected by the lock are together in a block. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Alex Deucher Cc: Luben Tuikov

[PATCH 6/8] drm/sched: Re-order struct drm_sched_rq members for clarity

2024-09-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Lets re-order the members to make it clear which are protected by the lock and at the same time document it via kerneldoc. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Alex Deucher Cc: Luben Tuikov Cc: Matthew Brost Cc: Philipp Stanner --- include/drm/gpu_sch

[PATCH v2 0/8] DRM scheduler fixes, or not, or incorrect kind

2024-09-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Re-spin of the series from two days ago with review feedback addressed and some new patches added. Changelog is in individual patches but essentially new patches are renames and struct members re-ordering as discussed in v1, plus one more optimisation when I noticed we can s

[PATCH 4/8] drm/sched: Optimise drm_sched_entity_push_job

2024-09-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In FIFO mode We can avoid dropping the lock only to immediately re-acquire by adding a new drm_sched_rq_update_fifo_locked() helper. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Alex Deucher Cc: Luben Tuikov Cc: Matthew Brost Cc: Philipp Stanner --- drivers/g

[PATCH 5/8] drm/sched: Stop setting current entity in FIFO mode

2024-09-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It does not seem there is a need to set the current entity in FIFO mode since ot only serves as being a "cursor" in round-robin mode. Even if scheduling mode is changed at runtime the change in behaviour is simply to restart from the first entity, instead of continuing in RR

[PATCH 2/8] drm/sched: Always wake up correct scheduler in drm_sched_entity_push_job

2024-09-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Since drm_sched_entity_modify_sched() can modify the entities run queue, lets make sure to only dereference the pointer once so both adding and waking up are guaranteed to be consistent. Alternative of moving the spin_unlock to after the wake up would for now be more problem

[PATCH 3/8] drm/sched: Always increment correct scheduler score

2024-09-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Entities run queue can change during drm_sched_entity_push_job() so make sure to update the score consistently. Signed-off-by: Tvrtko Ursulin Fixes: d41a39dda140 ("drm/scheduler: improve job distribution with multiple queues") Cc: Nirmoy Das Cc: Christian König Cc: Luben

Re: [PATCH 0/2] drm/amd: fix VRR race condition during IRQ handling

2024-09-09 Thread Harry Wentland
On 2024-09-09 13:11, Alex Deucher wrote: > On Sun, Sep 8, 2024 at 7:23 AM Tobias Jakobi > wrote: >> >> On 9/8/24 09:35, Christopher Snowhill wrote: >> >>> On Mon Sep 2, 2024 at 2:40 AM PDT, tjakobi wrote: From: Tobias Jakobi Hello, this fixes a nasty race condition in

[PATCH v4] drm/edid: add CTA Video Format Data Block support

2024-09-09 Thread Hamza Mahfooz
Video Format Data Blocks (VFDBs) contain the necessary information that needs to be fed to the Optimized Video Timings (OVT) Algorithm. Also, we require OVT support to cover modes that aren't supported by earlier standards (e.g. CVT). So, parse all of the relevant VFDB data and feed it to the OVT A

Re: [PATCH 0/2] drm/amd: fix VRR race condition during IRQ handling

2024-09-09 Thread Alex Deucher
On Sun, Sep 8, 2024 at 7:23 AM Tobias Jakobi wrote: > > On 9/8/24 09:35, Christopher Snowhill wrote: > > > On Mon Sep 2, 2024 at 2:40 AM PDT, tjakobi wrote: > >> From: Tobias Jakobi > >> > >> Hello, > >> > >> this fixes a nasty race condition in the set_drr() callbacks for DCN10 > >> and DCN35 th

Re: [RFC 1/2] drm/amdgpu: Remove dynamic DRM scheduling priority override

2024-09-09 Thread Alex Deucher
On Mon, Sep 9, 2024 at 8:23 AM Christian König wrote: > > Adding Leo as well. > > Am 06.09.24 um 20:06 schrieb Tvrtko Ursulin: > > From: Tvrtko Ursulin > > > > According to Christian the dynamic DRM priority override was only > > interesting before the hardware priority (dona via > > drm_sched_en

Re: [PATCH net-next v25 00/13] Device Memory TCP

2024-09-09 Thread Mina Almasry
On Mon, Sep 9, 2024 at 4:21 AM Yunsheng Lin wrote: > > On 2024/9/9 13:43, Mina Almasry wrote: > > > > > Perf - page-pool benchmark: > > --- > > > > bench_page_pool_simple.ko tests with and without these changes: > > https://pastebin.com/raw/ncHDwAbn > > > > AFAIK the number

Re: [PATCH v1] drm/xe: Use ERR_CAST to return an error-valued pointer

2024-09-09 Thread Matthew Brost
On Fri, Sep 06, 2024 at 03:01:09PM +0800, Yu Jiaoliang wrote: > Instead of directly casting and returning an error-valued pointer, > use ERR_CAST to make the error handling more explicit and improve > code clarity. > > Signed-off-by: Yu Jiaoliang Reviewed-by: Matthew Brost > --- > drivers/gpu

Re: [RFC 0/4] DRM scheduler fixes, or not, or incorrect kind

2024-09-09 Thread Matthew Brost
On Fri, Sep 06, 2024 at 07:06:14PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > In a recent conversation with Christian there was a thought that > drm_sched_entity_modify_sched() should start using the entity->rq_lock to be > safe against job submission and simultaneous priority change

RE: [REGRESSION] soft lockup on boot starting with kernel 6.10 / commit 5186ba33234c9a90833f7c93ce7de80e25fac6f5

2024-09-09 Thread Luck, Tony
> I have discovered a 100% reliable soft lockup on boot on my laptop: > Purism Librem 14, Intel Core i7-10710U, 48Gb RAM, Samsung Evo Plus 970 > SSD, CoreBoot BIOS, grub bootloader, Arch Linux. > > The last working release is kernel 6.9.10, every release from 6.10 > onwards reliably exhibit the is

Re: [PATCH RESEND v2 00/19] random: Resolve circular include dependency and include

2024-09-09 Thread Jason A. Donenfeld
Hi Uros, On Mon, Sep 09, 2024 at 09:53:43AM +0200, Uros Bizjak wrote: > a) Substitutes the inclusion of with the > inclusion of where needed (patches 1 - 17). > > b) Removes legacy inclusion of from > (patch 18). > > c) Includes in (patch 19). Thanks for doing this. That seems like a fin

Re: [PATCH v5 0/2] arm64: dts: mediatek: Add MT8186 Ponyta

2024-09-09 Thread Rob Herring (Arm)
On Mon, 09 Sep 2024 10:31:46 +0800, Jianeng Ceng wrote: > This is v5 of the MT8186 Chromebook device tree series. > --- > Changes in v5: > - PATCH 1/2: Remove sku2147483647. > - PATCH 2/2: Remove sku2147483647. > - Link to > v4:https://lore.kernel.org/all/20240906085739.1322676-1-cengjian...@hua

Re: [PATCH v3 00/10] Preemption support for A7XX

2024-09-09 Thread Rob Clark
On Fri, Sep 6, 2024 at 12:59 PM Akhil P Oommen wrote: > > On Thu, Sep 05, 2024 at 04:51:18PM +0200, Antonino Maniscalco wrote: > > This series implements preemption for A7XX targets, which allows the GPU to > > switch to an higher priority ring when work is pushed to it, reducing > > latency > >

Re: [PATCH v6 1/3] drm/bridge: synopsys: Add DW HDMI QP TX Controller support library

2024-09-09 Thread Maxime Ripard
Hi, On Fri, Sep 06, 2024 at 04:17:40AM GMT, Cristian Ciocaltea wrote: > +static enum drm_connector_status > +dw_hdmi_qp_bridge_detect(struct drm_bridge *bridge) > +{ > + struct dw_hdmi_qp *hdmi = bridge->driver_private; > + enum drm_connector_status status; > + > + status = hdmi->phy.o

Re: [PATCH v2 02/10] drm: bridge: dw_hdmi: Only notify connected status on HPD interrupt

2024-09-09 Thread Jonas Karlman
Hi Neil, On 2024-09-09 15:16, Neil Armstrong wrote: > On 08/09/2024 15:28, Jonas Karlman wrote: >> drm_helper_hpd_irq_event() and drm_bridge_hpd_notify() may incorrectly >> be called with a connected status when HPD is high and RX sense is >> changed. This typically happen when the HDMI cable is u

Re: [PATCH v3 07/10] drm/msm/A6xx: Add traces for preemption

2024-09-09 Thread Antonino Maniscalco
On 9/6/24 10:11 PM, Akhil P Oommen wrote: On Thu, Sep 05, 2024 at 04:51:25PM +0200, Antonino Maniscalco wrote: Add trace points corresponding to preemption being triggered and being completed for latency measurement purposes. Signed-off-by: Antonino Maniscalco Tested-by: Neil Armstrong # on S

Re: [PATCH v3 06/10] drm/msm/A6xx: Use posamble to reset counters on preemption

2024-09-09 Thread Antonino Maniscalco
On 9/6/24 10:08 PM, Akhil P Oommen wrote: On Thu, Sep 05, 2024 at 04:51:24PM +0200, Antonino Maniscalco wrote: Use the postamble to reset perf counters when switching between rings, except when sysprof is enabled, analogously to how they are reset between submissions when switching pagetables.

Re: [PATCH v5 2/2] arm64: dts: mediatek: Add MT8186 Ponyta Chromebooks

2024-09-09 Thread AngeloGioacchino Del Regno
Il 09/09/24 04:31, Jianeng Ceng ha scritto: MT8186 ponyta, known as huaqin custom label, is a MT8186 based laptop. It is based on the "corsola" design. It includes LTE, touchpad combinations. Signed-off-by: Jianeng Ceng --- Changes in v5: - PATCH 2/2: Remove sku2147483647. - Link to v4:https:/

Re: [PATCH v2] drm/panthor: Display FW version information

2024-09-09 Thread Boris Brezillon
Hi Thomas, On Mon, 9 Sep 2024 16:14:32 +0200 Thomas Zimmermann wrote: > Hi > > Am 06.09.24 um 11:40 schrieb Steven Price: > > The version number output when loading the firmware is actually the > > interface version not the version of the firmware itself. Update the > > message to make this cle

[PATCH] drm/dp_mst: Fix DSC decompression detection in Synaptics branch devices

2024-09-09 Thread Imre Deak
Atm it's assumed that all Synaptics MST branch devices support DSC, which is not exposed via a DP-to-DP peer device, rather a control flag in the branch device's UFP DPCD applying to all the streams going through it. This isn't true for all adapters with this branch device though (for instance the

Re: [PATCH v3 04/10] drm/msm/A6xx: Implement preemption for A7XX targets

2024-09-09 Thread Rob Clark
On Mon, Sep 9, 2024 at 6:43 AM Connor Abbott wrote: > > On Mon, Sep 9, 2024 at 2:15 PM Antonino Maniscalco > wrote: > > > > On 9/6/24 9:54 PM, Akhil P Oommen wrote: > > > On Thu, Sep 05, 2024 at 04:51:22PM +0200, Antonino Maniscalco wrote: > > >> This patch implements preemption feature for A6xx

Re: Time for drm-ci-next?

2024-09-09 Thread Rob Clark
On Mon, Sep 9, 2024 at 2:54 AM Dmitry Baryshkov wrote: > > On Mon, 9 Sept 2024 at 10:50, Maxime Ripard wrote: > > > > Hi, > > > > On Tue, Jul 09, 2024 at 01:27:51AM GMT, Dmitry Baryshkov wrote: > > > On Mon, 8 Jul 2024 at 21:38, Rob Clark wrote: > > > > > > > > On Mon, Jul 8, 2024 at 1:52 AM Dan

Re: [PATCH v2] drm/panthor: Display FW version information

2024-09-09 Thread Thomas Zimmermann
Hi Am 06.09.24 um 11:40 schrieb Steven Price: The version number output when loading the firmware is actually the interface version not the version of the firmware itself. Update the message to make this clearer. However, the firmware binary has a git SHA embedded into it which can be used to i

Re: [PATCH v2] drm/panthor: Display FW version information

2024-09-09 Thread Carsten Haitzler
+1 I like the interface ver. :) On 9/6/24 10:40 AM, Steven Price wrote: The version number output when loading the firmware is actually the interface version not the version of the firmware itself. Update the message to make this clearer. However, the firmware binary has a git SHA embedded int

Re: [PATCH] drm/panthor: Display FW version information

2024-09-09 Thread Carsten Haitzler
On 9/5/24 10:08 PM, Liviu Dudau wrote: On Thu, Sep 05, 2024 at 06:45:28PM +0200, Boris Brezillon wrote: On Thu, 5 Sep 2024 16:51:44 +0100 Steven Price wrote: The firmware binary has a git SHA embedded into it which can be used to identify which firmware binary is being loaded. Output this

[PATCH] accel/ivpu: Fix a typo

2024-09-09 Thread Andrew Kreimer
Fix a typo in comments. Reported-by: Matthew Wilcox Signed-off-by: Andrew Kreimer --- drivers/accel/ivpu/vpu_boot_api.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/accel/ivpu/vpu_boot_api.h b/drivers/accel/ivpu/vpu_boot_api.h index 82954b91b748..d474bc7b15c0 100

Re: [PATCH v2 1/3] drm/nouveau/tegra: Use iommu_paging_domain_alloc()

2024-09-09 Thread Jason Gunthorpe
On Thu, Sep 05, 2024 at 12:26:31PM -0400, Lyude Paul wrote: > I did take the one patch - but I'm happy to push the others to drm-misc > (provided they all get reviewed. 2/3 seems to be reviewed already but not 3/3) The whole series is acked now, can you pick it up please? Thanks, Jason

Re: [PATCH v2 1/3] drm/nouveau/tegra: Use iommu_paging_domain_alloc()

2024-09-09 Thread Thierry Reding
On Mon, Sep 02, 2024 at 09:46:58AM GMT, Lu Baolu wrote: > In nvkm_device_tegra_probe_iommu(), a paging domain is allocated for @dev > and attached to it on success. Use iommu_paging_domain_alloc() to make it > explicit. > > Signed-off-by: Lu Baolu > --- > drivers/gpu/drm/nouveau/nvkm/engine/devi

Re: [RFC 1/4] drm/sched: Add locking to drm_sched_entity_modify_sched

2024-09-09 Thread Christian König
Am 09.09.24 um 15:27 schrieb Tvrtko Ursulin: On 09/09/2024 13:46, Philipp Stanner wrote: On Mon, 2024-09-09 at 13:37 +0100, Tvrtko Ursulin wrote: [SNIP] That could also be a great opportunity for improving the lock naming: Well that comment made me laugh because I point out the same when th

Re: [PATCH v2 3/3] drm/tegra: Use iommu_paging_domain_alloc()

2024-09-09 Thread Thierry Reding
On Mon, Sep 02, 2024 at 09:47:00AM GMT, Lu Baolu wrote: > Commit <17de3f5fdd35> ("iommu: Retire bus ops") removes iommu ops from > the bus structure. The iommu subsystem no longer relies on bus for > operations. So iommu_domain_alloc() interface is no longer relevant. > > Replace iommu_domain_allo

Re: [PATCH v3 04/10] drm/msm/A6xx: Implement preemption for A7XX targets

2024-09-09 Thread Connor Abbott
On Mon, Sep 9, 2024 at 2:15 PM Antonino Maniscalco wrote: > > On 9/6/24 9:54 PM, Akhil P Oommen wrote: > > On Thu, Sep 05, 2024 at 04:51:22PM +0200, Antonino Maniscalco wrote: > >> This patch implements preemption feature for A6xx targets, this allows > >> the GPU to switch to a higher priority ri

Re: [RFC 1/4] drm/sched: Add locking to drm_sched_entity_modify_sched

2024-09-09 Thread Philipp Stanner
On Mon, 2024-09-09 at 14:27 +0100, Tvrtko Ursulin wrote: > > On 09/09/2024 13:46, Philipp Stanner wrote: > > On Mon, 2024-09-09 at 13:37 +0100, Tvrtko Ursulin wrote: > > > > > > On 09/09/2024 13:18, Christian König wrote: > > > > Am 09.09.24 um 14:13 schrieb Philipp Stanner: > > > > > On Mon, 202

Re: [RFC PATCH] drm: allow encoder mode_set even when connectors change for crtc

2024-09-09 Thread Maxime Ripard
Hi, On Thu, Sep 05, 2024 at 03:11:24PM GMT, Abhinav Kumar wrote: > In certain use-cases, a CRTC could switch between two encoders > and because the mode being programmed on the CRTC remains > the same during this switch, the CRTC's mode_changed remains false. > In such cases, the encoder's mode_se

Re: [RFC 1/4] drm/sched: Add locking to drm_sched_entity_modify_sched

2024-09-09 Thread Tvrtko Ursulin
On 09/09/2024 13:46, Philipp Stanner wrote: On Mon, 2024-09-09 at 13:37 +0100, Tvrtko Ursulin wrote: On 09/09/2024 13:18, Christian König wrote: Am 09.09.24 um 14:13 schrieb Philipp Stanner: On Mon, 2024-09-09 at 13:29 +0200, Christian König wrote: Am 09.09.24 um 11:44 schrieb Philipp Stan

Re: [PATCH v2 0/5] Add support for GE SUNH hot-pluggable connector (was: "drm: add support for hot-pluggable bridges")

2024-09-09 Thread Luca Ceresoli
Hello Sima, again thanks for your feedback, and again I'm afraid I'm having a hard time in understanding large parts of your e-mail. Below I'm trying to focus on one fundamental aspect only, which I need to understand the overall approach you are suggesting. On Tue, 27 Aug 2024 18:37:12 +0200 Dan

Re: [PATCH] drm/bochs: use ioremap_wc() to map framebuffer during driver probing

2024-09-09 Thread Yan Zhao
On Mon, Sep 09, 2024 at 08:40:30AM +0200, Thomas Zimmermann wrote: > Hi > > Am 09.09.24 um 07:15 schrieb Yan Zhao: > > Use ioremap_wc() instead of ioremap() to map framebuffer during driver > > probing phase. > > > > Using ioremap() results in a VA being mapped with PAT=UC-. Additionally, > > on

[PATCH v2] drm/bochs: use devm_ioremap_wc() to map framebuffer

2024-09-09 Thread Yan Zhao
Opt for devm_ioremap_wc() over devm_ioremap() when mapping the framebuffer. Using devm_ioremap() results in the VA being mapped with PAT=UC-, which considerably slows down drm_fb_memcpy(). In contrast, devm_ioremap_wc() maps the VA with PAT set to WC, leading to better performance on platforms whe

Re: [PATCH v2 02/10] drm: bridge: dw_hdmi: Only notify connected status on HPD interrupt

2024-09-09 Thread Neil Armstrong
On 08/09/2024 15:28, Jonas Karlman wrote: drm_helper_hpd_irq_event() and drm_bridge_hpd_notify() may incorrectly be called with a connected status when HPD is high and RX sense is changed. This typically happen when the HDMI cable is unplugged, shortly before the HPD is changed to low. Fix this

Re: [PATCH v3 04/10] drm/msm/A6xx: Implement preemption for A7XX targets

2024-09-09 Thread Antonino Maniscalco
On 9/6/24 9:54 PM, Akhil P Oommen wrote: On Thu, Sep 05, 2024 at 04:51:22PM +0200, Antonino Maniscalco wrote: This patch implements preemption feature for A6xx targets, this allows the GPU to switch to a higher priority ringbuffer if one is ready. A6XX hardware as such supports multiple levels o

Re: [PATCH v2 01/10] drm: bridge: dw_hdmi: Disable scrambler feature when not supported

2024-09-09 Thread Neil Armstrong
On 08/09/2024 15:28, Jonas Karlman wrote: The scrambler feature can be left enabled when hotplugging from a sink and mode that require scrambling to a sink that does not support SCDC or scrambling. Typically a blank screen or 'no signal' message can be observed after using a HDMI 2.0 4K@60Hz mod

Re: [PATCH] drm/panel: khadas-ts050: make ts050[v2]_panel_data static

2024-09-09 Thread Neil Armstrong
On 08/09/2024 15:35, Min-Hua Chen wrote: make ts050_panel_data and ts050v2_panel_data static because they are only used in drivers/gpu/drm/panel/panel-khadas-ts050.c, and fix the following sparse warnings: drivers/gpu/drm/panel/panel-khadas-ts050.c:620:32: sparse: warning: symbol 'ts050_panel_da

Re: [PATCH RESEND v2 16/19] lib/test_scanf: Include instead of

2024-09-09 Thread Petr Mladek
On Mon 2024-09-09 09:53:59, Uros Bizjak wrote: > Substitute the inclusion of header with > to allow the removal of legacy inclusion > of from . > > Signed-off-by: Uros Bizjak I have just acked v1 and missed that there already is v2. Just for record: Acked-by: Petr Mladek Best Regards, Petr

Re: [RFC 1/4] drm/sched: Add locking to drm_sched_entity_modify_sched

2024-09-09 Thread Philipp Stanner
On Mon, 2024-09-09 at 13:37 +0100, Tvrtko Ursulin wrote: > > On 09/09/2024 13:18, Christian König wrote: > > Am 09.09.24 um 14:13 schrieb Philipp Stanner: > > > On Mon, 2024-09-09 at 13:29 +0200, Christian König wrote: > > > > Am 09.09.24 um 11:44 schrieb Philipp Stanner: > > > > > On Fri, 2024-09

Re: [RFC 1/4] drm/sched: Add locking to drm_sched_entity_modify_sched

2024-09-09 Thread Tvrtko Ursulin
On 09/09/2024 13:18, Christian König wrote: Am 09.09.24 um 14:13 schrieb Philipp Stanner: On Mon, 2024-09-09 at 13:29 +0200, Christian König wrote: Am 09.09.24 um 11:44 schrieb Philipp Stanner: On Fri, 2024-09-06 at 19:06 +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Without the locki

Re: [RFC 3/4] drm/sched: Always increment correct scheduler score

2024-09-09 Thread Nirmoy Das
On 9/6/2024 8:06 PM, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Entities run queue can change during drm_sched_entity_push_job() so make > sure to update the score consistently. > > Signed-off-by: Tvrtko Ursulin > Fixes: d41a39dda140 ("drm/scheduler: improve job distribution with multiple

Re: [RFC 1/2] drm/amdgpu: Remove dynamic DRM scheduling priority override

2024-09-09 Thread Christian König
Adding Leo as well. Am 06.09.24 um 20:06 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin According to Christian the dynamic DRM priority override was only interesting before the hardware priority (dona via drm_sched_entity_modify_sched()) existed. Furthermore, both overrides also only work somewh

Re: [PATCH v3 04/10] drm/msm/A6xx: Implement preemption for A7XX targets

2024-09-09 Thread Connor Abbott
On Fri, Sep 6, 2024 at 9:03 PM Akhil P Oommen wrote: > > On Thu, Sep 05, 2024 at 04:51:22PM +0200, Antonino Maniscalco wrote: > > This patch implements preemption feature for A6xx targets, this allows > > the GPU to switch to a higher priority ringbuffer if one is ready. A6XX > > hardware as such

Re: [RFC 1/4] drm/sched: Add locking to drm_sched_entity_modify_sched

2024-09-09 Thread Christian König
Am 09.09.24 um 14:13 schrieb Philipp Stanner: On Mon, 2024-09-09 at 13:29 +0200, Christian König wrote: Am 09.09.24 um 11:44 schrieb Philipp Stanner: On Fri, 2024-09-06 at 19:06 +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Without the locking amdgpu currently can race amdgpu_ctx_set_ent

Re: [RFC 1/4] drm/sched: Add locking to drm_sched_entity_modify_sched

2024-09-09 Thread Philipp Stanner
On Mon, 2024-09-09 at 13:29 +0200, Christian König wrote: > Am 09.09.24 um 11:44 schrieb Philipp Stanner: > > On Fri, 2024-09-06 at 19:06 +0100, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > Without the locking amdgpu currently can race > > > amdgpu_ctx_set_entity_priority() and dr

Re: [PATCH] drm/msm: allow returning NULL from crete_address_space

2024-09-09 Thread Dmitry Baryshkov
On Mon, 9 Sept 2024 at 14:29, Konrad Dybcio wrote: > > On 9.09.2024 1:25 PM, Dmitry Baryshkov wrote: > > On Mon, 9 Sept 2024 at 13:34, Konrad Dybcio wrote: > >> > >> On 8.09.2024 7:59 PM, Dmitry Baryshkov wrote: > >>> Under some circumstance > >> > >> Under what circumstances? > >> > >> This bran

Re: [PATCH v2 3/3] drm/nouveau: Add drm_panic support for nv50+

2024-09-09 Thread kernel test robot
: e8653e63e834e4c7de60b81b8b24deb7bdd3bf56 patch link: https://lore.kernel.org/r/20240906100434.1171093-4-jfalempe%40redhat.com patch subject: [PATCH v2 3/3] drm/nouveau: Add drm_panic support for nv50+ config: x86_64-randconfig-121-20240909 (https://download.01.org/0day-ci/archive/20240909/202409091805.3pzxoay6

Re: [PATCH RESEND v2 05/19] media: vivid: Include in vivid-vid-cap.c

2024-09-09 Thread Hans Verkuil
On 09/09/2024 09:53, Uros Bizjak wrote: > Substitute the inclusion of header with > to allow the removal of legacy inclusion > of from . > > Signed-off-by: Uros Bizjak Acked-by: Hans Verkuil Regards, Hans > Cc: Hans Verkuil > Cc: Mauro Carvalho Chehab > Cc: linux-me...@vger.kern

Re: [PATCH net-next v25 00/13] Device Memory TCP

2024-09-09 Thread Yunsheng Lin
On 2024/9/9 13:43, Mina Almasry wrote: > > Perf - page-pool benchmark: > --- > > bench_page_pool_simple.ko tests with and without these changes: > https://pastebin.com/raw/ncHDwAbn > > AFAIK the number that really matters in the perf tests is the > 'tasklet_page_pool01_f

[PATCH v4 77/80] drm/radeon: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbde

[PATCH v4 80/80] drm/omapdrm: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbde

[PATCH v4 72/80] drm/fbdev-ttm: Remove obsolete setup function

2024-09-09 Thread Thomas Zimmermann
The old setup function drm_fbdev_ttm_setup() is unused. Remove it and its internal callbacks. New drivers should call drm_client_setup() instead. Signed-off-by: Thomas Zimmermann Acked-by: Javier Martinez Canillas --- drivers/gpu/drm/drm_fbdev_ttm.c | 119 inclu

[PATCH v4 75/80] drm/gma500: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbde

[PATCH v4 46/80] drm/vc4: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup_with_fourcc() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. v2: - use drm_client_setup_with_fourcc() Signed-off-by: Thomas Zimmermann Cc: Maxime Ripard Cc: Dave Stevenson

[PATCH v4 73/80] drm/armada: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbde

[PATCH v4 71/80] drm/vmwgfx: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Zack Rusin Cc: Broadcom internal kernel review list Acked-by: Javier Martinez Canillas

[PATCH v4 78/80] drm/tegra: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbde

[PATCH v4 43/80] drm/st7586: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: David Lechner Acked-by: David Lechner --- drivers/gpu/drm/tiny/st7586.c | 4 +++- 1 f

[PATCH v4 62/80] drm/vkms: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Rodrigo Siqueira Cc: Melissa Wen Cc: "Maíra Canal" Cc: Haneen Mohammed Acked-by: Jav

[PATCH v4 63/80] drm/fbdev-shmem: Remove obsolete setup function

2024-09-09 Thread Thomas Zimmermann
The old setup function drm_fbdev_shmem_setup() is unused. Remove it and its internal callbacks. New drivers should call drm_client_setup() instead. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/drm_fbdev_shmem.c | 120 +-

[PATCH v4 64/80] drm/fbdev-ttm: Support struct drm_driver.fbdev_probe

2024-09-09 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and reimplement the old fb_probe callback on top of it. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. This change allows the common fbdev client to run on top of TTM-

[PATCH v4 76/80] drm/msm: Run DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbde

[PATCH v4 57/80] drm/ofdrm: Use DRM default client setup

2024-09-09 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Thomas Zimmermann Cc: Javier Martinez Canillas Reviewed-by: Javier Martinez Canillas

  1   2   3   >