[PATCH 1/3] drm/xe: use devm_add_action_or_reset() helper

2024-09-06 Thread He Lugang
Use devm_add_action_or_reset() to release resources in case of failure, because the cleanup function will be automatically called. Signed-off-by: He Lugang --- drivers/gpu/drm/xe/xe_gt_freq.c | 2 +- drivers/gpu/drm/xe/xe_gt_sysfs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 1/3] drm/xe: use devm_add_action_or_reset() helper

2024-09-06 Thread He Lugang
Use devm_add_action_or_reset() to release resources in case of failure, because the cleanup function will be automatically called. Signed-off-by: He Lugang --- drivers/gpu/drm/xe/xe_gt_freq.c | 2 +- drivers/gpu/drm/xe/xe_gt_sysfs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

[PATCH for-next] drm/ttm: make ttm_swap_ops static

2024-09-06 Thread Min-Hua Chen
make ttm_swap_ops static to fix the following sparse warning: drivers/gpu/drm/ttm/ttm_bo.c:1142:31: sparse: warning: symbol 'ttm_swap_ops' was not declared. Should it be static? Fixes: 10efe34dae79 ("drm/ttm: Use the LRU walker helper for swapping") Signed-off-by: Min-Hua Chen --- drivers/gpu/d

Re: [PATCH] drm/rockchip: include rockchip_drm_drv.h

2024-09-06 Thread Min-Hua Chen
>FWIW: I didn't see it either, but I assumed I was missing the right >context (i.e. patches) needed to trigger that warning. > FYI I triggered the warning by the following step: install 'sparse' first git clone https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git cd linux ARCH=arm6

Re: [GIT PULL FOR v6.12] Miscellaneous small fixes for Renesas DRM drivers

2024-09-06 Thread Laurent Pinchart
Did this one fall through the cracks ? :-( On Fri, Aug 23, 2024 at 02:44:45AM +0300, Laurent Pinchart wrote: > Hello Dave, Sima, > > The following changes since commit 11df68c265460d4dff5d19a1313f0fff69470f98: > > Merge tag 'drm-misc-next-2024-08-16' of > https://gitlab.freedesktop.org/drm/mi

Re: [PATCH v4] rockchip/drm: vop2: add support for gamma LUT

2024-09-06 Thread Piotr Zalewski
Hi Daniel, Can you comment on or review this? This version of the patch was based on your suggestions and it has been stuck for some time now. I appreciate your time and help :) Best Regards, Piotr Zalewski On Thursday, August 15th, 2024 at 2:46 PM, Piotr Zalewski wrote: > Add support for ga

Re: [PATCH v2] drm/panthor: Display FW version information

2024-09-06 Thread Healy, Christopher
This looks good on a G310 based platform with older FW from Mali DDK and Panthor driver. Output looks as follows: [5.896994] panthor 1300.mali: [drm] Firmware git sha: b40270ac2191466fde1901ca0fbe8953dbf1d85c On 9/6/24, 2:40 AM, "Steven Price" mailto:steven.pr...@arm.com>> wrote: Th

Re:[PATCH] drm/rockchip: include rockchip_drm_drv.h

2024-09-06 Thread Min-Hua Chen
Hi, >Hi Min Hua, > Thanks for your work > >At 2024-09-06 06:38:50, "Min-Hua Chen" wrote: >>Include rockchip_drm_drv.h to fix the follow sparse warning: >> >>drivers/gpu/drm/rockchip/rockchip_vop2_reg.c:502:24: sparse: >>warning: symbol 'vop2_platform_driver' was not declared. >>Should it be st

[PATCH] drm/i915/cx0: Use one lane to set power state to ready in DP alt mode

2024-09-06 Thread Vamsi Krishna Brahmajosyula
In DP alt mode one lane is owned by display and the other by usb intel_cx0pll_enable currently performs a power cycle ready on both the lanes in all cases. Address the todo to perfom power state ready only on the display lane when DP alt mode is enabled. Tested on Meteor Lake-P [Intel Arc Graphic

[PATCH] accel/qaic: Fix a typo

2024-09-06 Thread Andrew Kreimer
Fix a typo in documentation. Signed-off-by: Andrew Kreimer --- Documentation/accel/qaic/qaic.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/accel/qaic/qaic.rst b/Documentation/accel/qaic/qaic.rst index efb7771273bb..628bf2f7a416 100644 --- a/Documentation/

Re: [PATCH v4 18/18] platform/chrome: cros_ec_typec: Handle lack of HPD information

2024-09-06 Thread Stephen Boyd
Quoting Tzung-Bi Shih (2024-09-06 01:18:21) > On Wed, Sep 04, 2024 at 02:45:36PM -0700, Stephen Boyd wrote: > > Quoting Tzung-Bi Shih (2024-09-04 02:36:45) > > > On Sat, Aug 31, 2024 at 09:06:56PM -0700, Stephen Boyd wrote: > > > > + /* Inject HPD from the GPIO state if EC firmware is broken. *

[PATCH v3] drm/edid: add CTA Video Format Data Block support

2024-09-06 Thread Hamza Mahfooz
Video Format Data Blocks (VFDBs) contain the necessary information that needs to be fed to the Optimized Video Timings (OVT) Algorithm. Also, we require OVT support to cover modes that aren't supported by earlier standards (e.g. CVT). So, parse all of the relevant VFDB data and feed it to the OVT A

Re: [PATCH] drm/panel: samsung-s6e3fa7: transition to mipi_dsi wrapped functions

2024-09-06 Thread Jessica Zhang
On 9/2/2024 12:10 AM, Tejas Vipin wrote: Changes the samsung-s6e3fa7 panel to use multi style functions for improved error handling. Signed-off-by: Tejas Vipin Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-samsung-s6e3fa7.c | 71 ++- 1 file changed, 21 in

Re: [PATCH v2] drm/panel: hx83112a: Transition to wrapped mipi_dsi functions

2024-09-06 Thread Jessica Zhang
On 9/3/2024 10:31 AM, Abhishek Tamboli wrote: Transition to mipi_dsi_dcs_write_seq_multi() macros for initialization sequences. The previous mipi_dsi_dcs_write_seq() macros were non-intuitive and use other wrapped MIPI DSI functions in the driver code to simplify the code pattern. Reported-by

Re: [PATCH] drm/panel: himax-hx83112a: transition to mipi_dsi wrapped functions

2024-09-06 Thread Jessica Zhang
On 9/6/2024 3:14 PM, Jessica Zhang wrote: On 9/4/2024 7:15 AM, Tejas Vipin wrote: Changes the himax-hx83112a panel to use multi style functions for improved error handling. Signed-off-by: Tejas Vipin Reviewed-by: Jessica Zhang Hi Tejas, Just a heads up, it seems that this might be a

Re: [PATCH] drm/panel: himax-hx83112a: transition to mipi_dsi wrapped functions

2024-09-06 Thread Jessica Zhang
On 9/4/2024 7:15 AM, Tejas Vipin wrote: Changes the himax-hx83112a panel to use multi style functions for improved error handling. Signed-off-by: Tejas Vipin Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-himax-hx83112a.c | 297 +-- 1 file changed, 136 ins

Re: [PATCH] drm/panel: nt35510: Make new commands optional

2024-09-06 Thread Jessica Zhang
T35510_CMD_BT3CTR | NT35510_CMD_SETVCMOFF, /* 0x03: AVDD = 6.2V */ .avdd = { 0x03, 0x03, 0x03 }, /* 0x46: PCK = 2 x Hsync, BTP = 2.5 x VDDB */ --- base-commit: 8400291e289ee6b2bf9779ff1c83a291501f017b change-id: 20240906-fix-nt35510-a8ec6e47e036 Best regards, -- Linus Walleij

[PATCH] drm/panel: nt35510: Make new commands optional

2024-09-06 Thread Linus Walleij
.2V */ .avdd = { 0x03, 0x03, 0x03 }, /* 0x46: PCK = 2 x Hsync, BTP = 2.5 x VDDB */ --- base-commit: 8400291e289ee6b2bf9779ff1c83a291501f017b change-id: 20240906-fix-nt35510-a8ec6e47e036 Best regards, -- Linus Walleij

Re: [PATCH v4 1/2] dt-bindings: arm: mediatek: Add MT8186 Ponyta Chromebook

2024-09-06 Thread Hsin-Yi Wang
On Fri, Sep 6, 2024 at 1:57 AM Jianeng Ceng wrote: > > Ponyta is a custom label Chromebook based on MT8186. It is a > self-developed project of Huaqin and has no fixed OEM. > > Signed-off-by: Jianeng Ceng > --- > Changes in v4: > - PATCH 1/2: Add more info for Ponyta custom label in commit. > - L

[pull] amdgpu, amdkfd drm-next-6.12

2024-09-06 Thread Alex Deucher
Hi Dave, Simona, Updates for 6.12. The following changes since commit e55ef65510a401862b902dc979441ea10ae25c61: Merge tag 'amd-drm-next-6.12-2024-08-26' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2024-08-27 14:33:12 +0200) are available in the Git repository at: https:/

Re: (subset) [PATCH v7 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-09-06 Thread Mark Brown
On Fri, Sep 06, 2024 at 12:23:23PM -0700, Nathan Chancellor wrote: > On Fri, Sep 06, 2024 at 07:27:01PM +0100, Mark Brown wrote: > > Are these just warnings introduced by recent versions of the toolchains? > > These commits passed an x86 allmodconfig with GCC 12 at each step (I did > > catch one wa

Re: [PATCH v3 07/10] drm/msm/A6xx: Add traces for preemption

2024-09-06 Thread Akhil P Oommen
On Thu, Sep 05, 2024 at 04:51:25PM +0200, Antonino Maniscalco wrote: > Add trace points corresponding to preemption being triggered and being > completed for latency measurement purposes. > > Signed-off-by: Antonino Maniscalco > Tested-by: Neil Armstrong # on SM8650-QRD > --- > drivers/gpu/drm/

Re: [PATCH v3 06/10] drm/msm/A6xx: Use posamble to reset counters on preemption

2024-09-06 Thread Akhil P Oommen
On Thu, Sep 05, 2024 at 04:51:24PM +0200, Antonino Maniscalco wrote: > Use the postamble to reset perf counters when switching between rings, > except when sysprof is enabled, analogously to how they are reset > between submissions when switching pagetables. > > Signed-off-by: Antonino Maniscalco

Re: i.MX8MP IMX-LCDIF Underrun Question(s)

2024-09-06 Thread Frieder Schrempf
On 06.09.24 3:46 AM, Adam Ford wrote: > I have been testing various settings on the HDMI out of the i.MX8MP. > > I noticed that sometimes my monitor would not sync, but sometimes it > would on the same resolution/refresh rate. Frieder noted the LCDIF > was sometimes underflowing, so read up on it

Re: [PATCH v3 00/10] Preemption support for A7XX

2024-09-06 Thread Akhil P Oommen
On Thu, Sep 05, 2024 at 04:51:18PM +0200, Antonino Maniscalco wrote: > This series implements preemption for A7XX targets, which allows the GPU to > switch to an higher priority ring when work is pushed to it, reducing latency > for high priority submissions. > > This series enables L1 preemption

Re: [PATCH v3 04/10] drm/msm/A6xx: Implement preemption for A7XX targets

2024-09-06 Thread Akhil P Oommen
On Thu, Sep 05, 2024 at 04:51:22PM +0200, Antonino Maniscalco wrote: > This patch implements preemption feature for A6xx targets, this allows > the GPU to switch to a higher priority ringbuffer if one is ready. A6XX > hardware as such supports multiple levels of preemption granularities, > ranging

[PATCH] drm/ipuv3/parallel: Fix an error handling path in imx_pd_probe()

2024-09-06 Thread Christophe JAILLET
If component_add() fails, we need to undo a potential previous drm_edid_alloc() call. Add an error handling path and the missing drm_edid_free(), as already done in the reomve function. Fixes: 42e08287a318 ("drm/ipuv3/parallel: convert to struct drm_edid") Signed-off-by: Christophe JAILLET ---

Re: 6.11/regression/bisected - after commit 1b04dcca4fb1, launching some RenPy games causes computer hang

2024-09-06 Thread Leo Li
Hi Mikhail, I've tried to align my system with yours as best as I can, but so far, I've had no luck reproducing the hang. A video of what I'm doing: https://youtu.be/VeD-LPCnfWM?si=b2baF8MyDBuU4jRH (Under the hood, the W7900 and 7900xt should be the same) I have a few suggestions: First, can

Re: [PATCH v4 0/2] arm64: dts: mediatek: Add MT8186 Ponyta

2024-09-06 Thread Rob Herring (Arm)
On Fri, 06 Sep 2024 16:57:37 +0800, Jianeng Ceng wrote: > This is v4 of the MT8186 Chromebook device tree series. > --- > Changes in v4: > - PATCH 1/2: Add more info for Ponyta custom label in commit. > - Link to > v3:https://lore.kernel.org/all/20240904081501.2060933-1-cengjian...@huaqin.corp-p

Re: [PATCH v2 3/3] drm/nouveau: Add drm_panic support for nv50+

2024-09-06 Thread James Jones
Right, there are 3 iterations of block linear tiling actually. NV50 does support scanout of block linear surfaces. All block-linear-capable GPUs do. The 3 generations are: NV5x/G8x/GTXXX line: Original block size. GFXXX(nvc0 I believe in nouveau terms)-GV100: double the block height I believe.

Re: (subset) [PATCH v7 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-09-06 Thread Nathan Chancellor
On Fri, Sep 06, 2024 at 07:27:01PM +0100, Mark Brown wrote: > Are these just warnings introduced by recent versions of the toolchains? > These commits passed an x86 allmodconfig with GCC 12 at each step (I did > catch one warning there with another patch in the series that didn't get > applied) and

Re: [PATCH] drm: vc4: Use of_property_present()

2024-09-06 Thread Rob Herring
On Fri, Sep 6, 2024 at 9:24 AM Dave Stevenson wrote: > > On Wed, 4 Sept 2024 at 14:19, Rob Herring wrote: > > > > On Wed, Sep 4, 2024 at 6:18 AM Dave Stevenson > > wrote: > > > > > > Hi Rob > > > > > > On Tue, 3 Sept 2024 at 20:19, Rob Herring wrote: > > > > > > > > On Wed, Jul 31, 2024 at 2:13

Re: [git pull] drm fixes for 6.11-rc7

2024-09-06 Thread pr-tracker-bot
The pull request you sent on Fri, 6 Sep 2024 14:42:24 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-09-06 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/ea462f0fa438381e0d420f94193c075e2a114894 Thank you! -- Deet-doot-dot, I am a bot. ht

Re: [PATCH] accel/qaic: Fix a typo

2024-09-06 Thread Jonathan Corbet
Andrew Kreimer writes: > Fix a typo in documentation. > > Signed-off-by: Andrew Kreimer > --- > Documentation/accel/qaic/qaic.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/accel/qaic/qaic.rst > b/Documentation/accel/qaic/qaic.rst > index efb7771273b

Re: [PATCH] drm/i915/guc: prevent a possible int overflow in wq offsets

2024-09-06 Thread Rodrigo Vivi
On Thu, Jul 25, 2024 at 08:59:25AM -0700, Nikita Zhandarovich wrote: > It may be possible for the sum of the values derived from > i915_ggtt_offset() and __get_parent_scratch_offset()/ > i915_ggtt_offset() to go over the u32 limit before being assigned > to wq offsets of u64 type. > > Mitigate the

RE: [RFC PATCH 05/28] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-09-06 Thread Zeng, Oak
There are fundamental design conflicts with what we have aligned, see inline. > -Original Message- > From: Intel-xe On Behalf > Of Matthew Brost > Sent: Tuesday, August 27, 2024 10:49 PM > To: intel...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: airl...@gmail.com; christi

Re: (subset) [PATCH v7 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-09-06 Thread Mark Brown
On Fri, Sep 06, 2024 at 07:27:04PM +0100, Mark Brown wrote: > These commits passed an x86 allmodconfig with GCC 12 at each step (I did > catch one warning there with another patch in the series that didn't get > applied) and 0day didn't say anything at any point. Oh, actually right as I was writi

Re: (subset) [PATCH v7 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-09-06 Thread Mark Brown
On Fri, Sep 06, 2024 at 11:03:48AM -0700, Nathan Chancellor wrote: > I am seeing several warnings/errors from both GCC and Clang with > ARCH=arm64 allmodconfig after this series appeared in next-20240906. > As far as I can tell, they appear to agree. I wondered how this was not > c

Re: [PATCH 1/2] Documentation/gpu: Document the situation with unqualified drm-memory-

2024-09-06 Thread Alex Deucher
On Wed, Sep 4, 2024 at 4:36 AM Tvrtko Ursulin wrote: > > > On 21/08/2024 21:47, Alex Deucher wrote: > > On Tue, Aug 13, 2024 at 9:57 AM Tvrtko Ursulin wrote: > >> > >> From: Tvrtko Ursulin > >> > >> Currently it is not well defined what is drm-memory- compared to other > >> categories. > >> > >>

[RFC 2/2] drm/sched: Remove drm_sched_entity_set_priority

2024-09-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Now that no callers exist, lets remove the whole misleading helper. Misleading because runtime changes do not reliably work due drm_sched_entity_select_rq() only acting on idle entities. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Alex Deucher Cc: Luben Tuikov

[RFC 1/2] drm/amdgpu: Remove dynamic DRM scheduling priority override

2024-09-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin According to Christian the dynamic DRM priority override was only interesting before the hardware priority (dona via drm_sched_entity_modify_sched()) existed. Furthermore, both overrides also only work somewhat on paper while in reality they are only effective if the entity i

[RFC 0/2] drm/amdgpu: No need for dynamic DRM priority?

2024-09-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In a recent conversation with Christian there was a thought that dynamic DRM scheduling priority changes are not required, or even not desired (actively prevented?!), and can be ripped out. For more context, starting point for that conversation was me observing that they (dy

[RFC 1/4] drm/sched: Add locking to drm_sched_entity_modify_sched

2024-09-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Without the locking amdgpu currently can race amdgpu_ctx_set_entity_priority() and drm_sched_job_arm(), leading to the latter accesing potentially inconsitent entity->sched_list and entity->num_sched_list pair. The comment on drm_sched_entity_modify_sched() however says: ""

[RFC 0/4] DRM scheduler fixes, or not, or incorrect kind

2024-09-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In a recent conversation with Christian there was a thought that drm_sched_entity_modify_sched() should start using the entity->rq_lock to be safe against job submission and simultaneous priority changes. The kerneldoc accompanying that function however is a bit unclear to m

[RFC 3/4] drm/sched: Always increment correct scheduler score

2024-09-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Entities run queue can change during drm_sched_entity_push_job() so make sure to update the score consistently. Signed-off-by: Tvrtko Ursulin Fixes: d41a39dda140 ("drm/scheduler: improve job distribution with multiple queues") Cc: Nirmoy Das Cc: Christian König Cc: Luben

[RFC 4/4] drm/sched: Optimise drm_sched_entity_push_job

2024-09-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In FIFO mode We can avoid dropping the lock only to immediately re-acquire by adding a new drm_sched_rq_update_fifo_locked() helper. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Alex Deucher Cc: Luben Tuikov Cc: Matthew Brost --- drivers/gpu/drm/scheduler/sche

[RFC 2/4] drm/sched: Always wake up correct scheduler in drm_sched_entity_push_job

2024-09-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Since drm_sched_entity_modify_sched() can modify the entities run queue lets make sure to only derefernce the pointer once so both adding and waking up are guaranteed to be consistent. Signed-off-by: Tvrtko Ursulin Fixes: b37aced31eb0 ("drm/scheduler: implement a function t

Re: (subset) [PATCH v7 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-09-06 Thread Nathan Chancellor
warnings/errors from both GCC and Clang with ARCH=arm64 allmodconfig after this series appeared in next-20240906. As far as I can tell, they appear to agree. I wondered how this was not caught during the series development but perhaps it was written against a development tree that did not have Arnd&#x

Re: [PATCH 11/21] drm/msm/dpu: Add RM support for allocating CWB

2024-09-06 Thread Dmitry Baryshkov
On Fri, 6 Sept 2024 at 19:53, Jessica Zhang wrote: > > > > On 9/5/2024 6:30 AM, Dmitry Baryshkov wrote: > > On Tue, Sep 03, 2024 at 06:04:13PM GMT, Jessica Zhang wrote: > >> > >> > >> On 8/30/2024 3:16 PM, Dmitry Baryshkov wrote: > >>> On Fri, 30 Aug 2024 at 22:28, Jessica Zhang > >>> wrote: > >

Re: [PATCH v2] drm/i915/guc: Enable PXP GuC autoteardown flow

2024-09-06 Thread Teres Alexis, Alan Previn
LGTM: Reviewed-by: Alan Previn On Fri, 2024-09-06 at 10:40 -0700, john.c.harri...@intel.com wrote: > From: Juston Li > > This feature flag enables GuC autoteardown which allows for a grace > period before session teardown. > > Also add a HAS_PXP() helper to share with the other place that wan

[PATCH v2] drm/i915/guc: Enable PXP GuC autoteardown flow

2024-09-06 Thread John . C . Harrison
From: Juston Li This feature flag enables GuC autoteardown which allows for a grace period before session teardown. Also add a HAS_PXP() helper to share with the other place that wants to check. Signed-off-by: Juston Li Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc.c

[PATCH] drm: writeback: Introduce drm managed helpers

2024-09-06 Thread Louis Chauvet
Currently drm_writeback_connector are created by drm_writeback_connector_init or drm_writeback_connector_init_with_encoder. Both of the function uses drm_connector_init and drm_encoder_init, but there is no way to properly clean those structure from outside. By using drm managed variants, we can en

Re: [PATCH v5 19/44] drm/vkms: add 3x4 matrix in color pipeline

2024-09-06 Thread Harry Wentland
On 2024-08-27 13:49, Louis Chauvet wrote: > Le 19/08/24 - 16:56, Harry Wentland a écrit : >> We add two 3x4 matrices into the VKMS color pipeline. The reason >> we're adding matrices is so that we can test that application >> of a matrix and its inverse yields an output equal to the input >> ima

Re: [PATCH 11/21] drm/msm/dpu: Add RM support for allocating CWB

2024-09-06 Thread Jessica Zhang
On 9/5/2024 6:30 AM, Dmitry Baryshkov wrote: On Tue, Sep 03, 2024 at 06:04:13PM GMT, Jessica Zhang wrote: On 8/30/2024 3:16 PM, Dmitry Baryshkov wrote: On Fri, 30 Aug 2024 at 22:28, Jessica Zhang wrote: On 8/30/2024 10:18 AM, Dmitry Baryshkov wrote: On Thu, Aug 29, 2024 at 01:48:32PM

Re: [PATCH] drm: Drop explicit initialization of struct i2c_device_id::driver_data to 0

2024-09-06 Thread Uwe Kleine-König
hello, On Thu, May 16, 2024 at 02:38:38PM +0200, Uwe Kleine-König wrote: > These drivers don't use the driver_data member of struct i2c_device_id, > so don't explicitly initialize this member. > > This prepares putting driver_data in an anonymous union which requires > either no initialization or

Re: [RFC PATCH 3/3] drm/log: Introduce a new boot logger to draw the kmsg on the screen

2024-09-06 Thread Jocelyn Falempe
On 06/09/2024 10:47, John Ogness wrote: On 2024-09-06, John Ogness wrote: Your device_lock()/device_unlock() callbacks probably just need to lock/unlock your mutex @drm_log_lock. Sorry, forgot to mention that the device_lock() callback must also disable migration. Since you are using a mutex,

[PATCH] drm/vkms: Remove index parameter from init_vkms_output

2024-09-06 Thread Louis Chauvet
_universal_plane_alloc(dev, struct vkms_plane, base, 0, &vkms_plane_funcs, vkms_formats, ARRAY_SIZE(vkms_formats), NULL, type, NULL); --- base-commit: a6bb1f77a94335de67dba12e7f52651c115b82d2 change-id: 20240906-vkms-remove-index-3a6e04c38e02 Best regards, -- Louis Chauvet

[PATCH] drm/vkms: Add missing check for CRTC initialization

2024-09-06 Thread Louis Chauvet
crtc, 0, false, VKMS_LUT_SIZE); spin_lock_init(&vkms_out->lock); --- base-commit: a6bb1f77a94335de67dba12e7f52651c115b82d2 change-id: 20240906-vkms-add-missing-check-e1b6ee8d1b39 Best regards, -- Louis Chauvet

Re: [PATCH] drm/vmwgfx: Add tracepoints

2024-09-06 Thread Zack Rusin
On Fri, Sep 6, 2024 at 11:26 AM Ian Forbes wrote: > > On Thu, Sep 5, 2024 at 10:59 PM Zack Rusin wrote: > > > > > > In general it looks good but what's the reason for the submit_time? > > > > z > > So you can get an approximate time of how long each command buffer takes. > You can then use it to

Re: [PATCH v2 7/8] selinux: move genheaders to security/selinux/

2024-09-06 Thread Paul Moore
On Fri, Sep 6, 2024 at 11:37 AM Masahiro Yamada wrote: > > On Fri, Sep 6, 2024 at 11:54 PM Paul Moore wrote: > > > > On Fri, Sep 6, 2024 at 7:01 AM Daniel Gomez via B4 Relay > > wrote: > > > > > > From: Masahiro Yamada > > > > > > This tool is only used in security/selinux/Makefile. > > > > > >

Re: [PATCH v2 7/8] selinux: move genheaders to security/selinux/

2024-09-06 Thread Masahiro Yamada
On Fri, Sep 6, 2024 at 11:54 PM Paul Moore wrote: > > On Fri, Sep 6, 2024 at 7:01 AM Daniel Gomez via B4 Relay > wrote: > > > > From: Masahiro Yamada > > > > This tool is only used in security/selinux/Makefile. > > > > There is no reason to keep it under scripts/. > > > > Signed-off-by: Masahiro

Re: [PATCH v2 3/8] drm/xe: xe_gen_wa_oob: fix program_invocation_short_name for macos

2024-09-06 Thread Jani Nikula
On Fri, 06 Sep 2024, Masahiro Yamada wrote: > On Fri, Sep 6, 2024 at 8:01 PM Daniel Gomez via B4 Relay > wrote: >> >> From: Daniel Gomez >> >> Use getprogname() [1] instead of program_invocation_short_name() [2] >> for macOS hosts. >> >> [1]: >> https://www.gnu.org/software/gnulib/manual/html_no

Re: [PATCH] drm/vmwgfx: Add tracepoints

2024-09-06 Thread Ian Forbes
On Thu, Sep 5, 2024 at 10:59 PM Zack Rusin wrote: > > > In general it looks good but what's the reason for the submit_time? > > z So you can get an approximate time of how long each command buffer takes. You can then use it to construct a histogram or look for outliers using bpftrace. Useful when

Re: [PATCH v2 6/8] selinux: do not include headers from host programs

2024-09-06 Thread Daniel Gomez (Samsung)
On Fri, Sep 6, 2024 at 4:56 PM Paul Moore wrote: > > On Fri, Sep 6, 2024 at 7:01 AM Daniel Gomez via B4 Relay > wrote: > > > > From: Masahiro Yamada > > > > Commit bfc5e3a6af39 ("selinux: use the kernel headers when building > > scripts/selinux") is not the right thing to do. > > > > It is clear

Re: [PATCH v2 7/8] selinux: move genheaders to security/selinux/

2024-09-06 Thread Daniel Gomez (Samsung)
On Fri, Sep 6, 2024 at 4:54 PM Paul Moore wrote: > > On Fri, Sep 6, 2024 at 7:01 AM Daniel Gomez via B4 Relay > wrote: > > > > From: Masahiro Yamada > > > > This tool is only used in security/selinux/Makefile. > > > > There is no reason to keep it under scripts/. > > > > Signed-off-by: Masahiro

Re: [PATCH v5.15-v5.10] drm/amd/pm: Fix the null pointer dereference for vega10_hwmgr

2024-09-06 Thread Alex Deucher
On Fri, Sep 6, 2024 at 4:50 AM Mukul Sikka wrote: > > On Fri, Sep 6, 2024 at 12:05 AM Alex Deucher wrote: > > > > On Tue, Sep 3, 2024 at 5:53 AM sikkamukul wrote: > > > > > > From: Bob Zhou > > > > > > [ Upstream commit 50151b7f1c79a09117837eb95b76c2de76841dab ] > > > > > > Check return value a

Re: [PATCH v2 6/8] selinux: do not include headers from host programs

2024-09-06 Thread Paul Moore
On Fri, Sep 6, 2024 at 7:01 AM Daniel Gomez via B4 Relay wrote: > > From: Masahiro Yamada > > Commit bfc5e3a6af39 ("selinux: use the kernel headers when building > scripts/selinux") is not the right thing to do. > > It is clear from the warning in include/uapi/linux/types.h: > > #ifndef __EXPOR

Re: [PATCH v2 7/8] selinux: move genheaders to security/selinux/

2024-09-06 Thread Paul Moore
On Fri, Sep 6, 2024 at 7:01 AM Daniel Gomez via B4 Relay wrote: > > From: Masahiro Yamada > > This tool is only used in security/selinux/Makefile. > > There is no reason to keep it under scripts/. > > Signed-off-by: Masahiro Yamada > --- > scripts/remove-stale-files

Re: [PATCH v2 3/8] drm/xe: xe_gen_wa_oob: fix program_invocation_short_name for macos

2024-09-06 Thread Masahiro Yamada
On Fri, Sep 6, 2024 at 8:01 PM Daniel Gomez via B4 Relay wrote: > > From: Daniel Gomez > > Use getprogname() [1] instead of program_invocation_short_name() [2] > for macOS hosts. > > [1]: > https://www.gnu.org/software/gnulib/manual/html_node/ > program_005finvocation_005fshort_005fname.html > >

Re: [PATCH 09/20] drm/bridge: tc358775: remove complex vsdelay calculation

2024-09-06 Thread Michael Walle
Hi Daniel, > > To cite the datasheet on VSDELAY: > > During DSI link speed is slower than that of LVDS link’s, data needs > > to be buffer within 775XBG before outputting to prevent data from > > underflow. Register field VPCTRL[VSDELAY] is used to for this purpose > > > > This driver assume

Re: [PATCH] drm: vc4: Use of_property_present()

2024-09-06 Thread Dave Stevenson
On Wed, 4 Sept 2024 at 14:19, Rob Herring wrote: > > On Wed, Sep 4, 2024 at 6:18 AM Dave Stevenson > wrote: > > > > Hi Rob > > > > On Tue, 3 Sept 2024 at 20:19, Rob Herring wrote: > > > > > > On Wed, Jul 31, 2024 at 2:13 PM Rob Herring (Arm) wrote: > > > > > > > > Use of_property_present() to t

Re: [PATCH 09/20] drm/bridge: tc358775: remove complex vsdelay calculation

2024-09-06 Thread Daniel Semkowicz
Hello Michael, On Mon, May 6, 2024 at 3:35 PM Michael Walle wrote: > > To cite the datasheet on VSDELAY: > During DSI link speed is slower than that of LVDS link’s, data needs > to be buffer within 775XBG before outputting to prevent data from > underflow. Register field VPCTRL[VSDELAY] is

Re: [PATCH v2 5/8] scripts: add bee-headers support

2024-09-06 Thread Masahiro Yamada
On Fri, Sep 6, 2024 at 8:01 PM Daniel Gomez via B4 Relay wrote: > > From: Daniel Gomez > > endian.h header is not provided by default in macOS. Use pkg-config with > the new development package 'bee-headers' [1] to find the path where the > headers are installed. > > [1] Bee Headers Project links

Re: [PATCH v2 4/8] arm64: nvhe: add bee-headers support

2024-09-06 Thread Masahiro Yamada
On Fri, Sep 6, 2024 at 8:01 PM Daniel Gomez via B4 Relay wrote: > > From: Daniel Gomez > > endian.h header is not provided by default in macOS. Use pkg-config with > the new development package 'bee-headers' [1] to find the path where the > headers are installed. > > [1] Bee Headers Project links

Re: [PATCH 07/20] drm/bridge: tc358775: use regmap instead of open coded access functions

2024-09-06 Thread Michael Walle
Hi Daniel, On Fri Sep 6, 2024 at 3:47 PM CEST, Daniel Semkowicz wrote: > > tc->i2c = client; > > so the assignment above is no longer correct and should > be also removed. Otherwise, this code will not compile. Ahh yes. Thanks for noticing. I have a wip patch which I didn't post, which h

Re: [PATCH 07/20] drm/bridge: tc358775: use regmap instead of open coded access functions

2024-09-06 Thread Daniel Semkowicz
Hello Michael, Thank you for the patch! On Mon, May 6, 2024 at 3:35 PM Michael Walle wrote: > > The DSI bridge also supports access via DSI in-band reads and writes. > Prepare the driver for that by converting all the access functions to > regmap. This also have the advantage that it will make t

Re: [PATCH v2 3/3] drm/nouveau: Add drm_panic support for nv50+

2024-09-06 Thread Ilia Mirkin
On Fri, Sep 6, 2024 at 9:10 AM Jocelyn Falempe wrote: > On 06/09/2024 14:53, Ilia Mirkin wrote: > > On Fri, Sep 6, 2024 at 6:05 AM Jocelyn Falempe > > wrote: > > > > Add drm_panic support, for nv50+ cards. > > It's enough to get the panic screen while running

Re: [PATCH v2 3/3] drm/nouveau: Add drm_panic support for nv50+

2024-09-06 Thread Jocelyn Falempe
On 06/09/2024 14:53, Ilia Mirkin wrote: On Fri, Sep 6, 2024 at 6:05 AM Jocelyn Falempe > wrote: Add drm_panic support, for nv50+ cards. It's enough to get the panic screen while running Gnome/Wayland on a GTX 1650. It doesn't support multi-plane or com

Re: [PATCH v2 3/3] drm/nouveau: Add drm_panic support for nv50+

2024-09-06 Thread Ilia Mirkin
On Fri, Sep 6, 2024 at 6:05 AM Jocelyn Falempe wrote: > Add drm_panic support, for nv50+ cards. > It's enough to get the panic screen while running Gnome/Wayland on a > GTX 1650. > It doesn't support multi-plane or compressed format. > Support for other formats and older cards will come later. >

Re: [PATCH 1/1] drm/imx: Add missing DRM_BRIDGE_CONNECTOR dependency

2024-09-06 Thread Dmitry Baryshkov
On Fri, Sep 06, 2024 at 01:46:43PM GMT, Philipp Zabel wrote: > On Fr, 2024-09-06 at 14:35 +0300, Dmitry Baryshkov wrote: > > On Fri, 6 Sept 2024 at 09:39, Alexander Stein > > wrote: > > > > > > When drm/bridge-connector was moved to DRM_DISPLAY_HELPER not all > > > users were updated. Add missing

Re: i.MX8MP IMX-LCDIF Underrun Question(s)

2024-09-06 Thread Maxime Ripard
On Fri, Sep 06, 2024 at 08:03:38AM GMT, Peng Fan wrote: > > Subject: i.MX8MP IMX-LCDIF Underrun Question(s) > > > > I have been testing various settings on the HDMI out of the i.MX8MP. > > > > I noticed that sometimes my monitor would not sync, but sometimes it > > would on the same resolution/re

Re: [PATCH v3 0/4] drm/tidss: Add OLDI bridge support

2024-09-06 Thread Francesco Dolcini
+Max Hello Aradhya, On Tue, Jul 16, 2024 at 02:12:44PM +0530, Aradhya Bhatia wrote: > The addition of the 2nd OLDI TX (and a 2nd DSS in AM62Px) creates a need > for some major changes for a full feature experience. > > 1. The OF graph needs to be updated to accurately show the data flow. > 2. Th

Re: [PATCH 1/1] drm/imx: Add missing DRM_BRIDGE_CONNECTOR dependency

2024-09-06 Thread Philipp Zabel
On Fr, 2024-09-06 at 14:35 +0300, Dmitry Baryshkov wrote: > On Fri, 6 Sept 2024 at 09:39, Alexander Stein > wrote: > > > > When drm/bridge-connector was moved to DRM_DISPLAY_HELPER not all > > users were updated. Add missing Kconfig selections. > > > > Fixes: 9da7ec9b19d8 ("drm/bridge-connector:

Re: [PATCH 1/1] drm/imx: Add missing DRM_BRIDGE_CONNECTOR dependency

2024-09-06 Thread Philipp Zabel
On Fr, 2024-09-06 at 14:35 +0300, Dmitry Baryshkov wrote: > On Fri, 6 Sept 2024 at 09:39, Alexander Stein > wrote: > > > > When drm/bridge-connector was moved to DRM_DISPLAY_HELPER not all > > users were updated. Add missing Kconfig selections. > > > > Fixes: 9da7ec9b19d8 ("drm/bridge-connector:

Re: [PATCH 1/1] drm/imx: Add missing DRM_BRIDGE_CONNECTOR dependency

2024-09-06 Thread Dmitry Baryshkov
On Fri, 6 Sept 2024 at 09:39, Alexander Stein wrote: > > When drm/bridge-connector was moved to DRM_DISPLAY_HELPER not all > users were updated. Add missing Kconfig selections. > > Fixes: 9da7ec9b19d8 ("drm/bridge-connector: move to DRM_DISPLAY_HELPER > module") > Signed-off-by: Alexander Stein

[PATCH] [PATCH RESEND] drm/i915:Remove unused parameter in marco.

2024-09-06 Thread He Lugang
The parameter dev_priv is actually not used in macro PORT_ALPM_CTL and PORT_ALPM_LFPS_CTL,so remove it to simplify the code. Reviewed-by: Jani Nikula Signed-off-by: He Lugang --- drivers/gpu/drm/i915/display/intel_alpm.c | 4 ++-- drivers/gpu/drm/i915/display/intel_psr.c | 2 +- driver

Re: [PATCH] drm/rockchip: include rockchip_drm_drv.h

2024-09-06 Thread Diederik de Haas
Hi, On Fri Sep 6, 2024 at 11:50 AM CEST, Andy Yan wrote: > At 2024-09-06 17:28:33, "Diederik de Haas" wrote: > >On Fri Sep 6, 2024 at 2:42 AM CEST, Andy Yan wrote: > >> At 2024-09-06 06:38:50, "Min-Hua Chen" wrote: > >> >Include rockchip_drm_drv.h to fix the follow sparse warning: > >> > > >> >d

[PATCH v2 0/8] Enable build system on macOS hosts

2024-09-06 Thread Daniel Gomez via B4 Relay
This patch set allows for building the Linux kernel for arm64 in macOS with LLVM. Patches are based on previous Nick's work and suggestions [1][2][3] to enable the Linux kernel build system on macOS hosts. macOS does not provide certain headers that are available in a GNU/Linux distribution with

[PATCH v2 8/8] Documentation: add howto build in macos

2024-09-06 Thread Daniel Gomez via B4 Relay
From: Daniel Gomez Add documentation under kbuild/llvm to inform about the experimental support for building the Linux kernel in macOS hosts environments. Signed-off-by: Daniel Gomez --- Documentation/kbuild/llvm.rst | 78 +++ 1 file changed, 78 insertio

[PATCH v2 7/8] selinux: move genheaders to security/selinux/

2024-09-06 Thread Daniel Gomez via B4 Relay
From: Masahiro Yamada This tool is only used in security/selinux/Makefile. There is no reason to keep it under scripts/. Signed-off-by: Masahiro Yamada --- scripts/remove-stale-files| 3 +++ scripts/selinux/Makefile | 2

[PATCH v2 5/8] scripts: add bee-headers support

2024-09-06 Thread Daniel Gomez via B4 Relay
From: Daniel Gomez endian.h header is not provided by default in macOS. Use pkg-config with the new development package 'bee-headers' [1] to find the path where the headers are installed. [1] Bee Headers Project links: https://github.com/bee-headers/headers https://github.com/bee-headers/homebre

[PATCH v2 6/8] selinux: do not include headers from host programs

2024-09-06 Thread Daniel Gomez via B4 Relay
From: Masahiro Yamada Commit bfc5e3a6af39 ("selinux: use the kernel headers when building scripts/selinux") is not the right thing to do. It is clear from the warning in include/uapi/linux/types.h: #ifndef __EXPORTED_HEADERS__ #warning "Attempt to use kernel headers from user space, see ht

[PATCH v2 1/8] scripts: subarch.include: fix SUBARCH on macOS hosts

2024-09-06 Thread Daniel Gomez via B4 Relay
From: Nick Desaulniers When building the Linux kernel on an aarch64 macOS based host, if we don't specify a value for ARCH when invoking make, we default to arm and thus multi_v7_defconfig rather than the expected arm64 and arm64's defconfig. This is because subarch.include invokes `uname -m` wh

[PATCH v2 4/8] arm64: nvhe: add bee-headers support

2024-09-06 Thread Daniel Gomez via B4 Relay
From: Daniel Gomez endian.h header is not provided by default in macOS. Use pkg-config with the new development package 'bee-headers' [1] to find the path where the headers are installed. [1] Bee Headers Project links: https://github.com/bee-headers/headers https://github.com/bee-headers/homebre

[PATCH v2 3/8] drm/xe: xe_gen_wa_oob: fix program_invocation_short_name for macos

2024-09-06 Thread Daniel Gomez via B4 Relay
From: Daniel Gomez Use getprogname() [1] instead of program_invocation_short_name() [2] for macOS hosts. [1]: https://www.gnu.org/software/gnulib/manual/html_node/ program_005finvocation_005fshort_005fname.html [2]: https://developer.apple.com/library/archive/documentation/System/ Conceptual/Ma

[PATCH v2 2/8] file2alias: fix uuid_t definitions for macos

2024-09-06 Thread Daniel Gomez via B4 Relay
From: Daniel Gomez The uuid_t struct defined in sys/types.h on macOS hosts conflicts with the one defined in file2alias, resulting in the typedef redefinition error below. To resolve this conflict, define the _UUID_T and __GETHOSTUUID_ in file2alias HOSTCFLAGS. Error: HOSTCC scripts/mod/file2

[PATCH] drm/imx: parallel-display: select DRM_IMX_LEGACY_BRIDGE

2024-09-06 Thread Philipp Zabel
14,6 +14,7 @@ config DRM_IMX_PARALLEL_DISPLAY depends on DRM_IMX select DRM_BRIDGE select DRM_PANEL_BRIDGE + select DRM_IMX_LEGACY_BRIDGE select VIDEOMODE_HELPERS config DRM_IMX_TVE --- base-commit: 8a8a31205e62b57f1fb844d790d682286121f729 change-id: 20240906-imx-par

[PULL] drm-intel-gt-next

2024-09-06 Thread Joonas Lahtinen
Hi Dave & Sima, Here goes the final drm-intel-gt-next towards 6.12. Primarily addition of fan speed hwmon, W/A fixups for ARL, add missing register for userspace into DG2/MTL/ARL. Then a few smaller fixes. Regards, Joonas *** drm-intel-gt-next-2024-09-06: Driver Changes: - Expose fan speed

Re: [PATCH v2 2/2] drm/panthor: Add DEV_QUERY_GROUP_PRIORITIES_INFO dev query

2024-09-06 Thread Steven Price
On 05/09/2024 18:32, Mary Guillemard wrote: > Expose allowed group priorities with a new device query. > > This new uAPI will be used in Mesa to properly report what priorities a > user can use for EGL_IMG_context_priority. > > Since this extends the uAPI and because userland needs a way to > adv

[PATCH v2 3/3] drm/nouveau: Add drm_panic support for nv50+

2024-09-06 Thread Jocelyn Falempe
Add drm_panic support, for nv50+ cards. It's enough to get the panic screen while running Gnome/Wayland on a GTX 1650. It doesn't support multi-plane or compressed format. Support for other formats and older cards will come later. Tiling is only tested on GTX1650, and might be wrong for other cards

  1   2   >