Re: [PATCH v4 5/5] udmabuf: remove udmabuf_folio

2024-08-28 Thread Huan Yang
在 2024/8/29 14:47, Kasireddy, Vivek 写道: Hi Huan, Subject: [PATCH v4 5/5] udmabuf: remove udmabuf_folio Currently, udmabuf handles folio by creating an unpin list to record each folio obtained from the list and unpinning them when released. To maintain this approach, many data structures have

Re: [PATCH v4 4/5] udmabuf: udmabuf_create codestyle cleanup

2024-08-28 Thread Huan Yang
在 2024/8/29 14:39, Kasireddy, Vivek 写道: Hi Huan, Subject: [PATCH v4 4/5] udmabuf: udmabuf_create codestyle cleanup There are some variables in udmabuf_create that are only used inside the loop. Therefore, there is no need to declare them outside the scope. This patch moved it into loop. It

RE: [PATCH v4 5/5] udmabuf: remove udmabuf_folio

2024-08-28 Thread Kasireddy, Vivek
Hi Huan, > Subject: [PATCH v4 5/5] udmabuf: remove udmabuf_folio > > Currently, udmabuf handles folio by creating an unpin list to record > each folio obtained from the list and unpinning them when released. To > maintain this approach, many data structures have been established. > > However, ma

RE: [PATCH v4 4/5] udmabuf: udmabuf_create codestyle cleanup

2024-08-28 Thread Kasireddy, Vivek
Hi Huan, > Subject: [PATCH v4 4/5] udmabuf: udmabuf_create codestyle cleanup > > There are some variables in udmabuf_create that are only used inside the > loop. Therefore, there is no need to declare them outside the scope. > This patch moved it into loop. > > It is difficult to understand the

Re: [PATCH v4 1/5] udmabuf: direct map pfn when first page fault

2024-08-28 Thread Huan Yang
在 2024/8/29 14:08, Kasireddy, Vivek 写道: Hi Huan, Subject: [PATCH v4 1/5] udmabuf: direct map pfn when first page fault The current udmabuf mmap uses a page fault to populate the vma. However, the current udmabuf has already obtained and pinned the folio upon completion of the creation.This

Re: [PATCH v8 1/8] Get rid of __get_task_comm()

2024-08-28 Thread Yafang Shao
On Wed, Aug 28, 2024 at 10:04 PM Kees Cook wrote: > > > > On August 27, 2024 8:03:14 PM PDT, Yafang Shao wrote: > >We want to eliminate the use of __get_task_comm() for the following > >reasons: > > > >- The task_lock() is unnecessary > > Quoted from Linus [0]: > > : Since user space can random

RE: [PATCH v4 3/5] udmabuf: fix vmap_udmabuf error page set

2024-08-28 Thread Kasireddy, Vivek
Hi Huan, > Subject: [PATCH v4 3/5] udmabuf: fix vmap_udmabuf error page set > > Currently vmap_udmabuf set page's array by each folio. > But, ubuf->folios is only contain's the folio's head page. > > That mean we repeatedly mapped the folio head page to the vmalloc area. > > Due to udmabuf can

RE: [PATCH v4 1/5] udmabuf: direct map pfn when first page fault

2024-08-28 Thread Kasireddy, Vivek
Hi Huan, > Subject: [PATCH v4 1/5] udmabuf: direct map pfn when first page fault > > The current udmabuf mmap uses a page fault to populate the vma. > > However, the current udmabuf has already obtained and pinned the folio > upon completion of the creation.This means that the physical memory ha

[PATCH net-next v23 13/13] netdev: add dmabuf introspection

2024-08-28 Thread Mina Almasry
Add dmabuf information to page_pool stats: $ ./cli.py --spec ../netlink/specs/netdev.yaml --dump page-pool-get ... {'dmabuf': 10, 'id': 456, 'ifindex': 3, 'inflight': 1023, 'inflight-mem': 4190208}, {'dmabuf': 10, 'id': 455, 'ifindex': 3, 'inflight': 1023, 'inflight-mem': 4190208

[PATCH net-next v23 11/13] net: add devmem TCP documentation

2024-08-28 Thread Mina Almasry
Add documentation outlining the usage and details of devmem TCP. Signed-off-by: Mina Almasry Reviewed-by: Bagas Sanjaya Reviewed-by: Donald Hunter --- v16: - Add documentation on unbinding the NIC from dmabuf (Donald). - Add note that any dmabuf should work (Donald). v9: https://lore.kernel

[PATCH net-next v23 12/13] selftests: add ncdevmem, netcat for devmem TCP

2024-08-28 Thread Mina Almasry
ncdevmem is a devmem TCP netcat. It works similarly to netcat, but it sends and receives data using the devmem TCP APIs. It uses udmabuf as the dmabuf provider. It is compatible with a regular netcat running on a peer, or a ncdevmem running on a peer. In addition to normal netcat support, ncdevmem

[PATCH net-next v23 10/13] net: add SO_DEVMEM_DONTNEED setsockopt to release RX frags

2024-08-28 Thread Mina Almasry
Add an interface for the user to notify the kernel that it is done reading the devmem dmabuf frags returned as cmsg. The kernel will drop the reference on the frags to make them available for reuse. Signed-off-by: Willem de Bruijn Signed-off-by: Kaiyuan Zhang Signed-off-by: Mina Almasry Reviewe

[PATCH net-next v23 08/13] net: add support for skbs with unreadable frags

2024-08-28 Thread Mina Almasry
For device memory TCP, we expect the skb headers to be available in host memory for access, and we expect the skb frags to be in device memory and unaccessible to the host. We expect there to be no mixing and matching of device memory frags (unaccessible) with host memory frags (accessible) in the

[PATCH net-next v23 06/13] memory-provider: dmabuf devmem memory provider

2024-08-28 Thread Mina Almasry
Implement a memory provider that allocates dmabuf devmem in the form of net_iov. The provider receives a reference to the struct netdev_dmabuf_binding via the pool->mp_priv pointer. The driver needs to set this pointer for the provider in the net_iov. The provider obtains a reference on the netde

[PATCH net-next v23 09/13] tcp: RX path for devmem TCP

2024-08-28 Thread Mina Almasry
In tcp_recvmsg_locked(), detect if the skb being received by the user is a devmem skb. In this case - if the user provided the MSG_SOCK_DEVMEM flag - pass it to tcp_recvmsg_devmem() for custom handling. tcp_recvmsg_devmem() copies any data in the skb header to the linear buffer, and returns a cmsg

[PATCH net-next v23 07/13] net: support non paged skb frags

2024-08-28 Thread Mina Almasry
Make skb_frag_page() fail in the case where the frag is not backed by a page, and fix its relevant callers to handle this case. Signed-off-by: Mina Almasry Reviewed-by: Eric Dumazet --- v10: - Fixed newly generated kdoc warnings found by patchwork. While we're at it, fix the Return section

[PATCH net-next v23 05/13] page_pool: devmem support

2024-08-28 Thread Mina Almasry
Convert netmem to be a union of struct page and struct netmem. Overload the LSB of struct netmem* to indicate that it's a net_iov, otherwise it's a page. Currently these entries in struct page are rented by the page_pool and used exclusively by the net stack: struct { unsigned long pp_mag

[PATCH net-next v23 04/13] netdev: netdevice devmem allocator

2024-08-28 Thread Mina Almasry
Implement netdev devmem allocator. The allocator takes a given struct netdev_dmabuf_binding as input and allocates net_iov from that binding. The allocation simply delegates to the binding's genpool for the allocation logic and wraps the returned memory region in a net_iov struct. Signed-off-by:

[PATCH net-next v23 02/13] net: netdev netlink api to bind dma-buf to a net device

2024-08-28 Thread Mina Almasry
API takes the dma-buf fd as input, and binds it to the netdevice. The user can specify the rx queues to bind the dma-buf to. Suggested-by: Stanislav Fomichev Signed-off-by: Mina Almasry Reviewed-by: Donald Hunter Reviewed-by: Jakub Kicinski --- v16: - Use subset-of: queue queue-id instead of

[PATCH net-next v23 03/13] netdev: support binding dma-buf to netdevice

2024-08-28 Thread Mina Almasry
Add a netdev_dmabuf_binding struct which represents the dma-buf-to-netdevice binding. The netlink API will bind the dma-buf to rx queues on the netdevice. On the binding, the dma_buf_attach & dma_buf_map_attachment will occur. The entries in the sg_table from mapping will be inserted into a genpool

[PATCH net-next v23 01/13] netdev: add netdev_rx_queue_restart()

2024-08-28 Thread Mina Almasry
Add netdev_rx_queue_restart(), which resets an rx queue using the queue API recently merged[1]. The queue API was merged to enable the core net stack to reset individual rx queues to actuate changes in the rx queue's configuration. In later patches in this series, we will use netdev_rx_queue_resta

[PATCH net-next v23 00/13] Device Memory TCP

2024-08-28 Thread Mina Almasry
v23: https://patchwork.kernel.org/project/netdevbpf/list/?series=882978&state=* Fixing relatively minor issues called out in v22. (thanks again!) Mostly code cleanups, extack error messages, and minor reworks. Nothing major really changed, so the exact changes per commit is called in the com

Re: [PATCH v3 2/2] mtd: rawnand: nuvoton: add new driver for the Nuvoton MA35 SoC

2024-08-28 Thread Markus Elfring
> Nuvoton MA35 SoCs NAND Flash Interface Controller > supports 2KB, 4KB and 8KB page size, and up to 8-bit, > 12-bit, and 24-bit hardware ECC calculation circuit > to protect data communication. You may occasionally put more than 53 characters into text lines of such a change description. https://

Re: remove the dma_set_{max_seg_size,seg_boundary,min_align_mask} return value v2

2024-08-28 Thread Christoph Hellwig
Thanks, I've pulled the series into the dma-mapping for-next tree now.

linux-next: build failure after merge of the drm-intel tree

2024-08-28 Thread Stephen Rothwell
Hi all, After merging the drm-intel tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/gpu/drm/i915/display/intel_dp_mst.c:2118:6: error: redefinition of 'intel_dp_mst_verify_dpcd_state' 2118 | bool intel_dp_mst_verify_dpcd_state(struct intel_dp *intel_dp) |

Re: [PATCH v3 2/2] mtd: rawnand: nuvoton: add new driver for the Nuvoton MA35 SoC

2024-08-28 Thread Hui-Ping Chen
Dear Miquel, Thank you for your reply. On 2024/8/24 上午 01:02, Miquel Raynal wrote: Hi Hui-Ping, hpchen0...@gmail.com wrote on Wed, 21 Aug 2024 07:11:32 +: Nuvoton MA35 SoCs NAND Flash Interface Controller supports 2KB, 4KB and 8KB page size, and up to 8-bit, Suffix is: kiB Okay, I

[PATCH -next] drm/amd/display: Remove the redundant else if branch in the function amdgpu_dm_init()

2024-08-28 Thread Jiapeng Chong
The assignment of the else and if else branches is the same, so we remove it and add comments here to make the code easier to understand. ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:1871:6-8: WARNING: possible condition with no effect (if == else). Reported-by: Abaci Robot Closes: https

[PATCH] drm/sched: coding style fixes: miscellaneous

2024-08-28 Thread qianyi liu
This patch fixes the following checkpatch: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' WARNING: Missing a blank line after declarations WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable Signed-off-by: qianyi liu --- drivers/gpu/drm/scheduler/gpu_scheduler

linux-next: manual merge of the drm-misc tree with the pmdomain tree

2024-08-28 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/tegra/gr3d.c between commit: 606cb5b75827 ("drm/tegra: gr3d: Convert into devm_pm_domain_attach_list()") from the pmdomain tree and commit: f790b5c09665 ("drm/tegra: gr3d: Convert into dev_pm_domai

Re: remove the dma_set_{max_seg_size,seg_boundary,min_align_mask} return value v2

2024-08-28 Thread Martin K. Petersen
Christoph, > the above three functions can only return errors if the bus code > failed to allocate the dma_parms structure, which is a grave error > that won't get us far. Thus remove the pointless return values, that > so far have fortunately been mostly ignored, but which the cleanup > brigade

linux-next: manual merge of the drm tree with the drm-intel-fixes tree

2024-08-28 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm tree got conflicts in: drivers/gpu/drm/i915/display/intel_dp_mst.c drivers/gpu/drm/i915/display/intel_dp_mst.h between commit: a2ccc33b88e2 ("drm/i915/dp_mst: Fix MST state after a sink reset") from the drm-intel-fixes tree and commit: e44bc

Re: [PATCH v8 1/8] Get rid of __get_task_comm()

2024-08-28 Thread Kees Cook
On Wed, Aug 28, 2024 at 05:09:08PM +0200, Alejandro Colomar wrote: > Hi Kees, > > On Wed, Aug 28, 2024 at 06:48:39AM GMT, Kees Cook wrote: > > [...] > > > >Thank you for your suggestion. How does the following commit log look > > >to you? Does it meet your expectations? > > > > > >string: Us

Re: [PATCH v8 1/8] Get rid of __get_task_comm()

2024-08-28 Thread Alejandro Colomar
Hi Kees, On Wed, Aug 28, 2024 at 05:17:55PM GMT, Kees Cook wrote: > On Wed, Aug 28, 2024 at 05:09:08PM +0200, Alejandro Colomar wrote: > > Hi Kees, > > > > On Wed, Aug 28, 2024 at 06:48:39AM GMT, Kees Cook wrote: > > > > [...] > > > > > >Thank you for your suggestion. How does the following com

Re: [PATCH] amdgpu: disable amdgpu_dpm on THTF-SW831-1W-DS25_MB board

2024-08-28 Thread Mario Limonciello
On 8/28/2024 11:14, Alex Deucher wrote: On Wed, Aug 28, 2024 at 11:47 AM WangYuli wrote: On 2024/8/28 23:30, Alex Deucher wrote: On Wed, Aug 28, 2024 at 7:28 AM WangYuli wrote: This will disable dpm on all devices that you might install on this platform. If this is specific to a particula

Re: [PATCH v5 09/12] drm/msm/dpu: move rot90 checking to dpu_plane_atomic_check_pipe()

2024-08-28 Thread Dmitry Baryshkov
On Wed, 28 Aug 2024 at 22:05, Abhinav Kumar wrote: > > > > On 6/26/2024 2:46 PM, Dmitry Baryshkov wrote: > > Move a call to dpu_plane_check_inline_rotation() to the > > dpu_plane_atomic_check_pipe() function, so that the rot90 constraints > > are checked for both pipes. Also move rotation field fr

Re: [PATCH v5 08/12] drm/msm/dpu: split dpu_plane_atomic_check()

2024-08-28 Thread Dmitry Baryshkov
On Wed, 28 Aug 2024 at 22:29, Abhinav Kumar wrote: > > > > On 8/28/2024 11:59 AM, Dmitry Baryshkov wrote: > > On Wed, 28 Aug 2024 at 21:27, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 6/26/2024 2:46 PM, Dmitry Baryshkov wrote: > >>> Split dpu_plane_atomic_check() function into two pieces: >

Re: [PATCH v5 10/12] drm/msm/dpu: add support for virtual planes

2024-08-28 Thread Abhinav Kumar
On 6/26/2024 2:46 PM, Dmitry Baryshkov wrote: Only several SSPP blocks support such features as YUV output or scaling, thus different DRM planes have different features. Properly utilizing all planes requires the attention of the compositor, who should prefer simpler planes to YUV-supporting

Re: [PATCH -next] drm/msm: Use devm_platform_ioremap_resource_byname()

2024-08-28 Thread Abhinav Kumar
On 8/28/2024 1:48 AM, Jinjie Ruan wrote: platform_get_resource_byname() and devm_ioremap_resource() can be replaced by devm_platform_ioremap_resource_byname(), which can simplify the code logic a bit, No functional change here. Signed-off-by: Jinjie Ruan --- drivers/gpu/drm/msm/msm_io_util

Re: [PATCH 03/11] drm/msm/dsi: correct programming sequence for SM8350 / SM8450

2024-08-28 Thread Abhinav Kumar
On 8/3/2024 10:40 PM, Dmitry Baryshkov wrote: According to the display-drivers, 5nm DSI PLL (v4.2, v4.3) have different boundaries for pll_clock_inverters programming. Follow the vendor code and use correct values. Fixes: 2f9ae4e395ed ("drm/msm/dsi: add support for DSI-PHY on SM8350 and SM84

Re: [PATCH 1/6] drm/bridge: imx8mp-hdmi-tx: Switch to SYSTEM_SLEEP_PM_OPS()

2024-08-28 Thread Fabio Estevam
A gentle ping on this series. Thanks On Wed, Jun 26, 2024 at 8:07 PM Fabio Estevam wrote: > > From: Fabio Estevam > > Replace SET_SYSTEM_SLEEP_PM_OPS with its modern SYSTEM_SLEEP_PM_OPS() > alternative. > > The combined usage of pm_ptr() and SYSTEM_SLEEP_PM_OPS() > allows the compiler to evalua

Re: [PATCH] drm/i915/gt: Continue creating engine sysfs files even after a failure

2024-08-28 Thread Rodrigo Vivi
On Tue, Aug 27, 2024 at 07:05:05PM +0200, Daniel Vetter wrote: > On Mon, Aug 19, 2024 at 01:31:40PM +0200, Andi Shyti wrote: > > The i915 driver generates sysfs entries for each engine of the > > GPU in /sys/class/drm/cardX/engines/. > > > > The process is straightforward: we loop over the UABI en

Re: [PATCH 1/2] drm/v3d: Disable preemption while updating GPU stats

2024-08-28 Thread Maíra Canal
Hi Tvrtko, On 8/13/24 07:25, Tvrtko Ursulin wrote: From: Tvrtko Ursulin We forgot to disable preemption around the write_seqcount_begin/end() pair while updating GPU stats: [ ] WARNING: CPU: 2 PID: 12 at include/linux/seqlock.h:221 __seqprop_assert.isra.0+0x128/0x150 [v3d] [ ] Workqueu

Re: [PATCH] drm/msm: fix the highest_bank_bit for sc7180

2024-08-28 Thread Dmitry Baryshkov
On Mon, Aug 12, 2024 at 12:41:40PM GMT, Abhinav Kumar wrote: > > > On 8/12/2024 11:40 AM, Stephen Boyd wrote: > > Quoting Abhinav Kumar (2024-08-08 16:52:27) > > > sc7180 programs the ubwc settings as 0x1e as that would mean a > > > highest bank bit of 14 which matches what the GPU sets as well.

Re: [PATCH v4 4/6] misc: fastrpc: Add support for cdsp1 remoteproc

2024-08-28 Thread Dmitry Baryshkov
On Mon, Aug 05, 2024 at 07:08:05PM GMT, Bartosz Golaszewski wrote: > From: Ling Xu > > The fastrpc supports 4 remoteproc. There are some products which > support cdsp1 remoteproc. Add changes to support cdsp1 remoteproc. I'd very much prefer to see this abstracted somehow, but it seems impossibl

Re: [PATCH v4 3/6] remoteproc: qcom_q6v5_pas: Add support for SA8775p ADSP, CDSP and GPDSP

2024-08-28 Thread Dmitry Baryshkov
On Mon, Aug 05, 2024 at 07:08:04PM GMT, Bartosz Golaszewski wrote: > From: Tengfei Fan > > Add support for PIL loading on ADSP, CDSP0, CDSP1, GPDSP0 and GPDSP1 on > SA8775p SoCs. > > Signed-off-by: Tengfei Fan > Co-developed-by: Bartosz Golaszewski > Signed-off-by: Bartosz Golaszewski > --- >

Re: [PATCH 4/7] drm/msm/A6xx: Implement preemption for A7XX targets

2024-08-28 Thread Antonino Maniscalco
On 8/28/24 9:23 PM, Akhil P Oommen wrote: On Wed, Aug 28, 2024 at 06:46:37AM -0700, Rob Clark wrote: On Wed, Aug 28, 2024 at 6:42 AM Rob Clark wrote: On Tue, Aug 27, 2024 at 3:56 PM Antonino Maniscalco wrote: On 8/27/24 11:07 PM, Rob Clark wrote: On Tue, Aug 27, 2024 at 1:25 PM Antonino M

Re: [Letux-kernel] [PATCHv2 0/6] drm/omap: hdmi: improve hdmi4 CEC, add CEC for hdmi5

2024-08-28 Thread H. Nikolaus Schaller
Hi all, > Am 28.08.2024 um 16:14 schrieb Hans Verkuil : > > On 28/08/2024 15:57, Tomi Valkeinen wrote: >> Hi, >> >> On 25/08/2024 23:31, H. Nikolaus Schaller wrote: >>> Hi, >>> CEC features are useful to e.g. control HDMI monitor standby. >>> >>> But I wonder what happened to this series? >>>

Re: [PATCH v2 2/2] drm/msm/dpu: don't play tricks with debug macros

2024-08-28 Thread Dmitry Baryshkov
On Tue, Aug 27, 2024 at 11:39:45AM GMT, Konrad Dybcio wrote: > On 2.08.2024 9:47 PM, Dmitry Baryshkov wrote: > > DPU debugging macros need to be converted to a proper drm_debug_* > > macros, however this is a going an intrusive patch, not suitable for a > > fix. Wire DPU_DEBUG and DPU_DEBUG_DRIVER

Re: [PATCH v5 08/12] drm/msm/dpu: split dpu_plane_atomic_check()

2024-08-28 Thread Abhinav Kumar
On 8/28/2024 11:59 AM, Dmitry Baryshkov wrote: On Wed, 28 Aug 2024 at 21:27, Abhinav Kumar wrote: On 6/26/2024 2:46 PM, Dmitry Baryshkov wrote: Split dpu_plane_atomic_check() function into two pieces: dpu_plane_atomic_check_nopipe() performing generic checks on the pstate, without touch

Re: [PATCH v2] drm/panel: novatek-nt35950: transition to mipi_dsi wrapped functions

2024-08-28 Thread Doug Anderson
Hi, On Wed, Aug 28, 2024 at 11:26 AM Tejas Vipin wrote: > > Changes the novatek-nt35950 panel to use multi style functions for > improved error handling. > > Reviewed-by: Neil Armstrong > Signed-off-by: Tejas Vipin > --- > Changes in v2: > - Style changes > - Fixed changes in logic > >

Re: [PATCH 4/7] drm/msm/A6xx: Implement preemption for A7XX targets

2024-08-28 Thread Akhil P Oommen
On Wed, Aug 28, 2024 at 06:46:37AM -0700, Rob Clark wrote: > On Wed, Aug 28, 2024 at 6:42 AM Rob Clark wrote: > > > > On Tue, Aug 27, 2024 at 3:56 PM Antonino Maniscalco > > wrote: > > > > > > On 8/27/24 11:07 PM, Rob Clark wrote: > > > > On Tue, Aug 27, 2024 at 1:25 PM Antonino Maniscalco > > >

[PULL] drm-xe-next

2024-08-28 Thread Lucas De Marchi
Hi Dave and Sima, Second drm-xe-next pull request for the 6.12 cycle. This includes the pull request from last week since it was not applied due to the ttm patch. That patch is now reverted and replacement on the back burner. The only UAPI change is actually a fix for building with gcc 5. Aside

Re: [PATCH v5 09/12] drm/msm/dpu: move rot90 checking to dpu_plane_atomic_check_pipe()

2024-08-28 Thread Abhinav Kumar
On 6/26/2024 2:46 PM, Dmitry Baryshkov wrote: Move a call to dpu_plane_check_inline_rotation() to the dpu_plane_atomic_check_pipe() function, so that the rot90 constraints are checked for both pipes. Also move rotation field from struct dpu_plane_state to struct dpu_sw_pipe_cfg. Signed-off-by

Re: [PATCH v5 03/16] drm/msm/dpu: move CRTC resource assignment to dpu_encoder_virt_atomic_mode_set

2024-08-28 Thread Dmitry Baryshkov
On Tue, 27 Aug 2024 at 23:35, Abhinav Kumar wrote: > > > > On 7/16/2024 4:06 PM, Dmitry Baryshkov wrote: > > On Wed, 17 Jul 2024 at 01:40, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 6/24/2024 2:13 PM, Dmitry Baryshkov wrote: > >>> Historically CRTC resources (LMs and CTLs) were assigned in

Re: [PATCH v5 08/12] drm/msm/dpu: split dpu_plane_atomic_check()

2024-08-28 Thread Dmitry Baryshkov
On Wed, 28 Aug 2024 at 21:27, Abhinav Kumar wrote: > > > > On 6/26/2024 2:46 PM, Dmitry Baryshkov wrote: > > Split dpu_plane_atomic_check() function into two pieces: > > > > dpu_plane_atomic_check_nopipe() performing generic checks on the pstate, > > without touching the associated pipe, > > > > a

Re: [PATCH net-next v22 04/13] netdev: netdevice devmem allocator

2024-08-28 Thread Jakub Kicinski
On Wed, 28 Aug 2024 00:20:23 -0700 Mina Almasry wrote: > > On Sun, 25 Aug 2024 04:15:02 + Mina Almasry wrote: > > > +void net_devmem_free_dmabuf(struct net_iov *niov) > > > +{ > > > + struct net_devmem_dmabuf_binding *binding = net_iov_binding(niov); > > > + unsigned long dma_addr = n

Re: [RFC PATCH 05/28] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-08-28 Thread Daniel Vetter
On Tue, Aug 27, 2024 at 07:48:38PM -0700, Matthew Brost wrote: > +int drm_gpusvm_migrate_to_sram(struct drm_gpusvm *gpusvm, > +struct drm_gpusvm_range *range, > +const struct drm_gpusvm_ctx *ctx) > +{ > + u64 start = range->va.start, end =

[pull] amdgpu drm-fixes-6.11

2024-08-28 Thread Alex Deucher
Hi Dave, Sima, Fixes for 6.11. The following changes since commit 5be63fc19fcaa4c236b307420483578a56986a37: Linux 6.11-rc5 (2024-08-25 19:07:11 +1200) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.11-2024-08-28 for you to fetc

Re: [PATCH v5 08/12] drm/msm/dpu: split dpu_plane_atomic_check()

2024-08-28 Thread Abhinav Kumar
On 6/26/2024 2:46 PM, Dmitry Baryshkov wrote: Split dpu_plane_atomic_check() function into two pieces: dpu_plane_atomic_check_nopipe() performing generic checks on the pstate, without touching the associated pipe, and dpu_plane_atomic_check_pipes(), which takes into account used pipes. Sig

[PATCH v2] drm/panel: novatek-nt35950: transition to mipi_dsi wrapped functions

2024-08-28 Thread Tejas Vipin
Changes the novatek-nt35950 panel to use multi style functions for improved error handling. Reviewed-by: Neil Armstrong Signed-off-by: Tejas Vipin --- Changes in v2: - Style changes - Fixed changes in logic v1: https://lore.kernel.org/all/20240824084422.202946-1-tejasvipi...@gmail.com/

Re: [RFC PATCH 23/28] drm/xe: Add SVM VRAM migration

2024-08-28 Thread Daniel Vetter
On Wed, Aug 28, 2024 at 06:06:47PM +0200, Daniel Vetter wrote: > On Tue, Aug 27, 2024 at 07:48:56PM -0700, Matthew Brost wrote: > > Migration is implemented with range granularity, with VRAM backing being > > a VM private TTM BO (i.e., shares dma-resv with VM). The lifetime of the > > TTM BO is lim

Re: [PATCH] fbdev: omapfb: panel-sony-acx565akm: Simplify show_cabc_available_modes()

2024-08-28 Thread Helge Deller
On 8/8/24 11:46, Christophe JAILLET wrote: Use sysfs_emit_at() instead of snprintf() + custom logic. Using sysfs_emit_at() is much more simple. Also, sysfs_emit() is already used in this function, so using sysfs_emit_at() is more consistent. Also simplify the logic: - always add a space afte

Re: [PATCH] fbdev: omapfb: Use sysfs_emit_at() to simplify code

2024-08-28 Thread Helge Deller
On 8/8/24 14:14, Christophe JAILLET wrote: This file already uses sysfs_emit(). So be consistent and also use sysfs_emit_at(). Moreover, size is always < PAGE_SIZE because scnprintf() (and now sysfs_emit_at()) returns the number of characters written not including the trailing '\0'. So some test

Re: [PATCH] fbdev: mmp: Use devm_clk_get_enabled() helpers

2024-08-28 Thread Helge Deller
On 8/23/24 14:29, ying zuxin wrote: The devm_clk_get_enabled() helpers: - call devm_clk_get() - call clk_prepare_enable() and register what is needed in order to call clk_disable_unprepare() when needed, as a managed resource. This simplifies the code and avoids the calls to clk_

Re: [PATCH 2/5] fbdev/efifb: Register sysfs groups through driver core

2024-08-28 Thread Helge Deller
On 8/27/24 17:25, Thomas Weißschuh wrote: The driver core can register and cleanup sysfs groups already. Make use of that functionality to simplify the error handling and cleanup. Also avoid a UAF race during unregistering where the sysctl attributes were usable after the info struct was freed.

Re: [PATCH 1/5] fbdev/efifb: Use stack memory for screeninfo structs

2024-08-28 Thread Helge Deller
On 8/27/24 17:25, Thomas Weißschuh wrote: These variables are only used inside efifb_probe(). Afterwards they are using memory unnecessarily. Did you check if this change really saves some memory? With your change, the compiler will either create a hidden structure which it uses then, or it gen

Re: [PATCH] drm/panthor: Add DEV_QUERY_TIMESTAMP_INFO dev query

2024-08-28 Thread Boris Brezillon
On Wed, 28 Aug 2024 18:07:03 +0200 Boris Brezillon wrote: > On Wed, 28 Aug 2024 14:22:51 +0100 > Mihail Atanassov wrote: > > > Hi Boris, > > > > On 28/08/2024 13:09, Boris Brezillon wrote: > > > Hi Mihail, > > > > > > On Thu, 8 Aug 2024 12:41:05 +0300 > > > Mihail Atanassov wrote: > > >

Re: [PATCH] drm/panthor: Add DEV_QUERY_TIMESTAMP_INFO dev query

2024-08-28 Thread Mihail Atanassov
On 28/08/2024 18:27, Boris Brezillon wrote: On Wed, 28 Aug 2024 18:07:03 +0200 Boris Brezillon wrote: On Wed, 28 Aug 2024 14:22:51 +0100 Mihail Atanassov wrote: Hi Boris, On 28/08/2024 13:09, Boris Brezillon wrote: Hi Mihail, On Thu, 8 Aug 2024 12:41:05 +0300 Mihail Atanassov wrote:

[PATCH 8/8] drm/panthor: Add SYNC_UPDATE ioctl

2024-08-28 Thread Mihail Atanassov
From: Ketil Johnsen Similar to how the kernel driver notifies userspace about syncobj modifications, the reverse notification is also necessary to let panthor re-evaluate any queues (GPU or XGS) that were blocked on wait operations. Signed-off-by: Mihail Atanassov Signed-off-by: Ketil Johnsen

[PATCH 6/8] drm/panthor: Implement XGS queues

2024-08-28 Thread Mihail Atanassov
From: Ketil Johnsen Synchronisation between GPU queues in groups from the same VM is achieved using either 32b or 64b synchronisation objects (see panthor_syncobj.(c|h)). They are also the mechanism to sync between a queue and the kernel (or the user application). To allow for the latter case, in

[PATCH 7/8] drm/panthor: Add sync_update eventfd handling

2024-08-28 Thread Mihail Atanassov
Expose the SYNC_UPDATE event to userspace so it can respond to changes in syncobj state. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/panthor/panthor_sched.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panthor/panthor_sched.c

[PATCH 4/8] drm/panthor: Add GROUP_KICK ioctl

2024-08-28 Thread Mihail Atanassov
From: Ketil Johnsen In the kernel submission flow, GROUP_SUBMIT will ensure that the group gets assigned to a CSG. Conversely for the user submission flow, work gets added to the ring buffer without kernel supervision, so there needs to be a mechanism to trigger rescheduling. Use a new GROUP_KICK

[PATCH 5/8] drm/panthor: Factor out syncobj handling

2024-08-28 Thread Mihail Atanassov
From: Ketil Johnsen The code is needed both for the existing kernel submission path and for implementing cross-group sync (XGS) queues which link between drm_syncobj and the HW syncobj primitives. Signed-off-by: Ketil Johnsen Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/panthor/Makefil

[PATCH 2/8] drm/panthor: Extend GROUP_CREATE for user submission

2024-08-28 Thread Mihail Atanassov
From: Ketil Johnsen Allow userspace to mmap() the ring buffer, and the doorbell and user I/O pages, so that it can submit work directly to queues. Signed-off-by: Ketil Johnsen Co-developed-by: Mihail Atanassov Signed-off-by: Mihail Atanassov Co-developed-by: Akash Goel Signed-off-by: Akash G

[PATCH 3/8] drm/panthor: Map doorbell pages

2024-08-28 Thread Mihail Atanassov
From: Ketil Johnsen Dinging the doorbell directly from userspace allows the user driver to bypass the kernel if the group is already assigned and active. Signed-off-by: Ketil Johnsen Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/panthor/panthor_device.c | 66 ++-- dr

[RFC PATCH 00/10] drm/panthor: Add user submission

2024-08-28 Thread Mihail Atanassov
Hello all, This series implements a mechanism to expose Mali CSF GPUs' queue ringbuffers directly to userspace, along with paraphernalia to allow userspace to control job synchronisation between the CPU and GPU. The goal of these changes is to allow userspace to control work submission to the FW/

[PATCH 1/8] drm/panthor: Add uAPI to submit from user space

2024-08-28 Thread Mihail Atanassov
From: Ketil Johnsen * Extend GROUP_CREATE to allow the kernel to expose the ringbuf, user I/O and doorbell pages for each queue, and add eventfds to signal sync updates and group state changes * Add a KICK ioctl to re-evaluate queues within a group * Add cross-group sync (XGS) queues as a mec

Re: [PATCH 2/2] drm/panel: visionox-vtdr6130: switch to devm_regulator_bulk_get_const

2024-08-28 Thread Doug Anderson
Hi, On Wed, Aug 28, 2024 at 9:03 AM Neil Armstrong wrote: > > Switch to devm_regulator_bulk_get_const() to stop setting the supplies > list in probe(), and move the regulator_bulk_data struct in static const. > > Signed-off-by: Neil Armstrong > --- > drivers/gpu/drm/panel/panel-visionox-vtdr613

Re: [PATCH 1/2] drm/panel: visionox-vtdr6130: switch to mipi_dsi wrapped functions

2024-08-28 Thread Doug Anderson
Hi, On Wed, Aug 28, 2024 at 9:03 AM Neil Armstrong wrote: > > Make usage of the new _multi() mipi_dsi functions instead of the > deprecated macros, improving error handling and printing. > > bloat-o-meter gives a 12% gain on arm64: > Function old new delt

Re: [RFC PATCH 05/28] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-08-28 Thread Daniel Vetter
On Wed, Aug 28, 2024 at 03:43:48PM +, Matthew Brost wrote: > On Wed, Aug 28, 2024 at 04:46:24PM +0200, Christian König wrote: > > Am 28.08.24 um 16:31 schrieb Daniel Vetter: > > > On Tue, Aug 27, 2024 at 07:48:38PM -0700, Matthew Brost wrote: > > > > + if (!ctx->mmap_locked) { > >

Re: [PATCH] drm/panthor: Add DEV_QUERY_TIMESTAMP_INFO dev query

2024-08-28 Thread Boris Brezillon
On Wed, 28 Aug 2024 14:22:51 +0100 Mihail Atanassov wrote: > Hi Boris, > > On 28/08/2024 13:09, Boris Brezillon wrote: > > Hi Mihail, > > > > On Thu, 8 Aug 2024 12:41:05 +0300 > > Mihail Atanassov wrote: > > > >>> > >>> +/** + * struct drm_panthor_timestamp_info - Timestamp information + >

Re: [PATCH] amdgpu: disable amdgpu_dpm on THTF-SW831-1W-DS25_MB board

2024-08-28 Thread Alex Deucher
On Wed, Aug 28, 2024 at 11:47 AM WangYuli wrote: > > > On 2024/8/28 23:30, Alex Deucher wrote: > > On Wed, Aug 28, 2024 at 7:28 AM WangYuli wrote: > > > > This will disable dpm on all devices that you might install on this > > platform. If this is specific to a particular platform and board > >

Re: [PATCH 2/7] media: v4l2-core: add v4l2_debugfs_if_alloc/free()

2024-08-28 Thread Jani Nikula
On Wed, 28 Aug 2024, Hans Verkuil wrote: > On 28/08/2024 17:08, Jani Nikula wrote: >> I recently discovered a lot of drm depending on getting seq_file.h and >> debugfs.h via media/cec.h... > > Patches are welcome! I've got the patch, just need to get these [1] reviewed and merged first... BR, Ja

Re: [RFC PATCH 23/28] drm/xe: Add SVM VRAM migration

2024-08-28 Thread Daniel Vetter
On Tue, Aug 27, 2024 at 07:48:56PM -0700, Matthew Brost wrote: > Migration is implemented with range granularity, with VRAM backing being > a VM private TTM BO (i.e., shares dma-resv with VM). The lifetime of the > TTM BO is limited to when the SVM range is in VRAM (i.e., when a VRAM > SVM range is

Re: [RFC PATCH 05/28] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-08-28 Thread Alex Deucher
On Wed, Aug 28, 2024 at 11:53 AM Matthew Brost wrote: > > On Wed, Aug 28, 2024 at 04:46:24PM +0200, Christian König wrote: > > Am 28.08.24 um 16:31 schrieb Daniel Vetter: > > > On Tue, Aug 27, 2024 at 07:48:38PM -0700, Matthew Brost wrote: > > > > + if (!ctx->mmap_locked) { > > > > +

[PATCH 1/2] drm/panel: visionox-vtdr6130: switch to mipi_dsi wrapped functions

2024-08-28 Thread Neil Armstrong
Make usage of the new _multi() mipi_dsi functions instead of the deprecated macros, improving error handling and printing. bloat-o-meter gives a 12% gain on arm64: Function old new delta visionox_vtdr6130_unprepare 208 204 -4 visi

[PATCH 2/2] drm/panel: visionox-vtdr6130: switch to devm_regulator_bulk_get_const

2024-08-28 Thread Neil Armstrong
Switch to devm_regulator_bulk_get_const() to stop setting the supplies list in probe(), and move the regulator_bulk_data struct in static const. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-visionox-vtdr6130.c | 26 +++-- 1 file changed, 16 insertions(+), 10

[PATCH 0/2] drm/panel: annual cleanup of visionox vtdr6130 driver

2024-08-28 Thread Neil Armstrong
/panel-visionox-vtdr6130.c | 212 +++- 1 file changed, 98 insertions(+), 114 deletions(-) --- base-commit: 195a402a75791e6e0d96d9da27ca77671bc656a8 change-id: 20240828-topic-sm8x50-upstream-vtdr6130-multi-d1f03595a394 Best regards, -- Neil Armstrong

Re: [PATCH] amdgpu: disable amdgpu_dpm on THTF-SW831-1W-DS25_MB board

2024-08-28 Thread WangYuli
On 2024/8/28 23:30, Alex Deucher wrote: On Wed, Aug 28, 2024 at 7:28 AM WangYuli wrote: This will disable dpm on all devices that you might install on this platform. If this is specific to a particular platform and board combination, it might be better to check the platform in the dpm_init()

Re: [PATCH 4/7] drm/ttm: move LRU walk defines into new internal header

2024-08-28 Thread Thomas Hellström
On Wed, 2024-08-28 at 17:25 +0200, Christian König wrote: > Am 28.08.24 um 16:05 schrieb Thomas Hellström: > > On Wed, 2024-08-28 at 14:20 +0200, Christian König wrote: > > > Am 27.08.24 um 19:53 schrieb Daniel Vetter: > > > > On Tue, Aug 27, 2024 at 06:52:13PM +0200, Daniel Vetter wrote: > > > > >

Re: [RFC PATCH 05/28] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-08-28 Thread Matthew Brost
On Wed, Aug 28, 2024 at 04:46:24PM +0200, Christian König wrote: > Am 28.08.24 um 16:31 schrieb Daniel Vetter: > > On Tue, Aug 27, 2024 at 07:48:38PM -0700, Matthew Brost wrote: > > > + if (!ctx->mmap_locked) { > > > + /* > > > + * XXX: HMM locking document

Re: [PATCH] amdgpu: disable amdgpu_dpm on THTF-SW831-1W-DS25_MB board

2024-08-28 Thread WangYuli
On 2024/8/28 23:19, Mario Limonciello wrote: This is production hardware? Unfortunately, this device was released quite a while back. Have you already checked whether a BIOS upgrade for the device could help this issue? Sadly, there's no BIOS update to address this problem. It seems to

Re: [PATCH v3 00/15] CCS static load balance

2024-08-28 Thread Andi Shyti
Hi Sima, On Wed, Aug 28, 2024 at 03:47:21PM +0200, Daniel Vetter wrote: > On Wed, Aug 28, 2024 at 10:20:15AM +0200, Andi Shyti wrote: > > Hi Sima, > > > > first of all, thanks for looking into this series. > > > > On Tue, Aug 27, 2024 at 07:31:21PM +0200, Daniel Vetter wrote: > > > On Fri, Aug 2

Re: [PATCH 4/7] drm/ttm: move LRU walk defines into new internal header

2024-08-28 Thread Alex Deucher
On Wed, Aug 28, 2024 at 11:26 AM Christian König wrote: > > Am 28.08.24 um 16:05 schrieb Thomas Hellström: > > On Wed, 2024-08-28 at 14:20 +0200, Christian König wrote: > >> Am 27.08.24 um 19:53 schrieb Daniel Vetter: > >>> On Tue, Aug 27, 2024 at 06:52:13PM +0200, Daniel Vetter wrote: > On T

Re: [PATCH] amdgpu: disable amdgpu_dpm on THTF-SW831-1W-DS25_MB board

2024-08-28 Thread Alex Deucher
On Wed, Aug 28, 2024 at 7:28 AM WangYuli wrote: > > From: wenlunpeng > > The quirk is for reboot-stability. > > A device reboot stress test has been observed to cause > random system hangs when amdgpu_dpm is enabled. > > Disabling amdgpu_dpm can fix this. > > However, a boot-param can still overw

[PATCH v3 04/11] dt-bindings: mfd: syscon: Add rk3576 QoS register compatible

2024-08-28 Thread Detlev Casanova
Document rk3576 compatible for QoS registers. Signed-off-by: Detlev Casanova Reviewed-by: Krzysztof Kozlowski Acked-by: Heiko Stuebner --- Documentation/devicetree/bindings/mfd/syscon.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml

Re: [PATCH 3/3] drm/tegra: Remove call to iommu_domain_alloc()

2024-08-28 Thread Thierry Reding
On Mon, Aug 12, 2024 at 03:10:34PM GMT, Lu Baolu wrote: > Commit <17de3f5fdd35> ("iommu: Retire bus ops") removes iommu ops from > the bus structure. The iommu subsystem no longer relies on bus for > operations. So iommu_domain_alloc() interface is no longer relevant. > > Normally, iommu_paging_do

[PATCH v3 11/11] arm64: dts: rockchip: Add rk3576-armsom-sige5 board

2024-08-28 Thread Detlev Casanova
Add board file for the rk3576 based ArmSoM Sige5 board. While the hardware offers plenty of peripherals and connectivity this basic implementation just handles things required to successfully boot Linux from SD card and connect via UART or Ethernet. Signed-off-by: Detlev Casanova --- arch/arm64/

Re: [PATCH 4/7] drm/ttm: move LRU walk defines into new internal header

2024-08-28 Thread Christian König
Am 28.08.24 um 16:05 schrieb Thomas Hellström: On Wed, 2024-08-28 at 14:20 +0200, Christian König wrote: Am 27.08.24 um 19:53 schrieb Daniel Vetter: On Tue, Aug 27, 2024 at 06:52:13PM +0200, Daniel Vetter wrote: On Thu, Aug 22, 2024 at 03:19:29PM +0200, Christian König wrote: Completely agree

[PATCH v3 07/11] dt-bindings: gpu: Add rockchip, rk3576-mali compatible

2024-08-28 Thread Detlev Casanova
The rk3576 SoC has an ARM Mali G52 MC3 GPU, that is compatible with arm,mali-bifrost. Signed-off-by: Detlev Casanova Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/binding

  1   2   3   >