Re: [PATCH -next 2/5] drm/mediatek: Fix missing of_node_put() for mtk_drm_get_all_drm_priv()

2024-08-24 Thread Marion & Christophe JAILLET
Le 23/08/2024 à 12:46, Christophe JAILLET a écrit : @@ -933,10 +931,8 @@ static int mtk_drm_probe(struct platform_device *pdev)   }   ret = mtk_ddp_comp_init(node, &private->ddp_comp[comp_id], comp_id); -    if (ret) { -    of_node_put(node); +    if (ret)   

[PATCH RESEND] drm/nouveau: fix a possible null pointer dereference

2024-08-24 Thread Ma Ke
In ch7006_encoder_get_modes(), the return value of drm_mode_duplicate() is used directly in drm_mode_probed_add(), which will lead to a NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Cc: sta...@vger.kernel.org Fixes: 6ee738610f41 ("drm/nouveau: Add DRM drive

[PATCH net-next v22 10/13] net: add SO_DEVMEM_DONTNEED setsockopt to release RX frags

2024-08-24 Thread Mina Almasry
Add an interface for the user to notify the kernel that it is done reading the devmem dmabuf frags returned as cmsg. The kernel will drop the reference on the frags to make them available for reuse. Signed-off-by: Willem de Bruijn Signed-off-by: Kaiyuan Zhang Signed-off-by: Mina Almasry Reviewe

[PATCH net-next v22 13/13] netdev: add dmabuf introspection

2024-08-24 Thread Mina Almasry
Add dmabuf information to page_pool stats: $ ./cli.py --spec ../netlink/specs/netdev.yaml --dump page-pool-get ... {'dmabuf': 10, 'id': 456, 'ifindex': 3, 'inflight': 1023, 'inflight-mem': 4190208}, {'dmabuf': 10, 'id': 455, 'ifindex': 3, 'inflight': 1023, 'inflight-mem': 4190208

[PATCH net-next v22 12/13] selftests: add ncdevmem, netcat for devmem TCP

2024-08-24 Thread Mina Almasry
ncdevmem is a devmem TCP netcat. It works similarly to netcat, but it sends and receives data using the devmem TCP APIs. It uses udmabuf as the dmabuf provider. It is compatible with a regular netcat running on a peer, or a ncdevmem running on a peer. In addition to normal netcat support, ncdevmem

[PATCH net-next v22 08/13] net: add support for skbs with unreadable frags

2024-08-24 Thread Mina Almasry
For device memory TCP, we expect the skb headers to be available in host memory for access, and we expect the skb frags to be in device memory and unaccessible to the host. We expect there to be no mixing and matching of device memory frags (unaccessible) with host memory frags (accessible) in the

[PATCH net-next v22 09/13] tcp: RX path for devmem TCP

2024-08-24 Thread Mina Almasry
In tcp_recvmsg_locked(), detect if the skb being received by the user is a devmem skb. In this case - if the user provided the MSG_SOCK_DEVMEM flag - pass it to tcp_recvmsg_devmem() for custom handling. tcp_recvmsg_devmem() copies any data in the skb header to the linear buffer, and returns a cmsg

[PATCH net-next v22 07/13] net: support non paged skb frags

2024-08-24 Thread Mina Almasry
Make skb_frag_page() fail in the case where the frag is not backed by a page, and fix its relevant callers to handle this case. Signed-off-by: Mina Almasry Reviewed-by: Eric Dumazet --- v10: - Fixed newly generated kdoc warnings found by patchwork. While we're at it, fix the Return section

[PATCH net-next v22 11/13] net: add devmem TCP documentation

2024-08-24 Thread Mina Almasry
Add documentation outlining the usage and details of devmem TCP. Signed-off-by: Mina Almasry Reviewed-by: Bagas Sanjaya Reviewed-by: Donald Hunter --- v16: - Add documentation on unbinding the NIC from dmabuf (Donald). - Add note that any dmabuf should work (Donald). v9: https://lore.kernel

[PATCH net-next v22 04/13] netdev: netdevice devmem allocator

2024-08-24 Thread Mina Almasry
Implement netdev devmem allocator. The allocator takes a given struct netdev_dmabuf_binding as input and allocates net_iov from that binding. The allocation simply delegates to the binding's genpool for the allocation logic and wraps the returned memory region in a net_iov struct. Signed-off-by:

[PATCH net-next v22 06/13] memory-provider: dmabuf devmem memory provider

2024-08-24 Thread Mina Almasry
Implement a memory provider that allocates dmabuf devmem in the form of net_iov. The provider receives a reference to the struct netdev_dmabuf_binding via the pool->mp_priv pointer. The driver needs to set this pointer for the provider in the net_iov. The provider obtains a reference on the netde

[PATCH net-next v22 05/13] page_pool: devmem support

2024-08-24 Thread Mina Almasry
Convert netmem to be a union of struct page and struct netmem. Overload the LSB of struct netmem* to indicate that it's a net_iov, otherwise it's a page. Currently these entries in struct page are rented by the page_pool and used exclusively by the net stack: struct { unsigned long pp_mag

[PATCH net-next v22 02/13] net: netdev netlink api to bind dma-buf to a net device

2024-08-24 Thread Mina Almasry
API takes the dma-buf fd as input, and binds it to the netdevice. The user can specify the rx queues to bind the dma-buf to. Suggested-by: Stanislav Fomichev Signed-off-by: Mina Almasry Reviewed-by: Donald Hunter Reviewed-by: Jakub Kicinski --- v16: - Use subset-of: queue queue-id instead of

[PATCH net-next v22 01/13] netdev: add netdev_rx_queue_restart()

2024-08-24 Thread Mina Almasry
Add netdev_rx_queue_restart(), which resets an rx queue using the queue API recently merged[1]. The queue API was merged to enable the core net stack to reset individual rx queues to actuate changes in the rx queue's configuration. In later patches in this series, we will use netdev_rx_queue_resta

[PATCH net-next v22 03/13] netdev: support binding dma-buf to netdevice

2024-08-24 Thread Mina Almasry
Add a netdev_dmabuf_binding struct which represents the dma-buf-to-netdevice binding. The netlink API will bind the dma-buf to rx queues on the netdevice. On the binding, the dma_buf_attach & dma_buf_map_attachment will occur. The entries in the sg_table from mapping will be inserted into a genpool

[PATCH net-next v22 00/13] Device Memory TCP

2024-08-24 Thread Mina Almasry
v22: https://patchwork.kernel.org/project/netdevbpf/list/?series=881158&state=* v22 aims to resolve the pending issue pointed to in v21, which is the interaction with xdp. In this series I rebase on top of the minor refactor which refactors propagating xdp configuration to slave devices: htt

Re: 6.11/regression/bisected - after commit 1b04dcca4fb1, launching some RenPy games causes computer hang

2024-08-24 Thread Mikhail Gavrilov
On Mon, Aug 5, 2024 at 11:05 PM Mikhail Gavrilov wrote: > > Hi, > After commit 1b04dcca4fb1, launching some RenPy games causes computer hang. > After the hang, even Alt + sysrq + REISUB can't reboot the computer! > And no trace in the kernel log! > For demonstration, I'm going to use the game "Fin

Re: [PATCH -next 5/5] drm/amd/display: Make dcn35_fpga_funcs static

2024-08-24 Thread kernel test robot
: https://lore.kernel.org/r/20240821064040.2292969-6-ruanjinjie%40huawei.com patch subject: [PATCH -next 5/5] drm/amd/display: Make dcn35_fpga_funcs static config: i386-randconfig-003-20240824 (https://download.01.org/0day-ci/archive/20240825/202408250235.xz6ztozy-...@intel.com/config) compiler

Re: [PATCH 01/12] scripts: subarch.include: fix SUBARCH on MacOS hosts

2024-08-24 Thread Daniel Gomez (Samsung)
On Sat, Aug 24, 2024 at 12:14 AM Daniel Gomez (Samsung) wrote: > > On Fri, Aug 23, 2024 at 6:13 PM Masahiro Yamada wrote: > > > > On Wed, Aug 7, 2024 at 8:10 AM Daniel Gomez via B4 Relay > > wrote: > > > > > > From: Nick Desaulniers > > > > > > When building the Linux kernel on an aarch64 MacOS

[PATCH v6 2/4] drm/amd/display: Add support for minimum backlight quirk

2024-08-24 Thread Thomas Weißschuh
Not all platforms provide the full range of PWM backlight capabilities supported by the hardware through ATIF. Use the generic drm panel minimum backlight quirk infrastructure to override the capabilities where necessary. Testing the backlight quirk together with the "panel_power_savings" sysfs fi

[PATCH v6 3/4] drm: panel-backlight-quirks: Add Framework 13 matte panel

2024-08-24 Thread Thomas Weißschuh
The value of "min_input_signal" returned from ATIF on a Framework AMD 13 is "12". This leads to a fairly bright minimum display backlight. Add a quirk to override that the minimum backlight PWM to "0" which leads to a much lower minimum brightness, which is still visible. Tested on a Framework AM

[PATCH v6 0/4] drm: Minimum backlight overrides and implementation for amdgpu

2024-08-24 Thread Thomas Weißschuh
The value of "min_input_signal" returned from ATIF on a Framework AMD 13 is "12". This leads to a fairly bright minimum display backlight. Introduce a quirk to override "min_input_signal" to "0" which leads to a much lower minimum brightness, which is still readable even in daylight. One solution

[PATCH v6 4/4] drm: panel-backlight-quirks: Add Framework 13 glossy and 2.8k panels

2024-08-24 Thread Thomas Weißschuh
From: "Dustin L. Howett" I have tested these panels on the Framework Laptop 13 AMD with firmware revision 3.05 (latest at time of submission). Signed-off-by: Dustin L. Howett Signed-off-by: Thomas Weißschuh Reviewed-by: Mario Limonciello --- drivers/gpu/drm/drm_panel_backlight_quirks.c | 16

[PATCH v6 1/4] drm: Add panel backlight quirks

2024-08-24 Thread Thomas Weißschuh
Panels using a PWM-controlled backlight source do not have a standard way to communicate their valid PWM ranges. On x86 the ranges are read from ACPI through driver-specific tables. The built-in ranges are not necessarily correct, or may grow stale if an older device can be retrofitted with newer p

Re: [PATCH v2 09/12] dt-bindings: watchdog: Add rockchip,rk3576-wdt compatible

2024-08-24 Thread Guenter Roeck
On Fri, Aug 23, 2024 at 10:52:36AM -0400, Detlev Casanova wrote: > It is compatible with the other rockchip SoCs. > > Signed-off-by: Detlev Casanova Acked-by: Guenter Roeck > --- > Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --

RE: [PATCH v4 0/4] Add support for RZ/G2UL Display Unit

2024-08-24 Thread Biju Das
Hi Laurent, > -Original Message- > From: Laurent Pinchart > Sent: Friday, August 23, 2024 4:00 PM > Subject: Re: [PATCH v4 0/4] Add support for RZ/G2UL Display Unit > > Hi Biju, > > On Fri, Aug 23, 2024 at 01:52:14PM +, Biju Das wrote: > > On Friday, August 23, 2024 2:15 PM, Laurent

Re: [PATCH v2 1/9] of: property: add of_graph_get_next_port()

2024-08-24 Thread Sakari Ailus
Hi Laurent, Morimoto-san, On Sun, Aug 11, 2024 at 08:03:16PM +0300, Laurent Pinchart wrote: > Hi Morimoto-san, > > (CC'ing Sakari) > > Thank you for the patch. > > On Fri, Aug 09, 2024 at 04:22:22AM +, Kuninori Morimoto wrote: > > We have endpoint base functions > > - of_graph_get_next_

Re: [PATCH] drm/xe: Fix total initialization in xe_ggtt_print_holes()

2024-08-24 Thread Lucas De Marchi
On Fri, Aug 23, 2024 at 08:47:13PM GMT, Nathan Chancellor wrote: Clang warns (or errors with CONFIG_DRM_WERROR or CONFIG_WERROR): drivers/gpu/drm/xe/xe_ggtt.c:810:3: error: variable 'total' is uninitialized when used here [-Werror,-Wuninitialized] 810 | total += hole_size;

Re: [PATCH] drm/i915/dsi: Make Lenovo Yoga Tab 3 X90F DMI match less strict

2024-08-24 Thread Hans de Goede
Hi, On 8/23/24 9:41 PM, Rodrigo Vivi wrote: > On Fri, Aug 23, 2024 at 07:34:39PM +0200, Hans de Goede wrote: >> Hi, >> >> On 8/23/24 10:22 AM, Jani Nikula wrote: >>> On Fri, 23 Aug 2024, Hans de Goede wrote: There are 2G and 4G RAM versions of the Lenovo Yoga Tab 3 X90F and it turns out

Re: AMD GFX12 modifiers

2024-08-24 Thread Simon Ser
Oh well, if AMD modifiers are documented via "read Mesa source code", then I'll just leave everything as-is and libdrm/drm_info/drmdb will just print "who knows" instead of something actually useful when hitting such modifiers. Sorry, I have no more free time to donate here.

Re: 回复: [PATCH] drm: komeda: Fix an issue related to normalized zpos

2024-08-24 Thread Liviu Dudau
On Fri, Aug 23, 2024 at 02:53:06AM +, Peng Hongchi/彭洪驰 wrote: > Hi, Liviu, Hi, > > I'm sorry for my carelessness and thanks for your correction, the corrected > patch is as follows. > And we do have an extra patch to set layer_split, but this part of the code > is owned by my colleague, >

Re: [PATCH -next 5/5] drm/amd/display: Make dcn35_fpga_funcs static

2024-08-24 Thread kernel test robot
: https://lore.kernel.org/r/20240821064040.2292969-6-ruanjinjie%40huawei.com patch subject: [PATCH -next 5/5] drm/amd/display: Make dcn35_fpga_funcs static config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240824/202408241600.uhrtix7j-...@intel.com/config) compiler: clang

[PATCH] drm: Fix kerneldoc for "Returns" section

2024-08-24 Thread renjun wang
The blank line between title "Returns:" and detail description is not allowed, otherwise the title will goes under the description block in generated .html file after running `make htmldocs`. There are a few examples for current kerneldoc: https://www.kernel.org/doc/html/latest/gpu/drm-kms.html#c.

[PATCH] drm/atomic: fix kerneldoc for fake_commit field

2024-08-24 Thread renjun wang
According to the context, the function description for fake_commit should be "prevent the atomic states from being freed too early" Signed-off-by: renjun wang --- include/drm/drm_atomic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_atomic.h b/include/drm/d

[PATCH] drm/panel: novatek-nt35950: transition to mipi_dsi wrapped functions

2024-08-24 Thread Tejas Vipin
Changes the novatek-nt35950 panel to use multi style functions for improved error handling. Signed-off-by: Tejas Vipin --- drivers/gpu/drm/panel/panel-novatek-nt35950.c | 214 ++ 1 file changed, 70 insertions(+), 144 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-

Re: [PATCH v2 10/12] dt-bindings: spi: Add rockchip,rk3576-spi compatible

2024-08-24 Thread Krzysztof Kozlowski
On Fri, Aug 23, 2024 at 12:07:10PM -0400, Detlev Casanova wrote: > It is compatible with the rockchip,rk3066-spi SPI core. Same comments... subject: spi: dt-bindings: Please use subject prefixes matching the subsystem. You can get them for example with on the directory your patch is touching. F

Re: [PATCH v2 09/12] dt-bindings: watchdog: Add rockchip,rk3576-wdt compatible

2024-08-24 Thread Krzysztof Kozlowski
On Fri, Aug 23, 2024 at 10:52:36AM -0400, Detlev Casanova wrote: > It is compatible with the other rockchip SoCs. > > Signed-off-by: Detlev Casanova Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 08/12] dt-bindings: gpu: Add rockchip,rk3576-mali compatible

2024-08-24 Thread Krzysztof Kozlowski
On Fri, Aug 23, 2024 at 10:52:35AM -0400, Detlev Casanova wrote: > Add the rockchip,rk3576-mali in arm,mali-bifrost.yaml This we see from the diff. And from commit subject. You have here plenty of space to explain shortly the hardware, e.g. it's new and not compatible with existing. > > Signed-o

Re: [PATCH v2 07/12] dt-bindings: mmc: Add support for rk3576 eMMC

2024-08-24 Thread Krzysztof Kozlowski
On Fri, Aug 23, 2024 at 10:52:34AM -0400, Detlev Casanova wrote: > The device is compatible with rk3588, so add an entry for the 2 > compatibles together. > > The rk3576 device has a power-domain that needs to be on for the eMMC to > be used. Add it as a requirement. > > Signed-off-by: Detlev Cas