Re: [PATCH 1/3] dt-bindings: display: mediatek: dpi: Add power domains

2024-08-20 Thread Krzysztof Kozlowski
On 20/08/2024 14:18, Rohit Agarwal wrote: > > On 20/08/24 4:40 PM, Krzysztof Kozlowski wrote: >> On Tue, Aug 20, 2024 at 08:06:57AM +, Rohit Agarwal wrote: >>> Add power domain binding to the mediatek DPI controller. >> Why? Who needs it? Why all devices suddenly have it (IOW, why is it not >>

[PATCH -next 5/5] drm/amd/display: Make dcn35_fpga_funcs static

2024-08-20 Thread Jinjie Ruan
The sparse tool complains as follows: drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c:1071:22: warning: symbol 'dcn35_fpga_funcs' was not declared. Should it be static? This symbol is not used outside of dcn35_clk_mgr.c, so marks it static. Signed-off-by: Jinjie R

[PATCH -next 4/5] drm/amd/display: Make dcn401_dsc_funcs static

2024-08-20 Thread Jinjie Ruan
The sparse tool complains as follows: drivers/gpu/drm/amd/amdgpu/../display/dc/dsc/dcn401/dcn401_dsc.c:30:24: warning: symbol 'dcn401_dsc_funcs' was not declared. Should it be static? This symbol is not used outside of dcn401_dsc.c, so marks it static. Signed-off-by: Jinjie Ruan --- dr

[PATCH -next 0/5] drm/amd/display: Make some symobols static

2024-08-20 Thread Jinjie Ruan
Make some symobols static. Jinjie Ruan (5): drm/amd/display: Make core_dcn4_g6_temp_read_blackout_table static drm/amd/display: Make core_dcn4_ip_caps_base static drm/amd/display: Make dcn35_hubp_funcs static drm/amd/display: Make dcn401_dsc_funcs static drm/amd/display: Make dcn35_fpga_

[PATCH -next 3/5] drm/amd/display: Make dcn35_hubp_funcs static

2024-08-20 Thread Jinjie Ruan
The sparse tool complains as follows: drivers/gpu/drm/amd/amdgpu/../display/dc/hubp/dcn35/dcn35_hubp.c:191:19: warning: symbol 'dcn35_hubp_funcs' was not declared. Should it be static? This symbol is not used outside of dcn35_hubp.c, so marks it static. Signed-off-by: Jinjie Ruan ---

[PATCH -next 1/5] drm/amd/display: Make core_dcn4_g6_temp_read_blackout_table static

2024-08-20 Thread Jinjie Ruan
The sparse tool complains as follows: drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c:6853:56: warning: symbol 'core_dcn4_g6_temp_read_blackout_table' was not declared. Should it be static? This symbol is not used outside of dml2_core_dcn4_calcs.

[PATCH -next 2/5] drm/amd/display: Make core_dcn4_ip_caps_base static

2024-08-20 Thread Jinjie Ruan
The sparse tool complains as follows: drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4.c:12:28: warning: symbol 'core_dcn4_ip_caps_base' was not declared. Should it be static? This symbol is not used outside of dcn35_hubp.c, so marks it static. And do not

Re: [PATCH v5 28/44] drm/amd/display: Add support for sRGB Inverse EOTF in SHAPER block

2024-08-20 Thread kernel test robot
Hi Harry, kernel test robot noticed the following build warnings: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip linus/master v6.11-rc4 next-20240820

[PATCH RESEND] drm/amd/display: avoid using null object of framebuffer

2024-08-20 Thread Ma Ke
Instead of using state->fb->obj[0] directly, get object from framebuffer by calling drm_gem_fb_get_obj() and return error code when object is null to avoid using null object of framebuffer. Cc: sta...@vger.kernel.org Fixes: 5d945cbcd4b1 ("drm/amd/display: Create a file dedicated to planes") Signed

Re: drm/bridge/imx8mp-hdmi-tx: Allow inexact pixel clock frequencies (Was: [PATCH V8 10/12] drm/bridge: imx: add bridge wrapper driver for i.MX8MP DWC HDMI)

2024-08-20 Thread Dominique MARTINET
Adam Ford wrote on Tue, Aug 20, 2024 at 09:49:03PM -0500: > > > However, this check is a bit overcautious in that it only allows exact > > > rate matches. IIRC HDMI allows a rate mismatch of +- 0.5%, so this > > > check could be relaxed quite a bit to allow for that. > > > > I checked with a 1080p

Re: [PATCH v5 20/44] drm/tests: Add a few tests around drm_fixed.h

2024-08-20 Thread kernel test robot
Hi Harry, kernel test robot noticed the following build errors: [auto build test ERROR on drm/drm-next] [also build test ERROR on drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip linus/master v6.11-rc4 next-20240820] [If

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-20 Thread Raag Jadav
On Tue, Aug 20, 2024 at 05:49:23PM -0400, Rodrigo Vivi wrote: > On Tue, Aug 20, 2024 at 12:00:27PM +0300, Raag Jadav wrote: > > On Fri, Aug 09, 2024 at 12:57:54PM +0100, Andi Shyti wrote: > > > On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: > > > > On Fri, Aug 09, 2024 at 11:45:25

Re: [PATCH v2 10/12] media: platform: mtk-mdp3: Get fine-grain control of cmdq_pkt_finalize()

2024-08-20 Thread 胡俊光

Re: [PATCH] gpu: drm: Use devm_clk_get_enabled() helpers

2024-08-20 Thread Rong Qianfeng
在 2024/8/20 21:51, Chen-Yu Tsai 写道: On Tue, Aug 20, 2024 at 8:59 PM Rong Qianfeng wrote: Replace devm_clk_get() and clk_prepare_enable() with devm_clk_get_enabled() that also disables and unprepares it on driver detach. Signed-off-by: Rong Qianfeng --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_

Re: [PATCH v5 36/44] drm/amd/display: add 3x4 matrix colorop

2024-08-20 Thread kernel test robot
Hi Harry, kernel test robot noticed the following build warnings: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip linus/master v6.11-rc4 next-20240820] [cannot apply to drm

Re: drm/bridge/imx8mp-hdmi-tx: Allow inexact pixel clock frequencies (Was: [PATCH V8 10/12] drm/bridge: imx: add bridge wrapper driver for i.MX8MP DWC HDMI)

2024-08-20 Thread Adam Ford
On Thu, Aug 15, 2024 at 3:19 AM Frieder Schrempf wrote: > > Hi Dominique, hi Lucas, > > On 17.06.24 6:32 PM, Lucas Stach wrote: > > Hi Dominique, > > > > Am Montag, dem 17.06.2024 um 15:16 +0900 schrieb Dominique MARTINET: > >> Adam Ford wrote on Sat, Feb 03, 2024 at 10:52:50AM -0600: > >>> From:

[PATCH v3] drm/i915/gt: Use kmemdup_array instead of kmemdup for multiple allocation

2024-08-20 Thread Yu Jiaoliang
Let the kememdup_array() take care about multiplication and possible overflows. v2: - Change subject - Leave one blank line between the commit log and the tag section - Fix code alignment issue v3: - Fix code alignment - Apply the patch on a clean drm-tip Signed-off-by: Yu Jiaoliang Reviewed-by

Re: [PATCH] staging: drivers: gpu: drm: mediatek: Fix warning: Using plain integer as NULL pointer in mtk_drm_gem.c

2024-08-20 Thread 胡俊光

Re: [PATCH net-next v19 03/13] netdev: support binding dma-buf to netdevice

2024-08-20 Thread Jakub Kicinski
On Tue, 20 Aug 2024 13:11:20 -0400 Mina Almasry wrote: > > Protecting the stack from unreadable memory is *the* challenge > > in this series. The rest is a fairly straightforward. > > Understandable. I pulled the trigger on v21 with the build fix last > night after reading your response on the o

Re: [PATCH] drm: mediatek: Drop unnecessary check for property presence

2024-08-20 Thread 胡俊光

Re: [PATCH -next] backlight: ktz8866: fix module autoloading

2024-08-20 Thread Jianhua Lu
On Tue, Aug 20, 2024 at 12:16:28PM +, Liao Chen wrote: > diff --git a/drivers/video/backlight/ktz8866.c > b/drivers/video/backlight/ktz8866.c > index 2e508741c0af..351c2b4d63ed 100644 > --- a/drivers/video/backlight/ktz8866.c > +++ b/drivers/video/backlight/ktz8866.c > @@ -190,6 +190,7 @@ stat

Re: [PATCH v5 20/44] drm/tests: Add a few tests around drm_fixed.h

2024-08-20 Thread Jeff Johnson
On 8/19/24 13:56, Harry Wentland wrote: > While working on the CTM implementation of VKMS I had to ascertain > myself of a few assumptions. One of those is whether drm_fixed.h > treats its numbers using signed-magnitude or twos-complement. It is > twos-complement. > > In order to make someone else

Re: [PATCH v5 03/44] drm/vkms: Add kunit tests for VKMS LUT handling

2024-08-20 Thread Jeff Johnson
On 8/19/24 13:56, Harry Wentland wrote: > Debugging LUT math is much easier when we can unit test > it. Add kunit functionality to VKMS and add tests for > - get_lut_index > - lerp_u16 > > v5: > - Bring back static for lerp_u16 and get_lut_index (Arthur) > > v4: > - Test the critical points o

Re: [PATCH v3 14/17] dt-bindings: usb: Add ports to google,cros-ec-typec for DP altmode

2024-08-20 Thread Rob Herring (Arm)
On Mon, 19 Aug 2024 15:38:28 -0700, Stephen Boyd wrote: > Add a DT graph binding to google,cros-ec-typec so that it can combine > DisplayPort (DP) and USB SuperSpeed (SS) data into a USB type-c endpoint > that is connected to the usb-c-connector node's SS endpoint. This also > allows us to connec

Re: [PATCH v3 13/17] dt-bindings: Move google,cros-ec-typec binding to usb

2024-08-20 Thread Rob Herring (Arm)
On Mon, 19 Aug 2024 15:38:27 -0700, Stephen Boyd wrote: > This binding is about USB type-c control. Move the binding to the usb > directory as it's a better home than chrome. > > Cc: Rob Herring > Cc: Krzysztof Kozlowski > Cc: Conor Dooley > Cc: Lee Jones > Cc: Benson Leung > Cc: Guenter Ro

Re: [PATCH v3 12/17] dt-bindings: usb-switch: Extend for DisplayPort altmode

2024-08-20 Thread Rob Herring (Arm)
On Mon, 19 Aug 2024 15:38:26 -0700, Stephen Boyd wrote: > Extend the usb-switch binding to support DisplayPort (DP) alternate > modes. A third port for the DP signal is necessary when a mode-switch is > muxing USB and DP together onto a usb type-c connector. Add data-lanes > to the usbc output no

Re: [PATCH v3 11/17] dt-bindings: usb-switch: Extract endpoints to defs

2024-08-20 Thread Rob Herring
On Mon, Aug 19, 2024 at 03:38:25PM -0700, Stephen Boyd wrote: > Move the usb-switch endpoint bindings to defs so that they can be reused > by other bindings. Future users of this binding will have more than one > type-c output node when they're muxing a single DP signal to more than > one usb-c-con

Re: [PATCH 25/28] HID: picoLCD: Replace check_fb in favor of struct fb_info.lcd_dev

2024-08-20 Thread Jiri Kosina
On Tue, 20 Aug 2024, Thomas Zimmermann wrote: > Store the lcd device in struct fb_info.lcd_dev. The lcd subsystem can > now detect the lcd's fbdev device from this field. > > This makes the implementation of check_fb in picolcd_lcdops obsolete. > Remove it. > > Signed-off-by: Thomas Zimmermann

[RESEND PATCH] accel/habanalabs/gaudi2: Use kvfree() for memory allocated with kvcalloc()

2024-08-20 Thread Thorsten Blum
Use kvfree() to fix the following Coccinelle/coccicheck warning reported by kfree_mismatch.cocci: WARNING kvmalloc is used to allocate this memory at line 10398 Reviewed-by: Tomer Tayar Signed-off-by: Thorsten Blum --- drivers/accel/habanalabs/gaudi2/gaudi2.c | 2 +- 1 file changed, 1 insert

Re: [PATCH V2] video/aperture: match the pci device when calling sysfb_disable()

2024-08-20 Thread kernel test robot
Hi Alex, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on robh/for-next drm-misc/drm-misc-next linus/master v6.11-rc4 next-20240820] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: (subset) [PATCH 1/2] dt-bindings: misc: qcom, fastrpc: document new domain ID

2024-08-20 Thread Bjorn Andersson
On Fri, 16 Aug 2024 12:23:44 +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Add "cdsp1" as the new supported label for the CDSP1 fastrpc domain. > > Applied, thanks! [2/2] arm64: dts: qcom: sa8775p: fix the fastrpc label commit: b45af698d5114f9b666c7d8b58a9111d0526d

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-20 Thread Rodrigo Vivi
On Tue, Aug 20, 2024 at 12:00:27PM +0300, Raag Jadav wrote: > On Fri, Aug 09, 2024 at 12:57:54PM +0100, Andi Shyti wrote: > > On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: > > > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote: > > > > Add hwmon support for fan1_input a

Re: [PATCH v3 2/2] drm/panel: jdi-fhd-r63452: transition to mipi_dsi wrapped functions

2024-08-20 Thread Doug Anderson
Hi, On Sat, Aug 17, 2024 at 11:08 PM Tejas Vipin wrote: > > Changes the jdi-fhd-r63452 panel to use multi style functions for > improved error handling. > > Reviewed-by: Douglas Anderson > Signed-off-by: Tejas Vipin > --- > drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c | 149 ++-

Re: [PATCH v3 1/2] drm/mipi-dsi: Add mipi_dsi_dcs_set_tear_scanline_multi

2024-08-20 Thread Doug Anderson
Hi, On Sat, Aug 17, 2024 at 11:08 PM Tejas Vipin wrote: > > mipi_dsi_dcs_set_tear_scanline_multi can heavily benefit from being > converted to a multi style function as it is often called in the context of > similar functions. > > Reviewed-by: Douglas Anderson > Signed-off-by: Tejas Vipin > ---

Re: [PATCH] drm/i915/gt: Continue creating engine sysfs files even after a failure

2024-08-20 Thread Rodrigo Vivi
On Mon, Aug 19, 2024 at 01:31:40PM +0200, Andi Shyti wrote: > The i915 driver generates sysfs entries for each engine of the > GPU in /sys/class/drm/cardX/engines/. > > The process is straightforward: we loop over the UABI engines and > for each one, we: > > - Create the object. > - Create basi

Re: Getting off this list

2024-08-20 Thread Lyude Paul
I can't tell you which list it specifically is, since you might be signed up on any of the email lists mentioned in the to/cc. But the relevant email headers that you can use to figure this out are here (this is from a totally unrelated email, and is just an example - you will have to look up the h

Re: [PATCH 2/2] drm/doc: Document that userspace should utilize CRTCs bottom up

2024-08-20 Thread Simon Ser
Sorry for the huge delay. Generally this looks good but maybe we could explain a bit more what "bottom up" means exactly since it may not be super obvious. Maybe something among these lines? Bottom up means that the first CRTCs in the array should be used first. For instance, if the drive

Re: [PATCH v4 3/4] dt-bindings: display: rockchip: Add schema for RK3588 HDMI TX Controller

2024-08-20 Thread Cristian Ciocaltea
On 8/20/24 7:14 PM, Conor Dooley wrote: > On Tue, Aug 20, 2024 at 03:37:44PM +0300, Cristian Ciocaltea wrote: >> On 8/19/24 7:53 PM, Conor Dooley wrote: >>> On Mon, Aug 19, 2024 at 01:29:30AM +0300, Cristian Ciocaltea wrote: Rockchip RK3588 SoC integrates the Synopsys DesignWare HDMI 2.1

Re: [PATCH v8 2/6] drm/ttm/pool: Provide a helper to shrink pages

2024-08-20 Thread Matthew Brost
On Mon, Aug 19, 2024 at 10:07:16AM +0200, Thomas Hellström wrote: > Hi, Matt. > > On Fri, 2024-08-16 at 14:10 +, Matthew Brost wrote: > > On Fri, Aug 16, 2024 at 03:37:13PM +0200, Thomas Hellström wrote: > > > Provide a helper to shrink ttm_tt page-vectors on a per-page > > > basis. A ttm_back

Re: [PATCH v3 10/17] device property: Add remote endpoint to devcon matcher

2024-08-20 Thread Stephen Boyd
Quoting Andy Shevchenko (2024-08-20 03:20:44) > On Mon, Aug 19, 2024 at 03:38:24PM -0700, Stephen Boyd wrote: > > include/linux/property.h| 5 +++-- > > > -typedef void *(*devcon_match_fn_t)(const struct fwnode_handle *fwnode, > > const char *id, > > -void *data

Re: [PATCH v3 02/17] drm/bridge: Verify lane assignment is going to work during atomic_check

2024-08-20 Thread Stephen Boyd
Quoting Andy Shevchenko (2024-08-20 10:29:41) > On Tue, Aug 20, 2024 at 10:24:47AM -0700, Stephen Boyd wrote: > > Quoting Andy Shevchenko (2024-08-20 10:17:46) > > > On Tue, Aug 20, 2024 at 10:12:55AM -0700, Stephen Boyd wrote: > > > > Quoting Andy Shevchenko (2024-08-20 03:09:29) > > > > > On Mon,

Re: [PATCH v3 02/17] drm/bridge: Verify lane assignment is going to work during atomic_check

2024-08-20 Thread Andy Shevchenko
On Tue, Aug 20, 2024 at 10:24:47AM -0700, Stephen Boyd wrote: > Quoting Andy Shevchenko (2024-08-20 10:17:46) > > On Tue, Aug 20, 2024 at 10:12:55AM -0700, Stephen Boyd wrote: > > > Quoting Andy Shevchenko (2024-08-20 03:09:29) > > > > On Mon, Aug 19, 2024 at 03:38:16PM -0700, Stephen Boyd wrote:

Re: [PATCH v3 05/17] usb: typec: Add device managed typec_switch_register()

2024-08-20 Thread Andy Shevchenko
On Tue, Aug 20, 2024 at 10:23:06AM -0700, Stephen Boyd wrote: > Quoting Stephen Boyd (2024-08-20 10:19:48) > > Quoting Andy Shevchenko (2024-08-20 10:16:40) > > > On Tue, Aug 20, 2024 at 10:01:07AM -0700, Stephen Boyd wrote: > > > > Quoting Andy Shevchenko (2024-08-20 03:16:09) > > > > > On Mon, Au

Re: [PATCH v3 02/17] drm/bridge: Verify lane assignment is going to work during atomic_check

2024-08-20 Thread Stephen Boyd
Quoting Andy Shevchenko (2024-08-20 10:17:46) > On Tue, Aug 20, 2024 at 10:12:55AM -0700, Stephen Boyd wrote: > > Quoting Andy Shevchenko (2024-08-20 03:09:29) > > > On Mon, Aug 19, 2024 at 03:38:16PM -0700, Stephen Boyd wrote: > > > > + /* > > > > + * Ensure this bridge is aware that the

Re: [PATCH v3 05/17] usb: typec: Add device managed typec_switch_register()

2024-08-20 Thread Stephen Boyd
Quoting Stephen Boyd (2024-08-20 10:19:48) > Quoting Andy Shevchenko (2024-08-20 10:16:40) > > On Tue, Aug 20, 2024 at 10:01:07AM -0700, Stephen Boyd wrote: > > > Quoting Andy Shevchenko (2024-08-20 03:16:09) > > > > On Mon, Aug 19, 2024 at 03:38:19PM -0700, Stephen Boyd wrote: > > > > > + ptr

Re: [PATCH v3 05/17] usb: typec: Add device managed typec_switch_register()

2024-08-20 Thread Stephen Boyd
Quoting Andy Shevchenko (2024-08-20 10:16:40) > On Tue, Aug 20, 2024 at 10:01:07AM -0700, Stephen Boyd wrote: > > Quoting Andy Shevchenko (2024-08-20 03:16:09) > > > On Mon, Aug 19, 2024 at 03:38:19PM -0700, Stephen Boyd wrote: > > > > + ptr = devres_alloc(devm_typec_switch_unregister, sizeof(*

Re: [PATCH v3 02/17] drm/bridge: Verify lane assignment is going to work during atomic_check

2024-08-20 Thread Andy Shevchenko
On Tue, Aug 20, 2024 at 10:12:55AM -0700, Stephen Boyd wrote: > Quoting Andy Shevchenko (2024-08-20 03:09:29) > > On Mon, Aug 19, 2024 at 03:38:16PM -0700, Stephen Boyd wrote: ... > > Yeah, I really think that the appearance of this thousandth time in the Git > > history has almost no value and j

[PATCH v7 4/4] drm/msm: Extend gpu devcore dumps with pgtbl info

2024-08-20 Thread Rob Clark
From: Rob Clark In the case of iova fault triggered devcore dumps, include additional debug information based on what we think is the current page tables, including the TTBR0 value (which should match what we have in adreno_smmu_fault_info unless things have gone horribly wrong), and the pagetabl

[PATCH v7 0/4] io-pgtable-arm + drm/msm: Extend iova fault debugging

2024-08-20 Thread Rob Clark
From: Rob Clark This series extends io-pgtable-arm with a method to retrieve the page table entries traversed in the process of address translation, and then beefs up drm/msm gpu devcore dump to include this (and additional info) in the devcore dump. This is a respin of https://patchwork.freedes

Re: [PATCH v3 05/17] usb: typec: Add device managed typec_switch_register()

2024-08-20 Thread Andy Shevchenko
On Tue, Aug 20, 2024 at 10:01:07AM -0700, Stephen Boyd wrote: > Quoting Andy Shevchenko (2024-08-20 03:16:09) > > On Mon, Aug 19, 2024 at 03:38:19PM -0700, Stephen Boyd wrote: > > > + ptr = devres_alloc(devm_typec_switch_unregister, sizeof(*ptr), > > > GFP_KERNEL); > > > + if (!ptr) > > >

Re: [PATCH v3 02/17] drm/bridge: Verify lane assignment is going to work during atomic_check

2024-08-20 Thread Stephen Boyd
Quoting Andy Shevchenko (2024-08-20 03:09:29) > On Mon, Aug 19, 2024 at 03:38:16PM -0700, Stephen Boyd wrote: > > Verify during drm_atomic_bridge_check() that the lane assignment set in > > a bridge's atomic_check() callback is going to be satisfied by the > > previous bridge. If the next bridge is

Re: [PATCH net-next v19 03/13] netdev: support binding dma-buf to netdevice

2024-08-20 Thread Mina Almasry
On Tue, Aug 20, 2024 at 11:19 AM Jakub Kicinski wrote: > > On Tue, 20 Aug 2024 00:01:02 -0400 Mina Almasry wrote: > > Took a bit of a look here. Forgive me, I'm not that familiar with XDP > > and virtual interfaces, so I'm a bit unsure what to do here. > > > > For veth, it seems, the device behind

Re: [PATCH v3 05/17] usb: typec: Add device managed typec_switch_register()

2024-08-20 Thread Stephen Boyd
Quoting Andy Shevchenko (2024-08-20 03:16:09) > On Mon, Aug 19, 2024 at 03:38:19PM -0700, Stephen Boyd wrote: > > + ptr = devres_alloc(devm_typec_switch_unregister, sizeof(*ptr), > > GFP_KERNEL); > > + if (!ptr) > > + return ERR_PTR(-ENOMEM); > > + > > + switch_dev = typec_

Re: [PATCH v6 1/2] drm/ttm: Add a flag to allow drivers to skip clear-on-free

2024-08-20 Thread Nirmoy Das
Hi Thomas, Christian, On 8/20/2024 5:47 PM, Christian König wrote: Am 20.08.24 um 17:45 schrieb Thomas Hellström: On Tue, 2024-08-20 at 17:30 +0200, Christian König wrote: Am 20.08.24 um 15:33 schrieb Thomas Hellström: Hi, Nirmoy, Christian On Fri, 2024-08-16 at 15:51 +0200, Nirmoy Das wrote

Re: [PATCH v4 3/4] dt-bindings: display: rockchip: Add schema for RK3588 HDMI TX Controller

2024-08-20 Thread Conor Dooley
On Tue, Aug 20, 2024 at 03:37:44PM +0300, Cristian Ciocaltea wrote: > On 8/19/24 7:53 PM, Conor Dooley wrote: > > On Mon, Aug 19, 2024 at 01:29:30AM +0300, Cristian Ciocaltea wrote: > >> Rockchip RK3588 SoC integrates the Synopsys DesignWare HDMI 2.1 > >> Quad-Pixel (QP) TX controller IP. > >> > >>

Re: [RFC PATCH 00/17] VKMS: Add configfs support

2024-08-20 Thread José Expósito
Hi Daniel, Thanks a lot for looking into this. On Wed, Aug 14, 2024 at 10:10:39AM +0100, Daniel Stone wrote: > Hi José, > > On Tue, 13 Aug 2024 at 11:51, José Expósito wrote: > > - When a CRTC is added and removed before device creation, there > >is a vblank warning. > >The issue is cau

Re: [PATCH 4/7] drm/ttm: move LRU walk defines into new internal header

2024-08-20 Thread Thomas Hellström
On Tue, 2024-08-20 at 17:45 +0200, Christian König wrote: > Am 20.08.24 um 12:37 schrieb Thomas Hellström: > > Hi, > > > > On Mon, 2024-08-19 at 17:26 +0200, Christian König wrote: > > > Am 19.08.24 um 16:14 schrieb Daniel Vetter: > > > > On Mon, Aug 19, 2024 at 01:38:56PM +0200, Thomas Hellström

Re: [PATCH] drm/amd/gfx11: move the gfx mutex into the caller

2024-08-20 Thread SRINIVASAN SHANMUGAM
On 8/20/2024 8:09 PM, Alex Deucher wrote: Otherwise we can fail to drop the software mutex when we fail to take the hardware mutex. Fixes: 76acba7b7f12 ("drm/amdgpu/gfx11: add a mutex for the gfx semaphore") Reported-by: Dan Carpenter Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amd

Re: [RFC PATCH 00/17] VKMS: Add configfs support

2024-08-20 Thread José Expósito
Hi Louis, Thanks a lot for the review and for your comments! On Tue, Aug 13, 2024 at 07:58:55PM +0200, Louis Chauvet wrote: > Le 13/08/24 - 12:44, José Expósito a écrit : > > Hi everyone, > > Hi José, > > > This RFC implements support to configure VKMS using configfs. > > It allows to: > > >

Re: [PATCH v6 1/2] drm/ttm: Add a flag to allow drivers to skip clear-on-free

2024-08-20 Thread Christian König
Am 20.08.24 um 17:45 schrieb Thomas Hellström: On Tue, 2024-08-20 at 17:30 +0200, Christian König wrote: Am 20.08.24 um 15:33 schrieb Thomas Hellström: Hi, Nirmoy, Christian On Fri, 2024-08-16 at 15:51 +0200, Nirmoy Das wrote: Add TTM_TT_FLAG_CLEARED_ON_FREE, which DRM drivers can set before

Re: [PATCH 4/7] drm/ttm: move LRU walk defines into new internal header

2024-08-20 Thread Christian König
Am 20.08.24 um 12:37 schrieb Thomas Hellström: Hi, On Mon, 2024-08-19 at 17:26 +0200, Christian König wrote: Am 19.08.24 um 16:14 schrieb Daniel Vetter: On Mon, Aug 19, 2024 at 01:38:56PM +0200, Thomas Hellström wrote: Hi, Christian, On Mon, 2024-08-19 at 13:03 +0200, Christian König wrote:

Re: [PATCH v6 1/2] drm/ttm: Add a flag to allow drivers to skip clear-on-free

2024-08-20 Thread Thomas Hellström
On Tue, 2024-08-20 at 17:30 +0200, Christian König wrote: > Am 20.08.24 um 15:33 schrieb Thomas Hellström: > > Hi, Nirmoy, Christian > > > > On Fri, 2024-08-16 at 15:51 +0200, Nirmoy Das wrote: > > > Add TTM_TT_FLAG_CLEARED_ON_FREE, which DRM drivers can set before > > > releasing backing stores i

Re: [PATCH v6 1/2] drm/ttm: Add a flag to allow drivers to skip clear-on-free

2024-08-20 Thread Christian König
Am 20.08.24 um 15:33 schrieb Thomas Hellström: Hi, Nirmoy, Christian On Fri, 2024-08-16 at 15:51 +0200, Nirmoy Das wrote: Add TTM_TT_FLAG_CLEARED_ON_FREE, which DRM drivers can set before releasing backing stores if they want to skip clear-on-free. Cc: Matthew Auld Cc: Thomas Hellström Sugge

[PATCH RFC 6/6] drm/vkms: Extract vkms_composer header

2024-08-20 Thread José Expósito
> The vkms composer functions are defined in a different .c, so make the > same thing for the function declaration in the headers and create > vkms_composer.h. > > Signed-off-by: Louis Chauvet Reviewed-by: José Expósito > --- > drivers/gpu/drm/vkms/vkms_composer.c | 2 ++ > drivers/gpu/drm/

[PATCH RFC 5/6] drm/vkms: Extract vkms_crtc header

2024-08-20 Thread José Expósito
> The vkms crtc functions are defined in a different .c, so make the same The VKMS CRTC... > thing for the function declaration in the headers and create vkms_crtc.h. > > Signed-off-by: Louis Chauvet Reviewed-by: José Expósito > --- > drivers/gpu/drm/vkms/vkms_composer.c | 2 +- > drivers

[PATCH RFC 4/6] drm/vkms: Rename to_vkms_plane_state to avoid confusion

2024-08-20 Thread José Expósito
> The macro to_vkms_plane_state was not explicit about its expected content. > Rename it to drm_plane_state_to_vkms_plane_state to avoid confusion and > help the reader. > > Signed-off-by: Louis Chauvet Reviewed-by: José Expósito > --- > drivers/gpu/drm/vkms/vkms_crtc.c | 2 +- > drivers/gpu

[PATCH RFC 3/6] drm/vkms: Extract vkms_plane header

2024-08-20 Thread José Expósito
> In order to properly split vkms_output function, extract all > its function to its own header. > > Signed-off-by: Louis Chauvet Reviewed-by: José Expósito > --- > drivers/gpu/drm/vkms/vkms_crtc.c | 2 ++ > drivers/gpu/drm/vkms/vkms_drv.h | 56 -- > dr

[PATCH RFC 2/6] drm/vkms: Extract vkms_writeback header

2024-08-20 Thread José Expósito
> The vkms writeback functions are defined in a different .c, so > make the same thing for the function declaration in the headers and create > vkms_writeback.h. > > Signed-off-by: Louis Chauvet Reviewed-by: José Expósito > --- > drivers/gpu/drm/vkms/vkms_composer.c | 1 + > drivers/gpu/drm

[PATCH RFC 1/6] drm/vkms: Properly extract vkms_formats header

2024-08-20 Thread José Expósito
Hi Louis, Thanks for refactoring this, it make things a bit easier to find. I already reviewed this series on your GitHub fork, but I'm adding the missing fixes here as well so we can discusse them in the right forum. Since these patches only move code around, I wonder if it'd make sense to merg

Re: [PATCH net-next v19 03/13] netdev: support binding dma-buf to netdevice

2024-08-20 Thread Jakub Kicinski
On Tue, 20 Aug 2024 00:01:02 -0400 Mina Almasry wrote: > Took a bit of a look here. Forgive me, I'm not that familiar with XDP > and virtual interfaces, so I'm a bit unsure what to do here. > > For veth, it seems, the device behind the veth is stored in > veth_priv->peer, so it seems maybe a dev_g

Re: [PATCH] drm/amd/gfx11: move the gfx mutex into the caller

2024-08-20 Thread Dan Carpenter
On Tue, Aug 20, 2024 at 10:39:09AM -0400, Alex Deucher wrote: > Otherwise we can fail to drop the software mutex when > we fail to take the hardware mutex. > > Fixes: 76acba7b7f12 ("drm/amdgpu/gfx11: add a mutex for the gfx semaphore") > Reported-by: Dan Carpenter > Signed-off-by: Alex Deucher

[PATCH] drm/amd/gfx11: move the gfx mutex into the caller

2024-08-20 Thread Alex Deucher
Otherwise we can fail to drop the software mutex when we fail to take the hardware mutex. Fixes: 76acba7b7f12 ("drm/amdgpu/gfx11: add a mutex for the gfx semaphore") Reported-by: Dan Carpenter Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 7 +++ 1 file changed, 3

Re: [PATCH v2 2/2] drm/virtio: Fix host color format for big endian guests

2024-08-20 Thread Javier Martinez Canillas
Jocelyn Falempe writes: > On 20/08/2024 14:48, Thomas Zimmermann wrote: >> Hi >> >> Am 20.08.24 um 11:07 schrieb Jocelyn Falempe: >>> The colors are inverted when testing a s390x VM on a s390x host. >>> Changing the conversion from DRM_FORMAT -> VIRTIO_GPU_FORMAT on big >>> endian guests fixes t

[PATCH] gpu: drm: Use devm_clk_get_enabled() helpers

2024-08-20 Thread Rong Qianfeng
Replace devm_clk_get() and clk_prepare_enable() with devm_clk_get_enabled() that also disables and unprepares it on driver detach. Signed-off-by: Rong Qianfeng --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 13 +++-- drivers/gpu/drm/sun4i/sun6i_drc.c | 15 --- driv

[PATCH -next] backlight: ktz8866: fix module autoloading

2024-08-20 Thread Liao Chen
Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based on the alias from of_device_id table. Signed-off-by: Liao Chen --- drivers/video/backlight/ktz8866.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/backlight/ktz8866.c b/drivers/video/backlight/ktz8866.c

Re: [PATCH v6 1/2] drm/ttm: Add a flag to allow drivers to skip clear-on-free

2024-08-20 Thread Nirmoy Das
On 8/20/2024 3:33 PM, Thomas Hellström wrote: Hi, Nirmoy, Christian On Fri, 2024-08-16 at 15:51 +0200, Nirmoy Das wrote: Add TTM_TT_FLAG_CLEARED_ON_FREE, which DRM drivers can set before releasing backing stores if they want to skip clear-on-free. Cc: Matthew Auld Cc: Thomas Hellström Sugg

Re: [PATCH v6] drm/i915/hwmon: expose fan speed

2024-08-20 Thread Andy Shevchenko
On Tue, Aug 20, 2024 at 04:12:46PM +0300, Raag Jadav wrote: > On Tue, Aug 20, 2024 at 01:23:35PM +0300, Andy Shevchenko wrote: > > On Tue, Aug 20, 2024 at 11:50:10AM +0530, Raag Jadav wrote: ... > > > v6: Drop overflow logic (Andy) > > > Aesthetic adjustments (Badal) > > > > But it still has

Re: [PATCH] gpu: drm: Use devm_clk_get_enabled() helpers

2024-08-20 Thread Chen-Yu Tsai
On Tue, Aug 20, 2024 at 8:59 PM Rong Qianfeng wrote: > > Replace devm_clk_get() and clk_prepare_enable() with > devm_clk_get_enabled() that also disables and unprepares it on > driver detach. > > Signed-off-by: Rong Qianfeng > --- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 13 +++-- >

Re: [PATCH 2/7] drm/msm: Add submitqueue setup and close

2024-08-20 Thread Antonino Maniscalco
On 8/20/24 12:10 PM, Konrad Dybcio wrote: On 15.08.2024 8:26 PM, Antonino Maniscalco wrote: This patch adds a bit of infrastructure to give the different Adreno targets the flexibility to setup the submitqueues per their needs. Signed-off-by: Sharat Masetty --- This email doesn't exist anymo

[PATCH] Revert "drm/ttm: increase ttm pre-fault value to PMD size"

2024-08-20 Thread Alex Deucher
This reverts commit 0ddd2ae586d28e521d37393364d989ce118802e0. This patch causes sluggishness and stuttering in graphical apps. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3564 Link: https://www.spinics.net/lists/dri-devel/msg457005.html Signed-off-by: Alex Deucher Cc: Zhu Lingshan C

Re: [PATCH v2] drm/i915/gt: Use kmemdup_array instead of kmemdup for multiple allocation

2024-08-20 Thread Andi Shyti
Hi Lucas, On Tue, Aug 20, 2024 at 07:53:10AM -0500, Lucas De Marchi wrote: > On Tue, Aug 20, 2024 at 05:53:02PM GMT, Yu Jiaoliang wrote: > > Let the kememdup_array() take care about multiplication and possible > > overflows. > > > > v2: > > - Change subject > > - Leave one blank line between the

Re: [PATCH v6 2/2] drm/xe/lnl: Offload system clear page activity to GPU

2024-08-20 Thread Thomas Hellström
Hi, Nirmoy, On Mon, 2024-08-19 at 18:01 +0200, Nirmoy Das wrote: > > On 8/19/2024 1:05 PM, Matthew Auld wrote: > > On 16/08/2024 14:51, Nirmoy Das wrote: > > > On LNL because of flat CCS, driver creates migrates job to clear > > > CCS meta data. Extend that to also clear system pages using GPU. >

Re: [PATCH v3 0/3] drm/amdgpu: Explicit sync for GEM VA operations

2024-08-20 Thread Sharma, Shashank
Hey Christian, On 19/08/2024 13:21, Christian König wrote: Am 19.08.24 um 09:21 schrieb Friedrich Vock: In Vulkan, it is the application's responsibility to perform adequate synchronization before a sparse unmap, replace or BO destroy operation. This adds an option to AMDGPU_VA_OPs to disable r

Re: [PATCH v6 1/2] drm/ttm: Add a flag to allow drivers to skip clear-on-free

2024-08-20 Thread Thomas Hellström
Hi, Nirmoy, Christian On Fri, 2024-08-16 at 15:51 +0200, Nirmoy Das wrote: > Add TTM_TT_FLAG_CLEARED_ON_FREE, which DRM drivers can set before > releasing backing stores if they want to skip clear-on-free. > > Cc: Matthew Auld > Cc: Thomas Hellström > Suggested-by: Christian König > Signed-off

Re: [PATCH v2 2/2] drm/virtio: Fix host color format for big endian guests

2024-08-20 Thread Thomas Zimmermann
Hi Am 20.08.24 um 14:55 schrieb Jocelyn Falempe: On 20/08/2024 14:48, Thomas Zimmermann wrote: Hi Am 20.08.24 um 11:07 schrieb Jocelyn Falempe: The colors are inverted when testing a s390x VM on a s390x host. Changing the conversion from DRM_FORMAT -> VIRTIO_GPU_FORMAT on big endian guests fi

Re: [PATCH v6] drm/i915/hwmon: expose fan speed

2024-08-20 Thread Raag Jadav
On Tue, Aug 20, 2024 at 01:23:35PM +0300, Andy Shevchenko wrote: > On Tue, Aug 20, 2024 at 11:50:10AM +0530, Raag Jadav wrote: > > Add hwmon support for fan1_input attribute, which will expose fan speed > > in RPM. With this in place we can monitor fan speed using lm-sensors tool. > > > > $ sensor

Re: [PATCH v2 2/2] drm/virtio: Fix host color format for big endian guests

2024-08-20 Thread Jocelyn Falempe
On 20/08/2024 14:48, Thomas Zimmermann wrote: Hi Am 20.08.24 um 11:07 schrieb Jocelyn Falempe: The colors are inverted when testing a s390x VM on a s390x host. Changing the conversion from DRM_FORMAT -> VIRTIO_GPU_FORMAT on big endian guests fixes the colors. But it may break big-endian guest o

Re: [PATCH v2] drm/i915/gt: Use kmemdup_array instead of kmemdup for multiple allocation

2024-08-20 Thread Lucas De Marchi
On Tue, Aug 20, 2024 at 05:53:02PM GMT, Yu Jiaoliang wrote: Let the kememdup_array() take care about multiplication and possible overflows. v2: - Change subject - Leave one blank line between the commit log and the tag section - Fix code alignment issue Signed-off-by: Yu Jiaoliang Reviewed-by:

Re: [PATCH v2 2/2] drm/virtio: Fix host color format for big endian guests

2024-08-20 Thread Thomas Zimmermann
Hi Am 20.08.24 um 11:07 schrieb Jocelyn Falempe: The colors are inverted when testing a s390x VM on a s390x host. Changing the conversion from DRM_FORMAT -> VIRTIO_GPU_FORMAT on big endian guests fixes the colors. But it may break big-endian guest on little-endian host. In this case, the fix sho

Re: [82/86] drm/i915: Move custom hotplug code into separate callback

2024-08-20 Thread Thomas Zimmermann
Hi Am 20.08.24 um 12:39 schrieb Sui Jingfeng: Besides, a lot of DRM driver instances has the DMA/2D acceleration hardware, promote it into drm_driver structure may has the potential to utilize hardware acceleration. Drivers will more easily to have custom implementation. I'm not 100% sure if

Re: [PATCH v4 3/4] dt-bindings: display: rockchip: Add schema for RK3588 HDMI TX Controller

2024-08-20 Thread Cristian Ciocaltea
On 8/19/24 7:53 PM, Conor Dooley wrote: > On Mon, Aug 19, 2024 at 01:29:30AM +0300, Cristian Ciocaltea wrote: >> Rockchip RK3588 SoC integrates the Synopsys DesignWare HDMI 2.1 >> Quad-Pixel (QP) TX controller IP. >> >> Since this is a new IP block, quite different from those used in the >> previou

Re: [PATCH 1/3] dt-bindings: display: mediatek: dpi: Add power domains

2024-08-20 Thread Rohit Agarwal
On 20/08/24 4:40 PM, Krzysztof Kozlowski wrote: On Tue, Aug 20, 2024 at 08:06:57AM +, Rohit Agarwal wrote: Add power domain binding to the mediatek DPI controller. Why? Who needs it? Why all devices suddenly have it (IOW, why is it not constrained anyhow per variant)? Ok, my intent was

Re: [PATCH 40/86] drm/stm: Run DRM default client setup

2024-08-20 Thread Raphael Gallais-Pou
On 8/16/24 14:23, Thomas Zimmermann wrote: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: Yannick Fertre > Cc: Raphael Ga

Re: [PATCH 1/7] drm/msm: Fix bv_fence being used as bv_rptr

2024-08-20 Thread Konrad Dybcio
On 20.08.2024 12:45 PM, Connor Abbott wrote: > On Tue, Aug 20, 2024 at 11:15 AM Konrad Dybcio wrote: >> >> On 15.08.2024 8:26 PM, Antonino Maniscalco wrote: >>> The bv_fence field of rbmemptrs was being used incorrectly as the BV >>> rptr shadow pointer in some places. >>> >>> Add a bv_rptr field

Re: [PATCH v3 2/2] drm/panfrost: Add cycle counter job requirement

2024-08-20 Thread Heiko Stübner
Am Montag, 19. August 2024, 10:02:23 CEST schrieb Mary Guillemard: > Extend the uAPI with a new job requirement flag for cycle > counters. This requirement is used by userland to indicate that a job > requires cycle counters or system timestamp to be propagated. (for use > with write value timestam

Re: [PATCH 1/3] dt-bindings: display: mediatek: dpi: Add power domains

2024-08-20 Thread Krzysztof Kozlowski
On Tue, Aug 20, 2024 at 08:06:57AM +, Rohit Agarwal wrote: > Add power domain binding to the mediatek DPI controller. Why? Who needs it? Why all devices suddenly have it (IOW, why is it not constrained anyhow per variant)? > > Signed-off-by: Rohit Agarwal > --- > .../devicetree/bindings/di

Re: [PATCH v2] drm/i915/gt: Use kmemdup_array instead of kmemdup for multiple allocation

2024-08-20 Thread Andi Shyti
Hi, On Tue, Aug 20, 2024 at 05:53:02PM +0800, Yu Jiaoliang wrote: > Let the kememdup_array() take care about multiplication and possible > overflows. > > v2: > - Change subject > - Leave one blank line between the commit log and the tag section > - Fix code alignment issue > > Signed-off-by: Yu

Re: [PATCH 6/7] drm/msm/A6XX: Add a flag to allow preemption to submitqueue_create

2024-08-20 Thread Connor Abbott
On Mon, Aug 19, 2024 at 9:31 PM Akhil P Oommen wrote: > > On Thu, Aug 15, 2024 at 08:26:16PM +0200, Antonino Maniscalco wrote: > > Some userspace changes are necessary so add a flag for userspace to > > advertise support for preemption. > > So the intention is to fallback to level 0 preemption unt

Re: [PATCH 1/7] drm/msm: Fix bv_fence being used as bv_rptr

2024-08-20 Thread Connor Abbott
On Tue, Aug 20, 2024 at 11:15 AM Konrad Dybcio wrote: > > On 15.08.2024 8:26 PM, Antonino Maniscalco wrote: > > The bv_fence field of rbmemptrs was being used incorrectly as the BV > > rptr shadow pointer in some places. > > > > Add a bv_rptr field and change the code to use that instead. > > > >

Re: [82/86] drm/i915: Move custom hotplug code into separate callback

2024-08-20 Thread Sui Jingfeng
Hi, On 2024/8/20 15:39, Thomas Zimmermann wrote: Hi Am 19.08.24 um 10:52 schrieb Sui Jingfeng: Hi, Thomas I love your patch, yet ... On 2024/8/16 20:23, Thomas Zimmermann wrote: i915's fbdev contains additional code for hotplugging a display that cannot be ported to the common fbdev clie

  1   2   >