Re: [PATCH 1/3] fault-inject: improve build for CONFIG_FAULT_INJECTION=n

2024-08-13 Thread Jani Nikula
On Tue, 13 Aug 2024, Andrew Morton wrote: > On Tue, 13 Aug 2024 15:12:35 +0300 Jani Nikula wrote: > >> The fault-inject.h users across the kernel need to add a lot of #ifdef >> CONFIG_FAULT_INJECTION to cater for shortcomings in the header. Make >> fault-inject.h self-contained for CONFIG_FAULT_I

Re: [PATCH v2] drm/xe/uapi: Bring back reset uevent

2024-08-13 Thread Aravind Iddamsetty
On 13/08/24 22:24, Rodrigo Vivi wrote: > On Tue, Aug 13, 2024 at 04:28:32PM +0300, Raag Jadav wrote: >> On Mon, Aug 12, 2024 at 03:08:14PM +0530, Aravind Iddamsetty wrote: >>> On 12/08/24 13:18, Raag Jadav wrote: From: Himal Prasad Ghimiray This was dropped in commit 77a0d4d1cea2

Re: [PATCH v2] drm/xe/uapi: Bring back reset uevent

2024-08-13 Thread Aravind Iddamsetty
On 13/08/24 19:43, Lucas De Marchi wrote: > On Mon, Aug 12, 2024 at 01:18:12PM GMT, Raag Jadav wrote: >> From: Himal Prasad Ghimiray >> >> This was dropped in commit 77a0d4d1cea2 ("drm/xe/uapi: Remove reset >> uevent for now") as part of refactoring. >> >> Now that we have better uapi semantics

Re: [PATCH] drm/sched: Only start TDR in drm_sched_job_begin on first job

2024-08-13 Thread Matthew Brost
On Thu, Jul 25, 2024 at 02:50:54PM +, Matthew Brost wrote: > On Thu, Jul 25, 2024 at 09:42:08AM +0200, Christian König wrote: > > Am 25.07.24 um 01:44 schrieb Matthew Brost: > > > Only start in drm_sched_job_begin on first job being added to the > > > pending list as if pending list non-empty t

Re: [PATCH v6 0/4] drm: Use full allocated minor range for DRM

2024-08-13 Thread James Zhu
Hi Michal I did give Tested-by before. If you need Acks, Here  I can give Acked-by: James Zhu for the series Best Regards! James On 2024-08-13 20:18, Michał Winiarski wrote: On Mon, Aug 12, 2024 at 01:38:38PM GMT, Alex Deucher wrote: Are there any objections to this series? We have been ru

Re: [PATCH v6 0/4] drm: Use full allocated minor range for DRM

2024-08-13 Thread James Zhu
Hi Michal I did give Tested-by before. If you need Acks, Here I can give Acked-by:JamesZhufortheseries Best Regards! James On 2024-08-13 20:18, Michał Winiarski wrote: On Mon, Aug 12, 2024 at 01:38:38PM GMT, Alex Deucher wrote: Are there any objections to this series? We have been running

[PATCH] drm/exynos: Remove unnecessary code

2024-08-13 Thread Kwanghoon Son
Function usage exynos_atomic_commit was removed in commit 41cbf0fdaa28 ("drm/exynos: use atomic helper commit"). Remove unnecessary function declare. Signed-off-by: Kwanghoon Son --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/ex

Re: [RESEND 1/2] drm/i915/gvt: stop using drm_edid_block_valid()

2024-08-13 Thread Zhenyu Wang
On 2024.08.12 17:28:48 +0300, Jani Nikula wrote: > We'll want to stop drm_edid_block_valid() usage. KVMGT is the last > user. Replace with drm_edid_valid(), which unfortunately requires an > allocated drm_edid. However, on the plus side, this would be required to > handle the TODO comment about EDI

Re: [PATCH v6 7/9] tracing: Replace strncpy() with strscpy()

2024-08-13 Thread Yafang Shao
On Wed, Aug 14, 2024 at 6:31 AM Justin Stitt wrote: > > On Tue, Aug 13, 2024 at 3:19 PM Justin Stitt wrote: > > > > Hi, > > > > On Mon, Aug 12, 2024 at 10:29:31AM GMT, Yafang Shao wrote: > > > Using strscpy() to read the task comm ensures that the name is > > > always NUL-terminated, regardless o

Re: [PATCH 0/3] drm/vmwgfx: Add support for userspace managed surfaces.

2024-08-13 Thread Zack Rusin
On Mon, Aug 12, 2024 at 3:16 PM Maaz Mombasawala wrote: > > This series introduces basic support for userspace managed surfaces. The > lifetime and id's of these surfaces is managed by userspace submitted > commands instead of relying on the kernel to manage them. > > Maaz Mombasawala (3): > drm

Re: [PATCH 1/3] fault-inject: improve build for CONFIG_FAULT_INJECTION=n

2024-08-13 Thread Andrew Morton
On Tue, 13 Aug 2024 15:12:35 +0300 Jani Nikula wrote: > The fault-inject.h users across the kernel need to add a lot of #ifdef > CONFIG_FAULT_INJECTION to cater for shortcomings in the header. Make > fault-inject.h self-contained for CONFIG_FAULT_INJECTION=n, and add > stubs for DECLARE_FAULT_ATT

Re: [PATCH 0/2] Allow partial memory mapping for cpu memory

2024-08-13 Thread Matthew Brost
On Tue, Aug 13, 2024 at 07:08:02PM +, Matthew Brost wrote: > On Tue, Aug 13, 2024 at 04:09:55PM +0200, Daniel Vetter wrote: > > On Tue, Aug 13, 2024 at 02:54:31AM +, Matthew Brost wrote: > > > On Mon, Aug 12, 2024 at 04:45:32PM +0200, Daniel Vetter wrote: > > > > On Mon, Aug 12, 2024 at 01:

Re: [syzbot] [mm?] kernel BUG in filemap_unaccount_folio

2024-08-13 Thread syzbot
syzbot suspects this issue was fixed by commit: commit 7d79cd784470395539bda91bf0b3505ff5b2ab6d Author: Vivek Kasireddy Date: Mon Jun 24 06:36:13 2024 + udmabuf: use vmf_insert_pfn and VM_PFNMAP for handling mmap bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=17dad691980

Re: [PATCH] drm/vmwgfx: Trigger a modeset when the screen moves

2024-08-13 Thread Maaz Mombasawala
On 6/24/24 13:59, Ian Forbes wrote: > When multi-monitor is cycled the X,Y position of the Screen Target will > likely change but the resolution will not. We need to trigger a modeset > when this occurs in order to recreate the Screen Target with the correct > X,Y position. > > Fixes a bug where m

Re: [PATCH] drm/vmwgfx: Bump the minor version of the driver

2024-08-13 Thread Maaz Mombasawala
On 7/22/24 21:35, Zack Rusin wrote: > Provide a way to query for the fixed support for dumb buffers with kms. > > Lets mesa svga return a buffer id, instead of a surface id from > resource_to_handle which fixes a lot of userspace apps that assume > that those handles are gem buffers. > > Signed-o

Re: [PATCH v6 0/4] drm: Use full allocated minor range for DRM

2024-08-13 Thread Michał Winiarski
On Mon, Aug 12, 2024 at 01:38:38PM GMT, Alex Deucher wrote: > Are there any objections to this series? We have been running into > this limit as a problem for a while now on big servers. I don't think there were any objections, just a general lack of interest - so there are no R-b / Acks. If you'

Re: [PATCH v6 7/9] tracing: Replace strncpy() with strscpy()

2024-08-13 Thread Justin Stitt
On Tue, Aug 13, 2024 at 3:19 PM Justin Stitt wrote: > > Hi, > > On Mon, Aug 12, 2024 at 10:29:31AM GMT, Yafang Shao wrote: > > Using strscpy() to read the task comm ensures that the name is > > always NUL-terminated, regardless of the source string. This approach also > > facilitates future extens

Re: [PATCH v6 7/9] tracing: Replace strncpy() with strscpy()

2024-08-13 Thread Justin Stitt
Hi, On Mon, Aug 12, 2024 at 10:29:31AM GMT, Yafang Shao wrote: > Using strscpy() to read the task comm ensures that the name is > always NUL-terminated, regardless of the source string. This approach also > facilitates future extensions to the task comm. Thanks for sending patches replacing str{n

Re: [PATCH 2/2] mtd: rawnand: nuvoton: add new driver for the Nuvoton MA35 SoC

2024-08-13 Thread kernel test robot
Hi Hui-Ping, kernel test robot noticed the following build warnings: [auto build test WARNING on mtd/nand/next] [also build test WARNING on linus/master v6.11-rc3 next-20240813] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[PATCH v2 0/5] Panthor devcoredump support

2024-08-13 Thread Daniel Almeida
Hi all. I will refrain from writing a changelog here, since I have rewritten this series from the ground up in C. I removed the Rust-for-Linux people from the loop for now, since this has become a bit tangential to Rust. Lastly, this is no longer RFC. For those looking for a branch instead, plea

[PATCH net-next v19 12/13] selftests: add ncdevmem, netcat for devmem TCP

2024-08-13 Thread Mina Almasry
ncdevmem is a devmem TCP netcat. It works similarly to netcat, but it sends and receives data using the devmem TCP APIs. It uses udmabuf as the dmabuf provider. It is compatible with a regular netcat running on a peer, or a ncdevmem running on a peer. In addition to normal netcat support, ncdevmem

[PATCH net-next v19 13/13] netdev: add dmabuf introspection

2024-08-13 Thread Mina Almasry
Add dmabuf information to page_pool stats: $ ./cli.py --spec ../netlink/specs/netdev.yaml --dump page-pool-get ... {'dmabuf': 10, 'id': 456, 'ifindex': 3, 'inflight': 1023, 'inflight-mem': 4190208}, {'dmabuf': 10, 'id': 455, 'ifindex': 3, 'inflight': 1023, 'inflight-mem': 4190208

[PATCH net-next v19 11/13] net: add devmem TCP documentation

2024-08-13 Thread Mina Almasry
Add documentation outlining the usage and details of devmem TCP. Signed-off-by: Mina Almasry Reviewed-by: Bagas Sanjaya Reviewed-by: Donald Hunter --- v16: - Add documentation on unbinding the NIC from dmabuf (Donald). - Add note that any dmabuf should work (Donald). v9: https://lore.kernel

[PATCH net-next v19 09/13] tcp: RX path for devmem TCP

2024-08-13 Thread Mina Almasry
In tcp_recvmsg_locked(), detect if the skb being received by the user is a devmem skb. In this case - if the user provided the MSG_SOCK_DEVMEM flag - pass it to tcp_recvmsg_devmem() for custom handling. tcp_recvmsg_devmem() copies any data in the skb header to the linear buffer, and returns a cmsg

[PATCH net-next v19 10/13] net: add SO_DEVMEM_DONTNEED setsockopt to release RX frags

2024-08-13 Thread Mina Almasry
Add an interface for the user to notify the kernel that it is done reading the devmem dmabuf frags returned as cmsg. The kernel will drop the reference on the frags to make them available for reuse. Signed-off-by: Willem de Bruijn Signed-off-by: Kaiyuan Zhang Signed-off-by: Mina Almasry Reviewe

[PATCH net-next v19 08/13] net: add support for skbs with unreadable frags

2024-08-13 Thread Mina Almasry
For device memory TCP, we expect the skb headers to be available in host memory for access, and we expect the skb frags to be in device memory and unaccessible to the host. We expect there to be no mixing and matching of device memory frags (unaccessible) with host memory frags (accessible) in the

[PATCH net-next v19 07/13] net: support non paged skb frags

2024-08-13 Thread Mina Almasry
Make skb_frag_page() fail in the case where the frag is not backed by a page, and fix its relevant callers to handle this case. Signed-off-by: Mina Almasry Reviewed-by: Eric Dumazet --- v10: - Fixed newly generated kdoc warnings found by patchwork. While we're at it, fix the Return section

[PATCH net-next v19 06/13] memory-provider: dmabuf devmem memory provider

2024-08-13 Thread Mina Almasry
Implement a memory provider that allocates dmabuf devmem in the form of net_iov. The provider receives a reference to the struct netdev_dmabuf_binding via the pool->mp_priv pointer. The driver needs to set this pointer for the provider in the net_iov. The provider obtains a reference on the netde

[PATCH net-next v19 04/13] netdev: netdevice devmem allocator

2024-08-13 Thread Mina Almasry
Implement netdev devmem allocator. The allocator takes a given struct netdev_dmabuf_binding as input and allocates net_iov from that binding. The allocation simply delegates to the binding's genpool for the allocation logic and wraps the returned memory region in a net_iov struct. Signed-off-by:

[PATCH net-next v19 05/13] page_pool: devmem support

2024-08-13 Thread Mina Almasry
Convert netmem to be a union of struct page and struct netmem. Overload the LSB of struct netmem* to indicate that it's a net_iov, otherwise it's a page. Currently these entries in struct page are rented by the page_pool and used exclusively by the net stack: struct { unsigned long pp_mag

[PATCH net-next v19 03/13] netdev: support binding dma-buf to netdevice

2024-08-13 Thread Mina Almasry
Add a netdev_dmabuf_binding struct which represents the dma-buf-to-netdevice binding. The netlink API will bind the dma-buf to rx queues on the netdevice. On the binding, the dma_buf_attach & dma_buf_map_attachment will occur. The entries in the sg_table from mapping will be inserted into a genpool

[PATCH net-next v19 01/13] netdev: add netdev_rx_queue_restart()

2024-08-13 Thread Mina Almasry
Add netdev_rx_queue_restart(), which resets an rx queue using the queue API recently merged[1]. The queue API was merged to enable the core net stack to reset individual rx queues to actuate changes in the rx queue's configuration. In later patches in this series, we will use netdev_rx_queue_resta

[PATCH net-next v19 02/13] net: netdev netlink api to bind dma-buf to a net device

2024-08-13 Thread Mina Almasry
API takes the dma-buf fd as input, and binds it to the netdevice. The user can specify the rx queues to bind the dma-buf to. Suggested-by: Stanislav Fomichev Signed-off-by: Mina Almasry Reviewed-by: Donald Hunter Reviewed-by: Jakub Kicinski --- v16: - Use subset-of: queue queue-id instead of

[PATCH net-next v19 00/13] Device Memory TCP

2024-08-13 Thread Mina Almasry
v19: https://patchwork.kernel.org/project/netdevbpf/list/?series=876852&state=* v18 got a thorough review (thanks!), and this iteration addresses the feedback. Major changes: - Prevent deactivating mp bound queues. - Prevent installing xdp on mp bound netdevs, or installing mps on xdp inst

Re: [PATCH V2 01/16] firmware: raspberrypi: Improve timeout warning

2024-08-13 Thread Florian Fainelli
From: Florian Fainelli On Sun, 28 Jul 2024 13:41:45 +0200, Stefan Wahren wrote: > Recent work on raspberry-power driver showed that even the > stacktrace on firmware property timeout doesn't provide > enough information. So add the first tag name to the warning > to be in line with a status erro

Re: [PATCH v1] drm/ci: enable lockdep detection

2024-08-13 Thread Helen Mae Koike Fornazier
On Tue, 13 Aug 2024 02:26:48 -0300 Vignesh Raman wrote --- > Hi Helen, > > On 13/08/24 01:47, Helen Mae Koike Fornazier wrote: > > > > Hi Vignesh, > > > > Thanks for your patch. > > > > > > On Mon, 12 Aug 2024 08:20:28 -0300 Vignesh Raman wrote --- > > > >

Re: [PATCH v1] drm/ci: uprev mesa

2024-08-13 Thread Helen Mae Koike Fornazier
On Wed, 07 Aug 2024 09:33:10 -0300 Daniel Stone wrote --- > On Wed, 7 Aug 2024 at 09:21, Vignesh Raman vignesh.ra...@collabora.com> > wrote: > > Uprev mesa to adapt to the latest changes in mesa ci. > > Project 'anholt/deqp-runner' was moved to 'mesa/deqp-runner'. > > So update

Re: [PATCH] drm/ci: Upgrade setuptools requirement to 70.0.0

2024-08-13 Thread Helen Mae Koike Fornazier
On Wed, 17 Jul 2024 08:06:18 -0300 Helen Koike wrote --- > > > On 16/07/2024 05:37, WangYuli wrote: > > GitHub Dependabot has issued the following alert: > > > > "Upgrade setuptools to version 70.0.0 or later. > > > > A vulnerability in the package_index module of pypa/

Re: [PATCH V2 14/16] WIP: usb: dwc2: Implement recovery after PM domain off

2024-08-13 Thread Doug Anderson
Hi, On Mon, Aug 12, 2024 at 4:48 PM Stefan Wahren wrote: > > Hi Doug, > > Am 28.07.24 um 15:00 schrieb Stefan Wahren: > > DO NOT MERGE > > > > According to the dt-bindings there are some platforms, which have a > > dedicated USB power domain for DWC2 IP core supply. If the power domain > > is swi

[PATCH] drm/exynos: cleanup header include

2024-08-13 Thread Kwanghoon Son
-#include "exynos_drm_fbdev.h" static int check_fb_gem_memory_type(struct drm_device *drm_dev, struct exynos_drm_gem *exynos_gem) --- base-commit: 7c626ce4bae1ac14f60076d00eafe71af30450ba change-id: 20240813-clean_header-863930a8f82f Best regards, -- Kwanghoon Son

Re: bisected/regression: choopy youtube video on Ryzen IGP - 0ddd2ae586d2 drm/ttm: increase ttm pre-fault value to PMD size

2024-08-13 Thread John Rowley
Apologies for resurrecting an old thread, but I'm experiencing the same issue. For me it manifests mostly as choppy scrolling in Mullvad Browser (Flatpak), also Firefox. E.g. on https://github.com/dandavison/delta, when trackpad flick-scrolling down the page, it's quite smooth up until the sectio

Re: [PATCH v3 2/4] drm: renesas: rz-du: Add RZ/G2UL DU Support

2024-08-13 Thread Laurent Pinchart
Hi Biju, Thank you for the patch. On Mon, Aug 05, 2024 at 04:52:36PM +0100, Biju Das wrote: > The LCD controller is composed of Frame Compression Processor (FCPVD), > Video Signal Processor (VSPD), and Display Unit (DU). > > It has DPI interface and supports a maximum resolution of WXGA along >

XDC 2024: Call for Proposals deadline extended to August 19

2024-08-13 Thread Mark Filion
Hello! The CfP deadline for talks, workshops and demos at XDC 2024 has been extended to next Monday, 19 August 2024.  You have one more week to submit, don't wait! https://indico.freedesktop.org/event/6/abstracts/ While any serious proposal will be gratefully considered, topics of interest to X

Re: [PATCH v3 1/4] dt-bindings: display: renesas,rzg2l-du: Document RZ/G2UL DU bindings

2024-08-13 Thread Laurent Pinchart
Hi Rob, On Tue, Aug 13, 2024 at 10:32:20AM -0600, Rob Herring wrote: > On Mon, Aug 05, 2024 at 04:52:35PM +0100, Biju Das wrote: > > Document DU found in RZ/G2UL SoC. The DU block is identical to RZ/G2L > > SoC, but has only DPI interface. > > > > While at it, add missing required property port@1

Re: [PATCH v3 4/5] drm/sched: Use drm sched lockdep map for submit_wq

2024-08-13 Thread Matthew Brost
On Mon, Aug 12, 2024 at 11:05:31AM +0530, Ghimiray, Himal Prasad wrote: > > > On 10-08-2024 03:58, Matthew Brost wrote: > > Avoid leaking a lockdep map on each drm sched creation and destruction > > by using a single lockdep map for all drm sched allocated submit_wq. > > > > v2: > > - Use allo

Re: [PATCH 0/2] Allow partial memory mapping for cpu memory

2024-08-13 Thread Matthew Brost
On Tue, Aug 13, 2024 at 04:09:55PM +0200, Daniel Vetter wrote: > On Tue, Aug 13, 2024 at 02:54:31AM +, Matthew Brost wrote: > > On Mon, Aug 12, 2024 at 04:45:32PM +0200, Daniel Vetter wrote: > > > On Mon, Aug 12, 2024 at 01:51:30PM +0200, Andi Shyti wrote: > > > > Hi Daniel, > > > > > > > > On

Re: [PATCH v3 3/5] workqueue: Add interface for user-defined workqueue lockdep map

2024-08-13 Thread Tejun Heo
On Fri, Aug 09, 2024 at 03:28:25PM -0700, Matthew Brost wrote: > Add an interface for a user-defined workqueue lockdep map, which is > helpful when multiple workqueues are created for the same purpose. This > also helps avoid leaking lockdep maps on each workqueue creation. > > v2: > - Add alloc_

Re: [PATCH v3 3/5] workqueue: Add interface for user-defined workqueue lockdep map

2024-08-13 Thread Tejun Heo
On Tue, Aug 13, 2024 at 06:55:20PM +, Matthew Brost wrote: > On Tue, Aug 13, 2024 at 08:52:26AM -1000, Tejun Heo wrote: > > On Fri, Aug 09, 2024 at 03:28:25PM -0700, Matthew Brost wrote: > > > Add an interface for a user-defined workqueue lockdep map, which is > > > helpful when multiple workqu

Re: [PATCH v3 3/5] workqueue: Add interface for user-defined workqueue lockdep map

2024-08-13 Thread Matthew Brost
On Tue, Aug 13, 2024 at 08:52:26AM -1000, Tejun Heo wrote: > On Fri, Aug 09, 2024 at 03:28:25PM -0700, Matthew Brost wrote: > > Add an interface for a user-defined workqueue lockdep map, which is > > helpful when multiple workqueues are created for the same purpose. This > > also helps avoid leakin

Re: [PATCH v3 3/5] workqueue: Add interface for user-defined workqueue lockdep map

2024-08-13 Thread Tejun Heo
On Fri, Aug 09, 2024 at 03:28:25PM -0700, Matthew Brost wrote: > Add an interface for a user-defined workqueue lockdep map, which is > helpful when multiple workqueues are created for the same purpose. This > also helps avoid leaking lockdep maps on each workqueue creation. > > v2: > - Add alloc_

Re: [PATCH 1/2] Documentation/gpu: Document the situation with unqualified drm-memory-

2024-08-13 Thread Rob Clark
On Tue, Aug 13, 2024 at 6:57 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Currently it is not well defined what is drm-memory- compared to other > categories. > > In practice the only driver which emits these keys is amdgpu and in them > exposes the current resident buffer object memory

Re: [PATCH v2 2/2] drm/panel: jdi-fhd-r63452: transition to mipi_dsi wrapped functions

2024-08-13 Thread Doug Anderson
Hi, On Mon, Aug 12, 2024 at 11:31 PM Tejas Vipin wrote: > > Changes the jdi-fhd-r63452 panel to use multi style functions for > improved error handling. > > Signed-off-by: Tejas Vipin > --- > drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c | 150 ++- > 1 file changed, 49 insertions

Re: [PATCH v3 2/2] drm/panel: startek-kd070fhfid015: transition to mipi_dsi wrapped functions

2024-08-13 Thread Doug Anderson
Hi, On Tue, Aug 6, 2024 at 7:00 AM Tejas Vipin wrote: > > Use multi style wrapped functions for mipi_dsi in the > startek-kd070fhfid015 panel. > > Signed-off-by: Tejas Vipin > --- > .../drm/panel/panel-startek-kd070fhfid015.c | 115 ++ > 1 file changed, 35 insertions(+), 80 de

Re: [PATCH v3 1/2] drm/mipi-dsi: add more multi functions for better error handling

2024-08-13 Thread Doug Anderson
Hi, On Tue, Aug 6, 2024 at 7:00 AM Tejas Vipin wrote: > > Add more functions that can benefit from being multi style and mark > older variants as deprecated to eventually convert all mipi_dsi functions > to multi style. > > Acked-by: Maxime Ripard > Signed-off-by: Tejas Vipin > --- > drivers/g

Re: [PATCH 1/2] drm/vmwgfx: Prevent unmapping active read buffers

2024-08-13 Thread Zack Rusin
On Tue, Aug 13, 2024 at 1:56 PM Ian Forbes wrote: > > In that case move `map_count` above `map` which should move it to a > separate cache line and update the doc strings as needed. Sorry, I'm not sure I understand. What are you trying to fix? z

Re: [RFC PATCH 15/17] drm/vkms: Allow to configure multiple planes via configfs

2024-08-13 Thread Louis Chauvet
Le 13/08/24 - 12:44, José Expósito a écrit : > Create a default subgroup at /config/vkms/planes to allow to create as > many overlay planes as required. When the plane is created the > possible_crtcs subgroup is created allowing to link planes and CRTCs. I think my comment about updating possible_

Re: [RFC PATCH 14/17] drm/vkms: Allow to configure multiple encoders

2024-08-13 Thread Louis Chauvet
Le 13/08/24 - 12:44, José Expósito a écrit : > Add a list of encoder configurations to vkms_config and add as many > encoders as configured during output initialization. Small mistake, this commit is about connector with configfs :) > > For backwards compatibility, create a single encoder in the

Re: [RFC PATCH 03/17] drm/vkms: Set device name from vkms_config

2024-08-13 Thread Louis Chauvet
Le 13/08/24 - 12:44, José Expósito a écrit : > In order to be able to create multiple devices, the device name needs to > be unique. > > Allow to set it in the VKMS configuration. > > Signed-off-by: José Expósito > --- > drivers/gpu/drm/vkms/vkms_config.c | 7 +-- > drivers/gpu/drm/vkms/vkm

Re: [RFC PATCH 10/17] drm/vkms: Allow to change connector status

2024-08-13 Thread Louis Chauvet
Le 13/08/24 - 12:44, José Expósito a écrit : > Store the connector status in vkms_config_connector and use the stored > value to update the connector status in the drm_connector_funcs.detect() > function. I did not work on this part, so my comments may be not relevant. > Signed-off-by: José Expó

Re: [RFC PATCH 11/17] drm/vkms: Add and remove VKMS instances via configfs

2024-08-13 Thread Louis Chauvet
Le 13/08/24 - 12:44, José Expósito a écrit : > Allow to create, enable, disable and destroy VKMS instances using > configfs. > > For the moment, add one primary plane, one CRC, one encoder and one > connector until we add support to configure them via configfs. > > Signed-off-by: José Expósito >

Re: [RFC PATCH 08/17] drm/vkms: Allow to configure multiple connectors

2024-08-13 Thread Louis Chauvet
Le 13/08/24 - 12:44, José Expósito a écrit : > Add a list of connector configurations to vkms_config and add as many > connector as configured during output initialization. > > For backwards compatibility, create a single connector in the default > configuration. > > Signed-off-by: José Expósito

Re: [RFC PATCH 06/17] drm/vkms: Allow to configure multiple encoders

2024-08-13 Thread Louis Chauvet
Le 13/08/24 - 12:44, José Expósito a écrit : > Add a list of encoder configurations to vkms_config and add as many > encoders as configured during output initialization. > > For backwards compatibility, create a single encoder in the default > configuration. You don't manage the deletion of crtc

Re: [RFC PATCH 09/17] drm/vkms: Allow to configure multiple overlay planes

2024-08-13 Thread Louis Chauvet
Le 13/08/24 - 12:44, José Expósito a écrit : > Add a list of overlay planes to vkms_config and add as many overlay > planes as configured during output initialization. > > For backwards compatibility, add NUM_OVERLAY_PLANES to the default > configuration. > > Note that a primary plane is created

Re: [RFC PATCH 13/17] drm/vkms: Allow to configure multiple encoders via configfs

2024-08-13 Thread Louis Chauvet
Le 13/08/24 - 12:44, José Expósito a écrit : > Create a default subgroup at /config/vkms/encoders to allow to create as > many encoders as required. When the encoder is created the > possible_crtcs subgroup is created allowing to link encoders and CRTCs. I did not test, but the issue about index f

Re: [RFC PATCH 07/17] drm/vkms: Use managed memory to create connectors

2024-08-13 Thread Louis Chauvet
Le 13/08/24 - 12:44, José Expósito a écrit : > A future patch will allow to create multiple connectors. Use managed > memory to simplify the code. > > Refactor, no functional changes. > > Signed-off-by: José Expósito > --- > drivers/gpu/drm/vkms/vkms_drv.h| 5 --- > drivers/gpu/drm/vkms/vk

Re: [PATCH v3 3/5] dt-bindings: display: rockchip: Add schema for RK3588 HDMI TX Controller

2024-08-13 Thread Rob Herring
On Wed, Aug 07, 2024 at 02:07:25PM +0300, Cristian Ciocaltea wrote: > Rockchip RK3588 SoC integrates the Synopsys DesignWare HDMI 2.1 > Quad-Pixel (QP) TX controller IP. > > Since this is a new IP block, quite different from those used in the > previous generations of Rockchip SoCs, add a dedicate

Re: [RFC PATCH 12/17] drm/vkms: Allow to configure multiple CRTCs via configfs

2024-08-13 Thread Louis Chauvet
Le 13/08/24 - 12:44, José Expósito a écrit : > Create a default subgroup at /config/vkms/crtcs to allow to create as > many CRTCs as required. When a CRTC is created, allow to configure the > equivalent of the module parameters enable_cursor and enable_writeback. I think this commit is not bissect

Re: [RFC PATCH 05/17] drm/vkms: Use managed memory to create encoders

2024-08-13 Thread Louis Chauvet
Le 13/08/24 - 12:44, José Expósito a écrit : > A future patch will allow to create multiple encoders. Use managed > memory to simplify the code. > > Refactor, no functional changes. > > Signed-off-by: José Expósito > --- > drivers/gpu/drm/vkms/vkms_drv.h| 1 - > drivers/gpu/drm/vkms/vkms_o

Re: [RFC PATCH 04/17] drm/vkms: Allow to configure multiple CRTCs

2024-08-13 Thread Louis Chauvet
Le 13/08/24 - 12:44, José Expósito a écrit : > Add a list of CRTC configurations to vkms_config and add as many CRTCs > as configured during output initialization. > > For backwards compatibility, create a single CRTC in the default > configuration. > > Since writeback support, vblank and compose

Re: [RFC PATCH 00/17] VKMS: Add configfs support

2024-08-13 Thread Louis Chauvet
Le 13/08/24 - 12:44, José Expósito a écrit : > Hi everyone, Hi José, > This RFC implements support to configure VKMS using configfs. > It allows to: > > - Create multiple devices > - Configure multiple overlay planes, CRTCs, encoders and >connectors > - Enable or disable cursor plane and

Re: [PATCH 1/2] drm/vmwgfx: Prevent unmapping active read buffers

2024-08-13 Thread Ian Forbes
In that case move `map_count` above `map` which should move it to a separate cache line and update the doc strings as needed. Reviewed-by: Ian Forbes On Tue, Aug 13, 2024 at 12:40 PM Zack Rusin wrote: > > On Tue, Aug 13, 2024 at 1:29 PM Ian Forbes wrote: > > > > Remove `busy_places` now that i

Re: [PATCH 1/2] drm/vmwgfx: Prevent unmapping active read buffers

2024-08-13 Thread Zack Rusin
On Tue, Aug 13, 2024 at 1:29 PM Ian Forbes wrote: > > Remove `busy_places` now that it's unused. There's also probably a > better place to put `map_count` in the struct layout to avoid false > sharing with `cpu_writers`. I'd repack the whole struct if we're going > to be adding and removing fields

Re: [PATCH 1/2] drm/vmwgfx: Prevent unmapping active read buffers

2024-08-13 Thread Ian Forbes
Remove `busy_places` now that it's unused. There's also probably a better place to put `map_count` in the struct layout to avoid false sharing with `cpu_writers`. I'd repack the whole struct if we're going to be adding and removing fields.

[PULL] drm-intel-next

2024-08-13 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our first drm-intel-next PR towards 6.12. drm-intel-next-2024-08-13: - Type-C programming fix for MTL+ (Gustavo) - Fix display clock workaround (Mitul) - Fix DP LTTPR detection (Imre) - Calculate vblank delay more accurately (Ville) - Make vrr_{enabling,disabling}(

Re: [PATCH] drm/vmwgfx: Handle possible ENOMEM in vmw_stdu_connector_atomic_check

2024-08-13 Thread Zack Rusin
On Fri, Aug 9, 2024 at 2:38 PM Ian Forbes wrote: > > Handle unlikely ENOMEN condition and other errors in > vmw_stdu_connector_atomic_check. > > Signed-off-by: Ian Forbes > Reported-by: Dan Carpenter > Fixes: 75c3e8a26a35 ("drm/vmwgfx: Trigger a modeset when the screen moves") > --- > drivers/g

Re: [PATCH] drm/vmwgfx: Limit display layout ioctl array size to VMWGFX_NUM_DISPLAY_UNITS

2024-08-13 Thread Zack Rusin
On Thu, Aug 8, 2024 at 4:06 PM Ian Forbes wrote: > > Currently the array size is only limited by the largest kmalloc size which > is incorrect. This change will also return a more specific error message > than ENOMEM to userspace. > > Signed-off-by: Ian Forbes > --- > drivers/gpu/drm/vmwgfx/vmwg

Re: [PATCH v2] drm/xe/uapi: Bring back reset uevent

2024-08-13 Thread Rodrigo Vivi
On Tue, Aug 13, 2024 at 04:28:32PM +0300, Raag Jadav wrote: > On Mon, Aug 12, 2024 at 03:08:14PM +0530, Aravind Iddamsetty wrote: > > > > On 12/08/24 13:18, Raag Jadav wrote: > > > From: Himal Prasad Ghimiray > > > > > > This was dropped in commit 77a0d4d1cea2 ("drm/xe/uapi: Remove reset > > > ue

Re: [PATCH v3 1/4] dt-bindings: display: renesas,rzg2l-du: Document RZ/G2UL DU bindings

2024-08-13 Thread Rob Herring
On Mon, Aug 05, 2024 at 04:52:35PM +0100, Biju Das wrote: > Document DU found in RZ/G2UL SoC. The DU block is identical to RZ/G2L > SoC, but has only DPI interface. > > While at it, add missing required property port@1 for RZ/G2L and RZ/V2L > SoCs. Currently there is no user for the DPI interface

[Bug 211807] [drm:drm_dp_mst_dpcd_read] *ERROR* mstb 000000004e6288dd port 3: DPCD read on addr 0x60 for 1 bytes NAKed

2024-08-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211807 Feicop1 (bofomol...@givehit.com) changed: What|Removed |Added CC||bofomol...@givehit.com

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-13 Thread Jakub Kicinski
On Tue, 13 Aug 2024 16:11:15 +0100 Pavel Begunkov wrote: > On 8/13/24 15:39, Jakub Kicinski wrote: > > On Tue, 13 Aug 2024 03:31:13 +0100 Pavel Begunkov wrote: > >> I'm getting lost, so repeating myself a bit. What I think > >> would be a good approach is if we get an error back from > >> the dri

Re: [PATCH v3 1/7] dt-bindings: connector: add GE SUNH hotplug addon connector

2024-08-13 Thread Rob Herring
On Fri, Aug 09, 2024 at 05:34:49PM +0200, Luca Ceresoli wrote: > Add bindings for the GE SUNH add-on connector. This is a physical, > hot-pluggable connector that allows to attach and detach at runtime an > add-on adding peripherals on non-discoverable busses. Overall, looks pretty good. > > Sig

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-13 Thread Pavel Begunkov
On 8/13/24 15:39, Jakub Kicinski wrote: On Tue, 13 Aug 2024 03:31:13 +0100 Pavel Begunkov wrote: I'm getting lost, so repeating myself a bit. What I think would be a good approach is if we get an error back from the driver if it doesn't support netiov / providers. netdev_rx_queue_restart() {

Re: [PATCH] drm/edid: add non-desktop quirk to Pimax VR Headsets

2024-08-13 Thread Jani Nikula
On Thu, 25 Jul 2024, Sefa Eyeoglu wrote: > Hi Jani, > > I have asked someone with the actual hardware to attach their EDID blob > to the issue. There's only one so far, but that one does require the quirk. Acked-by: Jani Nikula > > Kind regards, > Sefa > > On Wed, 2024-07-24 at 10:22 +0300,

Re: [PATCH 6/6] drm/amdgpu: Re-validate evicted buffers v2

2024-08-13 Thread Tvrtko Ursulin
I was waiting for some replies elsewhere on this thread. Anwyay.. for the below, because I don't understand how come an important fix like this is not garnering more attention: On 04/06/2024 17:05, Christian König wrote: From: Tvrtko Ursulin Since you pretty much changed my logic you cou

[PATCH v2 1/1] dt-bindings: display: panel-simple-lvds-dual-ports: add panel-timing: true

2024-08-13 Thread Frank Li
Add property panel-timing: true to allow use 'panel-timing', which defined in panel-common.yaml. Fix below warning: arch/arm64/boot/dts/freescale/imx8mp-evk-mx8-dlvds-lcd1.dtb: panel-lvds: 'panel-timing' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetr

Re: [PATCH v3 0/5] Add initial support for the Rockchip RK3588 HDMI TX Controller

2024-08-13 Thread Cristian Ciocaltea
On 8/13/24 4:17 PM, Heiko Stübner wrote: > Am Mittwoch, 7. August 2024, 13:07:22 CEST schrieb Cristian Ciocaltea: >> The Rockchip RK3588 SoC family integrates the Synopsys DesignWare HDMI >> 2.1 Quad-Pixel (QP) TX controller, which is a new IP block, quite >> different from those used in the previo

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-13 Thread Jakub Kicinski
On Tue, 13 Aug 2024 03:31:13 +0100 Pavel Begunkov wrote: > I'm getting lost, so repeating myself a bit. What I think > would be a good approach is if we get an error back from > the driver if it doesn't support netiov / providers. > > netdev_rx_queue_restart() { > ... > err = dev->queu

Re: [PATCH v6 2/4] drm/rect: Add drm_rect_overlap()

2024-08-13 Thread Jocelyn Falempe
On 13/08/2024 16:11, Jani Nikula wrote: On Mon, 12 Aug 2024, Jani Nikula wrote: On Mon, 12 Aug 2024, Jocelyn Falempe wrote: On 12/08/2024 15:49, Jani Nikula wrote: On Mon, 12 Aug 2024, Jocelyn Falempe wrote: Check if two rectangles overlap. It's a bit similar to drm_rect_intersect() but th

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-13 Thread Jakub Kicinski
On Tue, 13 Aug 2024 04:39:47 -0400 Mina Almasry wrote: > On Mon, Aug 12, 2024 at 8:15 PM Jakub Kicinski wrote: > > BTW, Mina, the core should probably also check that XDP isn't installed > > before / while the netmem is bound to a queue. > > Sorry if noob question, but what is the proper check

Re: [PATCH] drm/bridge: ti-sn65dsi83: use dev_err_probe when failing to get panel bridge

2024-08-13 Thread Andi Shyti
Hi Luca, On Tue, Aug 13, 2024 at 10:16:43AM +0200, Luca Ceresoli wrote: > On Thu, 8 Aug 2024 11:35:23 +0100 > Andi Shyti wrote: > > On Thu, Aug 08, 2024 at 12:26:14PM +0200, Luca Ceresoli wrote: > > > When devm_drm_of_get_bridge() fails, the probe fails silently. Use > > > dev_err_probe() instead

Re: [PATCH] drm/hisilicon: Remove unused delarations

2024-08-13 Thread Thomas Zimmermann
Am 12.08.24 um 14:35 schrieb Zhang Zekun: hibmc_mm_init() has been removed since commit 28645ae064d1 ("drm/hisilicon/hibmc: Remove hibmc_ttm.c"), but remain the declaration untouched in the header files. So, let's remove this unused declaration. Signed-off-by: Zhang Zekun Reviewed-by: Thom

Re: [PATCH v2] drm/xe/uapi: Bring back reset uevent

2024-08-13 Thread Lucas De Marchi
On Mon, Aug 12, 2024 at 01:18:12PM GMT, Raag Jadav wrote: From: Himal Prasad Ghimiray This was dropped in commit 77a0d4d1cea2 ("drm/xe/uapi: Remove reset uevent for now") as part of refactoring. Now that we have better uapi semantics and naming for the uevent, bring it back. With this in place

Re: [PATCH v6 2/4] drm/rect: Add drm_rect_overlap()

2024-08-13 Thread Jani Nikula
On Mon, 12 Aug 2024, Jani Nikula wrote: > On Mon, 12 Aug 2024, Jocelyn Falempe wrote: >> On 12/08/2024 15:49, Jani Nikula wrote: >>> On Mon, 12 Aug 2024, Jocelyn Falempe wrote: Check if two rectangles overlap. It's a bit similar to drm_rect_intersect() but this won't modify the re

Re: [PATCH] drm/amdgpu: Remove hidden double memset from amdgpu_vm_pt_clear()

2024-08-13 Thread Tvrtko Ursulin
On 13/08/2024 15:08, Tvrtko Ursulin wrote: From: Tvrtko Ursulin When CONFIG_INIT_STACK_ALL_ZERO is set and so -ftrivial-auto-var-init=zero compiler option active, compiler fails to notice that later in amdgpu_vm_pt_clear() there is a second memset to clear the same on stack struct amdgpu_vm_

Re: [PATCH 0/2] Allow partial memory mapping for cpu memory

2024-08-13 Thread Daniel Vetter
On Tue, Aug 13, 2024 at 02:54:31AM +, Matthew Brost wrote: > On Mon, Aug 12, 2024 at 04:45:32PM +0200, Daniel Vetter wrote: > > On Mon, Aug 12, 2024 at 01:51:30PM +0200, Andi Shyti wrote: > > > Hi Daniel, > > > > > > On Mon, Aug 12, 2024 at 11:11:21AM +0200, Daniel Vetter wrote: > > > > On Fri

[PATCH] drm/amdgpu: Remove hidden double memset from amdgpu_vm_pt_clear()

2024-08-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin When CONFIG_INIT_STACK_ALL_ZERO is set and so -ftrivial-auto-var-init=zero compiler option active, compiler fails to notice that later in amdgpu_vm_pt_clear() there is a second memset to clear the same on stack struct amdgpu_vm_update_params. If we replace this memset with

[PATCH] drm/amdgpu: Remove hidden double memset from amdgpu_cs_ioctl()

2024-08-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin When CONFIG_INIT_STACK_ALL_ZERO is set and so -ftrivial-auto-var-init=zero compiler option active, compiler fails to notice that inside amdgpu_cs_parser_init() there is a second memset to clear the same on stack struct amdgpu_cs_parser. If we pull this memset one level out,

[PATCH 1/2] Documentation/gpu: Document the situation with unqualified drm-memory-

2024-08-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Currently it is not well defined what is drm-memory- compared to other categories. In practice the only driver which emits these keys is amdgpu and in them exposes the current resident buffer object memory (including shared). To prevent any confusion, document that drm-memo

[PATCH 0/2] DRM fdinfo legacy drm-memory- clarification and amdgpu update

2024-08-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Re-sending these two since they garnered little attention last time round. First patch clarifies what drm-memory- is, and that it is legacy, and second patch updates amdgpu to start emitting new keys together with the legacy (by using the common DRM helper). With that gputo

[PATCH 2/2] drm/amdgpu: Use drm_print_memory_stats helper from fdinfo

2024-08-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Convert fdinfo memory stats to use the common drm_print_memory_stats helper. This achieves alignment with the common keys as documented in drm-usage-stats.rst, adding specifically drm-total- key the driver was missing until now. Additionally I made the code stop skipping to

  1   2   >