[PATCH 2/2] drm/panel: jdi-fhd-r63452: transition to mipi_dsi wrapped functions

2024-08-09 Thread Tejas Vipin
Changes the jdi-fhd-r63452 panel to use multi style functions for improved error handling. Signed-off-by: Tejas Vipin --- drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c | 125 ++- 1 file changed, 39 insertions(+), 86 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-jdi-fhd-r6

[PATCH 1/2] drm/mipi-dsi: Add mipi_dsi_dcs_set_tear_scanline_multi

2024-08-09 Thread Tejas Vipin
mipi_dsi_dcs_set_tear_scanline_multi can heavily benefit from being converted to a multi style function as it is often called in the context of similar functions. Signed-off-by: Tejas Vipin --- drivers/gpu/drm/drm_mipi_dsi.c | 31 +++ include/drm/drm_mipi_dsi.h |

[PATCH 0/2] add more multi functions for streamlined error handling

2024-08-09 Thread Tejas Vipin
This patch adds mipi_dsi_dcs_set_tear_scanline_multi to the list of multi functions and uses it with other multi functions in the jdi-fhd-r63452 panel. Tejas Vipin (2): drm/mipi-dsi: Add mipi_dsi_dcs_set_tear_scanline_multi drm/panel: jdi-fhd-r63452: transition to mipi_dsi wrapped functions

Re: [git pull] drm fixes for 6.11-rc3

2024-08-09 Thread pr-tracker-bot
The pull request you sent on Sat, 10 Aug 2024 06:00:08 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-08-10 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/15833fea97c1fdb3b34fceefa4b51177dd57e18f Thank you! -- Deet-doot-dot, I am a bot. h

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-09 Thread Jakub Kicinski
On Fri, 9 Aug 2024 16:45:50 +0100 Pavel Begunkov wrote: > > I think this is good, and it doesn't seem hacky to me, because we can > > check the page_pools of the netdev while we hold rtnl, so we can be > > sure nothing is messing with the pp configuration in the meantime. > > Like you say below it

RE: [PATCH v2 4/4] udmabuf: remove folio unpin list

2024-08-09 Thread Kasireddy, Vivek
Hi Huan, > > Currently, udmabuf handles folio by creating an unpin list to record > each folio obtained from the list and unpinning them when released. To > maintain this approach, many data structures have been established. > > However, maintaining this type of data structure requires a signifi

RE: [PATCH v2 3/4] fix vmap_udmabuf error page set

2024-08-09 Thread Kasireddy, Vivek
Hi Huan, > > Currently vmap_udmabuf set page's array by each folio. > But, ubuf->folios is only contain's the folio's head page. > > That mean we repeatedly mapped the folio head page to the vmalloc area. > > This patch fix it, set each folio's page correct, so that pages array > contains right

RE: [PATCH v2 2/4] udmabuf: change folios array from kmalloc to kvmalloc

2024-08-09 Thread Kasireddy, Vivek
Hi Huan, > > When PAGE_SIZE 4096, MAX_PAGE_ORDER 10, 64bit machine, > page_alloc only support 4MB. > If above this, trigger this warn and return NULL. > > udmabuf can change size limit, if change it to 3072(3GB), and then alloc > 3GB udmabuf, will fail create. > > [ 4080.876581] [ c

RE: [PATCH v2 1/4] udmabuf: cancel mmap page fault, direct map it

2024-08-09 Thread Kasireddy, Vivek
Hi Huan, > > The current udmabuf mmap uses a page fault mechanism to populate the > vma. > > However, the current udmabuf has already obtained and pinned the folio > upon completion of the creation.This means that the physical memory has > already been acquired, rather than being accessed dynami

[PATCH v3 5/5] drm/xe: Drop GuC submit_wq pool

2024-08-09 Thread Matthew Brost
Now that drm sched uses a single lockdep map for all submit_wq, drop the GuC submit_wq pool hack. Signed-off-by: Matthew Brost --- drivers/gpu/drm/xe/xe_guc_submit.c | 60 +- drivers/gpu/drm/xe/xe_guc_types.h | 7 2 files changed, 1 insertion(+), 66 deletions(-

[PATCH v3 3/5] workqueue: Add interface for user-defined workqueue lockdep map

2024-08-09 Thread Matthew Brost
Add an interface for a user-defined workqueue lockdep map, which is helpful when multiple workqueues are created for the same purpose. This also helps avoid leaking lockdep maps on each workqueue creation. v2: - Add alloc_workqueue_lockdep_map (Tejun) v3: - Drop __WQ_USER_OWNED_LOCKDEP (Tejun)

[PATCH v3 0/5] Use user-defined workqueue lockdep map for drm sched

2024-08-09 Thread Matthew Brost
By default, each DRM scheduler instance creates an ordered workqueue for submission, and each workqueue creation allocates a new lockdep map. This becomes problematic when a DRM scheduler is created for every user queue (e.g., in DRM drivers with firmware schedulers like Xe) due to the limited numb

[PATCH v3 4/5] drm/sched: Use drm sched lockdep map for submit_wq

2024-08-09 Thread Matthew Brost
Avoid leaking a lockdep map on each drm sched creation and destruction by using a single lockdep map for all drm sched allocated submit_wq. v2: - Use alloc_ordered_workqueue_lockdep_map (Tejun) Cc: Luben Tuikov Cc: Christian König Signed-off-by: Matthew Brost --- drivers/gpu/drm/scheduler/sc

[PATCH v3 1/5] workqueue: Split alloc_workqueue into internal function and lockdep init

2024-08-09 Thread Matthew Brost
Will help enable user-defined lockdep maps for workqueues. Cc: Tejun Heo Cc: Lai Jiangshan Signed-off-by: Matthew Brost --- kernel/workqueue.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 1745

[PATCH v3 2/5] workqueue: Change workqueue lockdep map to pointer

2024-08-09 Thread Matthew Brost
Will help enable user-defined lockdep maps for workqueues. Cc: Tejun Heo Cc: Lai Jiangshan Signed-off-by: Matthew Brost --- kernel/workqueue.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 90a98c9b0ac6..24df85

Re: [PATCH v2 3/3] drm/rockchip: Add basic RK3588 HDMI output support

2024-08-09 Thread kernel test robot
Hi Cristian, kernel test robot noticed the following build errors: [auto build test ERROR on 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0] url: https://github.com/intel-lab-lkp/linux/commits/Cristian-Ciocaltea/dt-bindings-display-rockchip-Add-schema-for-RK3588-HDMI-TX-Controller/20240802-173018

[RFC PATCH] drm/amd/display/dc: Refactor remove duplications

2024-08-09 Thread Luan Icaro Pinto Arcanjo
From: LipArcanjo All dce command_table_helper's shares a copy-pasted collection of copy-pasted functions, which are: phy_id_to_atom, clock_source_id_to_atom_phy_clk_src_id, and engine_bp_to_atom. This patch removes the multiple copy-pasted by creating a common command table and make the command_

Re: [PATCH v2 3/3] drm/rockchip: Add basic RK3588 HDMI output support

2024-08-09 Thread kernel test robot
Hi Cristian, kernel test robot noticed the following build errors: [auto build test ERROR on 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0] url: https://github.com/intel-lab-lkp/linux/commits/Cristian-Ciocaltea/dt-bindings-display-rockchip-Add-schema-for-RK3588-HDMI-TX-Controller/20240802-173018

Re: [PATCH 1/2] PCI: Deprecate pcim_iomap_regions() in favor of pcim_iomap_region()

2024-08-09 Thread Bjorn Helgaas
On Wed, Aug 07, 2024 at 10:30:18AM +0200, Philipp Stanner wrote: > pcim_iomap_regions() is a complicated function that uses a bit mask to > determine the BARs the user wishes to request and ioremap. Almost all > users only ever set a single bit in that mask, making that mechanism > questionable. >

[git pull] drm fixes for 6.11-rc3

2024-08-09 Thread Dave Airlie
Hi Linus, Weekly regular fixes, mostly amdgpu with i915/xe having a few each, and then some misc bits across the board, seems about right for rc3 time. Regards, Dave. drm-fixes-2024-08-10: drm fixes for 6.11-rc3 client: - fix null ptr deref bridge: - connector: fix double free atomic: - fix a

[PATCH v6 8/8] drm: zynqmp_dp: Add debugfs interface for compliance testing

2024-08-09 Thread Sean Anderson
Add a debugfs interface for exercising the various test modes supported by the DisplayPort controller. This allows performing compliance testing, or performing signal integrity measurements on a failing link. At the moment, we do not support sink-driven link quality testing, although such support w

[PATCH v6 7/8] drm: zynqmp_dp: Take dp->lock in zynqmp_dp_hpd_work_func

2024-08-09 Thread Sean Anderson
Add a non-locking version of zynqmp_dp_bridge_detect and use it in zynqmp_dp_hpd_work_func so we can take the lock explicitly. This will make it easier to check for hpd_ignore when we add debugfs support. Signed-off-by: Sean Anderson --- (no changes since v3) Changes in v3: - New drivers/gpu/

[PATCH v6 6/8] drm: zynqmp_dp: Split off several helper functions

2024-08-09 Thread Sean Anderson
In preparation for supporting compliance testing, split off several helper functions. No functional change intended. Signed-off-by: Sean Anderson Reviewed-by: Laurent Pinchart Reviewed-by: Tomi Valkeinen --- (no changes since v1) drivers/gpu/drm/xlnx/zynqmp_dp.c | 49 ++--

[PATCH v6 5/8] drm: zynqmp_dp: Use AUX IRQs instead of polling

2024-08-09 Thread Sean Anderson
Instead of polling the status register for the AUX status, just enable the IRQs and signal a completion. Signed-off-by: Sean Anderson --- (no changes since v3) Changes in v3: - New drivers/gpu/drm/xlnx/zynqmp_dp.c | 35 +++- 1 file changed, 25 insertions(+), 10 del

[PATCH v6 4/8] drm: zynqmp_dp: Convert to a hard IRQ

2024-08-09 Thread Sean Anderson
Now that all of the sleeping work is done outside of the IRQ, we can convert it to a hard IRQ. Shared IRQs may be triggered even after calling disable_irq, so use free_irq instead which removes our callback altogether. Signed-off-by: Sean Anderson --- Changes in v6: - Fix hang upon driver remova

[PATCH v6 3/8] drm: zynqmp_dp: Don't retrain the link in our IRQ

2024-08-09 Thread Sean Anderson
Retraining the link can take a while, and might involve waiting for DPCD reads/writes to complete. In preparation for unthreading the IRQ handler, move this into its own work function. Signed-off-by: Sean Anderson --- (no changes since v2) Changes in v2: - Document hpd_irq_work - Split this off

[PATCH v6 2/8] drm: zynqmp_dp: Add locking

2024-08-09 Thread Sean Anderson
Add some locking to prevent the IRQ/workers/bridge API calls from stepping on each other's toes. This lock protects: - Non-atomic registers configuring the link. That is, everything but the IRQ registers (since these are accessed in an atomic fashion), and the DP AUX registers (since these don

[PATCH v6 1/8] drm: zynqmp_kms: Unplug DRM device before removal

2024-08-09 Thread Sean Anderson
Prevent userspace accesses to the DRM device from causing use-after-frees by unplugging the device before we remove it. This causes any further userspace accesses to result in an error without further calls into this driver's internals. Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx Zy

[PATCH v6 0/8] drm: zynqmp_dp: IRQ cleanups and debugfs support

2024-08-09 Thread Sean Anderson
This series cleans up the zyqnmp_dp IRQ and locking situation. Once that's done, it adds debugfs support. The intent is to enable compliance testing or to help debug signal-integrity issues. Previously, I discussed converting the HPD work(s) to a threaded IRQ. I did not end up doing that for this

Re: [PATCH] drm/msm: Remove unused pm_state

2024-08-09 Thread Abhinav Kumar
On 8/9/2024 11:37 AM, Rob Clark wrote: From: Rob Clark This was added in commit ec446d09366c ("drm/msm: call drm_atomic_helper_suspend() and drm_atomic_helper_resume()"), but unused since commit ca8199f13498 ("drm/msm/dpu: ensure device suspend happens during PM sleep") which switched to drm

Re: [PATCH 0/2] drm/virtio: introduce the HOST_PAGE_SIZE feature

2024-08-09 Thread Gurchetan Singh
On Thu, Aug 8, 2024 at 3:38 AM Sergio Lopez Pascual wrote: > Gurchetan Singh writes: > > > On Tue, Aug 6, 2024 at 1:15 PM Rob Clark wrote: > > > >> On Tue, Aug 6, 2024 at 9:15 AM Gurchetan Singh > >> wrote: > >> > > >> > > >> > > >> > On Mon, Aug 5, 2024 at 2:14 AM Sergio Lopez Pascual > >> w

Re: [PATCH v5 00/10] drm: zynqmp_dp: IRQ cleanups and debugfs support

2024-08-09 Thread Sean Anderson
On 8/8/24 08:46, Tomi Valkeinen wrote: > Hi Sean, > > On 17/06/2024 17:48, Sean Anderson wrote: >> On 6/17/24 03:47, Tomi Valkeinen wrote: >>> Hi Sean, >>> >>> On 03/05/2024 22:29, Sean Anderson wrote: This series cleans up the zyqnmp_dp IRQ and locking situation. Once that's done, it ad

[PATCH] drm/vmwgfx: Handle possible ENOMEM in vmw_stdu_connector_atomic_check

2024-08-09 Thread Ian Forbes
Handle unlikely ENOMEN condition and other errors in vmw_stdu_connector_atomic_check. Signed-off-by: Ian Forbes Reported-by: Dan Carpenter Fixes: 75c3e8a26a35 ("drm/vmwgfx: Trigger a modeset when the screen moves") --- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 4 1 file changed, 4 insertions(

[PATCH] drm/msm: Remove unused pm_state

2024-08-09 Thread Rob Clark
From: Rob Clark This was added in commit ec446d09366c ("drm/msm: call drm_atomic_helper_suspend() and drm_atomic_helper_resume()"), but unused since commit ca8199f13498 ("drm/msm/dpu: ensure device suspend happens during PM sleep") which switched to drm_mode_config_helper_suspend()/ drm_mode_conf

[RFC] Adds support for ConfigFS to VKMS!

2024-08-09 Thread Louis Chauvet
and added a few comments on your > GitHub fork. I am not able to find any comments, can you send me the link to the page with them? I would like to read/apply them before submitting the first part of the series. Thanks for your time, Louis Chauvet [1]: https://lore.kernel.org/all/2024080

Re: [PATCH v2] dt-bindings: display: st,stm32-ltdc: Document stm32mp25 compatible

2024-08-09 Thread Rob Herring
On Fri, Aug 09, 2024 at 05:13:14PM +0200, Yannick Fertre wrote: > Add "st,stm32mp25-ltdc" compatible for SOC MP25. This new SOC introduce > new clocks (bus, ref & lvds). Bus clock was separated from lcd clock. > New sources are possible for lcd clock (lvds / ref). > > Signed-off-by: Yannick Fertre

[PATCH v10 15/16] drm/vkms: Add how to run the Kunit tests

2024-08-09 Thread Louis Chauvet
From: Arthur Grillo Now that we have KUnit tests, add instructions on how to run them. Signed-off-by: Arthur Grillo Signed-off-by: Louis Chauvet --- Documentation/gpu/vkms.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.

[PATCH v10 16/16] drm/vkms: Add support for DRM_FORMAT_R*

2024-08-09 Thread Louis Chauvet
This add the support for: - R1/R2/R4/R8 R1 format was tested with [1] and [2]. [1]: https://lore.kernel.org/r/20240313-new_rotation-v2-0-6230fd5ca...@bootlin.com [2]: https://lore.kernel.org/igt-dev/20240306-b4-kms_tests-v1-0-8fe451efd...@bootlin.com/ Reviewed-by: Pekka Paalanen Signed-off-by

[PATCH v10 11/16] drm/vkms: Add YUV support

2024-08-09 Thread Louis Chauvet
From: Arthur Grillo Add support to the YUV formats bellow: - NV12/NV16/NV24 - NV21/NV61/NV42 - YUV420/YUV422/YUV444 - YVU420/YVU422/YVU444 The conversion from yuv to rgb is done with fixed-point arithmetic, using 32.32 fixed-point numbers and the drm_fixed helpers. To do the conversion, a spec

[PATCH v10 12/16] drm/vkms: Add range and encoding properties to the plane

2024-08-09 Thread Louis Chauvet
From: Arthur Grillo Now that the driver internally handles these quantization ranges and YUV encoding matrices, expose the UAPI for setting them. Signed-off-by: Arthur Grillo [Louis Chauvet: retained only relevant parts, updated the commit message] Acked-by: Pekka Paalanen Signed-off-by: Louis

[PATCH v10 13/16] drm/vkms: Drop YUV formats TODO

2024-08-09 Thread Louis Chauvet
From: Arthur Grillo VKMS has support for YUV formats now. Remove the task from the TODO list. Signed-off-by: Arthur Grillo Signed-off-by: Louis Chauvet --- Documentation/gpu/vkms.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Documentation/gpu/vkms.rst b/Documentati

[PATCH v10 14/16] drm/vkms: Create KUnit tests for YUV conversions

2024-08-09 Thread Louis Chauvet
From: Arthur Grillo Create KUnit tests to test the conversion between YUV and RGB. Test each conversion and range combination with some common colors. The code used to compute the expected result can be found in comment. [Louis Chauvet: - fix minor formating issues (whitespace, double line) - c

[PATCH v10 08/16] drm/vkms: Introduce pixel_read_direction enum

2024-08-09 Thread Louis Chauvet
The pixel_read_direction enum is useful to describe the reading direction in a plane. It avoids using the rotation property of DRM, which not practical to know the direction of reading. This patch also introduce two helpers, one to compute the pixel_read_direction from the DRM rotation property, an

[PATCH v10 10/16] drm/vkms: Remove useless drm_rotation_simplify

2024-08-09 Thread Louis Chauvet
As all the rotation are now supported by VKMS, this simplification does not make sense anymore, so remove it. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_plane.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/

[PATCH v10 09/16] drm/vkms: Re-introduce line-per-line composition algorithm

2024-08-09 Thread Louis Chauvet
Re-introduce a line-by-line composition algorithm for each pixel format. This allows more performance by not requiring an indirection per pixel read. This patch is focused on readability of the code. Line-by-line composition was introduced by [1] but rewritten back to pixel-by-pixel algorithm in [

[PATCH v10 07/16] drm/vkms: Avoid computing blending limits inside pre_mul_alpha_blend

2024-08-09 Thread Louis Chauvet
The pre_mul_alpha_blend is dedicated to blending, so to avoid mixing different concepts (coordinate calculation and color management), extract the x_limit and x_dst computation outside of this helper. It also increases the maintainability by grouping the computation related to coordinates in the sa

[PATCH v10 05/16] drm/vkms: Use const for input pointers in pixel_read an pixel_write functions

2024-08-09 Thread Louis Chauvet
As the pixel_read and pixel_write function should never modify the input buffer, mark those pointers const. Reviewed-by: Pekka Paalanen Reviewed-by: Maíra Canal Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_drv.h | 4 ++-- drivers/gpu/drm/vkms/vkms_formats.c | 20 ++--

[PATCH v10 04/16] drm/vkms: Add typedef and documentation for pixel_read and pixel_write functions

2024-08-09 Thread Louis Chauvet
Introduce two typedefs: pixel_read_t and pixel_write_t. It allows the compiler to check if the passed functions take the correct arguments. Such typedefs will help ensuring consistency across the code base in case of update of these prototypes. Rename input/output variable in a consistent way betw

[PATCH v10 06/16] drm/vkms: Update pixels accessor to support packed and multi-plane formats.

2024-08-09 Thread Louis Chauvet
Introduce the usage of block_h/block_w to compute the offset and the pointer of a pixel. The previous implementation was specialized for planes with block_h == block_w == 1. To avoid confusion and allow easier implementation of tiled formats. It also remove the usage of the deprecated format field

[PATCH v10 02/16] drm/vkms: Use drm_frame directly

2024-08-09 Thread Louis Chauvet
From: Arthur Grillo Remove intermidiary variables and access the variables directly from drm_frame. These changes should be noop. Signed-off-by: Arthur Grillo Acked-by: Pekka Paalanen Reviewed-by: Maíra Canal Reviewed-by: Louis Chauvet [Louis Chauvet: Applied review from Maíra] Signed-off-by

[PATCH v10 01/16] drm/vkms: Code formatting

2024-08-09 Thread Louis Chauvet
Few no-op changes to remove double spaces and fix wrong alignments. Reviewed-by: Pekka Paalanen Reviewed-by: Maíra Canal Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_composer.c | 10 +- drivers/gpu/drm/vkms/vkms_crtc.c | 6 ++ drivers/gpu/drm/vkms/vkms_drv.c

[PATCH v10 03/16] drm/vkms: write/update the documentation for pixel conversion and pixel write functions

2024-08-09 Thread Louis Chauvet
Add some documentation on pixel conversion functions. Update of outdated comments for pixel_write functions. Signed-off-by: Louis Chauvet Acked-by: Pekka Paalanen --- drivers/gpu/drm/vkms/vkms_composer.c | 7 drivers/gpu/drm/vkms/vkms_drv.h | 15 - drivers/gpu/drm/vkms/vkms_f

[PATCH v10 00/16] drm/vkms: Reimplement line-per-line pixel conversion for plane reading

2024-08-09 Thread Louis Chauvet
This patchset is the second version of [1]. It is almost a complete rewrite to use a line-by-line algorithm for the composition. During the development of this series Pekka and Arthur found an issue in drm core. The YUV part of this series depend on the fix [9]. I'll let Arthur extract it and subm

Re: [PATCH v6 11/12] drm/ttm, drm/xe: Add a shrinker for xe bos

2024-08-09 Thread Matthew Brost
On Fri, Aug 09, 2024 at 04:31:27PM +0200, Thomas Hellström wrote: > On Thu, 2024-08-08 at 01:37 +, Matthew Brost wrote: > > On Wed, Jul 03, 2024 at 05:38:12PM +0200, Thomas Hellström wrote: > > > Rather than relying on the TTM watermark accounting add a shrinker > > > for xe_bos in TT or system

Re: [PATCH] drm/ast: astdp: fix pre-op vs post-op bug

2024-08-09 Thread Dan Carpenter
On Fri, Aug 09, 2024 at 04:43:51PM +0300, Jani Nikula wrote: > On Fri, 09 Aug 2024, Thomas Zimmermann wrote: > > Hi, > > > > thanks a lot for the bugfix. > > > > Am 09.08.24 um 14:33 schrieb Dan Carpenter: > >> The test for "Link training failed" expect the loop to exit with "i" > >> set to zero b

Re: [PATCH] accel: drm_accel: remove incorrect comments

2024-08-09 Thread Jeffrey Hugo
On 7/31/2024 12:42 AM, bajing wrote: accel_minor_replace is of type void, so remove the explanation of the return value in the comments. Signed-off-by: bajing --- drivers/accel/drm_accel.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/accel/drm_accel.c b/drivers/accel/drm_acc

Re: [PATCH V2 09/10] accel/amdxdna: Add query functions

2024-08-09 Thread Jeffrey Hugo
On 8/5/2024 11:39 AM, Lizhi Hou wrote: +/** + * struct amdxdna_drm_query_hwctx - The data for single context. + * @context_id: The ID for this context. + * @start_col: The starting column for the partition assigned to this context. + * @num_col: The number of columns in the partition assigned to

Re: [PATCH v6 10/12] drm/ttm: Use fault-injection to test error paths

2024-08-09 Thread Matthew Brost
On Fri, Aug 09, 2024 at 03:53:20PM +0200, Thomas Hellström wrote: > On Wed, 2024-08-07 at 23:43 +, Matthew Brost wrote: > > On Wed, Jul 03, 2024 at 05:38:11PM +0200, Thomas Hellström wrote: > > > Use fault-injection to test partial TTM swapout and interrupted > > > swapin. > > > Return -EINTR f

Re: [PATCH V2 05/10] accel/amdxdna: Add GEM buffer object management

2024-08-09 Thread Jeffrey Hugo
On 8/5/2024 11:39 AM, Lizhi Hou wrote: +/** + * struct amdxdna_drm_create_bo - Create a buffer object. + * @flags: Buffer flags. MBZ. + * @type: Buffer type. + * @vaddr: User VA of buffer if applied. MBZ. + * @size: Size in bytes. + * @handle: Returned DRM buffer object handle. + */ +struct amdxd

Re: [PATCH V2 03/10] accel/amdxdna: Add hardware resource solver

2024-08-09 Thread Jeffrey Hugo
On 8/5/2024 11:39 AM, Lizhi Hou wrote: +int aie2_max_col = XRS_MAX_COL; +module_param(aie2_max_col, int, 0600); +MODULE_PARM_DESC(aie2_max_col, "Maximum column could be used"); I think you selected the wrong type. What happens if someone sets this to a negative value?

Re: [PATCH v3 1/7] dt-bindings: connector: add GE SUNH hotplug addon connector

2024-08-09 Thread Rob Herring (Arm)
nh-addon-connector.example.dtb: /: '#size-cells' is a required property from schema $id: http://devicetree.org/schemas/root-node.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240809-hotplug-drm-bridge-v3-1-b4

Re: [PATCH V2 02/10] accel/amdxdna: Support hardware mailbox

2024-08-09 Thread Jeffrey Hugo
On 8/5/2024 11:39 AM, Lizhi Hou wrote: +enum aie2_msg_status { + AIE2_STATUS_SUCCESS = 0x0, + /* AIE Error codes */ + AIE2_STATUS_AIE_SATURATION_ERROR= 0x101, + AIE2_STATUS_AIE_FP_ERROR= 0x102, +

Re: [PATCH v2] dt-bindings: display: st,stm32-ltdc: Document stm32mp25 compatible

2024-08-09 Thread Rob Herring (Arm)
On Fri, 09 Aug 2024 17:13:14 +0200, Yannick Fertre wrote: > Add "st,stm32mp25-ltdc" compatible for SOC MP25. This new SOC introduce > new clocks (bus, ref & lvds). Bus clock was separated from lcd clock. > New sources are possible for lcd clock (lvds / ref). > > Signed-off-by: Yannick Fertre >

Re: [PATCH V2 01/10] accel/amdxdna: Add a new driver for AMD AI Engine

2024-08-09 Thread Jeffrey Hugo
On 8/5/2024 11:39 AM, Lizhi Hou wrote: AMD AI Engine forms the core of AMD NPU and can be used for accelerating machine learning applications. Add the driver to support AI Engine integrated to AMD CPU. Only very basic functionalities are added. - module and PCI device initialization - firm

Re: [PATCH 11/12] tty/vt: conmakehash requires linux/limits.h

2024-08-09 Thread Daniel Gomez (Samsung)
f6aa043c7afa40a2103163a0ef06d179/drivers/tty/vt/conmakehash.c#L15 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/tty/vt/conmakehash.c?h=1e391b34f6aa043c7afa40a2103163a0ef06d179#n15 This patch adds the header: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux

[PATCH] drm/meson: add check to prevent dereference of NULL

2024-08-09 Thread Anastasia Belova
If devm_kzalloc gives NULL instead of allocating priv, execution goes to free_drm where priv is dereferenced calling meson_encoder_dsi_remove, meson_encoder_hdmi_remove and meson_encoder_cvbs_remove. Add NULL-check for priv. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signe

Re: [PATCH v6 11/12] drm/ttm, drm/xe: Add a shrinker for xe bos

2024-08-09 Thread Matthew Auld
Hi, On 03/07/2024 16:38, Thomas Hellström wrote: Rather than relying on the TTM watermark accounting add a shrinker for xe_bos in TT or system memory. Leverage the newly added TTM per-page shrinking and shmem backup support. Although xe doesn't fully support WONTNEED (purgeable) bos yet, intro

Re: [PATCH v2] kerneldoc: Fix two missing newlines in drm_connector.c

2024-08-09 Thread Shuah Khan
On 8/8/24 21:23, Daniel Yang wrote: Fix the unexpected indentation errors. drm_connector.c has some kerneldoc comments that were missing newlines. This results in the following warnings when running make htmldocs: ./Documentation/gpu/drm-kms:538: ./drivers/gpu/drm/drm_connector.c:2344: WARNING:

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-09 Thread Pavel Begunkov
On 8/9/24 15:10, Mina Almasry wrote: On Thu, Aug 8, 2024 at 10:24 PM Jakub Kicinski wrote: On Thu, 8 Aug 2024 16:36:24 -0400 Mina Almasry wrote: How do you know that the driver: - supports net_iov at all (let's not make implicit assumptions based on presence of queue API); - supports

Re: [PATCH v2 0/2] Fix mmap memory boundary calculation

2024-08-09 Thread Jann Horn
On Fri, Aug 9, 2024 at 4:48 PM Jann Horn wrote: > On Tue, Aug 6, 2024 at 2:08 PM Joonas Lahtinen > wrote: > > Quoting Andi Shyti (2024-08-06 12:46:07) > > > Hi Greg, > > > > > > same question without the stable mailing list not to trigger the > > > automatic reply. > > > > > > > Andi Shyti (2): >

[PATCH DO NOT APPLY v3 7/7] driver core: do not unblock consumers any drivers found

2024-08-09 Thread Luca Ceresoli
Quick summary: I have investigated a problem for a long time, I have a pretty good understanding, I tried various fixes but none except this is working. The goal of this patch is to discuss the problem to converge to the best solution. - Symptoms --

[PATCH v3 6/7] misc: add ge-addon-connector driver

2024-08-09 Thread Luca Ceresoli
Add a driver to support the runtime hot-pluggable add-on connector on the GE SUNH device. This connector allows connecting and disconnecting an add-on to/from the main device to augment its features. Connection and disconnection can happen at runtime at any moment without notice. Different add-on

[PATCH v3 5/7] i2c: i2c-core-of: follow i2c-parent phandle to probe devices from added nodes

2024-08-09 Thread Luca Ceresoli
When device tree nodes are added, the I2C core tries to probe client devices based on the classic DT structure: i2c@abcd { some-client@42 { compatible = "xyz,blah"; ... }; }; However for hotplug connectors described via device tree overlays there is additional level of indirection,

[PATCH v3 1/7] dt-bindings: connector: add GE SUNH hotplug addon connector

2024-08-09 Thread Luca Ceresoli
Add bindings for the GE SUNH add-on connector. This is a physical, hot-pluggable connector that allows to attach and detach at runtime an add-on adding peripherals on non-discoverable busses. Signed-off-by: Luca Ceresoli --- Changed in v3: - change the layout to only add subnodes, not properti

[PATCH v3 4/7] drm/bridge: hotplug-bridge: add driver to support hot-pluggable DSI bridges

2024-08-09 Thread Luca Ceresoli
This driver implements the point of a DRM pipeline where a connector allows removal of all the following bridges up to the panel. The DRM subsystem currently allows hotplug of the monitor but not preceding components. However there are embedded devices where the "tail" of the DRM pipeline, includi

[PATCH v3 0/7] Add support for GE SUNH hot-pluggable connector

2024-08-09 Thread Luca Ceresoli
Hello, this series aims at supporting a Linux device with a connector to physically add and remove an add-on to/from the main device to augment its features at runtime, using device tree overlays. What's new in v3 (a lot!) = There are big changes compared to v2, in many a

[PATCH v3 3/7] drm/encoder: add drm_encoder_cleanup_from()

2024-08-09 Thread Luca Ceresoli
Supporting hardware whose final part of the DRM pipeline can be physically removed requires the ability to detach all bridges from a given point to the end of the pipeline. Introduce a variant of drm_encoder_cleanup() for this. Signed-off-by: Luca Ceresoli --- Changes in v3: none Changed in v

[PATCH v3 2/7] drm/bridge: add bridge notifier to be notified of bridge addition and removal

2024-08-09 Thread Luca Ceresoli
From: Paul Kocialkowski In preparation for allowing bridges to be added to and removed from a DRM card without destroying the whole card, add a DRM bridge notifier. Notified events are addition and removal to/from the global bridge list. Co-developed-by: Luca Ceresoli Signed-off-by: Luca Cereso

Re: [PATCH] accel: drm_accel: remove incorrect comments

2024-08-09 Thread Carl Vanderlip
On 7/30/2024 11:42 PM, bajing wrote: > accel_minor_replace is of type void, so remove the explanation of the return value in the comments. > > Signed-off-by: bajing Reviewed-by: Carl Vanderlip

Re: [PATCH V2 01/10] accel/amdxdna: Add a new driver for AMD AI Engine

2024-08-09 Thread Carl Vanderlip
On 8/5/2024 10:39 AM, Lizhi Hou wrote: > +static int aie2_init(struct amdxdna_dev *xdna) > +{ > +struct pci_dev *pdev = to_pci_dev(xdna->ddev.dev); > +struct amdxdna_dev_hdl *ndev; > +struct psp_config psp_conf; > +const struct firmware *fw; > +void __iomem * const *tbl; > +

Re: [PATCH V2 00/10] AMD XDNA driver

2024-08-09 Thread Jeffrey Hugo
On 8/5/2024 11:39 AM, Lizhi Hou wrote: This patchset introduces a new Linux Kernel Driver, amdxdna for AMD NPUs. The driver is based on Linux accel subsystem. NPU (Neural Processing Unit) is an AI inference accelerator integrated into AMD client CPUs. NPU enables efficient execution of Machine L

Re: [PATCH] MAINTAINERS: qaic: Drop Pranjal as reviewer

2024-08-09 Thread Carl Vanderlip
On 7/26/2024 8:53 AM, Jeffrey Hugo wrote: Pranjal's email address is bouncing. Signed-off-by: Jeffrey Hugo Reviewed-by: Carl Vanderlip

[PATCH] drm/v3d: Fix out-of-bounds read in `v3d_csd_job_run()`

2024-08-09 Thread Maíra Canal
When enabling UBSAN on Raspberry Pi 5, we get the following warning: [ 387.894977] UBSAN: array-index-out-of-bounds in drivers/gpu/drm/v3d/v3d_sched.c:320:3 [ 387.903868] index 7 is out of range for type '__u32 [7]' [ 387.909692] CPU: 0 PID: 1207 Comm: kworker/u16:2 Tainted: GWC

Re: [Linux-stm32] [PATCH RESEND v3 0/3] Update STM DSI PHY driver

2024-08-09 Thread Yannick FERTRE
Hi, we don't give enough attention to older SOCs like stm32f469. This is an error on our part. I think that to fix this point it would be necessary to define the clock hse as clock fix. I hope to be able to release a patch before the end of August Best regards Yannick Fertré Le 01/08/20

[PATCH v2] dt-bindings: display: st, stm32-ltdc: Document stm32mp25 compatible

2024-08-09 Thread Yannick Fertre
Add "st,stm32mp25-ltdc" compatible for SOC MP25. This new SOC introduce new clocks (bus, ref & lvds). Bus clock was separated from lcd clock. New sources are possible for lcd clock (lvds / ref). Signed-off-by: Yannick Fertre --- Changes in v2: Rework clock property. .../bindings/display/st,stm32

Re: [PATCH] fbdev: omapfb: panel-sony-acx565akm: Simplify show_cabc_available_modes()

2024-08-09 Thread Dan Carpenter
On Fri, Aug 09, 2024 at 05:09:28PM +0200, Christophe JAILLET wrote: > Le 09/08/2024 à 16:42, Dan Carpenter a écrit : > > On Thu, Aug 08, 2024 at 11:46:11AM +0200, Christophe JAILLET wrote: > > > Use sysfs_emit_at() instead of snprintf() + custom logic. > > > Using sysfs_emit_at() is much more simpl

Re: [PATCH] fbdev: omapfb: panel-sony-acx565akm: Simplify show_cabc_available_modes()

2024-08-09 Thread Christophe JAILLET
Le 09/08/2024 à 16:42, Dan Carpenter a écrit : On Thu, Aug 08, 2024 at 11:46:11AM +0200, Christophe JAILLET wrote: Use sysfs_emit_at() instead of snprintf() + custom logic. Using sysfs_emit_at() is much more simple. Also, sysfs_emit() is already used in this function, so using sysfs_emit_at() i

[PATCH] video/aperture: match the pci device when calling sysfb_disable()

2024-08-09 Thread Alex Deucher
In aperture_remove_conflicting_pci_devices(), match the pci device determine whether or not to call sysfb_disable(). This fixes cases where the pimary device is not VGA compatible which leads to the following problem: 1. A PCI device with a non-VGA class is the the boot display 2. That device is

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-09 Thread Raag Jadav
On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote: > > Add hwmon support for fan1_input attribute, which will expose fan speed > > in RPM. With this in place we can monitor fan speed using lm-sensors tool. > > > > $ sensor

Re: [PATCH v2 0/2] Fix mmap memory boundary calculation

2024-08-09 Thread Jann Horn
On Tue, Aug 6, 2024 at 2:08 PM Joonas Lahtinen wrote: > Quoting Andi Shyti (2024-08-06 12:46:07) > > Hi Greg, > > > > same question without the stable mailing list not to trigger the > > automatic reply. > > > > > Andi Shyti (2): > > > drm/i915/gem: Adjust vma offset for framebuffer mmap offset

Re: [PATCH] fbdev: omapfb: panel-sony-acx565akm: Simplify show_cabc_available_modes()

2024-08-09 Thread Dan Carpenter
On Fri, Aug 09, 2024 at 05:42:32PM +0300, Dan Carpenter wrote: > On Thu, Aug 08, 2024 at 11:46:11AM +0200, Christophe JAILLET wrote: > > Use sysfs_emit_at() instead of snprintf() + custom logic. > > Using sysfs_emit_at() is much more simple. > > > > Also, sysfs_emit() is already used in this funct

Re: [PATCH] fbdev: omapfb: panel-sony-acx565akm: Simplify show_cabc_available_modes()

2024-08-09 Thread Dan Carpenter
On Thu, Aug 08, 2024 at 11:46:11AM +0200, Christophe JAILLET wrote: > Use sysfs_emit_at() instead of snprintf() + custom logic. > Using sysfs_emit_at() is much more simple. > > Also, sysfs_emit() is already used in this function, so using > sysfs_emit_at() is more consistent. > > Also simplify th

Re: [PATCH v6 11/12] drm/ttm, drm/xe: Add a shrinker for xe bos

2024-08-09 Thread Thomas Hellström
On Thu, 2024-08-08 at 01:37 +, Matthew Brost wrote: > On Wed, Jul 03, 2024 at 05:38:12PM +0200, Thomas Hellström wrote: > > Rather than relying on the TTM watermark accounting add a shrinker > > for xe_bos in TT or system memory. > > > > Leverage the newly added TTM per-page shrinking and shme

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-09 Thread Mina Almasry
On Thu, Aug 8, 2024 at 10:24 PM Jakub Kicinski wrote: > > On Thu, 8 Aug 2024 16:36:24 -0400 Mina Almasry wrote: > > > How do you know that the driver: > > > - supports net_iov at all (let's not make implicit assumptions based > > >on presence of queue API); > > > - supports net_iov in curren

Re: [PATCH v6 12/12] drm/xe: Increase the XE_PL_TT watermark

2024-08-09 Thread Thomas Hellström
On Wed, 2024-08-07 at 23:44 +, Matthew Brost wrote: > On Wed, Jul 03, 2024 at 05:38:13PM +0200, Thomas Hellström wrote: > > The XE_PL_TT watermark was set to 50% of system memory. > > The idea behind that was unclear since the net effect is that > > TT memory will be evicted to TTM_PL_SYSTEM me

Re: [PATCH v6 10/12] drm/ttm: Use fault-injection to test error paths

2024-08-09 Thread Thomas Hellström
On Wed, 2024-08-07 at 23:43 +, Matthew Brost wrote: > On Wed, Jul 03, 2024 at 05:38:11PM +0200, Thomas Hellström wrote: > > Use fault-injection to test partial TTM swapout and interrupted > > swapin. > > Return -EINTR for swapin to test the callers ability to handle and > > restart the swapin,

Re: [PATCH] drm/ast: astdp: fix pre-op vs post-op bug

2024-08-09 Thread Jani Nikula
On Fri, 09 Aug 2024, Thomas Zimmermann wrote: > Hi, > > thanks a lot for the bugfix. > > Am 09.08.24 um 14:33 schrieb Dan Carpenter: >> The test for "Link training failed" expect the loop to exit with "i" >> set to zero but it exits when "i" is set to -1. Change this from a >> post-op to a pre-op

Re: [PATCH] drm/ast: astdp: fix pre-op vs post-op bug

2024-08-09 Thread Thomas Zimmermann
Hi, thanks a lot for the bugfix. Am 09.08.24 um 14:33 schrieb Dan Carpenter: The test for "Link training failed" expect the loop to exit with "i" set to zero but it exits when "i" is set to -1. Change this from a post-op to a pre-op so that it exits with "i" set to zero. This changes the numb

[PATCH] drm/ast: astdp: fix pre-op vs post-op bug

2024-08-09 Thread Dan Carpenter
The test for "Link training failed" expect the loop to exit with "i" set to zero but it exits when "i" is set to -1. Change this from a post-op to a pre-op so that it exits with "i" set to zero. This changes the number of iterations from 10 to 9 but probably that's okay. Fixes: 2281475168d2 ("dr

Re: [PATCH v6 12/12] drm/xe: Increase the XE_PL_TT watermark

2024-08-09 Thread Thomas Hellström
On Wed, 2024-08-07 at 23:13 +, Matthew Brost wrote: > On Mon, Aug 05, 2024 at 12:35:34PM -0600, Souza, Jose wrote: > > On Wed, 2024-07-03 at 17:38 +0200, Thomas Hellström wrote: > > > The XE_PL_TT watermark was set to 50% of system memory. > > > The idea behind that was unclear since the net ef

  1   2   >