Re: [PATCH v2 0/2] Fix mmap memory boundary calculation

2024-08-05 Thread Greg Kroah-Hartman
On Mon, Aug 05, 2024 at 11:05:22PM +0100, Andi Shyti wrote: > Hi Greg, > > > Andi Shyti (2): > > drm/i915/gem: Adjust vma offset for framebuffer mmap offset > > drm/i915/gem: Fix Virtual Memory mapping boundaries calculation > > I have forgotten to Cc the stable mailing list here. These two >

Re: [PATCH v4 1/6] dt-bindings: misc: qcom, fastrpc: increase the max number of iommus

2024-08-05 Thread Krzysztof Kozlowski
On 05/08/2024 19:08, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The fastrpc components on the SA8775P SoC can require up to 10 IOMMU > entries. Bump the maxItems. > > Signed-off-by: Bartosz Golaszewski Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

[PATCH 9/9] media: xilinx-tpg: use new of_graph functions

2024-08-05 Thread Kuninori Morimoto
Now we can use new port related functions for port parsing. Use it. Signed-off-by: Kuninori Morimoto --- drivers/media/platform/xilinx/xilinx-tpg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/xilinx/xilinx-tpg.c b/drivers/media/platform/xilinx/xi

[PATCH 8/9] fbdev: omapfb: use new of_graph functions

2024-08-05 Thread Kuninori Morimoto
Now we can use new port related functions for port parsing. Use it. Signed-off-by: Kuninori Morimoto --- drivers/video/fbdev/omap2/omapfb/dss/dpi.c| 3 +- drivers/video/fbdev/omap2/omapfb/dss/dss-of.c | 66 --- drivers/video/fbdev/omap2/omapfb/dss/dss.c| 9 +-- drivers/

[PATCH 7/9] gpu: drm: omapdrm: use new of_graph functions

2024-08-05 Thread Kuninori Morimoto
Now we can use new port related functions for port parsing. Use it. Signed-off-by: Kuninori Morimoto --- drivers/gpu/drm/omapdrm/dss/dpi.c | 3 ++- drivers/gpu/drm/omapdrm/dss/sdi.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dpi.c b/drive

[PATCH 6/9] ASoC: audio-graph-card2: use new of_graph functions

2024-08-05 Thread Kuninori Morimoto
Now we can use new port related functions for port parsing. Use it. Signed-off-by: Kuninori Morimoto --- sound/soc/generic/audio-graph-card2.c | 111 -- 1 file changed, 49 insertions(+), 62 deletions(-) diff --git a/sound/soc/generic/audio-graph-card2.c b/sound/soc/gene

[PATCH 5/9] ASoC: audio-graph-card: use new of_graph functions

2024-08-05 Thread Kuninori Morimoto
Now we can use new port related functions for port parsing. Use it. Signed-off-by: Kuninori Morimoto --- sound/soc/generic/audio-graph-card.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c index

[PATCH 4/9] ASoC: rcar_snd: use new of_graph functions

2024-08-05 Thread Kuninori Morimoto
Now we can use new port related functions for port parsing. Use it. Signed-off-by: Kuninori Morimoto --- sound/soc/sh/rcar/core.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c index 63b3c8bf0fde..eb146cf836eb

[PATCH 3/9] ASoC: test-component: use new of_graph functions

2024-08-05 Thread Kuninori Morimoto
Current test-component.c is using for_each_endpoint_of_node() for parsing, but it should use "port" base loop instead of "endpoint", because properties are "port" base, instead of "endpoint". Signed-off-by: Kuninori Morimoto --- sound/soc/generic/test-component.c | 2 +- 1 file changed, 1 insert

[PATCH 2/9] of: property: add of_graph_get_next_port_endpoint()

2024-08-05 Thread Kuninori Morimoto
We already have of_graph_get_next_endpoint(), but it is not intuitive to use. (X) node { (Y) ports { port@0 { endpoint { remote-endpoint = ...; };}; (A1)port@1 { endpoint { remote-endpoint = ...; }; (A2) endpoi

[PATCH 1/9] of: property: add of_graph_get_next_port()

2024-08-05 Thread Kuninori Morimoto
We have endpoint base functions - of_graph_get_next_device_endpoint() - of_graph_get_device_endpoint_count() - for_each_of_graph_device_endpoint() Here, for_each_of_graph_device_endpoint() loop finds each endpoints ports { port@0 { (1)

[PATCH 0/9] of: property: add of_graph_get_next_port/port_endpoint()

2024-08-05 Thread Kuninori Morimoto
Hi Rob, Saravana I have been posting to add new port base for loop function as below steps. [o] done [*] posting (A) [@] this patch set [o] tidyup of_graph_get_endpoint_count() [o] replace endpoint func - use endpoint_by_regs() [*] replace endpoint func - use for_each()

[PATCH v1] drm/xe/uapi: Bring back reset uevent

2024-08-05 Thread Raag Jadav
From: Lucas De Marchi Bring back uevent for gt reset failure with better uapi naming. With this in place we can receive failure event using udev. $ udevadm monitor --property --kernel monitor will print the received events for: KERNEL - the kernel uevent KERNEL[871.188570] change /devices/pc

Re: [PATCH v5 0/9] Improve the copy of task comm

2024-08-05 Thread Yafang Shao
On Tue, Aug 6, 2024 at 11:10 AM Linus Torvalds wrote: > > On Mon, 5 Aug 2024 at 20:01, Yafang Shao wrote: > > > > One concern about removing the BUILD_BUG_ON() is that if we extend > > TASK_COMM_LEN to a larger size, such as 24, the caller with a > > hardcoded 16-byte buffer may overflow. > > No,

[PATCH v2 2/2] drm/panel: jd9365da: Modify the init code of Melfas

2024-08-05 Thread Zhaoxiong Lv
Modify the Melfas panel init code to satisfy the gamma value of 2.2 Acked-by: Jessica Zhang Signed-off-by: Zhaoxiong Lv --- Changes between V2 and V1: - 1. No changed. v1: https://lore.kernel.org/all/20240725083245.12253-3-lvzhaoxi...@huaqin.corp-partner.google.com/ --- .../gpu/drm/panel/pane

[PATCH v2 1/2] drm/panel: jd9365da: Move the location of "exit sleep mode" and "set display on" commands

2024-08-05 Thread Zhaoxiong Lv
Move the "exit sleep mode" and "set display on" command from enable() to init() function. As mentioned in the patch: https://lore.kernel.org/all/20240624141926.5250-2-lvzhaoxi...@huaqin.corp-partner.google.com/ Our DSI host has different modes in prepare() and enable() functions. prepare() is in

[PATCH v2 0/2] Modify the method of sending "exit sleep

2024-08-05 Thread Zhaoxiong Lv
This "exit sleep mode" and "set display on" command needs to be sent in LP mode, so move "exit sleep mode" and "set display on" command to the init() function. Modify the Melfas panel init code to satisfy the gamma value of 2.2. Changes between V2 and V1: - PATCH 1/2: Modify the commit message

Re: [PATCH v5 0/9] Improve the copy of task comm

2024-08-05 Thread Linus Torvalds
On Mon, 5 Aug 2024 at 20:01, Yafang Shao wrote: > > One concern about removing the BUILD_BUG_ON() is that if we extend > TASK_COMM_LEN to a larger size, such as 24, the caller with a > hardcoded 16-byte buffer may overflow. No, not at all. Because get_task_comm() - and the replacements - would ne

Re: [PATCH v5 0/9] Improve the copy of task comm

2024-08-05 Thread Yafang Shao
On Tue, Aug 6, 2024 at 5:28 AM Linus Torvalds wrote: > > On Sun, 4 Aug 2024 at 00:56, Yafang Shao wrote: > > > > There is a BUILD_BUG_ON() inside get_task_comm(), so when you use > > get_task_comm(), it implies that the BUILD_BUG_ON() is necessary. > > Let's just remove that silly BUILD_BUG_ON().

[PATCH] drm/i915/dg2: Enable Wa_14019159160 for DG2

2024-08-05 Thread John . C . Harrison
From: John Harrison The context switch hold out workaround also applies to DG2. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc.c | 3 ++- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/dr

[PATCH v4 9/9] drm/tests: Add test for drm_framebuffer_free()

2024-08-05 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_framebuffer_free function. Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard --- v2: - Reorder kunit cases alphabetically. v3: - Replace the use of void pointer on drm_framebuffer_test_priv struct. - Remove the test with unregistered

[PATCH v4 8/9] drm/tests: Add test for drm_framebuffer_init()

2024-08-05 Thread Carlos Eduardo Gallo Filho
Add three KUnit test cases for the drm_framebuffer_init function: 1. Test if expected values are being set after drm_framebuffer_init() call. 2. Try to init a framebuffer without setting its format. 3. Try calling drm_framebuffer_init() with mismatch of the drm_device passed at the first argume

[PATCH v4 7/9] drm/tests: Add test for drm_framebuffer_lookup()

2024-08-05 Thread Carlos Eduardo Gallo Filho
Add two KUnit test cases for the drm_framebuffer_lookup function, one for the base case, that tests if the lookup finds the correct framebuffer object and another that tests the lookup for an inexistent framebuffer. Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard --- v2: - Re

[PATCH v4 5/9] drm/tests: Add test for drm_framebuffer_check_src_coords()

2024-08-05 Thread Carlos Eduardo Gallo Filho
Add a parametrized test for the drm_framebuffer_check_src_coords function. Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard --- v2: - Order kunit cases alphabetically. - Rename check_src_coords_case to drm_framebuffer_check_src_coords_case. - Remove unnecessary comments.

[PATCH v4 6/9] drm/tests: Add test for drm_framebuffer_cleanup()

2024-08-05 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_framebuffer_cleanup function. Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard --- v2: - Reorder kunit cases alphabetically. - Rely on drm_kunit_helper_alloc_device() for mock initialization. v3: - Init framebuffers using drm_frameb

[PATCH v4 4/9] drm/tests: Add test case for drm_internal_framebuffer_create()

2024-08-05 Thread Carlos Eduardo Gallo Filho
Introduce a test to cover the creation of framebuffer with modifier on a device that doesn't support it. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Reorder kunit cases alphabetically. v3: - Replace the use of void pointer on drm_framebuffer_test_priv struct. - Test return value of

[PATCH v4 3/9] drm/tests: Replace strcpy to strscpy on drm_test_framebuffer_create test

2024-08-05 Thread Carlos Eduardo Gallo Filho
Replace the use of strcpy to strscpy on the test_to_desc of the drm_test_framebuffer_create test for better security and reliability. Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[PATCH v4 2/9] drm/tests: Add parameters to the drm_test_framebuffer_create test

2024-08-05 Thread Carlos Eduardo Gallo Filho
Extend the existing test case to cover: 1. Invalid flag atribute in the struct drm_mode_fb_cmd2. 2. Pixel format which requires non-linear modifier with DRM_FORMAT_MOD_LINEAR set. 3. Buffer offset for inexistent plane Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard --- v2: -

[PATCH v4 1/9] drm/tests: Stop using deprecated dev_private member on drm_framebuffer tests

2024-08-05 Thread Carlos Eduardo Gallo Filho
The dev_private member of drm_device is deprecated and its use should be avoided. Stop using it by embedding the drm_device onto a mock struct. The new mock struct allows to share variables and even further mocks over the tests in a cleaner way than using dev_private void pointer. Also start usin

[PATCH v4 0/9] Increase coverage on drm_framebuffer.c

2024-08-05 Thread Carlos Eduardo Gallo Filho
This patchset includes new KUnit tests for 5 untested functions from drm_framebuffer.c and improvements to the existent one. The first patch replace the use of dev_private member from drm_device mock on the existent test by embedding it into an outer struct containing a generic pointer. The patch

[PATCH v4 2/2] drm/tiny: Add driver for Sharp Memory LCD

2024-08-05 Thread Alex Lanzano
Add support for the monochrome Sharp Memory LCDs. Co-developed-by: Mehdi Djait Signed-off-by: Mehdi Djait Signed-off-by: Alex Lanzano --- MAINTAINERS | 6 + drivers/gpu/drm/tiny/Kconfig| 20 + drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/

[PATCH v4 1/2] dt-bindings: display: Add Sharp Memory LCD bindings

2024-08-05 Thread Alex Lanzano
Add device tree bindings for the monochrome Sharp Memory LCD Co-developed-by: Mehdi Djait Signed-off-by: Mehdi Djait Signed-off-by: Alex Lanzano Reviewed-by: Krzysztof Kozlowski --- .../bindings/display/sharp,ls010b7dh04.yaml | 92 +++ 1 file changed, 92 insertions(+) creat

[PATCH v4 0/2] Add driver for Sharp Memory LCD

2024-08-05 Thread Alex Lanzano
This patch series add support for the monochrome Sharp Memory LCD panels. This series is based off of the work done by Mehdi Djait. References: https://lore.kernel.org/dri-devel/71a9dbf4609dbba46026a31f60261830163a0b99.1701267411.git.mehdi.dj...@bootlin.com/ https://www.sharpsde.com/fileadmin/prod

Re: [PATCH v2 0/2] Fix mmap memory boundary calculation

2024-08-05 Thread Andi Shyti
Hi Greg, > Andi Shyti (2): > drm/i915/gem: Adjust vma offset for framebuffer mmap offset > drm/i915/gem: Fix Virtual Memory mapping boundaries calculation I have forgotten to Cc the stable mailing list here. These two patches need to be merged together even if only the second patch has the "F

Re: [PATCH v5 0/9] Improve the copy of task comm

2024-08-05 Thread Linus Torvalds
On Sun, 4 Aug 2024 at 00:56, Yafang Shao wrote: > > There is a BUILD_BUG_ON() inside get_task_comm(), so when you use > get_task_comm(), it implies that the BUILD_BUG_ON() is necessary. Let's just remove that silly BUILD_BUG_ON(). I don't think it adds any value, and honestly, it really only make

[PATCH net-next v18 14/14] netdev: add dmabuf introspection

2024-08-05 Thread Mina Almasry
Add dmabuf information to page_pool stats: $ ./cli.py --spec ../netlink/specs/netdev.yaml --dump page-pool-get ... {'dmabuf': 10, 'id': 456, 'ifindex': 3, 'inflight': 1023, 'inflight-mem': 4190208}, {'dmabuf': 10, 'id': 455, 'ifindex': 3, 'inflight': 1023, 'inflight-mem': 4190208

[PATCH net-next v18 13/14] selftests: add ncdevmem, netcat for devmem TCP

2024-08-05 Thread Mina Almasry
ncdevmem is a devmem TCP netcat. It works similarly to netcat, but it sends and receives data using the devmem TCP APIs. It uses udmabuf as the dmabuf provider. It is compatible with a regular netcat running on a peer, or a ncdevmem running on a peer. In addition to normal netcat support, ncdevmem

[PATCH net-next v18 12/14] net: add devmem TCP documentation

2024-08-05 Thread Mina Almasry
Add documentation outlining the usage and details of devmem TCP. Signed-off-by: Mina Almasry Reviewed-by: Bagas Sanjaya Reviewed-by: Donald Hunter --- v16: - Add documentation on unbinding the NIC from dmabuf (Donald). - Add note that any dmabuf should work (Donald). v9: https://lore.kernel

[PATCH net-next v18 11/14] net: add SO_DEVMEM_DONTNEED setsockopt to release RX frags

2024-08-05 Thread Mina Almasry
Add an interface for the user to notify the kernel that it is done reading the devmem dmabuf frags returned as cmsg. The kernel will drop the reference on the frags to make them available for reuse. Signed-off-by: Willem de Bruijn Signed-off-by: Kaiyuan Zhang Signed-off-by: Mina Almasry Reviewe

[PATCH net-next v18 10/14] tcp: RX path for devmem TCP

2024-08-05 Thread Mina Almasry
In tcp_recvmsg_locked(), detect if the skb being received by the user is a devmem skb. In this case - if the user provided the MSG_SOCK_DEVMEM flag - pass it to tcp_recvmsg_devmem() for custom handling. tcp_recvmsg_devmem() copies any data in the skb header to the linear buffer, and returns a cmsg

[PATCH net-next v18 09/14] net: add support for skbs with unreadable frags

2024-08-05 Thread Mina Almasry
For device memory TCP, we expect the skb headers to be available in host memory for access, and we expect the skb frags to be in device memory and unaccessible to the host. We expect there to be no mixing and matching of device memory frags (unaccessible) with host memory frags (accessible) in the

[PATCH net-next v18 08/14] net: support non paged skb frags

2024-08-05 Thread Mina Almasry
Make skb_frag_page() fail in the case where the frag is not backed by a page, and fix its relevant callers to handle this case. Signed-off-by: Mina Almasry Reviewed-by: Eric Dumazet --- v10: - Fixed newly generated kdoc warnings found by patchwork. While we're at it, fix the Return section

[PATCH net-next v18 03/14] netdev: support binding dma-buf to netdevice

2024-08-05 Thread Mina Almasry
Add a netdev_dmabuf_binding struct which represents the dma-buf-to-netdevice binding. The netlink API will bind the dma-buf to rx queues on the netdevice. On the binding, the dma_buf_attach & dma_buf_map_attachment will occur. The entries in the sg_table from mapping will be inserted into a genpool

[PATCH net-next v18 05/14] page_pool: move dmaddr helpers to .c file

2024-08-05 Thread Mina Almasry
These helpers are used for setup and init of buffers, and their implementation need not be static inline in the header file. Moving the implementation to the .c file allows us to hide netmem implementation details in internal header files rather than the public file. Signed-off-by: Mina Almasry

[PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-05 Thread Mina Almasry
Implement a memory provider that allocates dmabuf devmem in the form of net_iov. The provider receives a reference to the struct netdev_dmabuf_binding via the pool->mp_priv pointer. The driver needs to set this pointer for the provider in the net_iov. The provider obtains a reference on the netde

[PATCH net-next v18 06/14] page_pool: devmem support

2024-08-05 Thread Mina Almasry
Convert netmem to be a union of struct page and struct netmem. Overload the LSB of struct netmem* to indicate that it's a net_iov, otherwise it's a page. Currently these entries in struct page are rented by the page_pool and used exclusively by the net stack: struct { unsigned long pp_mag

[PATCH net-next v18 04/14] netdev: netdevice devmem allocator

2024-08-05 Thread Mina Almasry
Implement netdev devmem allocator. The allocator takes a given struct netdev_dmabuf_binding as input and allocates net_iov from that binding. The allocation simply delegates to the binding's genpool for the allocation logic and wraps the returned memory region in a net_iov struct. Signed-off-by:

[PATCH net-next v18 02/14] net: netdev netlink api to bind dma-buf to a net device

2024-08-05 Thread Mina Almasry
API takes the dma-buf fd as input, and binds it to the netdevice. The user can specify the rx queues to bind the dma-buf to. Suggested-by: Stanislav Fomichev Signed-off-by: Mina Almasry Reviewed-by: Donald Hunter Reviewed-by: Jakub Kicinski --- v16: - Use subset-of: queue queue-id instead of

[PATCH net-next v18 01/14] netdev: add netdev_rx_queue_restart()

2024-08-05 Thread Mina Almasry
Add netdev_rx_queue_restart(), which resets an rx queue using the queue API recently merged[1]. The queue API was merged to enable the core net stack to reset individual rx queues to actuate changes in the rx queue's configuration. In later patches in this series, we will use netdev_rx_queue_resta

[PATCH net-next v18 00/14] Device Memory TCP

2024-08-05 Thread Mina Almasry
v18: https://patchwork.kernel.org/project/netdevbpf/list/?series=874848&state=* v17 got minor feedback: (a) to beef up the description on patch 1 and (b) to remove the leading underscores in the header definition. I applied (a). (b) seems to be against current conventions so I did not apply

Re: [PATCH] drm/i915: ARL requires a newer GSC firmware

2024-08-05 Thread Daniele Ceraolo Spurio
On 8/1/2024 8:10 PM, john.c.harri...@intel.com wrote: From: John Harrison ARL and MTL share a single GSC firmware blob. However, ARL requires a newer version of it. So add differentiate of the PCI ids for ARL from MTL and create ARL as a sub-platform of MTL. That way, all the existing worka

Re: [PATCH 1/2] drm/i915/gem: Adjust vma offset for framebuffer mmap offset

2024-08-05 Thread Rodrigo Vivi
On Fri, Aug 02, 2024 at 10:38:49AM +0200, Andi Shyti wrote: > When mapping a framebuffer object, the virtual memory area (VMA) > offset ('vm_pgoff') should be adjusted by the start of the > 'vma_node' associated with the object. This ensures that the VMA > offset is correctly aligned with the corre

Re: [PATCH] drm/radeon/r100: Handle unknown family in r100_cp_init_microcode()

2024-08-05 Thread Alex Deucher
Applied. Thanks! On Tue, Jul 30, 2024 at 12:05 PM Geert Uytterhoeven wrote: > > With -Werror: > > In function ‘r100_cp_init_microcode’, > inlined from ‘r100_cp_init’ at drivers/gpu/drm/radeon/r100.c:1136:7: > include/linux/printk.h:465:44: error: ‘%s’ directive argument is null

[PATCH v3] drm/msm/dp: fix the max supported bpp logic

2024-08-05 Thread Abhinav Kumar
Fix the dp_panel_get_supported_bpp() API to return the minimum supported bpp correctly for relevant cases and use this API to correct the behavior of DP driver which hard-codes the max supported bpp to 30. This is incorrect because the number of lanes and max data rate supported by the lanes need

Re: [PATCH] drm/amd: Use a constant format string for amdgpu_ucode_request

2024-08-05 Thread Alex Deucher
Applied. Thanks! On Fri, Jul 19, 2024 at 6:35 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > Multiple files in amdgpu call amdgpu_ucode_request() with a fw_name > variable that the compiler cannot check for being a valid format string, > as seen by enabling the (default-disabled) -Wformat-

RE: [PATCH 2/2] drm/i915: Attempt to get pages without eviction first

2024-08-05 Thread Cavitt, Jonathan
-Original Message- From: Intel-gfx On Behalf Of David Gow Sent: Sunday, August 4, 2024 2:19 AM To: Christian König ; Somalapuram Amaranath ; Thomas Hellström ; De Marchi, Lucas ; Andi Shyti ; Thomas Zimmermann Cc: David Gow ; Jani Nikula ; Joonas Lahtinen ; Vivi, Rodrigo ; Tvrtko Ur

RE: [PATCH 1/2] drm/i915: Allow evicting to use the requested placement

2024-08-05 Thread Cavitt, Jonathan
-Original Message- From: Intel-gfx On Behalf Of David Gow Sent: Sunday, August 4, 2024 2:19 AM To: Christian König ; Somalapuram Amaranath ; Thomas Hellström ; De Marchi, Lucas ; Andi Shyti ; Thomas Zimmermann Cc: David Gow ; Jani Nikula ; Joonas Lahtinen ; Vivi, Rodrigo ; Tvrtko Ur

Re: [PATCH 0/3] drm/amd: some trivial fixes

2024-08-05 Thread Alex Deucher
Applied the series. Thanks! Alex On Sun, Aug 4, 2024 at 10:14 AM wrote: > > From: Tobias Jakobi > > Nothing serious here, just some bits I noticed when reading code. > > Tobias Jakobi (3): > drm/amd: Make amd_ip_funcs static for SDMA v5.0 > drm/amd: Make amd_ip_funcs static for SDMA v5.2 >

Re: [PATCH 4/4] drm/msm/a5xx: workaround early ring-buffer emptiness check

2024-08-05 Thread Akhil P Oommen
On Thu, Jul 11, 2024 at 10:00:21AM +, Vladimir Lypak wrote: > There is another cause for soft lock-up of GPU in empty ring-buffer: > race between GPU executing last commands and CPU checking ring for > emptiness. On GPU side IRQ for retire is triggered by CACHE_FLUSH_TS > event and RPTR shadow

Re: [PATCH] drm/amdgpu/uvd4: fix mask and shift definitions

2024-08-05 Thread Alex Deucher
Applied. Thanks! On Wed, Jul 31, 2024 at 3:20 AM Remington Brasga wrote: > > A few define's are listed twice with different, incorrect values. > This fix sets them appropriately. > > Signed-off-by: Remington Brasga > --- > The second UVD_LMI_CTRL__RFU_MASK is incorrect, so it was removed. It sh

Re: [PATCH][next] drm/amd/display: remove extraneous ; after statements

2024-08-05 Thread Alex Deucher
Applied. Thanks! On Fri, Aug 2, 2024 at 8:00 AM Colin Ian King wrote: > > There are a several statements with two following semicolons, replace > these with just one semicolon. > > Signed-off-by: Colin Ian King > --- > .../drm/amd/display/dc/dml2/dml21/dml21_translation_helper.c | 2 +- > ...

Re: [PATCH v3] drm/amd/amdgpu: Properly tune the size of struct

2024-08-05 Thread Alex Deucher
Applied. Thanks! On Wed, Jul 31, 2024 at 6:25 AM WangYuli wrote: > > The struct assertion is failed because sparse cannot parse > `#pragma pack(push, 1)` and `#pragma pack(pop)` correctly. > GCC's output is still 1-byte-aligned. No harm to memory layout. > > The error can be filtered out by spar

Re: [PATCH v5 02/12] drm/msm/dpu: relax YUV requirements

2024-08-05 Thread Abhinav Kumar
On 7/31/2024 5:34 PM, Dmitry Baryshkov wrote: On Wed, 31 Jul 2024 at 22:36, Abhinav Kumar wrote: On 6/26/2024 2:45 PM, Dmitry Baryshkov wrote: YUV formats require only CSC to be enabled. Even decimated formats should not require scaler. Relax the requirement and don't check for the scale

RE: [PATCH v2] drm/i915: Explicitly cast divisor and use div_u64()

2024-08-05 Thread Cavitt, Jonathan
-Original Message- From: Intel-gfx On Behalf Of Thorsten Blum Sent: Friday, August 2, 2024 9:03 AM To: jani.nik...@linux.intel.com; joonas.lahti...@linux.intel.com; Vivi, Rodrigo ; tursu...@ursulin.net; airl...@gmail.com; dan...@ffwll.ch Cc: intel-...@lists.freedesktop.org; dri-devel@li

Re: [PATCH 3/4] drm/msm/a5xx: fix races in preemption evaluation stage

2024-08-05 Thread Akhil P Oommen
On Thu, Jul 11, 2024 at 10:00:20AM +, Vladimir Lypak wrote: > On A5XX GPUs when preemption is used it's invietable to enter a soft > lock-up state in which GPU is stuck at empty ring-buffer doing nothing. > This appears as full UI lockup and not detected as GPU hang (because > it's not). This h

Re: [PATCH v2 2/2] drm/msm/dpu: don't play tricks with debug macros

2024-08-05 Thread Abhinav Kumar
On 8/2/2024 12:47 PM, Dmitry Baryshkov wrote: DPU debugging macros need to be converted to a proper drm_debug_* macros, however this is a going an intrusive patch, not suitable for a fix. Wire DPU_DEBUG and DPU_DEBUG_DRIVER to always use DRM_DEBUG_DRIVER to make sure that DPU debugging message

Re: [PATCH v2 1/2] drm/msm/dpu1: don't choke on disabling the writeback connector

2024-08-05 Thread Abhinav Kumar
On 8/2/2024 12:47 PM, Dmitry Baryshkov wrote: During suspend/resume process all connectors are explicitly disabled and then reenabled. However resume fails because of the connector_status check: [ 1185.831970] [dpu error]connector not connected 3 It doesn't make sense to check for the Writeb

Re: [PATCH 2/4] drm/msm/a5xx: properly clear preemption records on resume

2024-08-05 Thread Akhil P Oommen
On Fri, Aug 02, 2024 at 01:41:32PM +, Vladimir Lypak wrote: > On Thu, Aug 01, 2024 at 06:46:10PM +0530, Akhil P Oommen wrote: > > On Thu, Jul 11, 2024 at 10:00:19AM +, Vladimir Lypak wrote: > > > Two fields of preempt_record which are used by CP aren't reset on > > > resume: "data" and "inf

RE: [PATCH 1/9] drm/amdgpu: Use backlight power constants

2024-08-05 Thread Deucher, Alexander
[Public] > -Original Message- > From: Thomas Zimmermann > Sent: Wednesday, July 31, 2024 8:17 AM > To: maarten.lankho...@linux.intel.com; mrip...@kernel.org; > airl...@gmail.com; dan...@ffwll.ch > Cc: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; intel- > g...@lists.free

Re: [bug report] drm/omap: gem: Replace struct_mutex usage with omap_obj private lock

2024-08-05 Thread Tomi Valkeinen
On 31/07/2024 15:26, Laurent Pinchart wrote: Hi Dan, (CC'ing Tomi) Thank for the report. It indeed seems that something is wrong. Tomi, could you handle this and send a fix ? On Tue, Jul 30, 2024 at 05:01:35PM -0500, Dan Carpenter wrote: Hello Laurent Pinchart, Commit 3cbd0c587b12 ("drm/

Re: [PATCH v6 12/12] drm/xe: Increase the XE_PL_TT watermark

2024-08-05 Thread Souza, Jose
On Wed, 2024-07-03 at 17:38 +0200, Thomas Hellström wrote: > The XE_PL_TT watermark was set to 50% of system memory. > The idea behind that was unclear since the net effect is that > TT memory will be evicted to TTM_PL_SYSTEM memory if that > watermark is exceeded, requiring PPGTT rebinds and dma >

6.11/regression/bisected - after commit 1b04dcca4fb1, launching some RenPy games causes computer hang

2024-08-05 Thread Mikhail Gavrilov
Hi, After commit 1b04dcca4fb1, launching some RenPy games causes computer hang. After the hang, even Alt + sysrq + REISUB can't reboot the computer! And no trace in the kernel log! For demonstration, I'm going to use the game "Find the Orange Narwhal" because it is free and has 100% reproducivity f

Re: [PATCH] drm/connector: Document destroy hook in drmm init functions

2024-08-05 Thread Daniel Vetter
On Sun, Aug 04, 2024 at 07:05:52PM +0200, José Expósito wrote: > Document that the drm_connector_funcs.destroy hook must be NULL in > drmm_connector_init() and drmm_connector_hdmi_init(). > > Signed-off-by: José Expósito Applied to drm-misc-next, thanks for your patch. -Sima > --- > drivers/gp

[PATCH AUTOSEL 5.4 1/2] drm: panel-orientation-quirks: Add quirk for OrangePi Neo

2024-08-05 Thread Sasha Levin
From: Philip Mueller [ Upstream commit d60c429610a14560085d98fa6f4cdb43040ca8f0 ] This adds a DMI orientation quirk for the OrangePi Neo Linux Gaming Handheld. Signed-off-by: Philip Mueller Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede Link: https://patchwork.freedesktop.org/patch

[PATCH AUTOSEL 5.10 1/4] drm: panel-orientation-quirks: Add quirk for OrangePi Neo

2024-08-05 Thread Sasha Levin
From: Philip Mueller [ Upstream commit d60c429610a14560085d98fa6f4cdb43040ca8f0 ] This adds a DMI orientation quirk for the OrangePi Neo Linux Gaming Handheld. Signed-off-by: Philip Mueller Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede Link: https://patchwork.freedesktop.org/patch

[PATCH AUTOSEL 5.15 1/4] drm: panel-orientation-quirks: Add quirk for OrangePi Neo

2024-08-05 Thread Sasha Levin
From: Philip Mueller [ Upstream commit d60c429610a14560085d98fa6f4cdb43040ca8f0 ] This adds a DMI orientation quirk for the OrangePi Neo Linux Gaming Handheld. Signed-off-by: Philip Mueller Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede Link: https://patchwork.freedesktop.org/patch

[PATCH AUTOSEL 6.1 1/5] drm: panel-orientation-quirks: Add quirk for OrangePi Neo

2024-08-05 Thread Sasha Levin
From: Philip Mueller [ Upstream commit d60c429610a14560085d98fa6f4cdb43040ca8f0 ] This adds a DMI orientation quirk for the OrangePi Neo Linux Gaming Handheld. Signed-off-by: Philip Mueller Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede Link: https://patchwork.freedesktop.org/patch

[PATCH AUTOSEL 6.6 02/15] drm: panel-orientation-quirks: Add quirk for OrangePi Neo

2024-08-05 Thread Sasha Levin
From: Philip Mueller [ Upstream commit d60c429610a14560085d98fa6f4cdb43040ca8f0 ] This adds a DMI orientation quirk for the OrangePi Neo Linux Gaming Handheld. Signed-off-by: Philip Mueller Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede Link: https://patchwork.freedesktop.org/patch

[PATCH AUTOSEL 6.6 01/15] drm/fb-helper: Don't schedule_work() to flush frame buffer during panic()

2024-08-05 Thread Sasha Levin
From: Qiuxu Zhuo [ Upstream commit 833cd3e9ad8360785b6c23c82dd3856df00732d9 ] Sometimes the system [1] hangs on x86 I/O machine checks. However, the expected behavior is to reboot the system, as the machine check handler ultimately triggers a panic(), initiating a reboot in the last step. The r

[PATCH AUTOSEL 6.10 02/16] drm: panel-orientation-quirks: Add quirk for OrangePi Neo

2024-08-05 Thread Sasha Levin
From: Philip Mueller [ Upstream commit d60c429610a14560085d98fa6f4cdb43040ca8f0 ] This adds a DMI orientation quirk for the OrangePi Neo Linux Gaming Handheld. Signed-off-by: Philip Mueller Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede Link: https://patchwork.freedesktop.org/patch

[PATCH AUTOSEL 6.10 01/16] drm/fb-helper: Don't schedule_work() to flush frame buffer during panic()

2024-08-05 Thread Sasha Levin
From: Qiuxu Zhuo [ Upstream commit 833cd3e9ad8360785b6c23c82dd3856df00732d9 ] Sometimes the system [1] hangs on x86 I/O machine checks. However, the expected behavior is to reboot the system, as the machine check handler ultimately triggers a panic(), initiating a reboot in the last step. The r

Re: [PATCH v2 0/5] Introduce DMA_HEAP_ALLOC_AND_READ_FILE heap flag

2024-08-05 Thread Daniel Vetter
On Thu, Aug 01, 2024 at 10:53:45AM +0800, Huan Yang wrote: > > 在 2024/8/1 4:46, Daniel Vetter 写道: > > On Tue, Jul 30, 2024 at 08:04:04PM +0800, Huan Yang wrote: > > > 在 2024/7/30 17:05, Huan Yang 写道: > > > > 在 2024/7/30 16:56, Daniel Vetter 写道: > > > > > [? daniel.vet...@ffwll.ch ?

Re: [PATCH v2] drm/msm/dp: fix the max supported bpp logic

2024-08-05 Thread Stephen Boyd
Quoting Abhinav Kumar (2024-07-30 10:55:40) > Fix the dp_panel_get_supported_bpp() API to return the minimum > supported bpp correctly for relevant cases and use this API > to correct the behavior of DP driver which hard-codes the max supported > bpp to 30. > > This is incorrect because the number

[PATCH V2 10/10] accel/amdxdna: Add firmware debug buffer support

2024-08-05 Thread Lizhi Hou
User application may allocate a debug buffer and attach it to an NPU context through the driver. Then the NPU firmware prints its debug information to this buffer for debugging. Co-developed-by: Min Ma Signed-off-by: Min Ma Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/aie2_ctx.c| 45

[PATCH V2 09/10] accel/amdxdna: Add query functions

2024-08-05 Thread Lizhi Hou
Add GET_INFO ioctl to retrieve hardware information, including AIE, clock, hardware context etc. Co-developed-by: Min Ma Signed-off-by: Min Ma Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/aie2_message.c | 65 drivers/accel/amdxdna/aie2_pci.c | 221 ++

[PATCH V2 08/10] accel/amdxdna: Add error handling

2024-08-05 Thread Lizhi Hou
When there is a hardware error, the NPU firmware notifies the host through a mailbox message. The message includes details of the error, such as the tile and column indexes where the error occurred. The driver starts a thread to handle the NPU error message. The thread stops the clients which are

[PATCH V2 05/10] accel/amdxdna: Add GEM buffer object management

2024-08-05 Thread Lizhi Hou
There different types of BOs are supported: - shmem A user application uses shmem BOs as input/output for its workload running on NPU. - device memory heap The fixed size buffer dedicated to the device. - device buffer The buffer object allocated from device memory heap. - command buffer The bu

[PATCH V2 07/10] accel/amdxdna: Add suspend and resume

2024-08-05 Thread Lizhi Hou
Implement PCI power management suspend and resume callbacks. Co-developed-by: Narendra Gutta Signed-off-by: Narendra Gutta Co-developed-by: Xiaoming Ren Signed-off-by: Xiaoming Ren Co-developed-by: Min Ma Signed-off-by: Min Ma Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/aie2_ctx.c

[PATCH V2 04/10] accel/amdxdna: Add hardware context

2024-08-05 Thread Lizhi Hou
The hardware can be shared among multiple user applications. The hardware resources are allocated/freed based on the request from user application via driver IOCTLs. DRM_IOCTL_AMDXDNA_CREATE_HWCTX Allocate tile columns and create a hardware context structure to track the usage and status of the re

[PATCH V2 06/10] accel/amdxdna: Add command execution

2024-08-05 Thread Lizhi Hou
Add interfaces for user application to submit command and wait for its completion. Co-developed-by: Min Ma Signed-off-by: Min Ma Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/aie2_ctx.c | 624 ++- drivers/accel/amdxdna/aie2_message.c | 341 +++ driv

[PATCH V2 03/10] accel/amdxdna: Add hardware resource solver

2024-08-05 Thread Lizhi Hou
The AI Engine consists of 2D array of tiles arranged as columns. Provides the basic column allocation and release functions for the tile columns. Co-developed-by: Min Ma Signed-off-by: Min Ma Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/Makefile | 1 + drivers/accel/amdxdna/aie2_p

[PATCH V2 02/10] accel/amdxdna: Support hardware mailbox

2024-08-05 Thread Lizhi Hou
The hardware mailboxes are used by the driver to submit requests to firmware and receive the completion notices from hardware. Initially, a management mailbox channel is up and running. The driver may request firmware to create/destroy more channels dynamically through management channel. Add dri

[PATCH V2 01/10] accel/amdxdna: Add a new driver for AMD AI Engine

2024-08-05 Thread Lizhi Hou
AMD AI Engine forms the core of AMD NPU and can be used for accelerating machine learning applications. Add the driver to support AI Engine integrated to AMD CPU. Only very basic functionalities are added. - module and PCI device initialization - firmware load - power up - low level hardwa

[PATCH V2 00/10] AMD XDNA driver

2024-08-05 Thread Lizhi Hou
This patchset introduces a new Linux Kernel Driver, amdxdna for AMD NPUs. The driver is based on Linux accel subsystem. NPU (Neural Processing Unit) is an AI inference accelerator integrated into AMD client CPUs. NPU enables efficient execution of Machine Learning applications like CNNs, LLMs, etc

Re: [PATCH 0/2] drm/bridge: lt9611uxc: require DRM_BRIDGE_ATTACH_NO_CONNECTOR

2024-08-05 Thread Sam Ravnborg
Hi Robert, On Tue, Jul 30, 2024 at 01:35:36PM +0200, Robert Foss wrote: > On Mon, Jul 1, 2024 at 8:20 PM Dmitry Baryshkov > wrote: > > > > There are no in-kernel DTs that use Lontium LT9611UXC bridge and still > > require creation of the drm_connector by the bridge on attachment. > > Drop support

Re: [PATCH v9 15/17] drm/vkms: Create KUnit tests for YUV conversions

2024-08-05 Thread Jeff Johnson
On 8/2/24 09:10, Louis Chauvet wrote: From: Arthur Grillo Create KUnit tests to test the conversion between YUV and RGB. Test each conversion and range combination with some common colors. The code used to compute the expected result can be found in comment. [Louis Chauvet: - fix minor format

[PATCH v4 6/6] arm64: dts: qcom: sa8775p-ride: enable remoteprocs

2024-08-05 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Enable all remoteproc nodes on the sa8775p-ride board and point to the appropriate firmware files. Reviewed-by: Dmitry Baryshkov Signed-off-by: Bartosz Golaszewski --- arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 25 + 1 file changed, 25 inser

[PATCH v4 4/6] misc: fastrpc: Add support for cdsp1 remoteproc

2024-08-05 Thread Bartosz Golaszewski
From: Ling Xu The fastrpc supports 4 remoteproc. There are some products which support cdsp1 remoteproc. Add changes to support cdsp1 remoteproc. Signed-off-by: Ling Xu [Bartosz: ported to mainline] Signed-off-by: Bartosz Golaszewski --- drivers/misc/fastrpc.c | 10 ++ 1 file changed,

[PATCH v4 2/6] dt-bindings: mailbox: qcom-ipcc: Add GPDSP0 and GPDSP1 clients

2024-08-05 Thread Bartosz Golaszewski
From: Tengfei Fan Add GPDSP0 and GPDSP1 clients for SA8775p platform. Signed-off-by: Tengfei Fan Acked-by: Krzysztof Kozlowski Signed-off-by: Bartosz Golaszewski --- include/dt-bindings/mailbox/qcom-ipcc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/dt-bindings/mailbox/qcom

[PATCH v4 5/6] arm64: dts: qcom: sa8775p: add ADSP, CDSP and GPDSP nodes

2024-08-05 Thread Bartosz Golaszewski
From: Tengfei Fan Add nodes for remoteprocs: ADSP, CDSP0, CDSP1, GPDSP0 and GPDSP1 for SA8775p SoCs. Reviewed-by: Dmitry Baryshkov Signed-off-by: Tengfei Fan [Ling: added the fastrcp nodes] Co-developed-by: Ling Xu Signed-off-by: Ling Xu [Bartosz: ported to mainline] Co-developed-by: Bartosz

  1   2   >